de6cec7f6805612313274b49b875f10e37ad9aba
[WebKit-https.git] / Tools / ChangeLog
1 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2
3         [WebEditingTester] Allow dropping HTML files on the app
4         https://bugs.webkit.org/show_bug.cgi?id=141834
5
6         Reviewed by Simon Fraser.
7
8         * WebEditingTester/AppDelegate.m:
9         (-[WebEditingAppDelegate openDocument:]):
10         (-[WebEditingAppDelegate application:openFile:]):
11         Implement application:openFile:, factoring file loading code out of openDocument.
12
13         * WebEditingTester/Info.plist:
14         Register as an editor for HTML files.
15
16         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
17         Enrica is not an organization.
18
19 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
20
21         [WebEditingTester] Expand "WK" to "WebKit" in a few places
22         https://bugs.webkit.org/show_bug.cgi?id=141833
23
24         Reviewed by Anders Carlsson.
25
26         * WebEditingTester/AppDelegate.h:
27         * WebEditingTester/AppDelegate.m:
28         (-[WebEditingAppDelegate newEditor:]):
29         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
30         (-[WebEditingAppDelegate validateMenuItem:]):
31         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
32         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
33         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
34         (-[WebEditingAppDelegate showOperations:]): Deleted.
35         * WebEditingTester/MainMenu.xib:
36         The WK abbreviation is unnaturally grating in menu items for some reason.
37
38 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
39
40         [WebEditingTester] Add a custom protocol for loading canned content
41         https://bugs.webkit.org/show_bug.cgi?id=141830
42
43         Reviewed by Enrica Casucci.
44
45         Add a canned:// protocol handler, which can be used to emulate behaviors
46         in WebKit client apps (like Mail) that use custom protocol handlers,
47         which can have important effects on editing (mostly, the URLs are only
48         valid inside of the client application, but not when copied/dragged out).
49
50         For now, we only support two canned files:
51
52             canned://dice is a PNG of dice (stolen from LayoutTests/)
53             canned://text is the string "canned text" served as text/html
54
55         In the future we could support things like very large (generated) files,
56         progressive loading, etc. to further simulate conditions in other apps.
57
58         * WebEditingTester/AppDelegate.m:
59         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
60         Register the protocol with CFNetwork, and the scheme with WebKit2.
61
62         * WebEditingTester/Canned Content/dice.png: Added.
63         * WebEditingTester/CannedContent.h: Added.
64         * WebEditingTester/CannedContent.m: Added.
65         (-[CannedContent initWithRequest:cachedResponse:client:]):
66         (+[CannedContent canonicalRequestForRequest:]):
67         (+[CannedContent canInitWithRequest:]):
68         We only want to handle canned:// URLs.
69
70         (-[CannedContent startLoading]):
71         For now, immediately load the two files we know about.
72         Otherwise, immediately fail the load.
73
74         (-[CannedContent stopLoading]):
75         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
76
77 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
78
79         [WebEditingTester] Implement an open panel
80         https://bugs.webkit.org/show_bug.cgi?id=141829
81
82         Reviewed by Simon Fraser.
83
84         * WebEditingTester/AppDelegate.m:
85         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
86         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
87         (-[WebEditingAppDelegate openDocument:]):
88         Add an open panel (with radio buttons to pick which WebKit to open with).
89         Loads the file as an HTML string.
90
91 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
92
93         [WebEditingTester] @properties, dot syntax, and remember the window position
94         https://bugs.webkit.org/show_bug.cgi?id=141843
95
96         Reviewed by Tim Horton.
97         
98         Modernize a bit with more dot syntax, use @property for the web views,
99         and give the main window an Autosave name so it remembers the widow position.
100
101         * WebEditingTester/WK1WebDocumentController.m:
102         (-[WK1WebDocumentController awakeFromNib]):
103         (-[WK1WebDocumentController loadHTMLString:]):
104         * WebEditingTester/WK2WebDocumentController.m:
105         (-[WK2WebDocumentController awakeFromNib]):
106         * WebEditingTester/WebDocument.xib:
107
108 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
109
110         [WebEditingTester] Hook up key equivalents for new window action
111         https://bugs.webkit.org/show_bug.cgi?id=141828
112
113         Reviewed by Enrica Casucci.
114
115         * WebEditingTester/AppDelegate.h:
116         * WebEditingTester/AppDelegate.m:
117         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
118         (-[WebEditingAppDelegate newEditor:]):
119         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
120         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
121         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
122         (defaultConfiguration): Deleted.
123         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
124         Move WKWebViewConfiguration setup into WK2WebDocumentController.
125         Remove unused application termination code.
126         Update new-window menu item key equivalents when launching and when
127         changing the use-WebKit2-by-default setting.
128         Make WebDocumentController subclasses all initialized the same way,
129         and use that to factor out alloc/init.
130         Rename loadContent to loadHTMLString for future use.
131
132         * WebEditingTester/MainMenu.xib:
133         Add default key equivalents.
134         Cmd-N will always make the default kind of window (controlled by the pref).
135         Cmd-Opt-N will always make the other kind.
136         The menu items are configured as alternates so they only show up if you
137         press alt (just like in MiniBrowser).
138
139         * WebEditingTester/WK1WebDocumentController.m:
140         (-[WK1WebDocumentController loadHTMLString:]):
141         (-[WK1WebDocumentController loadContent]): Deleted.
142         * WebEditingTester/WK2WebDocumentController.h:
143         * WebEditingTester/WK2WebDocumentController.m:
144         (defaultConfiguration):
145         (-[WK2WebDocumentController awakeFromNib]):
146         (-[WK2WebDocumentController loadHTMLString:]):
147         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
148         (-[WK2WebDocumentController dealloc]): Deleted.
149         * WebEditingTester/WebDocumentController.h:
150         * WebEditingTester/WebDocumentController.m:
151         (-[WebDocumentController init]):
152         (-[WebDocumentController initWithWindow:]):
153         (+[WebDocumentController defaultEditingSource]):
154         (-[WebDocumentController loadHTMLString:]):
155         (-[WebDocumentController windowDidLoad]): Deleted.
156         (-[WebDocumentController defaultEditingSource]): Deleted.
157         (-[WebDocumentController applicationTerminating]): Deleted.
158         (-[WebDocumentController loadContent]): Deleted.
159
160 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
161
162         [WebEditingTester] ARC-ify WebEditingTester
163         https://bugs.webkit.org/show_bug.cgi?id=141827
164
165         Reviewed by Sam Weinig.
166
167         * WebEditingTester/AppDelegate.m:
168         (-[WebEditingAppDelegate showOperations:]):
169         * WebEditingTester/EditingOperations.m:
170         (editingOperations):
171         * WebEditingTester/WK1WebDocumentController.m:
172         (-[WK1WebDocumentController dealloc]): Deleted.
173         * WebEditingTester/WK2WebDocumentController.m:
174         (-[WK2WebDocumentController dealloc]): Deleted.
175         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
176         Turn on ARC and remove a few retain/release/autorelease calls.
177         We don't need to implement dealloc in either document controller
178         because WebView and WKWebView's UIDelegate property does not hold a
179         strong reference.
180
181 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
182
183         [WebEditingTester] Factor out list of editing operations
184         https://bugs.webkit.org/show_bug.cgi?id=141826
185
186         Reviewed by Sam Weinig.
187
188         * WebEditingTester/AppDelegate.m:
189         (-[WebEditingAppDelegate showOperations:]):
190         * WebEditingTester/EditingOperations.h: Added.
191         * WebEditingTester/EditingOperations.m: Added.
192         (editingOperations):
193         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
194         Move EditingOperations array to its own file, and make it an NSArray
195         instead of a C array. Adjust accordingly in showOperations:.
196
197 2015-02-20  Michael Saboff  <msaboff@apple.com>
198
199         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
200         https://bugs.webkit.org/show_bug.cgi?id=141676
201
202         Reviewed by Filip Pizlo.
203
204         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
205         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
206         large string expression that we want to eval.
207
208         * Scripts/run-jsc-stress-tests:
209
210 2015-02-19  Daniel Bates  <dabates@apple.com>
211
212         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
213         https://bugs.webkit.org/show_bug.cgi?id=141815
214         <rdar://problem/19893933>
215
216         Reviewed by Simon Fraser.
217
218         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
219         was booted by iOS Simulator in a previous run of run-webkit-test.
220
221         * Scripts/webkitpy/port/ios.py:
222         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
223         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
224         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
225
226 2015-02-19  David Kilzer  <ddkilzer@apple.com>
227
228         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
229         <http://webkit.org/b/141799>
230
231         Reviewed by Alex Christensen.
232
233         * Scripts/webkitpy/style/checkers/cpp.py:
234         (_IncludeState.check_next_include_order): Don't emit a warning
235         if the primary header exists and the source file name ends with
236         "SoftLink.cpp".  Add 'filename' argument to method.
237         (check_include_line): Pass in 'filename'.
238
239         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
240         (OrderOfIncludesTest.test_check_next_include_order__no_config):
241         (OrderOfIncludesTest.test_check_next_include_order__no_self):
242         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
243         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
244         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
245         - Add test filename arguments for calls to
246           check_next_include_order().
247         (OrderOfIncludesTest.test_primary_header): Add test for a file
248         name ending in "SoftLink.cpp".
249
250 2015-02-18  Enrica Casucci  <enrica@apple.com>
251
252         Add new tool to test editable Webviews.
253         https://bugs.webkit.org/show_bug.cgi?id=141772
254
255         Reviewed by Tim Horton.
256
257         Adding WebEditingTester, a Cocoa application to
258         test WK1 and Wk2 views in editable mode.
259
260         * WebEditingTester: Added.
261         * WebEditingTester/AppDelegate.h: Added.
262         * WebEditingTester/AppDelegate.m: Added.
263         (-[WebEditingAppDelegate init]):
264         (defaultConfiguration):
265         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
266         (-[WebEditingAppDelegate applicationWillTerminate:]):
267         (-[WebEditingAppDelegate newEditor:]):
268         (-[WebEditingAppDelegate showOperations:]):
269         (-[WebEditingAppDelegate useWebKit2ByDefault]):
270         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
271         (-[WebEditingAppDelegate validateMenuItem:]):
272         * WebEditingTester/Info.plist: Added.
273         * WebEditingTester/MainMenu.xib: Added.
274         * WebEditingTester/WK1WebDocumentController.h: Added.
275         * WebEditingTester/WK1WebDocumentController.m: Added.
276         (-[WK1WebDocumentController awakeFromNib]):
277         (-[WK1WebDocumentController loadContent]):
278         (-[WK1WebDocumentController dealloc]):
279         (-[WK1WebDocumentController pasteAsMarkup:]):
280         * WebEditingTester/WK2WebDocumentController.h: Added.
281         * WebEditingTester/WK2WebDocumentController.m: Added.
282         (-[WK2WebDocumentController initWithConfiguration:]):
283         (-[WK2WebDocumentController pasteAsMarkup:]):
284         (-[WK2WebDocumentController awakeFromNib]):
285         (-[WK2WebDocumentController dealloc]):
286         (-[WK2WebDocumentController loadContent]):
287         * WebEditingTester/WebDocument.xib: Added.
288         * WebEditingTester/WebDocumentController.h: Added.
289         * WebEditingTester/WebDocumentController.m: Added.
290         (-[WebDocumentController initWithWindow:]):
291         (-[WebDocumentController windowDidLoad]):
292         (-[WebDocumentController defaultEditingSource]):
293         (-[WebDocumentController applicationTerminating]):
294         (-[WebDocumentController loadContent]):
295         * WebEditingTester/WebEditingTester.xcodeproj: Added.
296         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
297         * WebEditingTester/main.m: Added.
298         (main):
299
300 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
301
302         Run JSC tests on ARM EFL bots
303         https://bugs.webkit.org/show_bug.cgi?id=141165
304
305         Reviewed by Alexey Proskuryakov.
306
307         * BuildSlaveSupport/build.webkit.org-config/config.json:
308         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
309         (RunJavaScriptCoreTests.countFailures):
310         (RunRemoteJavaScriptCoreTests):
311         (RunRemoteJavaScriptCoreTests.start):
312         (BuildAndRemoteJSCTestsFactory):
313         (BuildAndRemoteJSCTestsFactory.__init__):
314
315 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
316
317         Streamline unexported function build fixes
318         https://bugs.webkit.org/show_bug.cgi?id=141761
319
320         Reviewed by Alex Christensen.
321
322         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
323         We don't need to ignore symbols that are not exported due to the .unexp file.
324
325 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
326
327         Remove more references to WebCore.exp.in
328         https://bugs.webkit.org/show_bug.cgi?id=141747
329
330         Reviewed by Alexey Proskuryakov.
331
332         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
333         (ShouldBuildTest):
334
335 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
336
337         Windows test results should not fall back to mac-mountainlion after r180176
338         https://bugs.webkit.org/show_bug.cgi?id=141719
339
340         Reviewed by Brent Fulgham.
341
342         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
343         (_should_file_trigger_build):
344         * Scripts/webkitpy/port/win.py:
345         (WinPort.default_baseline_search_path):
346         * Scripts/webkitpy/port/win_unittest.py:
347         (WinPortTest.test_baseline_search_path):
348
349 2015-02-17  Daniel Bates  <dabates@apple.com>
350
351         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
352         https://bugs.webkit.org/show_bug.cgi?id=141718
353
354         Reviewed by Alex Christensen.
355
356         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
357
358         * Scripts/webkitpy/port/ios.py:
359         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
360         Log a error and return False if we are unable to boot the simulator device so that the caller can take
361         appropriate action, say exit(3) before running any layout tests.
362         * Scripts/webkitpy/xcode/simulator.py:
363         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
364         with the specified UDID.
365         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
366         with the specified UDID can successfully boot and shut down. We make at most two attempts to
367         boot and shut down the device, erasing the device between tries so as to restore the device
368         to a known good state.
369
370 2015-02-17  Daniel Bates  <dabates@apple.com>
371
372         run_webkit_tests.py should not know about iOS Simulator details
373         https://bugs.webkit.org/show_bug.cgi?id=141711
374
375         Reviewed by Alex Christensen.
376
377         Run_webkit_tests.py should only parse the iOS-specific command
378         line options --runtime and --device-type. Let the port-specific
379         logic in ios.py validate the parsed options and instantiate
380         internal data structures.
381
382         Currently run_webkit_tests.py parses the iOS-specific command
383         line options --runtime and --device-type, validates them, and
384         instantiates internal data structures from the parsed strings.
385         Instead the validation logic and instantiation of internal
386         data structures should be handled by the iOS port object.
387
388         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
389         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
390         and instantiate internal data structures for them.
391         * Scripts/webkitpy/port/driver.py:
392         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
393         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
394         respectively.
395         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
396         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
397         object from --runtime, if specified. Otherwise, instantiates a Runtime
398         object for the latest installed iphonesimulator SDK version.
399         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
400         object from --device-type, if specified. Otherwise, instantiates
401         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
402         machine, respectively.
403         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
404         runtime is available to use.
405         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
406         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
407         * Scripts/webkitpy/xcode/simulator.py:
408         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
409         with a runtime identifier for the specified iOS version.
410
411 2015-02-17  Dana Burkart  <dburkart@apple.com>
412
413         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
414         https://bugs.webkit.org/show_bug.cgi?id=141672
415
416         Reviewed by David Kilzer.
417
418         * asan/webkit-asan-ignore.txt:
419
420 2015-02-17  Alex Christensen  <achristensen@webkit.org>
421
422         Remove WebCore.exp.in and clean up.
423         https://bugs.webkit.org/show_bug.cgi?id=141491
424
425         Reviewed by Andreas Kling.
426
427         * Scripts/sort-export-file: Removed.
428         * Scripts/webkitpy/style/checker.py:
429         (_all_categories):
430         (FileType):
431         (CheckerDispatcher._file_type):
432         (CheckerDispatcher._create_checker):
433         Don't check if the export files are sorted.
434         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
435         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
436
437 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
438
439         Unreviewed. Fix GTK+ make distcheck.
440
441         Do not exclude bmalloc directory from the tarball.
442
443         * gtk/manifest.txt.in:
444
445 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
446
447         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
448
449         I forgot to add the return of a bool function.
450
451         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
452         (WebKitDOMNodeTest::testDOMCache):
453
454 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
455
456         [GTK] GObject DOM bindings object are cached forever
457         https://bugs.webkit.org/show_bug.cgi?id=141558
458
459         Reviewed by Sergio Villar Senin.
460
461         Add checks for all DOM objects to ensure they are not leaked. Also
462         add a dedicated test for the DOM Object Cache.
463
464         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
465         (WebKitDOMNodeFilterTest::testTreeWalker):
466         (WebKitDOMNodeFilterTest::testNodeIterator):
467         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
468         (WebKitDOMNodeTest::testHierarchyNavigation):
469         (WebKitDOMNodeTest::testInsertion):
470         (WebKitDOMNodeTest::testTagNames):
471         (WebKitDOMNodeTest::testDOMCache):
472         (registerTests):
473         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
474         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
475         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
476         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
477         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
478         (testWebKitDOMObjectCache):
479         (beforeAll):
480         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
481         (documentLoadedCallback):
482
483 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
484
485         [GTK] WebKitFrame objects are never released
486         https://bugs.webkit.org/show_bug.cgi?id=141641
487
488         Reviewed by Martin Robinson.
489
490         Add a way to check GObjects leaks for WebProcess tests and check
491         WebKitFrame objects are not leaked.
492
493         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
494         (WebKitFrameTest::testMainFrame):
495         (WebKitFrameTest::testURI):
496         (WebKitFrameTest::testJavaScriptContext):
497         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
498         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
499         (runTest):
500         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
501
502 2015-02-16  Tim Horton  <timothy_horton@apple.com>
503
504         Fix the MiniBrowser build with newer clang
505
506         * MiniBrowser/mac/SettingsController.m:
507         (-[SettingsController _toggleBooleanDefault:]):
508         * MiniBrowser/mac/WK1BrowserWindowController.m:
509         (-[WK1BrowserWindowController windowWillClose:]):
510         * MiniBrowser/mac/WK2BrowserWindowController.m:
511         (-[WK2BrowserWindowController windowWillClose:]):
512         NSApp is id and clang gets confused about which -delegate we're talking about.
513
514 2015-02-16  Antti Koivisto  <antti@apple.com>
515
516         Develop/Disable Caches does not properly disable disk cache
517         https://bugs.webkit.org/show_bug.cgi?id=141636
518
519         Reviewed by Anders Carlsson.
520
521         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
522         the network process too.
523
524         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
525
526         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
527         (WTR::InjectedBundle::beginTesting):
528         (WTR::InjectedBundle::setCacheModel):
529         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
530         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
531
532             Forward to TestController.
533
534         (WTR::TestRunner::setCacheModel):
535         * WebKitTestRunner/TestInvocation.cpp:
536         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
537
538 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
539
540         Unreviewed. Add myself as a committer.
541
542         * Scripts/webkitpy/common/config/contributors.json:
543
544 2015-02-15  David Kilzer  <ddkilzer@apple.com>
545
546         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
547         <http://webkit.org/b/141607>
548
549         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
550         externals in Source/WebCore/Configurations/WebCore.unexp when
551         building with Xcode 5.x.
552         (readXcode5SymbolsToIgnore): Add.
553
554 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
555
556         [EFL] fix Evas GL engine error.
557         https://bugs.webkit.org/show_bug.cgi?id=141621
558
559         Reviewed by Gyuyoung Kim.
560
561         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
562
563         * MiniBrowser/efl/main.c:
564         (elm_main):
565
566 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
567
568         [buildbot] Enable run-api-tests on release Mac bots
569         https://bugs.webkit.org/show_bug.cgi?id=141518
570
571         Reviewed by Darin Adler.
572
573         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
574         (RunUnitTests):
575         (BuildFactory.__init__):
576         (TestFactory.__init__):
577         (BuildAndTestFactory.__init__):
578         (RunUnitTests.start): Deleted.
579         (unitTestsSupported): Deleted.
580
581 2015-02-13  Anders Carlsson  <andersca@apple.com>
582
583         Add a move constructor and move assignment operator to Deque
584         https://bugs.webkit.org/show_bug.cgi?id=141571
585
586         Reviewed by Andreas Kling.
587
588         * TestWebKitAPI/Tests/WTF/Deque.cpp:
589         (TestWebKitAPI::TEST):
590
591 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
592
593         run-jsc-stress-tests --remote should skip profiler tests
594         https://bugs.webkit.org/show_bug.cgi?id=141470
595
596         Reviewed by Filip Pizlo.
597
598         * Scripts/run-jsc-stress-tests:
599
600 2015-02-13  Anders Carlsson  <andersca@apple.com>
601
602         Add an initializer list constructor to Deque
603         https://bugs.webkit.org/show_bug.cgi?id=141565
604
605         Reviewed by Andreas Kling.
606
607         * TestWebKitAPI/Tests/WTF/Deque.cpp:
608         (TestWebKitAPI::TEST):
609
610 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
611
612         [buildbot] Remove buildJSCTool cruft from master.cfg
613         https://bugs.webkit.org/show_bug.cgi?id=141513
614
615         Reviewed by Alexey Proskuryakov.
616
617         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
618         (RunJavaScriptCoreTests):
619         (RunJavaScriptCoreTests.start):
620         (RunWebKitTests):
621         (RunWebKitTests.start):
622         (TestFactory.__init__):
623         (TestLeaksFactory.__init__):
624         (RunJavaScriptCoreTests.__init__): Deleted.
625         (RunWebKitTests.__init__): Deleted.
626
627 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
628
629         Unreviewed, remove empty directories.
630
631         * DumpRenderTree/gtk: Removed.
632         * DumpRenderTree/gtk/fonts: Removed.
633         * DumpRenderTree/unix: Removed.
634         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
635         * GtkLauncher: Removed.
636         * TestWebKitAPI/Tests/WebKitGtk: Removed.
637         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
638         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
639         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
640
641 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
642
643         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
644         https://bugs.webkit.org/show_bug.cgi?id=141519
645
646         Reviewed by Alexey Proskuryakov.
647
648         * Scripts/build-webkittestrunner:
649
650 2015-02-12  Alex Christensen  <achristensen@webkit.org>
651
652         Removed empty directory.
653
654         * WinCELauncher: Removed.
655
656 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
657
658         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
659         https://bugs.webkit.org/show_bug.cgi?id=141202
660
661         Reviewed by Darin Adler.
662
663         * Scripts/run-jsc-stress-tests:
664
665 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
666
667         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
668         https://bugs.webkit.org/show_bug.cgi?id=141517
669
670         Reviewed by Anders Carlsson.
671
672         We do not need to locate or use the DLL's that came with Safari, so stop
673         failing when we cannot find them. Also remove some old Qt cruft from this
674         script.
675
676         * BuildSlaveSupport/built-product-archive:
677         (archiveBuiltProduct): 
678         (extractBuiltProduct):
679
680 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
681
682         [Win] [64-bit] Work around MSVC2013 Runtime Bug
683         https://bugs.webkit.org/show_bug.cgi?id=141498
684         <rdar://problem/19803642>
685
686         Reviewed by Anders Carlsson.
687
688         Disable FMA3 instruction use in the MSVC math library to
689         work around a VS2013 runtime crash. We can remove this
690         workaround when we switch to VS2015.
691
692         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
693         disable FMA3 support.
694         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
695         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
696         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
697         * Scripts/webkitperl/httpd.pm: Ditto.
698         * TestWebKitAPI/win/main.cpp: Ditto.
699         * WinLauncher/Common.cpp: Ditto.
700         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
701
702 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
703
704         run-jsc-stress-tests should accept remote host config from JSON file
705         https://bugs.webkit.org/show_bug.cgi?id=141509
706
707         Reviewed by Michael Saboff.
708
709         * Scripts/run-javascriptcore-tests:
710         (runJSCStressTests):
711         * Scripts/run-jsc-stress-tests:
712
713 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
714
715         [GTK] Add API to allow overriding the default color chooser implementation
716         https://bugs.webkit.org/show_bug.cgi?id=98935
717
718         Reviewed by Gustavo Noronha Silva.
719
720         Add a color chooser implementation for MiniBrowser using
721         GtkPopover when the GTK+ version is recent enough.
722         And a test case to check the new color chooser API.
723
724         * MiniBrowser/gtk/BrowserWindow.c:
725         (colorChooserRGBAChanged):
726         (popoverColorClosed):
727         (colorChooserRequestFinished):
728         (runColorChooserCallback):
729         (browserWindowConstructed):
730         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
731         (testWebViewColorChooserRequest):
732         (beforeAll):
733
734 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
735
736         Make run-jsc-stress-tests --remote work with make-based runner
737         https://bugs.webkit.org/show_bug.cgi?id=141079
738
739         Reviewed by Darin Adler.
740
741         * Scripts/run-javascriptcore-tests:
742         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
743         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
744         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
745         to avoid code duplication.
746
747 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
748
749         run-jsc-stress tests should detect the number of processors on the remote machine too
750         https://bugs.webkit.org/show_bug.cgi?id=141196
751
752         Reviewed by Darin Adler.
753
754         * Scripts/run-javascriptcore-tests:
755         (runJSCStressTests): Pass through the --child-processes argument.
756         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
757         to detect the number of local and remote processors with the same algorithm.
758         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
759         same as $numProcessors.
760
761 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
762
763         run-jsc-stress-tests should pass JSC_timeout to remote hosts
764         https://bugs.webkit.org/show_bug.cgi?id=141164
765
766         Reviewed by Darin Adler.
767
768         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
769
770         * Scripts/run-jsc-stress-tests:
771
772 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
773
774         [GTK] Add default color chooser implementation using GtkColorChooserDialog
775         https://bugs.webkit.org/show_bug.cgi?id=141392
776
777         Reviewed by Gustavo Noronha Silva.
778
779         Enable INPUT_TYPE_COLOR by default for GTK+ port.
780
781         * Scripts/webkitperl/FeatureList.pm:
782
783 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
784
785         run-jsc-stress-tests shell test runner should run tests in fixed order
786         https://bugs.webkit.org/show_bug.cgi?id=141383
787
788         Reviewed by Darin Adler.
789
790         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
791
792 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
793
794         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
795         https://bugs.webkit.org/show_bug.cgi?id=140485
796
797         Reviewed by Anders Carlsson.
798
799         Implement takeFocus() as a way to set focus through accessibility wrappers.
800
801         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
802         (AccessibilityUIElement::takeFocus):
803         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
804         (WTR::AccessibilityUIElement::takeFocus):
805
806 2015-02-08  Darin Adler  <darin@apple.com>
807
808         Remove the SVG instance tree
809         https://bugs.webkit.org/show_bug.cgi?id=140602
810
811         Reviewed by Dean Jackson.
812
813         * Scripts/check-for-global-initializers: Removed special case for
814         SVGElementInstance.o.
815
816 2015-02-07  David Kilzer  <ddkilzer@apple.com>
817
818         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
819         <http://webkit.org/b/141365>
820
821         Reviewed by Daniel Bates.
822
823         * Scripts/webkitpy/xcode/simulator.py:
824         (Simulator): Add unavailable_version_re precompiled regex.
825         (Simulator._parse_devices): Check for unavailable versions and
826         ignore them if found when parsing the output of
827         `xcrun simctl list`.
828         * Scripts/webkitpy/xcode/simulator_unittest.py:
829         (test_unavailable_devices): Add test with output from
830         `xcrun simctl list` with unavailable runtimes that fails before
831         the fix.
832
833 2015-02-07  Chris Dumez  <cdumez@apple.com>
834
835         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
836         https://bugs.webkit.org/show_bug.cgi?id=141321
837
838         Reviewed by Darin Adler.
839
840         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
841
842 2015-02-07  David Kilzer  <ddkilzer@apple.com>
843
844         [iOS] Make Simulator class testable
845         <http://webkit.org/b/141358>
846
847         Rubber-stamped by Darin Adler.
848
849         * Scripts/webkitpy/common/system/platforminfo.py:
850         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
851         command to here from Simulator.refresh() in xcode/simulator.py
852         so that the output of the command can be mocked.
853
854         * Scripts/webkitpy/common/system/platforminfo_mock.py:
855         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
856         to None.
857         (MockPlatformInfo.xcode_simctl_list): Add method that returns
858         self.expected_xcode_simctl_list expectation.
859
860         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
861         and license header.
862         (Simulator.__init__): Add optional 'host' parameter to make it
863         possible to pass in a mock object for testing.  Set self._host
864         to 'host' parameter or create Host() object.
865         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
866         method.
867
868         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
869         for current code.
870         (SimulatorTest):
871         (SimulatorTest.setUp):
872         (SimulatorTest._set_expected_xcrun_simctl_list):
873         (SimulatorTest.test_simulator_device_types):
874         (test_invalid_device_types_header):
875         (test_invalid_runtimes_header):
876         (test_invalid_devices_header):
877
878 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
879
880         run-jsc-stress-tests --remote should use the default ssh port
881         https://bugs.webkit.org/show_bug.cgi?id=141287
882
883         Reviewed by Darin Adler.
884
885         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
886
887 2015-02-06  Dana Burkart  <dburkart@apple.com>
888
889         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
890         https://bugs.webkit.org/show_bug.cgi?id=141349
891
892         Reviewed by Alexey Proskuryakov.
893
894         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
895         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
896         (BuildbotTesterQueueView.prototype.update):
897
898 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
899
900         Report network process crashes during layout tests
901         https://bugs.webkit.org/show_bug.cgi?id=139646
902
903         Reviewed by Anders Carlsson.
904
905         * WebKitTestRunner/TestController.cpp:
906         (WTR::TestController::initialize):
907         (WTR::TestController::networkProcessName):
908         (WTR::TestController::networkProcessDidCrash):
909         * WebKitTestRunner/TestController.h:
910
911 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
912
913         run-jsc-stress-tests --remote should create remote directory before copying the bundle
914         https://bugs.webkit.org/show_bug.cgi?id=141329
915
916         Reviewed by Michael Saboff.
917
918         * Scripts/run-jsc-stress-tests:
919
920 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
921
922         [GTK] Remove WebKitWebView::close-notification signal
923         https://bugs.webkit.org/show_bug.cgi?id=141330
924
925         Reviewed by Gustavo Noronha Silva.
926
927         Update notifications unit tests according to the API changes, and
928         add a test case to check that onclose event is fired when a
929         notification is closed by the user.
930
931         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
932         (testWebViewNotification):
933
934 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
935
936         Dashboard doesn't consider building ASan a productive step
937         https://bugs.webkit.org/show_bug.cgi?id=141312
938
939         Reviewed by Simon Fraser.
940
941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
942
943 2015-02-05  Daniel Bates  <dabates@apple.com>
944
945         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
946         https://bugs.webkit.org/show_bug.cgi?id=141306
947
948         Reviewed by Alexey Proskuryakov.
949
950         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
951         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
952         existent runtime.
953
954         * Scripts/webkitpy/xcode/simulator.py:
955         (Runtime.from_identifier):
956
957 2015-02-05  Daniel Bates  <dabates@apple.com>
958
959         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
960         https://bugs.webkit.org/show_bug.cgi?id=139746
961         <rdar://problem/19283658>
962
963         Reviewed by Alexey Proskuryakov.
964
965         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
966         if the simulator device is not in state Booted.
967
968         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
969         launching/relaunching the iOS Simulator app and a simulator app can only be installed
970         on a device that is in the Booted state. LayoutTestRelay may run before the
971         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
972         We should defer executing LayoutTestRelay until the simulator device booted by
973         iOS Simulator is in the Booted state.
974
975         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
976         Simulator methods with the module name, simulator.
977         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
978         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
979         before launching iOS Simulator to boot it.
980         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
981         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
982         * Scripts/webkitpy/xcode/simulator.py:
983         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
984         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
985         interested in the state of the device are more likely interested in the current state of the device as
986         opposed to the state of the device when the Device object was created.
987         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
988         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
989         from both this function and Simulator.device_state().
990         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
991         (Simulator.DeviceState): Added; class of constants.
992         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
993         device is in the specified state.
994         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
995         (Simulator.device_directory): Added.
996         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
997
998 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
999
1000         Disable retries on Mac debug testers
1001         https://bugs.webkit.org/show_bug.cgi?id=141296
1002
1003         Reviewed by Simon Fraser.
1004
1005         * BuildSlaveSupport/build.webkit.org-config/config.json:
1006
1007 2015-02-05  Dan Bernstein  <mitz@apple.com>
1008
1009         Need a way to force $xcodeSDK in webkitdirs.pm
1010         https://bugs.webkit.org/show_bug.cgi?id=141291
1011
1012         Reviewed by Anders Carlsson.
1013
1014         * Scripts/webkitdirs.pm:
1015         (setXcodeSDK): Added.
1016
1017 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
1018
1019         [Streams API] Implement a barebone ReadableStream interface
1020         https://bugs.webkit.org/show_bug.cgi?id=141045
1021
1022         Reviewed by Benjamin Poulain.
1023
1024         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
1025
1026 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
1027
1028         filter-build-webkit: reduce more unfiltered output
1029         https://bugs.webkit.org/show_bug.cgi?id=141282
1030
1031         Reviewed by Daniel Bates.
1032
1033         * Scripts/filter-build-webkit:
1034         Report CompileDTraceScript and Preprocess lines as successful.
1035
1036 2015-02-04  Dana Burkart  <dburkart@apple.com>
1037
1038         Botwatcher's Dashboard is cramped
1039         https://bugs.webkit.org/show_bug.cgi?id=140273
1040
1041         Reviewed by Alexey Proskuryakov.
1042
1043         Add a heading key which will allow for arbitrary headings in builder queues.
1044
1045         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1046         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1047         (BuildbotBuilderQueueView.prototype.update):
1048         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
1049         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1050         (BuildbotIteration.prototype._parseData):
1051         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1052         (BuildbotLeaksQueueView.prototype.update):
1053         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
1054         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
1055         (BuildbotPerformanceQueueView.prototype.update):
1056         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
1057         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1058         (BuildbotQueue):
1059         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1060         (BuildbotQueueView.prototype._unauthorizedAccess):
1061         (BuildbotQueueView.prototype._appendBuild):
1062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1063         (BuildbotTestResults):
1064         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1065         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1066         (BuildbotTesterQueueView.prototype.update):
1067         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
1068
1069 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
1070
1071         WKTR should not use -mainScreen to pick a color profile
1072         https://bugs.webkit.org/show_bug.cgi?id=141265
1073
1074         Reviewed by Tim Horton.
1075         
1076         -[NSScreen mainScreen] depends on the active window, so use the first screen
1077         (which is the one we put the window on anyway).
1078         
1079         Do some cleanup in DRT that makes the code look similar.
1080
1081         * DumpRenderTree/mac/DumpRenderTree.mm:
1082         (createWebViewAndOffscreenWindow):
1083         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1084         (WTR::PlatformWebView::PlatformWebView):
1085
1086 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
1087
1088         LayoutTestHelper should set the color profile of all displays
1089         https://bugs.webkit.org/show_bug.cgi?id=141260
1090
1091         Reviewed by Tim Horton.
1092         
1093         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
1094         which is the screen with the active window. Make things more robust by changing
1095         the colorspace of all displays, not just the main screen, when running layout tests.
1096
1097         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
1098         * DumpRenderTree/mac/LayoutTestHelper.m: 
1099         (originalColorProfileURLs):
1100         (colorProfileURLForDisplay):
1101         (displayUUIDStrings):
1102         (saveDisplayColorProfiles):
1103         (setDisplayColorProfile):
1104         (restoreDisplayColorProfiles):
1105         (installLayoutTestColorProfile):
1106         (restoreUserColorProfile):
1107         (main):        
1108         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
1109         toll-free bridged, sadly). Use the map to restore all profiles on exit.
1110         Convert to use more Obj-C types.
1111
1112 2015-02-04  Daniel Bates  <dabates@apple.com>
1113
1114         test-webkitpy fails on Mac without iphoneos SDK
1115         https://bugs.webkit.org/show_bug.cgi?id=141255
1116         <rdar://problem/19619691>
1117
1118         I inadvertently committed the wrong exception message. Fix up the exception message
1119         to instruct a person to install the iOS SDK when it cannot be found.
1120
1121         * Scripts/webkitpy/port/ios.py:
1122         (IOSPort.determine_full_port_name):
1123
1124 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1125
1126         W3C test importer should sort the list of files when generating the w3c-import.log
1127         https://bugs.webkit.org/show_bug.cgi?id=141156
1128
1129         Reviewed by Bem Jones-Bey.
1130
1131         Sort explicitly the list of imported files written in the w3c-import.log.
1132         Removed logging of the import date.
1133
1134         * Scripts/webkitpy/w3c/test_importer.py:
1135         (TestImporter.write_import_log):
1136
1137 2015-02-04  Daniel Bates  <dabates@apple.com>
1138
1139         test-webkitpy fails on Mac without iphoneos SDK
1140         https://bugs.webkit.org/show_bug.cgi?id=141255
1141         <rdar://problem/19619691>
1142
1143         Reviewed by David Kilzer and Alexey Proskuryakov.
1144
1145         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
1146         should not require the iphoneos SDK to be installed to run the webkitpy tests.
1147
1148         * Scripts/webkitpy/common/system/platforminfo.py:
1149         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
1150         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
1151         to standard output if the SDK is installed to return the empty string if the SDK is
1152         not installed.
1153         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1154         (MockPlatformInfo.xcode_sdk_version): Added.
1155         * Scripts/webkitpy/port/ios.py:
1156         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
1157         to get the version of the iphoneos SDK, if installed.
1158
1159 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
1160
1161         run-webkit-tests doesn't always capture ASan violation reports
1162         https://bugs.webkit.org/show_bug.cgi?id=141231
1163
1164         Reviewed by Darin Adler.
1165
1166         * Scripts/webkitpy/port/driver.py:
1167         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
1168         by the driver already (as is the case with ASan violations, which are printed to
1169         stderr).
1170         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
1171         report.
1172         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
1173         a separate variable for reporting.
1174
1175 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
1176
1177         [webkitpy] Add platform specific Skipped file mechanism for performance tests
1178         https://bugs.webkit.org/show_bug.cgi?id=141152
1179
1180         Reviewed by Csaba Osztrogonác.
1181
1182         Support a test-expectation-like syntax in performance tests' skipped files.
1183         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
1184
1185         * Scripts/webkitpy/port/base.py:
1186         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
1187
1188         * Scripts/webkitpy/port/base_unittest.py:
1189         (PortTest.test_skipped_perf_tests): Test the new syntax.
1190
1191 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
1192
1193         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
1194         https://bugs.webkit.org/show_bug.cgi?id=141236
1195
1196         Reviewed by Sam Weinig.
1197
1198         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1199         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
1200
1201 2015-02-04  Chris Dumez  <cdumez@apple.com>
1202
1203         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
1204         https://bugs.webkit.org/show_bug.cgi?id=141192
1205
1206         Reviewed by Benjamin Poulain.
1207
1208         Add API tests for Vector::removeFirst(value) and
1209         Vector::removeAll(value).
1210
1211         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1212         (TestWebKitAPI::TEST):
1213
1214 2015-02-03  Tim Horton  <timothy_horton@apple.com>
1215
1216         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
1217         https://bugs.webkit.org/show_bug.cgi?id=141217
1218
1219         Reviewed by Sam Weinig.
1220
1221         * WebKitTestRunner/TestController.cpp:
1222         (WTR::copyWebCryptoMasterKey):
1223         (WTR::TestController::createOtherPage):
1224         (WTR::TestController::createWebViewWithOptions):
1225         (WTR::TestController::ensureViewSupportsOptions):
1226         (WTR::TestController::didCommitNavigation):
1227         (WTR::TestController::didFinishNavigation):
1228         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
1229         (WTR::TestController::didReceiveAuthenticationChallenge):
1230         (WTR::TestController::decidePolicyForPluginLoad):
1231         (WTR::TestController::decidePolicyForNavigationAction):
1232         (WTR::TestController::decidePolicyForNavigationResponse):
1233         (WTR::TestController::didCommitLoadForFrame): Deleted.
1234         (WTR::TestController::didFinishLoadForFrame): Deleted.
1235         * WebKitTestRunner/TestController.h:
1236         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
1237
1238 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
1239
1240         Unreviewed. Add myself as a committer.
1241
1242         * Scripts/webkitpy/common/config/contributors.json:
1243
1244 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1245
1246         [Win] Unreviewed test fix.
1247
1248         * DumpRenderTree/win/PolicyDelegate.cpp:
1249         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
1250         so was not matching expected output.
1251
1252 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1253
1254         Unreviewed. Moving myself to the committer section at last.
1255
1256         * Scripts/webkitpy/common/config/contributors.json:
1257
1258 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1259
1260         [Win] Tests fail because DRT reports '(null)' instead of an empty string
1261         https://bugs.webkit.org/show_bug.cgi?id=141205
1262
1263         Reviewed by Anders Carlsson.
1264
1265         * DumpRenderTree/win/HistoryDelegate.cpp:
1266         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
1267         properly so that we match expected DumpRenderTree output.
1268
1269 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1270
1271         [GTK] TestWebKitAccessibility is not skipped
1272         https://bugs.webkit.org/show_bug.cgi?id=141179
1273
1274         Reviewed by Carlos Garcia Campos.
1275
1276         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
1277         skipped, and it apparently works reliably on the bots.
1278
1279         * Scripts/run-gtk-tests:
1280         (TestRunner):
1281
1282 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1283
1284         run-perf-tests: allow to specify a wrapper command.
1285         https://bugs.webkit.org/show_bug.cgi?id=141172
1286
1287         Reviewed by Ryosuke Niwa.
1288
1289         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1290         (parse_args): Update text to indicate is also valid for WTR.
1291         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1292         (PerfTestsRunner._parse_args): Add wrapper command.
1293
1294 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1295
1296         [Win] Correct version parsing warning in update-webkit
1297         https://bugs.webkit.org/show_bug.cgi?id=141200
1298
1299         Reviewed by Anders Carlsson.
1300
1301         * Scripts/webkitdirs.pm:
1302         (setupAppleWinEnv): Strip out any specific version build level
1303         from the Cygwin version information.
1304   
1305
1306 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1307
1308         [Win] Attempt to improve the reliability of HTTP service
1309         https://bugs.webkit.org/show_bug.cgi?id=141191
1310
1311         Reviewed by Darin Adler.
1312
1313         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1314         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
1315         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
1316         when stopping the service doesn't do so on its own (for Windows runs).
1317
1318 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1319
1320         Web platform test server should not need to create __init__.py files
1321         https://bugs.webkit.org/show_bug.cgi?id=141030
1322
1323         Reviewed by Ryosuke Niwa.
1324
1325         W3C TestImporter ensures that copied __init__.py files are not empty.
1326         If needed, a comment is inserted in __init__.py files.
1327         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
1328
1329         * Scripts/webkitpy/common/system/filesystem.py:
1330         (FileSystem.getsize):
1331         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1332         (TestWebPlatformTestServer.test_start_cmd):
1333         (TestWebPlatformTestServer):
1334         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
1335         * Scripts/webkitpy/w3c/test_importer.py:
1336         (TestImporter.import_tests):
1337
1338 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1339
1340         Unreviewed. Moving myself to the committer section.
1341
1342         * Scripts/webkitpy/common/config/contributors.json:
1343
1344 2015-02-02  Saam Barati  <saambarati1@gmail.com>
1345
1346         Create tests for JSC's Control Flow Profiler
1347         https://bugs.webkit.org/show_bug.cgi?id=141123
1348
1349         Reviewed by Filip Pizlo.
1350
1351         * Scripts/run-javascriptcore-tests:
1352         (runJSCStressTests):
1353         * Scripts/run-jsc-stress-tests:
1354
1355 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
1356
1357         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
1358         https://bugs.webkit.org/show_bug.cgi?id=141158
1359
1360         Reviewed by Darin Adler.
1361
1362         * Scripts/run-jsc-stress-tests:
1363
1364 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1365
1366         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
1367         https://bugs.webkit.org/show_bug.cgi?id=141142
1368
1369         Reviewed by Carlos Garcia Campos.
1370
1371         * MiniBrowser/gtk/BrowserWindow.c:
1372         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
1373
1374 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1375
1376         Web platform test server is not always launching properly on Mac EWS bots
1377         https://bugs.webkit.org/show_bug.cgi?id=141141
1378
1379         Unreviewed.
1380
1381         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1382         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
1383
1384 2015-01-31  Sam Weinig  <sam@webkit.org>
1385
1386         Remove even more Mountain Lion support
1387         https://bugs.webkit.org/show_bug.cgi?id=141124
1388
1389         Reviewed by Alexey Proskuryakov.
1390
1391         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1392         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1393         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1394         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1395         * DumpRenderTree/mac/DumpRenderTree.mm:
1396         (activateTestingFonts):
1397         (prepareConsistentTestingEnvironment):
1398         * DumpRenderTree/mac/EventSendingController.mm:
1399         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1400         (-[EventSendingController contextClick]):
1401         * DumpRenderTree/mac/TextInputController.m:
1402         * LayoutTestRelay/Configurations/Base.xcconfig:
1403         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1404         * MiniBrowser/Configurations/Base.xcconfig:
1405         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1406         * MiniBrowser/mac/WK2BrowserWindowController.m:
1407         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1408         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1409         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
1410         * TestWebKitAPI/Configurations/Base.xcconfig:
1411         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1412         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1413         (-[DownloadDelegate _downloadDidFinish:]):
1414         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1415         (TestWebKitAPI::TEST):
1416         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1417         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1418         * WebKitLauncher/Configurations/Base.xcconfig:
1419         * WebKitTestRunner/Configurations/Base.xcconfig:
1420         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1421         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1422         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1423         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1424         (WTR::activateFonts):
1425         * WebKitTestRunner/TestController.cpp:
1426         (WTR::TestController::initialize):
1427         (WTR::TestController::webProcessName):
1428         * WebKitTestRunner/mac/EventSenderProxy.mm:
1429         * asan/asan.xcconfig:
1430
1431 2015-01-31  Commit Queue  <commit-queue@webkit.org>
1432
1433         Unreviewed, rolling out r179408.
1434         https://bugs.webkit.org/show_bug.cgi?id=141117
1435
1436         This didn't fully fix the issue (Requested by anttik on
1437         #webkit).
1438
1439         Reverted changeset:
1440
1441         "OSObjectPtr does not work with dispatch_data_t on Maverics"
1442         https://bugs.webkit.org/show_bug.cgi?id=141081
1443         http://trac.webkit.org/changeset/179408
1444
1445 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1446
1447         https://trac.webkit.org/changeset/179439 breaks a python test
1448         https://bugs.webkit.org/show_bug.cgi?id=141114
1449
1450         Unreviewed.
1451
1452         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1453         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
1454
1455 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1456
1457         Import W3C web platform tests infrastructure
1458         https://bugs.webkit.org/show_bug.cgi?id=140934
1459
1460         Reviewed by Ryosuke Niwa.
1461
1462         Loading necessary web platform tests modules before launching server.
1463         Ensuring that some empty __init__.py files are present and create them if necessary. 
1464
1465         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1466         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1467
1468 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1469
1470         [Win] Another unreviewed test fix.
1471
1472         Correct copy/paste error in buildbot handling.
1473
1474         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1475         (LayoutTestApacheHttpd.__init__):
1476         (LayoutTestApacheHttpd._get_apache_config_file_path):
1477
1478 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1479
1480         [Win] Unreviewed test fix.
1481
1482         Correct path handling based on failures on test bots to get things running again.
1483
1484         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1485         (LayoutTestApacheHttpd.__init__):
1486         (LayoutTestApacheHttpd._get_apache_config_file_path):
1487
1488 2015-01-30  Chris Dumez  <cdumez@apple.com>
1489
1490         Unreviewed. Fix Windows build after r179409.
1491
1492         * DumpRenderTree/win/TestRunnerWin.cpp:
1493         (TestRunner::notifyDone):
1494         (TestRunner::queueLoad):
1495
1496 2015-01-30  Chris Dumez  <cdumez@apple.com>
1497
1498         Rename shared() static member functions to singleton() for singleton classes.
1499         https://bugs.webkit.org/show_bug.cgi?id=141088
1500
1501         Reviewed by Ryosuke Niwa and Benjamin Poulain.
1502
1503         Rename shared() static member functions to singleton() for singleton
1504         classes as per the recent coding style change.
1505
1506 2015-01-30  Antti Koivisto  <antti@apple.com>
1507
1508         OSObjectPtr does not work with dispatch_data_t on Maverics
1509         https://bugs.webkit.org/show_bug.cgi?id=141081
1510
1511         Reviewed by Pratik Solanki.
1512
1513         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
1514         (TestWebKitAPI::TEST):
1515
1516 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1517
1518         [Win] Switch to Apache on Windows
1519         https://bugs.webkit.org/show_bug.cgi?id=141060
1520
1521         Reviewed by Alexey Proskuryakov.
1522
1523         Update our scripts under Windows (and Cygwin) to locate and use
1524         the XAMPP installation of Apache for running tests.
1525
1526         * Scripts/run-webkit-httpd:
1527         * Scripts/webkitperl/httpd.pm:
1528         (getHTTPDPath):
1529         (getDefaultConfigForTestDirectory):
1530         (getHTTPDConfigPathForTestDirectory):
1531         * Scripts/webkitpy/common/system/executive_unittest.py:
1532         (ExecutiveTest.serial_test_kill_process):
1533         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1534         (LayoutTestApacheHttpd.__init__):
1535         (LayoutTestApacheHttpd._get_apache_config_file_path):
1536         (LayoutTestApacheHttpd._stop_running_server):
1537         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1538         (HttpServerBase._is_server_running_on_all_ports):
1539         * Scripts/webkitpy/port/base.py:
1540         (Port._apache_config_file_name_for_platform):
1541         * Scripts/webkitpy/port/port_testcase.py:
1542         (test_apache_config_file_name_for_platform):
1543         * Scripts/webkitpy/port/win.py:
1544         (WinPort.show_results_html_file):
1545         (WinPort._uses_apache):
1546         (WinPort):
1547         (WinPort._path_to_apache):
1548
1549 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
1550
1551         Built result takes too long to be compressed on bots
1552         https://bugs.webkit.org/show_bug.cgi?id=141056
1553
1554         Reviewed by Daniel Bates.
1555
1556         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
1557
1558         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
1559
1560 2015-01-29  Sam Weinig  <sam@webkit.org>
1561
1562         Remove support for screen font substitution
1563         https://bugs.webkit.org/show_bug.cgi?id=141038
1564
1565         Reviewed by Tim Horton.
1566
1567         * DumpRenderTree/win/DumpRenderTree.cpp:
1568         (resetWebPreferencesToConsistentValues):
1569         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
1570
1571 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1572
1573         Make run-jsc-stress-tests --remote work on Linux too
1574         https://bugs.webkit.org/show_bug.cgi?id=141000
1575
1576         Reviewed by Darin Adler.
1577
1578         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
1579         use bash/dash compatible signal names, use Linux/Mac compatible find options,
1580         use bash/dash compatible functions.
1581         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
1582
1583 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1584
1585         [buildbot] Simplify jscore-test buildstep
1586         https://bugs.webkit.org/show_bug.cgi?id=140821
1587
1588         Reviewed by Alexey Proskuryakov.
1589
1590         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1591         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
1592         (RunJavaScriptCoreTests.countFailures): Added.
1593         (RunJavaScriptCoreTests.commandComplete): Deleted.
1594         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
1595         (RunJavaScriptCoreTests.getText): Deleted.
1596         (RunJavaScriptCoreTests.getText2): Deleted.
1597         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
1598         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
1599         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
1600         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
1601         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
1602
1603 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1604
1605         Unreviewed, revert r179337, we don't need this dependency.
1606
1607         * efl/install-dependencies:
1608         * gtk/install-dependencies:
1609
1610 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
1611
1612         Unreviewed. Moving myself to the committer section.
1613
1614         * Scripts/webkitpy/common/config/contributors.json:
1615
1616 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
1617
1618         URTBF after r179326, added uuid-dev package as new dependency.
1619
1620         * efl/install-dependencies:
1621         * gtk/install-dependencies:
1622
1623 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
1624
1625         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
1626         https://bugs.webkit.org/show_bug.cgi?id=140673
1627
1628         Reviewed by Sam Weinig.
1629
1630         * Scripts/dtrace/trace-webkit2-messages.d: Added.
1631         Add a DTrace script that outputs a small blob of JSON per message.
1632
1633 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
1634
1635         Removed fastMallocForbid / fastMallocAllow
1636         https://bugs.webkit.org/show_bug.cgi?id=141012
1637
1638         Reviewed by Mark Hahnenberg.
1639
1640         Fixed a test bug I noticed while testing.
1641
1642         * DumpRenderTree/JavaScriptThreading.cpp:
1643         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
1644         accessing javaScriptThreads -- otherwise, you'll ASSERT.
1645
1646 2015-01-28  Dana Burkart  <dburkart@apple.com>
1647
1648         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
1649         https://bugs.webkit.org/show_bug.cgi?id=141015
1650
1651         Reviewed by Alexey Proskuryakov.
1652
1653         * asan/asan.xcconfig:
1654
1655 2015-01-28  Sam Weinig  <sam@webkit.org>
1656
1657         Fix the build.
1658
1659         * Scripts/copy-webkitlibraries-to-product-directory:
1660
1661 2015-01-28  Lucas Forschler  <lforschler@apple.com>
1662
1663         Increase the FileUpload block size in an attempt to improve network performance.
1664         
1665         Reviewed by Alexey Proskuryakov.
1666         
1667         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1668         (UploadBuiltProduct.__init__):
1669
1670 2015-01-28  Dana Burkart  <dburkart@apple.com>
1671
1672         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1673         https://bugs.webkit.org/show_bug.cgi?id=136765
1674
1675         Reviewed by Alexey Proskuryakov.
1676
1677         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1678         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1679         * LayoutTestRelay/Configurations/Base.xcconfig:
1680         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1681         * MiniBrowser/Configurations/Base.xcconfig:
1682         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1683         * TestWebKitAPI/Configurations/Base.xcconfig:
1684         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1685         * WebKitLauncher/Configurations/Base.xcconfig:
1686         * WebKitTestRunner/Configurations/Base.xcconfig:
1687         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1688
1689 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
1690
1691         AX: [ATK] Implement support for new AtkRole types for MathML
1692         https://bugs.webkit.org/show_bug.cgi?id=140916
1693
1694         Reviewed by Chris Fleizach.
1695
1696         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
1697         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
1698
1699 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1700
1701         [GTK] Stop removing color marks from unit tests output
1702         https://bugs.webkit.org/show_bug.cgi?id=140996
1703
1704         Reviewed by Philippe Normand.
1705
1706         Since r178236 google tests use a custom simplified output without
1707         any colors, so we don't need to handle the case of non ttys to
1708         remove the color marks.
1709
1710         * Scripts/run-gtk-tests:
1711         (TestRunner.__init__):
1712         (TestRunner._run_test_command.parse_line):
1713
1714 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1715
1716         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
1717         https://bugs.webkit.org/show_bug.cgi?id=131731
1718
1719         Reviewed by Žan Doberšek.
1720
1721         A web page loaded offscreen is in prerender state not hidden.
1722
1723         * Scripts/run-gtk-tests:
1724         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
1725         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1726         (testWebViewPageVisibility):
1727
1728 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1729
1730         Partially revert r178802.
1731
1732         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
1733         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
1734
1735 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1736
1737         build.webkit.org/dashboard asserts on some commits
1738         https://bugs.webkit.org/show_bug.cgi?id=140926
1739
1740         Reviewed by Tim Horton.
1741
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1743         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
1744
1745 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1746
1747         Make flakiness dashboard OS list actually match test_expectations.py
1748         https://bugs.webkit.org/show_bug.cgi?id=140969
1749
1750         Reviewed by Ryosuke Niwa.
1751
1752         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1753
1754 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
1755
1756         [Win] WinLauncher crashes on eleventh site visited
1757         https://bugs.webkit.org/show_bug.cgi?id=140960
1758
1759         Reviewed by Anders Carlsson.
1760
1761         * WinLauncher/WinLauncher.cpp:
1762         (WinLauncher::showLastVisitedSites): Don't access off the end of
1763         the history array.
1764
1765 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1766
1767         [Mac] Disable building Java applets by default
1768         https://bugs.webkit.org/show_bug.cgi?id=140957
1769         rdar://problem/19619529
1770
1771         Reviewed by Anders Carlsson.
1772
1773         It was actually already disabled unconditionally, by accident.
1774
1775         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
1776         * Scripts/webkitpy/port/mac.py:
1777         (MacPort._check_port_build):
1778         (MacPort._build_java_test_support):
1779
1780 2015-01-27  Daniel Bates  <dabates@apple.com>
1781
1782         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
1783         https://bugs.webkit.org/show_bug.cgi?id=140949
1784
1785         Reviewed by Alexey Proskuryakov.
1786
1787         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
1788         builders so that run-webkit-tests can lint the appropriate TestExpectation
1789         files.
1790
1791         * Scripts/webkitpy/port/builders.py:
1792         * Scripts/webkitpy/port/ios.py:
1793         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
1794         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
1795         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
1796         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
1797         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
1798         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
1799         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
1800
1801
1802 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1803
1804         Update bots on the flakiness dashboard
1805         https://bugs.webkit.org/show_bug.cgi?id=140956
1806
1807         Reviewed by Ryosuke Niwa.
1808
1809         * TestResultServer/static-dashboards/builders.jsonp:
1810         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1811
1812 2015-01-27  Daniel Bates  <dabates@apple.com>
1813
1814         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
1815         https://bugs.webkit.org/show_bug.cgi?id=140942
1816
1817         Reviewed by Alexey Proskuryakov.
1818
1819         The directory LayoutTests/platform/wk2 contains test expectations and test results that
1820         are applicable to all WebKit2 ports. We should make use of this information when
1821         running layout tests using iOS WebKit2.
1822
1823         Additionally, make use of the convenience function Port._wk2_port_name() for the name
1824         of the WebKit2 port instead of directly using string concatenation.
1825
1826         * Scripts/webkitpy/port/ios.py:
1827         (IOSSimulatorPort.default_baseline_search_path):
1828
1829 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
1830
1831         [Win] Disable FTL stress tests
1832         https://bugs.webkit.org/show_bug.cgi?id=140932
1833
1834         Reviewed by Brent Fulgham.
1835
1836         * Scripts/run-javascriptcore-tests:
1837
1838 2015-01-27  Daniel Bates  <dabates@apple.com>
1839
1840         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
1841         https://bugs.webkit.org/show_bug.cgi?id=140939
1842
1843         Reviewed by Eric Carlson.
1844
1845         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
1846
1847         * Scripts/webkitdirs.pm:
1848         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
1849         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
1850         and define a function called wanted.
1851
1852 2015-01-27  Daniel Bates  <dabates@apple.com>
1853
1854         Teach run-webkit-app --simulator how to install custom built app
1855         https://bugs.webkit.org/show_bug.cgi?id=140691
1856
1857         Fix inadvertent omission of directory test flag in expression to check for the
1858         existence of the iOS simulator device-specific directory for user installed apps.
1859
1860         * Scripts/webkitdirs.pm:
1861         (hasUserInstalledAppInSimulatorDevice):
1862
1863 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
1864
1865         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
1866         https://bugs.webkit.org/show_bug.cgi?id=87426
1867         <rdar://problem/11527899>
1868
1869         Reviewed by Darin Adler.
1870
1871         Revise COMPtr to work better with our HashMap implementation. Use
1872         modern loop syntax.
1873
1874         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1875         (AccessibilityController::~AccessibilityController):
1876         (AccessibilityController::winNotificationReceived):
1877         * DumpRenderTree/win/DumpRenderTree.cpp:
1878         (dumpBackForwardListForAllWindows):
1879
1880 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1881
1882         [Win] Enable JSC stress tests by default
1883         https://bugs.webkit.org/show_bug.cgi?id=128307
1884
1885         Reviewed by Brent Fulgham.
1886
1887         * Scripts/run-javascriptcore-tests:
1888
1889 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1890
1891         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
1892         arguments for build and test scripts
1893         https://bugs.webkit.org/show_bug.cgi?id=139748
1894
1895         Reviewed by Daniel Bates.
1896
1897         There was much confusion resulting from the multitude of aliases used to build/test for
1898         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
1899         tests directory.
1900
1901         This fixes an issue where run-api-tests and some other scripts failed when run with
1902         --simulator.
1903
1904         * Scripts/build-webkit:
1905         * Scripts/package-root:
1906         (usage):
1907         * Scripts/webkitdirs.pm:
1908         (argumentsForConfiguration):
1909         (determineXcodeSDK):
1910         * Scripts/webkitpy/port/factory.py:
1911         (platform_options):
1912
1913 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1914
1915         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
1916         https://bugs.webkit.org/show_bug.cgi?id=140203
1917         rdar://problem/19198492
1918
1919         Reviewed by Sam Weinig.
1920
1921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1922         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
1923         (TEST):
1924
1925 2015-01-26  David Kilzer  <ddkilzer@apple.com>
1926
1927         Add iOS EWS to build.webkit.org/dashboard
1928         <http://webkit.org/b/140627>
1929
1930         Reviewed by Alexey Proskuryakov.
1931
1932         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
1933         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
1934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1935         (BubbleQueueServer): Add ios-ews queue info.
1936         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1937         Add iOS8Device platform.
1938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1939         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
1940         iOS device logo.
1941
1942 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
1943
1944         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
1945         https://bugs.webkit.org/show_bug.cgi?id=140896
1946
1947         Reviewed by Michael Saboff.
1948         
1949         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
1950         makes our script do this.
1951         
1952         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
1953         this would be harder given llvm's autoconf setup.
1954
1955         * Scripts/copy-webkitlibraries-to-product-directory:
1956
1957 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1958
1959         Update bot assignments.
1960
1961         * BuildSlaveSupport/build.webkit.org-config/config.json:
1962
1963 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1964
1965         Integrate WP python server into WebKit test framework
1966         https://bugs.webkit.org/show_bug.cgi?id=127094
1967
1968         Reviewed by Ryosuke Niwa.
1969
1970         This patch adds W3C web server (wptserver) as a new HTTP server.
1971         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
1972         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
1973
1974         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
1975         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
1976         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
1977
1978         * Scripts/webkitpy/common/system/executive_mock.py:
1979         (MockProcess.communicate):
1980         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
1981         (LayoutTestRunner.__init__):
1982         (LayoutTestRunner.run_tests):
1983         (LayoutTestRunner.start_servers):
1984         (LayoutTestRunner.stop_servers):
1985         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
1986         (LayoutTestRunnerTests._run_tests):
1987         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
1988         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
1989         (LayoutTestRunnerTests):
1990         (LayoutTestRunnerTests.test_servers_started):
1991         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
1992         (Manager.__init__):
1993         (Manager._is_http_test):
1994         (Manager._is_web_platform_test):
1995         (Manager._run_tests):
1996         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1997         (ManagerTest.test_needs_servers.get_wpt_doc_root):
1998         (ManagerTest.test_needs_servers.get_manager):
1999         (ManagerTest.test_needs_servers):
2000         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
2001         (parse_args):
2002         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
2003         (main):
2004         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
2005         (doc_root):
2006         (base_url):
2007         (WebPlatformTestServer):
2008         (WebPlatformTestServer.__init__):
2009         (WebPlatformTestServer._set_start_cmd):
2010         (WebPlatformTestServer._copy_webkit_test_files):
2011         (WebPlatformTestServer._clean_webkit_test_files):
2012         (WebPlatformTestServer._prepare_config):
2013         (WebPlatformTestServer._spawn_process):
2014         (WebPlatformTestServer._stop_running_server):
2015         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
2016         (TestWebPlatformTestServer):
2017         (TestWebPlatformTestServer.test_start_cmd):
2018         * Scripts/webkitpy/port/base.py:
2019         (Port.__init__):
2020         (Port.to.start_web_platform_test_server):
2021         (Port.to):
2022         (Port.to.web_platform_test_server_doc_root):
2023         (Port.to.web_platform_test_server_base_url):
2024         (Port.to.stop_web_platform_test_server):
2025         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
2026         (Driver.__init__):
2027         (Driver.is_web_platform_test):
2028         (Driver.test_to_uri):
2029         (Driver.uri_to_test):
2030         (Driver._command_from_driver_input):
2031         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
2032         (DriverTest.test_test_to_uri):
2033         (DriverTest.test_uri_to_test):
2034
2035 2015-01-26  Daniel Bates  <dabates@apple.com>
2036
2037         Teach run-webkit-app --simulator how to install custom built app
2038         https://bugs.webkit.org/show_bug.cgi?id=140691
2039
2040         Reviewed by David Kilzer.
2041
2042         We should teach run-webkit-app --simulator how to install a custom built app.
2043
2044         Currently run-webkit-app --simulator can only run a system app or an app that
2045         was installed using the simctl command line tool. For convenience we should
2046         teach run-webkit-app --simulator how to install a custom built app.
2047
2048         As a side effect of this change run-safari --simulator will install and run
2049         a custom built of MobileSafari (if it exists).
2050
2051         * Scripts/webkitdirs.pm:
2052         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
2053         Perl from the structure of the device.plist file.
2054         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
2055         file system check to determine the plist path for a Mac app bundle.
2056         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
2057         it will complain that it cannot find the file: "Domain ... does not exist".
2058         (appDisplayNameFromBundle): Ditto.
2059         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
2060         until a simulator device is the specified state.
2061         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
2062         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
2063         the specified device.
2064         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
2065         As implied by its name, this function will not return until the specified simulator
2066         device UDID is in the shutdown state.
2067         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
2068         device with the specified UDID.
2069         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
2070         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
2071         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
2072         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
2073         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
2074         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
2075         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
2076         (hasUserInstalledAppInSimulatorDevice): Added.
2077         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
2078         "Booted" state.
2079         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
2080         switching between a system installed app and a custom built version of the same app (e.g.
2081         custom build of MobileSafari) will erase all contents and settings in the simulator device.
2082         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
2083         as that was the only caller of this function.
2084         (bootedIOSSimulatorDevice): Deleted.
2085         (openIOSSimulator): Deleted.
2086
2087 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
2088
2089         Update bot assignments.
2090
2091         * BuildSlaveSupport/build.webkit.org-config/config.json:
2092
2093 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
2094
2095         Leaks bot shouldn't run JSC tests
2096         https://bugs.webkit.org/show_bug.cgi?id=140877
2097
2098         Reviewed by Darin Adler.
2099
2100         Shaves off 48 minutes of time.
2101
2102         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2103         (TestLeaksFactory): Slim down the leaks queue.
2104
2105         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2106         * Scripts/webkitpy/port/ios.py:
2107         (IOSSimulatorPort.print_leaks_summary):
2108         * Scripts/webkitpy/port/mac.py:
2109         (MacPort.print_leaks_summary):
2110         Don't yell when leaks are detected.
2111
2112 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2113
2114         Refactor run-javascriptcore-tests
2115         https://bugs.webkit.org/show_bug.cgi?id=140824
2116
2117         Reviewed by Darin Adler.
2118
2119         Separated mozilla, stress test code paths and
2120         determining skipped mozilla tests into subroutines.
2121
2122         * Scripts/run-javascriptcore-tests:
2123         (runMozillaTests):
2124         (runJSCStressTests):
2125         (defaultJsDriverArgsForMozillaTests):
2126
2127 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2128
2129         [buildbot] Fix grammar of TestWithFailureCount
2130         https://bugs.webkit.org/show_bug.cgi?id=140884
2131
2132         Reviewed by Alexey Proskuryakov.
2133
2134         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2135         (TestWithFailureCount):
2136         (TestWithFailureCount.commandComplete):
2137         (TestWithFailureCount.getText2):
2138         (RunUnitTests):
2139         (RunPythonTests):
2140         (RunPerlTests):
2141         (RunLLINTCLoopTests):
2142         (Run32bitJSCTests):
2143         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2144         (RunLLINTCLoopTestsTest.test_failure):
2145         (Run32bitJSCTestsTest.test_failure):
2146         (RunUnitTestsTest.assertFailures):
2147
2148 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2149
2150         Unreviewed. Moving myself to the committer section.
2151
2152         * Scripts/webkitpy/common/config/contributors.json:
2153
2154 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
2155
2156         [GTK] gtkdoc does not appear in DevHelp
2157         https://bugs.webkit.org/show_bug.cgi?id=139369
2158
2159         Reviewed by Philippe Normand.
2160
2161         * gtk/generate-gtkdoc: Create the generators in the main function
2162         and use them to get the local cross renference dependencies. Also
2163         pass the generator module name to webkitdom.write_doc_files().
2164         (get_gtkdoc_module_paths): Receive a list of local cross reference
2165         dependencies.
2166         (get_generator_for_config): Set the main_sgml_file property of the
2167         GtkDoc object from the configuration file.
2168         (generate_documentation): Generate the documentation for the given
2169         generator.
2170         (generate_documentation_for_config): Deleted.
2171         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
2172         * gtk/webkitdom.py:
2173         (write_doc_files): Receive the module name used to build the
2174         -sections.txt filename.
2175
2176 2015-01-26  Commit Queue  <commit-queue@webkit.org>
2177
2178         Unreviewed, rolling out r179107.
2179         https://bugs.webkit.org/show_bug.cgi?id=140880
2180
2181         The GCC in the bots doesn't support the AsyncTask
2182         implementation (Requested by KaL on #webkit).
2183
2184         Reverted changeset:
2185
2186         "[GTK] Enable IndexedDB"
2187         https://bugs.webkit.org/show_bug.cgi?id=98932
2188         http://trac.webkit.org/changeset/179107
2189
2190 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2191
2192         [EFL] Bump libseccomp version to 2.1.1
2193         https://bugs.webkit.org/show_bug.cgi?id=140357
2194
2195         Reviewed by Gyuyoung Kim.
2196
2197         * efl/jhbuild.modules:
2198
2199 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2200
2201         [GTK] Enable IndexedDB
2202         https://bugs.webkit.org/show_bug.cgi?id=98932
2203
2204         Reviewed by Žan Doberšek.
2205
2206         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
2207
2208 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
2209
2210         Would like leaks bot results at build.webkit.org/dashboard
2211         https://bugs.webkit.org/show_bug.cgi?id=122657
2212
2213         Reviewed by Darin Adler.
2214
2215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2216         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
2217         than necessary, could use the ones from buildbot in more places.
2218
2219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2220         (BuildbotQueue): Reflect configuration option for leaks queues.
2221
2222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2223         Add leaks queues to performance column. First, leaks are about performance indeed,
2224         and second, this is where we have some space to spare.
2225
2226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2227         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
2228         least a year.
2229
2230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2231         (table.queue-grid td): Moved height from queue-view - we can now have more than one
2232         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
2233         results - once the results are loaded, all rows are currently higher than that.
2234
2235         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2236         (.leaks-popover): Added.
2237
2238         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2239         Added.
2240
2241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2242         Load BuildbotLeaksQueueView.js.
2243
2244 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
2245
2246         [Win] Add WebKit message loop interface.
2247         https://bugs.webkit.org/show_bug.cgi?id=140857
2248
2249         Reviewed by Brent Fulgham.
2250
2251         Added message loop interface which will run the message loop,
2252         and perform required tasks (like calling CFRunLoopRunInMode)
2253         on each iteration of the loop.
2254
2255         * WinLauncher/WinMain.cpp:
2256         (wWinMain): Use new message loop interface.
2257
2258 2015-01-24  Dan Bernstein  <mitz@apple.com>
2259
2260         update-webkit’s --internal option is unused
2261         https://bugs.webkit.org/show_bug.cgi?id=140861
2262
2263         Reviewed by Anders Carlsson.
2264
2265         * Scripts/update-webkit: Removed the option.
2266
2267 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
2268
2269         DumpRenderTree needs to run with Windows native controls on Windows
2270         https://bugs.webkit.org/show_bug.cgi?id=25592
2271
2272         Reviewed by Anders Carlsson.
2273
2274         * DumpRenderTree/win/DumpRenderTree.cpp:
2275         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
2276         (prepareConsistentTestingEnvironment): Ditto.
2277
2278 2015-01-23  David Kilzer  <ddkilzer@apple.com>
2279
2280         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
2281         <http://webkit.org/b/140787>
2282
2283         Reviewed by Daniel Bates.
2284
2285         * Scripts/webkitpy/port/ios.py:
2286         (IOSPort.determine_full_port_name): Instead of checking the type
2287         of the current host, test if /usr/bin/xcrun exists before trying
2288         to use it.
2289
2290 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
2291
2292         Fix the false positive build failures on the Windows buildbots
2293         https://bugs.webkit.org/show_bug.cgi?id=140819
2294
2295         Reviewed by Brent Fulgham.
2296
2297         Increase the build timeout (without producing output) to 2 hours for Windows bots,
2298         the default 20 minutes is enough for others since they produce output during the build.
2299
2300         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2301         (BuildFactory.__init__):
2302
2303 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
2304
2305         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
2306         https://bugs.webkit.org/show_bug.cgi?id=140839
2307
2308         Reviewed by Dean Jackson.
2309
2310         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2311         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
2312         from the IA2Locale structure and pass it to DRT.
2313
2314 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
2315
2316         [Win] Update DRT Accessibility implementation to better match Mac.
2317         https://bugs.webkit.org/show_bug.cgi?id=140830
2318
2319         Reviewed by Dean Jackson.
2320
2321         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2322         (AccessibilityUIElement::titleUIElement):
2323         (AccessibilityUIElement::parentElement):
2324         (convertToDRTLabel):
2325         (AccessibilityUIElement::role):
2326         (AccessibilityUIElement::title):
2327         (AccessibilityUIElement::description):
2328         (AccessibilityUIElement::stringValue):
2329         (AccessibilityUIElement::helpText):
2330         (AccessibilityUIElement::isFocused):
2331
2332 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
2333
2334         REGRESSION: run-perf-tests --profiler= seems to have broken
2335         https://bugs.webkit.org/show_bug.cgi?id=113528
2336
2337         Reviewed by Daniel Bates.
2338
2339         The problem is that "perf --record" (or the equivalent call for
2340         other profilers) is never called whenever there is a wrapper
2341         option in the port. We should inject the profiler call first
2342         (should it exists) and then use the port wrapper.
2343
2344         * Scripts/webkitpy/port/driver.py:
2345         (Driver._command_wrapper):
2346         * Scripts/webkitpy/port/driver_unittest.py:
2347         (DriverTest.test_profiler_and_wrapper): New unit test.
2348
2349 2015-01-22  David Kilzer  <ddkilzer@apple.com>
2350
2351         configure-xcode-for-ios-development needs to import webkitdirs.pm
2352         <http://webkit.org/b/140704>
2353
2354         Fixes the following runtime error:
2355
2356             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
2357
2358         * Scripts/configure-xcode-for-ios-development: Add back code to
2359         import webkitdirs.pm for the exitStatus() method.  Not sure why
2360         I removed it before patch review.
2361
2362 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
2363
2364         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
2365         https://bugs.webkit.org/show_bug.cgi?id=140795
2366
2367         Reviewed by Jon Honeycutt.
2368
2369         * BuildSlaveSupport/build.webkit.org-config/config.json:
2370         r178847 accidentally remove the scheduler for this bot. Re-add it to the
2371         Yosemite scheduler.
2372
2373 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
2374
2375         [Win] Expose missing editing features through WebView interface
2376         https://bugs.webkit.org/show_bug.cgi?id=140773
2377         <rdar://problem/19565421>
2378
2379         Reviewed by Dean Jackson.
2380
2381         Connect the various WebView editing delegate methods to our
2382         test infrastructure. Also prefer _bstr_t to raw BSTR types
2383         to simplify life cycle management.
2384
2385         * DumpRenderTree/win/DumpRenderTree.cpp:
2386         (resetWebViewToConsistentStateBeforeTesting):
2387         * DumpRenderTree/win/EditingDelegate.cpp:
2388         (EditingDelegate::QueryInterface):
2389         (dumpPath):
2390         (dump):
2391         (EditingDelegate::shouldBeginEditingInDOMRange):
2392         (EditingDelegate::shouldEndEditingInDOMRange):
2393         (EditingDelegate::shouldInsertNode):
2394         (EditingDelegate::shouldInsertText):
2395         (EditingDelegate::shouldDeleteDOMRange):
2396         (EditingDelegate::shouldChangeSelectedDOMRange):
2397         (EditingDelegate::shouldApplyStyle):
2398         (EditingDelegate::shouldChangeTypingStyle):
2399         (EditingDelegate::doPlatformCommand):
2400         (EditingDelegate::webViewDidBeginEditing):
2401         (EditingDelegate::webViewDidChange):
2402         (EditingDelegate::webViewDidEndEditing):
2403         (EditingDelegate::webViewDidChangeTypingStyle):
2404         (EditingDelegate::webViewDidChangeSelection):
2405         (EditingDelegate::checkSpellingOfString):
2406         (EditingDelegate::onNotify):
2407         * DumpRenderTree/win/EditingDelegate.h:
2408
2409 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2410
2411         Add a build flag for ES6 class syntax
2412         https://bugs.webkit.org/show_bug.cgi?id=140760
2413
2414         Reviewed by Michael Saboff.
2415
2416         * Scripts/webkitperl/FeatureList.pm:
2417
2418 2015-01-22  Daniel Bates  <dabates@apple.com>
2419
2420         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
2421         runtime in simctl output
2422         https://bugs.webkit.org/show_bug.cgi?id=140751
2423
2424         Reviewed by David Kilzer.
2425
2426         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
2427         with an error because it does not know how to parse the output of the simctl tool
2428         to identify an Apple Internal runtime.
2429
2430         * Scripts/webkitpy/xcode/simulator.py:
2431         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
2432         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
2433         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
2434         the runtime is an internal runtime.
2435         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
2436         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
2437         appropriate value.
2438         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
2439         it updates the appropriate Runtime object.
2440         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
2441         looking up a Runtime object for an internal runtime.
2442
2443 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
2444
2445         LeaksViewer doesn't show recent builds if there are less than 10
2446         https://bugs.webkit.org/show_bug.cgi?id=140716
2447
2448         Reviewed by Tim Horton.
2449
2450         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2451
2452 2015-01-22  Lucas Forschler  <lforschler@apple.com>
2453
2454         Add Apple build slaves.
2455         Fixed text alignment for slave list.
2456         
2457         Unreviewed.
2458         
2459         * BuildSlaveSupport/build.webkit.org-config/config.json:
2460
2461 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2462
2463         Teach build.webkit.org about bot308 and bot309.
2464         
2465         Unreviewed.
2466         
2467         * BuildSlaveSupport/build.webkit.org-config/config.json:
2468
2469 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2470
2471         Add two Apple Mavericks slaves.
2472         
2473         Unreviewed.
2474         
2475         * BuildSlaveSupport/build.webkit.org-config/config.json:
2476
2477 2015-01-21  Daniel Bates  <dabates@apple.com>
2478
2479         Add iOS WebKit1 TestExpectation file
2480         https://bugs.webkit.org/show_bug.cgi?id=140739
2481
2482         Reviewed by David Kilzer.
2483
2484         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
2485         expectations in directory LayoutTests/platform/ios-simulator-wk1.
2486
2487         * Scripts/webkitpy/port/ios.py:
2488         (IOSSimulatorPort.default_baseline_search_path):
2489
2490 2015-01-21  David Kilzer  <ddkilzer@apple.com>
2491
2492         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
2493         <http://webkit.org/b/140704>
2494
2495         Reviewed by Daniel Bates.
2496
2497         * Scripts/configure-xcode-for-ios-development:
2498         - Update copyright.
2499         - Remove FIXME addressed by r178709.
2500         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
2501         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
2502         missing headers from iphonesimulator SDK to iphoneos SDK.
2503         (sdkDirectory): Add method that returns SDK directory.
2504         (sdkPlatformDirectory): Extract method from
2505         xcodeSDKSpecificationsPath() that returns SDK platform
2506         directory.
2507         (xcodeSDKSpecificationsPath): Update to use
2508         sdkPlatformDirectory().
2509
2510 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
2511
2512         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
2513         https://bugs.webkit.org/show_bug.cgi?id=140731
2514
2515         Reviewed by Tim Horton.
2516
2517         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2518         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
2519
2520 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
2521
2522         [Win] eventSender does not support scalePageBy
2523         https://bugs.webkit.org/show_bug.cgi?id=140726
2524         <rdar://problem/19549865>
2525
2526         Reviewed by Dean Jackson.
2527
2528         * DumpRenderTree/win/EventSender.cpp:
2529         (scalePageByCallback): Provide implementation using new WebView method.
2530
2531 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2532
2533         Remove Apple Mountain Lion Build & Test slaves.
2534         
2535         Unreviewed.
2536
2537         * BuildSlaveSupport/build.webkit.org-config/config.json:
2538
2539 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
2540
2541         Remove ENABLE(INSPECTOR) ifdef guards
2542         https://bugs.webkit.org/show_bug.cgi?id=140668
2543
2544         Reviewed by Darin Adler.
2545
2546         * DumpRenderTree/mac/TestRunnerMac.mm:
2547         (TestRunner::showWebInspector):
2548         (TestRunner::closeWebInspector):
2549         (TestRunner::evaluateInWebInspector):
2550         * Scripts/webkitperl/FeatureList.pm:
2551         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2552         (WTR::TestRunner::showWebInspector):
2553         (WTR::TestRunner::closeWebInspector):
2554         (WTR::TestRunner::evaluateInWebInspector):
2555         * WebKitTestRunner/TestInvocation.cpp:
2556         (WTR::TestInvocation::invoke):
2557
2558 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
2559
2560         Update build.webkit.org/dashboard to match current Mac queues.
2561
2562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
2563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
2564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
2565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
2566         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2569         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
2570         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
2571
2572 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2573
2574         Update Apple MountainLion Leaks slave to Yosemite
2575         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
2576         
2577         Unreviewed.
2578
2579         * BuildSlaveSupport/build.webkit.org-config/config.json:
2580
2581 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2582
2583         Update LeaksViewer from MountainLion to Yosemite
2584         
2585         Reviewed by Alexey Proskuryakov.
2586
2587         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2588         (LeaksViewer._displayURLPrompt):
2589
2590 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
2591
2592         Fix EWS python unit tests and address code comments as per 140476
2593         https://bugs.webkit.org/show_bug.cgi?id=140637
2594
2595         Reviewed by David Kilzer.
2596
2597         * Scripts/webkitpy/port/base.py:
2598         (Port):
2599         (Port.__init__):
2600         Adds DEFAULT_ARCHITECTURE member.
2601         (Port.architecture):
2602         Removes architecture member and instead uses
2603         self.get_option('architecture'). Also removes redundant architecture
2604         method.
2605         (Port.set_architecture):
2606         Adds a setter for the architecture variable to be able to set a flag
2607         upon modification.
2608         (Port.test_configuration):
2609         Uses self.architecture() instead of self._architecture.
2610         * Scripts/webkitpy/port/ios.py:
2611         Overrides DEFAULT_ARCHITECTURE.
2612         (IOSPort):
2613         (IOSPort.determine_full_port_name):
2614         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
2615         strip. Fixes regex to not match arbitrary characters after the
2616         relevent digits are matched.
2617         (IOSPort.__init__):
2618         Removes old _architecture defaulting strategy.
2619         (IOSPort._build_driver_flags):
2620         Uses self.architecture() instead of self._architecture.
2621         (IOSSimulatorPort):
2622         Overrides DEFAULT_ARCHITECTURE.
2623         (IOSSimulatorPort.__init__):
2624         Removes old _architecture defaulting strategy.
2625         * Scripts/webkitpy/port/mac.py:
2626         (MacPort):
2627         Overrides DEFAULT_ARCHITECTURE.
2628         (MacPort.__init__):
2629         Removes old _architecture defaulting strategy.
2630         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2631         (AbstractEarlyWarningSystem.run_command):
2632         Checks the did_override_architecture flag to determine whether to add
2633         the --architecture option.
2634         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2635         Uses ews.architecture rather than trying to discern the correct
2636         architecture using a port object.
2637         (EarlyWarningSystemTest._default_expected_logs):
2638         * Scripts/webkitpy/tool/commands/queues.py:
2639         Removes use of optparse, and removes the import statement.
2640         (AbstractQueue.__init__):
2641         (PatchProcessingQueue.begin_work_queue):
2642
2643 2015-01-20  Sam Weinig  <sam@webkit.org>
2644
2645         Attempt to fix Mountain Lion and EFL tests.
2646
2647         * WebKitTestRunner/TestController.cpp:
2648         (WTR::TestController::initialize):
2649         Disable Process-per-tab and network process on Mountain Lion and EFL.
2650
2651 2015-01-20  Darin Adler  <darin@apple.com>
2652
2653         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
2654         https://bugs.webkit.org/show_bug.cgi?id=140679
2655
2656         Reviewed by Anders Carlsson.
2657
2658         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2659         Removed a reference to SVGElementInstanceList.
2660
2661 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2662
2663         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
2664         https://bugs.webkit.org/show_bug.cgi?id=140028
2665
2666         Reviewed by Carlos Garcia Campos.
2667
2668         This won't work as expected, since this function is called before the
2669         WebViewTest constructor completes.
2670
2671         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2672
2673 2015-01-20  David Kilzer  <ddkilzer@apple.com>
2674
2675         configure-xcode-for-ios-development needs to update iPhoneOS SDK
2676         <http://webkit.org/b/140661>
2677
2678         Reviewed by Daniel Bates.
2679
2680         * Scripts/configure-xcode-for-ios-development: Add for() loop to
2681         run createXcodeSpecificationFilesForSDKIfNeeded() for both
2682         "iphoneos" and "iphonesimulator" SDKs.
2683         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
2684         the main body of the script.
2685
2686 2015-01-20  Tomas Popela  <tpopela@redhat.com>
2687
2688         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
2689         https://bugs.webkit.org/show_bug.cgi?id=139443
2690
2691         Reviewed by Carlos Garcia Campos.
2692
2693         Create the new test cases for setting the editable property on the web
2694         view and on the contenteditable enabled document. Also rework the
2695         current tests that are expecting that the web view is editable.
2696
2697         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2698         (loadTestHtml):
2699         (testWebViewEditorCutCopyPasteNonEditable):
2700         (testWebViewEditorCutCopyPasteEditable):
2701         (testWebViewEditorSelectAllNonEditable):
2702         (testWebViewEditorSelectAllEditable):
2703         (runEditorEditableCutTests):
2704         (testWebViewEditorEditableOnNonEditable):
2705         (testWebViewEditorEditableOnContentEditable):
2706         (testWebViewEditorNonEditable):
2707         (beforeAll):
2708         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2709         (WebViewTest::isEditable):
2710         (WebViewTest::setEditable):
2711
2712 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2713
2714         [GTK] Add an option to create WebKitWebView snapshots with transparent background
2715         https://bugs.webkit.org/show_bug.cgi?id=140617
2716
2717         Reviewed by Gustavo Noronha Silva.
2718
2719         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2720         (testWebViewSnapshot): Check that the same snapshot with
2721         transparent background is different than the default one filled
2722         with white.
2723
2724 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2725
2726         [GTK] Add API to change the WebKitWebView background color
2727         https://bugs.webkit.org/show_bug.cgi?id=140610
2728
2729         Reviewed by Gustavo Noronha Silva.
2730
2731         Add --bg-color command line option to MiniBrowser to be able to
2732         manually test the API passing any RGBA color to MiniBrowser.
2733         Also add a simple unit test to check that getting and setting
2734         colors from the API point of view.
2735
2736         * MiniBrowser/gtk/BrowserWindow.c:
2737         (browser_window_set_background_color):
2738         * MiniBrowser/gtk/BrowserWindow.h:
2739         * MiniBrowser/gtk/main.c:
2740         (createBrowserWindow):
2741         (parseBackgroundColor):
2742         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2743         (testWebViewBackgroundColor):
2744         (beforeAll):
2745
2746 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2747
2748         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
2749         https://bugs.webkit.org/show_bug.cgi?id=140665
2750
2751         Reviewed by Brian Burg.
2752
2753         * DumpRenderTree/win/UIDelegate.cpp:
2754         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
2755         match expected test output.
2756
2757 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
2758
2759         Remove the support for custom suffixes on ChangeLog
2760         https://bugs.webkit.org/show_bug.cgi?id=140648
2761
2762         Reviewed by David Kilzer.
2763
2764         Custom suffixes were used for the iOS branch of WebKit.
2765         Now that everything is opensource, there is no need for it.
2766
2767         * Scripts/VCSUtils.pm:
2768         (changeLogSuffix): Deleted.
2769         (changeLogFileName): Deleted.
2770         * Scripts/commit-log-editor:
2771         * Scripts/prepare-ChangeLog:
2772         (getLatestChangeLogs):
2773         (generateNewChangeLogs):
2774         (generateFileList):
2775         * Scripts/resolve-ChangeLogs:
2776         (findChangeLog):
2777
2778 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
2779
2780         Adjust naming of action menu SPI
2781         https://bugs.webkit.org/show_bug.cgi?id=140644
2782         <rdar://problem/19448129>
2783
2784         Reviewed by Brian Weinstein.
2785
2786         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2787         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2788         (TestWebKitAPI::TEST):
2789
2790 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2791
2792         [GTK] Generate the make dist manifest from a CMake template file
2793         https://bugs.webkit.org/show_bug.cgi?id=139387
2794
2795         Reviewed by Martin Robinson.
2796
2797         Remove the code that performs variable substitution on manifest.txt.
2798         Replace the custom variables used in that file with CMake variables.
2799
2800         * gtk/make-dist.py:
2801         (Manifest.add_directory):
2802         (Manifest.get_full_source_path):
2803         (Manifest.process_line):
2804         (Manifest.resolve_variables): Deleted.
2805         (Manifest.get_full_tarball_path): Deleted.
2806         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
2807
2808 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2809
2810         [Win] Correct merge error in last commit.
2811
2812         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2813         (findAccessibleObjectById): Undo accidental paste made during landing.
2814
2815 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2816
2817         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
2818         https://bugs.webkit.org/show_bug.cgi?id=139906
2819
2820         Reviewed by Dean Jackson.
2821
2822         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
2823         to use them. This patch fixes that.
2824
2825         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2826         (findAccessibleObjectById):
2827         (AccessibilityController::focusedElement):
2828         (logEventProc):
2829         (notificationListenerProc):
2830         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2831         (AccessibilityUIElement::getChildAtIndex):
2832         (AccessibilityUIElement::titleUIElement):
2833         (self):
2834         (AccessibilityUIElement::role):
2835         (AccessibilityUIElement::valueDescription):
2836         (accessibilityState):
2837         (AccessibilityUIElement::isChecked):
2838         * DumpRenderTree/win/DumpRenderTree.cpp:
2839         (dumpFrameScrollPosition):
2840         (dumpFramesAsText):
2841         * DumpRenderTree/win/PolicyDelegate.cpp:
2842         (PolicyDelegate::decidePolicyForNavigationAction):
2843         * DumpRenderTree/win/UIDelegate.cpp:
2844         (UIDelegate::exceededDatabaseQuota):
2845         * WinLauncher/Common.cpp:
2846         (setWindowText):
2847
2848 2015-01-19  Dean Jackson  <dino@apple.com>
2849
2850         Add "override" to fix the build with newer clangs.
2851
2852         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2853         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
2854
2855 2015-01-19  David Kilzer  <ddkilzer@apple.com>
2856
2857         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
2858         <http://webkit.org/b/140623>
2859
2860         Reviewed by Daniel Bates.
2861
2862         * Scripts/build-webkit: Update help for --device switch.
2863         * Scripts/webkitdirs.pm:
2864         (determineXcodeSDK): When passing --device, prefer the internal
2865         iOS SDK if it exists, else fall back to the external iOS SDK.
2866         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
2867         xcodebuild instead of trying to sanitize values.
2868
2869 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
2870
2871         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
2872         https://bugs.webkit.org/show_bug.cgi?id=140606
2873
2874         Reviewed by Csaba Osztrogonác.
2875
2876         * Scripts/webkitpy/bindings/main.py:
2877         (BindingsTests.generate_supplemental_dependency):
2878         (BindingsTests.main):
2879
2880 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2881
2882         [GTK] [WK2] TestWebKitWebView snapshot fails
2883         https://bugs.webkit.org/show_bug.cgi?id=120404
2884
2885         Reviewed by Žan Doberšek.
2886
2887         Rework the test to make sure the snapshot is always created at the
2888         desired size.
2889
2890         * Scripts/run-gtk-tests:
2891         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
2892         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2893         (testWebViewSnapshot): Use a fixed size for the document, and
2894         disable scrollbars to make sure the visible area is always the
2895         WebView size.
2896         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2897         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
2898         and height parameters to create the window with a given size.
2899         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2900
2901 2015-01-18  David Kilzer  <ddkilzer@apple.com>
2902
2903         iOS EWS queue name should be consistent
2904         <http://webkit.org/b/140585>
2905
2906         Reviewed by Daniel Bates.
2907
2908         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
2909         to 'ios'.
2910         * Scripts/webkitpy/common/config/ports.py: Ditto.
2911         (DeprecatedPort.port):
2912         (IOSPort):
2913         * Scripts/webkitpy/port/ios.py: Ditto.
2914         (IOSPort):
2915
2916         * Scripts/webkitpy/port/factory.py:
2917         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
2918         appears before ios.IOSPort.  If this is not done,
2919         `run-webkit-tests --ios-simulator` will get the wrong Port class
2920         (IOSPort instead of IOSSimulatorPort) due to the way that
2921         PortFactory.get() uses prefix matching of <Port>.port_name to
2922         find the correct class to use.
2923
2924 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
2925
2926         build.webkit.org/dashboard: OS X EWS is now on Mavericks
2927         https://bugs.webkit.org/show_bug.cgi?id=140595
2928
2929         Reviewed by Csaba Osztrogonác.
2930
2931         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2932         (BubbleQueueServer):
2933
2934 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2935
2936         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
2937
2938         * Scripts/webkitpy/port/ios.py:
2939         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
2940         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
2941         the Mountain Lion and Mavericks bots.
2942
2943 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2944
2945         Attempt to fix webkitpy tests on GTK Linux ports
2946
2947         * Scripts/webkitpy/port/ios.py:
2948         (IOSPort.determine_full_port_name): Set a sensible default if
2949         not running on a Mac platform or if no iOS SDK is installed.
2950
2951 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
2952
2953         Create iOS-EWS client queue
2954         https://bugs.webkit.org/show_bug.cgi?id=140476
2955
2956         Reviewed by Alexey Proskuryakov.
2957
2958         * EWSTools/start-queue-mac.sh:
2959         Adds call to configure-xcode-for-ios-development for iOS EWS.
2960         * Scripts/webkitpy/common/config/ews.json:
2961         Adds the iOS EWS config entry.
2962         * Scripts/webkitpy/common/config/ports.py:
2963         (DeprecatedPort.port):
2964         Adds IOSPort to the port map.
2965         (IOSPort):
2966         (IOSPort.build_webkit_command):
2967         Adds --sdk=iphoneos to the webkit build command.
2968         * Scripts/webkitpy/port/base.py:
2969         (Port.architecture):
2970         Adds an accessor for the architecture member variable.
2971         * Scripts/webkitpy/port/factory.py:
2972         (PortFactory):
2973         Adds IOSPort to the port class list.
2974         * Scripts/webkitpy/port/ios.py:
2975         Adds the IOSPort to encapsulate iOS-specific things.
2976         (IOSPort):
2977         (IOSPort.determine_full_port_name):
2978         (IOSPort.__init__):
2979         (IOSPort._build_driver_flags):
2980         (IOSPort.operating_system):
2981         * Scripts/webkitpy/tool/commands/download_unittest.py:
2982         Adds the archetecture option to the mock options.
2983         (DownloadCommandsTest._default_options):
2984         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2985         Appends the archetecture option into calls to webkit-patch.
2986         (AbstractEarlyWarningSystem.review_patch):
2987         (AbstractEarlyWarningSystem.run_command):
2988         (AbstractEarlyWarningSystem.load_ews_classes):
2989         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2990         Adds logic to soothe the unittest now that --architecture is being
2991         thrown around everywhere.
2992         (EarlyWarningSystemTest._default_expected_logs):
2993         * Scripts/webkitpy/tool/commands/queues.py:
2994         Adds glue code to ferry the --architecture option around.
2995         (AbstractQueue.__init__):
2996         (PatchProcessingQueue.begin_work_queue):
2997         * Scripts/webkitpy/tool/steps/abstractstep.py:
2998         Adds the archetecture option to all AbstractSteps so that
2999         EarlyWarningSystem doesn't start shoving --architecture into
3000         unsuspecting commands.
3001         (AbstractStep.options):
3002         * Scripts/webkitpy/tool/steps/build.py:
3003         Translates the --architecture option into an ARCHS= format to pass to
3004         build-webkit.
3005         (Build.build):
3006         * Scripts/webkitpy/tool/steps/options.py:
3007         Adds a definition for the --architecture option.
3008         (Options):
3009
3010 2015-01-16  Sam Weinig  <sam@webkit.org>
3011
3012         Add a basic configuration object for WKView
3013         https://bugs.webkit.org/show_bug.cgi?id=140559
3014
3015         Reviewed by Anders Carlsson.
3016
3017         Add tests for WKPageConfigurationRef.
3018
3019         * TestWebKitAPI/PlatformWebView.h:
3020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3021         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
3022         (TestWebKitAPI::TEST):
3023         (TestWebKitAPI::didFinishLoadForFrame):
3024         (TestWebKitAPI::setPageLoaderClient):
3025         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3026         (TestWebKitAPI::PlatformWebView::initialize):
3027         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3028
3029 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
3030
3031         WeakPtr functions crash when created with default constructor
3032         https://bugs.webkit.org/show_bug.cgi?id=140479
3033
3034         Reviewed by Andreas Kling.
3035
3036         Add WeakPtr API tests.
3037
3038         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3039         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
3040         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
3041
3042 2015-01-16  Chris Dumez  <cdumez@apple.com>
3043
3044         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
3045         https://bugs.webkit.org/show_bug.cgi?id=140568
3046
3047         Reviewed by Alexey Proskuryakov.
3048
3049         Fix the script parsing CSSPropertyNames.in to stop splitting lines
3050         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
3051         e.g. "Longhands=background-position-x|background-position-y".
3052         This would confuse the script and treat this as a CSS property:
3053         "background-position-x|background-position-y".
3054
3055         We now split on white space and treat the first string on the line
3056         to be the property name (this is the syntax in this file).
3057
3058         * Scripts/webkitpy/w3c/test_converter.py:
3059         (_W3CTestConverter.__init__):
3060         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
3061
3062 2015-01-16  Daniel Bates  <dabates@apple.com>
3063
3064         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
3065         https://bugs.webkit.org/show_bug.cgi?id=135589
3066
3067         Reviewed by David Kilzer.
3068
3069         Derived from a patch by David Farler.
3070
3071         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
3072         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
3073         in terms of the simctl command line utility.
3074
3075         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
3076         (eraseIOSSimulatorDevice): Added.
3077         (bootedIOSSimulatorDevice): Added.
3078         (iosSimulatorApplicationsPath): Added.
3079         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
3080         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
3081         (quitIOSSimulator): Added.
3082         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
3083         the specified name and currently selected iOS runtime.
3084         (isIOSSimulatorSystemInstalledApp): Added.
3085         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
3086         (deleteiOSSimulatorDevice): Deleted.
3087         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
3088         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
3089
3090 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
3091
3092         Resurrect the WinCairo bot.
3093         https://bugs.webkit.org/show_bug.cgi?id=139908
3094
3095         Reviewed by Csaba Osztrogonác.
3096
3097         * BuildSlaveSupport/build.webkit.org-config/config.json:
3098         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3099         (appendCustomBuildFlags):
3100         * BuildSlaveSupport/test-result-archive:
3101         (archiveTestResults):
3102         Add WinCairo buildbot.
3103
3104 2015-01-16  Chris Dumez  <cdumez@apple.com>
3105
3106         webkit-patch should auto-install the keyring python module
3107         https://bugs.webkit.org/show_bug.cgi?id=140547
3108
3109         Reviewed by David Kilzer.
3110
3111         Auto-install the keyring python module. This is the module that
3112         webkit-patch uses for cross-platform access to the keyring
3113         service.
3114
3115         Without this module, if the password if not in the keychain,
3116         webkit-patch will keep asking for your username / password and
3117         never remember them.
3118
3119         * Scripts/webkitpy/common/net/credentials.py:
3120         * Scripts/webkitpy/thirdparty/__init__.py:
3121         (AutoinstallImportHook.find_module):
3122         (AutoinstallImportHook._install_keyring):
3123
3124 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
3125
3126         Remove ENABLE(SQL_DATABASE) guards
3127         https://bugs.webkit.org/show_bug.cgi?id=140434
3128
3129         Reviewed by Darin Adler.
3130
3131         * Scripts/webkitperl/FeatureList.pm:
3132
3133 2015-01-15  Daniel Bates  <dabates@apple.com>
3134
3135         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
3136         https://bugs.webkit.org/show_bug.cgi?id=139685
3137         <rdar://problem/19281317>
3138
3139         Reviewed by Simon Fraser.
3140
3141         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
3142         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
3143
3144         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
3145         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
3146         before DRT dumps the output of a test. In particular, the WebThread may start a new page
3147         load (say, as a result of continued JavaScript execution), which will ultimately lead to
3148         dumping the test result again. Instead we want DRT to dump the test result synchronously
3149         such that we capture the state of the web page either when the page is loaded or when
3150         window.testRunner.notifyDone() is called.
3151
3152         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3153         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
3154         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
3155         flush CA transactions to the window.
3156         * DumpRenderTree/mac/DumpRenderTree.mm:
3157         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
3158         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
3159         (dump): Renamed; formerly named dumpTestResults().
3160         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
3161         enabling repaint support on iOS.
3162         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
3163         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
3164         (dumpTestResults): Deleted.
3165
3166 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
3167
3168         [Win] Miscellaneous DRT fixes
3169         https://bugs.webkit.org/show_bug.cgi?id=116562
3170
3171         Reviewed by Tim Horton.
3172
3173         While investigating the cause of several Windows crashes, I found:
3174         (1) Messy conversions to and from BSTR types
3175         (2) Weird mixes of wide-string and narrow string conversions
3176         (3) Passing nullptr to some CoreFoundation routines that do not
3177             permit null arguments.
3178         (4) Commands to link the executable to the VS2005 runtime.
3179
3180         This patch cleans up these issues to improve DRT reliability on
3181         Windows.
3182
3183         * DumpRenderTree/cg/ImageDiffCG.cpp:
3184         (main): Get rid of VS2005 runtime linking.
3185         * DumpRenderTree/win/DumpRenderTree.cpp:
3186         (urlSuitableForTestResult): Protect against being asked
3187         to process an empty URL.
3188         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
3189         than converting to/from wchar_t buffers.
3190         (runTest): Simplify string and BSTR handling.
3191         (createWebViewAndOffscreenWindow): Ditto.
3192         (main): Get rid of VS2005 runtime linking.
3193         * DumpRenderTree/win/TestRunnerWin.cpp:
3194         (jsStringRefToWString): Simplify code.
3195         (TestRunner::pathToLocalResource):
3196         (TestRunner::setUserStyleSheetLocation):
3197         * TestWebKitAPI/win/main.cpp: Get rid of
3198         VS2005 runtime linking.
3199         * win/DLLLauncher/DLLLauncherMain.cpp:
3200         (wWinMain): Ditto.
3201
3202 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
3203
3204         Stop hardcoding mac-mountainlion in commit queue
3205         https://bugs.webkit.org/show_bug.cgi?id=140492
3206
3207         Reviewed by Anders Carlsson.
3208
3209         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
3210         there should be no change in behavior, because:
3211         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
3212         using it to create a port object.
3213         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
3214         is actually correct to use "mac" for the name there. We only used to get the expected
3215         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
3216         for unknown deprecated port names.
3217
3218         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
3219
3220 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
3221
3222         Create iOS-EWS server queue
3223         https://bugs.webkit.org/show_bug.cgi?id=140473
3224
3225         Reviewed by Benjamin Poulain.
3226
3227         * QueueStatusServer/app.yaml: Updates the SVN version number.
3228         * QueueStatusServer/config/queues.py: Add ios-ews queue.
3229         * QueueStatusServer/model/queues.py:         
3230         (Queue.display_name): Makes sure the display name is pretty!
3231
3232 2015-01-14  Daniel Bates  <dabates@apple.com>
3233
3234         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
3235         https://bugs.webkit.org/show_bug.cgi?id=140301
3236         <rdar://problem/19389266>
3237
3238         Reviewed by Jon Honeycutt.
3239
3240         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
3241         with an unavailable runtime.
3242
3243         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3244         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
3245         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
3246         specified runtime cannot be used because it is unavailable.
3247         * Scripts/webkitpy/port/ios.py:
3248         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
3249         which was formerly named testing_device.
3250         * Scripts/webkitpy/xcode/simulator.py:
3251         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
3252         more robust than looking up the simulator device by name and runtime. This approach also
3253         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
3254         unavailable runtimes under the same iOS heading it would use to show it as available).
3255         (Simulator.find_device_by_udid): Added.
3256         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
3257         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
3258         (Simulator.available_runtimes): Added.
3259         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
3260         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
3261         first element of the sorted list is the runtime with the highest version number.
3262         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
3263
3264 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
3265
3266         Remove WK2 Windows cruft
3267         https://bugs.webkit.org/show_bug.cgi?id=140440
3268
3269         Reviewed by Anders Carlsson.
3270
3271         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
3272         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
3273         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
3274
3275 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
3276
3277         Fix TestWTF failed in TestWebKitAPI
3278         https://bugs.webkit.org/show_bug.cgi?id=140333
3279
3280         Reviewed by Sam Weinig.
3281
3282         Clear the std::ostringstream before starting test.
3283
3284         * TestWebKitAPI/Tests/WTF/RefLogger.h:
3285         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
3286
3287 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3288
3289         TestWebKitWebContext depends on British English spellcheck dictionary
3290         https://bugs.webkit.org/show_bug.cgi?id=140403
3291
3292         Reviewed by Martin Robinson.
3293
3294         Install all English hunspell dictionaries on Fedora and Arch.
3295
3296         * gtk/install-dependencies:
3297
3298 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3299
3300         [GTK] install-dependencies should grok dnf
3301         https://bugs.webkit.org/show_bug.cgi?id=140396
3302
3303         Reviewed by Martin Robinson.
3304
3305         Fedora: install dependencies with dnf if yum is not installed.
3306
3307         * gtk/install-dependencies:
3308
3309 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
3310
3311         [EFL][GTK] Fix build after r178309  
3312         https://bugs.webkit.org/show_bug.cgi?id=140381
3313
3314         Reviewed by Gyuyoung Kim.
3315
3316         * TestWebKitAPI/CMakeLists.txt: Added the API directory
3317
3318 2015-01-11  Sam Weinig  <sam@webkit.org>
3319
3320         Remove support for SharedWorkers
3321         https://bugs.webkit.org/show_bug.cgi?id=140344
3322
3323         Reviewed by Anders Carlsson.
3324
3325         * Scripts/webkitperl/FeatureList.pm:
3326
3327 2015-01-12  Anders Carlsson  <andersca@apple.com>
3328
3329         Make delegates conform to formal delegate protocols
3330         https://bugs.webkit.org/show_bug.cgi?id=140370
3331
3332         Reviewed by Dan Bernstein.
3333
3334         * DumpRenderTree/mac/TestRunnerMac.mm:
3335         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3336         (TestRunner::setGeolocationPermission):
3337
3338 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3339
3340         build-webkit: silence output of 'which'
3341         https://bugs.webkit.org/show_bug.cgi?id=140278
3342
3343         Reviewed by Daniel Bates.
3344
3345         Use a more elegent test for the existance of ninja and eclipse.
3346
3347         * Scripts/webkitdirs.pm:
3348         (commandExists): Don't assume the command supports --version
3349         (canUseNinja): Use commandExists()
3350         (canUseEclipse): Use commandExists()
3351
3352 2015-01-09  Sam Weinig  <sam@webkit.org>
3353
3354         Update the output format for run-api-tests
3355         https://bugs.webkit.org/show_bug.cgi?id=140332
3356
3357         Reviewed by Dan Bernstein.
3358
3359         Changes the output format for run-api-tests be a bit simpler (no longer 
3360         indented based on suite, as we were not really using suite very well) but
3361         also include details in the case of failure.
3362
3363         Changes verbose mode to no longer spew out the gtest default printer output,
3364         as the custom printer now includes the failure information.
3365
3366         * Scripts/run-api-tests:
3367         (runTestsBySuite):
3368         (runTest):
3369         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
3370         with colorized variants and strip out leaks spew (the leaks can be added back using
3371         the new --show-leaks argument).
3372
3373         * TestWebKitAPI/TestsController.cpp:
3374         (TestWebKitAPI::Printer::OnTestPartResult):
3375         (TestWebKitAPI::Printer::OnTestEnd):
3376         (TestWebKitAPI::TestsController::run):
3377         Implement a custom result printer that just prints out the information we want.
3378
3379 2015-01-09  Sam Weinig  <sam@webkit.org>
3380
3381         TestWebKitAPI should print out the lists that fail at the end
3382         https://bugs.webkit.org/show_bug.cgi?id=140329
3383
3384         Reviewed by Tim Horton.
3385
3386         * Scripts/run-api-tests:
3387         (runTestsBySuite):
3388         Print out failures and timeouts in all modes, not just verbose.
3389
3390 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
3391
3392         Make bmalloc work with ASan
3393         https://bugs.webkit.org/show_bug.cgi?id=140194
3394
3395         Reviewed by Mark Lam.
3396
3397         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
3398         ASan automatically (by forwarding to system malloc at runtime).
3399
3400 2015-01-09  Daniel Bates  <dabates@apple.com>
3401
3402         [iOS] Make DumpRenderTree build with public SDK
3403         https://bugs.webkit.org/show_bug.cgi?id=140311
3404
3405         Reviewed by Sam Weinig.
3406
3407         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
3408         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
3409         Additionally, remove unused header CoreGraphics/CGFontDB.h.
3410
3411         * DumpRenderTree/mac/DumpRenderTree.mm:
3412         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
3413
3414 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
3415
3416         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
3417         https://bugs.webkit.org/show_bug.cgi?id=140300
3418
3419         Reviewed by Simon Fraser.
3420
3421         * WebKitTestRunner/TestController.cpp:
3422         (WTR::TestController::createOtherPage):
3423         (WTR::TestController::updateWindowScaleForTest):
3424         (WTR::TestController::configureViewForTest):
3425         * WebKitTestRunner/TestController.h:
3426
3427 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3428
3429         Unreviewed. Moving myself to the committer section.
3430
3431         * Scripts/webkitpy/common/config/contributors.json:
3432
3433 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3434
3435         Add a script to check for platform layering violations
3436         https://bugs.webkit.org/show_bug.cgi?id=140248
3437
3438         Reviewed by Darin Adler.
3439
3440         It prints all the cases where files inside platform include
3441         headers that are not in platform directory.
3442
3443         * Scripts/check-for-platform-layering-violations: Added.
3444         (get_platform_headers):
3445         (check_source_file):
3446
3447 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3448
3449         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
3450         https://bugs.webkit.org/show_bug.cgi?id=139884
3451
3452         Reviewed by Tim Horton.
3453
3454         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
3455         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
3456         what the "nominal resolution" is, but this appears to work in practice.
3457
3458 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
3459
3460         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
3461         https://bugs.webkit.org/show_bug.cgi?id=140256
3462
3463         Reviewed by Anders Carlsson.
3464
3465         * DumpRenderTree/win/DumpRenderTree.cpp:
3466         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
3467         running with heap validation checks.
3468         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
3469         the "svg\\W3C-SVG-1.1" test directory.
3470         (removeFontFallbackIfPresent): Use nullptr instead of 0.
3471         * DumpRenderTree/win/TestRunnerWin.cpp:
3472         (TestRunner::clearPersistentUserStyleSheet): Ditto.
3473
3474 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3475
3476         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
3477         https://bugs.webkit.org/show_bug.cgi?id=140218
3478
3479         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
3480         Undone an accidental change - check for self.has_crashed() again. This code path
3481         is for ports that don't have a signal handler printing #CRASHED when main process
3482         crashes.
3483
3484         * Scripts/webkitpy/port/driver_unittest.py:
3485         (DriverTest.test_check_for_driver_crash.assert_crash):
3486         (DriverTest.test_check_for_driver_crash):
3487         Updated the tests, all changes are expected.
3488
3489 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3490
3491         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
3492         https://bugs.webkit.org/show_bug.cgi?id=140218
3493
3494         Reviewed by Darin Adler.
3495
3496         * Scripts/webkitpy/port/driver.py:
3497         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
3498         "process crashed" condition. These don't make sense together - it's either a crash
3499         or a timeout, and we should detect those properly at a much lower level.
3500         (Driver.run_test): Ditto.
3501         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
3502         cases.
3503
3504         * WebKitTestRunner/TestController.h:
3505         * WebKitTestRunner/TestController.cpp:
3506         (WTR::TestController::webProcessName): 
3507         (WTR::TestController::processDidCrash):
3508         Factored out hardcoded child process names, as we now use these in two places.
3509
3510         * WebKitTestRunner/TestInvocation.cpp:
3511         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
3512         process name, so that it can be sampled (fixes sampling on Mavericks and above).
3513
3514 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3515
3516         Reorder my list of email addresses, keeping the Bugzilla address at the
3517         top since Bugzilla and other webkitpy scripts rely on that ordering.
3518
3519         * Scripts/webkitpy/common/config/contributors.json:
3520
3521 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3522
3523         Moving myself to the reviewers section and updating
3524         the list of my email addresses.
3525
3526         * Scripts/webkitpy/common/config/contributors.json:
3527
3528 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3529
3530         [GTK] Build gtk-doc without gtkdoc-mktmpl
3531         https://bugs.webkit.org/show_bug.cgi?id=140225
3532
3533         Reviewed by Darin Adler.
3534
3535         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
3536         don't modify the tmpl files that it generates, it's not doing anything
3537         for us.
3538
3539         * gtk/gtkdoc.py:
3540         (GTKDoc.generate):
3541         (GTKDoc._run_gtkdoc_scangobj):
3542         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
3543
3544 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
3545
3546         [GTK][ThreadedCompositor] Add support for threaded compositor.
3547         https://bugs.webkit.org/show_bug.cgi?id=118265
3548
3549         Reviewed by Martin Robinson.
3550
3551         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
3552         autotools build systems. The feature is disabled by default.
3553         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
3554         from the feature flags.
3555
3556         * Scripts/webkitperl/FeatureList.pm:
3557
3558 2015-01-07  Daniel Bates  <dabates@apple.com>
3559
3560         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3561         https://bugs.webkit.org/show_bug.cgi?id=137371
3562
3563         Reviewed by David Kilzer.
3564
3565         Use SPI wrapper headers instead of directly referencing private SPI headers.
3566
3567         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3568         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3569         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3570         to the list of iOS header search directories so that we can include header UIKitSPI.h.
3571         * DumpRenderTree/mac/DumpRenderTree.mm:
3572         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3573         * DumpRenderTree/mac/EventSendingController.mm:
3574         * DumpRenderTree/mac/TestRunnerMac.mm:
3575
3576 2015-01-07  Commit Queue  <commit-queue@webkit.org>
3577
3578         Unreviewed, rolling out r178068.
3579         https://bugs.webkit.org/show_bug.cgi?id=140235
3580
3581         Breaks the iOS build (Requested by enrica on #webkit).
3582
3583         Reverted changeset:
3584
3585         "[iOS] Make WebKit2 build with public iOS SDK and more build
3586         fixes for DRT"
3587         https://bugs.webkit.org/show_bug.cgi?id=137371
3588         http://trac.webkit.org/changeset/178068
3589
3590 2015-01-07  Daniel Bates  <dabates@apple.com>
3591
3592         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3593         https://bugs.webkit.org/show_bug.cgi?id=137371
3594
3595         Reviewed by David Kilzer.
3596
3597         Use SPI wrapper headers instead of directly referencing private SPI headers.
3598
3599         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3600         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3601         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3602         to the list of header search directories so that we can include header UIKitSPI.h.
3603         * DumpRenderTree/mac/DumpRenderTree.mm:
3604         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3605         * DumpRenderTree/mac/EventSendingController.mm:
3606         * DumpRenderTree/mac/TestRunnerMac.mm:
3607
3608 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
3609
3610         [Win] Unreviewed test change to improve run reproducibility
3611
3612         * Scripts/webkitpy/port/win.py:
3613         (WinPort.default_child_processes): Run a single DRT instance to help
3614         identify failures caused by earlier test runs.
3615
3616 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3617
3618         Myles C. Maxfield is a reviewer now
3619         https://bugs.webkit.org/show_bug.cgi?id=140196
3620
3621         Reviewed by Dean Jackson.
3622
3623         * Scripts/webkitpy/common/config/contributors.json:
3624
3625 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3626
3627         Make webkit-patch try harder to find keychain credentials
3628         https://bugs.webkit.org/show_bug.cgi?id=140170
3629
3630         Reviewed by Ryosuke Niwa.
3631
3632         When the user manually enters a password into webkit-patch, we hand that off to the
3633         Keyring Python module. However, that module creates a generic password entry instead
3634         of an internet password entry. We should look for both kinds.
3635
3636         * Scripts/webkitpy/common/net/credentials.py:
3637         (Credentials._run_security_tool):
3638         (Credentials._credentials_from_keychain):
3639         * Scripts/webkitpy/common/net/credentials_unittest.py:
3640         (test_security_output_parse_entry_not_found):
3641         (_assert_security_call):
3642
3643 2015-01-06  Anders Carlsson  <andersca@apple.com>
3644
3645         Try to fix the Mountain Lion build