de36f8014caa2abe6e19ece79252872bc8c14bb3
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-16  Sam Weinig  <sam@webkit.org>
2
3         Fix fallout after r148545.
4
5         * WebKitTestRunner/TestController.cpp:
6         (WTR::TestController::resetStateToConsistentValues):
7         Remove calls to non-existent API functions.
8
9 2013-04-13  Roger Fong  <roger_fong@apple.com>
10
11         Unreviewed. Disable WinEWS tests, simply not enough bots.
12
13         All bots are running consistently now but the queue still keeps growing.
14         Until we get more bots or make the tests faster, it doesn't seem wise to keep running tests.
15
16         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
17         (WinEWS):
18
19 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
20
21         The list of contributors in committers.py should be a separate JSON
22         https://bugs.webkit.org/show_bug.cgi?id=114673
23
24         Reviewed by Anders Carlsson.
25
26         Added webkitpy/common/config/contributors.json, made CommitterList load it.
27
28         * EWSTools/start-queue-mac.sh:
29         * EWSTools/start-queue.sh:
30         * Scripts/webkitpy/common/checkout/commitinfo.py:
31         (CommitInfo.committer):
32         * Scripts/webkitpy/common/config/contributors.json: Added.
33         * Scripts/webkitpy/common/config/committers.py:
34         (Reviewer.__init__):
35         (CommitterList.__init__):
36         (CommitterList.load_json): Added.
37         (CommitterList.load_json.emails):
38         (CommitterList.load_json.nicks):
39         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
40         (MockCommitInfo.author):
41
42 2013-04-16  Manuel Rego Casasnovas  <rego@igalia.com>
43
44         [EFL] Bump libsoup dependency to 2.42.0
45         https://bugs.webkit.org/show_bug.cgi?id=113927
46
47         Reviewed by Gyuyoung Kim.
48
49         Update libsoup required version to v2.42.0 and GLib to v2.36.0 as
50         required by libsoup for EFL port.
51
52         * efl/jhbuild.modules:
53         * efl/patches/libsoup-2.40-auth-fix.patch: Removed as it's already
54         included in v2.42.0.
55
56 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
57
58         Remove Account class from committers.py
59         https://bugs.webkit.org/show_bug.cgi?id=114671
60
61         Reviewed by Csaba Osztrogonác.
62
63         Account class was added to support watch list email addresses that are not associated with
64         a particular contributor but nobody uses these email address since Chromium port forked.
65
66         Remove it.
67
68         Also removed account_by_login from CommitterList since it was never called except its unittests.
69
70         * Scripts/webkitpy/common/checkout/changelog.py:
71         * Scripts/webkitpy/common/config/committers.py:
72         (Contributor):
73         (Contributor.matches_glob):
74         (Reviewer.__init__):
75         (CommitterList.__init__):
76         (CommitterList._email_to_account_map):
77         (CommitterList._login_to_account_map):
78         (CommitterList.contributors_by_fuzzy_match):
79         (CommitterList.contributor_by_email):
80         (CommitterList.contributor_by_name):
81         (CommitterList.committer_by_email):
82         (CommitterList.reviewer_by_email):
83         * Scripts/webkitpy/common/config/committers_unittest.py:
84         (CommittersTest.test_committer_lookup):
85         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
86         (Bugzilla._commit_queue_flag):
87         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
88         (test_commit_queue_flag):
89         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
90         (WatchListParser._validate):
91
92 2013-04-16  Mike West  <mkwst@chromium.org>
93
94         Unreviewed update to the watchlist.
95
96         Removing 'mkwst+watchlist@chromium.org' from committers.py and the
97         watchist file; moving to 'mkwst@chromium.org' instead.
98
99         * Scripts/webkitpy/common/config/committers.py:
100         * Scripts/webkitpy/common/config/watchlist:
101
102 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
103
104         Move webkitpy.layout_tests.port to webkitpy.port
105         https://bugs.webkit.org/show_bug.cgi?id=114668
106
107         Reviewed by Maciej Stachowiak.
108
109         Moved. Port objects knows a lot more than just layout_tests. They doesn't belong down in layout_tests.
110
111         * Scripts/webkitpy/common/host.py:
112         * Scripts/webkitpy/common/host_mock.py:
113         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
114         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
115         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
116         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
117         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
118         * Scripts/webkitpy/layout_tests/port: Removed.
119         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
120         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
121         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
122         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
123         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
124         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
125         * Scripts/webkitpy/performance_tests/perftest.py:
126         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
127         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
128         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
129         * Scripts/webkitpy/port: Copied from Tools/Scripts/webkitpy/layout_tests/port.
130         * Scripts/webkitpy/port/apple.py:
131         * Scripts/webkitpy/port/base.py:
132         * Scripts/webkitpy/port/base_unittest.py:
133         * Scripts/webkitpy/port/config_unittest.py:
134         (ConfigTest.test_default_configuration__standalone):
135         * Scripts/webkitpy/port/driver_unittest.py:
136         * Scripts/webkitpy/port/efl.py:
137         * Scripts/webkitpy/port/efl_unittest.py:
138         * Scripts/webkitpy/port/factory.py:
139         * Scripts/webkitpy/port/factory_unittest.py:
140         * Scripts/webkitpy/port/gtk.py:
141         * Scripts/webkitpy/port/gtk_unittest.py:
142         * Scripts/webkitpy/port/image_diff.py:
143         * Scripts/webkitpy/port/image_diff_unittest.py:
144         * Scripts/webkitpy/port/leakdetector_unittest.py:
145         * Scripts/webkitpy/port/mac.py:
146         * Scripts/webkitpy/port/mac_unittest.py:
147         * Scripts/webkitpy/port/mock_drt.py:
148         * Scripts/webkitpy/port/mock_drt_unittest.py:
149         * Scripts/webkitpy/port/port_testcase.py:
150         * Scripts/webkitpy/port/qt.py:
151         * Scripts/webkitpy/port/qt_unittest.py:
152         * Scripts/webkitpy/port/server_process_unittest.py:
153         * Scripts/webkitpy/port/test.py:
154         * Scripts/webkitpy/port/win.py:
155         * Scripts/webkitpy/port/win_unittest.py:
156         * Scripts/webkitpy/port/xvfbdriver.py:
157         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
158         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
159         * Scripts/webkitpy/tool/commands/gardenomatic.py:
160         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
161         * Scripts/webkitpy/tool/commands/queries.py:
162         * Scripts/webkitpy/tool/commands/queries_unittest.py:
163         * Scripts/webkitpy/tool/commands/rebaseline.py:
164         * Scripts/webkitpy/tool/servers/gardeningserver.py:
165         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
166         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
167         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
168
169 2013-04-16  Commit Queue  <rniwa@webkit.org>
170
171         Unreviewed, rolling out r148498.
172         http://trac.webkit.org/changeset/148498
173         https://bugs.webkit.org/show_bug.cgi?id=114669
174
175         Appears to have broken EWS (Requested by rniwa on #webkit).
176
177         * Scripts/webkitpy/common/config/ews.json: Removed.
178         * Scripts/webkitpy/tool/commands/__init__.py:
179         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
180         (AbstractEarlyWarningSystem):
181         (AbstractEarlyWarningSystem.__init__):
182         (AbstractEarlyWarningSystem.handle_script_error.does):
183         (GtkEWS):
184         (GtkWK2EWS):
185         (EflEWS):
186         (QtEWS):
187         (QtWK2EWS):
188         (WinEWS):
189         (MacEWS):
190         (MacWK2EWS):
191         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
192         (EarlyWarningSystemTest._default_expected_logs):
193         (_test_ews):
194         (test_ewses):
195
196 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
197
198         Isolate Early Warning System definitions into a JSON
199         https://bugs.webkit.org/show_bug.cgi?id=114558
200
201         Reviewed by Benjamin Poulain.
202
203         Added ews.json to common/config, and made tool/commands/__init__.py call
204         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
205
206         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
207         * Scripts/webkitpy/tool/commands/__init__.py:
208         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
209         (AbstractEarlyWarningSystem):
210         (AbstractEarlyWarningSystem.__init__):
211         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
212         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
213         (EarlyWarningSystemTest._default_expected_logs):
214         (_test_ews):
215         (test_ewses):
216
217 2013-04-15  Ryosuke Niwa  <rniwa@webkit.org>
218
219         WKR gets stuck when there are many merges
220         https://bugs.webkit.org/show_bug.cgi?id=114632
221
222         Reviewed by Andreas Kling.
223
224         Move the last revision forward when it exists in a branch.
225         Otherwise, we'll be stuck looping over revisions made to merge patches.
226
227         * Scripts/webkitpy/tool/commands/newcommitbot.py:
228         (NewCommitBot.next_work_item):
229
230 2013-04-15  Gustavo Noronha Silva  <gns@gnome.org>
231
232         [GTK] Missing a few packages for building on stock Fedora
233         https://bugs.webkit.org/show_bug.cgi?id=113916
234
235         Reviewed by Philippe Normand.
236
237         * gtk/install-dependencies: add packages that are missing.
238
239 2013-04-15  Zan Dobersek  <zdobersek@igalia.com>
240
241         REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
242         https://bugs.webkit.org/show_bug.cgi?id=114602
243
244         Reviewed by Ryosuke Niwa.
245
246         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
247         (CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
248         interface so its value doesn't leak into the following tests.
249
250 2013-04-15  Zan Dobersek  <zandobersek@gmail.com>
251
252         Deprecate land-cowboy in favor of land-cowhand
253         https://bugs.webkit.org/show_bug.cgi?id=104470
254
255         Reviewed by Darin Adler.
256
257         Move the LandCowboy command implementation under the LandCowhand command and deprecate the former.
258
259         * Scripts/webkitpy/tool/commands/download.py:
260         (LandCowhand):
261         (LandCowboy):
262         (LandCowboy._prepare_state):
263         * Scripts/webkitpy/tool/commands/download_unittest.py:
264         (test_land_cowhand): Adjust the unit tests by testing both LandCowhand and LandCowboy,
265         also checking the deprecation message in the output of the latter.
266
267 2013-04-15  Jonathan Liu  <net147@gmail.com>
268
269         Improve Windows cmd.exe detection
270         https://bugs.webkit.org/show_bug.cgi?id=114620
271
272         Reviewed by Jocelyn Turcotte.
273
274         The current detection code handles Windows cmd.exe and Cygwin shell
275         but not does not handle MSYS shell correctly. Simplify and improve the
276         detection by checking MINGW_IN_SHELL instead as used in other places
277         (e.g. qt_functions.prf).
278
279         * qmake/mkspecs/features/default_pre.prf:
280
281 2013-04-15  Manuel Rego Casasnovas  <rego@igalia.com>
282
283         [webkitpy] Use $NUMBER_OF_PROCESSORS in Executive.cpu_count()
284         https://bugs.webkit.org/show_bug.cgi?id=114506
285
286         Reviewed by Philippe Normand.
287
288         * Scripts/webkitpy/common/system/executive.py:
289         (Executive.cpu_count): Modify function in order to use the environment
290         variable $NUMBER_OF_PROCESSORS if it is defined and it is an integer
291         greater than 0.
292
293 2013-04-15  Xan Lopez  <xlopez@igalia.com>
294
295         [BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
296         https://bugs.webkit.org/show_bug.cgi?id=114615
297
298         Reviewed by Carlos Garcia Campos.
299
300         Enable the style scoped feature if we have support for it.
301
302         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
303         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
304
305 2013-04-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
306
307         [Qt] QtMultimedia not used when GStreamer is not found
308         https://bugs.webkit.org/show_bug.cgi?id=111842
309
310         Reviewed by Philippe Normand.
311
312         Fallback to using QtMultimedia when native libraries are not found.
313
314         * qmake/mkspecs/features/features.prf:
315
316 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
317
318         Build fix attempt for webkitbot. Unicodify everything.
319
320         * Scripts/webkitpy/tool/bot/irc_command.py:
321         (Whois.execute):
322
323 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
324
325         webkitbot should provide full name, email address, and IRC nicknames on whois
326         https://bugs.webkit.org/show_bug.cgi?id=114494
327
328         Reviewed by Benjamin Poulain.
329
330         A response like the one below is useless. Improve it:
331         webkitbot: rniwa: zdobersek is zdobersek (zandobersek@gmail.com). Why do you ask?
332
333         We now report full name, email address, committer/reviewer status, and IRC nickname.
334
335         Also teach webkitbot how to respond to ping.
336
337         * Scripts/webkitpy/tool/bot/irc_command.py:
338         (PingPong): Moved 
339         (PingPong.execute):
340         (Whois._full_record_and_nick): Renamed and rewritten.
341         (Whois.execute):
342
343         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
344         (IRCCommandTest.test_whois): Updated test cases as needed.
345
346         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
347         (IRCBotTest.test_help): Added ping.
348
349         * Scripts/webkitpy/tool/commands/newcommitbot.py:
350         (NewCommitBot): Teached WKR how to respond to hi.
351
352 2013-04-13  Anders Carlsson  <andersca@apple.com>
353
354         Add form delegate method that's invoked right before sending a submit event to a form element
355         https://bugs.webkit.org/show_bug.cgi?id=114575
356
357         Reviewed by Dan Bernstein.
358
359         Add a test.
360
361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
362         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm: Added.
363         (-[FormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
364         (TestWebKitAPI):
365         (TestWebKitAPI::TEST):
366         
367         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
368         (TestWebKitAPI::Util::toSTD):
369         Don't crash when a null NSString is passed to toSTD.
370
371 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
372
373         Python test fix attempt after r148360.
374
375         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
376         (test_command_help):
377
378 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
379
380         Merge AbstractDeclarativeCommand into Command as a comment suggests
381         https://bugs.webkit.org/show_bug.cgi?id=114559
382
383         Reviewed by Antti Koivisto.
384
385         Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
386         We need to merge a lot more classes to make webkitpy hackable.
387
388         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
389         (AbstractLocalServerCommand):
390         (AbstractLocalServerCommand.__init__):
391         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
392         (AbstractSequencedCommand):
393         (AbstractSequencedCommand.__init__):
394         * Scripts/webkitpy/tool/commands/adduserstogroups.py:
395         (AddUsersToGroups):
396         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
397         (AnalyzeChangeLog):
398         (AnalyzeChangeLog.__init__):
399         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
400         * Scripts/webkitpy/tool/commands/bugfortest.py:
401         (BugForTest):
402         * Scripts/webkitpy/tool/commands/bugsearch.py:
403         (BugSearch):
404         * Scripts/webkitpy/tool/commands/chromechannels.py:
405         (ChromeChannels):
406         (__init__):
407         * Scripts/webkitpy/tool/commands/download.py:
408         (AbstractPatchProcessingCommand):
409         * Scripts/webkitpy/tool/commands/findusers.py:
410         (FindUsers):
411         * Scripts/webkitpy/tool/commands/openbugs.py:
412         (OpenBugs):
413         * Scripts/webkitpy/tool/commands/queries.py:
414         (BugsToCommit):
415         (PatchesInCommitQueue):
416         (PatchesToCommitQueue):
417         (PatchesToCommitQueue.__init__):
418         (PatchesToReview):
419         (PatchesToReview.__init__):
420         (PatchesToReview.execute):
421         (WhatBroke):
422         (ResultsFor):
423         (FailureReason):
424         (FindFlakyTests):
425         (TreeStatus):
426         (CrashLog):
427         (PrintExpectations):
428         (PrintExpectations.__init__):
429         (PrintBaselines):
430         (PrintBaselines.__init__):
431         * Scripts/webkitpy/tool/commands/queues.py:
432         (AbstractQueue.__init__):
433         * Scripts/webkitpy/tool/commands/rebaseline.py:
434         (AbstractRebaseliningCommand):
435         * Scripts/webkitpy/tool/commands/suggestnominations.py:
436         (SuggestNominations):
437         (SuggestNominations.__init__):
438         * Scripts/webkitpy/tool/commands/upload.py:
439         (CommitMessageForCurrentDiff):
440         (CommitMessageForCurrentDiff.__init__):
441         (CleanPendingCommit):
442         (CleanReviewQueue):
443         (AssignToCommitter):
444         (PostCommits):
445         (PostCommits.__init__):
446         (MarkBugFixed):
447         (MarkBugFixed.__init__):
448         (CreateBug):
449         (CreateBug.__init__):
450         * Scripts/webkitpy/tool/multicommandtool.py:
451         (Command):
452         (Command.__init__):
453         (Command.main):
454         (HelpCommand):
455         (HelpCommand.__init__):
456         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
457         (TrivialCommand):
458         (TrivialCommand.__init__):
459         (LikesToRetry):
460         (LikesToRetry.__init__):
461         (CommandTest.test_name_with_arguments):
462         (CommandTest.test_required_arguments):
463         (test_command_help):
464
465 2013-04-13  Ed Bartosh  <bartosh@gmail.com>
466
467         [EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
468         https://bugs.webkit.org/show_bug.cgi?id=114048
469
470         Reviewed by Gyuyoung Kim.
471
472         Wrapped view media related code in #if ENABLE(VIEW_MODE_CSS_MEDIA)
473
474         * DumpRenderTree/efl/TestRunnerEfl.cpp:
475         (TestRunner::setViewModeMediaFeature):
476
477 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
478
479         Merge watchlistloader into host since it's an unnecessary indirection
480         https://bugs.webkit.org/show_bug.cgi?id=114555
481
482         Reviewed by Antti Koivisto.
483
484         We don't need a class to load a file.
485
486         * Scripts/webkitpy/common/host.py:
487         (Host.watch_list):
488         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Removed.
489         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Removed.
490
491 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
492
493         Rename JSONResultsGeneratorBase to JSONResultsGenerator
494         https://bugs.webkit.org/show_bug.cgi?id=114553
495
496         Reviewed by Philippe Normand.
497
498         Renamed now that we've got rid of the old JSONResultsGenerator in r148352.
499
500         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
501         (JSONLayoutResultsGenerator):
502         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
503         (JSONResultsGenerator):
504         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
505         (JSONGeneratorTest._test_json_generation):
506         (JSONGeneratorTest._verify_json_results):
507
508 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
509
510         Remove more Chromium specific code from webkitpy
511         https://bugs.webkit.org/show_bug.cgi?id=114552
512
513         Reviewed by Philippe Normand.
514
515         * Scripts/webkitpy/common/host.py:
516         (Host.checkout):
517         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
518         (JSONResultsGeneratorBase):
519         (JSONResultsGeneratorBase.__init__):
520         (JSONResultsGeneratorBase._is_results_all_of_type):
521         * Scripts/webkitpy/layout_tests/port/base.py:
522         (Port):
523         (Port.expected_filename):
524         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
525         (PerfTestsRunner._parse_args):
526         * Scripts/webkitpy/tool/commands/queues.py:
527         (PatchProcessingQueue._new_port_name_from_old):
528         (CommitQueue.did_pass_testing_ews):
529         * Scripts/webkitpy/tool/commands/rebaseline.py:
530         (RebaselineTest._results_url):
531         (Rebaseline._builder_with_name):
532         * Scripts/webkitpy/tool/mocktool.py:
533         (MockTool.irc):
534
535 2013-04-13  Zan Dobersek  <zdobersek@igalia.com>
536
537         Fix flakiness dashboard unit test failures
538         https://bugs.webkit.org/show_bug.cgi?id=114518
539
540         Reviewed by Ryosuke Niwa.
541
542         Fix the current failures in unit tests for the flakiness dashboard by adjusting failing
543         test cases to simulate loading the builders list from the webkit.org build master, replacing
544         the Chromium builders and platforms that are used in tests with builders and platforms for the
545         Apple Mac Lion WebKit2 port, and removing two test cases that were testing Chromium-specific
546         functionality of the dashboard.
547
548         This is sort of an interlude to the flakiness dashboard cleanup, with the removal of Chromium-specific
549         code and hopefully general simplification of the dashboard codebase coming in near future.
550
551         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
552         (resetGlobals):
553         (test):
554         * TestResultServer/static-dashboards/loader_unittests.js:
555
556 2013-04-12  David Kilzer  <ddkilzer@apple.com>
557
558         BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS
559
560         Reviewed by Chris Fleizach.
561
562         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Declare
563         -_accessibilityPath from the WebAccessibilityObjectWrapper
564         class.
565         (_CGPathEnumerationIteration): Remove unused CGPoint* variable.
566
567 2013-04-12  Jeffrey Pfau  <jpfau@apple.com>
568
569         Unreviewed, remove an old email address for myself.
570
571         * Scripts/webkitpy/common/config/committers.py:
572
573 2013-04-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
574
575         [WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
576         https://bugs.webkit.org/show_bug.cgi?id=110743
577
578         Reviewed by Benjamin Poulain.
579
580         Adding a new test file to check if loading a page just after WebProcess
581         has crashed (or was terminated) works. The test executes the
582         following steps (Load, Crash, Load), thus stressing WebProcess
583         reattach and process termination code path.
584
585         * TestWebKitAPI/GNUmakefile.am:
586         * TestWebKitAPI/PlatformEfl.cmake:
587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
588         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
589         (TestWebKitAPI::setPageLoaderClient):
590         (TestWebKitAPI::TEST):
591         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Added.
592         (TestWebKitAPI):
593         (WebKit2CrashLoader):
594         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
595         (TestWebKitAPI::WebKit2CrashLoader::loadUrl):
596         (TestWebKitAPI::WebKit2CrashLoader::crashWebProcess):
597         (TestWebKitAPI::didFinishLoad):
598         (TestWebKitAPI::TEST):
599         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
600
601 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
602
603         [Mac] REGRESSION: Auto substitution strips new lines
604         https://bugs.webkit.org/show_bug.cgi?id=114537
605
606         Reviewed by Enrica Casucci.
607
608         Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.
609
610         * DumpRenderTree/mac/DumpRenderTree.mm:
611         (resetDefaultsToConsistentValues):
612
613 2013-04-09  Roger Fong  <roger_fong@apple.com>
614
615         Re-enable WinEWS tests.
616
617         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
618         (WinEWS):
619
620 2013-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
621
622         [GTK] Split GtkAuthenticationDialog in two widgets
623         https://bugs.webkit.org/show_bug.cgi?id=103644
624
625         Reviewed by Xan Lopez.
626
627         * gtk/generate-gtkdoc:
628         (get_webkit2_options): Do not generate api docs for
629         WebKitAuthenticationDialog which is private in WebKit2.
630         (get_webkit1_options): Do not generate api docs for
631         webkitauthenticationdialog which is private in WebKit1.
632
633 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
634
635         WebKit Queues should capitalize K in Wk2
636         https://bugs.webkit.org/show_bug.cgi?id=114524
637
638         Reviewed by Philippe Normand.
639
640         * QueueStatusServer/model/queues.py:
641         (Queue.display_name):
642
643 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
644
645         [Mac] Enable spellchecking tests added in r141471
646         https://bugs.webkit.org/show_bug.cgi?id=108525
647
648         Reviewed by Darin Adler.
649
650         * DumpRenderTree/mac/DumpRenderTree.mm:
651         (createWebViewAndOffscreenWindow):
652         (resetDefaultsToConsistentValues):
653         * WebKitTestRunner/TestController.cpp:
654         (WTR::TestController::resetStateToConsistentValues):
655
656 2013-04-12  Manuel Rego Casasnovas  <rego@igalia.com>
657
658         [GTK] Enable WebKit2 building on GTK EWSs
659         https://bugs.webkit.org/show_bug.cgi?id=114500
660
661         Reviewed by Philippe Normand.
662
663         Add configuration in order to be able to setup GTK EWSs building
664         WebKit2. A new queue gtk-wk2-ews is added.
665
666         * QueueStatusServer/config/queues.py:
667         * Scripts/webkitpy/common/config/ports.py:
668         (DeprecatedPort.port):
669         (GtkWK2Port):
670         (GtkWK2Port.build_webkit_command):
671         (GtkWK2Port.run_webkit_tests_command):
672         * Scripts/webkitpy/common/config/ports_unittest.py:
673         (DeprecatedPortTest.test_gtk_port):
674         (DeprecatedPortTest):
675         (DeprecatedPortTest.test_gtk_wk2_port):
676         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
677         (GtkWK2EWS):
678
679 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
680
681         Remove Chromium scripts
682         https://bugs.webkit.org/show_bug.cgi?id=114492
683
684         Reviewed by Benjamin Poulain.
685
686         * Scripts/run-chromium-webkit-unit-tests: Removed.
687         * Scripts/update-webkit-chromium: Removed.
688
689 2013-04-12  Commit Queue  <rniwa@webkit.org>
690
691         Unreviewed, rolling out r148262.
692         http://trac.webkit.org/changeset/148262
693         https://bugs.webkit.org/show_bug.cgi?id=114493
694
695         Cairo dep should now build, rolling r148247 back in (Requested
696         by zdobersek on #webkit).
697
698         * Scripts/webkitdirs.pm:
699         (buildAutotoolsProject):
700         * gtk/jhbuild.modules:
701
702 2013-04-11  Commit Queue  <rniwa@webkit.org>
703
704         Unreviewed, rolling out r148247.
705         http://trac.webkit.org/changeset/148247
706         https://bugs.webkit.org/show_bug.cgi?id=114490
707
708         Cairo dep fails to build on builders due to missing EGL
709         headers (Requested by zdobersek on #webkit).
710
711         * Scripts/webkitdirs.pm:
712         (buildAutotoolsProject):
713         * gtk/jhbuild.modules:
714
715 2013-04-11  Martin Robinson  <mrobinson@igalia.com>
716
717         [GTK] Add accelerated 2D canvas support using cairo-gl
718         https://bugs.webkit.org/show_bug.cgi?id=104672
719
720         Reviewed by Alejandro G. Castro.
721
722         Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
723         dependencies, don't override value of the setting determined by configure.
724         This will make it easier for people using build-webkit, but not the
725         WebKit JHBuild.
726
727         * Scripts/webkitdirs.pm:
728         (buildAutotoolsProject): Add a blacklist for settings to never override.
729         * gtk/jhbuild.modules: Build CairoGL.
730
731 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
732
733         build.webkit.org should link to webkit-queues instead of webkit-commit-queue
734         https://bugs.webkit.org/show_bug.cgi?id=114477
735
736         Reviewed by Benjamin Poulain.
737
738         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
739
740 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
741
742         Leaks builder should not be triggered upon new commits
743         https://bugs.webkit.org/show_bug.cgi?id=114475
744
745         Reviewed by Jessie Berlin.
746
747         Don't trigger them on new checkins. Wait for Mountain Lion (Build), which already triggers
748         the leak builder when builds are done.
749
750         * BuildSlaveSupport/build.webkit.org-config/config.json:
751
752 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
753
754         [GTK] Windows build failure after r136056
755         https://bugs.webkit.org/show_bug.cgi?id=114121
756
757         Reviewed by Martin Robinson.
758
759         * TestWebKitAPI/config.h: Make sure defines are correct for other
760         Windows ports than apple-win.
761
762 2013-04-11  Ojan Vafai  <ojan@chromium.org>
763
764         Remove myself from watchlists.
765         * Scripts/webkitpy/common/config/watchlist:
766
767 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
768
769         Build fix. Don't hard-code queues.webkit.org at least during the transition.
770
771         * QueueStatusServer/templates/statusbubble.html:
772
773 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
774
775         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
776         https://bugs.webkit.org/show_bug.cgi?id=114397
777
778         Reviewed by Benjamin Poulain.
779
780         Reland the patch since Alan appears to have finished the migration.
781
782         * Scripts/webkitpy/common/net/statusserver.py:
783         (StatusServer):
784
785 2013-04-11  Brian Holt  <brian.holt@samsung.com>
786
787         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
788         https://bugs.webkit.org/show_bug.cgi?id=76796
789
790         Reviewed by Chris Fleizach.
791
792         Make the Gtk window for the DRT a toplevel so that it gets the
793         focus from the window manager when the test starts.
794
795         * DumpRenderTree/gtk/DumpRenderTree.cpp:
796         (main):
797
798 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
799
800         Use CSS4 image-rendering to determing image scaling quality
801         https://bugs.webkit.org/show_bug.cgi?id=113405
802
803         Reviewed by Simon Fraser.
804
805         Introduce new flag to enable experimental support for CSS4 Images.
806
807         * Scripts/webkitperl/FeatureList.pm:
808
809 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
810
811         Remove code for Chromium from wkbuild.py
812         https://bugs.webkit.org/show_bug.cgi?id=114423
813
814         Reviewed by Benjamin Poulain.
815
816         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
817         (_should_file_trigger_build):
818         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
819         (ShouldBuildTest):
820
821 2013-04-11  Philippe Normand  <pnormand@igalia.com>
822
823         Unreviewed, update my IRC nickname.
824
825         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
826
827 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
828
829         Remove the rest of Chromium code from webkitpy
830         https://bugs.webkit.org/show_bug.cgi?id=114420
831
832         Reviewed by Benjamin Poulain.
833
834         * Scripts/webkitpy/common/config/urls.py:
835         (view_revision_url):
836         * Scripts/webkitpy/common/host.py:
837         (Host._engage_awesome_locale_hacks):
838         (Host.initialize_scm):
839         (Host):
840         * Scripts/webkitpy/common/host_mock.py:
841         (MockHost.__init__):
842         (MockHost.checkout):
843         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
844         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
845         (JSONResultsGeneratorBase._insert_generic_metadata):
846         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
847         (TestExpectationParser._tokenize_line):
848         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
849         (ExpectationSyntaxTests.test_bare_name_and_bugs):
850         (ExpectationSyntaxTests.test_warnings):
851         * Scripts/webkitpy/layout_tests/port/base.py:
852         (Port.skips_perf_test):
853         (Port.path_to_test_expectations_file):
854         (Port._port_flag_for_scripts):
855         * Scripts/webkitpy/style/checkers/cpp.py:
856         (check_function_definition):
857         (check_include_line):
858         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
859         (OrderOfIncludesTest.test_check_wtf_includes):
860         (WebKitStyleTest.test_webkit_export_check):
861         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
862         (TestExpectationsTestCase.test_valid_expectations):
863         * Scripts/webkitpy/tool/bot/irc_command.py:
864         (Rollout.execute):
865         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
866         (IRCCommandTest.test_whois):
867         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
868         (IRCBotTest.test_help):
869         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
870         (SheriffBotTest.test_command_aliases):
871
872 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
873
874         roll-chromium-deps doesn't roll DEPS
875         https://bugs.webkit.org/show_bug.cgi?id=114421
876
877         Reviewed by Antti Koivisto.
878
879         Roll DEPS. Rolling DEPS. Rolled DEPS.
880
881         * Scripts/webkitpy/tool/bot/irc_command.py:
882         (RollChromiumDEPS.execute):
883
884 2013-04-11  Glenn Adams  <glenn@skynav.com>
885
886         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
887         https://bugs.webkit.org/show_bug.cgi?id=114418
888
889         Reviewed by Ryosuke Niwa.
890
891         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
892         (MockSCM.add): Remove optional remove_exit_code argument.
893         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
894         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
895         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
896         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
897
898 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
899
900         Fix roll-chromium-deps and hi.
901
902         * Scripts/webkitpy/tool/bot/irc_command.py:
903         (Hi.execute):
904         (RollChromiumDEPS.execute):
905
906 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
907
908         Remove webkitpy code to roll Chromium DEPS
909         https://bugs.webkit.org/show_bug.cgi?id=114415
910
911         Reviewed by Benjamin Poulain.
912
913         Removed the code to roll Chromium DEPS in WebKit.
914
915         * Scripts/webkitpy/common/checkout/checkout.py:
916         (Checkout.bug_id_for_this_commit):
917         * Scripts/webkitpy/common/checkout/checkout_mock.py:
918         (MockCheckout.commit_message_for_this_commit):
919         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
920         (CheckoutTest.test_suggested_reviewers):
921         * Scripts/webkitpy/common/checkout/deps.py: Removed.
922         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
923         * Scripts/webkitpy/tool/bot/irc_command.py:
924         (RollChromiumDEPS): Teach webkitbot a sense of humor.
925         (RollChromiumDEPS.execute):
926         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
927         (IRCCommandTest.test_create_bug):
928         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
929         (IRCBotTest.test_revert):
930         * Scripts/webkitpy/tool/bot/sheriff.py:
931         (Sheriff.post_rollout_patch):
932         * Scripts/webkitpy/tool/commands/__init__.py:
933         * Scripts/webkitpy/tool/commands/roll.py: Removed.
934         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
935         * Scripts/webkitpy/tool/steps/__init__.py:
936         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
937         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
938         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
939
940 2013-04-11  Glenn Adams  <glenn@skynav.com>
941
942         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
943         https://bugs.webkit.org/show_bug.cgi?id=114386
944
945         Reviewed by Benjamin Poulain.
946
947         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
948         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
949         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
950         by default and to return exit code 1 if a file/dir had already been added.
951
952         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
953         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
954         * Scripts/webkitpy/common/checkout/scm/svn.py:
955         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
956
957 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
958
959         Unreviewed.
960
961         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
962
963 2013-04-10  Glenn Adams  <glenn@skynav.com>
964
965         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
966         https://bugs.webkit.org/show_bug.cgi?id=114410
967
968         Reviewed by Ryosuke Niwa.
969
970         * Scripts/webkitpy/common/checkout/scm/git.py:
971         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
972         * Scripts/webkitpy/common/checkout/scm/scm.py:
973         (SCM.add): Remove optional return_exit_code argument.
974         (SCM.add_list): Remove optional return_exit_code argument.
975         * Scripts/webkitpy/common/checkout/scm/svn.py:
976         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
977
978 2013-04-10  Eric Seidel  <eric@webkit.org>
979
980         Remove myself from the watchlists, I'm getting too much bug mail. :)
981
982         * Scripts/webkitpy/common/config/watchlist:
983
984 2013-04-10  Commit Queue  <rniwa@webkit.org>
985
986         Unreviewed, rolling out r148158.
987         http://trac.webkit.org/changeset/148158
988         https://bugs.webkit.org/show_bug.cgi?id=114405
989
990         We need to migrate status data (Requested by rniwa on
991         #webkit).
992
993         * Scripts/webkitpy/common/net/statusserver.py:
994         (StatusServer):
995
996 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
997
998         Mass remove all the empty directories
999
1000         Rubberstamped by Ryosuke Niwa.
1001
1002         * BuildSlaveSupport/gtk/crashmon/log: Removed.
1003         * BuildSlaveSupport/gtk/xvfb/log: Removed.
1004         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
1005         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
1006         * MiniBrowser/gtk/WebBundle: Removed.
1007         * MiniBrowser/win: Removed.
1008         * QtTestPlatformPlugin/mac: Removed.
1009         * Scripts/webkitpy/tool/bot/testdata: Removed.
1010         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
1011         * efl/ImageDiff: Removed.
1012         * iExploder/htdocs: Removed.
1013         * iExploder/iexploder-1.7.2/output: Removed.
1014         * iExploder/tools: Removed.
1015         * qmake/config.tests/libexecdir: Removed.
1016         * qmake/config.tests/libjpeg: Removed.
1017         * qmake/config.tests/libpng: Removed.
1018
1019 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1020
1021         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
1022         https://bugs.webkit.org/show_bug.cgi?id=114397
1023
1024         Reviewed by Benjamin Poulain.
1025
1026         * Scripts/webkitpy/common/net/statusserver.py:
1027         (StatusServer):
1028
1029 2013-04-10  Adam Barth  <abarth@webkit.org>
1030
1031         Remove abarth from watchlists
1032         https://bugs.webkit.org/show_bug.cgi?id=114390
1033
1034         Reviewed by Ryosuke Niwa.
1035
1036         I'm trying to cut down on the amount of bugmail I get so that I'll have
1037         more of a chance to notice a piece of bugmail directed at me.
1038
1039         * Scripts/webkitpy/common/config/watchlist:
1040
1041 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1042
1043         webkit-test-results.appspot.com loads the dashboard for Chromium by default
1044         https://bugs.webkit.org/show_bug.cgi?id=114381
1045
1046         Reviewed by Benjamin Poulain.
1047
1048         Changed the defaults.
1049
1050         * TestResultServer/static-dashboards/builders.js:
1051         * TestResultServer/static-dashboards/dashboard_base.js:
1052         (currentBuilderGroupCategory):
1053
1054 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1055
1056         Remove Chromium EWS bots from the queue status server
1057         https://bugs.webkit.org/show_bug.cgi?id=113988
1058
1059         Reviewed by Benjamin Poulain.
1060
1061         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
1062
1063         * QueueStatusServer/app.yaml:
1064         * QueueStatusServer/config/queues.py:
1065         * QueueStatusServer/model/queues.py:
1066         (Queue.short_name):
1067         (Queue.display_name):
1068         * QueueStatusServer/model/queues_unittest.py:
1069         (QueueTest.test_short_name):
1070         (QueueTest.test_display_name):
1071         (QueueTest.test_name_with_underscores):
1072         * QueueStatusServer/templates/activebots.html:
1073
1074 2013-04-10  Ojan Vafai  <ojan@chromium.org>
1075
1076         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
1077         https://bugs.webkit.org/show_bug.cgi?id=114370
1078
1079         Reviewed by Ryosuke Niwa.
1080
1081         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
1082         Unfortunately, there's no way to test this until this is committed and there is
1083         a master restart.
1084
1085         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1091         * TestResultServer/generate_builders_json.py:
1092         * TestResultServer/static-dashboards/dashboard_base.js:
1093         * TestResultServer/static-dashboards/loader.js:
1094
1095 2013-04-10  Glenn Adams  <glenn@skynav.com>
1096
1097         [Qt] Fix regression to test-webkitpy.
1098         https://bugs.webkit.org/show_bug.cgi?id=114368
1099
1100         Reviewed by Ryosuke Niwa.
1101
1102         * Scripts/webkitpy/layout_tests/port/factory.py:
1103         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
1104         (PortFactory.get): Remove obsolete chromium port related code.
1105         * Scripts/webkitpy/layout_tests/port/mac.py:
1106         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
1107
1108 2013-04-10  Anders Carlsson  <andersca@apple.com>
1109
1110         Remove unneeded headers from FrameLoader.h
1111         https://bugs.webkit.org/show_bug.cgi?id=114223
1112
1113         Reviewed by Geoffrey Garen.
1114
1115         Add back headers implicitly included by other headers.
1116
1117         * WebKitTestRunner/WorkQueueManager.cpp:
1118
1119 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1120
1121         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
1122         https://bugs.webkit.org/show_bug.cgi?id=114365
1123
1124         Reviewed by Martin Robinson.
1125
1126         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
1127         The patch addresses crashes in the tally_event_reply method. It is already committed into the
1128         at-spi2-atk source tree and will be available with the next stable release, after which the
1129         patch should be removed and the dependency version bumped.
1130
1131         * gtk/jhbuild.modules:
1132         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
1133
1134 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
1135
1136         [WinCairo] Unreviewed build fix. Correct DropBox download link.
1137
1138         * Scripts/update-webkit-wincairo-libs: Revise download URL to
1139         match change in DropBox server behavior.
1140
1141 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
1142
1143         Removed an annoying message from svn-create-patch
1144         https://bugs.webkit.org/show_bug.cgi?id=114332
1145
1146         Reviewed by Alexey Proskuryakov.
1147
1148         I see this message basically every time I write a patch, so it must not
1149         be true.
1150
1151         * Scripts/svn-create-patch:
1152         (generateDiff):
1153
1154 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
1155
1156         [GTK] Add support for Page Visibility
1157         https://bugs.webkit.org/show_bug.cgi?id=97324
1158
1159         Reviewed by Sam Weinig.
1160
1161         Implemented test runner API for page visibility layout tests.
1162
1163         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1164         (TestRunner::resetPageVisibility):
1165         (TestRunner::setPageVisibility):
1166         * Scripts/webkitperl/FeatureList.pm:
1167
1168 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1169
1170         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
1171         https://bugs.webkit.org/show_bug.cgi?id=114342
1172
1173         Reviewed by Gyuyoung Kim.
1174
1175         Commit 148033 only added an implementation for the Mac port, which made
1176         other ports fail most tests since loading the injected bundle failed
1177         with a missing symbol.
1178
1179         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1180         (WTR::AccessibilityUIElement::pathDescription):
1181
1182 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
1183
1184         [EFL] Add spell checking option to MiniBrowser
1185         https://bugs.webkit.org/show_bug.cgi?id=114282
1186
1187         Reviewed by Ryosuke Niwa.
1188
1189         Spell checking is enabled by adding a flag (t/text-checking)
1190         with launching MiniBrowser.
1191
1192         * MiniBrowser/efl/main.c:
1193         (window_create):
1194         (elm_main):
1195
1196 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1197
1198         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
1199         https://bugs.webkit.org/show_bug.cgi?id=113281
1200
1201         Reviewed by Darin Adler.
1202
1203         * Scripts/run-gtk-tests:
1204         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
1205
1206 2013-04-09  Glenn Adams  <glenn@skynav.com>
1207
1208         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
1209
1210         Unreviewed.
1211
1212         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1213         (RunTest.test_build_check):
1214
1215 2013-04-09  Glenn Adams  <glenn@skynav.com>
1216
1217         [webkitpy] Remove chromium ports.
1218         https://bugs.webkit.org/show_bug.cgi?id=114326
1219
1220         Reviewed by Dirk Pranke.
1221
1222         As a side effect, also:
1223
1224         - remove chromium builders from webkitpy.layout_tests.port.builders
1225         - remove chromium builders from rebaseline
1226         - rewrite chromium dependent tests in rebaseline_unittest
1227         - remove chromium platform from garden-o-matic
1228         - select apple platform as default platform in garden-o-matic
1229         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
1230
1231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1233         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1234         (BaselineOptimizerTest.test_move_baselines):
1235         (BaselineOptimizerTest.test_efl):
1236         (BaselineOptimizerTest.test_no_add_mac_future):
1237         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1238         (BaselineOptimizerTest.test_common_directory_includes_root):
1239         (BaselineOptimizerTest.test_complex_shadowing):
1240         (BaselineOptimizerTest.test_virtual_ports_filtered):
1241         * Scripts/webkitpy/layout_tests/port/builders.py:
1242         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
1243         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
1244         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
1245         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
1246         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
1247         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
1248         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
1249         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
1250         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
1251         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
1252         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
1253         * Scripts/webkitpy/layout_tests/port/factory.py:
1254         (platform_options):
1255         (PortFactory):
1256         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1257         (FactoryTest.test_qt):
1258         (FactoryTest.test_get_from_builder_name):
1259         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1260         (RunTest.test_build_check):
1261         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1262         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1263         * Scripts/webkitpy/tool/commands/rebaseline.py:
1264         (Rebaseline._builders_to_pull_from):
1265         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1266         (_BaseTestCase):
1267         (_BaseTestCase.setUp):
1268         (TestRebaselineTest.setUp):
1269         (TestRebaselineTest.test_baseline_directory):
1270         (test_rebaseline_updates_expectations_file):
1271         (test_rebaseline_does_not_include_overrides):
1272         (test_rebaseline_test):
1273         (test_rebaseline_test_and_print_scm_changes):
1274         (test_rebaseline_and_copy_test):
1275         (test_rebaseline_and_copy_test_no_existing_result):
1276         (test_rebaseline_and_copy_test_with_lion_result):
1277         (test_rebaseline_and_copy_no_overwrite_test):
1278         (TestRebaselineExpectations.test_rebaseline_expectations):
1279
1280 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1281
1282         newcommitbot (WKR) requires a subversion checkout
1283         https://bugs.webkit.org/show_bug.cgi?id=114309
1284
1285         Reviewed by Benjamin Poulain.
1286
1287         Directly talk to the subversion server instead of relying on a local checkout.
1288         This allows us to run WKR off of a git clone.
1289
1290         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1291         (NewCommitBot.next_work_item):
1292         (NewCommitBot.process_work_item):
1293
1294 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1295
1296         webkitbot refers to sheriffbot in help
1297         https://bugs.webkit.org/show_bug.cgi?id=114307
1298
1299         Reviewed by Benjamin Poulain.
1300
1301         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
1302
1303         * Scripts/webkitpy/tool/bot/irc_command.py:
1304         (Help):
1305         (Help.execute):
1306         (RollChromiumDEPS.execute):
1307         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1308         (IRCBotTest.test_help):
1309         * Scripts/webkitpy/tool/bot/sheriff.py:
1310         (Sheriff.name):
1311
1312 2013-04-06  Roger Fong  <roger_fong@apple.com>
1313
1314         Kill old processes between runs on WinEWS bots.
1315         Temporarily disable tests to let bots catch up again.
1316
1317         * EWSTools/start-queue-win.sh:
1318         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1319         (WinEWS):
1320
1321 2013-04-09  Glenn Adams  <glenn@skynav.com>
1322
1323         [webkitpy] Remove chromium deprecated port support.
1324         https://bugs.webkit.org/show_bug.cgi?id=114228
1325
1326         Reviewed by Ryosuke Niwa.
1327
1328         * Scripts/webkitpy/common/config/ports.py:
1329         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
1330         (ChromiumPort): Removed.
1331         (ChromiumAndroidPort): Removed.
1332         (ChromiumXVFBPort): Removed.
1333         * Scripts/webkitpy/common/config/ports_unittest.py:
1334         (DeprecatedPortTest.test_chromium_port): Removed.
1335         (DeprecatedPortTest.test_chromium_android_port): Removed.
1336         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
1337         * Scripts/webkitpy/tool/steps/update_unittest.py:
1338         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
1339         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
1340
1341 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
1342
1343         AX: The bounding paths should be made available through accessibility
1344         https://bugs.webkit.org/show_bug.cgi?id=113817
1345
1346         Reviewed by David Kilzer.
1347
1348         Add a pathDescription property for testing so that it's possible
1349         to verify that a path is being returned correctly.
1350
1351         * DumpRenderTree/AccessibilityUIElement.cpp:
1352         (getPathDescriptionCallback):
1353         (AccessibilityUIElement::pathDescription):
1354         (AccessibilityUIElement::getJSClass):
1355         * DumpRenderTree/AccessibilityUIElement.h:
1356         (AccessibilityUIElement):
1357         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1358         (_CGPathEnumerationIteration):
1359         (AccessibilityUIElement::pathDescription):
1360         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1361         (AccessibilityUIElement::pathDescription):
1362         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1363         (WTR::AccessibilityUIElement::pathDescription):
1364         (WTR):
1365         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1366         (AccessibilityUIElement):
1367         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1368         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1369         (WTR::AccessibilityUIElement::pathDescription):
1370         (WTR):
1371
1372 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1373
1374         [EFL] Declare TEST_THEME_DIR in a single place.
1375         https://bugs.webkit.org/show_bug.cgi?id=114285
1376
1377         Reviewed by Anders Carlsson.
1378
1379         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
1380
1381         * DumpRenderTree/efl/CMakeLists.txt:
1382         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1383         (DumpRenderTreeChrome::createView):
1384         (DumpRenderTreeChrome::createInspectorView):
1385         (DumpRenderTreeChrome::initialize):
1386         (DumpRenderTreeChrome::onDownloadRequest):
1387         * EWebLauncher/CMakeLists.txt:
1388         * EWebLauncher/main.c:
1389         (findThemePath):
1390         * EWebLauncher/url_bar.c:
1391         (url_bar_add):
1392         * MiniBrowser/efl/CMakeLists.txt:
1393         * MiniBrowser/efl/main.c:
1394         (window_create):
1395         * TestWebKitAPI/PlatformEfl.cmake:
1396         * TestWebKitAPI/efl/PlatformWebView.cpp:
1397         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1398         * WebKitTestRunner/PlatformEfl.cmake:
1399         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1400         (WTR::PlatformWebView::PlatformWebView):
1401
1402 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
1403
1404         [GTK][AC] upversion of clutter and its dependecy
1405         https://bugs.webkit.org/show_bug.cgi?id=114016
1406
1407         Reviewed by Gustavo Noronha Silva.
1408
1409         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
1410
1411         * gtk/jhbuild-optional.modules:
1412
1413 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1414
1415         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
1416         https://bugs.webkit.org/show_bug.cgi?id=89875
1417
1418         Reviewed by Maciej Stachowiak.
1419
1420         Add unit tests to verify if the handling of the open, openat, creat syscall
1421         is being done right. We check if the Read/Write/ReadAndWrite permissions
1422         are respected, if the canonical path is being resolved and if
1423         the permissions are falling back to the topmost parent directory with a
1424         policy set when the directory being opened has no policy.
1425
1426         We also test if any attempt of blocking SIGSYS is silently ignored.
1427         SIGSYS cannot be blocked because in it's handler is where we hook
1428         syscalls to the broker process.
1429
1430         Also added libseccomp to EFL's jhbuild to make the life of developers
1431         willing to help easier.
1432
1433         * Scripts/webkitperl/FeatureList.pm:
1434         * TestWebKitAPI/PlatformEfl.cmake:
1435         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
1436         (TestWebKitAPI):
1437         (SeccompEnvironment):
1438         (TestWebKitAPI::SeccompEnvironment::SetUp):
1439         (TestWebKitAPI::SeccompEnvironment::TearDown):
1440         (TestWebKitAPI::dummyHandler):
1441         (TestWebKitAPI::TEST):
1442         (TestWebKitAPI::stressTest):
1443         * efl/jhbuild.modules:
1444         * qmake/mkspecs/features/features.pri:
1445
1446 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1447
1448         REGRESSION: Autocorrection doesn't work in DumpRenderTree
1449         https://bugs.webkit.org/show_bug.cgi?id=113846
1450
1451         Reviewed by Alexey Proskuryakov.
1452
1453         The problem was that we were replacing NSSpellCheck's dictionary with our own
1454         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
1455
1456         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
1457         and "would" respectively in DumpRenderTree.
1458
1459         * DumpRenderTree/mac/DumpRenderTree.mm:
1460         (resetDefaultsToConsistentValues):
1461
1462 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
1463
1464         Remove the gyp files for Tools
1465         https://bugs.webkit.org/show_bug.cgi?id=114248
1466
1467         Reviewed by Ryosuke Niwa.
1468
1469         * DumpRenderTree/DumpRenderTree.gyp: Removed.
1470         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
1471         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
1472         * DumpRenderTree/DumpRenderTree.gypi: Removed.
1473         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
1474         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
1475         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
1476         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
1477
1478 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1479
1480         WKR (new-commit-bot) is too slow
1481         https://bugs.webkit.org/show_bug.cgi?id=110087
1482
1483         Reviewed by Geoffrey Garen.
1484
1485         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
1486         Just run "svn log -r <revision>" instead to cut down the delay.
1487
1488         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
1489
1490         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1491         (NewCommitBot):
1492         (NewCommitBot.next_work_item):
1493         (NewCommitBot._is_empty_log):
1494         (NewCommitBot._update_checkout):
1495
1496 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1497
1498         Build fix. Can't remove appendCustomBuildFlags.
1499
1500         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1501         (appendCustomBuildFlags):
1502
1503 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1504
1505         Remove Chromium builders from build.webkit.org
1506         https://bugs.webkit.org/show_bug.cgi?id=113990
1507
1508         Reviewed by Benjamin Poulain.
1509
1510         Removed.
1511
1512         * BuildSlaveSupport/build.webkit.org-config/config.json:
1513         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1514         (InstallGtkDependencies):
1515         (RunUnitTests.start):
1516         (RunWebKit2Tests.start):
1517         (Factory.__init__):
1518         (unitTestsSupported):
1519         (TestFactory.__init__):
1520         (BuildAndTestFactory.__init__):
1521         (BuildAndPerfTestFactory.__init__):
1522         (BuildAndPerfTestWebKit2Factory.__init__):
1523         (DownloadAndPerfTestFactory.__init__):
1524         (loadBuilderConfig):
1525         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1526
1527 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
1528
1529         Remove HTML Notification
1530         https://bugs.webkit.org/show_bug.cgi?id=114231
1531
1532         Reviewed by Ryosuke Niwa.
1533
1534         * qmake/mkspecs/features/features.pri:
1535
1536 2013-04-08  Glenn Adams  <glenn@skynav.com>
1537
1538         Remove chromium EWS support, and fix broken test.
1539         https://bugs.webkit.org/show_bug.cgi?id=114221
1540
1541         Reviewed by Ryosuke Niwa.
1542
1543         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1544         (AbstractChromiumEWS): Removed.
1545         (ChromiumLinuxEWS): Removed.
1546         (ChromiumLinuxDebugEWS): Removed.
1547         (ChromiumWindowsEWS): Removed.
1548         (ChromiumAndroidEWS): Removed.
1549         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1550         (EarlyWarningSystemTest): Fix misspelled class name.
1551         (test_ewses): Fix entry point name to ensure test is run.
1552
1553 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
1554
1555         [WIN] Remove WebKit2 source code
1556         https://bugs.webkit.org/show_bug.cgi?id=114096
1557
1558         Reviewed by Anders Carlsson.
1559
1560         Remove the windows specific parts of the MiniBrowser.
1561
1562         * MiniBrowser/MiniBrowser.vcproj: Removed.
1563         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
1564         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
1565         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
1566         * MiniBrowser/win/BrowserView.cpp: Removed.
1567         * MiniBrowser/win/BrowserView.h: Removed.
1568         * MiniBrowser/win/BrowserWindow.cpp: Removed.
1569         * MiniBrowser/win/BrowserWindow.h: Removed.
1570         * MiniBrowser/win/MiniBrowser.cpp: Removed.
1571         * MiniBrowser/win/MiniBrowser.h: Removed.
1572         * MiniBrowser/win/MiniBrowser.rc: Removed.
1573         * MiniBrowser/win/main.cpp: Removed.
1574         * MiniBrowser/win/resource.h: Removed.
1575         * MiniBrowser/win/stdafx.cpp: Removed.
1576         * MiniBrowser/win/stdafx.h: Removed.
1577
1578 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1579
1580         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
1581
1582         * Scripts/webkitpy/common/config/irc.py:
1583
1584 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
1585
1586         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
1587         https://bugs.webkit.org/show_bug.cgi?id=113139
1588
1589         Reviewed by Anders Carlsson.
1590
1591         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1592         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
1593         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1594         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
1595         (ToStringAndValueOfObject):
1596         (ToStringAndValueOfObject::ToStringAndValueOfObject):
1597         (ScriptableObject):
1598         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
1599         (ToStringAndValueOfObject::ScriptableObject::invoke):
1600         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
1601         (ToStringAndValueOfObject::NPP_GetValue):
1602         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1603         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1604         * GNUmakefile.am:
1605
1606 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
1607
1608         [GTK] Bump gnome-themes-standard to 3.6.0
1609         https://bugs.webkit.org/show_bug.cgi?id=114155
1610
1611         Reviewed by Martin Robinson.
1612
1613         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
1614         dependency of gnome-themes-standard accordingly.
1615
1616 2013-04-08  David Levin  <levin@chromium.org>
1617
1618         Remove my watchlist entries.
1619         https://bugs.webkit.org/show_bug.cgi?id=114180
1620
1621         Reviewed by Adam Barth.
1622
1623         * Scripts/webkitpy/common/config/committers.py:
1624         * Scripts/webkitpy/common/config/watchlist:
1625
1626 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1627
1628         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
1629         https://bugs.webkit.org/show_bug.cgi?id=114161
1630
1631         Reviewed by Gyuyoung Kim.
1632
1633         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
1634         as it is crashing due to Bug 111074.
1635
1636         * TestWebKitAPI/PlatformEfl.cmake:
1637
1638 2013-04-07  David Kilzer  <ddkilzer@apple.com>
1639
1640         Remove the rest of SVG_DOM_OBJC_BINDINGS
1641         <http://webkit.org/b/114112>
1642
1643         Reviewed by Geoffrey Garen.
1644
1645         * Scripts/webkitperl/FeatureList.pm:
1646         - Remove --svg-dom-objc-bindings switch.
1647         * qmake/mkspecs/features/features.pri:
1648         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
1649
1650 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
1651
1652         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
1653         https://bugs.webkit.org/show_bug.cgi?id=114089
1654
1655         Reviewed by Chris Fleizach.
1656
1657         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
1658         * DumpRenderTree/AccessibilityController.cpp:
1659         * DumpRenderTree/AccessibilityUIElement.cpp:
1660         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1661         (DumpRenderTreeChrome::DumpRenderTreeChrome):
1662         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1663         (DumpRenderTreeChrome):
1664
1665 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
1666
1667         Build fix after r147857, remove remaining USE(JSC) guards.
1668
1669         Unreviewed.
1670
1671         * DumpRenderTree/config.h:
1672         * TestWebKitAPI/config.h:
1673         * WebKitTestRunner/config.h:
1674
1675 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1676
1677         Rename sheriffbot to webkitbot
1678         https://bugs.webkit.org/show_bug.cgi?id=114109
1679
1680         Reviewed by Benjamin Poulain.
1681
1682         Renamed since sheriffbot will be used in Blink.
1683
1684         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1685         (SheriffBot):
1686         (SheriffBot.begin_work_queue):
1687
1688 2013-04-06  Oliver Hunt  <oliver@apple.com>
1689
1690         Unify the many and varied stack trace mechanisms, and make the result sane.
1691         https://bugs.webkit.org/show_bug.cgi?id=114072
1692
1693         Reviewed by Filip Pizlo.
1694
1695         The commandline jsc executable no longer requires arguments, so
1696         I've made run-jsc work without them.
1697
1698         * Scripts/run-jsc:
1699
1700 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
1701
1702         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
1703         https://bugs.webkit.org/show_bug.cgi?id=114086
1704
1705         Reviewed by Tim Horton.
1706
1707         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
1708
1709 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
1710
1711         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
1712         https://bugs.webkit.org/show_bug.cgi?id=114083
1713
1714         Reviewed by Ryosuke Niwa.
1715
1716         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
1717         in TestWebKitAPI and WebKitTestRunner.
1718
1719         * TestWebKitAPI/config.h:
1720         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1721         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1722         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1723         (WTR::InjectedBundle::platformInitialize):
1724
1725 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
1726
1727         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
1728         https://bugs.webkit.org/show_bug.cgi?id=114094
1729
1730         Reviewed by Anders Carlsson.
1731
1732         * Scripts/run-jsc:
1733
1734 2013-04-05  Ojan Vafai  <ojan@chromium.org>
1735
1736         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
1737         https://bugs.webkit.org/show_bug.cgi?id=114080
1738
1739         Reviewed by Ryosuke Niwa.
1740
1741         This way, the WebKit and Blink dashboard code can change as appropriate without
1742         needing to consider the other project's needs. This still doesn't update the
1743         buildbots to upload to the new location, or the dashboard code to pull the
1744         results.json files from the new location, but it at least allows for changing the
1745         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
1746
1747         * TestResultServer/app.yaml:
1748
1749 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1750
1751         Re-enable testing on the commit queue
1752         https://bugs.webkit.org/show_bug.cgi?id=114078
1753
1754         Reviewed by Darin Adler.
1755
1756         Re-enabled the feature and the associated tests.
1757
1758         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1759         (CommitQueueTask.run):
1760         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1761         (CommitQueueTaskTest._run_through_task):
1762         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1763         (CommitQueueTest._mock_test_result):
1764
1765 2013-04-05  Oliver Hunt  <oliver@apple.com>
1766
1767         Unify the many and varied stack trace mechanisms, and make the result sane.
1768         https://bugs.webkit.org/show_bug.cgi?id=114072
1769
1770         Reviewed by Filip Pizlo.
1771
1772         The commandline jsc executable no longer requires arguments, so
1773         I've made run-jsc work without them.
1774
1775         * Scripts/run-jsc:
1776
1777 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1778
1779         AX: Make SVG Group containers accessible elements
1780         https://bugs.webkit.org/show_bug.cgi?id=113939
1781
1782         Reviewed by Simon Fraser.
1783
1784         Implement axController.elementAtPoint for iOS.
1785         Implement a correct version of clickPoint for iOS.
1786
1787         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1788         (AccessibilityController::elementAtPoint):
1789         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1790         (AccessibilityUIElement::clickPointX):
1791         (AccessibilityUIElement::clickPointY):
1792
1793 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1794
1795         Unreviewed, rolling out r147773 and r147774.
1796         http://trac.webkit.org/changeset/147773
1797         http://trac.webkit.org/changeset/147774
1798         https://bugs.webkit.org/show_bug.cgi?id=114056
1799
1800         Causing some exceptions on AppEngine I don't understand
1801         (Requested by rniwa on #webkit).
1802
1803         * QueueStatusServer/config/queues.py:
1804         * QueueStatusServer/model/queues.py:
1805         (Queue.short_name):
1806         (Queue.display_name):
1807         * QueueStatusServer/model/queues_unittest.py:
1808         (QueueTest.test_short_name):
1809         (QueueTest.test_display_name):
1810         (QueueTest.test_name_with_underscores):
1811
1812 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
1813
1814         Fixed run-bindings-tests by removing V8
1815         https://bugs.webkit.org/show_bug.cgi?id=114053
1816
1817         Reviewed by Benjamin Poulain.
1818
1819         * Scripts/run-bindings-tests:
1820         (main):
1821
1822 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1823
1824         Build fix.
1825
1826         * QueueStatusServer/model/queues.py:
1827         (Queue.short_name):
1828         (Queue.display_name):
1829
1830 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1831
1832         Remove Chromium EWS bots from the queue status server
1833         https://bugs.webkit.org/show_bug.cgi?id=113988
1834
1835         Reviewed by Benjamin Poulain.
1836
1837         Removed Chromium EWS bots.
1838
1839         * QueueStatusServer/config/queues.py:
1840         * QueueStatusServer/model/queues.py:
1841         (Queue.short_name):
1842         (Queue.display_name):
1843         * QueueStatusServer/model/queues_unittest.py:
1844         (QueueTest.test_short_name):
1845         (QueueTest.test_display_name):
1846         (QueueTest.test_name_with_underscores):
1847
1848 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1849
1850         [EFL] Enable indexed database
1851         https://bugs.webkit.org/show_bug.cgi?id=107248
1852
1853         Reviewed by Alexis Menard.
1854
1855         * Scripts/webkitperl/FeatureList.pm:
1856
1857 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1858
1859         Remove vestiges of Chromium bits from watchlists.
1860         https://bugs.webkit.org/show_bug.cgi?id=114047
1861
1862         Reviewed by Ryosuke Niwa.
1863
1864         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1865
1866 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1867
1868         Add James Craig to the contributors list.
1869
1870         * Scripts/webkitpy/common/config/committers.py:
1871
1872 2013-04-04  Kent Tamura  <tkent@chromium.org>
1873
1874         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1875
1876         * Scripts/webkitpy/common/config/watchlist:
1877
1878 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1879
1880         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1881         https://bugs.webkit.org/show_bug.cgi?id=113997
1882
1883         Reviewed by Ryosuke Niwa.
1884
1885         Disable the tests until Ryosuke gets the time and hardware to have
1886         a testing commit-queue.
1887
1888         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1889         (CommitQueueTaskTest):
1890         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1891         (CommitQueueTest):
1892
1893 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1894
1895         Remove Chromium builders from build.webkit.org
1896         https://bugs.webkit.org/show_bug.cgi?id=113990
1897
1898         Reviewed by Benjamin Poulain.
1899
1900         Land the part to disable triggering of Chromium builders first so that we may start
1901         deleting more Chromium code that breaks the update step.
1902
1903         * BuildSlaveSupport/build.webkit.org-config/config.json:
1904
1905 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1906
1907         Remove Chromium's DumpRenderTree
1908         https://bugs.webkit.org/show_bug.cgi?id=113989
1909
1910         Reviewed by Kent Tamura.
1911
1912         On second thought, let's not go to Camelot. It is a silly place.
1913
1914         * DumpRenderTree/mac/DumpRenderTree.mm:
1915         (resetDefaultsToConsistentValues):
1916
1917 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1918
1919         Nixed the defunct chromium folder from DumpRenderTree
1920         https://bugs.webkit.org/show_bug.cgi?id=113993
1921
1922         Reviewed by Ryosuke Niwa.
1923
1924         * DumpRenderTree/chromium: Removed.
1925         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1926         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1927         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1928         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1929         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1930         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1931         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1932         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1933         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1934         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1935         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1936         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1937         * DumpRenderTree/chromium/Task.cpp: Removed.
1938         * DumpRenderTree/chromium/Task.h: Removed.
1939         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1940         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1941         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1942         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1943         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1944         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1945         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1946         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1947         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1948         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1949         * DumpRenderTree/chromium/TestRunner: Removed.
1950         * DumpRenderTree/chromium/TestRunner/public: Removed.
1951         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1952         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1953         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1954         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1955         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1956         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1957         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1958         * DumpRenderTree/chromium/TestRunner/src: Removed.
1959         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1960         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1961         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1962         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1963         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1964         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1965         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1966         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1967         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1968         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1969         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1970         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1971         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1972         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1973         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1974         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1975         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1976         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1977         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1978         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1979         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1980         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1981         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1982         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1983         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1984         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1985         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1986         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1987         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1988         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1989         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1990         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1991         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1992         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1993         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1994         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1995         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1996         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1997         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1998         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1999         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
2000         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
2001         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
2002         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
2003         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
2004         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
2005         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
2006         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
2007         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
2008         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
2009         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
2010         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
2011         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
2012         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
2013         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
2014         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
2015         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2016         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
2017         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
2018         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2019         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
2020         * DumpRenderTree/chromium/TestShell.cpp: Removed.
2021         * DumpRenderTree/chromium/TestShell.h: Removed.
2022         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
2023         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
2024         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
2025         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
2026         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
2027         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
2028         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
2029         * DumpRenderTree/chromium/WebViewHost.h: Removed.
2030         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
2031         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
2032         * DumpRenderTree/chromium/config.h: Removed.
2033         * DumpRenderTree/chromium/fonts.conf: Removed.
2034
2035 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2036
2037         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
2038
2039         Rubber stamped by Benjamin Poulain.
2040
2041         * RebaselineQueueServer: Removed.
2042         * RebaselineQueueServer/app.yaml: Removed.
2043         * RebaselineQueueServer/handlers: Removed.
2044         * RebaselineQueueServer/handlers/__init__.py: Removed.
2045         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
2046         * RebaselineQueueServer/handlers/pages.py: Removed.
2047         * RebaselineQueueServer/index.yaml: Removed.
2048         * RebaselineQueueServer/main.py: Removed.
2049         * RebaselineQueueServer/model: Removed.
2050         * RebaselineQueueServer/model/__init__.py: Removed.
2051         * RebaselineQueueServer/model/queueentry.py: Removed.
2052         * RebaselineQueueServer/static: Removed.
2053         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
2054         * RebaselineQueueServer/static/styles.css: Removed.
2055         * RebaselineQueueServer/templates: Removed.
2056         * RebaselineQueueServer/templates/builder-picker.html: Removed.
2057         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
2058         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
2059         * RebaselineQueueServer/templates/home.html: Removed.
2060
2061 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2062
2063         Fix setup-commit-queue and temporarily disable testing on commit-queue
2064         https://bugs.webkit.org/show_bug.cgi?id=113979
2065
2066         Reviewed by Benjamin Poulain.
2067
2068         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
2069         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
2070
2071         * EWSTools/setup-commit-queue.sh:
2072         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2073         (CommitQueueTask.run):
2074
2075 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2076
2077         temporarily make flakiness dashboard work again webkit.org bots
2078         https://bugs.webkit.org/show_bug.cgi?id=113972
2079
2080         Reviewed by Ojan Vafai.
2081
2082         This patch disables the chromium.org layout test bots TestExpectations
2083         parsing temporarily until we can work out the right way to split into
2084         two instances for webkit.org and chromium.org and figure out which
2085         code to delete where :).
2086
2087         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2088
2089 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2090
2091         Fix webkitpy tests after r147678.
2092
2093         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2094         (CommitQueueTest.test_commit_queue):
2095         (test_manual_reject_during_processing):
2096
2097 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2098
2099         The commit queue should use Mac MountainLion port
2100         https://bugs.webkit.org/show_bug.cgi?id=113971
2101
2102         Reviewed by Lucas Forschler.
2103
2104         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
2105         * Scripts/webkitpy/tool/commands/queues.py:
2106         (CommitQueue):
2107
2108 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2109
2110         turn off running tests on chromium linux EWS bots
2111         https://bugs.webkit.org/show_bug.cgi?id=113959
2112
2113         Reviewed by Geoffrey Garen.
2114
2115         Now that the Chromium port is no longer being maintained
2116         there's little point in running the tests. Soon we should
2117         just shut this bot off altogether.
2118
2119         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2120         (ChromiumLinuxEWS):
2121
2122 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
2123
2124         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
2125
2126         * Scripts/webkitpy/common/config/watchlist:
2127
2128 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
2129
2130         Indentation fix to get webkit-patch working again after r147625
2131
2132         Unreviewed.
2133
2134         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2135         (MacEWS):
2136         (MacWK2EWS):
2137
2138 2013-04-04  Lucas Forschler  <lforschler@apple.com>
2139
2140         Turn tests back on for Mac WK1/WK2 EWS.
2141         
2142         Unreviewed.
2143         
2144         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2145         (MacEWS):
2146         (MacWK2EWS):
2147
2148 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
2149
2150         [GTK][WK2] MiniBrowser custom URI scheme support
2151         https://bugs.webkit.org/show_bug.cgi?id=112419
2152
2153         Reviewed by Carlos Garcia Campos.
2154
2155         Add support for about URIs in MiniBrowser. An example about page is show
2156         with URI "about:minibrowser", the rest of the cases it will show a
2157         proper message explaining that the about page didn't exist.
2158
2159         Internally it uses "minibrowser-about" prefix instead of "about", but
2160         from the user point of view it works with "about" prefix.
2161
2162         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
2163         (getInternalURI): Method to convert URIs from "about" prefix to
2164         "minibrowser-about".
2165         (getExternalURI): Opposite method.
2166         (webViewURIChanged): Use "about" prefix to show the URI to users.
2167         (webViewEnterFullScreen): Ditto.
2168         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
2169         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
2170         (aboutURISchemeRequestCallback): Callback to manage about calls.
2171         (main): Register the URI scheme to manage about URIs.
2172
2173 2013-04-03  Roger Fong  <roger_fong@apple.com>
2174
2175         Re-enable WinEWS tests.
2176
2177         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2178         (WinEWS):
2179
2180 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
2181
2182         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
2183         https://bugs.webkit.org/show_bug.cgi?id=113883
2184
2185         Reviewed by Martin Robinson.
2186
2187         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
2188         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
2189         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
2190
2191 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2192
2193         [GTK] Include Pango in jhbuild-optional.modules
2194         https://bugs.webkit.org/show_bug.cgi?id=113878
2195
2196         Reviewed by Martin Robinson.
2197
2198         Since r147547 Pango 1.32.0 is required. Including the module in the
2199         JHBuild optional moduleset.
2200
2201         * gtk/jhbuild-optional.modules: Add Pango module.
2202
2203 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2204
2205         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
2206         https://bugs.webkit.org/show_bug.cgi?id=113864
2207
2208         Moving setDefersLoading from TestRunnerQt to TestRunner
2209         requires access to the non-Qt TestRunner.
2210         As long as we instantiate both TestRunner and TestRunnerQt,
2211         we need a separate getter for the non-Qt TestRunner instance.
2212
2213         Reviewed by Simon Hausmann.
2214
2215         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2216         (WebPage::resetSettings):
2217         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2218         (DumpRenderTree::jscTestRunner):
2219         * DumpRenderTree/qt/TestRunnerQt.cpp:
2220         (TestRunner::setDefersLoading):
2221             Moving setDefersLoading from TestRunnerQt
2222             to TestRunner.
2223         * DumpRenderTree/qt/TestRunnerQt.h:
2224         (TestRunnerQt):
2225
2226 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2227
2228         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2229         https://bugs.webkit.org/show_bug.cgi?id=104779
2230
2231         Reviewed by Carlos Garcia Campos.
2232
2233         * Scripts/run-gtk-tests:
2234         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2235         passing in current trunk.
2236
2237 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
2238
2239         Fix HAVE(QTTESTSUPPORT) logic
2240
2241         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
2242         resulting in HAVE(QTTESTSUPPORT) never being true.
2243         Move that logic down in sanitizeFeatures.
2244
2245         Rubber-stamped by Tor Arne Vestbø.
2246
2247         * qmake/mkspecs/features/features.prf:
2248
2249 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2250
2251         [GTK] Bump required versions of some dependencies
2252         https://bugs.webkit.org/show_bug.cgi?id=113282
2253
2254         Reviewed by Martin Robinson.
2255
2256         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2257
2258 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2259
2260         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
2261         https://bugs.webkit.org/show_bug.cgi?id=113809
2262
2263         Reviewed by Philippe Normand.
2264
2265         Newer Linux kernels have removed some deprecated macros from v4l2
2266         headers, causing gst-plugins-good's build to break. We don't need it
2267         right now, so just disable it.
2268
2269         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
2270
2271 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2272
2273         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
2274         https://bugs.webkit.org/show_bug.cgi?id=113535
2275
2276         Reviewed by Simon Hausmann.
2277
2278         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
2279
2280         * qmake/mkspecs/features/features.prf:
2281
2282 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2283
2284         [Qt] Move logic of simple forwarding functions to TestRunner.
2285         https://bugs.webkit.org/show_bug.cgi?id=113863
2286
2287         Reviewed by Simon Hausmann.
2288
2289         * DumpRenderTree/qt/TestRunnerQt.cpp:
2290         (TestRunner::setTextDirection):
2291         (TestRunner::goBack):
2292         (TestRunner::evaluateScriptInIsolatedWorld):
2293         (TestRunner::addUserStyleSheet):
2294         * DumpRenderTree/qt/TestRunnerQt.h:
2295         (TestRunnerQt):
2296
2297 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2298
2299         [Qt] Disable media support using QuickTime if deployment target != SDK
2300
2301         We link to a single libWebKitSystemInterface static lib, so unless the
2302         deployment target matches the SDK let's not pretend like we'll be able
2303         to run on anything lower than the SDK version.
2304
2305         Reviewed by Simon Hausmann.
2306
2307         * qmake/mkspecs/features/features.prf:
2308
2309 2013-04-02  James Craig  <james@cookiecrook.com>
2310
2311         AXRoleDescripton for DL is "list"; should be "description list"
2312         https://bugs.webkit.org/show_bug.cgi?id=111665
2313
2314         Reviewed by Chris Fleizach.
2315
2316         Defining the role and description strings.
2317
2318         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2319
2320 2013-04-02  Roger Fong  <roger_fong@apple.com>
2321
2322         Unreviewed. Disable running tests on Win EWS queue.
2323
2324         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2325         (WinEWS):
2326
2327 2013-04-02  Lucas Forschler  <lforschler@apple.com>
2328
2329         Disable running tests on the MAC WK2 EWS queue.
2330         
2331         Unreviewed.
2332         
2333         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2334         (MacWK2EWS):
2335
2336 2013-04-02  Julie Parent  <jparent@chromium.org>
2337
2338         Dashboard refactor: Move dashboard specific history related features to History.
2339         https://bugs.webkit.org/show_bug.cgi?id=113717
2340
2341         Reviewed by Ojan Vafai.
2342         
2343         Each dashboard now creates its own History object, with a custom
2344         configuration. This changes from just overriding global functions
2345         to passing in callbacks for generatePage, handleValidHashParameter,
2346         and handleQueryParameterChange. Same with passing in defaultStateValues
2347         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
2348         variables.
2349         
2350         All functions related to these features are now (mostly) private
2351         function on History. 
2352         
2353         Loader no longer needs a loadingComplete callback, since it can just
2354         initialize the history object itself.
2355
2356         * TestResultServer/static-dashboards/aggregate_results.js:
2357         (handleValidHashParameter):
2358         * TestResultServer/static-dashboards/dashboard_base.js:
2359         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2360         (generatePage):
2361         (.switch.return):
2362         (handleQueryParameterChange):
2363         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2364         (resetGlobals):
2365         * TestResultServer/static-dashboards/history.js:
2366         (.):
2367         * TestResultServer/static-dashboards/loader.js:
2368         (.):
2369         * TestResultServer/static-dashboards/loader_unittests.js:
2370         * TestResultServer/static-dashboards/timeline_explorer.js:
2371         (generatePage):
2372         (initCurrentBuilderTestResults):
2373         * TestResultServer/static-dashboards/treemap.js:
2374         (generatePage):
2375         (.switch.return):
2376         (handleQueryParameterChange):
2377
2378 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2379
2380         Unreviewed, rolling out r147401.
2381         http://trac.webkit.org/changeset/147401
2382         https://bugs.webkit.org/show_bug.cgi?id=113767
2383
2384         The patch makes it extremely hard to set up the dependencies
2385         properly on the GTK builders (Requested by zdobersek on
2386         #webkit).
2387
2388         * gtk/jhbuild.modules:
2389
2390 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2391
2392         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
2393         https://bugs.webkit.org/show_bug.cgi?id=113382
2394
2395         Reviewed by Gyuyoung Kim.
2396
2397         Do not show the empty tooltip box if the text is null.
2398
2399         * MiniBrowser/efl/main.c:
2400         (popup_menu_populate):
2401
2402 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2403
2404         [GTK] Bump required versions of some dependencies
2405         https://bugs.webkit.org/show_bug.cgi?id=113282
2406
2407         Reviewed by Martin Robinson.
2408
2409         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2410
2411 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2412
2413         Unreviewed, rolling out r147319.
2414         http://trac.webkit.org/changeset/147319
2415         https://bugs.webkit.org/show_bug.cgi?id=113707
2416
2417         The unit test is still failing on the buildbot (Requested by
2418         zdobersek on #webkit).
2419
2420         * Scripts/run-gtk-tests:
2421         (TestRunner):
2422
2423 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2424
2425         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2426         https://bugs.webkit.org/show_bug.cgi?id=104779
2427
2428         Reviewed by Carlos Garcia Campos.
2429
2430         * Scripts/run-gtk-tests:
2431         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2432         passing in current trunk.
2433
2434 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
2435
2436         Unreviewed, rolling out r147289.
2437         http://trac.webkit.org/changeset/147289
2438         https://bugs.webkit.org/show_bug.cgi?id=113678
2439
2440         broke Win7 (dbg) build (Requested by shinyak|gardener on
2441         #webkit).
2442
2443         * DumpRenderTree/DumpRenderTree.gypi:
2444         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
2445         (WebTestRunner):
2446         (WebUserMediaClientMock):
2447         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
2448         (WebTestRunner::WebUserMediaClientMock::taskList):
2449         * Scripts/webkitpy/style/checkers/cpp.py:
2450         (check_function_definition):
2451
2452 2013-03-31  Adam Barth  <abarth@webkit.org>
2453
2454         configure-svn-config.sh fails
2455         https://codereview.chromium.org/13392007/
2456
2457         Reviewed by Eric Seidel.
2458
2459         This script was trying to use "svn checkout" to dowload a file from
2460         svn.webkit.org, but "svn checkout" only works with directories.
2461         Instead, we should use "svn export".
2462
2463         * EWSTools/configure-svn-config.sh:
2464
2465 2013-03-31  Wei Jia  <wjia@chromium.org>
2466
2467         Allow WebUserMediaClientMock to be used by client
2468         https://bugs.webkit.org/show_bug.cgi?id=113633
2469
2470         Reviewed by Adam Barth.
2471
2472         Export WebUserMediaClientMock.
2473         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
2474
2475         * DumpRenderTree/DumpRenderTree.gypi:
2476         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
2477         (WebUserMediaClientMock):
2478         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2479         * Scripts/webkitpy/style/checkers/cpp.py:
2480         (check_function_definition):
2481
2482 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
2483
2484         Expose FeatureObserver data to WebKit clients
2485         https://bugs.webkit.org/show_bug.cgi?id=113613
2486
2487         Reviewed by Sam Weinig.
2488
2489         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2490         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
2491
2492 2013-03-29  Greg Hughes  <ghughes@apple.com>
2493
2494         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
2495         https://bugs.webkit.org/show_bug.cgi?id=112276
2496
2497         Reviewed by Chris Fleizach.
2498
2499         Added support to test accessibility search predicates with multiple keys.  
2500
2501         * DumpRenderTree/AccessibilityUIElement.cpp:
2502         (uiElementForSearchPredicateCallback):
2503         * DumpRenderTree/AccessibilityUIElement.h:
2504         (AccessibilityUIElement):
2505         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2506         (AccessibilityUIElement::uiElementForSearchPredicate):
2507         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2508         (AccessibilityUIElement::uiElementForSearchPredicate):
2509         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2510         (AccessibilityUIElement::uiElementForSearchPredicate):
2511         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2512         (AccessibilityUIElement::uiElementForSearchPredicate):
2513         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2514         (AccessibilityUIElement::uiElementForSearchPredicate):
2515         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2516         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2517         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2518         (AccessibilityUIElement):
2519         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2520         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2521         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2522         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2523         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2524
2525 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
2526
2527         Fix a typo in r147147 to fix Mac EWS.
2528
2529         * Scripts/webkitpy/tool/commands/queues.py:
2530         (PatchProcessingQueue._new_port_name_from_old):
2531
2532 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
2533
2534         [EFL] Build break with latest EFL libraries after r146265
2535         https://bugs.webkit.org/show_bug.cgi?id=113558
2536
2537         Unreviewed build fix.
2538
2539         * TestWebKitAPI/PlatformWebView.h:
2540         * WebKitTestRunner/PlatformWebView.h:
2541
2542 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2543
2544         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
2545
2546         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
2547         in libgcrypt build.
2548
2549 2013-03-28  Lucas Forschler  <lforschler@apple.com>
2550
2551         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
2552
2553         Unreviewed.
2554
2555         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2556         (MacEWS):
2557
2558 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
2559
2560         Use the right OS name on Mac EWS instead of mac-future.
2561
2562         Rubber-stamped by Dirk Pranke.
2563
2564         * Scripts/webkitpy/tool/commands/queues.py:
2565         (PatchProcessingQueue._new_port_name_from_old):
2566         (PatchProcessingQueue.begin_work_queue):
2567         (PatchProcessingQueue._upload_results_archive_for_patch):
2568
2569 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
2570
2571         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
2572         https://bugs.webkit.org/show_bug.cgi?id=112546
2573
2574         Reviewed by Martin Robinson.
2575
2576         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
2577         moved back to Source/WebCore/platform. Fix an indentation issue as well.
2578
2579 2013-03-28  Ming Xie  <mxie@blackberry.com>
2580
2581         [BlackBerry] Committer Email Updates
2582         https://bugs.webkit.org/show_bug.cgi?id=113435
2583
2584         Reviewed by Rob Buis.
2585
2586         Add the @blackberry.com email address for all our BlackBerry
2587         WebKit committers. This is the first step for our email address
2588         migration.
2589
2590         * Scripts/webkitpy/common/config/committers.py:
2591
2592 2013-03-28  Philippe Normand  <pnormand@igalia.com>
2593
2594         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
2595         https://bugs.webkit.org/show_bug.cgi?id=113508
2596
2597         Reviewed by Martin Robinson.
2598
2599         Prevent the GStreamer plugin scanner to load system-wide
2600         plugins. Only the ones built in JHBuild should be loaded and used
2601         at runtime.
2602
2603         * efl/jhbuildrc:
2604         * gtk/jhbuildrc:
2605
2606 2013-03-27  Philippe Normand  <pnormand@igalia.com>
2607
2608         [GTK] run-launcher --gtk -2 fails on a WK2-only build
2609         https://bugs.webkit.org/show_bug.cgi?id=113386
2610
2611         Reviewed by Carlos Garcia Campos.
2612
2613         * Scripts/webkitdirs.pm:
2614         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
2615         version to 3.0. Reflect this change so the builtDylibPathForName
2616         function doesn't fail to report the library as found.
2617
2618 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
2619
2620         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
2621         https://bugs.webkit.org/show_bug.cgi?id=113484
2622
2623         Unreviewed build fix.
2624
2625         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
2626
2627         * TestWebKitAPI/CMakeLists.txt:
2628         * WebKitTestRunner/CMakeLists.txt:
2629
2630 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2631
2632         Revision for the internal jhbuild is too old
2633         https://bugs.webkit.org/show_bug.cgi?id=113324
2634
2635         Reviewed by Martin Robinson.
2636
2637         Update the minimum required version to a point where jhbuild won't
2638         fail installing packages when trying to remove a symlink to a directory.
2639
2640         * jhbuild/jhbuild-wrapper: Updated revision.
2641
2642 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
2643
2644         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
2645         https://bugs.webkit.org/show_bug.cgi?id=113203
2646
2647         Reviewed by Philippe Normand.
2648
2649         We build our libsoup without GNOME support. gst-plugins-good does separate
2650         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
2651         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
2652         build failures as the headers of those diverge. We do not use souphttpsrc, so
2653         disable it when building gst-plugins-good.
2654
2655         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
2656
2657 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
2658
2659         Build fix after r146852. Please another reference to the Lion leaks builder.
2660
2661         * BuildSlaveSupport/build.webkit.org-config/config.json:
2662
2663 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
2664
2665         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
2666         https://bugs.webkit.org/show_bug.cgi?id=113421
2667
2668         Reviewed by Dirk Pranke.
2669
2670         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
2671         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
2672         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
2673         in the GTK-specific TestExpectations files.
2674
2675         To avoid this only enable the warnings only when not using WKTR.
2676
2677         * Scripts/webkitpy/layout_tests/port/gtk.py:
2678         (GtkPort.warn_if_bug_missing_in_test_expectations):
2679
2680 2013-03-27  Antti Koivisto  <antti@apple.com>
2681
2682         Fix Zalan's email.
2683
2684         * Scripts/webkitpy/common/config/committers.py:
2685
2686 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2687
2688         master.cfg cleanup
2689         https://bugs.webkit.org/show_bug.cgi?id=113195
2690
2691         Reviewed by Ryosuke Niwa.
2692
2693         * BuildSlaveSupport/build.webkit.org-config/config.json:
2694         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2695
2696 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2697
2698         master.cfg fine-tuning for Qt Mountain Lion Release bot
2699         https://bugs.webkit.org/show_bug.cgi?id=113191
2700
2701         Reviewed by Ryosuke Niwa.
2702
2703         * BuildSlaveSupport/build.webkit.org-config/config.json:
2704           - Rename the slave due to its location change.
2705           - Update the platform of the slave.
2706         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2707         (RunQtAPITests): Enable running WK2 API tests on Qt.
2708         (RunQtAPITests.start):
2709         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
2710         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
2711
2712 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2713
2714         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
2715         https://bugs.webkit.org/show_bug.cgi?id=113403
2716
2717         Reviewed by Kenneth Rohde Christiansen.
2718
2719         As of Evas 1.7.5, when Wayland is detected on the system, support for
2720         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
2721         The code, however, seems to depend on a few other flags which must be
2722         explicitly enabled.
2723
2724         If those additional GL-related options are passed, we end up
2725         having issues on the WebKit side, so disable Wayland support for
2726         now.
2727
2728         * efl/jhbuild.modules:
2729
2730 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2731
2732         Unreviewed, rolling out r146864.
2733         http://trac.webkit.org/changeset/146864
2734         https://bugs.webkit.org/show_bug.cgi?id=113391
2735
2736         causes crashes on Wk2 EFL release bot (Requested by drott on
2737         #webkit).
2738
2739         * Scripts/webkitperl/FeatureList.pm:
2740
2741 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2742
2743         [jhbuild] Correctly specify an alternate number of make jobs.
2744         https://bugs.webkit.org/show_bug.cgi?id=113396
2745
2746         Reviewed by Philippe Normand.
2747
2748         So far, we were using the `MAKEFLAGS' environment variable to pass the
2749         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
2750         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
2751
2752         We now behave more closely to the rest of the WebKit tools by first
2753         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
2754         not set, just letting jhbuild itself figure out how many jobs to use.
2755
2756         * efl/jhbuildrc:
2757         * gtk/jhbuildrc:
2758
2759 2013-03-27  Zeno Albisser  <zeno@webkit.org>
2760
2761         [Qt] Remove Qt specific WorkQueueItem definitions.
2762         https://bugs.webkit.org/show_bug.cgi?id=112891
2763
2764         This patch is preparation work for removing
2765         WorkQueue related code from TestRunnerQt and
2766         replacing it with generic TestRunner code.
2767
2768         Reviewed by Benjamin Poulain.
2769
2770         * DumpRenderTree/qt/TestRunnerQt.cpp:
2771         (TestRunnerQt::queueBackNavigation):
2772         (TestRunnerQt::queueForwardNavigation):
2773         (TestRunnerQt::queueLoadHTMLString):
2774         (TestRunnerQt::queueReload):
2775         (TestRunnerQt::queueLoadingScript):
2776         (TestRunnerQt::queueNonLoadingScript):
2777         (TestRunner::queueLoad):
2778         * DumpRenderTree/qt/TestRunnerQt.h:
2779         (TestRunnerQt):
2780         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2781         (LoadItem::invoke):
2782         (LoadHTMLStringItem::invoke):
2783         (LoadAlternateHTMLStringItem::invoke):
2784         (ReloadItem::invoke):
2785         (ScriptItem::invoke):
2786         (BackForwardItem::invoke):
2787         * DumpRenderTree/qt/WorkQueueItemQt.h:
2788         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2789         (LoadAlternateHTMLStringItem):
2790
2791 2013-03-26  Julie Parent  <jparent@chromium.org>
2792
2793         Flakiness dashboard: simplify logic around which tests to show.
2794         https://bugs.webkit.org/show_bug.cgi?id=113250
2795
2796         Reviewed by Ojan Vafai.
2797         
2798         The different filters for showing results are only used for layout
2799         tests, otherwise, we show everything.
2800         
2801         Change the defaults to false (what layout tests used), and only
2802         look at the values when viewing layout tests.
2803
2804         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2805         (htmlForTestsWithExpectationsButNoFailures):
2806         (shouldHideTest):
2807
2808 2013-03-26  Isaac Levy  <ilevy@google.com>
2809
2810         Update bots on test-results.appspot
2811         https://bugs.webkit.org/show_bug.cgi?id=113333
2812
2813         Reviewed by Ojan Vafai.
2814
2815         * TestResultServer/static-dashboards/builders.jsonp:
2816
2817 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2818
2819         Unreviewed GTK gardening.
2820
2821         * Scripts/run-gtk-tests:
2822         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2823
2824 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2825
2826         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2827         https://bugs.webkit.org/show_bug.cgi?id=113287
2828
2829         Reviewed by Jocelyn Turcotte.
2830
2831         * Scripts/run-qtwebkit-tests:
2832         (Options.__init__):
2833
2834 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2835
2836         [EFL] Enable IndexedDB by default
2837         https://bugs.webkit.org/show_bug.cgi?id=107248
2838
2839         Reviewed by Laszlo Gombos.
2840
2841         * Scripts/webkitperl/FeatureList.pm:
2842         Enable IndexedDB by default on EFL.
2843
2844 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2845
2846         Sheriffbot should explain rollout failures in a human readable form.
2847         https://bugs.webkit.org/show_bug.cgi?id=107092
2848
2849         Reviewed by Ryosuke Niwa.
2850
2851         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2852
2853         * Scripts/webkitpy/tool/bot/irc_command.py:
2854         (Rollout._check_diff_failure):
2855         (Rollout.execute):
2856         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2857         (IRCCommandTest.test_rollout):
2858
2859 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2860
2861         Unreviewed GTK gardening.
2862
2863         * Scripts/run-gtk-tests:
2864         (TestRunner): Skipping a failing unit test after r146518.
2865
2866 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2867
2868         Remove Lion leaks builder
2869         https://bugs.webkit.org/show_bug.cgi?id=113252
2870
2871         Reviewed by Andreas Kling.
2872
2873         Removed.
2874
2875         * BuildSlaveSupport/build.webkit.org-config/config.json:
2876
2877 2013-03-25  Kent Tamura  <tkent@chromium.org>
2878
2879         Rename ENABLE_INPUT_TYPE_DATETIME
2880         https://bugs.webkit.org/show_bug.cgi?id=113254
2881
2882         Reviewed by Kentaro Hara.
2883
2884         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2885         Actually I'd like to remove the code, but we shouldn't remove it yet
2886         because we shipped products with it on some platforms.
2887
2888         * Scripts/webkitperl/FeatureList.pm:
2889         * qmake/mkspecs/features/features.pri:
2890
2891 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2892
2893         Remove one more line that was intended to be removed in r146657.
2894
2895         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2896         (summarize_results):
2897
2898 2013-03-25  Roger Fong  <roger_fong@apple.com>
2899
2900         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2901         Re-enable WinEWS tests.
2902
2903         * Scripts/webkitpy/common/config/ports.py:
2904         (WinPort.run_bindings_tests_command):
2905         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2906         (WinEWS):
2907
2908 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2909
2910         Unreviewed, rolling out r146793.
2911         http://trac.webkit.org/changeset/146793
2912         https://bugs.webkit.org/show_bug.cgi?id=113248
2913
2914         Fix did not work (Requested by rfong on #webkit).
2915
2916         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2917         (WinEWS):
2918
2919 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2920
2921         REGRESSION(r146657): Test failures reported incorrectly
2922         https://bugs.webkit.org/show_bug.cgi?id=113223
2923
2924         Reviewed by Dirk Pranke.
2925
2926         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2927
2928         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2929         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2930
2931         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2932         (Manager.run):
2933
2934         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2935         (RunDetails.__init__):
2936         (summarize_results): Remove the line I intended to remove in r146657.
2937
2938         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2939         (logging_run): Return details instead of the exit code.
2940         (run_and_capture): Ditto.
2941
2942         (RunTest.test_full_results_html):
2943         (RunTest.test_hung_thread):
2944         (RunTest.test_no_tests_found):
2945         (RunTest.test_no_tests_found_2):
2946         (RunTest.test_repeat_each_iterations_num_tests):
2947         (RunTest.test_run_singly_actually_runs_tests):
2948         (RunTest.test_test_list):
2949         (RunTest.test_missing_and_unexpected_results):
2950         (RunTest.test_pixel_test_directories):
2951         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2952         (RunTest.test_crash_with_stderr):
2953         (RunTest.test_no_image_failure_with_image_diff):
2954         (RunTest.test_crash_log):
2955         (RunTest.test_exit_after_n_failures_upload):
2956         (RunTest.test_results_directory_absolute):
2957         (RunTest.test_results_directory_relative):
2958         (RunTest.test_retrying_and_flaky_tests):
2959         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2960         (RunTest.test_retrying_uses_retries_directory):
2961         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2962         (RunTest.test_output_diffs):
2963         (EndToEndTest.test_reftest_with_two_notrefs):
2964         (RebaselineTest.test_reset_results):
2965         (RebaselineTest.test_missing_results):
2966         (RebaselineTest.test_new_baseline):
2967
2968         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2969         (BuildBotPrinter.print_results):
2970         (BuildBotPrinter.print_unexpected_results):
2971         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2972         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2973
2974 2013-03-25  Julie Parent  <jparent@chromium.org>
2975
2976         Dashboard refactor: Move cross dashboard history related code into history.js.
2977         https://bugs.webkit.org/show_bug.cgi?id=113104
2978
2979         Reviewed by Ojan Vafai.
2980
2981         All functions relating to cross dashboard behavior move from being
2982         globals to methods on the history.History object. Names stay the same,
2983         except many are made private, ones that should have been constants now
2984         are, and the long standing TODO to change "currentState" to 
2985         dashboardSpecificState is done.
2986         
2987         We now create a global history object in dashboard_base, as an 
2988         intermediate measure.  Once the dashboard specific code is
2989         added to history, each DB will need to create its own, and this
2990         global will be eliminated.
2991         
2992         * TestResultServer/static-dashboards/aggregate_results.js:
2993         (handleValidHashParameter):
2994         (htmlForBuilder):
2995         (rawValuesHTML):
2996         * TestResultServer/static-dashboards/dashboard_base.js:
2997         (parseDashboardSpecificParameters):
2998         (defaultValue):
2999         (currentBuilderGroupCategory):
3000         (currentBuilderGroupName):
3001         (handleLocationChange):
3002         (expectationsMap):
3003         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3004         (generatePage):
3005         (.switch.return):
3006         (platformAndBuildType):
3007         (individualTests):
3008         (substringList):
3009         (processMissingAndExtraExpectations):
3010         (pathToFailureLog):
3011         (showPopupForBuild):
3012         (htmlForTestsWithExpectationsButNoFailures):
3013         (shouldHideTest):
3014         (isCrossBuilderView):
3015         (tableHeaders):
3016         (htmlForSingleTestRow):
3017         (htmlForTableColumnHeader):
3018         (generatePageForExpectationsUpdate):
3019         (handleUpdate):
3020         (nextUpdate):
3021         (setUpdateIndex):
3022         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
3023         (.appendExpectationsItem):
3024         (loadExpectations):
3025         (.dummyNode.onload):
3026         (loadExpectationsLayoutTests):
3027         (appendExpectations):
3028         (htmlForNavBar):
3029         (checkBoxToToggleState):
3030         (linkHTMLToToggleState):
3031         (generatePageForBuilder):
3032         (isInvalidKeyForCrossBuilderView):
3033         (handleQueryParameterChange):
3034         (showLegend):
3035         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3036         (resetGlobals):
3037         (test):
3038         * TestResultServer/static-dashboards/history.js:
3039         (.):
3040         * TestResultServer/static-dashboards/history_unittests.js:
3041         * TestResultServer/static-dashboards/loader.js:
3042         (.):
3043         * TestResultServer/static-dashboards/loader_unittests.js:
3044         * TestResultServer/static-dashboards/timeline_explorer.js:
3045         (generatePage):
3046         (initCurrentBuilderTestResults):
3047         (selectBuild):
3048         (showResultsDelta):
3049         * TestResultServer/static-dashboards/treemap.js:
3050         (generatePage):
3051         (.switch.return):
3052         (handleFocus):
3053         * TestResultServer/static-dashboards/ui.js:
3054
3055 2013-03-25  Roger Fong  <roger_fong@apple.com>
3056
3057         Unreviewed. Enable WinEWS tests again.
3058
3059         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3060         (WinEWS):
3061
3062 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
3063
3064         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
3065         https://bugs.webkit.org/show_bug.cgi?id=112166
3066
3067         HarfBuzz 0.9.14 merged my patch for icu detection without
3068         pkg-config files, as needed by for example Ubuntu 12.04.
3069         This obsoletes our local workaround. Removed it for GTK and EFL.
3070
3071         Reviewed by Martin Robinson.
3072
3073         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3074         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
3075         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3076         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
3077
3078 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
3079
3080         Unreviewed.  Move self from contributor to committer list.
3081
3082         * Scripts/webkitpy/common/config/committers.py:
3083
3084 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3085
3086         EWS should use a human readable port name when uploading layout test archives
3087         https://bugs.webkit.org/show_bug.cgi?id=113099
3088
3089         Reviewed by Dirk Pranke.
3090
3091         Use new port's object's name() method to report human readable port names.
3092         This will also help us resolving the bug to apply layout test results posted by EWS.
3093
3094         * Scripts/webkitpy/tool/bot/botinfo.py:
3095         (BotInfo.__init__): Take port's name.
3096         (BotInfo.summary_text):
3097
3098         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3099         (BotInfoTest.test_summary_text):
3100
3101         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3102         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
3103
3104         * Scripts/webkitpy/tool/commands/queues.py:
3105         (PatchProcessingQueue.__init__): Initialize self._port.
3106         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
3107         and use that for the attachment filename and the comment posted.
3108
3109         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3110         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
3111         "mac-snowleopard" as expected for TestPort.
3112
3113 2013-03-22  Roger Fong  <roger_fong@apple.com>
3114
3115         Unreviewed. Turn off EWS test on Win again.
3116         The battle continues.
3117
3118         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3119         (WinEWS):
3120
3121 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3122
3123         NRWT: Enable pixel tests when retrying tests
3124         https://bugs.webkit.org/show_bug.cgi?id=112898
3125
3126         Reviewed by Dirk Pranke.
3127
3128         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3129         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
3130         if we've forced pixel tests in the retry.
3131         (Manager._run_tests):
3132         (Manager._clean_up_run): Fixed the capitalizations.
3133         (Manager._force_pixel_tests_if_needed): Added.
3134
3135         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3136         (_interpret_test_failures): Now that this function maybe called multiple times, only set
3137         'image_diff_percent' if it doesn't already exist.
3138
3139         (summarize_results): When the first attempt resulted in a text failure and the second attempt
3140         resulted in image and text failures and we've forced to run pixel tests in the retry run,
3141         treat this as a regular regression instead of a flakiness.
3142
3143         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
3144         run had image diffs.
3145
3146         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3147         (summarized_results):
3148
3149         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3150         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
3151         Also removed some dead code.
3152
3153         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
3154         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
3155         is set and pixel_tests_enabled is set to false.
3156         (EndToEndTest.test_reftest_with_two_notrefs):
3157
3158 2013-03-22  Tim Horton  <timothy_horton@apple.com>
3159
3160         Make it possible to run layout tests on Retina MBP
3161         https://bugs.webkit.org/show_bug.cgi?id=93673
3162
3163         Reviewed by Ryosuke Niwa.
3164
3165         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
3166         windows on 2x machines still run at 1x.
3167
3168         * DumpRenderTree/mac/DumpRenderTree.mm:
3169         (createWebViewAndOffscreenWindow):
3170         Reset the window resolution to 1x on creation.
3171         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
3172         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3173         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
3174         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3175         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
3176         (WTR::PlatformWebView::PlatformWebView):
3177         Add NSWindow details, reset the window resolution to 1x on creation.
3178
3179 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3180
3181         Leak bots shouldn't build
3182         https://bugs.webkit.org/show_bug.cgi?id=112774
3183
3184         Reviewed by Simon Fraser.
3185
3186         Since leak bots use regular debug builds, there is no need to build on these bots.
3187         Simply downloading builds will dramatically improve the cycle time of these bots.
3188
3189         * BuildSlaveSupport/build.webkit.org-config/config.json:
3190         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3191         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
3192         TestFactory instead of BuildAndTestFactory.
3193
3194 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
3195
3196         [Qt] Fix the TestWebKitAPI build
3197         https://bugs.webkit.org/show_bug.cgi?id=113044
3198
3199         Reviewed by Tor Arne Vestbø.
3200
3201         The generate-forwarding-headers script would only be run
3202         after the targets in InjectedBundle.pri since the second
3203         addStrictSubdirOrderBetween call in
3204         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
3205         the derived_sources -> injected_bundle order in SUBDIRS.
3206
3207         Fix it by only moving the dependent target at the end of
3208         SUBDIRS, don't touch its dependency.
3209
3210         * qmake/mkspecs/features/functions.prf:
3211
3212 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3213
3214         [EFL][WK2] View is not focused when fullscreen mode toggled
3215         https://bugs.webkit.org/show_bug.cgi?id=113009
3216
3217         Reviewed by Laszlo Gombos.
3218
3219         Set focus on view when fullscreen mode enabled/disabled
3220         by FullScreen API.
3221
3222         * MiniBrowser/efl/main.c:
3223         (on_fullscreen_accept):
3224         (on_fullscreen_deny):
3225
3226 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3227
3228         nrwt is no longer saving retry results in the retries/ subdirectory
3229         https://bugs.webkit.org/show_bug.cgi?id=112995
3230
3231         Reviewed by Ojan Vafai.
3232
3233         I think this has been broken a long time, unfortunately. This
3234         patch should fix that.
3235
3236         In order to do so, I had to pass the directory to use from
3237         the Worker object through the SingleTestWriter to the
3238         TestResultWriter. While I was plumbing that through, I rationalized
3239         the order of the parameter arguments a bit ...
3240
3241         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3242         (Worker._run_single_test):
3243         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3244         (run_single_test):
3245         (SingleTestRunner.__init__):
3246         (SingleTestRunner._run_compare_test):
3247         (SingleTestRunner._run_rebaseline):
3248         (SingleTestRunner._run_reftest):
3249         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3250         (write_test_result):
3251         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3252         (TestResultWriterTest.test_reftest_diff_image):
3253         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3254         (RunTest.test_retrying_uses_retries_directory):
3255
3256 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
3257
3258         JSC profiler should have an at-a-glance report of the success of DFG optimization
3259         https://bugs.webkit.org/show_bug.cgi?id=112988
3260
3261         Reviewed by Geoffrey Garen.
3262
3263         * Scripts/display-profiler-output:
3264
3265 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3266
3267         [chromium] Linux ASAN WebKit canary is running out of memory
3268         https://bugs.webkit.org/show_bug.cgi?id=112978
3269
3270         Reviewed by Tony Chang.
3271
3272         Running the AddressSanitizer on a crash takes a lot of
3273         memory, so we should serialize access to it to avoid running
3274         out of memory on a machine.
3275
3276         * Scripts/webkitpy/layout_tests/port/chromium.py:
3277         (ChromiumPort._get_crash_log):
3278         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3279         (HttpLock.__init__):
3280         (HttpLock.wait_for_httpd_lock):
3281
3282 2013-03-21  Min Qin  <qinmin@chromium.org>
3283
3284         Cleanup android media layout test code
3285         https://bugs.webkit.org/show_bug.cgi?id=112944
3286
3287         Reviewed by Adam Barth.
3288
3289         Chromium change: https://codereview.chromium.org/12892010/
3290         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
3291         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
3292         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
3293         Instead, we should switch to use content shell for layout tests.
3294
3295         * DumpRenderTree/chromium/TestShell.cpp:
3296         (TestShell::resetTestController):
3297
3298 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3299
3300         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
3301         https://bugs.webkit.org/show_bug.cgi?id=112953
3302
3303         Reviewed by Tony Chang.
3304
3305         When I created the DumpRenderTree_resources target in r144863 I
3306         forgot to declare the needed dependencies on the other resource
3307         targets. Due to a quirk of ordering, this appears to have been fine
3308         w/ ninja but not w/ Xcode (which is still being used on the chromium
3309         mac valgrind bots). Declaring the dependencies fixes the build
3310         failures.
3311
3312         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3313
3314 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
3315
3316         [WinCairo] Correct assert in Empty BitmapImage Test.
3317         https://bugs.webkit.org/show_bug.cgi?id=112934
3318
3319         Reviewed by Tim Horton.
3320
3321         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3322         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
3323         to avoid ref counting assertion when leaving test scope.
3324
3325 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
3326
3327         [GTK] generate-feature-defines-files is incompatible with Python3
3328         https://bugs.webkit.org/show_bug.cgi?id=112956
3329
3330         Reviewed by Martin Robinson.
3331
3332         Make the generate-feature-defines-files compatible with Python3 by calling the items()
3333         method on the dictionary objects when iterating through said dictionaries.
3334
3335         * gtk/generate-feature-defines-files:
3336         (write_feature_defines_header):
3337         (write_flattened_feature_defines_file):
3338
3339 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
3340
3341         kill-old-processes spits out error messages on Mac
3342         https://bugs.webkit.org/show_bug.cgi?id=112878
3343
3344         Reviewed by Jessie Berlin.
3345
3346         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
3347         included in the list of options grep --help shows.
3348
3349         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
3350
3351         * BuildSlaveSupport/kill-old-processes:
3352         (main):
3353
3354 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
3355
3356         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
3357         https://bugs.webkit.org/show_bug.cgi?id=112597
3358
3359         Reviewed by Xan Lopez.
3360
3361         These were introduced for the Chromium port in r105295. We need
3362         dummy implementations in order to compile the BlackBerry port.
3363
3364         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3365         (AccessibilityUIElement::scrollToMakeVisible):
3366         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3367         (AccessibilityUIElement::scrollToGlobalPoint):
3368
3369 2013-03-21  Roger Fong  <roger_fong@apple.com>
3370
3371         Re-enable WinEWS tests following r146376.
3372
3373         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3374         (WinEWS):
3375
3376 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
3377
3378         Unreviewed. Add Bem Jones-Bey to the list of contributors.
3379
3380         * Scripts/webkitpy/common/config/committers.py:
3381
3382 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
3383
3384         [GTK] Missing atk in install-dependencies script
3385         https://bugs.webkit.org/show_bug.cgi?id=112272
3386
3387         Reviewed by Gustavo Noronha Silva.
3388
3389         * gtk/install-dependencies: Add missing atk dependency.
3390
3391 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
3392
3393         [GTK] Missing backslash in install-dependencies script
3394         https://bugs.webkit.org/show_bug.cgi?id=112907
3395
3396         Reviewed by Philippe Normand.
3397
3398         * gtk/install-dependencies: Add missing backslash to dependencies
3399         list.
3400
3401 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
3402
3403         EWS bots have stopped uploading results to bugzilla
3404         https://bugs.webkit.org/show_bug.cgi?id=101091
3405
3406         Reviewed by Adam Barth.
3407
3408         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
3409         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
3410         this relative file path resoled to a file inside a non-existent directory for "zip".
3411
3412         Fixed the bug by resolving both test results directory and zip archive paths in
3413         LayoutTestResultsReader.archive.
3414
3415         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
3416         in the future.
3417
3418         * Scripts/webkitpy/common/system/filesystem_mock.py:
3419         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
3420
3421         * Scripts/webkitpy/common/system/workspace.py:
3422         (Workspace.create_zip): Log the source path when "zip" failed.
3423
3424         * Scripts/webkitpy/common/system/workspace_mock.py:
3425         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
3426
3427         * Scripts/webkitpy/common/system/workspace_unittest.py:
3428         (WorkspaceTest.test_create_zip_exception): Test that.
3429
3430         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3431         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
3432         This is the actual bug fix.
3433
3434         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3435         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
3436
3437 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
3438
3439         [chromium] move WebThemeEngine implementations to TestRunner library
3440         https://bugs.webkit.org/show_bug.cgi?id=112751
3441
3442         Reviewed by Adam Barth.
3443
3444         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3445         * DumpRenderTree/DumpRenderTree.gypi:
3446         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3447         (WebKit):
3448         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3449         (WebTestRunner::TestInterfaces::themeEngine):
3450         (WebTestRunner):
3451         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3452         (WebKit):
3453         (TestInterfaces):
3454         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3455         (WebTestRunner::WebTestInterfaces::themeEngine):
3456         (WebTestRunner):
3457         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3458         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3459         (WebTestRunner):
3460         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3461         (WebTestRunner::WebTestThemeControlWin::box):
3462         (WebTestRunner::WebTestThemeControlWin::line):
3463         (WebTestRunner::WebTestThemeControlWin::triangle):
3464         (WebTestRunner::WebTestThemeControlWin::roundRect):
3465         (WebTestRunner::WebTestThemeControlWin::oval):
3466         (WebTestRunner::WebTestThemeControlWin::circle):
3467         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3468         (WebTestRunner::WebTestThemeControlWin::markState):
3469         (WebTestRunner::WebTestThemeControlWin::draw):
3470         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3471         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3472         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3473         (WebTestRunner):
3474         (WebTestThemeControlWin):
3475         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3476         (WebTestRunner):
3477         (WebTestThemeEngineMac):
3478         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3479         (+[FakeActiveWindow alwaysActiveWindow]):
3480         (+[FakeActiveWindow alwaysInactiveWindow]):
3481         (-[FakeActiveWindow initWithActiveControls:]):
3482         (-[FakeActiveWindow _hasActiveControls]):
3483         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3484         (WebTestRunner):
3485         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3486         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3487         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3488         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3489         (WebTestRunner):
3490         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3491         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3492         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3493         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3494         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3495         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3496         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3497         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3498         (WebTestRunner::WebTestThemeEngineWin::getSize):
3499         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3500         (WebTestRunner):
3501         (WebTestThemeEngineWin):
3502         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3503         * DumpRenderTree/chromium/TestShell.cpp:
3504         (TestShell::initialize):
3505         * DumpRenderTree/chromium/TestShell.h:
3506         (WebKit):
3507         * DumpRenderTree/chromium/TestShellMac.mm:
3508         (platformInit):
3509         * DumpRenderTree/chromium/TestShellWin.cpp:
3510         (platformInit):
3511         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3512
3513 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
3514
3515         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
3516
3517         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
3518         New property sheet that does not link against CoreFoundation and
3519         CFNetwork.
3520         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3521         Use new TestWebKitAPICommonWinCairo property sheet.
3522         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3523         Ditto.
3524
3525 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
3526
3527         [WinCairo] Unreviewed build fix for VS2010.
3528
3529         Had to add WinCairo-specific property sheets to deal with some
3530         library and path differences with the main Apple port.
3531
3532         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3533         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3534         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3535         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
3536         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
3537         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
3538
3539 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
3540
3541         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
3542         https://bugs.webkit.org/show_bug.cgi?id=112849
3543
3544         Reviewed by Sam Weinig.
3545
3546         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3547         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3548         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3549
3550 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
3551
3552         [WinCairo] Build WebKit Tools under VS2010
3553         https://bugs.webkit.org/show_bug.cgi?id=112821
3554
3555         Reviewed by Tim Horton.
3556
3557         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3558         Add WinCairo-specific build target.
3559         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
3560         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
3561         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
3562         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
3563         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3564         Add WinCairo-specific build target.
3565         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3566         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3567         Add WinCairo-specific build target.
3568         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
3569         WinCairo-specific build target.
3570         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
3571         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
3572         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
3573         specific build target.
3574         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
3575         WinCairo-specific build target.
3576         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
3577         * win/record-memory/record-memoryDebugWinCairo.props: Added.
3578         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
3579
3580 2013-03-20  Roger Fong  <roger_fong@apple.com>
3581
3582         API test gardening AppleWin port.
3583
3584         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
3585
3586         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3587         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3588
3589 2013-03-20  Roger Fong  <roger_fong@apple.com>
3590
3591         Test fix for Win EWS bots, catch various errors and restart script if necessary.
3592
3593         * EWSTools/start-queue-win.sh:
3594
3595 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
3596
3597         Unreviewed, add myself to committers.py.
3598
3599 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3600
3601         Unreviewed. Adding another email for me.
3602
3603         * Scripts/webkitpy/common/config/committers.py:
3604
3605 2013-03-20  Justin Novosad  <junov@google.com>
3606
3607         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
3608         https://bugs.webkit.org/show_bug.cgi?id=112605
3609
3610         Reviewed by James Robinson.
3611
3612         Deleting all the code that was used for propagating and supporting
3613         the Chromium setting for disabling deferred 2d canvas rendering.
3614
3615         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3616         (main):
3617         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3618         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3619         (WebTestRunner::WebPreferences::reset):
3620         (WebTestRunner::WebPreferences::applyTo):
3621         * DumpRenderTree/chromium/TestShell.cpp:
3622         (TestShell::TestShell):
3623         (TestShell::resetWebSettings):
3624         (TestShell::runFileTest):
3625         * DumpRenderTree/chromium/TestShell.h:
3626         (TestShell):
3627
3628 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
3629
3630         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
3631         https://bugs.webkit.org/show_bug.cgi?id=112699.
3632
3633         Reviewed by Adam Barth.
3634
3635         * Scripts/webkitpy/layout_tests/port/qt.py:
3636         (QtPort._search_paths):
3637         (QtPort._port_specific_expectations_files):
3638         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3639         (QtPortTest):
3640         (QtPortTest._assert_search_path):
3641         (QtPortTest._assert_expectations_files):
3642
3643 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3644
3645         [Qt] Enable kerning by default
3646         https://bugs.webkit.org/show_bug.cgi?id=112704
3647
3648         Reviewed by Jocelyn Turcotte.
3649
3650         Disable kerning by default, since some reference test expectations
3651         expect kerning to be default off.
3652
3653         * DumpRenderTree/qt/TestRunnerQt.cpp:
3654         (TestRunnerQt::reset):
3655         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3656         (WTR::activateFonts):
3657
3658 2013-03-20  Zeno Albisser  <zeno@webkit.org>
3659
3660         [Qt] Remove empty function stubs from TestRunnerQt.
3661         https://bugs.webkit.org/show_bug.cgi?id=112799
3662
3663         We are reducing the code in TestRunnerQt step by step,
3664         in order to finally replace all of it with the generic
3665         TestRunner implementation.
3666         This patch removes several simple function stubs that
3667         currently do not implement any actual functionality.
3668
3669         Reviewed by Kenneth Rohde Christiansen.
3670
3671         * DumpRenderTree/qt/TestRunnerQt.cpp:
3672         * DumpRenderTree/qt/TestRunnerQt.h:
3673         (TestRunnerQt):
3674
3675 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3676
3677         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
3678         https://bugs.webkit.org/show_bug.cgi?id=112687
3679
3680         Reviewed by Kenneth Rohde Christiansen.
3681
3682         Hide the SearchBar by default on window creation.
3683
3684         * MiniBrowser/efl/main.c:
3685         (window_create):
3686
3687 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
3688
3689         Unreviewed, rolling out r146304.
3690         http://trac.webkit.org/changeset/146304
3691         https://bugs.webkit.org/show_bug.cgi?id=112788
3692
3693         to many expectations to update (Requested by antonm on
3694         #webkit).
3695
3696         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3697         * DumpRenderTree/DumpRenderTree.gypi:
3698         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3699         (WebKit):
3700         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3701         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3702         (TestInterfaces):
3703         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3704         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3705         * DumpRenderTree/chromium/TestShell.cpp:
3706         (TestShell::initialize):
3707         * DumpRenderTree/chromium/TestShell.h:
3708         (WebKit):
3709         * DumpRenderTree/chromium/TestShellMac.mm:
3710         (platformInit):
3711         * DumpRenderTree/chromium/TestShellWin.cpp:
3712         (platformInit):
3713         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3714         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3715         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3716         (WebThemeControlDRTWin::box):
3717         (WebThemeControlDRTWin::line):
3718         (WebThemeControlDRTWin::triangle):
3719         (WebThemeControlDRTWin::roundRect):
3720         (WebThemeControlDRTWin::oval):
3721         (WebThemeControlDRTWin::circle):
3722         (WebThemeControlDRTWin::nestedBoxes):
3723         (WebThemeControlDRTWin::markState):
3724         (WebThemeControlDRTWin::draw):
3725         (WebThemeControlDRTWin::drawTextField):
3726         (WebThemeControlDRTWin::drawProgressBar):
3727         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3728         (WebThemeControlDRTWin):
3729         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3730         (WebThemeEngineDRTMac):
3731         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3732         (+[FakeActiveWindow alwaysActiveWindow]):
3733         (+[FakeActiveWindow alwaysInactiveWindow]):
3734         (-[FakeActiveWindow initWithActiveControls:]):
3735         (-[FakeActiveWindow _hasActiveControls]):
3736         (WebThemeEngineDRTMac::paintScrollbarThumb):
3737         (stateToHIEnableState):
3738         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3739         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3740         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3741         (webRectToSkIRect):
3742         (drawControl):
3743         (drawTextField):
3744         (drawProgressBar):
3745         (WebThemeEngineDRTWin::paintButton):
3746         (WebThemeEngineDRTWin::paintMenuList):
3747         (WebThemeEngineDRTWin::paintScrollbarArrow):
3748         (WebThemeEngineDRTWin::paintScrollbarThumb):
3749         (WebThemeEngineDRTWin::paintScrollbarTrack):
3750         (WebThemeEngineDRTWin::paintSpinButton):
3751         (WebThemeEngineDRTWin::paintTextField):
3752         (WebThemeEngineDRTWin::paintTrackbar):
3753         (WebThemeEngineDRTWin::paintProgressBar):
3754         (WebThemeEngineDRTWin::getSize):
3755         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3756         (WebThemeEngineDRTWin):
3757         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3758
3759 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3760
3761         [Qt] Support -webkit-font-smoothing
3762         https://bugs.webkit.org/show_bug.cgi?id=106009
3763
3764         Reviewed by Jocelyn Turcotte.
3765
3766         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
3767
3768         * DumpRenderTree/qt/TestRunnerQt.cpp:
3769         (TestRunnerQt::reset):
3770
3771 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
3772
3773         [GTK] accessibility/aria-scrollbar-role.html is failing
3774         https://bugs.webkit.org/show_bug.cgi?id=98358
3775
3776         Reviewed by Martin Robinson.
3777
3778         Adds support for checking accessibility object's orientation.
3779         Orientation is checked by retrieving proper state of accessibility object.
3780
3781         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3782         (checkElementState):
3783         (AccessibilityUIElement::orientation):
3784         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3785         (WTR::AccessibilityUIElement::orientation):
3786
3787 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3788
3789         [chromium] move WebThemeEngine implementations to TestRunner library
3790         https://bugs.webkit.org/show_bug.cgi?id=112751
3791
3792         Reviewed by Adam Barth.
3793
3794         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3795         * DumpRenderTree/DumpRenderTree.gypi:
3796         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3797         (WebKit):
3798         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3799         (WebTestRunner::TestInterfaces::themeEngine):
3800         (WebTestRunner):
3801         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3802         (WebKit):
3803         (TestInterfaces):
3804         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3805         (WebTestRunner::WebTestInterfaces::themeEngine):
3806         (WebTestRunner):
3807         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3808         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3809         (WebTestRunner):
3810         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3811         (WebTestRunner::WebTestThemeControlWin::box):
3812         (WebTestRunner::WebTestThemeControlWin::line):
3813         (WebTestRunner::WebTestThemeControlWin::triangle):
3814         (WebTestRunner::WebTestThemeControlWin::roundRect):
3815         (WebTestRunner::WebTestThemeControlWin::oval):
3816         (WebTestRunner::WebTestThemeControlWin::circle):
3817         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3818         (WebTestRunner::WebTestThemeControlWin::markState):
3819         (WebTestRunner::WebTestThemeControlWin::draw):
3820         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3821         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3822         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3823         (WebTestRunner):
3824         (WebTestThemeControlWin):
3825         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3826         (WebTestRunner):
3827         (WebTestThemeEngineMac):
3828         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3829         (+[FakeActiveWindow alwaysActiveWindow]):
3830         (+[FakeActiveWindow alwaysInactiveWindow]):
3831         (-[FakeActiveWindow initWithActiveControls:]):
3832         (-[FakeActiveWindow _hasActiveControls]):
3833         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3834         (WebTestRunner):
3835         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3836         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3837         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3838         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3839         (WebTestRunner):
3840         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3841         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3842         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3843         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3844         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3845         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3846         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3847         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3848         (WebTestRunner::WebTestThemeEngineWin::getSize):
3849         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3850         (WebTestRunner):
3851         (WebTestThemeEngineWin):
3852         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3853         * DumpRenderTree/chromium/TestShell.cpp:
3854         (TestShell::initialize):
3855         * DumpRenderTree/chromium/TestShell.h:
3856         (WebKit):
3857         * DumpRenderTree/chromium/TestShellMac.mm:
3858         (platformInit):
3859         * DumpRenderTree/chromium/TestShellWin.cpp:
3860         (platformInit):
3861         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3862
3863 2013-03-19  Tony Chang  <tony@chromium.org>
3864
3865         Move testRunner.setTouchDragDropEnabled to internals.settings
3866         https://bugs.webkit.org/show_bug.cgi?id=112739
3867
3868         Reviewed by Adam Barth.
3869
3870         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3871         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
3872         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3873         (TestRunner): Remove unnecessary code.
3874         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3875         (WebTestRunner::WebPreferences::reset):
3876         (WebTestRunner::WebPreferences::applyTo): Always set to false.
3877
3878 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
3879
3880         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3881         https://bugs.webkit.org/show_bug.cgi?id=112754
3882
3883         Reviewed by Darin Fisher.
3884
3885         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3886         now that it's always defined.
3887
3888         * DumpRenderTree/chromium/WebViewHost.cpp:
3889         * DumpRenderTree/chromium/WebViewHost.h:
3890         (WebViewHost):
3891
3892 2013-03-19  Kenneth Russell  <kbr@google.com>
3893
3894         Unreviewed, rolling out r146290.
3895         http://trac.webkit.org/changeset/146290
3896         https://bugs.webkit.org/show_bug.cgi?id=112751
3897
3898         Broke Chromium Mac build.
3899
3900         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3901         * DumpRenderTree/DumpRenderTree.gypi:
3902         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3903         (WebKit):
3904         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3905         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3906         (TestInterfaces):
3907         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3908         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3909         * DumpRenderTree/chromium/TestShell.cpp:
3910         (TestShell::initialize):
3911         * DumpRenderTree/chromium/TestShell.h:
3912         (WebKit):
3913         * DumpRenderTree/chromium/TestShellMac.mm:
3914         (platformInit):
3915         * DumpRenderTree/chromium/TestShellWin.cpp:
3916         (platformInit):
3917         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3918         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3919         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3920         (WebThemeControlDRTWin::box):
3921         (WebThemeControlDRTWin::line):
3922         (WebThemeControlDRTWin::triangle):
3923         (WebThemeControlDRTWin::roundRect):
3924         (WebThemeControlDRTWin::oval):
3925         (WebThemeControlDRTWin::circle):
3926         (WebThemeControlDRTWin::nestedBoxes):
3927         (WebThemeControlDRTWin::markState):
3928         (WebThemeControlDRTWin::draw):
3929         (WebThemeControlDRTWin::drawTextField):
3930         (WebThemeControlDRTWin::drawProgressBar):
3931         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3932         (WebThemeControlDRTWin):
3933         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3934         (WebThemeEngineDRTMac):
3935         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3936         (+[FakeActiveWindow alwaysActiveWindow]):
3937         (+[FakeActiveWindow alwaysInactiveWindow]):
3938         (-[FakeActiveWindow initWithActiveControls:]):
3939         (-[FakeActiveWindow _hasActiveControls]):
3940         (WebThemeEngineDRTMac::paintScrollbarThumb):
3941         (stateToHIEnableState):
3942         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3943         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3944         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3945         (webRectToSkIRect):
3946         (drawControl):
3947         (drawTextField):
3948         (drawProgressBar):
3949         (WebThemeEngineDRTWin::paintButton):
3950         (WebThemeEngineDRTWin::paintMenuList):
3951         (WebThemeEngineDRTWin::paintScrollbarArrow):
3952         (WebThemeEngineDRTWin::paintScrollbarThumb):
3953         (WebThemeEngineDRTWin::paintScrollbarTrack):
3954         (WebThemeEngineDRTWin::paintSpinButton):
3955         (WebThemeEngineDRTWin::paintTextField):
3956         (WebThemeEngineDRTWin::paintTrackbar):
3957         (WebThemeEngineDRTWin::paintProgressBar):
3958         (WebThemeEngineDRTWin::getSize):
3959         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3960         (WebThemeEngineDRTWin):
3961         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3962
3963 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3964
3965         [EFL] canvas-fallback-content.html is failing
3966         https://bugs.webkit.org/show_bug.cgi?id=111998
3967
3968         Reviewed by Chris Fleizach.
3969
3970         Adds support for getting platform name.
3971
3972         * DumpRenderTree/TestRunner.cpp:
3973         (TestRunner::staticValues):
3974         * DumpRenderTree/TestRunner.h:
3975         (TestRunner):
3976         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3977         (TestRunner::platformName):
3978
3979 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3980
3981         [chromium] move WebThemeEngine implementations to TestRunner library
3982         https://bugs.webkit.org/show_bug.cgi?id=112751
3983
3984         Reviewed by Adam Barth.
3985
3986         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3987         * DumpRenderTree/DumpRenderTree.gypi:
3988         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3989         (WebKit):
3990         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3991         (WebTestRunner::TestInterfaces::themeEngine):
3992         (WebTestRunner):
3993         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3994         (WebKit):
3995         (TestInterfaces):
3996         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3997         (WebTestRunner::WebTestInterfaces::themeEngine):
3998         (WebTestRunner):
3999         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
4000         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
4001         (WebTestRunner):
4002         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
4003         (WebTestRunner::WebTestThemeControlWin::box):
4004         (WebTestRunner::WebTestThemeControlWin::line):
4005         (WebTestRunner::WebTestThemeControlWin::triangle):
4006         (WebTestRunner::WebTestThemeControlWin::roundRect):
4007         (WebTestRunner::WebTestThemeControlWin::oval):
4008         (WebTestRunner::WebTestThemeControlWin::circle):
4009         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
4010         (WebTestRunner::WebTestThemeControlWin::markState):
4011         (WebTestRunner::WebTestThemeControlWin::draw):
4012         (WebTestRunner::WebTestThemeControlWin::drawTextField):
4013         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
4014         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
4015         (WebTestRunner):
4016         (WebTestThemeControlWin):
4017         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
4018         (WebTestRunner):
4019         (WebTestThemeEngineMac):
4020         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
4021         (+[FakeActiveWindow alwaysActiveWindow]):
4022         (+[FakeActiveWindow alwaysInactiveWindow]):
4023         (-[FakeActiveWindow initWithActiveControls:]):
4024         (-[FakeActiveWindow _hasActiveControls]):
4025         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
4026         (WebTestRunner):
4027         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
4028         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
4029         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
4030         (WebTestRunner::WebTestThemeEngineWin::paintButton):
4031         (WebTestRunner):
4032         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
4033         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
4034         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
4035         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
4036         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
4037         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
4038         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
4039         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
4040         (WebTestRunner::WebTestThemeEngineWin::getSize):
4041         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
4042         (WebTestRunner):
4043         (WebTestThemeEngineWin):
4044         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
4045         * DumpRenderTree/chromium/TestShell.cpp:
4046         (TestShell::initialize):
4047         * DumpRenderTree/chromium/TestShell.h:
4048         (WebKit):
4049         * DumpRenderTree/chromium/TestShellMac.mm:
4050         (platformInit):
4051         * DumpRenderTree/chromium/TestShellWin.cpp:
4052         (platformInit):
4053         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
4054
4055 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4056
4057         [EFL][WK2] Separate WebView further from EwkView
4058         https://bugs.webkit.org/show_bug.cgi?id=111591
4059
4060         Reviewed by Caio Marcelo de Oliveira Filho.
4061
4062         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
4063         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
4064         since we can afford it having EWKViewGetWKView() private API to access WKView.
4065
4066         * TestWebKitAPI/PlatformWebView.h:
4067         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
4068         (TestWebKitAPI::TEST):
4069         * TestWebKitAPI/efl/PlatformWebView.cpp:
4070         (TestWebKitAPI::PlatformWebView::PlatformWebView):
4071         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
4072         (TestWebKitAPI::PlatformWebView::resizeTo):
4073         (TestWebKitAPI::PlatformWebView::page):
4074         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
4075         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
4076         (TestWebKitAPI::PlatformWebView::simulateRightClick):
4077         * WebKitTestRunner/PlatformWebView.h:
4078         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
4079         (WTR::EventSenderProxy::dispatchEvent):
4080         (WTR::EventSenderProxy::keyDown):
4081         (WTR::EventSenderProxy::sendTouchEvent):
4082         (WTR::EventSenderProxy::setTouchModifier):
4083         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4084         (WTR::PlatformWebView::PlatformWebView):
4085         (WTR::PlatformWebView::~PlatformWebView):
4086         (WTR::PlatformWebView::resizeTo):
4087         (WTR::PlatformWebView::page):
4088         (WTR::PlatformWebView::focus):
4089         (WTR::PlatformWebView::windowSnapshotImage):
4090
4091 2013-03-19  Roger Fong  <roger_fong@apple.com>
4092
4093         Changes to VS2010 project files should only trigger builds on Windows bots.
4094         https://bugs.webkit.org/show_bug.cgi?id=112731
4095
4096         Reviewed by Timothy Horton.
4097
4098         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
4099         (_should_file_trigger_build):
4100
4101 2013-03-19  Roger Fong  <roger_fong@apple.com>
4102
4103         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
4104
4105         * Scripts/webkitpy/tool/steps/runtests.py:
4106         (RunTests.run):
4107         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4108         (RunTestsTest.test_webkit_run_unit_tests):
4109
4110 2013-03-19  Julie Parent  <jparent@chromium.org>
4111
4112         Dashboards: Introduce history namespace and unit tests.
4113         https://bugs.webkit.org/show_bug.cgi?id=112645
4114
4115         Reviewed by Ojan Vafai.
4116         
4117         Laying the framework for introducing the new history object and
4118         namespace.  This moves only static functions into the history
4119         namespace, and moves corresponding unit tests into seperate
4120         unit test file.
4121
4122         * TestResultServer/static-dashboards/aggregate_results.html:
4123         * TestResultServer/static-dashboards/dashboard_base.js:
4124         (parseCrossDashboardParameters):
4125         (parseDashboardSpecificParameters):
4126         (parseParameters):
4127         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4128         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4129         (.switch.return):
4130         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4131         * TestResultServer/static-dashboards/history.js: Added.
4132         * TestResultServer/static-dashboards/history_unittests.js: Added.
4133         * TestResultServer/static-dashboards/loader.js:
4134         (.):
4135         * TestResultServer/static-dashboards/run-embedded-unittests.html:
4136         * TestResultServer/static-dashboards/run-unittests.html:
4137         * TestResultServer/static-dashboards/timeline_explorer.html:
4138         * TestResultServer/static-dashboards/timeline_explorer.js:
4139         * TestResultServer/static-dashboards/treemap.html:
4140         * TestResultServer/static-dashboards/treemap.js:
4141         (.switch.return):
4142         * TestResultServer/static-dashboards/ui.js:
4143
4144 2013-03-19  Daniel Bates  <dbates@webkit.org>
4145
4146         svn-apply has trouble applying a patch that adds a Windows newline to EOF
4147         https://bugs.webkit.org/show_bug.cgi?id=112732
4148
4149         Reviewed by Eric Seidel.
4150
4151         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
4152         of an existing file cannot be applied.
4153
4154         In particular, svn-{apply, unapply} compensate for differences in line endings
4155         by converting the line endings in a diff to match the line endings in the target
4156         file. The diff(1) command precedes the last line of a diff that adds a newline
4157         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
4158         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
4159         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
4160         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
4161         the newline characters in this special character sequence to match the line endings
4162         in the target file.
4163
4164         * Scripts/VCSUtils.pm:
4165         (parseDiff):
4166         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
4167         Added tests:
4168             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
4169             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
4170             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
4171             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
4172         (escapeNewLineCharacters): Added.
4173         (toMacLineEndings): Added.
4174
4175 2013-03-19  James Robinson  <jamesr@chromium.org>
4176
4177         [chromium] Remove compositor settings that don't go through WebKit
4178         https://bugs.webkit.org/show_bug.cgi?id=112718
4179
4180         Reviewed by Adam Barth.
4181
4182         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4183         (main):
4184         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
4185         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
4186         (WebTestRunner::WebPreferences::reset):
4187         (WebTestRunner::WebPreferences::applyTo):
4188         * DumpRenderTree/chromium/TestShell.cpp:
4189         (TestShell::TestShell):
4190         (TestShell::resetWebSettings):
4191         * DumpRenderTree/chromium/TestShell.h:
4192         (TestShell):
4193
4194 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
4195
4196         Unreviewed, rolling out r146101.
4197         https://bugs.webkit.org/show_bug.cgi?id=111884
4198
4199         re-enable custom freetype on asan; this needs to be on
4200         now that the bot is running lucid.
4201
4202         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4203
4204 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
4205
4206         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
4207         https://bugs.webkit.org/show_bug.cgi?id=112365
4208
4209         Reviewed by Benjamin Poulain.
4210
4211         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
4212         harcoding it in wtf/Platform.h
4213
4214         * Scripts/webkitperl/FeatureList.pm:
4215
4216 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
4217
4218         [Qt] Make ImageDiff similar to Chromium's ImageDiff
4219         https://bugs.webkit.org/show_bug.cgi?id=94782
4220
4221         Based on patch by Csaba Osztrogonác.
4222         Reviewed by Jocelyn Turcotte.
4223
4224         The diff image is generated with bright red indicating errors, but letting the base image
4225         shine through so the context of the error-pixel can be identified.
4226
4227         * DumpRenderTree/qt/ImageDiff.cpp:
4228         (main):
4229
4230 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
4231
4232         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
4233
4234         Rubber-stamped by Csaba Osztrogonác.
4235
4236         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
4237         since the latter might not cover the former.
4238
4239         * QtTestBrowser/launcherwindow.cpp:
4240         (LauncherWindow::print):
4241
4242 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
4243
4244         Style tweeks to default.css.
4245         
4246         Rubber-stamped by David Kilzer.
4247         
4248         Give visited links a different color to other links, so you can
4249         see which builds you've viewed.
4250         
4251         Make the <small> text less tiny.
4252
4253         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
4254         (small):
4255         (a:link,a:visited,a:active):
4256         (a:visited):
4257
4258 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
4259
4260         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
4261         https://bugs.webkit.org/show_bug.cgi?id=112494
4262
4263         Reviewed by Dirk Pranke.
4264
4265         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
4266         Also merged two pairs of methods to cleanup the code.
4267
4268         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4269         (PerfTestsRunner.run): Merged _upload_and_show_results.
4270         (PerfTestsRunner._generate_results): Merged _generate_output_files.
4271
4272 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
4273
4274         [chromium] build xdisplaycheck when building DRT
4275         https://bugs.webkit.org/show_bug.cgi?id=112636
4276
4277         Reviewed by Tony Chang.
4278
4279         It appears that we need xdisplaycheck to be built in order for
4280         Xvfb to be started correctly on the bots, and DRT was missing
4281         a dependency on it. This may be the cause of the ASAN bot not
4282         starting up properly (it only builds DRT).
4283
4284         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4285
4286 2013-03-18  David Levin  <levin@chromium.org>
4287
4288         Implement icon change notification dump for Chromium's test shell.
4289         https://bugs.webkit.org/show_bug.cgi?id=112614
4290
4291         This was previously implemented for some other platforms in r58111
4292         and r116547.
4293
4294         In r122806, fast/dom/icon-url-property.html stopped using it, but
4295         it is useful for tests, so I plan to re-add it to that test again.
4296
4297         Reviewed by Jochen Eisinger.
4298
4299         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4300         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
4301          icon change notifications from WebKit may be logged in test output.
4302         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4303         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
4304         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
4305         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
4306         (WebTestRunner):
4307         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
4308         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4309         (TestRunner):
4310         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4311         (WebTestRunner::WebTestProxyBase::didChangeIcon):
4312         (WebTestRunner):
4313         * DumpRenderTree/chromium/WebViewHost.cpp:
4314         (WebViewHost::didChangeIcon): Add the output about changing the icon.
4315         * DumpRenderTree/chromium/WebViewHost.h:
4316         (WebViewHost):
4317
4318 2013-03-18  Julie Parent  <jparent@chromium.org>
4319
4320         Cleanup: Move js for treemap and aggregate_results into own js files.
4321         https://bugs.webkit.org/show_bug.cgi?id=112618
4322
4323         Reviewed by Dirk Pranke.
4324         
4325         No functional changes, just moving the code into separate js file
4326         rather than inlined in the html, so we can test it, make it more
4327         modular, etc.  Other dashboard types are already done this way.
4328
4329         * TestResultServer/static-dashboards/aggregate_results.html:
4330         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
4331         (generatePage):
4332         (handleValidHashParameter):
4333         (htmlForBuilder):
4334         (rawValuesHTML):