dcb23bb2fd03fa0eb11c3e358b503aa2e5c56748
[WebKit-https.git] / Tools / ChangeLog
1 2016-10-28  Alex Christensen  <achristensen@webkit.org>
2
3         URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
4         https://bugs.webkit.org/show_bug.cgi?id=164154
5
6         Reviewed by Andy Estes.
7
8         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
9         (TestWebKitAPI::TEST_F):
10
11 2016-10-28  Sam Weinig  <sam@webkit.org>
12
13         [WebIDL] Update parser and code generators to only access type information through the type property
14         https://bugs.webkit.org/show_bug.cgi?id=164141
15
16         Reviewed by Anders Carlsson.
17
18         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
19         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
20         Update to always access type information through type accessors. Remove use of removed
21         properties.
22
23 2016-10-28  Frederic Wang  <fwang@igalia.com>
24
25         [GTK] Upgrade HarfBuzz to version 1.3.3
26         https://bugs.webkit.org/show_bug.cgi?id=162719
27
28         Reviewed by Michael Catanzaro.
29
30         * gtk/jhbuild.modules:
31
32 2016-10-27  Chris Dumez  <cdumez@apple.com>
33
34         Regression(r203601): Caused crashes in iBooks
35         https://bugs.webkit.org/show_bug.cgi?id=164093
36         <rdar://problem/28745634>
37
38         Reviewed by Darin Adler.
39
40         Add API test coverage.
41
42         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
43         * TestWebKitAPI/Tests/mac/DOMNode.mm: Added.
44         (-[DOMNodeTest webView:didFinishLoadForFrame:]):
45         (TestWebKitAPI::TEST):
46
47 2016-10-27  Sam Weinig  <sam@webkit.org>
48
49         [WebIDL] Move code generators off of domSignature::type and onto domSignature::idlType
50         https://bugs.webkit.org/show_bug.cgi?id=164089
51
52         Reviewed by Alex Christensen.
53
54         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
55         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
56         Update for the removal of domSignature::type, and new signatures of helper predicates.
57
58 2016-10-27  Commit Queue  <commit-queue@webkit.org>
59
60         Unreviewed, rolling out r207992.
61         https://bugs.webkit.org/show_bug.cgi?id=164070
62
63         triggered aclocal version conflict (Requested by mcatanzaro on
64         #webkit).
65
66         Reverted changeset:
67
68         "[GTK] Bump glib to 2.50.1 (or find alternative solution to
69         Gtk+ CUPS build issue)"
70         https://bugs.webkit.org/show_bug.cgi?id=163689
71         http://trac.webkit.org/changeset/207992
72
73 2016-10-27  Joanmarie Diggs  <jdiggs@igalia.com>
74
75         [GTK] Bump glib to 2.50.1 (or find alternative solution to Gtk+ CUPS build issue)
76         https://bugs.webkit.org/show_bug.cgi?id=163689
77
78         Reviewed by Michael Catanzaro.
79
80         In order to fix bug #163591, we need to apply an upstream patch to GTK+.
81         But GTK+ won't build with that patch due to the following error:
82
83             m4_copy: won't overwrite defined macro: glib_DEFUN
84
85         There is an upstream GLib patch which solves that issue. We should apply
86         that patch as well, until we bump GLib to 2.50.1 or later.
87
88         * gtk/jhbuild.modules: Apply upstream GLib patch.
89         * gtk/patches/glib-deprecate-am-glib-gnu-gettext.patch: Added.
90
91 2016-10-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
92
93         Unreviewed fix of GTK and EFL test bots.
94
95         * Scripts/webkitperl/FeatureList.pm: Deactivated media-source and
96         legacy-encrypted-media by default for GTK and EFL.
97
98 2016-10-26  Yusuke Suzuki  <utatane.tea@gmail.com>
99
100         [GTK] JSC test wasm.yaml/wasm/js-api/test_basic_api.js.default-wasm and wasm.yaml/wasm/js-api/test_Module.js.default-wasm fail with Exception: ReferenceError: Can't find variable: WebAssembly
101         https://bugs.webkit.org/show_bug.cgi?id=163846
102
103         Reviewed by Michael Catanzaro.
104
105         WebAssembly is now developed for Darwin right now.
106         Disable WASM tests in the other platforms.
107
108         * Scripts/run-jsc-stress-tests:
109
110 2016-10-26  Enrique Ocaña González  <eocanha@igalia.com>
111
112         [cmake][GStreamer][MSE][EME] Build MSE and EME code after refactoring
113         https://bugs.webkit.org/show_bug.cgi?id=162928
114
115         Reviewed by Xabier Rodriguez-Calvar.
116
117         Explicitly enable MSE and EME on WebKitGTK+ buildbots.
118
119         This patch is co-authored with Philippe Normand <philn@igalia.com> (EME support).
120
121         * Scripts/webkitperl/FeatureList.pm:
122
123 2016-10-25  Antoine Quint  <graouts@apple.com>
124
125         [Modern Media Controls] Media Controller: skip back support
126         https://bugs.webkit.org/show_bug.cgi?id=163725
127         <rdar://problem/27989480>
128
129         Reviewed by Dean Jackson.
130
131         * Scripts/webkitpy/layout_tests/servers/aliases.json: Adding a new alias such that we may
132         access the modern-media-controls source files through the web server.
133
134 2016-10-19  Jer Noble  <jer.noble@apple.com>
135
136         Add WKWebView fullscreen delegate SPI
137         https://bugs.webkit.org/show_bug.cgi?id=163674
138
139         Reviewed by Anders Carlsson.
140
141         Add a new API test which verifies that the fullscreen delegate receives notifications.
142
143         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
144         (-[FullscreenDelegateMessageHandler userContentController:didReceiveScriptMessage:]):
145         (-[FullscreenDelegateMessageHandler _webViewWillEnterFullscreen:]):
146         (-[FullscreenDelegateMessageHandler _webViewDidEnterFullscreen:]):
147         (-[FullscreenDelegateMessageHandler _webViewWillExitFullscreen:]):
148         (-[FullscreenDelegateMessageHandler _webViewDidExitFullscreen:]):
149         (TestWebKitAPI::TEST):
150
151 2016-10-24  Alex Christensen  <achristensen@webkit.org>
152
153         URLParser should match old URL::parse with %2E in path
154         https://bugs.webkit.org/show_bug.cgi?id=163929
155
156         Reviewed by Alexey Proskuryakov.
157
158         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
159         (TestWebKitAPI::TEST_F):
160
161 2016-10-24  Ryan Haddad  <ryanhaddad@apple.com>
162
163         Unreviewed, rolling out r207795.
164
165         Introduced API test failures on iOS and macOS.
166
167         Reverted changeset:
168
169         "URLParser should match old URL::parse with %2E in path"
170         https://bugs.webkit.org/show_bug.cgi?id=163929
171         http://trac.webkit.org/changeset/207795
172
173 2016-10-24  Alex Christensen  <achristensen@webkit.org>
174
175         URLParser should match old URL::parse with %2E in path
176         https://bugs.webkit.org/show_bug.cgi?id=163929
177
178         Reviewed by Alexey Proskuryakov.
179
180         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
181         (TestWebKitAPI::TEST_F):
182
183 2016-10-21  Alex Christensen  <achristensen@webkit.org>
184
185         URL::port should return Optional<uint16_t>
186         https://bugs.webkit.org/show_bug.cgi?id=163806
187
188         Reviewed by Darin Adler.
189
190         * TestWebKitAPI/Tests/WebCore/URL.cpp:
191         (TestWebKitAPI::TEST_F):
192         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
193         (TestWebKitAPI::checkURL):
194         (TestWebKitAPI::checkRelativeURL):
195         (TestWebKitAPI::checkURLDifferences):
196         (TestWebKitAPI::checkRelativeURLDifferences):
197         (TestWebKitAPI::TEST_F):
198
199 2016-10-24  Youenn Fablet  <youenn@apple.com>
200
201         Activate WEB_RTC compilation flags for Mac bots
202         https://bugs.webkit.org/show_bug.cgi?id=163886
203
204         Reviewed by Eric Carlson.
205
206         * Scripts/webkitperl/FeatureList.pm:
207         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
208
209 2016-10-24  Wenson Hsieh  <wenson_hsieh@apple.com>
210
211         Unreviewed, add myself as a WebKit reviewer
212
213         * Scripts/webkitpy/common/config/contributors.json:
214
215 2016-10-22  Dan Bernstein  <mitz@apple.com>
216
217         Improve MiniBrowser window titles for URLs without paths and with no title
218         <https://webkit.org/b/163843>
219
220         Reviewed by Darin Adler.
221
222         * MiniBrowser/mac/WK1BrowserWindowController.m:
223         (-[WK1BrowserWindowController fetch:]): While we’re here, deploy
224           +[NSURL _webkit_URLWithUserTypedString:] here to match the WK2BrowserWindowController
225           version of this method.
226         (-[WK1BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
227           use the entire URL.
228         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]): Also while we’re here,
229           deploy +[NSURL _web_userVisibleString] here to match the WK2BrowserWindowController
230           behavior.
231
232         * MiniBrowser/mac/WK2BrowserWindowController.m:
233         (-[WK2BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
234           use the entire URL.
235
236 2016-10-21  David Kilzer  <ddkilzer@apple.com>
237
238         Bug 163762: IntSize::area() should used checked arithmetic
239         <https://webkit.org/b/163762>
240
241         Reviewed by Darin Adler.
242
243         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
244         (TestWebKitAPI::TEST): Call unsafeGet().
245         * TestWebKitAPI/Tests/WebCore/IntSize.cpp:
246         (TestWebKitAPI::TEST): Ditto.
247
248 2016-10-21  James Craig  <jcraig@apple.com>
249
250         Unreviewed: Added Aaron Chu <aaron_chu@apple.com> to contributors list.
251
252         * Scripts/webkitpy/common/config/contributors.json:
253
254 2016-10-21  Commit Queue  <commit-queue@webkit.org>
255
256         Unreviewed, rolling out r207582.
257         https://bugs.webkit.org/show_bug.cgi?id=163819
258
259         Not quite ready rdar://problem/28897179 (Requested by
260         alexchristensen on #webkit).
261
262         Reverted changeset:
263
264         "Re-enable URLParser for non-Safari Cocoa apps after r207321"
265         https://bugs.webkit.org/show_bug.cgi?id=163690
266         http://trac.webkit.org/changeset/207582
267
268 2016-10-21  Jonathan Bedard  <jbedard@apple.com>
269
270         WebKitTestRunnerApp packages .idl file
271         https://bugs.webkit.org/show_bug.cgi?id=163788
272
273         Reviewed by Darin Adler.
274
275         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Removed .idl file from app package, removed bad reference to app icon.
276
277 2016-10-21  Csaba Osztrogonác  <ossy@webkit.org>
278
279         [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package
280         https://bugs.webkit.org/show_bug.cgi?id=163733
281
282         Reviewed by Gyuyoung Kim.
283
284         * efl/install-dependencies: Added geoclue-2.0 package.
285
286 2016-10-21  Commit Queue  <commit-queue@webkit.org>
287
288         Unreviewed, rolling out r207609.
289         https://bugs.webkit.org/show_bug.cgi?id=163776
290
291         As glib bump was rollout, we need to rollout this too
292         (Requested by rego on #webkit).
293
294         Reverted changeset:
295
296         "[GTK] Cannot build GTK+ with CUPS 2.* versions"
297         https://bugs.webkit.org/show_bug.cgi?id=163591
298         http://trac.webkit.org/changeset/207609
299
300 2016-10-20  Chris Dumez  <cdumez@apple.com>
301
302         "Download Linked File" context menu action should use 'download' attribute as suggested filename
303         https://bugs.webkit.org/show_bug.cgi?id=163742
304         <rdar://problem/28840734>
305
306         Reviewed by Darin Adler.
307
308         Add API test coverage.
309
310         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
311         * TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Added.
312         * TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Added.
313         (TestWebKitAPI::didFinishLoadForFrame):
314         (TestWebKitAPI::getContextMenuFromProposedMenu):
315         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
316         (TestWebKitAPI::TEST):
317
318 2016-10-20  Commit Queue  <commit-queue@webkit.org>
319
320         Unreviewed, rolling out r207589.
321         https://bugs.webkit.org/show_bug.cgi?id=163765
322
323         Introduced 17 new layout test failures (Requested by
324         mcatanzaro on #webkit).
325
326         Reverted changeset:
327
328         "[GTK] Bump glib to 2.50.1"
329         https://bugs.webkit.org/show_bug.cgi?id=163689
330         http://trac.webkit.org/changeset/207589
331
332 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
333
334         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
335         https://bugs.webkit.org/show_bug.cgi?id=163374
336
337         Reviewed by Darin Adler.
338
339         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
340
341 2016-10-20  Sam Weinig  <sam@webkit.org>
342
343         Add convenience function that combines WTF::visit(...) with WTF::makeVisitor(...)
344         https://bugs.webkit.org/show_bug.cgi?id=163713
345
346         Reviewed by Dan Bernstein.
347
348         * TestWebKitAPI/Tests/WTF/Variant.cpp:
349         Add test for WTF::switchOn()
350
351 2016-10-20  Fujii Hironori  <Hironori.Fujii@sony.com>
352
353         [CMake] CMake does not support the dep files for implicit dependency
354         https://bugs.webkit.org/show_bug.cgi?id=161433
355
356         Reviewed by Brent Fulgham.
357
358         Created a Perl script to generate all IDL bindings for CMake.
359         This script can regenerate outdated bindings by based on the
360         supplemental dependency and dep files created by
361         '--write-dependencies' switch of generate-bindings.pl.
362
363         add_custom_target is used to invoke the script instead of
364         add_custom_command because Ninja deletes all output files before
365         executing the command in case of add_custom_command.
366
367         USES_TERMINAL option of add_custom_target has two effects:
368         1) Not buffering output of the command
369         2) Invoking the command in the special Ninja pool which inhibits parallel build
370         One needs to use CMake 3.2 or later to enable this feature.
371
372         * DumpRenderTree/CMakeLists.txt: Specified a target name for
373         GENERATE_BINDINGS. Added dependency for the target.
374         * WebKitTestRunner/CMakeLists.txt: Ditto.
375
376 2016-10-20  Manuel Rego Casasnovas  <rego@igalia.com>
377
378         [GTK] Cannot build GTK+ with CUPS 2.* versions
379         https://bugs.webkit.org/show_bug.cgi?id=163591
380
381         Reviewed by Michael Catanzaro.
382
383         GTK+ is wrongly checking about the available CUPS version,
384         so if you have CUPS 2.* the configure step fails.
385
386         This has been already fixed upstream and included in 2.30 series:
387         https://git.gnome.org/browse/gtk+/commit/?id=631f6b536485829a0bd00532f5826ad302b4951b
388
389         Added patch on JHBuild so we can now build GTK+ with CUPS 2.*.
390
391         * gtk/jhbuild.modules: Applied patch and avoid using "configure" script directly
392         as the patch modifies "configure.ac".
393         * gtk/patches/configure-fix-detecting-CUPS-2.x.patch: Added.
394
395 2016-10-20  Manuel Rego Casasnovas  <rego@igalia.com>
396
397         [GTK] Bump glib to 2.50.1
398         https://bugs.webkit.org/show_bug.cgi?id=163689
399
400         Reviewed by Michael Catanzaro.
401
402         This is need in order to fix GTK+ build with CUPS 2.* (bug #163591).
403
404         * gtk/jhbuild.modules: Bump glib version. Pass --disable-libmount to build properly.
405         Also we don't need the patches anymore.
406         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.
407         * gtk/patches/glib-warning-fix.patch: Removed.
408
409 2016-10-19  Alex Christensen  <achristensen@webkit.org>
410
411         Re-enable URLParser for non-Safari Cocoa apps after r207321
412         https://bugs.webkit.org/show_bug.cgi?id=163690
413
414         Reviewed by Darin Adler.
415
416         * DumpRenderTree/mac/DumpRenderTree.mm:
417         (DumpRenderTreeMain):
418         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
419         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
420         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
421         (TestWebKitAPI::TEST):
422         * WebKitTestRunner/TestController.cpp:
423         (WTR::TestController::TestController):
424
425 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
426
427         Unreviewed, rolling out r207557.
428
429         This change caused animations/font-variations tests to time
430         out on pre-Sierra Macs.
431
432         Reverted changeset:
433
434         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
435         iOS 9"
436         https://bugs.webkit.org/show_bug.cgi?id=163374
437         http://trac.webkit.org/changeset/207557
438
439 2016-10-19  Andy Estes  <aestes@apple.com>
440
441         Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
442         https://bugs.webkit.org/show_bug.cgi?id=163476
443         <rdar://problem/26941395>
444
445         Reviewed by Andreas Kling.
446
447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
448         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
449         (TEST): Added an API test that passes a nil MIMEType to
450         -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
451
452 2016-10-19  Jer Noble  <jer.noble@apple.com>
453
454         Modify testrunner to mute audio during tests
455         https://bugs.webkit.org/show_bug.cgi?id=162582
456
457         Reviewed by Alexey Proskuryakov.
458
459         * DumpRenderTree/mac/DumpRenderTree.mm:
460         (createWebViewAndOffscreenWindow):
461         * WebKitTestRunner/TestController.cpp:
462         (WTR::TestController::resetStateToConsistentValues):
463
464 2016-10-19  Joseph Pecoraro  <pecoraro@apple.com>
465
466         check-webkit-style: fix false-positive warnings about using #pragma once header guard
467         https://bugs.webkit.org/show_bug.cgi?id=163575
468
469         Reviewed by Brady Eidson.
470
471         There were some false positive warnings about header guards
472         for ObjC headers that don't need guards. This changes the
473         style checker to no longer warn if there is no #pragma once.
474         It only warns if there are #ifndef that should be #pragma once.
475
476         * Scripts/webkitpy/style/checkers/cpp.py:
477         (check_for_header_guard):
478         Change when we output an error.
479
480         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
481         (CppStyleTest.test_build_header_guard):
482         Update tests.
483
484 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
485
486         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
487         https://bugs.webkit.org/show_bug.cgi?id=163374
488
489         Reviewed by Darin Adler.
490
491         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
492
493 2016-10-18  Philippe Normand  <pnormand@igalia.com>
494
495         WebRTC: [GTK] Update jhbuild environment for OpenWebRTC
496         https://bugs.webkit.org/show_bug.cgi?id=163330
497
498         Reviewed by Michael Catanzaro.
499
500         Bring back the openwebrtc JHBuild moduleset in the time being. It
501         should be removed after the bump to GStreamer 1.10 is complete and
502         the libnice patches have been upstreamed. The GStreamer git
503         snapshots used in this patch are the ones configured in Ericsson's
504         GStreamer Cerbero fork.
505
506         * gtk/openwebrtc.modules: Added.
507         * gtk/patches/libnice-0001-TURN-allow-REALM-to-be-empty.patch: Added.
508         * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Added.
509         * gtk/patches/libnice-0001-nicesrc-spin-the-agent-mainloop-in-a-separate-thread.patch: Added.
510         * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Added.
511         * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Added.
512         * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Added.
513         * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Added.
514
515 2016-10-18  Sam Weinig  <sam@webkit.org>
516
517         Replace std::experimental::variant with WTF::Variant (or similar)
518         https://bugs.webkit.org/show_bug.cgi?id=163626
519
520         Reviewed by Chris Dumez.
521
522         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
523         into the WTF namespace.
524
525         * TestWebKitAPI/Tests/WTF/Variant.cpp:
526         (TestWebKitAPI::TEST):
527
528 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
529
530         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
531         https://bugs.webkit.org/show_bug.cgi?id=163627
532
533         Reviewed by Dean Jackson.
534
535         Rename setScale: to setViewScale: and add setPageScale:, hooking it up for WK1 (via exisiting SPI)
536         and WK2 (via new SPI).
537
538         * MiniBrowser/mac/BrowserWindowController.h:
539         * MiniBrowser/mac/BrowserWindowController.m:
540         (-[BrowserWindowController pageScaleForMenuItemTag:]):
541         (-[BrowserWindowController setPageScale:]):
542         (-[BrowserWindowController setViewScale:]):
543         (-[BrowserWindowController setScale:]): Deleted.
544         * MiniBrowser/mac/MainMenu.xib:
545         * MiniBrowser/mac/WK1BrowserWindowController.m:
546         (-[WK1BrowserWindowController setPageScale:]):
547         (-[WK1BrowserWindowController setViewScale:]):
548         (areEssentiallyEqual):
549         (-[WK1BrowserWindowController validateMenuItem:]):
550         (-[WK1BrowserWindowController setScale:]): Deleted.
551         * MiniBrowser/mac/WK2BrowserWindowController.m:
552         (-[WK2BrowserWindowController setPageScale:]):
553         (-[WK2BrowserWindowController viewScaleForMenuItemTag:]):
554         (-[WK2BrowserWindowController setViewScale:]):
555         (areEssentiallyEqual):
556         (-[WK2BrowserWindowController validateMenuItem:]):
557         (viewScaleForMenuItemTag): Deleted.
558         (-[WK2BrowserWindowController setScale:]): Deleted.
559
560 2016-10-18  Anders Carlsson  <andersca@apple.com>
561
562         Add an beforeunload alert to the WebKitLegacy MiniBrowser
563         https://bugs.webkit.org/show_bug.cgi?id=163634
564
565         Reviewed by Sam Weinig.
566
567         * MiniBrowser/mac/WK1BrowserWindowController.m:
568         (-[WK1BrowserWindowController webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
569
570 2016-10-18  Commit Queue  <commit-queue@webkit.org>
571
572         Unreviewed, rolling out r207443.
573         https://bugs.webkit.org/show_bug.cgi?id=163616
574
575         "Caused 5% PLT regression" (Requested by krollin on #webkit).
576
577         Reverted changeset:
578
579         "Crash in ASCIICaseInsensitiveHash::hash() when a response has
580         a null MIME type"
581         https://bugs.webkit.org/show_bug.cgi?id=163476
582         http://trac.webkit.org/changeset/207443
583
584 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
585
586         [MediaStream] Resolve constraints and enumerate devices in the UI process
587         https://bugs.webkit.org/show_bug.cgi?id=162147
588         <rdar://problem/28803569>
589
590         Reviewed by Darin Adler.
591
592         * WebKitTestRunner/TestController.cpp:
593         (WTR::TestController::resetPreferencesToConsistentValues): Enable mock capture devices.
594         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update for API changes.
595
596 2016-10-17  Megan Gardner  <megan_gardner@apple.com>
597
598         Add test and infrastructure for link popover
599         https://bugs.webkit.org/show_bug.cgi?id=163406
600
601         Reviewed by Simon Fraser.
602
603         Added functionality test for link popovers.
604         Can query for what URL is loaded, and that the popover has appeared or has
605         been dismissed.
606         Added a link popover test.
607
608         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
609         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
610         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
611         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
612         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
613         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
614         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
615         (WTR::UIScriptController::setDidShowForcePressPreviewCallback):
616         (WTR::UIScriptController::didShowForcePressPreviewCallback):
617         (WTR::UIScriptController::setDidDismissForcePressPreviewCallback):
618         (WTR::UIScriptController::didDismissForcePressPreviewCallback):
619         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
620         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
621         (WTR::UIScriptController::didEndFormControlInteractionCallback): Deleted.
622         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
623         * TestRunnerShared/UIScriptContext/UIScriptController.h:
624         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
625         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
626         (-[TestRunnerWKWebView dealloc]):
627         (-[TestRunnerWKWebView didShowForcePressPreview]):
628         (-[TestRunnerWKWebView didDismissForcePressPreview]):
629         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
630         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
631         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
632         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
633
634 2016-10-17  Tim Horton  <timothy_horton@apple.com>
635
636         REGRESSION (r169805): WKWebView canGoBack returning YES when nothing is in the back-forward list after restoring session state
637         https://bugs.webkit.org/show_bug.cgi?id=163573
638         <rdar://problem/28744549>
639
640         Reviewed by Dan Bernstein.
641
642         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
643         (TEST):
644         Add a test ensuring that canGoBack returns NO after restoring session state without navigating.
645
646 2016-10-17  Andy Estes  <aestes@apple.com>
647
648         Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
649         https://bugs.webkit.org/show_bug.cgi?id=163476
650         <rdar://problem/26941395>
651
652         Reviewed by Tim Horton.
653
654         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
655         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
656         (TEST): Added an API test that passes a nil MIMEType to
657         -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
658
659 2016-10-17  Dean Jackson  <dino@apple.com>
660
661         Allow creation of ExtendedColors and make Color immutable
662         https://bugs.webkit.org/show_bug.cgi?id=163557
663         <rdar://problem/28805360>
664
665         Reviewed by Darin Adler and Dave Hyatt.
666
667         API tests for ExtendedColor.
668
669         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
670         * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp: Added.
671         (TestWebKitAPI::TEST):
672         (TestWebKitAPI::makeColor):
673
674 2016-10-17  JF Bastien  <jfbastien@apple.com>
675
676         WebAssembly JS API: implement basic stub
677
678         Implement the global WebAssembly JavaScript object, and its constructor +
679         function properties as described in:
680           https://github.com/WebAssembly/design/blob/master/JS.md
681
682         These don't do anything at the moment, the parent bug will take care of adding
683         more functionality and associated tests.
684
685         WebAssembly JS API: implement basic stub
686         https://bugs.webkit.org/show_bug.cgi?id=163404
687
688         Reviewed by Keith Miller.
689
690         * Scripts/run-jsc-stress-tests: use the new JSC option which exposes the WebAssembly object.
691
692 2016-10-17  Fujii Hironori  <Hironori.Fujii@sony.com>
693
694         resolve-ChangeLogs: Specify --no-page to git diff
695         https://bugs.webkit.org/show_bug.cgi?id=163441
696
697         Reviewed by Darin Adler.
698
699         resolve-ChangeLogs shows the result after resolving by invoking
700         'git diff'. It runs a pager for every ChangeLog if it is under
701         TTY.
702
703         * Scripts/resolve-ChangeLogs:
704         (showStatus): Specify '--no-page' to git diff.
705
706 2016-10-17  Michael Catanzaro  <mcatanzaro@igalia.com>
707
708         Move user agent quirks to cross-platform location
709         https://bugs.webkit.org/show_bug.cgi?id=163508
710
711         Reviewed by Carlos Garcia Campos.
712
713         Move the test to a cross-platform location and improve it to better check the full list of
714         sites we have defined quirks for.
715
716         * TestWebKitAPI/PlatformGTK.cmake:
717         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp.
718         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
719         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
720         (TestWebKitAPI::TEST):
721
722 2016-10-17  Carlos Garcia Campos  <cgarcia@igalia.com>
723
724         [SOUP] Downloads should always sniff contents
725         https://bugs.webkit.org/show_bug.cgi?id=163538
726
727         Reviewed by Michael Catanzaro.
728
729         Add a test case to check that the MIME type is correctly guessed for downloads.
730
731         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
732         (writeNextChunk):
733         (serverCallback):
734         (testDownloadMIMEType):
735         (beforeAll):
736         (writeNextChunkIdle): Deleted.
737
738 2016-10-16  Daniel Bates  <dabates@apple.com>
739
740         Fix Perl warning about masked variable following <http://trac.webkit.org/changeset/207382>
741         (https://bugs.webkit.org/show_bug.cgi?id=163456)
742
743         * Scripts/prepare-ChangeLog:
744         (actuallyGenerateFunctionLists):
745
746 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
747
748         Unreviewed. Fix GTK+ unit test /webkit2/WebKitWebContext/languages after r206949.
749
750         After r206949 navigator.language returns en-US instead of en-us. Language tags in Accept-Language header are
751         actually case-insensitive, so we should actually do case-insensitive comparisons, but we only have
752         g_assert_cmpstr for tests.
753
754         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
755         (testWebContextLanguages):
756
757 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
758
759         [GTK] WebKitWebPage URI not updated after URI is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
760         https://bugs.webkit.org/show_bug.cgi?id=163389
761
762         Reviewed by Michael Catanzaro.
763
764         Update /webkit2/WebKitWebPage/get-uri test to check that web view and page uri always match even when request is
765         modified by WebKitWebPage::send-request signal.
766
767         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
768         (testWebPageURI):
769
770 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
771
772         Document request not updated after willSendRequest is called for a redirect
773         https://bugs.webkit.org/show_bug.cgi?id=163436
774
775         Reviewed by Michael Catanzaro.
776
777         Update /webkit2/WebKitWebView/active-uri test to check the active URI also when modified by
778         WebKitPage::send-request signal in a web extension.
779
780         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
781         (testWebViewActiveURI):
782         (serverCallback):
783         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
784         (sendRequestCallback):
785         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
786         (loadChangedCallback):
787
788 2016-10-15  Dan Bernstein  <mitz@apple.com>
789
790         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
791         https://bugs.webkit.org/show_bug.cgi?id=163492
792         <rdar://problem/28654799>
793
794         Reviewed by Darin Adler.
795
796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
797         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm: Added.
798         (-[ContextMenuDefaultItemsHaveTagsDelegate webView:didFinishLoadForFrame:]):
799         (TestWebKitAPI::TEST):
800
801 2016-10-15  Daniel Bates  <dabates@apple.com>
802
803         prepare-ChangeLog erroneously said that a python __init__ method was deleted
804         https://bugs.webkit.org/show_bug.cgi?id=163456
805
806         Reviewed by Simon Fraser.
807
808         Fixes an issue where prepare-ChangeLog may list as deleted functions that are
809         immediately above added code.
810
811         Currently prepare-ChangeLog makes use of the same overlap detection algorithm
812         to compute the list of deleted functions as it does to compute added and modified
813         functions. We consider a function deleted if its entire function body and signature
814         are removed. It is sufficient to compare the list of functions before the patch
815         is applied and the list of functions are the patch is applied to identify
816         these functions.
817
818         * Scripts/prepare-ChangeLog: Fix some style nits, including using Camel Case for
819         variable names.
820         (actuallyGenerateFunctionLists): Modified to call computeModifiedFunctions(). Always
821         compute the list of functions in the file after the patch regardless of whether the
822         patch only contains deletions. We will compare this list against the list of functions
823         before the patch was applied to determine the deleted functions.
824         (computeModifiedFunctions): Renamed; formerly named generateFunctionListsByRanges.
825         Removed out argument for the seen functions as we no longer make use of when computing
826         the list of deleted functions.
827         (diffCommand): Update comment.
828         (generateFunctionListsByRanges): Deleted.
829         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added more unit tests.
830
831 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
832
833         REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name'
834         https://bugs.webkit.org/show_bug.cgi?id=163478
835
836         Reviewed by Daniel Bates.
837         
838         Handle a None other in Contributor.__eq__.
839
840         * Scripts/webkitpy/common/config/committers.py:
841         (Contributor.__eq__):
842
843 2016-10-14  JF Bastien  <jfbastien@apple.com>
844
845         Basic WebAssembly testing
846
847         Create a small DSL in JavaScript which can build WebAssembly binary modules based on the JSON description of the format as described in:
848         https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md
849
850         This DSL can then be used to write small text description of valid and invalid WebAssembly binaries, making testing the JSC implementation much easier.
851
852         Details and example in README.md.
853
854         Basic WebAssembly testing
855         https://bugs.webkit.org/show_bug.cgi?id=163267
856
857         Reviewed by Keith Miller.
858
859         * Scripts/run-javascriptcore-tests:
860         (runJSCStressTests): run wasm.yaml tests
861         * Scripts/run-jsc-stress-tests: add a WebAssembly-specific runner
862
863 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
864
865         Annotate bots in contributors.json and don't show them on webkit.org/team
866         https://bugs.webkit.org/show_bug.cgi?id=163317
867
868         Reviewed by Daniel Bates.
869         
870         Add "class" : "bot" for non-humans in contributors.json and round-trip it.
871
872         * Scripts/webkitpy/common/config/committers.py:
873         (Contributor.__init__):
874         (Contributor.as_dict):
875         (Bot):
876         (Bot.__init__):
877         (CommitterList.load_json):
878         * Scripts/webkitpy/common/config/contributors.json:
879
880 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
881
882         Fix printing in WK2 MiniBrowser
883         https://bugs.webkit.org/show_bug.cgi?id=163455
884
885         Reviewed by Tim Horton.
886         
887         Call the basic -_printOperationWithPrintInfo: which doens't require a frame argument.
888
889         * MiniBrowser/mac/WK2BrowserWindowController.m:
890         (-[WK2BrowserWindowController printWebView:]):
891
892 2016-10-14  Commit Queue  <commit-queue@webkit.org>
893
894         Unreviewed, rolling out r207335.
895         https://bugs.webkit.org/show_bug.cgi?id=163445
896
897         WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing
898         out on Mac bots (Requested by youenn on #webkit).
899
900         Reverted changeset:
901
902         "Add ProvisionalURLAfterWillSendRequestCallback.cpp and
903         ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac
904         builds"
905         https://bugs.webkit.org/show_bug.cgi?id=163440
906         http://trac.webkit.org/changeset/207335
907
908 2016-10-14  Youenn Fablet  <youenn@apple.com>
909
910         Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac builds
911         https://bugs.webkit.org/show_bug.cgi?id=163440
912
913         Unreviewed.
914
915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Adding new test files introduced in
916         https://bugs.webkit.org/show_bug.cgi?id=146306 patch.
917
918 2016-10-13  Carlos Garcia Campos  <cgarcia@igalia.com>
919
920         Unreviewed. Removed myself from BindingsScripts watch list.
921
922         * Scripts/webkitpy/common/config/watchlist:
923
924 2016-10-13  Carlos Garcia Campos  <cgarcia@igalia.com>
925
926         WebView and WebPage URLs not updated after URL is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
927         https://bugs.webkit.org/show_bug.cgi?id=146306
928
929         Reviewed by Darin Adler.
930
931         Add unit test to check that the committed URL is updated when changed in willSendRequest callback.
932
933         * TestWebKitAPI/CMakeLists.txt:
934         * TestWebKitAPI/PlatformEfl.cmake:
935         * TestWebKitAPI/PlatformGTK.cmake:
936         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Added.
937         (TestWebKitAPI::didCommitLoadForFrame):
938         (TestWebKitAPI::TEST):
939         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Added.
940         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::ProvisionalURLAfterWillSendRequestCallbackTest):
941         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::willSendRequestForFrame):
942         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::didCommitLoadForFrame):
943
944 2016-10-13  Alex Christensen  <achristensen@webkit.org>
945
946         Hosts of URLs with non-special schemes should be case-sensitive, and non-ASCII characters in such hosts should be punycode-encoded
947         https://bugs.webkit.org/show_bug.cgi?id=163413
948
949         Reviewed by Tim Horton.
950
951         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
952         (TestWebKitAPI::TEST_F):
953         Update parsing results.  There are now fewer differences between the new URLParser and the old URL::parse.
954
955 2016-10-13  Alex Christensen  <achristensen@webkit.org>
956
957         Rebase API tests after r207305.
958
959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
960         Actually build Tests/mac/LoadInvalidURLRequest.mm so we are running the WebKit1.LoadInvalidURLRequest API test.
961         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
962         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
963         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
964         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
965         Change results back to what they were before r207162, r207167, and r207184.
966
967 2016-10-13  Alex Christensen  <achristensen@webkit.org>
968
969         Disable URLParser for non-Safari iOS and Mac apps for now
970         https://bugs.webkit.org/show_bug.cgi?id=163397
971
972         Reviewed by Tim Horton.
973
974         * DumpRenderTree/mac/DumpRenderTree.mm:
975         (DumpRenderTreeMain):
976         * WebKitTestRunner/TestController.cpp:
977         Enable the URLParser for testing.
978         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
979         Link with WebCoreTestSupport so we can find setURLParserEnabled.
980
981 2016-10-13  Ryan Haddad  <ryanhaddad@apple.com>
982
983         Unreviewed, rolling out r207297.
984
985         This change broke the iOS build.
986
987         Reverted changeset:
988
989         "Disable URLParser for non-Safari iOS and Mac apps for now"
990         https://bugs.webkit.org/show_bug.cgi?id=163397
991         http://trac.webkit.org/changeset/207297
992
993 2016-10-13  Alex Christensen  <achristensen@webkit.org>
994
995         Disable URLParser for non-Safari iOS and Mac apps for now
996         https://bugs.webkit.org/show_bug.cgi?id=163397
997
998         Reviewed by Tim Horton.
999
1000         * DumpRenderTree/mac/DumpRenderTree.mm:
1001         (DumpRenderTreeMain):
1002         * WebKitTestRunner/ios/mainIOS.mm:
1003         (main):
1004         * WebKitTestRunner/mac/main.mm:
1005         (main):
1006
1007 2016-10-12  Alex Christensen  <achristensen@webkit.org>
1008
1009         Fix out-of-bounds reading in URLParser when parsing improperly percent-encoded values
1010         https://bugs.webkit.org/show_bug.cgi?id=163376
1011
1012         Reviewed by Saam Barati.
1013
1014         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1015         (TestWebKitAPI::TEST_F):
1016
1017 2016-10-11  Dean Jackson  <dino@apple.com>
1018
1019         Add preliminary support for extended colors to WebCore::Color
1020         https://bugs.webkit.org/show_bug.cgi?id=162878
1021         <rdar://problem/28596413>
1022
1023         Reviewed by Darin Adler.
1024
1025         A new API test for Colors.
1026
1027         * TestWebKitAPI/Tests/WebCore/Color.cpp:
1028         (TestWebKitAPI::TEST):
1029
1030 2016-10-12  Ryan Haddad  <ryanhaddad@apple.com>
1031
1032         Unreviewed, rolling out r207225.
1033
1034         This change causes debug tests to exit early with crashes.
1035
1036         Reverted changeset:
1037
1038         "Optional's move-constructor and move-assignment operator
1039         don't disengage the value being moved from"
1040         https://bugs.webkit.org/show_bug.cgi?id=163309
1041         http://trac.webkit.org/changeset/207225
1042
1043 2016-10-12  Alex Christensen  <achristensen@webkit.org>
1044
1045         Fix assertion after switching to URLParser
1046         https://bugs.webkit.org/show_bug.cgi?id=163350
1047         rdar://problem/28739938
1048
1049         Reviewed by Brady Eidson.
1050
1051         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1052         (TEST):
1053
1054 2016-10-11  Sam Weinig  <sam@webkit.org>
1055
1056         Optional's move-constructor and move-assignment operator don't disengage the value being moved from
1057         https://bugs.webkit.org/show_bug.cgi?id=163309
1058
1059         Reviewed by Anders Carlsson.
1060
1061         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1062         (TestWebKitAPI::TEST):
1063         Add tests for Optional's move-constructor and move-assignment operator.
1064
1065 2016-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1066
1067         Now playing media sessions are always cleared for the active foreground tab
1068         https://bugs.webkit.org/show_bug.cgi?id=163310
1069         <rdar://problem/28573301>
1070
1071         Reviewed by Jer Noble.
1072
1073         Tweaks existing unit tests to verify that media session info persists when backgrounding and foregrounding, but
1074         that media session info is correctly cleared out if the media session itself is no longer eligible for Now
1075         Playing (not accounting for foreground/active state). Previously, these tests were verifying that we would
1076         always clear out the information, but this is incorrect, and is the source of the problem.
1077
1078         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1079         (-[NowPlayingTestWebView waitForNowPlayingInfoToChange]):
1080         (TestWebKitAPI::TEST):
1081
1082 2016-10-12  Per Arne Vollan  <pvollan@apple.com>
1083
1084         [Win] Parallel DRTs are sharing preferences and cache.
1085         https://bugs.webkit.org/show_bug.cgi?id=163013
1086
1087         Reviewed by Brent Fulgham.
1088
1089         Use separate cache and preferences for each DRT instance.
1090
1091         * DumpRenderTree/win/DumpRenderTree.cpp:
1092         (applicationId):
1093         (setApplicationId):
1094         (setCacheFolder):
1095         (setDefaultsToConsistentValuesForTesting):
1096         * Scripts/webkitpy/port/win.py:
1097         (WinPort.setup_test_run):
1098
1099 2016-10-11  Alex Christensen  <achristensen@webkit.org>
1100
1101         Update API test expectation after r207162.
1102        ​https://bugs.webkit.org/show_bug.cgi?id=162660
1103
1104         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
1105         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1106         Like r207167 but with a WebKit2 test.
1107         "https://www.example.com<>/" was an invalid URL with the old URL parser, is now valid with URLParser but not with NSURL's parser.
1108
1109 2016-10-11  Alex Christensen  <achristensen@webkit.org>
1110
1111         Update API test expectation after r207162.
1112         https://bugs.webkit.org/show_bug.cgi?id=162660
1113
1114         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
1115         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1116         "https://www.example.com<>/" was an invalid URL with the old URL parser.
1117         It is now a valid URL, but NSURL still considers it invalid.
1118         This will be looked into more with https://bugs.webkit.org/show_bug.cgi?id=163127
1119
1120 2016-10-11  Edward O'Connor  <eoconnor@apple.com>
1121
1122         Update my name in contributors.json
1123         https://bugs.webkit.org/show_bug.cgi?id=163251
1124
1125         Reviewed by Simon Fraser.
1126
1127         * Scripts/webkitpy/common/config/contributors.json:
1128
1129 2016-10-11  Said Abou-Hallawa  <sabouhallawa@apple.com>
1130
1131         Add SynchronizedFixedQueue class
1132         https://bugs.webkit.org/show_bug.cgi?id=162478
1133
1134         Reviewed by Geoffrey Garen.
1135
1136         Add a new test for SynchronizedFixedQueue. The test defines a new class
1137         called ToUpperConverter which converts strings from lower case to upper
1138         case. It creates two threads : (1) produce thread and (2) consume thread.
1139         Here is what each thread does:
1140
1141         1. Main threads: Enqueues lower case strings into m_lowerQueue.
1142         2. Produce thread: Dequeues lower case strings from m_lowerQueue and 
1143            enqueue their upper case strings in the m_upperQueue.
1144         3. Consume thread: Dequeues upper case strings from m_upperQueue.
1145
1146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1147         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp: Added.
1148         (TestWebKitAPI::textItem): A helper function which returns a lower case string given an index.
1149         (TestWebKitAPI::toUpper): A helper function which Returns the upper case of a string.
1150         (TestWebKitAPI::ToUpperConverter::ToUpperConverter):
1151         (TestWebKitAPI::ToUpperConverter::produceQueue): Returns a workQueue for the produce thread.
1152         (TestWebKitAPI::ToUpperConverter::consumeQueue): Returns a workQueue for the consume thread.
1153         (TestWebKitAPI::ToUpperConverter::startProducing): Creates a thread for the producer.
1154         (TestWebKitAPI::ToUpperConverter::startConsuming): Creates a thread for the consumer.
1155         (TestWebKitAPI::ToUpperConverter::start): Starts both the producer and the consumer threads.
1156         (TestWebKitAPI::ToUpperConverter::stopProducing): Terminates the producer thread.
1157         (TestWebKitAPI::ToUpperConverter::stopConsuming): Terminates the consumer thread.
1158         (TestWebKitAPI::ToUpperConverter::stop): Terminates both the producer and the consumer threads.
1159         (TestWebKitAPI::ToUpperConverter::enqueueLower): Adds a lower case string to the m_lowerQueue on the main thread.
1160         (TestWebKitAPI::ToUpperConverter::isProducing): Returns whether the producing thread is active.
1161         (TestWebKitAPI::ToUpperConverter::isConsuming): Returns whether the consuming thread is active.
1162         (TestWebKitAPI::ToUpperConverter::produceCount): Returns the number of produced elements.
1163         (TestWebKitAPI::ToUpperConverter::consumeCount): Returns the number of consumed elements.
1164         (TestWebKitAPI::TEST):
1165
1166 2016-10-11  Megan Gardner  <megan_gardner@apple.com>
1167
1168         Extend event stream to include interpolated events and add a force press test that uses that interpolation
1169         https://bugs.webkit.org/show_bug.cgi?id=163161
1170
1171         Reviewed by Simon Fraser.
1172
1173         Added functionality to the event stream to allow for interpolated events.
1174         Can now do long press, as well as a better way to do drag and other time-based
1175         events that require a large stream of descrete HID events.
1176         Added a basic force touch test to demostrate this interpolation.
1177         Also updated the script to allow for iPhone 7 specific tests, as force touch
1178         needs to be on a device that had force touch.
1179
1180         * Scripts/webkitpy/port/ios.py:
1181         (IOSSimulatorPort):
1182         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1183         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1184         (linearInterpolation):
1185         (simpleCurveInterpolation):
1186         (calculateNextCurveLocation):
1187         (phaseFromString):
1188         (interpolationFromString):
1189         (-[HIDEventGenerator eventMaskFromEventInfo:]):
1190         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
1191         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
1192         (-[HIDEventGenerator interpolatedEvents:]):
1193         (-[HIDEventGenerator processEventsArray:withStartTime:]):
1194         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1195         (simpleDragCurve): Deleted.
1196         (calculateNextLocation): Deleted.
1197
1198 2016-10-11  Alex Christensen  <achristensen@webkit.org>
1199
1200         URLParser should percent-encode non-ASCII and non-printable characters in fragment
1201         https://bugs.webkit.org/show_bug.cgi?id=163287
1202
1203         Reviewed by Brady Eidson.
1204
1205         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1206         (TestWebKitAPI::TEST_F):
1207
1208 2016-10-11  Alex Christensen  <achristensen@webkit.org>
1209
1210         Remove dead networking code
1211         https://bugs.webkit.org/show_bug.cgi?id=163263
1212
1213         Reviewed by Daniel Bates.
1214
1215         * DumpRenderTree/DumpRenderTree.h:
1216         * DumpRenderTree/config.h:
1217         * DumpRenderTree/win/DumpRenderTree.cpp:
1218         (main):
1219
1220 2016-10-11  John Wilander  <wilander@apple.com>
1221
1222         Modify check-webkit-style to prohibit sensitive phrases
1223         https://bugs.webkit.org/show_bug.cgi?id=163048
1224         <rdar://problem/28289755>
1225
1226         Terms considered or found to be too general to flag:
1227         ASSERT_WITH_SECURITY_IMPLICATION, bad cast, bug, bypass, crash,
1228         denial of service, dereference, disclosure, error, exploit,
1229         failure, heap, integer overflow, leak, null dereference,
1230         null pointer dereference, out of bounds, overflow,
1231         race condition, sensitive information, stack, type confusion.
1232
1233         Reviewed by Brent Fulgham.
1234
1235         * Scripts/webkitpy/style/checkers/changelog.py:
1236         (ChangeLogChecker.check_entry):
1237             Now calls ChangeLogChecker.check_for_unwanted_security_terms().
1238         (ChangeLogChecker):
1239         (ChangeLogChecker.check_for_unwanted_security_terms):
1240             New function to check for sensitive terms.
1241         (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm):
1242         (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm.__init__):
1243             Convenience class.
1244         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1245         (ChangeLogCheckerTest.test_unwanted_security_terms):
1246
1247 2016-10-11  Ryan Haddad  <ryanhaddad@apple.com>
1248
1249         Unreviewed, rolling out r207067.
1250
1251         This change caused webkitpy test failures.
1252
1253         Reverted changeset:
1254
1255         "[Win] Parallel DRTs are sharing preferences and cache."
1256         https://bugs.webkit.org/show_bug.cgi?id=163013
1257         http://trac.webkit.org/changeset/207067
1258
1259 2016-10-11  Per Arne Vollan  <pvollan@apple.com>
1260
1261         [Win] Parallel DRTs are sharing preferences and cache.
1262         https://bugs.webkit.org/show_bug.cgi?id=163013
1263
1264         Reviewed by Brent Fulgham.
1265
1266         Use separate cache and preferences for each DRT instance.
1267
1268         * DumpRenderTree/win/DumpRenderTree.cpp:
1269         (applicationId):
1270         (setApplicationId):
1271         (setCacheFolder):
1272         (setDefaultsToConsistentValuesForTesting):
1273         * Scripts/webkitpy/port/win.py:
1274         (WinPort.setup_test_run):
1275
1276 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
1277
1278         Add ENABLE_ENCRYPTED_MEDIA configuration option
1279         https://bugs.webkit.org/show_bug.cgi?id=163219
1280
1281         Reviewed by Darin Adler.
1282
1283         * Scripts/webkitperl/FeatureList.pm:
1284         Make the ENABLE_ENCRYPTED_MEDIA option overridable via build-webkit.
1285         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1286         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
1287         to enable or disable the new EME implementation at build-time.
1288
1289 2016-10-10  Commit Queue  <commit-queue@webkit.org>
1290
1291         Unreviewed, rolling out r206972.
1292         https://bugs.webkit.org/show_bug.cgi?id=163227
1293
1294         Making EWS flaky (Requested by bfulgham_ on #webkit).
1295
1296         Reverted changeset:
1297
1298         "[CMake] CMake does not support the dep files for implicit
1299         dependency"
1300         https://bugs.webkit.org/show_bug.cgi?id=161433
1301         http://trac.webkit.org/changeset/206972
1302
1303 2016-10-10  Youenn Fablet  <youenn@apple.com>
1304
1305         W3C test downloader should be able to import specific files/sub-directories in a skipped directory
1306         https://bugs.webkit.org/show_bug.cgi?id=161789
1307
1308         Reviewed by Ryosuke Niwa.
1309
1310         Removed tests_directory option and corresponding test.
1311         This option was allowing to import a sub-directory from a test repository.
1312         We can readd it if necessary.
1313
1314         Adding support for finer-grained import rules.
1315         Previously skipped directories were fully removed.
1316         Now, directories may be skipped but sub directories of them may be imported.
1317         This currently happens in web-platform-tests repo.
1318
1319         * Scripts/webkitpy/w3c/test_downloader.py:
1320         (TestDownloader._add_test_suite_paths): Removing tests_directory option.
1321         (TestDownloader.copy_tests): Refactoring file copy by generating the list of all directories for which direct files should be imported.
1322         (TestDownloader.copy_tests.should_copy_dir):
1323         (TestDownloader.copy_tests.should_copy_file):
1324         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1325         (TestImporterTest.test_tests_directory): Deleted.
1326         (TestImporterTest.test_skip_test_import): Added.
1327
1328 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
1329
1330         Make validate-committer-lists show inactive reviewers
1331         https://bugs.webkit.org/show_bug.cgi?id=163193
1332
1333         Reviewed by Sam Weinig.
1334         
1335         In preparation for updating contributors.json with the WebKit policy of retiring
1336         inactive reviewers, make validate-committer-lists show the list of reviewers who
1337         have not reviewed in the past year.
1338         
1339         This list is computed by grepping the output of 'git log --since=1.year" for
1340         the reviewer line, and looking up reviewers via Contributor.mentioned_in_text(),
1341         which looks for full names, aliases, irc nicks and email addresses.
1342         
1343         Support for aliases is added to Contributor. Aliases are alternates
1344         or misspellings of the reviewer's name. Some common aliases were added to
1345         contributors.json by manual examination of "Reviewed by" lines.
1346
1347         * Scripts/validate-committer-lists:
1348         (CommitterListFromGit.possibly_expired_committers):
1349         (CommitterListFromGit):
1350         (CommitterListFromGit.possibly_inactive_reviewers):
1351         (CommitterListFromGit.print_possibly_expired_committers):
1352         (CommitterListFromGit.print_possibly_inactive_reviewers):
1353         * Scripts/webkitpy/common/config/committers.py:
1354         (Contributor.__init__):
1355         (Contributor.contains_string):
1356         (Contributor.mentioned_in_text):
1357         (Contributor.as_dict):
1358         (Committer.__init__):
1359         (Reviewer.__init__):
1360         (CommitterList.load_json):
1361         * Scripts/webkitpy/common/config/contributors.json:
1362
1363 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
1364
1365         Convert contributors.json to a flat list
1366         https://bugs.webkit.org/show_bug.cgi?id=163183
1367
1368         Reviewed by Darin Adler.
1369         
1370         Make contributors.json easier to maintain by eliminating the big groupings ("Committers", "Reviewers" etc)
1371         and moving that data to a "status" property on each contributor.
1372
1373         * Scripts/webkitpy/common/config/committers.py:
1374         (Contributor.__eq__): Implement this to fix unit tests, now that load_json() is not @memoized.
1375         (Contributor.as_dict): Include status in the dict.
1376         (CommitterList.__init__): Clean up to make the testing code path more explicit.
1377         (CommitterList.load_json):
1378         (CommitterList.load_test_data):
1379         (CommitterList.as_json):
1380         (Contributor.__unicode__): Deleted.
1381         * Scripts/webkitpy/common/config/contributors.json:
1382         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1383         (IRCCommandTest.test_whois): The ordering here is now alphabetical.
1384
1385 2016-10-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1386
1387         [CMake] CMake does not support the dep files for implicit dependency
1388         https://bugs.webkit.org/show_bug.cgi?id=161433
1389
1390         Reviewed by Brent Fulgham.
1391
1392         Created a Perl script to generate all IDL bindings for CMake.
1393         This script can regenerate outdated bindings by based on the
1394         supplemental dependency and dep files created by
1395         '--write-dependencies' switch of generate-bindings.pl.
1396
1397         add_custom_target is used to invoke the script instead of
1398         add_custom_command because Ninja deletes all output files before
1399         executing the command in case of add_custom_command.
1400
1401         USES_TERMINAL option of add_custom_target has two effects:
1402         1) Not buffering output of the command
1403         2) Invoking the command in the special Ninja pool which inhibits parallel build
1404         One needs to use CMake 3.2 or later to enable this feature.
1405
1406         * DumpRenderTree/CMakeLists.txt: Specified a target name for
1407         GENERATE_BINDINGS. Added dependency for the target.
1408         * WebKitTestRunner/CMakeLists.txt: Ditto.
1409
1410 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
1411
1412         Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
1413         https://bugs.webkit.org/show_bug.cgi?id=163177
1414
1415         Follow-up fix.
1416         
1417         For unknown reasons, overriding Commiter.__dict__() caused mysterious test failures.
1418         Rename it to as_dict().
1419
1420         * Scripts/webkitpy/common/config/committers.py:
1421         (Contributor.as_dict):
1422         (CommitterList._contributor_list_to_dict):
1423         (Contributor.__dict__): Deleted.
1424
1425 2016-10-08  Simon Fraser  <simon.fraser@apple.com>
1426
1427         Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
1428         https://bugs.webkit.org/show_bug.cgi?id=163177
1429
1430         Reviewed by Ryosuke Niwa.
1431         
1432         Make it possible to round-trip contributors.json through CommitterList, so we can
1433         support writing out contributors.json in canonical format. This requires saving
1434         the case-preserved email and expertise in Contributor. CommitterList also needs
1435         to be able to generate the "exclusive" lists, since it currently uses lists
1436         that are the union of, say, committers and reviewers.
1437         
1438         If contributors.json is malformed (invalid JSON), catch the Exception, report it
1439         and exit rather than allowing the exception to propagate. With an invalid file,
1440         an exception would be thrown before the JSON style checker reached this file, so
1441         the error was not correctly reported.
1442         
1443         Add style/checker/committer.py for checking that committers.json has the canonical format.
1444         
1445         Add support to validate-committer-lists to dump out the canonical json (-d) or update
1446         the file in-place (-c).
1447
1448         * Scripts/validate-committer-lists:
1449         (CommitterListFromGit._print_three_column_row):
1450         (CommitterListFromGit.possibly_expired_committers):
1451         (CommitterListFromGit):
1452         (CommitterListFromGit.print_possibly_expired_committers):
1453         (main):
1454         * Scripts/webkitpy/common/config/committers.py:
1455         (Contributor.__init__):
1456         (Contributor.__dict__):
1457         (Committer.__init__):
1458         (Reviewer.__init__):
1459         (CommitterList.load_json):
1460         (CommitterList):
1461         (CommitterList._contributor_list_to_dict):
1462         (CommitterList.as_json):
1463         (CommitterList.reformat_in_place):
1464         (CommitterList._exclusive_contributors):
1465         (CommitterList._exclusive_committers):
1466         (Contributor.matches_glob): Deleted.
1467         (CommitterList.contributors): Deleted.
1468         * Scripts/webkitpy/common/config/contributors.json:
1469         * Scripts/webkitpy/style/checker.py:
1470         (CheckerDispatcher._create_checker):
1471         * Scripts/webkitpy/style/checkers/contributors.py: Added.
1472         (ContributorsChecker):
1473         (ContributorsChecker.__init__):
1474         (ContributorsChecker.check):
1475         (ContributorsChecker._unidiff_output):
1476
1477 2016-10-06  Darin Adler  <darin@apple.com>
1478
1479         Next step on moving to modern way to return DOM exceptions
1480         https://bugs.webkit.org/show_bug.cgi?id=163016
1481
1482         Reviewed by Ryosuke Niwa.
1483
1484         * Scripts/do-webcore-rename: Add proposed name change of setDOMException
1485         to propagateException, since this function is primarily used to take an
1486         exception already effectively "thrown" by setting an ExceptionCode out
1487         argument and propagate it into the JavaScript engine's exception machinery.
1488
1489 2016-10-07  Alex Christensen  <achristensen@webkit.org>
1490
1491         Non-special URL fragments should percent-encode non-ASCII characters
1492         https://bugs.webkit.org/show_bug.cgi?id=163153
1493
1494         Reviewed by Tim Horton.
1495
1496         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1497         (TestWebKitAPI::TEST_F):
1498
1499 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
1500
1501         Build fix for “Move functionality common to Darwin ports into a base class”
1502         https://bugs.webkit.org/show_bug.cgi?id=160709
1503
1504         Unreviewed build fix.
1505
1506         * Scripts/webkitpy/port/ios.py:
1507         (IOSSimulatorPort._get_crash_log): Added iOS implementation.
1508         * Scripts/webkitpy/port/mac.py:
1509         (MacPort._get_crash_log): Added Mac implementation.
1510
1511 2016-10-07  Chelsea Pugh  <cpugh@apple.com>
1512
1513         Unreviewed. Added myself to the list of committers.
1514
1515         * Scripts/webkitpy/common/config/contributors.json:
1516
1517 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
1518
1519         Move functionality common to Darwin ports into a base class
1520         https://bugs.webkit.org/show_bug.cgi?id=160709
1521
1522         Reviewed by Darin Adler.
1523
1524         * Scripts/webkitpy/port/apple.py:
1525         (ApplePort.determine_full_port_name): Specific iOS port check.
1526         (ApplePort.__init__): Move leak detector to DarwinPort.
1527         (ApplePort._make_leak_detector): Moved to DarwinPort.
1528         (ApplePort.supports_per_test_timeout): Moved to Port.
1529         (ApplePort.check_for_leaks): Moved to DarwinPort.
1530         (ApplePort.print_leaks_summary): Moved to DarwinPort.
1531         (ApplePort._path_to_webcore_library): Moved to DarwinPort.
1532         (ApplePort.show_results_html_file): Moved to DarwinPort.
1533         (ApplePort._merge_crash_logs): Moved to DarwinPort.
1534         (ApplePort._look_for_all_crash_logs_in_log_dir): Moved to DarwinPort.
1535         (ApplePort._get_crash_log): Moved to DarwinPort.
1536         (ApplePort.look_for_new_crash_logs): Moved to DarwinPort.
1537         (ApplePort.sample_process): Moved to DarwinPort.
1538         (ApplePort.sample_file_path): Moved to DarwinPort.
1539         (ApplePort.look_for_new_samples): Moved to DarwinPort.
1540         * Scripts/webkitpy/port/base.py:
1541         (Port.supports_per_test_timeout): Return true for all ports.
1542         * Scripts/webkitpy/port/darwin.py: Added.
1543         (DarwinPort): Shared iOS and Mac functions.
1544         * Scripts/webkitpy/port/darwin_testcase.py: Added.
1545         (DarwinTest): Shared iOS and Mac testing.
1546         * Scripts/webkitpy/port/efl.py:
1547         (EflPort):
1548         (EflPort.supports_per_test_timeout): Moved to Port.
1549         * Scripts/webkitpy/port/gtk.py:
1550         (GtkPort._driver_class):
1551         (GtkPort):
1552         (GtkPort.supports_per_test_timeout): Moved to Port.
1553         * Scripts/webkitpy/port/ios.py:
1554         (IOSPort):
1555         (IOSPort.operating_system):
1556         (IOSSimulatorPort):
1557         (IOSSimulatorPort.__init__): Inherits from DarwinPort.
1558         (IOSSimulatorPort._port_specific_expectations_files): Moved to DarwinPort.
1559         (IOSSimulatorPort._get_crash_log): Deleted.
1560         (IOSSimulatorPort.xcrun_find): Deleted.
1561         * Scripts/webkitpy/port/ios_unittest.py: Added.
1562         (iosTest): Unit tests for the iOS port.
1563         * Scripts/webkitpy/port/mac.py:
1564         (MacPort):
1565         (MacPort.__init__): Inherits from DarwinPort.
1566         (MacPort._port_specific_expectations_files): Moved to DarwinPort.
1567         (MacPort.make_command): Moved to DarwinPort.
1568         (MacPort._get_crash_log): Moved to DarwinPort.
1569         (MacPort.nm_command): Moved to DarwinPort.
1570         * Scripts/webkitpy/port/mac_unittest.py:
1571         (MacTest):
1572         (MacTest.test_sdk_name): Added test.
1573         (MacTest.test_xcrun): Added test.
1574         (MacTest.assert_skipped_file_search_paths): Moved to DarwinTest.
1575         (MacTest.test_default_timeout_ms): Moved to DarwinTest.
1576         (MacTest.assert_name): Moved to DarwinTest.
1577         (MacTest.test_helper_starts): Moved to DarwinTest.
1578         (MacTest.test_helper_fails_to_start): Moved to DarwinTest.
1579         (MacTest.test_helper_fails_to_stop): Moved to DarwinTest.
1580         (MacTest.test_spindump): Moved to DarwinTest.
1581         (MacTest.test_sample_process): Moved to DarwinTest.
1582         (MacTest.test_sample_process_exception): Moved to DarwinTest.
1583         * Scripts/webkitpy/port/port_testcase.py:
1584         (PortTestCase):
1585         (PortTestCase.test_diff_image): Added is_simulator flag.
1586         (PortTestCase.test_diff_image): Skip test if on a simulator.
1587         (PortTestCase.test_diff_image_crashed): Skip test if on a simulator.
1588         * Scripts/webkitpy/port/win.py:
1589         (WinPort):
1590         (WinPort.look_for_new_samples): Used default, ApplePort no longer implements.
1591         (WinPort.sample_process): Ditto.
1592         (WinPort._make_leak_detector): Ditto.
1593         (WinPort.check_for_leaks): Ditto.
1594         (WinPort.print_leaks_summary): Ditto.
1595         (WinPort._path_to_webcore_library): Ditto.
1596
1597 2016-10-07  Anders Carlsson  <andersca@apple.com>
1598
1599         Get rid of WKPageSetSession
1600         https://bugs.webkit.org/show_bug.cgi?id=163129
1601
1602         Reviewed by Tim Horton.
1603
1604         Rewrite this test to use WKPageConfigurationRef and WKWebsiteDataStoreRef.
1605
1606         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1607         (TestWebKitAPI::TEST):
1608
1609 2016-10-07  Andreas Kling  <akling@apple.com>
1610
1611         [WK2] didRemoveFrameFromHierarchy callback doesn't fire for subframes when evicting from PageCache.
1612         <https://webkit.org/b/163098>
1613         <rdar://problem/28663488>
1614
1615         Reviewed by Antti Koivisto.
1616
1617         Add an API test that puts a 10-subframe page into the page cache, then loads other pages
1618         until the first page gets kicked out. The test succeeds if we receive didRemoveFrameFromHierarchy
1619         callbacks for all the subframes.
1620
1621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1622         * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp: Added.
1623         (TestWebKitAPI::didFinishLoadForFrame):
1624         (TestWebKitAPI::setPageLoaderClient):
1625         (TestWebKitAPI::didReceivePageMessageFromInjectedBundle):
1626         (TestWebKitAPI::setInjectedBundleClient):
1627         (TestWebKitAPI::TEST):
1628         * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: Added.
1629         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1630         (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::DidRemoveFrameFromHiearchyInPageCacheTest):
1631         (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::didCreatePage):
1632         * TestWebKitAPI/Tests/WebKit2/many-iframes.html: Added.
1633
1634 2016-10-07  Emanuele Aina  <emanuele.aina@collabora.com>
1635
1636         Replace bug URL placeholders independently of the short desc one
1637         https://bugs.webkit.org/show_bug.cgi?id=161684
1638
1639         Reviewed by Darin Adler.
1640
1641         Instead of adding the bug URL when replacing the short description
1642         placeholder and then ignoring the bug URL placeholder, use the former
1643         to set the short description and the latter for the bug URL.
1644         This means that developers can fully prepare the changelog with short
1645         and long description before submission leaving the bug placeholder in
1646         place, and the changelog machinery will make sure to replace the
1647         latter with the URL of the newly created bug while submitting.
1648
1649         Note that this also means that the short description placeholder alone
1650         no longer causes the bug URL to be added.
1651
1652         * Scripts/webkitpy/common/checkout/changelog.py:
1653         (ChangeLog.set_short_description_and_bug_url):
1654         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1655         (test_set_short_description_and_bug_url):
1656
1657 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
1658
1659         Style Checking Error when Objective C Blocks passed as Argument
1660         https://bugs.webkit.org/show_bug.cgi?id=162463
1661
1662         Reviewed by Darin Adler.
1663
1664         * Scripts/webkitpy/style/checkers/cpp.py:
1665         (regex_for_lambdas_and_blocks): Consider case where block is passed as a function argument.
1666         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1667         (CppStyleTest.test_objective_c_block_as_argument): Test case where block is passed as a function argument. 
1668
1669 2016-10-07  Philippe Normand  <pnormand@igalia.com>
1670
1671         [GTK] Docs build failure
1672         https://bugs.webkit.org/show_bug.cgi?id=163102
1673
1674         Reviewed by Carlos Garcia Campos.
1675
1676         * gtk/jhbuild.modules: Bump to gtk-doc 1.25 to fix build errors on Debian Testing.
1677
1678 2016-10-06  Joseph Pecoraro  <pecoraro@apple.com>
1679
1680         check-webkit-style: Enable the legal/copyright rule for cpp/h files
1681         https://bugs.webkit.org/show_bug.cgi?id=162707
1682
1683         Reviewed by Darin Adler.
1684
1685         * Scripts/webkitpy/style/checker.py:
1686         Enable this rule by default.
1687
1688 2016-10-06  Joseph Pecoraro  <pecoraro@apple.com>
1689
1690         Header guard style should be updated to be "#pragma once"
1691         https://bugs.webkit.org/show_bug.cgi?id=159785
1692
1693         Reviewed by Darin Adler.
1694
1695         * Scripts/webkitpy/style/checkers/cpp.py:
1696         (check_for_header_guard):
1697         (_process_lines):
1698         Simplify header_guard check to warn for a missing #pragma once
1699         in header files. For legacy files that contain an #ifndef only
1700         warn if the #ifndef line itself is changing.
1701
1702         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1703         (CppStyleTestBase.perform_header_guard_check):
1704         (CppStyleTestBase.assert_header_guard):
1705         Helpers for enabling just this warning.
1706
1707         (CppStyleTest.test_build_header_guard):
1708         Test different header guard cases.
1709
1710         * Scripts/webkitpy/style/error_handlers.py:
1711         (DefaultStyleErrorHandler.should_line_be_checked):
1712         Always allow warnings that output for "line 0" which won't be in
1713         the list of modified lines that are 1-based.
1714
1715 2016-10-06  Commit Queue  <commit-queue@webkit.org>
1716
1717         Unreviewed, rolling out r206713.
1718         https://bugs.webkit.org/show_bug.cgi?id=163097
1719
1720         triggers apparent codegen bug on ARM 32-bit (Requested by smfr
1721         on #webkit).
1722
1723         Reverted changeset:
1724
1725         "Support transitions/animations of background-position with
1726         right/bottom-relative values"
1727         https://bugs.webkit.org/show_bug.cgi?id=162048
1728         http://trac.webkit.org/changeset/206713
1729
1730 2016-10-06  Alex Christensen  <achristensen@webkit.org>
1731
1732         URLParser: Non-ASCII characters in Non-UTF-8 encoded queries of relative URLs with ws, wss, or nonspecial schemes should be UTF-8 encoded
1733         https://bugs.webkit.org/show_bug.cgi?id=163089
1734
1735         Reviewed by Tim Horton.
1736
1737         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1738         (TestWebKitAPI::checkURL):
1739         (TestWebKitAPI::TEST_F):
1740
1741 2016-10-06  Alex Christensen  <achristensen@webkit.org>
1742
1743         Skip tabs and newlines between end of query and beginning of fragment in non-UTF-8-encoded URLs
1744         https://bugs.webkit.org/show_bug.cgi?id=163071
1745
1746         Reviewed by Tim Horton.
1747
1748         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1749         (TestWebKitAPI::TEST_F):
1750
1751 2016-10-06  Alex Christensen  <achristensen@webkit.org>
1752
1753         URLParser should parse file URLs with ports consistently
1754         https://bugs.webkit.org/show_bug.cgi?id=163075
1755
1756         Reviewed by Brady Eidson.
1757
1758         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1759         (TestWebKitAPI::TEST_F):
1760
1761 2016-10-06  John Wilander  <wilander@apple.com>
1762
1763         Update Resource Load Statistics
1764         https://bugs.webkit.org/show_bug.cgi?id=162811
1765
1766         Reviewed by Alex Christensen.
1767
1768         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
1769             Change from USE(PUBLIC_SUFFIX_LIST) to ENABLE(PUBLIC_SUFFIX_LIST)
1770
1771 2016-10-05  Philippe Normand  <pnormand@igalia.com>
1772
1773         [GStreamer][OWR] GL rendering support
1774         https://bugs.webkit.org/show_bug.cgi?id=162972
1775
1776         Reviewed by Žan Doberšek.
1777
1778         When GStreamer-GL is enabled the GL context needs to be properly passed
1779         to the GStreamer pipeline running within the OpenWebRTC video renderer.
1780         This is now supported using a new OpenWebRTC API that allows the
1781         renderer to request the context from the application using a callback
1782         registered within the renderer.
1783
1784         * gtk/jhbuild.modules: Bump to latest OpenWebRTC for the new
1785         owr_video_renderer_set_request_context_callback API added
1786         recently.
1787
1788 2016-10-05  Youenn Fablet  <youenn@apple.com>
1789
1790         Reuse CodeGenerator::UpdateFile in Tools CodeGenerator
1791         https://bugs.webkit.org/show_bug.cgi?id=162960
1792
1793         Reviewed by Alex Christensen.
1794
1795         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1796         (WriteData): Using CodeGenerator::UpdateFile to do lazy generated file update when it is made feasible.
1797         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1798         (WriteData): Ditto.
1799
1800 2016-10-05  Alex Christensen  <achristensen@webkit.org>
1801
1802         URLParser should parse IPv4 addresses as the last two pieces of an IPv6 address
1803         https://bugs.webkit.org/show_bug.cgi?id=162991
1804
1805         Reviewed by Saam Barati.
1806
1807         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1808         (TestWebKitAPI::TEST_F):
1809
1810 2016-10-05  Tim Horton  <timothy_horton@apple.com>
1811
1812         Avoid automatically re-taking snapshots for back-forward items that were never loaded into the view
1813         https://bugs.webkit.org/show_bug.cgi?id=162955
1814         <rdar://problem/27659173>
1815
1816         Reviewed by Simon Fraser.
1817
1818         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1819         (-[SnapshotTestWKWebView init]):
1820         (forceRepaintCallback):
1821         (-[SnapshotTestWKWebView synchronouslyForceRepaint]):
1822         (-[SnapshotTestWKWebView synchronouslyLoadTestPageAndForceRepaint:]):
1823         (TEST):
1824         (makeRedSquareView):
1825         Add a test that restoring session state into a web view without navigating,
1826         then explicitly snapshotting and navigating away, leaves the original snapshot alone.
1827
1828         Adjust the existing test, as well, to ensure that it will reliably fail
1829         if the feature is broken. Use an explicitly added and removed red square
1830         instead of scrolling, because we can't scroll in the restore-without-navigating case.
1831
1832         Stop trying to override the window scale, because it's not working (we're getting partial snapshots)
1833         and isn't necessary; instead just multiply the expected value by the page scale.
1834
1835         (-[SnapshotTestWKWebView loadPageNamed:]): Deleted.
1836         * TestWebKitAPI/mac/TestWKWebViewMac.h:
1837         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
1838         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1839         Reorganize to reduce duplication.
1840
1841 2016-10-05  Tim Horton  <timothy_horton@apple.com>
1842
1843         Make it possible to test ViewSnapshotStore behaviors
1844         https://bugs.webkit.org/show_bug.cgi?id=162983
1845
1846         Reviewed by Simon Fraser.
1847
1848         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1849         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: Added.
1850         (-[SnapshotTestWKWebView init]):
1851         (-[SnapshotTestWKWebView loadPageNamed:]):
1852         (imagesAreEqual):
1853         Add tests for existing basic snapshotting behavior:
1854
1855         - a back-forward item shouldn't have a snapshot
1856           until it is navigated away from
1857
1858         - causing a back-forward item to fall out of the
1859           back-forward list should remove the snapshot
1860
1861         - calling the explicit snapshotting SPI, then navigating away from the page,
1862           should result in the snapshot being retaken
1863
1864 2016-10-05  Chris Dumez  <cdumez@apple.com>
1865
1866         KeyboardEvent.getModifierState() should support "CapsLock" modifier
1867         https://bugs.webkit.org/show_bug.cgi?id=162861
1868
1869         Reviewed by Darin Adler.
1870
1871         Add support for 'capsLockKey' modifier for EventSender.keyDown() so
1872         that we can test this new modifier support for layout tests.
1873
1874         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1875         (TestWebKitAPI::modifierFlagsForWKModifiers):
1876         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1877         (WTR::parseModifier):
1878         * WebKitTestRunner/mac/EventSenderProxy.mm:
1879         (WTR::buildModifierFlags):
1880
1881 2016-10-05  Jeremy Jones  <jeremyj@apple.com>
1882
1883         Add MobileMiniBrowser tests for control center and looping fullscreen.
1884         https://bugs.webkit.org/show_bug.cgi?id=162748
1885
1886         Reviewed by Jer Noble.
1887
1888         Refactor existing MobileMiniBrowserTests and add new tests for 
1889         - fullscreen rotation
1890         - fullscreen looping (failing)
1891         - control center interruption (failing)
1892
1893         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1894         * MobileMiniBrowser/MobileMiniBrowserFramework/Resources/looping2s.html: Added.
1895         * MobileMiniBrowser/MobileMiniBrowserFramework/test2s.mp4: Added.
1896         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
1897         (-[MobileMiniBrowserUITests setUp]):
1898         (-[MobileMiniBrowserUITests waitToTapButtonNamed:forApp:]):
1899         (-[MobileMiniBrowserUITests loadURL:]):
1900         (-[MobileMiniBrowserUITests requireMinFPS:sampleDurationSeconds:message:]):
1901         (-[MobileMiniBrowserUITests ensureFullscreenControls]):
1902         (-[MobileMiniBrowserUITests timeForTimeString:]):
1903         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
1904         (-[MobileMiniBrowserUITests testBasicVideoFullscreen]):
1905         (-[MobileMiniBrowserUITests testVideoFullscreenAndRotationAnimation]):
1906         (-[MobileMiniBrowserUITests testVideoFullscreenControlCenter]):
1907         (-[MobileMiniBrowserUITests testLoopingFullscreenLockup]):
1908
1909 2016-10-05  Alex Christensen  <achristensen@webkit.org>
1910
1911         URLParser should correctly strip unnecessary 0's in IPv6 addresses
1912         https://bugs.webkit.org/show_bug.cgi?id=162979
1913
1914         Reviewed by Brady Eidson.
1915
1916         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1917         (TestWebKitAPI::TEST_F):
1918
1919 2016-10-05  Alex Christensen  <achristensen@webkit.org>
1920
1921         UTF-8 encode queries of nonspecial and websocket schemes
1922         https://bugs.webkit.org/show_bug.cgi?id=162956
1923
1924         Reviewed by Geoffrey Garen and Brady Eidson.
1925
1926         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1927         (TestWebKitAPI::TEST_F):
1928
1929 2016-10-05  Alex Christensen  <achristensen@webkit.org>
1930
1931         Prepare to enable URLParser
1932         https://bugs.webkit.org/show_bug.cgi?id=162974
1933
1934         Reviewed by Brady Eidson.
1935
1936         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1937         (TestWebKitAPI::TEST_F):
1938         Added some tests that are unrelated to the code change, but these are
1939         reflected in changed LayoutTest results when enabling the URLParser,
1940         and they weren't in the URLParser tests yet.  They should be.
1941
1942 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
1943
1944         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
1945         https://bugs.webkit.org/show_bug.cgi?id=162903
1946
1947         Reviewed by Alex Christensen.
1948
1949         Rename build guards for the remaining implementation of the legacy EME API
1950         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
1951         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
1952
1953         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Also remove the
1954         ENABLE_IOS_TEXT_AUTOSIZING feature define that was renamed in r206395 and was
1955         throwing up style checker errors.
1956
1957 2016-10-04  Andy Estes  <aestes@apple.com>
1958
1959         [iOS] Crash in WebResourceLoaderQuickLookDelegate when the client cancels the navigation to a QuickLook resource
1960         https://bugs.webkit.org/show_bug.cgi?id=162950
1961         <rdar://problem/23759114>
1962
1963         Reviewed by Brady Eidson.
1964
1965         Added a new API test.
1966
1967         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Sorted imports and removed redundant
1968         initialization of static bools.
1969         (runTest): Factored out the common test logic between QuickLook.NavigationDelegate and
1970         QuickLook.CancelNavigationAfterResponse.
1971         (TEST): Added QuickLook.CancelNavigationAfterResponse.
1972         (-[QuickLookDecidePolicyDelegate
1973         webView:decidePolicyForNavigationResponse:decisionHandler:]): Canceled the navigation.
1974         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Set
1975         isDone to true.
1976
1977 2016-10-04  Ryosuke Niwa  <rniwa@webkit.org>
1978
1979         Add the support for running ES6SampleBench to run-benchmark
1980         https://bugs.webkit.org/show_bug.cgi?id=162890
1981
1982         Reviewed by Saam Barati.
1983
1984         Added the support for running ES6SampleBench as "es6bench".
1985         e.g. ./Tools/Scripts/run-benchmark --platform osx --plan es6bench --browser safari
1986
1987         Instead of the default 10 iterations, run the test 4 iterations using 5 instances of browser
1988         for the total of 20 iterations.
1989
1990         * Scripts/webkitpy/benchmark_runner/data/patches/ES6SampleBench.patch: Added.
1991         * Scripts/webkitpy/benchmark_runner/data/plans/es6bench.plan: Added.
1992         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1993         (start): Fixed the bug that the linter will complain about the presence of "debugOutput" by
1994         removing it if it's present.
1995
1996 2016-10-04  Simon Fraser  <simon.fraser@apple.com>
1997
1998         [iOS WK2] Make it possible for a test to describe a user gesture as a stream of events in JSON format
1999         https://bugs.webkit.org/show_bug.cgi?id=162934
2000
2001         Reviewed by Dean Jackson.
2002
2003         With this change, a test can describe a user gesture in an "event stream", which is
2004         some JSON describing an array of events with their underlying touches. The added
2005         test describes a single tap.
2006         
2007         The implementation fires up an NSThread, and sleeps the thread between events to dispatch
2008         them at close to real time.
2009         
2010         In future, HIDEventGenerator could use this internally for all of the "compound" interactions.
2011
2012         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2013         (WTR::UIScriptController::sendEventStream):
2014         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2015         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2016         (WTR::UIScriptController::sendEventStream):
2017         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2018         * WebKitTestRunner/ios/HIDEventGenerator.h:
2019         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2020         (transducerTypeFromString):
2021         (phaseFromString):
2022         (-[HIDEventGenerator eventMaskFromEventInfo:]):
2023         (-[HIDEventGenerator touchFromEventInfo:]):
2024         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
2025         (-[HIDEventGenerator dispatchEventWithInfo:]):
2026         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2027         (-[HIDEventGenerator sendEventStream:completionBlock:]):
2028         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2029         (WTR::UIScriptController::sendEventStream):
2030
2031 2016-10-04  Megan Gardner  <megan_gardner@apple.com>
2032
2033         Add Megan to contributor's list
2034         https://bugs.webkit.org/show_bug.cgi?id=162944
2035
2036         Reviewed by Tim Horton.
2037
2038         Add Megan to the contributor's lists so that her e-mail autocompletes for CC
2039
2040         * Scripts/webkitpy/common/config/contributors.json:
2041
2042 2016-10-04  Alex Christensen  <achristensen@webkit.org>
2043
2044         Add tests verifying non-special URL hosts are parsed according to spec
2045         https://bugs.webkit.org/show_bug.cgi?id=162885
2046
2047         Reviewed by Sam Weinig.
2048
2049         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2050         (TestWebKitAPI::TEST_F):
2051
2052 2016-10-04  Anders Carlsson  <andersca@apple.com>
2053
2054         Properly kill web processes in the launching state
2055         https://bugs.webkit.org/show_bug.cgi?id=162938
2056
2057         Reviewed by Tim Horton.
2058
2059         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
2060         Enable this test again.
2061
2062 2016-10-04  Alex Christensen  <achristensen@webkit.org>
2063
2064         URLParser: query-only URLs relative to file URLs should just add a query
2065         https://bugs.webkit.org/show_bug.cgi?id=162888
2066
2067         Reviewed by Tim Horton.
2068
2069         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2070         (TestWebKitAPI::TEST_F):
2071
2072 2016-10-04  Alex Christensen  <achristensen@webkit.org>
2073
2074         URLParser should match URL::parse and other browsers when parsing a URL containing only scheme://
2075         https://bugs.webkit.org/show_bug.cgi?id=162909
2076
2077         Reviewed by Tim Horton.
2078
2079         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2080         (TestWebKitAPI::TEST_F):
2081
2082 2016-10-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2083
2084         [DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information
2085         https://bugs.webkit.org/show_bug.cgi?id=162916
2086
2087         Reviewed by Filip Pizlo.
2088
2089         * DumpRenderTree/CMakeLists.txt:
2090
2091 2016-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2092
2093         Media controls are displayed in the incorrect state momentarily after switching between tabs playing media
2094         https://bugs.webkit.org/show_bug.cgi?id=162766
2095         <rdar://problem/28533523>
2096
2097         Reviewed by Jer Noble.
2098
2099         Adds new tests and tweaks existing tests to verify last updated Now Playing information.
2100
2101         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2102         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]):
2103         (TestWebKitAPI::TEST):
2104         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]): Deleted.
2105         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html:
2106
2107 2016-10-03  Alex Christensen  <achristensen@webkit.org>
2108
2109         URLParser should ignore tabs at all locations
2110         https://bugs.webkit.org/show_bug.cgi?id=162836
2111
2112         Reviewed by Geoffrey Garen.
2113
2114         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2115         (TestWebKitAPI::checkURL):
2116         (TestWebKitAPI::checkRelativeURL):
2117         (TestWebKitAPI::checkURLDifferences):
2118         (TestWebKitAPI::checkRelativeURLDifferences):
2119         (TestWebKitAPI::TEST_F):
2120
2121 2016-10-03  Alex Christensen  <achristensen@webkit.org>
2122
2123         URLParser: fragment-only URLs relative to file URLs should just add a fragment
2124         https://bugs.webkit.org/show_bug.cgi?id=162871
2125
2126         Reviewed by Geoffrey Garen.
2127
2128         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2129         (TestWebKitAPI::TEST_F):
2130
2131 2016-10-03  Per Arne Vollan  <pvollan@apple.com>
2132
2133         [Win] DRT temp folder is not used.
2134         https://bugs.webkit.org/show_bug.cgi?id=162863
2135
2136         Reviewed by Alex Christensen.
2137
2138         Convert DRT temp folder to DOS path, which DRT can use.
2139
2140         * Scripts/webkitpy/port/driver.py:
2141         (Driver._setup_environ_for_driver):
2142
2143 2016-10-03  Alex Christensen  <achristensen@webkit.org>
2144
2145         URLParser: empty relative URLs should not copy fragment from the base URL
2146         https://bugs.webkit.org/show_bug.cgi?id=162864
2147
2148         Reviewed by Chris Dumez.
2149
2150         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2151         (TestWebKitAPI::TEST_F):
2152
2153 2016-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2154
2155         [SOUP] Cleanup persistent credential storage code
2156         https://bugs.webkit.org/show_bug.cgi?id=162777
2157
2158         Reviewed by Alex Christensen.
2159
2160         Use USE(LIBSECRET) instead of ENABLE(CREDENTIAL_STORAGE).
2161
2162         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2163         (testWebViewAuthenticationStorage):
2164
2165 2016-10-02  Darin Adler  <darin@apple.com>
2166
2167         Rename ExceptionCode-based exception handling to "legacy"
2168         https://bugs.webkit.org/show_bug.cgi?id=162859
2169
2170         Reviewed by Chris Dumez.
2171
2172         * Scripts/do-webcore-rename: Updated script to do this round of renames.
2173
2174 2016-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2175
2176         Media controls for Soundcloud easily falls out of sync with what's actually playing
2177         https://bugs.webkit.org/show_bug.cgi?id=162843
2178         <rdar://problem/28176874>
2179
2180         Reviewed by Beth Dakin.
2181
2182         Adds two new tests simulating audio playback behavior on soundcloud. Also tweaks some of the WKWebView test
2183         message handling logic to support having multiple message-handler mappings.
2184
2185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2186         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2187         (TestWebKitAPI::TEST):
2188         * TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Added.
2189         * TestWebKitAPI/mac/TestWKWebViewMac.h:
2190         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
2191         (-[TestMessageHandler addMessage:withHandler:]):
2192         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2193         (-[TestWKWebView performAfterReceivingMessage:action:]):
2194         (-[TestWKWebView performAfterLoading:]):
2195         (-[TestMessageHandler initWithMessage:handler:]): Deleted.
2196
2197 2016-09-30  Alex Christensen  <achristensen@webkit.org>
2198
2199         Fix off-by-one error in URLParser::parseIPv4Host
2200         https://bugs.webkit.org/show_bug.cgi?id=162789
2201
2202         Reviewed by Tim Horton.
2203
2204         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2205         (TestWebKitAPI::TEST_F):
2206
2207 2016-09-30  Alex Christensen  <achristensen@webkit.org>
2208
2209         URLParser: parsing a URL with an empty host and a colon should fail
2210         https://bugs.webkit.org/show_bug.cgi?id=162795
2211
2212         Reviewed by Tim Horton.
2213
2214         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2215         (TestWebKitAPI::TEST_F):
2216
2217 2016-09-30  Alex Christensen  <achristensen@webkit.org>
2218
2219         URLParser: handle syntax violations in non-UTF-8 encoded queries
2220         https://bugs.webkit.org/show_bug.cgi?id=162770
2221
2222         Reviewed by Tim Horton.
2223
2224         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2225         (TestWebKitAPI::checkURL):
2226         (TestWebKitAPI::TEST_F):
2227         Tests with emoji change behavior when we insert a tab between the surrogates, so don't do the
2228         insert-tab-at-each-location verification that syntax violations are handled correctly.
2229
2230 2016-09-30  Megan Gardner  <megan_gardner@apple.com>
2231
2232         Make it possible to test web-related user-interface features
2233         https://bugs.webkit.org/show_bug.cgi?id=162657
2234
2235         Reviewed by Simon Fraser.
2236
2237         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2238         (WTR::UIScriptController::contentsOfUserInterfaceItem):
2239         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
2240         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2241         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2242         (WTR::UIScriptController::contentsOfUserInterfaceItem):
2243         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
2244         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2245         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2246         (WTR::UIScriptController::contentsOfUserInterfaceItem):
2247         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
2248
2249 2016-09-29  Jiewen Tan  <jiewen_tan@apple.com>
2250
2251         Expose CryptoKey to web workers
2252         https://bugs.webkit.org/show_bug.cgi?id=162640
2253         <rdar://problem/28182204>
2254
2255         Reviewed by Brent Fulgham.
2256
2257         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2258         * TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm: Added.
2259         (TestWebKitAPI::TEST_F):
2260         Add API tests for SerializedCryptoKeyWrap APIs.
2261
2262 2016-09-29  Alex Christensen  <achristensen@webkit.org>
2263
2264         Fix syntax violation handling in IPv4 address parsing
2265         https://bugs.webkit.org/show_bug.cgi?id=162756
2266
2267         Reviewed by Tim Horton.
2268
2269         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2270         (TestWebKitAPI::TEST_F):
2271
2272 2016-09-29  Alex Christensen  <achristensen@webkit.org>
2273
2274         URLParser should correctly parse ports with leading 0's
2275         https://bugs.webkit.org/show_bug.cgi?id=162752
2276
2277         Reviewed by Tim Horton.
2278
2279         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2280         (TestWebKitAPI::TEST_F):
2281
2282 2016-09-29  Alex Christensen  <achristensen@webkit.org>
2283
2284         URLParser: make parsing invalid IPv4 addresses more robust and correct
2285         https://bugs.webkit.org/show_bug.cgi?id=162746
2286
2287         Reviewed by Tim Horton.
2288
2289         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2290         (TestWebKitAPI::TEST_F):
2291
2292 2016-09-29  Alex Christensen  <achristensen@webkit.org>
2293
2294         URLParser: IPv6 addresses followed by a colon are invalid
2295         https://bugs.webkit.org/show_bug.cgi?id=162747
2296
2297         Reviewed by Tim Horton.
2298
2299         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2300         (TestWebKitAPI::TEST_F):
2301
2302 2016-09-29  Alexey Proskuryakov  <ap@apple.com>
2303
2304         Make WKTR short timeout dynamic
2305         https://bugs.webkit.org/show_bug.cgi?id=162733
2306
2307         Reviewed by Alex Christensen.
2308
2309         WebKitTestRunner has a hardcoded value for how long to wait for IPC responses,
2310         which is 5 seconds, or 10 seconds under ASan. But some of the operations can be
2311         fairly time consuming - e.g. launching Networking process on demand.
2312         These may take longer under load, especially with GuardMalloc.
2313
2314         * WebKitTestRunner/TestController.cpp:
2315         (WTR::TestController::resetStateToConsistentValues):
2316         (WTR::TestController::reattachPageToWebProcess):
2317         * WebKitTestRunner/TestController.h:
2318         * WebKitTestRunner/TestInvocation.cpp:
2319         (WTR::TestInvocation::shortTimeout):
2320         (WTR::TestInvocation::invoke):
2321         (WTR::TestInvocation::dumpResults):
2322
2323         * WebKitTestRunner/TestInvocation.h:
2324         (WTR::TestInvocation::customTimeout): Deleted, this function was unused.
2325
2326 2016-09-29  Alex Christensen  <achristensen@webkit.org>
2327
2328         URLParser should fail to parse unclosed IPv6 addresses
2329         https://bugs.webkit.org/show_bug.cgi?id=162715
2330
2331         Reviewed by Tim Horton.
2332
2333         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2334         (TestWebKitAPI::TEST_F):
2335
2336 2016-09-29  Alex Christensen  <achristensen@webkit.org>
2337
2338         URLParser should ignore tabs at all possible locations
2339         https://bugs.webkit.org/show_bug.cgi?id=162711
2340
2341         Reviewed by Tim Horton.
2342
2343         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2344         (TestWebKitAPI::ExpectedParts::isInvalid):
2345         (TestWebKitAPI::checkURL):
2346         (TestWebKitAPI::TEST_F):
2347
2348 2016-09-29  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
2349
2350         [EFL] Add search button to url bar in MiniBrowser
2351         https://bugs.webkit.org/show_bug.cgi?id=162716
2352
2353         Reviewed by Michael Catanzaro.
2354
2355         As a bug title, it would be good to add a search button to URL bar.
2356         Additionally this patch changes color of button to recognize the buttons.
2357
2358         * MiniBrowser/efl/main.c:
2359         (_search_button_clicked_cb):
2360         (_create_toolbar_button):
2361         (window_create):
2362         (create_toolbar_button): Deleted.
2363
2364 2016-09-28  Tim Horton  <timothy_horton@apple.com>
2365
2366         API test WebKit2.AutoLayoutIntegration is a flaky timeout
2367         https://bugs.webkit.org/show_bug.cgi?id=160284
2368
2369         Reviewed by Dan Bernstein.
2370
2371         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2372         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
2373         (-[AutoLayoutWKWebView beginLayoutAtMinimumWidth:andExpectContentSizeChange:]):
2374         (-[AutoLayoutWKWebView waitForContentSizeChangeResettingWidth:]):
2375         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
2376         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
2377         (TEST):
2378         Make the autolayout tests a bit more flexible regarding the ordering of
2379         invalidateIntrinsicContentSize, to avoid a race between the load
2380         completing and the invalidation.
2381
2382         Also, move the newly added test to use its own WKWebView, since once in a
2383         while we get a first layout notification from the previous page, causing the test to fail.
2384
2385         Un-disable the tests, which now run without any flakes for me with quite a few iterations.
2386
2387 2016-09-28  Alex Christensen  <achristensen@webkit.org>
2388
2389         URLParser should properly handle unexpected periods and overflows in IPv4 addresses
2390         https://bugs.webkit.org/show_bug.cgi?id=162655
2391
2392         Reviewed by Geoffrey Garen.
2393
2394         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2395         (TestWebKitAPI::TEST_F):
2396
2397 2016-09-28  Ryan Haddad  <ryanhaddad@apple.com>
2398
2399         Disable flaky API test WebKit2.AutoLayoutIntegration.
2400         https://bugs.webkit.org/show_bug.cgi?id=160284
2401
2402         Unreviewed test gardening.
2403
2404         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2405         (TEST):
2406
2407 2016-09-28  Alex Christensen  <achristensen@webkit.org>
2408
2409         URLParser should ignore tabs in authority
2410         https://bugs.webkit.org/show_bug.cgi?id=162694
2411
2412         Reviewed by Geoffrey Garen.
2413
2414         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2415         (TestWebKitAPI::TEST_F):
2416
2417 2016-09-28  Alex Christensen  <achristensen@webkit.org>
2418
2419         URLParser should ignore extra slashes after scheme:// and handle a missing slash after the port
2420         https://bugs.webkit.org/show_bug.cgi?id=162690
2421
2422         Reviewed by Geoffrey Garen.
2423
2424         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2425         (TestWebKitAPI::TEST_F):
2426
2427 2016-09-28  Alex Christensen  <achristensen@webkit.org>
2428
2429         URLParser should correctly canonicalize uppercase IPv6 addresses
2430         https://bugs.webkit.org/show_bug.cgi?id=162680
2431
2432         Reviewed by Tim Horton.
2433
2434         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2435         (TestWebKitAPI::TEST_F):
2436
2437 2016-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2438
2439         Adopt MediaRemote SPI to achieve desired Now Playing behavior
2440         https://bugs.webkit.org/show_bug.cgi?id=162658
2441         <rdar://problem/28499358>
2442
2443         Reviewed by Jer Noble.
2444
2445         Introduces 2 unit tests in the new NowPlayingControlsTests test suite. Also provides some basic support for
2446         mocking key window status for TestWKWebViews.
2447
2448         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2449         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: Added.
2450         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
2451         (-[NowPlayingTestWebView expectHasActiveNowPlayingSession:]):
2452         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]):
2453         (TestWebKitAPI::TEST):
2454         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: Added.
2455         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
2456         (-[TestWKWebViewHostWindow isKeyWindow]):
2457         (-[TestWKWebViewHostWindow makeKeyWindow]):
2458         (-[TestWKWebViewHostWindow resignKeyWindow]):
2459
2460 2016-09-28  Per Arne Vollan  <pvollan@apple.com>
2461
2462         [Win] Compile fix.
2463         https://bugs.webkit.org/show_bug.cgi?id=162670
2464
2465         Reviewed by Brent Fulgham.
2466
2467         Make sure we include JavaScriptCore files from the forwarding headers folder.
2468         Otherwise we might get multiple definitions if a JSC file is included both
2469         from the forwarding headers folder and the JSC source folder, since
2470         #pragma once is used in the header files.
2471
2472         * DumpRenderTree/TestRunner.cpp:
2473
2474 2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2475
2476         [GTK] Add Chrome UA quirk
2477         https://bugs.webkit.org/show_bug.cgi?id=162617
2478
2479         Reviewed by Carlos Garcia Campos.
2480
2481         Update test. This portion of the commit was actually unreviewed.
2482
2483         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
2484         (TestWebKitAPI::TEST):
2485
2486 2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2487
2488         [GTK] Adjust OS X UA quirks list
2489         https://bugs.webkit.org/show_bug.cgi?id=162616
2490
2491         "Reviewed" by Carlos Garcia Campos.
2492
2493         Update test. This portion of the commit was actually unreviewed.
2494
2495         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
2496         (TestWebKitAPI::TEST):
2497
2498 2016-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2499
2500         [GTK] Switch to use GMenu internally in the context menu implementation
2501         https://bugs.webkit.org/show_bug.cgi?id=162603
2502
2503         Reviewed by Michael Catanzaro.
2504
2505         Remove smart separators test, since that's now done automatically by GTK+.
2506
2507         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2508         (beforeAll):
2509         (testContextMenuWebExtensionMenu): Deleted.
2510
2511 2016-09-27  Alex Christensen  <achristensen@webkit.org>
2512
2513         Correctly parse URLs with the first tab in the fragment
2514         https://bugs.webkit.org/show_bug.cgi?id=162650
2515
2516         Reviewed by Saam Barati.
2517
2518         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2519         (TestWebKitAPI::TEST_F):
2520
2521 2016-09-27  Alex Christensen  <achristensen@webkit.org>
2522
2523         URLParser: Handle windows drive letters after two slashes in relative URLs according to spec
2524         https://bugs.webkit.org/show_bug.cgi?id=162646
2525
2526         Reviewed by Saam Barati.
2527
2528         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2529         (TestWebKitAPI::TEST_F):
2530
2531 2016-09-27  Alex Christensen  <achristensen@webkit.org>
2532
2533         URLs with @ in the user should only search for the last @ until the end of the authority and host
2534         https://bugs.webkit.org/show_bug.cgi?id=162635
2535
2536         Reviewed by Geoffrey Garen.
2537
2538         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2539         (TestWebKitAPI::TEST_F):
2540
2541 2016-09-27  JF Bastien  <jfbastien@apple.com>
2542
2543         Speed up Heap::isMarkedConcurrently
2544         https://bugs.webkit.org/show_bug.cgi?id=162095
2545
2546         Reviewed by Filip Pizlo.
2547
2548         * TestWebKitAPI/CMakeLists.txt:
2549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2550         * TestWebKitAPI/Tests/WTF/Consume.cpp: Added.
2551         (testConsume):
2552         (TestWebKitAPI::TEST):
2553
2554 2016-09-26  Alex Christensen  <achristensen@webkit.org>
2555
2556         Implement URLParser::syntaxViolation
2557         https://bugs.webkit.org/show_bug.cgi?id=162593
2558
2559         Reviewed by Geoffrey Garen.
2560
2561         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2562         (TestWebKitAPI::TEST_F):
2563
2564 2016-09-27  Anders Carlsson  <andersca@apple.com>
2565
2566         Turns out OptionSet.cpp wasn't added to the right target. Add it and fix the build for real.
2567
2568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2569         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2570         (TestWebKitAPI::TEST):
2571
2572 2016-09-27  Anders Carlsson  <andersca@apple.com>
2573
2574         Try to fix the GTK+ build.
2575
2576         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2577         (TestWebKitAPI::TEST):
2578
2579 2016-09-27  Dan Bernstein  <mitz@apple.com>
2580
2581         [iOS] REGRESSION (r182126): Selection highlight and handles aren’t visible with WKSelectionGranularityCharacter
2582         https://bugs.webkit.org/show_bug.cgi?id=162577
2583         <rdar://problem/28481984>
2584
2585         Reviewed by Simon Fraser.
2586
2587         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2588         (WTR::UIScriptController::selectionRangeViewRects): Returns null.
2589
2590         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Declared new
2591           selectionRangeViewRects attribute.
2592
2593         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2594         (WTR::UIScriptContext::jsContext): Added this public accessor.
2595
2596         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2597         (WTR::selectionRangeViewRects): Generic implementation that returns null.
2598         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2599
2600         * WebKitTestRunner/TestController.cpp:
2601         (WTR::updateTestOptionsFromTestHeader): Parse the new useCharacterSelectionGranularity
2602           option.
2603
2604         * WebKitTestRunner/TestOptions.h: Added new useCharacterSelectionGranularity option.
2605
2606         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2607         (WTR::TestController::platformCreateWebView): Set the configuration’s selectionGranularity
2608           property based on the new option.
2609
2610         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2611         (WTR::PlatformWebView::viewSupportsOptions): Compare selection granularity option values.
2612
2613         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2614         (WTR::UIScriptController::selectionRangeViewRects): iOS-specific implementation that calls
2615           the new -[WKWebView _uiTextSelectionRectViews] and returns an array of view frame
2616           dictionaries.
2617
2618 2016-09-27  Daniel Bates  <dabates@apple.com>
2619
2620         Cannot run dump-class-layout; dies with "global name 'lldb' is not defined"
2621         https://bugs.webkit.org/show_bug.cgi?id=162585
2622
2623         Reviewed by Simon Fraser.
2624
2625         Import the lldb module into the global namespace.
2626
2627         Currently dump-class-layout imports the lldb Python module using the import statement
2628         from the helper function import_lldb. The import statement imports the names of the
2629         specified module into the scope of import_lldb(); => the names imported from this
2630         module cannot be accessed outside the scope of import_lldb(). Other functions in
2631         this script assume that the lldb module was imported into the global scope. We should
2632         import the module lldb into the global scope, if it exists, so that these functions
2633         can find it. Otherwise, we should emit a human readable error message that explains
2634         that we failed to import the lldb module.
2635
2636         Also remove some unnecessary semicolon characters.
2637
2638         * Scripts/dump-class-layout:
2639         (import_lldb):
2640
2641 2016-09-27  Jer Noble  <jer.noble@apple.com>
2642
2643         Remove deprecated ENCRYPTED_MEDIA implementation.
2644         https://bugs.webkit.org/show_bug.cgi?id=161010
2645
2646         Reviewed by Eric Carlson.
2647
2648         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2649
2650 2016-09-27  Chris Dumez  <cdumez@apple.com>
2651
2652         [WK2] Navigating to a Blob URL does not trigger a download
2653         https://bugs.webkit.org/show_bug.cgi?id=162574
2654
2655         Reviewed by Darin Adler.
2656
2657         Add API that tests navigating to a Blob URL and checks that that the load
2658         properly gets converted into a download.
2659
2660         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2661         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2662         (-[BlobDownloadDelegate _downloadDidStart:]):
2663         (-[BlobDownloadDelegate _download:didReceiveResponse:]):
2664         (-[BlobDownloadDelegate _download:didReceiveData:]):
2665         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2666         (-[BlobDownloadDelegate _downloadDidFinish:]):
2667         (-[DownloadBlobURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2668         (TEST):
2669         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestBlobURL.html: Added.
2670
2671 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2672
2673         [GTK] Install binaries to pkglibexecdir rather than bindir
2674         https://bugs.webkit.org/show_bug.cgi?id=162602
2675
2676         Reviewed by Carlos Garcia Campos.
2677
2678         Install MiniBrowser to LIBEXEC_INSTALL_DIR rather than EXEC_INSTALL_DIR.
2679
2680         * MiniBrowser/gtk/CMakeLists.txt:
2681
2682 2016-09-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2683
2684         [EFL] Locate color picker popup to center of window
2685         https://bugs.webkit.org/show_bug.cgi?id=162540
2686
2687         Reviewed by Michael Catanzaro.
2688
2689         Color picker popup hasn't located in a center of main window, because
2690         elm_win_center() function doesn't work correctly. It looks a bug.
2691
2692         To fix the problem, this patch uses evas_object_geometry_set() instead.
2693
2694         * MiniBrowser/efl/main.c:
2695         (_color_picker_request_cb):
2696
2697 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2698
2699         [GTK] Disable ACCELERATED_2D_CANVAS when using build-webkit
2700         https://bugs.webkit.org/show_bug.cgi?id=162600
2701
2702         Reviewed by Carlos Garcia Campos.
2703
2704         * Scripts/webkitperl/FeatureList.pm:
2705
2706 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2707
2708         PyGIWarnings printed by webkit-patch
2709         https://bugs.webkit.org/show_bug.cgi?id=152470
2710
2711         Reviewed by Carlos Garcia Campos.
2712
2713         Update to a newer version of the keyring module, since this bug has been fixed upstream for
2714         a while. But be careful not to update to the latest version, since it has some compatibility
2715         breaks and requires the SecretService python module on Linux, but I couldn't figure out how
2716         to autoinstall it successfully.
2717
2718         * Scripts/webkitpy/thirdparty/__init__.py:
2719         (AutoinstallImportHook._install_keyring):
2720
2721 2016-09-26  Ryan Haddad  <ryanhaddad@apple.com>
2722
2723         Add Sierra to the flakiness dashboard.
2724         https://bugs.webkit.org/show_bug.cgi?id=162509
2725
2726         Reviewed by Alexey Proskuryakov.
2727
2728         * TestResultServer/static-dashboards/builders.jsonp:
2729
2730 2016-09-26  Daniel Bates  <dabates@apple.com>
2731
2732         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
2733         https://bugs.webkit.org/show_bug.cgi?id=162365
2734
2735         Reviewed by Simon Fraser.
2736
2737         * DumpRenderTree/TestRunner.h:
2738         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2739
2740 2016-09-26  Tomas Popela  <tpopela@redhat.com>
2741
2742         [GTK] TestContextMenu is failing
2743         https://bugs.webkit.org/show_bug.cgi?id=162569
2744
2745         We cannot use the MP3 file in the TestContextMenu, as it will not work
2746         by default on most distributions (that don't have an MP3 codecs
2747         installed). Change the test to use OGG file instead.
2748
2749         Reviewed by Michael Catanzaro.
2750
2751         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2752         (testContextMenuDefaultMenu):
2753
2754 2016-09-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2755
2756         Using char16_t instead of wchar_t in TestWebKitAPI URLParser tests
2757         https://bugs.webkit.org/show_bug.cgi?id=162537
2758
2759         Reviewed by Alex Christensen.
2760
2761         Some build bot (Linux ARM GTK port) fails since we cannot select
2762         the specific StringBuilder::append method for wchar_t.
2763
2764         wchar_t implementation highly depends on platforms. sizeof(wchar_t) == 2
2765         in Windows, while sizeof(wchar_t) == 4 in Linux and OS X. So, ICU
2766         uses wchar_t for UChar (UTF-16) in Windows while it doesn't in other
2767         platforms.
2768
2769         StringBuilder::append is overloaded for UChar. In Windows, we can pass
2770         wchar_t since UChar is wchar_t. However, we cannot do that in other platforms.
2771
2772         Instead of using wchar_t, we use more platform portable UTF-16 literal for
2773         testing. Use char16_t and C++11 UTF-16 literal.
2774
2775         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2776         (TestWebKitAPI::utf16String):
2777         (TestWebKitAPI::TEST_F):
2778         (TestWebKitAPI::wideString): Deleted.
2779
2780 2016-09-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2781
2782         [EFL] Adjust EFL indentation to EFL MiniBrowser
2783         https://bugs.webkit.org/show_bug.cgi?id=162542
2784
2785         Unreviewed, EFL simple coding style fix.
2786
2787         Some functions wasn't applied EFL coding style in prefix fix.
2788
2789         * MiniBrowser/efl/main.c:
2790         (_key_down_cb):
2791         (view_focus_set):
2792         (_mouse_down_cb):
2793         (title_set):
2794         (_title_changed_cb):
2795         (_url_changed_cb):
2796         (_back_forward_list_changed_cb):
2797         (_progress_cb):
2798         (_error_cb):
2799         (_download_request_cb):
2800         (close_file_picker):
2801         (_filepicker_parent_deletion_cb):
2802         (_filepicker_deletion_cb):
2803         (_fileselector_done_cb):
2804         (_file_chooser_request_cb):
2805         (_download_finished_cb):
2806         (_download_failed_cb):
2807         (_color_changed_cb):
2808         (_color_item_selected_cb):
2809         (_color_picker_ok_clicked_cb):
2810         (_color_picker_cancel_clicked_cb):
2811         (_color_picker_dismiss_cb):
2812         (_color_picker_request_cb):
2813         (quit):
2814         (has_scheme):
2815         (url_from_user_input):
2816         (url_load_from_user_input):
2817         (_url_bar_activated_cb):
2818         (_url_bar_clicked_cb):
2819         (_search_field_aborted_cb):
2820         (_search_field_activated_cb):
2821         (_search_field_clicked_cb):
2822         (_back_button_clicked_cb):
2823         (_forward_button_clicked_cb):
2824         (_search_backward_button_clicked_cb):
2825         (_search_forward_button_clicked_cb):
2826         (_search_case_option_changed):
2827         (_search_word_start_option_changed_cb):
2828         (_search_close_button_clicked_cb):
2829         (_refresh_button_clicked_cb):
2830         (_stop_button_clicked_cb):
2831         (list_item_label_get):
2832         (_list_item_select_cb):
2833         (navigation_button_longpress_process):
2834         (_forward_button_longpress_cb):
2835         (_back_button_longpress_cb):
2836         (quit_event_loop):
2837         (_ok_clicked_cb):
2838         (_file_entry_dialog_show):
2839
2840 2016-09-24  Chris Dumez  <cdumez@apple.com>
2841
2842         [WK2] anchor.download attribute value is ignored by NETWORK_SESSION code path
2843         https://bugs.webkit.org/show_bug.cgi?id=162531
2844
2845         Reviewed by Darin Adler.
2846
2847         Update decideDestinationWithSuggestedFilename() to return a actual file path
2848         instead of nullptr. The NETWORK_SESSION code path cancels the download when
2849         decideDestinationWithSuggestedFilename() returns an empty file path, unlike
2850         the !NETWORK_SESSION code path that just continue downloading without
2851         explicitely setting a destination path. This lead to different test results
2852         for NETWORK_SESSION and !NETWORK_SESSION code paths. Returns a valid
2853         destination path makes more sense and leads to consistent results.
2854
2855         * WebKitTestRunner/TestController.cpp:
2856         (WTR::TestController::decideDestinationWithSuggestedFilename):
2857
2858 2016-09-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2859
2860         [mac-sierra] 2 WKWebViewCandidateTests API test failures
2861         https://bugs.webkit.org/show_bug.cgi?id=162470
2862
2863         Reviewed by Tim Horton.
2864
2865         VideoControlsManager, WKWebViewCandidateTests and CandidateTests should not be running on 10.12.0. Guard these
2866         tests with an SDK check to prevent 10.12.0 bots from building them.
2867
2868         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2869         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2870         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2871
2872 2016-09-23  Alex Christensen  <achristensen@webkit.org>
2873
2874         Refactor URLParser
2875         https://bugs.webkit.org/show_bug.cgi?id=162516
2876
2877         Reviewed by Brady Eidson.
2878
2879         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2880         (TestWebKitAPI::TEST_F):
2881
2882 2016-09-23  Caitlin Potter  <caitp@igalia.com>
2883
2884         [JSC] Implement parsing of Async Functions
2885         https://bugs.webkit.org/show_bug.cgi?id=161409
2886
2887         Reviewed by Yusuke Suzuki.
2888
2889         * Scripts/build-jsc:
2890         (cMakeArgsFromFeatures):
2891         * Scripts/webkitperl/FeatureList.pm:
2892         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2893
2894 2016-09-23  Alex Christensen  <achristensen@webkit.org>
2895
2896         Refactor URLParser
2897         https://bugs.webkit.org/show_bug.cgi?id=162511
2898
2899         Reviewed by Brady Eidson.
2900
2901         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2902         (TestWebKitAPI::TEST_F):
2903         (TestWebKitAPI::checkURL):
2904
2905 2016-09-23  Alexey Proskuryakov  <ap@apple.com>
2906
2907         iOS playback user action tests fail on some machines
2908         https://bugs.webkit.org/show_bug.cgi?id=162504
2909         rdar://problem/28013994
2910
2911         Reviewed by Jer Noble.
2912
2913         Avoid the need to have a timeout.
2914
2915         * TestWebKitAPI/Tests/WebKit/ios/audio-only.html:
2916         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
2917         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
2918         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html:
2919
2920 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2921
2922         REGRESSION(r204163): [GTK] API test /webkit2/WebKitSecurityManager/file-xhr is failing
2923         https://bugs.webkit.org/show_bug.cgi?id=161607
2924
2925         Reviewed by Michael Catanzaro.
2926
2927         Since r204163, in case of cross origin error when loading the XHR, the load fails and an error message is shown
2928         in the console, but there isn't any js expcetion, which is what we were checking. Now, we check that there
2929         aren't exceptions, and that the error message is sent to the console.
2930
2931         * Scripts/run-gtk-tests:
2932         (TestRunner):
2933         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2934         (consoleMessageReceivedCallback):
2935         (testWebContextSecurityFileXHR):
2936
2937 2016-09-23  Ryan Haddad  <ryanhaddad@apple.com>
2938
2939         Use correct hardware for Sierra Debug WK2 testers.
2940         https://bugs.webkit.org/show_bug.cgi?id=162474
2941
2942         Reviewed by Alexey Proskuryakov.
2943
2944         * BuildSlaveSupport/build.webkit.org-config/config.json:
2945
2946 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2947
2948         [GTK] Make all WebView tests have a WebKitUserContentManager
2949         https://bugs.webkit.org/show_bug.cgi?id=162487
2950
2951         Reviewed by Michael Catanzaro.
2952
2953         It simplifies tests using the user content manager, and allows to use it without having to subclass WebViewTest.
2954
2955         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2956         (ConsoleMessageTest::ConsoleMessageTest):
2957         (ConsoleMessageTest::~ConsoleMessageTest):
2958         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2959         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2960         (testUserContentManagerInjectedStyleSheet):
2961         (testUserContentManagerInjectedScript):
2962         (UserScriptMessageTest::UserScriptMessageTest):
2963         (beforeAll):
2964         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2965         (testWebViewIsPlayingAudio):
2966         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2967         (WebViewTest::WebViewTest):
2968         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2969
2970 2016-09-23  Antoine Quint  <graouts@apple.com>
2971
2972         Add a new runtime flag for work on modern media controls (off by default)
2973         https://bugs.webkit.org/show_bug.cgi?id=162420
2974         <rdar://problem/27989489>
2975
2976         Reviewed by Eric Carlson.
2977
2978         * DumpRenderTree/mac/DumpRenderTree.mm:
2979         (resetWebPreferencesToConsistentValues):
2980         * DumpRenderTree/win/DumpRenderTree.cpp:
2981         (resetWebPreferencesToConsistentValues):
2982         * Scripts/webkitperl/FeatureList.pm:
2983         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2984         (WTR::InjectedBundle::beginTesting):
2985         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2986         (WTR::TestRunner::setModernMediaControlsEnabled):
2987         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2988
2989 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2990
2991         REGRESSION(r194387): Crash on github.com in IntlDateTimeFormat::resolvedOptions in C locale
2992         https://bugs.webkit.org/show_bug.cgi?id=162139
2993
2994         Reviewed by Michael Catanzaro.
2995
2996         Add test cases to check the behavior when using the C locale and an invalid locale.
2997
2998         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2999         (testWebContextLanguages):
3000
3001 2016-09-22  Hunseop Jeong  <hs85.jeong@samsung.com>
3002
3003         [EFL] alert box is not displayed 
3004         https://bugs.webkit.org/show_bug.cgi?id=156395
3005
3006         Reviewed by Gyuyoung Kim.
3007
3008         Some popup objects(alert, confirm, prompt, file entry dialog) used the ecore_main_loop_begin() to make
3009         the modal popup but ecore_main_loop_begin() was not executed inside an exisiting main loop. So we have
3010         to use the ecore_main_loop_iterate() instead of the ecore_main_loop_begin().
3011
3012         * MiniBrowser/efl/main.c:
3013         (_ok_clicked_cb):
3014         (_file_entry_dialog_show):
3015         (_javascript_alert_cb):
3016         (_javascript_confirm_cb):
3017         (_javascript_prompt_cb):
3018         (quit_event_loop): Deleted.
3019
3020 2016-09-22  Matthew Hanson  <matthew_hanson@apple.com>
3021
3022         Add an API for getting the branch identifier from a Git or SVN checkout.
3023         https://bugs.webkit.org/show_bug.cgi?id=151570
3024         rdar://problem/17959831
3025
3026         Reviewed by David Kilzer.
3027
3028         This patch adds a function called svnIdentifierForPath. This function returns either "trunk",
3029         the name of the tag, or the name of the branch, as appropriate. This function is necessary for
3030         a VCSUtils client that is not checked in to the WebKit project.
3031
3032         This patch also breaks up pathRelativeToSVNRepositoryRootForPath into four functions:
3033         - pathRelativeToSVNRepositoryRootForPath
3034         - svnInfoForPath
3035         - svnURLForPath
3036         - svnRepositoryRootForPath
3037
3038         This allows us to reuse logic from pathRelativeToSVNRepositoryRootForPath in svnIdentifierForPath and
3039         allows clients of VCSUtils to extract what arbitrary information from the `svn info` command regardless
3040         of SCM.
3041
3042         * Scripts/VCSUtils.pm:
3043         (svnInfoForPath):
3044         Copied logic that previously lived in pathRelativeToSVNRepositoryRootForPath.
3045         Make code safe to use for a path, and not just for the CWD.
3046
3047         (svnURLForPath):
3048         Calls svnInfoForPath and extracts the URL.
3049
3050         (svnRepositoryRootForPath):
3051         Calls svnInfoForPath and extracts the Repository Root.
3052
3053         (svnIdentifierForPath):
3054         Calls pathRelativeToSVNRepositoryRootForPath and extracts the repository identifier.
3055
3056         (pathRelativeToSVNRepositoryRootForPath):
3057         Now uses svnURLForPath and svnRepositoryRootForPath instead of being responsible for
3058         determining both values.
3059
3060 2016-09-22  Megan Gardner  <megan_gardner@apple.com>
3061
3062         Add long press selection test
3063         https://bugs.webkit.org/show_bug.cgi?id=162367
3064
3065         Reviewed by Simon Fraser.
3066
3067         Add support to UIScriptController to synthesize long press events on iOS.
3068         This required adding long-press functionality to HIDEventGenerator.
3069
3070         HIDEventGenerator sends the touchDown, but must then send the touchUp with
3071         a dispatch_after (rather than sleeping, as we do for other events) in order
3072         for the gesture recognizers to correctly detect a long press.
3073
3074         Use the long press synthesis in a test that detects whether a long press
3075         gesture triggers text selection.
3076
3077         Fixed incorrect constants. NSTimeInterval is in seconds, original numbers
3078         were nanoseconds and typedefed to long without regard to the type
3079         differences. Redid constants to be the right value, and converted upon use.
3080
3081         Cleaned up unused enum types.
3082
3083         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3084         (WTR::UIScriptController::longPressAtPoint):
3085         (WTR::UIScriptController::forcePressAtPoint):
3086         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
3087         * Scripts/webkitpy/common/config/contributors.json:
3088         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3089         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3090         (WTR::UIScriptController::longPressAtPoint):
3091         (WTR::UIScriptController::forcePressAtPoint):
3092         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
3093         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3094         * WebKitTestRunner/ios/HIDEventGenerator.h:
3095         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3096         (-[HIDEventGenerator _createIOHIDEventType:]):
3097         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3098         (-[HIDEventGenerator clearTap:]):
3099         (-[HIDEventGenerator longPressTimerCall:]):
3100         (-[HIDEventGenerator longPressFinish:completionBlock:]):
3101         (-[HIDEventGenerator longPress:completionBlock:]):
3102         (-[HIDEventGenerator forcePress:completionBlock:]):
3103         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3104         (WTR::UIScriptController::longPressAtPoint):
3105         (WTR::UIScriptController::forcePressAtPoint):
3106         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
3107
3108 2016-09-22  Jonathan Bedard  <jbedard@apple.com>
3109
3110         Automatic Text Replacement Testing in WebKit2
3111         https://bugs.webkit.org/show_bug.cgi?id=161919
3112
3113         Reviewed by Ryosuke Niwa.
3114
3115         Implemented test hooks for text replacement for WebKit2.
3116         Note that spell checking has not been implemented, so most tests which use text replacement still fail.
3117
3118         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Removed setAutomaticLinkDetectionEnabled from TestRunner, moved to Internals.
3119         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
3120         (WTR::InjectedBundle::beginTesting): Ditto.
3121         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
3122         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
3123         * WebKitTestRunner/TestController.cpp:
3124         (WTR::TestController::runTest): Place TextChecker into testing mode.
3125
3126 2016-09-21  Dan Bernstein  <mitz@apple.com>
3127
3128         [macOS] Upon layout, _webView:renderingProgressDidChange: fires before the intrinsic content size is updated
3129         https://bugs.webkit.org/show_bug.cgi?id=162359
3130         <rdar://problem/27776454>
3131
3132         Reviewed by Tim Horton.
3133
3134         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3135         (TEST):
3136
3137 2016-09-21  Keith Miller  <keith_miller@apple.com>
3138
3139         Fix build for future versions of Clang.
3140         https://bugs.webkit.org/show_bug.cgi?id=162346
3141
3142         Reviewed by Filip Pizlo.
3143
3144         * TestWebKitAPI/Counters.cpp:
3145         * TestWebKitAPI/Counters.h:
3146         (DeleterCounter::deleterCount):
3147         (DeleterCounter::TestingScope::TestingScope):
3148         (DeleterCounter::operator()):
3149         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
3150         (TestWebKitAPI::TEST):
3151         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3152         (TestWebKitAPI::TEST):
3153
3154 2016-09-21  Commit Queue  <commit-queue@webkit.org>
3155
3156         Unreviewed, rolling out r206222 and r206227.
3157         https://bugs.webkit.org/show_bug.cgi?id=162361
3158
3159         "broke the windows build" (Requested by keith_mi_ on #webkit).
3160
3161         Reverted changesets:
3162
3163         "Fix build for future versions of Clang."
3164         https://bugs.webkit.org/show_bug.cgi?id=162346
3165         http://trac.webkit.org/changeset/206222
3166
3167         "Attempt to fix windows build after r206222."
3168         http://trac.webkit.org/changeset/206227
3169
3170 2016-09-21  Alex Christensen  <achristensen@webkit.org>
3171
3172         URLParser should match URL::parse when parsing data urls with slashes in them
3173         https://bugs.webkit.org/show_bug.cgi?id=162352
3174
3175         Reviewed by Darin Adler.
3176
3177         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3178         (TestWebKitAPI::TEST_F):
3179
3180 2016-09-21  Alex Christensen  <achristensen@webkit.org>
3181
3182         URLParser should fail when parsing invalid relative URLs with no schemes
3183         https://bugs.webkit.org/show_bug.cgi?id=162355
3184
3185         Reviewed by Tim Horton.
3186
3187         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3188         (TestWebKitAPI::TEST_F):
3189
3190 2016-09-21  Keith Miller  <keith_miller@apple.com>
3191
3192         Fix build for future versions of Clang.
3193         https://bugs.webkit.org/show_bug.cgi?id=162346
3194
3195         Reviewed by Filip Pizlo.
3196
3197         * TestWebKitAPI/Counters.cpp:
3198         * TestWebKitAPI/Counters.h:
3199         (DeleterCounter::deleterCount):
3200         (DeleterCounter::TestingScope::TestingScope):
3201         (DeleterCounter::operator()):
3202         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
3203         (TestWebKitAPI::TEST):
3204         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3205         (TestWebKitAPI::TEST):
3206
3207 2016-09-21  Alex Christensen  <achristensen@webkit.org>
3208
3209         Prepare API tests for enabling URLParser by default
3210         https://bugs.webkit.org/show_bug.cgi?id=162341
3211
3212         Reviewed by Tim Horton.
3213
3214         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3215         (TestWebKitAPI::checkURL):
3216         (TestWebKitAPI::checkRelativeURL):
3217         (TestWebKitAPI::checkURLDifferences):
3218         (TestWebKitAPI::checkRelativeURLDifferences):
3219         (TestWebKitAPI::shouldFail):
3220
3221 2016-09-21  Alex Christensen  <achristensen@webkit.org>
3222
3223         URLParser: Correctly parse URLs that are just nonspecialscheme:/
3224         https://bugs.webkit.org/show_bug.cgi?id=162340
3225
3226         Reviewed by Tim Horton.
3227
3228         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3229         (TestWebKitAPI::TEST_F):
3230
3231 2016-09-21  Alex Christensen  <achristensen@webkit.org>
3232
3233         URLParser: correctly parse relative URLs that are just one character
3234         https://bugs.webkit.org/show_bug.cgi?id=162344
3235
3236         Reviewed by Tim Horton.
3237
3238         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3239         (TestWebKitAPI::TEST_F):
3240
3241 2016-09-20  Alex Christensen  <achristensen@webkit.org>
3242
3243         Optimize URLParser
3244         https://bugs.webkit.org/show_bug.cgi?id=162105
3245
3246         Reviewed by Geoffrey Garen.
3247
3248         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3249         (TestWebKitAPI::TEST_F):
3250
3251 2016-09-20  Aakash Jain  <aakash_jain@apple.com>
3252
3253         enable remote_api (for debugging) in flakiness dashboard app
3254         https://bugs.webkit.org/show_bug.cgi?id=162325
3255
3256         Reviewed by Alexey Proskuryakov.
3257
3258         * TestResultServer/app.yaml: enabled remote_api and datastore_admin.
3259
3260 2016-09-20  Ryan Haddad  <ryanhaddad@apple.com>
3261
3262         Unreviewed, rolling out r206180.
3263
3264         Roll r206178 back in as the necessary changes have been made
3265         on the build master.
3266
3267         Reverted changeset:
3268
3269         "Unreviewed, rolling out r206178."
3270         https://bugs.webkit.org/show_bug.cgi?id=162249
3271         http://trac.webkit.org/changeset/206180
3272
3273 2016-09-20  Alexey Proskuryakov  <ap@apple.com>
3274
3275         Use a hardcoded patch for sRGB color profile
3276         https://bugs.webkit.org/show_bug.cgi?id=162320
3277         rdar://problem/28387318
3278
3279         Reviewed by Simon Fraser.
3280
3281         This is a workaround for rdar://problem/28392768
3282
3283         * DumpRenderTree/mac/LayoutTestHelper.m:
3284         (installLayoutTestColorProfile):
3285
3286 2016-09-20  Ryan Haddad  <ryanhaddad@apple.com>
3287
3288         Unreviewed, rolling out r206178.
3289
3290         This change caused buildbot config issues.
3291
3292         Reverted changeset:
3293
3294         "Add Sierra bots to buildbot and dashboard."
3295         https://bugs.webkit.org/show_bug.cgi?id=162249
3296         http://trac.webkit.org/changeset/206178
3297
3298 2016-09-20  Dean Johnson  <dean_johnson@apple.com>
3299
3300         Add Sierra bots to buildbot and dashboard.
3301         https://bugs.webkit.org/show_bug.cgi?id=162249
3302
3303         Reviewed by Alexey Proskuryakov.
3304
3305         * BuildSlaveSupport/build.webkit.org-config/config.json:
3306         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3307         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3308         (WebKitBuildbot):
3309
3310 2016-09-20  Alex Christensen  <achristensen@webkit.org>
3311
3312         Reduce allocations in URLParser
3313         https://bugs.webkit.org/show_bug.cgi?id=162241
3314
3315         Reviewed by Chris Dumez.
3316
3317         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3318         (TestWebKitAPI::TEST_F):
3319         (TestWebKitAPI::checkURL):
3320
3321 2016-09-20  Alex Christensen  <achristensen@webkit.org>
3322
3323         Align URLParser with web platform tests when parsing non-special relative URLs ending in AuthorityOrHost state
3324         https://bugs.webkit.org/show_bug.cgi?id=162251
3325
3326         Reviewed by Tim Horton.
3327
3328         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3329         (TestWebKitAPI::checkURL):
3330         (TestWebKitAPI::TEST_F):
3331         (TestWebKitAPI::checkRelativeURL):
3332         (TestWebKitAPI::checkURLDifferences):
3333         (TestWebKitAPI::checkRelativeURLDifferences):
3334
3335 2016-09-20  Alex Christensen  <achristensen@webkit.org>
3336
3337         URLParser should allow '@' in user
3338         https://bugs.webkit.org/show_bug.cgi?id=162272
3339
3340         Reviewed by Tim Horton.
3341
3342         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3343         (TestWebKitAPI::TEST_F):
3344
3345 2016-09-20  Alex Christensen  <achristensen@webkit.org>
3346
3347         URLParser: Fix parsing relative URLs with one slash after the scheme:
3348         https://bugs.webkit.org/show_bug.cgi?id=162294
3349
3350         Reviewed by Tim Horton.
3351
3352         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3353         (TestWebKitAPI::TEST_F):
3354
3355 2016-09-20  Alex Christensen  <achristensen@webkit.org>
3356
3357         Fix Windows file URL quirks in URLParser
3358         https://bugs.webkit.org/show_bug.cgi?id=162303
3359
3360         Reviewed by Tim Horton.
3361
3362         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3363         (TestWebKitAPI::TEST_F):
3364
3365 2016-09-20  Filip Pizlo  <fpizlo@apple.com>
3366
3367         Make MarkedBlock state tracking support overlapped allocation and marking state
3368         https://bugs.webkit.org/show_bug.cgi?id=161581
3369
3370         Reviewed by Geoffrey Garen.
3371         
3372         Remove the always-trigger-copy-phase configuration.
3373
3374         * Scripts/run-jsc-stress-tests:
3375
3376 2016-09-20  Don Olmstead  <don.olmstead@am.sony.com>
3377
3378         [WinCairo] Use find_package cairo in build
3379         https://bugs.webkit.org/show_bug.cgi?id=162239
3380
3381         Reviewed by Alex Christensen.
3382
3383         * DumpRenderTree/PlatformWin.cmake:
3384         * TestWebKitAPI/PlatformWin.cmake:
3385
3386 2016-09-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3387
3388         Unreviewed build fix on 10.10 bots.
3389
3390         * TestWebKitAPI/mac/TestWKWebViewMac.h:
3391
3392 2016-09-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3393
3394         VideoControlsManager.VideoControlsManagerSingleLargeVideo fails intermittently on the Mac WK2 bot
3395         https://bugs.webkit.org/show_bug.cgi?id=162255
3396
3397         Reviewed by Jer Noble.
3398
3399         This is reproducible by running the test repeatedly in a for loop (locally, I observed that running the test
3400         back-to-back would result in the second one failing). This suggests that even on the runloop after the video
3401         starts playing, the state of the playback controls manager may not be up to date in the UI process. Instead, we
3402         can just spin the runloop until the playback controls are shown, which makes back-to-back tests to succeed and
3403         will probably address flakiness on the bots for this test.
3404
3405         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3406         (TestWebKitAPI::TEST):
3407         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
3408
3409 2016-09-20  Per Arne Vollan  <pvollan@apple.com>
3410
3411         [Win] Run layout tests in parallel.
3412         https://bugs.webkit.org/show_bug.cgi?id=162145
3413
3414         Reviewed by Brent Fulgham.
3415
3416         To speed up layout tests, try running them in parallel.
3417
3418         * Scripts/webkitpy/port/win.py:
3419         (WinPort.default_child_processes): Deleted.
3420
3421 2016-09-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3422
3423         Unreviewed build fix after r206135
3424
3425         NSEventMaskLeftMouseDown and friends are only available on 10.12.
3426
3427         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
3428         (__simulated_forceClickAssociatedEventsMask):
3429
3430 2016-09-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3431
3432         Add a unit test covering <https://trac.webkit.org/changeset/205983>
3433         https://bugs.webkit.org/show_bug.cgi?id=162112
3434
3435         Reviewed by Beth Dakin.
3436
3437         Adds a new unit test covering the changes in r205983 along with the infrastructure needed to support it. Also
3438         further refactors the TestWKWebView used by VideoControlsManager and WKWebViewCandidateTests so that in both
3439         cases, we add the WKWebView to a visible key window, and when sending a mouse down event, we propagate the event
3440         at the window level rather than the view level, allowing greater flexibility to simulate behaviors such as
3441         pressure-sensitive events that are needed for the new test.
3442
3443         Also rewrites currently disabled unit tests in CandidateTests as WebKit2 unit tests in WKWebViewCandidateTests,
3444         checking whether or not to should be requesting candidates in password and non-password fields.
3445
3446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3447         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3448         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
3449         (TestWebKitAPI::TEST):
3450         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
3451         (-[CandidateTestWebView typeString:inputMessage:]):
3452         (+[CandidateTestWebView setUpWithFrame:testPage:]):
3453         * TestWebKitAPI/Tests/WebKit2Cocoa/large-input-field-focus-onload.html: Added.
3454         * TestWebKitAPI/Tests/WebKit2Cocoa/text-and-password-inputs.html: Added.
3455         * TestWebKitAPI/mac/TestWKWebViewMac.h:
3456         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
3457         (__simulated_forceClickAssociatedEventsMask):
3458         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
3459         (-[TestWKWebView initWithFrame:]):
3460         (-[TestWKWebView initWithFrame:configuration:]):
3461         (-[TestWKWebView _setUpTestWindow:]):
3462         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
3463         (-[TestWKWebView typeCharacter:]):
3464         (-[TestWKWebView mouseDownAtPoint:]): Deleted.
3465
3466 2016-09-19  Alex Christensen  <achristensen@webkit.org>
3467
3468         URLParser can read memory out of bounds
3469         https://bugs.webkit.org/show_bug.cgi?id=162206
3470
3471         Reviewed by Geoff Garen.
3472
3473         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3474         (TestWebKitAPI::TEST_F):
3475
3476 2016-09-19  Daniel Bates  <dabates@apple.com>
3477
3478         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
3479         https://bugs.webkit.org/show_bug.cgi?id=162167
3480
3481         Reviewed by Simon Fraser.
3482
3483         * Scripts/webkitperl/FeatureList.pm:
3484         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3485
3486 2016-09-19  Nan Wang  <n_wang@apple.com>
3487
3488         AX: Add accessibility support for details element on iOS
3489         https://bugs.webkit.org/show_bug.cgi?id=162041
3490
3491         Reviewed by Chris Fleizach.
3492
3493         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3494         (AccessibilityUIElement::isExpanded):
3495         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3496         (WTR::AccessibilityUIElement::isExpanded):
3497
3498 2016-09-18  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
3499
3500         [EFL] Bump efl library to 1.18.1
3501         https://bugs.webkit.org/show_bug.cgi?id=162120
3502
3503         Reviewed by Michael Catanzaro.
3504
3505         * efl/jhbuild.modules: Use efl-1.18.1 instead of 1.18.
3506
3507 2016-09-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3508
3509         [EFL] Adjust EFL coding style to EFL MiniBrowser
3510         https://bugs.webkit.org/show_bug.cgi?id=162119
3511
3512         Reviewed by Michael Catanzaro.
3513
3514         Apply EFL coding style to main.c for MiniBrowser.
3515           - Use _foo_cb instead of on_foo for callback function
3516           - Use 3 spaces and use 2 spaces in keywords.
3517
3518         - EFL coding style.
3519           https://phab.enlightenment.org/w/coding_convention/
3520
3521         Additionally this patch adds an exception rule that style checker doesn't
3522         check indentation rule in EFL MiniBrowser.
3523
3524         * MiniBrowser/efl/main.c:
3525         (miniBrowserViewSmartClass):
3526         (window_find_with_ewk_view):
3527         (_tooltip_show):
3528         (window_tooltip_hide):
3529         (window_tooltip_update):
3530         (_mouse_in_cb):
3531         (_mouse_move_cb):
3532         (_mouse_out_cb):
3533         (_mouse_wheel_cb):
3534         (_window_resize_cb):
3535         (update_view_favicon):
3536         (_icon_changed_cb):
3537         (window_free):
3538         (window_close):
3539         (search_icon_show):
3540         (search_box_show):
3541         (search_box_hide):
3542         (history_list_hide):
3543         (save_page_contents_callback):
3544         (script_execute_callback):
3545         (toggle_window_fullscreen):
3546         (_key_down_cb):
3547         (_mouse_down_cb):
3548         (_title_changed_cb):
3549         (_url_changed_cb):
3550         (_back_forward_list_changed_cb):
3551         (_progress_cb):
3552         (_error_cb):
3553         (_download_request_cb):
3554         (close_file_picker):
3555         (_filepicker_parent_deletion_cb):
3556         (_filepicker_deletion_cb):
3557         (_fileselector_done_cb):
3558         (_file_chooser_request_cb):
3559         (_download_finished_cb):
3560         (_download_failed_cb):
3561         (_color_changed_cb):
3562         (_color_item_selected_cb):
3563         (_color_picker_ok_clicked_cb):
3564         (_color_picker_cancel_clicked_cb):
3565         (_color_picker_dismiss_cb):
3566         (_color_picker_request_cb):
3567         (_url_bar_activated_cb):
3568         (_url_bar_clicked_cb):
3569         (_search_field_aborted_cb):
3570         (_search_field_activated_cb):
3571         (_search_field_clicked_cb):
3572         (_back_button_clicked_cb):
3573         (_forward_button_clicked_cb):
3574         (_search_backward_button_clicked_cb):
3575         (_search_forward_button_clicked_cb):
3576         (_search_case_option_changed):
3577         (_search_word_start_option_changed_cb):
3578         (_search_close_button_clicked_cb):
3579         (_refresh_button_clicked_cb):
3580         (_stop_button_clicked_cb):
3581         (_list_item_select_cb):
3582         (navigation_button_longpress_process):
3583         (_forward_button_longpress_cb):
3584         (_back_button_longpress_cb):
3585         (_ok_clicked_cb):
3586         (_file_entry_dialog_show):
3587         (_javascript_alert_cb):
3588         (_javascript_confirm_cb):
3589         (_javascript_prompt_cb):
3590         (_javascript_before_unload_confirm_cb):
3591         (_popup_menu_item_clicked_cb):
3592         (popup_menu_populate):
3593         (_popup_menu_show):
3594         (_popup_menu_hide):
3595         (_window_geometry_get):
3596         (_window_geometry_set):
3597         (_fullscreen_accept_cb):
3598         (_fullscreen_deny_cb):
3599         (_fullscreen_enter_cb):
3600         (_fullscreen_exit_cb):
3601         (_window_create_cb):
3602         (_window_close_cb):
3603         (_context_menu_item_selected_cb):
3604         (context_menu_populate):
3605         (_context_menu_show):
3606         (_context_menu_hide):
3607         (auth_popup_close):
3608         (_auth_cancel_cb):
3609         (_auth_ok_cb):
3610         (_authentication_request_cb):
3611         (_search_text_found_cb):
3612         (_tooltip_text_set):
3613         (_tooltip_text_unset):
3614         (_navigation_policy_decision_cb):
3615         (_home_button_clicked_cb):
3616         (_window_deletion_cb):
3617         (create_toolbar_button):
3618         (window_create):
3619         (configuration):
3620         (parse_cookies_policy):
3621         (parse_window_size):
3622         (elm_main):
3623         (on_tooltip_show): Deleted.
3624         (on_mouse_in): Deleted.
3625         (on_mouse_move): Deleted.
3626         (on_mouse_out): Deleted.
3627         (on_mouse_wheel): Deleted.
3628         (on_window_resize): Deleted.
3629         (on_icon_changed_cb): Deleted.
3630         (on_key_down): Deleted.
3631         (on_mouse_down): Deleted.
3632         (on_title_changed): Deleted.
3633         (on_url_changed): Deleted.
3634         (on_back_forward_list_changed): Deleted.
3635         (on_progress): Deleted.
3636         (on_error): Deleted.
3637         (on_download_request): Deleted.
3638         (on_filepicker_parent_deletion): Deleted.
3639         (on_filepicker_deletion): Deleted.
3640         (on_fileselector_done): Deleted.
3641         (on_file_chooser_request): Deleted.
3642         (on_download_finished): Deleted.
3643         (on_download_failed): Deleted.
3644         (on_color_changed): Deleted.
3645         (on_color_item_selected): Deleted.
3646         (on_color_picker_ok_clicked): Deleted.
3647         (on_color_picker_cancel_clicked): Deleted.
3648         (on_color_picker_dismiss): Deleted.
3649         (on_color_picker_request): Deleted.
3650         (on_url_bar_activated): Deleted.
3651         (on_url_bar_clicked): Deleted.
3652         (on_search_field_aborted): Deleted.
3653         (on_search_field_activated): Deleted.
3654         (on_search_field_clicked): Deleted.
3655         (on_back_button_clicked): Deleted.
3656         (on_forward_button_clicked): Deleted.
3657         (on_search_backward_button_clicked): Deleted.
3658         (on_search_forward_button_clicked): Deleted.
3659         (on_search_case_option_changed): Deleted.
3660         (on_search_word_start_option_changed): Deleted.
3661         (on_search_close_button_clicked): Deleted.
3662         (on_refresh_button_clicked): Deleted.
3663         (on_stop_button_clicked): Deleted.
3664         (on_list_item_select): Deleted.
3665         (on_forward_button_longpress): Deleted.
3666         (on_back_button_longpress): Deleted.
3667         (on_ok_clicked): Deleted.
3668         (show_file_entry_dialog): Deleted.
3669         (on_javascript_alert): Deleted.
3670         (on_javascript_confirm): Deleted.
3671         (on_javascript_prompt): Deleted.
3672         (on_javascript_before_unload_confirm): Deleted.
3673         (on_popup_menu_item_clicked): Deleted.
3674         (on_popup_menu_show): Deleted.
3675         (on_popup_menu_hide): Deleted.
3676         (on_window_geometry_get): Deleted.
3677         (on_window_geometry_set): Deleted.
3678         (on_fullscreen_accept): Deleted.
3679         (on_fullscreen_deny): Deleted.
3680         (on_fullscreen_enter): Deleted.
3681         (on_fullscreen_exit): Deleted.
3682         (on_window_create): Deleted.
3683         (on_window_close): Deleted.
3684         (context_menu_item_selected_cb): Deleted.
3685         (on_context_menu_show): Deleted.
3686         (on_context_menu_hide): Deleted.
3687         (on_auth_cancel): Deleted.
3688         (on_auth_ok): Deleted.
3689         (on_authentication_request): Deleted.
3690         (on_search_text_found): Deleted.
3691         (on_tooltip_text_set): Deleted.
3692         (on_tooltip_text_unset): Deleted.
3693         (on_navigation_policy_decision): Deleted.
3694         (on_home_button_clicked): Deleted.
3695         (on_window_deletion): Deleted.
3696         * Scripts/webkitpy/style/checker.py:
3697
3698 2016-09-16  Dave Hyatt  <hyatt@apple.com>
3699
3700         [CSS Parser] Get CSSPropertyParserHelpers.cpp compiling
3701         https://bugs.webkit.org/show_bug.cgi?id=162078
3702
3703         Reviewed by Dean Jackson.
3704
3705         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
3706         (TestWebKitAPI::createTestValue):
3707         Convert to ValueRange.
3708
3709 2016-09-16  Alex Christensen  <achristensen@webkit.org>
3710
3711         Fix API tests after r206036
3712         https://bugs.webkit.org/show_bug.cgi?id=162049
3713
3714         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3715         (TestWebKitAPI::TEST_F):
3716         An emoji had been UTF-8 encoded in the patch that was applied.
3717         The test needed to check the encoding of the emoji, not the UTF-8 encoding of the emoji.
3718         Everything was correct except applying the patch before committing.
3719
3720 2016-09-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3721
3722         RequiresUserActionForPlayback TestWebKitAPI tests are broken after r206033.
3723         https://bugs.webkit.org/show_bug.cgi?id=162080
3724
3725         Reviewed by Jer Noble.
3726
3727         I renamed "playingHandler" to the more generalized "testHandler", but did not realize that the
3728         RequiresUserActionForPlayback tests also used "playingHandler". Renames the handler to account for this change.
3729
3730         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3731         (RequiresUserActionForPlaybackTest::SetUp):
3732
3733 2016-09-16  Alex Christensen  <achristensen@webkit.org>
3734
3735         URLParser should percent encode the user and password according to spec
3736         https://bugs.webkit.org/show_bug.cgi?id=162049
3737
3738         Reviewed by Tim Horton.
3739
3740         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3741         (TestWebKitAPI::TEST_F):
3742
3743 2016-09-16  Alex Christensen  <achristensen@webkit.org>
3744
3745         Fix more edge cases in URLParser
3746         https://bugs.webkit.org/show_bug.cgi?id=162051
3747
3748         Reviewed by Tim Horton.
3749
3750         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3751         (TestWebKitAPI::TEST_F):
3752
3753 2016-09-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3754
3755         Inserting a space after inserting an accepted candidate scrolls the document and causes a flicker
3756         https://bugs.webkit.org/show_bug.cgi?id=162009
3757         <rdar://problem/28086237>
3758
3759         Reviewed by Tim Horton.
3760
3761         Adds 3 new text editing API tests covering candidate insertion, as well as support for testing candidates in
3762         WKWebViews. Refactors common WKWebView helpers across both VideoControlsManager tests and the new
3763         WKWebViewCandidateTests into a new utility class, TestWKWebView in TestWKWebView.mm, which is capable of
3764         simulating mouse and keyboard events as well as waiting for JavaScript messages sent from the web process and
3765         performing actions in response.
3766
3767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3768         * TestWebKitAPI/Tests/WebKit/ios/audio-only.html:
3769         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
3770         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
3771         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3772         (TestWebKitAPI::TEST):
3773         (-[MessageHandler initWithMessage:handler:]): Deleted.
3774         (-[MessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
3775         (-[VideoControlsManagerTestWebView mouseDownAtPoint:]): Deleted.
3776         (-[VideoControlsManagerTestWebView performAfterLoading:]): Deleted.
3777         (-[VideoControlsManagerTestWebView callJavascriptFunction:]): Deleted.
3778         (-[VideoControlsManagerTestWebView loadTestPageNamed:]): Deleted.
3779         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]): Deleted.
3780         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: Added.
3781         (-[TestCandidate initWithReplacementString:inRange:]):
3782         (-[TestCandidate replacementString]):
3783         (-[TestCandidate resultType]):
3784         (-[TestCandidate range]):
3785         (-[CandidateTestWebView insertCandidatesAndWaitForResponse:range:]):
3786         (-[CandidateTestWebView _didHandleAcceptedCandidate]):
3787         (-[CandidateTestWebView expectCandidateListVisibilityUpdates:whenPerformingActions:]):
3788         (-[CandidateTestWebView _didUpdateCandidateListVisibility:]):
3789         (TEST):
3790         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html:
3791         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html:
3792         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html:
3793         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html:
3794         * TestWebKitAPI/Tests/WebKit2Cocoa/input-field-in-scrollable-document.html: Added.
3795         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html:
3796         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-mutes-onplaying.html:
3797         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html:
3798         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html:
3799         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html:
3800         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html:
3801         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
3802         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html:
3803         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html:
3804         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html:
3805         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html:
3806         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html:
3807         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html:
3808         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html:
3809         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html:
3810         * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html:
3811         * TestWebKitAPI/mac/TestWKWebViewMac.h: Added.
3812         * TestWebKitAPI/mac/TestWKWebViewMac.mm: Added.
3813         (-[TestMessageHandler initWithMessage:handler:]):
3814         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
3815         (-[TestWKWebView mouseDownAtPoint:]):
3816         (-[TestWKWebView performAfterReceivingMessage:action:]):
3817         (-[TestWKWebView loadTestPageNamed:]):
3818         (-[TestWKWebView typeCharacter:]):
3819         (-[TestWKWebView stringByEvaluatingJavaScript:]):
3820         (-[TestWKWebView waitForMessage:]):
3821         (-[TestWKWebView performAfterLoading:]):
3822
3823 2016-09-14  Jer Noble  <jer.noble@apple.com>
3824
3825         [media-source] fix imported/w3c/web-platform-tests/media-source/mediasource-duration.html
3826         https://bugs.webkit.org/show_bug.cgi?id=161999
3827
3828         Reviewed by Eric Carlson.
3829
3830         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3831         (TestWebKitAPI::TEST):
3832
3833 2016-09-16  Anders Carlsson  <andersca@apple.com>
3834
3835         Fix isValidEnum to work with older versions of GCC
3836         https://bugs.webkit.org/show_bug.cgi?id=162065
3837
3838         Reviewed by Michael Catanzaro.
3839
3840         Add EnumTraits.cpp to the CMake build.
3841
3842         * TestWebKitAPI/CMakeLists.txt:
3843
3844 2016-09-16  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
3845
3846         Unreviewed: Change my primary address for auto-complete in bugzilla.
3847
3848         * Scripts/webkitpy/common/config/contributors.json:
3849
3850 2016-09-15  Alex Christensen  <achristensen@webkit.org>
3851
3852         URLParser: Check for invalid characters in the host
3853         https://bugs.webkit.org/show_bug.cgi?id=162023
3854
3855         Reviewed by Tim Horton.
3856
3857         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3858         (TestWebKitAPI::TEST_F):
3859
3860 2016-09-15  Fujii Hironori  <Hironori.Fujii@sony.com>
3861
3862         [CMake] Refactor GENERATE_BINDINGS
3863         https://bugs.webkit.org/show_bug.cgi?id=161854
3864
3865         Reviewed by Gyuyoung Kim.
3866
3867         * DumpRenderTree/CMakeLists.txt: Changed the arguments of
3868         GENERATE_BINDINGS to new style.
3869         * WebKitTestRunner/CMakeLists.txt: Ditto.
3870
3871 2016-09-15  Ryan Haddad  <ryanhaddad@apple.com>
3872
3873         Disable failing API WebKit2.DataDetectionReferenceDate until it can be investigated.
3874         https://bugs.webkit.org/show_bug.cgi?id=161967
3875
3876         Unreviewed test gardening.
3877
3878         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3879         (TEST):
3880
3881 2016-09-15  Per Arne Vollan  <pvollan@apple.com>
3882
3883         [Win] run-api-tests is failing.
3884         https://bugs.webkit.org/show_bug.cgi?id=162015
3885
3886         Reviewed by Brent Fulgham.
3887
3888         MSVC is not interpreting C++ string literals with unicode characters correctly when the source file
3889         doesn't contain encoding information. Save the file with utf8 encoding with signature.
3890
3891         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3892
3893 2016-09-15  Jonathan Bedard  <jbedard@apple.com>
3894
3895         Move --no-sample-on-timeout to config.json for each bot
3896         https://bugs.webkit.org/show_bug.cgi?id=161964
3897
3898         Reviewed by Daniel Bates.
3899
3900         Roll out changes from 205573 and move them into config.json.  At this time, only macOS and iOS simulator sample a process on timeout, —no-sample-on-timeout is unneeded for GTK, EFL and Windows.
3901
3902         * BuildSlaveSupport/build.webkit.org-config/config.json: Each bot now independently defines if it will be running sample on timeout.
3903         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3904         (RunWebKitTests.start): Rolled out changes from 205573.
3905
3906 2016-09-15  Csaba Osztrogonác  <ossy@webkit.org>
3907
3908         js/stringimpl-to-jsstring-on-large-strings tests consume huge memory
3909         https://bugs.webkit.org/show_bug.cgi?id=159807
3910
3911         Reviewed by Saam Barati.
3912
3913         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3914         (RunRemoteJavaScriptCoreTests.start): JSCOnly bots are memory limited devices, tests should run with --memory-limited option.
3915         * Scripts/run-javascriptcore-tests:
3916         (runJSCStressTests): Pass through --memory-limited option to run-jsc-stress-tests.
3917         * Scripts/run-jsc-stress-tests: Typo fix.
3918
3919 2016-09-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3920
3921         Media controls behave strangely when changing media sources
3922         https://bugs.webkit.org/show_bug.cgi?id=161914
3923         <rdar://problem/28227805>
3924
3925         Reviewed by Tim Horton.
3926
3927         Adds three new unit tests verifying that media controls remain stable during common `src` change scenarios. Also
3928         tweaks an existing test to account for new `ended` behavior.
3929
3930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3931         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3932         (-[VideoControlsManagerTestWebView waitForMediaControlsToShow]):
3933         (-[VideoControlsManagerTestWebView waitForMediaControlsToHide]):
3934         (TestWebKitAPI::TEST):
3935         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: Added.
3936         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: Added.
3937         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: Added.
3938
3939 2016-09-14  Jonathan Bedard  <jbedard@apple.com>
3940
3941         Fix mastercfg_unittest
3942         https://bugs.webkit.org/show_bug.cgi?id=161816
3943
3944         Reviewed by Daniel Bates.
3945
3946         (RunWebKitTests.start):
3947         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Fixed broken unit tests.
3948
3949 2016-09-13  Alexey Proskuryakov  <ap@apple.com>
3950
3951         Landing optimized .png files, forgot to do it initially.
3952
3953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
3954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
3955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
3956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
3957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
3958
3959 2016-09-13  Alexey Proskuryakov  <ap@apple.com>
3960
3961         Switch build.webkit.org to iOS 10
3962         https://bugs.webkit.org/show_bug.cgi?id=161930
3963
3964         Reviewed by Daniel Bates.
3965
3966         * BuildSlaveSupport/build.webkit.org-config/config.json:
3967         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3968         (RunWebKitTests.start):
3969         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png: Added.
3971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png: Added.
3972         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png: Added.
3973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png: Added.
3974         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
3975         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
3976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png: Added.
3977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png: Added.
3978         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3979         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3982         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3983         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3984         * Scripts/webkitpy/port/ios.py:
3985         * TestResultServer/static-dashboards/builders.jsonp:
3986
3987 2016-09-13  Tim Horton  <timothy_horton@apple.com>
3988
3989         Provide a mechanism to specify the maximum width of WKThumbnailView snapshots
3990         https://bugs.webkit.org/show_bug.cgi?id=161896
3991         <rdar://problem/28229827>
3992
3993         Reviewed by Simon Fraser.
3994
3995         * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm:
3996         (TestWebKitAPI::TEST):
3997         Add a test for the new property.
3998         Also fix the old new test to run on arbitrary scale displays without failing.
3999
4000 2016-09-12  Brent Fulgham  <bfulgham@apple.com>
4001
4002         [Win][Direct2D] Provide Direct2D-based geometry and transform cast operations
4003         https://bugs.webkit.org/show_bug.cgi?id=161818
4004
4005         Reviewed by Dean Jackson.
4006
4007         Add several new test suites for the various geometric primitives in WebCore.
4008
4009         * TestWebKitAPI/PlatformWin.cmake: Add new files for test cases.
4010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
4011         * TestWebKitAPI/Tests/WebCore/AffineTransform.cpp: Added.
4012         * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp: Added.
4013         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp: Added.
4014         * TestWebKitAPI/Tests/WebCore/FloatSize.cpp: Added.
4015         * TestWebKitAPI/Tests/WebCore/IntPoint.cpp: Added.
4016         * TestWebKitAPI/Tests/WebCore/IntRect.cpp: Added.
4017         * TestWebKitAPI/Tests/WebCore/IntSize.cpp: Added.
4018         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Add some new
4019         Windows-focused test cases.
4020
4021 2016-09-12  Chris Dumez  <cdumez@apple.com>
4022
4023         Fix post-landing review comments after r205787
4024         https://bugs.webkit.org/show_bug.cgi?id=161885
4025
4026         Reviewed by Darin Adler.
4027
4028         Leverage new StringBuilder::append(CFStringRef) overload.
4029
4030         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4031         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
4032
4033 2016-09-12  Alex Christensen  <achristensen@webkit.org>
4034
4035         URLParser: Correctly ignore spaces before relative URLs with no scheme
4036         https://bugs.webkit.org/show_bug.cgi?id=161889
4037
4038         Reviewed by Daniel Bates.
4039
4040         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4041         (TestWebKitAPI::TEST_F):
4042
4043 2016-09-12  Alex Christensen  <achristensen@webkit.org>
4044
4045         URLParser: Fix relative URLs containing only fragments
4046         https://bugs.webkit.org/show_bug.cgi?id=161882
4047
4048         Reviewed by Brady Eidson.
4049
4050         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4051         (TestWebKitAPI::TEST_F):
4052
4053 2016-09-12  Alex Christensen  <achristensen@webkit.org>
4054
4055         URLParser: Correctly handle relative URLs that are just a scheme and a colon
4056         https://bugs.webkit.org/show_bug.cgi?id=161876
4057
4058         Reviewed by Brady Eidson.
4059
4060         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4061         (TestWebKitAPI::TEST_F):
4062
4063 2016-09-12  DAN SAUNDERS  <dasau@microsoft.com>
4064
4065         AX: WKWebView for macOS does not allow configuration of tabsToLinks
4066         https://bugs.webkit.org/show_bug.cgi?id=161394
4067
4068         Reviewed by Anders Carlsson.
4069
4070         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
4071         (TEST):
4072
4073 2016-09-12  Alex Christensen  <achristensen@webkit.org>
4074
4075         Remove trailing control characters and spaces before parsing a URL
4076         https://bugs.webkit.org/show_bug.cgi?id=161870
4077
4078         Reviewed by Tim Horton.
4079
4080         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4081         (TestWebKitAPI::TEST_F):
4082
4083 2016-09-12  Alex Christensen  <achristensen@webkit.org>
4084
4085         Fix more URLParser quirks
4086         https://bugs.webkit.org/show_bug.cgi?id=161834
4087
4088         Reviewed by Brady Eidson.
4089
4090         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4091         (TestWebKitAPI::TEST_F):
4092
4093 2016-09-10  Alex Christensen  <achristensen@webkit.org>
4094
4095         Optimize URLParser performance
4096         https://bugs.webkit.org/show_bug.cgi?id=161837
4097
4098         Reviewed by Brady Eidson.
4099
4100         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4101         (TestWebKitAPI::TEST_F):
4102         Added a test to verify the case insensitivity of the default port checks.
4103
4104 2016-09-10  Chris Dumez  <cdumez@apple.com>
4105
4106         parseHTMLInteger() should take a StringView in parameter
4107         https://bugs.webkit.org/show_bug.cgi?id=161669
4108
4109         Reviewed by Ryosuke Niwa.
4110
4111         Explicitly construct a String from the CFStringRef in order to call
4112         StringBuilder::append(). This is needed now that there is an append()
4113         overload taking an AtomicString in parameter.
4114
4115         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4116         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
4117
4118 2016-09-10  Wenson Hsieh  <wenson_hsieh@apple.com>
4119
4120         Apple.com keynote does not display media controls
4121         https://bugs.webkit.org/show_bug.cgi?id=161833
4122         <rdar://problem/28230123>
4123
4124         Reviewed by Tim Horton.
4125
4126         New unit test verifying that wide videos (~2 aspect ratio) still get media controls.
4127
4128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4129         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
4130         (TestWebKitAPI::TEST):
4131         * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: Added.
4132
4133 2016-09-09  Tim Horton  <timothy_horton@apple.com>
4134
4135         WKThumbnailView should expose a mode where it can be reparented without resnapshotting
4136         https://bugs.webkit.org/show_bug.cgi?id=161828
4137         <rdar://problem/28229756>
4138
4139         Reviewed by Alex Christensen.
4140
4141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4142         * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: Added.
4143         (-[SnapshotSizeObserver observeValueForKeyPath:ofObject:change:context:]):
4144         (TestWebKitAPI::didFinishLoadForFrame):
4145         (TestWebKitAPI::setPageLoaderClient):
4146         (TestWebKitAPI::TEST):
4147         Add a test ensuring that this behaves correctly.
4148
4149 2016-09-09  Alex Christensen  <achristensen@webkit.org>
4150
4151         URLParser: Keep track of cannot-be-a-base-url according to spec
4152         https://bugs.webkit.org/show_bug.cgi?id=161830
4153
4154         Reviewed by Tim Horton.
4155
4156         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4157         (TestWebKitAPI::TEST_F):
4158
4159 2016-09-09  Alex Christensen  <achristensen@webkit.org>
4160
4161         Fix API tests after r205774.
4162         https://bugs.webkit.org/show_bug.cgi?id=161820
4163
4164         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4165         (TestWebKitAPI::TEST_F):
4166         I had committed the wrong expected path in one case. The functionality is correct.
4167
4168 2016-09-09  Michael Saboff  <msaboff@apple.com>
4169
4170         Unreviewed, rolling r205759 back in with a fix.
4171
4172         An expectation file, JSTests/ChakraCore/test/Lib/tostring.baseline-jsc,
4173         should be named "toString.baseline-jsc".  For systems with case-insensitive
4174         filesystems, the wrong name isn't an issue.  That rename is part of this
4175         fix.
4176
4177         * Scripts/run-javascriptcore-tests:
4178         (runJSCStressTests):
4179
4180 2016-09-09  Johan K. Jensen  <johan_jensen@apple.com>
4181
4182         Unreviewed. Added myself to the list of committers.
4183
4184         * Scripts/webkitpy/common/config/contributors.json:
4185
4186 2016-09-09  Alex Christensen  <achristensen@webkit.org>
4187
4188         URLParser should convert ASCII hosts to lowercase
4189         https://bugs.webkit.org/show_bug.cgi?id=161820
4190
4191         Reviewed by Geoffrey Garen.
4192
4193         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4194         (TestWebKitAPI::TEST_F):
4195
4196 2016-09-09  Ryan Haddad  <ryanhaddad@apple.com>
4197
4198         Unreviewed, rolling out r205759.
4199
4200         This change broke all JSC tests
4201
4202         Reverted changeset:
4203
4204         "Add ChakraCore tests to run-javascriptcore-tests"
4205         https://bugs.webkit.org/show_bug.cgi?id=161808
4206         http://trac.webkit.org/changeset/205759
4207
4208 2016-09-09  Ryan Haddad  <ryanhaddad@apple.com>
4209
4210         Revert r205770 because Ricky is already a committer.
4211
4212         Unreviewed.
4213
4214         * Scripts/webkitpy/common/config/contributors.json:
4215
4216 2016-09-09  Ricky Mondello  <rmondello@apple.com>
4217
4218         Unreviewed. Added myself to the list of committers.
4219
4220         * Scripts/webkitpy/common/config/contributors.json:
4221
4222 2016-09-09  Alex Christensen  <achristensen@webkit.org>
4223
4224         URLParser: Fix and optimize parsing file URLs ending with a host but no slash
4225         https://bugs.webkit.org/show_bug.cgi?id=161815
4226
4227         Reviewed by Geoffrey Garen.
4228
4229         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4230         (TestWebKitAPI::TEST_F):
4231
4232 2016-09-08  Dean Jackson  <dino@apple.com>
4233
4234         Expose Apple Pencil data to Touch events
4235         https://bugs.webkit.org/show_bug.cgi?id=161783
4236         <rdar://problem/28218898>
4237
4238         Reviewed by Beth Dakin.
4239
4240         The values that IOHID expects are different from their
4241         documentation, and from what UITouch interprets. Tweak
4242         incoming data so it will produce the output we expect.
4243
4244         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4245         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]):
4246         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]):
4247
4248 2016-09-09  JF Bastien  <jfbastien@apple.com>
4249
4250         Unreviewed. Added myself to the list of committers.
4251
4252         * Scripts/webkitpy/common/config/contributors.json:
4253
4254 2016-09-09  Michael Saboff  <msaboff@apple.com>
4255
4256         Add ChakraCore tests to run-javascriptcore-tests
4257         https://bugs.webkit.org/show_bug.cgi?id=161808
4258
4259         Reviewed by Saam Barati.
4260
4261         Added ChakraCore tests to the default list of tests to run.
4262
4263         * Scripts/run-javascriptcore-tests:
4264         (runJSCStressTests):
4265
4266 2016-09-09  Alex Christensen  <achristensen@webkit.org>
4267
4268         URLParser: Handle \ in path according to spec
4269         https://bugs.webkit.org/show_bug.cgi?id=161805
4270
4271         Reviewed by Andy Estes.
4272
4273         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4274         (TestWebKitAPI::TEST_F):
4275
4276 2016-09-09  Alex Christensen  <achristensen@webkit.org>
4277
4278         URLParser should parse URLs with non-special schemes
4279         https://bugs.webkit.org/show_bug.cgi?id=161786
4280
4281         Reviewed by Andy Estes.
4282
4283         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4284         (TestWebKitAPI::TEST_F):
4285
4286 2016-09-08  Yusuke Suzuki  <utatane.tea@gmail.com>
4287
4288         [WTF] HashTable's rehash is not compatible to Ref<T> and ASan
4289         https://bugs.webkit.org/show_bug.cgi?id=161763
4290
4291         Reviewed by Mark Lam.
4292
4293         Add tests that inserts many Ref<>s. It incurs HashTable::rehash, and we can ensure
4294         that ASan crash does not occur with this patch.
4295
4296         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4297         (TestWebKitAPI::TEST):
4298         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4299         (TestWebKitAPI::TEST):
4300
4301 2016-09-08  Alex Christensen  <achristensen@webkit.org>
4302
4303         URLParser: Handle \ in paths of special URLs according to spec
4304         https://bugs.webkit.org/show_bug.cgi?id=161781
4305
4306         Reviewed by Tim Horton.
4307
4308         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4309         (TestWebKitAPI::TEST_F):
4310
4311 2016-09-08  Simon Fraser  <simon.fraser@apple.com>
4312
4313         Update the content-animation.plan file to run css-accelerated-animation.html
4314         and pull SVN revision r205680.
4315
4316         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
4317
4318 2016-09-08  Simon Fraser  <simon.fraser@apple.com>
4319
4320         Add a content-animation test with accelerated CSS animations
4321         https://bugs.webkit.org/show_bug.cgi?id=161776
4322
4323         Reviewed by Dean Jackson.
4324
4325         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
4326
4327 2016-09-08  Alex Christensen  <achristensen@webkit.org>
4328
4329         URLParser: Parsing empty URLs with a base URL should return the base URL
4330         https://bugs.webkit.org/show_bug.cgi?id=161777
4331
4332         Reviewed by Tim Horton.
4333
4334         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4335         (TestWebKitAPI::TEST_F):
4336
4337 2016-09-08  Alex Christensen  <achristensen@webkit.org>
4338
4339         URLParser failures should preserve the original input string
4340         https://bugs.webkit.org/show_bug.cgi?id=161769
4341
4342         Reviewed by Tim Horton.
4343
4344         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4345         (TestWebKitAPI::TEST_F):
4346         (TestWebKitAPI::shouldFail):
4347
4348 2016-09-08  Alex Christensen  <achristensen@webkit.org>
4349
4350         URLParser should parse URLs with a user but no password
4351         https://bugs.webkit.org/show_bug.cgi?id=161773
4352
4353         Reviewed by Brady Eidson.
4354
4355         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4356         (TestWebKitAPI::TEST_F):
4357
4358 2016-09-08  Alex Christensen  <achristensen@webkit.org>
4359
4360         URLParser should parse ports after IPv4 and IPv6 hosts
4361         https://bugs.webkit.org/show_bug.cgi?id=161731
4362
4363         Reviewed by Brady Eidson.
4364
4365         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4366