2011-01-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2
3         Reviewed by Xan Lopez.
4
5         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
6         https://bugs.webkit.org/show_bug.cgi?id=51806
7
8         Originally, the $libraryName is 'JavaScriptCore'. When building release 
9         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
10         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
11         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
12         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
13         so make it 'WebKitBuild/Release/.libs'
14
15         * Scripts/webkitdirs.pm: 
16
17 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
18
19         Reviewed by Adam Barth.
20
21         Make EFL a core builder
22         https://bugs.webkit.org/show_bug.cgi?id=51804
23
24         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
25         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
26
27 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
28
29         [Qt] Unreviewed fix after r74855 and r74875.
30
31         * BuildSlaveSupport/built-product-archive:
32          - Create directories explicitly.
33          - Pass shell=True to subprocess.call().
34
35 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
36
37         [Qt] Unreviewed fix after r74855.
38
39         Move JavaScriptCore to Source
40         https://bugs.webkit.org/show_bug.cgi?id=51604
41
42         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
43
44 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
45
46         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
47
48         Move JavaScriptCore to Source
49         https://bugs.webkit.org/show_bug.cgi?id=51604
50
51         * Scripts/webkitdirs.pm:
52
53 2011-01-02  Robert Hogan  <robert@webkit.org>
54
55         Unreviewed, build fix.
56
57         [Qt] Fix DRT build after 74855
58
59         * DumpRenderTree/qt/DumpRenderTree.pro:
60
61 2011-01-01  Adam Barth  <abarth@webkit.org>
62
63         Remove the assumption from the Qt and Gtk builds that every project is
64         in the root directory.
65
66         * Scripts/build-webkit:
67
68 2011-01-01  Adam Barth  <abarth@webkit.org>
69
70         Reviewed by Eric Seidel.
71
72         Teach svn-apply how to apply patches even though JavaScriptCore has moved
73         https://bugs.webkit.org/show_bug.cgi?id=51796
74
75         After this change, svn-apply will magically apply patches to
76         JavaScriptCore/foo to Source/JavaScriptCore/foo.
77
78         * Scripts/VCSUtils.pm:
79
80 2011-01-01  Adam Barth  <abarth@webkit.org>
81
82         Reviewed by Eric Seidel.
83
84         Move JavaScriptCore to Source
85         https://bugs.webkit.org/show_bug.cgi?id=51604
86
87         Update references to JavaScriptCore to point to the new location.
88
89         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
90         * DumpRenderTree/qt/DumpRenderTree.pro:
91         * DumpRenderTree/qt/ImageDiff.pro:
92         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
93         * DumpRenderTree/wscript:
94         * Scripts/build-jsc:
95         * Scripts/build-webkit:
96         * Scripts/do-file-rename:
97         * Scripts/do-webcore-rename:
98         * Scripts/run-javascriptcore-tests:
99         * Scripts/update-javascriptcore-test-results:
100         * Scripts/webkitdirs.pm:
101         * Scripts/webkitpy/common/config/build_unittest.py:
102         * Scripts/webkitpy/style/checker.py:
103         * Scripts/webkitpy/style/checker_unittest.py:
104         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
105         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
106         * WebKitTestRunner/qt/WebKitTestRunner.pro:
107         * wx/build/settings.py:
108
109 2011-01-01  Adam Barth  <abarth@webkit.org>
110
111         Reviewed by Eric Seidel.
112
113         Move Sources to Source
114         https://bugs.webkit.org/show_bug.cgi?id=51794
115
116         Update scripts to point to the new location.
117
118         * Scripts/build-webkit:
119         * Scripts/do-file-rename:
120         * Scripts/do-webcore-rename:
121         * Scripts/webkitpy/common/config/build.py:
122         * Scripts/webkitpy/common/config/build_unittest.py:
123
124 2010-12-31  Kent Tamura  <tkent@chromium.org>
125
126         Reviewed by Eric Seidel.
127
128         [DRT/Chromium] Enable mock spell checker on non-OSX
129         https://bugs.webkit.org/show_bug.cgi?id=51401
130
131         * DumpRenderTree/chromium/WebViewHost.cpp:
132         (WebViewHost::spellCheck):
133
134 2010-12-31  Adam Barth  <abarth@webkit.org>
135
136         Reviewed by Ariya Hidayat.
137
138         Remove Tools/Scripts/wkstyle
139         https://bugs.webkit.org/show_bug.cgi?id=51774
140
141         This script appears to not have been touched in a while and seems to
142         have been replaced by check-webkit-style.
143
144         * Scripts/wkstyle: Removed.
145
146 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
147
148         Unreviewed. Coding style fix.
149
150         * DumpRenderTree/chromium/TestShell.h:
151
152 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
153
154         Reviewed by Pavel Feldman.
155
156         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
157
158         It was a problem with Chromium DRT. DevToolsAgent object instance was
159         attached not only to the inspected page but to the DevTools window too.
160         As result all the inspector files were interpreted as a content of inspected page
161         and were transfered to the DevTools scripts panel for debugging etc.
162
163         https://bugs.webkit.org/show_bug.cgi?id=51735
164
165         * DumpRenderTree/chromium/TestShell.cpp:
166         (TestShell::TestShell):
167         (TestShell::bindJSObjectsToWindow):
168         (TestShell::createNewWindow):
169         * DumpRenderTree/chromium/TestShell.h:
170
171 2010-12-31  Adam Barth  <abarth@webkit.org>
172
173         Rubber-stamped by Eric Seidel.
174
175         Move PageLoadTests to PerformanceTests/PageLoad
176         https://bugs.webkit.org/show_bug.cgi?id=51771
177
178         Update references to PageLoadTests to point to the new location.
179
180         * Scripts/run-pageloadtest:
181         * Scripts/webkitpy/common/config/build.py:
182
183 2010-12-31  Adam Barth  <abarth@webkit.org>
184
185         Rubber-stamped by Eric Seidel.
186
187         Move SunSpider into PerformanceTests
188         https://bugs.webkit.org/show_bug.cgi?id=51769
189
190         Update these scripts to point to the new location.
191
192         * Scripts/run-sunspider:
193         * Scripts/sunspider-compare-results:
194
195 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
196
197         Reviewed by Kent Tamura.
198
199         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
200         https://bugs.webkit.org/show_bug.cgi?id=51728
201         
202         Add implementation of the Mac WebThemeEngine that uses an NSScroller
203         to render top-level scrollbars. This makes them match the Mac port's
204         use of an NSScrollView, which means that we'll be able to share more
205         pixel baselines.
206         
207         The new rendering code will not be activated until the 
208         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
209         ScrollbarThemeChromiumMac.
210
211         * DumpRenderTree/DumpRenderTree.gypi:
212         * DumpRenderTree/chromium/TestShellMac.mm:
213         (platformInit):
214         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
215         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
216         (+[FakeActiveWindow alwaysActiveWindow]):
217         (+[FakeActiveWindow alwaysInactiveWindow]):
218         (-[FakeActiveWindow initWithActiveControls:]):
219         (-[FakeActiveWindow _hasActiveControls]):
220         (WebThemeEngineDRTMac::paintScrollbarThumb):
221         (stateToHIEnableState):
222         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
223         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
224
225 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
226
227         Reviewed by David Kilzer.
228
229         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
230         used
231         https://bugs.webkit.org/show_bug.cgi?id=51672
232
233         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
234         with USE_SYSTEM_MALLOC=1
235         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
236         with USE_SYSTEM_MALLOC=1
237
238 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
239
240         Reviewed by David Kilzer.
241
242         [Qt] [Symbian] Fix build-webkit script for Symbian
243         https://bugs.webkit.org/show_bug.cgi?id=51509
244
245         Set the OUTPUT_DIR for Symbian to be the same as the source
246         directory.
247
248         * Scripts/webkitdirs.pm:
249
250 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
251
252         Reviewed by Darin Adler.
253
254         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
255         https://bugs.webkit.org/show_bug.cgi?id=51758
256
257         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
258
259         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
260         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
261
262 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
263
264         Unreviewed WinCE buildfix.
265
266         * WinCELauncher/main.cpp: Add missing include.
267
268 2010-12-29  Daniel Bates  <dbates@rim.com>
269
270         Reviewed by Darin Adler.
271
272         svn-apply updates date of wrong change log entry for a change log diff that
273         contains two consecutive entries with the same author and date
274         https://bugs.webkit.org/show_bug.cgi?id=46061
275
276         Fixes an issue where the date of the wrong change log entry may be modified.
277         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
278         in a ChangeLog file to the top of the file.
279
280         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
281         diff when it detects that the diff inserts a change log entry earlier in a
282         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
283         change. With the advent of the commit-queue this functionality of bailing out
284         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
285         Instead, we should always move the change log entry to the top of the ChangeLog file.
286
287         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
288         the date line of the correct change log entry in a ChangeLog diff.
289
290         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
291
292         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
293           Updated the following unit tests now that we move entries inserted earlier to the top:
294           - "fixChangeLogPatch: New entry inserted in middle."
295             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
296
297           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
298             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
299
300         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
301
302 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
303
304         Reviewed by Eric Seidel.
305
306         [Qt] Fixed compatibility with gold linker on X11 platforms
307         https://bugs.webkit.org/show_bug.cgi?id=51700
308
309         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
310         Linked TestNetscapePlugin with libX11 on Unix platforms
311
312 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
313
314         Reviewed by Darin Adler.
315
316         Circular dependency in webkitpy.common.checkout.changelog module
317         https://bugs.webkit.org/show_bug.cgi?id=50475
318
319         Remove automatic import of api.Checkout module when any checkout/
320         submodule is imported (e.g.: when checkout.scm.Git is imported).
321
322         * Scripts/webkitpy/common/checkout/__init__.py:
323
324 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
325
326         Reviewed by Ojan Vafai.
327
328         prepare-ChangeLog should support the -g option for specifying the git-commit
329         https://bugs.webkit.org/show_bug.cgi?id=51708
330
331         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
332         webkit-patch, though the exact meaning of the two options remain different.
333
334         * Scripts/prepare-ChangeLog: Add -g.
335
336 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
337
338         Reviewed by Simon Hausmann.
339
340         [Qt] Fix compilation with Qt in namespace
341         https://bugs.webkit.org/show_bug.cgi?id=51701
342
343         * QtTestBrowser/webview.h:
344
345 2010-12-28  Daniel Bates  <dbates@rim.com>
346
347         Reviewed by Sam Weinig.
348
349         Substitute // MARK: for compiler-specific #pragma mark
350         https://bugs.webkit.org/show_bug.cgi?id=51657
351
352         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
353         substituting  "// MARK:" for "#pragma mark", which provides
354         analogous code-bookmarking functionality under Xcode.
355
356         Also, for consistency, we should substitute "// MARK:" for compiler-
357         specific "#pragma mark" in the source files for the Mac port.
358
359         * DumpRenderTree/AccessibilityTextMarker.cpp:
360         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
361         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
362         * DumpRenderTree/mac/ObjCController.m:
363         * MiniBrowser/mac/AppDelegate.m:
364         * MiniBrowser/mac/BrowserWindowController.m:
365
366 2010-12-28  Xan Lopez  <xlopez@igalia.com>
367
368         Reviewed by Eric Seidel.
369
370         Add --no-build option to run-sunspider
371         https://bugs.webkit.org/show_bug.cgi?id=51658
372
373         * Scripts/run-sunspider: add --no-build flag to skip building
374         phase.
375
376 2010-12-27  Daniel Bates  <dbates@rim.com>
377
378         Rubber-stamped by Martin Robinson.
379
380         Append the directory Tools/DumpRenderTree to the list of directories that
381         do-webcore-rename should search so that it can rename DRT files and
382         source code.
383
384         * Scripts/do-webcore-rename:
385
386 2010-12-27  Eric Seidel  <eric@webkit.org>
387
388         Reviewed by Adam Barth.
389
390         build-webkit should detect missing Java SDK and explain how to install it
391         https://bugs.webkit.org/show_bug.cgi?id=51651
392
393         * Scripts/build-webkit:
394
395 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
396
397         Reviewed by Daniel Bates.
398
399         [GTK] Add support for build-jsc
400         https://bugs.webkit.org/show_bug.cgi?id=51625
401
402         Add GTK+ support to build-jsc now that building the jsc executable as
403         a standalone target is easy.
404
405         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
406         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
407         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
408         and pass it along to buildAutotoolsProject.
409
410 2010-12-27  David Levin  <levin@chromium.org>
411
412         Reviewed by Eric Seidel.
413
414         check-webkit-style check for meaningless variable names in function declarations.
415         https://bugs.webkit.org/show_bug.cgi?id=51523
416
417         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
418         from the new check and whitespace/parens because the syntax is unusual and
419         produced a fair number of positives for these checks.
420         * Scripts/webkitpy/style/checkers/cpp.py:
421         (_convert_to_lower_with_underscores): Used as a canonical form for type names
422         and parameter names when determining if the parameter name is useless.
423         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
424         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
425         format.
426         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
427         text or an acronym of it.
428         (check_function_definition): Checks function definitions for meaningless variable names.
429         (process_line): Added call to check_function_definition.
430         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
431         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
432         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
433         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
434         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
435         because when only checking a snippet, there are a lot of bogus functions.
436         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
437         that I put there previously and just noticed.
438         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
439         check_function_definition and process_line.
440
441 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
442
443         Reviewed by Martin Robinson.
444
445         [GTK] Disable flash plugin in GtkLauncher when using gtk3
446         https://bugs.webkit.org/show_bug.cgi?id=51591
447
448         Flash plugin uses gtk2 that is incompatible with gtk3 making
449         webkit crash when it's built with gtk3.
450
451         * GtkLauncher/main.c:
452         (main):
453
454 2010-12-25  Adam Barth  <abarth@webkit.org>
455
456         Reviewed by Eric Seidel.
457
458         Move ANGLE to Sources/ThirdParty
459         https://bugs.webkit.org/show_bug.cgi?id=51605
460
461         * Scripts/build-webkit:
462           - Point to the new ANGLE location.
463
464 2010-12-26  David Levin  <levin@chromium.org>
465
466         Reviewed by Eric Seidel.
467
468         check-webkit-style should be able to parse function declaration parameters.
469         https://bugs.webkit.org/show_bug.cgi?id=51451
470
471         * Scripts/webkitpy/style/checkers/cpp.py:
472         (Position.__init__): Holds simple position information (row, column).
473         (Parameter.__init__): Holds information about a parameter.
474         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
475         (SingleLineView.convert_column_to_row): Returns the original row given a column.
476         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
477         (find_parameter_name_index): Finds where the parameter name is.
478         (parameter_list): Generates the list of parameters for a function.
479         (_FunctionState.begin): Added information to allow determining the parameters
480         on demand.
481         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
482         (detect_functions): Improve function detection for operator functions and
483         determine where the parameters end and pass that to _FunctionState.begin.
484         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
485         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
486         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
487         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
488         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
489         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
490         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
491         (FunctionDetectionTest.perform_function_detection): Added support for verifying
492         the parameters found.
493         (FunctionDetectionTest.test_function_declaration_detection): Added more function
494         detection test to verify that we catch the operator functions.
495         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
496         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
497         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
498         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
499         test_function_length_check_definition_severity1_for_test.
500
501 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
502
503         Unreviewed WinCE buildfix after r74334.
504
505         * CMakeListsWinCE.txt:
506
507 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
508
509         Unreviewed, rolling out r74632.
510         http://trac.webkit.org/changeset/74632
511         https://bugs.webkit.org/show_bug.cgi?id=51600
512
513         makes test-webkitpy hang forever on GTK (Requested by philn-tp
514         on #webkit).
515
516         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
517         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
518
519 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
520
521         Reviewed by Kenneth Rohde Christiansen.
522
523         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
524         https://bugs.webkit.org/show_bug.cgi?id=43528
525
526         Remove on_resize because ewk_view_fixed_layout_size_set should not be
527         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
528         FrameView, rendering was ignored when _ewk_view_smart_calculate was
529         called.
530
531         * EWebLauncher/main.c:
532         (browserCreate):
533
534 2010-12-24  Eric Seidel  <eric@webkit.org>
535
536         Reviewed by Adam Barth.
537
538         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
539         https://bugs.webkit.org/show_bug.cgi?id=28291
540
541         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
542         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
543         to strings with find in the diff.
544         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
545
546         * Scripts/webkitpy/common/checkout/api.py:
547         * Scripts/webkitpy/common/checkout/diff_parser.py:
548         * Scripts/webkitpy/tool/steps/abstractstep.py:
549         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
550         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
551         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
552         * Scripts/webkitpy/tool/steps/validatereviewer.py:
553
554 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
555
556         Reviewed by Kenneth Russell.
557
558         Modify new-run-webkit-tests to shut up and exit when all the threads
559         are wedged so that test runs complete faster and we don't end up
560         w/ enormous log files.
561
562         https://bugs.webkit.org/show_bug.cgi?id=51572
563
564         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
565         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
566
567 2010-12-24  Eric Seidel  <eric@webkit.org>
568
569         Reviewed by David Levin.
570
571         commit-queue should better explain how it will re-open bugs and follow duplicate chains
572         https://bugs.webkit.org/show_bug.cgi?id=51549
573
574         I've had multiple people ask me about the commit-queue's behavior
575         regarding reporting flaky tests.  I figured it would be best to just
576         have the queue explain itself in the bugs it files.
577
578         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
579         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
580
581 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
582
583         Reviewed by Eric Seidel.
584
585         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
586         https://bugs.webkit.org/show_bug.cgi?id=51467
587
588         * Scripts/webkitpy/style/checker.py:
589         * Scripts/webkitpy/style/checker_unittest.py:
590
591 2010-12-23  Adam Barth  <abarth@webkit.org>
592
593         Rubber-stamped by Eric Seidel.
594
595         Move JavaScriptGlue into Sources
596         https://bugs.webkit.org/show_bug.cgi?id=51583
597
598         These tools refer to JavaScriptGlue and need to be updated to its new
599         location.
600
601         * Scripts/build-webkit:
602         * Scripts/do-file-rename:
603         * Scripts/do-webcore-rename:
604         * Scripts/webkitpy/common/config/build.py:
605         * Scripts/webkitpy/common/config/build_unittest.py:
606
607 2010-12-23  Lucas Forschler  <lforschler@apple.com>
608
609         Reviewed by Eric Seidel.
610
611         Bug 51539 - update iexploder scripts to point to new location
612
613         * Scripts/run-iexploder-tests:
614         * Scripts/update-iexploder-cssproperties:
615
616 2010-12-23  Evan Martin  <evan@chromium.org>
617
618         Reviewed by Ryosuke Niwa.
619
620         [chromium] LayoutTestController warning in float->int conversion
621         https://bugs.webkit.org/show_bug.cgi?id=51553
622
623         Rather than reading an int, converting to a float, then getting a compiler
624         warning on passing the float to something that expects an int, instead
625         just pass around ints.
626
627         No tests, fixes a compiler warning.
628
629         * DumpRenderTree/chromium/LayoutTestController.cpp:
630         (parsePageSizeParameters):
631         (LayoutTestController::pageNumberForElementById):
632         (LayoutTestController::numberOfPages):
633
634 2010-12-23  Lucas Forschler  <lforschler@apple.com>
635
636         Reviewed by Darin Adler.
637
638         Bug 51537 - iexploder needs cleanup
639         
640         * iExploder/htdocs: Removed.
641         * iExploder/htdocs/config.rb: Removed.
642         * iExploder/htdocs/cssproperties.in: Removed.
643         * iExploder/htdocs/cssvalues.in: Removed.
644         * iExploder/htdocs/htmlattrs.in: Removed.
645         * iExploder/htdocs/htmltags.in: Removed.
646         * iExploder/htdocs/htmlvalues.in: Removed.
647         * iExploder/htdocs/iexploder.cgi: Removed.
648         * iExploder/htdocs/iexploder.rb: Removed.
649         * iExploder/htdocs/index.html: Removed.
650         * iExploder/htdocs/webserver.rb: Removed.
651         * iExploder/iexploder-1.7.2/output: Removed.
652         * iExploder/tools: Removed.
653         * iExploder/tools/lasthit.rb: Removed.
654         * iExploder/tools/osx_last_crash.rb: Removed.
655         * iExploder/tools/showtest.rb: Removed.
656
657 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
658
659         Reviewed by Kenneth Rohde Christiansen.
660
661         [EFL] Make 'single' the default backing store in EWebLauncher
662         https://bugs.webkit.org/show_bug.cgi?id=51534
663
664         'single' is the simplest backing store and the one intended to be the
665         default in the test browser. By mistake the tiled backing store was
666         left as default in r72617.
667
668         * EWebLauncher/main.c:
669         (browserCreate): ditto.
670
671 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
672
673         Reviewed by Kenneth Rohde Christiansen.
674
675         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
676         https://bugs.webkit.org/show_bug.cgi?id=51533
677
678         There's no point in concatenating env("HOME") with "blah", so remove
679         option from EWebLauncher.
680
681         * EWebLauncher/main.c:
682         (main): ditto.
683
684 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
685
686         Reviewed by Eric Seidel.
687
688         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
689
690         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
691         I just discovered that we have two additional GC runs per each WebViewHost.
692         Test_shell had no such calls.
693         These gc runs eat 15% of cpu time.
694
695         https://bugs.webkit.org/show_bug.cgi?id=51479
696
697         * DumpRenderTree/chromium/WebViewHost.cpp:
698         (WebViewHost::~WebViewHost):
699
700 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
701
702         Reviewed by Ojan Vafai.
703
704         This change splits out the TestRunner class into its own file.
705         When we fork the code for message passing, we will create a new
706         TestRunner, and this change will allow that to be more modular.
707
708         While we're at it, split out TestInput and ResultSummary into
709         their own files, to reduce the size of run_webkit_tests to
710         something more managable.
711
712         https://bugs.webkit.org/show_bug.cgi?id=51092
713
714         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
715         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
716         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
717         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
718         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
719         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
720         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
721
722  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
723
724         Reviewed by Ojan Vafai.
725
726         nrwt multiprocessing - start over, prepare to fork the code
727  
728         This code cleans up the signatures and implementation of the
729         TestRunner class so we can easily fork it to run either the
730         stable implementation or the new, unstable message-passing
731         implementation. The two variants will have different
732         implementations of the run_tests() method. We will switch
733         between the two based on the setting for the '--worker-model'
734         switch. We rename the two currently valid values to 'old-inline'
735         and 'old-threads'.
736
737         https://bugs.webkit.org/show_bug.cgi?id=51081
738
739         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
740         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
741
742 2010-12-22  Victor Wang  <victorw@chromium.org>
743
744         Reviewed by Darin Fisher.
745
746         [Chromium] Update chromium archive test result url in rebaseline script.
747
748         https://bugs.webkit.org/show_bug.cgi?id=51503
749
750         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
751
752 2010-12-22  Lucas Forschler  <lforschler@apple.com>
753
754         Reviewed by Alice Liu.
755
756         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
757         Verified on Chrome, Safari, and IE.
758         With this change, we will record memory from a parent browser window and all child processes.
759
760         * record-memory-win/main.cpp:
761         (ProcessArgs):
762         (PrintUsage):
763         (getMemoryInfo):
764         (printProcessInfo):
765         (evalProcesses):
766         (UseImage):
767         (QueryContinuously):
768         (ElapsedTime):
769
770 2010-12-22  Lucas Forschler  <lforschler@apple.com>
771
772         Unreviewed rollout r74489, because it was missing changelog.
773
774         * record-memory-win/main.cpp:
775         
776 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
777
778         Adding myself as a reviewer.
779
780         * Scripts/webkitpy/common/config/committers.py:
781
782 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
783
784         Unreviewed.  Adding myself to committers.py.
785
786         * Scripts/webkitpy/common/config/committers.py:
787
788 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
789
790         Reviewed by Kenneth Rohde Christiansen.
791
792         TestNetscapePlugIn should use #if defined
793         https://bugs.webkit.org/show_bug.cgi?id=51471
794
795         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
796         (NP_Initialize):
797         (NPP_New):
798
799 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
800
801         Reviewed by Yury Semikhatsky.
802
803         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
804
805         DevTools window should be closed explicitly because it has custom deinitialization code.
806
807         https://bugs.webkit.org/show_bug.cgi?id=50722
808
809         * DumpRenderTree/chromium/TestShell.cpp:
810         (TestShell::closeRemainingWindows):
811
812 2010-12-22  David Levin  <levin@chromium.org>
813
814         Reviewed by Shinichiro Hamaji.
815
816         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
817         https://bugs.webkit.org/show_bug.cgi?id=51452
818
819         * Scripts/webkitpy/style/checkers/cpp.py:
820         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
821         Using the file extension if possible but falling back to the file contents if we have a header file.
822         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
823         (_FileState.is_c_or_objective_c):
824         (check_using_std): Changed to using _FileState to determine the file type.
825         (check_max_min_macros): Ditto.
826         (check_for_null): Ditto.
827         (check_style): Changed the parameters to various calls since they now need _FileState
828         to determine the file type.
829         (check_language): Added the file_state parameter so it could be passed
830         to check_identifier_name_in_declaration.
831         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
832         this is an Objective C file.
833         (_process_lines): Added information for the _FileState constructor (and moved the
834         call to a place that had the information).
835         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
836         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
837         its functionality.
838         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
839
840 2010-12-21  Andy Estes  <aestes@apple.com>
841
842         Reviewed by Mark Rowe.
843
844         Do not build non-Intel architectures for WebKit2-related projects.
845         https://bugs.webkit.org/show_bug.cgi?id=51440
846
847         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
848         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
849         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
850
851 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
852
853         Reviewed by Darin Fisher.
854
855         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
856         https://bugs.webkit.org/show_bug.cgi?id=51406 
857         
858         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
859         to WebThemeEngineDRTWin and update references everywhere.
860
861         * DumpRenderTree/DumpRenderTree.gypi:
862         * DumpRenderTree/chromium/TestShellWin.cpp:
863         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
864         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
865         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
866         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
867
868 2010-12-21  Anders Carlsson  <andersca@apple.com>
869
870         Reviewed by John Sullivan.
871
872         Clicking missing plug-in text does not show a sheet
873         https://bugs.webkit.org/show_bug.cgi?id=51403
874
875         Update for changes to the WebPageUIClient.
876
877         * MiniBrowser/mac/BrowserWindowController.m:
878         (-[BrowserWindowController awakeFromNib]):
879         * WebKitTestRunner/TestController.cpp:
880         (WTR::createOtherPage):
881         (WTR::TestController::initialize):
882
883 2010-12-21  Eric Seidel  <eric@webkit.org>
884
885         Reviewed by Adam Barth.
886
887         commit-queue will report constant failures as flaky if other tests flake
888         https://bugs.webkit.org/show_bug.cgi?id=51272
889
890         This patch just removes functionality and adds testing.
891         Previously we attempted to report flaky tests when we had
892         two different tests fail in a row.  However, since we stop
893         running the tests at the first failure, our code was wrong in
894         trying to determine flakiness from the incomplete runs.
895
896         Originally I posted an alternate patch:
897         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
898         which fixed our flaky logic in this case, however it was decided
899         that that patch would be too difficult to maintain, so now
900         I'm just removing the broken logic.
901
902         This will dramatically cut-down on our flaky-test false positives
903         at the (small) cost of the queues being unable to report
904         any flakiness if the tree is very flaky.  (With at least one test
905         flaking on every run, we'll never report failures anymore.)  I think
906         this is a tradeoff worth making.
907
908         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
909         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
910
911 2010-12-20  Eric Seidel  <eric@webkit.org>
912
913         Reviewed by Adam Barth.
914
915         commit-queue wrongly rejects patches when it can't update itself
916         https://bugs.webkit.org/show_bug.cgi?id=46636
917
918         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
919         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
920         * Scripts/webkitpy/tool/commands/queues_unittest.py:
921
922 2010-12-20  Adam Barth  <abarth@webkit.org>
923
924         Move web sites to Websites directory
925         https://bugs.webkit.org/show_bug.cgi?id=51323
926
927         Update references to BugsSite to point to the new location.
928
929         This patch was never officially reviewed (because it was too large to
930         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
931         Rowe gave me the green light.
932
933         * Scripts/old-run-webkit-tests:
934         * Scripts/webkitpy/common/config/build.py:
935         * Scripts/webkitpy/common/config/build_unittest.py:
936         * Scripts/webkitpy/common/prettypatch.py:
937         * Scripts/webkitpy/layout_tests/port/base.py:
938         * Scripts/webkitpy/style/main.py:
939
940 2010-12-20  Adrienne Walker  <enne@google.com>
941
942         Unreviewed. Adding myself to the list of committers.
943
944         * webkitpy/common/config/committers.py:
945
946 2010-12-20  Mark Rowe  <mrowe@apple.com>
947
948         Reviewed by Dan Bernstein.
949
950         <rdar://problem/8757601> Don't install header files in to the Resources directory.
951
952         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
953         Resources directory.
954
955 2010-12-20  Eric Seidel  <eric@webkit.org>
956
957         Reviewed by Adam Barth.
958
959         commit-queue should include bot id when attaching failure diffs
960         https://bugs.webkit.org/show_bug.cgi?id=51280
961
962         This is a tiny change to include the bot id in the name of the attachment.
963         Most of this diff is just changing the unit test expectations
964         now that I hid the comment printing when the comment is None.
965
966         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
967         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
968         * Scripts/webkitpy/tool/commands/upload_unittest.py:
969         * Scripts/webkitpy/tool/mocktool.py:
970
971 2010-12-20  Jeff Miller  <jeffm@apple.com>
972
973         Reviewed by Dan Bernstein.
974
975         Tools/vcbin/midl.exe needs to be rebuilt
976         https://bugs.webkit.org/show_bug.cgi?id=51347
977
978         * vcbin/midl.exe: Rebuilt.
979
980 2010-12-20  David Levin  <levin@chromium.org>
981
982         Reviewed by Ariya Hidayat.
983
984         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
985         https://bugs.webkit.org/show_bug.cgi?id=51343
986
987         Follow up from the WebKitTools -> Tools rename.
988
989         * Scripts/webkit-tools-completion.sh:
990
991 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
992
993         Reviewed by James Robinson.
994
995         new-run-webkit-tests ignores trailing EOL differences in text tests
996         https://bugs.webkit.org/show_bug.cgi?id=36983
997
998         Changed the handling of new-line characters within new-run-webkit-tests
999         to match old-run-webkit-tests.  Differences in leading and trailing empty
1000         lines in text expectation files are no longer ignored.
1001
1002         * Scripts/webkitpy/layout_tests/port/base.py:
1003         * Scripts/webkitpy/layout_tests/port/test.py:
1004         Added unit tests.  Removed old duplicate unit test entries.
1005         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1006
1007 2010-12-20  David Levin  <levin@chromium.org>
1008
1009         Reviewed by Shinichiro Hamaji.
1010
1011         check-webkit-style should detect function declarations (and trivial functions).
1012         https://bugs.webkit.org/show_bug.cgi?id=51303
1013
1014         * Scripts/webkitpy/style/checkers/cpp.py:
1015         (_FunctionState.begin): Add is_declaration and changed the line count
1016         start to begin at -1 (which will keep the results consistent, since
1017         the starting line number passed in is one less in this change).
1018         (detect_functions): changed function detection to now catch trivial
1019         functions and declarations.
1020         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
1021         of the function as this may look at return values (when processing
1022         a declaration).
1023         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1024         (FunctionDetectionTest.perform_function_detection): Basic mechanics
1025         of testing the function detection.
1026         (FunctionDetectionTest.test_basic_function_detection): Test a simple
1027         function.
1028         (FunctionDetectionTest.test_function_declaration_detection): Test a
1029         declaration.
1030         (FunctionDetectionTest.test_non_functions): A test case for a case
1031         that caused the code to fail due to the { being in quotes.
1032         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
1033         cases to help catch false alarms for return values.
1034         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
1035         we don't get false alarms for member variables either.
1036
1037 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
1038
1039         Reviewed by Antonio Gomes.
1040
1041         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
1042         https://bugs.webkit.org/show_bug.cgi?id=51319
1043
1044         * CMakeListsEfl.txt:
1045
1046 2010-12-18  Adam Barth  <abarth@webkit.org>
1047
1048         Reviewed by Sam Weinig.
1049
1050         Move WebKitExamplePlugins to Examples
1051         https://bugs.webkit.org/show_bug.cgi?id=51291
1052
1053         * Scripts/webkitpy/common/config/build.py:
1054
1055 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
1056
1057         Unreviewed Qt buildfix after r74301.
1058
1059         Rename WebKitTools to Tools
1060         https://bugs.webkit.org/show_bug.cgi?id=49861
1061
1062         * MiniBrowser/DerivedSources.pro:
1063         * MiniBrowser/qt/MiniBrowser.pro:
1064
1065 2010-12-17  Dan Bernstein  <mitz@apple.com>
1066
1067         Reviewed by Simon Fraser.
1068
1069         Rename WebKitTools to Tools
1070         https://bugs.webkit.org/show_bug.cgi?id=49861
1071
1072         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1073         * CodeCoverage/README:
1074         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1075         (WebCore::DumpRenderTree::initializeFonts):
1076         * EWSTools/start-commit-queue.sh:
1077         * EWSTools/start-queue.sh:
1078         * GNUmakefile.am:
1079         * MIDLWrapper/MIDLWrapper.cpp:
1080         (wmain):
1081         * MiniBrowser/qt/MiniBrowser.pro:
1082         * Scripts/build-api-tests:
1083         * Scripts/build-dumprendertree:
1084         * Scripts/build-webkit:
1085         * Scripts/build-webkittestrunner:
1086         * Scripts/generate-coverage-data:
1087         * Scripts/old-run-webkit-tests:
1088         * Scripts/run-api-tests:
1089         * Scripts/run-iexploder-tests:
1090         * Scripts/run-javascriptcore-tests:
1091         * Scripts/run-mangleme-tests:
1092         * Scripts/run-sunspider:
1093         * Scripts/run-webkit-websocketserver:
1094         * Scripts/sunspider-compare-results:
1095         * Scripts/test-webkitperl:
1096         * Scripts/test-webkitpy:
1097         * Scripts/update-iexploder-cssproperties:
1098         * Scripts/update-webkit:
1099         * Scripts/update-webkit-localizable-strings:
1100         * Scripts/webkitdirs.pm:
1101         * Scripts/webkitpy/common/checkout/scm.py:
1102         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1103         * Scripts/webkitpy/common/config/committervalidator.py:
1104         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1105         * Scripts/webkitpy/common/config/ports.py:
1106         * Scripts/webkitpy/common/config/ports_unittest.py:
1107         * Scripts/webkitpy/common/system/logutils_unittest.py:
1108         * Scripts/webkitpy/common/system/ospath_unittest.py:
1109         * Scripts/webkitpy/layout_tests/port/chromium.py:
1110         * Scripts/webkitpy/layout_tests/port/config.py:
1111         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1112         * Scripts/webkitpy/layout_tests/port/http_server.py:
1113         * Scripts/webkitpy/layout_tests/port/test.py:
1114         * Scripts/webkitpy/style/checker.py:
1115         * Scripts/webkitpy/style/checker_unittest.py:
1116         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1117         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1118         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1119         * WebKitTestRunner/DerivedSources.pro:
1120         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1121         (WTR::activateFonts):
1122         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1123         * wx/build/build_utils.py:
1124
1125 2010-12-16  Antonio Gomes  <agomes@rim.com>
1126
1127         Reviewed by Martin Robinson.
1128
1129         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
1130         https://bugs.webkit.org/show_bug.cgi?id=51163
1131
1132         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
1133         GTK+'s DRT should also reset to UNIX after each test execution.
1134
1135         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1136         (resetDefaultsToConsistentValues):
1137
1138 2010-12-17  David Levin  <levin@chromium.org>
1139
1140         Reviewed by Eric Seidel.
1141
1142         check-webkit-style should understand WTF #include guards
1143         https://bugs.webkit.org/show_bug.cgi?id=44911
1144
1145         * Scripts/webkitpy/style/checkers/cpp.py:
1146         (get_header_guard_cpp_variable): modify to suggest the WTF style
1147         of header guard when appropriate.
1148         (check_for_header_guard): handle multiple return values from
1149         get_header_guard_cpp_variable
1150         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1151         (CppStyleTest.test_build_header_guard): Added tests for the WTF
1152         header style.
1153
1154 2010-12-16  David Levin  <levin@chromium.org>
1155
1156         Reviewed by Eric Seidel.
1157
1158         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
1159         https://bugs.webkit.org/show_bug.cgi?id=51210
1160
1161         The error only shows up when using python 2.6 or later.
1162
1163         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
1164         the decprecated field error,message with something equivalent.
1165
1166 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
1167
1168         Reviewed by Eric Seidel.
1169
1170         Add --exit-after-n-failures/crashes to NRWT
1171         https://bugs.webkit.org/show_bug.cgi?id=51160
1172         
1173         Abort test run (in a similar way to how control-C is handled) when
1174         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
1175         that number of unexpected failures/crashes/timeouts.
1176
1177         * Scripts/webkitpy/layout_tests/port/test.py:
1178         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1179         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1180
1181 2010-12-16  David Levin  <levin@chromium.org>
1182
1183         Reviewed by Shinichiro Hamaji.
1184
1185         check-webkit-style unit tests has some duplicate boilerplate code.
1186         https://bugs.webkit.org/show_bug.cgi?id=49519
1187
1188         * Scripts/webkitpy/style/checkers/cpp.py:
1189         (update_include_state): Replaced the "io" parameter with the global
1190         configuration _unit_test_config. This allowed not calling into
1191         functions at a low level and also not plumbing through the injection
1192         information through many levels of code.
1193         (check_for_include_what_you_use): Ditto.
1194         (process_file_data): Added the ability to set up the unit test config
1195         to allow for injection.
1196         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1197         (ErrorCollector.__init__): Added support for having a filter for errors.
1198         (ErrorCollector.__call__): Ditto.
1199         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
1200         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
1201         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
1202         functions in the cpp.py with generic processing and a filter that
1203         indicates what errors should be kept.
1204         (CppStyleTestBase.perform_multi_line_lint): Ditto.
1205         (CppStyleTestBase.perform_language_rules_check): Ditto.
1206         (CppStyleTestBase.perform_function_lengths_check): Ditto.
1207         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
1208         (CppStyleTestBase.perform_include_what_you_use): Ditto.
1209         (CppStyleTest.test_multi_line_comments): Added another
1210         error message which applies to the test case.
1211         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
1212         to not have config.h, since it is processed as a header file.
1213         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
1214         style and indentation in checked code.
1215         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
1216         Fixed line number.
1217         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
1218         Ditto.
1219
1220 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1221
1222         Unreviewed, rolling out r74136.
1223         http://trac.webkit.org/changeset/74136
1224         https://bugs.webkit.org/show_bug.cgi?id=51135
1225
1226         r74136 breaks chromium canary bots because some tests are not
1227         rebaselined correctly to resolve EOL differences (Requested by
1228         jianli on #webkit).
1229
1230         * Scripts/webkitpy/layout_tests/port/base.py:
1231         * Scripts/webkitpy/layout_tests/port/test.py:
1232         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1233
1234 2010-12-15  Adam Roben  <aroben@apple.com>
1235
1236         Teach check-webkit-style to check .vcproj and .vsprops files for XML
1237         syntax errors
1238
1239         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
1240         XML syntax errors in .vcproj/.vsprops files
1241
1242         Reviewed by Dave Levin.
1243
1244         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
1245         that should be treated as XML and that should be allowed to contain
1246         carriage returns. (These lists happen to be identical currently.)
1247         (FileType): Added a new XML type.
1248         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
1249         Just does a simple file extension check.
1250         (CheckerDispatcher._file_type): Added a case for XML files.
1251         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
1252         files (surprise!).
1253         (StyleProcessor.process): Ask the dispatcher whether we should pass the
1254         lines through the carriage checker.
1255
1256         * Scripts/webkitpy/style/checker_unittest.py:
1257         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
1258         Added. Checks a few file names to see if carriage returns are allowed
1259         or not.
1260         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
1261         other assert_checker_* functions.
1262         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
1263         test_*_paths functions.
1264         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
1265         test_*_paths functions.
1266         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
1267         file from this test case, as vcproj files now have a type.
1268         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
1269         Added. Similar to the other should_* functions.
1270         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
1271         Added. Checks that carriage returns aren't checked for or stripped for
1272         allowed files.
1273
1274         * Scripts/webkitpy/style/checkers/xml.py: Added.
1275         (XMLChecker.__init__): Simple init method.
1276         (XMLChecker.check): Pass each line through the expat parser, and record
1277         a style error for any errors thrown by the parser.
1278
1279         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
1280         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
1281         produce a style error.
1282         (XMLCheckerTest.assert_error): Checks that the given XML produces an
1283         error of the given category on the given line.
1284         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
1285         checking that the XMLChecker constructor works properly.
1286         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
1287         cause a style error (see, e.g., r73887).
1288         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
1289         cause a style error (see, e.g., r73773).
1290         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
1291         properly.
1292         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
1293         tags cause a style error (see, e.g., r72795).
1294         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
1295         style error.
1296
1297 2010-12-15  Lucas Forschler  <lforschler@apple.com>
1298
1299         Reviewed by Stephanie Lewis.
1300
1301         https://bugs.webkit.org/show_bug.cgi?id=51117
1302         Add a new leopard test bot
1303         really really commit to trunk this time.
1304
1305         * BuildSlaveSupport/build.webkit.org-config/config.json:
1306
1307 2010-12-15  Sam Weinig  <sam@webkit.org>
1308
1309         Reviewed by Anders Carlsson.
1310
1311         WebKit2: Can't add files to an <input type=file>
1312         https://bugs.webkit.org/show_bug.cgi?id=51087
1313
1314         * MiniBrowser/mac/BrowserWindowController.m:
1315         (runOpenPanel):
1316         (-[BrowserWindowController awakeFromNib]):
1317         Add simple implementation of runOpenPanel callback.
1318
1319         * MiniBrowser/win/BrowserView.cpp:
1320         (BrowserView::create):
1321         * WebKitTestRunner/TestController.cpp:
1322         (WTR::createOtherPage):
1323         (WTR::TestController::initialize):
1324         Stub out runOpenPanel callback. 
1325
1326 2010-12-14  Eric Seidel  <eric@webkit.org>
1327
1328         Reviewed by Adam Barth.
1329
1330         commit-queue should upload failure diffs when tests flake
1331         https://bugs.webkit.org/show_bug.cgi?id=51051
1332
1333         To make this testable I needed to pipe FileSystem down onto tool.
1334         We've wanted it there for a long time anyway.
1335
1336         This patch is kinda a big hack.  But we don't have a nice
1337         way to read results.html files.  I think this will need further
1338         revision before this code actually feels clean.
1339
1340         As part of testing this change, I had to make MockBugzilla.create_bug
1341         actually return an id (like it should) which required updating
1342         a few other unit test results (for the better).
1343
1344         The results_matching_keys change in layouttestresults/rebasline
1345         was an alternate path which I decided not to use in the end, but
1346         I left the change as it seemed an improvement.
1347
1348         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1349         * Scripts/webkitpy/common/net/layouttestresults.py:
1350         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1351         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1352         * Scripts/webkitpy/tool/commands/queues.py:
1353         * Scripts/webkitpy/tool/commands/rebaseline.py:
1354         * Scripts/webkitpy/tool/main.py:
1355         * Scripts/webkitpy/tool/mocktool.py:
1356
1357 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
1358
1359         Reviewed by James Robinson.
1360
1361         new-run-webkit-tests ignores trailing EOL differences in text tests
1362         https://bugs.webkit.org/show_bug.cgi?id=36983
1363
1364         Changed the handling of new-line characters within new-run-webkit-tests
1365         to match old-run-webkit-tests.  Differences in leading and trailing empty
1366         lines in text expectation files are no longer ignored.
1367
1368         * Scripts/webkitpy/layout_tests/port/base.py:
1369         * Scripts/webkitpy/layout_tests/port/test.py:
1370         Added unit tests.  Removed old duplicate unit test entries.
1371         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1372
1373 2010-12-15  Ojan Vafai  <ojan@chromium.org>
1374
1375         Reviewed by Adam Barth.
1376
1377         make status-bubble white-space:nowrap so we can measure it's width without wrapping
1378         https://bugs.webkit.org/show_bug.cgi?id=51149
1379
1380         * QueueStatusServer/templates/statusbubble.html:
1381
1382 2010-12-15  Ojan Vafai  <ojan@chromium.org>
1383
1384         Reviewed by Adam Barth.
1385
1386         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
1387         https://bugs.webkit.org/show_bug.cgi?id=51125
1388
1389         * QueueStatusServer/templates/statusbubble.html:
1390
1391 2010-12-15  Darin Adler  <darin@apple.com>
1392
1393         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
1394
1395 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1396
1397         Unreviewed, rolling out r74117.
1398         http://trac.webkit.org/changeset/74117
1399         https://bugs.webkit.org/show_bug.cgi?id=51113
1400
1401         This broke the GTK1 build. (Requested by mrobinson on
1402         #webkit).
1403
1404         * Scripts/webkitdirs.pm:
1405
1406 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
1407
1408         Reviewed by Martin Robinson.
1409
1410         Change generate-forwarding-headers.pl for GTK port usage 
1411         (https://bugs.webkit.org/show_bug.cgi?id=37369)
1412
1413         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
1414
1415 2010-12-14  Kent Tamura  <tkent@chromium.org>
1416
1417         Reviewed by Jian Li.
1418
1419         [DRT/Chromium] Remove another unnecessary error message
1420         https://bugs.webkit.org/show_bug.cgi?id=51083
1421
1422         * DumpRenderTree/chromium/WebViewHost.cpp:
1423         (WebViewHost::didInvalidateRect):
1424
1425 2010-12-14  Lucas Forschler  <lforschler@apple.com>
1426
1427         Reviewed by Stephanie Lewis.
1428
1429         Add a new Leopard Debug Test WK2 Bot
1430
1431         * BuildSlaveSupport/build.webkit.org-config/config.json:
1432
1433 2010-12-14  Ojan Vafai  <ojan@chromium.org>
1434
1435         Fix python unittests after http://trac.webkit.org/changeset/74070.
1436
1437         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1438
1439 2010-12-14  Kent Tamura  <tkent@chromium.org>
1440
1441         Reviewed by Jian Li.
1442
1443         [DRT/Chromium] Remove a unnecessary error message
1444         https://bugs.webkit.org/show_bug.cgi?id=51069
1445
1446         * DumpRenderTree/chromium/WebViewHost.cpp:
1447         (WebViewHost::paintInvalidatedRegion):
1448
1449 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
1450
1451         Reviewed by Ojan Vafai.
1452
1453         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
1454         https://bugs.webkit.org/show_bug.cgi?id=48926
1455
1456         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1457         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
1458
1459 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1460
1461         Reviewed by Eric Seidel.
1462
1463         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
1464         https://bugs.webkit.org/show_bug.cgi?id=50231
1465
1466         Guard CONFIG+=link_pkgconfig with !symbian.
1467
1468         * DumpRenderTree/qt/DumpRenderTree.pro:
1469         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1470         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1471
1472 2010-12-14  Philippe Normand  <pnormand@igalia.com>
1473
1474         Reviewed by Ojan Vafai.
1475
1476         [new-run-webkit-tests] expectations parsing is slow
1477         https://bugs.webkit.org/show_bug.cgi?id=50635
1478
1479         Avoid expensive iteration of all the tests when checking if a test
1480         file is to be skipped or not.
1481
1482         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1483         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1484         * Scripts/webkitpy/layout_tests/port/test.py:
1485
1486 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
1487
1488         Reviewed by Xan Lopez.
1489
1490         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
1491         https://bugs.webkit.org/show_bug.cgi?id=27048
1492
1493         Add support in DRT for checking whether an accessibility UI
1494         element is focusable and/or focused. Implemented for GTK.
1495
1496         * DumpRenderTree/AccessibilityUIElement.cpp:
1497         (getIsFocusedCallback): New.
1498         (getIsFocusableCallback): New.
1499         (AccessibilityUIElement::getJSClass): Add the new available
1500         callbacks for isFocused and isFocusable.
1501         * DumpRenderTree/AccessibilityUIElement.h:
1502         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1503         (AccessibilityUIElement::isFocused): New, implemented by checking
1504         whether the related AtkState value is in the object's state set.
1505         (AccessibilityUIElement::isFocusable): Ditto.
1506         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1507         (AccessibilityUIElement::isFocused): New, dummy implementation.
1508         (AccessibilityUIElement::isFocusable): Ditto.
1509         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1510         (AccessibilityUIElement::isFocused): Ditto.
1511         (AccessibilityUIElement::isFocusable): Ditto.
1512
1513 2010-12-14  Eric Seidel  <eric@webkit.org>
1514
1515         Reviewed by Ojan Vafai.
1516
1517         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
1518         https://bugs.webkit.org/show_bug.cgi?id=50715
1519
1520         This patch makes webkit-patch print the following:
1521
1522         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
1523         Install a 64-bit git for better performance, see:
1524         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
1525
1526         I wrote this mostly because I have approximately 8 machines that I use
1527         and making sure each one is using a good Git install seemed folly.
1528         webkit-patch makes a lot of git calls, so using a fast git can shave
1529         several seconds in every invocation.  See the webkit-dev thread for more info.
1530
1531         This message will print twice during 'webkit-patch upload',
1532         once from webkit-patch and once from check-webkit-style.
1533
1534         Unfortunately there is no good way to test this due to how machine-dependent
1535         the code is.  I considered writing a test for the log message, but it seemed not worth it.
1536
1537         * Scripts/webkitpy/common/checkout/scm.py:
1538
1539 2010-12-13  Eric Seidel  <eric@webkit.org>
1540
1541         Reviewed by Adam Barth.
1542
1543         FlakyTestReporter doesn't understand bots running from multiple email addresses
1544         https://bugs.webkit.org/show_bug.cgi?id=50960
1545
1546         This explains at least one of the dupes of:
1547         https://bugs.webkit.org/show_bug.cgi?id=50863
1548         that we saw filed by the commit-queue this morning.
1549         I think the other one was explained by my previous fix to result counting code.
1550
1551         Since this is really hard to test with a unit test, instead I
1552         create a new (possibly useful in the future) command
1553         which given a layout test path will return you
1554         the one bug which our tools would assume it the flaky test bug.
1555         If some other script wants to use bug-for-test we'll
1556         need to extend it with some options like --create-if-missing or similar.
1557
1558         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1559         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1560         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1561         * Scripts/webkitpy/tool/commands/__init__.py:
1562         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
1563
1564 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
1565
1566         Reviewed by James Robinson.
1567
1568         Add option to build-webkit to not build WebKit2
1569         https://bugs.webkit.org/show_bug.cgi?id=50988
1570         
1571         Add support for a --no-webkit2 option to build-webkit. It seems to save
1572         ~1 minute from clean builds and ~10 seconds from no-op builds.
1573
1574         * Scripts/build-webkit:
1575
1576 2010-12-13  Lucas Forschler  <lforschler@apple.com>
1577
1578         Reviewed by Dave Kilzer.
1579
1580         Update iexploder from 1.3.2 to 1.7.2
1581         Move 1.3.2 into its own subdir
1582         Add 1.7.2 into its own subdir
1583         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
1584
1585         * Scripts/run-iexploder-tests:
1586         * Scripts/update-iexploder-cssproperties:
1587         * iExploder/CHANGELOG.txt: Removed.
1588         * iExploder/LICENSE.txt: Removed.
1589         * iExploder/README.txt: Removed.
1590         * iExploder/htdocs: Removed.
1591         * iExploder/iexploder-1.3.2: Added.
1592         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
1593         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
1594         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
1595         * iExploder/iexploder-1.3.2/htdocs: Added.
1596         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
1597         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
1598         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
1599         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
1600         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
1601         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
1602         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
1603         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
1604         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
1605         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
1606         * iExploder/iexploder-1.3.2/tools: Added.
1607         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
1608         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
1609         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
1610         * iExploder/iexploder-1.7.2: Added.
1611         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
1612         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
1613         * iExploder/iexploder-1.7.2/README.txt: Added.
1614         * iExploder/iexploder-1.7.2/output: Added.
1615         * iExploder/iexploder-1.7.2/src: Added.
1616         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
1617         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
1618         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
1619         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
1620         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
1621         * iExploder/iexploder-1.7.2/src/css-properties: Added.
1622         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
1623         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
1624         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
1625         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
1626         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
1627         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
1628         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
1629         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
1630         * iExploder/iexploder-1.7.2/src/css-values: Added.
1631         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
1632         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
1633         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
1634         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
1635         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
1636         * iExploder/iexploder-1.7.2/src/headers: Added.
1637         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
1638         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
1639         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
1640         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
1641         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
1642         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
1643         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
1644         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
1645         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
1646         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
1647         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
1648         * iExploder/iexploder-1.7.2/src/html-tags: Added.
1649         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
1650         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
1651         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
1652         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
1653         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
1654         * iExploder/iexploder-1.7.2/src/html-values: Added.
1655         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
1656         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
1657         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
1658         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
1659         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
1660         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
1661         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
1662         * iExploder/iexploder-1.7.2/src/index.html: Added.
1663         * iExploder/iexploder-1.7.2/src/media: Added.
1664         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
1665         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
1666         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
1667         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
1668         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
1669         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
1670         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
1671         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
1672         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
1673         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
1674         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
1675         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
1676         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
1677         * iExploder/iexploder-1.7.2/src/mime-types: Added.
1678         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
1679         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
1680         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
1681         * iExploder/iexploder-1.7.2/src/protocols: Added.
1682         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
1683         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
1684         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
1685         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
1686         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
1687         * iExploder/iexploder-1.7.2/src/version.rb: Added.
1688         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
1689         * iExploder/iexploder-1.7.2/testcases: Added.
1690         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
1691         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
1692         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
1693         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
1694         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
1695         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
1696         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
1697         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
1698         * iExploder/iexploder-1.7.2/tools: Added.
1699         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
1700         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
1701         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
1702         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
1703         * iExploder/tools: Removed.
1704
1705 2010-12-13  Sam Weinig  <sam@webkit.org>
1706
1707         Reviewed by Anders Carlsson.
1708
1709         Remove associated page concept from WKView constructor
1710         https://bugs.webkit.org/show_bug.cgi?id=50983
1711
1712         Step 1: Remove associate page constructors from WKView and make
1713         all views use the shared namespace for the context.
1714
1715         * TestWebKitAPI/PlatformWebView.h:
1716         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1717         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1718         * WebKitTestRunner/PlatformWebView.h:
1719         * WebKitTestRunner/TestController.cpp:
1720         (WTR::createOtherPage):
1721         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1722         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1723         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1724
1725 2010-12-13  Sam Weinig  <sam@webkit.org>
1726
1727         Reviewed by Anders Carlsson.
1728
1729         Change the WebKit2 public API so there is no explicit WKPageNamespace object
1730         https://bugs.webkit.org/show_bug.cgi?id=50898
1731
1732         * MiniBrowser/mac/AppDelegate.h:
1733         * MiniBrowser/mac/AppDelegate.m:
1734         * MiniBrowser/mac/BrowserWindowController.h:
1735         * MiniBrowser/mac/BrowserWindowController.m:
1736         * MiniBrowser/win/BrowserView.cpp:
1737         Convert MiniBrowser to not use PageNamespaces.
1738
1739         * TestWebKitAPI/PlatformWebView.h:
1740         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1741         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1742         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1743         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1744         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1745         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1746         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1747         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1748         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1749         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1750         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1751         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1752         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1753         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1754         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1755         Convert TestWebKitAPI to not use PageNamespaces.
1756
1757         * WebKitTestRunner/PlatformWebView.h:
1758         * WebKitTestRunner/TestController.cpp:
1759         * WebKitTestRunner/TestController.h:
1760         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1761         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1762         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1763         Convert WebKitTestRunner to not use PageNamespaces.
1764
1765 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1766
1767         Reviewed by Eric Seidel.
1768
1769         webkit-patch rollout should be able to do multi-revision rollouts
1770         https://bugs.webkit.org/show_bug.cgi?id=33336
1771
1772         Make it possible to pass more than one revision to webkit-patch.
1773
1774         * Scripts/webkitpy/common/checkout/api.py:
1775         * Scripts/webkitpy/common/checkout/changelog.py:
1776         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1777         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1778         * Scripts/webkitpy/tool/commands/download.py:
1779         * Scripts/webkitpy/tool/commands/download_unittest.py:
1780         * Scripts/webkitpy/tool/mocktool.py:
1781         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1782         * Scripts/webkitpy/tool/steps/revertrevision.py:
1783
1784 2010-12-13  Eric Seidel  <eric@webkit.org>
1785
1786         Unreviewed.
1787
1788         Teach webkit-patch how to search bugzilla
1789         https://bugs.webkit.org/show_bug.cgi?id=50500
1790
1791         webkit-patch bug-search fails when there is only one result.
1792         Turns out we needed a bit more logic in our result count parsing code.
1793
1794         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1795         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1796
1797 2010-12-13  Antti Koivisto  <antti@apple.com>
1798
1799         Reviewed by Alexey Proskuryakov.
1800
1801         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1802         https://bugs.webkit.org/show_bug.cgi?id=50758
1803
1804         * DumpRenderTree/LayoutTestController.cpp:
1805         (setSerializeHTTPLoadsCallback):
1806         (LayoutTestController::staticFunctions):
1807         * DumpRenderTree/LayoutTestController.h:
1808         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1809         (LayoutTestController::setSerializeHTTPLoads):
1810         * DumpRenderTree/mac/DumpRenderTree.mm:
1811         (resetDefaultsToConsistentValues):
1812         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1813         (LayoutTestController::setSerializeHTTPLoads):
1814         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1815         (LayoutTestController::setSerializeHTTPLoads):
1816
1817 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1818
1819         Reviewed by Ojan Vafai.
1820
1821         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1822         https://bugs.webkit.org/show_bug.cgi?id=50936
1823
1824         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1825
1826 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
1827
1828         Reviewed by Csaba Osztrogonác.
1829
1830         Add revlink to BuildBot status
1831         https://bugs.webkit.org/show_bug.cgi?id=50914
1832
1833         This adds a hyperlink to trac changeset on the revision numbers. 
1834
1835         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1836
1837 2010-12-13  Andras Becsi  <abecsi@webkit.org>
1838
1839         Reviewed by Csaba Osztrogonác.
1840
1841         [Qt][WK2] Fix build if WebKitTools are not available
1842         https://bugs.webkit.org/show_bug.cgi?id=50242
1843
1844         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
1845         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
1846         * MiniBrowser/DerivedSources.pro: Added.
1847
1848 2010-12-13  Eric Seidel  <eric@webkit.org>
1849
1850         Reviewed by Adam Barth.
1851
1852         EWS Queues should remove orpahned pyc files before starting
1853         https://bugs.webkit.org/show_bug.cgi?id=50904
1854
1855         A previous check added a platform.py which caused
1856         EWS bots on some platforms to hit an import exception.
1857         The platform.py file was removed in a subsequent commit, but
1858         the EWS bots in question stayed stuck.  This change will
1859         fix those bots once restarted (and prevent this in the future).
1860
1861         I also went ahead and unified start-queue and start-commit-queue
1862         since they were nearly identical.  I also added bot_id support
1863         to both force all EWSes to have bot ids as well as get rid of the one
1864         remaining reason why I had my own copies of these scripts.
1865         Hopefully this will be enough to get all the other bot admins
1866         (ahem, Adam, ahem) to move to using these checked in copies as well.
1867
1868         * EWSTools/start-commit-queue.sh: Removed.
1869         * EWSTools/start-queue.sh:
1870
1871 2010-10-28  MORITA Hajime  <morrita@google.com>
1872
1873         Reviewed by Ojan Vafai.
1874
1875         spellcheck does not check pasted text
1876         https://bugs.webkit.org/show_bug.cgi?id=40092
1877
1878         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
1879         to control the setting.
1880
1881         * DumpRenderTree/LayoutTestController.cpp:
1882         (setAsynchronousSpellCheckingEnabledCallback):
1883         (LayoutTestController::staticFunctions):
1884         * DumpRenderTree/LayoutTestController.h:
1885         * DumpRenderTree/chromium/LayoutTestController.h:
1886         * DumpRenderTree/chromium/LayoutTestController.cpp:
1887         (LayoutTestController::LayoutTestController):
1888         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1889         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1890         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1891         * DumpRenderTree/mac/DumpRenderTree.mm:
1892         (resetDefaultsToConsistentValues):
1893         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1894         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1895         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1896         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1897         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1898         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1899         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1900         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1901         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1902
1903 2010-12-12  Sam Weinig  <sam@webkit.org>
1904
1905         Reviewed by Anders Carlsson.
1906
1907         Fix failing API test. It turns out that a pop-state event
1908         is sent before every fragment navigation, so we have to test
1909         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
1910
1911         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1912         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1913
1914 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
1915
1916         Reviewed by Eric Seidel.
1917
1918         [GTK] Add new-run-webkit-tests support to gtk
1919         https://bugs.webkit.org/show_bug.cgi?id=50681
1920
1921         Adding the basic support to run the new-run-webkit-tests.
1922
1923         * Scripts/webkitpy/layout_tests/port/gtk.py:
1924
1925 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
1926
1927         Reviewed by Kenneth Rohde Christiansen.
1928
1929         [Qt] Mock DeviceOrientation client for DRT
1930         https://bugs.webkit.org/show_bug.cgi?id=47490
1931
1932         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1933         (WebCore::DumpRenderTree::DumpRenderTree):
1934         (WebCore::DumpRenderTree::~DumpRenderTree):
1935         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1936         (LayoutTestController::setMockDeviceOrientation):
1937
1938 2010-12-11  Philippe Normand  <pnormand@igalia.com>
1939
1940         Reviewed by Gustavo Noronha Silva.
1941
1942         [GTK] launcher: disable the Mozilla-style fullscreen API
1943         https://bugs.webkit.org/show_bug.cgi?id=50874
1944
1945         Disabling the fullscreen API until its implementation for GTK is
1946         mature enough. The webview setting for it is already FALSE by
1947         default.
1948
1949         * GtkLauncher/main.c:
1950         (createWindow):
1951
1952 2010-12-10  Eric Seidel  <eric@webkit.org>
1953
1954         Reviewed by Adam Barth.
1955
1956         commit-queue flaky test messages show cryptic version information for mac os x
1957         https://bugs.webkit.org/show_bug.cgi?id=50864
1958
1959         Turns out platform.platform() returns kernel version information
1960         which isn't helpful, and just plain confusing on Mac
1961         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
1962
1963         So I've updated PlatformInfo.display_name() to special case
1964         mac.  I also found a bad use of sys.platform in the process
1965         and fixed that.  (sys.platform always returns 'darwin' on mac).
1966
1967         * Scripts/webkitpy/common/system/platforminfo.py:
1968         * Scripts/webkitpy/common/system/user.py:
1969         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1970         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1971         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1972
1973 2010-12-10  Eric Seidel  <eric@webkit.org>
1974
1975         Unreviewed.
1976
1977         Exception seen while reporting flaky test with commit-queue.
1978         Just a missing include.
1979
1980         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1981         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1982
1983 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
1984
1985         Reviewed by Eric Seidel.
1986
1987         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
1988         https://bugs.webkit.org/show_bug.cgi?id=50796
1989
1990         Also updating the test code to use JSONResultsGeneratorBase and
1991         to improve test coverage for incremental cases.
1992
1993         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1994         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1995
1996 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
1997
1998         Reviewed by Darin Adler.
1999
2000         prepare-ChangeLog --help doesn't mention --bug shorthand -b
2001         https://bugs.webkit.org/show_bug.cgi?id=50835
2002
2003         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
2004
2005 2010-12-10  Eric Seidel  <eric@webkit.org>
2006
2007         Reviewed by Adam Barth.
2008
2009         Bugs created by the commit-queue should all block on a master bug
2010         https://bugs.webkit.org/show_bug.cgi?id=50857
2011
2012         This makes all bugs created by the commit-queue block on:
2013         https://bugs.webkit.org/show_bug.cgi?id=50856
2014
2015         In the process of testing this, I found that the existing
2016         create_bug code was wrong.  I also found that existing
2017         unit tests for create-rollout used invalid values
2018         for options.blocks.  I fixed both issues and tested.
2019
2020         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2021         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2022         * Scripts/webkitpy/tool/commands/commandtest.py:
2023         * Scripts/webkitpy/tool/commands/download_unittest.py:
2024         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2025         * Scripts/webkitpy/tool/mocktool.py:
2026         * Scripts/webkitpy/tool/steps/options.py:
2027
2028 2010-12-10  Eric Seidel  <eric@webkit.org>
2029
2030         Reviewed by Adam Barth.
2031
2032         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
2033         https://bugs.webkit.org/show_bug.cgi?id=50853
2034
2035         I also discovered when doing this that the code was posting
2036         the comment on the wrong bug, but that's fixed here too.
2037
2038         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2039         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2040         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2041         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2042         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2043         * Scripts/webkitpy/tool/mocktool.py:
2044
2045 2010-12-10  Anders Carlsson  <andersca@apple.com>
2046
2047         Reviewed by John Sullivan.
2048
2049         Make WKContextGetStatistics gather global statistics
2050         https://bugs.webkit.org/show_bug.cgi?id=50850
2051
2052         Remove the code that gets the statistics and fills in the per context
2053         statistics information for now.
2054
2055         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
2056         (-[BrowserStatisticsWindowController refreshStatistics:]):
2057
2058 2010-12-10  Eric Seidel  <eric@webkit.org>
2059
2060         Unreviewed.
2061
2062         commit-queue should report port/platform information when commenting on flaky test bugs
2063         https://bugs.webkit.org/show_bug.cgi?id=50839
2064
2065         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
2066         which was only used by new run webkit tests (and clearly not unit tested).
2067
2068         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
2069         * Scripts/webkitpy/tool/main.py:
2070         * Scripts/webkitpy/tool/mocktool.py:
2071
2072 2010-12-10  Eric Seidel  <eric@webkit.org>
2073
2074         Reviewed by Tony Chang.
2075
2076         commit-queue should report port/platform information when commenting on flaky test bugs
2077         https://bugs.webkit.org/show_bug.cgi?id=50839
2078
2079         This was a suggestion from Tony Chang this morning.
2080         I added a platform.py class so I could easily mock the platform call,
2081         but that may not be the final solution for this mocking.
2082         We'll try it and see.
2083
2084         * Scripts/webkitpy/common/system/platform.py: Added.
2085         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2086         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2087         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2088         * Scripts/webkitpy/tool/main.py:
2089         * Scripts/webkitpy/tool/mocktool.py:
2090
2091 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
2092
2093         Reviewed by Joseph Pecoraro.
2094
2095         Bug 43455 - [Qt]: Implement Application Cache Quotas
2096         https://bugs.webkit.org/show_bug.cgi?id=43455
2097
2098         Introduce functions to allow new appcache layout test origin-quota.html
2099         to work correctly under Qt.
2100
2101         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2102         (WebCore::DumpRenderTree::DumpRenderTree):
2103         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
2104         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2105
2106         Introduce functions to allow new appcache layout test origin-quota.html
2107         to be successful under qt. Changes required because LayoutTestControllerQt
2108         does not inherit from LayoutController.
2109
2110         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2111         (LayoutTestController::reset):
2112         (LayoutTestController::clearAllApplicationCaches):
2113         (LayoutTestController::setApplicationCacheOriginQuota):
2114         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2115         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
2116         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
2117
2118 2010-12-10  Eric Seidel  <eric@webkit.org>
2119
2120         Reviewed by Adam Barth.
2121
2122         Move buildbot.py into its own module so we can split it out into one-file-per-class
2123         https://bugs.webkit.org/show_bug.cgi?id=50806
2124
2125         We're adding more buildbot logic these days, so it makes sense
2126         to give buildbot its own module.
2127
2128         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
2129         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
2130         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
2131         * Scripts/webkitpy/common/net/failuremap.py:
2132         * Scripts/webkitpy/common/net/regressionwindow.py:
2133         * Scripts/webkitpy/tool/commands/rebaseline.py:
2134
2135 2010-12-10  Tony Chang  <tony@chromium.org>
2136
2137         Reviewed by Eric Seidel.
2138
2139         Use FileSystem::remove when cleaning up http lock files
2140         https://bugs.webkit.org/show_bug.cgi?id=50830
2141
2142         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2143
2144 2010-12-10  Joone Hur  <joone@kldp.org>
2145
2146         Reviewed by Martin Robinson.
2147
2148         [GTK] DRT needs layoutTestController.setCacheModel
2149         https://bugs.webkit.org/show_bug.cgi?id=50705
2150         
2151         webkit_set_cache_mode() is called to set the cache model.
2152         
2153         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2154         (LayoutTestController::setCacheModel): Set the cache model. 
2155
2156 2010-12-10  Tony Chang  <tony@chromium.org>
2157
2158         Reviewed by Ojan Vafai.
2159
2160         [chromium] remove --use-drt and add --use-test-shell
2161         https://bugs.webkit.org/show_bug.cgi?id=50701
2162
2163         * Scripts/webkitpy/common/config/ports.py:
2164         * Scripts/webkitpy/common/config/ports_unittest.py:
2165         * Scripts/webkitpy/layout_tests/port/chromium.py:
2166         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2167         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2168         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2169         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2170         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2171         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2172         * Scripts/webkitpy/layout_tests/port/webkit.py:
2173         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2174         * Scripts/webkitpy/style/checkers/test_expectations.py:
2175         * Scripts/webkitpy/tool/commands/queries.py:
2176
2177 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
2178
2179         Reviewed by Steve Block.
2180
2181         [Chromium] Implement mocks for client-based geolocation
2182         https://bugs.webkit.org/show_bug.cgi?id=46895
2183
2184         * DumpRenderTree/chromium/LayoutTestController.cpp:
2185         (LayoutTestController::setGeolocationPermission):
2186         (LayoutTestController::setMockGeolocationPosition):
2187         (LayoutTestController::setMockGeolocationError):
2188         * DumpRenderTree/chromium/LayoutTestController.h:
2189         * DumpRenderTree/chromium/WebViewHost.cpp:
2190         (WebViewHost::geolocationClient):
2191         (WebViewHost::geolocationClientMock):
2192         (WebViewHost::reset):
2193         * DumpRenderTree/chromium/WebViewHost.h:
2194
2195 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
2196
2197         Reviewed by Martin Robinson.
2198
2199         [GTK] Add hasSpellingMarker support to the DRT
2200         https://bugs.webkit.org/show_bug.cgi?id=50739
2201
2202         Implemented the hasSpellingMarker to support spelling tests.
2203
2204         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2205         (LayoutTestController::hasSpellingMarker):
2206
2207 2010-12-10  Eric Seidel  <eric@webkit.org>
2208
2209         Reviewed by Ojan Vafai.
2210
2211         webkit-patch: not possible to use build-and-test with local commits
2212         https://bugs.webkit.org/show_bug.cgi?id=33378
2213
2214         Make --no-clean not even check if we have local commits.
2215         It's unclear to me why the code was originally written this way.
2216         I was unable to dig up a reason from svn history.
2217
2218         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2219         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2220
2221 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
2222
2223         Reviewed by Martin Robinson.
2224
2225         [GTK] AX: implement isEnabled in DRT
2226         https://bugs.webkit.org/show_bug.cgi?id=50814
2227
2228         Implement AccessibilityUIElement::isEnabled() for GTK.
2229
2230         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2231         (checkElementState): New function to refactor common code.
2232         (AccessibilityUIElement::isEnabled): Implement this by checking
2233         the current state of the AtkObject.
2234         (AccessibilityUIElement::isSelected): Use the new
2235         checkElementState function.
2236
2237 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2238
2239         Reviewed by Kenneth Rohde Christiansen.
2240
2241         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
2242         https://bugs.webkit.org/show_bug.cgi?id=50750
2243
2244         * MiniBrowser/qt/BrowserView.cpp:
2245         (BrowserView::BrowserView):
2246         * MiniBrowser/qt/BrowserView.h:
2247         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2248         (WTR::WebView::WebView):
2249
2250 2010-12-10  Joone Hur  <joone@kldp.org>
2251
2252         Reviewed by Xan Lopez.
2253
2254         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
2255         https://bugs.webkit.org/show_bug.cgi?id=50808
2256
2257         Unskipping the following test cases:
2258         userscripts/mixed-case-stylesheet.html
2259         userscripts/simple-stylesheet.html
2260         userscripts/user-style-all-frames.html
2261
2262         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2263         (LayoutTestController::addUserStyleSheet):
2264
2265 2010-12-10  Joone Hur  <joone@kldp.org>
2266
2267         Reviewed by Eric Seidel.
2268
2269         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
2270         https://bugs.webkit.org/show_bug.cgi?id=50783
2271
2272         This patch allows to unskip the following test cases:
2273         printing/page-rule-selection.html
2274         printing/page-format-data.html
2275
2276         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2277         (LayoutTestController::pageProperty): Added.
2278         (LayoutTestController::isPageBoxVisible): Ditto.
2279         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
2280         (LayoutTestController::addUserStyleSheet): Ditto.
2281
2282 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2283
2284         Reviewed by Kenneth Rohde Christiansen.
2285
2286         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
2287
2288         A menu allows to switch QNAM back to the same thread.
2289
2290         * QtTestBrowser/launcherwindow.cpp:
2291         (LauncherWindow::initializeView):
2292         (LauncherWindow::createChrome):
2293         (LauncherWindow::toggleThreadedQnam):
2294         * QtTestBrowser/launcherwindow.h:
2295         (WindowOptions::WindowOptions):
2296         * QtTestBrowser/webpage.cpp:
2297         (WebPage::WebPage):
2298         (WebPage::setQnamThreaded):
2299         * QtTestBrowser/webpage.h:
2300         (QnamThread::QnamThread):
2301         (QnamThread::~QnamThread):
2302         (QnamThread::networkAccessManager):
2303         (QnamThread::run):
2304
2305 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
2306
2307         Reviewed by Xan Lopez.
2308
2309         [Gtk] style="font-family: courier" makes text disappear
2310         https://bugs.webkit.org/show_bug.cgi?id=47452
2311
2312         Add a test that verifies that fonts without valid charmaps are
2313         never selected.
2314
2315         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2316         (initializeFonts): Initialize DRT with our font (derived from Ahem)
2317         that has no valid charmap.
2318         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
2319         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
2320         settings which may disable selection of bitmap fonts.
2321
2322 2010-12-10  Eric Seidel  <eric@webkit.org>
2323
2324         Unreviewed.
2325
2326         The commit-queue should file bugs about flaky tests it encounters
2327         https://bugs.webkit.org/show_bug.cgi?id=50803
2328
2329         create_bug_for_flaky_test was insufficiently tested, thus buggy.
2330         Now it's tested.
2331
2332         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2333         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2334
2335 2010-12-10  Eric Seidel  <eric@webkit.org>
2336
2337         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
2338
2339         The commit-queue should file bugs about flaky tests it encounters
2340         https://bugs.webkit.org/show_bug.cgi?id=50803
2341
2342         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2343
2344 2010-12-09  Eric Seidel  <eric@webkit.org>
2345
2346         Reviewed by Adam Barth.
2347
2348         The commit-queue should file bugs about flaky tests it encounters
2349         https://bugs.webkit.org/show_bug.cgi?id=50803
2350
2351         This change got a bit big.  I also added a new config.urls file
2352         because I needed to share the view_source_url code with committervalidator.py.
2353
2354         This adds a new class FlakyTestReporter which holds all the logic about
2355         reporting flaky tests to bugzilla.
2356
2357         Right now this code knows how to look up bugs for flaky tests.
2358         If it can't find a bug filed from the commit-queue, it will open a new
2359         one, ccing the relevant people and adding information about the failure.
2360
2361         It is not yet smart enough to chase down duplicate chains, or to include
2362         the actual failure diff.  But those can be added in later iterations.
2363
2364         * Scripts/webkitpy/common/checkout/api.py:
2365         * Scripts/webkitpy/common/checkout/changelog.py:
2366         * Scripts/webkitpy/common/checkout/commitinfo.py:
2367         * Scripts/webkitpy/common/config/committervalidator.py:
2368         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
2369         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2370         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
2371         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
2372         * Scripts/webkitpy/tool/bot/irc_command.py:
2373         * Scripts/webkitpy/tool/bot/sheriff.py:
2374         * Scripts/webkitpy/tool/commands/download.py:
2375         * Scripts/webkitpy/tool/commands/queues.py:
2376         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2377         * Scripts/webkitpy/tool/comments.py:
2378         * Scripts/webkitpy/tool/mocktool.py:
2379         * Scripts/webkitpy/tool/steps/commit.py:
2380
2381 2010-12-09  Eric Seidel  <eric@webkit.org>
2382
2383         Reviewed by Adam Barth.
2384
2385         Teach webkit-patch how to search bugzilla
2386         https://bugs.webkit.org/show_bug.cgi?id=50500
2387
2388         This is a step towards teaching webkitpy how to file
2389         new bugs for flaky tests and update them when new flakes occur.
2390
2391         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2392         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2393         * Scripts/webkitpy/tool/commands/__init__.py:
2394         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
2395
2396 2010-12-09  Adam Barth  <abarth@webkit.org>
2397
2398         Reviewed by Ojan Vafai.
2399
2400         commit-queue errors out due to local commits
2401         https://bugs.webkit.org/show_bug.cgi?id=50766
2402
2403         We seem to be tripping over having local commits in the working copy a
2404         lot recently.  I don't quite fully understand what the issue is, but
2405         this patch attempts to solve the problem by adding an explicit clean
2406         step before processing a patch.  Previously, we did the cleaning as
2407         part of the apply-attachment step, so this might not actually fix the
2408         problem.
2409
2410         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2411         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2412         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2413
2414 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
2415
2416         Reviewed by Ojan Vafai.
2417
2418         Make new-run-webkit-tests --lint-test-files log slightly better
2419         messages and return -1 if lint fails. Remove the
2420         'suppress_errors' keyword param to the TestExpectationsFile
2421         class, and clean up logging and exception raising for error
2422         handling. Also add more unit tests and clean up the unit test code a bit.
2423
2424         https://bugs.webkit.org/show_bug.cgi?id=50205
2425
2426         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2427         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2428         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
2429         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
2430         * Scripts/webkitpy/layout_tests/port/chromium.py:
2431         * Scripts/webkitpy/style/checkers/test_expectations.py:
2432         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2433
2434 2010-12-09  Tony Chang  <tony@chromium.org>
2435
2436         Unreviewed, fix for windows code.  We were catching the wrong
2437         exception in Windows.
2438
2439         * Scripts/webkitpy/common/system/filesystem.py:
2440
2441 2010-12-09  Antonio Gomes  <agomes@rim.com>
2442
2443         Reviewed by Martin Robinson.
2444
2445         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
2446         https://bugs.webkit.org/show_bug.cgi?id=48429
2447
2448         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
2449
2450         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2451         (LayoutTestController::workerThreadCount):
2452
2453 2010-12-06  Philippe Normand  <pnormand@igalia.com>
2454
2455         Reviewed by Martin Robinson.
2456
2457         [GTK] Support the Mozilla-style Fullscreen Javascript API
2458         https://bugs.webkit.org/show_bug.cgi?id=50572
2459
2460         Enable the Javascript Fullscreen support in the GtkLauncher. Also
2461         make DRT update the Chrome when the WebView settings have been
2462         reset to consistent values.
2463
2464         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2465         (resetDefaultsToConsistentValues):
2466         * GtkLauncher/main.c:
2467         (create_window):
2468         * Scripts/build-webkit:
2469
2470 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
2471
2472         Reviewed by Tor Arne Vestbø
2473
2474         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
2475         https://bugs.webkit.org/show_bug.cgi?id=50742
2476
2477         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
2478
2479         * Scripts/webkitdirs.pm:
2480
2481 2010-12-09  Joone Hur  <joone@kldp.org>
2482
2483          Reviewed by Martin Robinson.
2484
2485          [GTK] Support for viewport meta tag
2486          https://bugs.webkit.org/show_bug.cgi?id=45443
2487
2488          Add support for testing the viewport properties for WebKitGtk.
2489
2490          * DumpRenderTree/LayoutTestController.cpp:
2491          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
2492          (LayoutTestController::staticFunctions):
2493          * DumpRenderTree/LayoutTestController.h:
2494          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2495          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
2496          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2497          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2498          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2499          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2500          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2501          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2502          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2503          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2504
2505 2010-12-08  William Siegrist <wsiegrist@apple.com>
2506
2507         Reviewed by Eric Seidel.
2508
2509         Migrate buildbot.py from xmlrpc to json.
2510         https://bugs.webkit.org/show_bug.cgi?id=50647
2511
2512         * Scripts/webkitpy/common/net/buildbot.py:
2513
2514 2010-12-08  Tony Chang  <tony@chromium.org>
2515
2516         Reviewed by Eric Seidel.
2517
2518         make starting the websocket server more reliable on windows
2519         https://bugs.webkit.org/show_bug.cgi?id=50712
2520
2521         * Scripts/webkitpy/common/system/filesystem.py:
2522         (remove): Substitute method for os.remove to retry on error on Windows
2523         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2524         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
2525
2526 2010-12-08  Jessie Berlin  <jberlin@apple.com>
2527
2528         Reviewed by Adam Roben.
2529
2530         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
2531         https://bugs.webkit.org/show_bug.cgi?id=50656
2532
2533         * MiniBrowser/mac/BrowserWindowController.m:
2534         (-[BrowserWindowController awakeFromNib]):
2535         Indicate that exceededDatabaseQuota is not implemented.
2536         * MiniBrowser/win/BrowserView.cpp:
2537         (BrowserView::create):
2538         Ditto.
2539         * WebKitTestRunner/TestController.cpp:
2540         (WTR::createOtherPage):
2541         Ditto.
2542         (WTR::TestController::initialize):
2543         Ditto.
2544
2545 2010-12-08  Antonio Gomes  <agomes@rim.com>
2546
2547         Reviewed by Martin Robinson.
2548
2549         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
2550         https://bugs.webkit.org/show_bug.cgi?id=48429
2551
2552         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
2553         * webkit_gc_collect_javascript_objects;
2554         * webkit_gc_collect_javascript_objects_on_alternate_thread;
2555         * webkit_gc_count_javascript_objects;
2556         * webkit_web_frame_layout.
2557
2558         These were all only used by GTK+ DRT.
2559
2560         * DumpRenderTree/gtk/EventSender.cpp:
2561         (dispatchEvent):
2562         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2563         (GCController::collect):
2564         (GCController::collectOnAlternateThread):
2565         (GCController::getJSObjectCount):
2566
2567 2010-12-07  Tony Chang  <tony@chromium.org>
2568
2569         Reviewed by Ojan Vafai.
2570
2571         [chromium] force NRWT to use DRT
2572         https://bugs.webkit.org/show_bug.cgi?id=50359
2573
2574         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2575
2576 2010-12-06  Sam Weinig  <sam@webkit.org>
2577
2578         Reviewed by Anders Carlsson.
2579
2580         Generalize didChangeLocationWithinPageForFrame for all same document navigations
2581         https://bugs.webkit.org/show_bug.cgi?id=50584
2582
2583         * MiniBrowser/mac/BrowserWindowController.m:
2584         (didSameDocumentNavigationForFrame):
2585         (-[BrowserWindowController awakeFromNib]):
2586         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
2587         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2588         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2589         (TestWebKitAPI::TEST):
2590         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2591         (WTR::InjectedBundlePage::InjectedBundlePage):
2592         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
2593         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2594         * WebKitTestRunner/TestController.cpp:
2595         (WTR::TestController::initialize):
2596
2597 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
2598
2599         Reviewed by Ojan Vafai.
2600
2601         Make TestResultsServer return 404 for non-existing results files.
2602         https://bugs.webkit.org/show_bug.cgi?id=50581
2603
2604         * TestResultServer/handlers/testfilehandler.py:
2605
2606 2010-12-06  Tony Chang  <tony@chromium.org>
2607
2608         Reviewed by Ojan Vafai.
2609
2610         [chromium] fix an assert hit in DRT
2611         https://bugs.webkit.org/show_bug.cgi?id=50575
2612
2613         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
2614         semantics.
2615
2616         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
2617         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
2618         WTF::RefCountedBase::ref()).
2619
2620         * DumpRenderTree/chromium/TestWebWorker.h:
2621         (TestWebWorker::TestWebWorker):
2622
2623 2010-12-02  Ojan Vafai  <ojan@chromium.org>
2624
2625         Reviewed by Eric Seidel.
2626
2627         make webkit-patch command work when the git branch is not synced to the remote svn branch
2628         https://bugs.webkit.org/show_bug.cgi?id=50424
2629
2630         * Scripts/webkitpy/common/checkout/scm.py:
2631         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2632
2633 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
2634
2635         Reviewed by Andreas Kling.
2636
2637         [WINCE] Add build system
2638         https://bugs.webkit.org/show_bug.cgi?id=50522
2639
2640         * CMakeListsWinCE.txt: Added.
2641
2642 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2643
2644         Reviewed by Tony Chang.
2645
2646         Allow the Chromium port to have Leopard-specific baselines
2647         https://bugs.webkit.org/show_bug.cgi?id=50506
2648
2649         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2650
2651 2010-12-03  Tony Chang  <tony@chromium.org>
2652
2653         Reviewed by Kent Tamura.
2654
2655         [chromium] fix 2 bugs with inspector tests in DRT
2656         https://bugs.webkit.org/show_bug.cgi?id=50492
2657
2658         Tasks can outlive the tasklist (even when canceled) so this was
2659         causing a crash when ~WebTask() ran.  Avoid this by unregistering
2660         when a task is canceled.
2661
2662         Also fix an assert when closing devtool windows by copying some
2663         logic from test_shell.
2664
2665         * DumpRenderTree/chromium/Task.cpp:
2666         (WebTask::~WebTask):
2667         (TaskList::revokeAll):
2668         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
2669             the tasklist (since the task can outlive the tasklist).
2670         * DumpRenderTree/chromium/TestShell.h:
2671         (TestShell::devToolsWebView):
2672         * DumpRenderTree/chromium/WebViewHost.cpp:
2673         (WebViewHost::~WebViewHost): Don't load about:blank when closing
2674             a window if the window has devtools loaded.  This avoids an
2675             ASSERT and matches test_shell.
2676
2677 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
2678
2679         Reviewed by Martin Robinson.
2680
2681         [GTK] Fix GtkLauncher.c style, use webkit style
2682         https://bugs.webkit.org/show_bug.cgi?id=50542
2683
2684         * GtkLauncher/main.c:
2685         (activateUriEntryCb):
2686         (updateTitle):
2687         (linkHoverCb):
2688         (notifyTitleCb):
2689         (notifyLoadStatusCb):
2690         (notifyProgressCb):
2691         (destroyCb):
2692         (goBackCb):
2693         (goForwardCb):
2694         (create_webViewCb):
2695         (webViewReadyCb):
2696         (closeWebViewCb):
2697         (createBrowser):
2698         (createStatusbar):
2699         (createToolbar):
2700         (createWindow):
2701         (main):
2702
2703 2010-12-04  Antonio Gomes  <agomes@rim.com>
2704
2705         Reviewed by Martin Robinson.
2706
2707         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
2708         https://bugs.webkit.org/show_bug.cgi?id=48429
2709
2710         Moved more private method declared with WEBKIT_API to
2711         DumpRenderTreeSupportGtk, since they were only being used by DRT.
2712
2713         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2714         (resetDefaultsToConsistentValues):
2715         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2716         (LayoutTestController::addOriginAccessWhitelistEntry):
2717         (LayoutTestController::execCommand):
2718         (LayoutTestController::isCommandEnabled):
2719
2720 2010-12-04  Antonio Gomes  <agomes@rim.com>
2721
2722         Reviewed by Andreas Kling.
2723
2724         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
2725
2726         Method was removed by http://trac.webkit.org/changeset/71604
2727
2728         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2729
2730 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
2731
2732         Reviewed by Xan Lopez.
2733
2734         [GTK] Fix compilation warnings reported by clang
2735         https://bugs.webkit.org/show_bug.cgi?id=50252
2736
2737         * GtkLauncher/main.c:
2738         (create_window): The create_statusbar function does not have
2739         parameters.
2740
2741 2010-12-05  Robert Hogan  <robert@webkit.org>
2742
2743         Reviewed by Andreas Kling.
2744
2745         [Qt] Zero-sized font does not yet work
2746
2747         Fix fast/text/font-size-zero.html
2748
2749         Copy other ports by setting minimumFontSize to 0 for DRT runs.
2750
2751         https://bugs.webkit.org/show_bug.cgi?id=49759
2752
2753         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2754         (WebCore::WebPage::WebPage):
2755
2756 2010-12-04  Sam Weinig  <sam@webkit.org>
2757
2758         Reviewed by Jon Honeycutt.
2759
2760         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
2761         https://bugs.webkit.org/show_bug.cgi?id=50511
2762
2763         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
2764         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
2765
2766         * MiniBrowser/mac/BrowserWindowController.m:
2767         (didChangeLocationWithinPageForFrame):
2768         (-[BrowserWindowController awakeFromNib]):
2769         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
2770         * TestWebKitAPI/PlatformUtilities.cpp:
2771         (TestWebKitAPI::Util::toWK):
2772         * TestWebKitAPI/PlatformUtilities.h:
2773         (TestWebKitAPI::Util::adoptWK):
2774         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2775         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2776         (TestWebKitAPI::nullJavaScriptCallback):
2777         (TestWebKitAPI::didFinishLoadForFrame):
2778         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2779         (TestWebKitAPI::TEST):
2780         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2781         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2782         * TestWebKitAPI/win/copy-resources.cmd:
2783         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2784         (WTR::InjectedBundlePage::InjectedBundlePage):
2785         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2786         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2787         * WebKitTestRunner/TestController.cpp:
2788         (WTR::TestController::initialize):
2789
2790 2010-11-08  Antonio Gomes  <agomes@rim.com>
2791
2792         Reviewed by Martin Robinson.
2793
2794         [Gtk] Populate DumpRenderTreeSupportGtk
2795         https://bugs.webkit.org/show_bug.cgi?id=48429
2796
2797         Made the previous calls to webkit_web_frame* functions defined as private
2798         APIs in webkitprivate.h go through DRTSupportGtk.
2799
2800         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2801         (AccessibilityController::focusedElement):
2802         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2803         (dumpFramesAsText):
2804         (resetDefaultsToConsistentValues):
2805         (dump):
2806         (webViewDocumentLoadFinished):
2807         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2808         (LayoutTestController::counterValueForElementById):
2809         (LayoutTestController::pageNumberForElementById):
2810         (LayoutTestController::numberOfPages):
2811         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2812         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2813         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2814         (LayoutTestController::numberOfActiveAnimations):
2815         (LayoutTestController::suspendAnimations):
2816         (LayoutTestController::resumeAnimations):
2817         (LayoutTestController::markerTextForListItem):
2818
2819 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2820
2821         Reviewed by Tony Chang.
2822
2823         Rebaseline server: use pretty text diff output
2824         https://bugs.webkit.org/show_bug.cgi?id=50484
2825         
2826         Serve *-pretty-diff.html for text diff output.
2827
2828         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2829         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2830         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2831         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2832
2833 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2834
2835         Unreviewed, rolling out r73302.
2836         http://trac.webkit.org/changeset/73302
2837         https://bugs.webkit.org/show_bug.cgi?id=50499
2838
2839         Causes crashes in debug LayoutTests (Requested by xan_ on
2840         #webkit).
2841
2842         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2843         (AccessibilityUIElement::AccessibilityUIElement):
2844         (AccessibilityUIElement::parentElementCallback):
2845         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2846         * DumpRenderTree/chromium/CppBoundClass.cpp:
2847         * DumpRenderTree/chromium/CppBoundClass.h:
2848
2849 2010-12-03  Sam Weinig  <sam@webkit.org>
2850
2851         Reviewed by Maciej Stachowiak.
2852
2853         Enable <a ping> for Mac/Windows/WebKit2 builds
2854         <rdar://problem/8504473>
2855         https://bugs.webkit.org/show_bug.cgi?id=50488
2856
2857         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2858         (TestWebKitAPI::TEST): Test that the default value of
2859         WKPreferencesGetHyperlinkAuditingEnabled is true.
2860
2861 2010-12-03  Chris Guillory  <chris.guillory@google.com>
2862
2863         Reviewed by Chris Fleizach.
2864
2865         Include the FrameView widget of a RenderWidget in the accessibility tree.
2866         https://bugs.webkit.org/show_bug.cgi?id=49106
2867
2868         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2869         (AccessibilityUIElement::AccessibilityUIElement):
2870         (AccessibilityUIElement::parentElementCallback):
2871         (AccessibilityUIElement::isEqualCallback):
2872         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2873         * DumpRenderTree/chromium/CppBoundClass.cpp:
2874         (CppBoundClass::getFromCppVariant):
2875         * DumpRenderTree/chromium/CppBoundClass.h:
2876
2877 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2878
2879         Reviewed by Tony Chang.
2880
2881         Rebaseline server: organize tests by state, add dry run mode
2882         https://bugs.webkit.org/show_bug.cgi?id=50473
2883         
2884         Group tests in the menu by state, so that it's easier to see after
2885         processing the queue which failed.
2886         
2887         Add support for the --dry-run flag so that it's easier to test changes
2888         such as this (stubs out filesystem and SCM operations).
2889
2890         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2891         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2892         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2893
2894 2010-12-03  Brady Eidson  <beidson@apple.com>
2895
2896         Reviewed by Anders Carlsson.
2897
2898         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
2899         WebKit2 Authentication Support
2900
2901         Keep these builds working:
2902         * MiniBrowser/mac/BrowserWindowController.m:
2903         (-[BrowserWindowController awakeFromNib]):
2904
2905         * WebKitTestRunner/TestController.cpp:
2906         (WTR::TestController::initialize):
2907
2908 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
2909
2910         Reviewed by Tony Chang.
2911
2912         Rebaseline server: move existing baselines
2913         https://bugs.webkit.org/show_bug.cgi?id=50421
2914         
2915         Implement moving of existing baselines: move all files that are about
2916         to be overwriten by update baselines.
2917         
2918         Also fix a typo in the UI JS.
2919
2920         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2921         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2922         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2923
2924 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2925
2926         Unreviewed, rolling out r73211.
2927         http://trac.webkit.org/changeset/73211
2928         https://bugs.webkit.org/show_bug.cgi?id=50450
2929
2930         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
2931         yutak on #webkit).
2932
2933         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2934
2935 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2936
2937         Unreviewed, rolling out r73222.
2938         http://trac.webkit.org/changeset/73222
2939         https://bugs.webkit.org/show_bug.cgi?id=50449
2940
2941         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2942         (Requested by yutak on #webkit).
2943
2944         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2945         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2946         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2947         * Scripts/webkitpy/layout_tests/port/base.py:
2948         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2949         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2950
2951 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2952
2953         Unreviewed, rolling out r73228.
2954         http://trac.webkit.org/changeset/73228
2955         https://bugs.webkit.org/show_bug.cgi?id=50448
2956
2957         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2958         (Requested by yutak on #webkit).
2959
2960         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2961         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2962         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2963         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2964         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2965
2966 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2967
2968         Unreviewed, rolling out r73231.
2969         http://trac.webkit.org/changeset/73231
2970         https://bugs.webkit.org/show_bug.cgi?id=50443
2971
2972         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
2973         (Requested by yutak on #webkit).
2974
2975         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2976         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2977         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2978         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2979
2980 2010-12-03  David Levin  <levin@chromium.org>
2981
2982         Reviewed by Shinichiro Hamaji.
2983
2984         check-webkit-style: false positive reported for #if macro
2985         https://bugs.webkit.org/show_bug.cgi?id=48242
2986
2987         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
2988           all preprocessor commands.
2989         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2990
2991 2010-12-02  Eric Seidel  <eric@webkit.org>
2992
2993         Reviewed by Adam Barth.
2994
2995         Update the EWSTools scripts to use modern-style git repos
2996         https://bugs.webkit.org/show_bug.cgi?id=50402
2997
2998         * EWSTools/create-webkit-git:
2999         * EWSTools/start-commit-queue.sh:
3000         * EWSTools/start-queue.sh:
3001
3002 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
3003
3004         Fix Chromium Linux plugin tests by not logging
3005         unconditionally from the event handling code.
3006
3007         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3008         (handleEventX11):
3009
3010 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
3011
3012         Reviewed by Tony Chang.
3013
3014         nrwt multiprocessing - move logic back into run_webkit_tests
3015
3016         This change moves a bunch of logic that I had put into
3017         message_broker back into run_webkit_tests, in a slightly
3018         different format. WorkerMessageBroker needed to become less aware of
3019         the logic the TestRunner class uses, and more generic.
3020         Eventually the MessageBroker will only do generic messaging and
3021         thread/process-pooling, and (almost) all of the
3022         run-webkit-tests-specific logic will be moved to
3023         run_webkit_tests.py and dump_render_tree_thread.py.
3024         
3025         The biggest changes are that the Broker can now start a single
3026         worker, but the responsibility for starting all of them is pushed
3027         back to the TestRunner (Manager), and the logic for checking if
3028         the threads are done or wedged is moved back to TestRunner. We
3029         also remove WorkerMessageBroker.cleanup (not needed) and
3030         cancel_workers (they have to be cancelled individually).
3031         
3032         The  message_broker is now encapsulated inside
3033         TestRunner._run_tests(); it only needs to exist while actually
3034         running the tests.
3035
3036         Also, delete a bunch of tests in message_broker_unittest that no
3037         longer make much sense.
3038
3039         This patch depends on bug 50372.
3040
3041         https://bugs.webkit.org/show_bug.cgi?id=50374
3042
3043         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3044         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3045         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3046         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3047         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3048
3049 2010-12-02  Hayato Ito  <hayato@chromium.org>
3050
3051         Reviewed by Eric Seidel.
3052
3053         Refactor test_types's compare_output() method so that it takes a
3054         TestInput object.
3055
3056         compare_output() will need additional information included in a TestInput
3057         object to support reftests. This change is a pre-requirement of that.
3058
3059         https://bugs.webkit.org/show_bug.cgi?id=50362
3060
3061         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3062         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3063         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3064         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
3065         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3066
3067 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
3068
3069         Reviewed by Anders Carlsson.
3070
3071         Add the ability to run script on 'new' and 'paint' in the test plugin
3072         https://bugs.webkit.org/show_bug.cgi?id=50425
3073         
3074         Add "onnew" and "onpaintevent" attributes to the test plugin,
3075         so that tests can run JS at these times.
3076
3077         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3078         (pluginAllocate):
3079         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3080         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3081         (NPP_New):
3082         (NPP_Destroy):
3083         (handleEventCarbon):
3084         (handleEventCocoa):
3085         (NPP_HandleEvent):
3086
3087 2010-12-02  Sam Weinig  <sam@webkit.org>
3088
3089         Fix Qt build.
3090
3091         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3092         (WTR::PlatformWebView::PlatformWebView):
3093
3094 2010-12-02  Sam Weinig  <sam@webkit.org>
3095
3096         Reviewed by Anders Carlsson.
3097
3098         WebKit2 Preferences should be held off the PageGroup, not the Context
3099         https://bugs.webkit.org/show_bug.cgi?id=50414
3100
3101         Update for API changes.
3102
3103         * WebKitTestRunner/PlatformWebView.h:
3104         * WebKitTestRunner/TestController.cpp:
3105         (WTR::createOtherPage):
3106         (WTR::TestController::initialize):
3107         (WTR::TestController::resetStateToConsistentValues):
3108         * WebKitTestRunner/TestController.h:
3109         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3110         (WTR::PlatformWebView::PlatformWebView):
3111         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3112         (WTR::PlatformWebView::PlatformWebView):
3113
3114 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
3115
3116         Reviewed by Tony Chang.
3117
3118         new-run-webkit-tests: minor cleanup for multiprocessing work
3119
3120         This change:
3121         * moves worker naming into TestShellThread, eliminating a
3122           parameter to the constructor and putting the responsibility in
3123           the correct place.
3124         * eliminates the _WorkerState() class in message_broker, because
3125           it turns out that state really needs to be in run_webkit_tests
3126         * renames the Broker classes to be module-private.
3127         * fixes a bunch of minor commenting and whitespace issues to
3128           make subsequent patches a bit clearer.
3129         * Adds a Port hook for default_worker_model() so that we can
3130           accomodate the potential for different worker models on
3131           different ports.
3132         * merge in the fix from 50420 for the brokenness introduced in
3133           bug 50367.
3134
3135         This patch depends on bug 50367.
3136
3137         https://bugs.webkit.org/show_bug.cgi?id=50372
3138
3139         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3140         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3141         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3142         * Scripts/webkitpy/layout_tests/port/base.py:
3143         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3144         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3145
3146 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
3147
3148         Reviewed by Tony Chang.
3149
3150         This change is a bunch of cleanup / refactoring of the file
3151         below. It moves a bunch of free functions to methods on the
3152         TestShellThread class, and restructures other methods to be
3153         closer to the structure we'll need for the multiprocessing
3154         rewrite.
3155
3156         It also makes the logic of --run-singly a *lot* easier to follow
3157         by nestling all of the separate-thread logic into a single
3158         routine.
3159
3160         There should be no semantic changes in this patch, just cleanup.
3161
3162         https://bugs.webkit.org/show_bug.cgi?id=50367
3163
3164         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3165
3166 2010-12-02  Tony Chang  <tony@chromium.org>
3167
3168         Unreviewed, rolling out r73164.
3169         http://trac.webkit.org/changeset/73164
3170         https://bugs.webkit.org/show_bug.cgi?id=50359
3171
3172         broke debugger tests on win
3173
3174         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3175
3176 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
3177
3178         Reviewed by Tony Chang.
3179
3180         Rebaseline server: add updating of baselines
3181         https://bugs.webkit.org/show_bug.cgi?id=50305
3182         
3183         Implements updating of baselines, where we copy -actual.* files over
3184         the current -expected.* files. To do this, we need a
3185         _get_actual_result_files method to get test results files and a
3186         _rebaseline_test method to actually do the file copy and SCM operation.
3187         _rebaseline_test logs output into a buffer, this is useful for both
3188         showing result in the UI and for unit tests.
3189         
3190         To make passing around of the various test environment properties
3191         (results directory, filesystem, SCM, etc) easier, add a TestConfig
3192         class for them.
3193         
3194         Moving of existing baselines is not implemented yet, this patch is big
3195         enough as it is.
3196
3197         * Scripts/webkitpy/common/system/filesystem.py:
3198         * Scripts/webkitpy/common/system/filesystem_mock.py:
3199         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3200         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3201         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
3202         * Scripts/webkitpy/tool/mocktool.py:
3203
3204 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
3205
3206         Unreviewed build fix after vcproj updates.
3207
3208         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
3209         that WIN_CAIRO is defined for this build.
3210         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
3211         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
3212         (these were previously 'Debug_Cairo' and 'Release_Cairo'
3213
3214 2010-12-02  Sam Weinig  <sam@webkit.org>
3215
3216         Reviewed by Anders Carlsson.
3217
3218         WebKit2 needs API to turn on popup blocking
3219         https://bugs.webkit.org/show_bug.cgi?id=50407
3220
3221         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3222         (TestWebKitAPI::TEST):
3223         * WebKitTestRunner/TestController.cpp:
3224         (WTR::TestController::resetStateToConsistentValues):
3225
3226 2010-12-01  Tony Chang  <tony@chromium.org>
3227
3228         Reviewed by Ojan Vafai.
3229
3230         [chromium] force NRWT to use DRT
3231         https://bugs.webkit.org/show_bug.cgi?id=50359
3232
3233         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3234
3235 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
3236
3237         Reviewed by Xan Lopez.
3238
3239         [GTK] DumpRenderTree has two copies of JavaScriptCore
3240         https://bugs.webkit.org/show_bug.cgi?id=49877
3241
3242         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
3243         LDADD list for DumpRenderTree.
3244
3245 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
3246
3247         Unreviewed: Added myself to list of Committers.
3248
3249         * Scripts/webkitpy/common/config/committers.py:
3250
3251 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
3252
3253         Reviewed by Adam Barth.
3254
3255         build-webkit --chromium always updates DEPS and re-generates project files
3256         https://bugs.webkit.org/show_bug.cgi?id=50340
3257         
3258         Make build-webkit --chromium invoke update-webkit-chromium only when
3259         --update-chromium is passed in, so that we don't add 20 seconds to all
3260         builds.
3261         
3262         Making all invocations update was added with r61883, with the goal of
3263         making EWS bots always update. The bots will switch to using this flag
3264         (as will all other webkit-patch build steps) so nothing should change
3265         for them.
3266
3267         * Scripts/webkitdirs.pm:
3268         * Scripts/webkitpy/common/config/ports.py:
3269         * Scripts/webkitpy/common/config/ports_unittest.py:
3270
3271 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
3272
3273         Reviewed by Tony Chang.
3274
3275         new-run-webkit-tests: add a --dry-run / -n flag
3276         https://bugs.webkit.org/show_bug.cgi?id=50045
3277
3278         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3279         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3280
3281 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3282
3283         Reviewed by Adam Roben.
3284
3285         WinCairo build should not use link-time code generation (LTCG)
3286         https://bugs.webkit.org/show_bug.cgi?id=50353
3287
3288         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3289         * DumpRenderTree/win/DumpRenderTree.vcproj:
3290         * DumpRenderTree/win/ImageDiff.vcproj:
3291         * FindSafari/FindSafari.vcproj:
3292         * MiniBrowser/MiniBrowser.vcproj:
3293         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3294         * WebKitAPITest/WebKitAPITest.vcproj:
3295         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3296         * WebKitTestRunner/win/InjectedBundle.vcproj:
3297         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3298         * WinLauncher/WinLauncher.vcproj:
3299         * record-memory-win/record-memory-win.vcproj:
3300
3301 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
3302
3303         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
3304         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
3305         adding the file to the sources list was not enough to force the rebuild.
3306
3307         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
3308         Remove an empty line at the end of this file to force a rebuild.
3309
3310 2010-12-01  Sam Weinig  <sam@webkit.org>
3311
3312         Fix windows build.
3313
3314         * MiniBrowser/win/BrowserView.cpp:
3315         (BrowserView::create):
3316
3317 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
3318
3319         Add missing file to the TestNetscapePlugin sources list after r73057.
3320
3321         * GNUmakefile.am: Add missing file.
3322
3323 2010-12-01  Sam Weinig  <sam@webkit.org>
3324
3325         Reviewed by Anders Carlsson.
3326
3327         Add PageGrouping to WebKit2 API
3328         https://bugs.webkit.org/show_bug.cgi?id=50332
3329
3330         - Update testing harnesses to deal with new PageGroup API.
3331
3332         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3333         (WKBundleInitialize):
3334         * TestWebKitAPI/InjectedBundleController.cpp:
3335         (TestWebKitAPI::InjectedBundleController::initialize):
3336         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
3337         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
3338         * TestWebKitAPI/InjectedBundleController.h:
3339         * TestWebKitAPI/InjectedBundleTest.h:
3340         (TestWebKitAPI::InjectedBundleTest::initialize):
3341         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
3342         * TestWebKitAPI/PlatformUtilities.cpp:
3343         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3344         * TestWebKitAPI/PlatformUtilities.h:
3345         * TestWebKitAPI/PlatformWebView.h:
3346         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3347         (TestWebKitAPI::TEST):
3348         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3349         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
3350         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3351         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3352         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3353         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3354         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3355         (WTR::InjectedBundle::didInitializePageGroup):
3356         (WTR::InjectedBundle::initialize):
3357         (WTR::InjectedBundle::beginTesting):
3358         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3359         (WTR::InjectedBundle::pageGroup):
3360         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3361         (WTR::LayoutTestController::addUserScript):
3362         (WTR::LayoutTestController::addUserStyleSheet):
3363         (WTR::LayoutTestController::setXSSAuditorEnabled):
3364         * WebKitTestRunner/TestController.cpp:
3365         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3366         (WTR::PlatformWebView::PlatformWebView):
3367
3368 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3369
3370         Reviewed by Adam Roben.
3371
3372         vcproj changes can't be applied cleanly by the Windows EWS bot
3373         https://bugs.webkit.org/show_bug.cgi?id=50328
3374
3375         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3376         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
3377         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3378         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
3379         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
3380         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
3381         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
3382         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
3383         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
3384         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
3385         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
3386         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
3387         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
3388         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3389         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
3390         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
3391         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
3392         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
3393         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
3394         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
3395         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
3396         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
3397         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
3398         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
3399         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
3400         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
3401         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
3402         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
3403         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
3404         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
3405         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
3406         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
3407         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
3408         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
3409         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
3410         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
3411         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
3412         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
3413         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
3414         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
3415         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
3416         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
3417         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
3418         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
3419         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
3420
3421 2010-12-01  Anders Carlsson  <andersca@apple.com>
3422
3423         Reviewed by Darin Adler.
3424
3425         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
3426         https://bugs.webkit.org/show_bug.cgi?id=50336
3427
3428         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3429         Add new test.
3430
3431         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3432         (PluginTest::NPP_New):
3433         Add default implementation/
3434
3435         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3436         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
3437         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
3438         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
3439         Get the user agent.
3440
3441         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3442         (NPP_New):
3443         Call PluginTest::NPP_New.
3444
3445         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3446         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3447         Add new files.
3448
3449         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3450         (webkit_test_plugin_new_instance):
3451         Call PluginTest::NPP_New.
3452
3453 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
3454
3455         [wx] Build fixes after recent trunk changes.
3456
3457         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3458         (LayoutTestController::findString):
3459         * wx/build/settings.py:
3460
3461 2010-12-01  Dan Bernstein  <mitz@apple.com>
3462
3463         Reviewed by Darin Adler.
3464
3465         WebKitTestRunner needs layoutTestController.findString
3466         https://bugs.webkit.org/show_bug.cgi?id=50238
3467
3468         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
3469         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3470         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
3471         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
3472
3473 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3474
3475         Try using svn:eol-style native on a vcproj file.
3476
3477         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
3478
3479 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
3480
3481         Reviewed by Adam Roben.
3482
3483         [WINCE] Add WinCELauncher
3484         https://bugs.webkit.org/show_bug.cgi?id=50217
3485
3486         * WinCELauncher/main.cpp: Added.
3487
3488 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
3489
3490         Reviewed by Kenneth Rohde Christiansen.
3491
3492         [Qt] Implement layoutTestController.findString
3493         https://bugs.webkit.org/show_bug.cgi?id=50236
3494
3495         Add the missing function to the LayoutTestController.
3496
3497         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3498         (LayoutTestController::findString):
3499         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3500
3501 2010-11-30  Tony Chang  <tony@chromium.org>
3502
3503         Reviewed by Adam Barth.
3504
3505         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
3506         https://bugs.webkit.org/show_bug.cgi?id=49036
3507
3508         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
3509             for CppVariants.
3510         (LayoutTestController::cppVariantToBool):
3511         (LayoutTestController::cppVariantToInt32):
3512         (LayoutTestController::setDatabaseQuota):
3513         (LayoutTestController::evaluateInWebInspector):
3514         (LayoutTestController::setMockGeolocationError):
3515
3516 2010-11-30  Eric Seidel  <eric@webkit.org>
3517
3518         Reviewed by Tony Chang.
3519
3520         update-webkit should call git fetch before git svn rebase
3521         https://bugs.webkit.org/show_bug.cgi?id=50273
3522
3523         After discussion on webkit-dev, we've decided to move the "default"
3524         git setup to pulling updates from git.webkit.org in preference
3525         to rebuilding the local svn index using git svn fetch every time.
3526
3527         This change should have no effect on people using the "old" git setup
3528         and should dramatically increase the speed of updates for those using
3529         the "new" git setup along with update-webkit.  I'm about to move the
3530         EWS and other queues over to this setup once this lands.
3531
3532         * Scripts/update-webkit:
3533
3534 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
3535
3536         Reviewed by Xan Lopez.
3537
3538         GTK: AX: implement press in DRT
3539         https://bugs.webkit.org/show_bug.cgi?id=36146
3540
3541         Implement AccessibilityUIElement::press() for GTK.
3542
3543         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3544         (AccessibilityUIElement::press): Implemented.
3545
3546 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
3547
3548         Reviewed by Tony Chang.
3549
3550         config.webkit_base_dir returns a path with a trailing slash
3551         https://bugs.webkit.org/show_bug.cgi?id=50197
3552         
3553         config.webkit_base_dir() should return a path without a trailing slash,
3554         like all the other methods that return paths.
3555         
3556         Undoes MockFileSytem changes by r72640, since they're no longer
3557         necessary for GetBaselinesTest to pass.
3558
3559         * Scripts/webkitpy/common/system/filesystem_mock.py:
3560         * Scripts/webkitpy/layout_tests/port/base.py:
3561         * Scripts/webkitpy/layout_tests/port/config.py:
3562         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3563
3564 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
3565
3566         Reviewed by Tony Chang.
3567
3568         Rebaseline server: baseline display tweaks
3569         https://bugs.webkit.org/show_bug.cgi?id=50207
3570         
3571         Determine which baselines were used when running the tests and highlight
3572         them in the UI. Sort platform names alphabetically.
3573         
3574         Also makes the server URL be launched in the user's browser
3575         automatically.
3576
3577         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3578         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3579         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3580         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3581         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
3582
3583 2010-11-30  Dan Bernstein  <mitz@apple.com>
3584
3585         Reviewed by Anders Carlsson.
3586
3587         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
3588         https://bugs.webkit.org/show_bug.cgi?id=50238
3589
3590         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3591         (WTR::LayoutTestController::findString): Added.
3592         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3593
3594 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
3595
3596         Reviewed by Adam Roben.
3597
3598         All projects on Windows should use cmd files for build events
3599         https://bugs.webkit.org/show_bug.cgi?id=50213
3600
3601         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3602         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
3603         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
3604         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3605         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
3606         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
3607         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3608         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
3609         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
3610         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
3611         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3612         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
3613         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
3614         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
3615         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3616         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
3617         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
3618         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3619         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
3620         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
3621         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3622         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3623         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
3624         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
3625         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
3626         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
3627         * WinLauncher/WinLauncherCommon.vsprops:
3628         * WinLauncher/WinLauncherPostBuild.cmd: Added.
3629         * WinLauncher/WinLauncherPreBuild.cmd: Added.
3630
3631 2010-11-29  Dan Bernstein  <mitz@apple.com>
3632
3633         GTK DumpRenderTree build fix after r72887.
3634
3635         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: