Tools/ChangeLog

   1 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
   2
   3         Unreviewed fix after r75908.
   4
   5         Move WebKit into Source
   6         https://bugs.webkit.org/show_bug.cgi?id=52530
   7
   8         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
   9
  10 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
  11
  12         Unreviewed.
  13
  14         Remove accidentally committed debug printing after r75908.
  15
  16         * Scripts/webkitdirs.pm:
  17
  18 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
  19
  20         Unreviewed.
  21
  22         Add myself to committers list
  23         https://bugs.webkit.org/show_bug.cgi?id=52566
  24
  25         * Scripts/webkitpy/common/config/committers.py:
  26
  27 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
  28
  29         Reviewed by Jeremy Orlow.
  30
  31         GeolocationController should call stopUpdating on destruction
  32         https://bugs.webkit.org/show_bug.cgi?id=52216
  33
  34         fast/dom/Geolocation/window-close-crash.html requires that a
  35         Geolocation watch be started in a secondary window. Consequently,
  36         we need to allow geolocation permission and provide a mock
  37         geolocation position for the secondary window's
  38         GeolocationClientMock.
  39
  40         * DumpRenderTree/chromium/LayoutTestController.cpp:
  41         (LayoutTestController::setGeolocationPermission):
  42         (LayoutTestController::setMockGeolocationPosition):
  43         (LayoutTestController::setMockGeolocationError):
  44         * DumpRenderTree/chromium/TestShell.h:
  45         (TestShell::windowList):
  46
  47 2011-01-16  Adam Barth  <abarth@webkit.org>
  48
  49         Update more include paths to reflect WebKit move.
  50
  51         * DumpRenderTree/chromium/EventSender.cpp:
  52         (EventSender::keyDown):
  53         (EventSender::needsShiftModifier):
  54         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
  55         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
  56
  57 2011-01-16  Kent Tamura  <tkent@chromium.org>
  58
  59         Unreviewed, Chromium build fix.
  60
  61         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
  62
  63 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
  64
  65         Build fix for GTK+ after source directory movement.
  66
  67         * GNUmakefile.am: Correct include paths.
  68
  69 2011-01-16  Adam Barth  <abarth@webkit.org>
  70
  71         Teach svn-apply about WebKit move.
  72
  73         * Scripts/VCSUtils.pm:
  74
  75 2011-01-16  Adam Barth  <abarth@webkit.org>
  76
  77         Rubber-stamped by Eric Seidel.
  78
  79         Move WebKit into Source
  80         https://bugs.webkit.org/show_bug.cgi?id=52530
  81
  82         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
  83         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  84         * DumpRenderTree/qt/DumpRenderTreeQt.h:
  85         * DumpRenderTree/qt/GCControllerQt.cpp:
  86         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  87         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
  88         * DumpRenderTree/qt/TextInputControllerQt.cpp:
  89         * DumpRenderTree/wscript:
  90         * QtTestBrowser/launcherwindow.h:
  91         * Scripts/build-webkit:
  92         * Scripts/webkitdirs.pm:
  93
  94 2011-01-15  Adam Barth  <abarth@webkit.org>
  95
  96         Teach svn-apply about WebKit2 move.
  97
  98         * Scripts/VCSUtils.pm:
  99
 100 2011-01-15  Adam Barth  <abarth@webkit.org>
 101
 102         Rubber-stamped by Eric Seidel.
 103
 104         Move WebKit2 into Source
 105         https://bugs.webkit.org/show_bug.cgi?id=52438
 106
 107         * MiniBrowser/qt/MiniBrowser.pro:
 108         * Scripts/build-webkit:
 109         * Scripts/do-file-rename:
 110         * Scripts/do-webcore-rename:
 111         * Scripts/test-webkitpy:
 112         * Scripts/webkitdirs.pm:
 113         * Scripts/webkitpy/style/checker.py:
 114         * WebKitTestRunner/DerivedSources.pro:
 115         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 116         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 117
 118 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
 119
 120         Reviewed by David Levin.
 121
 122         [chromium] remove obsolete createView method
 123         https://bugs.webkit.org/show_bug.cgi?id=52437
 124
 125         * DumpRenderTree/chromium/WebViewHost.cpp:
 126         (WebViewHost::createView):
 127         * DumpRenderTree/chromium/WebViewHost.h:
 128
 129 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
 130
 131         Reviewed by Geoff Garen.
 132
 133         ShouldLoadResourceForFrame should use strings, not URLs.
 134         https://bugs.webkit.org/show_bug.cgi?id=52476
 135
 136         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 137         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
 138         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 139
 140 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
 141
 142         Reviewed by David Levin.
 143
 144         Add Tony Gentilcore as a reviewer
 145         https://bugs.webkit.org/show_bug.cgi?id=52480
 146
 147         * Scripts/webkitpy/common/config/committers.py:
 148
 149 2011-01-14  David Levin  <levin@chromium.org>
 150
 151         Reviewed by Eric Seidel.
 152
 153         check-webkit-style: _FunctionState should keep track of where the function name starts.
 154         https://bugs.webkit.org/show_bug.cgi?id=52454
 155
 156         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
 157         _FunctionState and logic for setting it correctly.
 158         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
 159
 160 2011-01-14  Vincent Scheib  <scheib@chromium.org>
 161
 162         Reviewed by David Levin.
 163
 164         Add support to DumpRenderTree to use the GPU rather than software renderer
 165         https://bugs.webkit.org/show_bug.cgi?id=52333
 166
 167         * DumpRenderTree/chromium/DumpRenderTree.cpp:
 168         (main):
 169         * Scripts/webkitpy/layout_tests/port/chromium.py:
 170         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 171
 172 2011-01-14  Tony Chang  <tony@chromium.org>
 173
 174         Reviewed by Kent Tamura.
 175
 176         [chromium] update fonts.conf to fix 6 linux tests in drt
 177         https://bugs.webkit.org/show_bug.cgi?id=52411
 178
 179         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
 180             chromium's src/webkit/tools/test_shell/resources/fonts.conf
 181
 182 2011-01-14  Eric Seidel  <eric@webkit.org>
 183
 184         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
 185
 186         Reviewed by Adam Barth.
 187
 188         Fix when running Tools/Scripts/check-webkit-style without arguments.
 189         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
 190
 191         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
 192         * Scripts/webkitpy/common/checkout/scm_unittest.py:
 193
 194 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
 195
 196         Reviewed by David Levin.
 197
 198         Store the tempdir object in a variable so it doesn't get deleted too early.
 199         https://bugs.webkit.org/show_bug.cgi?id=51875
 200
 201         * Scripts/update-webkit-auxiliary-libs:
 202         * Scripts/update-webkit-support-libs:
 203
 204 2011-01-14  Eric Seidel  <eric@webkit.org>
 205
 206         Unreviewed.  Make it work in python 2.5.
 207
 208         webkit-patch suggest-reviewers dies when ChangeLogs are missing
 209         https://bugs.webkit.org/show_bug.cgi?id=49158
 210
 211         * Scripts/webkitpy/common/checkout/api_unittest.py:
 212
 213 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
 214
 215         Unreviewed, rolling out r75774.
 216         http://trac.webkit.org/changeset/75774
 217         https://bugs.webkit.org/show_bug.cgi?id=52431
 218
 219         gtk builds were broken (Requested by loislo2 on #webkit).
 220
 221         * Scripts/webkitpy/common/checkout/scm.py:
 222
 223 2011-01-14  David Levin  <levin@chromium.org>
 224
 225         Reviewed by Shinichiro Hamaji.
 226
 227         check-webkit-style: _FunctionState should detect pure functions.
 228         https://bugs.webkit.org/show_bug.cgi?id=52428
 229
 230         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
 231         is a pure virtual function.
 232         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
 233         virtual functions are correctly detected.
 234
 235 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
 236
 237         Reviewed by Yury Semikhatsky.
 238
 239         Just small fix for problem with check-webkit-style.
 240         It just didn't work for this patch.
 241         Old code can't concatenate a list of strings with None.
 242
 243         * Scripts/webkitpy/common/checkout/scm.py:
 244
 245 2011-01-13  David Levin  <levin@chromium.org>
 246
 247         Reviewed by Shinichiro Hamaji.
 248
 249         check-webkit-style: _FunctionState should use Position to know where items are.
 250         https://bugs.webkit.org/show_bug.cgi?id=52424
 251
 252         * Scripts/webkitpy/style/checkers/cpp.py:
 253         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
 254         (detect_functions): Changed to pass Position's to _FunctionState.begin and
 255         did some minor clean-up.
 256         (*): Other changes are simply about converting to use the Position's in_FunctionState
 257         instead of line numbers.
 258         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
 259         to verify the positions stored in _FunctionState.
 260
 261 2011-01-13  Eric Seidel  <eric@webkit.org>
 262
 263         Reviewed by David Levin.
 264
 265         webkit-patch suggest-reviewers dies when ChangeLogs are missing
 266         https://bugs.webkit.org/show_bug.cgi?id=49158
 267
 268         This is not the most elegant, but it is a very safe fix to this bug.
 269         One advantage of catching ScriptError like this instead of adding a
 270         new added_or_modified_files or fixing all changed_files callers
 271         to use a more specific change_files variant, is that we catch
 272         all kinds of ScriptErrors which might cause our (non-essential)
 273         suggest-reviewers code to fail out.  This should make passing
 274         --suggest-reviewers to webkit-patch upload much more robust
 275         and may even make it possible for us to make it default.
 276
 277         The root of the problem here is that SCM.changed_files includes
 278         deleted ChangeLog paths (from moves, etc) which then when we ask
 279         SVN/Git for the contents of the file at that revision, the command
 280         errors out and Executive.run_command raises a ScriptError.
 281
 282         In the future we might fix this differently by making all current
 283         callers of chagned_files use a more specific method for requesting
 284         what types of changes they're interested in (adds, modifies, deletes, etc.)
 285
 286         * Scripts/webkitpy/common/checkout/api.py:
 287         * Scripts/webkitpy/common/checkout/api_unittest.py:
 288
 289 2011-01-13  Dan Bernstein  <mitz@apple.com>
 290
 291         Reviewed by Alexey Proskuryakov.
 292
 293         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
 294         https://bugs.webkit.org/show_bug.cgi?id=52419
 295
 296         Allow to further control the behavior of the willSendRequest delegate callback by making it
 297         set a different URL in the new request.
 298
 299         * DumpRenderTree/LayoutTestController.cpp:
 300         (addURLToRedirectCallback): Added.
 301         (LayoutTestController::staticFunctions): Added addURLToRedirect.
 302         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
 303         (LayoutTestController::redirectionDestinationForURL): Added this getter.
 304         * DumpRenderTree/LayoutTestController.h:
 305         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 306         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
 307         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
 308         change the URL in the new request to the redirect destination.
 309
 310 2011-01-13  Eric Seidel  <eric@webkit.org>
 311
 312         Reviewed by Mihai Parparita.
 313
 314         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
 315         https://bugs.webkit.org/show_bug.cgi?id=52416
 316
 317         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717
 318         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
 319
 320         I also added FIXMEs about the changed_files returning deleted files problem
 321         which is causing the other most common exception for suggest-reviewers
 322         (and is probably breaking sheriff-bots blame detection).
 323
 324         * Scripts/webkitpy/common/checkout/api.py:
 325         * Scripts/webkitpy/common/checkout/api_unittest.py:
 326         * Scripts/webkitpy/common/checkout/scm.py:
 327
 328 2011-01-13  Eric Seidel  <eric@webkit.org>
 329
 330         Reviewed by Adam Barth.
 331
 332         results archives from commit-queue are too large to upload
 333         https://bugs.webkit.org/show_bug.cgi?id=52405
 334
 335         * Scripts/webkitpy/common/system/filesystem.py:
 336         * Scripts/webkitpy/common/system/filesystem_mock.py:
 337         * Scripts/webkitpy/tool/commands/queues.py:
 338
 339 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
 340
 341         Reviewed by Martin Robinson.
 342
 343         [gtk] Zero-sized font does not yet work
 344         https://bugs.webkit.org/show_bug.cgi?id=49793
 345
 346         Set minimum-font-size to 0 for the DRT.
 347
 348         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 349         (resetDefaultsToConsistentValues):
 350
 351 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
 352
 353         Reviewed by Darin Adler.
 354
 355         Make old-run-webkit-tests more robust on buildbots
 356         https://bugs.webkit.org/show_bug.cgi?id=52364
 357
 358         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
 359
 360 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
 361
 362         Reviewed by Darin Adler.
 363
 364         Make old-run-webkit-tests more robust on buildbots
 365         https://bugs.webkit.org/show_bug.cgi?id=52364
 366
 367         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
 368
 369 2011-01-13  Tony Chang  <tony@chromium.org>
 370
 371         Reviewed by Kent Tamura.
 372
 373         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
 374         https://bugs.webkit.org/show_bug.cgi?id=52332
 375
 376         Forked Info.plist is not longer needed.
 377
 378         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
 379
 380 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
 381
 382         Reviewed by Timothy Hatcher.
 383
 384         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
 385         to be passed directly to WebInspector.UIString
 386
 387         https://bugs.webkit.org/show_bug.cgi?id=52365
 388
 389         * Scripts/check-inspector-strings:
 390
 391 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
 392
 393         Unreviewed, rolling out r74881.
 394         http://trac.webkit.org/changeset/74881
 395         https://bugs.webkit.org/show_bug.cgi?id=52357
 396
 397         The EFL builder has been red for days (Requested by abarth on
 398         #webkit).
 399
 400         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
 401         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
 402
 403 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 404
 405         Reviewed by David Levin.
 406
 407         Add beforeunload support to WebKitTestRunner
 408         https://bugs.webkit.org/show_bug.cgi?id=52353
 409
 410         This makes a number of currently failing tests pass.
 411
 412         * WebKitTestRunner/TestController.cpp:
 413         (WTR::runBeforeUnloadConfirmPanel):
 414         (WTR::createOtherPage):
 415         (WTR::TestController::initialize):
 416
 417 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 418
 419         Reviewed by Sam Weinig.
 420
 421         Detect, identify and recover from WebProcess crashes in run-webkit-tests
 422         https://bugs.webkit.org/show_bug.cgi?id=52330
 423
 424         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
 425         a web process crash.
 426         * WebKitTestRunner/TestController.cpp:
 427         (WTR::TestController::initialize): Set up a processDidCrash
 428         callback.
 429         (WTR::TestController::processDidCrash): Report that the Web process
 430         crashed.
 431         * WebKitTestRunner/TestController.h:
 432
 433 2011-01-12  David Levin  <levin@chromium.org>
 434
 435         Reviewed by Shinichiro Hamaji.
 436
 437         check-webkit-style -- close_expression function doesn't work correctly.
 438         https://bugs.webkit.org/show_bug.cgi?id=52272
 439
 440         * Scripts/webkitpy/style/checkers/cpp.py:
 441         (Position.__str__): Added a way to convert it to a string which is useful in tests.
 442         (Position.__cmp__): Added a way to compare Position which is useful in tests and
 443         generally useful (for upcoming code changes).
 444         (close_expression): Changed to use Position for input and output.
 445         Also, fixed many bugs such as only working correctly for parenthesis,
 446         not working correctly if given an offset in a line and not finding
 447         the real closing element if there were multiple closing elements in
 448         the same line.
 449         (detect_functions): Adjusted due to the change in arguments for
 450         close_expression.
 451         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 452         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
 453         two positions are the same.
 454         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
 455         (CppStyleTest.test_close_expression): Added tests to catch the issues
 456         that were fixed.
 457
 458 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
 459
 460         Unreviewed, rolling out r75576.
 461         http://trac.webkit.org/changeset/75576
 462         https://bugs.webkit.org/show_bug.cgi?id=52304
 463
 464         broke rebaseline-chromium-webkit-test (Requested by thakis on
 465         #webkit).
 466
 467         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 468         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 469         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 470         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 471         * Scripts/webkitpy/layout_tests/port/base.py:
 472         * Scripts/webkitpy/layout_tests/port/chromium.py:
 473         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 474         * Scripts/webkitpy/layout_tests/port/test.py:
 475         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 476         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 477         * Scripts/webkitpy/style/checkers/test_expectations.py:
 478         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
 479
 480 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 481
 482         Reviewed by Darin Adler.
 483
 484         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
 485         https://bugs.webkit.org/show_bug.cgi?id=52307
 486
 487         * Scripts/old-run-webkit-tests:
 488
 489 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
 490
 491         Reviewed by Martin Robinson.
 492
 493         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
 494         https://bugs.webkit.org/show_bug.cgi?id=50867
 495
 496         Fixed library extention for Mac in webkitdirs.pm and type conflict in
 497         TestNetscapePlugin.cpp
 498
 499         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
 500         * Scripts/webkitdirs.pm:
 501
 502 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
 503
 504         Reviewed by Pavel Feldman.
 505
 506         Add check-inspector-strings script.
 507
 508         https://bugs.webkit.org/show_bug.cgi?id=52295
 509
 510         * Scripts/check-inspector-strings: Added.
 511
 512 2011-01-12  Adam Roben  <aroben@apple.com>
 513
 514         Advertise the .testnetscape file extension on Windows
 515
 516         Fixes <http://webkit.org/b/52298>
 517         plugins/no-mime-with-valid-extension.html fails on Windows
 518
 519         Reviewed by Dan Bernstein.
 520
 521         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
 522         FileExtents field to map the .testnetscape file extension to the
 523         application/x-webkit-test-netscape MIME type, just as we do on Mac.
 524
 525 2011-01-12  Adam Barth  <abarth@webkit.org>
 526
 527         Reviewed by Eric Seidel.
 528
 529         Make webkit-patch support subdirectories for SVN checkouts
 530         https://bugs.webkit.org/show_bug.cgi?id=52261
 531
 532         os.relpath does not exist on Python 2.5, so we need to call our version
 533         of the API.
 534
 535         * Scripts/webkitpy/common/checkout/scm.py:
 536
 537 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
 538
 539         Reviewed by Eric Seidel.
 540
 541         Close additional pages opened during a test once the test completes.
 542         https://bugs.webkit.org/show_bug.cgi?id=52276
 543
 544         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 545         (WTR::InjectedBundle::done):
 546
 547 2011-01-11  David Levin  <levin@chromium.org>
 548
 549         Reviewed by Eric Seidel.
 550
 551         Errors should be separated from the command line in bot messages.
 552         https://bugs.webkit.org/show_bug.cgi?id=52275
 553
 554         * Scripts/webkitpy/common/system/executive.py:
 555         (ScriptError.message_with_output): Added a newline to separate the command
 556         line from the errors.
 557         * Scripts/webkitpy/common/system/executive_unittest.py:
 558         (ScriptErrorTest.test_message_with_output): Added tests for the various code
 559         paths in message_with_output.
 560
 561 2011-01-11  Eric Seidel  <eric@webkit.org>
 562
 563         Unreviewed.
 564
 565         commit-queue should know how to upload archived results (for test flakes or general failures)
 566         https://bugs.webkit.org/show_bug.cgi?id=52048
 567
 568         The zips are mostly empty due to forgetting -r.
 569         Expected diffs were not being pulled from the archive due
 570         to the archive having longer paths than I realized.
 571
 572         * Scripts/webkitpy/common/system/workspace.py:
 573         * Scripts/webkitpy/common/system/workspace_unittest.py:
 574         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
 575         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
 576
 577 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
 578
 579         Reviewed by Ojan Vafai.
 580
 581         The current modifier parsing code in test_expectations is
 582         fragile and hard-coded, so it's not easy to understand the logic
 583         or easily add new types of modifiers (like GPU vs. CPU testing
 584         for graphics tests, or 32-bit vs. 64-bit differences).
 585
 586         This is the first of two patches that will add in more generic
 587         support and then eliminate the GPU-specific test expectations
 588         files for Chromium.
 589
 590         This patch adds two standalone objects for handling modifiers. The
 591         rules for interpreting modifiers, precedence, and conflicts are
 592         given in the docstring to the ModifierMatcher class, which
 593         returns ModifierMatchResult objects.
 594
 595         This patch also adds routines to the Port interface and a
 596         default set of values in the base object, in order to obtain the
 597         values needed on a given test run. These values are then passed
 598         to the expectation parser. This also allows us to clean up the
 599         logic used to lint all of the different configurations in a
 600         single test_expectations.txt file.
 601
 602         The next patch will merge in the separate GPU expectations file.
 603
 604         https://bugs.webkit.org/show_bug.cgi?id=51222
 605
 606         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 607         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 608         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 609         * Scripts/webkitpy/layout_tests/port/base.py:
 610         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 611         * Scripts/webkitpy/layout_tests/port/chromium.py:
 612         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 613         * Scripts/webkitpy/layout_tests/port/test.py:
 614         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 615         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 616
 617 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
 618
 619         Reviewed by Adam Barth.
 620
 621         Make webkit-patch support subdirectories for SVN checkouts
 622         https://bugs.webkit.org/show_bug.cgi?id=52261
 623
 624         * Scripts/webkitpy/common/checkout/scm.py:
 625         * Scripts/webkitpy/style_references.py:
 626         * Scripts/webkitpy/tool/main.py:
 627         * Scripts/webkitpy/tool/steps/preparechangelog.py:
 628
 629 2011-01-11  Eric Seidel  <eric@webkit.org>
 630
 631         Unreviewed.
 632
 633         commit-queue should know how to upload archived results (for test flakes or general failures)
 634         https://bugs.webkit.org/show_bug.cgi?id=52048
 635
 636         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
 637         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
 638
 639         * Scripts/webkitpy/common/system/workspace.py:
 640         * Scripts/webkitpy/common/system/workspace_unittest.py:
 641         * Scripts/webkitpy/tool/commands/queues.py:
 642
 643 2011-01-11  Sam Weinig  <sam@webkit.org>
 644
 645         Roll r75474 back in.
 646
 647 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
 648
 649         Reviewed by Kenneth Rohde Christiansen.
 650
 651         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
 652         https://bugs.webkit.org/show_bug.cgi?id=51204
 653
 654         * QtTestBrowser/webpage.h:
 655         (QtNAMThread::QtNAMThread):
 656         (QtNAMThread::networkAccessManager):
 657         (QtNAMThread::run):
 658
 659 2011-01-11  Peter Varga  <pvarga@webkit.org>
 660
 661         Unreviewed.
 662
 663         Add myself to committers' list.
 664
 665         * Scripts/webkitpy/common/config/committers.py:
 666
 667 2011-01-11  Eric Seidel  <eric@webkit.org>
 668
 669         Reviewed by Adam Barth.
 670
 671         commit-queue should know how to upload archived results (for test flakes or general failures)
 672         https://bugs.webkit.org/show_bug.cgi?id=52048
 673
 674         Now the queue will always upload results.  Either the entire zip, or just
 675         the diffs.txt in the case of text failures.
 676
 677         This should make understanding flakes much easier, and paves the way
 678         for having the EWS run layout tests (and upload failures).
 679
 680         In order to upload .zip files I had to teach bugzilla.py to autodetect
 681         mime types from the filename.  Since mimetypes.py doesn't include a mapping
 682         for .patch files, I have it add one before calling guess_type.
 683
 684         We may find that always uploading the whole zip instead of just the -diffs.txt
 685         file is preferable, but for now I'm keeping the old behavior because it makes
 686         quickly understanding text failures easy.
 687
 688         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 689         * Scripts/webkitpy/common/system/workspace.py: Added.
 690         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
 691         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 692         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 693         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
 694         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
 695         * Scripts/webkitpy/tool/commands/queues.py:
 696         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 697
 698 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
 699
 700         Unreviewed, rolling out r75464.
 701         http://trac.webkit.org/changeset/75464
 702         https://bugs.webkit.org/show_bug.cgi?id=52193
 703
 704         Followup rollout for 75474 (Requested by Ossy on #webkit).
 705
 706         * MiniBrowser/mac/BrowserWindowController.m:
 707         (-[BrowserWindowController awakeFromNib]):
 708         * MiniBrowser/win/BrowserView.cpp:
 709         (BrowserView::create):
 710         * WebKitTestRunner/TestController.cpp:
 711         (WTR::createOtherPage):
 712         (WTR::TestController::initialize):
 713
 714 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 715
 716         Reviewed by Csaba Osztrogonác.
 717
 718         [Qt] Baseline qt_minimal configuration
 719         https://bugs.webkit.org/show_bug.cgi?id=51313
 720
 721         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 722         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
 723         QT_NO_UNDOSTACK guard.
 724
 725         * QtTestBrowser/launcherwindow.cpp:
 726         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
 727         guards.
 728         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
 729         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
 730         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
 731         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
 732
 733         * QtTestBrowser/launcherwindow.h:
 734         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
 735         * QtTestBrowser/locationedit.h: Ditto.
 736
 737         * QtTestBrowser/mainwindow.cpp:
 738         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
 739         QT_NO_UNDOSTACK guards.
 740         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
 741         (MainWindow::changeLocation): Ditto.
 742         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
 743         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
 744
 745         * QtTestBrowser/webpage.cpp:
 746         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
 747         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
 748
 749         * QtTestBrowser/webview.cpp:
 750         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
 751         (WebViewGraphicsBased::animatedYFlip): Ditto.
 752
 753 2011-01-10  Sam Weinig  <sam@webkit.org>
 754
 755         Fix build.
 756
 757         * MiniBrowser/mac/BrowserWindowController.m:
 758         (-[BrowserWindowController awakeFromNib]):
 759         * MiniBrowser/win/BrowserView.cpp:
 760         (BrowserView::create):
 761         * WebKitTestRunner/TestController.cpp:
 762         (WTR::createOtherPage):
 763         (WTR::TestController::initialize):
 764
 765 2011-01-10  Eric Seidel  <eric@webkit.org>
 766
 767         Reviewed by Ojan Vafai.
 768
 769         style-queue messages are way too long for big patches
 770         https://bugs.webkit.org/show_bug.cgi?id=52161
 771
 772         We definitely could build much fancier list-to-string-with-limit functions
 773         but this should be sufficient for our needs at the moment.
 774
 775         * Scripts/webkitpy/common/system/executive.py:
 776         * Scripts/webkitpy/common/system/executive_unittest.py:
 777
 778 2011-01-10  Tony Chang  <tony@chromium.org>
 779
 780         Unreviewed, rolling out r75398.
 781         http://trac.webkit.org/changeset/75398
 782         https://bugs.webkit.org/show_bug.cgi?id=52008
 783
 784         Some layout tests are crashing on Chromium Win.
 785
 786         * DumpRenderTree/chromium/WebViewHost.cpp:
 787         (WebViewHost::updatePaintRect):
 788         * DumpRenderTree/chromium/WebViewHost.h:
 789
 790 2011-01-10  Adam Roben  <aroben@apple.com>
 791
 792         Roll out r75392
 793
 794         It isn't needed now that r75289 has been rolled out.
 795
 796         * Scripts/run-javascriptcore-tests:
 797
 798 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
 799
 800         Reviewed by Anders Carlsson.
 801
 802         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
 803         https://bugs.webkit.org/show_bug.cgi?id=52160
 804
 805         * WebKitTestRunner/mac/TestControllerMac.mm:
 806         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
 807         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
 808         anyway.
 809
 810 2011-01-10  Tony Chang  <tony@chromium.org>
 811
 812         Reviewed by Mihai Parparita.
 813
 814         [chromium] fix for animated gif layout tests
 815         https://bugs.webkit.org/show_bug.cgi?id=52008
 816
 817         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
 818             to trigger gif animations.
 819         (WebViewHostPaintTask::WebViewHostPaintTask):
 820         (WebViewHostPaintTask::runIfValid):
 821         (WebViewHost::updatePaintRect):
 822         * DumpRenderTree/chromium/WebViewHost.h:
 823         (WebViewHost::taskList):
 824
 825 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
 826
 827         Reviewed by Xan Lopez.
 828
 829         [GTK] Fix gtk2 compilation for master
 830         https://bugs.webkit.org/show_bug.cgi?id=51885
 831
 832         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
 833         (createBitmapContextFromWebView): Replaced the old
 834         gdk_drawable_get_size with gdk_pixmap_get_size.
 835
 836 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
 837
 838         Reviewed by Laszlo Gombos.
 839
 840         [WINCE] Reenable NPAPI after r75203
 841         https://bugs.webkit.org/show_bug.cgi?id=52109
 842
 843         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
 844         it with !isEfl(), because EFL port does not support NPAPI (yet).
 845
 846         * Scripts/build-webkit:
 847
 848 2011-01-10  Adam Roben  <aroben@apple.com>
 849
 850         Skip some asserting JS tests
 851
 852         See <http://webkit.org/b/52156>.
 853
 854         * Scripts/run-javascriptcore-tests:
 855
 856 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
 857
 858         Reviewed by Xan Lopez.
 859
 860         [GTK] build-webkit disable Blob support via arguments passed to automake
 861         https://bugs.webkit.org/show_bug.cgi?id=52097
 862
 863         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
 864         build-webkit.
 865
 866 2011-01-10  Adam Roben  <aroben@apple.com>
 867
 868         Use the same name and description for TestNetscapePlugin on Windows and
 869         Mac
 870
 871         Fixes <http://webkit.org/b/52151>
 872         fast/frames/iframe-reparenting-plugins.html fails on Windows
 873
 874         Reviewed by Steve Falkenburg.
 875
 876         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
 877         the name and description from Mac's Info.plist.
 878
 879 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
 880
 881         Reviewed by Laszlo Gombos.
 882
 883         [Qt][WK2] Guard gcc-specific syntax
 884
 885         Non-gcc based compliers choke on the "-include"
 886         syntax for preinclude, place guard around it.
 887
 888         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 889         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 890
 891 2011-01-10  Andreas Kling  <kling@webkit.org>
 892
 893         Reviewed by Simon Hausmann.
 894
 895         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
 896         https://bugs.webkit.org/show_bug.cgi?id=52111
 897
 898         When getting a createNewPage() callback from QWKPage, create the
 899         new page with the same QWKContext as the page that is passed to
 900         the callback.
 901
 902         * MiniBrowser/qt/BrowserView.h:
 903         * MiniBrowser/qt/BrowserWindow.cpp:
 904         (newPageFunction):
 905         (BrowserWindow::BrowserWindow):
 906         * MiniBrowser/qt/BrowserWindow.h:
 907
 908 2011-01-10  Andreas Kling  <kling@webkit.org>
 909
 910         Reviewed by Kenneth Rohde Christiansen.
 911
 912         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
 913
 914         BrowserView set its own useless createNewPage() callback on QWKPage.
 915         This was immediately overridden by BrowserWindow anyway, so remove
 916         the BrowserView one.
 917
 918         * MiniBrowser/qt/BrowserView.cpp:
 919         (BrowserView::BrowserView):
 920
 921 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
 922
 923         Reviewed by Jeremy Orlow.
 924
 925         [Chromium] Remove non-client-based Geolocation code
 926         https://bugs.webkit.org/show_bug.cgi?id=50921
 927
 928         * DumpRenderTree/chromium/LayoutTestController.cpp:
 929         (LayoutTestController::setGeolocationPermission):
 930         (LayoutTestController::setMockGeolocationPosition):
 931         (LayoutTestController::setMockGeolocationError):
 932         * DumpRenderTree/chromium/WebViewHost.cpp:
 933         (WebViewHost::geolocationClientMock):
 934         (WebViewHost::reset):
 935         * DumpRenderTree/chromium/WebViewHost.h:
 936
 937 2011-01-10  Eric Seidel  <eric@webkit.org>
 938
 939         Reviewed by Adam Barth.
 940
 941         Commit bot tried to land r? cq+ patch
 942         https://bugs.webkit.org/show_bug.cgi?id=36638
 943
 944         It should now be possible to post a patch with r? and cq+ and the
 945         commit-queue will correctly wait for the r+ before attempting to land the patch.
 946         (This was a feature requested by several users.)
 947
 948         One caveat: We don't actually reject r-, cq+ patches from the queue
 949         (we just ignore them), but I think that's OK for now.
 950
 951         I also noticed that setting r- once a commit-queue node had grabbed
 952         a patch would not properly cancel the landing.  That's fixed and
 953         tested in this patch.
 954
 955         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 956         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 957         * Scripts/webkitpy/tool/bot/feeders.py:
 958         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
 959
 960 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
 961
 962         Reviewed by Kenneth Rohde Christiansen.
 963
 964         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
 965         https://bugs.webkit.org/show_bug.cgi?id=51934
 966
 967         When accessing the network from the destructor of QWebPage, the network access manager
 968         was already deleted because the object WebPage was already destructed.
 969
 970         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
 971         The object is now destructed in the destructor of QObject.
 972
 973         * QtTestBrowser/webpage.cpp:
 974         (WebPage::WebPage):
 975         (WebPage::setQnamThreaded):
 976         * QtTestBrowser/webpage.h:
 977         (QtNAMThread::QtNAMThread):
 978
 979 2011-01-08  Eric Seidel  <eric@webkit.org>
 980
 981         Reviewed by Ojan Vafai.
 982
 983         test_failures.py should not mention TestShell (long live DumpRenderTree!)
 984         https://bugs.webkit.org/show_bug.cgi?id=52067
 985
 986         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
 987         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
 988
 989         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
 990
 991 2011-01-08  Eric Seidel  <eric@webkit.org>
 992
 993         Reviewed by Mihai Parparita.
 994
 995         commit-queue hangs when the ChangeLog diff is bad
 996         https://bugs.webkit.org/show_bug.cgi?id=52072
 997
 998         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
 999         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1000
1001 2011-01-08  Adam Barth  <abarth@webkit.org>
1002
1003         Teach svn-apply how to re-write WebCore to Source/WebCore.
1004
1005         * Scripts/VCSUtils.pm:
1006
1007 2011-01-07  Adam Barth  <abarth@webkit.org>
1008
1009         Rubber-stamped by Eric Seidel.
1010
1011         Move WebCore to Source
1012         https://bugs.webkit.org/show_bug.cgi?id=52050
1013
1014         Update the tools to understand WebCore's new location.
1015
1016         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1017         * DumpRenderTree/wscript:
1018         * GNUmakefile.am:
1019         * Scripts/build-webkit:
1020         * Scripts/do-file-rename:
1021         * Scripts/do-webcore-rename:
1022         * Scripts/generate-qt-inspector-resource:
1023         * Scripts/prepare-ChangeLog:
1024         * Scripts/run-bindings-tests:
1025         * Scripts/update-iexploder-cssproperties:
1026         * Scripts/update-sources-list.py:
1027         * Scripts/update-webkit-localizable-strings:
1028         * Scripts/webkitdirs.pm:
1029         * Scripts/webkitpy/common/config/build.py:
1030         * Scripts/webkitpy/common/config/build_unittest.py:
1031         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1032         * Scripts/webkitpy/style/checker.py:
1033         * Scripts/webkitpy/style/checker_unittest.py:
1034         * WebKitTestRunner/DerivedSources.pro:
1035         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1036         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1037         * wx/browser/wscript:
1038         * wx/build/settings.py:
1039
1040 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1041
1042         Reviewed by Sam Weinig.
1043
1044         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1045         https://bugs.webkit.org/show_bug.cgi?id=52086
1046
1047         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1048         (WTR::InjectedBundle::didReceiveMessage):
1049         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1050         (WTR::LayoutTestController::notifyDone):
1051         * WebKitTestRunner/TestController.cpp:
1052         (WTR::TestController::resetStateToConsistentValues):
1053         (WTR::TestController::run):
1054
1055 2011-01-07  James Robinson  <jamesr@chromium.org>
1056
1057         Revert "Implement mozilla's animationTime property"
1058         https://bugs.webkit.org/show_bug.cgi?id=51952
1059
1060         This approach isn't quite right.
1061
1062         * DumpRenderTree/chromium/WebViewHost.cpp:
1063         (WebViewHost::paintInvalidatedRegion):
1064
1065 2011-01-07  Adam Roben  <aroben@apple.com>
1066
1067         Build master fix
1068
1069         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1070         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1071
1072 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1073
1074         Reviewed by Csaba Osztrogonác.
1075
1076         run-qtwebkit-tests should be able to kill a testsuite.
1077
1078         Add new option in the script that can setup a timeout for a test.
1079         If the test execution takes more then specified time then the test
1080         would be terminated.
1081
1082         [Qt] run-qtwebkit-tests needs timeout
1083         https://bugs.webkit.org/show_bug.cgi?id=51894
1084
1085         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1086         * Scripts/run-qtwebkit-tests:
1087
1088 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1089
1090         Unreviewed fix after r75233.
1091
1092         Based on idea from Eric Seidel.
1093
1094         Add remote zip file handling to webkitpy.
1095         https://bugs.webkit.org/show_bug.cgi?id=50901
1096
1097         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1098
1099 2011-01-07  Shane Stephens  <shanestephens@google.com>
1100
1101         Reviewed by Eric Seidel.
1102
1103         svn-apply: should support git binary delta diffs
1104         https://bugs.webkit.org/show_bug.cgi?id=38864
1105
1106         * Scripts/VCSUtils.pm:
1107         * Scripts/svn-apply:
1108
1109 2011-01-06  Julie Parent  <jparent@chromium.org>
1110
1111         Reviewed by Eric Seidel.
1112
1113         Test Result Server not removing old results.
1114         https://bugs.webkit.org/show_bug.cgi?id=52012
1115
1116         * TestResultServer/model/jsonresults.py:
1117         Fix off-by-one: Truncate if >= num_runs, not just >.
1118         * TestResultServer/model/jsonresults_unittest.py:
1119         Add unit test to test that merging in a new result with the same value
1120         as the last result causes previous result to fall off.
1121
1122 2011-01-06  James Kozianski  <koz@chromium.org>
1123
1124         Reviewed by Mihai Parparita.
1125
1126         Add classes to provide a consistent interface to a set of files.
1127         https://bugs.webkit.org/show_bug.cgi?id=50901
1128
1129         These classes allow us to write code that is agnostic to whether a
1130         particular set of files resides in a local directory or in a zip file
1131         on a remote machine.
1132
1133         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1134         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1135         * Scripts/webkitpy/common/system/fileset.py: Added.
1136         * Scripts/webkitpy/common/system/filesystem.py:
1137         * Scripts/webkitpy/common/system/filesystem_mock.py:
1138         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1139         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1140
1141 2011-01-06  Eric Seidel  <eric@webkit.org>
1142
1143         Reviewed by Adam Barth.
1144
1145         NetworkTransaction should log the url it is retrying
1146         https://bugs.webkit.org/show_bug.cgi?id=52043
1147
1148         * Scripts/webkitpy/common/net/networktransaction.py:
1149         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1150
1151 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1152
1153         Windows build fix.
1154         Import os before using it.
1155
1156         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1157
1158 2011-01-06  Eric Seidel  <eric@webkit.org>
1159
1160         Reviewed by Adam Barth.
1161
1162         StyleQueue fails to report errors when patches have many files
1163         https://bugs.webkit.org/show_bug.cgi?id=52042
1164
1165         This is one of at least two errors preventing style error reporting at the moment.
1166         When we moved to passing the list of files to check explicitly,
1167         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1168         We could change the type of the QueueStatus.message type, or we could
1169         just teach statusserver.py how to clamp values (and warn when it does).
1170         I chose the latter path.
1171
1172         * Scripts/webkitpy/common/net/statusserver.py:
1173
1174 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1175
1176         Reviewed by Stephanie Lewis.
1177
1178         Fix syntax error in script.
1179
1180         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1181         https://bugs.webkit.org/show_bug.cgi?id=51996
1182
1183         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1184
1185 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1186
1187         Unreviewed, fixing WinCE build after r75196.
1188
1189         WinCE port does not (yet) support NPAPI.
1190
1191         * Scripts/build-webkit:
1192
1193 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1194
1195         Reviewed by Darin Adler.
1196
1197         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1198         https://bugs.webkit.org/show_bug.cgi?id=52015
1199
1200         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1201         after the platform has been detected, otherwise the script will
1202         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1203         detection.
1204
1205 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1206
1207         Reviewed by Eric Seidel.
1208
1209         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1210         https://bugs.webkit.org/show_bug.cgi?id=51346
1211
1212         * Scripts/build-webkit:
1213
1214 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1215
1216         Reviewed by Adam Roben.
1217
1218         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1219         https://bugs.webkit.org/show_bug.cgi?id=51996
1220
1221         After the configuration directory change, we were archiving the incorrect directory for
1222         build product, so we were running tests on the wrong binaries.
1223
1224         This change archives the correct directory, and also unarchives it into a configuration-
1225         specific directory.
1226
1227         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1228         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1229
1230 2011-01-06  Eric Seidel  <eric@webkit.org>
1231
1232         Reviewed by Mihai Parparita.
1233
1234         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1235         https://bugs.webkit.org/show_bug.cgi?id=52002
1236
1237         See an example of this here:
1238         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1239
1240         It's due to the fact that we pass around TestFailure() instance
1241         objects and yet expect them to all compare to be the same.
1242
1243         This is bad.  We should either have shared instances of these values
1244         or we should just pass around the class names.  There are already hacks
1245         in place to make TestFailure objects pass equality tests, I just added
1246         a __hash__ implementation so they can be used in sets as expected.
1247
1248         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1249         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1250
1251 2011-01-06  Evan Martin  <evan@chromium.org>
1252
1253         Reviewed by Tony Chang.
1254
1255         [gdb] handle inaccessible memory and UChar*
1256         https://bugs.webkit.org/show_bug.cgi?id=52003
1257
1258         To pretty-print a UChar*, we just grope around in the memory
1259         looking for a terminating NUL.  We need to handle the exception
1260         that can occur when we poke into an invalid location.
1261
1262         Additionally, the logic for choosing which pretty-printer would
1263         early return before hitting the point where we'd use the UChar*
1264         printer.  (Did this ever work?  How did it regress?)
1265
1266         * gdb/webkit.py:
1267
1268 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1269
1270         Reviewed by Ada Chan.
1271
1272         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1273         https://bugs.webkit.org/show_bug.cgi?id=51969
1274
1275         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1276
1277         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1278         (WTR::InjectedBundlePage::InjectedBundlePage):
1279         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1280         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1281
1282 2011-01-06  James Robinson  <jamesr@chromium.org>
1283
1284         Reviewed by Simon Fraser.
1285
1286         Implement mozilla's animationTime property
1287         https://bugs.webkit.org/show_bug.cgi?id=51952
1288
1289         Chromium DRT support for webkitAnimationTime.
1290
1291         * DumpRenderTree/chromium/WebViewHost.cpp:
1292         (WebViewHost::paintInvalidatedRegion):
1293
1294 2011-01-06  Julie Parent  <jparent@chromium.org>
1295
1296         Reviewed by Tony Chang.
1297
1298         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1299         https://bugs.webkit.org/show_bug.cgi?id=51217
1300
1301         * TestResultServer/model/jsonresults.py:
1302         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1303         Adds missing documentation.
1304         * TestResultServer/model/jsonresults_unittest.py:
1305         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1306         Update test_merge to take a number of builds to truncate at.
1307
1308 2011-01-06  Adam Barth  <abarth@webkit.org>
1309
1310         Reviewed by Eric Seidel.
1311
1312         The EWS should log outside of the working directory
1313         https://bugs.webkit.org/show_bug.cgi?id=51986
1314
1315         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1316         script, which will actually clean the working copy back to a pristine
1317         state instead of leaving untracked directories and ignored files.
1318
1319         * Scripts/webkitpy/tool/commands/queues.py:
1320         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1321
1322 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1323
1324         Windows build fix.
1325         Back out attempted change to built-product-archive.
1326
1327         * BuildSlaveSupport/built-product-archive:
1328
1329 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1330
1331         Windows build fix.
1332         Include configuration name when unpacking a build archive.
1333
1334         Needed, since we split Windows build results into configuration-specific directories
1335         under WebKitOutputDir.
1336
1337         * BuildSlaveSupport/built-product-archive:
1338
1339 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1340
1341         Reviewed by Darin Adler.
1342
1343         Debug and Release builds on Windows clobber each other
1344         https://bugs.webkit.org/show_bug.cgi?id=49185
1345
1346         Changes the structure of WebKitBuild build products directory so we
1347         completely separate each build configuration into independent directories.
1348
1349         Although we previously had per-configuration directories for obj, this change adds
1350         per-configuration directories for bin, lib, obj, and include. Each configuration's
1351         build products are stored within a directory inside of WebKitBuild.
1352
1353         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1354         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1355
1356         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1357         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1358         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1359         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1360         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1361         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1362         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1363         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1364         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1365         * FindSafari/FindSafari.vcproj:
1366         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1367         * MiniBrowser/MiniBrowserPostBuild.cmd:
1368         * MiniBrowser/MiniBrowserPreBuild.cmd:
1369         * Scripts/webkitdirs.pm:
1370         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1371         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1372         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1373         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1374         * TestWebKitAPI/win/copy-resources.cmd:
1375         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1376         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1377         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1378         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1379         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1380         * WebKitTestRunner/win/InjectedBundle.vcproj:
1381         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1382         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1383         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1384         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1385         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1386         * WinLauncher/WinLauncherCommon.vsprops:
1387         * WinLauncher/WinLauncherPostBuild.cmd:
1388         * WinLauncher/WinLauncherPreBuild.cmd:
1389
1390 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1391
1392         Reviewed by Ariya Hidayat.
1393
1394         [Qt] TestNetscapePlugin doesn't link on OS X
1395         https://bugs.webkit.org/show_bug.cgi?id=51948
1396
1397         Only add a dependency on libX11 on X11 systems
1398
1399         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1400
1401 2011-01-05  Jeff Miller  <jeffm@apple.com>
1402
1403         Reviewed by Adam Roben.
1404
1405         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1406         https://bugs.webkit.org/show_bug.cgi?id=51970
1407
1408         * Scripts/webkitpy/style/checker.py:
1409         Add -readability/naming for WebKit2 C API directories.
1410
1411 2011-01-05  Eric Seidel  <eric@webkit.org>
1412
1413         Unreviewed, just fixing one more log error from my previous python patch.
1414
1415         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1416         https://bugs.webkit.org/show_bug.cgi?id=51802
1417
1418         webkit-patch failure-reason was logging about parsing errors
1419         due to my misunderstanding of how BeautifulSoup.findAll worked.
1420
1421         Fixed, and added a unit test.
1422
1423         * Scripts/webkitpy/common/net/layouttestresults.py:
1424         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1425
1426 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1427
1428         Reviewed by Kenneth Rohde Christiansen.
1429
1430         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1431         https://bugs.webkit.org/show_bug.cgi?id=51951
1432
1433         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1434         to create new window from WebKit.
1435
1436         * MiniBrowser/qt/BrowserWindow.cpp:
1437         (newPageFunction):
1438         (BrowserWindow::BrowserWindow):
1439         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1440         (BrowserWindow::newWindow):
1441         (BrowserWindow::updateUserAgentList):
1442         (BrowserWindow::showUserAgentDialog):
1443         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1444         define the type of the backing store used for new windows.
1445         * MiniBrowser/qt/main.cpp:
1446         (main):
1447
1448 2011-01-05  Eric Seidel  <eric@webkit.org>
1449
1450         Reviewed by Ojan Vafai.
1451
1452         commit-queue should report failure type when reporting flaky tests
1453         https://bugs.webkit.org/show_bug.cgi?id=51900
1454
1455         This patch was a ridiculous amount of plumbing.  In the end I like
1456         the NRWT-style TestResult class even less.  But now we're passing
1457         a list of TestResult objects from the queue to the FlakyTestReporter.
1458         Thus the FlakyTestReporter can more easily report what type of failure
1459         occurred.
1460
1461         In the process, I found that I was not alone in finding TestResult
1462         cumbersome to use.  A bunch of code was trying to create a TestResult
1463         object with default values.  However since the constructor didn't make
1464         this easy, some places were getting it wrong (including the TestResult unit test)!
1465         I've fixed the TestResult constructor to have default values for non-essential
1466         arguments.
1467
1468         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1469         * Scripts/webkitpy/common/net/layouttestresults.py:
1470         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1471         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1472         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1473         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1474         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1475         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1476         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1477         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1478         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1479         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1480         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1481         * Scripts/webkitpy/tool/commands/queues.py:
1482         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1483
1484 2011-01-05  Eric Seidel  <eric@webkit.org>
1485
1486         Unreviewed.
1487
1488         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1489         https://bugs.webkit.org/show_bug.cgi?id=51802
1490
1491         Add another unit test to cover a previously missing import.
1492
1493         * Scripts/webkitpy/common/net/layouttestresults.py:
1494         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1495
1496 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1497
1498         Reviewed by David Levin.
1499
1500         Add mihaip@chromium.org as a reviewer
1501         https://bugs.webkit.org/show_bug.cgi?id=51966
1502
1503         Add myself as a reviewer.
1504
1505         * Scripts/webkitpy/common/config/committers.py:
1506
1507 2011-01-05  James Simonsen  <simonjam@chromium.org>
1508
1509         Unreviewed. Adding myself to the list of committers.
1510
1511         * Scripts/webkitpy/common/config/committers.py:
1512
1513 2011-01-05  Eric Seidel  <eric@webkit.org>
1514
1515         Unreviewed.
1516
1517         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1518         https://bugs.webkit.org/show_bug.cgi?id=51802
1519
1520         Fix two exceptions seen on the bots after my original commit.
1521
1522         * Scripts/webkitpy/common/net/layouttestresults.py:
1523         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1524
1525 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1526
1527         Reviewed by Andreas Kling.
1528
1529         [Qt]Add local storage settings to QtTestBrowser command line arguments
1530         https://bugs.webkit.org/show_bug.cgi?id=51750
1531
1532         * QtTestBrowser/main.cpp:
1533         (LauncherApplication::handleUserOptions):
1534          Local storage settings can be enable form command line arguments for
1535          QtTestBrowser.
1536
1537 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1538
1539         Reviewed by Martin Robinson.
1540
1541         GTK: AX: DRT needs to use correct root object method.
1542         https://bugs.webkit.org/show_bug.cgi?id=51911
1543
1544         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1545         (AccessibilityController::rootElement):
1546
1547 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1548
1549         Rubber-stamped by Csaba Osztrogonác.
1550
1551         Based on idea from Péter Gál.
1552
1553         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1554
1555 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1556
1557         Reviewed by Adam Barth.
1558
1559         sheriff-bot should be able to do multi-revision rollouts
1560         https://bugs.webkit.org/show_bug.cgi?id=51176
1561
1562         * Scripts/webkitpy/tool/bot/irc_command.py:
1563         * Scripts/webkitpy/tool/bot/sheriff.py:
1564         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1565
1566 2011-01-05  Eric Seidel  <eric@webkit.org>
1567
1568         Reviewed by Adam Barth.
1569
1570         queues.webkit.org should have per-bot status pages
1571         https://bugs.webkit.org/show_bug.cgi?id=51906
1572
1573         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1574         statuses from a single queue.  Now that we have many bots servicing
1575         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1576         you care about scroll off the end of the 15-message limit on the main page.
1577
1578         Eventually we should probably rename /queue-status to /queue or /queues,
1579         but that's fodder for another patch.
1580
1581         * QueueStatusServer/handlers/queuestatus.py:
1582         * QueueStatusServer/index.yaml:
1583         * QueueStatusServer/main.py:
1584         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1585          - This probably should use a custom filter instead of hard-coding
1586            the URL scheme here, but I couldn't figure out how to easily
1587            create such a filter.  Most filters work with "strings" so we can't
1588            pass the status object.  We could add a method to the status
1589            object and call that, but that seemed a bit strange too.
1590         * QueueStatusServer/templates/queuestatus.html:
1591
1592 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1593
1594         Unreviewed. Adding myself to the list of committers.
1595
1596         * Scripts/webkitpy/common/config/committers.py:
1597
1598 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1599
1600         Reviewed by David Levin.
1601
1602         check-webkit-style treated some macros with parentheses after #elif as function calls
1603         https://bugs.webkit.org/show_bug.cgi?id=51695
1604
1605         Ingore function call space checking in any preprocessor directives
1606         (things starting with #). Change search() to match() because
1607         preprocessor directives are supposed to be in the beginning of lines.
1608
1609         * Scripts/webkitpy/style/checkers/cpp.py:
1610         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1611
1612 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1613
1614         Reviewed by Tony Chang.
1615
1616         Change the --multi-load test option to --stress-opt
1617         https://bugs.webkit.org/show_bug.cgi?id=50751
1618
1619         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1620         (runTest):
1621         (main):
1622         * DumpRenderTree/chromium/TestShell.cpp:
1623         (TestShell::TestShell):
1624         * DumpRenderTree/chromium/TestShell.h:
1625         (TestShell::stressOpt):
1626         (TestShell::setStressOpt):
1627         (TestShell::stressDeopt):
1628         (TestShell::setStressDeopt):
1629         (TestShell::javaScriptFlags):
1630         (TestShell::setJavaScriptFlags):
1631         * Scripts/webkitpy/layout_tests/port/chromium.py:
1632         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1633
1634 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1635
1636         Reviewed by Sam Weinig.
1637
1638         WK2: Support Accessibility
1639         https://bugs.webkit.org/show_bug.cgi?id=51859
1640
1641         Use rootObject() method to get top of accessibility tree.
1642
1643         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1644         (AccessibilityController::focusedElement):
1645         (AccessibilityController::rootElement):
1646
1647 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1648
1649         Reviewed by Darin Adler.
1650
1651         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1652         https://bugs.webkit.org/show_bug.cgi?id=51846
1653
1654         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1655         back to GRefPtr.
1656
1657 2011-01-04  Zhe Su  <suzhe@chromium.org>
1658
1659         Reviewed by Kenneth Russell.
1660
1661         Fix insertText, setMarkedText and unmarkText methods of
1662         TextInputController to call corresponding methods of WebKit::WebView
1663         rather than WebKit::WebFrame. This change matches the behavior of
1664         chromium browser.
1665         insertText corresponds to WebView::confirmComposition(text)
1666         setMarkedText corresponds to WebView::setComposition(...)
1667         unmarkText corresponds to WebView::confirmComposition()
1668         https://bugs.webkit.org/show_bug.cgi?id=51693
1669
1670         * DumpRenderTree/chromium/TextInputController.cpp:
1671         (TextInputController::insertText):
1672         (TextInputController::setMarkedText):
1673         (TextInputController::unmarkText):
1674
1675 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1676
1677         Reviewed by Laszlo Gombos.
1678
1679         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1680
1681         On Symbian productDir points to the source directory. Removing all the
1682         empty files from the productDir directory corrupts the svn repository.
1683
1684         * Scripts/build-webkit:
1685
1686 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1687
1688         Reviewed by Adam Barth.
1689
1690         [Qt] Add SelectAll option to the context menu for the editor
1691         https://bugs.webkit.org/show_bug.cgi?id=50049
1692
1693         Set shortcut for the SelectAll action.
1694
1695         * QtTestBrowser/mainwindow.cpp:
1696         (MainWindow::buildUI):
1697
1698 2011-01-03  David Levin  <levin@chromium.org>
1699
1700         Reviewed by Eric Seidel.
1701
1702         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1703         https://bugs.webkit.org/show_bug.cgi?id=51842
1704
1705         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1706         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1707
1708 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1709
1710         Reviewed by David Kilzer.
1711
1712         [WINCE] Adds a build slave.
1713         https://bugs.webkit.org/show_bug.cgi?id=50523
1714
1715         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1716         entry for a release build of the WinCE port.
1717         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1718         flag to build the WinCE port.
1719
1720 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1721
1722         Reviewed by David Kilzer.
1723
1724         Add WinCE support to build-webkit
1725         https://bugs.webkit.org/show_bug.cgi?id=51642
1726
1727         * Scripts/build-webkit:
1728         * Scripts/webkitdirs.pm:
1729
1730 2011-01-03  Eric Seidel  <eric@webkit.org>
1731
1732         Reviewed by Adam Barth.
1733
1734         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1735         https://bugs.webkit.org/show_bug.cgi?id=51802
1736
1737         I'm not the biggest fan of the test_failures or test_results classes,
1738         but it's better to have one shared set of classes, than separate ones
1739         for new vs. old run-webkit-test result handling.
1740
1741         This moves the ORWT results class "LayoutTestResults" over to using
1742         TestResult and TestFailure classes, making it easy for us to
1743         make all our sheriff-bot and other webkitpy code NRWT ready.
1744
1745         This also makes it a trivial patch to generate results.json information
1746         from ORWT results.html files (for flaky test analysis, etc.) as well
1747         as making it a one-liner to report test failure types when the
1748         commit-queue sees flaky tests.
1749
1750         This patch tried not to add new functionality, but only to replace
1751         the guts of LayoutTestResults, while adding unit tests and hoping
1752         not to break anything.
1753
1754         I also moved callers which assumed User.prompt* were static/class methods
1755         to using them as instance methods (since we'll eventually want to make them such).
1756
1757         In the process of re-writing things, I broke the rebaseline command, so I wrote
1758         a unit test to catch my breakage were I do do so again in the future.
1759
1760         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1761         * Scripts/webkitpy/common/net/layouttestresults.py:
1762         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1763         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1764         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1765         * Scripts/webkitpy/tool/commands/queries.py:
1766         * Scripts/webkitpy/tool/commands/rebaseline.py:
1767         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1768         * Scripts/webkitpy/tool/mocktool.py:
1769
1770 2011-01-03  Adam Barth  <abarth@webkit.org>
1771
1772         Reviewed by Simon Fraser.
1773
1774         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1775         https://bugs.webkit.org/show_bug.cgi?id=51840
1776
1777         * Scripts/webkitpy/common/checkout/scm.py:
1778
1779 2011-01-03  Adam Barth  <abarth@webkit.org>
1780
1781         Reviewed by Simon Fraser.
1782
1783         webkit-patch should only hide update output if --quiet
1784         https://bugs.webkit.org/show_bug.cgi?id=51838
1785
1786         As requested by smfr.
1787
1788         * Scripts/webkitpy/tool/steps/update.py:
1789
1790 2011-01-03  Adam Barth  <abarth@webkit.org>
1791
1792         Reviewed by David Levin.
1793
1794         commit-queue shouldn't reject patches twice if two bots process the same patch
1795         https://bugs.webkit.org/show_bug.cgi?id=51805
1796
1797         Before raising an error, we first check whether the patch is still in
1798         the commit-queue.  This check is still racy, of course, but the time
1799         window is much smaller.
1800
1801         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1802
1803 2011-01-03  Sam Weinig  <sam@webkit.org>
1804
1805         Reviewed by Anders Carlsson.
1806
1807         Make run-api-tests less chatty.
1808         https://bugs.webkit.org/show_bug.cgi?id=51831
1809
1810         - Make script quiet by default and add --verbose option (replacing --quiet).
1811         - When not verbose, pipe stdout and stderr to devnull.
1812
1813         * Scripts/run-api-tests:
1814
1815 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1816
1817         Unreviewed. Adding myself to committers.py.
1818
1819         * Scripts/webkitpy/common/config/committers.py:
1820
1821 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1822
1823         Reviewed by Xan Lopez.
1824
1825         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1826         https://bugs.webkit.org/show_bug.cgi?id=51806
1827
1828         Originally, the $libraryName is 'JavaScriptCore'. When building release
1829         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1830         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1831         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and
1832         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1833         so make it 'WebKitBuild/Release/.libs'
1834
1835         * Scripts/webkitdirs.pm:
1836
1837 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1838
1839         Reviewed by Adam Barth.
1840
1841         Make EFL a core builder
1842         https://bugs.webkit.org/show_bug.cgi?id=51804
1843
1844         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1845         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1846
1847 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1848
1849         [Qt] Unreviewed fix after r74855 and r74875.
1850
1851         * BuildSlaveSupport/built-product-archive:
1852          - Create directories explicitly.
1853          - Pass shell=True to subprocess.call().
1854
1855 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1856
1857         [Qt] Unreviewed fix after r74855.
1858
1859         Move JavaScriptCore to Source
1860         https://bugs.webkit.org/show_bug.cgi?id=51604
1861
1862         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1863
1864 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1865
1866         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1867
1868         Move JavaScriptCore to Source
1869         https://bugs.webkit.org/show_bug.cgi?id=51604
1870
1871         * Scripts/webkitdirs.pm:
1872
1873 2011-01-02  Robert Hogan  <robert@webkit.org>
1874
1875         Unreviewed, build fix.
1876
1877         [Qt] Fix DRT build after 74855
1878
1879         * DumpRenderTree/qt/DumpRenderTree.pro:
1880
1881 2011-01-01  Adam Barth  <abarth@webkit.org>
1882
1883         Remove the assumption from the Qt and Gtk builds that every project is
1884         in the root directory.
1885
1886         * Scripts/build-webkit:
1887
1888 2011-01-01  Adam Barth  <abarth@webkit.org>
1889
1890         Reviewed by Eric Seidel.
1891
1892         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1893         https://bugs.webkit.org/show_bug.cgi?id=51796
1894
1895         After this change, svn-apply will magically apply patches to
1896         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1897
1898         * Scripts/VCSUtils.pm:
1899
1900 2011-01-01  Adam Barth  <abarth@webkit.org>
1901
1902         Reviewed by Eric Seidel.
1903
1904         Move JavaScriptCore to Source
1905         https://bugs.webkit.org/show_bug.cgi?id=51604
1906
1907         Update references to JavaScriptCore to point to the new location.
1908
1909         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1910         * DumpRenderTree/qt/DumpRenderTree.pro:
1911         * DumpRenderTree/qt/ImageDiff.pro:
1912         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1913         * DumpRenderTree/wscript:
1914         * Scripts/build-jsc:
1915         * Scripts/build-webkit:
1916         * Scripts/do-file-rename:
1917         * Scripts/do-webcore-rename:
1918         * Scripts/run-javascriptcore-tests:
1919         * Scripts/update-javascriptcore-test-results:
1920         * Scripts/webkitdirs.pm:
1921         * Scripts/webkitpy/common/config/build_unittest.py:
1922         * Scripts/webkitpy/style/checker.py:
1923         * Scripts/webkitpy/style/checker_unittest.py:
1924         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1925         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1926         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1927         * wx/build/settings.py:
1928
1929 2011-01-01  Adam Barth  <abarth@webkit.org>
1930
1931         Reviewed by Eric Seidel.
1932
1933         Move Sources to Source
1934         https://bugs.webkit.org/show_bug.cgi?id=51794
1935
1936         Update scripts to point to the new location.
1937
1938         * Scripts/build-webkit:
1939         * Scripts/do-file-rename:
1940         * Scripts/do-webcore-rename:
1941         * Scripts/webkitpy/common/config/build.py:
1942         * Scripts/webkitpy/common/config/build_unittest.py:
1943
1944 2010-12-31  Kent Tamura  <tkent@chromium.org>
1945
1946         Reviewed by Eric Seidel.
1947
1948         [DRT/Chromium] Enable mock spell checker on non-OSX
1949         https://bugs.webkit.org/show_bug.cgi?id=51401
1950
1951         * DumpRenderTree/chromium/WebViewHost.cpp:
1952         (WebViewHost::spellCheck):
1953
1954 2010-12-31  Adam Barth  <abarth@webkit.org>
1955
1956         Reviewed by Ariya Hidayat.
1957
1958         Remove Tools/Scripts/wkstyle
1959         https://bugs.webkit.org/show_bug.cgi?id=51774
1960
1961         This script appears to not have been touched in a while and seems to
1962         have been replaced by check-webkit-style.
1963
1964         * Scripts/wkstyle: Removed.
1965
1966 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1967
1968         Unreviewed. Coding style fix.
1969
1970         * DumpRenderTree/chromium/TestShell.h:
1971
1972 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1973
1974         Reviewed by Pavel Feldman.
1975
1976         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1977
1978         It was a problem with Chromium DRT. DevToolsAgent object instance was
1979         attached not only to the inspected page but to the DevTools window too.
1980         As result all the inspector files were interpreted as a content of inspected page
1981         and were transfered to the DevTools scripts panel for debugging etc.
1982
1983         https://bugs.webkit.org/show_bug.cgi?id=51735
1984
1985         * DumpRenderTree/chromium/TestShell.cpp:
1986         (TestShell::TestShell):
1987         (TestShell::bindJSObjectsToWindow):
1988         (TestShell::createNewWindow):
1989         * DumpRenderTree/chromium/TestShell.h:
1990
1991 2010-12-31  Adam Barth  <abarth@webkit.org>
1992
1993         Rubber-stamped by Eric Seidel.
1994
1995         Move PageLoadTests to PerformanceTests/PageLoad
1996         https://bugs.webkit.org/show_bug.cgi?id=51771
1997
1998         Update references to PageLoadTests to point to the new location.
1999
2000         * Scripts/run-pageloadtest:
2001         * Scripts/webkitpy/common/config/build.py:
2002
2003 2010-12-31  Adam Barth  <abarth@webkit.org>
2004
2005         Rubber-stamped by Eric Seidel.
2006
2007         Move SunSpider into PerformanceTests
2008         https://bugs.webkit.org/show_bug.cgi?id=51769
2009
2010         Update these scripts to point to the new location.
2011
2012         * Scripts/run-sunspider:
2013         * Scripts/sunspider-compare-results:
2014
2015 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2016
2017         Reviewed by Kent Tamura.
2018
2019         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2020         https://bugs.webkit.org/show_bug.cgi?id=51728
2021
2022         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2023         to render top-level scrollbars. This makes them match the Mac port's
2024         use of an NSScrollView, which means that we'll be able to share more
2025         pixel baselines.
2026
2027         The new rendering code will not be activated until the
2028         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2029         ScrollbarThemeChromiumMac.
2030
2031         * DumpRenderTree/DumpRenderTree.gypi:
2032         * DumpRenderTree/chromium/TestShellMac.mm:
2033         (platformInit):
2034         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2035         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2036         (+[FakeActiveWindow alwaysActiveWindow]):
2037         (+[FakeActiveWindow alwaysInactiveWindow]):
2038         (-[FakeActiveWindow initWithActiveControls:]):
2039         (-[FakeActiveWindow _hasActiveControls]):
2040         (WebThemeEngineDRTMac::paintScrollbarThumb):
2041         (stateToHIEnableState):
2042         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2043         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2044
2045 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2046
2047         Reviewed by David Kilzer.
2048
2049         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2050         used
2051         https://bugs.webkit.org/show_bug.cgi?id=51672
2052
2053         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2054         with USE_SYSTEM_MALLOC=1
2055         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2056         with USE_SYSTEM_MALLOC=1
2057
2058 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2059
2060         Reviewed by David Kilzer.
2061
2062         [Qt] [Symbian] Fix build-webkit script for Symbian
2063         https://bugs.webkit.org/show_bug.cgi?id=51509
2064
2065         Set the OUTPUT_DIR for Symbian to be the same as the source
2066         directory.
2067
2068         * Scripts/webkitdirs.pm:
2069
2070 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2071
2072         Reviewed by Darin Adler.
2073
2074         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2075         https://bugs.webkit.org/show_bug.cgi?id=51758
2076
2077         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2078
2079         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2080         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2081
2082 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2083
2084         Unreviewed WinCE buildfix.
2085
2086         * WinCELauncher/main.cpp: Add missing include.
2087
2088 2010-12-29  Daniel Bates  <dbates@rim.com>
2089
2090         Reviewed by Darin Adler.
2091
2092         svn-apply updates date of wrong change log entry for a change log diff that
2093         contains two consecutive entries with the same author and date
2094         https://bugs.webkit.org/show_bug.cgi?id=46061
2095
2096         Fixes an issue where the date of the wrong change log entry may be modified.
2097         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2098         in a ChangeLog file to the top of the file.
2099
2100         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2101         diff when it detects that the diff inserts a change log entry earlier in a
2102         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2103         change. With the advent of the commit-queue this functionality of bailing out
2104         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2105         Instead, we should always move the change log entry to the top of the ChangeLog file.
2106
2107         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2108         the date line of the correct change log entry in a ChangeLog diff.
2109
2110         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2111
2112         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2113           Updated the following unit tests now that we move entries inserted earlier to the top:
2114           - "fixChangeLogPatch: New entry inserted in middle."
2115             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2116
2117           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2118             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2119
2120         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2121
2122 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2123
2124         Reviewed by Eric Seidel.
2125
2126         [Qt] Fixed compatibility with gold linker on X11 platforms
2127         https://bugs.webkit.org/show_bug.cgi?id=51700
2128
2129         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2130         Linked TestNetscapePlugin with libX11 on Unix platforms
2131
2132 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2133
2134         Reviewed by Darin Adler.
2135
2136         Circular dependency in webkitpy.common.checkout.changelog module
2137         https://bugs.webkit.org/show_bug.cgi?id=50475
2138
2139         Remove automatic import of api.Checkout module when any checkout/
2140         submodule is imported (e.g.: when checkout.scm.Git is imported).
2141
2142         * Scripts/webkitpy/common/checkout/__init__.py:
2143
2144 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2145
2146         Reviewed by Ojan Vafai.
2147
2148         prepare-ChangeLog should support the -g option for specifying the git-commit
2149         https://bugs.webkit.org/show_bug.cgi?id=51708
2150
2151         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2152         webkit-patch, though the exact meaning of the two options remain different.
2153
2154         * Scripts/prepare-ChangeLog: Add -g.
2155
2156 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2157
2158         Reviewed by Simon Hausmann.
2159
2160         [Qt] Fix compilation with Qt in namespace
2161         https://bugs.webkit.org/show_bug.cgi?id=51701
2162
2163         * QtTestBrowser/webview.h:
2164
2165 2010-12-28  Daniel Bates  <dbates@rim.com>
2166
2167         Reviewed by Sam Weinig.
2168
2169         Substitute // MARK: for compiler-specific #pragma mark
2170         https://bugs.webkit.org/show_bug.cgi?id=51657
2171
2172         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2173         substituting  "// MARK:" for "#pragma mark", which provides
2174         analogous code-bookmarking functionality under Xcode.
2175
2176         Also, for consistency, we should substitute "// MARK:" for compiler-
2177         specific "#pragma mark" in the source files for the Mac port.
2178
2179         * DumpRenderTree/AccessibilityTextMarker.cpp:
2180         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2181         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2182         * DumpRenderTree/mac/ObjCController.m:
2183         * MiniBrowser/mac/AppDelegate.m:
2184         * MiniBrowser/mac/BrowserWindowController.m:
2185
2186 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2187
2188         Reviewed by Eric Seidel.
2189
2190         Add --no-build option to run-sunspider
2191         https://bugs.webkit.org/show_bug.cgi?id=51658
2192
2193         * Scripts/run-sunspider: add --no-build flag to skip building
2194         phase.
2195
2196 2010-12-27  Daniel Bates  <dbates@rim.com>
2197
2198         Rubber-stamped by Martin Robinson.
2199
2200         Append the directory Tools/DumpRenderTree to the list of directories that
2201         do-webcore-rename should search so that it can rename DRT files and
2202         source code.
2203
2204         * Scripts/do-webcore-rename:
2205
2206 2010-12-27  Eric Seidel  <eric@webkit.org>
2207
2208         Reviewed by Adam Barth.
2209
2210         build-webkit should detect missing Java SDK and explain how to install it
2211         https://bugs.webkit.org/show_bug.cgi?id=51651
2212
2213         * Scripts/build-webkit:
2214
2215 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2216
2217         Reviewed by Daniel Bates.
2218
2219         [GTK] Add support for build-jsc
2220         https://bugs.webkit.org/show_bug.cgi?id=51625
2221
2222         Add GTK+ support to build-jsc now that building the jsc executable as
2223         a standalone target is easy.
2224
2225         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2226         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2227         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2228         and pass it along to buildAutotoolsProject.
2229
2230 2010-12-27  David Levin  <levin@chromium.org>
2231
2232         Reviewed by Eric Seidel.
2233
2234         check-webkit-style check for meaningless variable names in function declarations.
2235         https://bugs.webkit.org/show_bug.cgi?id=51523
2236
2237         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2238         from the new check and whitespace/parens because the syntax is unusual and
2239         produced a fair number of positives for these checks.
2240         * Scripts/webkitpy/style/checkers/cpp.py:
2241         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2242         and parameter names when determining if the parameter name is useless.
2243         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2244         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2245         format.
2246         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2247         text or an acronym of it.
2248         (check_function_definition): Checks function definitions for meaningless variable names.
2249         (process_line): Added call to check_function_definition.
2250         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2251         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2252         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2253         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2254         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2255         because when only checking a snippet, there are a lot of bogus functions.
2256         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2257         that I put there previously and just noticed.
2258         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2259         check_function_definition and process_line.
2260
2261 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2262
2263         Reviewed by Martin Robinson.
2264
2265         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2266         https://bugs.webkit.org/show_bug.cgi?id=51591
2267
2268         Flash plugin uses gtk2 that is incompatible with gtk3 making
2269         webkit crash when it's built with gtk3.
2270
2271         * GtkLauncher/main.c:
2272         (main):
2273
2274 2010-12-25  Adam Barth  <abarth@webkit.org>
2275
2276         Reviewed by Eric Seidel.
2277
2278         Move ANGLE to Sources/ThirdParty
2279         https://bugs.webkit.org/show_bug.cgi?id=51605
2280
2281         * Scripts/build-webkit:
2282           - Point to the new ANGLE location.
2283
2284 2010-12-26  David Levin  <levin@chromium.org>
2285
2286         Reviewed by Eric Seidel.
2287
2288         check-webkit-style should be able to parse function declaration parameters.
2289         https://bugs.webkit.org/show_bug.cgi?id=51451
2290
2291         * Scripts/webkitpy/style/checkers/cpp.py:
2292         (Position.__init__): Holds simple position information (row, column).
2293         (Parameter.__init__): Holds information about a parameter.
2294         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2295         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2296         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2297         (find_parameter_name_index): Finds where the parameter name is.
2298         (parameter_list): Generates the list of parameters for a function.
2299         (_FunctionState.begin): Added information to allow determining the parameters
2300         on demand.
2301         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2302         (detect_functions): Improve function detection for operator functions and
2303         determine where the parameters end and pass that to _FunctionState.begin.
2304         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2305         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2306         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2307         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2308         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2309         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2310         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2311         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2312         the parameters found.
2313         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2314         detection test to verify that we catch the operator functions.
2315         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2316         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2317         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2318         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2319         test_function_length_check_definition_severity1_for_test.
2320
2321 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2322
2323         Unreviewed WinCE buildfix after r74334.
2324
2325         * CMakeListsWinCE.txt:
2326
2327 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2328
2329         Unreviewed, rolling out r74632.
2330         http://trac.webkit.org/changeset/74632
2331         https://bugs.webkit.org/show_bug.cgi?id=51600
2332
2333         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2334         on #webkit).
2335
2336         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2337         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2338
2339 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2340
2341         Reviewed by Kenneth Rohde Christiansen.
2342
2343         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2344         https://bugs.webkit.org/show_bug.cgi?id=43528
2345
2346         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2347         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2348         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2349         called.
2350
2351         * EWebLauncher/main.c:
2352         (browserCreate):
2353
2354 2010-12-24  Eric Seidel  <eric@webkit.org>
2355
2356         Reviewed by Adam Barth.
2357
2358         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2359         https://bugs.webkit.org/show_bug.cgi?id=28291
2360
2361         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2362         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2363         to strings with find in the diff.
2364         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2365
2366         * Scripts/webkitpy/common/checkout/api.py:
2367         * Scripts/webkitpy/common/checkout/diff_parser.py:
2368         * Scripts/webkitpy/tool/steps/abstractstep.py:
2369         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2370         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2371         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2372         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2373
2374 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2375
2376         Reviewed by Kenneth Russell.
2377
2378         Modify new-run-webkit-tests to shut up and exit when all the threads
2379         are wedged so that test runs complete faster and we don't end up
2380         w/ enormous log files.
2381
2382         https://bugs.webkit.org/show_bug.cgi?id=51572
2383
2384         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2385         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2386
2387 2010-12-24  Eric Seidel  <eric@webkit.org>
2388
2389         Reviewed by David Levin.
2390
2391         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2392         https://bugs.webkit.org/show_bug.cgi?id=51549
2393
2394         I've had multiple people ask me about the commit-queue's behavior
2395         regarding reporting flaky tests.  I figured it would be best to just
2396         have the queue explain itself in the bugs it files.
2397
2398         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2399         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2400
2401 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2402
2403         Reviewed by Eric Seidel.
2404
2405         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2406         https://bugs.webkit.org/show_bug.cgi?id=51467
2407
2408         * Scripts/webkitpy/style/checker.py:
2409         * Scripts/webkitpy/style/checker_unittest.py:
2410
2411 2010-12-23  Adam Barth  <abarth@webkit.org>
2412
2413         Rubber-stamped by Eric Seidel.
2414
2415         Move JavaScriptGlue into Sources
2416         https://bugs.webkit.org/show_bug.cgi?id=51583
2417
2418         These tools refer to JavaScriptGlue and need to be updated to its new
2419         location.
2420
2421         * Scripts/build-webkit:
2422         * Scripts/do-file-rename:
2423         * Scripts/do-webcore-rename:
2424         * Scripts/webkitpy/common/config/build.py:
2425         * Scripts/webkitpy/common/config/build_unittest.py:
2426
2427 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2428
2429         Reviewed by Eric Seidel.
2430
2431         Bug 51539 - update iexploder scripts to point to new location
2432
2433         * Scripts/run-iexploder-tests:
2434         * Scripts/update-iexploder-cssproperties:
2435
2436 2010-12-23  Evan Martin  <evan@chromium.org>
2437
2438         Reviewed by Ryosuke Niwa.
2439
2440         [chromium] LayoutTestController warning in float->int conversion
2441         https://bugs.webkit.org/show_bug.cgi?id=51553
2442
2443         Rather than reading an int, converting to a float, then getting a compiler
2444         warning on passing the float to something that expects an int, instead
2445         just pass around ints.
2446
2447         No tests, fixes a compiler warning.
2448
2449         * DumpRenderTree/chromium/LayoutTestController.cpp:
2450         (parsePageSizeParameters):
2451         (LayoutTestController::pageNumberForElementById):
2452         (LayoutTestController::numberOfPages):
2453
2454 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2455
2456         Reviewed by Darin Adler.
2457
2458         Bug 51537 - iexploder needs cleanup
2459
2460         * iExploder/htdocs: Removed.
2461         * iExploder/htdocs/config.rb: Removed.
2462         * iExploder/htdocs/cssproperties.in: Removed.
2463         * iExploder/htdocs/cssvalues.in: Removed.
2464         * iExploder/htdocs/htmlattrs.in: Removed.
2465         * iExploder/htdocs/htmltags.in: Removed.
2466         * iExploder/htdocs/htmlvalues.in: Removed.
2467         * iExploder/htdocs/iexploder.cgi: Removed.
2468         * iExploder/htdocs/iexploder.rb: Removed.
2469         * iExploder/htdocs/index.html: Removed.
2470         * iExploder/htdocs/webserver.rb: Removed.
2471         * iExploder/iexploder-1.7.2/output: Removed.
2472         * iExploder/tools: Removed.
2473         * iExploder/tools/lasthit.rb: Removed.
2474         * iExploder/tools/osx_last_crash.rb: Removed.
2475         * iExploder/tools/showtest.rb: Removed.
2476
2477 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2478
2479         Reviewed by Kenneth Rohde Christiansen.
2480
2481         [EFL] Make 'single' the default backing store in EWebLauncher
2482         https://bugs.webkit.org/show_bug.cgi?id=51534
2483
2484         'single' is the simplest backing store and the one intended to be the
2485         default in the test browser. By mistake the tiled backing store was
2486         left as default in r72617.
2487
2488         * EWebLauncher/main.c:
2489         (browserCreate): ditto.
2490
2491 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2492
2493         Reviewed by Kenneth Rohde Christiansen.
2494
2495         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2496         https://bugs.webkit.org/show_bug.cgi?id=51533
2497
2498         There's no point in concatenating env("HOME") with "blah", so remove
2499         option from EWebLauncher.
2500
2501         * EWebLauncher/main.c:
2502         (main): ditto.
2503
2504 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2505
2506         Reviewed by Eric Seidel.
2507
2508         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2509
2510         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2511         I just discovered that we have two additional GC runs per each WebViewHost.
2512         Test_shell had no such calls.
2513         These gc runs eat 15% of cpu time.
2514
2515         https://bugs.webkit.org/show_bug.cgi?id=51479
2516
2517         * DumpRenderTree/chromium/WebViewHost.cpp:
2518         (WebViewHost::~WebViewHost):
2519
2520 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2521
2522         Reviewed by Ojan Vafai.
2523
2524         This change splits out the TestRunner class into its own file.
2525         When we fork the code for message passing, we will create a new
2526         TestRunner, and this change will allow that to be more modular.
2527
2528         While we're at it, split out TestInput and ResultSummary into
2529         their own files, to reduce the size of run_webkit_tests to
2530         something more managable.
2531
2532         https://bugs.webkit.org/show_bug.cgi?id=51092
2533
2534         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2535         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2536         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2537         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2538         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2539         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2540         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2541
2542  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2543
2544         Reviewed by Ojan Vafai.
2545
2546         nrwt multiprocessing - start over, prepare to fork the code
2547
2548         This code cleans up the signatures and implementation of the
2549         TestRunner class so we can easily fork it to run either the
2550         stable implementation or the new, unstable message-passing
2551         implementation. The two variants will have different
2552         implementations of the run_tests() method. We will switch
2553         between the two based on the setting for the '--worker-model'
2554         switch. We rename the two currently valid values to 'old-inline'
2555         and 'old-threads'.
2556
2557         https://bugs.webkit.org/show_bug.cgi?id=51081
2558
2559         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2560         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2561
2562 2010-12-22  Victor Wang  <victorw@chromium.org>
2563
2564         Reviewed by Darin Fisher.
2565
2566         [Chromium] Update chromium archive test result url in rebaseline script.
2567
2568         https://bugs.webkit.org/show_bug.cgi?id=51503
2569
2570         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2571
2572 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2573
2574         Reviewed by Alice Liu.
2575
2576         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2577         Verified on Chrome, Safari, and IE.
2578         With this change, we will record memory from a parent browser window and all child processes.
2579
2580         * record-memory-win/main.cpp:
2581         (ProcessArgs):
2582         (PrintUsage):
2583         (getMemoryInfo):
2584         (printProcessInfo):
2585         (evalProcesses):
2586         (UseImage):
2587         (QueryContinuously):
2588         (ElapsedTime):
2589
2590 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2591
2592         Unreviewed rollout r74489, because it was missing changelog.
2593
2594         * record-memory-win/main.cpp:
2595
2596 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2597
2598         Adding myself as a reviewer.
2599
2600         * Scripts/webkitpy/common/config/committers.py:
2601
2602 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2603
2604         Unreviewed.  Adding myself to committers.py.
2605
2606         * Scripts/webkitpy/common/config/committers.py:
2607
2608 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2609
2610         Reviewed by Kenneth Rohde Christiansen.
2611
2612         TestNetscapePlugIn should use #if defined
2613         https://bugs.webkit.org/show_bug.cgi?id=51471
2614
2615         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2616         (NP_Initialize):
2617         (NPP_New):
2618
2619 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2620
2621         Reviewed by Yury Semikhatsky.
2622
2623         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2624
2625         DevTools window should be closed explicitly because it has custom deinitialization code.
2626
2627         https://bugs.webkit.org/show_bug.cgi?id=50722
2628
2629         * DumpRenderTree/chromium/TestShell.cpp:
2630         (TestShell::closeRemainingWindows):
2631
2632 2010-12-22  David Levin  <levin@chromium.org>
2633
2634         Reviewed by Shinichiro Hamaji.
2635
2636         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2637         https://bugs.webkit.org/show_bug.cgi?id=51452
2638
2639         * Scripts/webkitpy/style/checkers/cpp.py:
2640         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2641         Using the file extension if possible but falling back to the file contents if we have a header file.
2642         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2643         (_FileState.is_c_or_objective_c):
2644         (check_using_std): Changed to using _FileState to determine the file type.
2645         (check_max_min_macros): Ditto.
2646         (check_for_null): Ditto.
2647         (check_style): Changed the parameters to various calls since they now need _FileState
2648         to determine the file type.
2649         (check_language): Added the file_state parameter so it could be passed
2650         to check_identifier_name_in_declaration.
2651         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2652         this is an Objective C file.
2653         (_process_lines): Added information for the _FileState constructor (and moved the
2654         call to a place that had the information).
2655         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2656         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2657         its functionality.
2658         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2659
2660 2010-12-21  Andy Estes  <aestes@apple.com>
2661
2662         Reviewed by Mark Rowe.
2663
2664         Do not build non-Intel architectures for WebKit2-related projects.
2665         https://bugs.webkit.org/show_bug.cgi?id=51440
2666
2667         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2668         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2669         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2670
2671 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2672
2673         Reviewed by Darin Fisher.
2674
2675         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2676         https://bugs.webkit.org/show_bug.cgi?id=51406
2677
2678         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2679         to WebThemeEngineDRTWin and update references everywhere.
2680
2681         * DumpRenderTree/DumpRenderTree.gypi:
2682         * DumpRenderTree/chromium/TestShellWin.cpp:
2683         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2684         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2685         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2686         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2687
2688 2010-12-21  Anders Carlsson  <andersca@apple.com>
2689
2690         Reviewed by John Sullivan.
2691
2692         Clicking missing plug-in text does not show a sheet
2693         https://bugs.webkit.org/show_bug.cgi?id=51403
2694
2695         Update for changes to the WebPageUIClient.
2696
2697         * MiniBrowser/mac/BrowserWindowController.m:
2698         (-[BrowserWindowController awakeFromNib]):
2699         * WebKitTestRunner/TestController.cpp:
2700         (WTR::createOtherPage):
2701         (WTR::TestController::initialize):
2702
2703 2010-12-21  Eric Seidel  <eric@webkit.org>
2704
2705         Reviewed by Adam Barth.
2706
2707         commit-queue will report constant failures as flaky if other tests flake
2708         https://bugs.webkit.org/show_bug.cgi?id=51272
2709
2710         This patch just removes functionality and adds testing.
2711         Previously we attempted to report flaky tests when we had
2712         two different tests fail in a row.  However, since we stop
2713         running the tests at the first failure, our code was wrong in
2714         trying to determine flakiness from the incomplete runs.
2715
2716         Originally I posted an alternate patch:
2717         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2718         which fixed our flaky logic in this case, however it was decided
2719         that that patch would be too difficult to maintain, so now
2720         I'm just removing the broken logic.
2721
2722         This will dramatically cut-down on our flaky-test false positives
2723         at the (small) cost of the queues being unable to report
2724         any flakiness if the tree is very flaky.  (With at least one test
2725         flaking on every run, we'll never report failures anymore.)  I think
2726         this is a tradeoff worth making.
2727
2728         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2729         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2730
2731 2010-12-20  Eric Seidel  <eric@webkit.org>
2732
2733         Reviewed by Adam Barth.
2734
2735         commit-queue wrongly rejects patches when it can't update itself
2736         https://bugs.webkit.org/show_bug.cgi?id=46636
2737
2738         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2739         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2740         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2741
2742 2010-12-20  Adam Barth  <abarth@webkit.org>
2743
2744         Move web sites to Websites directory
2745         https://bugs.webkit.org/show_bug.cgi?id=51323
2746
2747         Update references to BugsSite to point to the new location.
2748
2749         This patch was never officially reviewed (because it was too large to
2750         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2751         Rowe gave me the green light.
2752
2753         * Scripts/old-run-webkit-tests:
2754         * Scripts/webkitpy/common/config/build.py:
2755         * Scripts/webkitpy/common/config/build_unittest.py:
2756         * Scripts/webkitpy/common/prettypatch.py:
2757         * Scripts/webkitpy/layout_tests/port/base.py:
2758         * Scripts/webkitpy/style/main.py:
2759
2760 2010-12-20  Adrienne Walker  <enne@google.com>
2761
2762         Unreviewed. Adding myself to the list of committers.
2763
2764         * webkitpy/common/config/committers.py:
2765
2766 2010-12-20  Mark Rowe  <mrowe@apple.com>
2767
2768         Reviewed by Dan Bernstein.
2769
2770         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2771
2772         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2773         Resources directory.
2774
2775 2010-12-20  Eric Seidel  <eric@webkit.org>
2776
2777         Reviewed by Adam Barth.
2778
2779         commit-queue should include bot id when attaching failure diffs
2780         https://bugs.webkit.org/show_bug.cgi?id=51280
2781
2782         This is a tiny change to include the bot id in the name of the attachment.
2783         Most of this diff is just changing the unit test expectations
2784         now that I hid the comment printing when the comment is None.
2785
2786         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2787         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2788         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2789         * Scripts/webkitpy/tool/mocktool.py:
2790
2791 2010-12-20  Jeff Miller  <jeffm@apple.com>
2792
2793         Reviewed by Dan Bernstein.
2794
2795         Tools/vcbin/midl.exe needs to be rebuilt
2796         https://bugs.webkit.org/show_bug.cgi?id=51347
2797
2798         * vcbin/midl.exe: Rebuilt.
2799
2800 2010-12-20  David Levin  <levin@chromium.org>
2801
2802         Reviewed by Ariya Hidayat.
2803
2804         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2805         https://bugs.webkit.org/show_bug.cgi?id=51343
2806
2807         Follow up from the WebKitTools -> Tools rename.
2808
2809         * Scripts/webkit-tools-completion.sh:
2810
2811 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2812
2813         Reviewed by James Robinson.
2814
2815         new-run-webkit-tests ignores trailing EOL differences in text tests
2816         https://bugs.webkit.org/show_bug.cgi?id=36983
2817
2818         Changed the handling of new-line characters within new-run-webkit-tests
2819         to match old-run-webkit-tests.  Differences in leading and trailing empty
2820         lines in text expectation files are no longer ignored.
2821
2822         * Scripts/webkitpy/layout_tests/port/base.py:
2823         * Scripts/webkitpy/layout_tests/port/test.py:
2824         Added unit tests.  Removed old duplicate unit test entries.
2825         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2826
2827 2010-12-20  David Levin  <levin@chromium.org>
2828
2829         Reviewed by Shinichiro Hamaji.
2830
2831         check-webkit-style should detect function declarations (and trivial functions).
2832         https://bugs.webkit.org/show_bug.cgi?id=51303
2833
2834         * Scripts/webkitpy/style/checkers/cpp.py:
2835         (_FunctionState.begin): Add is_declaration and changed the line count
2836         start to begin at -1 (which will keep the results consistent, since
2837         the starting line number passed in is one less in this change).
2838         (detect_functions): changed function detection to now catch trivial
2839         functions and declarations.
2840         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2841         of the function as this may look at return values (when processing
2842         a declaration).
2843         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2844         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2845         of testing the function detection.
2846         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2847         function.
2848         (FunctionDetectionTest.test_function_declaration_detection): Test a
2849         declaration.
2850         (FunctionDetectionTest.test_non_functions): A test case for a case
2851         that caused the code to fail due to the { being in quotes.
2852         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2853         cases to help catch false alarms for return values.
2854         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2855         we don't get false alarms for member variables either.
2856
2857 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2858
2859         Reviewed by Antonio Gomes.
2860
2861         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2862         https://bugs.webkit.org/show_bug.cgi?id=51319
2863
2864         * CMakeListsEfl.txt:
2865
2866 2010-12-18  Adam Barth  <abarth@webkit.org>
2867
2868         Reviewed by Sam Weinig.
2869
2870         Move WebKitExamplePlugins to Examples
2871         https://bugs.webkit.org/show_bug.cgi?id=51291
2872
2873         * Scripts/webkitpy/common/config/build.py:
2874
2875 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2876
2877         Unreviewed Qt buildfix after r74301.
2878
2879         Rename WebKitTools to Tools
2880         https://bugs.webkit.org/show_bug.cgi?id=49861
2881
2882         * MiniBrowser/DerivedSources.pro:
2883         * MiniBrowser/qt/MiniBrowser.pro:
2884
2885 2010-12-17  Dan Bernstein  <mitz@apple.com>
2886
2887         Reviewed by Simon Fraser.
2888
2889         Rename WebKitTools to Tools
2890         https://bugs.webkit.org/show_bug.cgi?id=49861
2891
2892         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2893         * CodeCoverage/README:
2894         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2895         (WebCore::DumpRenderTree::initializeFonts):
2896         * EWSTools/start-commit-queue.sh:
2897         * EWSTools/start-queue.sh:
2898         * GNUmakefile.am:
2899         * MIDLWrapper/MIDLWrapper.cpp:
2900         (wmain):
2901         * MiniBrowser/qt/MiniBrowser.pro:
2902         * Scripts/build-api-tests:
2903         * Scripts/build-dumprendertree:
2904         * Scripts/build-webkit:
2905         * Scripts/build-webkittestrunner:
2906         * Scripts/generate-coverage-data:
2907         * Scripts/old-run-webkit-tests:
2908         * Scripts/run-api-tests:
2909         * Scripts/run-iexploder-tests:
2910         * Scripts/run-javascriptcore-tests:
2911         * Scripts/run-mangleme-tests:
2912         * Scripts/run-sunspider:
2913         * Scripts/run-webkit-websocketserver:
2914         * Scripts/sunspider-compare-results:
2915         * Scripts/test-webkitperl:
2916         * Scripts/test-webkitpy:
2917         * Scripts/update-iexploder-cssproperties:
2918         * Scripts/update-webkit:
2919         * Scripts/update-webkit-localizable-strings:
2920         * Scripts/webkitdirs.pm:
2921         * Scripts/webkitpy/common/checkout/scm.py:
2922         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2923         * Scripts/webkitpy/common/config/committervalidator.py:
2924         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2925         * Scripts/webkitpy/common/config/ports.py:
2926         * Scripts/webkitpy/common/config/ports_unittest.py:
2927         * Scripts/webkitpy/common/system/logutils_unittest.py:
2928         * Scripts/webkitpy/common/system/ospath_unittest.py:
2929         * Scripts/webkitpy/layout_tests/port/chromium.py:
2930         * Scripts/webkitpy/layout_tests/port/config.py:
2931         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2932         * Scripts/webkitpy/layout_tests/port/http_server.py:
2933         * Scripts/webkitpy/layout_tests/port/test.py:
2934         * Scripts/webkitpy/style/checker.py:
2935         * Scripts/webkitpy/style/checker_unittest.py:
2936         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2937         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2938         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2939         * WebKitTestRunner/DerivedSources.pro:
2940         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2941         (WTR::activateFonts):
2942         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2943         * wx/build/build_utils.py:
2944
2945 2010-12-16  Antonio Gomes  <agomes@rim.com>
2946
2947         Reviewed by Martin Robinson.
2948
2949         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2950         https://bugs.webkit.org/show_bug.cgi?id=51163
2951
2952         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2953         GTK+'s DRT should also reset to UNIX after each test execution.
2954
2955         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2956         (resetDefaultsToConsistentValues):
2957
2958 2010-12-17  David Levin  <levin@chromium.org>
2959
2960         Reviewed by Eric Seidel.
2961
2962         check-webkit-style should understand WTF #include guards
2963         https://bugs.webkit.org/show_bug.cgi?id=44911
2964
2965         * Scripts/webkitpy/style/checkers/cpp.py:
2966         (get_header_guard_cpp_variable): modify to suggest the WTF style
2967         of header guard when appropriate.
2968         (check_for_header_guard): handle multiple return values from
2969         get_header_guard_cpp_variable
2970         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2971         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2972         header style.
2973
2974 2010-12-16  David Levin  <levin@chromium.org>
2975
2976         Reviewed by Eric Seidel.
2977
2978         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2979         https://bugs.webkit.org/show_bug.cgi?id=51210
2980
2981         The error only shows up when using python 2.6 or later.
2982
2983         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2984         the decprecated field error,message with something equivalent.
2985
2986 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2987
2988         Reviewed by Eric Seidel.
2989
2990         Add --exit-after-n-failures/crashes to NRWT
2991         https://bugs.webkit.org/show_bug.cgi?id=51160
2992
2993         Abort test run (in a similar way to how control-C is handled) when
2994         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2995         that number of unexpected failures/crashes/timeouts.
2996
2997         * Scripts/webkitpy/layout_tests/port/test.py:
2998         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2999         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3000
3001 2010-12-16  David Levin  <levin@chromium.org>
3002
3003         Reviewed by Shinichiro Hamaji.
3004
3005         check-webkit-style unit tests has some duplicate boilerplate code.
3006         https://bugs.webkit.org/show_bug.cgi?id=49519
3007
3008         * Scripts/webkitpy/style/checkers/cpp.py:
3009         (update_include_state): Replaced the "io" parameter with the global
3010         configuration _unit_test_config. This allowed not calling into
3011         functions at a low level and also not plumbing through the injection
3012         information through many levels of code.
3013         (check_for_include_what_you_use): Ditto.
3014         (process_file_data): Added the ability to set up the unit test config
3015         to allow for injection.
3016         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3017         (ErrorCollector.__init__): Added support for having a filter for errors.
3018         (ErrorCollector.__call__): Ditto.
3019         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3020         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3021         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3022         functions in the cpp.py with generic processing and a filter that
3023         indicates what errors should be kept.
3024         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3025         (CppStyleTestBase.perform_language_rules_check): Ditto.
3026         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3027         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3028         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3029         (CppStyleTest.test_multi_line_comments): Added another
3030         error message which applies to the test case.
3031         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3032         to not have config.h, since it is processed as a header file.
3033         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3034         style and indentation in checked code.
3035         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3036         Fixed line number.
3037         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3038         Ditto.
3039
3040 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3041
3042         Unreviewed, rolling out r74136.
3043         http://trac.webkit.org/changeset/74136
3044         https://bugs.webkit.org/show_bug.cgi?id=51135
3045
3046         r74136 breaks chromium canary bots because some tests are not
3047         rebaselined correctly to resolve EOL differences (Requested by
3048         jianli on #webkit).
3049
3050         * Scripts/webkitpy/layout_tests/port/base.py:
3051         * Scripts/webkitpy/layout_tests/port/test.py:
3052         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3053
3054 2010-12-15  Adam Roben  <aroben@apple.com>
3055
3056         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3057         syntax errors
3058
3059         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3060         XML syntax errors in .vcproj/.vsprops files
3061
3062         Reviewed by Dave Levin.
3063
3064         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3065         that should be treated as XML and that should be allowed to contain
3066         carriage returns. (These lists happen to be identical currently.)
3067         (FileType): Added a new XML type.
3068         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3069         Just does a simple file extension check.
3070         (CheckerDispatcher._file_type): Added a case for XML files.
3071         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3072         files (surprise!).
3073         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3074         lines through the carriage checker.
3075
3076         * Scripts/webkitpy/style/checker_unittest.py:
3077         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3078         Added. Checks a few file names to see if carriage returns are allowed
3079         or not.
3080         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3081         other assert_checker_* functions.
3082         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3083         test_*_paths functions.
3084         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3085         test_*_paths functions.
3086         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3087         file from this test case, as vcproj files now have a type.
3088         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3089         Added. Similar to the other should_* functions.
3090         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3091         Added. Checks that carriage returns aren't checked for or stripped for
3092         allowed files.
3093
3094         * Scripts/webkitpy/style/checkers/xml.py: Added.
3095         (XMLChecker.__init__): Simple init method.
3096         (XMLChecker.check): Pass each line through the expat parser, and record
3097         a style error for any errors thrown by the parser.
3098
3099         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3100         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3101         produce a style error.
3102         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3103         error of the given category on the given line.
3104         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3105         checking that the XMLChecker constructor works properly.
3106         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3107         cause a style error (see, e.g., r73887).
3108         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3109         cause a style error (see, e.g., r73773).
3110         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3111         properly.
3112         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3113         tags cause a style error (see, e.g., r72795).
3114         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3115         style error.
3116
3117 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3118
3119         Reviewed by Stephanie Lewis.
3120
3121         https://bugs.webkit.org/show_bug.cgi?id=51117
3122         Add a new leopard test bot
3123         really really commit to trunk this time.
3124
3125         * BuildSlaveSupport/build.webkit.org-config/config.json:
3126
3127 2010-12-15  Sam Weinig  <sam@webkit.org>
3128
3129         Reviewed by Anders Carlsson.
3130
3131         WebKit2: Can't add files to an <input type=file>
3132         https://bugs.webkit.org/show_bug.cgi?id=51087
3133
3134         * MiniBrowser/mac/BrowserWindowController.m:
3135         (runOpenPanel):
3136         (-[BrowserWindowController awakeFromNib]):
3137         Add simple implementation of runOpenPanel callback.
3138
3139         * MiniBrowser/win/BrowserView.cpp:
3140         (BrowserView::create):
3141         * WebKitTestRunner/TestController.cpp:
3142         (WTR::createOtherPage):
3143         (WTR::TestController::initialize):
3144         Stub out runOpenPanel callback.
3145
3146 2010-12-14  Eric Seidel  <eric@webkit.org>
3147
3148         Reviewed by Adam Barth.
3149
3150         commit-queue should upload failure diffs when tests flake
3151         https://bugs.webkit.org/show_bug.cgi?id=51051
3152
3153         To make this testable I needed to pipe FileSystem down onto tool.
3154         We've wanted it there for a long time anyway.
3155
3156         This patch is kinda a big hack.  But we don't have a nice
3157         way to read results.html files.  I think this will need further
3158         revision before this code actually feels clean.
3159
3160         As part of testing this change, I had to make MockBugzilla.create_bug
3161         actually return an id (like it should) which required updating
3162         a few other unit test results (for the better).
3163
3164         The results_matching_keys change in layouttestresults/rebasline
3165         was an alternate path which I decided not to use in the end, but
3166         I left the change as it seemed an improvement.
3167
3168         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3169         * Scripts/webkitpy/common/net/layouttestresults.py:
3170         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3171         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3172         * Scripts/webkitpy/tool/commands/queues.py:
3173         * Scripts/webkitpy/tool/commands/rebaseline.py:
3174         * Scripts/webkitpy/tool/main.py:
3175         * Scripts/webkitpy/tool/mocktool.py:
3176
3177 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3178
3179         Reviewed by James Robinson.
3180
3181         new-run-webkit-tests ignores trailing EOL differences in text tests
3182         https://bugs.webkit.org/show_bug.cgi?id=36983
3183
3184         Changed the handling of new-line characters within new-run-webkit-tests
3185         to match old-run-webkit-tests.  Differences in leading and trailing empty
3186         lines in text expectation files are no longer ignored.
3187
3188         * Scripts/webkitpy/layout_tests/port/base.py:
3189         * Scripts/webkitpy/layout_tests/port/test.py:
3190         Added unit tests.  Removed old duplicate unit test entries.
3191         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3192
3193 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3194
3195         Reviewed by Adam Barth.
3196
3197         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3198         https://bugs.webkit.org/show_bug.cgi?id=51149
3199
3200         * QueueStatusServer/templates/statusbubble.html:
3201
3202 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3203
3204         Reviewed by Adam Barth.
3205
3206         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3207         https://bugs.webkit.org/show_bug.cgi?id=51125
3208
3209         * QueueStatusServer/templates/statusbubble.html:
3210
3211 2010-12-15  Darin Adler  <darin@apple.com>
3212
3213         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3214
3215 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3216
3217         Unreviewed, rolling out r74117.
3218         http://trac.webkit.org/changeset/74117
3219         https://bugs.webkit.org/show_bug.cgi?id=51113
3220
3221         This broke the GTK1 build. (Requested by mrobinson on
3222         #webkit).
3223
3224         * Scripts/webkitdirs.pm:
3225
3226 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3227
3228         Reviewed by Martin Robinson.
3229
3230         Change generate-forwarding-headers.pl for GTK port usage
3231         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3232
3233         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3234
3235 2010-12-14  Kent Tamura  <tkent@chromium.org>
3236
3237         Reviewed by Jian Li.
3238
3239         [DRT/Chromium] Remove another unnecessary error message
3240         https://bugs.webkit.org/show_bug.cgi?id=51083
3241
3242         * DumpRenderTree/chromium/WebViewHost.cpp:
3243         (WebViewHost::didInvalidateRect):
3244
3245 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3246
3247         Reviewed by Stephanie Lewis.
3248
3249         Add a new Leopard Debug Test WK2 Bot
3250
3251         * BuildSlaveSupport/build.webkit.org-config/config.json:
3252
3253 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3254
3255         Fix python unittests after http://trac.webkit.org/changeset/74070.
3256
3257         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3258
3259 2010-12-14  Kent Tamura  <tkent@chromium.org>
3260
3261         Reviewed by Jian Li.
3262
3263         [DRT/Chromium] Remove a unnecessary error message
3264         https://bugs.webkit.org/show_bug.cgi?id=51069
3265
3266         * DumpRenderTree/chromium/WebViewHost.cpp:
3267         (WebViewHost::paintInvalidatedRegion):
3268
3269 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3270
3271         Reviewed by Ojan Vafai.
3272
3273         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3274         https://bugs.webkit.org/show_bug.cgi?id=48926
3275
3276         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3277         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3278
3279 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3280
3281         Reviewed by Eric Seidel.
3282
3283         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3284         https://bugs.webkit.org/show_bug.cgi?id=50231
3285
3286         Guard CONFIG+=link_pkgconfig with !symbian.
3287
3288         * DumpRenderTree/qt/DumpRenderTree.pro:
3289         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3290         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3291
3292 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3293
3294         Reviewed by Ojan Vafai.
3295
3296         [new-run-webkit-tests] expectations parsing is slow
3297         https://bugs.webkit.org/show_bug.cgi?id=50635
3298
3299         Avoid expensive iteration of all the tests when checking if a test
3300         file is to be skipped or not.
3301
3302         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3303         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3304         * Scripts/webkitpy/layout_tests/port/test.py:
3305
3306 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3307
3308         Reviewed by Xan Lopez.
3309
3310         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3311         https://bugs.webkit.org/show_bug.cgi?id=27048
3312
3313         Add support in DRT for checking whether an accessibility UI
3314         element is focusable and/or focused. Implemented for GTK.
3315
3316         * DumpRenderTree/AccessibilityUIElement.cpp:
3317         (getIsFocusedCallback): New.
3318         (getIsFocusableCallback): New.
3319         (AccessibilityUIElement::getJSClass): Add the new available
3320         callbacks for isFocused and isFocusable.
3321         * DumpRenderTree/AccessibilityUIElement.h:
3322         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3323         (AccessibilityUIElement::isFocused): New, implemented by checking
3324         whether the related AtkState value is in the object's state set.
3325         (AccessibilityUIElement::isFocusable): Ditto.
3326         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3327         (AccessibilityUIElement::isFocused): New, dummy implementation.
3328         (AccessibilityUIElement::isFocusable): Ditto.
3329         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3330         (AccessibilityUIElement::isFocused): Ditto.
3331         (AccessibilityUIElement::isFocusable): Ditto.
3332
3333 2010-12-14  Eric Seidel  <eric@webkit.org>
3334
3335         Reviewed by Ojan Vafai.
3336
3337         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3338         https://bugs.webkit.org/show_bug.cgi?id=50715
3339
3340         This patch makes webkit-patch print the following:
3341
3342         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3343         Install a 64-bit git for better performance, see:
3344         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3345
3346         I wrote this mostly because I have approximately 8 machines that I use
3347         and making sure each one is using a good Git install seemed folly.
3348         webkit-patch makes a lot of git calls, so using a fast git can shave
3349         several seconds in every invocation.  See the webkit-dev thread for more info.
3350
3351         This message will print twice during 'webkit-patch upload',
3352         once from webkit-patch and once from check-webkit-style.
3353
3354         Unfortunately there is no good way to test this due to how machine-dependent
3355         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3356
3357         * Scripts/webkitpy/common/checkout/scm.py:
3358
3359 2010-12-13  Eric Seidel  <eric@webkit.org>
3360
3361         Reviewed by Adam Barth.
3362
3363         FlakyTestReporter doesn't understand bots running from multiple email addresses
3364         https://bugs.webkit.org/show_bug.cgi?id=50960
3365
3366         This explains at least one of the dupes of:
3367         https://bugs.webkit.org/show_bug.cgi?id=50863
3368         that we saw filed by the commit-queue this morning.
3369         I think the other one was explained by my previous fix to result counting code.
3370
3371         Since this is really hard to test with a unit test, instead I
3372         create a new (possibly useful in the future) command
3373         which given a layout test path will return you
3374         the one bug which our tools would assume it the flaky test bug.
3375         If some other script wants to use bug-for-test we'll
3376         need to extend it with some options like --create-if-missing or similar.
3377
3378         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3379         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3380         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3381         * Scripts/webkitpy/tool/commands/__init__.py:
3382         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3383
3384 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3385
3386         Reviewed by James Robinson.
3387
3388         Add option to build-webkit to not build WebKit2
3389         https://bugs.webkit.org/show_bug.cgi?id=50988
3390
3391         Add support for a --no-webkit2 option to build-webkit. It seems to save
3392         ~1 minute from clean builds and ~10 seconds from no-op builds.
3393
3394         * Scripts/build-webkit:
3395
3396 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3397
3398         Reviewed by Dave Kilzer.
3399
3400         Update iexploder from 1.3.2 to 1.7.2
3401         Move 1.3.2 into its own subdir
3402         Add 1.7.2 into its own subdir
3403         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3404
3405         * Scripts/run-iexploder-tests:
3406         * Scripts/update-iexploder-cssproperties:
3407         * iExploder/CHANGELOG.txt: Removed.
3408         * iExploder/LICENSE.txt: Removed.
3409         * iExploder/README.txt: Removed.
3410         * iExploder/htdocs: Removed.
3411         * iExploder/iexploder-1.3.2: Added.
3412         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3413         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3414         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3415         * iExploder/iexploder-1.3.2/htdocs: Added.
3416         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3417         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3418         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3419         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3420         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3421         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3422         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3423         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3424         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3425         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3426         * iExploder/iexploder-1.3.2/tools: Added.
3427         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3428         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3429         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3430         * iExploder/iexploder-1.7.2: Added.
3431         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3432         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3433         * iExploder/iexploder-1.7.2/README.txt: Added.
3434         * iExploder/iexploder-1.7.2/output: Added.
3435         * iExploder/iexploder-1.7.2/src: Added.
3436         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3437         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3438         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3439         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3440         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3441         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3442         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3443         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3444         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3445         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3446         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3447         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3448         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3449         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3450         * iExploder/iexploder-1.7.2/src/css-values: Added.
3451         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3452         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3453         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3454         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3455         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3456         * iExploder/iexploder-1.7.2/src/headers: Added.
3457         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3458         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3459         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3460         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3461         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3462         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3463         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3464         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3465         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3466         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3467         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3468         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3469         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3470         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3471         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3472         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3473         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3474         * iExploder/iexploder-1.7.2/src/html-values: Added.
3475         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3476         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3477         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3478         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3479         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3480         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3481         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3482         * iExploder/iexploder-1.7.2/src/index.html: Added.
3483         * iExploder/iexploder-1.7.2/src/media: Added.
3484         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3485         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3486         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3487         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3488         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3489         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3490         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3491         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3492         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3493         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3494         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3495         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3496         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3497         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3498         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3499         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3500         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3501         * iExploder/iexploder-1.7.2/src/protocols: Added.
3502         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3503         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3504         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3505         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3506         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3507         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3508         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3509         * iExploder/iexploder-1.7.2/testcases: Added.
3510         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3511         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3512         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3513         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3514         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3515         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3516         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3517         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3518         * iExploder/iexploder-1.7.2/tools: Added.
3519         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3520         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3521         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3522         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3523         * iExploder/tools: Removed.
3524
3525 2010-12-13  Sam Weinig  <sam@webkit.org>
3526
3527         Reviewed by Anders Carlsson.
3528
3529         Remove associated page concept from WKView constructor
3530         https://bugs.webkit.org/show_bug.cgi?id=50983
3531
3532         Step 1: Remove associate page constructors from WKView and make
3533         all views use the shared namespace for the context.
3534
3535         * TestWebKitAPI/PlatformWebView.h:
3536         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3537         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3538         * WebKitTestRunner/PlatformWebView.h:
3539         * WebKitTestRunner/TestController.cpp:
3540         (WTR::createOtherPage):
3541         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3542         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3543         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3544
3545 2010-12-13  Sam Weinig  <sam@webkit.org>
3546
3547         Reviewed by Anders Carlsson.
3548
3549         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3550         https://bugs.webkit.org/show_bug.cgi?id=50898
3551
3552         * MiniBrowser/mac/AppDelegate.h:
3553         * MiniBrowser/mac/AppDelegate.m:
3554         * MiniBrowser/mac/BrowserWindowController.h:
3555         * MiniBrowser/mac/BrowserWindowController.m:
3556         * MiniBrowser/win/BrowserView.cpp:
3557         Convert MiniBrowser to not use PageNamespaces.
3558
3559         * TestWebKitAPI/PlatformWebView.h:
3560         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3561         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3562         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3563         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3564         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3565         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3566         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3567         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3568         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3569         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3570         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3571         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3572         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3573         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3574         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3575         Convert TestWebKitAPI to not use PageNamespaces.
3576
3577         * WebKitTestRunner/PlatformWebView.h:
3578         * WebKitTestRunner/TestController.cpp:
3579         * WebKitTestRunner/TestController.h:
3580         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3581         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3582         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3583         Convert WebKitTestRunner to not use PageNamespaces.
3584
3585 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3586
3587         Reviewed by Eric Seidel.
3588
3589         webkit-patch rollout should be able to do multi-revision rollouts
3590         https://bugs.webkit.org/show_bug.cgi?id=33336
3591
3592         Make it possible to pass more than one revision to webkit-patch.
3593
3594         * Scripts/webkitpy/common/checkout/api.py:
3595         * Scripts/webkitpy/common/checkout/changelog.py:
3596         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3597         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3598         * Scripts/webkitpy/tool/commands/download.py:
3599         * Scripts/webkitpy/tool/commands/download_unittest.py:
3600         * Scripts/webkitpy/tool/mocktool.py:
3601         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3602         * Scripts/webkitpy/tool/steps/revertrevision.py:
3603
3604 2010-12-13  Eric Seidel  <eric@webkit.org>
3605
3606         Unreviewed.
3607
3608         Teach webkit-patch how to search bugzilla
3609         https://bugs.webkit.org/show_bug.cgi?id=50500
3610
3611         webkit-patch bug-search fails when there is only one result.
3612         Turns out we needed a bit more logic in our result count parsing code.
3613
3614         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3615         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3616
3617 2010-12-13  Antti Koivisto  <antti@apple.com>
3618
3619         Reviewed by Alexey Proskuryakov.
3620
3621         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3622         https://bugs.webkit.org/show_bug.cgi?id=50758
3623
3624         * DumpRenderTree/LayoutTestController.cpp:
3625         (setSerializeHTTPLoadsCallback):
3626         (LayoutTestController::staticFunctions):
3627         * DumpRenderTree/LayoutTestController.h:
3628         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3629         (LayoutTestController::setSerializeHTTPLoads):
3630         * DumpRenderTree/mac/DumpRenderTree.mm:
3631         (resetDefaultsToConsistentValues):
3632         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3633         (LayoutTestController::setSerializeHTTPLoads):
3634         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3635         (LayoutTestController::setSerializeHTTPLoads):
3636
3637 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3638
3639         Reviewed by Ojan Vafai.
3640
3641         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3642         https://bugs.webkit.org/show_bug.cgi?id=50936
3643
3644         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
3645
3646 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
3647
3648         Reviewed by Csaba Osztrogonác.
3649
3650         Add revlink to BuildBot status
3651         https://bugs.webkit.org/show_bug.cgi?id=50914
3652
3653         This adds a hyperlink to trac changeset on the revision numbers.
3654
3655         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3656
3657 2010-12-13  Andras Becsi  <abecsi@webkit.org>
3658
3659         Reviewed by Csaba Osztrogonác.
3660
3661         [Qt][WK2] Fix build if WebKitTools are not available
3662         https://bugs.webkit.org/show_bug.cgi?id=50242
3663
3664         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
3665         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
3666         * MiniBrowser/DerivedSources.pro: Added.
3667
3668 2010-12-13  Eric Seidel  <eric@webkit.org>
3669
3670         Reviewed by Adam Barth.
3671
3672         EWS Queues should remove orpahned pyc files before starting
3673         https://bugs.webkit.org/show_bug.cgi?id=50904
3674
3675         A previous check added a platform.py which caused
3676         EWS bots on some platforms to hit an import exception.
3677         The platform.py file was removed in a subsequent commit, but
3678         the EWS bots in question stayed stuck.  This change will
3679         fix those bots once restarted (and prevent this in the future).
3680
3681         I also went ahead and unified start-queue and start-commit-queue
3682         since they were nearly identical.  I also added bot_id support
3683         to both force all EWSes to have bot ids as well as get rid of the one
3684         remaining reason why I had my own copies of these scripts.
3685         Hopefully this will be enough to get all the other bot admins
3686         (ahem, Adam, ahem) to move to using these checked in copies as well.
3687
3688         * EWSTools/start-commit-queue.sh: Removed.
3689         * EWSTools/start-queue.sh:
3690
3691 2010-10-28  MORITA Hajime  <morrita@google.com>
3692
3693         Reviewed by Ojan Vafai.
3694
3695         spellcheck does not check pasted text
3696         https://bugs.webkit.org/show_bug.cgi?id=40092
3697
3698         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
3699         to control the setting.
3700
3701         * DumpRenderTree/LayoutTestController.cpp:
3702         (setAsynchronousSpellCheckingEnabledCallback):
3703         (LayoutTestController::staticFunctions):
3704         * DumpRenderTree/LayoutTestController.h:
3705         * DumpRenderTree/chromium/LayoutTestController.h:
3706         * DumpRenderTree/chromium/LayoutTestController.cpp:
3707         (LayoutTestController::LayoutTestController):
3708         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3709         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3710         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3711         * DumpRenderTree/mac/DumpRenderTree.mm:
3712         (resetDefaultsToConsistentValues):
3713         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3714         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3715         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3716         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3717         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3718         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3719         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3720         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3721         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3722
3723 2010-12-12  Sam Weinig  <sam@webkit.org>
3724
3725         Reviewed by Anders Carlsson.
3726
3727         Fix failing API test. It turns out that a pop-state event
3728         is sent before every fragment navigation, so we have to test
3729         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
3730
3731         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3732         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3733
3734 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
3735
3736         Reviewed by Eric Seidel.
3737
3738         [GTK] Add new-run-webkit-tests support to gtk
3739         https://bugs.webkit.org/show_bug.cgi?id=50681
3740
3741         Adding the basic support to run the new-run-webkit-tests.
3742
3743         * Scripts/webkitpy/layout_tests/port/gtk.py:
3744
3745 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
3746
3747         Reviewed by Kenneth Rohde Christiansen.
3748
3749         [Qt] Mock DeviceOrientation client for DRT
3750         https://bugs.webkit.org/show_bug.cgi?id=47490
3751
3752         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3753         (WebCore::DumpRenderTree::DumpRenderTree):
3754         (WebCore::DumpRenderTree::~DumpRenderTree):
3755         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3756         (LayoutTestController::setMockDeviceOrientation):
3757
3758 2010-12-11  Philippe Normand  <pnormand@igalia.com>
3759
3760         Reviewed by Gustavo Noronha Silva.
3761
3762         [GTK] launcher: disable the Mozilla-style fullscreen API
3763         https://bugs.webkit.org/show_bug.cgi?id=50874
3764
3765         Disabling the fullscreen API until its implementation for GTK is
3766         mature enough. The webview setting for it is already FALSE by
3767         default.
3768
3769         * GtkLauncher/main.c:
3770         (createWindow):
3771
3772 2010-12-10  Eric Seidel  <eric@webkit.org>
3773
3774         Reviewed by Adam Barth.
3775
3776         commit-queue flaky test messages show cryptic version information for mac os x
3777         https://bugs.webkit.org/show_bug.cgi?id=50864
3778
3779         Turns out platform.platform() returns kernel version information
3780         which isn't helpful, and just plain confusing on Mac
3781         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
3782
3783         So I've updated PlatformInfo.display_name() to special case
3784         mac.  I also found a bad use of sys.platform in the process
3785         and fixed that.  (sys.platform always returns 'darwin' on mac).
3786
3787         * Scripts/webkitpy/common/system/platforminfo.py:
3788         * Scripts/webkitpy/common/system/user.py:
3789         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3790         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3791         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3792
3793 2010-12-10  Eric Seidel  <eric@webkit.org>
3794
3795         Unreviewed.
3796
3797         Exception seen while reporting flaky test with commit-queue.
3798         Just a missing include.
3799
3800         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3801         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3802
3803 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
3804
3805         Reviewed by Eric Seidel.
3806
3807         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
3808         https://bugs.webkit.org/show_bug.cgi?id=50796
3809
3810         Also updating the test code to use JSONResultsGeneratorBase and
3811         to improve test coverage for incremental cases.
3812
3813         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3814         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3815
3816 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
3817
3818         Reviewed by Darin Adler.
3819
3820         prepare-ChangeLog --help doesn't mention --bug shorthand -b
3821         https://bugs.webkit.org/show_bug.cgi?id=50835
3822
3823         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
3824
3825 2010-12-10  Eric Seidel  <eric@webkit.org>
3826
3827         Reviewed by Adam Barth.
3828
3829         Bugs created by the commit-queue should all block on a master bug
3830         https://bugs.webkit.org/show_bug.cgi?id=50857
3831
3832         This makes all bugs created by the commit-queue block on:
3833         https://bugs.webkit.org/show_bug.cgi?id=50856
3834
3835         In the process of testing this, I found that the existing
3836         create_bug code was wrong.  I also found that existing
3837         unit tests for create-rollout used invalid values
3838         for options.blocks.  I fixed both issues and tested.
3839
3840         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3841         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3842         * Scripts/webkitpy/tool/commands/commandtest.py:
3843         * Scripts/webkitpy/tool/commands/download_unittest.py:
3844         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3845         * Scripts/webkitpy/tool/mocktool.py:
3846         * Scripts/webkitpy/tool/steps/options.py:
3847
3848 2010-12-10  Eric Seidel  <eric@webkit.org>
3849
3850         Reviewed by Adam Barth.
3851
3852         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
3853         https://bugs.webkit.org/show_bug.cgi?id=50853
3854
3855         I also discovered when doing this that the code was posting
3856         the comment on the wrong bug, but that's fixed here too.
3857
3858         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3859         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3860         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3861         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3862         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3863         * Scripts/webkitpy/tool/mocktool.py:
3864
3865 2010-12-10  Anders Carlsson  <andersca@apple.com>
3866
3867         Reviewed by John Sullivan.
3868
3869         Make WKContextGetStatistics gather global statistics
3870         https://bugs.webkit.org/show_bug.cgi?id=50850
3871
3872         Remove the code that gets the statistics and fills in the per context
3873         statistics information for now.
3874
3875         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3876         (-[BrowserStatisticsWindowController refreshStatistics:]):
3877
3878 2010-12-10  Eric Seidel  <eric@webkit.org>
3879
3880         Unreviewed.
3881
3882         commit-queue should report port/platform information when commenting on flaky test bugs
3883         https://bugs.webkit.org/show_bug.cgi?id=50839
3884
3885         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
3886         which was only used by new run webkit tests (and clearly not unit tested).
3887
3888         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
3889         * Scripts/webkitpy/tool/main.py:
3890         * Scripts/webkitpy/tool/mocktool.py:
3891
3892 2010-12-10  Eric Seidel  <eric@webkit.org>
3893
3894         Reviewed by Tony Chang.
3895
3896         commit-queue should report port/platform information when commenting on flaky test bugs
3897         https://bugs.webkit.org/show_bug.cgi?id=50839
3898
3899         This was a suggestion from Tony Chang this morning.
3900         I added a platform.py class so I could easily mock the platform call,
3901         but that may not be the final solution for this mocking.
3902         We'll try it and see.
3903
3904         * Scripts/webkitpy/common/system/platform.py: Added.
3905         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3906         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3907         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3908         * Scripts/webkitpy/tool/main.py:
3909         * Scripts/webkitpy/tool/mocktool.py:
3910
3911 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
3912
3913         Reviewed by Joseph Pecoraro.
3914
3915         Bug 43455 - [Qt]: Implement Application Cache Quotas
3916         https://bugs.webkit.org/show_bug.cgi?id=43455
3917
3918         Introduce functions to allow new appcache layout test origin-quota.html
3919         to work correctly under Qt.
3920
3921         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3922         (WebCore::DumpRenderTree::DumpRenderTree):
3923         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
3924         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3925
3926         Introduce functions to allow new appcache layout test origin-quota.html
3927         to be successful under qt. Changes required because LayoutTestControllerQt
3928         does not inherit from LayoutController.
3929
3930         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3931         (LayoutTestController::reset):
3932         (LayoutTestController::clearAllApplicationCaches):
3933         (LayoutTestController::setApplicationCacheOriginQuota):
3934         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3935         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
3936         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
3937
3938 2010-12-10  Eric Seidel  <eric@webkit.org>
3939
3940         Reviewed by Adam Barth.
3941
3942         Move buildbot.py into its own module so we can split it out into one-file-per-class
3943         https://bugs.webkit.org/show_bug.cgi?id=50806
3944
3945         We're adding more buildbot logic these days, so it makes sense
3946         to give buildbot its own module.
3947
3948         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
3949         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
3950         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
3951         * Scripts/webkitpy/common/net/failuremap.py:
3952         * Scripts/webkitpy/common/net/regressionwindow.py:
3953         * Scripts/webkitpy/tool/commands/rebaseline.py:
3954
3955 2010-12-10  Tony Chang  <tony@chromium.org>
3956
3957         Reviewed by Eric Seidel.
3958
3959         Use FileSystem::remove when cleaning up http lock files
3960         https://bugs.webkit.org/show_bug.cgi?id=50830
3961
3962         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3963
3964 2010-12-10  Joone Hur  <joone@kldp.org>
3965
3966         Reviewed by Martin Robinson.
3967
3968         [GTK] DRT needs layoutTestController.setCacheModel
3969         https://bugs.webkit.org/show_bug.cgi?id=50705
3970
3971         webkit_set_cache_mode() is called to set the cache model.
3972
3973         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3974         (LayoutTestController::setCacheModel): Set the cache model.
3975
3976 2010-12-10  Tony Chang  <tony@chromium.org>
3977
3978         Reviewed by Ojan Vafai.
3979
3980         [chromium] remove --use-drt and add --use-test-shell
3981         https://bugs.webkit.org/show_bug.cgi?id=50701
3982
3983         * Scripts/webkitpy/common/config/ports.py:
3984         * Scripts/webkitpy/common/config/ports_unittest.py:
3985         * Scripts/webkitpy/layout_tests/port/chromium.py:
3986         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3987         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3988         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3989         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3990         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3991         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3992         * Scripts/webkitpy/layout_tests/port/webkit.py:
3993         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3994         * Scripts/webkitpy/style/checkers/test_expectations.py:
3995         * Scripts/webkitpy/tool/commands/queries.py:
3996
3997 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
3998
3999         Reviewed by Steve Block.
4000
4001         [Chromium] Implement mocks for client-based geolocation
4002         https://bugs.webkit.org/show_bug.cgi?id=46895
4003
4004         * DumpRenderTree/chromium/LayoutTestController.cpp:
4005         (LayoutTestController::setGeolocationPermission):
4006         (LayoutTestController::setMockGeolocationPosition):
4007         (LayoutTestController::setMockGeolocationError):
4008         * DumpRenderTree/chromium/LayoutTestController.h:
4009         * DumpRenderTree/chromium/WebViewHost.cpp:
4010         (WebViewHost::geolocationClient):
4011         (WebViewHost::geolocationClientMock):
4012         (WebViewHost::reset):
4013         * DumpRenderTree/chromium/WebViewHost.h:
4014
4015 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
4016
4017         Reviewed by Martin Robinson.
4018
4019         [GTK] Add hasSpellingMarker support to the DRT
4020         https://bugs.webkit.org/show_bug.cgi?id=50739
4021
4022         Implemented the hasSpellingMarker to support spelling tests.
4023
4024         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4025         (LayoutTestController::hasSpellingMarker):
4026
4027 2010-12-10  Eric Seidel  <eric@webkit.org>
4028
4029         Reviewed by Ojan Vafai.
4030
4031         webkit-patch: not possible to use build-and-test with local commits
4032         https://bugs.webkit.org/show_bug.cgi?id=33378
4033
4034         Make --no-clean not even check if we have local commits.
4035         It's unclear to me why the code was originally written this way.
4036         I was unable to dig up a reason from svn history.
4037
4038         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4039         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
4040
4041 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
4042
4043         Reviewed by Martin Robinson.
4044
4045         [GTK] AX: implement isEnabled in DRT
4046         https://bugs.webkit.org/show_bug.cgi?id=50814
4047
4048         Implement AccessibilityUIElement::isEnabled() for GTK.
4049
4050         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4051         (checkElementState): New function to refactor common code.
4052         (AccessibilityUIElement::isEnabled): Implement this by checking
4053         the current state of the AtkObject.
4054         (AccessibilityUIElement::isSelected): Use the new
4055         checkElementState function.
4056
4057 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4058
4059         Reviewed by Kenneth Rohde Christiansen.
4060
4061         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
4062         https://bugs.webkit.org/show_bug.cgi?id=50750
4063
4064         * MiniBrowser/qt/BrowserView.cpp:
4065         (BrowserView::BrowserView):
4066         * MiniBrowser/qt/BrowserView.h:
4067         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4068         (WTR::WebView::WebView):
4069
4070 2010-12-10  Joone Hur  <joone@kldp.org>
4071
4072         Reviewed by Xan Lopez.
4073
4074         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
4075         https://bugs.webkit.org/show_bug.cgi?id=50808
4076
4077         Unskipping the following test cases:
4078         userscripts/mixed-case-stylesheet.html
4079         userscripts/simple-stylesheet.html
4080         userscripts/user-style-all-frames.html
4081
4082         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4083         (LayoutTestController::addUserStyleSheet):
4084
4085 2010-12-10  Joone Hur  <joone@kldp.org>
4086
4087         Reviewed by Eric Seidel.
4088
4089         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
4090         https://bugs.webkit.org/show_bug.cgi?id=50783
4091
4092         This patch allows to unskip the following test cases:
4093         printing/page-rule-selection.html
4094         printing/page-format-data.html
4095
4096         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4097         (LayoutTestController::pageProperty): Added.
4098         (LayoutTestController::isPageBoxVisible): Ditto.
4099         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
4100         (LayoutTestController::addUserStyleSheet): Ditto.
4101
4102 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4103
4104         Reviewed by Kenneth Rohde Christiansen.
4105
4106         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
4107
4108         A menu allows to switch QNAM back to the same thread.
4109
4110         * QtTestBrowser/launcherwindow.cpp:
4111         (LauncherWindow::initializeView):
4112         (LauncherWindow::createChrome):
4113         (LauncherWindow::toggleThreadedQnam):
4114         * QtTestBrowser/launcherwindow.h:
4115         (WindowOptions::WindowOptions):
4116         * QtTestBrowser/webpage.cpp:
4117         (WebPage::WebPage):
4118         (WebPage::setQnamThreaded):
4119         * QtTestBrowser/webpage.h:
4120         (QnamThread::QnamThread):
4121         (QnamThread::~QnamThread):
4122         (QnamThread::networkAccessManager):
4123         (QnamThread::run):
4124
4125 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
4126
4127         Reviewed by Xan Lopez.
4128
4129         [Gtk] style="font-family: courier" makes text disappear
4130         https://bugs.webkit.org/show_bug.cgi?id=47452
4131
4132         Add a test that verifies that fonts without valid charmaps are
4133         never selected.
4134
4135         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4136         (initializeFonts): Initialize DRT with our font (derived from Ahem)
4137         that has no valid charmap.
4138         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
4139         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
4140         settings which may disable selection of bitmap fonts.
4141
4142 2010-12-10  Eric Seidel  <eric@webkit.org>
4143
4144         Unreviewed.
4145
4146         The commit-queue should file bugs about flaky tests it encounters
4147         https://bugs.webkit.org/show_bug.cgi?id=50803
4148
4149         create_bug_for_flaky_test was insufficiently tested, thus buggy.
4150         Now it's tested.
4151
4152         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4153         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4154
4155 2010-12-10  Eric Seidel  <eric@webkit.org>
4156
4157         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
4158
4159         The commit-queue should file bugs about flaky tests it encounters
4160         https://bugs.webkit.org/show_bug.cgi?id=50803
4161
4162         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4163
4164 2010-12-09  Eric Seidel  <eric@webkit.org>
4165
4166         Reviewed by Adam Barth.
4167
4168         The commit-queue should file bugs about flaky tests it encounters
4169         https://bugs.webkit.org/show_bug.cgi?id=50803
4170
4171         This change got a bit big.  I also added a new config.urls file
4172         because I needed to share the view_source_url code with committervalidator.py.
4173
4174         This adds a new class FlakyTestReporter which holds all the logic about
4175         reporting flaky tests to bugzilla.
4176
4177         Right now this code knows how to look up bugs for flaky tests.
4178         If it can't find a bug filed from the commit-queue, it will open a new
4179         one, ccing the relevant people and adding information about the failure.
4180
4181         It is not yet smart enough to chase down duplicate chains, or to include
4182         the actual failure diff.  But those can be added in later iterations.
4183
4184         * Scripts/webkitpy/common/checkout/api.py:
4185         * Scripts/webkitpy/common/checkout/changelog.py:
4186         * Scripts/webkitpy/common/checkout/commitinfo.py:
4187         * Scripts/webkitpy/common/config/committervalidator.py:
4188         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
4189         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4190         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
4191         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
4192         * Scripts/webkitpy/tool/bot/irc_command.py:
4193         * Scripts/webkitpy/tool/bot/sheriff.py:
4194         * Scripts/webkitpy/tool/commands/download.py:
4195         * Scripts/webkitpy/tool/commands/queues.py:
4196         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4197         * Scripts/webkitpy/tool/comments.py:
4198         * Scripts/webkitpy/tool/mocktool.py:
4199         * Scripts/webkitpy/tool/steps/commit.py:
4200
4201 2010-12-09  Eric Seidel  <eric@webkit.org>
4202
4203         Reviewed by Adam Barth.
4204
4205         Teach webkit-patch how to search bugzilla
4206         https://bugs.webkit.org/show_bug.cgi?id=50500
4207
4208         This is a step towards teaching webkitpy how to file
4209         new bugs for flaky tests and update them when new flakes occur.
4210
4211         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4212         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4213         * Scripts/webkitpy/tool/commands/__init__.py:
4214         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
4215
4216 2010-12-09  Adam Barth  <abarth@webkit.org>
4217
4218         Reviewed by Ojan Vafai.
4219
4220         commit-queue errors out due to local commits
4221         https://bugs.webkit.org/show_bug.cgi?id=50766
4222
4223         We seem to be tripping over having local commits in the working copy a
4224         lot recently.  I don't quite fully understand what the issue is, but
4225         this patch attempts to solve the problem by adding an explicit clean
4226         step before processing a patch.  Previously, we did the cleaning as
4227         part of the apply-attachment step, so this might not actually fix the
4228         problem.
4229
4230         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4231         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4232         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4233
4234 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
4235
4236         Reviewed by Ojan Vafai.
4237
4238         Make new-run-webkit-tests --lint-test-files log slightly better
4239         messages and return -1 if lint fails. Remove the
4240         'suppress_errors' keyword param to the TestExpectationsFile
4241         class, and clean up logging and exception raising for error
4242         handling. Also add more unit tests and clean up the unit test code a bit.
4243
4244         https://bugs.webkit.org/show_bug.cgi?id=50205
4245
4246         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4247         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4248         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
4249         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
4250         * Scripts/webkitpy/layout_tests/port/chromium.py:
4251         * Scripts/webkitpy/style/checkers/test_expectations.py:
4252         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4253
4254 2010-12-09  Tony Chang  <tony@chromium.org>
4255
4256         Unreviewed, fix for windows code.  We were catching the wrong
4257         exception in Windows.
4258
4259         * Scripts/webkitpy/common/system/filesystem.py:
4260
4261 2010-12-09  Antonio Gomes  <agomes@rim.com>
4262
4263         Reviewed by Martin Robinson.
4264
4265         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
4266         https://bugs.webkit.org/show_bug.cgi?id=48429
4267
4268         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
4269
4270         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4271         (LayoutTestController::workerThreadCount):
4272
4273 2010-12-06  Philippe Normand  <pnormand@igalia.com>
4274
4275         Reviewed by Martin Robinson.
4276
4277         [GTK] Support the Mozilla-style Fullscreen Javascript API
4278         https://bugs.webkit.org/show_bug.cgi?id=50572
4279
4280         Enable the Javascript Fullscreen support in the GtkLauncher. Also
4281         make DRT update the Chrome when the WebView settings have been
4282         reset to consistent values.
4283
4284         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4285         (resetDefaultsToConsistentValues):
4286         * GtkLauncher/main.c:
4287         (create_window):
4288         * Scripts/build-webkit:
4289
4290 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
4291
4292         Reviewed by Tor Arne Vestbø
4293
4294         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
4295         https://bugs.webkit.org/show_bug.cgi?id=50742
4296
4297         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
4298
4299         * Scripts/webkitdirs.pm:
4300
4301 2010-12-09  Joone Hur  <joone@kldp.org>
4302
4303          Reviewed by Martin Robinson.
4304
4305          [GTK] Support for viewport meta tag
4306          https://bugs.webkit.org/show_bug.cgi?id=45443
4307
4308          Add support for testing the viewport properties for WebKitGtk.
4309
4310          * DumpRenderTree/LayoutTestController.cpp:
4311          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
4312          (LayoutTestController::staticFunctions):
4313          * DumpRenderTree/LayoutTestController.h:
4314          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4315          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
4316          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4317          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4318          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4319          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4320          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4321          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4322          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4323          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4324
4325 2010-12-08  William Siegrist <wsiegrist@apple.com>
4326