db5deea556543503def65692b8eb7dfd839d879b
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
2
3         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
4         https://bugs.webkit.org/show_bug.cgi?id=69444
5
6         Reviewed by Tony Chang.
7
8         Currently if a test's image checksum doesn't match the checksum
9         in the baseline, but the images themselves match according to
10         ImageDiff, new-run-webkit-tests ignores the problem. This is
11         probably bad, but it's not yet clear what the right thing to do
12         is. This patch will log a warning to stderr, at least (but the
13         test will still pass).
14
15         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
16         (SingleTestRunner._compare_image):
17         (SingleTestRunner._run_reftest):
18         * Scripts/webkitpy/layout_tests/port/test.py:
19         (unit_test_list):
20         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
21
22 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
23
24         NRWT does not report failure for a skipped test
25         https://bugs.webkit.org/show_bug.cgi?id=78750
26
27         Reviewed by Eric Seidel.
28
29         If a test is listed in a Skipped file and you run it anyway
30         with --force, and the test fails, currently NRWT will print
31         "test ran as expected"; this is confusing, because you probably
32         expect the test to fail and yet this might lead you to think the
33         test passed. This patch changes the expected behavior to "PASS",
34         so tests that fail will be reported.
35
36         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
37         (result_was_expected):
38         (TestExpectationParser):
39         (TestExpectationParser.expectation_for_skipped_test):
40         (TestExpectations):
41         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
42         (test_add_skipped_tests):
43         * Scripts/webkitpy/layout_tests/port/test.py:
44         (unit_test_list): Add some tests that are expected to be in a Skipped file.
45         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
46
47 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
48
49         webkitpy: fix test code after bug 78181
50         https://bugs.webkit.org/show_bug.cgi?id=78870
51
52         Reviewed by Adam Barth.
53
54         I forgot to update the test code as per Tony's suggestion in
55         bug 78181 (r108005). This change does that, and in doing so
56         it revealed a subtle bug in _InlineWorkerConnection.run() that
57         I am fixing as part of this (_alive would not be cleared if an
58         exception was thrown).
59
60         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
61         (_InlineWorkerConnection.run):
62         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
63         (_TestWorker.__init__):
64         (_TestWorker.handle_stop):
65         (_TestWorker.handle_test):
66         (_TestWorker.run):
67         (_TestsMixin.handle_exception):
68         (_TestsMixin.test_unknown_message):
69
70 2012-02-17  Adam Roben  <aroben@apple.com>
71
72         Mac build fix after r108119
73
74         * DumpRenderTree/mac/DumpRenderTree.mm:
75         (runThread):
76         (runPthread):
77         (testThreadIdentifierMap):
78         Updated to match current WTF threading APIs.
79
80 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
81
82         revert r107147 - breaks webkit-patch on Mac SL
83         https://bugs.webkit.org/show_bug.cgi?id=78866
84
85         Reviewed by Adam Barth.
86
87         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
88         which is the version that ships on Mac SL. Reverting this
89         change until we no longer have to worry about that version.
90
91         * Scripts/webkitpy/common/system/autoinstall.py:
92         (AutoInstaller):
93         (AutoInstaller._extract_all): Added a comment about SL.
94         (AutoInstaller._unzip):
95
96 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
97
98         CSS regions enabled by default
99         https://bugs.webkit.org/show_bug.cgi?id=78525
100
101         Reviewed by David Hyatt.
102
103         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
104         CSSRegions are still enabled by default.
105         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
106
107         * DumpRenderTree/chromium/LayoutTestController.cpp:
108         (LayoutTestController::overridePreference):
109         * DumpRenderTree/chromium/WebPreferences.cpp:
110         (WebPreferences::reset):
111         (WebPreferences::applyTo):
112         * DumpRenderTree/chromium/WebPreferences.h:
113         (WebPreferences):
114         * DumpRenderTree/mac/DumpRenderTree.mm:
115         (resetDefaultsToConsistentValues):
116
117 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
118
119         Some API tests erroneously use = instead of == (causing build failures)
120         https://bugs.webkit.org/show_bug.cgi?id=78915
121
122         Reviewed by Sam Weinig.
123
124         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
125         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
126         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
127
128 2012-02-17  Peter Beverloo  <peter@chromium.org>
129
130         [Chromium] Include TestShellLinux.cpp in the build for Android
131         https://bugs.webkit.org/show_bug.cgi?id=78865
132
133         Reviewed by Eric Seidel.
134
135         Android will be re-using the TestShellLinux.cpp file. I already
136         added this r104033, but it seems to have gotten lost in the
137         recent refactorings.
138
139         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
140
141 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
142
143         Unreviewed, disable video build on EFL until it can be
144         supported by EFL build bot.
145
146         * Scripts/build-webkit:
147
148 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
149
150         [GTK] Implement zoom in/out in MiniBrowser
151         https://bugs.webkit.org/show_bug.cgi?id=75253
152
153         Reviewed by Gustavo Noronha Silva.
154
155         * MiniBrowser/gtk/BrowserWindow.c:
156         (browserWindowCanZoomIn):
157         (browserWindowCanZoomOut):
158         (browserWindowUpdateZoomActions):
159         (webViewZoomLevelChanged):
160         (zoomInCallback):
161         (zoomOutCallback):
162         (browser_window_init):
163         (browserWindowConstructed):
164
165 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
166
167         layoutTestController.display() is flaky for SVG tests
168         https://bugs.webkit.org/show_bug.cgi?id=78021
169
170         Reviewed by Adam Roben.
171
172         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
173         Size the web view before running the test, not when dumping.
174         All platforms handle this correctly now.
175
176         * DumpRenderTree/win/DumpRenderTree.cpp:
177         (dump):
178         (sizeWebViewForCurrentTest):
179         (runTest):
180
181 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
182
183         [GTK] Make install is broken when building without --enable-gtk-doc
184         https://bugs.webkit.org/show_bug.cgi?id=78828
185
186         Reviewed by Martin Robinson.
187
188         * gtk/generate-gtkdoc:
189         (rebase_installed_docs): Check documentation has been generated
190         before trying to rebase it.
191
192 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
193
194         nrwt: simplify worker interface
195         https://bugs.webkit.org/show_bug.cgi?id=78181
196
197         Reviewed by Tony Chang.
198
199         This change moves code in name(), is_done(), run(), and cancel()
200         from Worker to AbstractWorker, since the logic is pretty much
201         boilerplate code that any implementation would want to use.
202
203         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
204         (get.should):
205         (AbstractWorker.__init__):
206         (AbstractWorker):
207         (AbstractWorker.name):
208         (AbstractWorker.stop_handling_messages):
209         (AbstractWorker.run):
210         (AbstractWorker.is_done):
211         (AbstractWorker.cancel):
212         * Scripts/webkitpy/layout_tests/controllers/worker.py:
213         (Worker.__init__):
214         (Worker.run):
215         (Worker.handle_stop):
216
217 2012-02-16  Michael Saboff  <msaboff@apple.com>
218
219         ENH: Add ability to run subset of JavaScript layout tests with JSC
220         https://bugs.webkit.org/show_bug.cgi?id=78764
221
222         Reviewed by Gavin Barraclough.
223
224         New simple test drive shell script that runs a defined
225         list of javascript tests using jsc and the standalone-{pre,post}.js
226         wrappers.
227
228         * Scripts/run-fast-jsc: Added.
229
230 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
231
232         Add new Qt performance tester bot to build.webkit.org
233         https://bugs.webkit.org/show_bug.cgi?id=78795
234
235         Reviewed by Adam Roben.
236
237         * BuildSlaveSupport/build.webkit.org-config/config.json:
238
239 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
240
241         Disable inspector on WinCE.
242
243         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
244
245         * Scripts/build-webkit:
246
247 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
248
249         WinCE build fix after r107656.
250
251         Disable FTPDIR on WinCE, since it does not compile there.
252
253         * Scripts/build-webkit:
254
255 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
256
257         Build fix after r107863.
258
259         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
260
261 2012-02-15  Tony Chang  <tony@chromium.org>
262
263         [chromium] add linux dbg back to garden-o-matic
264         https://bugs.webkit.org/show_bug.cgi?id=78752
265
266         Reviewed by Adam Barth.
267
268         This reflects the current linux debug bot name (there's only one bot).
269         I'm also remove the mac clang builder since it doesn't exist (mac
270         always uses clang now).
271
272         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
273         * Scripts/webkitpy/layout_tests/port/builders.py:
274
275 2012-02-15  Sam Weinig  <sam@webkit.org>
276
277         Add style check for ctype functions that are generally frowned upon in WebKit
278         https://bugs.webkit.org/show_bug.cgi?id=78748
279
280         Reviewed by Anders Carlsson.
281
282         Not every platform has DisallowCType.h to check for uses of the ctype.h
283         functions, so add a style check for them as well.
284
285         * Scripts/webkitpy/style/checkers/cpp.py:
286         (check_ctype_functions):
287         (check_style):
288         (CppChecker):
289         Add check.
290
291         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
292         (WebKitStyleTest.test_ctype_fucntion):
293         Add checker.
294
295 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
296
297         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
298         https://bugs.webkit.org/show_bug.cgi?id=76546
299
300         Reviewed by Simon Hausmann.
301
302         Resize the web view programatically because the declarative property binding
303         does not work. Seems like our qml environment is not initialized fully but it
304         needs more investigation.
305
306         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
307         (WTR::WrapperWindow::handleStatusChanged):
308         (WTR::PlatformWebView::resizeTo):
309
310 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
311
312         webkitpy: add a worker_args concept to start_worker()
313         https://bugs.webkit.org/show_bug.cgi?id=78572
314
315         Reviewed by Tony Chang.
316
317         This change replaces the three NRWT-specific arguments passed
318         through the broker to the worker with a generic WorkerArguments
319         wrapper class and a separate set_inline_arguments() call that can
320         be used to pass additional data to the worker when it is running
321         in the same process as the manager (this is needed for testing).
322         With the addition of set_inline_arguments() we also no longer
323         need to pass an optional argument to the worker.run() call.
324
325         Note that this method is *only* implemented on inline workers,
326         so calling this on a regular (child process) worker will result
327         in a runtime error.
328
329         * Scripts/webkitpy/layout_tests/controllers/manager.py:
330         (Manager._run_tests):
331         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
332         (AbstractWorker.__init__):
333         (AbstractWorker.run):
334         (_ManagerConnection.start_worker):
335         (_InlineManager.start_worker):
336         (_InlineManager.set_inline_arguments):
337         (_InlineManager.run_message_loop):
338         (_MultiProcessManager.start_worker): Reworked signature.
339         (_WorkerConnection.__init__):
340         (_InlineWorkerConnection.__init__):
341         (_InlineWorkerConnection.set_inline_arguments): New method.
342         (_InlineWorkerConnection):
343         (_InlineWorkerConnection.run):
344         (_Process.run):
345         (_MultiProcessWorkerConnection.__init__):
346         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
347         (_TestWorker.__init__):
348         (_TestWorker.set_inline_arguments):
349         (_TestWorker.handle_test):
350         (_TestWorker.run):
351         (_TestsMixin.test_cancel):
352         (_TestsMixin.test_done):
353         (_TestsMixin.test_unknown_message):
354         (InlineBrokerTests): New class for more testing.
355         (InlineBrokerTests.setUp):
356         (InlineBrokerTests.test_inline_arguments): New test.
357         (InterfaceTest.test_managerconnection_is_abstract):
358         (InterfaceTest.test_workerconnection_is_abstract):
359         * Scripts/webkitpy/layout_tests/controllers/worker.py:
360         (WorkerArguments):
361         (WorkerArguments.__init__):
362         (Worker.__init__):
363         (Worker.set_inline_arguments):
364         (Worker):
365         (Worker.run):
366         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
367         (WorkerTest.test_default_platform_in_worker):
368
369 2012-02-15  Adam Klein  <adamk@chromium.org>
370
371         Unreviewed, rolling out r107704.
372         http://trac.webkit.org/changeset/107704
373         https://bugs.webkit.org/show_bug.cgi?id=78486
374
375         Caused layout test crashes in debug builds.
376
377         Specific crashing tests:
378
379         fast/events/show-modal-dialog-onblur-onfocus.html
380         fast/harness/show-modal-dialog.html
381         inspector/console/console-long-eval-crash.html
382
383         * DumpRenderTree/chromium/TestShell.cpp:
384         (TestShell::TestShell):
385         * DumpRenderTree/chromium/TestShell.h:
386         (TestShell):
387         * DumpRenderTree/chromium/WebViewHost.cpp:
388         (WebViewHost::runModal):
389
390 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
391
392         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
393         https://bugs.webkit.org/show_bug.cgi?id=76347
394
395         Reviewed by Kenneth Rohde Christiansen.
396
397         * MiniBrowser/qt/MiniBrowser.qrc:
398         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
399         * MiniBrowser/qt/qml/BrowserWindow.qml:
400         * MiniBrowser/qt/qml/DialogLineInput.qml:
401
402 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
403
404         [Qt] Fix WebGL in QtTestBrowser
405
406         Reviewed by Tor Arne Vestbø.
407
408         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
409         the options for enabling GL we also pass them on properly.
410
411 2012-02-14  Sam Weinig  <sam@webkit.org>
412
413         Add #include of unistd.h on the mac for getcwd. 
414
415         Reviewed by Anders Carlsson.
416
417         This is necessary when building with libc++.
418
419         * WebKitTestRunner/TestInvocation.cpp:
420
421 2012-02-14  Sam Weinig  <sam@webkit.org>
422
423         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
424         https://bugs.webkit.org/show_bug.cgi?id=78663
425
426         Reviewed by Anders Carlsson.
427
428         * DumpRenderTree/DumpRenderTreePrefix.h:
429         * DumpRenderTree/cg/ImageDiffCG.cpp:
430
431 2012-02-14  Adam Barth  <abarth@webkit.org>
432
433         Implement an adb-based driver for the ChromiumAndroidPort
434         https://bugs.webkit.org/show_bug.cgi?id=78627
435
436         Reviewed by Eric Seidel.
437
438         This driver mostly just wires up the ChromiumDriver through adb.  In
439         some cases, it translates protocol elements, such as URIs, so that the
440         rest of webkitpy is insulated from the "remoteness" of the target device.
441
442         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
443         (ChromiumAndroidPort.start_helper):
444         (ChromiumAndroidPort._driver_class):
445         (ChromiumAndroidPort._update_version):
446         (ChromiumAndroidPort._get_stderr):
447         (ChromiumAndroidPort):
448         (ChromiumAndroidPort._get_last_stacktrace):
449         (ChromiumAndroidPort._teardown_performance):
450         (ChromiumAndroidDriver):
451         (ChromiumAndroidDriver.__init__):
452         (ChromiumAndroidDriver._start):
453         (ChromiumAndroidDriver.run_test):
454         (ChromiumAndroidDriver.stop):
455         (ChromiumAndroidDriver._test_shell_command):
456         (ChromiumAndroidDriver._write_command_and_read_line):
457         (ChromiumAndroidDriver._output_image):
458         (ChromiumAndroidDriver._has_crash_hint):
459
460 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
461
462         webkitpy: the real_name() method in the Port class is no longer needed
463         https://bugs.webkit.org/show_bug.cgi?id=78651
464
465         Reviewed by Eric Seidel.
466
467         The change in bug 78565 / r107718 made it no longer necessary
468         (we can use options.platform instead).
469
470         * Scripts/webkitpy/layout_tests/port/base.py:
471         (Port.name):
472         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
473         (MockDRTPort.__init__):
474
475 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
476
477         webkitpy: clean up options, port handling in manager_worker_broker
478         https://bugs.webkit.org/show_bug.cgi?id=78568
479
480         Reviewed by Tony Chang.
481
482         manager_worker_broker no longer needs options or port objects
483         directly, so we make them only be passed in start_worker().
484
485         * Scripts/webkitpy/layout_tests/controllers/manager.py:
486         (Manager._run_tests):
487         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
488         (get):
489         (_ManagerConnection.__init__):
490         (_ManagerConnection.start_worker):
491         (_InlineManager.__init__):
492         (_InlineManager.start_worker):
493         (_InlineManager.run_message_loop):
494         (_MultiProcessManager.__init__):
495         (_MultiProcessManager):
496         (_MultiProcessManager.start_worker):
497         (_InlineWorkerConnection.__init__):
498         (_InlineWorkerConnection.run):
499         (_Process.__init__):
500         (_MultiProcessWorkerConnection.__init__):
501         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
502         (make_broker):
503         (_TestWorker.run):
504         (_TestsMixin.test_cancel):
505         (_TestsMixin.test_done):
506         (_TestsMixin.test_unknown_message):
507         (MultiProcessBrokerTests.setUp):
508         (InterfaceTest.test_managerconnection_is_abstract):
509         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
510         (Broker.__init__):
511
512 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
513
514         nrwt: add a unit test for regression introduced in bug 78565
515         https://bugs.webkit.org/show_bug.cgi?id=78646
516
517         Reviewed by Tony Chang.
518
519         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
520         (FakeConnection):
521         (FakeConnection.run_message_loop):
522         (FakeConnection.post_message):
523         (WorkerTest):
524         (WorkerTest.test_default_platform_in_worker):
525
526 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
527
528         NRWT is broken for the default port
529         https://bugs.webkit.org/show_bug.cgi?id=78640
530     
531         Reviewed by Tony Chang.
532
533         The change in r107718 (bug 78565) broke NRWT if you didn't
534         specify any sort of --platform flag or equivalent. I didn't
535         catch this because it's a full integration test (which we don't
536         have an automated test for) and I missed this command line
537         variant when testing interactively.
538
539         * Scripts/webkitpy/layout_tests/controllers/worker.py:
540         (Worker.run):
541
542 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
543
544         Last character display for passwords in Android.
545         https://bugs.webkit.org/show_bug.cgi?id=78532
546
547         Reviewed by Adam Barth.
548
549         * DumpRenderTree/chromium/WebPreferences.cpp:
550         (WebPreferences::applyTo):
551
552 2012-02-14  Adam Barth  <abarth@webkit.org>
553
554         Finish implementing start_helper for ChromiumAndroidPort
555         https://bugs.webkit.org/show_bug.cgi?id=78582
556
557         Reviewed by Eric Seidel.
558
559         This patch contains the remaining odds and ends for the start_helper function.
560
561         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
562         (ChromiumAndroidPort.start_helper):
563         (ChromiumAndroidPort._synchronize_datetime):
564         (ChromiumAndroidPort):
565         (ChromiumAndroidPort._check_version):
566         (ChromiumAndroidPort._run_adb_command):
567         (ChromiumAndroidPort._copy_device_file):
568
569 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
570
571         webkitpy: create ports in Workers, not in manager_worker_broker
572         https://bugs.webkit.org/show_bug.cgi?id=78565
573
574         Reviewed by Tony Chang.
575
576         We will now create the Port object (if necessary) in the Worker
577         directly, so that the manager_worker_broker module doesn't need
578         all of this layout_test-specific logic. Part of the fixes for
579         bug 78171.
580
581         These changes are all well-tested by the existing tests in
582         run_webkit_tests_integrationtest.py.
583
584         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
585         (_Process.run):
586         * Scripts/webkitpy/layout_tests/controllers/worker.py:
587         (Worker.__init__):
588         (Worker.safe_init):
589         (Worker.run):
590         (Worker.cleanup):
591         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
592         (parse_args):
593         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
594
595 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
596
597         [chromium] check that we're not running multiple modal dialogs at the same time
598         https://bugs.webkit.org/show_bug.cgi?id=78486
599
600         Reviewed by Kent Tamura.
601
602         * DumpRenderTree/chromium/TestShell.cpp:
603         (TestShell::TestShell):
604         * DumpRenderTree/chromium/TestShell.h:
605         (TestShell::setIsDisplayingModalDialog):
606         (TestShell::isDisplayingModalDialog):
607         (TestShell):
608         * DumpRenderTree/chromium/WebViewHost.cpp:
609         (WebViewHost::runModal):
610
611 2012-02-14  Adam Barth  <abarth@webkit.org>
612
613         Enable the GPU codepath in the chromium-android port
614         https://bugs.webkit.org/show_bug.cgi?id=78580
615
616         Reviewed by James Robinson.
617
618         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
619         Android always uses the GPU codepath, so we set the GPU flags on the
620         main chromium-android port instead.
621
622         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
623         (ChromiumAndroidPort.__init__):
624
625 2012-02-14  Adam Barth  <abarth@webkit.org>
626
627         NRWT should expose --adb-args flag for Android
628         https://bugs.webkit.org/show_bug.cgi?id=78579
629
630         Reviewed by Eric Seidel.
631
632         This flag is already wired up to the ChromiumAndroidPort.
633
634         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
635         (parse_args):
636
637 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
638
639         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
640         https://bugs.webkit.org/show_bug.cgi?id=78541
641         <rdar://problem/10036695>
642
643         Reviewed by Kent Tamura.
644
645         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
646         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
647         After each test, reset to using new protocol.
648
649 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
650
651         Convert svg/animations to use SMIL methods for driving the timeline
652         https://bugs.webkit.org/show_bug.cgi?id=78422
653
654         Reviewed by Dirk Schulze.
655
656         Remove no longer needed SVG specific animation sampling functionality from DRT.
657         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
658
659         * DumpRenderTree/LayoutTestController.cpp:
660         (LayoutTestController::staticFunctions):
661         * DumpRenderTree/LayoutTestController.h:
662         (LayoutTestController):
663         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
664         * DumpRenderTree/chromium/LayoutTestController.cpp:
665         (LayoutTestController::LayoutTestController):
666         * DumpRenderTree/chromium/LayoutTestController.h:
667         (LayoutTestController):
668         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
669         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
670         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
671         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
672         * DumpRenderTree/qt/LayoutTestControllerQt.h:
673         (LayoutTestController):
674         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
675         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
676
677 2012-02-13  Rob Flack  <flackr@chromium.org>
678
679         Add Linux ChromiumOS test results to flakiness dashboard.
680         https://bugs.webkit.org/show_bug.cgi?id=78495
681
682         Reviewed by Ojan Vafai.
683
684         * TestResultServer/static-dashboards/builders.js:
685         * TestResultServer/static-dashboards/dashboard_base.js:
686
687 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
688
689         [GTK] Mutation Observers build is broken
690         https://bugs.webkit.org/show_bug.cgi?id=78433
691
692         Reviewed by Martin Robinson.
693
694         Enabled mutation observers as a default feature for GTK port, too.
695
696         * Scripts/build-webkit:
697
698 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
699
700         Allow to configure ENABLE_FTPDIR in build-webkit
701         https://bugs.webkit.org/show_bug.cgi?id=65098
702
703         Reviewed by Eric Seidel.
704
705         Allow to disable ENABLE_FTPDIR by command line.
706         Remove ENABLE_FTPDIR from --minimal build
707
708         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
709         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
710         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
711
712 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
713
714         Add shinyak as committer.
715
716         Unreviewed.
717
718         * Scripts/webkitpy/common/config/committers.py:
719
720 2012-02-13  Adam Barth  <abarth@webkit.org>
721
722         Implement start/stop_helper for ChromiumAndroidPort
723         https://bugs.webkit.org/show_bug.cgi?id=78558
724
725         Reviewed by Dirk Pranke.
726
727         These functions (and their dependencies) set up the Android device for
728         testing.
729
730         This patch also includes a few tweaks on the previous patch recommended
731         by dpranke.
732
733         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
734         (ChromiumAndroidPort.__init__):
735         (ChromiumAndroidPort.start_helper):
736         (ChromiumAndroidPort.stop_helper):
737         (ChromiumAndroidPort._shut_down_http_server):
738         (ChromiumAndroidPort):
739         (ChromiumAndroidPort._push_executable):
740         (ChromiumAndroidPort._push_fonts):
741         (ChromiumAndroidPort._restore_system_font):
742         (ChromiumAndroidPort._push_test_resources):
743         (ChromiumAndroidPort._push_to_device):
744         (ChromiumAndroidPort._pull_from_device):
745         (ChromiumAndroidPort._kill_device_process):
746         (ChromiumAndroidPort._setup_performance):
747         (ChromiumAndroidPort._teardown_performance):
748         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
749         (ChromiumAndroidPortTest):
750         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
751         (PortTestCase):
752         (PortTestCase.make_port):
753         (PortTestCase.test_default_worker_model):
754
755 2012-02-13  Adam Barth  <abarth@webkit.org>
756
757         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
758         https://bugs.webkit.org/show_bug.cgi?id=78550
759
760         Reviewed by Eric Seidel.
761
762         Much of this code just forwards to the "host" port, which seems like a
763         reasonable thing to do.
764
765         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
766         (ChromiumAndroidPort.__init__):
767         (ChromiumAndroidPort.stop_helper):
768         (ChromiumAndroidPort):
769         (ChromiumAndroidPort._build_path):
770         (ChromiumAndroidPort._path_to_apache):
771         (ChromiumAndroidPort._path_to_apache_config_file):
772         (ChromiumAndroidPort._path_to_driver):
773         (ChromiumAndroidPort._path_to_helper):
774         (ChromiumAndroidPort._path_to_image_diff):
775         (ChromiumAndroidPort._path_to_lighttpd):
776         (ChromiumAndroidPort._path_to_lighttpd_modules):
777         (ChromiumAndroidPort._path_to_lighttpd_php):
778         (ChromiumAndroidPort._path_to_wdiff):
779         (ChromiumAndroidPort._shut_down_http_server):
780         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
781         (ChromiumAndroidPortTest):
782         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
783         (PortTestCase):
784         (PortTestCase.make_port):
785         (PortTestCase.test_default_worker_model):
786
787 2012-02-13  Adam Barth  <abarth@webkit.org>
788
789         chromium_android.py should implement "virtual" methods from ChromiumPort
790         https://bugs.webkit.org/show_bug.cgi?id=78545
791
792         Reviewed by Dirk Pranke.
793
794         This patch adds basic implementations that specialize a bunch of
795         functions from ChromiumPort.
796
797         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
798         (ChromiumAndroidPort):
799         (ChromiumAndroidPort.__init__):
800         (ChromiumAndroidPort.default_child_processes):
801         (ChromiumAndroidPort.baseline_search_path):
802         (ChromiumAndroidPort.check_build):
803         (ChromiumAndroidPort.check_sys_deps):
804         (ChromiumAndroidPort.default_worker_model):
805         (ChromiumAndroidPort.test_expectations):
806         (ChromiumAndroidPort.start_http_server):
807         (ChromiumAndroidPort.stop_http_server):
808         (ChromiumAndroidPort.start_helper):
809         (ChromiumAndroidPort.stop_helper):
810
811 2012-02-13  Adam Barth  <abarth@webkit.org>
812
813         Add a skeleton ChromiumAndroid port to webkitpy
814         https://bugs.webkit.org/show_bug.cgi?id=78543
815
816         Reviewed by Eric Seidel.
817
818         This patch just adds an empty ChromiumAndroid port object to webkitpy
819         and wires it up to the factory objects.  An actual implementation will
820         follow.
821
822         * Scripts/webkitpy/layout_tests/port/chromium.py:
823         (ChromiumPort):
824         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
825         (ChromiumAndroidPort):
826         (ChromiumAndroidPort.__init__):
827         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
828         (ChromiumPortTest.test_all_test_configurations):
829         * Scripts/webkitpy/layout_tests/port/factory.py:
830         (PortFactory):
831
832 2012-02-13  Adam Barth  <abarth@webkit.org>
833
834         NRWT's HTTP servers should support additional directories for resources
835         https://bugs.webkit.org/show_bug.cgi?id=78528
836
837         Reviewed by Eric Seidel.
838
839         This functionality will be used by the Chromium-Android port.
840
841         * Scripts/webkitpy/layout_tests/port/base.py:
842         (Port.to.start_http_server):
843         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
844         (LayoutTestApacheHttpd.__init__):
845         * Scripts/webkitpy/layout_tests/servers/http_server.py:
846         (Lighttpd.__init__):
847         (Lighttpd._prepare_config):
848
849 2012-02-13  Ami Fischman  <fischman@chromium.org>
850
851         Add fischman as committer.
852
853         Unreviewed
854
855         * Scripts/webkitpy/common/config/committers.py:
856
857 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
858
859         [EFL] Drop support for the Curl network backend.
860         https://bugs.webkit.org/show_bug.cgi?id=77874
861
862         Reviewed by Eric Seidel.
863
864         Nobody seems to be maintaining the Curl backend in WebCore, the
865         EFL port developers all seem to be using the Soup backend and the
866         port itself has many features which are only implemented for the
867         latter.
868
869         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
870         and always add the required include directories.
871         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
872         include directories and link to them.
873
874 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
875
876         [WebSocket] Update pywebsocket to 0.7.1
877         https://bugs.webkit.org/show_bug.cgi?id=78484
878
879         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
880
881         Reviewed by Kent Tamura.
882
883         * Scripts/webkitpy/thirdparty/__init__.py:
884         (AutoinstallImportHook._install_pywebsocket):
885
886 2012-02-12  Kangil Han  <kangil.han@samsung.com>
887
888         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
889         https://bugs.webkit.org/show_bug.cgi?id=78091
890
891         Reviewed by Hajime Morita.
892
893         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
894         This patch will activate around 1,900 test cases from skipped list in EFL port.
895
896         * DumpRenderTree/efl/EventSender.cpp:
897         (textZoom):
898         (pageZoom):
899         (textZoomInCallback):
900         (textZoomOutCallback):
901         (zoomPageInCallback):
902         (zoomPageOutCallback):
903
904 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
905
906         KeywordLookupGenerator.py script fails in some cases
907         https://bugs.webkit.org/show_bug.cgi?id=77886
908
909         Reviewed by Benjamin Poulain.
910
911         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
912         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
913         (GlobalVariablesTest.test_path_rules_specifier):
914
915 2012-02-12  Joe Thomas  <joethomas@motorola.com>
916
917         Add toText and isTextNode helpers in Text class.
918         https://bugs.webkit.org/show_bug.cgi?id=78140
919
920         Unit test case for the new style checker introduced.
921
922         Reviewed by Adam Barth.
923
924         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
925         (CppStyleTest):
926         (CppStyleTest.test_static_cast_readability): Added a unit test case.
927
928 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
929
930         Enable features supported by EFL port in build-webkit.
931         https://bugs.webkit.org/show_bug.cgi?id=78348
932
933         Reviewed by Ryosuke Niwa.
934
935         Sync build-webkit with OptionEfl.cmake, as some features enabled in
936         OptionEfl.cmake are not enabled in build-webkit.
937
938         * Scripts/build-webkit:
939
940 2012-02-12  Joe Thomas  <joethomas@motorola.com>
941
942         Add toText and isTextNode helpers in Text class.
943         https://bugs.webkit.org/show_bug.cgi?id=78140
944
945         Added a style checker to use toText rather than static_cast<Text*>.
946
947         Reviewed by Adam Barth.
948
949         * Scripts/webkitpy/style/checkers/cpp.py:
950         (check_language): Style checker for static_cast<Text*>.
951
952 2012-02-12  Philippe Normand  <pnormand@igalia.com>
953
954         Unreviewed, disable Mutation observers build on GTK until it can
955         actually build.
956
957         * Scripts/build-webkit:
958
959 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
960
961         Add back WTFURL to WebKit
962         https://bugs.webkit.org/show_bug.cgi?id=77291
963
964         Reviewed by Adam Barth.
965
966         Add a flag to build-webkit to easily build WebKit with WTFURL.
967
968         * Scripts/build-webkit:
969
970 2012-02-10  Adam Klein  <adamk@chromium.org>
971
972         Enable MUTATION_OBSERVERS by default on all platforms
973         https://bugs.webkit.org/show_bug.cgi?id=78196
974
975         Reviewed by Ojan Vafai.
976
977         * Scripts/build-webkit:
978
979 2012-02-10  Adam Barth  <abarth@webkit.org>
980
981         Move garden-o-matic's All Failures out of experimental
982         https://bugs.webkit.org/show_bug.cgi?id=78395
983
984         Reviewed by Dimitri Glazkov.
985
986         Several folks have tried this feature and found it useful.
987
988         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
989
990 2012-02-10  Tim Horton  <timothy_horton@apple.com>
991
992         NRWT should categorize options in --help
993         https://bugs.webkit.org/show_bug.cgi?id=76221
994
995         Reviewed by Eric Seidel.
996         
997         Use optparse's OptionGroup mechanism to logically group NRWT's options,
998         providing a better experience when scanning all the options.
999
1000         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1001         (parse_args):
1002
1003 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1004
1005         [Qt][WK2] Refactor on Qt5 Layout tests' structure
1006         https://bugs.webkit.org/show_bug.cgi?id=77450
1007
1008         Reviewed by Csaba Osztrogonác.
1009
1010         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
1011         to qt-5.0-wk2 and qt-5.0-wk1.
1012
1013         * Scripts/old-run-webkit-tests:
1014         (buildPlatformResultHierarchy):
1015         (readSkippedFiles):
1016         * Scripts/webkitpy/layout_tests/port/qt.py:
1017         (QtPort._wk2_port_name):
1018         (QtPort._skipped_file_search_paths):
1019         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1020         (QtPortTest.test_baseline_search_path):
1021         * Scripts/webkitpy/layout_tests/port/webkit.py:
1022         (WebKitPort._wk2_port_name):
1023
1024 2012-02-09  Philippe Normand  <pnormand@igalia.com>
1025
1026         [GTK] EWS command-line option to run the tests
1027         https://bugs.webkit.org/show_bug.cgi?id=78211
1028
1029         Reviewed by Adam Barth.
1030
1031         New --run-tests option (defaults to False) for the EWS commands.
1032
1033         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1034         (AbstractEarlyWarningSystem):
1035         (AbstractEarlyWarningSystem.__init__):
1036         (AbstractEarlyWarningSystem.review_patch):
1037         (ChromiumLinuxEWS):
1038         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1039         (EarlyWarningSytemTest._test_builder_ews):
1040
1041 2012-02-09  Eric Seidel  <eric@webkit.org>
1042
1043         Rename compare_text and compare_audio to make it clear that they're !=
1044         https://bugs.webkit.org/show_bug.cgi?id=78301
1045
1046         Reviewed by Adam Barth.
1047
1048         I also removed the maybe_create_directory function which was redundant.
1049
1050         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1051         (Manager.set_up_run):
1052         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1053         (TestResultWriter._make_output_directory):
1054         * Scripts/webkitpy/layout_tests/port/base.py:
1055         (Port.do_text_results_differ):
1056         (Port.do_audio_results_differ):
1057         (Port.diff_text):
1058         (Port.driver_name):
1059         (Port.skips_perf_test):
1060         * Scripts/webkitpy/layout_tests/port/win.py:
1061         (WinPort.do_text_results_differ):
1062         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1063         (WinPortTest.test_do_text_results_differ):
1064         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1065         (LayoutTestApacheHttpd.__init__):
1066         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1067         (HttpServerBase.__init__):
1068         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1069         (Rebaseliner._diff_baselines):
1070
1071 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
1072
1073         [GTK] Add DRT support for modal dialogs
1074         https://bugs.webkit.org/show_bug.cgi?id=53600
1075
1076         Reviewed by Martin Robinson.
1077
1078         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
1079         Most significantly, when creating a new web view in GtkLauncher, the window
1080         of the web view opener is passed around. In DumpRenderTree, the window of
1081         the main web view is always considered as the opener. This is required so
1082         the modal dialog's toplevel can be made transient for the opener's toplevel.
1083
1084         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1085         (webViewRunModalDialog):
1086         (createWebView):
1087         * GtkLauncher/main.c:
1088         (createWebViewCb):
1089         (runModalDialogCb):
1090         (createBrowser):
1091         (createWindow):
1092         (main):
1093
1094 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
1095
1096         [Gtk] security/set-form-autocomplete-attribute.html fails
1097         https://bugs.webkit.org/show_bug.cgi?id=78261
1098
1099         Reviewed by Martin Robinson.
1100
1101         Use the new helper in DumpRenderTreeSupportGtk to properly
1102         test whether an element performs autocompletion.
1103
1104         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1105         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
1106
1107 2012-02-09  James Robinson  <jamesr@chromium.org>
1108
1109         [chromium] Enable mock scrollbars for compositing layout tests
1110         https://bugs.webkit.org/show_bug.cgi?id=78299
1111
1112         Reviewed by Dirk Pranke.
1113
1114         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
1115         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
1116         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
1117
1118         * DumpRenderTree/chromium/TestShell.cpp:
1119         (TestShell::runFileTest):
1120         * DumpRenderTree/chromium/WebPreferences.cpp:
1121         (WebPreferences::reset):
1122         (WebPreferences::applyTo):
1123         * DumpRenderTree/chromium/WebPreferences.h:
1124         (WebPreferences):
1125
1126 2012-02-09  Eric Seidel  <eric@webkit.org>
1127
1128         Remove more uses of "os" from our webkitpy code
1129         https://bugs.webkit.org/show_bug.cgi?id=78292
1130
1131         Reviewed by Adam Barth.
1132
1133         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1134         (MockCheckout.__init__):
1135         (MockCheckout.is_path_to_changelog):
1136         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1137         * Scripts/webkitpy/common/system/filesystem_mock.py:
1138         (MockFileSystem._split):
1139         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1140         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1141         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1142         * Scripts/webkitpy/layout_tests/port/webkit.py:
1143         * Scripts/webkitpy/tool/bot/queueengine.py:
1144         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1145         * Scripts/webkitpy/tool/commands/download.py:
1146         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1147         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1148         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1149         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1150         * Scripts/webkitpy/tool/commands/upload.py:
1151         (CreateBug.prompt_for_bug_title_and_comment):
1152         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1153         * Scripts/webkitpy/tool/steps/attachtobug.py:
1154         (AttachToBug.run):
1155         * Scripts/webkitpy/tool/steps/checkstyle.py:
1156         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1157         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1158         * Scripts/webkitpy/tool/steps/editchangelog.py:
1159         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1160         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1161         (PrepareChangeLogTest.test_ensure_bug_url):
1162         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1163         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1164         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1165         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1166
1167 2012-02-09  Eric Seidel  <eric@webkit.org>
1168
1169         Remove the cr-mac-ews (it's long been dead)
1170         https://bugs.webkit.org/show_bug.cgi?id=78267
1171
1172         Reviewed by Adam Barth.
1173
1174         * QueueStatusServer/model/queues.py:
1175         (Queue):
1176         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1177         (ChromiumWindowsEWS):
1178         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1179         (EarlyWarningSytemTest._test_builder_ews):
1180         (EarlyWarningSytemTest._test_testing_ews):
1181
1182 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
1183
1184         some tests in webkitpy are being run three times
1185         https://bugs.webkit.org/show_bug.cgi?id=78283
1186
1187         Reviewed by Ryosuke Niwa.
1188
1189         It turns out that if you import a class derived from
1190         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
1191         the unittest framework treats it as if the class was defined in
1192         the file (as well in the original file). This led us to running
1193         the tests in ChangeLogTest three times.
1194
1195         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1196         (PrepareChangeLogTest):
1197         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1198         (_assert_message_for_revert_output):
1199
1200 2012-02-09  Adam Barth  <abarth@webkit.org>
1201
1202         Remove extraneous line in previous patch.  I forgot to remove this
1203         before landing.
1204
1205         * Scripts/webkitpy/layout_tests/port/driver.py:
1206         (DriverProxy.start):
1207
1208 2012-02-09  Adam Barth  <abarth@webkit.org>
1209
1210         run-perf-tests should have an option to pause before running tests so we can attach Instruments
1211         https://bugs.webkit.org/show_bug.cgi?id=78271
1212
1213         Reviewed by Ryosuke Niwa.
1214
1215         This lets me attach instruments to profile the performance of the test.
1216
1217         * Scripts/webkitpy/layout_tests/port/chromium.py:
1218         (ChromiumDriver.start):
1219         * Scripts/webkitpy/layout_tests/port/driver.py:
1220         (Driver.start):
1221         (DriverProxy.start):
1222         * Scripts/webkitpy/layout_tests/port/server_process.py:
1223         (ServerProcess.start):
1224         * Scripts/webkitpy/layout_tests/port/test.py:
1225         (TestDriver.start):
1226         * Scripts/webkitpy/layout_tests/port/webkit.py:
1227         (WebKitDriver.start):
1228         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1229         (get_tests_run.RecordingTestDriver.start):
1230         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1231         (PerfTestsRunner._parse_args):
1232         (PerfTestsRunner._run_tests_set):
1233         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1234         (start):
1235         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1236         (test_run_test_set_kills_drt_per_run):
1237         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
1238         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
1239
1240 2012-02-09  Adam Barth  <abarth@webkit.org>
1241
1242         run-perf-tests --chromium should run the chromium port
1243         https://bugs.webkit.org/show_bug.cgi?id=78266
1244
1245         Reviewed by Ryosuke Niwa.
1246
1247         This patch makes run-perf-tests work more like run-webkit-tests.
1248
1249         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1250         (PerfTestsRunner._parse_args):
1251
1252 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1253
1254         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
1255         https://bugs.webkit.org/show_bug.cgi?id=77466
1256
1257         Reviewed by Dirk Pranke.
1258
1259         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
1260         is set or if we should raise an error. A unit test was added.
1261
1262         * Scripts/webkitpy/layout_tests/port/qt.py:
1263         (QtPort.operating_system):
1264         (QtPort):
1265         (QtPort.check_sys_deps):
1266         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1267         (QtPortTest.test_operating_system):
1268         (QtPortTest):
1269         (QtPortTest.test_check_sys_deps):
1270
1271 2012-02-09  Eric Seidel  <eric@webkit.org>
1272
1273         Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
1274         https://bugs.webkit.org/show_bug.cgi?id=78263
1275
1276         Reviewed by Adam Barth.
1277
1278         * Scripts/webkitpy/common/config/ports.py:
1279         (DeprecatedPort):
1280         (DeprecatedPort.name):
1281         (DeprecatedPort.flag):
1282         (DeprecatedPort.script_path):
1283         (DeprecatedPort.script_shell_command):
1284         (DeprecatedPort.port):
1285         (DeprecatedPort.makeArgs):
1286         (DeprecatedPort.update_webkit_command):
1287         (DeprecatedPort.check_webkit_style_command):
1288         (DeprecatedPort.prepare_changelog_command):
1289         (DeprecatedPort.build_webkit_command):
1290         (DeprecatedPort.run_javascriptcore_tests_command):
1291         (DeprecatedPort.run_webkit_unit_tests_command):
1292         (DeprecatedPort.run_webkit_tests_command):
1293         (DeprecatedPort.run_python_unittests_command):
1294         (DeprecatedPort.run_perl_unittests_command):
1295         (DeprecatedPort.layout_tests_results_path):
1296         (MacPort):
1297         (WinPort):
1298         (GtkPort):
1299         (GtkPort.build_webkit_command):
1300         (GtkPort.run_webkit_tests_command):
1301         (QtPort):
1302         (QtPort.build_webkit_command):
1303         (EflPort):
1304         (EflPort.build_webkit_command):
1305         (ChromiumPort):
1306         (ChromiumPort.update_webkit_command):
1307         (ChromiumPort.build_webkit_command):
1308         (ChromiumPort.run_webkit_tests_command):
1309         (ChromiumPort.run_javascriptcore_tests_command):
1310         (ChromiumXVFBPort):
1311         (ChromiumXVFBPort.run_webkit_tests_command):
1312         * Scripts/webkitpy/common/config/ports_unittest.py:
1313         (DeprecatedPortTest):
1314         (DeprecatedPortTest.test_mac_port):
1315         (DeprecatedPortTest.test_gtk_port):
1316         (DeprecatedPortTest.test_qt_port):
1317         (DeprecatedPortTest.test_chromium_port):
1318         (DeprecatedPortTest.test_chromium_xvfb_port):
1319         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1320         (AbstractEarlyWarningSystem.__init__):
1321         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1322         * Scripts/webkitpy/tool/main.py:
1323         (WebKitPatch):
1324         (WebKitPatch.handle_global_options):
1325         * Scripts/webkitpy/tool/steps/abstractstep.py:
1326         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1327         (StepsTest.test_runtests_args):
1328
1329 2012-02-09  Jochen Eisinger  <jochen@chromium.org>
1330
1331         [chromium] always initialize makeArgs in buildChromiumNinja
1332         https://bugs.webkit.org/show_bug.cgi?id=78231
1333
1334         Reviewed by Tony Gentilcore.
1335
1336         * Scripts/webkitdirs.pm:
1337         (buildChromiumNinja):
1338
1339 2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1340
1341         [GTK] Show url of current hovered link in MiniBrowser
1342         https://bugs.webkit.org/show_bug.cgi?id=78098
1343
1344         Reviewed by Martin Robinson.
1345
1346         * MiniBrowser/gtk/BrowserWindow.c:
1347         (webViewMouseTargetChanged): Check whether hit test result is a
1348         link and use the url to update the status bar text.
1349         (browserWindowConstructed): Connect to
1350         WebKitWebView::mouse-target-changed signal.
1351
1352 2012-02-09  Rob Buis  <rbuis@rim.com>
1353
1354         [BlackBerry] Upstream DumpRenderTreeBlackBerry
1355         https://bugs.webkit.org/show_bug.cgi?id=78042
1356
1357         Reviewed by Antonio Gomes.
1358
1359         Upstream final part of our DRT implementation.
1360
1361         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
1362         * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
1363         * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
1364         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
1365         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
1366
1367 2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
1368
1369         kill-old-processes should kill gcc and clang
1370         https://bugs.webkit.org/show_bug.cgi?id=78189
1371
1372         Reviewed by Eric Seidel.
1373
1374         Added a bunch of processes names of gcc and clang to the list.
1375
1376         * BuildSlaveSupport/kill-old-processes:
1377
1378 2012-02-07  MORITA Hajime  <morrita@google.com>
1379
1380         Replacement text should be available from the marker.
1381         https://bugs.webkit.org/show_bug.cgi?id=77934
1382
1383         Made the mock requestCheckingOfText() implementation to return
1384         a replacement text for each misspelled word if available.
1385
1386         Reviewed by Kent Tamura.
1387
1388         * DumpRenderTree/chromium/WebViewHost.cpp:
1389         (WebViewHost::finishLastTextCheck):
1390
1391 2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1392
1393         [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
1394         https://bugs.webkit.org/show_bug.cgi?id=78146
1395
1396         Reviewed by Ryosuke Niwa.
1397
1398         Our DumpRenderTree should support --no-timeout and --timeout options in order
1399         to be able to use run-perf-tests and have a Performance Bot.
1400         This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
1401         and the necessary code to handle such command line arguments to our DumpRenderTree.
1402
1403         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1404         (WebCore::DumpRenderTree::setTimeout):
1405         (WebCore):
1406         (WebCore::DumpRenderTree::setShouldTimeout):
1407         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1408         (DumpRenderTree):
1409         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1410         (LayoutTestController::LayoutTestController):
1411         (LayoutTestController::waitUntilDone):
1412         (LayoutTestController::notifyDone):
1413         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1414         (LayoutTestController::setTimeout):
1415         (LayoutTestController::setShouldTimeout):
1416         (LayoutTestController):
1417         * DumpRenderTree/qt/main.cpp:
1418         (isOption):
1419         (printUsage):
1420         (main):
1421
1422 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1423
1424         Rubber-stamped by Martin Robinson.
1425
1426         * gtk/common.py:
1427         (get_build_path): Move test for current directory being a valid
1428         directory up so it takes precedence over WebKitBuild/Release and
1429         WebKitBuild/Debug when they exist as well.
1430
1431 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1432
1433         [GTK] doc rebasing does not respect DESTDIR
1434         https://bugs.webkit.org/show_bug.cgi?id=78177
1435
1436         Reviewed by Martin Robinson.
1437
1438         * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
1439         calling it for rebasing.
1440         * gtk/generate-gtkdoc:
1441         (get_common_options): Handle the new --virtual-root option.
1442         * gtk/gtkdoc.py:
1443         (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
1444         it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
1445
1446 2012-02-08  Adam Barth  <abarth@webkit.org>
1447
1448         Remove Python 2.5 support from WebKit
1449         https://bugs.webkit.org/show_bug.cgi?id=71593
1450
1451         Reviewed by Eric Seidel.
1452
1453         This is the last vestige of our Python 2.5 support.
1454
1455         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1456         (AbstractQueueTest.test_log_from_script_error_for_upload):
1457
1458 2012-02-08  Adam Barth  <abarth@webkit.org>
1459
1460         version_check.py should inform users that we don't support Python 2.5 anymore
1461         https://bugs.webkit.org/show_bug.cgi?id=78179
1462
1463         Reviewed by Eric Seidel.
1464
1465         We don't support Python 2.5 anymore.
1466
1467         * Scripts/webkitpy/common/version_check.py:
1468
1469 2012-02-08  Adam Barth  <abarth@webkit.org>
1470
1471         test_configuration.py shouldn't re-implement itertools
1472         https://bugs.webkit.org/show_bug.cgi?id=78178
1473
1474         Reviewed by Eric Seidel.
1475
1476         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1477         (TestConfigurationConverter.to_specifiers_list):
1478         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1479         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1480         (TestConfigurationConverter):
1481
1482 2012-02-08  Adam Barth  <abarth@webkit.org>
1483
1484         webkitpy should reply upon the multiprocessing package existing
1485         https://bugs.webkit.org/show_bug.cgi?id=78176
1486
1487         Reviewed by Eric Seidel.
1488
1489         Now that we don't support Python 2.5, this import can't fail.
1490
1491         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1492         (get):
1493         (_Process):
1494         (_Process.__init__):
1495         (_Process.run):
1496         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1497         (FunctionTests.test_get__processes):
1498         (MultiProcessBrokerTests.setUp):
1499         * Scripts/webkitpy/layout_tests/port/base.py:
1500         (Port.__init__):
1501         (Port.default_worker_model):
1502         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1503         (ChromiumMacPort.check_build):
1504         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1505         (PortTestCase.test_default_worker_model):
1506         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1507
1508 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1509
1510         Unreviewed typo fix that makes docs build again for the gtk2-based
1511         library.
1512
1513         * gtk/generate-gtkdoc:
1514
1515 2012-02-08  Adam Barth  <abarth@webkit.org>
1516
1517         Don't re-implement ZipFile.extractall
1518         https://bugs.webkit.org/show_bug.cgi?id=78173
1519
1520         Reviewed by Eric Seidel.
1521
1522         We can use ZipFile.extractall now that we don't support Python 2.5.
1523
1524         * Scripts/webkitpy/common/system/autoinstall.py:
1525         (AutoInstaller._extract_targz):
1526         (AutoInstaller._unzip):
1527
1528 2012-02-08  Adam Barth  <abarth@webkit.org>
1529
1530         Remove the ospath compat shim from webkitpy
1531         https://bugs.webkit.org/show_bug.cgi?id=78170
1532
1533         Reviewed by Eric Seidel.
1534
1535         We no longer need this compat shim now that we don't support Python 2.5.
1536
1537         * Scripts/webkitpy/common/checkout/scm/git.py:
1538         * Scripts/webkitpy/common/checkout/scm/svn.py:
1539         * Scripts/webkitpy/common/system/filesystem.py:
1540         (FileSystem.relpath):
1541         * Scripts/webkitpy/common/system/filesystem_mock.py:
1542         (MockFileSystem.relpath):
1543         * Scripts/webkitpy/common/system/ospath.py: Removed.
1544         * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
1545
1546 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
1547
1548         Build fix attempt after r107053.
1549
1550         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1551         (test_collect_tests):
1552
1553 2012-02-08  Adam Barth  <abarth@webkit.org>
1554
1555         Remove simplejson because it's no longer used by webkitpy
1556         https://bugs.webkit.org/show_bug.cgi?id=78164
1557
1558         Reviewed by Eric Seidel.
1559
1560         All the importers of this code were removed in a previous patch.
1561
1562         * Scripts/webkitpy/thirdparty/simplejson: Removed.
1563         * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
1564         * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
1565         * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
1566         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
1567         * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
1568         * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
1569         * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
1570         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
1571         * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
1572         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
1573
1574 2012-02-08  Adam Barth  <abarth@webkit.org>
1575
1576         webkitpy still imports simplejson
1577         https://bugs.webkit.org/show_bug.cgi?id=78161
1578
1579         Reviewed by Eric Seidel.
1580
1581         We no longer support Python 2.5, so we can rely upon Python's built-in
1582         JSON package.
1583
1584         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1585         * Scripts/webkitpy/common/net/resultsjsonparser.py:
1586         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
1587         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1588         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1589         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1590         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1591         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1592         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1593         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1594         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1595
1596 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1597
1598         [GTK] Fails to build docs with non-standard build directories
1599         https://bugs.webkit.org/show_bug.cgi?id=78118
1600
1601         * gtk/common.py:
1602         (get_build_path): add comment to document changes done in r107098,
1603         as requested by the reviewer and forgotten by me.
1604
1605 2012-02-08  Adam Barth  <abarth@webkit.org>
1606
1607         Stop importing with_statement from the mysterious future
1608         https://bugs.webkit.org/show_bug.cgi?id=78156
1609
1610         Reviewed by Eric Seidel.
1611
1612         The future is now!  (Well, at least 2008, when Python 2.6 was released,
1613         is no longer the __future__.)
1614
1615         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1616         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1617         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1618         * Scripts/webkitpy/common/net/credentials_unittest.py:
1619         * Scripts/webkitpy/common/net/file_uploader.py:
1620         * Scripts/webkitpy/common/newstringio_unittest.py:
1621         * Scripts/webkitpy/common/system/autoinstall.py:
1622         * Scripts/webkitpy/common/system/crashlogs.py:
1623         * Scripts/webkitpy/common/system/fileset.py:
1624         * Scripts/webkitpy/common/system/filesystem.py:
1625         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1626         * Scripts/webkitpy/common/system/path.py:
1627         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
1628         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1629         * Scripts/webkitpy/layout_tests/port/base.py:
1630         (of):
1631         * Scripts/webkitpy/layout_tests/port/gtk.py:
1632         * Scripts/webkitpy/layout_tests/port/test.py:
1633         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1634         * Scripts/webkitpy/style/filereader_unittest.py:
1635         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1636         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1637         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1638         * Scripts/webkitpy/tool/commands/queues.py:
1639         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1640         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1641
1642 2012-02-08  Rob Buis  <rbuis@rim.com>
1643
1644         [BlackBerry] Upstream DumpRenderTreeBlackBerry
1645         https://bugs.webkit.org/show_bug.cgi?id=78042
1646
1647         Reviewed by Antonio Gomes.
1648
1649         Upstream more parts of our DRT implementation.
1650
1651         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
1652         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
1653         * DumpRenderTree/blackberry/EventSender.cpp: Added.
1654         * DumpRenderTree/blackberry/EventSender.h: Added.
1655         * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
1656         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
1657
1658 2012-02-08  Dirk Pranke  <dpranke@chromium.org>
1659
1660         check-webkit-style failing with "Path does not exist."
1661         https://bugs.webkit.org/show_bug.cgi?id=77873
1662
1663         Reviewed by Ojan Vafai.
1664
1665         This change fixes the way the style checker determines which
1666         Port class to use for a given test_expectations.txt path; the
1667         previous version used a heuristic that didn't really work in the
1668         first place.
1669
1670         * Scripts/webkitpy/style/checkers/test_expectations.py:
1671         (TestExpectationsChecker._determine_port_from_expectations_path):
1672         (TestExpectationsChecker.__init__):
1673         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1674         (TestExpectationsTestCase._expect_port_for_expectations_path):
1675         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1676
1677 2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>
1678
1679         nrwt: make --skip-pixel-test-if-no-baseline option
1680         https://bugs.webkit.org/show_bug.cgi?id=70484
1681
1682         Reviewed by Dirk Pranke.
1683
1684         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1685         (SingleTestRunner.__init__):
1686         (SingleTestRunner._should_fetch_expected_checksum):
1687         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1688         (Worker.handle_test_list):
1689         * Scripts/webkitpy/layout_tests/models/test_input.py:
1690         (TestInput.__init__):
1691         * Scripts/webkitpy/layout_tests/port/webkit.py:
1692         (WebKitDriver.cmd_line):
1693         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1694         (_set_up_derived_options):
1695         (parse_args):
1696         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1697         (MainTest.test_skip_pixel_test_if_no_baseline_option):
1698         * WebKitTestRunner/TestController.cpp:
1699         (WTR::TestController::TestController):
1700         (WTR::TestController::initialize):
1701         (WTR::TestController::runTest):
1702         * WebKitTestRunner/TestController.h:
1703         (TestController):
1704         * WebKitTestRunner/TestInvocation.cpp:
1705         (WTR::TestInvocation::TestInvocation):
1706         (WTR::TestInvocation::setIsPixelTest):
1707         * WebKitTestRunner/TestInvocation.h:
1708         (WTR::TestInvocation::setSkipPixelTestOption):
1709         (TestInvocation):
1710
1711 2012-02-08  Rob Buis  <rbuis@rim.com>
1712
1713         [BlackBerry] Upstream DumpRenderTreeBlackBerry
1714         https://bugs.webkit.org/show_bug.cgi?id=78042
1715
1716         Reviewed by Antonio Gomes.
1717
1718         Add implementation for our DumpRenderTree solution.
1719
1720         * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
1721         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
1722
1723 2012-02-08  Antti Koivisto  <antti@apple.com>
1724
1725         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
1726         https://bugs.webkit.org/show_bug.cgi?id=78080
1727
1728         Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
1729         
1730         Add API test.
1731
1732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1733         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
1734         (TestWebKitAPI):
1735         (TestWebKitAPI::TEST):
1736
1737 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1738
1739         [GTK] Fails to build docs with non-standard build directories
1740         https://bugs.webkit.org/show_bug.cgi?id=78118
1741
1742         Reviewed by Martin Robinson.
1743
1744         * gtk/common.py:
1745         (get_build_path): also try the current directory as a valid build
1746         dir, which makes non-standard build directories such as build-2.0
1747         and build-3.0 work
1748
1749 2012-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1750
1751         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
1752         https://bugs.webkit.org/show_bug.cgi?id=78099
1753
1754         Reviewed by Martin Robinson.
1755
1756         * MiniBrowser/gtk/BrowserWindow.c:
1757         (webViewDecidePolicy): Check whether it's a link clicked with the
1758         middle mouse button and load the request in a new window.
1759         (browserWindowConstructed): Connect to
1760         WebKitWebView::decide-policy signal.
1761
1762 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
1763
1764         Revert a part of the change in r106687 as a build fix.
1765
1766         Since Chromium port doesn't checkout the entire WebKit trunk,
1767         we can't run "svn info" on webkit_base.
1768
1769         * Scripts/webkitpy/layout_tests/port/base.py:
1770         (Port.repository_paths):
1771
1772 2012-02-07  Ryosuke Niwa  <rniwa@webkit.org>
1773
1774         run-perf-tests doesn't recognize paths that start with PerformanceTests
1775         https://bugs.webkit.org/show_bug.cgi?id=78012
1776
1777         Reviewed by Adam Barth.
1778
1779         Use resolve paths using filesystem.relpath before passing it to find_files.find.
1780
1781         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1782         (PerfTestsRunner):
1783         (PerfTestsRunner._collect_tests):
1784         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1785         (test_collect_tests):
1786         (test_collect_tests.add_file):
1787
1788 2012-02-07  Justin Novosad  <junov@chromium.org>
1789
1790         [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
1791         https://bugs.webkit.org/show_bug.cgi?id=78039
1792
1793         Reviewed by Stephen White.
1794
1795         Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
1796
1797         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1798         (main):
1799         * DumpRenderTree/chromium/TestShell.cpp:
1800         (TestShell::TestShell):
1801         (TestShell::resetWebSettings):
1802         (TestShell::runFileTest):
1803         * DumpRenderTree/chromium/TestShell.h:
1804         (TestShell::setDeferred2dCanvasEnabled):
1805         (TestShell):
1806         * DumpRenderTree/chromium/WebPreferences.cpp:
1807         (WebPreferences::reset):
1808         (WebPreferences::applyTo):
1809         * DumpRenderTree/chromium/WebPreferences.h:
1810         (WebPreferences):
1811
1812 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1813
1814         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
1815         https://bugs.webkit.org/show_bug.cgi?id=77928
1816
1817         Reviewed by Daniel Bates.
1818
1819         CMake has used *Programs* directory for executable. In addition, shared libraries are being
1820         built in source directory. It is better to set common places in order to maintain executable
1821         and libraries. *bin* is for executable and *lib* is for library.
1822
1823         * DumpRenderTree/efl/CMakeLists.txt:
1824         * EWebLauncher/CMakeLists.txt:
1825         * Scripts/run-launcher:
1826         * Scripts/webkitdirs.pm:
1827         (jscProductDir):
1828         * Scripts/webkitpy/layout_tests/port/efl.py:
1829         (EflPort._path_to_driver):
1830         (EflPort._path_to_image_diff):
1831
1832 2012-02-07  Adam Klein  <adamk@chromium.org>
1833
1834         Add JSC support for delivering mutations when the outermost script context exits
1835         https://bugs.webkit.org/show_bug.cgi?id=70289
1836
1837         Reviewed by Eric Seidel.
1838
1839         * DumpRenderTree/mac/EventSendingController.mm: Add support for
1840         eventSender.scheduleAsynchronousKeyDown.
1841         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1842         (+[EventSendingController webScriptNameForSelector:]):
1843         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
1844         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
1845         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
1846
1847 2012-02-07  Chris Rogers  <crogers@google.com>
1848
1849         Add Chris Rogers to reviewers section
1850         https://bugs.webkit.org/show_bug.cgi?id=78016
1851
1852         Reviewed by Adam Barth.
1853
1854         * Scripts/webkitpy/common/config/committers.py:
1855
1856 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
1857
1858         layoutTestController.display() is flaky for SVG tests
1859         https://bugs.webkit.org/show_bug.cgi?id=78021
1860
1861         Reviewed by Dan Bernstein.
1862
1863         Fix race condition in repaint rect tracking. When running a test using the repaint.js
1864         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
1865         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
1866         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
1867         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
1868         the repaint test already run, thus invalidating the previously tracked repaint rects.
1869
1870         * DumpRenderTree/mac/DumpRenderTree.mm:
1871         (dump):
1872         (runTest):
1873
1874 2012-02-07  Hans Wennborg  <hans@chromium.org>
1875
1876         Chromium: remove WebSpeechInputResult::set
1877         https://bugs.webkit.org/show_bug.cgi?id=77977
1878
1879         Reviewed by Darin Fisher.
1880
1881         It was renamed to assign() in r106475.
1882
1883         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1884         (makeRectResult):
1885
1886 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1887
1888         [Qt] Give emulated touch-point a radius
1889         https://bugs.webkit.org/show_bug.cgi?id=77985
1890         
1891         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
1892
1893         Reviewed by Kenneth Rohde Christiansen.
1894
1895         * MiniBrowser/qt/BrowserWindow.cpp:
1896         (BrowserWindow::updateVisualMockTouchPoints):
1897         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1898         (MiniBrowserApplication::notify):
1899         * MiniBrowser/qt/qml/MockTouchPoint.qml:
1900
1901 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
1902
1903         [GTK] Include gdk-pixbuf in the jhbuild modules
1904         https://bugs.webkit.org/show_bug.cgi?id=77980
1905
1906         Reviewed by Gustavo Noronha Silva.
1907
1908         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
1909
1910 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
1911
1912         [Qt] Prevent early test termination with newer Qt 5
1913         https://bugs.webkit.org/show_bug.cgi?id=77945
1914
1915         Reviewed by Csaba Osztrogonác.
1916
1917         QTBUG-24120 tracks a regression in Qt that would make layout tests
1918         terminate early. This patch works around it in a Qt 4 + 5 safe manner
1919         by disabling the quitOnLastWindowClosed feature, which we don't want/need
1920         for DRT anyway.
1921
1922         * DumpRenderTree/qt/main.cpp:
1923         (main): Don't quit on last window closed.
1924
1925 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
1926
1927         Fix some miscellaneous 'make dist' error for WebKitGTK+.
1928
1929         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
1930         files should not be distributed.
1931
1932 2012-02-02  Hajime Morrita  <morrita@chromium.org>
1933
1934         [PerformanceTests] Each Dromaeo test needs its landing html.
1935         https://bugs.webkit.org/show_bug.cgi?id=77504
1936
1937         Reviewed by Ryosuke Niwa.
1938
1939         Added an ignorable pattern which happens in some Dromaeo tests.
1940
1941         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1942         (PerfTestsRunner):
1943
1944 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
1945
1946         [GTK] Add missing pango include dir to fix build
1947         https://bugs.webkit.org/show_bug.cgi?id=77832
1948
1949         Reviewed by Martin Robinson.
1950
1951         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
1952
1953 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
1954
1955         [GTK] Fix remaining errors in GTK+ WebKit2 API
1956         https://bugs.webkit.org/show_bug.cgi?id=77890
1957
1958         Reviewed by Gustavo Noronha Silva.
1959
1960         Verify that WebKit2 GTK+ test files are not skipped during style checks.
1961         Skip soup_server_new when checking for NULL versus 0 usage.
1962
1963         * Scripts/webkitpy/style/checker_unittest.py:
1964         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1965         * Scripts/webkitpy/style/checkers/cpp.py:
1966         (check_for_null):
1967
1968 2012-02-06  Eric Seidel  <eric@webkit.org>
1969
1970         webkit-patch apply-from-bug should be able to apply non-reviewed patches
1971         https://bugs.webkit.org/show_bug.cgi?id=77883
1972
1973         Reviewed by Adam Barth.
1974
1975         This is very helpful if you use bugzilla as a replacement for git-stash.
1976         Makes it simpler to re-apply the patch w/o having to look up the patch id.
1977
1978         * Scripts/webkitpy/tool/commands/download.py:
1979         (ProcessBugsMixin._fetch_list_of_patches_to_process):
1980         * Scripts/webkitpy/tool/commands/download_unittest.py:
1981         (DownloadCommandsTest.test_apply_from_bug):
1982
1983 2012-02-06  Philippe Normand  <pnormand@igalia.com>
1984
1985         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
1986         https://bugs.webkit.org/show_bug.cgi?id=77866
1987
1988         Reviewed by Martin Robinson.
1989
1990         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
1991         errors in some gstreamer source code files defining new GStreamer elements.
1992         * Scripts/webkitpy/style/checker_unittest.py:
1993         (GlobalVariablesTest.test_path_rules_specifier):
1994
1995 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1996
1997         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
1998         https://bugs.webkit.org/show_bug.cgi?id=77869
1999
2000         Reviewed by Philippe Normand.
2001
2002         * gtk/gtkdoc.py:
2003         (GTKDoc.rebase_installed_docs): Check html_dir exists.
2004
2005 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2006
2007         [Qt] Don't version QtWebKit.experimental.
2008         https://bugs.webkit.org/show_bug.cgi?id=77739
2009
2010         Reviewed by Tor Arne Vestbø.
2011
2012         * MiniBrowser/qt/qml/BrowserWindow.qml:
2013
2014 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2015
2016         [GTK] Fix several gtkdoc-fixxref warnings
2017         https://bugs.webkit.org/show_bug.cgi?id=77613
2018
2019         Reviewed by Martin Robinson.
2020
2021         * gtk/generate-gtkdoc:
2022         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
2023         of ignored files, since it's private.
2024         * gtk/gtkdoc.py:
2025         (GTKDoc._ignored_files_basenames): Helper function that returns a
2026         string with the list of ignored files basenames separated by a
2027         spaces, as expected by several gtkdoc commands.
2028         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
2029         --ignore-headers option.
2030         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
2031         --ignore-files option.
2032
2033 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2034
2035         [GTK] Fix xrefs after installing API documentation
2036         https://bugs.webkit.org/show_bug.cgi?id=77551
2037
2038         Reviewed by Martin Robinson.
2039
2040         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
2041         api docs.
2042         * gtk/common.py:
2043         (prefix_of_pkg_config_file): Get the prefix variable of the given
2044         pkg-config file.
2045         (gtk_version_of_pkg_config_file): Get the gtk version required by
2046         the given pkg-config file.
2047         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
2048         installed documentation.
2049         (get_gtkdoc_module_paths): Get paths where API doc is installed
2050         for the dependencies of the given pkg-config file.
2051         (get_common_xref_deps): Get API doc directories of dependencies
2052         common to WebKit1 and WebKit2.
2053         (get_webkit2_options): Add cross_reference_deps option.
2054         (get_webkit1_options): Ditto
2055         (rebase_installed_docs): Helper function to create a generator for
2056         the given pkg-config file and options and call rebase_installed_docs.
2057         * gtk/gtkdoc.py:
2058         (GTKDoc.__init__): Initialize cross_reference_deps.
2059         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
2060         dependencies.
2061         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
2062         links of installed documentation.
2063         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
2064         file.
2065
2066 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
2067
2068         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
2069         https://bugs.webkit.org/show_bug.cgi?id=77672
2070
2071         Reviewed by Dirk Pranke.
2072
2073         Test repetitions must be taken into account when working out
2074         the statistics shown by run-webkit-tests.
2075
2076         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2077         (Manager.prepare_lists_and_print_output):
2078         (Manager._print_result_summary):
2079         * Scripts/webkitpy/layout_tests/models/result_summary.py:
2080         (ResultSummary.__init__):
2081         (ResultSummary.add):
2082         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2083         (MainTest.test_repeat_each_iterations_num_tests):
2084
2085 2012-02-05  Dan Bernstein  <mitz@apple.com>
2086
2087         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
2088         https://bugs.webkit.org/show_bug.cgi?id=77823
2089
2090         Reviewed by Anders Carlsson.
2091
2092         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2093         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
2094
2095 2012-02-04  Dan Bernstein  <mitz@apple.com>
2096
2097         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
2098         https://bugs.webkit.org/show_bug.cgi?id=77822
2099
2100         Reviewed by Sam Weinig.
2101
2102         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2103         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
2104
2105 2012-02-04  Sam Weinig  <sam@webkit.org>
2106
2107         Add ability to send WKURLRequests in WebKit2 API user messages
2108         https://bugs.webkit.org/show_bug.cgi?id=77819
2109
2110         Reviewed by Anders Carlsson.
2111
2112         Add testing for round-tripping WKTypes from the UIProcess,
2113         to the WebProcess, and back.
2114
2115         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
2116           More can easily be added.
2117
2118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2119         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
2120         (TestWebKitAPI):
2121         (WebKit2UserMessageRoundTripTest):
2122         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
2123         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
2124         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
2125         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
2126         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
2127         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
2128         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
2129         (TestWebKitAPI::TEST_F):
2130         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
2131         (TestWebKitAPI):
2132         (UserMessageTest):
2133         (TestWebKitAPI::UserMessageTest::UserMessageTest):
2134         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
2135         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2136         (TestWebKitAPI::PlatformWebView::resizeTo):
2137         (TestWebKitAPI):
2138         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2139         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2140
2141 2012-02-04  Dan Bernstein  <mitz@apple.com>
2142
2143         <rdar://problem/10772406> WKPreferences instances cannot be copied
2144         https://bugs.webkit.org/show_bug.cgi?id=77816
2145
2146         Reviewed by Sam Weinig.
2147
2148         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2149         (TestWebKitAPI::TEST):
2150
2151 2012-02-04  Adam Barth  <abarth@webkit.org>
2152
2153         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
2154         https://bugs.webkit.org/show_bug.cgi?id=77802
2155
2156         Reviewed by Eric Seidel.
2157
2158         This patch refactors our directory grouping code into base.js where it
2159         can be shared between failures.js and notifications.js.  It then adds
2160         an Examine action to each group of failures that triggers the "results"
2161         view.
2162
2163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2167         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
2169
2170 2012-02-04  Ojan Vafai  <ojan@chromium.org>
2171
2172         check-webkit-style is throwing an exception
2173         https://bugs.webkit.org/show_bug.cgi?id=77744
2174
2175         Reviewed by David Levin.
2176
2177         If the test_list is None, then we don't need to check for unsupported
2178         feature tests to skip.
2179
2180         * Scripts/webkitpy/layout_tests/port/webkit.py:
2181         (WebKitPort._has_test_in_directories):
2182         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2183         (test_skipped_tests_for_unsupported_features_empty_test_list):
2184
2185 2012-02-03  Adam Barth  <abarth@webkit.org>
2186
2187         List of all failures in garden-o-matic should actually list all the failures
2188         https://bugs.webkit.org/show_bug.cgi?id=77796
2189
2190         Reviewed by Eric Seidel.
2191
2192         This patch wires a bit more data into the new "All Failures" tab.  I've
2193         also iterated on how we enable this experimental feature.  The tab is
2194         still just a dumb list, but we'll make it smarter.
2195
2196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2197         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2199         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2200
2201 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2202
2203         Windows build fix after r106692.
2204
2205         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2206         (PortTest.test_reference_files):
2207
2208 2012-02-03  Beth Dakin  <bdakin@apple.com>
2209
2210         https://bugs.webkit.org/show_bug.cgi?id=77782
2211         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than 
2212         once on some pages with frames
2213         -and corresponding-
2214         <rdar://problem/10798474>
2215
2216         Reviewed by Sam Weinig.
2217
2218         One new test.
2219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2220         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
2221         (TestWebKitAPI):
2222         (TestWebKitAPI::didForceRepaint):
2223         (TestWebKitAPI::didFinishLoadForFrame):
2224         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2225         (TestWebKitAPI::setPageLoaderClient):
2226         (TestWebKitAPI::TEST):
2227         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
2228         (TestWebKitAPI):
2229         (NewFirstVisuallyNonEmptyLayoutFramesTest):
2230         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
2231         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
2232         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
2233
2234 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
2235
2236         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
2237         https://bugs.webkit.org/show_bug.cgi?id=77781
2238
2239         Reviewed by Eric Seidel.
2240
2241         This change fixes a couple of issues discovered while debugging
2242         test-webkitpy; both calling exit() instead of sys.exit() --
2243         which is discouraged in program code instead of the interpreter
2244         -- and a particular usage of outputcapture were stdin to get whacked
2245         and preventing debugging.
2246        
2247         This change introduces a couple of common _exit() methods that
2248         will standardize how webkit-patch exit's, in case we need to do
2249         something different in the future.
2250
2251         * Scripts/webkitpy/common/system/deprecated_logging.py:
2252         (error):
2253         * Scripts/webkitpy/common/system/outputcapture.py:
2254         (OutputCapture.assert_outputs):
2255         * Scripts/webkitpy/tool/bot/queueengine.py:
2256         (QueueEngine.exit_after_handled_error):
2257         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2258         (AbstractSequencedCommand.execute):
2259         * Scripts/webkitpy/tool/commands/queues.py:
2260         (StyleQueue.handle_script_error):
2261         * Scripts/webkitpy/tool/commands/upload.py:
2262         (MarkBugFixed.execute):
2263         * Scripts/webkitpy/tool/multicommandtool.py:
2264         (Command._exit):
2265         * Scripts/webkitpy/tool/steps/abstractstep.py:
2266         (AbstractStep._exit):
2267         * Scripts/webkitpy/tool/steps/checkstyle.py:
2268         (CheckStyle.run):
2269         * Scripts/webkitpy/tool/steps/commit.py:
2270         (Commit._check_test_expectations):
2271         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2272         (ConfirmDiff.run):
2273
2274 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2275
2276         Perf bot build fix.
2277
2278         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2279         (PerfTestsRunner._generate_json):
2280
2281 2012-02-03  Adam Barth  <abarth@webkit.org>
2282
2283         Add a blank "Expected Failures" tab to garden-o-matic
2284         https://bugs.webkit.org/show_bug.cgi?id=77793
2285
2286         Reviewed by Eric Seidel.
2287
2288         This tab will help us explore and manage our expected failures.  The
2289         tab is hidden by default via a new "experimental features" flag.
2290
2291         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2296         (#unexpected):
2297         (#onebar.partytime #unexpected):
2298
2299 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2300
2301         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
2302         https://bugs.webkit.org/show_bug.cgi?id=77785
2303
2304         Fix the build bots.
2305         
2306         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
2307
2308         * Scripts/update-webkit-support-libs:
2309         (downloadExpectedVersionNumber):
2310
2311 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2312
2313         Add a Mac Lion Performance bot.
2314         https://bugs.webkit.org/show_bug.cgi?id=77765
2315
2316         Reviewed by Adam Roben.
2317
2318         This will update the master configuration in the following ways:
2319             Add a new performance slave (apple-xseve-11)
2320             Add a new Factory to download a build and run perf tests.
2321             
2322         * BuildSlaveSupport/build.webkit.org-config/config.json:
2323         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2324         (DownloadAndPerfTestFactory):
2325         (DownloadAndPerfTestFactory.__init__):
2326
2327 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
2328
2329         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
2330         https://bugs.webkit.org/show_bug.cgi?id=77752
2331
2332         Reviewed by James Robinson.
2333
2334         Delete unneeded file accidentally checked in in r106481.
2335
2336         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
2337
2338 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2339
2340         Ref Tests should support plain SVG files
2341         https://bugs.webkit.org/show_bug.cgi?id=77685
2342
2343         Reviewed by Tony Chang.
2344
2345         Don't assume reference files always use .html as the extension.
2346         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
2347
2348         Also fix various bugs in MockFileSystem and TestPort.
2349
2350         * Scripts/webkitpy/common/system/filesystem_mock.py:
2351         (MockFileSystem.isdir):
2352         * Scripts/webkitpy/layout_tests/port/base.py:
2353         (Port.reference_files):
2354         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2355         (PortTest.test_is_test_file):
2356         (PortTest.test_reference_files):
2357         * Scripts/webkitpy/layout_tests/port/test.py:
2358         (TestInstance.__init__):
2359
2360 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2361
2362         perf-o-matic should store chromium svn revision
2363         https://bugs.webkit.org/show_bug.cgi?id=77725
2364
2365         Reviewed by Dirk Pranke.
2366
2367         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
2368         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
2369         is implemented in terms of newly added svn_revision.
2370
2371         * Scripts/webkitpy/common/checkout/scm/git.py:
2372         (Git.svn_revision):
2373         * Scripts/webkitpy/common/checkout/scm/scm.py:
2374         (SCM.head_svn_revision):
2375         (SCM):
2376         (SCM.svn_revision):
2377         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2378         (MockSCM.svn_revision):
2379         * Scripts/webkitpy/common/checkout/scm/svn.py:
2380         (SVN.svn_revision):
2381         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2382         (JSONLayoutResultsGenerator.__init__):
2383         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2384         (JSONResultsGeneratorBase._insert_generic_metadata):
2385         * Scripts/webkitpy/layout_tests/port/base.py:
2386         (Port.repository_paths):
2387         * Scripts/webkitpy/layout_tests/port/chromium.py:
2388         (ChromiumPort.repository_paths):
2389         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2390         (PerfTestsRunner._generate_json):
2391         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2392         (test_run_test_set_with_json_output):
2393         (test_run_test_set_with_json_source):
2394         (test_run_test_set_with_multiple_repositories):
2395
2396 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2397
2398         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
2399         https://bugs.webkit.org/show_bug.cgi?id=77632
2400
2401         Reviewed by Kenneth Rohde Christiansen.
2402
2403         * MiniBrowser/qt/BrowserWindow.cpp:
2404         (BrowserWindow::BrowserWindow):
2405         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2406         (MiniBrowserApplication::sendTouchEvent):
2407         (MiniBrowserApplication::handleUserOptions):
2408         * MiniBrowser/qt/MiniBrowserApplication.h:
2409         (WindowOptions):
2410         (WindowOptions::WindowOptions):
2411         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2412         (WTR::PlatformWebView::PlatformWebView):
2413         * WebKitTestRunner/qt/main.cpp:
2414         (main):
2415         * qmake/mkspecs/features/default_post.prf:
2416
2417 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
2418
2419         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
2420         https://bugs.webkit.org/show_bug.cgi?id=77723
2421
2422         Reviewed by Tor Arne Vestbø.
2423
2424         * Tools.pro: Compile WTR again on all platforms with WK2.
2425
2426 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
2427
2428         Ensure that inspector disabled build works
2429         https://bugs.webkit.org/show_bug.cgi?id=77604
2430
2431         Reviewed by Tor Arne Vestbø.
2432
2433         * qmake/mkspecs/features/features.prf:
2434
2435 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
2436
2437         [chromium] add support for --makeargs to the ninja-based build
2438         https://bugs.webkit.org/show_bug.cgi?id=77688
2439
2440         Reviewed by Adam Barth.
2441
2442         * Scripts/webkitdirs.pm:
2443         (buildChromiumNinja):
2444
2445 2012-02-02  Eric Seidel  <eric@webkit.org>
2446
2447         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
2448         https://bugs.webkit.org/show_bug.cgi?id=75145
2449
2450         Reviewed by Dirk Pranke.
2451
2452         * Scripts/webkitpy/layout_tests/port/mac.py:
2453         (MacPort.default_child_processes):
2454         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2455         (test_operating_system):
2456         (test_default_child_processes):
2457
2458 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
2459
2460        nrwt shouldn't blow up when there are errors in test_expectations.txt
2461        https://bugs.webkit.org/show_bug.cgi?id=73603
2462
2463        Reviewed by Ojan Vafai.
2464
2465        This change removes the distinction between 'errors' and 'warnings'
2466        in the test expectations parser. Now, any problem is a
2467        'warning', and if we are linting the file, warnings become fatal (errors).
2468
2469         This will allow a normal run-webkit-tests run to proceed even if
2470         there are bad lines.
2471
2472         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2473         (ParseError.__init__):
2474         (ParseError.__str__):
2475         (ParseError.__repr__):
2476         (TestExpectationSerializer.to_string):
2477         (TestExpectationParser._parse_modifiers):
2478         (TestExpectationParser._parse_expectations):
2479         (TestExpectationParser._check_modifiers_against_expectations):
2480         (TestExpectationParser._tokenize):
2481         (TestExpectationLine.__init__):
2482         (TestExpectationLine.is_invalid):
2483         (TestExpectationsModel.add_expectation_line):
2484         (TestExpectationsModel._already_seen_better_match):
2485         (TestExpectations.__init__):
2486         (TestExpectations._report_warnings):
2487         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
2488         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2489         (assert_bad_expectations):
2490         (test_parse_warning):
2491         (test_overrides__duplicate):
2492         (ExpectationSyntaxTests.test_missing_expectation):
2493         (ExpectationSyntaxTests.test_missing_colon):
2494         (ExpectationSyntaxTests.test_too_many_colons):
2495         (ExpectationSyntaxTests.test_too_many_equals_signs):
2496         (ExpectationSyntaxTests.test_unrecognized_expectation):
2497         (SemanticTests.test_bug_format):
2498         (SemanticTests.test_bad_bugid):
2499         (SemanticTests.test_slow_and_timeout):
2500         (test_ambiguous):
2501         (test_more_modifiers):
2502         (test_order_in_file):
2503         (test_macro_overrides):
2504         (RebaseliningTest.assertRemove):
2505         (TestExpectationParserTests.test_tokenize_blank):
2506         (TestExpectationParserTests.test_tokenize_missing_colon):
2507         (TestExpectationParserTests.test_tokenize_extra_colon):
2508         (TestExpectationParserTests.test_tokenize_empty_comment):
2509         (TestExpectationParserTests.test_tokenize_comment):
2510         (TestExpectationParserTests.test_tokenize_missing_equal):
2511         (TestExpectationParserTests.test_tokenize_extra_equal):
2512         (TestExpectationParserTests.test_tokenize_valid):
2513         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2514         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2515         (TestExpectationSerializerTests.test_unparsed_to_string):
2516         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2517         (lint):
2518         * Scripts/webkitpy/style/checkers/test_expectations.py:
2519         (TestExpectationsChecker.check_test_expectations):
2520
2521 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2522
2523         Unreviewed, rolling out r106543.
2524         http://trac.webkit.org/changeset/106543
2525         https://bugs.webkit.org/show_bug.cgi?id=77671
2526
2527         Made tests less stable (Requested by rniwa on #webkit).
2528
2529         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2530         (PerfTestsRunner):
2531         (PerfTestsRunner.__init__):
2532         (PerfTestsRunner._run_tests_set):
2533         (PerfTestsRunner._run_single_test):
2534         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2535         (MainTest.TestDriver.run_test):
2536         (run_test):
2537
2538 2012-02-02  Beth Dakin  <bdakin@apple.com>
2539
2540         https://bugs.webkit.org/show_bug.cgi?id=77664
2541         Add API tests for didNewFirstVisuallyNonEmptyLayout
2542
2543         Reviewed by Darin Adler.
2544
2545         Two new tests.
2546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2547         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
2548         (TestWebKitAPI):
2549         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2550         (TestWebKitAPI::setPageLoaderClient):
2551         (TestWebKitAPI::TEST):
2552         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
2553         (TestWebKitAPI):
2554         (TestWebKitAPI::didForceRepaint):
2555         (TestWebKitAPI::didFinishLoadForFrame):
2556         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2557         (TestWebKitAPI::setPageLoaderClient):
2558         (TestWebKitAPI::TEST):
2559         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
2560         (TestWebKitAPI):
2561         (NewFirstVisuallyNonEmptyLayoutFailsTest):
2562         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
2563         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
2564         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
2565         (TestWebKitAPI):
2566         (NewFirstVisuallyNonEmptyLayoutTest):
2567         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
2568         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
2569
2570 2012-02-02  Michael Saboff  <msaboff@apple.com>
2571
2572         Add Michael Saboff to reviewers list.
2573
2574         Rubber-stamped by Gavin Barraclough.
2575
2576         * Scripts/webkitpy/common/config/committers.py:
2577
2578 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2579
2580         Add myself as a committer
2581
2582         Unreviewed
2583
2584         * Scripts/webkitpy/common/config/committers.py:
2585
2586 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
2587
2588         [PerformanceTests] tests have dependencies
2589         https://bugs.webkit.org/show_bug.cgi?id=77506
2590
2591         Reviewed by Hajime Morita.
2592
2593         Load an initialization page before each test after starting a DRT so that
2594         warming up DRT won't affect the performance test results.
2595
2596         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2597         (PerfTestsRunner):
2598         (PerfTestsRunner.__init__):
2599         (PerfTestsRunner._run_tests_set):
2600         (PerfTestsRunner._run_single_test):
2601         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2602         (MainTest.TestDriver.run_test):
2603         (test_initial_page_loaded):
2604         (test_initial_page_loaded.run_test):
2605
2606 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
2607
2608         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
2609
2610         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2611         (PerfTestsRunner._run_tests_set):
2612         (PerfTestsRunner._run_single_test):
2613         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2614         (create_runner):
2615         (test_run_passing_test):
2616         (test_run_silent_test):
2617         (test_run_failed_test):
2618         (test_run_tonguey_test):
2619         (test_run_timeout_test):
2620         (test_run_crash_test):
2621         (test_run_test_set_kills_drt_per_run):
2622         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2623         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
2624         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
2625
2626 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
2627
2628         Webkit generate-coverage-data script needs update to use new test script
2629         https://bugs.webkit.org/show_bug.cgi?id=77597
2630
2631         Reviewed by Dirk Schulze.
2632
2633         * Scripts/generate-coverage-data:
2634
2635 2012-02-01  Adam Barth  <abarth@webkit.org>
2636
2637         Update the tests to show that the mac-ews processes patches from
2638         non-committers.
2639
2640         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2641         (EarlyWarningSytemTest.test_committer_only_ewses):
2642         (EarlyWarningSytemTest.test_builder_ewses):
2643
2644 2012-02-01  Adam Barth  <abarth@webkit.org>
2645
2646         Mac-ews logs are huge
2647         https://bugs.webkit.org/show_bug.cgi?id=77045
2648
2649         Reviewed by Eric Seidel.
2650
2651         In order to get the cr-linux-ews bot to run tests on EC2, we created
2652         the chromium-xvfb port, which contained a number of tweaks to the
2653         Chromium port's behavior.  This patch refactors those tweaks so they
2654         can be shared with the mac-ews, mostly by moving them into the
2655         non-interactive mode of RunTests.
2656
2657         * Scripts/webkitpy/common/config/ports.py:
2658         (WebKitPort):
2659         (WebKitPort.layout_tests_results_path):
2660         (ChromiumPort.run_javascriptcore_tests_command):
2661         (ChromiumXVFBPort):
2662         (ChromiumXVFBPort.run_webkit_tests_command):
2663         * Scripts/webkitpy/common/config/ports_mock.py:
2664         (MockPort):
2665         (MockPort.layout_tests_results_path):
2666         * Scripts/webkitpy/common/config/ports_unittest.py:
2667         (WebKitPortTest.test_chromium_xvfb_port):
2668         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2669         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2670         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2671         (CommitQueueTest.test_commit_queue):
2672         (test_rollout):
2673         (test_manual_reject_during_processing):
2674         * Scripts/webkitpy/tool/steps/runtests.py:
2675         (RunTests.run):
2676         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2677         (RunTestsTest.test_no_unit_tests):
2678         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2679         (StepsTest.test_runtests_args):
2680
2681 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
2682
2683         Roll out r106442. It made some tests more stable but others less stable.
2684
2685         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2686         (PerfTestsRunner._run_tests_set):
2687         (PerfTestsRunner._run_single_test):
2688         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2689         (create_runner):
2690         (test_run_passing_test):
2691         (test_run_silent_test):
2692         (test_run_failed_test):
2693         (test_run_tonguey_test):
2694         (test_run_timeout_test):
2695         (test_run_crash_test):
2696         (test_run_test_set):
2697
2698 2012-02-01  Lucas Forschler  <lforschler@apple.com>
2699
2700         Enable EWS for non-contributers.
2701         https://bugs.webkit.org/show_bug.cgi?id=77576
2702         
2703         Reviewed by Adam Barth.
2704
2705         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2706         (MacEWS):
2707
2708 2012-02-01  Beth Dakin  <bdakin@apple.com>
2709
2710         https://bugs.webkit.org/show_bug.cgi?id=77383
2711         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
2712         -and corresponding-
2713         <rdar://problem/10709560>
2714
2715         Reviewed by Sam Weinig.
2716
2717         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
2718         for.
2719         * MiniBrowser/mac/BrowserWindowController.m:
2720         (-[BrowserWindowController awakeFromNib]):
2721         * WebKitTestRunner/TestController.cpp:
2722         (WTR::TestController::initialize):
2723
2724 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
2725
2726         TestWebKitAPI isn't being built on chromium bots any more
2727         https://bugs.webkit.org/show_bug.cgi?id=77563
2728
2729         Reviewed by Dimitri Glazkov.
2730
2731         I accidentally dropped it in the refactoring in r105449.
2732
2733         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
2734
2735 2012-02-01  Hans Wennborg  <hans@chromium.org>
2736
2737         Rename WebSpeechInputResult::set() to assign()
2738         https://bugs.webkit.org/show_bug.cgi?id=77540
2739
2740         Reviewed by Darin Fisher.
2741
2742         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2743         (MockWebSpeechInputController::addMockRecognitionResult):
2744         (MockWebSpeechInputController::speechTaskFired):
2745
2746 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2747
2748         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
2749         https://bugs.webkit.org/show_bug.cgi?id=77542
2750
2751         Reviewed by Martin Robinson.
2752
2753         * gtk/generate-gtkdoc: Check first whether there's
2754         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
2755         instead.
2756         (get_webkit2_options): Return just the options since the
2757         pkg_config_path doesn't depend on options
2758         (get_webkit1_options): Ditto.
2759         (generate_doc): Helper function to create a generator and generate
2760         documentation for the given pkg-config file with the given options.
2761         * gtk/gtkdoc.py:
2762         (GTKDoc.__init__): Don't use ** for args parameter, since it's
2763         used as a dict and never expanded.
2764         (PkgConfigGTKDoc.__init__): Ditto.
2765
2766 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2767
2768         [GTK] API documentation is not installed even when building with --enable-gtk-doc
2769         https://bugs.webkit.org/show_bug.cgi?id=77094
2770
2771         Reviewed by Martin Robinson.
2772
2773         * GNUmakefile.am: Add install-data-local and uninstall-local rules
2774         to install/uninstall WebKit1 and WebKit2 API documentation.
2775
2776 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2777
2778         Unreviewed, rolling out r106460.
2779         http://trac.webkit.org/changeset/106460
2780         https://bugs.webkit.org/show_bug.cgi?id=77552
2781
2782         It break unit tests if WEBKIT_TESTFONTS isn't defined.
2783         (Requested by Ossy on #webkit).
2784
2785         * Scripts/webkitpy/layout_tests/port/qt.py:
2786
2787 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
2788
2789         [Qt] Automatic clean build feature always do clean build with --no-webkit2
2790         https://bugs.webkit.org/show_bug.cgi?id=74519
2791
2792         Reviewed by Tor Arne Vestbø.
2793
2794         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
2795
2796         * qmake/mkspecs/features/features.prf:
2797
2798 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2799
2800         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
2801         https://bugs.webkit.org/show_bug.cgi?id=77466
2802
2803         Reviewed by Kenneth Rohde Christiansen.
2804
2805         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
2806         is set or if we should raise an error.
2807
2808         * Scripts/webkitpy/layout_tests/port/qt.py:
2809         (QtPort.setup_environ_for_server):
2810
2811 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
2812
2813         Reviewed by Martin Robinson.
2814
2815         [GTK] Improve FrameLoader signals. Resource loading
2816         https://bugs.webkit.org/show_bug.cgi?id=49543
2817
2818         Support for the new loader signals in DRT.
2819
2820         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2821         (urlPath):
2822         (willSendRequestCallback):
2823         (urlSuitableForTestResult):
2824         (descriptionSuitableForTestResult):
2825         (didReceiveResponse):
2826         (didFinishLoading):
2827         (didFailLoadingWithError):
2828         (createWebView):
2829
2830 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
2831
2832         run-perf-tests should restart DRT for each test
2833         https://bugs.webkit.org/show_bug.cgi?id=77506
2834
2835         Reviewed by Adam Barth.
2836
2837         Always restart DRT when running performance tests in order to minimize the dependency between tests.
2838
2839         * Scripts/webkitpy/layout_tests/port/chromium.py:
2840         (ChromiumDriver.stop):
2841         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2842         (PerfTestsRunner._run_tests_set):
2843         (PerfTestsRunner._run_single_test):
2844         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2845         (create_runner):
2846         (test_run_passing_test):
2847         (test_run_silent_test):
2848         (test_run_failed_test):
2849         (test_run_tonguey_test):
2850         (test_run_timeout_test):
2851         (test_run_crash_test):
2852         (test_run_test_set_kills_drt_per_run):
2853         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2854         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
2855         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
2856
2857 2012-01-31  Hans Wennborg  <hans@chromium.org>
2858
2859         Speech Input: Report speech element rect relative to window rather than frame
2860         https://bugs.webkit.org/show_bug.cgi?id=76443
2861
2862         Reviewed by Darin Fisher.
2863
2864         Update LayoutTestController to allow for retrieving the speech
2865         element's position used in a request.
2866
2867         In Chromium this is handled by the MockWebSpeechInputController;
2868         adding stubs for the other implementations.
2869
2870         * DumpRenderTree/LayoutTestController.cpp:
2871         (setMockSpeechInputDumpRectCallback):
2872         (LayoutTestController::staticFunctions):
2873         * DumpRenderTree/LayoutTestController.h:
2874         (LayoutTestController):
2875         * DumpRenderTree/chromium/LayoutTestController.cpp:
2876         (LayoutTestController::LayoutTestController):
2877         (LayoutTestController::setMockSpeechInputDumpRect):
2878         * DumpRenderTree/chromium/LayoutTestController.h:
2879         (LayoutTestController):
2880         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2881         (MockWebSpeechInputController::setDumpRect):
2882         (MockWebSpeechInputController::clearResults):
2883         (MockWebSpeechInputController::startRecognition):
2884         (MockWebSpeechInputController::MockWebSpeechInputController):
2885         (makeRectResult):
2886         (MockWebSpeechInputController::speechTaskFired):
2887         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
2888         (MockWebSpeechInputController):
2889         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2890         (LayoutTestController::setMockSpeechInputDumpRect):
2891         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2892         (LayoutTestController::setMockSpeechInputDumpRect):
2893         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2894         (LayoutTestController::setMockSpeechInputDumpRect):
2895         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2896         (LayoutTestController::setMockSpeechInputDumpRect):
2897         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2898         (LayoutTestController):
2899         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2900         (LayoutTestController::setMockSpeechInputDumpRect):
2901         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2902         (LayoutTestController::setMockSpeechInputDumpRect):
2903
2904 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
2905
2906         [EFL] Add basic DRT/Efl implementation to support viewport test.
2907         https://bugs.webkit.org/show_bug.cgi?id=77320
2908
2909         Reviewed by Andreas Kling.
2910
2911         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2912         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
2913
2914 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
2915
2916         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
2917         https://bugs.webkit.org/show_bug.cgi?id=77473
2918         <rdar://problem/10751357>
2919
2920         Reviewed by Darin Adler.
2921
2922         * DumpRenderTree/mac/EventSendingController.mm:
2923         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2924         * WebKitTestRunner/mac/EventSenderProxy.mm:
2925         (WTR::EventSenderProxy::keyDown):
2926         Added a new special keyDown value to test this.
2927
2928 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
2929
2930         nrwt: fix the mock port to work with DriverProxy, reftests
2931         https://bugs.webkit.org/show_bug.cgi?id=77170
2932
2933         Reviewed by Eric Seidel.
2934
2935         The DryrunPort used for benchmarking and testing NRWT has been
2936         broken since we added the DriverProxy code. It isn't really
2937         needed any more, so I've removed it.
2938
2939         The MockDRT port was also broken by DriverProxy, and moreover,
2940         never worked w/ reftests. Since we don't exercise this module in
2941         the unit tests, the code had also bitrotted some. I have cleaned
2942         it up and made it use DriverInput and DriverOutput for
2943         consistency.
2944
2945         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2946         (DryRunPort.__init__):
2947         (DryRunPort):
2948         (DryRunPort.real_name):
2949         (DryRunPort.create_driver):
2950         (DryRunPort.driver_cmd_line):
2951         (DryRunPort._driver_class):
2952         (DryrunDriver):
2953         (DryrunDriver.run_test):
2954         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2955         (MockDRTPort.create_driver):
2956         (MockChromiumDRT.run_one_test):
2957
2958 2012-01-31  Ojan Vafai  <ojan@chromium.org>
2959
2960         run-webkit-tests calls out to webkit-build-directory twice
2961         https://bugs.webkit.org/show_bug.cgi?id=77248
2962
2963         Reviewed by Dirk Pranke.
2964
2965         * Scripts/webkit-build-directory:
2966         If called with no arguments, print out both the top-level directory and the 
2967         configuration directory
2968
2969         * Scripts/webkitpy/layout_tests/port/config.py:
2970         (Config.build_directory):
2971         When called with no arguments, get and cache both the top-level and configuration directories.
2972
2973         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2974         (main):
2975         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2976         (ConfigTest.assert_configuration):
2977         (ConfigTest.test_build_directory.mock_webkit_build_directory):
2978         (ConfigTest.test_build_directory):
2979         (ConfigTest.test_default_configuration__notfound):
2980         * Scripts/webkitpy/layout_tests/port/webkit.py:
2981         (WebKitPort._build_path):
2982         Cache the build directory in the options object so that other users
2983         of the options object don't need to call out to webkit-build-directory.
2984         Also, properly support the existing --build-directory argument.
2985
2986 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
2987
2988         Bump up the timeout for performance tests since DOM/DOMTable.html
2989         and Parser/html5-full-render.html are timing out on the bot.
2990
2991         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2992         (PerfTestsRunner._parse_args):
2993
2994 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
2995
2996         Fix the update_webgl_conformance_tests.py script in order to enable it
2997         to detect the SCM being used correctly.
2998         https://bugs.webkit.org/show_bug.cgi?id=77462
2999
3000         Reviewed by Kenneth Russell.
3001
3002         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3003         (default_out_dir):
3004
3005 2012-01-31  Eric Seidel  <eric@webkit.org>
3006
3007         webkit-patch apply-from-bug should work regardless of your CWD
3008         https://bugs.webkit.org/show_bug.cgi?id=77482
3009
3010         Reviewed by Adam Barth.
3011
3012         webkit-patch only ever works with patches made from the root
3013         directory.  We should pass the CWD to svn-apply in the case
3014         where we're running not from the webkit root.  I believe
3015         this used to work in the past and regressed.
3016
3017         * Scripts/webkitpy/common/checkout/checkout.py:
3018         (Checkout.apply_patch):
3019         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3020         (CheckoutTest.test_apply_patch):
3021
3022 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3023
3024         Unreviewed, rolling out r106302.
3025         http://trac.webkit.org/changeset/106302
3026         https://bugs.webkit.org/show_bug.cgi?id=77472
3027
3028         Broke building DRT before running the tests (Requested by ojan
3029         on #webkit).
3030
3031         * Scripts/webkit-build-directory:
3032         * Scripts/webkitpy/layout_tests/port/config.py:
3033         (Config.build_directory):
3034         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3035         (main):
3036         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3037         (ConfigTest.assert_configuration):
3038         (ConfigTest.test_build_directory.mock_webkit_build_directory):
3039         (ConfigTest.test_build_directory):
3040         (ConfigTest.test_default_configuration__notfound):
3041         * Scripts/webkitpy/layout_tests/port/webkit.py:
3042         (WebKitPort._build_path):
3043
3044 2012-01-31  Antoine Labour  <piman@chromium.org>
3045
3046         Merge WebGraphicsContext3D creation and initialization, and move it to
3047         WebViewClient.
3048         https://bugs.webkit.org/show_bug.cgi?id=76593
3049
3050         Reviewed by Darin Fisher.
3051
3052         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3053         (TestWebPlugin::TestWebPlugin):
3054         (TestWebPlugin::initialize):
3055         * DumpRenderTree/chromium/TestWebPlugin.h:
3056         * DumpRenderTree/chromium/WebViewHost.cpp:
3057         (WebViewHost::createGraphicsContext3D):
3058         (WebViewHost::createPlugin):
3059         * DumpRenderTree/chromium/WebViewHost.h:
3060
3061 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
3062
3063         [GTK] build-webkit warning.
3064         https://bugs.webkit.org/show_bug.cgi?id=77411
3065
3066         Reviewed by Philippe Normand.
3067
3068         * Scripts/webkitdirs.pm:
3069         (isCrossCompilation):
3070
3071 2012-01-31  Dan Bernstein  <mitz@apple.com>
3072
3073         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
3074
3075         Reviewed by Anders Carlsson.
3076
3077         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3078
3079 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
3080
3081         If the QTDIR environment variable is set, the build system fails to compile WinCairo
3082         https://bugs.webkit.org/show_bug.cgi?id=77112
3083
3084         Reviewed by Daniel Bates.
3085
3086         * Scripts/webkitdirs.pm:
3087         (determineIsQt):
3088
3089 2012-01-31  Adam Roben  <aroben@apple.com>
3090
3091         Only call -typingAttributes on WebViews, not WebHTMLViews
3092
3093         Looks like this case was just missed in r105908.
3094
3095         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
3096
3097         Reviewed by Antti Koivisto.
3098
3099         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3100         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
3101         earlier.
3102
3103 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3104
3105         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
3106         https://bugs.webkit.org/show_bug.cgi?id=77221
3107
3108         Reviewed by Kenneth Rohde Christiansen.
3109
3110         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
3111
3112         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3113         (MiniBrowserApplication::sendTouchEvent):
3114
3115 2012-01-26  Hans Wennborg  <hans@chromium.org>
3116
3117         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
3118         https://bugs.webkit.org/show_bug.cgi?id=77083
3119
3120         Reviewed by Darin Fisher.
3121
3122         Add MockWebSpeechInputController which provides a mock implementation
3123         of the WebSpeechInputController interface, and use that in
3124         DumpRenderTree.
3125
3126         * DumpRenderTree/DumpRenderTree.gypi:
3127         * DumpRenderTree/chromium/LayoutTestController.cpp:
3128         (LayoutTestController::addMockSpeechInputResult):
3129         * DumpRenderTree/chromium/LayoutTestController.h:
3130         ():
3131         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
3132         (MockWebSpeechInputController::create):
3133         (MockWebSpeechInputController::addMockRecognitionResult):
3134         (MockWebSpeechInputController::clearResults):
3135         (MockWebSpeechInputController::startRecognition):
3136         (MockWebSpeechInputController::cancelRecognition):
3137         (MockWebSpeechInputController::stopRecording):
3138         (MockWebSpeechInputController::MockWebSpeechInputController):
3139         (MockWebSpeechInputController::speechTaskFired):
3140         (MockWebSpeechInputController::SpeechTask::SpeechTask):
3141         (MockWebSpeechInputController::SpeechTask::stop):
3142         (MockWebSpeechInputController::SpeechTask::runIfValid):
3143         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
3144         (WebKit):
3145         (MockWebSpeechInputController):
3146         (MockWebSpeechInputController::taskList):
3147         (SpeechTask):
3148         * DumpRenderTree/chromium/TestShell.cpp:
3149         * DumpRenderTree/chromium/WebViewHost.cpp:
3150         (WebViewHost::speechInputController):
3151         * DumpRenderTree/chromium/WebViewHost.h:
3152         (WebKit):
3153         (WebViewHost::speechInputControllerMock):
3154         (WebViewHost):
3155         ():
3156
3157 2012-01-31  Hajime Morrita  <morrita@chromium.org>
3158
3159         [PerformanceTests] Add landing html for Dromaeo dom-query test
3160         https://bugs.webkit.org/show_bug.cgi?id=77329
3161
3162         Reviewed by Ryosuke Niwa.
3163
3164         Added some more ignorable output patterns to allow warnings
3165         from a third party test suite.
3166
3167         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3168         (PerfTestsRunner):
3169         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
3170
3171 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
3172
3173         [wx] Unreviewed. Update download URLs to new domain.
3174         
3175         * waf/build/build_utils.py:
3176         (update_wx_deps):
3177
3178 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
3179
3180         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
3181         to the list of build directories.
3182         
3183         * waf/build/settings.py:
3184
3185 2012-01-30  Kentaro Hara  <haraken@chromium.org>
3186
3187         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
3188         output an empty method name (i.e. "()")
3189         https://bugs.webkit.org/show_bug.cgi?id=77336
3190
3191         Reviewed by Darin Adler.
3192
3193         r105797 tried to detect a change outside methods, but it causes a bug that
3194         prepare-ChangeLog can output an empty method name, like this:
3195
3196             * foo/bar/baz.cpp:
3197             (method1):
3198             ():
3199             (method2):
3200
3201         This is because the cpp parser in prepare-ChangeLog cannot distinguish
3202         '{' as the beginning of a method with '{' as the beginning of an array definition
3203         at the top level.
3204
3205             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
3206
3207             void func() { // This '{' is the beginning of a method.
3208                 ...;
3209             }
3210
3211         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
3212
3213         * Scripts/prepare-ChangeLog:
3214         (get_function_line_ranges_for_cpp): Modified as described above.
3215         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
3216         an empty method name. Ideally this should not happen but may happen, since the
3217         parsers are not perfect.
3218         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
3219         (NameSpace7):
3220         (NameSpace8):
3221         (Class109):
3222         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
3223
3224 2012-01-30  Ojan Vafai  <ojan@chromium.org>
3225
3226         run-webkit-tests calls out to webkit-build-directory twice
3227         https://bugs.webkit.org/show_bug.cgi?id=77248
3228
3229         Reviewed by Dirk Pranke.
3230
3231         This reduces to calls to webkit-build-directory to one call and
3232         saves 500ms for run-webkit-tests over a single file.
3233
3234         * Scripts/webkit-build-directory:
3235         If called with no arguments, print out both the top-level directory and the 
3236         configuration directory.
3237
3238         * Scripts/webkit-build-directory:
3239         * Scripts/webkitpy/layout_tests/port/config.py:
3240         (Config.build_directory):
3241         When called with no arguments, get and cache both the top-level and configuration directories.
3242
3243         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3244         (main):
3245         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3246         (ConfigTest.assert_configuration):
3247         (ConfigTest.test_build_directory.mock_webkit_build_directory):
3248         (ConfigTest.test_build_directory):
3249         (ConfigTest.test_default_configuration__notfound):
3250         * Scripts/webkitpy/layout_tests/port/webkit.py:
3251         (WebKitPort._build_path):
3252         Cache the root directory in the options object so that other users
3253         of the options object don't need to call out to webkit-build-directory.
3254
3255 2012-01-30  Ojan Vafai  <ojan@chromium.org>
3256
3257         Parsing test_expecations.txt + Skipped lists takes too long
3258         https://bugs.webkit.org/show_bug.cgi?id=77059
3259
3260         Reviewed by Dirk Pranke.
3261
3262         This saves ~100ms on the Apple Mac port.
3263         -memoize a bunch of path methods.
3264         -Avoid doing multiple disk accesses per line.
3265         -Parse the skipped list directly instead of turning it into a test_expecations.txt
3266         formatting string and parsing that.
3267
3268         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3269         (TestExpectationParser):
3270         (TestExpectationParser.expectation_for_skipped_test):
3271         (TestExpectationParser._parse_line):
3272         (TestExpectationParser._collect_matching_tests):
3273         (TestExpectations.__init__):
3274         (TestExpectations._add_skipped_tests):
3275         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3276         (test_add_skipped_tests):
3277         (test_add_skipped_tests_duplicate):
3278         * Scripts/webkitpy/layout_tests/port/base.py:
3279         (Port):
3280         (Port.test_isfile):
3281         (Port.normalize_test_name):
3282         (Port.layout_tests_dir):
3283         (Port.abspath_for_test):
3284         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3285
3286 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
3287
3288         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
3289         
3290         * Scripts/webkitpy/common/config/watchlist:
3291
3292 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
3293
3294         Unreviewed build fix following bug#76855
3295
3296         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3297         ():
3298         (TestWebKitAPI::TEST_F):
3299
3300 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3301
3302         [Qt] WKTR: Use a software rendering pipiline when running tests.
3303         https://bugs.webkit.org/show_bug.cgi?id=76708
3304
3305         Reviewed by Kenneth Rohde Christiansen.
3306
3307         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3308         (WTR::WrapperWindow::WrapperWindow):
3309         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
3310
3311 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3312
3313         [Qt] Store build config immediately instead of waiting for a successfull build
3314
3315         Otherwise we will not pick up changes to the config if the build is aborted,
3316         for example due to build errors or if the user pressed Ctrl+Z. We now write
3317         the new config before starting a build, but still defer to write the SVN
3318         revision once the build completes successfully.
3319
3320         Reviewed by Ossy.
3321
3322         * Scripts/webkitdirs.pm:
3323         (buildQMakeProjects):
3324
3325 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
3326
3327         [Qt] Add "New Window" button to the Qt MiniBrowser
3328         https://bugs.webkit.org/show_bug.cgi?id=77281
3329
3330         Reviewed by Tor Arne Vestbø.
3331
3332         * MiniBrowser/qt/BrowserWindow.cpp:
3333         (BrowserWindow::BrowserWindow):
3334         * MiniBrowser/qt/MiniBrowser.qrc:
3335         * MiniBrowser/qt/icons/plus.png: Added.
3336         * MiniBrowser/qt/qml/BrowserWindow.qml:
3337
3338 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
3339
3340         Unreviewed rolling out r106222.
3341
3342         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3343         (SingleTestRunner.__init__):
3344         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3345         (Worker.handle_test_list):
3346         * Scripts/webkitpy/layout_tests/models/test_input.py:
3347         (TestInput.__init__):
3348         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3349         (_set_up_derived_options):
3350         (parse_args):
3351         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3352         (MainTest.test_repeat_each):
3353         * WebKitTestRunner/TestInvocation.cpp:
3354         (WTR::TestInvocation::setIsPixelTest):
3355
3356 2012-01-30  Hans Wennborg  <hans@chromium.org>
3357
3358         Unreviewed, rolling out r106219.
3359         http://trac.webkit.org/changeset/106219
3360         https://bugs.webkit.org/show_bug.cgi?id=77083
3361
3362         This broke Chromium's test_shell.
3363
3364         * DumpRenderTree/DumpRenderTree.gypi:
3365         * DumpRenderTree/chromium/LayoutTestController.cpp:
3366         (LayoutTestController::addMockSpeechInputResult):
3367         * DumpRenderTree/chromium/LayoutTestController.h:
3368         (WebKit):
3369         (LayoutTestController):
3370         ():
3371         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
3372         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
3373         * DumpRenderTree/chromium/TestShell.cpp:
3374         * DumpRenderTree/chromium/WebViewHost.cpp:
3375         (WebViewHost::speechInputController):
3376         * DumpRenderTree/chromium/WebViewHost.h:
3377         (WebKit):
3378         (WebViewHost::speechInputControllerMock):
3379         (WebViewHost):
3380         ():
3381
3382 2012-01-26  Hans Wennborg  <hans@chromium.org>
3383
3384         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
3385         https://bugs.webkit.org/show_bug.cgi?id=77083
3386
3387         Reviewed by Darin Fisher.
3388
3389         Add MockWebSpeechInputController which provides a mock implementation
3390         of the WebSpeechInputController interface, and use that in
3391         DumpRenderTree.
3392
3393         * DumpRenderTree/DumpRenderTree.gypi:
3394         * DumpRenderTree/chromium/LayoutTestController.cpp:
3395         (LayoutTestController::addMockSpeechInputResult):
3396         * DumpRenderTree/chromium/LayoutTestController.h:
3397         ():
3398         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
3399         (MockWebSpeechInputController::create):
3400         (MockWebSpeechInputController::addMockRecognitionResult):
3401         (MockWebSpeechInputController::clearResults):
3402         (MockWebSpeechInputController::startRecognition):
3403         (MockWebSpeechInputController::cancelRecognition):
3404         (MockWebSpeechInputController::stopRecording):
3405         (MockWebSpeechInputController::MockWebSpeechInputController):
3406         (MockWebSpeechInputController::speechTaskFired):
3407         (MockWebSpeechInputController::SpeechTask::SpeechTask):
3408         (MockWebSpeechInputController::SpeechTask::stop):
3409         (MockWebSpeechInputController::SpeechTask::runIfValid):
3410         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
3411         (WebKit):
3412         (MockWebSpeechInputController):
3413         (MockWebSpeechInputController::taskList):
3414         (SpeechTask):
3415         * DumpRenderTree/chromium/TestShell.cpp:
3416         * DumpRenderTree/chromium/WebViewHost.cpp:
3417         (WebViewHost::speechInputController):
3418         * DumpRenderTree/chromium/WebViewHost.h:
3419         (WebKit):
3420         (WebViewHost::speechInputControllerMock):
3421         (WebViewHost):
3422         ():
3423
3424 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3425
3426         Unreviewed, rolling out r106109.
3427         http://trac.webkit.org/changeset/106109
3428         https://bugs.webkit.org/show_bug.cgi?id=77302
3429
3430         It made tests crash (Requested by Ossy_weekend on #webkit).
3431
3432         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3433         (WTR::WrapperWindow::WrapperWindow):
3434         (WTR::PlatformWebView::PlatformWebView):
3435
3436 2012-01-28  Nico Weber  <thakis@chromium.org>
3437
3438         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
3439         https://bugs.webkit.org/show_bug.cgi?id=77243
3440
3441         Reviewed by Adam Barth.
3442
3443         * Scripts/update-webkit:
3444         * Scripts/webkitdirs.pm:
3445         (isChromiumNinja):
3446         (determineIsChromiumNinja):
3447         (buildChromiumNinja):
3448         (buildChromium):
3449
3450 2012-01-27  Kentaro Hara  <haraken@chromium.org>
3451
3452         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
3453         https://bugs.webkit.org/show_bug.cgi?id=77241
3454
3455         Reviewed by Ryosuke Niwa.
3456
3457         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
3458         in a method in some namespace or class is treated as a method.
3459         This patch fixes the bug.
3460
3461             class C {
3462                 void func()
3463                 {
3464                     if (1) {    // This should not be treated as a method.
3465                     }
3466                 }
3467             };
3468
3469         * Scripts/prepare-ChangeLog:
3470         (get_function_line_ranges_for_cpp):
3471         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
3472         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
3473         (Class108):
3474         (Class108::func35):
3475
3476 2012-01-27  Enrica Casucci  <enrica@apple.com>
3477
3478         Followup to http://trac.webkit.org/changeset/106171.
3479         Dan Bernstein pointed out correctly that I should
3480         have used copy instead of initWithString.
3481
3482         Reviewed by Dan Bernstein.
3483
3484         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3485         (-[LocalPasteboard initWithName:]):
3486
3487 2012-01-27  Enrica Casucci  <enrica@apple.com>
3488
3489         DRT pasteboard object should return the correct pasteboard name.
3490         https://bugs.webkit.org/show_bug.cgi?id=77260
3491         
3492         Currently the name property always returns nil.
3493         Adding a memeber variable to store the pasteboard name and return its
3494         value from the name method instead of returning nil always.
3495
3496         Reviewed by Dan Bernstein.
3497
3498         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3499         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
3500         (-[LocalPasteboard initWithName:]):
3501         (-[LocalPasteboard name]):
3502
3503 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
3504
3505         [GTK] [WK2] Implement the policy client
3506         https://bugs.webkit.org/show_bug.cgi?id=76343
3507
3508         Reviewed by Gustavo Noronha Silva.
3509
3510         * gtk/generate-gtkdoc:
3511         (get_webkit2_options): Update the list of skipped source files to include all clients.
3512
3513 2012-01-27  Ada Chan  <adachan@apple.com>
3514
3515         Add test for WKBundleFrameGetParentFrame().
3516         https://bugs.webkit.org/show_bug.cgi?id=77161
3517
3518         Reviewed by Anders Carlsson.
3519
3520         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
3521         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
3522         (TestWebKitAPI):
3523         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
3524         (TestWebKitAPI::setInjectedBundleClient):
3525         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
3526         Make sure the check is successful.
3527         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
3528         (TestWebKitAPI):
3529         (ParentFrameTest):
3530         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
3531         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
3532         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
3533         to the test controller.
3534         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
3535
3536 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
3537
3538         [Gtk] DumpRenderTree lacks --no-timeout command line option
3539         https://bugs.webkit.org/show_bug.cgi?id=77196
3540
3541         Reviewed by Martin Robinson.
3542
3543         Add the --no-timeout command line option and reorganize
3544         watchdog code to make running DumpRenderTree without
3545         timeout possible.
3546
3547         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3548         (setWaitToDumpWatchdog):
3549         (shouldSetWaitToDumpWatchdog):
3550         (initializeGlobalsFromCommandLineOptions):
3551         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3552         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3553         (waitToDumpWatchdogFired):
3554         (LayoutTestController::setWaitToDump):
3555
3556 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
3557
3558         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
3559         https://bugs.webkit.org/show_bug.cgi?id=77122
3560
3561         Reviewed by Kenneth Rohde Christiansen.
3562
3563         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3564         (MiniBrowserApplication::MiniBrowserApplication):
3565
3566 2012-01-27  Zeno Albisser  <zeno@webkit.org>
3567
3568         [Qt][Mac] Build fails after adding ICU support (r105997).
3569         https://bugs.webkit.org/show_bug.cgi?id=77118
3570
3571         Define WTF_USE_ICU_UNICODE if we are on mac.
3572
3573         Reviewed by Tor Arne Vestbø.
3574
3575         * qmake/mkspecs/features/features.prf:
3576
3577 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
3578
3579         Update committers.py with new contributors.
3580         https://bugs.webkit.org/show_bug.cgi?id=77207
3581
3582         I added six new contributors into committers.py:
3583
3584         - Adam Kallai
3585         - Balazs Ankes
3586         - Janos Badics
3587         - Nandor Huszka
3588         - Roland Takacs
3589         - Szilard Ledan-Muntean
3590
3591         * Scripts/webkitpy/common/config/committers.py:
3592
3593 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
3594
3595         Add Vsevolod Vlasov to reviewers list.
3596
3597         Reviewed by Pavel Feldman.
3598
3599         * Scripts/webkitpy/common/config/committers.py:
3600
3601 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3602
3603         [Qt] WKTR: Use a software rendering pipiline when running tests.
3604         https://bugs.webkit.org/show_bug.cgi?id=76708
3605
3606         Reviewed by Kenneth Rohde Christiansen.
3607
3608         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3609         (WTR::WrapperWindow::WrapperWindow):
3610         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
3611
3612 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
3613
3614         [wx] Unreviewed. Build fix, add WebCore/testing/js
3615         to the list of source directories we build.
3616
3617         * waf/build/settings.py:
3618
3619 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
3620
3621         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
3622         https://bugs.webkit.org/show_bug.cgi?id=77177
3623
3624         Reviewed by Jon Honeycutt.
3625
3626         * Scripts/commit-log-editor:
3627
3628 2012-01-26  Ojan Vafai  <ojan@chromium.org>
3629
3630         Decrease sleep time when killing server_process on Mac.
3631         https://bugs.webkit.org/show_bug.cgi?id=77169
3632
3633         Reviewed by Eric Seidel.
3634
3635         This shaves another ~70ms off single test runtime.
3636
3637         * Scripts/webkitpy/layout_tests/port/server_process.py:
3638         (ServerProcess.stop):
3639
3640 2012-01-26  Ojan Vafai  <ojan@chromium.org>
3641
3642         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
3643         https://bugs.webkit.org/show_bug.cgi?id=77164
3644
3645         Reviewed by Dirk Pranke.
3646
3647         http://trac.webkit.org/changeset/106035 depends on builder_name being
3648         falsey by default. There's other code that requires it to be iterable
3649         by default. So, make it be the empty string.
3650
3651         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3652         (parse_args):
3653
3654 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
3655
3656         run-perf-test should include relative file paths in test names
3657         https://bugs.webkit.org/show_bug.cgi?id=77144
3658
3659         Reviewed by Adam Birth.
3660
3661         Include all directory names in the test name separated by "/".
3662         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
3663
3664         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3665         (PerfTestsRunner):
3666         (PerfTestsRunner._process_parser_test_result):
3667         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3668         (test_run_test_set_with_json_output):
3669         (test_run_test_set_with_json_source):
3670
3671 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
3672
3673         webkitpy: re-land cleanup of test scaffolding
3674         https://bugs.webkit.org/show_bug.cgi?id=77153
3675
3676         Reviewed by Eric Seidel.
3677
3678         This is an attempt to reland the change in bug 76973 / 
3679         r105935. My earlier attempt to manipulate PYTHONPATH
3680         seems to only work some of the time, for reasons that
3681         elude me. Directly adding Tools/Scripts to sys.path from
3682         inside the test script appears to work (more?) reliably.
3683
3684         Also, it seemed like the files didn't actually get deleted
3685         the last time; I don't know why.
3686
3687         * Scripts/test-webkitpy:
3688         * Scripts/webkitpy/common/system/executive_unittest.py:
3689         (command_line):
3690         (ExecutiveTest):
3691         (ExecutiveTest.test_run_command_args_type):
3692         (ExecutiveTest.test_run_command_with_unicode):
3693         (ExecutiveTest.test_running_pids):
3694         (main):
3695         * Scripts/webkitpy/common/system/fileutils.py: Removed.
3696         * Scripts/webkitpy/test/cat.py: Removed.
3697         * Scripts/webkitpy/test/cat_unittest.py: Removed.
3698         * Scripts/webkitpy/test/echo.py: Removed.
3699         * Scripts/webkitpy/test/echo_unittest.py: Removed.
3700
3701 2012-01-26  Ojan Vafai  <ojan@chromium.org>
3702
3703         run-webkit-tests calls "nm" when it doesn't need to
3704         https://bugs.webkit.org/show_bug.cgi?id=77143
3705
3706         Reviewed by Dirk Pranke.
3707
3708         If we are not running any test that can be skipped by checking
3709         the DRT feature list or looking at the list of symbols, avoid calling
3710         out to DRT or calling "nm".
3711
3712         This saves ~700ms on my Mac Pro. In cases where you still have to call out
3713         to "nm" it's only a couple ms slower.
3714
3715         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3716         (TestExpectations.__init__):
3717         * Scripts/webkitpy/layout_tests/port/base.py:
3718         (Port.skipped_tests):
3719         * Scripts/webkitpy/layout_tests/port/webkit.py:
3720         (WebKitPort._should_check_for_missing_features):
3721         (WebKitPort):
3722         (WebKitPort._should_check_for_missing_symbols):
3723         (WebKitPort._skipped_tests_for_unsupported_features):
3724         (WebKitPort.skipped_layout_tests):
3725         (WebKitPort.skipped_tests):
3726         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3727         (WebKitPortTest.test_skipped_directories_for_symbols):
3728         (test_skipped_directories_for_features):
3729         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
3730         (test_skipped_layout_tests):
3731
3732 2012-01-26  Benjamin Poulain  <bpoulain@apple.com>
3733
3734         Support a suffix on ChangeLog filenames based on a configuration file
3735         https://bugs.webkit.org/show_bug.cgi?id=76956
3736
3737         Reviewed by Kentaro Hara.
3738
3739         Modify the tools used to generate, edit and resolve ChangeLogs to support
3740         the addition of a suffix to the ChangeLog filename.
3741
3742         This patch makes it easier to support alternate ChangeLog files in branches.
3743
3744         * Scripts/VCSUtils.pm:
3745         (changeLogSuffix):
3746         (changeLogFileName):
3747         * Scripts/commit-log-editor:
3748         * Scripts/prepare-ChangeLog:
3749         (getLatestChangeLogs):
3750         (generateNewChangeLogs):
3751         (generateFileList):
3752         * Scripts/resolve-ChangeLogs:
3753         (findChangeLog):
3754
3755 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3756
3757         Unreviewed, rolling out r106038.
3758         http://trac.webkit.org/changeset/106038
3759         https://bugs.webkit.org/show_bug.cgi?id=77142
3760
3761         Caused a bunch of skipped tests to not be skipped. (Requested
3762         by ojan on #webkit).
3763
3764         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3765         (TestExpectationParser):
3766         (TestExpectationParser.parse):
3767         (TestExpectationParser._parse_line):
3768         (TestExpectationParser._collect_matching_tests):
3769         (TestExpectations.__init__):
3770         (TestExpectations._add_skipped_tests):
3771         * Scripts/webkitpy/layout_tests/port/base.py:
3772         (Port.test_dirs):
3773         (Port.normalize_test_name):
3774         (Port.update_baseline):
3775         (Port.layout_tests_dir):
3776         (Port.relative_perf_test_filename):
3777         (Port.abspath_for_test):
3778
3779 2012-01-25  Ojan Vafai  <ojan@chromium.org>
3780
3781         Parsing test_expecations.txt + Skipped lists takes too long
3782         https://bugs.webkit.org/show_bug.cgi?id=77059
3783
3784         Reviewed by Dirk Pranke.
3785
3786         This saves ~100ms on the Apple Mac port.
3787         -memoize a bunch of path methods.
3788         -Avoid doing multiple disk accesses per line.
3789         -Parse the skipped list directly instead of turning it into a test_expecations.txt
3790         formatting string and parsing that.
3791
3792         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3793         (TestExpectationParser):
3794         (TestExpectationParser.parse_skipped_tests):
3795         (TestExpectationParser._parse_line):
3796         (TestExpectationParser._collect_matching_tests):
3797         (TestExpectations.__init__):
3798         (TestExpectations._add_skipped_tests):
3799         * Scripts/webkitpy/layout_tests/port/base.py:
3800         (Port):
3801         (Port.test_isfile):
3802         (Port.normalize_test_name):
3803         (Port.layout_tests_dir):
3804         (Port.abspath_for_test):
3805
3806 2012-01-25  Ojan Vafai  <ojan@chromium.org>
3807
3808         Only store the SVN revision in the summarized results if we're on a builder
3809         https://bugs.webkit.org/show_bug.cgi?id=76976
3810
3811         Reviewed by Dirk Pranke.
3812
3813         This shaves another ~130ms off the single test run-webkit-tests runtime.
3814
3815         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3816         (summarize_results):
3817         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3818         (ResultSummaryTest.get_result):
3819         (ResultSummaryTest):
3820         (ResultSummaryTest.get_result_summary):
3821         (ResultSummaryTest.get_unexpected_results):
3822         (ResultSummaryTest.test_no_svn_revision):
3823         (ResultSummaryTest.test_svn_revision):
3824         * Scripts/webkitpy/layout_tests/port/base.py:
3825         (Port.use_trac_links_in_results_html):
3826
3827 2012-01-26  Luciano Wolf  <luciano.wolf@openbossa.org>
3828
3829         [Qt][WK2] fast/loader tests failed after r94178
3830         https://bugs.webkit.org/show_bug.cgi?id=67388
3831
3832         Reviewed by Simon Hausmann.
3833
3834         Applying the same fix used for Qt-WebKit1 from bug #67254 -
3835         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
3836         https://bugs.webkit.org/show_bug.cgi?id=67254
3837         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
3838         derived from the running location of DumpRenderTree binary.
3839
3840         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3841         (WTR::LayoutTestController::pathToLocalResource):
3842
3843 2012-01-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3844
3845         Implement overridePreference for boolean preferences in WebKitTestRunner
3846         https://bugs.webkit.org/show_bug.cgi?id=77033
3847
3848         Reviewed by Alexey Proskuryakov.
3849
3850         For now overridePreference supports boolean values.
3851
3852         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3853         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3854         (WTR::LayoutTestController::setXSSAuditorEnabled):
3855         (WTR::LayoutTestController::overridePreference):
3856         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3857         * WebKitTestRunner/TestController.cpp:
3858         (WTR::TestController::resetStateToConsistentValues): Reset the overrides
3859         explicitly and properly disable the use of PageCache when resetting the
3860         state. Tests that use PageCache can now enable it via overridePreference.
3861
3862 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
3863
3864         [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
3865         https://bugs.webkit.org/show_bug.cgi?id=77100
3866
3867         Reviewed by Simon Hausmann.
3868
3869         This patch makes the MiniBrowser read multiple URL's from the command
3870         line such that there will be one browser window opened for each URL.
3871
3872         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3873         (MiniBrowserApplication::handleUserOptions):
3874
3875 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
3876
3877         [Qt] The Qt MiniBrowser crashes when given multiple URL's
3878         https://bugs.webkit.org/show_bug.cgi?id=77009
3879
3880         Reviewed by Simon Hausmann.
3881
3882         This patch fixes a crash in BrowserWindow::newWindow() where a
3883         BrowserWindow-object is constructed with a 0 pointer as the
3884         WindowOptions parameter which leads to a crash.
3885
3886         * MiniBrowser/qt/BrowserWindow.cpp:
3887         (BrowserWindow::BrowserWindow):
3888         (BrowserWindow::newWindow):
3889         * MiniBrowser/qt/BrowserWindow.h:
3890
3891 2012-01-26  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3892
3893         [Qt] Use ICU if available
3894         https://bugs.webkit.org/show_bug.cgi?id=76821
3895
3896         Reviewed by Simon Hausmann.
3897
3898         Adding unicode defines for a Qt 5 based build.
3899
3900         * qmake/mkspecs/features/features.prf:
3901
3902 2012-01-26  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
3903
3904         [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
3905         https://bugs.webkit.org/show_bug.cgi?id=42545
3906
3907         Reviewed by Zoltan Herczeg.
3908
3909         Implement the setGeolocationPermission method.
3910
3911         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3912         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3913         (WTR::LayoutTestController::setGeolocationPermission):
3914         (WTR):
3915         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3916         (LayoutTestController):
3917
3918 2012-01-26  Balazs Kelemen  <kbalazs@webkit.org>
3919
3920         [NRWT] Support --ignore-metrics
3921         https://bugs.webkit.org/show_bug.cgi?id=76278
3922
3923         Reviewed by Tony Chang.
3924
3925         Port the feature from ORWT.
3926
3927         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3928         (SingleTestRunner._run_compare_test):
3929         * Scripts/webkitpy/layout_tests/port/driver.py:
3930         (DriverOutput):
3931         (DriverOutput.strip_metrics):
3932         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3933         (DriverOutputTest):
3934         (DriverOutputTest.test_strip_metrics):
3935         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3936         (_set_up_derived_options):
3937         (parse_args):
3938
3939 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3940
3941         Unreviewed, rolling out r105935 and r105954.
3942         http://trac.webkit.org/changeset/105935
3943         http://trac.webkit.org/changeset/105954
3944         https://bugs.webkit.org/show_bug.cgi?id=77080
3945
3946         test-webkitpy is still broken (Requested by abarth on
3947         #webkit).
3948
3949         * Scripts/test-webkitpy:
3950         * Scripts/webkitpy/common/system/executive_unittest.py:
3951         (never_ending_command):
3952         (ExecutiveTest.test_run_command_args_type):
3953         (ExecutiveTest.test_run_command_with_unicode):
3954         (ExecutiveTest.test_running_pids):
3955         * Scripts/webkitpy/common/system/fileutils.py:
3956         (make_stdout_binary):
3957         * Scripts/webkitpy/test/cat.py:
3958         (command_arguments):
3959         (main):
3960         * Scripts/webkitpy/test/cat_unittest.py:
3961         (CatTest):
3962         (CatTest.assert_cat):
3963         (CatTest.test_basic):
3964         (CatTest.test_no_newline):
3965         (CatTest.test_unicode):
3966         (CatTest.test_as_command):
3967         * Scripts/webkitpy/test/echo.py:
3968         (command_arguments):
3969         (main):
3970         * Scripts/webkitpy/test/echo_unittest.py:
3971         (EchoTest):
3972         (EchoTest.test_basic):
3973         (EchoTest.test_no_newline):
3974         (EchoTest.test_unicode):
3975         (EchoTest.test_argument_order):
3976         (EchoTest.test_empty_arguments):
3977         (EchoTest.test_no_arguments):
3978         (EchoTest.test_as_command):
3979
3980 2012-01-26  Gabor Rapcsanyi  <rgabor@webkit.org>
3981
3982         [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
3983         https://bugs.webkit.org/show_bug.cgi?id=76138
3984
3985         Reviewed by Martin Robinson.
3986
3987         * Scripts/webkitdirs.pm:
3988         (isCrossCompilation):
3989         (buildAutotoolsProject):
3990
3991 2012-01-25  Adam Barth  <abarth@webkit.org>
3992
3993         Kentaro is a reviewer now.  Yay!
3994
3995         * Scripts/webkitpy/common/config/committers.py:
3996
3997 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
3998
3999         nrwt: running w/ no arguments fails
4000         https://bugs.webkit.org/show_bug.cgi?id=77064
4001
4002         Unreviewed, build fix.
4003
4004         This change fixes a regression introduced in r105944
4005         where running without --platform <foo> or one of the other
4006         platform switches would cause a null deref :(.
4007
4008         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4009         (main):
4010
4011 2012-01-25  Eric Seidel  <eric@webkit.org>
4012
4013         Automatically CC someone from Apple on any changes to Obj-C public API
4014         https://bugs.webkit.org/show_bug.cgi?id=77053
4015
4016         Reviewed by Timothy Hatcher.
4017
4018         This has long been de-facto practice, seems now that we have
4019         fancy watchlist support, we should just make the tools
4020         do this automatically.
4021
4022         * Scripts/webkitpy/common/config/watchlist:
4023
4024 2012-01-25  Antoine Labour  <piman@chromium.org>
4025
4026         Updating status in committers.py.
4027
4028         Unreviewed.
4029
4030         * Scripts/webkitpy/common/config/committers.py:
4031
4032 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
4033
4034         test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
4035         https://bugs.webkit.org/show_bug.cgi?id=77058
4036
4037         Reviewed by Eric Seidel.
4038
4039         r105935 broke executive_unittest by changing which script we
4040         were running and not ensuring that the PYTHONPATH was set up
4041         properly.
4042
4043         This change also fixes a regression introduced recently where
4044         test-webkitpy wasn't figuring out the path to Tools/Scripts
4045         right, either (so running ./test-webkitpy would fail).
4046
4047         * Scripts/test-webkitpy:
4048         * Scripts/webkitpy/common/system/executive_unittest.py:
4049         (script_dir):
4050         (ExecutiveTest.setUp):
4051         (ExecutiveTest):
4052         (ExecutiveTest.tearDown):
4053
4054 2012-01-25  Adam Barth  <abarth@webkit.org>
4055
4056         Disable tests on the mac-ews while we sort out hte stability issues.
4057
4058         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4059         (MacEWS):
4060
4061 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
4062
4063         investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
4064         https://bugs.webkit.org/show_bug.cgi?id=76475
4065
4066         Reviewed by Eric Seidel.
4067
4068         This patch cleans up the internal usage of port names for the
4069         Apple mac and Apple win ports so that 'mac' and 'win are never
4070         considered "fully specified" port names: they are still legal
4071         input to the PortFactory.get() routine, but only if run on the given
4072         platform (i.e. trying to PortFactory.get('mac') on windows or
4073         linux will return an error, since we don't know which version of
4074         the port is desired.
4075
4076         This also cleans up handling of the webkit2 variants, so that
4077         the full port names consistently follow the
4078         <operating_system>-<version>[-<wk2>] convention.
4079
4080         Lastly this patch adds some assertions and removes some
4081         try/catch logic to catch more programming and usage errors;
4082         previously mac-tiger might've been allowed -- and it would've
4083         translated into using just the baselines in platform/mac -- but
4084         now it should fail.
4085
4086         * Scripts/webkitpy/layout_tests/port/apple.py:
4087         (ApplePort.determine_full_port_name):
4088         (ApplePort.__init__):
4089         (ApplePort):
4090         (ApplePort._port_name_with_version):
4091         * Scripts/webkitpy/layout_tests/port/builders.py:
4092         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4093         (FactoryTest.test_mac):
4094         (FactoryTest.test_win):
4095         * Scripts/webkitpy/layout_tests/port/mac.py:
4096         (MacPort.baseline_search_path):
4097         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4098         (MacTest.test_versions):
4099         * Scripts/webkitpy/layout_tests/port/win.py:
4100         (WinPort.baseline_search_path):
4101         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4102         (WinTest.test_versions):
4103
4104 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
4105
4106         webkitpy: print nicer errors while linting expectations files, remove redundant tests
4107         https://bugs.webkit.org/show_bug.cgi?id=76955
4108
4109         Reviewed by Adam Barth.
4110
4111         This change cleans up the errors that are printed so that the
4112         are more "quickfix" compatible (path:lineno).
4113
4114         Also, there were a bunch of redundant tests between
4115         layout_tests.models.test_expectations_unittest and
4116         style.checkers.test_expectations_unittest. The latter should
4117         just expect the former to do most of the testing.
4118
4119         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4120         (TestExpectationParser._parse_modifiers):
4121         (TestExpectations._report_errors):
4122         (TestExpectations._add_skipped_tests):
4123         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4124         (test_parse_error_nonfatal):
4125         (SemanticTests.test_bad_bugid):
4126         * Scripts/webkitpy/style/checkers/test_expectations.py:
4127         (TestExpectationsChecker.__init__):
4128         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4129         (TestExpectationsTestCase.assert_lines_lint):
4130         (TestExpectationsTestCase.test_valid_expectations):
4131         (TestExpectationsTestCase.test_invalid_expectations):
4132         (TestExpectationsTestCase.test_tab):
4133
4134 2012-01-25  Eric Seidel  <eric@webkit.org>
4135
4136         webkit-patch apply-* should always continue after failures
4137         https://bugs.webkit.org/show_bug.cgi?id=77057
4138
4139         Reviewed by Adam Barth.
4140
4141         As far as I can tell there is only one potential drawback to always
4142         forcing: that if you're somehow in the wrong directory it will create new
4143         directories for new files.  Since webkit-patch always cd's to the root
4144         it seems that's not a drawback.  The drawback of not using --force for
4145         svn-apply, is that it will stop after the first failure, which is rarely
4146         (if ever) the desired behavior.  This just removes the force option
4147         (which was strangely hidden behind --non-interactive).  This should
4148         make for a better user experiance.
4149
4150         * Scripts/webkitpy/common/checkout/checkout.py:
4151         (Checkout.apply_patch):
4152         * Scripts/webkitpy/common/checkout/checkout_mock.py:
4153         (MockCheckout.apply_patch):
4154         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4155         (CheckoutTest.test_chromium_deps):
4156         (CheckoutTest):
4157         (CheckoutTest.test_apply_patch):
4158         * Scripts/webkitpy/tool/commands/download_unittest.py:
4159         (DownloadCommandsTest._default_options):
4160         * Scripts/webkitpy/tool/steps/applypatch.py:
4161         (ApplyPatch.options):
4162         (ApplyPatch.run):
4163         * Scripts/webkitpy/tool/steps/options.py:
4164         (Options):
4165
4166 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
4167
4168         nrwt: should be able to run --platform test interactively
4169         https://bugs.webkit.org/show_bug.cgi?id=76959
4170
4171         Reviewed by Adam Barth.
4172
4173         As part of refactoring the Port interfaces, in r103254 I made
4174         passing a Host object to the Port mandatory; previously TestPort
4175         objects would create their own (mock) hosts. However,
4176         new-run-webkit-tests always passed a real Host, not a MockHost,
4177         and so you couldn't run new-run-webkit-tests --platform test
4178         interactively to debug test failures.
4179
4180         This change fixes that by creating a MockHost instead of a real
4181         host if you say --platform test*.
4182
4183         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4184         (main):
4185
4186 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
4187
4188         run-webkit-tests --lint-test-files should lint all the ports by default
4189         https://bugs.webkit.org/show_bug.cgi?id=76749
4190
4191         Reviewed by Ojan Vafai.
4192
4193         Currently run-webkit-tests --lint-test-files will only lint the
4194         test_expectations for the single port determined by the command
4195         line options. This is not obvious and can produce unintended results
4196         if you want to lint the chromium port (probably the normal case
4197         for using --lint-test-files) but don't specify a port name or
4198         --chromium.
4199
4200         I think we should probably lint *all* of the ports if no port
4201         name is supplied. This change implements that, and also moves
4202         the linting logic out of the Manager class, since this really
4203         has nothing to do with Managers. It has little to do with
4204         run-webkit-tests, but splitting it into a different script would
4205         introduce compatibility issues. It might make sense to do that
4206         anyway, in a separate patch and combining that with cleaning up
4207         the style checker to share more code.
4208
4209         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4210         (Manager._strip_test_dir_prefix):
4211         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4212         (lint):
4213         (run):
4214         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4215         (LintTest.test_all_configurations): added.
4216         (LintTest.test_lint_test_files): added.
4217         (LintTest.test_lint_test_files__errors): added.
4218         (MainTest.test_lint_test_files): removed.
4219         (MainTest.test_lint_test_files__errors): removed.
4220
4221 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
4222
4223         webkitpy: clean up a bunch of test scaffolding
4224         https://bugs.webkit.org/show_bug.cgi?id=76973
4225
4226         Reviewed by Eric Seidel.
4227
4228         There were several helper modules in the webkitpy.test package
4229         that appear to only be used by executive_unittest.py. I am
4230         rolling them all into that file to make that clearer.
4231
4232         * Scripts/webkitpy/common/system/executive_unittest.py:
4233         (ExecutiveTest.test_run_command_args_type):
4234         (ExecutiveTest.test_run_command_with_unicode):
4235         (ExecutiveTest.test_running_pids):
4236         (command_line):
4237         (main):
4238         * Scripts/webkitpy/common/system/fileutils.py: Removed.
4239         * Scripts/webkitpy/test/cat.py: Removed.
4240         * Scripts/webkitpy/test/cat_unittest.py: Removed.
4241         * Scripts/webkitpy/test/echo.py: Removed.
4242         * Scripts/webkitpy/test/echo_unittest.py: Removed.
4243
4244 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
4245
4246         webkitpy: clean up a bunch of test scaffolding
4247         https://bugs.webkit.org/show_bug.cgi?id=76973
4248
4249         Reviewed by Eric Seidel.
4250
4251         There were several helper modules in the webkitpy.test package
4252         that appear to only be used by executive_unittest.py. I am
4253         rolling them all into that file to make that clearer.
4254
4255         * Scripts/webkitpy/common/system/executive_unittest.py:
4256         (ExecutiveTest.test_run_command_args_type):
4257         (ExecutiveTest.test_run_command_with_unicode):
4258         (ExecutiveTest.test_running_pids):
4259         (command_line):
4260         (main):
4261         * Scripts/webkitpy/common/system/fileutils.py: Removed.
4262         * Scripts/webkitpy/test/cat.py: Removed.
4263         * Scripts/webkitpy/test/cat_unittest.py: Removed.
4264         * Scripts/webkitpy/test/echo.py: Removed.
4265         * Scripts/webkitpy/test/echo_unittest.py: Removed.
4266
4267 2012-01-25  Eric Seidel  <eric@webkit.org>
4268
4269         Remove Python 2.5 support from WebKit
4270         https://bugs.webkit.org/show_bug.cgi?id=71593
4271
4272         Reviewed by Adam Barth.
4273
4274         Just removing support from this one core file.
4275         I'll commit the rest of the (large) change once we've
4276         gone 24 hours and seen that no bots have exploded.
4277         We can roll out this one change if we break bots
4278         and then roll in the rest once those bots are fixed.
4279
4280         * Scripts/webkitpy/common/system/executive.py:
4281         (Executive.cpu_count):
4282
4283 2012-01-25  Hajime Morita  <morrita@google.com>
4284
4285         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
4286         https://bugs.webkit.org/show_bug.cgi?id=76863
4287
4288         Reviewed by Dimitri Glazkov.
4289
4290         Added a feature flag.
4291
4292         * Scripts/build-webkit:
4293         * qmake/mkspecs/features/features.prf:
4294
4295 2012-01-25  Martin Robinson  <mrobinson@igalia.com>
4296
4297         [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
4298         https://bugs.webkit.org/show_bug.cgi?id=76344
4299
4300         Reviewed by Sam Weinig.
4301
4302         Add a test verifying that the mouse button during policy decisions for
4303         events not triggered by mouse events is NoButton.
4304
4305         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
4306         (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
4307         (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
4308
4309 2012-01-25  Ryosuke Niwa  <rniwa@webkit.org>
4310
4311         run-perf-tests should timeout sooner
4312         https://bugs.webkit.org/show_bug.cgi?id=77026
4313
4314         Reviewed by Adam Barth.
4315
4316         Bump off the timeout from 10 minutes to 4 minutes.
4317
4318         Also use float instead of str in test result values to compress the size of json files bots upload.
4319
4320         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4321         (PerfTestsRunner._parse_args):
4322         (PerfTestsRunner._process_chromium_style_test_result):
4323         (PerfTestsRunner._process_parser_test_result):
4324         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4325         (test_run_test_set_for_parser_tests):
4326         (test_run_test_set_with_json_output):
4327         (test_run_test_set_with_json_source):
4328
4329 2012-01-25  Enrica Casucci  <enrica@apple.com>
4330
4331         WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
4332         https://bugs.webkit.org/show_bug.cgi?id=76951
4333         <rdar://problem/9325158>
4334
4335         Reviewed by Alexey Proskuryakov.
4336
4337         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
4338         and WebHTMLView.
4339         (TestWebKitAPI::TEST):
4340
4341 2012-01-23  MORITA Hajime  <morrita@google.com>
4342
4343         [Refactoring][Internals] Should have InternalSettings
4344         https://bugs.webkit.org/show_bug.cgi?id=76424
4345
4346         Reviewed by Kent Tamura.
4347
4348         * GNUmakefile.am: Added so new files.
4349
4350 2012-01-25  Takashi Toyoshima  <toyoshim@chromium.org>
4351
4352         webkitpy: new-run-webkit-websocket is broken
4353         https://bugs.webkit.org/show_bug.cgi?id=76999
4354
4355         Reviewed by Dirk Pranke.
4356
4357         r105674 broke new-run-webkit-websocket, since options.chromium
4358         doesn't exist any more. new-run-webkit-httpd was also broken
4359         and already fixed at r105835.
4360         * Scripts/new-run-webkit-websocketserver:
4361         (main):
4362
4363 2012-01-25  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
4364
4365         [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
4366         https://bugs.webkit.org/show_bug.cgi?id=63458
4367
4368         Reviewed by Adam Roben.
4369
4370         Implement the setPopupBlockingEnabled method.
4371
4372         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4373         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4374         (WTR::LayoutTestController::setPopupBlockingEnabled):