[chromium] Remove dead transitional code from WebViewImpl
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-24  James Robinson  <jamesr@chromium.org>
2
3         [chromium] Remove dead transitional code from WebViewImpl
4         https://bugs.webkit.org/show_bug.cgi?id=107889
5
6         Reviewed by Adrienne Walker.
7
8         * DumpRenderTree/chromium/WebViewHost.cpp:
9         (WebViewHost::initializeLayerTreeView):
10         (WebViewHost::setWebWidget):
11
12 2013-01-24  Joshua Bell  <jsbell@chromium.org>
13
14         Add watchlist for IndexedDB development, and add myself and others.
15
16         Unreviewed.
17
18         * Scripts/webkitpy/common/config/watchlist:
19
20 2013-01-24  Martin Robinson  <mrobinson@igalia.com>
21
22         Abstract the logic for appending a UChar32 onto StringBuilder
23         https://bugs.webkit.org/show_bug.cgi?id=107505
24
25         Reviewed by Darin Adler.
26
27         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
28         (TestWebKitAPI::TEST): Added a simple test for appending UChar32.
29
30 2013-01-24  Erik Arvidsson  <arv@chromium.org>
31
32         Unreviewed, rolling out r140703.
33         http://trac.webkit.org/changeset/140703
34         https://bugs.webkit.org/show_bug.cgi?id=107556
35
36         r140561 was not the reason for the Android breakage
37
38         * DumpRenderTree/chromium/TestShell.cpp:
39         (TestShell::~TestShell):
40         (TestShell::closeWindow):
41         * DumpRenderTree/chromium/WebViewHost.cpp:
42         (WebViewHost::WebViewHost):
43         (WebViewHost::~WebViewHost):
44         (WebViewHost::shutdown):
45         * DumpRenderTree/chromium/WebViewHost.h:
46         (WebViewHost):
47
48 2013-01-24  Dean Jackson  <dino@apple.com>
49
50         Allow some plugin snapshot UI content to come from Injected Bundle
51         https://bugs.webkit.org/show_bug.cgi?id=107852
52
53         Reviewed by Anders Carlsson.
54
55         Null implementations of plugInStartLabelTitle, plugInStartLabelSubtitle and
56         plugInExtraStyleSheet.
57
58         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
59         (WTR::InjectedBundlePage::InjectedBundlePage):
60
61 2013-01-24  Erik Arvidsson  <arv@chromium.org>
62
63         Unreviewed, rolling out r140561.
64         http://trac.webkit.org/changeset/140561
65         https://bugs.webkit.org/show_bug.cgi?id=107556
66
67         Suspected to break Android which prevens WebKit roll
68
69         * DumpRenderTree/chromium/TestShell.cpp:
70         (TestShell::~TestShell):
71         (TestShell::closeWindow):
72         * DumpRenderTree/chromium/WebViewHost.cpp:
73         (WebViewHost::WebViewHost):
74         (WebViewHost::~WebViewHost):
75         * DumpRenderTree/chromium/WebViewHost.h:
76         (WebViewHost):
77
78 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
79
80         Adding "has-landed" command to webkit-patch which compares a
81         committed patch to the changes which exist locally (ignoring the
82         ChangeLog file).
83
84         https://bugs.webkit.org/show_bug.cgi?id=106402
85
86         Reviewed by Eric Seidel.
87
88         * Scripts/webkitpy/common/checkout/diff_parser.py:
89         (git_diff_to_svn_diff):
90         * Scripts/webkitpy/common/net/bugzilla/bug.py:
91         (Bug.commit_revision):
92         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
93         (BugTest.test_is_in_comments):
94         (BugTest):
95         (BugTest.test_commit_revision):
96         * Scripts/webkitpy/tool/commands/upload.py:
97         (HasLanded):
98         * Scripts/webkitpy/tool/steps/__init__.py:
99         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
100         (HasLanded):
101         (HasLanded.convert_to_svn):
102         (HasLanded.strip_change_log):
103         (run):
104
105         * Scripts/webkitpy/common/net/bugzilla/bug.py:
106         (Bug.commit_revision):
107         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
108         (BugTest.test_is_in_comments):
109         (BugTest):
110         (BugTest.test_commit_revision):
111         * Scripts/webkitpy/tool/commands/upload.py:
112         (HasLanded):
113         * Scripts/webkitpy/tool/steps/__init__.py:
114         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
115         (HasLanded):
116         (HasLanded.convert_to_svn):
117         (HasLanded.strip_change_log):
118         (HasLanded.diff_diff):
119         (HasLanded.run):
120         * Scripts/webkitpy/tool/steps/haslanded_unittest.py: Added.
121         (HasLandedTest):
122         (HasLandedTest.test_run):
123         (test_convert_to_svn_and_strip_change_log):
124
125 2013-01-24  Dan Carney  <dcarney@google.com>
126
127         [chromium] move most WebViewHost printf calls to WebTestProxy
128         https://bugs.webkit.org/show_bug.cgi?id=107553
129
130         Reviewed by Jochen Eisinger.
131
132         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
133         (WebKit):
134         (WebTestProxyBase):
135         (WebTestRunner::WebTestProxy::unableToImplementPolicyWithError):
136         (WebTestRunner::WebTestProxy::didAddMessageToConsole):
137         (WebTestRunner::WebTestProxy::runModalAlertDialog):
138         (WebTestRunner::WebTestProxy::runModalConfirmDialog):
139         (WebTestRunner::WebTestProxy::runModalPromptDialog):
140         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
141         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
142         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
143         (WebTestRunner::WebTestProxyBase::reset):
144         (WebTestRunner::WebTestProxyBase::setLogConsoleOutput):
145         (WebTestRunner):
146         (WebTestRunner::WebTestProxyBase::unableToImplementPolicyWithError):
147         (WebTestRunner::WebTestProxyBase::didAddMessageToConsole):
148         (WebTestRunner::WebTestProxyBase::runModalAlertDialog):
149         (WebTestRunner::WebTestProxyBase::runModalConfirmDialog):
150         (WebTestRunner::WebTestProxyBase::runModalPromptDialog):
151         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
152         * DumpRenderTree/chromium/TestShell.cpp:
153         (TestShell::showDevTools):
154         * DumpRenderTree/chromium/WebViewHost.cpp:
155         (WebViewHost::didAddMessageToConsole):
156         (WebViewHost::runModalAlertDialog):
157         (WebViewHost::runModalConfirmDialog):
158         (WebViewHost::runModalPromptDialog):
159         (WebViewHost::runModalBeforeUnloadDialog):
160         (WebViewHost::unableToImplementPolicyWithError):
161         (WebViewHost::reset):
162         * DumpRenderTree/chromium/WebViewHost.h:
163         (WebViewHost):
164
165 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
166
167         [Chromium] Give webkit_support a chance to reset state between layout test runs
168         https://bugs.webkit.org/show_bug.cgi?id=107132
169
170         Reviewed by Adam Barth.
171
172         We currently only have need for this on OS(ANDROID), but now it
173         would be useful to have a hook for resetting state on all
174         platforms. Will soon be using this for IDBFactory initialization.
175
176         * DumpRenderTree/chromium/TestShell.cpp:
177         (TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
178
179 2013-01-23  Alan Cutter  <alancutter@chromium.org>
180
181         QueueStatusServer crashes in production on next-patch
182         https://bugs.webkit.org/show_bug.cgi?id=107775
183
184         Reviewed by Adam Barth.
185
186         Replaced Python 2.5 incompatible call to timedelta.total_seconds().
187
188         * QueueStatusServer/app.yaml:
189         * QueueStatusServer/model/patchlog.py:
190         (PatchLog.calculate_wait_duration):
191         (PatchLog.calculate_process_duration):
192         (PatchLog):
193         (PatchLog._time_delta_to_seconds):
194
195 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
196
197         The previous patch wasn't complete. Finish reverting r139998 for real.
198
199         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
200         (ProfilerAgent.getProfile):
201
202 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
203
204         Revert r139998 for now since the Leaks Viewer pulls in a specific version of Inspector code.
205
206         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
207         (ProfilerAgent.getProfile):
208
209 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
210
211         [Chromium] Remove unused header files in chromium/public/platform/
212         https://bugs.webkit.org/show_bug.cgi?id=107741
213
214         Reviewed by James Robinson.
215
216         These header files have migrated to the new Platform directory.
217         This patch updates the remaining #include references and removes
218         the old files that did nothing but redirect to the new ones.
219
220         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
221         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
222
223 2013-01-23  Martin Robinson  <mrobinson@igalia.com>
224
225         [GTK] Bump webkitgtk-test-fonts dependency to cover fallbacks for Tamil, Bengali, and others
226         https://bugs.webkit.org/show_bug.cgi?id=107727
227
228         Reviewed by Gustavo Noronha Silva.
229
230         * gtk/jhbuild.modules: Update the JHBuild moduleset to point to the new webkitgtk-test-fonts.
231         We are using the git repository now that github has deprecated the downloads feature.
232
233 2013-01-23  Tony Chang  <tony@chromium.org>
234
235         Unreviewed, set svn:eol-style to CRLF on Windows .sln files.
236
237         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
238         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
239         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
240         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
241
242 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
243
244         [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
245         https://bugs.webkit.org/show_bug.cgi?id=107145
246
247         Reviewed by Adam Barth.
248
249         Part of a larger refactoring series; see tracking bug 82948.
250         
251         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
252         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
253         * DumpRenderTree/chromium/DRTDevToolsClient.h:
254         * DumpRenderTree/chromium/DRTTestRunner.cpp:
255         * DumpRenderTree/chromium/DRTTestRunner.h:
256         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
257         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
258         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
259         * DumpRenderTree/chromium/NotificationPresenter.cpp:
260         * DumpRenderTree/chromium/TestNavigationController.h:
261         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
262         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
263         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
264         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
265         (WebTestRunner):
266         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
267         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
268         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
269         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
270         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
271         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
272         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
273         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
274         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
275         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
276         * DumpRenderTree/chromium/TestShell.cpp:
277         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
278         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
279         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
280         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
281         * DumpRenderTree/chromium/WebViewHost.cpp:
282
283 2013-01-23  Jochen Eisinger  <jochen@chromium.org>
284
285         [chromium] Use after free in plugins/geturlnotify-during-document-teardown.html
286         https://bugs.webkit.org/show_bug.cgi?id=107556
287
288         Reviewed by Tony Chang.
289
290         WebViewHost initiates a navigation to about:blank in its destructor.
291         However, since WebTestProxy inherits from WebViewHost, at this point
292         the WebViewClient and WebFrameClient interfaces are already partially
293         destructed resulting in the use after free.
294
295         This does not affect the chromium implementation since it doesn't
296         invoke WebKit API methods in its destructor.
297
298         * DumpRenderTree/chromium/TestShell.cpp:
299         (TestShell::~TestShell):
300         (TestShell::closeWindow):
301         * DumpRenderTree/chromium/WebViewHost.cpp:
302         (WebViewHost::WebViewHost):
303         (WebViewHost::~WebViewHost):
304         (WebViewHost::shutdown):
305         * DumpRenderTree/chromium/WebViewHost.h:
306         (WebViewHost):
307
308 2013-01-23  Andrei Bucur  <abucur@adobe.com>
309
310         [CSS Regions] Create Regions watchlist
311         https://bugs.webkit.org/show_bug.cgi?id=107281
312
313         Reviewed by Adam Barth.
314
315         This patch adds 4 new definitions:
316         - RegionsDevelopment - used to track the development progress for regions
317         - RegionsExpectationsMore and RegionsExpectationsLess - used to track expectations changes for the regions tests
318         - RegionsUsage - used to track changes that make use of regions in all the code base
319
320         For now, the Adobe internal tracker is the only email address listening for these patterns.
321
322         * Scripts/webkitpy/common/config/watchlist:
323
324 2013-01-22  Pavel Feldman  <pfeldman@chromium.org>
325
326         Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
327         https://bugs.webkit.org/show_bug.cgi?id=107523
328
329         Reviewed by Yury Semikhatsky.
330
331         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
332         (DRTDevToolsClient::isUnderTest):
333         (DRTDevToolsClient::call):
334         * DumpRenderTree/chromium/DRTDevToolsClient.h:
335         (DRTDevToolsClient):
336
337 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
338
339         Removing command line shortening as it makes it difficult to see the command during errors.
340         https://bugs.webkit.org/show_bug.cgi?id=107643
341
342         Reviewed by Eric Seidel.
343
344         * Scripts/webkitpy/common/system/executive.py:
345         (ScriptError):
346         (ScriptError.__init__):
347         * Scripts/webkitpy/common/system/executive_unittest.py:
348
349 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
350
351         Adding myself as contributor in committers.py (as requested by eseidel).
352         https://bugs.webkit.org/show_bug.cgi?id=107647
353
354         Reviewed by Eric Seidel.
355
356         * Scripts/webkitpy/common/config/committers.py:
357
358 2013-01-22  Alan Cutter  <alancutter@chromium.org>
359
360         Add monitoring of patches and queues to the QueueStatusServer
361         https://bugs.webkit.org/show_bug.cgi?id=107612
362
363         Reviewed by Adam Barth.
364
365         Created classes for recording events into the datastore and integrated them into the existing handlers.
366         Code for presenting the recorded data will come in a separate patch.
367
368         * QueueStatusServer/app.yaml:
369         * QueueStatusServer/config/__init__.py: Added.
370         * QueueStatusServer/config/logging.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
371         * QueueStatusServer/config/messages.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
372         * QueueStatusServer/handlers/nextpatch.py:
373         (NextPatch.get):
374         (NextPatch._assign_patch):
375         * QueueStatusServer/handlers/releasepatch.py:
376         (ReleasePatch.post):
377         * QueueStatusServer/handlers/updatestatus.py:
378         (UpdateStatus.post):
379         * QueueStatusServer/handlers/updateworkitems.py:
380         (UpdateWorkItems._parse_work_items_string):
381         (UpdateWorkItems):
382         (UpdateWorkItems._update_work_items_from_request):
383         (UpdateWorkItems._queue_from_request):
384         (UpdateWorkItems.post):
385         * QueueStatusServer/loggers/__init__.py: Added.
386         * QueueStatusServer/loggers/recordbotevent.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
387         (RecordBotEvent):
388         (RecordBotEvent.activity):
389         * QueueStatusServer/loggers/recordpatchevent.py: Added.
390         (RecordPatchEvent):
391         (RecordPatchEvent.added):
392         (RecordPatchEvent.retrying):
393         (RecordPatchEvent.started):
394         (RecordPatchEvent.stopped):
395         (RecordPatchEvent.updated):
396         (RecordPatchEvent._get_patches_waiting):
397         * QueueStatusServer/model/patchlog.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
398         (PatchLog):
399         (PatchLog.lookup):
400         (PatchLog.calculate_wait_duration):
401         (PatchLog.calculate_process_duration):
402         * QueueStatusServer/model/queuelog.py: Copied from Tools/QueueStatusServer/handlers/nextpatch.py.
403         (QueueLog):
404         (QueueLog.get_current):
405         (QueueLog.create_key):
406         * QueueStatusServer/model/queuestatus.py:
407         (QueueStatus.is_retry_request):
408
409 2013-01-22  Timothy Loh  <timloh@chromium.com>
410
411         prepare-Changelog should support updating the list of changed files
412         https://bugs.webkit.org/show_bug.cgi?id=74358
413
414         Reviewed by Eric Seidel.
415
416         Needing to re-make ChangeLog entries when the list of files/functions
417         changes is a bit annoying, it'd be nice to have this more automated.
418         This patch makes `webkit-patch update' update the date line and bug
419         description if needed, and if the list of changed files/functions has
420         changed, either updates the list (if there are no annotations), or
421         otherwise appends the new list below.
422
423         * Scripts/webkitpy/tool/steps/preparechangelog.py:
424         (PrepareChangeLog._resolve_existing_entry):
425         (PrepareChangeLog):
426         (PrepareChangeLog._merge_entries):
427         (PrepareChangeLog.run):
428         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
429         (PrepareChangeLogTest.test_resolve_existing_entry):
430         (make_entry):
431         (test_ensure_bug_url):
432
433 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
434
435         Use Python 2.7 unittest syntax in our unittests
436         https://bugs.webkit.org/show_bug.cgi?id=105607
437
438         Reviewed by Eric Seidel.
439
440         * Scripts/webkitpy/**/*_unittest.py:
441
442 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
443
444         Convert disable-msg to disable for new pylint.
445         https://bugs.webkit.org/show_bug.cgi?id=107627
446
447         Reviewed by Eric Seidel.
448
449         * Scripts/webkitpy/common/checkout/scm/svn.py:
450         (SVNRepository.has_authorization_for_realm):
451         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
452         (Builder.force_build):
453         * Scripts/webkitpy/common/system/executive_mock.py:
454         (MockExecutive2.run_command):
455         * Scripts/webkitpy/layout_tests/port/base.py:
456         (Port.reference_files):
457         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
458         (ChromiumPortTestCase.test_default_configuration):
459         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
460         (PortTestCase.test_expectations_ordering):
461         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
462         (HttpServerBase._check_that_all_ports_are_available):
463         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
464         (AbstractLocalServerCommand.execute):
465         * Scripts/webkitpy/tool/commands/download.py:
466         (AbstractPatchProcessingCommand):
467         * Scripts/webkitpy/tool/commands/rebaseline.py:
468         (AbstractRebaseliningCommand):
469         (AbstractParallelRebaselineCommand):
470         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
471         (_BaseTestCase.setUp):
472         (TestAnalyzeBaselines.setUp):
473
474 2013-01-22  Frank Farzan  <frankf@chromium.org>
475
476         Flakiness dashboard: update builders.jsonp
477         https://bugs.webkit.org/show_bug.cgi?id=107610
478
479         Reviewed by Ojan Vafai.
480
481         * TestResultServer/static-dashboards/builders.jsonp:
482
483 2013-01-22  Frank Farzan  <frankf@chromium.org>
484
485         Add Android instrumentation tests from ChromiumLinux waterfall
486         https://bugs.webkit.org/show_bug.cgi?id=107597
487
488         Reviewed by Ojan Vafai.
489
490         * TestResultServer/static-dashboards/builders.js:
491         (loadBuildersList):
492
493 2013-01-21  Kentaro Hara  <haraken@chromium.org>
494
495         Implement UIEvent constructor
496         https://bugs.webkit.org/show_bug.cgi?id=107430
497
498         Reviewed by Adam Barth.
499
500         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
501
502         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
503         which is enabled on Safari and Chromium for now.
504
505         * Scripts/webkitperl/FeatureList.pm:
506
507 2013-01-22  Timothy Loh  <timloh@chromium.com>
508
509         Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
510         https://bugs.webkit.org/show_bug.cgi?id=107478
511
512         Reviewed by Eric Seidel.
513
514         On the road to resolving Bug 74358, we need a few more functions in
515         changelog.py.
516         To make things easier to mock, change @staticmethods to @classmethods.
517
518         * Scripts/webkitpy/common/checkout/changelog.py:
519         (ChangeLogEntry):
520         (ChangeLogEntry._parse_reviewer_text):
521         (ChangeLogEntry._split_contributor_names):
522         (ChangeLogEntry._parse_author_name_and_email):
523         (ChangeLogEntry._parse_author_text):
524         (ChangeLogEntry._parse_touched_functions):
525         (ChangeLogEntry._parse_bug_description):
526         (ChangeLogEntry._parse_entry):
527         (ChangeLogEntry.date_line):
528         (ChangeLogEntry.bug_description):
529         (ChangeLogEntry.touched_functions):
530         (ChangeLogEntry.touched_files_text):
531         (ChangeLogEntry.is_touched_files_text_clean):
532         (ChangeLog):
533         (ChangeLog.parse_latest_entry_from_file):
534         (ChangeLog._separate_revision_and_line):
535         (ChangeLog.parse_entries_from_file):
536         (ChangeLog.set_short_description_and_bug_url):
537         (ChangeLog.delete_entries):
538         (ChangeLog.prepend_text):
539         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
540         (test_parse_log_entries_from_changelog):
541         (test_latest_entry_parse):
542         (test_set_short_description_and_bug_url):
543         (test_delete_entries):
544         (test_prepend_text):
545
546 2013-01-22  Lucas Forschler  <lforschler@apple.com>
547
548         Create a MAC EWS startup shell script.
549
550         Reviewed by Ryosuke Niwa.
551
552         * EWSTools/start-queue-mac.sh: Added.
553
554 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
555
556         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
557         https://bugs.webkit.org/show_bug.cgi?id=107230
558
559         Reviewed by David Kilzer.
560
561         * DumpRenderTree/mac/TestRunnerMac.mm:
562         (TestRunner::resetPageVisibility):
563         Fix a typo in the original implementation. resetPageVisibility should
564         pass initialState YES so an event is not dispatched, which causes
565         issues in multiple tests. This now matches other ports.
566
567 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
568
569         [GTK] Enable CSS Image Orientation feature
570         https://bugs.webkit.org/show_bug.cgi?id=99040
571
572         Reviewed by Martin Robinson.
573
574         Enable the CSS Image Orientation feature in the development
575         builds of the GTK port. The feature is still disabled in the release
576         builds.
577
578         * Scripts/webkitperl/FeatureList.pm:
579
580 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
581
582         [GTK] Enable the <template> element support in development builds
583         https://bugs.webkit.org/show_bug.cgi?id=106575
584
585         Reviewed by Martin Robinson.
586
587         Enable the <template> element support in the development builds of the GTK port.
588
589         * Scripts/webkitperl/FeatureList.pm:
590
591 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
592
593         Prettify the output of the override-feature-defines script
594         https://bugs.webkit.org/show_bug.cgi?id=106542
595
596         Reviewed by Martin Robinson.
597
598         The output now clearly lists the feature defines being overridden
599         along with the default and overriding values for each feature define.
600
601         * gtk/override-feature-defines:
602         (adjust_feature_defines_makefile):
603         (adjust_feature_defines_makefile.override_feature_define):
604
605 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
606
607         Remove uses of deprecated unittest.TestCase aliases
608         https://bugs.webkit.org/show_bug.cgi?id=102252
609
610         Reviewed by Adam Barth.
611
612         Replace the deprecated assertEquals method of the TestCase interface
613         used in some webkitpy unittests with the assertEqual method.
614
615         * Scripts/webkitpy/common/system/profiler_unittest.py:
616         (ProfilerFactoryTest._assert_default_profiler_name):
617         (ProfilerFactoryTest.test_default_profiler_output):
618         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
619         (GtkPortTest.test_expectations_files):
620         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
621         (TestHttpServer.test_win32_start_and_stop):
622
623 2013-01-22  Jer Noble  <jer.noble@apple.com>
624
625         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
626         https://bugs.webkit.org/show_bug.cgi?id=107562
627
628         Rubber-stamped by Alexy Proskuryakov.
629
630         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
631
632         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
633         (WTR::PlatformWebView::PlatformWebView):
634         (WTR::PlatformWebView::viewSupportsOptions):
635
636 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
637
638         One is not allowed to use commit-queue to make oneself a committer.
639
640         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
641
642 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
643
644         Add myself to commiters.py
645         https://bugs.webkit.org/show_bug.cgi?id=107546
646
647         Reviewed by Kentaro Hara.
648
649         * Scripts/webkitpy/common/config/committers.py:
650
651 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
652
653         [GTK] Implement TestRunner::setTextDirection
654         https://bugs.webkit.org/show_bug.cgi?id=107131
655
656         Reviewed by Philippe Normand.
657
658         * DumpRenderTree/gtk/DumpRenderTree.cpp:
659         (resetDefaultsToConsistentValues): Reset direction to default value.
660         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
661         (TestRunner::setTextDirection): Implement method using
662         gtk_widget_set_direction.
663
664 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
665
666         [chromium] move spell checking mocks to TestRunner library
667         https://bugs.webkit.org/show_bug.cgi?id=107455
668
669         Reviewed by Kent Tamura.
670
671         The content module doesn't provide its own WebSpellCheckClient.
672
673         * DumpRenderTree/DumpRenderTree.gypi:
674         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
675         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
676         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
677         (WebKit):
678         (WebTestRunner):
679         (WebTestProxyBase):
680         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
681         (WebTestRunner):
682         (WebTestRunner::makeMenuItemStringsFor):
683         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
684         (MockGrammarCheck::checkGrammarOfString):
685         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
686         (WebKit):
687         (MockGrammarCheck):
688         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
689         (MockSpellCheck::MockSpellCheck):
690         (MockSpellCheck::~MockSpellCheck):
691         (isNotASCIIAlpha):
692         (MockSpellCheck::spellCheckWord):
693         (MockSpellCheck::fillSuggestionList):
694         (MockSpellCheck::initializeIfNeeded):
695         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
696         (MockSpellCheck):
697         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
698         (WebTestRunner::SpellCheckClient::SpellCheckClient):
699         (WebTestRunner):
700         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
701         (WebTestRunner::SpellCheckClient::setDelegate):
702         (WebTestRunner::SpellCheckClient::spellCheck):
703         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
704         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
705         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
706         (WebTestRunner::SpellCheckClient::autoCorrectWord):
707         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
708         (WebTestRunner):
709         (SpellCheckClient):
710         (WebTestRunner::SpellCheckClient::taskList):
711         (WebTestRunner::SpellCheckClient::mockSpellCheck):
712         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
713         (TestDelegate):
714         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
715         (WebTestInterfaces::Internal):
716         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
717         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
718         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
719         (WebTestRunner::WebTestProxyBase::setDelegate):
720         (WebTestRunner::WebTestProxyBase::spellCheckClient):
721         (WebTestRunner):
722         * DumpRenderTree/chromium/WebViewHost.cpp:
723         (WebViewHost::WebViewHost):
724         (WebViewHost::setWebWidget):
725         * DumpRenderTree/chromium/WebViewHost.h:
726         (WebViewHost):
727
728 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
729
730         [EFL] Adds Accessibility support to wk1
731         https://bugs.webkit.org/show_bug.cgi?id=107440
732
733         Reviewed by Gyuyoung Kim.
734
735         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
736
737 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
738
739         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
740         https://bugs.webkit.org/show_bug.cgi?id=107506
741
742         Reviewed by Dan Bernstein.
743
744         * MiniBrowser/mac/WK1BrowserWindowController.m:
745         (-[WK1BrowserWindowController dealloc]):
746
747 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
748
749         Add build flag for Canvas's Path object (disabled by default)
750         https://bugs.webkit.org/show_bug.cgi?id=107473
751
752         Reviewed by Dean Jackson.
753
754         Add CANVAS_PATH build flag to build systems.
755
756         * Scripts/webkitperl/FeatureList.pm:
757
758 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
759
760         [EFL][WK2] Add APIs to set/get view source mode
761         https://bugs.webkit.org/show_bug.cgi?id=106633
762
763         Reviewed by Gyuyoung Kim.
764
765         Added a shotcut 'F8' in Minibrowser to display a source code
766         of the web page in a new window.
767
768        * MiniBrowser/efl/main.c:
769         (on_key_down):
770         (on_window_create):
771         (window_create):
772         (elm_main):
773
774 2013-01-21  Nico Weber  <thakis@chromium.org>
775
776         [chromium] Don't archive generated source files.
777         https://bugs.webkit.org/show_bug.cgi?id=106736
778
779         Reviewed by Eric Seidel.
780
781         They shouldn't be needed to run tests. They don't need a lot of space,
782         but add many lines to the "extracting" stdout. This attempts to reduce
783         that noise a bit.
784
785         * BuildSlaveSupport/built-product-archive:
786         (archiveBuiltProduct):
787
788 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
789
790         Mac DumpRenderTree's installSignalHandlers() is unreachable code
791         https://bugs.webkit.org/show_bug.cgi?id=107383
792
793         Reviewed by Sam Weinig.
794
795         The CrashHandler of DumpRenderTree were originally used for restoring
796         the color profile of the main display even if DRT crashes.
797
798         That feature was later limited to pixel tests only in r29999.
799
800         In r104351, the DRT was changed to use device color space. Making the crash
801         handlers useless, but they were left in the code since the error reporting
802         code was still reachable.
803
804         Later, r124581 refactored the code and dumpPixelsForCurrentTest
805         is being used before being assigned its value.
806         This did cause any regression because the code had become useless with the previous change.
807
808         * DumpRenderTree/mac/DumpRenderTree.mm:
809         Remove crashHandler() and installSignalHandlers() as they have become useless and
810         have been unreachable code for 6 months.
811         (dumpRenderTree):
812         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
813         at those points.
814
815 2013-01-21  Nico Weber  <thakis@chromium.org>
816
817         Make ninja the default build system for build-webkit --chromium on mac
818         https://bugs.webkit.org/show_bug.cgi?id=106737
819
820         Reviewed by Eric Seidel.
821
822         * Scripts/update-webkit-chromium:
823
824 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
825
826         Regression(r140262): Causes a lot of flakiness
827         https://bugs.webkit.org/show_bug.cgi?id=107454
828
829         Reviewed by Alexey Proskuryakov.
830
831         r140262 introduced a lot of flakiness due to fixed layout mode
832         not getting disabled on the view after being enabled for
833         specific test cases. This patch makes sure fixed layout mode
834         properly gets reset in WebKitTestRunner to avoid flakiness.
835
836         * WebKitTestRunner/TestInvocation.cpp:
837         (WTR::updateLayoutType):
838
839 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
840
841         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
842         https://bugs.webkit.org/show_bug.cgi?id=107421
843
844         Unreviewed build fix.
845
846         * Scripts/run-gtk-tests:
847         (TestRunner): skip Resource tests.
848
849 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
850
851         [EFL][WKTR] platformRunUntil() should keep the main loop running
852         https://bugs.webkit.org/show_bug.cgi?id=107442
853
854         Reviewed by Noam Rosenthal.
855
856         EFL's implementation of platformRunUntil() should keep the main loop
857         running and avoid calling sleep() between calls to
858         ecore_main_loop_iterate(). This call to sleep seems to be a source
859         of deadlocks (see Bug 106884).
860
861         * WebKitTestRunner/efl/TestControllerEfl.cpp:
862         (WTR::TestController::platformRunUntil):
863
864 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
865
866         QtTestBrowser should provide way to clear selected elements
867         https://bugs.webkit.org/show_bug.cgi?id=107437
868
869         Reviewed by Simon Hausmann.
870
871         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
872         Invoke the clearSelection prior to highlighting new elements.
873
874         * QtTestBrowser/launcherwindow.cpp:
875         (ElementHighlight):
876         (LauncherWindow::createChrome):
877         (LauncherWindow::selectElements):
878         (LauncherWindow::clearSelection):
879         * QtTestBrowser/launcherwindow.h:
880         (LauncherWindow):
881
882 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
883
884         [chromium] move methods interacting with willSendRequest to TestRunner
885         https://bugs.webkit.org/show_bug.cgi?id=107270
886
887         Reviewed by Kent Tamura.
888
889         * DumpRenderTree/chromium/DRTTestRunner.cpp:
890         (DRTTestRunner::DRTTestRunner):
891         (DRTTestRunner::waitForPolicyDelegate):
892         * DumpRenderTree/chromium/DRTTestRunner.h:
893         (DRTTestRunner):
894         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
895         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
896         (WebTestRunner::WebTestRunner::httpHeadersToClear):
897         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
898         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
899         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
900         (WebTestRunner::TestRunner::TestRunner):
901         (WebTestRunner::TestRunner::reset):
902         (WebTestRunner::TestRunner::httpHeadersToClear):
903         (WebTestRunner):
904         (WebTestRunner::TestRunner::shouldBlockRedirects):
905         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
906         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
907         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
908         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
909         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
910         (TestRunner):
911         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
912         (WebTestRunner::WebTestProxyBase::willSendRequest):
913         * DumpRenderTree/chromium/WebViewHost.cpp:
914         (WebViewHost::willSendRequest):
915         (WebViewHost::reset):
916         * DumpRenderTree/chromium/WebViewHost.h:
917         (WebViewHost):
918
919 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
920
921         [GTK] Stop building WebKit2 on GTK EWSs
922         https://bugs.webkit.org/show_bug.cgi?id=107435
923
924         Reviewed by Philippe Normand.
925
926         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
927         so stop building it on GTK EWSs.
928
929         * Scripts/webkitpy/common/config/ports.py:
930         (GtkPort.build_webkit_command):
931         * Scripts/webkitpy/common/config/ports_unittest.py:
932         (DeprecatedPortTest.test_gtk_port):
933
934 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
935
936         MediaStream API: Update the RTCPeerConnection states to match the latest specification
937         https://bugs.webkit.org/show_bug.cgi?id=107120
938
939         Reviewed by Adam Barth.
940
941         Updating mock to use the new states.
942
943         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
944         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
945         (MockWebRTCPeerConnectionHandler::initialize):
946         (MockWebRTCPeerConnectionHandler::updateICE):
947
948 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
949
950         Extend diff_parser to support the --full-index output.
951         https://bugs.webkit.org/show_bug.cgi?id=107408
952
953         Reviewed by Maciej Stachowiak.
954
955         * Scripts/webkitpy/common/checkout/diff_parser.py:
956         (git_diff_to_svn_diff):
957         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
958         (DiffParserTest):
959         (DiffParserTest.test_git_diff_to_svn_diff):
960         (git_diff_to_svn_diff):
961
962 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
963
964         Dragging over an element with scrollbars should scroll the element when dragging near edges
965         https://bugs.webkit.org/show_bug.cgi?id=39725
966
967         Reviewed by Hajime Morita.
968
969         This patch introduces canceling drag-and-drop by escape key for testing
970         behavior after cancellation drag-and-drop.
971
972         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
973         (WebTestRunner):
974         (WebTestRunner::EventSender::doMouseUp):
975         (WebTestRunner::EventSender::finishDragAndDrop):
976         (WebTestRunner::EventSender::keyDown):
977         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
978         (EventSender):
979         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
980
981 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
982
983         [chromium] move frame generation related methods to TestRunner
984         https://bugs.webkit.org/show_bug.cgi?id=107268
985
986         Reviewed by Adam Barth.
987
988         * DumpRenderTree/chromium/DRTTestRunner.cpp:
989         (DRTTestRunner::DRTTestRunner):
990         (DRTTestRunner::setWillSendRequestReturnsNull):
991         * DumpRenderTree/chromium/DRTTestRunner.h:
992         (DRTTestRunner):
993         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
994         (WebTestRunner::WebTestDelegate::display):
995         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
996         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
997         (WebTestRunner::TestRunner::TestRunner):
998         (WebTestRunner::TestRunner::display):
999         (WebTestRunner):
1000         (WebTestRunner::TestRunner::displayInvalidatedRegion):
1001         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1002         (TestRunner):
1003         * DumpRenderTree/chromium/WebViewHost.cpp:
1004         (WebViewHost::display):
1005         (WebViewHost::displayInvalidatedRegion):
1006         * DumpRenderTree/chromium/WebViewHost.h:
1007
1008 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1009
1010         [chromium] move speech related methods to TestRunner library
1011         https://bugs.webkit.org/show_bug.cgi?id=107266
1012
1013         Reviewed by Adam Barth.
1014
1015         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1016         (DRTTestRunner::DRTTestRunner):
1017         (DRTTestRunner::displayInvalidatedRegion):
1018         * DumpRenderTree/chromium/DRTTestRunner.h:
1019         (DRTTestRunner):
1020         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1021         (WebTestDelegate):
1022         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
1023         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
1024         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
1025         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
1026         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
1027         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1028         (WebTestRunner::TestRunner::TestRunner):
1029         (WebTestRunner):
1030         (WebTestRunner::TestRunner::addMockSpeechInputResult):
1031         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
1032         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
1033         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
1034         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
1035         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1036         (TestRunner):
1037         * DumpRenderTree/chromium/WebViewHost.cpp:
1038         (WebViewHost::addMockSpeechInputResult):
1039         (WebViewHost::setMockSpeechInputDumpRect):
1040         (WebViewHost::addMockSpeechRecognitionResult):
1041         (WebViewHost::setMockSpeechRecognitionError):
1042         (WebViewHost::wasMockSpeechRecognitionAborted):
1043         * DumpRenderTree/chromium/WebViewHost.h:
1044
1045 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1046
1047         [chromium] move notification related methods to TestRunner
1048         https://bugs.webkit.org/show_bug.cgi?id=107269
1049
1050         Reviewed by Adam Barth.
1051
1052         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1053         (DRTTestRunner::DRTTestRunner):
1054         * DumpRenderTree/chromium/DRTTestRunner.h:
1055         (DRTTestRunner):
1056         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1057         (WebTestDelegate):
1058         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
1059         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
1060         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1061         (WebTestRunner::TestRunner::TestRunner):
1062         (WebTestRunner):
1063         (WebTestRunner::TestRunner::grantWebNotificationPermission):
1064         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
1065         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1066         (TestRunner):
1067         * DumpRenderTree/chromium/WebViewHost.cpp:
1068         (WebViewHost::grantWebNotificationPermission):
1069         (WebViewHost::simulateLegacyWebNotificationClick):
1070         * DumpRenderTree/chromium/WebViewHost.h:
1071
1072 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1073
1074         [chromium] move geolocation related methods to TestRunner
1075         https://bugs.webkit.org/show_bug.cgi?id=107267
1076
1077         Reviewed by Adam Barth.
1078
1079         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1080         (DRTTestRunner::DRTTestRunner):
1081         * DumpRenderTree/chromium/DRTTestRunner.h:
1082         (DRTTestRunner):
1083         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1084         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
1085         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
1086         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
1087         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
1088         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1089         (WebTestRunner::TestRunner::TestRunner):
1090         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
1091         (WebTestRunner):
1092         (WebTestRunner::TestRunner::setGeolocationPermission):
1093         (WebTestRunner::TestRunner::setMockGeolocationPosition):
1094         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
1095         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1096         (TestRunner):
1097         * DumpRenderTree/chromium/WebViewHost.cpp:
1098         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
1099         (WebViewHost::setGeolocationPermission):
1100         (WebViewHost::setMockGeolocationPosition):
1101         (WebViewHost::setMockGeolocationPositionUnavailableError):
1102         * DumpRenderTree/chromium/WebViewHost.h:
1103
1104 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1105
1106         Unreviewed build fix for Qt WK2 after r140258.
1107         Use the size_t type instead of unsigned for the variable
1108         which holds the position of the first null character in the
1109         console message.
1110
1111         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1112         (WTR::InjectedBundlePage::willAddMessageToConsole):
1113
1114 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1115
1116         Unreviewed, rolling out r140260.
1117         http://trac.webkit.org/changeset/140260
1118         https://bugs.webkit.org/show_bug.cgi?id=107387
1119
1120         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
1121         nothing else) (Requested by thakis__ on #webkit).
1122
1123         * Scripts/update-webkit-chromium:
1124
1125 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1126
1127         Delegated scrolling: Assertion on attempt to show a CSS sticky element
1128         https://bugs.webkit.org/show_bug.cgi?id=106890
1129
1130         Reviewed by Kenneth Rohde Christiansen.
1131
1132         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
1133
1134         * WebKitTestRunner/TestInvocation.cpp:
1135         (WTR::shouldUseFixedLayout):
1136         (WTR):
1137         (WTR::updateLayoutType):
1138
1139 2013-01-19  Nico Weber  <thakis@chromium.org>
1140
1141         Make ninja the default build system for build-webkit --chromium on mac
1142         https://bugs.webkit.org/show_bug.cgi?id=106737
1143
1144         Reviewed by Eric Seidel.
1145
1146         * Scripts/update-webkit-chromium:
1147
1148 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1149
1150         [WK2] svg/dom/fuzz-path-parser.html is failing
1151         https://bugs.webkit.org/show_bug.cgi?id=107133
1152
1153         Reviewed by Alexey Proskuryakov.
1154
1155         Console messages can contain null characters before the end of string.
1156         Appending such message to the StringBuilder as a WTFString appends the
1157         complete string, including the null character. This later cuts off everything
1158         after the null character when the string is being printed out to the test
1159         output.
1160
1161         To avoid this, truncate the string up to the first null character. This
1162         preserves the newline character appended immediately after this and
1163         stops giving incorrect output.
1164
1165         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1166         (WTR::InjectedBundlePage::willAddMessageToConsole):
1167
1168 2013-01-19  Eric Seidel  <eric@webkit.org>
1169
1170         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
1171         https://bugs.webkit.org/show_bug.cgi?id=107367
1172
1173         Reviewed by Ryosuke Niwa.
1174
1175         Using srcdoc instead of document.write changes the error output
1176         ever so slightly.  Clearly we were already trying to ignore these
1177         messages, just not succeeding.  This change makes this new test "pass" correctly.
1178
1179         * Scripts/webkitpy/performance_tests/perftest.py:
1180         (PerfTest):
1181
1182 2013-01-18  Dan Winship  <danw@gnome.org>
1183
1184         REGRESSION (r139071): run-webkit-httpd complains at launch
1185         https://bugs.webkit.org/show_bug.cgi?id=107310
1186
1187         Reviewed by Alexey Proskuryakov.
1188
1189         * Scripts/webkitperl/httpd.pm:
1190         (getApacheVersion): use preferred perl syntax
1191
1192 2013-01-18  Julie Parent  <jparent@chromium.org>
1193
1194         Add back 'group' as a default cross dashboard parameter, but with null as its value.
1195         https://bugs.webkit.org/show_bug.cgi?id=107336
1196
1197         We need to have 'group' listed as a parameter, else we never parse it,
1198         as we only parse parameters with defaults.
1199         
1200         Reviewed by Ojan Vafai.
1201
1202         * TestResultServer/static-dashboards/dashboard_base.js:
1203
1204 2013-01-18  Emil A Eklund  <eae@chromium.org>
1205
1206         Update LayoutUnit rounding unit test
1207         https://bugs.webkit.org/show_bug.cgi?id=107322
1208
1209         Reviewed by Levi Weintraub.
1210         
1211         Update the LayoutUnitRounding test to use fromFloatRound for
1212         values that cannot accurately be represented as a LayoutUnit
1213         (the default behavior is to floor the value to the nearest
1214         LayoutUnit).
1215
1216         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1217         (TestWebKitAPI::TEST):
1218
1219 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1220
1221         VCSUtils.pm: Stop calling git repo-config.
1222         https://bugs.webkit.org/show_bug.cgi?id=107294
1223
1224         Reviewed by Dirk Pranke.
1225
1226         The `repo-config' git command has been deprecated since early
1227         2008, and recent versions have started warning it is deprecated.
1228
1229         Basically revert r27870 and use the `config' command all the time.
1230
1231         * Scripts/VCSUtils.pm:
1232         (gitConfig):
1233
1234 2013-01-18  Levi Weintraub  <leviw@chromium.org>
1235
1236         LayoutUnit should round half consistently, not away from zero
1237         https://bugs.webkit.org/show_bug.cgi?id=107208
1238
1239         Reviewed by Eric Seidel.
1240
1241         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
1242         cover this change in rounding behavior.
1243
1244 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1245
1246         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
1247         https://bugs.webkit.org/show_bug.cgi?id=107234
1248
1249         Reviewed by Simon Fraser.
1250
1251         * DumpRenderTree/mac/DumpRenderTree.mm:
1252         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
1253         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1254         (WTR::PlatformWebView::PlatformWebView): Ditto.
1255
1256 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1257
1258         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
1259         https://bugs.webkit.org/show_bug.cgi?id=107251
1260
1261         Reviewed by Simon Fraser.
1262
1263         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
1264
1265         * DumpRenderTree/mac/DumpRenderTree.mm:
1266         (dumpRenderTree):
1267         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1268         (WTR::InjectedBundle::platformInitialize):
1269
1270 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1271
1272         [GTK] Enable indexed database for development builds
1273         https://bugs.webkit.org/show_bug.cgi?id=107299
1274
1275         Reviewed by Gustavo Noronha Silva.
1276
1277         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
1278         for GTK+ development builds.
1279
1280 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
1281
1282         AX: Improve table-guessing heuristics
1283         https://bugs.webkit.org/show_bug.cgi?id=107042
1284
1285         Reviewed by Chris Fleizach.
1286
1287         Implement parentElementCallback on Chromium to make testing easier.
1288
1289         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1290         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
1291
1292 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1293
1294         [GTK] Add property for IndexedDB database path to WebKitGTK+
1295         https://bugs.webkit.org/show_bug.cgi?id=106136
1296
1297         Reviewed by Gustavo Noronha Silva.
1298
1299         During testing, set the web database directory to DUMPRENDERTREE_TEMP
1300         before falling back to the old default. This is necessary because
1301         indexed database tests require that each DRT shard is using a different
1302         IDB database location.
1303
1304         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1305         (temporaryDatabaseDirectory): Added this helper for getting the
1306         database directory.
1307         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
1308
1309 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1310
1311         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
1312         https://bugs.webkit.org/show_bug.cgi?id=107264
1313
1314         Reviewed by Laszlo Gombos.
1315
1316         Enable API test InjectedBundleFrameHitTest for hit-testing,
1317         since it is now passing on both Debug and Release builds.
1318
1319         * TestWebKitAPI/CMakeLists.txt:
1320         * TestWebKitAPI/PlatformEfl.cmake:
1321
1322 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
1323
1324         [GTK] Implement TestRunner::addUserScript
1325         https://bugs.webkit.org/show_bug.cgi?id=107275
1326
1327         Reviewed by Philippe Normand.
1328
1329         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1330         (TestRunner::addUserScript): Implement method using
1331         DumpRenderTreeSupportGtk::addUserScript.
1332
1333 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1334
1335         Unreviewed, add my secondary email address to the list.
1336
1337         * Scripts/webkitpy/common/config/committers.py:
1338
1339 2013-01-18  Dan Carney  <dcarney@google.com>
1340
1341         [chromium] move pointerlock functions to TestRunner library
1342         https://bugs.webkit.org/show_bug.cgi?id=107241
1343
1344         Reviewed by Jochen Eisinger.
1345
1346         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1347         (DRTTestRunner::DRTTestRunner):
1348         * DumpRenderTree/chromium/DRTTestRunner.h:
1349         (DRTTestRunner):
1350         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1351         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
1352         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
1353         (WebTestRunner::WebTestDelegate::didLosePointerLock):
1354         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
1355         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
1356         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1357         (WebTestRunner::TestRunner::TestRunner):
1358         (WebTestRunner):
1359         (WebTestRunner::TestRunner::didAcquirePointerLock):
1360         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
1361         (WebTestRunner::TestRunner::didLosePointerLock):
1362         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
1363         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
1364         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1365         (TestRunner):
1366         * DumpRenderTree/chromium/WebViewHost.h:
1367         (WebViewHost):
1368
1369 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
1370
1371         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
1372         https://bugs.webkit.org/show_bug.cgi?id=106774
1373
1374         Reviewed by Martin Robinson.
1375
1376         In order to fix a long standing linespacing/font ascent & descent issue
1377         we found that FreeType commit b0962ac34e660 solves that problem.
1378         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
1379         maintainer recommending several security updates after that said commit.
1380
1381         Also, in order to avoid extra rebaselining, let's activate subpixel
1382         layout at the same time.
1383
1384         * efl/jhbuild.modules: New freetype 2.4.11
1385
1386 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1387
1388         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
1389         https://bugs.webkit.org/show_bug.cgi?id=107107
1390         PR 282192
1391
1392         Reviewed by Rob Buis.
1393
1394         The DRT application will convert relative/absolute file path to
1395         file://<real-file-path> format, so we only check for http/file prefix.
1396
1397         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1398         (BlackBerry::WebKit::isFullUrl):
1399         (WebKit):
1400         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
1401
1402 2013-01-17  Frank Farzan  <frankf@chromium.org>
1403
1404         Flakiness dashboard: Add ChromiumFYI master
1405         https://bugs.webkit.org/show_bug.cgi?id=107180
1406
1407         Reviewed by Ojan Vafai.
1408
1409         This is needed to enable Chrome Android bots
1410         to upload results for instrumentation tests.
1411
1412         * TestResultServer/generate_builders_json.py:
1413         (main):
1414         * TestResultServer/static-dashboards/builders.jsonp:
1415
1416 2013-01-17  Frank Farzan  <frankf@chromium.org>
1417
1418         Add Chrome on Android instrumentation test types to flakiness dashboard
1419         https://bugs.webkit.org/show_bug.cgi?id=106964
1420
1421         Reviewed by Ojan Vafai.
1422
1423         Specifically, add these test types:
1424         
1425          androidwebview_instrumentation_tests
1426          chromiumtestshell_instrumentation_tests
1427          contentshell_instrumentation_tests
1428         
1429         Also, add ChromiumFYI to the list of masters.
1430
1431         * TestResultServer/static-dashboards/builders.js:
1432         (loadBuildersList):
1433         * TestResultServer/static-dashboards/dashboard_base.js:
1434         (currentBuilderGroupCategory):
1435
1436 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
1437
1438         Fixing webkitpy's SCM unit tests.
1439         https://bugs.webkit.org/show_bug.cgi?id=106429
1440
1441         Reviewed by Eric Seidel.
1442
1443         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1444         (SCMDetectorTest.test_detect_scm_system):
1445         * Scripts/webkitpy/common/checkout/scm/git.py:
1446         (Git.in_working_directory):
1447         (Git.read_git_config):
1448         (Git._assert_can_squash):
1449         (Git.remote_branch_ref):
1450         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1451         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
1452         (GitTestWithMock):
1453         (GitTestWithMock.make_scm):
1454         (GitTestWithMock.test_create_patch):
1455         * Scripts/webkitpy/common/system/outputcapture.py:
1456         (OutputCapture.assert_outputs):
1457         (OutputCaptureTestCaseBase):
1458         * Scripts/webkitpy/test/printer.py:
1459         (Printer.configure):
1460
1461 2013-01-17  Julie Parent  <jparent@chromium.org>
1462
1463         Flakiness dashboard assumes there must be ToT tests
1464         https://bugs.webkit.org/show_bug.cgi?id=107155
1465
1466         Remove group as a default parameter, since we can't actually know
1467         the name of a group initially.  Instead, introduces 
1468         currentBuilderGroupName which returns the current builder group
1469         if it has been explicitly set, or picks the first one available
1470         as a default. Allows us to remove some extra code tracking this
1471         stuff as well.
1472         
1473         Reviewed by Ojan Vafai.
1474
1475         * TestResultServer/static-dashboards/dashboard_base.js:
1476         (parseCrossDashboardParameters):
1477         (currentBuilderGroupName):
1478         (currentBuilderGroup):
1479         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1480         (platformAndBuildType):
1481         * TestResultServer/static-dashboards/loader.js:
1482         (.):
1483
1484 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1485
1486         Remove NodeListsNodeData when it's no longer needed
1487         https://bugs.webkit.org/show_bug.cgi?id=107074
1488
1489         Reviewed by Darin Adler.
1490
1491         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
1492
1493         * Scripts/webkitpy/performance_tests/perftest.py:
1494         (PerfTest):
1495
1496 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
1497
1498         Ref test images are upside-down in WebKit2
1499         https://bugs.webkit.org/show_bug.cgi?id=105457
1500
1501         Reviewed by Sam "Speedy" Weinig.
1502         
1503         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
1504         from the window snapshot contained a flipped copy of the image, causing all ref
1505         and pixel images to be upside-down.
1506
1507         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1508         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1509
1510 2013-01-17  Timothy Loh  <timloh@google.com>
1511
1512         Replaced specifiers variable with is_debug in builders.py
1513         https://bugs.webkit.org/show_bug.cgi?id=107057
1514
1515         Reviewed by Dirk Pranke.
1516
1517         Replaced specifiers variable with is_debug in builders.py to simplify
1518         Bug 106259. The other specifiers are not used elsewhere in the code.
1519         Fixed builder_name_for_port_name to return a debug builder if we don't
1520         have a release builder.
1521
1522         * Scripts/webkitpy/layout_tests/port/builders.py:
1523         (all_port_names):
1524         (builder_name_for_port_name):
1525         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1526         (TestRebaselineExpectations.test_rebaseline_expectations):
1527
1528 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
1529
1530         [GTK] Build with LevelDB when IndexedDB is enabled
1531         https://bugs.webkit.org/show_bug.cgi?id=103220
1532
1533         Reviewed by Gustavo Noronha Silva.
1534
1535         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
1536         as it does not conform to WebKit style.
1537
1538 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1539
1540         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
1541         https://bugs.webkit.org/show_bug.cgi?id=107119
1542
1543         Reviewed by Laszlo Gombos.
1544
1545         Do not use ASSERT on ecore_evas_init(), since the expression inside
1546         the macro compiles out of release builds.
1547
1548         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
1549         * TestWebKitAPI/efl/PlatformWebView.cpp:
1550         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
1551
1552 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
1553
1554         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
1555         https://bugs.webkit.org/show_bug.cgi?id=104545
1556
1557         Reviewed by Yury Semikhatsky.
1558
1559         Adopt signature changes.
1560
1561         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1562         (ProfilerAgent.getCPUProfile): Renamed.
1563         (ProfilerAgent.getHeapSnapshot): Added.
1564
1565 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
1566
1567         [GTK][EFL] NWRT should check that Xvfb is installed
1568         https://bugs.webkit.org/show_bug.cgi?id=71767
1569
1570         Reviewed by Dirk Pranke.
1571
1572         EFL and GTK ports now check that Xvfb is installed before running
1573         layout tests. The command line used to check whether Xvfb is present
1574         is a simple `which Xvfb` that should return 0 as the exit code upon
1575         success.
1576
1577         * Scripts/webkitpy/layout_tests/port/efl.py:
1578         (EflPort.show_results_html_file):
1579         (EflPort):
1580         (EflPort.check_sys_deps):
1581         * Scripts/webkitpy/layout_tests/port/gtk.py:
1582         (GtkPort.check_sys_deps):
1583         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1584         (XvfbDriver):
1585         (XvfbDriver.check_xvfb):
1586
1587 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1588
1589         sheriffbot can't tell me who "kov" is
1590         https://bugs.webkit.org/show_bug.cgi?id=106184
1591
1592         Reviewed by Eric Seidel.
1593
1594         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
1595
1596         * Scripts/webkitpy/common/config/committers.py:
1597         (Account.matches_glob):
1598         (CommitterList.contributors_by_search_string):
1599         * Scripts/webkitpy/common/config/committers_unittest.py:
1600         (CommittersTest.test_committer_lookup):
1601         * Scripts/webkitpy/tool/bot/irc_command.py:
1602         (Whois):
1603
1604 2013-01-16  David Kilzer  <ddkilzer@apple.com>
1605
1606         Use xcrun to find path to make for Mac port
1607         <http://webkit.org/b/107091>
1608
1609         Reviewed by Dan Bernstein.
1610
1611         * Scripts/webkitpy/layout_tests/port/mac.py:
1612         (MacPort._build_java_test_support): Call self.make_command().
1613         (MacPort.make_command): Add.  Call xcrun_find().
1614         (MacPort.nm_command): Use self.xcrun_find().
1615         (MacPort.xcrun_find): Add.  Extract from nm_command().
1616
1617 2013-01-16  Sam Weinig  <sam@webkit.org>
1618
1619         Make debug-safari --target-web-process work again
1620         https://bugs.webkit.org/show_bug.cgi?id=107088
1621
1622         Reviewed by Anders Carlsson.
1623
1624         * Scripts/webkitdirs.pm:
1625         (execMacWebKitAppForDebugging):
1626         The shim is now called SecItemShim.
1627
1628 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1629
1630         GCE build scripts don't take working directory into account when calling findzone.sh
1631         https://bugs.webkit.org/show_bug.cgi?id=106962
1632
1633         Reviewed by Adam Barth.
1634
1635         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1636         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1637         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1638
1639 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1640
1641         start-queue.sh does not pass remaining parameters correctly
1642         https://bugs.webkit.org/show_bug.cgi?id=107054
1643
1644         Reviewed by Adam Barth.
1645
1646         start-queue.sh now passes all remaining params to the webkit-patch command.
1647         Previously only one additional queue parameter could be sent.
1648
1649         * EWSTools/start-queue.sh:
1650
1651 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
1652
1653         check-webkit-style script cannot running in Chinese windows.
1654         https://bugs.webkit.org/show_bug.cgi?id=87548
1655
1656         Reviewed by Darin Adler.
1657
1658         * Scripts/webkitpy/common/system/platforminfo.py:
1659         (PlatformInfo._win_version_tuple_from_cmd):
1660
1661 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
1662
1663         Delete an extraneous print statement.
1664         https://bugs.webkit.org/show_bug.cgi?id=106562
1665
1666         Delete the extraneous print statement introduced in r139841.
1667
1668         * Scripts/webkitpy/layout_tests/views/printing.py:
1669         (Printer.print_found):
1670
1671 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
1672
1673         Please reinstate --pixel
1674         https://bugs.webkit.org/show_bug.cgi?id=101995
1675
1676         Reviewed by Dirk Pranke.
1677
1678         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
1679         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
1680         Some developers are still used to these options that were available in the ORWT.
1681
1682         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1683         (parse_args):
1684
1685 2013-01-16  Eric Seidel  <eric@webkit.org>
1686
1687         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
1688         https://bugs.webkit.org/show_bug.cgi?id=99512
1689
1690         Reviewed by Darin Adler.
1691
1692         * Scripts/run-sunspider:
1693
1694 2013-01-16  Eric Seidel  <eric@webkit.org>
1695
1696         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
1697         https://bugs.webkit.org/show_bug.cgi?id=106036
1698
1699         Reviewed by Darin Adler.
1700
1701         * Scripts/webkitpy/webkitpy.pyproj: Removed.
1702         * Scripts/webkitpy/webkitpy.sln: Removed.
1703
1704 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
1705
1706         [Chromium] Remove hardcoded chromium_*.jar in gyp files
1707         https://bugs.webkit.org/show_bug.cgi?id=104049
1708
1709         Reviewed by Eric Seidel.
1710
1711         Targets with dependencies (direct/indirect) on a java target receive
1712         the chromium_*.jar paths in the variable input_jars_paths. Targets
1713         should use that rather than hardcoding where they think the jar will
1714         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
1715         than as --jars to generate_native_test.py.
1716
1717         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1718         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1719
1720 2013-01-16  Dan Carney  <dcarney@google.com>
1721
1722         [chromium] move setMockDeviceOrientation to TestRunner library
1723         https://bugs.webkit.org/show_bug.cgi?id=106895
1724
1725         Reviewed by Jochen Eisinger.
1726
1727         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1728         (DRTTestRunner::DRTTestRunner):
1729         * DumpRenderTree/chromium/DRTTestRunner.h:
1730         (DRTTestRunner):
1731         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1732         (WebKit):
1733         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
1734         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1735         (WebTestRunner::TestRunner::TestRunner):
1736         (WebTestRunner::TestRunner::setMockDeviceOrientation):
1737         (WebTestRunner):
1738         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1739         (TestRunner):
1740         * DumpRenderTree/chromium/WebViewHost.cpp:
1741         (WebViewHost::setDeviceOrientation):
1742         * DumpRenderTree/chromium/WebViewHost.h:
1743         (WebViewHost):
1744
1745 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1746
1747         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1748         https://bugs.webkit.org/show_bug.cgi?id=106904
1749
1750         Reviewed by Adam Barth.
1751
1752         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1753         (DRTTestRunner::DRTTestRunner):
1754         (DRTTestRunner::notifyDone):
1755         (DRTTestRunner::reset):
1756         * DumpRenderTree/chromium/DRTTestRunner.h:
1757         (DRTTestRunner):
1758         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1759         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1760         (WebTestRunner::WebTestDelegate::setFocus):
1761         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1762         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1763         (WebTestRunner::WebTestDelegate::setLocale):
1764         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1765         (WebTestRunner::TestRunner::TestRunner):
1766         (WebTestRunner::TestRunner::reset):
1767         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1768         (WebTestRunner):
1769         (WebTestRunner::TestRunner::setWindowIsKey):
1770         (WebTestRunner::TestRunner::pathToLocalResource):
1771         (WebTestRunner::TestRunner::setBackingScaleFactor):
1772         (WebTestRunner::TestRunner::setPOSIXLocale):
1773         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1774         (WebTestRunner::TestRunner::taskList):
1775         (TestRunner):
1776         * DumpRenderTree/chromium/WebViewHost.cpp:
1777         (WebViewHost::setDeviceScaleFactor):
1778         (WebViewHost::setFocus):
1779         (WebViewHost::setAcceptAllCookies):
1780         (WebViewHost::pathToLocalResource):
1781         (WebViewHost::setLocale):
1782         * DumpRenderTree/chromium/WebViewHost.h:
1783         (WebViewHost):
1784
1785 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
1786
1787         [GTK] build-webkit fails if the jhbuild wrapper is not used
1788         https://bugs.webkit.org/show_bug.cgi?id=106769
1789
1790         Reviewed by Martin Robinson.
1791
1792         Return an empty array instead of "" in
1793         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
1794         will not be recognized as a valid command when the returned array
1795         is directly passed to perl's system() call.
1796
1797         * Scripts/webkitdirs.pm:
1798         (jhbuildWrapperPrefixIfNeeded):
1799
1800 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1801
1802         [chromium] add title text direction attribute to TestRunner
1803         https://bugs.webkit.org/show_bug.cgi?id=106907
1804
1805         Reviewed by Adam Barth.
1806
1807         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1808         (DRTTestRunner::DRTTestRunner):
1809         (DRTTestRunner::reset):
1810         * DumpRenderTree/chromium/DRTTestRunner.h:
1811         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1812         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1813         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1814         (WebTestRunner::TestRunner::TestRunner):
1815         (WebTestRunner::TestRunner::reset):
1816         (WebTestRunner::TestRunner::setTitleTextDirection):
1817         (WebTestRunner):
1818         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1819         (TestRunner):
1820         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1821         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1822         * DumpRenderTree/chromium/WebViewHost.cpp:
1823         (WebViewHost::didReceiveTitle):
1824
1825 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1826
1827         NRWT still confused about test count with --repeat-each and --iterations
1828         https://bugs.webkit.org/show_bug.cgi?id=106562
1829
1830         Reviewed by Dirk Pranke.
1831
1832         Fix the printed unique test count and skipped count. This
1833         seems to have broken in r127688 ("NRWT lies about the number
1834         of tests that it's skipping when used with --repeat-each").
1835
1836         Also add a test for print_found()
1837
1838         * Scripts/webkitpy/layout_tests/views/printing.py:
1839         (Printer.print_found):
1840         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1841         (Testprinter.test_details):
1842         (Testprinter):
1843         (Testprinter.test_found):
1844
1845 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1846
1847         Unreviewed follow-up to r139769.
1848
1849         Note that omitting the WebKit1 code from the build now
1850         works for GTK as well.
1851
1852         * Scripts/build-webkit:
1853
1854 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1855
1856         test-webkitpy: truncate output to the terminal width when necessary
1857         https://bugs.webkit.org/show_bug.cgi?id=106973
1858
1859         Reviewed by Ojan Vafai.
1860
1861         this implements the same logic for test-webkitpy that we have
1862         for run-webkit-tests (and ninja).
1863
1864         No tests written as this is exercised by running test-webkitpy itself.
1865
1866         * Scripts/webkitpy/test/printer.py:
1867         (Printer.configure):
1868         (Printer._test_line):
1869
1870 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1871
1872         remove extraneous output in test-webkitpy
1873         https://bugs.webkit.org/show_bug.cgi?id=106971
1874
1875         Reviewed by Ojan Vafai.
1876
1877         We weren't ignoring or capturing the echoed output from
1878         these two tests, and getting noise in the logs as a result.
1879
1880         * Scripts/webkitpy/common/system/executive_unittest.py:
1881         (ExecutiveTest.test_auto_stringify_args):
1882         (ExecutiveTest.test_popen_args):
1883
1884 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1885
1886         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
1887         https://bugs.webkit.org/show_bug.cgi?id=106974
1888
1889         Reviewed by Ryosuke Niwa.
1890
1891         I forgot to stub out the call to check to ensure that the ports were
1892         available, so this test could fail if something was listening on 8000 or
1893         8443 on the machine.
1894
1895         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1896         (TestHttpServer.test_win32_start_and_stop):
1897
1898 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1899
1900         Unreviewed, rolling out r139792.
1901         http://trac.webkit.org/changeset/139792
1902         https://bugs.webkit.org/show_bug.cgi?id=106970
1903
1904         Broke the windows build.
1905
1906         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1907         (DRTTestRunner::DRTTestRunner):
1908         (DRTTestRunner::notifyDone):
1909         (DRTTestRunner::reset):
1910         (DRTTestRunner::setAlwaysAcceptCookies):
1911         (DRTTestRunner::setWindowIsKey):
1912         (DRTTestRunner::pathToLocalResource):
1913         (DRTTestRunner::setPOSIXLocale):
1914         (InvokeCallbackTask):
1915         (InvokeCallbackTask::InvokeCallbackTask):
1916         (InvokeCallbackTask::runIfValid):
1917         (DRTTestRunner::setBackingScaleFactor):
1918         * DumpRenderTree/chromium/DRTTestRunner.h:
1919         (DRTTestRunner):
1920         (DRTTestRunner::taskList):
1921         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1922         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1923         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1924         (WebTestRunner::TestRunner::TestRunner):
1925         (WebTestRunner::TestRunner::reset):
1926         (WebTestRunner::TestRunner::setDatabaseQuota):
1927         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1928         (TestRunner):
1929         * DumpRenderTree/chromium/WebViewHost.cpp:
1930         (WebViewHost::setPendingExtraData):
1931         (WebViewHost::setDeviceScaleFactor):
1932         * DumpRenderTree/chromium/WebViewHost.h:
1933         (WebViewHost):
1934
1935 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
1936
1937         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
1938
1939         * Scripts/webkitpy/common/config/ports.py:
1940         (MacWK2Port):
1941
1942 2013-01-15  Alan Cutter  <alancutter@chromium.org>
1943
1944         Extend sheriffbot's "help" command to be able to get help on individual commands
1945         https://bugs.webkit.org/show_bug.cgi?id=106629
1946
1947         Reviewed by Eric Seidel.
1948
1949         Added a help command to sheriffbot.
1950         Fixed some style issues and ordered the commands alphabetically.
1951
1952         * Scripts/webkitpy/tool/bot/irc_command.py:
1953         (IRCCommand):
1954         (IRCCommand.execute):
1955         (IRCCommand.usage):
1956         (IRCCommand.help):
1957         (CreateBug):
1958         (CreateBug.execute):
1959         (Help):
1960         (Help.execute):
1961         (Help._post_command_help):
1962         (Hi):
1963         (Hi.execute):
1964         (Restart):
1965         (RollChromiumDEPS):
1966         (RollChromiumDEPS._parse_args):
1967         (RollChromiumDEPS._expand_irc_nickname):
1968         (RollChromiumDEPS.execute):
1969         (Rollout):
1970         (Rollout._extract_revisions):
1971         (Rollout.execute):
1972         (Sheriffs):
1973         (Sheriffs.execute):
1974         (Whois):
1975         (Whois.execute):
1976         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1977         (IRCBotTest.test_help):
1978
1979 2013-01-15  Enrica Casucci  <enrica@apple.com>
1980
1981         Add a new set of WebKit2 APIs for text search and
1982         search results management.
1983         https://bugs.webkit.org/show_bug.cgi?id=106834.
1984         <rdar://problem/12597159>
1985
1986         Added new test for the new WebKit2 API for
1987         text search.
1988         
1989         Reviewed by Simon Fraser.
1990
1991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1992         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
1993
1994 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1995
1996         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1997         https://bugs.webkit.org/show_bug.cgi?id=106904
1998
1999         Reverting 139794. It broke the build. It appears that a header file,
2000         WebTextDirection.h, was left out.
2001
2002         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2003         (DRTTestRunner::DRTTestRunner):
2004         (DRTTestRunner::reset):
2005         * DumpRenderTree/chromium/DRTTestRunner.h:
2006         (DRTTestRunner::setTitleTextDirection):
2007         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2008         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2009         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2010         (WebTestRunner::TestRunner::TestRunner):
2011         (WebTestRunner::TestRunner::reset):
2012         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2013         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2014         (TestRunner):
2015         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2016         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2017         * DumpRenderTree/chromium/WebViewHost.cpp:
2018         (WebViewHost::didReceiveTitle):
2019
2020 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2021
2022         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2023         https://bugs.webkit.org/show_bug.cgi?id=106904
2024
2025         Reviewed by Adam Barth.
2026
2027         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2028         (DRTTestRunner::DRTTestRunner):
2029         (DRTTestRunner::notifyDone):
2030         (DRTTestRunner::reset):
2031         * DumpRenderTree/chromium/DRTTestRunner.h:
2032         (DRTTestRunner):
2033         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2034         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
2035         (WebTestRunner::WebTestDelegate::setFocus):
2036         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
2037         (WebTestRunner::WebTestDelegate::pathToLocalResource):
2038         (WebTestRunner::WebTestDelegate::setLocale):
2039         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2040         (WebTestRunner::TestRunner::TestRunner):
2041         (WebTestRunner::TestRunner::reset):
2042         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
2043         (WebTestRunner):
2044         (WebTestRunner::TestRunner::setWindowIsKey):
2045         (WebTestRunner::TestRunner::pathToLocalResource):
2046         (WebTestRunner::TestRunner::setBackingScaleFactor):
2047         (WebTestRunner::TestRunner::setPOSIXLocale):
2048         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2049         (WebTestRunner::TestRunner::taskList):
2050         (TestRunner):
2051         * DumpRenderTree/chromium/WebViewHost.cpp:
2052         (WebViewHost::setDeviceScaleFactor):
2053         (WebViewHost::setFocus):
2054         (WebViewHost::setAcceptAllCookies):
2055         (WebViewHost::pathToLocalResource):
2056         (WebViewHost::setLocale):
2057         * DumpRenderTree/chromium/WebViewHost.h:
2058         (WebViewHost):
2059
2060 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2061
2062         Tests with WontFix expectation are (indirectly) skipped
2063         https://bugs.webkit.org/show_bug.cgi?id=105860
2064
2065         Reviewed by Dirk Pranke.
2066
2067         Only skip the WontFix expectation if there are no other layout test
2068         expectations (like Failure, ImageOnlyFailure) listed for the test.
2069         This makes it possible to run an expected failure for which there
2070         is no reason or interest to fix. There are some ports that would like
2071         to exercise this behavior as well as specific test cases that should use
2072         such expectations.
2073
2074         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2075         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
2076         WONTFIX test if there are no expectations listed. The warning is adjusted
2077         to reflect the new behavior.
2078         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
2079         and adjust test cases for these changes.
2080         (ExpectationSyntaxTests.test_wontfix):
2081         (SemanticTests.test_skip_and_wontfix):
2082
2083 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2084
2085         [chromium] add title text direction attribute to TestRunner
2086         https://bugs.webkit.org/show_bug.cgi?id=106907
2087
2088         Reviewed by Adam Barth.
2089
2090         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2091         (DRTTestRunner::DRTTestRunner):
2092         (DRTTestRunner::reset):
2093         * DumpRenderTree/chromium/DRTTestRunner.h:
2094         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2095         (WebTestRunner::WebTestRunner::setTitleTextDirection):
2096         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2097         (WebTestRunner::TestRunner::TestRunner):
2098         (WebTestRunner::TestRunner::reset):
2099         (WebTestRunner::TestRunner::setTitleTextDirection):
2100         (WebTestRunner):
2101         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2102         (TestRunner):
2103         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2104         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2105         * DumpRenderTree/chromium/WebViewHost.cpp:
2106         (WebViewHost::didReceiveTitle):
2107
2108 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2109
2110         nrwt: change the default # of locked shards on chromium_win to 1
2111         https://bugs.webkit.org/show_bug.cgi?id=106938
2112
2113         Reviewed by Eric Seidel.
2114
2115         It looks like LigHTTPd might be buggy or unstable if we are
2116         running multiple http tests in parallel; see
2117         http://code.google.com/p/chromium/issues/detail?id=169530 for more
2118         context as well. This change will stop running http tests in parallel
2119         and we can see if this fixes things.
2120
2121         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2122         (ChromiumWinPort.default_max_locked_shards):
2123         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2124         (ChromiumWinTest.test_path_to_image_diff):
2125         (ChromiumWinTest):
2126         (ChromiumWinTest.test_default_max_locked_shards):
2127
2128 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2129
2130         [chromium] move WebDatabase related methods to TestRunner library
2131         https://bugs.webkit.org/show_bug.cgi?id=106905
2132
2133         Reviewed by Adam Barth.
2134
2135         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2136         (DRTTestRunner::DRTTestRunner):
2137         (DRTTestRunner::reset):
2138         * DumpRenderTree/chromium/DRTTestRunner.h:
2139         (DRTTestRunner):
2140         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2141         (WebTestRunner::WebTestDelegate::clearAllDatabases):
2142         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
2143         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2144         (WebTestRunner::TestRunner::TestRunner):
2145         (WebTestRunner::TestRunner::reset):
2146         (WebTestRunner::TestRunner::clearAllDatabases):
2147         (WebTestRunner):
2148         (WebTestRunner::TestRunner::setDatabaseQuota):
2149         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2150         (TestRunner):
2151         * DumpRenderTree/chromium/WebViewHost.cpp:
2152         (WebViewHost::clearAllDatabases):
2153         (WebViewHost::setDatabaseQuota):
2154         * DumpRenderTree/chromium/WebViewHost.h:
2155         (WebViewHost):
2156
2157 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
2158
2159         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
2160         functionality match the name.
2161         https://bugs.webkit.org/show_bug.cgi?id=106870
2162
2163         Reviewed by Adam Barth.
2164
2165         * Scripts/webkitpy/tool/commands/download.py:
2166         (Clean):
2167         (Update):
2168         (Build):
2169         (BuildAndTest):
2170         (CheckStyle):
2171         (BuildAttachment):
2172         (BuildAndTestAttachment):
2173         (AbstractPatchApplyingCommand):
2174         (ApplyWatchList):
2175         (AbstractPatchLandingCommand):
2176         (CreateRollout):
2177         * Scripts/webkitpy/tool/steps/__init__.py:
2178         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2179         (CleanWorkingDirectory.options):
2180         (CleanWorkingDirectory.run):
2181         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2182         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2183         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
2184
2185 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2186
2187         [Autotools] Add support for WebKit2-only builds
2188         https://bugs.webkit.org/show_bug.cgi?id=106889
2189
2190         Reviewed by Gustavo Noronha Silva.
2191
2192         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
2193         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
2194         building the GTK port through build-webkit.
2195         * Scripts/webkitdirs.pm:
2196         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
2197         arguments when not building WebKit1.
2198         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
2199         through the Autotools build system.
2200
2201 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2202
2203         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
2204         https://bugs.webkit.org/show_bug.cgi?id=106197
2205
2206         Reviewed by Martin Robinson.
2207
2208         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
2209         features. Enable them on GTK, meaning they will be enabled in development builds
2210         (i.e. when building with build-webkit).
2211
2212 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2213
2214         [GTK] Enable CSS Image Resolution feature
2215         https://bugs.webkit.org/show_bug.cgi?id=99038
2216
2217         Reviewed by Gustavo Noronha Silva.
2218
2219         Enable the CSS Image Resolution feature for the development
2220         builds of the GTK port.
2221
2222         * Scripts/webkitperl/FeatureList.pm:
2223
2224 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2225
2226         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
2227         https://bugs.webkit.org/show_bug.cgi?id=106579
2228
2229         Reviewed by Gustavo Noronha Silva.
2230
2231         The --enable-unstable-features flag is not required to be passed anymore
2232         to the configure script as it was removed in r138252.
2233
2234         * Scripts/webkitdirs.pm:
2235         (buildAutotoolsProject):
2236
2237 2013-01-15  Tony Chang  <tony@chromium.org>
2238
2239         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
2240
2241         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2242         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
2243         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2244         (TestHttpServer.test_win32_start_and_stop):
2245
2246 2013-01-15  Joshua Bell  <jsbell@chromium.org>
2247
2248         Unreviewed. Adding Michael Pruett as contributor.
2249
2250         * Scripts/webkitpy/common/config/committers.py:
2251
2252 2013-01-15  Victor Carbune  <victor@rosedu.org>
2253
2254         Unreviewed. Update my email addresses.
2255
2256         * Scripts/webkitpy/common/config/committers.py:
2257
2258 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2259
2260         [GTK] Waiting on the gdb process will lead to deadlock
2261         https://bugs.webkit.org/show_bug.cgi?id=106906
2262
2263         Reviewed by Philippe Normand.
2264
2265         Use communicate() rather than wait() on the Popen object that's running the gdb
2266         command. This avoids the deadlock that occurs on the GTK builders.
2267
2268         * Scripts/webkitpy/layout_tests/port/gtk.py:
2269         (GtkPort._get_gdb_output):
2270
2271 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2272
2273         [GTK] Limit the number of frames printed out when backtracing with gdb
2274         https://bugs.webkit.org/show_bug.cgi?id=106901
2275
2276         Reviewed by Philippe Normand.
2277
2278         Printing an unlimited number of frames when dumping the gdb backtracing
2279         output can cause timeouts in the builders. This patch limits the number
2280         of frames that are printed out to 1024.
2281
2282         * Scripts/webkitpy/layout_tests/port/gtk.py:
2283         (GtkPort._get_gdb_output):
2284
2285 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
2286
2287         [Qt] Fix ImageDiff's image format conversion
2288         https://bugs.webkit.org/show_bug.cgi?id=106880
2289
2290         Reviewed by Csaba Osztrogonác.
2291
2292         Besides actually doing the conversion this also silences the suspicious warning:
2293         "ignoring return value of function declared with warn_unused_result attribute".
2294
2295         * ImageDiff/qt/ImageDiff.cpp:
2296         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
2297         copy of the image in the given format and does not alter the image itself.
2298
2299 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2300
2301         [chromium] move remaining methods that just set a boolean flag to TestRunner library
2302         https://bugs.webkit.org/show_bug.cgi?id=106823
2303
2304         Reviewed by Darin Fisher.
2305
2306         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2307         (DRTTestRunner::DRTTestRunner):
2308         (DRTTestRunner::reset):
2309         * DumpRenderTree/chromium/DRTTestRunner.h:
2310         (DRTTestRunner):
2311         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2312         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
2313         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
2314         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
2315         (WebTestRunner::WebTestRunner::testRepaint):
2316         (WebTestRunner::WebTestRunner::sweepHorizontally):
2317         (WebTestRunner::WebTestRunner::isPrinting):
2318         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2319         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2320         (WebTestRunner::TestRunner::TestRunner):
2321         (WebTestRunner::TestRunner::reset):
2322         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
2323         (WebTestRunner):
2324         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
2325         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
2326         (WebTestRunner::TestRunner::testRepaint):
2327         (WebTestRunner::TestRunner::sweepHorizontally):
2328         (WebTestRunner::TestRunner::isPrinting):
2329         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2330         (WebTestRunner::TestRunner::dumpBackForwardList):
2331         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
2332         (WebTestRunner::TestRunner::dumpSelectionRect):
2333         (WebTestRunner::TestRunner::repaintSweepHorizontally):
2334         (WebTestRunner::TestRunner::setPrinting):
2335         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
2336         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2337         (TestRunner):
2338
2339 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2340
2341         nrwt: stub out show_results_html for mock ports
2342         https://bugs.webkit.org/show_bug.cgi?id=106848
2343
2344         Reviewed by Ojan Vafai.
2345
2346         We were accidentally using the underlying ports'
2347         show_results_html_file() implementation, which would, unsurprisingly,
2348         fail in many cases (e.g., running mock-efl on the mac).
2349
2350         No test added since we don't generally add tests for the mock
2351         implementation.
2352
2353         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2354         (MockDRTPort.show_results_html_file):
2355
2356 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2357
2358         Changing clean_working_directory/clean_local_commits and related
2359         functions to have consistent naming.
2360
2361         https://bugs.webkit.org/show_bug.cgi?id=104198
2362
2363         Reviewed by Adam Barth.
2364
2365         * Scripts/webkitpy/common/checkout/scm/git.py:
2366         * Scripts/webkitpy/common/checkout/scm/scm.py:
2367         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2368         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2369         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2370         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2371
2372 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2373
2374         Fix EWS GCE build scripts to detect which zone is available
2375         https://bugs.webkit.org/show_bug.cgi?id=106524
2376
2377         Reviewed by Adam Barth.
2378
2379         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2380         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2381         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2382         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
2383
2384 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2385
2386         Adding an error string to AmbiguousCommitError.
2387         https://bugs.webkit.org/show_bug.cgi?id=106846
2388
2389         Reviewed by Adam Barth.
2390
2391         * Scripts/webkitpy/common/checkout/scm/git.py:
2392         (AmbiguousCommitError.__init__):
2393
2394 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2395
2396         kill whole lighttpd process tree for chromium win
2397         https://bugs.webkit.org/show_bug.cgi?id=106838
2398
2399         Reviewed by Tony Chang.
2400
2401         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
2402         I think a test is causing a httpd server child process to wedge and
2403         killing the parent httpd server process isn't sufficient to ensure
2404         that the children are also killed.
2405
2406         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2407         (Lighttpd._check_and_kill):
2408         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2409         (TestHttpServer.test_start_cmd):
2410         (TestHttpServer):
2411         (TestHttpServer.test_win32_start_and_stop):
2412         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
2413         (TestHttpServer.test_win32_start_and_stop.mock_returns):
2414         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
2415
2416 2013-01-14  Nico Weber  <thakis@chromium.org>
2417
2418         [chromium] Enable `update-webkit --chromium --ninja` on windows
2419         https://bugs.webkit.org/show_bug.cgi?id=106836
2420
2421         Reviewed by Eric Seidel.
2422
2423         After running this, build-webkit --chromium will use ninja to build.
2424         Apparently there are some minor issues with that still, so it's
2425         not quite ready for use yet.
2426
2427         * Scripts/webkitdirs.pm:
2428         (determineIsChromiumNinja):
2429         (buildChromium):
2430
2431 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2432
2433         nrwt: use the same search path for baselines and TestExpectations on apple mac
2434         https://bugs.webkit.org/show_bug.cgi?id=105599
2435
2436         Reviewed by Ryosuke Niwa.
2437
2438         Bug 105583 revealed some confusion due to the fact that the Apple
2439         Mac port used a different list of directories to search for baselines
2440         and TestExpectations files (actually, pretty much every port does).
2441
2442         It seems like a good idea to use the same list for both by default, but
2443         making this happen will affect every port in slightly different ways, so
2444         we'll try this on the Apple Mac port first.
2445
2446         Note that the effective changes for this are that:
2447         1) The apple mac port will look in platform/wk2 for baselines where
2448         it didn't before (it will look after looking in mac-wk2 but before
2449         the non-wk2 dirs)
2450         2) The apple mac-snowleopard port will use the expectations in
2451         mac-lion as well as the expectations in mac-snowleopard, although
2452         I'm not even sure if mac-snowleopard is still supported ...
2453
2454         * Scripts/webkitpy/layout_tests/port/mac.py:
2455         (MacPort.default_baseline_search_path):
2456         (MacPort.expectations_files):
2457         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2458         (test_baseline_search_path):
2459
2460 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2461
2462         AX: Need to implement ColorWellRole
2463         https://bugs.webkit.org/show_bug.cgi?id=106756
2464
2465         Reviewed by Chris Fleizach.
2466
2467         Returns a string representation of the value of a color
2468         when the role is Color Well, to make it easy to write layout
2469         tests for color controls.
2470
2471         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2472
2473 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2474
2475         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
2476         https://bugs.webkit.org/show_bug.cgi?id=106682
2477
2478         Reviewed by Chris Fleizach.
2479
2480         Modify Chromium's DRT implementation of intValue to return a
2481         different value depending on the role.
2482
2483         There are actually platform-specific differences in what should
2484         be returned in the "value" of an object, so Chromium normally keeps
2485         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
2486         but this is a fine simplification to make cross-platform tests easier.
2487
2488         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2489         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
2490
2491 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
2492
2493         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
2494         https://bugs.webkit.org/show_bug.cgi?id=106785
2495
2496         Reviewed by Adam Barth.
2497
2498         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2499         (DRTTestRunner::DRTTestRunner):
2500         (DRTTestRunner::reset):
2501         * DumpRenderTree/chromium/DRTTestRunner.h:
2502         (DRTTestRunner):
2503         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2504         (WebTestProxyBase):
2505         (WebTestRunner::WebTestProxy::setStatusText):
2506         (WebTestRunner::WebTestProxy::didStopLoading):
2507         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2508         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
2509         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
2510         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2511         (WebTestRunner::TestRunner::TestRunner):
2512         (WebTestRunner::TestRunner::reset):
2513         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
2514         (WebTestRunner):
2515         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
2516         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
2517         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
2518         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2519         (TestRunner):
2520         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2521         (WebTestRunner::WebTestProxyBase::setStatusText):
2522         (WebTestRunner):
2523         (WebTestRunner::WebTestProxyBase::didStopLoading):
2524         * DumpRenderTree/chromium/WebViewHost.cpp:
2525         (WebViewHost::didStopLoading):
2526         * DumpRenderTree/chromium/WebViewHost.h:
2527         (WebViewHost):
2528
2529 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2530
2531         Web Inspector: devtools front-end doesn't have focus in TestShell
2532         https://bugs.webkit.org/show_bug.cgi?id=106778
2533
2534         Reviewed by Pavel Feldman.
2535
2536         Focus devTools window after loadURL method.
2537
2538         * DumpRenderTree/chromium/TestShell.cpp:
2539         (TestShell::runFileTest):
2540
2541 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2542
2543         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
2544         https://bugs.webkit.org/show_bug.cgi?id=106573
2545
2546         Reviewed by Philippe Normand.
2547
2548         Similarly to what's been described in bug 106569, we're building
2549         from release tarballs, so there's no reason to regenerate the
2550         autoconf-related stuff with autogen.sh, especially since we might
2551         run into trouble with automake 1.13 and deprecated macros.
2552
2553         * efl/jhbuild.modules:
2554
2555 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2556
2557         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
2558         https://bugs.webkit.org/show_bug.cgi?id=104909
2559
2560         Reviewed by Simon Hausmann.
2561
2562         To be able to build redistribuable binary packages, Qt's configure switches
2563         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
2564         dynamically link to optional system libraries.
2565         QtWebKit is doing its own configure checks for those libraries, thus adding a
2566         runtime dependency that might not be fulfilled if the packager's machine had
2567         those libraries while the user's machine won't.
2568
2569         Since in most cases where WebKit will want to use those system libraries, Qt will
2570         also be using them, remove these configure tests from WebKit.
2571
2572         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
2573         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
2574         * qmake/config.tests/libpng/libpng.cpp: Removed.
2575         * qmake/config.tests/libpng/libpng.pro: Removed.
2576         * qmake/mkspecs/features/features.prf:
2577
2578 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2579
2580         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
2581         https://bugs.webkit.org/show_bug.cgi?id=106574
2582
2583         Reviewed by Laszlo Gombos.
2584
2585         Rely on a more recent stable release, which includes support for
2586         Lua 5.2 in Edje and other assorted minor fixes.
2587
2588         While here, also use the "configure" script to build the libraries
2589         instead of relying on autogen.sh, which is not really needed with
2590         a release tarball and may have problems with automake 1.13.
2591
2592         * efl/jhbuild.modules:
2593
2594 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2595
2596         Web Inspector: fix DRT to deliver simulated events to devtools front-end
2597         https://bugs.webkit.org/show_bug.cgi?id=106650
2598
2599         Reviewed by Pavel Feldman.
2600
2601         Add separated m_devToolsTestInterfaces object to testShell which is
2602         bind to devTools webview.
2603
2604         * DumpRenderTree/chromium/TestShell.cpp:
2605         (TestShell::initialize):
2606         (TestShell::createMainWindow):
2607         (TestShell::~TestShell):
2608         (TestShell::showDevTools):
2609         (TestShell::resetTestController):
2610         (TestShell::bindJSObjectsToWindow):
2611         (TestShell::createNewWindow):
2612         * DumpRenderTree/chromium/TestShell.h:
2613         (TestShell):
2614
2615 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2616
2617         Sheriffbot command aliases need test cases
2618         https://bugs.webkit.org/show_bug.cgi?id=106754
2619
2620         Reviewed by Eric Seidel.
2621
2622         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2623         (SheriffBotTest.test_command_aliases):
2624
2625 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2626
2627         Allow users to misspell the "sheriffs" command in sheriffbot
2628         https://bugs.webkit.org/show_bug.cgi?id=106628
2629
2630         Reviewed by Steve Block.
2631
2632         * Scripts/webkitpy/tool/bot/irc_command.py:
2633
2634 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2635
2636         Make "gardeners" an alias for "sheriffs" in sherrifbot
2637         https://bugs.webkit.org/show_bug.cgi?id=106627
2638
2639         Reviewed by Eric Seidel.
2640
2641         * Scripts/webkitpy/tool/bot/irc_command.py:
2642
2643 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
2644
2645         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
2646         https://bugs.webkit.org/show_bug.cgi?id=105380
2647
2648         Reviewed by Eric Seidel.
2649
2650         Fix a regression introduced in r137692 where we were double-encoding
2651         the arguments to popen(); this was only an issue on windows, where
2652         we would try to encode something to mbcs, then try to encode it
2653         to unicode as if the input as ascii.
2654
2655         * Scripts/webkitpy/common/system/executive.py:
2656         (Executive.run_command):
2657
2658 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2659
2660         State who told sheriffbot to roll the Chromium deps and to what revision
2661         https://bugs.webkit.org/show_bug.cgi?id=106626
2662
2663         Reviewed by Eric Seidel.
2664
2665         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
2666
2667         * Scripts/webkitpy/tool/bot/irc_command.py:
2668         (RollChromiumDEPS._expand_irc_nickname):
2669         (RollChromiumDEPS.execute):
2670         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2671         (IRCCommandTest.test_roll_chromium_deps):
2672         * Scripts/webkitpy/tool/bot/sheriff.py:
2673         (Sheriff.post_chromium_deps_roll):
2674         * Scripts/webkitpy/tool/commands/roll.py:
2675         (RollChromiumDEPS._prepare_state):
2676         (PostChromiumDEPSRoll):
2677         (PostChromiumDEPSRoll._prepare_state):
2678         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2679         (PostRollCommandsTest.test_prepare_state):
2680         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2681         (PrepareChangeLogForDEPSRoll.run):
2682
2683 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2684
2685         Add Alan Cutter as contributor
2686         https://bugs.webkit.org/show_bug.cgi?id=106747
2687
2688         Reviewed by Eric Seidel.
2689
2690         * Scripts/webkitpy/common/config/committers.py:
2691
2692 2013-01-13  Jonathan Liu  <net147@gmail.com>
2693
2694         Fix CONFIG missing link_pkgconfig on Windows
2695         https://bugs.webkit.org/show_bug.cgi?id=106647
2696
2697         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
2698         properly on Windows because they are added to PKGCONFIG but
2699         CONFIG does not contain link_pkgconfig.
2700
2701         This is because link_pkgconfig is added in unix/default_pre.prf
2702         which is only used for UNIX platforms. To fix this, move it to
2703         the general default_pre.prf.
2704
2705         Reviewed by Simon Hausmann.
2706
2707         * qmake/mkspecs/features/default_pre.prf:
2708         * qmake/mkspecs/features/unix/default_pre.prf:
2709
2710 2013-01-12  Nico Weber  <thakis@chromium.org>
2711
2712         nrwt/chromium: Don't prefer chromium over webkit build directories
2713         https://bugs.webkit.org/show_bug.cgi?id=105597
2714
2715         Reviewed by Dirk Pranke.
2716
2717         Rely on the new timestamp logic instead. Requested by dpranke in
2718         https://bugs.webkit.org/show_bug.cgi?id=105498
2719
2720         * Scripts/webkitpy/layout_tests/port/chromium.py:
2721         (ChromiumPort._static_build_path):
2722         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2723         (ChromiumLinuxPortTest.test_build_path):
2724         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2725         (ChromiumMacPortTest.test_build_path):
2726         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2727         (ChromiumWinTest.test_build_path):
2728
2729 2013-01-12  Nico Weber  <thakis@chromium.org>
2730
2731         Use ninja by default on Linux for build-webkit --chromium, bot edition
2732         https://bugs.webkit.org/show_bug.cgi?id=104434
2733
2734         Reviewed by Eric Seidel.
2735
2736         r139557 changed update-webkit to pick ninja by default on linux, but
2737         the bots run update-webkit-chromium directly so they didn't see this.
2738         Move the default for ninja into update-webkit-chromium so that it's
2739         picked up by the bots, and let update-webkit forward non-default
2740         options to there.
2741
2742         This way, the default is in one place only and both developers (who
2743         usually use update-webkit which then shells out to
2744         updat-webkit-chromium) and bots (which use update-webkit-chromium
2745         directly) see the same behavior.
2746
2747         * Scripts/update-webkit:
2748         * Scripts/update-webkit-chromium:
2749
2750 2013-01-12  Nico Weber  <thakis@chromium.org>
2751
2752         Make ninja the default build system on Linux for build-webkit --chromium
2753         https://bugs.webkit.org/show_bug.cgi?id=104434
2754
2755         Reviewed by Eric Seidel.
2756
2757         * Scripts/update-webkit:
2758
2759 2013-01-12  Alan Cutter  <alancutter@chromium.org>
2760
2761         Migrate the remaining bots in EC2 to Google Compute Engine
2762         https://bugs.webkit.org/show_bug.cgi?id=106005
2763
2764         Reviewed by Eric Seidel.
2765
2766         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
2767
2768         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
2769         * EWSTools/boot.sh:
2770         * EWSTools/build-repo.sh:
2771         * EWSTools/start-queue.sh:
2772
2773 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
2774
2775         [chromium] move inspector related methods to TestRunner library
2776         https://bugs.webkit.org/show_bug.cgi?id=106654
2777
2778         Reviewed by Adam Barth.
2779
2780         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2781         (DRTTestRunner::DRTTestRunner):
2782         * DumpRenderTree/chromium/DRTTestRunner.h:
2783         (DRTTestRunner):
2784         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2785         (WebTestRunner::WebTestDelegate::showDevTools):
2786         (WebTestRunner::WebTestDelegate::closeDevTools):
2787         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
2788         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2789         (WebTestRunner::TestRunner::TestRunner):
2790         (WebTestRunner::TestRunner::showWebInspector):
2791         (WebTestRunner):
2792         (WebTestRunner::TestRunner::closeWebInspector):
2793         (WebTestRunner::TestRunner::evaluateInWebInspector):
2794         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2795         (TestRunner):
2796         * DumpRenderTree/chromium/WebViewHost.cpp:
2797         (WebViewHost::showDevTools):
2798         (WebViewHost::closeDevTools):
2799         (WebViewHost::evaluateInWebInspector):
2800         * DumpRenderTree/chromium/WebViewHost.h:
2801         (WebViewHost):
2802
2803 2013-01-11  Julie Parent  <jparent@chromium.org>
2804
2805         Builder should not be a valid parameter for stats dashboard
2806         https://bugs.webkit.org/show_bug.cgi?id=106698
2807
2808         Reviewed by Dirk Pranke.
2809         
2810         Since builder is a dashboard specific parameter, dashboard_base
2811         should not be handling it in handleValidHashParameterWrapper, rather,
2812         each specific dashboard should in its handleValidHashParameter function.
2813     
2814         Note that the FIXME in dashboard_base about this was actually wrong -
2815         we don't want to move it to g_crossDashboardState, because it isn't
2816         actually cross dashboard state.
2817         
2818         In fact, flakiness and treemap have the code in 
2819         handleValidHashParameter, but it is currently dead code because 
2820         dashboard_base gets to it first.
2821         
2822         Added the proper handling to timeline_explorer, since builder is
2823         valid there.
2824
2825         * TestResultServer/static-dashboards/dashboard_base.js:
2826         * TestResultServer/static-dashboards/timeline_explorer.html:
2827
2828 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2829
2830         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
2831         https://bugs.webkit.org/show_bug.cgi?id=106688
2832
2833         Reviewed by Eric Seidel.
2834
2835         Update the regular expression used to strip the garbage at the beginning.
2836
2837         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2838         (RunWebKitTests.nrwt_log_message_regexp):
2839
2840 2013-01-11  Pratik Solanki  <psolanki@apple.com>
2841
2842         TestRunner leaks when running tests
2843         https://bugs.webkit.org/show_bug.cgi?id=106683
2844
2845         Reviewed by Simon Fraser.
2846
2847         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
2848         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
2849         tests.
2850
2851         * DumpRenderTree/TestRunner.cpp:
2852         (TestRunner::makeWindowObject):
2853
2854 2013-01-11  Julie Parent  <jparent@chromium.org>
2855
2856         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
2857         https://bugs.webkit.org/show_bug.cgi?id=106247
2858
2859         Old code nulled out the loader instance when it completed loading and
2860         then later used the fact that it was null to determine if it had loaded
2861         or not.  This is not only unintuitive, but it also prevents using the
2862         loader object later on.
2863         
2864         Added new method, used it, added unit test for it.
2865         
2866         Reviewed by Dirk Pranke.
2867
2868         * TestResultServer/static-dashboards/dashboard_base.js:
2869         (resourceLoadingComplete):
2870         (handleLocationChange):
2871         * TestResultServer/static-dashboards/loader.js:
2872         (.):
2873         * TestResultServer/static-dashboards/loader_unittests.js:
2874
2875 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2876
2877         Try CRLF to LF change in r139407 again.
2878
2879         * BuildSlaveSupport/delete-stale-build-files:
2880         (main):
2881         (webkitBuildDirectory):
2882         * BuildSlaveSupport/kill-old-processes:
2883         (main):
2884
2885 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2886
2887         [GTK] Disable the unit tests timeout when running from make check
2888         https://bugs.webkit.org/show_bug.cgi?id=106670
2889
2890         Reviewed by Philippe Normand.
2891
2892         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
2893
2894 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2895
2896         Yet another unreviewed fix after r139431.
2897
2898         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
2899         the correct order.
2900
2901 2013-01-11  Dan Carney  <dcarney@google.com>
2902
2903         [chromium] move some whitespace and resize related methods to TestRunner library
2904         https://bugs.webkit.org/show_bug.cgi?id=106655
2905
2906         Reviewed by Jochen Eisinger.
2907
2908         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2909         (DRTTestRunner::DRTTestRunner):
2910         * DumpRenderTree/chromium/DRTTestRunner.h:
2911         (DRTTestRunner):
2912         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2913         (WebKit):
2914         (WebTestRunner::WebTestDelegate::setClientWindowRect):
2915         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
2916         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
2917         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2918         (WebTestRunner::TestRunner::TestRunner):
2919         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
2920         (WebTestRunner):
2921         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
2922         (WebTestRunner::TestRunner::enableAutoResizeMode):
2923         (WebTestRunner::TestRunner::disableAutoResizeMode):
2924         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2925         (TestRunner):
2926         * DumpRenderTree/chromium/WebViewHost.cpp:
2927         (WebViewHost::setClientWindowRect):
2928         * DumpRenderTree/chromium/WebViewHost.h:
2929         (WebViewHost):
2930
2931 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2932
2933         Unreviewed. Update my e-mail addresses.
2934
2935         * Scripts/webkitpy/common/config/committers.py:
2936
2937 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2938
2939         Another unreviewed fix after r139431.
2940
2941         In a way, this is also a generic bug fix, since previously isEfl()
2942         would fail when called from run-efl-tests and we thus did not use
2943         jhbuild to run our tests. This now resulted in us calling
2944         "jhbuild-wrapper run" without specifying a platform.
2945
2946         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
2947         to work.
2948
2949 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2950
2951         [Qt][WK1] Web Audio support
2952         https://bugs.webkit.org/show_bug.cgi?id=106651
2953
2954         Reviewed by Jocelyn Turcotte.
2955
2956         Implements support for dumping audio data in DumpRenderTree.
2957
2958         Adds WebAudio to toggleable features in QtTestBrowser.
2959
2960         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
2961         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
2962
2963         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2964         (WebCore::DumpRenderTree::dump):
2965         * DumpRenderTree/qt/TestRunnerQt.cpp:
2966         (TestRunner::reset):
2967         (TestRunner::overridePreference):
2968         (TestRunner::setAudioData):
2969         * DumpRenderTree/qt/TestRunnerQt.h:
2970         (TestRunner::shouldDumpAsAudio):
2971         (TestRunner::audioData):
2972         (TestRunner):
2973         * QtTestBrowser/launcherwindow.cpp:
2974         (LauncherWindow::applyPrefs):
2975         (LauncherWindow::createChrome):
2976         (LauncherWindow::toggleWebAudio):
2977         * QtTestBrowser/launcherwindow.h:
2978         (WindowOptions::WindowOptions):
2979         (WindowOptions):
2980         (LauncherWindow):
2981         * qmake/mkspecs/features/features.prf:
2982         * qmake/mkspecs/features/features.pri:
2983
2984 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2985
2986         Unreviewed jhbuild-related fix after r139431.
2987
2988         * Scripts/webkitpy/layout_tests/port/efl.py:
2989         (EflPort.__init__): Pass a string to set_option_default(), since
2990         shlex.split() will be called on it later.
2991
2992 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
2993
2994         Unreviewed typo fixes after r139431.
2995
2996         * Scripts/run-javascriptcore-tests:
2997
2998 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2999
3000         [jhbuild] Remove the "run-with-jhbuild" scripts.
3001         https://bugs.webkit.org/show_bug.cgi?id=106572
3002
3003         Reviewed by Martin Robinson.
3004
3005         Both ports which use jhbuild were mostly duplicating the
3006         `run-with-jhbuild' script in their own directories for no clear reason.
3007
3008         The script itself was just a thin wrapper around the `jhbuild-wrapper',
3009         so just start using that directly and get rid of a useless middle man.
3010
3011         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
3012         instead.
3013
3014         * Scripts/run-javascriptcore-tests:
3015         * Scripts/run-launcher:
3016         * Scripts/webkitdirs.pm:
3017         (runAutogenForAutotoolsProjectIfNecessary):
3018         (buildAutotoolsProject):
3019         (jhbuildWrapperPrefixIfNeeded):
3020         (generateBuildSystemFromCMakeProject):
3021         (buildCMakeGeneratedProject):
3022         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
3023         (run):
3024         * Scripts/webkitpy/layout_tests/port/efl.py:
3025         (EflPort.__init__):
3026         (EflPort._image_diff_command):
3027         * efl/run-with-jhbuild: Removed.
3028         * gtk/run-with-jhbuild: Removed.
3029
3030 2013-01-11  Alan Cutter  <alancutter@chromium.org>
3031
3032         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
3033         https://bugs.webkit.org/show_bug.cgi?id=106636
3034
3035         Reviewed by Adam Barth.
3036
3037         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
3038
3039         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3040         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3041         * EWSTools/screen-config:
3042         * EWSTools/start-queue.sh:
3043
3044 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3045
3046         kill-old-processes and delete-stale-build-files use CRLF linebreaks
3047         https://bugs.webkit.org/show_bug.cgi?id=106622
3048
3049         Reviewed by Simon Fraser.
3050
3051         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
3052         Also escape clang\+\+ correctly in kill-old-processes.
3053
3054         * BuildSlaveSupport/delete-stale-build-files:
3055         * BuildSlaveSupport/kill-old-processes:
3056
3057 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3058
3059         Build fix after r139357. It was missing a comma.
3060
3061         * QueueStatusServer/model/queues.py:
3062         (Queue):
3063
3064 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3065
3066         Fixing AuthenticationError when running test-webkitpy as a non-committer.
3067         https://bugs.webkit.org/show_bug.cgi?id=106420
3068
3069         Reviewed by Eric Seidel.
3070
3071         * Scripts/webkitpy/common/checkout/scm/git.py:
3072         (Git.push_local_commits_to_server):
3073         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3074         * Scripts/webkitpy/common/checkout/scm/svn.py:
3075         (SVNRepository):
3076         (SVNRepository.has_authorization_for_realm):
3077
3078 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
3079
3080         [EFL][jhbuild] Use tarballs for gstreamer instead of git
3081         https://bugs.webkit.org/show_bug.cgi?id=106552
3082
3083         Reviewed by Laszlo Gombos.
3084
3085         Use tarballs for gstreamer instead of git in EFL's jhbuild
3086         to work around intermittent network issues on our build
3087         bots. Tarballs are fully cached and require no network
3088         operation if their checksum matches.
3089
3090         * efl/jhbuild.modules:
3091
3092 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3093
3094         Add Mac WK2 EWS bots
3095         https://bugs.webkit.org/show_bug.cgi?id=106590
3096
3097         Reviewed by Adam Barth.
3098
3099         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
3100         Also add a deprecated MacWK2Port class.
3101
3102         * QueueStatusServer/model/queues.py:
3103         (Queue):
3104         * Scripts/webkitpy/common/config/ports.py:
3105         (DeprecatedPort.port):
3106         (MacWK2Port):
3107         (MacWK2Port.run_webkit_tests_command):
3108         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3109         (MacEWS):
3110         (MacWK2EWS):
3111         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3112         (_test_ewses):
3113
3114 2013-01-10  Dan Carney  <dcarney@google.com>
3115
3116         [chromium] move webpermissionclient related methods to TestRunner library
3117         https://bugs.webkit.org/show_bug.cgi?id=106548
3118
3119         Reviewed by Jochen Eisinger.
3120
3121         * DumpRenderTree/DumpRenderTree.gypi:
3122         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3123         (DRTTestRunner::DRTTestRunner):
3124         (DRTTestRunner::reset):
3125         * DumpRenderTree/chromium/DRTTestRunner.h:
3126         (DRTTestRunner):
3127         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3128         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
3129         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3130         (WebKit):
3131         (WebTestRunner::WebTestRunner::webPermissions):
3132         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3133         (WebTestRunner::TestRunner::TestRunner):
3134         (WebTestRunner::TestRunner::setDelegate):
3135         (WebTestRunner):
3136         (WebTestRunner::TestRunner::reset):
3137         (WebTestRunner::TestRunner::webPermissions):
3138         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
3139         (WebTestRunner::TestRunner::setImagesAllowed):
3140         (WebTestRunner::TestRunner::setScriptsAllowed):
3141         (WebTestRunner::TestRunner::setStorageAllowed):
3142         (WebTestRunner::TestRunner::setPluginsAllowed):
3143         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
3144         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
3145         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3146         (WebTestRunner):
3147         (TestRunner):
3148         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
3149         (WebTestRunner):
3150         (WebTestRunner::WebPermissions::WebPermissions):
3151         (WebTestRunner::WebPermissions::~WebPermissions):
3152         (WebTestRunner::WebPermissions::allowImage):
3153         (WebTestRunner::WebPermissions::allowScriptFromSource):
3154         (WebTestRunner::WebPermissions::allowStorage):
3155         (WebTestRunner::WebPermissions::allowPlugins):
3156         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
3157         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
3158         (WebTestRunner::WebPermissions::setImagesAllowed):
3159         (WebTestRunner::WebPermissions::setScriptsAllowed):
3160         (WebTestRunner::WebPermissions::setStorageAllowed):
3161         (WebTestRunner::WebPermissions::setPluginsAllowed):
3162         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
3163         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
3164         (WebTestRunner::WebPermissions::setDelegate):
3165         (WebTestRunner::WebPermissions::setDumpCallbacks):
3166         (WebTestRunner::WebPermissions::reset):
3167         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
3168         (WebTestRunner):
3169         (WebPermissions):
3170         * DumpRenderTree/chromium/TestShell.cpp:
3171         (TestShell::initialize):
3172         (TestShell::resetTestController):
3173         (TestShell::createNewWindow):
3174         * DumpRenderTree/chromium/TestShell.h:
3175         (TestShell):
3176         * DumpRenderTree/chromium/WebViewHost.cpp:
3177         (WebViewHost::normalizeLayoutTestURL):
3178         * DumpRenderTree/chromium/WebViewHost.h:
3179         (WebViewHost):
3180
3181 2013-01-10  Alan Cutter  <alancutter@chromium.org>
3182
3183         Split EWS tool cold-boot.sh into modular components
3184         https://bugs.webkit.org/show_bug.cgi?id=106527
3185
3186         Reviewed by Adam Barth.
3187
3188         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
3189         Updated GCE bot build scripts to match.
3190         Unable to test scripts directly as they depend on being in the repository to work!
3191
3192         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3193         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3194         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
3195         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
3196         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
3197
3198 2013-01-10  Julie Parent  <jparent@chromium.org>
3199
3200         Dashboard Cleanup: Do not generate the page if we are about to reload.
3201         https://bugs.webkit.org/show_bug.cgi?id=106584
3202
3203         Reviewed by Dirk Pranke.
3204
3205         Move the logic to determine if we should generate the page into
3206         parseParameters() since that is where we have the knowledge to
3207         determine it, and return that value to handleLocationChange, 
3208         rather than passing the changed parameters back to handleLocationChange
3209         and having it make the decision.
3210         
3211         This is logically equivalent, save one case: when we are about to do
3212         a reload, we know that there is no reason to generate the page.  Old
3213         code was causing an extra page generation in this case.
3214         
3215         * TestResultServer/static-dashboards/dashboard_base.js:
3216         (parseParameters):
3217         (handleLocationChange):
3218
3219 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3220
3221         [jhbuild] Use the "configure" script to build glib
3222         https://bugs.webkit.org/show_bug.cgi?id=106569
3223
3224         Reviewed by Martin Robinson.
3225
3226         So far both EFL and GTK have been using autogen.sh to build glib.
3227         While that does work most of the time, it's not really needed since
3228         we are downloading and building stable releases from tarballs.
3229         Additionally, autogen.sh fails to work with automake 1.13 due to the
3230         usage of some macros that have been removed (this has already been
3231         fixed in glib master).
3232
3233         * efl/jhbuild.modules:
3234         * gtk/jhbuild.modules:
3235
3236 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3237
3238         Changing tests to be consistent and use self.scm rather then recreating the scm object.
3239         (Missed a couple)
3240         https://bugs.webkit.org/show_bug.cgi?id=106536
3241
3242         Reviewed by Eric Seidel.
3243
3244         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3245
3246 2013-01-10  Tony Chang  <tony@chromium.org>
3247
3248         Speed up supplemental dependency computation
3249         https://bugs.webkit.org/show_bug.cgi?id=106503
3250
3251         Reviewed by Adam Barth.
3252
3253         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
3254
3255         * WebKitTestRunner/CMakeLists.txt:
3256
3257 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
3258
3259         Remove the ENABLE_ANIMATION_API feature define occurences
3260         https://bugs.webkit.org/show_bug.cgi?id=106544
3261
3262         Reviewed by Simon Fraser.
3263
3264         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
3265         feature define handling still lingers in various build systems and configurations
3266         but is of no use, so it should be removed.
3267
3268         * Scripts/webkitperl/FeatureList.pm:
3269         * qmake/mkspecs/features/features.pri:
3270
3271 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3272
3273         [GTK] Add support for loading web process extensions
3274         https://bugs.webkit.org/show_bug.cgi?id=105631
3275
3276         Reviewed by Gustavo Noronha Silva.
3277
3278         * MiniBrowser/gtk/GNUmakefile.am:
3279         * MiniBrowser/gtk/main.c:
3280         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
3281         bundle lib from build dir.
3282         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
3283         located in WebProcess/InjectedBundle/API/gtk.
3284         * gtk/generate-gtkdoc:
3285         (get_webkit2_options): Scan also files in
3286         WebProcess/InjectedBundle/API/gtk to generate API docs.
3287         (get_webkit2_options.injected_bundle_src_path): Helper function to
3288         build paths in WebProcess/InjectedBundle/API/gtk.
3289
3290 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3291
3292         [EFL][WK2] Writing immediately to created windows (open) fails
3293         https://bugs.webkit.org/show_bug.cgi?id=105276
3294
3295         Reviewed by Kenneth Rohde Christiansen.
3296
3297         Do not reset 'about:blank' url for the new pages in mini browser.
3298
3299         * MiniBrowser/efl/main.c:
3300         (window_create):
3301
3302 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3303
3304         Changing tests to be consistent and use self.scm rather then recreating the scm object.
3305         https://bugs.webkit.org/show_bug.cgi?id=106536
3306
3307         Reviewed by Eric Seidel.
3308
3309         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3310
3311 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3312
3313         Converting to unittest2 so we can use assertItemsEqual, making tests
3314         not dependent on order of items.
3315         https://bugs.webkit.org/show_bug.cgi?id=106532
3316
3317         Before:
3318         Ran 1733 tests in 38.385s
3319         FAILED (failures=1, errors=22)
3320
3321         After:
3322         Ran 1733 tests in 32.298s
3323         FAILED (failures=0, errors=22)
3324
3325         Reviewed by Eric Seidel.
3326
3327         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3328         * Scripts/webkitpy/thirdparty/__init__.py:
3329         (AutoinstallImportHook._install_unittest2):
3330
3331 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
3332
3333         [EFL] Add gstreamer 1.0.5 to jhbuild
3334         https://bugs.webkit.org/show_bug.cgi?id=106178
3335
3336         Reviewed by Laszlo Gombos.
3337
3338         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
3339
3340         * efl/jhbuild.modules:
3341
3342 2013-01-09  Alan Cutter  <alancutter@chromium.org>
3343
3344         Updated parameters in GCE build scripts so they now work.
3345         https://bugs.webkit.org/show_bug.cgi?id=106523
3346
3347         Reviewed by Adam Barth.
3348
3349         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3350         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3351         * EWSTools/cold-boot.sh:
3352
3353 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
3354
3355         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
3356         https://bugs.webkit.org/show_bug.cgi?id=106520
3357
3358         Reviewed by James Robinson.
3359
3360         Part of a larger refactoring series. See tracking bug 82948.
3361
3362         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3363         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3364
3365 2013-01-09  Julie Parent  <jparent@chromium.org>
3366
3367         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
3368         https://bugs.webkit.org/show_bug.cgi?id=106514
3369
3370         This is old code, as these can no longer get out of sync.
3371         permmaLinkURLHash is generated from currentState, which is set only
3372         from the location.  The commment about how these can get out of sync
3373         refers to a function that no longer exists.
3374         
3375         Reviewed by Dirk Pranke.
3376
3377         * TestResultServer/static-dashboards/dashboard_base.js:
3378         (handleLocationChange):
3379
3380 2013-01-09  Julie Parent  <jparent@chromium.org>
3381
3382         Dashboard Cleanup: Reload the page as soon as we know we need to.
3383         https://bugs.webkit.org/show_bug.cgi?id=106515
3384
3385         No need to continue parsing all of the data once we know that
3386         we need to do a reload.
3387         
3388         Reviewed by Dirk Pranke.
3389
3390         * TestResultServer/static-dashboards/dashboard_base.js:
3391         (parseParameters):
3392
3393 2013-01-09  Eric Seidel  <eric@webkit.org>
3394
3395         run-perf-tests --chromium-android --profile should show symbols for the kernel
3396         https://bugs.webkit.org/show_bug.cgi?id=106498
3397
3398         Reviewed by Adam Barth.
3399
3400         Turns out this was easy, once I finally read the output from "perf report".
3401         It appears there may be a bug in "perf record" on android, as it complains
3402         about not being able to read from /proc/kallsyms even when
3403         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
3404         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
3405         but rather just flip it to 0 long enough to grab the /proc/kallsyms
3406         and then flip it back to whatever the device had.
3407
3408         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
3409         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
3410         to symbol names.  Its world-readable, but will return all 0s if you
3411         don't have permission to see the kernel symbols.  kptr_restrict
3412         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
3413         1 is only a specific group, and 2 is "no one, not even root".
3414         By default kptr_restrict is 2 on Android it seems.
3415         More kptr_restrict docs: http://lwn.net/Articles/420403/
3416
3417         I also took this opportunity to clean up how the perf record command
3418         was built for use/display in AndroidPerf.profile_after_exit and
3419         change to always using long-form names for the arguments (to hopefully help readability).
3420
3421         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3422         (AndroidPerf.__init__):
3423         (profile_after_exit):
3424         (ChromiumAndroidDriver.__init__):
3425         (ChromiumAndroidDriver._update_kallsyms_cache):
3426         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3427
3428 2013-01-09  Julie Parent  <jparent@chromium.org>
3429
3430         Dashboard cleanup: remove dead code.
3431         https://bugs.webkit.org/show_bug.cgi?id=106509
3432
3433         Reviewed by Dirk Pranke.
3434
3435         * TestResultServer/static-dashboards/dashboard_base.js:
3436         (parseParameters):
3437
3438 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
3439
3440         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
3441         https://bugs.webkit.org/show_bug.cgi?id=105638
3442
3443         Reviewed by Martin Robinson.
3444
3445         The test was failing for two reasons:
3446         - AccessibilityRenderObject::correspondingLabelForControlElement() was
3447           not ignoring the ARIA labelled-by property
3448         - AccessibilityController::accessibleElementById() was not implemented
3449
3450         Because getting an element by ID cannot be done in the UIProcess, the
3451         decision was made to expose the element's ID as an accessible attribute
3452         of the object.
3453
3454         In addition, fixing the bug in AccessibilityRenderObject made it possible
3455         to eliminate the Gtk platform-specific expectations for another test.
3456
3457         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3458         (childElementById): Added. Walks the tree looking for the AtkObject
3459         Attribute which exposes the HTML element's ID.
3460         (AccessibilityController::accessibleElementById): Implemented.
3461         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3462         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
3463         when there is no title, as is done with the Mac port.
3464         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3465         (WTR):
3466         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3467         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
3468         Attribute which exposes the HTML element's ID.
3469         (WTR):
3470         (WTR::AccessibilityController::accessibleElementById): Implemented.
3471         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3472         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
3473         even when there is no title, as is done with the Mac port.
3474
3475 2013-01-09  Gregg Tavares  <gman@google.com>
3476
3477         Add Gregg Tavares as a committer
3478         https://bugs.webkit.org/show_bug.cgi?id=106492
3479
3480         Unreviewed.
3481
3482         * Scripts/webkitpy/common/config/committers.py:
3483
3484 2013-01-09  Roger Fong  <roger_fong@apple.com>
3485
3486         Enable seamless iFrames for Windows DRT.
3487         https://bugs.webkit.org/show_bug.cgi?id=106468.
3488
3489         Rubberstamped by Timothy Horton.
3490
3491         * DumpRenderTree/win/DumpRenderTree.cpp:
3492         (resetDefaultsToConsistentValues):
3493
3494 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
3495
3496         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
3497         https://bugs.webkit.org/show_bug.cgi?id=93979
3498
3499         Reviewed by Benjamin Poulain.
3500
3501         Implement eventSender.scheduleAsynchronousKeyDown() in
3502         WebKitTestRunner.
3503
3504         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3505         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3506         (WTR::createKeyDownMessageBody):
3507         (WTR::EventSendingController::keyDown):
3508         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
3509         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3510         (EventSendingController):
3511         * WebKitTestRunner/TestController.cpp:
3512         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
3513         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3514         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3515         * WebKitTestRunner/TestController.h:
3516         (TestController):
3517
3518 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
3519
3520         [chromium] move resource load callback dumping to TestRunner library
3521         https://bugs.webkit.org/show_bug.cgi?id=106449
3522
3523         Reviewed by Adam Barth.
3524
3525         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3526         (DRTTestRunner::DRTTestRunner):
3527         (DRTTestRunner::reset):
3528         * DumpRenderTree/chromium/DRTTestRunner.h:
3529         (DRTTestRunner):
3530         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3531         (WebKit):
3532         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
3533         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3534         (WebKit):
3535         (WebTestProxyBase):
3536         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
3537         (WebTestRunner::WebTestProxy::willRequestResource):
3538         (WebTestRunner::WebTestProxy::willSendRequest):
3539         (WebTestRunner::WebTestProxy::didReceiveResponse):
3540         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
3541         (WebTestRunner::WebTestProxy::didFailResourceLoad):
3542         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3543         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
3544         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
3545         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
3546         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3547         (WebTestRunner::TestRunner::TestRunner):
3548         (WebTestRunner::TestRunner::reset):
3549         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
3550         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
3551         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
3552         (WebTestRunner):
3553         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
3554         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
3555         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
3556         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3557         (TestRunner):
3558         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3559         (WebTestRunner::WebTestProxyBase::reset):
3560         (WebTestRunner):
3561         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
3562         (WebTestRunner::WebTestProxyBase::willRequestResource):
3563         (WebTestRunner::WebTestProxyBase::willSendRequest):
3564         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
3565         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
3566         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
3567         * DumpRenderTree/chromium/WebViewHost.cpp:
3568         (WebViewHost::willSendRequest):
3569         (WebViewHost::makeURLErrorDescription):
3570         (WebViewHost::reset):
3571         * DumpRenderTree/chromium/WebViewHost.h:
3572         (WebViewHost):
3573
3574 2013-01-09  Dan Carney  <dcarney@google.com>
3575
3576         [chromium] move dumpcreateview methods to testrunner library
3577         https://bugs.webkit.org/show_bug.cgi?id=106434
3578
3579         Reviewed by Adam Barth.
3580
3581         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3582         (DRTTestRunner::DRTTestRunner):
3583         (DRTTestRunner::reset):
3584         * DumpRenderTree/chromium/DRTTestRunner.h:
3585         (DRTTestRunner):
3586         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3587         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
3588         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3589         (WebTestRunner::TestRunner::TestRunner):
3590         (WebTestRunner::TestRunner::reset):
3591         (WebTestRunner::TestRunner::shouldDumpCreateView):
3592         (WebTestRunner):
3593         (WebTestRunner::TestRunner::dumpCreateView):
3594         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3595         (TestRunner):
3596
3597 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
3598
3599         webkitpy cleanup: Merge additional_comment_text into comment_text
3600         https://bugs.webkit.org/show_bug.cgi?id=106421
3601
3602         Reviewed by Adam Barth.
3603
3604         * Scripts/webkitpy/common/config/committervalidator.py:
3605         (CommitterValidator.reject_patch_from_commit_queue):
3606         (CommitterValidator.reject_patch_from_review_queue):
3607         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3608         (Bugzilla.set_flag_on_attachment):
3609         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3610         (MockBugzilla.set_flag_on_attachment):
3611         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3612         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3613         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
3614         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3615
3616 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3617
3618         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
3619         https://bugs.webkit.org/show_bug.cgi?id=106464
3620
3621         Reviewed by Martin Robinson.
3622
3623         Current version in jhbuild.modules (2.26.0) is giving trouble to
3624         when trying to build WebKitGTK from scratch, due to a segmentation
3625         fault error in gdk-pixbuf-query-loader during the 'make'
3626         phase. Raising the version to 2.26.5 fixes this issue.
3627
3628         * gtk/jhbuild.modules: Version raised, checksums updated.
3629
3630 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
3631
3632         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
3633         https://bugs.webkit.org/show_bug.cgi?id=90968.
3634
3635         Reviewed by Csaba Osztrogonác.
3636
3637         Added functionality in DRT and WTR to use any timeout value while running
3638         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
3639         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
3640         to indicate whether the current port supports setting timeout value
3641         per test (it's False by default; I enabled it only on Qt).
3642         Also corrected a typo in driver.py
3643
3644         * DumpRenderTree/DumpRenderTree.h:
3645         (TestCommand::TestCommand):
3646         (TestCommand):
3647         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3648         (parseInputLine):
3649         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3650         (WebCore::DumpRenderTree::processLine):
3651         * Scripts/webkitpy/layout_tests/port/base.py:
3652         (Port.supports_per_test_timeout):
3653         * Scripts/webkitpy/layout_tests/port/driver.py:
3654         (Driver.run_test):
3655         (Driver._command_from_driver_input):
3656         * Scripts/webkitpy/layout_tests/port/qt.py:
3657         (QtPort.supports_per_test_timeout):
3658         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3659         (WTR::InjectedBundle::InjectedBundle):
3660         (WTR::InjectedBundle::didReceiveMessage):
3661         (WTR::InjectedBundle::beginTesting):
3662         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3663         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3664         (WTR::TestRunner::setCustomTimeout):
3665         (WTR):
3666         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3667         (TestRunner):
3668         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
3669         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3670         * WebKitTestRunner/TestController.cpp:
3671         (WTR::TestController::TestController):
3672         (WTR::TestController::getCustomTimeout):
3673         (WTR):
3674         (WTR::TestCommand::TestCommand):
3675         (TestCommand):