Use xcrun to find path to make for Mac port
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-16  David Kilzer  <ddkilzer@apple.com>
2
3         Use xcrun to find path to make for Mac port
4         <http://webkit.org/b/107091>
5
6         Reviewed by Dan Bernstein.
7
8         * Scripts/webkitpy/layout_tests/port/mac.py:
9         (MacPort._build_java_test_support): Call self.make_command().
10         (MacPort.make_command): Add.  Call xcrun_find().
11         (MacPort.nm_command): Use self.xcrun_find().
12         (MacPort.xcrun_find): Add.  Extract from nm_command().
13
14 2013-01-16  Sam Weinig  <sam@webkit.org>
15
16         Make debug-safari --target-web-process work again
17         https://bugs.webkit.org/show_bug.cgi?id=107088
18
19         Reviewed by Anders Carlsson.
20
21         * Scripts/webkitdirs.pm:
22         (execMacWebKitAppForDebugging):
23         The shim is now called SecItemShim.
24
25 2013-01-16  Alan Cutter  <alancutter@chromium.org>
26
27         GCE build scripts don't take working directory into account when calling findzone.sh
28         https://bugs.webkit.org/show_bug.cgi?id=106962
29
30         Reviewed by Adam Barth.
31
32         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
33         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
34         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
35
36 2013-01-16  Alan Cutter  <alancutter@chromium.org>
37
38         start-queue.sh does not pass remaining parameters correctly
39         https://bugs.webkit.org/show_bug.cgi?id=107054
40
41         Reviewed by Adam Barth.
42
43         start-queue.sh now passes all remaining params to the webkit-patch command.
44         Previously only one additional queue parameter could be sent.
45
46         * EWSTools/start-queue.sh:
47
48 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
49
50         check-webkit-style script cannot running in Chinese windows.
51         https://bugs.webkit.org/show_bug.cgi?id=87548
52
53         Reviewed by Darin Adler.
54
55         * Scripts/webkitpy/common/system/platforminfo.py:
56         (PlatformInfo._win_version_tuple_from_cmd):
57
58 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
59
60         Delete an extraneous print statement.
61         https://bugs.webkit.org/show_bug.cgi?id=106562
62
63         Delete the extraneous print statement introduced in r139841.
64
65         * Scripts/webkitpy/layout_tests/views/printing.py:
66         (Printer.print_found):
67
68 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
69
70         Please reinstate --pixel
71         https://bugs.webkit.org/show_bug.cgi?id=101995
72
73         Reviewed by Dirk Pranke.
74
75         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
76         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
77         Some developers are still used to these options that were available in the ORWT.
78
79         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
80         (parse_args):
81
82 2013-01-16  Eric Seidel  <eric@webkit.org>
83
84         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
85         https://bugs.webkit.org/show_bug.cgi?id=99512
86
87         Reviewed by Darin Adler.
88
89         * Scripts/run-sunspider:
90
91 2013-01-16  Eric Seidel  <eric@webkit.org>
92
93         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
94         https://bugs.webkit.org/show_bug.cgi?id=106036
95
96         Reviewed by Darin Adler.
97
98         * Scripts/webkitpy/webkitpy.pyproj: Removed.
99         * Scripts/webkitpy/webkitpy.sln: Removed.
100
101 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
102
103         [Chromium] Remove hardcoded chromium_*.jar in gyp files
104         https://bugs.webkit.org/show_bug.cgi?id=104049
105
106         Reviewed by Eric Seidel.
107
108         Targets with dependencies (direct/indirect) on a java target receive
109         the chromium_*.jar paths in the variable input_jars_paths. Targets
110         should use that rather than hardcoding where they think the jar will
111         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
112         than as --jars to generate_native_test.py.
113
114         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
115         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
116
117 2013-01-16  Dan Carney  <dcarney@google.com>
118
119         [chromium] move setMockDeviceOrientation to TestRunner library
120         https://bugs.webkit.org/show_bug.cgi?id=106895
121
122         Reviewed by Jochen Eisinger.
123
124         * DumpRenderTree/chromium/DRTTestRunner.cpp:
125         (DRTTestRunner::DRTTestRunner):
126         * DumpRenderTree/chromium/DRTTestRunner.h:
127         (DRTTestRunner):
128         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
129         (WebKit):
130         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
131         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
132         (WebTestRunner::TestRunner::TestRunner):
133         (WebTestRunner::TestRunner::setMockDeviceOrientation):
134         (WebTestRunner):
135         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
136         (TestRunner):
137         * DumpRenderTree/chromium/WebViewHost.cpp:
138         (WebViewHost::setDeviceOrientation):
139         * DumpRenderTree/chromium/WebViewHost.h:
140         (WebViewHost):
141
142 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
143
144         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
145         https://bugs.webkit.org/show_bug.cgi?id=106904
146
147         Reviewed by Adam Barth.
148
149         * DumpRenderTree/chromium/DRTTestRunner.cpp:
150         (DRTTestRunner::DRTTestRunner):
151         (DRTTestRunner::notifyDone):
152         (DRTTestRunner::reset):
153         * DumpRenderTree/chromium/DRTTestRunner.h:
154         (DRTTestRunner):
155         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
156         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
157         (WebTestRunner::WebTestDelegate::setFocus):
158         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
159         (WebTestRunner::WebTestDelegate::pathToLocalResource):
160         (WebTestRunner::WebTestDelegate::setLocale):
161         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
162         (WebTestRunner::TestRunner::TestRunner):
163         (WebTestRunner::TestRunner::reset):
164         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
165         (WebTestRunner):
166         (WebTestRunner::TestRunner::setWindowIsKey):
167         (WebTestRunner::TestRunner::pathToLocalResource):
168         (WebTestRunner::TestRunner::setBackingScaleFactor):
169         (WebTestRunner::TestRunner::setPOSIXLocale):
170         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
171         (WebTestRunner::TestRunner::taskList):
172         (TestRunner):
173         * DumpRenderTree/chromium/WebViewHost.cpp:
174         (WebViewHost::setDeviceScaleFactor):
175         (WebViewHost::setFocus):
176         (WebViewHost::setAcceptAllCookies):
177         (WebViewHost::pathToLocalResource):
178         (WebViewHost::setLocale):
179         * DumpRenderTree/chromium/WebViewHost.h:
180         (WebViewHost):
181
182 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
183
184         [GTK] build-webkit fails if the jhbuild wrapper is not used
185         https://bugs.webkit.org/show_bug.cgi?id=106769
186
187         Reviewed by Martin Robinson.
188
189         Return an empty array instead of "" in
190         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
191         will not be recognized as a valid command when the returned array
192         is directly passed to perl's system() call.
193
194         * Scripts/webkitdirs.pm:
195         (jhbuildWrapperPrefixIfNeeded):
196
197 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
198
199         [chromium] add title text direction attribute to TestRunner
200         https://bugs.webkit.org/show_bug.cgi?id=106907
201
202         Reviewed by Adam Barth.
203
204         * DumpRenderTree/chromium/DRTTestRunner.cpp:
205         (DRTTestRunner::DRTTestRunner):
206         (DRTTestRunner::reset):
207         * DumpRenderTree/chromium/DRTTestRunner.h:
208         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
209         (WebTestRunner::WebTestRunner::setTitleTextDirection):
210         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
211         (WebTestRunner::TestRunner::TestRunner):
212         (WebTestRunner::TestRunner::reset):
213         (WebTestRunner::TestRunner::setTitleTextDirection):
214         (WebTestRunner):
215         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
216         (TestRunner):
217         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
218         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
219         * DumpRenderTree/chromium/WebViewHost.cpp:
220         (WebViewHost::didReceiveTitle):
221
222 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
223
224         NRWT still confused about test count with --repeat-each and --iterations
225         https://bugs.webkit.org/show_bug.cgi?id=106562
226
227         Reviewed by Dirk Pranke.
228
229         Fix the printed unique test count and skipped count. This
230         seems to have broken in r127688 ("NRWT lies about the number
231         of tests that it's skipping when used with --repeat-each").
232
233         Also add a test for print_found()
234
235         * Scripts/webkitpy/layout_tests/views/printing.py:
236         (Printer.print_found):
237         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
238         (Testprinter.test_details):
239         (Testprinter):
240         (Testprinter.test_found):
241
242 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
243
244         Unreviewed follow-up to r139769.
245
246         Note that omitting the WebKit1 code from the build now
247         works for GTK as well.
248
249         * Scripts/build-webkit:
250
251 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
252
253         test-webkitpy: truncate output to the terminal width when necessary
254         https://bugs.webkit.org/show_bug.cgi?id=106973
255
256         Reviewed by Ojan Vafai.
257
258         this implements the same logic for test-webkitpy that we have
259         for run-webkit-tests (and ninja).
260
261         No tests written as this is exercised by running test-webkitpy itself.
262
263         * Scripts/webkitpy/test/printer.py:
264         (Printer.configure):
265         (Printer._test_line):
266
267 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
268
269         remove extraneous output in test-webkitpy
270         https://bugs.webkit.org/show_bug.cgi?id=106971
271
272         Reviewed by Ojan Vafai.
273
274         We weren't ignoring or capturing the echoed output from
275         these two tests, and getting noise in the logs as a result.
276
277         * Scripts/webkitpy/common/system/executive_unittest.py:
278         (ExecutiveTest.test_auto_stringify_args):
279         (ExecutiveTest.test_popen_args):
280
281 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
282
283         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
284         https://bugs.webkit.org/show_bug.cgi?id=106974
285
286         Reviewed by Ryosuke Niwa.
287
288         I forgot to stub out the call to check to ensure that the ports were
289         available, so this test could fail if something was listening on 8000 or
290         8443 on the machine.
291
292         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
293         (TestHttpServer.test_win32_start_and_stop):
294
295 2013-01-15  Levi Weintraub  <leviw@chromium.org>
296
297         Unreviewed, rolling out r139792.
298         http://trac.webkit.org/changeset/139792
299         https://bugs.webkit.org/show_bug.cgi?id=106970
300
301         Broke the windows build.
302
303         * DumpRenderTree/chromium/DRTTestRunner.cpp:
304         (DRTTestRunner::DRTTestRunner):
305         (DRTTestRunner::notifyDone):
306         (DRTTestRunner::reset):
307         (DRTTestRunner::setAlwaysAcceptCookies):
308         (DRTTestRunner::setWindowIsKey):
309         (DRTTestRunner::pathToLocalResource):
310         (DRTTestRunner::setPOSIXLocale):
311         (InvokeCallbackTask):
312         (InvokeCallbackTask::InvokeCallbackTask):
313         (InvokeCallbackTask::runIfValid):
314         (DRTTestRunner::setBackingScaleFactor):
315         * DumpRenderTree/chromium/DRTTestRunner.h:
316         (DRTTestRunner):
317         (DRTTestRunner::taskList):
318         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
319         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
320         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
321         (WebTestRunner::TestRunner::TestRunner):
322         (WebTestRunner::TestRunner::reset):
323         (WebTestRunner::TestRunner::setDatabaseQuota):
324         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
325         (TestRunner):
326         * DumpRenderTree/chromium/WebViewHost.cpp:
327         (WebViewHost::setPendingExtraData):
328         (WebViewHost::setDeviceScaleFactor):
329         * DumpRenderTree/chromium/WebViewHost.h:
330         (WebViewHost):
331
332 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
333
334         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
335
336         * Scripts/webkitpy/common/config/ports.py:
337         (MacWK2Port):
338
339 2013-01-15  Alan Cutter  <alancutter@chromium.org>
340
341         Extend sheriffbot's "help" command to be able to get help on individual commands
342         https://bugs.webkit.org/show_bug.cgi?id=106629
343
344         Reviewed by Eric Seidel.
345
346         Added a help command to sheriffbot.
347         Fixed some style issues and ordered the commands alphabetically.
348
349         * Scripts/webkitpy/tool/bot/irc_command.py:
350         (IRCCommand):
351         (IRCCommand.execute):
352         (IRCCommand.usage):
353         (IRCCommand.help):
354         (CreateBug):
355         (CreateBug.execute):
356         (Help):
357         (Help.execute):
358         (Help._post_command_help):
359         (Hi):
360         (Hi.execute):
361         (Restart):
362         (RollChromiumDEPS):
363         (RollChromiumDEPS._parse_args):
364         (RollChromiumDEPS._expand_irc_nickname):
365         (RollChromiumDEPS.execute):
366         (Rollout):
367         (Rollout._extract_revisions):
368         (Rollout.execute):
369         (Sheriffs):
370         (Sheriffs.execute):
371         (Whois):
372         (Whois.execute):
373         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
374         (IRCBotTest.test_help):
375
376 2013-01-15  Enrica Casucci  <enrica@apple.com>
377
378         Add a new set of WebKit2 APIs for text search and
379         search results management.
380         https://bugs.webkit.org/show_bug.cgi?id=106834.
381         <rdar://problem/12597159>
382
383         Added new test for the new WebKit2 API for
384         text search.
385         
386         Reviewed by Simon Fraser.
387
388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
389         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
390
391 2013-01-15  Levi Weintraub  <leviw@chromium.org>
392
393         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
394         https://bugs.webkit.org/show_bug.cgi?id=106904
395
396         Reverting 139794. It broke the build. It appears that a header file,
397         WebTextDirection.h, was left out.
398
399         * DumpRenderTree/chromium/DRTTestRunner.cpp:
400         (DRTTestRunner::DRTTestRunner):
401         (DRTTestRunner::reset):
402         * DumpRenderTree/chromium/DRTTestRunner.h:
403         (DRTTestRunner::setTitleTextDirection):
404         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
405         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
406         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
407         (WebTestRunner::TestRunner::TestRunner):
408         (WebTestRunner::TestRunner::reset):
409         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
410         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
411         (TestRunner):
412         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
413         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
414         * DumpRenderTree/chromium/WebViewHost.cpp:
415         (WebViewHost::didReceiveTitle):
416
417 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
418
419         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
420         https://bugs.webkit.org/show_bug.cgi?id=106904
421
422         Reviewed by Adam Barth.
423
424         * DumpRenderTree/chromium/DRTTestRunner.cpp:
425         (DRTTestRunner::DRTTestRunner):
426         (DRTTestRunner::notifyDone):
427         (DRTTestRunner::reset):
428         * DumpRenderTree/chromium/DRTTestRunner.h:
429         (DRTTestRunner):
430         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
431         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
432         (WebTestRunner::WebTestDelegate::setFocus):
433         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
434         (WebTestRunner::WebTestDelegate::pathToLocalResource):
435         (WebTestRunner::WebTestDelegate::setLocale):
436         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
437         (WebTestRunner::TestRunner::TestRunner):
438         (WebTestRunner::TestRunner::reset):
439         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
440         (WebTestRunner):
441         (WebTestRunner::TestRunner::setWindowIsKey):
442         (WebTestRunner::TestRunner::pathToLocalResource):
443         (WebTestRunner::TestRunner::setBackingScaleFactor):
444         (WebTestRunner::TestRunner::setPOSIXLocale):
445         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
446         (WebTestRunner::TestRunner::taskList):
447         (TestRunner):
448         * DumpRenderTree/chromium/WebViewHost.cpp:
449         (WebViewHost::setDeviceScaleFactor):
450         (WebViewHost::setFocus):
451         (WebViewHost::setAcceptAllCookies):
452         (WebViewHost::pathToLocalResource):
453         (WebViewHost::setLocale):
454         * DumpRenderTree/chromium/WebViewHost.h:
455         (WebViewHost):
456
457 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
458
459         Tests with WontFix expectation are (indirectly) skipped
460         https://bugs.webkit.org/show_bug.cgi?id=105860
461
462         Reviewed by Dirk Pranke.
463
464         Only skip the WontFix expectation if there are no other layout test
465         expectations (like Failure, ImageOnlyFailure) listed for the test.
466         This makes it possible to run an expected failure for which there
467         is no reason or interest to fix. There are some ports that would like
468         to exercise this behavior as well as specific test cases that should use
469         such expectations.
470
471         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
472         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
473         WONTFIX test if there are no expectations listed. The warning is adjusted
474         to reflect the new behavior.
475         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
476         and adjust test cases for these changes.
477         (ExpectationSyntaxTests.test_wontfix):
478         (SemanticTests.test_skip_and_wontfix):
479
480 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
481
482         [chromium] add title text direction attribute to TestRunner
483         https://bugs.webkit.org/show_bug.cgi?id=106907
484
485         Reviewed by Adam Barth.
486
487         * DumpRenderTree/chromium/DRTTestRunner.cpp:
488         (DRTTestRunner::DRTTestRunner):
489         (DRTTestRunner::reset):
490         * DumpRenderTree/chromium/DRTTestRunner.h:
491         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
492         (WebTestRunner::WebTestRunner::setTitleTextDirection):
493         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
494         (WebTestRunner::TestRunner::TestRunner):
495         (WebTestRunner::TestRunner::reset):
496         (WebTestRunner::TestRunner::setTitleTextDirection):
497         (WebTestRunner):
498         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
499         (TestRunner):
500         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
501         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
502         * DumpRenderTree/chromium/WebViewHost.cpp:
503         (WebViewHost::didReceiveTitle):
504
505 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
506
507         nrwt: change the default # of locked shards on chromium_win to 1
508         https://bugs.webkit.org/show_bug.cgi?id=106938
509
510         Reviewed by Eric Seidel.
511
512         It looks like LigHTTPd might be buggy or unstable if we are
513         running multiple http tests in parallel; see
514         http://code.google.com/p/chromium/issues/detail?id=169530 for more
515         context as well. This change will stop running http tests in parallel
516         and we can see if this fixes things.
517
518         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
519         (ChromiumWinPort.default_max_locked_shards):
520         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
521         (ChromiumWinTest.test_path_to_image_diff):
522         (ChromiumWinTest):
523         (ChromiumWinTest.test_default_max_locked_shards):
524
525 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
526
527         [chromium] move WebDatabase related methods to TestRunner library
528         https://bugs.webkit.org/show_bug.cgi?id=106905
529
530         Reviewed by Adam Barth.
531
532         * DumpRenderTree/chromium/DRTTestRunner.cpp:
533         (DRTTestRunner::DRTTestRunner):
534         (DRTTestRunner::reset):
535         * DumpRenderTree/chromium/DRTTestRunner.h:
536         (DRTTestRunner):
537         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
538         (WebTestRunner::WebTestDelegate::clearAllDatabases):
539         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
540         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
541         (WebTestRunner::TestRunner::TestRunner):
542         (WebTestRunner::TestRunner::reset):
543         (WebTestRunner::TestRunner::clearAllDatabases):
544         (WebTestRunner):
545         (WebTestRunner::TestRunner::setDatabaseQuota):
546         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
547         (TestRunner):
548         * DumpRenderTree/chromium/WebViewHost.cpp:
549         (WebViewHost::clearAllDatabases):
550         (WebViewHost::setDatabaseQuota):
551         * DumpRenderTree/chromium/WebViewHost.h:
552         (WebViewHost):
553
554 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
555
556         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
557         functionality match the name.
558         https://bugs.webkit.org/show_bug.cgi?id=106870
559
560         Reviewed by Adam Barth.
561
562         * Scripts/webkitpy/tool/commands/download.py:
563         (Clean):
564         (Update):
565         (Build):
566         (BuildAndTest):
567         (CheckStyle):
568         (BuildAttachment):
569         (BuildAndTestAttachment):
570         (AbstractPatchApplyingCommand):
571         (ApplyWatchList):
572         (AbstractPatchLandingCommand):
573         (CreateRollout):
574         * Scripts/webkitpy/tool/steps/__init__.py:
575         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
576         (CleanWorkingDirectory.options):
577         (CleanWorkingDirectory.run):
578         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
579         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
580         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
581
582 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
583
584         [Autotools] Add support for WebKit2-only builds
585         https://bugs.webkit.org/show_bug.cgi?id=106889
586
587         Reviewed by Gustavo Noronha Silva.
588
589         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
590         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
591         building the GTK port through build-webkit.
592         * Scripts/webkitdirs.pm:
593         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
594         arguments when not building WebKit1.
595         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
596         through the Autotools build system.
597
598 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
599
600         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
601         https://bugs.webkit.org/show_bug.cgi?id=106197
602
603         Reviewed by Martin Robinson.
604
605         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
606         features. Enable them on GTK, meaning they will be enabled in development builds
607         (i.e. when building with build-webkit).
608
609 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
610
611         [GTK] Enable CSS Image Resolution feature
612         https://bugs.webkit.org/show_bug.cgi?id=99038
613
614         Reviewed by Gustavo Noronha Silva.
615
616         Enable the CSS Image Resolution feature for the development
617         builds of the GTK port.
618
619         * Scripts/webkitperl/FeatureList.pm:
620
621 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
622
623         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
624         https://bugs.webkit.org/show_bug.cgi?id=106579
625
626         Reviewed by Gustavo Noronha Silva.
627
628         The --enable-unstable-features flag is not required to be passed anymore
629         to the configure script as it was removed in r138252.
630
631         * Scripts/webkitdirs.pm:
632         (buildAutotoolsProject):
633
634 2013-01-15  Tony Chang  <tony@chromium.org>
635
636         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
637
638         * Scripts/webkitpy/layout_tests/servers/http_server.py:
639         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
640         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
641         (TestHttpServer.test_win32_start_and_stop):
642
643 2013-01-15  Joshua Bell  <jsbell@chromium.org>
644
645         Unreviewed. Adding Michael Pruett as contributor.
646
647         * Scripts/webkitpy/common/config/committers.py:
648
649 2013-01-15  Victor Carbune  <victor@rosedu.org>
650
651         Unreviewed. Update my email addresses.
652
653         * Scripts/webkitpy/common/config/committers.py:
654
655 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
656
657         [GTK] Waiting on the gdb process will lead to deadlock
658         https://bugs.webkit.org/show_bug.cgi?id=106906
659
660         Reviewed by Philippe Normand.
661
662         Use communicate() rather than wait() on the Popen object that's running the gdb
663         command. This avoids the deadlock that occurs on the GTK builders.
664
665         * Scripts/webkitpy/layout_tests/port/gtk.py:
666         (GtkPort._get_gdb_output):
667
668 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
669
670         [GTK] Limit the number of frames printed out when backtracing with gdb
671         https://bugs.webkit.org/show_bug.cgi?id=106901
672
673         Reviewed by Philippe Normand.
674
675         Printing an unlimited number of frames when dumping the gdb backtracing
676         output can cause timeouts in the builders. This patch limits the number
677         of frames that are printed out to 1024.
678
679         * Scripts/webkitpy/layout_tests/port/gtk.py:
680         (GtkPort._get_gdb_output):
681
682 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
683
684         [Qt] Fix ImageDiff's image format conversion
685         https://bugs.webkit.org/show_bug.cgi?id=106880
686
687         Reviewed by Csaba Osztrogonác.
688
689         Besides actually doing the conversion this also silences the suspicious warning:
690         "ignoring return value of function declared with warn_unused_result attribute".
691
692         * ImageDiff/qt/ImageDiff.cpp:
693         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
694         copy of the image in the given format and does not alter the image itself.
695
696 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
697
698         [chromium] move remaining methods that just set a boolean flag to TestRunner library
699         https://bugs.webkit.org/show_bug.cgi?id=106823
700
701         Reviewed by Darin Fisher.
702
703         * DumpRenderTree/chromium/DRTTestRunner.cpp:
704         (DRTTestRunner::DRTTestRunner):
705         (DRTTestRunner::reset):
706         * DumpRenderTree/chromium/DRTTestRunner.h:
707         (DRTTestRunner):
708         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
709         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
710         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
711         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
712         (WebTestRunner::WebTestRunner::testRepaint):
713         (WebTestRunner::WebTestRunner::sweepHorizontally):
714         (WebTestRunner::WebTestRunner::isPrinting):
715         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
716         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
717         (WebTestRunner::TestRunner::TestRunner):
718         (WebTestRunner::TestRunner::reset):
719         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
720         (WebTestRunner):
721         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
722         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
723         (WebTestRunner::TestRunner::testRepaint):
724         (WebTestRunner::TestRunner::sweepHorizontally):
725         (WebTestRunner::TestRunner::isPrinting):
726         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
727         (WebTestRunner::TestRunner::dumpBackForwardList):
728         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
729         (WebTestRunner::TestRunner::dumpSelectionRect):
730         (WebTestRunner::TestRunner::repaintSweepHorizontally):
731         (WebTestRunner::TestRunner::setPrinting):
732         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
733         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
734         (TestRunner):
735
736 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
737
738         nrwt: stub out show_results_html for mock ports
739         https://bugs.webkit.org/show_bug.cgi?id=106848
740
741         Reviewed by Ojan Vafai.
742
743         We were accidentally using the underlying ports'
744         show_results_html_file() implementation, which would, unsurprisingly,
745         fail in many cases (e.g., running mock-efl on the mac).
746
747         No test added since we don't generally add tests for the mock
748         implementation.
749
750         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
751         (MockDRTPort.show_results_html_file):
752
753 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
754
755         Changing clean_working_directory/clean_local_commits and related
756         functions to have consistent naming.
757
758         https://bugs.webkit.org/show_bug.cgi?id=104198
759
760         Reviewed by Adam Barth.
761
762         * Scripts/webkitpy/common/checkout/scm/git.py:
763         * Scripts/webkitpy/common/checkout/scm/scm.py:
764         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
765         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
766         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
767         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
768
769 2013-01-14  Alan Cutter  <alancutter@chromium.org>
770
771         Fix EWS GCE build scripts to detect which zone is available
772         https://bugs.webkit.org/show_bug.cgi?id=106524
773
774         Reviewed by Adam Barth.
775
776         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
777         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
778         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
779         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
780
781 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
782
783         Adding an error string to AmbiguousCommitError.
784         https://bugs.webkit.org/show_bug.cgi?id=106846
785
786         Reviewed by Adam Barth.
787
788         * Scripts/webkitpy/common/checkout/scm/git.py:
789         (AmbiguousCommitError.__init__):
790
791 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
792
793         kill whole lighttpd process tree for chromium win
794         https://bugs.webkit.org/show_bug.cgi?id=106838
795
796         Reviewed by Tony Chang.
797
798         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
799         I think a test is causing a httpd server child process to wedge and
800         killing the parent httpd server process isn't sufficient to ensure
801         that the children are also killed.
802
803         * Scripts/webkitpy/layout_tests/servers/http_server.py:
804         (Lighttpd._check_and_kill):
805         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
806         (TestHttpServer.test_start_cmd):
807         (TestHttpServer):
808         (TestHttpServer.test_win32_start_and_stop):
809         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
810         (TestHttpServer.test_win32_start_and_stop.mock_returns):
811         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
812
813 2013-01-14  Nico Weber  <thakis@chromium.org>
814
815         [chromium] Enable `update-webkit --chromium --ninja` on windows
816         https://bugs.webkit.org/show_bug.cgi?id=106836
817
818         Reviewed by Eric Seidel.
819
820         After running this, build-webkit --chromium will use ninja to build.
821         Apparently there are some minor issues with that still, so it's
822         not quite ready for use yet.
823
824         * Scripts/webkitdirs.pm:
825         (determineIsChromiumNinja):
826         (buildChromium):
827
828 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
829
830         nrwt: use the same search path for baselines and TestExpectations on apple mac
831         https://bugs.webkit.org/show_bug.cgi?id=105599
832
833         Reviewed by Ryosuke Niwa.
834
835         Bug 105583 revealed some confusion due to the fact that the Apple
836         Mac port used a different list of directories to search for baselines
837         and TestExpectations files (actually, pretty much every port does).
838
839         It seems like a good idea to use the same list for both by default, but
840         making this happen will affect every port in slightly different ways, so
841         we'll try this on the Apple Mac port first.
842
843         Note that the effective changes for this are that:
844         1) The apple mac port will look in platform/wk2 for baselines where
845         it didn't before (it will look after looking in mac-wk2 but before
846         the non-wk2 dirs)
847         2) The apple mac-snowleopard port will use the expectations in
848         mac-lion as well as the expectations in mac-snowleopard, although
849         I'm not even sure if mac-snowleopard is still supported ...
850
851         * Scripts/webkitpy/layout_tests/port/mac.py:
852         (MacPort.default_baseline_search_path):
853         (MacPort.expectations_files):
854         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
855         (test_baseline_search_path):
856
857 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
858
859         AX: Need to implement ColorWellRole
860         https://bugs.webkit.org/show_bug.cgi?id=106756
861
862         Reviewed by Chris Fleizach.
863
864         Returns a string representation of the value of a color
865         when the role is Color Well, to make it easy to write layout
866         tests for color controls.
867
868         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
869
870 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
871
872         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
873         https://bugs.webkit.org/show_bug.cgi?id=106682
874
875         Reviewed by Chris Fleizach.
876
877         Modify Chromium's DRT implementation of intValue to return a
878         different value depending on the role.
879
880         There are actually platform-specific differences in what should
881         be returned in the "value" of an object, so Chromium normally keeps
882         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
883         but this is a fine simplification to make cross-platform tests easier.
884
885         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
886         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
887
888 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
889
890         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
891         https://bugs.webkit.org/show_bug.cgi?id=106785
892
893         Reviewed by Adam Barth.
894
895         * DumpRenderTree/chromium/DRTTestRunner.cpp:
896         (DRTTestRunner::DRTTestRunner):
897         (DRTTestRunner::reset):
898         * DumpRenderTree/chromium/DRTTestRunner.h:
899         (DRTTestRunner):
900         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
901         (WebTestProxyBase):
902         (WebTestRunner::WebTestProxy::setStatusText):
903         (WebTestRunner::WebTestProxy::didStopLoading):
904         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
905         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
906         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
907         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
908         (WebTestRunner::TestRunner::TestRunner):
909         (WebTestRunner::TestRunner::reset):
910         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
911         (WebTestRunner):
912         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
913         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
914         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
915         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
916         (TestRunner):
917         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
918         (WebTestRunner::WebTestProxyBase::setStatusText):
919         (WebTestRunner):
920         (WebTestRunner::WebTestProxyBase::didStopLoading):
921         * DumpRenderTree/chromium/WebViewHost.cpp:
922         (WebViewHost::didStopLoading):
923         * DumpRenderTree/chromium/WebViewHost.h:
924         (WebViewHost):
925
926 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
927
928         Web Inspector: devtools front-end doesn't have focus in TestShell
929         https://bugs.webkit.org/show_bug.cgi?id=106778
930
931         Reviewed by Pavel Feldman.
932
933         Focus devTools window after loadURL method.
934
935         * DumpRenderTree/chromium/TestShell.cpp:
936         (TestShell::runFileTest):
937
938 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
939
940         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
941         https://bugs.webkit.org/show_bug.cgi?id=106573
942
943         Reviewed by Philippe Normand.
944
945         Similarly to what's been described in bug 106569, we're building
946         from release tarballs, so there's no reason to regenerate the
947         autoconf-related stuff with autogen.sh, especially since we might
948         run into trouble with automake 1.13 and deprecated macros.
949
950         * efl/jhbuild.modules:
951
952 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
953
954         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
955         https://bugs.webkit.org/show_bug.cgi?id=104909
956
957         Reviewed by Simon Hausmann.
958
959         To be able to build redistribuable binary packages, Qt's configure switches
960         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
961         dynamically link to optional system libraries.
962         QtWebKit is doing its own configure checks for those libraries, thus adding a
963         runtime dependency that might not be fulfilled if the packager's machine had
964         those libraries while the user's machine won't.
965
966         Since in most cases where WebKit will want to use those system libraries, Qt will
967         also be using them, remove these configure tests from WebKit.
968
969         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
970         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
971         * qmake/config.tests/libpng/libpng.cpp: Removed.
972         * qmake/config.tests/libpng/libpng.pro: Removed.
973         * qmake/mkspecs/features/features.prf:
974
975 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
976
977         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
978         https://bugs.webkit.org/show_bug.cgi?id=106574
979
980         Reviewed by Laszlo Gombos.
981
982         Rely on a more recent stable release, which includes support for
983         Lua 5.2 in Edje and other assorted minor fixes.
984
985         While here, also use the "configure" script to build the libraries
986         instead of relying on autogen.sh, which is not really needed with
987         a release tarball and may have problems with automake 1.13.
988
989         * efl/jhbuild.modules:
990
991 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
992
993         Web Inspector: fix DRT to deliver simulated events to devtools front-end
994         https://bugs.webkit.org/show_bug.cgi?id=106650
995
996         Reviewed by Pavel Feldman.
997
998         Add separated m_devToolsTestInterfaces object to testShell which is
999         bind to devTools webview.
1000
1001         * DumpRenderTree/chromium/TestShell.cpp:
1002         (TestShell::initialize):
1003         (TestShell::createMainWindow):
1004         (TestShell::~TestShell):
1005         (TestShell::showDevTools):
1006         (TestShell::resetTestController):
1007         (TestShell::bindJSObjectsToWindow):
1008         (TestShell::createNewWindow):
1009         * DumpRenderTree/chromium/TestShell.h:
1010         (TestShell):
1011
1012 2013-01-14  Alan Cutter  <alancutter@chromium.org>
1013
1014         Sheriffbot command aliases need test cases
1015         https://bugs.webkit.org/show_bug.cgi?id=106754
1016
1017         Reviewed by Eric Seidel.
1018
1019         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1020         (SheriffBotTest.test_command_aliases):
1021
1022 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1023
1024         Allow users to misspell the "sheriffs" command in sheriffbot
1025         https://bugs.webkit.org/show_bug.cgi?id=106628
1026
1027         Reviewed by Steve Block.
1028
1029         * Scripts/webkitpy/tool/bot/irc_command.py:
1030
1031 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1032
1033         Make "gardeners" an alias for "sheriffs" in sherrifbot
1034         https://bugs.webkit.org/show_bug.cgi?id=106627
1035
1036         Reviewed by Eric Seidel.
1037
1038         * Scripts/webkitpy/tool/bot/irc_command.py:
1039
1040 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
1041
1042         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
1043         https://bugs.webkit.org/show_bug.cgi?id=105380
1044
1045         Reviewed by Eric Seidel.
1046
1047         Fix a regression introduced in r137692 where we were double-encoding
1048         the arguments to popen(); this was only an issue on windows, where
1049         we would try to encode something to mbcs, then try to encode it
1050         to unicode as if the input as ascii.
1051
1052         * Scripts/webkitpy/common/system/executive.py:
1053         (Executive.run_command):
1054
1055 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1056
1057         State who told sheriffbot to roll the Chromium deps and to what revision
1058         https://bugs.webkit.org/show_bug.cgi?id=106626
1059
1060         Reviewed by Eric Seidel.
1061
1062         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
1063
1064         * Scripts/webkitpy/tool/bot/irc_command.py:
1065         (RollChromiumDEPS._expand_irc_nickname):
1066         (RollChromiumDEPS.execute):
1067         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1068         (IRCCommandTest.test_roll_chromium_deps):
1069         * Scripts/webkitpy/tool/bot/sheriff.py:
1070         (Sheriff.post_chromium_deps_roll):
1071         * Scripts/webkitpy/tool/commands/roll.py:
1072         (RollChromiumDEPS._prepare_state):
1073         (PostChromiumDEPSRoll):
1074         (PostChromiumDEPSRoll._prepare_state):
1075         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1076         (PostRollCommandsTest.test_prepare_state):
1077         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1078         (PrepareChangeLogForDEPSRoll.run):
1079
1080 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1081
1082         Add Alan Cutter as contributor
1083         https://bugs.webkit.org/show_bug.cgi?id=106747
1084
1085         Reviewed by Eric Seidel.
1086
1087         * Scripts/webkitpy/common/config/committers.py:
1088
1089 2013-01-13  Jonathan Liu  <net147@gmail.com>
1090
1091         Fix CONFIG missing link_pkgconfig on Windows
1092         https://bugs.webkit.org/show_bug.cgi?id=106647
1093
1094         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
1095         properly on Windows because they are added to PKGCONFIG but
1096         CONFIG does not contain link_pkgconfig.
1097
1098         This is because link_pkgconfig is added in unix/default_pre.prf
1099         which is only used for UNIX platforms. To fix this, move it to
1100         the general default_pre.prf.
1101
1102         Reviewed by Simon Hausmann.
1103
1104         * qmake/mkspecs/features/default_pre.prf:
1105         * qmake/mkspecs/features/unix/default_pre.prf:
1106
1107 2013-01-12  Nico Weber  <thakis@chromium.org>
1108
1109         nrwt/chromium: Don't prefer chromium over webkit build directories
1110         https://bugs.webkit.org/show_bug.cgi?id=105597
1111
1112         Reviewed by Dirk Pranke.
1113
1114         Rely on the new timestamp logic instead. Requested by dpranke in
1115         https://bugs.webkit.org/show_bug.cgi?id=105498
1116
1117         * Scripts/webkitpy/layout_tests/port/chromium.py:
1118         (ChromiumPort._static_build_path):
1119         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1120         (ChromiumLinuxPortTest.test_build_path):
1121         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1122         (ChromiumMacPortTest.test_build_path):
1123         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1124         (ChromiumWinTest.test_build_path):
1125
1126 2013-01-12  Nico Weber  <thakis@chromium.org>
1127
1128         Use ninja by default on Linux for build-webkit --chromium, bot edition
1129         https://bugs.webkit.org/show_bug.cgi?id=104434
1130
1131         Reviewed by Eric Seidel.
1132
1133         r139557 changed update-webkit to pick ninja by default on linux, but
1134         the bots run update-webkit-chromium directly so they didn't see this.
1135         Move the default for ninja into update-webkit-chromium so that it's
1136         picked up by the bots, and let update-webkit forward non-default
1137         options to there.
1138
1139         This way, the default is in one place only and both developers (who
1140         usually use update-webkit which then shells out to
1141         updat-webkit-chromium) and bots (which use update-webkit-chromium
1142         directly) see the same behavior.
1143
1144         * Scripts/update-webkit:
1145         * Scripts/update-webkit-chromium:
1146
1147 2013-01-12  Nico Weber  <thakis@chromium.org>
1148
1149         Make ninja the default build system on Linux for build-webkit --chromium
1150         https://bugs.webkit.org/show_bug.cgi?id=104434
1151
1152         Reviewed by Eric Seidel.
1153
1154         * Scripts/update-webkit:
1155
1156 2013-01-12  Alan Cutter  <alancutter@chromium.org>
1157
1158         Migrate the remaining bots in EC2 to Google Compute Engine
1159         https://bugs.webkit.org/show_bug.cgi?id=106005
1160
1161         Reviewed by Eric Seidel.
1162
1163         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
1164
1165         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
1166         * EWSTools/boot.sh:
1167         * EWSTools/build-repo.sh:
1168         * EWSTools/start-queue.sh:
1169
1170 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
1171
1172         [chromium] move inspector related methods to TestRunner library
1173         https://bugs.webkit.org/show_bug.cgi?id=106654
1174
1175         Reviewed by Adam Barth.
1176
1177         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1178         (DRTTestRunner::DRTTestRunner):
1179         * DumpRenderTree/chromium/DRTTestRunner.h:
1180         (DRTTestRunner):
1181         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1182         (WebTestRunner::WebTestDelegate::showDevTools):
1183         (WebTestRunner::WebTestDelegate::closeDevTools):
1184         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
1185         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1186         (WebTestRunner::TestRunner::TestRunner):
1187         (WebTestRunner::TestRunner::showWebInspector):
1188         (WebTestRunner):
1189         (WebTestRunner::TestRunner::closeWebInspector):
1190         (WebTestRunner::TestRunner::evaluateInWebInspector):
1191         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1192         (TestRunner):
1193         * DumpRenderTree/chromium/WebViewHost.cpp:
1194         (WebViewHost::showDevTools):
1195         (WebViewHost::closeDevTools):
1196         (WebViewHost::evaluateInWebInspector):
1197         * DumpRenderTree/chromium/WebViewHost.h:
1198         (WebViewHost):
1199
1200 2013-01-11  Julie Parent  <jparent@chromium.org>
1201
1202         Builder should not be a valid parameter for stats dashboard
1203         https://bugs.webkit.org/show_bug.cgi?id=106698
1204
1205         Reviewed by Dirk Pranke.
1206         
1207         Since builder is a dashboard specific parameter, dashboard_base
1208         should not be handling it in handleValidHashParameterWrapper, rather,
1209         each specific dashboard should in its handleValidHashParameter function.
1210     
1211         Note that the FIXME in dashboard_base about this was actually wrong -
1212         we don't want to move it to g_crossDashboardState, because it isn't
1213         actually cross dashboard state.
1214         
1215         In fact, flakiness and treemap have the code in 
1216         handleValidHashParameter, but it is currently dead code because 
1217         dashboard_base gets to it first.
1218         
1219         Added the proper handling to timeline_explorer, since builder is
1220         valid there.
1221
1222         * TestResultServer/static-dashboards/dashboard_base.js:
1223         * TestResultServer/static-dashboards/timeline_explorer.html:
1224
1225 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1226
1227         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
1228         https://bugs.webkit.org/show_bug.cgi?id=106688
1229
1230         Reviewed by Eric Seidel.
1231
1232         Update the regular expression used to strip the garbage at the beginning.
1233
1234         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1235         (RunWebKitTests.nrwt_log_message_regexp):
1236
1237 2013-01-11  Pratik Solanki  <psolanki@apple.com>
1238
1239         TestRunner leaks when running tests
1240         https://bugs.webkit.org/show_bug.cgi?id=106683
1241
1242         Reviewed by Simon Fraser.
1243
1244         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
1245         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
1246         tests.
1247
1248         * DumpRenderTree/TestRunner.cpp:
1249         (TestRunner::makeWindowObject):
1250
1251 2013-01-11  Julie Parent  <jparent@chromium.org>
1252
1253         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
1254         https://bugs.webkit.org/show_bug.cgi?id=106247
1255
1256         Old code nulled out the loader instance when it completed loading and
1257         then later used the fact that it was null to determine if it had loaded
1258         or not.  This is not only unintuitive, but it also prevents using the
1259         loader object later on.
1260         
1261         Added new method, used it, added unit test for it.
1262         
1263         Reviewed by Dirk Pranke.
1264
1265         * TestResultServer/static-dashboards/dashboard_base.js:
1266         (resourceLoadingComplete):
1267         (handleLocationChange):
1268         * TestResultServer/static-dashboards/loader.js:
1269         (.):
1270         * TestResultServer/static-dashboards/loader_unittests.js:
1271
1272 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1273
1274         Try CRLF to LF change in r139407 again.
1275
1276         * BuildSlaveSupport/delete-stale-build-files:
1277         (main):
1278         (webkitBuildDirectory):
1279         * BuildSlaveSupport/kill-old-processes:
1280         (main):
1281
1282 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1283
1284         [GTK] Disable the unit tests timeout when running from make check
1285         https://bugs.webkit.org/show_bug.cgi?id=106670
1286
1287         Reviewed by Philippe Normand.
1288
1289         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
1290
1291 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1292
1293         Yet another unreviewed fix after r139431.
1294
1295         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
1296         the correct order.
1297
1298 2013-01-11  Dan Carney  <dcarney@google.com>
1299
1300         [chromium] move some whitespace and resize related methods to TestRunner library
1301         https://bugs.webkit.org/show_bug.cgi?id=106655
1302
1303         Reviewed by Jochen Eisinger.
1304
1305         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1306         (DRTTestRunner::DRTTestRunner):
1307         * DumpRenderTree/chromium/DRTTestRunner.h:
1308         (DRTTestRunner):
1309         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1310         (WebKit):
1311         (WebTestRunner::WebTestDelegate::setClientWindowRect):
1312         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
1313         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
1314         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1315         (WebTestRunner::TestRunner::TestRunner):
1316         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
1317         (WebTestRunner):
1318         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
1319         (WebTestRunner::TestRunner::enableAutoResizeMode):
1320         (WebTestRunner::TestRunner::disableAutoResizeMode):
1321         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1322         (TestRunner):
1323         * DumpRenderTree/chromium/WebViewHost.cpp:
1324         (WebViewHost::setClientWindowRect):
1325         * DumpRenderTree/chromium/WebViewHost.h:
1326         (WebViewHost):
1327
1328 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1329
1330         Unreviewed. Update my e-mail addresses.
1331
1332         * Scripts/webkitpy/common/config/committers.py:
1333
1334 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1335
1336         Another unreviewed fix after r139431.
1337
1338         In a way, this is also a generic bug fix, since previously isEfl()
1339         would fail when called from run-efl-tests and we thus did not use
1340         jhbuild to run our tests. This now resulted in us calling
1341         "jhbuild-wrapper run" without specifying a platform.
1342
1343         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
1344         to work.
1345
1346 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1347
1348         [Qt][WK1] Web Audio support
1349         https://bugs.webkit.org/show_bug.cgi?id=106651
1350
1351         Reviewed by Jocelyn Turcotte.
1352
1353         Implements support for dumping audio data in DumpRenderTree.
1354
1355         Adds WebAudio to toggleable features in QtTestBrowser.
1356
1357         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
1358         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
1359
1360         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1361         (WebCore::DumpRenderTree::dump):
1362         * DumpRenderTree/qt/TestRunnerQt.cpp:
1363         (TestRunner::reset):
1364         (TestRunner::overridePreference):
1365         (TestRunner::setAudioData):
1366         * DumpRenderTree/qt/TestRunnerQt.h:
1367         (TestRunner::shouldDumpAsAudio):
1368         (TestRunner::audioData):
1369         (TestRunner):
1370         * QtTestBrowser/launcherwindow.cpp:
1371         (LauncherWindow::applyPrefs):
1372         (LauncherWindow::createChrome):
1373         (LauncherWindow::toggleWebAudio):
1374         * QtTestBrowser/launcherwindow.h:
1375         (WindowOptions::WindowOptions):
1376         (WindowOptions):
1377         (LauncherWindow):
1378         * qmake/mkspecs/features/features.prf:
1379         * qmake/mkspecs/features/features.pri:
1380
1381 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1382
1383         Unreviewed jhbuild-related fix after r139431.
1384
1385         * Scripts/webkitpy/layout_tests/port/efl.py:
1386         (EflPort.__init__): Pass a string to set_option_default(), since
1387         shlex.split() will be called on it later.
1388
1389 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
1390
1391         Unreviewed typo fixes after r139431.
1392
1393         * Scripts/run-javascriptcore-tests:
1394
1395 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1396
1397         [jhbuild] Remove the "run-with-jhbuild" scripts.
1398         https://bugs.webkit.org/show_bug.cgi?id=106572
1399
1400         Reviewed by Martin Robinson.
1401
1402         Both ports which use jhbuild were mostly duplicating the
1403         `run-with-jhbuild' script in their own directories for no clear reason.
1404
1405         The script itself was just a thin wrapper around the `jhbuild-wrapper',
1406         so just start using that directly and get rid of a useless middle man.
1407
1408         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
1409         instead.
1410
1411         * Scripts/run-javascriptcore-tests:
1412         * Scripts/run-launcher:
1413         * Scripts/webkitdirs.pm:
1414         (runAutogenForAutotoolsProjectIfNecessary):
1415         (buildAutotoolsProject):
1416         (jhbuildWrapperPrefixIfNeeded):
1417         (generateBuildSystemFromCMakeProject):
1418         (buildCMakeGeneratedProject):
1419         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1420         (run):
1421         * Scripts/webkitpy/layout_tests/port/efl.py:
1422         (EflPort.__init__):
1423         (EflPort._image_diff_command):
1424         * efl/run-with-jhbuild: Removed.
1425         * gtk/run-with-jhbuild: Removed.
1426
1427 2013-01-11  Alan Cutter  <alancutter@chromium.org>
1428
1429         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
1430         https://bugs.webkit.org/show_bug.cgi?id=106636
1431
1432         Reviewed by Adam Barth.
1433
1434         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
1435
1436         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1437         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1438         * EWSTools/screen-config:
1439         * EWSTools/start-queue.sh:
1440
1441 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1442
1443         kill-old-processes and delete-stale-build-files use CRLF linebreaks
1444         https://bugs.webkit.org/show_bug.cgi?id=106622
1445
1446         Reviewed by Simon Fraser.
1447
1448         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
1449         Also escape clang\+\+ correctly in kill-old-processes.
1450
1451         * BuildSlaveSupport/delete-stale-build-files:
1452         * BuildSlaveSupport/kill-old-processes:
1453
1454 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1455
1456         Build fix after r139357. It was missing a comma.
1457
1458         * QueueStatusServer/model/queues.py:
1459         (Queue):
1460
1461 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1462
1463         Fixing AuthenticationError when running test-webkitpy as a non-committer.
1464         https://bugs.webkit.org/show_bug.cgi?id=106420
1465
1466         Reviewed by Eric Seidel.
1467
1468         * Scripts/webkitpy/common/checkout/scm/git.py:
1469         (Git.push_local_commits_to_server):
1470         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1471         * Scripts/webkitpy/common/checkout/scm/svn.py:
1472         (SVNRepository):
1473         (SVNRepository.has_authorization_for_realm):
1474
1475 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
1476
1477         [EFL][jhbuild] Use tarballs for gstreamer instead of git
1478         https://bugs.webkit.org/show_bug.cgi?id=106552
1479
1480         Reviewed by Laszlo Gombos.
1481
1482         Use tarballs for gstreamer instead of git in EFL's jhbuild
1483         to work around intermittent network issues on our build
1484         bots. Tarballs are fully cached and require no network
1485         operation if their checksum matches.
1486
1487         * efl/jhbuild.modules:
1488
1489 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1490
1491         Add Mac WK2 EWS bots
1492         https://bugs.webkit.org/show_bug.cgi?id=106590
1493
1494         Reviewed by Adam Barth.
1495
1496         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
1497         Also add a deprecated MacWK2Port class.
1498
1499         * QueueStatusServer/model/queues.py:
1500         (Queue):
1501         * Scripts/webkitpy/common/config/ports.py:
1502         (DeprecatedPort.port):
1503         (MacWK2Port):
1504         (MacWK2Port.run_webkit_tests_command):
1505         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1506         (MacEWS):
1507         (MacWK2EWS):
1508         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1509         (_test_ewses):
1510
1511 2013-01-10  Dan Carney  <dcarney@google.com>
1512
1513         [chromium] move webpermissionclient related methods to TestRunner library
1514         https://bugs.webkit.org/show_bug.cgi?id=106548
1515
1516         Reviewed by Jochen Eisinger.
1517
1518         * DumpRenderTree/DumpRenderTree.gypi:
1519         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1520         (DRTTestRunner::DRTTestRunner):
1521         (DRTTestRunner::reset):
1522         * DumpRenderTree/chromium/DRTTestRunner.h:
1523         (DRTTestRunner):
1524         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1525         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
1526         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1527         (WebKit):
1528         (WebTestRunner::WebTestRunner::webPermissions):
1529         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1530         (WebTestRunner::TestRunner::TestRunner):
1531         (WebTestRunner::TestRunner::setDelegate):
1532         (WebTestRunner):
1533         (WebTestRunner::TestRunner::reset):
1534         (WebTestRunner::TestRunner::webPermissions):
1535         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
1536         (WebTestRunner::TestRunner::setImagesAllowed):
1537         (WebTestRunner::TestRunner::setScriptsAllowed):
1538         (WebTestRunner::TestRunner::setStorageAllowed):
1539         (WebTestRunner::TestRunner::setPluginsAllowed):
1540         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
1541         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
1542         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1543         (WebTestRunner):
1544         (TestRunner):
1545         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
1546         (WebTestRunner):
1547         (WebTestRunner::WebPermissions::WebPermissions):
1548         (WebTestRunner::WebPermissions::~WebPermissions):
1549         (WebTestRunner::WebPermissions::allowImage):
1550         (WebTestRunner::WebPermissions::allowScriptFromSource):
1551         (WebTestRunner::WebPermissions::allowStorage):
1552         (WebTestRunner::WebPermissions::allowPlugins):
1553         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
1554         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
1555         (WebTestRunner::WebPermissions::setImagesAllowed):
1556         (WebTestRunner::WebPermissions::setScriptsAllowed):
1557         (WebTestRunner::WebPermissions::setStorageAllowed):
1558         (WebTestRunner::WebPermissions::setPluginsAllowed):
1559         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
1560         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
1561         (WebTestRunner::WebPermissions::setDelegate):
1562         (WebTestRunner::WebPermissions::setDumpCallbacks):
1563         (WebTestRunner::WebPermissions::reset):
1564         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
1565         (WebTestRunner):
1566         (WebPermissions):
1567         * DumpRenderTree/chromium/TestShell.cpp:
1568         (TestShell::initialize):
1569         (TestShell::resetTestController):
1570         (TestShell::createNewWindow):
1571         * DumpRenderTree/chromium/TestShell.h:
1572         (TestShell):
1573         * DumpRenderTree/chromium/WebViewHost.cpp:
1574         (WebViewHost::normalizeLayoutTestURL):
1575         * DumpRenderTree/chromium/WebViewHost.h:
1576         (WebViewHost):
1577
1578 2013-01-10  Alan Cutter  <alancutter@chromium.org>
1579
1580         Split EWS tool cold-boot.sh into modular components
1581         https://bugs.webkit.org/show_bug.cgi?id=106527
1582
1583         Reviewed by Adam Barth.
1584
1585         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
1586         Updated GCE bot build scripts to match.
1587         Unable to test scripts directly as they depend on being in the repository to work!
1588
1589         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1590         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1591         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
1592         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
1593         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
1594
1595 2013-01-10  Julie Parent  <jparent@chromium.org>
1596
1597         Dashboard Cleanup: Do not generate the page if we are about to reload.
1598         https://bugs.webkit.org/show_bug.cgi?id=106584
1599
1600         Reviewed by Dirk Pranke.
1601
1602         Move the logic to determine if we should generate the page into
1603         parseParameters() since that is where we have the knowledge to
1604         determine it, and return that value to handleLocationChange, 
1605         rather than passing the changed parameters back to handleLocationChange
1606         and having it make the decision.
1607         
1608         This is logically equivalent, save one case: when we are about to do
1609         a reload, we know that there is no reason to generate the page.  Old
1610         code was causing an extra page generation in this case.
1611         
1612         * TestResultServer/static-dashboards/dashboard_base.js:
1613         (parseParameters):
1614         (handleLocationChange):
1615
1616 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1617
1618         [jhbuild] Use the "configure" script to build glib
1619         https://bugs.webkit.org/show_bug.cgi?id=106569
1620
1621         Reviewed by Martin Robinson.
1622
1623         So far both EFL and GTK have been using autogen.sh to build glib.
1624         While that does work most of the time, it's not really needed since
1625         we are downloading and building stable releases from tarballs.
1626         Additionally, autogen.sh fails to work with automake 1.13 due to the
1627         usage of some macros that have been removed (this has already been
1628         fixed in glib master).
1629
1630         * efl/jhbuild.modules:
1631         * gtk/jhbuild.modules:
1632
1633 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1634
1635         Changing tests to be consistent and use self.scm rather then recreating the scm object.
1636         (Missed a couple)
1637         https://bugs.webkit.org/show_bug.cgi?id=106536
1638
1639         Reviewed by Eric Seidel.
1640
1641         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1642
1643 2013-01-10  Tony Chang  <tony@chromium.org>
1644
1645         Speed up supplemental dependency computation
1646         https://bugs.webkit.org/show_bug.cgi?id=106503
1647
1648         Reviewed by Adam Barth.
1649
1650         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
1651
1652         * WebKitTestRunner/CMakeLists.txt:
1653
1654 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
1655
1656         Remove the ENABLE_ANIMATION_API feature define occurences
1657         https://bugs.webkit.org/show_bug.cgi?id=106544
1658
1659         Reviewed by Simon Fraser.
1660
1661         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
1662         feature define handling still lingers in various build systems and configurations
1663         but is of no use, so it should be removed.
1664
1665         * Scripts/webkitperl/FeatureList.pm:
1666         * qmake/mkspecs/features/features.pri:
1667
1668 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1669
1670         [GTK] Add support for loading web process extensions
1671         https://bugs.webkit.org/show_bug.cgi?id=105631
1672
1673         Reviewed by Gustavo Noronha Silva.
1674
1675         * MiniBrowser/gtk/GNUmakefile.am:
1676         * MiniBrowser/gtk/main.c:
1677         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
1678         bundle lib from build dir.
1679         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
1680         located in WebProcess/InjectedBundle/API/gtk.
1681         * gtk/generate-gtkdoc:
1682         (get_webkit2_options): Scan also files in
1683         WebProcess/InjectedBundle/API/gtk to generate API docs.
1684         (get_webkit2_options.injected_bundle_src_path): Helper function to
1685         build paths in WebProcess/InjectedBundle/API/gtk.
1686
1687 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1688
1689         [EFL][WK2] Writing immediately to created windows (open) fails
1690         https://bugs.webkit.org/show_bug.cgi?id=105276
1691
1692         Reviewed by Kenneth Rohde Christiansen.
1693
1694         Do not reset 'about:blank' url for the new pages in mini browser.
1695
1696         * MiniBrowser/efl/main.c:
1697         (window_create):
1698
1699 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1700
1701         Changing tests to be consistent and use self.scm rather then recreating the scm object.
1702         https://bugs.webkit.org/show_bug.cgi?id=106536
1703
1704         Reviewed by Eric Seidel.
1705
1706         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1707
1708 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1709
1710         Converting to unittest2 so we can use assertItemsEqual, making tests
1711         not dependent on order of items.
1712         https://bugs.webkit.org/show_bug.cgi?id=106532
1713
1714         Before:
1715         Ran 1733 tests in 38.385s
1716         FAILED (failures=1, errors=22)
1717
1718         After:
1719         Ran 1733 tests in 32.298s
1720         FAILED (failures=0, errors=22)
1721
1722         Reviewed by Eric Seidel.
1723
1724         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1725         * Scripts/webkitpy/thirdparty/__init__.py:
1726         (AutoinstallImportHook._install_unittest2):
1727
1728 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
1729
1730         [EFL] Add gstreamer 1.0.5 to jhbuild
1731         https://bugs.webkit.org/show_bug.cgi?id=106178
1732
1733         Reviewed by Laszlo Gombos.
1734
1735         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
1736
1737         * efl/jhbuild.modules:
1738
1739 2013-01-09  Alan Cutter  <alancutter@chromium.org>
1740
1741         Updated parameters in GCE build scripts so they now work.
1742         https://bugs.webkit.org/show_bug.cgi?id=106523
1743
1744         Reviewed by Adam Barth.
1745
1746         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1747         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1748         * EWSTools/cold-boot.sh:
1749
1750 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
1751
1752         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
1753         https://bugs.webkit.org/show_bug.cgi?id=106520
1754
1755         Reviewed by James Robinson.
1756
1757         Part of a larger refactoring series. See tracking bug 82948.
1758
1759         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1760         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1761
1762 2013-01-09  Julie Parent  <jparent@chromium.org>
1763
1764         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
1765         https://bugs.webkit.org/show_bug.cgi?id=106514
1766
1767         This is old code, as these can no longer get out of sync.
1768         permmaLinkURLHash is generated from currentState, which is set only
1769         from the location.  The commment about how these can get out of sync
1770         refers to a function that no longer exists.
1771         
1772         Reviewed by Dirk Pranke.
1773
1774         * TestResultServer/static-dashboards/dashboard_base.js:
1775         (handleLocationChange):
1776
1777 2013-01-09  Julie Parent  <jparent@chromium.org>
1778
1779         Dashboard Cleanup: Reload the page as soon as we know we need to.
1780         https://bugs.webkit.org/show_bug.cgi?id=106515
1781
1782         No need to continue parsing all of the data once we know that
1783         we need to do a reload.
1784         
1785         Reviewed by Dirk Pranke.
1786
1787         * TestResultServer/static-dashboards/dashboard_base.js:
1788         (parseParameters):
1789
1790 2013-01-09  Eric Seidel  <eric@webkit.org>
1791
1792         run-perf-tests --chromium-android --profile should show symbols for the kernel
1793         https://bugs.webkit.org/show_bug.cgi?id=106498
1794
1795         Reviewed by Adam Barth.
1796
1797         Turns out this was easy, once I finally read the output from "perf report".
1798         It appears there may be a bug in "perf record" on android, as it complains
1799         about not being able to read from /proc/kallsyms even when
1800         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
1801         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
1802         but rather just flip it to 0 long enough to grab the /proc/kallsyms
1803         and then flip it back to whatever the device had.
1804
1805         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
1806         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
1807         to symbol names.  Its world-readable, but will return all 0s if you
1808         don't have permission to see the kernel symbols.  kptr_restrict
1809         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
1810         1 is only a specific group, and 2 is "no one, not even root".
1811         By default kptr_restrict is 2 on Android it seems.
1812         More kptr_restrict docs: http://lwn.net/Articles/420403/
1813
1814         I also took this opportunity to clean up how the perf record command
1815         was built for use/display in AndroidPerf.profile_after_exit and
1816         change to always using long-form names for the arguments (to hopefully help readability).
1817
1818         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1819         (AndroidPerf.__init__):
1820         (profile_after_exit):
1821         (ChromiumAndroidDriver.__init__):
1822         (ChromiumAndroidDriver._update_kallsyms_cache):
1823         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1824
1825 2013-01-09  Julie Parent  <jparent@chromium.org>
1826
1827         Dashboard cleanup: remove dead code.
1828         https://bugs.webkit.org/show_bug.cgi?id=106509
1829
1830         Reviewed by Dirk Pranke.
1831
1832         * TestResultServer/static-dashboards/dashboard_base.js:
1833         (parseParameters):
1834
1835 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
1836
1837         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
1838         https://bugs.webkit.org/show_bug.cgi?id=105638
1839
1840         Reviewed by Martin Robinson.
1841
1842         The test was failing for two reasons:
1843         - AccessibilityRenderObject::correspondingLabelForControlElement() was
1844           not ignoring the ARIA labelled-by property
1845         - AccessibilityController::accessibleElementById() was not implemented
1846
1847         Because getting an element by ID cannot be done in the UIProcess, the
1848         decision was made to expose the element's ID as an accessible attribute
1849         of the object.
1850
1851         In addition, fixing the bug in AccessibilityRenderObject made it possible
1852         to eliminate the Gtk platform-specific expectations for another test.
1853
1854         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1855         (childElementById): Added. Walks the tree looking for the AtkObject
1856         Attribute which exposes the HTML element's ID.
1857         (AccessibilityController::accessibleElementById): Implemented.
1858         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1859         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
1860         when there is no title, as is done with the Mac port.
1861         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1862         (WTR):
1863         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1864         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
1865         Attribute which exposes the HTML element's ID.
1866         (WTR):
1867         (WTR::AccessibilityController::accessibleElementById): Implemented.
1868         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1869         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
1870         even when there is no title, as is done with the Mac port.
1871
1872 2013-01-09  Gregg Tavares  <gman@google.com>
1873
1874         Add Gregg Tavares as a committer
1875         https://bugs.webkit.org/show_bug.cgi?id=106492
1876
1877         Unreviewed.
1878
1879         * Scripts/webkitpy/common/config/committers.py:
1880
1881 2013-01-09  Roger Fong  <roger_fong@apple.com>
1882
1883         Enable seamless iFrames for Windows DRT.
1884         https://bugs.webkit.org/show_bug.cgi?id=106468.
1885
1886         Rubberstamped by Timothy Horton.
1887
1888         * DumpRenderTree/win/DumpRenderTree.cpp:
1889         (resetDefaultsToConsistentValues):
1890
1891 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
1892
1893         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
1894         https://bugs.webkit.org/show_bug.cgi?id=93979
1895
1896         Reviewed by Benjamin Poulain.
1897
1898         Implement eventSender.scheduleAsynchronousKeyDown() in
1899         WebKitTestRunner.
1900
1901         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1902         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1903         (WTR::createKeyDownMessageBody):
1904         (WTR::EventSendingController::keyDown):
1905         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1906         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1907         (EventSendingController):
1908         * WebKitTestRunner/TestController.cpp:
1909         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
1910         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1911         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1912         * WebKitTestRunner/TestController.h:
1913         (TestController):
1914
1915 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
1916
1917         [chromium] move resource load callback dumping to TestRunner library
1918         https://bugs.webkit.org/show_bug.cgi?id=106449
1919
1920         Reviewed by Adam Barth.
1921
1922         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1923         (DRTTestRunner::DRTTestRunner):
1924         (DRTTestRunner::reset):
1925         * DumpRenderTree/chromium/DRTTestRunner.h:
1926         (DRTTestRunner):
1927         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1928         (WebKit):
1929         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
1930         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1931         (WebKit):
1932         (WebTestProxyBase):
1933         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
1934         (WebTestRunner::WebTestProxy::willRequestResource):
1935         (WebTestRunner::WebTestProxy::willSendRequest):
1936         (WebTestRunner::WebTestProxy::didReceiveResponse):
1937         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
1938         (WebTestRunner::WebTestProxy::didFailResourceLoad):
1939         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1940         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
1941         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
1942         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
1943         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1944         (WebTestRunner::TestRunner::TestRunner):
1945         (WebTestRunner::TestRunner::reset):
1946         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
1947         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
1948         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
1949         (WebTestRunner):
1950         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
1951         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
1952         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
1953         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1954         (TestRunner):
1955         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1956         (WebTestRunner::WebTestProxyBase::reset):
1957         (WebTestRunner):
1958         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
1959         (WebTestRunner::WebTestProxyBase::willRequestResource):
1960         (WebTestRunner::WebTestProxyBase::willSendRequest):
1961         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
1962         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
1963         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
1964         * DumpRenderTree/chromium/WebViewHost.cpp:
1965         (WebViewHost::willSendRequest):
1966         (WebViewHost::makeURLErrorDescription):
1967         (WebViewHost::reset):
1968         * DumpRenderTree/chromium/WebViewHost.h:
1969         (WebViewHost):
1970
1971 2013-01-09  Dan Carney  <dcarney@google.com>
1972
1973         [chromium] move dumpcreateview methods to testrunner library
1974         https://bugs.webkit.org/show_bug.cgi?id=106434
1975
1976         Reviewed by Adam Barth.
1977
1978         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1979         (DRTTestRunner::DRTTestRunner):
1980         (DRTTestRunner::reset):
1981         * DumpRenderTree/chromium/DRTTestRunner.h:
1982         (DRTTestRunner):
1983         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1984         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
1985         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1986         (WebTestRunner::TestRunner::TestRunner):
1987         (WebTestRunner::TestRunner::reset):
1988         (WebTestRunner::TestRunner::shouldDumpCreateView):
1989         (WebTestRunner):
1990         (WebTestRunner::TestRunner::dumpCreateView):
1991         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1992         (TestRunner):
1993
1994 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
1995
1996         webkitpy cleanup: Merge additional_comment_text into comment_text
1997         https://bugs.webkit.org/show_bug.cgi?id=106421
1998
1999         Reviewed by Adam Barth.
2000
2001         * Scripts/webkitpy/common/config/committervalidator.py:
2002         (CommitterValidator.reject_patch_from_commit_queue):
2003         (CommitterValidator.reject_patch_from_review_queue):
2004         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2005         (Bugzilla.set_flag_on_attachment):
2006         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2007         (MockBugzilla.set_flag_on_attachment):
2008         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2009         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2010         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
2011         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2012
2013 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
2014
2015         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
2016         https://bugs.webkit.org/show_bug.cgi?id=106464
2017
2018         Reviewed by Martin Robinson.
2019
2020         Current version in jhbuild.modules (2.26.0) is giving trouble to
2021         when trying to build WebKitGTK from scratch, due to a segmentation
2022         fault error in gdk-pixbuf-query-loader during the 'make'
2023         phase. Raising the version to 2.26.5 fixes this issue.
2024
2025         * gtk/jhbuild.modules: Version raised, checksums updated.
2026
2027 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
2028
2029         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
2030         https://bugs.webkit.org/show_bug.cgi?id=90968.
2031
2032         Reviewed by Csaba Osztrogonác.
2033
2034         Added functionality in DRT and WTR to use any timeout value while running
2035         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
2036         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
2037         to indicate whether the current port supports setting timeout value
2038         per test (it's False by default; I enabled it only on Qt).
2039         Also corrected a typo in driver.py
2040
2041         * DumpRenderTree/DumpRenderTree.h:
2042         (TestCommand::TestCommand):
2043         (TestCommand):
2044         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2045         (parseInputLine):
2046         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2047         (WebCore::DumpRenderTree::processLine):
2048         * Scripts/webkitpy/layout_tests/port/base.py:
2049         (Port.supports_per_test_timeout):
2050         * Scripts/webkitpy/layout_tests/port/driver.py:
2051         (Driver.run_test):
2052         (Driver._command_from_driver_input):
2053         * Scripts/webkitpy/layout_tests/port/qt.py:
2054         (QtPort.supports_per_test_timeout):
2055         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2056         (WTR::InjectedBundle::InjectedBundle):
2057         (WTR::InjectedBundle::didReceiveMessage):
2058         (WTR::InjectedBundle::beginTesting):
2059         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2060         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2061         (WTR::TestRunner::setCustomTimeout):
2062         (WTR):
2063         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2064         (TestRunner):
2065         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
2066         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2067         * WebKitTestRunner/TestController.cpp:
2068         (WTR::TestController::TestController):
2069         (WTR::TestController::getCustomTimeout):
2070         (WTR):
2071         (WTR::TestCommand::TestCommand):
2072         (TestCommand):
2073         (WTR::parseInputLine):
2074         (WTR::TestController::runTest):
2075         (WTR::TestController::runUntil):
2076         * WebKitTestRunner/TestController.h:
2077         (TestController):
2078         * WebKitTestRunner/TestInvocation.cpp:
2079         (WTR::TestInvocation::TestInvocation):
2080         (WTR::TestInvocation::setCustomTimeout):
2081         (WTR):
2082         (WTR::TestInvocation::invoke):
2083         * WebKitTestRunner/TestInvocation.h:
2084         (TestInvocation):
2085
2086 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2087
2088         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
2089         https://bugs.webkit.org/show_bug.cgi?id=106290
2090
2091         Reviewed by Martin Robinson.
2092
2093         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
2094         the macro isn't enabled.
2095
2096         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2097
2098 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
2099
2100         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
2101         https://bugs.webkit.org/show_bug.cgi?id=103653
2102
2103         Reviewed by Anders Carlsson.
2104
2105         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
2106         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
2107         client callback.
2108
2109         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
2110         methods to the JavaScript API.
2111         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2112         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
2113         (WTR::TestRunner::setAuthenticationUsername): Ditto.
2114         (WTR::TestRunner::setAuthenticationPassword): Ditto.
2115         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2116         (TestRunner): Added new declarations for the above.
2117         * WebKitTestRunner/TestController.cpp:
2118         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
2119         callback.
2120         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
2121         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
2122         the authentication information passed from the InjectedBundle.
2123         * WebKitTestRunner/TestController.h:
2124         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
2125         to communicate with the TestController.
2126         (WTR::TestController::setAuthenticationUsername): Ditto.
2127         (WTR::TestController::setAuthenticationPassword): Ditto.
2128         (TestController):
2129         * WebKitTestRunner/TestInvocation.cpp:
2130         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
2131         information from the InjectedBundle.
2132         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
2133         text to the TestInvocation text output.
2134         * WebKitTestRunner/TestInvocation.h:
2135         (TestInvocation): Added declaration for new method.
2136
2137 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
2138
2139         Add myself as a watcher for Web Geolocation
2140
2141         Unreviewed.
2142
2143         * Scripts/webkitpy/common/config/watchlist:
2144
2145 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2146
2147         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
2148         https://bugs.webkit.org/show_bug.cgi?id=106364
2149
2150         Reviewed by Eric Seidel.
2151
2152         When the setup_test_run method is called on the subclasses of the base Port
2153         interface, the parent method should also be called via super(), despite the
2154         parent method not doing anything at the moment.
2155
2156         The according calls to super() are required in the ChromiumPort, EflPort
2157         and GtkPort implementations.
2158
2159         * Scripts/webkitpy/layout_tests/port/chromium.py:
2160         (ChromiumPort.setup_test_run):
2161         * Scripts/webkitpy/layout_tests/port/efl.py:
2162         (EflPort.setup_test_run):
2163         * Scripts/webkitpy/layout_tests/port/gtk.py:
2164         (GtkPort.setup_test_run):
2165
2166 2013-01-08  Julie Parent  <jparent@chromium.org>
2167
2168         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
2169         https://bugs.webkit.org/show_bug.cgi?id=106356
2170
2171         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
2172         dashboard_base, assigned by Loader, and used only by dashboard_base to
2173         create error messages.  Moved the variables to be privates on the Loader
2174         object, moved error message creation to _getLoadingErrorMessages on the
2175         Loader object, and now pass the errors back to dashboard base via the
2176         resourceLoadingComplete callback.
2177         
2178         Also removed the now unused clearError function, it was only being used
2179         by unit tests to clean up global state.
2180         
2181         Reviewed by Dirk Pranke.
2182
2183         * TestResultServer/static-dashboards/dashboard_base.js:
2184         (resourceLoadingComplete):
2185         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2186         * TestResultServer/static-dashboards/loader.js:
2187         (.):
2188         * TestResultServer/static-dashboards/loader_unittests.js:
2189
2190 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2191
2192         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
2193         https://bugs.webkit.org/show_bug.cgi?id=106354
2194
2195         Reviewed by Eric Seidel.
2196
2197         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
2198         instead of those two inheriting from it. Also add a mock object of the
2199         sanitizer that's used in unit tests.
2200
2201         * Scripts/webkitpy/layout_tests/port/efl.py:
2202         (EflPort):
2203         (EflPort.__init__):
2204         (EflPort.setup_test_run):
2205         (EflPort.clean_up_test_run):
2206         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
2207         importing order.
2208         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
2209         * Scripts/webkitpy/layout_tests/port/gtk.py:
2210         (GtkPort):
2211         (GtkPort.__init__):
2212         (GtkPort.setup_test_run):
2213         (GtkPort.clean_up_test_run):
2214         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
2215         importing order.
2216         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
2217         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
2218         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
2219         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
2220         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
2221         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
2222         (PulseAudioSanitizerMock.unload_pulseaudio_module):
2223         (PulseAudioSanitizerMock.restore_pulseaudio_module):
2224
2225 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
2226
2227         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
2228         https://bugs.webkit.org/show_bug.cgi?id=106324
2229
2230         Reviewed by Adam Barth.
2231
2232         Since the frame load callbacks are part of the WebFrameClient, the
2233         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
2234         methods.
2235
2236         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2237         (DRTTestRunner::DRTTestRunner):
2238         (DRTTestRunner::reset):
2239         * DumpRenderTree/chromium/DRTTestRunner.h:
2240         (DRTTestRunner):
2241         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2242         (WebTestInterfaces):
2243         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2244         (WebKit):
2245         (WebTestProxyBase):
2246         (WebTestRunner):
2247         (WebTestRunner::WebTestProxy::WebTestProxy):
2248         (WebTestProxy):
2249         (WebTestRunner::WebTestProxy::didInvalidateRect):
2250         (WebTestRunner::WebTestProxy::didScrollRect):
2251         (WebTestRunner::WebTestProxy::scheduleComposite):
2252         (WebTestRunner::WebTestProxy::scheduleAnimation):
2253         (WebTestRunner::WebTestProxy::setWindowRect):
2254         (WebTestRunner::WebTestProxy::show):
2255         (WebTestRunner::WebTestProxy::didAutoResize):
2256         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
2257         (WebTestRunner::WebTestProxy::startDragging):
2258         (WebTestRunner::WebTestProxy::shouldBeginEditing):
2259         (WebTestRunner::WebTestProxy::shouldEndEditing):
2260         (WebTestRunner::WebTestProxy::shouldInsertNode):
2261         (WebTestRunner::WebTestProxy::shouldInsertText):
2262         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
2263         (WebTestRunner::WebTestProxy::shouldDeleteRange):
2264         (WebTestRunner::WebTestProxy::shouldApplyStyle):
2265         (WebTestRunner::WebTestProxy::didBeginEditing):
2266         (WebTestRunner::WebTestProxy::didChangeSelection):
2267         (WebTestRunner::WebTestProxy::didChangeContents):
2268         (WebTestRunner::WebTestProxy::didEndEditing):
2269         (WebTestRunner::WebTestProxy::registerIntentService):
2270         (WebTestRunner::WebTestProxy::dispatchIntent):
2271         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
2272         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
2273         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
2274         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
2275         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
2276         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
2277         (WebTestRunner::WebTestProxy::didReceiveTitle):
2278         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
2279         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
2280         (WebTestRunner::WebTestProxy::didFailLoad):
2281         (WebTestRunner::WebTestProxy::didFinishLoad):
2282         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
2283         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
2284         (WebTestRunner::WebTestProxy::didRunInsecureContent):
2285         (WebTestRunner::WebTestProxy::didDetectXSS):
2286         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2287         (WebTestRunner::WebTestRunner::setTestIsRunning):
2288         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
2289         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
2290         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
2291         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
2292         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
2293         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2294         (WebTestRunner::TestRunner::TestRunner):
2295         (WebTestRunner::TestRunner::reset):
2296         (WebTestRunner::TestRunner::setTestIsRunning):
2297         (WebTestRunner):
2298         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
2299         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
2300         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
2301         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
2302         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
2303         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
2304         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
2305         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
2306         (WebTestRunner::TestRunner::dumpTitleChanges):
2307         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2308         (TestRunner):
2309         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2310         (WebTestInterfaces::Internal):
2311         (WebTestRunner::WebTestInterfaces::Internal::webView):
2312         (WebTestRunner::WebTestInterfaces::Internal::Internal):
2313         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
2314         (WebTestRunner):
2315         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
2316         (WebTestRunner::WebTestInterfaces::setWebView):
2317         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
2318         (WebTestRunner::WebTestInterfaces::webView):
2319         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2320         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
2321         (WebTestRunner):
2322         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
2323         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
2324         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
2325         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
2326         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
2327         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2328         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
2329         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
2330         (WebTestRunner::WebTestProxyBase::didFailLoad):
2331         (WebTestRunner::WebTestProxyBase::didFinishLoad):
2332         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
2333         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
2334         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
2335         (WebTestRunner::WebTestProxyBase::didDetectXSS):
2336         * DumpRenderTree/chromium/TestShell.cpp:
2337         (TestShell::runFileTest):
2338         (TestShell::testFinished):
2339         * DumpRenderTree/chromium/TestShell.h:
2340         (TestShell):
2341         * DumpRenderTree/chromium/WebViewHost.cpp:
2342         (WebViewHost::didStartProvisionalLoad):
2343         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
2344         (WebViewHost::didFailProvisionalLoad):
2345         (WebViewHost::didCommitProvisionalLoad):
2346         (WebViewHost::didReceiveTitle):
2347         (WebViewHost::didFailLoad):
2348         (WebViewHost::didFinishLoad):
2349         * DumpRenderTree/chromium/WebViewHost.h:
2350         (WebViewHost):
2351
2352 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2353
2354         [GTK] Lower the default timeout value for WebKitTestRunner
2355         https://bugs.webkit.org/show_bug.cgi?id=106353
2356
2357         Reviewed by Dirk Pranke.
2358
2359         The default timeout value for WebKitTestRunner should be lowered.
2360         The current value (80 seconds) is irrational and just leads to producing
2361         text failures for layout tests that genuinely time out. This just leads
2362         to more deviation from the GTK WK1 port in terms of test expectations.
2363
2364         The value used is the same as when running the DumpRenderTree, that's
2365         6 seconds in release builds and 12 seconds in debug builds.
2366
2367         * Scripts/webkitpy/layout_tests/port/gtk.py:
2368         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2369         (GtkPortTest.test_default_timeout_ms):
2370
2371 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2372
2373         test-webkitpy shows failure output on my linux box
2374         https://bugs.webkit.org/show_bug.cgi?id=101261
2375
2376         Reviewed by Eric Seidel.
2377
2378         Mock out the PulseAudioSanitizer methods when creating testing instances
2379         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
2380         PulseAudio output when the sanitizer was trying to unload modules which
2381         were already unloaded by another unit test that was being run in parallel.
2382
2383         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2384         (EflPortTest):
2385         (EflPortTest.make_port):
2386         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2387         (GtkPortTest):
2388         (GtkPortTest.make_port):
2389
2390 2013-01-08  Julie Parent  <jparent@chromium.org>
2391
2392         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
2393         https://bugs.webkit.org/show_bug.cgi?id=106254
2394
2395         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
2396         only to figure out if we should call addBuilderLoadErrors during
2397         handleLocationChange, which was called when the loader completed and on
2398         any hash change, but we only ever wanted to call addBuilderLoadErrors
2399         on the initial loader load.  Moved the call of addBuilderLoadErrors to
2400         resourceLoadingComplete rather than handleLocationChange, so now we
2401         only call it when we want to, and the check can go away completely.
2402
2403         Reviewed by Dirk Pranke.
2404
2405         * TestResultServer/static-dashboards/dashboard_base.js:
2406         (addBuilderLoadErrors):
2407         (resourceLoadingComplete):
2408         (handleLocationChange):
2409         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2410
2411 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
2412
2413         Add aboxhall@chromium.org to accessibility watchlist.
2414
2415         Unreviewed.
2416
2417         * Scripts/webkitpy/common/config/watchlist:
2418
2419 2013-01-08  Dan Winship  <danw@gnome.org>
2420
2421         Add Apache 2.4 support for Fedora 18
2422         https://bugs.webkit.org/show_bug.cgi?id=104478
2423
2424         Reviewed by Martin Robinson.
2425
2426         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
2427         need a separate config.
2428
2429         * Scripts/webkitpy/layout_tests/port/base.py:
2430         (Port._apache_version):
2431         (Port._apache_config_file_name_for_platform):
2432         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2433         * Scripts/run-webkit-httpd:
2434         * Scripts/webkitperl/httpd.pm:
2435         (getApacheVersion):
2436         (getDefaultConfigForTestDirectory):
2437         (getHTTPDConfigPathForTestDirectory):
2438
2439 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2440
2441         Make the override-feature-defines script compatible with Python v3
2442         https://bugs.webkit.org/show_bug.cgi?id=105742
2443
2444         Reviewed by Martin Robinson.
2445
2446         Instead of printing output through a statement, use the print function and format
2447         the output using the str.format method. This makes the script runnable with Python v3.
2448
2449         * gtk/override-feature-defines:
2450         (adjust_feature_defines_makefile):
2451
2452 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
2453
2454         [Qt] Fix libxml2 config test
2455         https://bugs.webkit.org/show_bug.cgi?id=106317
2456
2457         Reviewed by Simon Hausmann.
2458
2459         Don't assume standard include/libxml2, libxml-2.0.pc should know
2460         where it's headers are.
2461
2462         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
2463
2464 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2465
2466         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
2467         https://bugs.webkit.org/show_bug.cgi?id=106195
2468
2469         Reviewed by Philippe Normand.
2470
2471         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
2472         to make the Python code compatible with Python 3. This includes modifying
2473         print statements, exception handling, dictionary iteration and
2474         byte-sequence-to-string conversion.
2475
2476         * gtk/common.py:
2477         (get_build_path):
2478         (pkg_config_file_variable):
2479         (gtk_version_of_pkg_config_file):
2480         * gtk/generate-gtkdoc:
2481         (print_missing_api):
2482         * gtk/gtkdoc.py:
2483         (GTKDoc.__init__):
2484         (GTKDoc._run_command):
2485
2486 2013-01-02  Steve Block  <steveblock@chromium.org>
2487
2488         Add chromium.org email address for Steve Block.
2489
2490         Unreviewed.
2491
2492         * Scripts/webkitpy/common/config/committers.py:
2493
2494 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
2495
2496         Rationalize closure call heuristics and profiling
2497         https://bugs.webkit.org/show_bug.cgi?id=106270
2498
2499         Reviewed by Oliver Hunt.
2500         
2501         Add ability to use display-profiler-output via a pipe, and add the ability to dump
2502         all generated code ('display *' or 'd *').
2503
2504         * Scripts/display-profiler-output:
2505
2506 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2507
2508         Sorted more xcodeproj files.
2509
2510         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2512         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2513
2514 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2515
2516         Sorted xcodeproj files.
2517
2518         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2519         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2520
2521 2013-01-07  Dan Bernstein  <mitz@apple.com>
2522
2523         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
2524         https://bugs.webkit.org/show_bug.cgi?id=106261
2525
2526         Reviewed by Simon Fraser.
2527
2528         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
2529
2530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2531         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
2532         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
2533         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
2534         (TestWebKitAPI):
2535         (TestWebKitAPI::TEST):
2536
2537 2013-01-07  Ojan Vafai  <ojan@chromium.org>
2538
2539         Add the Apple MountainLion bots to garden-o-matic.
2540         Eventually, we really should move away from hardcoding
2541         the list of bots.
2542
2543         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2544
2545 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
2546
2547         [chromium] move web audio related methods to testrunner library
2548         https://bugs.webkit.org/show_bug.cgi?id=106211
2549
2550         Reviewed by Adam Barth.
2551
2552         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2553         (DRTTestRunner::DRTTestRunner):
2554         (DRTTestRunner::reset):
2555         * DumpRenderTree/chromium/DRTTestRunner.h:
2556         (DRTTestRunner):
2557         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2558         (WebKit):
2559         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
2560         (WebTestRunner::WebTestRunner::audioData):
2561         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2562         (WebTestRunner::TestRunner::TestRunner):
2563         (WebTestRunner::TestRunner::reset):
2564         (WebTestRunner::TestRunner::shouldDumpAsAudio):
2565         (WebTestRunner):
2566         (WebTestRunner::TestRunner::audioData):
2567         (WebTestRunner::TestRunner::setAudioData):
2568         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2569         (TestRunner):
2570         * DumpRenderTree/chromium/TestShell.cpp:
2571         (TestShell::dump):
2572
2573 2013-01-07  Mike West  <mkwst@chromium.org>
2574
2575         Make the IFRAME_SEAMLESS flag runtime-enabled.
2576         https://bugs.webkit.org/show_bug.cgi?id=106213
2577
2578         Reviewed by Ojan Vafai.
2579
2580         * DumpRenderTree/chromium/TestShell.cpp:
2581         (TestShell::TestShell):
2582         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2583         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2584         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2585         (resetDefaultsToConsistentValues):
2586         * DumpRenderTree/mac/DumpRenderTree.mm:
2587         (resetDefaultsToConsistentValues):
2588         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2589         (WebCore::WebPage::resetSettings):
2590         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2591         (WTR::InjectedBundle::beginTesting):
2592             Ensure that seamless IFrames are enabled for layout tests in each of
2593             the ports that support seamless IFrames.
2594
2595 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
2596
2597         [chromium] move dumpAsText and friends to the TestRunner library
2598         https://bugs.webkit.org/show_bug.cgi?id=106222
2599
2600         Reviewed by Adam Barth.
2601
2602         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
2603
2604         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2605         (DRTTestRunner::DRTTestRunner):
2606         (DRTTestRunner::reset):
2607         * DumpRenderTree/chromium/DRTTestRunner.h:
2608         (DRTTestRunner):
2609         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2610         (WebTestRunner::WebTestRunner::shouldDumpAsText):
2611         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
2612         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
2613         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
2614         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
2615         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
2616         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2617         (WebTestRunner::TestRunner::TestRunner):
2618         (WebTestRunner::TestRunner::reset):
2619         (WebTestRunner::TestRunner::shouldDumpAsText):
2620         (WebTestRunner):
2621         (WebTestRunner::TestRunner::setShouldDumpAsText):
2622         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
2623         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
2624         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
2625         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
2626         (WebTestRunner::TestRunner::dumpAsText):
2627         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
2628         (WebTestRunner::TestRunner::dumpChildFramesAsText):
2629         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2630         (TestRunner):
2631
2632 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2633
2634         Build fix attempt after r138810.
2635
2636         Apparently python 2.6 is really bad at floating point computation.
2637
2638         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2639         (MainTest.test_run_memory_test):
2640
2641 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2642
2643         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
2644         https://bugs.webkit.org/show_bug.cgi?id=106172
2645
2646         Reviewed by Tony Chang.
2647
2648         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
2649         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
2650         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
2651         test on perf-o-matic and perf. test's results page.
2652
2653         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
2654
2655         * Scripts/webkitpy/performance_tests/perftest.py:
2656         (PerfTestMetric): Added.
2657         (PerfTestMetric.__init__): Added.
2658         (PerfTestMetric.metric): Added.
2659         (PerfTestMetric.has_values): Added.
2660         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
2661         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
2662         conversions to be done on the client side (perf-o-matic and results page).
2663         (PerfTestMetric.append): Added.
2664         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
2665         a result for this metric.
2666         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
2667         (PerfTestMetric.compute_statistics): Moved from PerfTest.
2668
2669         (PerfTest._create_driver): Extracted from PerfTest.run.
2670         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
2671         as needed.
2672         (PerfTest._run_with_driver):
2673         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
2674         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
2675         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
2676
2677         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
2678         from other perf tests, there isn't much point in sharing the code here.
2679
2680         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
2681         statistics for the measured values.
2682
2683         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2684         (TestPerfTestMetric): Added.
2685         (TestPerfTestMetric.test_init_set_missing_unit): Added.
2686         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
2687         (TestPerfTestMetric.test_has_values): Added.
2688         (TestPerfTestMetric.test_append): Added.
2689         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
2690         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
2691
2692         (TestPerfTest._assert_results_are_correct): Updated as needed.
2693         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
2694         in PerfTest.run now after generating the results dictionary.
2695         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
2696
2697 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
2698
2699         Support size_t multiplication and division operators on LayoutUnit
2700         https://bugs.webkit.org/show_bug.cgi?id=83848
2701
2702         Reviewed by Emil A Eklund.
2703
2704         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2705         Added some simple tests for the new operators using size_t.
2706
2707 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2708
2709         [Qt] run-webkit-tests cleanup for parallel NRWT
2710         https://bugs.webkit.org/show_bug.cgi?id=106220
2711
2712         Reviewed by Dirk Pranke.
2713
2714         * Scripts/run-webkit-tests:
2715         (useNewRunWebKitTests):
2716         * Scripts/webkitpy/layout_tests/port/qt.py:
2717         (QtPort):
2718         (QtPort.default_child_processes):
2719
2720 2013-01-07  Philippe Normand  <pnormand@igalia.com>
2721
2722         Create a GStreamerAudio watchlist and add myself to it.
2723
2724         Unreviewed.
2725
2726         * Scripts/webkitpy/common/config/watchlist:
2727
2728 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
2729
2730         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
2731         Also removed the empty mac directory.
2732
2733         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
2734         * BuildSlaveSupport/download-built-product: Added property svn:executable.
2735         * BuildSlaveSupport/mac: Removed.
2736         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
2737
2738 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
2739
2740         Add a script to delete stale zero-byte build files
2741         https://bugs.webkit.org/show_bug.cgi?id=106131
2742
2743         Reviewed by Tony Chang.
2744
2745         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
2746
2747         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2748         (DeleteStaleBuildFiles): Added.
2749         (Factory.__init__): Add DeleteStaleBuildFiles step.
2750         * BuildSlaveSupport/delete-stale-build-files: Added.
2751         (main): Delete zero-byte files except ones intentionally generated by our build process.
2752         (webkitBuildDirectory): Copied from build-product-archive.
2753
2754 2013-01-04  Michael Pruett  <michael@68k.org>
2755
2756         [GTK] Fix build error on GTK due to r138836
2757         https://bugs.webkit.org/show_bug.cgi?id=106154
2758
2759         Reviewed by Kentaro Hara.
2760
2761         * GNUmakefile.am:
2762
2763 2013-01-04  Dan Bernstein  <mitz@apple.com>
2764
2765         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
2766         https://bugs.webkit.org/show_bug.cgi?id=106121
2767
2768         Reviewed by Adele Peterson.
2769
2770         Added test for -[DOMTHMLTableCellElement _cellAbove].
2771
2772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2773         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
2774         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
2775         (TestWebKitAPI):
2776         (TestWebKitAPI::expectCellAboveCell):
2777         (TestWebKitAPI::TEST):
2778         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
2779
2780 2013-01-04  Eric Seidel  <eric@webkit.org>
2781
2782         FlakyTestReporter should be re-enabled and taught how to post patches
2783         https://bugs.webkit.org/show_bug.cgi?id=103839
2784
2785         Reviewed by Adam Barth.
2786
2787         This moves LayoutTestResultsReader off of the DeprecatedPort object.
2788         It also adds a real Port object to the EWS and CommitQueue objects
2789         using a new PatchProcessingQueue superclass.
2790         PatchProcessingQueue doesn't seem to be the cleanest insertion point
2791         but works for this purpose.
2792         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
2793         to resolve a FIXME.
2794
2795         This required some hacks/shiming between the non-specific "old"
2796         port names which the EWS system is currently using, and the new
2797         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
2798
2799         Hopefully this will fix the flaky test reporter and results uploading.
2800         Certainly it's another small step towards getting rid of the old ports.py
2801         infrastructure and making the NRWT Port class common webkitpy infrastructure.
2802
2803         Now that DeprecatedPort is no longer used for the results directory
2804         I removed all the explicit results-dir code which webkit-patch was using
2805         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
2806
2807         * Scripts/webkitpy/common/config/ports.py:
2808         (DeprecatedPort.run_perl_unittests_command):
2809         * Scripts/webkitpy/common/config/ports_mock.py:
2810         (MockPort.name):
2811         * Scripts/webkitpy/common/system/outputcapture.py:
2812         (OutputCapture.assert_outputs):
2813         * Scripts/webkitpy/layout_tests/port/apple.py:
2814         (ApplePort.determine_full_port_name):
2815         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2816         (LayoutTestResultsReader.__init__):
2817         (LayoutTestResultsReader):
2818         (LayoutTestResultsReader._read_file_contents):
2819         (LayoutTestResultsReader._create_layout_test_results):
2820         (LayoutTestResultsReader._create_unit_test_results):
2821         (LayoutTestResultsReader.results):
2822         (LayoutTestResultsReader.archive):
2823         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2824         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2825         (LayoutTestResultsReaderTest.test_create_unit_test_results):
2826         (test_missing_unit_test_results_path):
2827         (test_layout_test_results):
2828         (test_archive_last_layout_test_results):
2829         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2830         (AbstractEarlyWarningSystem):
2831         (AbstractEarlyWarningSystem.__init__):
2832         (AbstractEarlyWarningSystem.begin_work_queue):
2833         (AbstractEarlyWarningSystem.run_command):
2834         * Scripts/webkitpy/tool/commands/queues.py:
2835         (AbstractPatchQueue.work_item_log_path):
2836         (PatchProcessingQueue):
2837         (PatchProcessingQueue._new_port_name_from_old):
2838         (PatchProcessingQueue.begin_work_queue):
2839         (PatchProcessingQueue._upload_results_archive_for_patch):
2840         (CommitQueue):
2841         (CommitQueue.begin_work_queue):
2842         (CommitQueue.run_command):
2843         (AbstractReviewQueue):
2844         (AbstractReviewQueue.__init__):
2845         (AbstractReviewQueue.begin_work_queue):
2846         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2847         (AbstractPatchQueueTest.test_next_patch):
2848         (PatchProcessingQueueTest):
2849         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
2850         * Scripts/webkitpy/tool/steps/runtests.py:
2851         (RunTests.run):
2852         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2853
2854 2013-01-04  Dana Jansens  <danakj@chromium.org>
2855
2856         [chromium] Remove lost-compositor-context layout tests
2857         https://bugs.webkit.org/show_bug.cgi?id=106089
2858
2859         Reviewed by James Robinson.
2860
2861         Remove the loseCompositorContext() test function.
2862
2863         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2864         (WebTestRunner::TestRunner::TestRunner):
2865         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2866         (TestRunner):
2867
2868 2013-01-04  Adam Klein  <adamk@chromium.org>
2869
2870         Remove ENABLE_MUTATION_OBSERVERS #define
2871         https://bugs.webkit.org/show_bug.cgi?id=105459
2872
2873         Reviewed by Ryosuke Niwa.
2874
2875         * Scripts/webkitperl/FeatureList.pm:
2876         * qmake/mkspecs/features/features.pri:
2877
2878 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
2879
2880         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
2881         https://bugs.webkit.org/show_bug.cgi?id=106078
2882
2883         Reviewed by Tony Chang.
2884
2885         This patch updates values for individual iterations in dummy performance tests used in
2886         perftest_unittest.py and perftest_integrationtest.py so that they match up with
2887         statistics such as stdev and median reported in those tests. This change is required
2888         to resolve the bug 97510.
2889
2890         This patch also refactors integration tests by extracting *TestData classes that
2891         centralizes the definitions of each dummy performance test's text (DRT output),
2892         runner output, and parsed results (JSON) so that we may share more data between
2893         python tests.
2894
2895         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2896         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
2897         Use self.assertAlmostEqual when comparing the standard deviation.
2898         (MainTest.test_parse_output):
2899         (test_parse_output_with_failing_line):
2900         (test_parse_output_with_description): Use _assert_results_are_correct.
2901         (test_parse_output_with_subtests): Ditto.
2902
2903         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2904         (InspectorPassTestData): Extracted from tests below.
2905         (EventTargetWrapperTestData): Ditto.
2906         (SomeParserTestData): Ditto.
2907         (MemoryTestData): Ditto.
2908         (TestDriver.run_test): Moved test definitions out of the method.
2909         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
2910         (MainTest._load_output_json): Extracted from create_runner.
2911         (MainTest.create_runner):
2912         (MainTest.test_run_test_set_for_parser_tests):
2913         (MainTest.test_run_memory_test):
2914         (MainTest._test_run_with_json_output):
2915         (MainTest.test_run_with_json_output):
2916         (MainTest.test_run_with_description):
2917         (MainTest.test_run_generates_json_by_default):
2918         (MainTest.test_run_merges_output_by_default):
2919         (MainTest.test_run_respects_reset_results):
2920         (MainTest.test_run_generates_and_show_results_page):
2921         (MainTest.test_run_with_slave_config_json):
2922         (MainTest.test_run_with_multiple_repositories):
2923
2924 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
2925
2926         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
2927         https://bugs.webkit.org/show_bug.cgi?id=106045
2928
2929         Reviewed by Carlos Garcia Campos.
2930
2931         Update test results to confirm that compositions without preedits do not trigger
2932         a composition confirmation.
2933
2934         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2935         (TestWebKitAPI::verifyCanceledComposition):
2936
2937 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
2938
2939         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
2940         https://bugs.webkit.org/show_bug.cgi?id=105958
2941
2942         Reviewed by Alexey Proskuryakov.
2943
2944         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
2945
2946         * WebKitTestRunner/mac/EventSenderProxy.mm:
2947         (KeyMappingEntry):
2948         (WTR):
2949         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
2950
2951 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
2952
2953         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
2954         https://bugs.webkit.org/show_bug.cgi?id=106073
2955
2956         Reviewed by Ryosuke Niwa.
2957
2958         Check that the element being compared to is not nil. 
2959         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
2960         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
2961         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
2962         sometimes before on parallel WebKitTestRunner runs.
2963
2964         * DumpRenderTree/AccessibilityUIElement.cpp:
2965         (AccessibilityUIElement::isEqual):
2966         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2967         (WTR::AccessibilityUIElement::isEqual):
2968
2969 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
2970
2971         Downloads can be flaky, so try downloading multiple times.
2972         https://bugs.webkit.org/show_bug.cgi?id=105976
2973
2974         Reviewed by Eric Seidel.
2975
2976         * Scripts/webkitpy/common/system/autoinstall.py:
2977         (AutoInstaller._download_to_stream):
2978
2979 2013-01-03  Eric Seidel  <eric@webkit.org>
2980
2981         Rename Tool.port to deprecated_port in preparation for removing more callers
2982         https://bugs.webkit.org/show_bug.cgi?id=106076
2983
2984         Reviewed by Ryosuke Niwa.
2985
2986         This resolves a long-standing FIXME to rename this method. :)
2987
2988         * Scripts/webkitpy/tool/bot/botinfo.py:
2989         (BotInfo.summary_text):
2990         * Scripts/webkitpy/tool/bot/irc_command.py:
2991         (Rollout._update_working_copy):
2992         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2993         (LayoutTestResultsReader._create_layout_test_results):
2994         (LayoutTestResultsReader._create_unit_test_results):
2995         (LayoutTestResultsReader._results_directory):
2996         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2997         (test_missing_unit_test_results_path):
2998         * Scripts/webkitpy/tool/main.py:
2999         (WebKitPatch.deprecated_port):
3000         * Scripts/webkitpy/tool/mocktool.py:
3001         (MockTool.deprecated_port):
3002         * Scripts/webkitpy/tool/steps/build.py:
3003         (Build.build):
3004         * Scripts/webkitpy/tool/steps/checkstyle.py:
3005         (CheckStyle.run):
3006         * Scripts/webkitpy/tool/steps/commit.py:
3007         (Commit._check_test_expectations):
3008         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3009         (PrepareChangeLog.run):
3010         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
3011         (PrepareChangeLogForDEPSRoll.run):
3012         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3013         (PrepareChangeLogForRevert.run):
3014         * Scripts/webkitpy/tool/steps/runtests.py:
3015         (RunTests.run):
3016         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3017         (StepsTest.test_runtests_args):
3018         * Scripts/webkitpy/tool/steps/update.py:
3019         (Update._update_command):
3020
3021 2013-01-03  Eric Seidel  <eric@webkit.org>
3022
3023         Add myself to the webkitpy watchlist.
3024
3025         Unreviewed.
3026
3027         * Scripts/webkitpy/common/config/watchlist:
3028
3029 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3030
3031         Cleanup perftest* tests and add a test for computing statistics
3032         https://bugs.webkit.org/show_bug.cgi?id=105685
3033
3034         Reviewed by Eric Seidel.
3035
3036         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
3037         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
3038
3039         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
3040
3041         * Scripts/webkitpy/performance_tests/perftest.py:
3042         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
3043         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
3044         accurate result for the mean.
3045         (PageLoadingPerfTest.run_single):
3046         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3047         (MainTest.test_compute_statistics):
3048         (MainTest.test_compute_statistics.compute_statistics): Added.
3049         (TestPageLoadingPerfTest.test_run): floatify values.
3050         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
3051         correctly recognizes them as integers.
3052
3053         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
3054         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
3055         (TestDriver): Moved out of MainTest.
3056         (MainTest): Got rid of assertWritten and all unit tests.
3057         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
3058         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
3059         (MainTest.test_run_test_set_for_parser_tests):
3060         (MainTest.test_run_memory_test):
3061         (MainTest._test_run_with_json_output):
3062         (MainTest.test_run_generates_json_by_default):
3063         (MainTest.test_run_merges_output_by_default):
3064         (MainTest.test_run_respects_reset_results):
3065         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
3066         parsing output JSON files. Just verify that the output path is correct instead.
3067         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3068         (MainTest): Removed all integration tests.
3069         (MainTest.create_runner): Simplified.
3070
3071 2013-01-03  Julie Parent  <jparent@chromium.org>
3072
3073         Dashboard cleanup: remove usage of global g_defaultBuilderName
3074         https://bugs.webkit.org/show_bug.cgi?id=106043
3075
3076         Use now public defaultBuilder() from the BuilderGroup, rather
3077         than global variable.
3078
3079         Also eliminates the setup() and initBuilders() functions since we
3080         no longer need to track the global.
3081
3082         Reviewed by Adam Barth.
3083
3084         * TestResultServer/static-dashboards/builders.js:
3085         (BuilderGroup.prototype.defaultBuilder):
3086         (BuilderGroup.prototype.master):
3087         * TestResultServer/static-dashboards/dashboard_base.js:
3088         (parseParameters):
3089         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3090         (updateDefaultBuilderState):
3091         * TestResultServer/static-dashboards/loader.js:
3092         (.):
3093         * TestResultServer/static-dashboards/loader_unittests.js:
3094
3095 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3096
3097         Disable an intermittently failing unit test for now.
3098         The failure is tracked by the bug 106051.
3099
3100         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
3101         (TestWebKitAPI::TEST):
3102
3103 2013-01-03  Dan Bernstein  <mitz@apple.com>
3104
3105         No way to obtain a DOMNode given a JS wrapper for a Node
3106         https://bugs.webkit.org/show_bug.cgi?id=106033
3107
3108         Added a test for +[DOMNode _nodeFromJSWrapper:].
3109
3110         Reviewed by Sam Weinig.
3111
3112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3113         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
3114         (TestWebKitAPI):
3115         (TestWebKitAPI::TEST):
3116
3117 2013-01-03  Emil A Eklund  <eae@chromium.org>
3118
3119         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
3120         https://bugs.webkit.org/show_bug.cgi?id=105961
3121
3122         Reviewed by Levi Weintraub.
3123         
3124         Add tests for LayoutUnit::ceil and floor.
3125
3126         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3127         (TestWebKitAPI::TEST):
3128         (TestWebKitAPI):
3129
3130 2013-01-03  Julie Parent  <jparent@chromium.org>
3131
3132         Add unit test for default builder for the dashboards.
3133         https://bugs.webkit.org/show_bug.cgi?id=105972
3134
3135         Reviewed by Dirk Pranke.
3136
3137         * TestResultServer/static-dashboards/loader_unittests.js:
3138
3139 2013-01-03  Tony Chang  <tony@chromium.org>
3140
3141         Generate internal.settings from Settings.in
3142         https://bugs.webkit.org/show_bug.cgi?id=104740
3143
3144         Reviewed by Adam Barth.
3145
3146         * GNUmakefile.am: Compile new generated files on GTK+.
3147         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
3148         with both extra_sources and add_output_to_sources=false will still
3149         compile the files in extra_sources. This makes it possible to compile
3150         InternalSettingsGenerated.cpp and not be confused by
3151         InternalSettingsGenerated.idl.
3152
3153 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
3154
3155         [style] WebIDL-reflecting uppercase enums reported as style violation
3156         https://bugs.webkit.org/show_bug.cgi?id=105832
3157
3158         Reviewed by Tony Chang.
3159
3160         Recognize the enum as WebIDL-reflecting one if there's a comment present that
3161         indicates this. In enums spanning over multiple lines, the comment is expected
3162         on the first line. In enums placed in one line, the comment is expected at the
3163         end of that line.
3164
3165         WebIDL-reflecting enum values are required to be written in uppercase and as such
3166         violate the common rule of these values being written in InterCaps. Annotating
3167         enums this way makes it possible to avoid false style violation reports.
3168
3169         The comment is of form '// Web(?:Kit)?IDL enum'.
3170
3171         * Scripts/webkitpy/style/checkers/cpp.py:
3172         (_EnumState.__init__):
3173         (_EnumState.process_clean_line):
3174         (check_enum_casing):
3175         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3176         (NoNonVirtualDestructorsTest.test_enum_casing):
3177
3178 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
3179
3180         Adding favicon.ico to the garden-o-matic.
3181         https://bugs.webkit.org/show_bug.cgi?id=105982
3182
3183         Reviewed by Adam Barth.
3184
3185         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
3187
3188 2013-01-03  Jonathan Liu  <net147@gmail.com>
3189
3190         [Qt] Fix library linking order
3191         https://bugs.webkit.org/show_bug.cgi?id=105818
3192
3193         Some Qt libraries are linked before the private static libraries
3194         that depend on them which results in QtWebKit failing to link.
3195
3196         Copy Qt module dependencies from QT to QT_PRIVATE when creating
3197         module to ensure the Qt libraries are linked after the private
3198         static libraries that depend on them.
3199
3200         Reviewed by Tor Arne Vestbø.
3201
3202         * qmake/mkspecs/features/default_post.prf:
3203
3204 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
3205
3206         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
3207         https://bugs.webkit.org/show_bug.cgi?id=102209
3208
3209         Reviewed by Gyuyoung Kim.
3210
3211         Set tooltip on the elm_window instead of ewk_view, and add delay to
3212         show the tooltip window.
3213
3214         Setting tooltip on the ewk_view makes elementary error message because
3215         ewk_view is not an elementary widget. To remove the error message,
3216         tooltip should be set on the elm_window.
3217
3218         Most browsers show the tooltip after a mouse pointer stays on an
3219         element object that has tooltip text.
3220         But elm_tooltip widget itself doesn't have delay or handle mouse
3221         events to show/hide.
3222
3223         So additional codes are added to show/hide tooltip widget along with
3224         mouse events.
3225           1) When a mouse pointer stays for a second on an element which has
3226              tooltip text, then tooltip widget is displayed.
3227           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
3228              widget.
3229
3230         * MiniBrowser/efl/main.c:
3231         (_Tooltip_Information):
3232         (_Browser_Window):
3233         (on_tooltip_show):
3234         (window_tooltip_hide):
3235         (window_tooltip_update):
3236         (on_mouse_in):
3237         (on_mouse_move):
3238         (on_mouse_out):
3239         (window_free):
3240         (on_tooltip_text_set):
3241         (on_tooltip_text_unset):
3242         (window_create):
3243
3244 2013-01-02  Tony Chang  <tony@chromium.org>
3245
3246         Unreviewed, rolling out r138661.
3247         http://trac.webkit.org/changeset/138661
3248         https://bugs.webkit.org/show_bug.cgi?id=104740
3249
3250         Compile problems on EFL
3251
3252         * GNUmakefile.am:
3253         * qmake/mkspecs/features/default_post.prf:
3254
3255 2013-01-02  Tony Chang  <tony@chromium.org>
3256
3257         Generate internal.settings from Settings.in
3258         https://bugs.webkit.org/show_bug.cgi?id=104740
3259
3260         Reviewed by Adam Barth.
3261
3262         * GNUmakefile.am: Compile new generated files on GTK+.
3263         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
3264         with both extra_sources and add_output_to_sources=false will still
3265         compile the files in extra_sources. This makes it possible to compile
3266         InternalSettingsGenerated.cpp and not be confused by
3267         InternalSettingsGenerated.idl.
3268
3269 2013-01-02  Adam Barth  <abarth@webkit.org>
3270
3271         Remove old-run-webkit-tests support from webkitpy
3272         https://bugs.webkit.org/show_bug.cgi?id=105619
3273
3274         Reviewed by Eric Seidel.
3275
3276         This patch removes support for webkitpy parsing the
3277         old-run-webkit-tests results format. There doesn't seem to be any
3278         reason to keep this code around anymore now that most bots have
3279         switched to new-run-webkit-tests.
3280
3281         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3282         (Builder.fetch_layout_test_results):
3283         * Scripts/webkitpy/common/net/layouttestresults.py:
3284         (path_for_layout_test):
3285         (LayoutTestResults.results_from_string):
3286         (LayoutTestResults):
3287         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3288         (LayoutTestResultsTest.test_results_from_string):
3289         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3290         (test_flaky_test_failure):
3291         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3292         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
3293         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3294         (PatchAnalysisTask._test_patch):
3295         * Scripts/webkitpy/tool/commands/queuestest.py:
3296         (QueuesTest.assert_queue_outputs):
3297
3298 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
3299
3300         [Qt][WK2] Add simple UI to find text from page
3301         https://bugs.webkit.org/show_bug.cgi?id=96481
3302
3303         Reviewed by Jocelyn Turcotte.
3304
3305         Find bar that slides between navigation bar and WebView.
3306
3307         * MiniBrowser/qt/BrowserWindow.cpp:
3308         (BrowserWindow::toggleFind):
3309         * MiniBrowser/qt/BrowserWindow.h:
3310         (BrowserWindow):
3311         * MiniBrowser/qt/MiniBrowser.qrc:
3312         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3313         (MiniBrowserApplication::notify):
3314         * MiniBrowser/qt/icons/find.png: Added.
3315         * MiniBrowser/qt/qml/BrowserWindow.qml:
3316
3317 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
3318
3319         Regression(r138603): Caused 2 webkitpy tests to fail
3320         https://bugs.webkit.org/show_bug.cgi?id=105913
3321
3322         Reviewed by Kentaro Hara.
3323
3324         Fix 2 webkitpy tests that started to fail after
3325         r138603.
3326
3327         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3328         (IRCCommandTest._sheriff_test_data_url): Make sure the
3329         returned test file URL is valid no matter what the
3330         current working directory is.
3331         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3332         (IRCBotTest.test_help): Add "sheriffs" command to the
3333         list of available commands.
3334
3335 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
3336
3337         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
3338         https://bugs.webkit.org/show_bug.cgi?id=105897
3339
3340         Reviewed by Alexey Proskuryakov.
3341
3342         Dump in WebKitTestRunner the message that is expected by layout tests
3343         when the missing plugin button is clicked.
3344
3345         * WebKitTestRunner/TestController.cpp:
3346         (WTR::TestController::createWebViewWithOptions):
3347         (WTR::TestController::unavailablePluginButtonClicked):
3348         (WTR):
3349         * WebKitTestRunner/TestController.h:
3350         (TestController):
3351
3352 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
3353
3354         [EFL] Enable MHTML feature
3355         https://bugs.webkit.org/show_bug.cgi?id=105815
3356
3357         Reviewed by Laszlo Gombos.
3358
3359         Enable MHTML feature for EFL port by default.
3360
3361         * Scripts/webkitperl/FeatureList.pm:
3362
3363 2013-01-01  Alan Cutter  <alancutter@chromium.org>
3364
3365         sheriff-bot should know who the gardeners/sheriffs are
3366         https://bugs.webkit.org/show_bug.cgi?id=105698
3367
3368         Reviewed by Eric Seidel.
3369
3370         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
3371
3372         * Scripts/webkitpy/tool/bot/irc_command.py:
3373         (Current):
3374         (Current._retrieve_webkit_sheriffs):
3375         (Current.execute):
3376         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3377         (IRCCommandTest.test_current):
3378         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
3379         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
3380         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
3381         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
3382         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
3383
3384 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3385
3386         [GTK] Move ImageDiff to the Tools directory root
3387         https://bugs.webkit.org/show_bug.cgi?id=105421
3388
3389         Reviewed by Kenneth Rohde Christiansen.
3390
3391         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
3392         * GNUmakefile.am:
3393         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
3394
3395 2012-12-30  Mike West  <mkwst@chromium.org>
3396
3397         Add myself to watchlists for CSP and console logs.
3398         https://bugs.webkit.org/show_bug.cgi?id=105874
3399
3400         Reviewed by Dirk Pranke.
3401
3402         Because I really, really, really need more email.
3403
3404         * Scripts/webkitpy/common/config/committers.py:
3405             Add mkwst+watchlist@chromium.org as a contributor.
3406         * Scripts/webkitpy/common/config/watchlist:
3407             Create watchlist categories for 1) the various mechanisms used to
3408             generate console messages, and 2) CSP usage and files.
3409
3410 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3411
3412         [EFL] Enable TEMPLATE_ELEMENT feature
3413         https://bugs.webkit.org/show_bug.cgi?id=105865
3414         
3415         Reviewed by Laszlo Gombos.
3416
3417         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
3418
3419 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
3420
3421         Unreviewed GTK gardening of the unit tests.
3422
3423         Skip the TestInspectorServer unit test that's timing out completely.
3424
3425         * Scripts/run-gtk-tests:
3426         (TestRunner):
3427
3428 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
3429
3430         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
3431         https://bugs.webkit.org/show_bug.cgi?id=105855
3432
3433         Reviewed by Vsevolod Vlasov.
3434
3435         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
3436         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
3437
3438         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3439         (ReportMemoryUsageVisitor):
3440         (clang::AddMemberCallVisitor::VisitCallExpr):
3441         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
3442         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
3443
3444 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
3445
3446         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
3447         https://bugs.webkit.org/show_bug.cgi?id=105852
3448
3449         Reviewed by Alexander Pavlov.
3450
3451         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3452         (clang):
3453         (AddMemberCallVisitor):
3454         (ReportMemoryUsageVisitor):
3455         (clang::ReportMemoryUsageAction::ParseArgs):
3456         (clang::AddMemberCallVisitor::VisitCallExpr):
3457         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
3458         (clang::ReportMemoryUsageVisitor::emitWarning):
3459         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
3460         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
3461         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
3462
3463 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
3464
3465         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
3466         https://bugs.webkit.org/show_bug.cgi?id=105835
3467
3468         Reviewed by Dirk Pranke.
3469
3470         The BeautifulSoup module is a third-party import and as such we don't have much control
3471         over its testing. Because of that it should be omitted from code coverage checking.
3472
3473         * Scripts/webkitpy/test/main.py:
3474         (Tester._run_tests):
3475
3476 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
3477
3478         [GTK][WK2] Add support for IME Composition
3479         https://bugs.webkit.org/show_bug.cgi?id=65093
3480
3481         Reviewed by Carlos Garcia Campos.
3482
3483         Update unit tests for GtkInputMethodFilter to note whether or not an event
3484         was a fake event synthesized for composition purposes. This is now used
3485         for WebKit2.
3486
3487         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
3488         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
3489         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
3490         (TestWebKitAPI::TEST):
3491         * gtk/generate-gtkdoc:
3492         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
3493         generation.
3494
3495 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
3496
3497         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
3498         https://bugs.webkit.org/show_bug.cgi?id=105800
3499
3500         Reviewed by Yury Semikhatsky.
3501
3502         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3503         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
3504         (clang):
3505
3506 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
3507
3508         Create a GTK build system watchlist and add myself to it
3509         https://bugs.webkit.org/show_bug.cgi?id=105769
3510
3511         Reviewed by Dirk Pranke.
3512
3513         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
3514         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
3515         omitted on purpose due to relatively high change rate they are exposed to.
3516
3517         The new watchlist would be of use to me as the GTK build system recently went
3518         through a series of changes that included a changed policy on adding configuration
3519         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
3520         mailing list about this change will be published later, but I'd also like to be
3521         notified of any pending changes to these files just so I can check the changes are
3522         in compliance with the new policy.
3523
3524         * Scripts/webkitpy/common/config/watchlist:
3525
3526 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
3527
3528         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
3529         As example ..../DevTools/src/third_party/WebKit
3530
3531         * Scripts/webkitpy/common/webkit_finder.py:
3532         (WebKitFinder.webkit_base):
3533
3534 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
3535
3536         [EFL][WK2] Refactor snapshot taking code
3537         https://bugs.webkit.org/show_bug.cgi?id=105687
3538
3539         Reviewed by Kenneth Rohde Christiansen.
3540
3541         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
3542         since the function was renamed to follow naming style.
3543
3544         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3545         (WTR::PlatformWebView::windowSnapshotImage):
3546
3547 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
3548
3549         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
3550         https://bugs.webkit.org/show_bug.cgi?id=105725
3551
3552         Reviewed by Yury Semikhatsky.
3553
3554         MemberType value names were adjusted according to Style Guide.
3555         Existing tests were extended with link type validation.
3556
3557         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3558
3559 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
3560
3561         [BlackBerry] DRT - Crashed when running pixels tests
3562         https://bugs.webkit.org/show_bug.cgi?id=105711
3563
3564         RIM PR 270003
3565
3566         Reviewed by George Staikos.
3567
3568         Calling window->post() here will result in buffer swapping which is
3569         only allowed in UI thread now, and I found we don't need to call it
3570         for GL renderer.
3571
3572         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3573         (createBitmapContextFromWebView):
3574
3575 2012-12-22  Dan Winship  <danw@gnome.org>
3576
3577         Add a patch to fix libxml2 2.9.0 regression
3578         https://bugs.webkit.org/show_bug.cgi?id=104494
3579
3580         Reviewed by Martin Robinson.
3581
3582         * gtk/jhbuild.modules:
3583         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
3584
3585 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3586
3587         Unreviewed update of status to reviewer.
3588
3589         * Scripts/webkitpy/common/config/committers.py:
3590
3591 2012-12-23  Philippe Normand  <pnormand@igalia.com>
3592
3593         [GTK][jhbuild] Bump GStreamer to 1.0.4
3594         https://bugs.webkit.org/show_bug.cgi?id=105640
3595
3596         Reviewed by Martin Robinson.
3597
3598         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
3599
3600 2012-12-21  Nico Weber  <thakis@chromium.org>
3601
3602         chromium: webkit-build-directory doesn't handle ninja output dirs
3603         https://bugs.webkit.org/show_bug.cgi?id=105671
3604
3605         Reviewed by Daniel Bates.
3606
3607         Teach webkit-build-directory to detect the ninja build directory.
3608
3609         * Scripts/webkitdirs.pm:
3610         (determineBaseProductDir):
3611         (determineIsChromiumNinja):
3612
3613 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
3614
3615         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
3616         https://bugs.webkit.org/show_bug.cgi?id=95477
3617
3618         Reviewed by Sam Weinig.
3619
3620         Co-authored by Jia Pu.
3621
3622         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
3623         we can have consistent autocorrection behavior when running tests.
3624
3625         * DumpRenderTree/mac/DumpRenderTree.mm:
3626         (resetDefaultsToConsistentValues):
3627         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3628         (WTR::InjectedBundle::platformInitialize):
3629
3630 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
3631
3632         [GTK] Add WebKit1-specific TestExpectations file
3633         https://bugs.webkit.org/show_bug.cgi?id=97562
3634
3635         Reviewed by Dirk Pranke.
3636
3637         Implement the expectations_files method inside the GtkPort class that
3638         returns the list of the TestExpectations files the current test configuration
3639         requires. The method is implemented in a similar way as on the EFL port.
3640         A unit test is also added.
3641
3642         * Scripts/webkitpy/layout_tests/port/gtk.py:
3643         (GtkPo