db0abfef8d874b55e23a928e110327885a5b8e36
[WebKit-https.git] / Tools / ChangeLog
1 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2
3         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
4         https://bugs.webkit.org/show_bug.cgi?id=125854
5
6         Reviewed by Chris Fleizach.
7
8         Ensure we don't ever create instances of AccessibilityUIElement
9         wrapping invalid platform-specific accessibility objects in DRT,
10         both for consistency with what WKTR does (so we avoid situations
11         where some tests fail in WK2 and not in WK1) and also to avoid
12         overlooking tests that might not be checking the right thing.
13
14         * DumpRenderTree/AccessibilityUIElement.cpp:
15         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
16         nullPtr if the platformUIElement() is not a valid one.
17         * DumpRenderTree/AccessibilityUIElement.h:
18         (AccessibilityUIElement::platformUIElement): Added const modifier.
19
20 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
21
22         Programmatically-inserted children lack accessibility events
23         https://bugs.webkit.org/show_bug.cgi?id=100275
24
25         Reviewed by Chris Fleizach.
26
27         Update DRT and WebKitTestRunner to handle the children-changed
28         signal properly, considering the detail and optional parameters.
29
30         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
31         (axObjectEventListener):
32         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
33
34 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
35
36         Removed unused BUILDER_BASE_URL.
37         https://bugs.webkit.org/show_bug.cgi?id=125442
38
39         Reviewed by Csaba Osztrogonác.
40
41         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
42         (JSONGeneratorTest._test_json_generation): Trivial test fix after r160900.
43
44 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
45
46         Removed unused BUILDER_BASE_URL.
47         https://bugs.webkit.org/show_bug.cgi?id=125442
48
49         Reviewed by Csaba Osztrogonác.
50
51         The string constant BUILDER_BASE_URL is passed around several times,
52         but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
53
54         * Scripts/webkitpy/layout_tests/controllers/manager.py:
55         (Manager._upload_json_files):
56         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
57         (JSONLayoutResultsGenerator.__init__):
58         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
59         (JSONResultsGenerator.__init__):
60
61 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
62
63         check-webkit-style mistakenly flags assigning to a dereferenced pointer
64         https://bugs.webkit.org/show_bug.cgi?id=126041
65
66         Reviewed by Ryosuke Niwa.
67
68         When checking for lines like "Foo *bar;", check-webkit-style doesn't make
69         sure that there is a declaration. This patch makes sure that there is a
70         declaration in order to flag spacing around asterisks.
71
72         * Scripts/webkitpy/style/checkers/cpp.py:
73         (check_spacing):
74         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
75         (CppStyleTest.test_pointer_reference_marker_location):
76
77 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
78
79         check-webkit-style marks rvalue references as violations
80         https://bugs.webkit.org/show_bug.cgi?id=126000
81
82         Reviewed by Ryosuke Niwa.
83
84         Previously, check-webkit-style was making sure that any line with "&&" had
85         spaces around it. However, we can now legitimately use "&&" without a previous
86         space when declaring an rvalue reference. This patch relaxes this check.
87
88         * Scripts/webkitpy/style/checkers/cpp.py:
89         (check_spacing):
90         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
91         (CppStyleTest.test_spacing_for_binary_ops):
92
93 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
94
95         check-webkit-style marks auto return types for functions as violations
96         https://bugs.webkit.org/show_bug.cgi?id=125999
97
98         Reviewed by Ryosuke Niwa.
99
100         If a function declaration ends with a "->" followed by a non whitespace
101         string, don't mark as an invalid "{" on its own line
102
103         * Scripts/webkitpy/style/checkers/cpp.py:
104         (check_braces):
105         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
106         (CppStyleTest.test_brace_at_begin_of_line):
107
108 2013-12-19  Alex Christensen  <achristensen@webkit.org>
109
110         [WinCairo] More GStreamer preparations.
111
112         Unreviewed.
113
114         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props:
115         Include FeatureDefinesCairo and WinCairo to compile the GLib part of WinLauncher.
116
117 2013-12-19  Lucas Forschler  <lforschler@apple.com>
118
119         Add Apple Mavericks perf bot.
120         
121         Unreviewed.
122
123         * BuildSlaveSupport/build.webkit.org-config/config.json:
124
125 2013-12-19  Commit Queue  <commit-queue@webkit.org>
126
127         Unreviewed, rolling out r160842.
128         http://trac.webkit.org/changeset/160842
129         https://bugs.webkit.org/show_bug.cgi?id=126003
130
131         broke accessibility/loading-iframe-updates-axtree.html
132         (Requested by ap on #webkit).
133
134         * DumpRenderTree/AccessibilityUIElement.cpp:
135         (AccessibilityUIElement::makeJSAccessibilityUIElement):
136         * DumpRenderTree/AccessibilityUIElement.h:
137         (AccessibilityUIElement::platformUIElement):
138
139 2013-12-19  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
140
141         get_test_baseline should get Host from test_config
142         https://bugs.webkit.org/show_bug.cgi?id=125989
143
144         Reviewed by Ryosuke Niwa.
145
146         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
147         (TestConfig.__init__):
148         (RebaselineServer._prepare_config):
149         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
150         (get_test_baselines):
151         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
152         (get_test_config):
153
154 2013-12-19  Roger Fong  <roger_fong@apple.com>
155
156         Don't check VSINSTALLDIR when looking for Visual Studio install directory.
157         https://bugs.webkit.org/show_bug.cgi?id=125998.
158
159         Reviewed by Alexey Proskuryakov.
160
161         * Scripts/webkitdirs.pm:
162         (visualStudioInstallDir):
163         Get rid of the VSINSTALLDIR check. We can't build on anything besides VS2013 now anyways.
164
165 2013-12-19  Mario Sanchez Prada  <mario.prada@samsung.com>
166
167         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
168         https://bugs.webkit.org/show_bug.cgi?id=125854
169
170         Reviewed by Chris Fleizach.
171
172         Ensure we don't ever create instances of AccessibilityUIElement
173         wrapping invalid platform-specific accessibility objects in DRT,
174         both for consistency with what WKTR does (so we avoid situations
175         where some tests fail in WK2 and not in WK1) and also to avoid
176         overlooking tests that might not be checking the right thing.
177
178         * DumpRenderTree/AccessibilityUIElement.cpp:
179         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
180         nullPtr if the platformUIElement() is not a valid one.
181         * DumpRenderTree/AccessibilityUIElement.h:
182         (AccessibilityUIElement::platformUIElement): Added const modifier.
183
184 2013-12-18  Anders Carlsson  <andersca@apple.com>
185
186         Deprecate some WKMutableDictionary functions
187         https://bugs.webkit.org/show_bug.cgi?id=125962
188
189         Reviewed by Tim Horton.
190
191         * TestWebKitAPI/PlatformUtilities.cpp:
192         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
193         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
194         (TestWebKitAPI::didAssociateFormControls):
195         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
196         (TestWebKitAPI::WillLoadTest::willLoadURLRequest):
197         (TestWebKitAPI::WillLoadTest::willLoadDataRequest):
198         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
199         (WTR::createMouseMessageBody):
200         (WTR::EventSendingController::mouseMoveTo):
201         (WTR::EventSendingController::leapForward):
202         (WTR::createKeyDownMessageBody):
203         (WTR::EventSendingController::mouseScrollBy):
204         (WTR::EventSendingController::continuousMouseScrollBy):
205         (WTR::EventSendingController::addTouchPoint):
206         (WTR::EventSendingController::updateTouchPoint):
207         (WTR::EventSendingController::setTouchModifier):
208         (WTR::EventSendingController::setTouchPointRadius):
209         (WTR::EventSendingController::touchStart):
210         (WTR::EventSendingController::touchMove):
211         (WTR::EventSendingController::touchEnd):
212         (WTR::EventSendingController::touchCancel):
213         (WTR::EventSendingController::clearTouchPoints):
214         (WTR::EventSendingController::releaseTouchPoint):
215         (WTR::EventSendingController::cancelTouchPoint):
216         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
217         (WTR::InjectedBundle::done):
218         (WTR::InjectedBundle::setMockGeolocationPosition):
219         (WTR::InjectedBundle::setCustomPolicyDelegate):
220         (WTR::InjectedBundle::setVisibilityState):
221         (WTR::InjectedBundle::queueLoad):
222         (WTR::InjectedBundle::queueLoadHTMLString):
223         * WebKitTestRunner/TestController.cpp:
224         (WTR::TestController::initialize):
225         (WTR::TestController::resetStateToConsistentValues):
226         * WebKitTestRunner/TestInvocation.cpp:
227         (WTR::updateThreadedScrollingForCurrentTest):
228         (WTR::updateLayoutType):
229         (WTR::TestInvocation::invoke):
230
231 2013-12-18  Martin Robinson  <mrobinson@igalia.com>
232
233         [GTK] [CMake] Add support for building GtkLauncher
234         https://bugs.webkit.org/show_bug.cgi?id=125766
235
236         Reviewed by Gustavo Noronha Silva.
237
238         * CMakeLists.txt: Add the GtkLauncher subdirectory for the GTK port.
239         * GtkLauncher/CMakeLists.txt: Added.
240         * GtkLauncher/main.c: Support including the CMake config file.
241
242 2013-12-18  Alex Christensen  <achristensen@webkit.org>
243
244         [WinCairo] Preparation for GStreamer on Windows.
245         https://bugs.webkit.org/show_bug.cgi?id=125946
246
247         Reviewed by Brent Fulgham.
248
249         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
250         Use new GStreamer property sheets for WinCairo.
251         * win/DLLLauncher/DLLLauncherMain.cpp:
252         (modifyPath):
253         (wWinMain):
254         Prepend GStreamer bin directory to path if it exists.
255
256 2013-12-18  Anders Carlsson  <andersca@apple.com>
257
258         Remove now useless test.
259
260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
261         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
262         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
263         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
264
265 2013-12-18  Gavin Barraclough  <barraclough@apple.com>
266
267         Fix page visibility api test, initialization in WebKit2
268         https://bugs.webkit.org/show_bug.cgi?id=125933
269
270         Reviewed by Anders Carlsson.
271
272         The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
273         (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
274
275         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
276         (TestWebKitAPI::TEST_F):
277             - Running a test on WebKit1 twice is not the same as running it on WebKit2!
278
279 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
280
281         Should not have identifiers with underscores in them, especially not leading underscores.
282         https://bugs.webkit.org/show_bug.cgi?id=125847
283
284         Reviewed by Darin Adler.
285
286         * Scripts/webkitpy/style/checkers/cpp.py:
287         (check_identifier_name_in_declaration):
288         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
289         (CppStyleTest.test_runtime_selfinit):
290         (WebKitStyleTest.test_names):
291
292 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
293
294         False webkit-check-style warnings on *.
295         https://bugs.webkit.org/show_bug.cgi?id=125915
296
297         Reviewed by Darin Adler.
298
299         * Scripts/webkitpy/style/checkers/cpp.py:
300         (check_spacing):
301         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
302         (CppStyleTest.test_pointer_reference_marker_location):
303
304 2013-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
305
306         prepare-ChangeLog doesn't handle templates properly
307         https://bugs.webkit.org/show_bug.cgi?id=125853
308
309         Reviewed by Daniel Bates.
310
311         * Scripts/prepare-ChangeLog:
312         (get_function_line_ranges_for_cpp):
313         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
314         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
315         (Class110<TemplateClass>::func36):
316
317 2013-12-18  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
318
319         Move expectation parsing out of the constructor of TestExpectations
320         https://bugs.webkit.org/show_bug.cgi?id=125439
321
322         Reviewed by Csaba Osztrogonác.
323
324         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
325         (LayoutTestRunnerTests._run_tests):
326         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
327         (LayoutTestRunnerTests.test_update_summary_with_result):
328         * Scripts/webkitpy/layout_tests/controllers/manager.py:
329         (Manager.run):
330         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
331         (ManagerTest.test_look_for_new_crash_logs):
332         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
333         (lint):
334         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
335         (TestExpectations.suffixes_for_expectations):
336         (TestExpectations.__init__):
337         (TestExpectations):
338         (TestExpectations.parse_generic_expectations):
339         (TestExpectations.parse_default_port_expectations):
340         (TestExpectations.parse_override_expectations):
341         (TestExpectations.parse_all_expectations):
342         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
343         (parse_exp):
344         (SkippedTests.check):
345         (SkippedTests.test_skipped_entry_dont_exist):
346         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
347         (run_results):
348         * Scripts/webkitpy/tool/commands/queries.py:
349         (PrintExpectations._model):
350         * Scripts/webkitpy/tool/commands/rebaseline.py:
351         (RebaselineTest._update_expectations_file):
352         (RebaselineExpectations._update_expectations_files):
353         (RebaselineExpectations._tests_to_rebaseline):
354
355 2013-12-17  Jer Noble  <jer.noble@apple.com>
356
357         Fix TimeRanges::intersectWith
358         https://bugs.webkit.org/show_bug.cgi?id=118802
359
360         Reviewed by Eric Carlson.
361
362         Add unit tests for WebCore/TimeRanges.
363
364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
365         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: Added.
366         (TestWebKitAPI::ToString):
367         (TestWebKitAPI::TEST):
368
369 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
370
371         Botwatcher's dashboard ceases to update itself after a while
372         https://bugs.webkit.org/show_bug.cgi?id=125885
373
374         Reviewed by Timothy Hatcher.
375
376         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
377         Removed code that checked for the view being hidden. It's none of model's business.
378
379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
380         (BuildbotQueueView): Find out what platform the view is for. Initlialize update timer.
381         (BuildbotQueueView.prototype._updateHiddenState): Start or stop update timer as appropriate.
382         We now stop the timer for hidden views.
383         (BuildbotQueueView.prototype._updateQueues): Removed the logic for ignoring some updates.
384
385 2013-12-17  Anders Carlsson  <andersca@apple.com>
386
387         Fix the 32-bit build.
388
389         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
390         * MiniBrowser/MiniBrowserWebProcessPlugIn.m:
391
392 2013-12-17  Anders Carlsson  <andersca@apple.com>
393
394         Give the MiniBrowser a bundle
395         https://bugs.webkit.org/show_bug.cgi?id=125882
396
397         Reviewed by Sam Weinig.
398
399         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Added.
400         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
401         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Added.
402         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Added.
403         (-[MiniBrowserWebProcessPlugIn webProcessPlugIn:initializeWithObject:]):
404         * MiniBrowser/mac/AppDelegate.m:
405         (-[BrowserAppDelegate init]):
406         * MiniBrowser/mac/Bundle/Info.plist: Added.
407         * MiniBrowser/mac/Bundle/MiniBrowserBundle_Prefix.pch: Added.
408
409 2013-12-17  Gavin Barraclough  <barraclough@apple.com>
410
411         Remove PageVisibilityStateUnloaded
412         https://bugs.webkit.org/show_bug.cgi?id=125869
413
414         Reviewed by Anders Carlsson.
415
416         This is not currently supported by WebKit, remove this enum value.
417         We can always add this back later if/when we add support for this state.
418
419         * DumpRenderTree/mac/TestRunnerMac.mm:
420         (TestRunner::setPageVisibility):
421         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
422         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
423         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
424         (WTR::TestRunner::setPageVisibility):
425             - remove test for visibility state "unloaded"; this is no longer supported (it never really was).
426
427 2013-12-12  Martin Robinson  <mrobinson@igalia.com>
428
429         [GTK] [CMake] Build the plugin process against GTK+ 2
430         https://bugs.webkit.org/show_bug.cgi?id=116374
431
432         Reviewed by Gustavo Noronha Silva.
433
434         * TestWebKitAPI/PlatformGTK.cmake: Add WebCorePlatformGTK to the list of
435         libraries required for WebCore unit tests.
436
437 2013-12-17  Brent Fulgham  <bfulgham@apple.com>
438
439         [Win] Revise filter-build-webkit to deal with Windows build logs
440         https://bugs.webkit.org/show_bug.cgi?id=125866
441
442         Reviewed by David Kilzer.
443
444         Enhance the script to accept a 'platform' argument. When platform
445         'win' is provided, use processing for the Windows build file format.
446         Otherwise, process the files as normal.
447
448         * Scripts/filter-build-webkit:
449         (usageAndExit): Add a 'platform' argument
450         (shouldIgnoreLine): When platform == 'win' use the new Windows
451         rules for processing the build file.
452
453 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
454
455         Update style checker now that ENUM_CLASS is gone
456         https://bugs.webkit.org/show_bug.cgi?id=125864
457
458         Reviewed by Anders Carlsson.
459
460         * Scripts/webkitpy/style/checkers/cpp.py:
461         (_EnumState.process_clean_line):
462         (check_braces):
463         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
464         (NoNonVirtualDestructorsTest.test_enum_casing.Foo):
465         (NoNonVirtualDestructorsTest.test_enum_casing):
466         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123):
467         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass):
468         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum):
469         (WebKitStyleTest.test_braces.CPP11EnumClass):
470
471 2013-12-17  Mario Sanchez Prada  <mario.prada@samsung.com>
472
473         [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
474         https://bugs.webkit.org/show_bug.cgi?id=125857
475
476         Reviewed by Chris Fleizach.
477
478         Add mappings to DRT & WKTR for the newly exposed roles, and
479         increase the version of ATK used by the internal jhbuild.
480
481         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
482         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
483         * gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
484
485 2013-12-17  Alex Christensen  <achristensen@webkit.org>
486
487         [WinCairo] Adding support for GStreamer and GLib.
488         https://bugs.webkit.org/show_bug.cgi?id=124867
489
490         Reviewed by Philippe Normand.
491
492         * WinLauncher/WinLauncher.cpp:
493         (wWinMain):
494         Added g_main_context_iteration in main event loop.
495
496 2013-12-17  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
497
498         Fix for C++ should have the & or * beside the type not the variable name check.
499         https://bugs.webkit.org/show_bug.cgi?id=125846
500
501         Reviewed by Darin Adler.
502
503         * Scripts/webkitpy/style/checkers/cpp.py:
504         (check_spacing):
505         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
506         (CppStyleTest.test_pointer_reference_marker_location):
507
508 2013-12-16  Rob Buis  <rob.buis@samsung.com>
509
510         Add my Samsung email address.
511
512         Unreviewed.
513
514         * Scripts/webkitpy/common/config/contributors.json:
515
516 2013-12-16  Oliver Hunt  <oliver@apple.com>
517
518         Cache getters and custom accessors on the prototype chain
519         https://bugs.webkit.org/show_bug.cgi?id=125602
520
521         Reviewed by Michael Saboff.
522
523         Make sure bencher scripts also make noInline exist
524
525         * Scripts/bencher:
526
527 2013-12-16  Anders Carlsson  <andersca@apple.com>
528
529         Fix crash when trying to load a null HTML string
530         https://bugs.webkit.org/show_bug.cgi?id=125801
531
532         Reviewed by Dan Bernstein.
533
534         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
535         (TestWebKitAPI::TEST_F):
536         Update test results.
537
538 2013-12-16  Alex Christensen  <achristensen@webkit.org>
539
540         Fixed Win64 build on VS2013.
541         https://bugs.webkit.org/show_bug.cgi?id=125753
542
543         Reviewed by Brent Fulgham.
544
545         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
546         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
547         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
548         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
549         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
550         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
551         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
552         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
553         * win/record-memory/record-memory.vcxproj:
554         Added correct PlatformToolset for 64-bit builds.
555
556 2013-12-16  Simon Fraser  <simon.fraser@apple.com>
557
558         Add a menu option to MiniBrowser to enable UI-side compositing
559         https://bugs.webkit.org/show_bug.cgi?id=125793
560
561         Reviewed by Anders Carlsson.
562         
563         Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
564
565         * MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
566         to toggle UI-side compositing.
567         * MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
568         * MiniBrowser/mac/WK2BrowserWindowController.m:
569         (-[WK2BrowserWindowController validateMenuItem:]):
570         (-[WK2BrowserWindowController isUISideCompositingEnabled]):
571         (-[WK2BrowserWindowController toggleUISideCompositing:]):
572         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
573         Adjust the window title to indicate whether the window is using UI-side compositing.
574
575 2013-12-16  Commit Queue  <commit-queue@webkit.org>
576
577         Unreviewed, rolling out r160645.
578         http://trac.webkit.org/changeset/160645
579         https://bugs.webkit.org/show_bug.cgi?id=125787
580
581         Change breaks test-webkitpy (Requested by bfulgham on
582         #webkit).
583
584         * Scripts/prepare-ChangeLog:
585         (get_selector_line_ranges_for_css):
586
587 2013-12-16  David Farler  <dfarler@apple.com>
588
589         [ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
590         https://bugs.webkit.org/show_bug.cgi?id=124610
591
592         Reviewed by Mark Rowe.
593
594         * WebKitLauncher/WebKitNightlyEnabler.m:
595         (enableWebKitNightlyBehaviour):
596         Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
597         * WebKitLauncher/main.m:
598         (main):
599         Include both libasancrashreporter and the nightly enabler to
600         the list of libraries to insert.
601
602 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
603
604         Resolve inconsistant style warning caused by r160319.
605         https://bugs.webkit.org/show_bug.cgi?id=125772
606
607         Reviewed by Darin Adler.
608
609         * Scripts/webkitpy/style/checkers/cpp.py:
610         (check_for_extra_new_line_at_eof):
611         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
612         (CppStyleTest.test_newline_at_eof):
613         (CppStyleTest.test_extra_newlines_at_eof):
614
615 2013-12-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
616
617         Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
618         https://bugs.webkit.org/show_bug.cgi?id=125780
619
620         Reviewed by Darin Adler.
621
622         * Scripts/webkitpy/port/mock_drt.py:
623         (main):
624         (parse_options):
625         (MockDRT.write_test_output):
626         * Scripts/webkitpy/port/mock_drt_unittest.py:
627         (MockDRTTest.assertTest):
628         (MockDRTTest.test_reftest_mismatch):
629
630 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
631
632         prepare-Changelog treats CSS keyframes as mismatched parentheses.
633         https://bugs.webkit.org/show_bug.cgi?id=125435
634
635         Reviewed by Darin Adler.
636
637         * Scripts/prepare-ChangeLog:
638         (get_selector_line_ranges_for_css):
639
640 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
641
642         [ATK] Expose accessibility objects for more WAI-ARIA roles
643         https://bugs.webkit.org/show_bug.cgi?id=125596
644
645         Reviewed by Chris Fleizach.
646
647         Add mappings to DRT & WKTR for the newly exposed roles.
648
649         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
650         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
651
652 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
653
654         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
655         https://bugs.webkit.org/show_bug.cgi?id=125594
656
657         Reviewed by Chris Fleizach.
658
659         Add mappings to DRT & WKTR for checkmenuitem role.
660
661         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
662         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
663
664 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
665
666         [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
667         https://bugs.webkit.org/show_bug.cgi?id=125587
668
669         Reviewed by Chris Fleizach.
670
671         Add mappings to DRT & WKTR for article roles.
672
673         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
674         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
675
676 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
677
678         [FTL] Allow EFL to build FTL with the build-jsc script.
679         https://bugs.webkit.org/show_bug.cgi?id=125774
680
681         Reviewed by Zoltan Herczeg.
682
683         * Scripts/build-jsc:
684
685 2013-12-16  Krzysztof Czech  <k.czech@samsung.com>
686
687         Add myself as a committer
688
689         Unreviewed.
690
691         * Scripts/webkitpy/common/config/contributors.json:
692
693 2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
694
695         Refactor option handling in WebKitTestRunner.
696         https://bugs.webkit.org/show_bug.cgi?id=123185
697
698         Reviewed by Darin Adler.
699
700         Option handling is refactored (according to the FIXME) that allows
701         to automatically generate the help message.
702
703         * WebKitTestRunner/CMakeLists.txt:
704         * WebKitTestRunner/GNUmakefile.am:
705         * WebKitTestRunner/Options.cpp: Added.
706         (WTR::Options::Options):
707         (WTR::handleOptionTimeout):
708         (WTR::handleOptionNoTimeout):
709         (WTR::handleOptionNoTimeoutAtAll):
710         (WTR::handleOptionVerbose):
711         (WTR::handleOptionGcBetweenTests):
712         (WTR::handleOptionPixelTests):
713         (WTR::handleOptionPrintSupportedFeatures):
714         (WTR::handleOptionComplexText):
715         (WTR::handleOptionAcceleratedDrawing):
716         (WTR::handleOptionRemoteLayerTree):
717         (WTR::handleOptionUnmatched):
718         (WTR::OptionsHandler::OptionsHandler):
719         (WTR::Option::Option):
720         (WTR::Option::matches):
721         (WTR::OptionsHandler::parse):
722         (WTR::OptionsHandler::printHelp):
723         * WebKitTestRunner/Options.h: Added.
724         * WebKitTestRunner/TestController.cpp:
725         (WTR::TestController::initialize):
726         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
727
728 2013-12-15  Dan Bernstein  <mitz@apple.com>
729
730         32-bit build fix.
731
732         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
733         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
734
735 2013-12-14  Tim Horton  <timothy_horton@apple.com>
736
737         stylebot should warn when FeatureDefines differ
738         https://bugs.webkit.org/show_bug.cgi?id=125748
739
740         Reviewed by Dan Bernstein.
741
742         Add a stylebot checker that ensures that FeatureDefines.xcconfig files
743         are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
744         an unlikely occurrance, to add them to the list).
745
746         It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
747         but that is the most straightforward way to implement it (and we're at zero diffs right now).
748
749         * Scripts/webkitpy/style/checker.py:
750         (_all_categories):
751         (FileType):
752         (CheckerDispatcher._file_type):
753         (CheckerDispatcher._create_checker):
754         * Scripts/webkitpy/style/checkers/featuredefines.py: Added.
755         (FeatureDefinesChecker):
756         (FeatureDefinesChecker.__init__):
757         (FeatureDefinesChecker.check):
758
759 2013-12-13  Sam Weinig  <sam@webkit.org>
760
761         Fix API tests.
762
763         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
764         (TestWebKitAPI::TEST_F):
765
766 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
767
768         [Win] Remove Pre-VS2013 support code.
769         https://bugs.webkit.org/show_bug.cgi?id=125693
770
771         Reviewed by Darin Adler.
772
773         * DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
774         the math library.
775         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
776
777 2013-12-13  Lucas Forschler  <lforschler@apple.com>
778
779         Update Webkit bots.
780         
781         Unreviewed.
782         
783         * BuildSlaveSupport/build.webkit.org-config/config.json:
784
785 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
786
787         [Win] Unreviewed build fix after r160548
788
789         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
790         we are using vs12_xp target for Makefile-based projects.
791
792 2013-12-13  Lucas Forschler  <lforschler@apple.com>
793
794         Update Apple Webkit Bots
795         
796         Unreviewed.
797
798         * BuildSlaveSupport/build.webkit.org-config/config.json:
799
800 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
801
802         Unreviewed build fix after r160548.
803
804         * Scripts/webkitdirs.pm:
805         (setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
806
807 2013-12-13  Lucas Forschler  <lforschler@apple.com>
808
809         Update Apple bots.
810         
811         Unreviewed.
812
813         * BuildSlaveSupport/build.webkit.org-config/config.json:
814
815 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
816
817         [Win] Switch WebKit solution to Visual Studio 2013
818         https://bugs.webkit.org/show_bug.cgi?id=125192
819
820         Reviewed by Anders Carlsson.
821
822         Project files must reference vs12_xp for 32-bit builds. 
823
824         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
825         Update for VS2013
826         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
827         Ditto
828         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
829         Ditto
830         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
831         Ditto
832         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
833         Ditto
834         * Scripts/webkitdirs.pm:
835         (visualStudioInstallDir): Specify VS2013
836         (visualStudioVersion): Ditto.
837         (setupAppleWinEnv): Use VS2013 in messages
838         (setupCygwinEnv): Ditto
839         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
840         Update for VS2013
841         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
842         Ditto
843         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
844         Ditto
845         * win/record-memory/record-memory.vcxproj:
846         Ditto
847
848 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
849
850         Adding a .ycm_extra_conf file for webkitGtk
851         https://bugs.webkit.org/show_bug.cgi?id=119618
852
853         Reviewed by Gustavo Noronha Silva.
854
855         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
856         read the GTK+ build files to determine dynamically what flags to compile a source
857         file with. This allows Vim to provide auto-complete for C++/C language. See
858         https://github.com/Valloric/YouCompleteMe for how to use this file.
859
860         * gtk/common.py:
861         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
862         * gtk/ycm_extra_conf.py: Added.
863
864 2013-12-12  Tim Horton  <timothy_horton@apple.com>
865
866         [wk2] Handle pinch-to-zoom gesture
867         https://bugs.webkit.org/show_bug.cgi?id=125604
868
869         Reviewed by Simon Fraser.
870
871         * MiniBrowser/mac/WK2BrowserWindowController.m:
872         (-[WK2BrowserWindowController awakeFromNib]):
873         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
874
875 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
876
877         Unreviewed. Add myself as a committer.
878
879         * Scripts/webkitpy/common/config/contributors.json:
880
881 2013-12-12  Lucas Forschler  <lforschler@apple.com>
882
883         Update hardware for Apple bots.
884         
885         Unreviewed.
886
887         * BuildSlaveSupport/build.webkit.org-config/config.json:
888
889 2013-12-12  Lucas Forschler  <lforschler@apple.com>
890
891         Remove unused Apple Bots.
892         
893         Unreviewed.
894
895         * BuildSlaveSupport/build.webkit.org-config/config.json:
896
897 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
898
899         Unreviewed. Add myself as a committer.
900
901         * Scripts/webkitpy/common/config/contributors.json:
902
903 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
904
905         Test new JSContext name APIs
906         https://bugs.webkit.org/show_bug.cgi?id=125607
907
908         Reviewed by Darin Adler.
909
910         * Scripts/run-javascriptcore-tests:
911         Remove trailing whitespace.
912
913 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
914
915         [Autotools] Prepend the WebCore layer archives' names with 'lib'
916         https://bugs.webkit.org/show_bug.cgi?id=125627
917
918         Reviewed by Martin Robinson.
919
920         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
921         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
922
923 2013-12-12  Commit Queue  <commit-queue@webkit.org>
924
925         Unreviewed, rolling out r160446.
926         http://trac.webkit.org/changeset/160446
927         https://bugs.webkit.org/show_bug.cgi?id=125630
928
929         The upower-glib-based implementation is using API that was
930         recently removed (Requested by zdobersek1 on #webkit).
931
932         * Scripts/webkitperl/FeatureList.pm:
933
934 2013-12-12  Commit Queue  <commit-queue@webkit.org>
935
936         Unreviewed, rolling out r160417.
937         http://trac.webkit.org/changeset/160417
938         https://bugs.webkit.org/show_bug.cgi?id=125629
939
940         The patch is causing crashes (Requested by zdobersek1 on
941         #webkit).
942
943         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
944         (axObjectEventListener):
945         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
946
947 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
948
949         Use of ar T option not supported by older binutils
950         https://bugs.webkit.org/show_bug.cgi?id=118732
951
952         Reviewed by Gustavo Noronha Silva.
953
954         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
955         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
956         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
957         of the member's object file, and not the full path to it. To work around that, all the object files
958         under the build directory are listed by their relative paths. The members of various archives then have
959         the basenames of their paths grepped against that list, with the found path correlating to the member
960         finally added as the new member of the WebCoreLayer archive.
961
962 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
963
964         check-webkit-style shouldn't check spacing in #if preprocessor lines
965         https://bugs.webkit.org/show_bug.cgi?id=125534
966
967         Reviewed by Ryosuke Niwa.
968
969         Preprocessor lines that start with #if shouldn't have to adhere to
970         the same spacing requirements that regular code does
971
972         * Scripts/webkitpy/style/checkers/cpp.py:
973         (check_spacing):
974         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
975         (CppStyleTest.test_spacing_for_binary_ops):
976         (WebKitStyleTest.test_line_breaking):
977
978 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
979
980         check-webkit-style can't determine if a comma is part of an initialization list
981         https://bugs.webkit.org/show_bug.cgi?id=125537
982
983         Reviewed by Darin Adler.
984
985         The original check to make sure that initialization list lines start with
986         a comma didn't distinguish between commas that belong to the initialization
987         list and commas that are part of function calls. Because we don't want to
988         match parentheses with regular expressions, we should weaken this check to
989         only check for commas at the end of initialization list lines.
990
991         * Scripts/webkitpy/style/checkers/cpp.py:
992         (check_member_initialization_list):
993         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
994         (WebKitStyleTest.test_member_initialization_list):
995
996 2013-12-11  Tim Horton  <timothy_horton@apple.com>
997
998         Make it possible to compare layout test results between various configurations of WebKit
999         https://bugs.webkit.org/show_bug.cgi?id=125212
1000         <rdar://problem/15199108>
1001
1002         Reviewed by Darin Adler.
1003
1004         * Scripts/compare-webkit-configurations: Added.
1005         Add a script that allows comparison between the "normal" WebKit configuration
1006         used for testing and a different configuration (e.g. with accelerated drawing
1007         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
1008
1009         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
1010
1011         This script runs the tests once in the default configuration, ignoring
1012         all test expectations, writing the results out to a temporary directory.
1013
1014         It then runs the tests again in the modified configuration, against the
1015         just-written temporary results.
1016
1017         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
1018
1019         * DumpRenderTree/mac/DumpRenderTree.mm:
1020         (resetWebPreferencesToConsistentValues):
1021         (initializeGlobalsFromCommandLineOptions):
1022         Enable accelerated drawing if requested.
1023
1024         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1025         (parse_args):
1026         Add --accelerated-drawing and --remote-layer-tree feature switches, which
1027         are forwarded on to the test drivers.
1028         Move those two and --complex-text into their own "feature switches" section.
1029         Drive-by change "Mac OS X" to "OS X".
1030         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
1031         as traditional pixel tests (with PNGs dumped on disk), and
1032         ignores e.g. -expected.html files.
1033
1034         * Scripts/webkitpy/port/base.py:
1035         (Port.reference_files):
1036         Pretend that there are no ref tests.
1037         Since is_reference_html_file is intact, our mechanism to ignore
1038         the expected files will continue working in this case.
1039
1040         * Scripts/webkitpy/port/driver.py:
1041         (Driver.cmd_line):
1042         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
1043
1044         * WebKitTestRunner/TestController.cpp:
1045         (WTR::TestController::TestController):
1046         (WTR::TestController::initialize):
1047         (WTR::TestController::resetPreferencesToConsistentValues):
1048         * WebKitTestRunner/TestController.h:
1049         (WTR::TestController::shouldUseRemoteLayerTree):
1050         * WebKitTestRunner/TestInvocation.cpp:
1051         (WTR::updateThreadedScrollingForCurrentTest):
1052         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1053         (WTR::PlatformWebView::PlatformWebView):
1054         Parse and implement the three feature switches.
1055
1056 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1057
1058         [ATK] Expose accessibility objects WAI-ARIA landmark roles
1059         https://bugs.webkit.org/show_bug.cgi?id=125584
1060
1061         Reviewed by Chris Fleizach.
1062
1063         Add mappings to DRT & WKTR for landmark roles.
1064
1065         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1066         (AccessibilityUIElement::role):
1067         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1068         (WTR::AccessibilityUIElement::role):
1069         * gtk/jhbuild.modules:
1070
1071 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
1072
1073         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
1074         https://bugs.webkit.org/show_bug.cgi?id=125441
1075
1076         Reviewed by Martin Robinson.
1077
1078         Just avoid the double quotations when building the parameter
1079         because some versions of valgrind are not handling it correctly.
1080
1081         * Scripts/webkitpy/port/gtk.py:
1082         (GtkPort.setup_environ_for_server):
1083
1084 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
1085
1086         [GTK] Enable Battery Status API
1087         https://bugs.webkit.org/show_bug.cgi?id=125453
1088
1089         Reviewed by Martin Robinson.
1090
1091         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
1092
1093 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1094
1095         [GTK][WK2] Add the WebKitBatteryProvider class
1096         https://bugs.webkit.org/show_bug.cgi?id=115720
1097
1098         Reviewed by Martin Robinson.
1099
1100         * gtk/generate-gtkdoc:
1101         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
1102
1103 2013-12-11  Mark Rowe  <mrowe@apple.com>
1104
1105         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
1106
1107         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
1108         to build and maintain this custom Perl module.
1109
1110         Reviewed by Anders Carlsson.
1111
1112         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
1113         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
1114         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
1115         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
1116         * DumpRenderTree/mac/PerlSupport/Makefile: Removed.
1117         * Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
1118         build DumpRenderTree.
1119         (dumpToolDidCrash): Stop importing and using the module.
1120         * Scripts/webkitpy/port/base.py:
1121         (Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
1122
1123 2013-12-11  Brendan Long  <b.long@cablelabs.com>
1124
1125         [GTK] Add "enable-mediasource" property to WebKitWebSettings
1126         https://bugs.webkit.org/show_bug.cgi?id=125566
1127
1128         Reviewed by Philippe Normand.
1129
1130         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1131         (resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
1132         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1133         (TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
1134
1135 2013-12-11  Dan Bernstein  <mitz@apple.com>
1136
1137         [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
1138         https://bugs.webkit.org/show_bug.cgi?id=125579
1139
1140         Reviewed by Anders Carlsson.
1141
1142         * MiniBrowser/mac/WK2BrowserWindowController.m:
1143         (-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
1144         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
1145         activeURL property changes, update the URL field with its value.
1146         (-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
1147         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
1148         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1149         Ditto.
1150         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
1151         Ditto.
1152         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1153         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1154
1155 2013-12-11  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1156
1157         Fixed test-wepkitpy logging for buildslaves
1158         https://bugs.webkit.org/show_bug.cgi?id=125445
1159
1160         Reviewed by Csaba Osztrogonác.
1161
1162         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1163         (RunPythonTests):
1164
1165 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1166
1167         Programmatically-inserted children lack accessibility events
1168         https://bugs.webkit.org/show_bug.cgi?id=100275
1169
1170         Reviewed by Chris Fleizach.
1171
1172         Update DRT and WebKitTestRunner to handle the children-changed
1173         signal properly, considering the detail and optional parameters.
1174
1175         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
1176         (axObjectEventListener):
1177         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
1178
1179 2013-12-03  Mark Rowe  <mrowe@apple.com>
1180
1181         <https://webkit.org/b/125139> Modernize the WebKit API headers
1182         <rdar://problem/15540175>
1183
1184         Reviewed by Anders Carlsson.
1185
1186         * DumpRenderTree/mac/TestRunnerMac.mm:
1187         (TestRunner::setCacheModel): Cast to the enum type.
1188
1189 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
1190
1191         Get rid of forward exit on DoubleAsInt32
1192         https://bugs.webkit.org/show_bug.cgi?id=125552
1193
1194         Reviewed by Oliver Hunt.
1195         
1196         Add some support for testing the generic (non-X86) paths on X86 by disabling
1197         architecture-specific optimizations (ASO's).
1198
1199         * Scripts/run-javascriptcore-tests:
1200         * Scripts/run-jsc-stress-tests:
1201
1202 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
1203
1204         Unreviewed EFL build fix attempt
1205
1206         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
1207         * WebKitTestRunner/CMakeLists.txt: Ditto.
1208
1209 2013-12-10  Anders Carlsson  <andersca@apple.com>
1210
1211         Add a HashMap constructor that takes an initializer list
1212         https://bugs.webkit.org/show_bug.cgi?id=125551
1213
1214         Reviewed by Dan Bernstein.
1215
1216         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1217         (TestWebKitAPI::TEST):
1218
1219 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1220
1221         Use std::array when computing MD5 checksum
1222         https://bugs.webkit.org/show_bug.cgi?id=125509
1223
1224         Reviewed by Anders Carlsson.
1225
1226         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
1227
1228         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1229         (computeMD5HashStringForBitmapContext):
1230         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
1231         (computeMD5HashStringForBitmapContext):
1232         * TestWebKitAPI/Tests/WTF/MD5.cpp:
1233         (TestWebKitAPI::expectMD5):
1234         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1235         (WTR::computeMD5HashStringForCairoSurface):
1236         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1237         (WTR::computeMD5HashStringForContext):
1238
1239 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
1240
1241         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
1242         https://bugs.webkit.org/show_bug.cgi?id=125522
1243
1244         Reviewed by Chris Fleizach.
1245
1246         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
1247
1248         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1249         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1250
1251 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1252
1253         Add --makeargs option to build-jsc
1254         https://bugs.webkit.org/show_bug.cgi?id=125344
1255
1256         Reviewed by Filip Pizlo.
1257
1258         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
1259
1260 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
1261
1262         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
1263         https://bugs.webkit.org/show_bug.cgi?id=125497
1264
1265         Reviewed by Mario Sanchez Prada.
1266
1267         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1268         (AccessibilityUIElement::stringForRange): Implemented.
1269         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1270         (WTR::AccessibilityUIElement::stringForRange): Implemented.
1271
1272 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
1273
1274         Various fixes for the CMake GTK+ build
1275
1276         Reviewed by Gustavo Noronha.
1277
1278         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
1279         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
1280
1281 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
1282
1283         --cloop option does not work in Tools/Scripts/build-jsc.
1284         https://bugs.webkit.org/show_bug.cgi?id=125214
1285
1286         Reviewed by Csaba Osztrogonác.
1287
1288         * Scripts/build-jsc:
1289
1290 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1291
1292         Merge mark_for_landing and mark_for_commit_queue into one argument
1293         https://bugs.webkit.org/show_bug.cgi?id=125448
1294
1295         Reviewed by Ryosuke Niwa.
1296
1297         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1298         (CommitQueueFlag):
1299         (Bugzilla._commit_queue_flag):
1300         (Bugzilla._fill_attachment_form):
1301         (Bugzilla.add_patch_to_bug):
1302         (Bugzilla.create_bug):
1303         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1304         (test_commit_queue_flag.assert_commit_queue_flag):
1305         (test_commit_queue_flag):
1306
1307 2013-12-09  Tim Horton  <timothy_horton@apple.com>
1308
1309         Remove dead extract_reference_link.py (and the reftests module)
1310         https://bugs.webkit.org/show_bug.cgi?id=125116
1311
1312         Reviewed by Ryosuke Niwa.
1313
1314         This code doesn't seem to have ever been used.
1315
1316         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
1317         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
1318         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
1319
1320 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1321
1322         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
1323         https://bugs.webkit.org/show_bug.cgi?id=125456
1324
1325         Reviewed by Chris Fleizach.
1326
1327         Return 'AXSection' for section roles instead of 'AXDiv'.
1328
1329         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1330         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1331
1332 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
1333
1334         check-webkit-style should check for extra newlines at EOF
1335         https://bugs.webkit.org/show_bug.cgi?id=125424
1336
1337         Reviewed by Darin Adler.
1338
1339         Report a style violation if extraneous newlines are added
1340         to the end of a C++ file. There should only be one newline at EOF.
1341
1342         * Scripts/webkitpy/style/checkers/cpp.py:
1343         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
1344         (check_for_extra_new_line_at_eof): Added.
1345         (_process_lines): Added new check and renamed existing EOF check.
1346         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1347         (CppStyleTest.test_extra_newlines_at_eof): Added.
1348         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
1349
1350 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1351
1352         check-webkit-style: ternary operator in macro call identified as initialization list
1353         https://bugs.webkit.org/show_bug.cgi?id=125443
1354
1355         Reviewed by Ryosuke Niwa.
1356
1357         Do not match initialization list when questionmark is placed before :
1358
1359         * Scripts/webkitpy/style/checkers/cpp.py:
1360         (check_member_initialization_list):
1361
1362 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
1363
1364         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
1365         https://bugs.webkit.org/show_bug.cgi?id=125451
1366
1367         Reviewed by Mario Sanchez Prada.
1368
1369         Create the needed callbacks for DRT and WKTR.
1370
1371         * DumpRenderTree/AccessibilityUIElement.cpp:
1372         (characterAtOffsetCallback): added
1373         (wordAtOffsetCallback): added
1374         (lineAtOffsetCallback): added
1375         (sentenceAtOffsetCallback): added
1376         (AccessibilityUIElement::getJSClass):
1377         * DumpRenderTree/AccessibilityUIElement.h:
1378         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1379         (stringAtOffset): added
1380         (AccessibilityUIElement::characterAtOffset): added
1381         (AccessibilityUIElement::wordAtOffset): added
1382         (AccessibilityUIElement::lineAtOffset): added
1383         (AccessibilityUIElement::sentenceAtOffset): added
1384         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1385         (WTR::AccessibilityUIElement::characterAtOffset): added
1386         (WTR::AccessibilityUIElement::wordAtOffset): added
1387         (WTR::AccessibilityUIElement::lineAtOffset): added
1388         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1389         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1390         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1391         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1392         (WTR::stringAtOffset): added
1393         (WTR::AccessibilityUIElement::characterAtOffset): added
1394         (WTR::AccessibilityUIElement::wordAtOffset): added
1395         (WTR::AccessibilityUIElement::lineAtOffset): added
1396         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1397
1398 2013-12-08  Sam Weinig  <sam@webkit.org>
1399
1400         32-bit MiniBrowser doesn't build
1401         https://bugs.webkit.org/show_bug.cgi?id=125420
1402
1403         Reviewed by Dan Bernstein.
1404
1405         * MiniBrowser/mac/AppDelegate.h:
1406         * MiniBrowser/mac/AppDelegate.m:
1407         (-[BrowserAppDelegate init]):
1408         (-[BrowserAppDelegate applicationWillTerminate:]):
1409
1410 2013-12-08  Brian Holt  <brian.holt@samsung.com>
1411
1412         [WK2] Add ENABLE_NETWORK_PROCESS flag
1413         https://bugs.webkit.org/show_bug.cgi?id=125421
1414
1415         Add support to build with the Network Process enabled.
1416
1417         Reviewed by Martin Robinson.
1418
1419         * Scripts/webkitperl/FeatureList.pm:
1420
1421 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
1422
1423         Fold typedArray.length if typedArray is constant
1424         https://bugs.webkit.org/show_bug.cgi?id=125252
1425
1426         Reviewed by Sam Weinig.
1427         
1428         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
1429         should put tests that run just like JSRegress but don't run as part of LayoutTests.
1430         Currently I'm using it for tests that require some surgical support from jsc.cpp.
1431
1432         * Scripts/run-javascriptcore-tests:
1433
1434 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1435
1436         [gdb] Update printers for WTF::CString, JSC::JSString
1437         https://bugs.webkit.org/show_bug.cgi?id=124600
1438
1439         Reviewed by Gustavo Noronha Silva.
1440
1441         Update the two printers after they fell behind the changes in implementation.
1442
1443         * gdb/webkit.py:
1444         (WTFCStringPrinter.to_string):
1445         (JSCJSStringPrinter.to_string):
1446
1447 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1448
1449         [webkitpy] Add a WestonDriver unit test
1450         https://bugs.webkit.org/show_bug.cgi?id=125408
1451
1452         Reviewed by Gustavo Noronha Silva.
1453
1454         Add a webkitpy unit test for the Weston driver.
1455
1456         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
1457         (WestonDriverTest):
1458         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
1459         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
1460         the server environment contains proper WAYLAND and GDK_BACKEND entries.
1461         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
1462         the driver cleans up the temporary directory.
1463         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
1464         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
1465
1466 2013-12-08  Brendan Long  <b.long@cablelabs.com>
1467
1468         [Gtk] install-dependencies doesn't install libgtk-3-dev
1469         https://bugs.webkit.org/show_bug.cgi?id=125320
1470
1471         Reviewed by Gustavo Noronha Silva.
1472
1473         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
1474
1475 2013-12-07  Sam Weinig  <sam@webkit.org>
1476
1477         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
1478         https://bugs.webkit.org/show_bug.cgi?id=125401
1479
1480         Reviewed by Dan Bernstein.
1481
1482         * MiniBrowser/mac/WK2BrowserWindowController.m:
1483         (-[WK2BrowserWindowController fetch:]):
1484         (-[WK2BrowserWindowController reload:]):
1485         (-[WK2BrowserWindowController goBack:]):
1486         (-[WK2BrowserWindowController goForward:]):
1487         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
1488         (-[WK2BrowserWindowController currentZoomFactor]):
1489         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
1490         (-[WK2BrowserWindowController zoomIn:]):
1491         (-[WK2BrowserWindowController zoomOut:]):
1492         (-[WK2BrowserWindowController canResetZoom]):
1493         (-[WK2BrowserWindowController resetZoom:]):
1494         (-[WK2BrowserWindowController toggleZoomMode:]):
1495         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
1496
1497 2013-12-07  Sam Weinig  <sam@webkit.org>
1498
1499         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
1500         https://bugs.webkit.org/show_bug.cgi?id=125400
1501
1502         Reviewed by Dan Bernstein.
1503
1504         * MiniBrowser/mac/AppDelegate.h:
1505         * MiniBrowser/mac/AppDelegate.m:
1506         * MiniBrowser/mac/WK2BrowserWindowController.h:
1507         * MiniBrowser/mac/WK2BrowserWindowController.m:
1508         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
1509         (-[WK2BrowserWindowController dealloc]):
1510         (createNewPage):
1511         (-[WK2BrowserWindowController awakeFromNib]):
1512         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
1513         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
1514         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
1515         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
1516         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
1517         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
1518
1519 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1520
1521         [GTK] Run each gtest subtest separately instead of in one go
1522         https://bugs.webkit.org/show_bug.cgi?id=125386
1523
1524         Reviewed by Martin Robinson.
1525
1526         This is what other ports are doing (except they build each test as a separate binary)
1527         and will help with the timeouts we sometimes hit because it applies to the full test
1528         run.
1529
1530         * Scripts/run-gtk-tests:
1531         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
1532         (TestRunner._run_google_test): run a single subtest from a gtest binary.
1533         (TestRunner._run_google_test_suite): call the binary once per subtest.
1534
1535 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1536
1537         Move PrettyPatch related code to prettypatch.py
1538         https://bugs.webkit.org/show_bug.cgi?id=124937
1539
1540         Reviewed by Ryosuke Niwa.
1541
1542         This code seems to have a better place here than in Port, since PrettyPatch already knows
1543         pretty_patch_path, and this also unifies the usage of PrettyPatch
1544
1545         * Scripts/webkitpy/common/prettypatch.py:
1546         (PrettyPatch.__init__):
1547         (PrettyPatch.pretty_diff):
1548         (PrettyPatch):
1549         (PrettyPatch.pretty_patch_available):
1550         (PrettyPatch.check_pretty_patch):
1551         (PrettyPatch.pretty_patch_text):
1552         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1553         (TestResultWriter.create_text_diff_and_write_result):
1554         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1555         (summarize_results):
1556         * Scripts/webkitpy/port/base.py:
1557         (Port.__init__):
1558         (Port.wdiff_available):
1559         (Port.check_image_diff):
1560         (Port.wdiff_text):
1561         * Scripts/webkitpy/port/base_unittest.py:
1562         (PortTest.test_pretty_patch_os_error):
1563         (PortTest.test_pretty_patch_script_error):
1564
1565 2013-12-06  Dan Bernstein  <mitz@apple.com>
1566
1567         [Mac] MiniBrowser Debug builds are compiled with -Os
1568         https://bugs.webkit.org/show_bug.cgi?id=125376
1569
1570         Reviewed by Tim Horton.
1571
1572         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
1573         the Debug configuration at the project level.
1574
1575 2013-12-06  Jer Noble  <jer.noble@apple.com>
1576
1577         [MSE] Add a runtime-setting for the MediaSource constructor.
1578         https://bugs.webkit.org/show_bug.cgi?id=125336
1579
1580         Reviewed by Eric Carlson.
1581
1582         Enable MediaSource in DRT and WKTR.
1583
1584         * DumpRenderTree/mac/DumpRenderTree.mm:
1585         (resetWebPreferencesToConsistentValues):
1586         * WebKitTestRunner/TestController.cpp:
1587         (WTR::TestController::resetPreferencesToConsistentValues):
1588
1589 2013-12-06  Jer Noble  <jer.noble@apple.com>
1590
1591         Strip out extraneous logging from AppleGVA in media tests.
1592         https://bugs.webkit.org/show_bug.cgi?id=125357
1593
1594         Reviewed by Simon Fraser.
1595
1596         Add a mechanism for stripping out abritrary regular expressions from test input and output.
1597
1598         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1599         (SingleTestRunner._run_compare_test): Strip out logging
1600         * Scripts/webkitpy/port/base.py:
1601         (Port.logging_patterns_to_strip): Return an empty list by default.
1602         * Scripts/webkitpy/port/driver.py:
1603         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
1604         * Scripts/webkitpy/port/mac.py:
1605         (MacPort.logging_patterns_to_strip): Return a complete list.
1606
1607 2013-12-06  Dean Jackson  <dino@apple.com>
1608
1609         Updating ANGLE should point to instructions
1610         https://bugs.webkit.org/show_bug.cgi?id=125361
1611
1612         Reviewed by Eric Carlson.
1613
1614         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
1615         someone wants to patch ANGLE.
1616
1617         * Scripts/webkitpy/common/config/watchlist:
1618
1619 2013-12-06  Dan Bernstein  <mitz@apple.com>
1620
1621         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
1622         https://bugs.webkit.org/show_bug.cgi?id=125334
1623
1624         Reviewed by Darin Adler.
1625
1626         * MiniBrowser/mac/WK2BrowserWindowController.m:
1627         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
1628         title property.
1629         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
1630         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
1631         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
1632         window title with the title property changes.
1633         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
1634         set the load delegate instead of the load client.
1635         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
1636         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
1637         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
1638         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
1639         Implemented this load delegate method.
1640         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1641         Ditto.
1642         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
1643         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1644         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
1645         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1646         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
1647         Ditto.
1648         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
1649         Ditto.
1650         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
1651
1652 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1653
1654         Remove function from style/checkers/cpp.py.
1655         https://bugs.webkit.org/show_bug.cgi?id=125341
1656
1657         Reviewed by Darin Adler.
1658
1659         Corrects a FIXME: by removing a function from cpp.py.
1660
1661         * Scripts/webkitpy/style/checkers/cpp.py:
1662         (CppChecker.__init__):
1663         (CppChecker.check):
1664         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1665         (CppStyleTestBase.process_file_data):
1666
1667 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1668
1669         check-webkit-style: false positive warning for indentation of #ifdef code.
1670         https://bugs.webkit.org/show_bug.cgi?id=125254
1671
1672         Reviewed by Darin Adler.
1673
1674         * Scripts/webkitpy/style/checkers/cpp.py:
1675         (check_member_initialization_list):
1676         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1677         (WebKitStyleTest.test_member_initialization_list):
1678
1679 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
1680
1681         Fix spelling error in style checker: beggining
1682         https://bugs.webkit.org/show_bug.cgi?id=125347
1683
1684         Reviewed by Anders Carlsson.
1685
1686         * Scripts/webkitpy/style/checkers/cpp.py:
1687         (check_member_initialization_list):
1688         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1689         (WebKitStyleTest.test_member_initialization_list):
1690
1691 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
1692
1693         [ATK] Missing aria roles mappings
1694         https://bugs.webkit.org/show_bug.cgi?id=117729
1695
1696         Reviewed by Mario Sanchez Prada.
1697
1698         Added new mappings to AccessibilityUIElementAtk.cpp.
1699
1700         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1701         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1702
1703 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1704
1705         Typo fix after r160218.
1706
1707         * Scripts/webkitpy/test/main.py:
1708         (main):
1709
1710 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1711
1712         Unreviewed fix after r160206.
1713
1714         * Scripts/webkitpy/test/main.py:
1715         (main): sys.platform can be win32 or cygwin too on Windows.
1716
1717 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
1718
1719         Disable WebKit2 webkitpy unittests on Windows
1720         https://bugs.webkit.org/show_bug.cgi?id=125318
1721
1722         Reviewed by Ryosuke Niwa.
1723
1724         * Scripts/webkitpy/test/main.py:
1725         (main):
1726
1727 2013-12-05  Anders Carlsson  <andersca@apple.com>
1728
1729         Tweak WeakObjCPtr
1730         https://bugs.webkit.org/show_bug.cgi?id=125311
1731
1732         Reviewed by Darin Adler.
1733
1734         Split up tests into more logical groups. Add new tests for new functionality.
1735
1736         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1737
1738 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1739
1740         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
1741         https://bugs.webkit.org/show_bug.cgi?id=125302
1742
1743         Reviewed by Philippe Normand.
1744
1745         * gtk/generate-webkitdom-doc-files:
1746         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
1747         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
1748         and WEBKIT_DEPRECATED_FOR macros.
1749
1750 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1751
1752         Fix cross compilation on x86
1753         https://bugs.webkit.org/show_bug.cgi?id=125295
1754
1755         Reviewed by Zoltan Herczeg.
1756
1757         Certain compiler flags should not be added when cross compilation is enabled.
1758
1759         * Scripts/webkitdirs.pm:
1760         (runAutogenForAutotoolsProjectIfNecessary):
1761         (generateBuildSystemFromCMakeProject):
1762
1763 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1764
1765         Remove duplicated/dead code from cpp style checker unit tests.
1766         https://bugs.webkit.org/show_bug.cgi?id=125226
1767
1768         Reviewed by Ryosuke Niwa.
1769
1770         Remove the first definition of OrderOfIncludesTest class as it is
1771         overwritten by the second. Remove a duplicated assert statement
1772         from the second class.
1773
1774         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1775         (OrderOfIncludesTest.setUp):
1776         (OrderOfIncludesTest.test_try_drop_common_suffixes):
1777           The last assert was duplicated.
1778
1779 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
1780
1781         Remove Scripts/generate-qt-inspector-resource.
1782         https://bugs.webkit.org/show_bug.cgi?id=125288
1783
1784         Reviewed by Andreas Kling.
1785
1786         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
1787         We don't need this file.
1788
1789 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1790
1791         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
1792         https://bugs.webkit.org/show_bug.cgi?id=125218
1793
1794         Reviewed by Ryosuke Niwa.
1795
1796         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1797         (LayoutTestFinder.skip_tests):
1798         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1799         (LayoutTestRunner.run_tests):
1800         (LayoutTestRunner._update_summary_with_result):
1801         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1802         (Manager._test_is_slow):
1803         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1804         (JSONLayoutResultsGenerator._insert_failure_summaries):
1805         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1806         (TestExpectations.get_rebaselining_failures):
1807         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1808         (assert_exp):
1809         (MiscTests.test_multiple_results):
1810         (MiscTests.test_category_expectations):
1811         (MiscTests.test_get_modifiers):
1812         (MiscTests.test_get_expectations_string):
1813         (MiscTests.test_expectation_to_string):
1814         (MiscTests.test_get_test_set):
1815         (MiscTests.test_more_specific_override_resets_skip):
1816         (SkippedTests.check):
1817         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1818         (TestRunResults.__init__):
1819         (summarize_results):
1820         * Scripts/webkitpy/tool/commands/rebaseline.py:
1821         (RebaselineExpectations._tests_to_rebaseline):
1822
1823 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1824
1825         Enable HTMLTemplateElement by default
1826         https://bugs.webkit.org/show_bug.cgi?id=123851
1827
1828         Reviewed by Antti Koivisto.
1829
1830         * Scripts/webkitperl/FeatureList.pm:
1831
1832 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
1833
1834         [EFL] Bumping GStreamer version to 1.2.1
1835         https://bugs.webkit.org/show_bug.cgi?id=125155
1836
1837         Reviewed by Gyuyoung Kim.
1838
1839         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
1840
1841
1842 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1843
1844         Update jhbuild revision.
1845         https://bugs.webkit.org/show_bug.cgi?id=124966
1846         
1847         Reviewed by Gyuyoung Kim.
1848
1849         Used version of Jhbuild failed to create directories and caused
1850         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
1851
1852         * jhbuild/jhbuild-wrapper:
1853
1854 2013-12-04  Anders Carlsson  <andersca@apple.com>
1855
1856         Add a WeakObjCPtr class
1857         https://bugs.webkit.org/show_bug.cgi?id=125267
1858
1859         Reviewed by Geoffrey Garen.
1860
1861         Add API tests for WeakObjCPtr.
1862
1863         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1864         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
1865         (TEST):
1866
1867 2013-12-04  Anders Carlsson  <andersca@apple.com>
1868
1869         Make the estimatedProgress property observable using KVO
1870         https://bugs.webkit.org/show_bug.cgi?id=125259
1871
1872         Reviewed by Dan Bernstein.
1873
1874         Bind the progress indicator value to the "estimatedProgress" property.
1875
1876         * MiniBrowser/mac/WK2BrowserWindowController.m:
1877         (-[WK2BrowserWindowController dealloc]):
1878         (-[WK2BrowserWindowController awakeFromNib]):
1879
1880 2013-12-04  Anders Carlsson  <andersca@apple.com>
1881
1882         Add a loading property to WKBrowsingContextController
1883         https://bugs.webkit.org/show_bug.cgi?id=125256
1884
1885         Reviewed by Dan Bernstein.
1886
1887         Bind the progress indicator visibility to the "loading" property.
1888
1889         * MiniBrowser/mac/WK2BrowserWindowController.m:
1890         (-[WK2BrowserWindowController dealloc]):
1891         (-[WK2BrowserWindowController awakeFromNib]):
1892         (-[WK2BrowserWindowController didStartProgress]):
1893         (-[WK2BrowserWindowController didFinishProgress]):
1894
1895 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
1896
1897         [EFL][WK2] Buildfix after r160104
1898         https://bugs.webkit.org/show_bug.cgi?id=125231
1899
1900         Reviewed by Anders Carlsson.
1901
1902         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1903         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
1904         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1905         (TestWebKitAPI::setViewClient): Ditto.
1906
1907 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
1908
1909         check-webkit-style detected some ternary statements as initialization lists
1910         https://bugs.webkit.org/show_bug.cgi?id=125246
1911
1912         Reviewed by Dean Jackson.
1913
1914         The regular expression that check-webkit-tests uses to detect initialization
1915         lists was too broad, resulting in false positives. This patch makes the
1916         regex more specific
1917
1918         * Scripts/webkitpy/style/checkers/cpp.py:
1919         (check_member_initialization_list):
1920         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1921         (WebKitStyleTest.test_member_initialization_list):
1922
1923 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
1924
1925         run-jsc-stress-tests can only run locally
1926         https://bugs.webkit.org/show_bug.cgi?id=124551
1927
1928         Reviewed by Filip Pizlo.
1929
1930         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
1931         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
1932         added a couple more signals to handle gracefully at shutdown. 
1933         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
1934         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
1935         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
1936         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
1937         toward the end of the script to make it easier to tell which of the various modes do what.
1938
1939 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
1940
1941         [EFL][WK2] Buildfix after r160104
1942         https://bugs.webkit.org/show_bug.cgi?id=125233
1943
1944         Reviewed by Anders Carlsson.
1945
1946         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1947         (TestWebKitAPI::TEST):
1948         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1949         (TestWebKitAPI::setPageLoaderClient):
1950
1951 2013-12-03  Anders Carlsson  <andersca@apple.com>
1952
1953         Deprecate all unversioned client structs in favor of having explicit versioned structs
1954         https://bugs.webkit.org/show_bug.cgi?id=125203
1955
1956         Reviewed by Dan Bernstein.
1957
1958         Update for WebKit2 API changes.
1959
1960         * MiniBrowser/mac/AppDelegate.m:
1961         (-[BrowserAppDelegate init]):
1962         * MiniBrowser/mac/WK2BrowserWindowController.m:
1963         (-[WK2BrowserWindowController awakeFromNib]):
1964         * TestWebKitAPI/InjectedBundleController.cpp:
1965         (TestWebKitAPI::InjectedBundleController::initialize):
1966         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1967         (TestWebKitAPI::TEST):
1968         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1969         (TestWebKitAPI::setInjectedBundleClient):
1970         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
1971         (TestWebKitAPI::TEST):
1972         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1973         (TestWebKitAPI::TEST):
1974         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1975         (TestWebKitAPI::TEST):
1976         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1977         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
1978         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1979         (TestWebKitAPI::TEST):
1980         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1981         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
1982         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
1983         (TestWebKitAPI::setInjectedBundleClient):
1984         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1985         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1986         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1987         (TestWebKitAPI::TEST):
1988         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1989         (TestWebKitAPI::TEST):
1990         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1991         (TestWebKitAPI::setContextDownloadClient):
1992         (TestWebKitAPI::setPagePolicyClient):
1993         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1994         (TestWebKitAPI::TEST):
1995         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1996         (TestWebKitAPI::TEST):
1997         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1998         (TestWebKitAPI::TEST):
1999         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2000         (TestWebKitAPI::TEST):
2001         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2002         (TestWebKitAPI::TEST):
2003         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2004         (TestWebKitAPI::TEST):
2005         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2006         (TestWebKitAPI::setupGeolocationProvider):
2007         (TestWebKitAPI::setupView):
2008         (TestWebKitAPI::TEST):
2009         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
2010         (TestWebKitAPI::TEST):
2011         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2012         (TestWebKitAPI::setPageLoaderClient):
2013         (TestWebKitAPI::setInjectedBundleClient):
2014         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2015         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
2016         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2017         (TestWebKitAPI::TEST):
2018         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
2019         (TestWebKitAPI::setInjectedBundleClient):
2020         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2021         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
2022         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
2023         (TestWebKitAPI::TEST):
2024         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
2025         (TestWebKitAPI::TEST):
2026         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2027         (TestWebKitAPI::TEST):
2028         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2029         (TestWebKitAPI::TEST):
2030         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2031         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
2032         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
2033         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2034         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2035         (TestWebKitAPI::setPageLoaderClient):
2036         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2037         (TestWebKitAPI::setPageLoaderClient):
2038         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2039         (TestWebKitAPI::setPageLoaderClient):
2040         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2041         (TestWebKitAPI::setPageLoaderClient):
2042         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2043         (TestWebKitAPI::setPageLoaderClient):
2044         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2045         (TestWebKitAPI::TEST):
2046         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2047         (TestWebKitAPI::TEST):
2048         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
2049         (TestWebKitAPI::setInjectedBundleClient):
2050         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
2051         (TestWebKitAPI::ParentFrameTest::didCreatePage):
2052         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
2053         (TestWebKitAPI::setInjectedBundleClient):
2054         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
2055         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
2056         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2057         (TestWebKitAPI::TEST):
2058         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
2059         (TestWebKitAPI::TEST):
2060         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2061         (TestWebKitAPI::TEST):
2062         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
2063         (TestWebKitAPI::TEST):
2064         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2065         (TestWebKitAPI::setInjectedBundleClient):
2066         (TestWebKitAPI::setPageLoaderClient):
2067         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2068         (TestWebKitAPI::setPageLoaderClient):
2069         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2070         (TestWebKitAPI::TEST):
2071         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
2072         (TestWebKitAPI::setPageLoaderClient):
2073         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
2074         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
2075         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2076         (TestWebKitAPI::TEST):
2077         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
2078         (TestWebKitAPI::TEST):
2079         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
2080         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
2081         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
2082         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
2083         (TestWebKitAPI::TEST):
2084         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
2085         (TestWebKitAPI::WKConnectionTest::initialize):
2086         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
2087         (TestWebKitAPI::setPageLoaderClient):
2088         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2089         (TestWebKitAPI::setInjectedBundleClient):
2090         (TestWebKitAPI::TEST):
2091         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2092         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
2093         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2094         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
2095         (TestWebKitAPI::setInjectedBundleClient):
2096         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
2097         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
2098         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
2099         (TestWebKitAPI::TEST):
2100         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
2101         (TestWebKitAPI::setInjectedBundleClient):
2102         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2103         (TestWebKitAPI::TEST):
2104         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2105         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
2106         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
2107         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
2108         (TestWebKitAPI::didCreateConnection):
2109         (TestWebKitAPI::TEST):
2110         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2111         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2112         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
2113         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2114         (TestWebKitAPI::setPageLoaderClient):
2115         * WebKitTestRunner/GeolocationProviderMock.cpp:
2116         (WTR::GeolocationProviderMock::GeolocationProviderMock):
2117         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2118         (WTR::InjectedBundle::initialize):
2119         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2120         (WTR::InjectedBundlePage::InjectedBundlePage):
2121         * WebKitTestRunner/TestController.cpp:
2122         (WTR::TestController::createOtherPage):
2123         (WTR::TestController::initialize):
2124         (WTR::TestController::createWebViewWithOptions):
2125
2126 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2127
2128         Style checker for .messages.in files (WTF:: prefix)
2129         https://bugs.webkit.org/show_bug.cgi?id=125142
2130
2131         Reviewed by Anders Carlsson.
2132
2133         A new style checker for .messages.in files, that checks for the use of WTF::
2134         prefix in these files. (Also checks for tabs as these files were previously
2135         handled as text files.)
2136
2137         * Scripts/webkitpy/style/checker.py:
2138         (CheckerDispatcher._create_checker):
2139           New checker is returned for .messages.in files.
2140         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
2141           The new style checker class.
2142         (MessagesInChecker):
2143         (MessagesInChecker.__init__):
2144         (MessagesInChecker.check):
2145         (MessagesInChecker.check_WTF_prefix):
2146         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
2147           Unit test for the new style  checker class.
2148         (MessagesInCheckerStyleTestCase):
2149         (test_checker):
2150         (test_checker.error_handler_for_test):
2151         (MessagesInCheckerTestCase):
2152         (MessagesInCheckerTestCase.test_init):
2153         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
2154
2155 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2156
2157         Style checker requires alphabetical ordering in cmake lists even it contains variable.
2158         https://bugs.webkit.org/show_bug.cgi?id=124918
2159
2160         Reviewed by Csaba Osztrogonác.
2161
2162         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2163         (CMakeCheckerTest.test_check):
2164         * Scripts/webkitpy/style/checkers/cmake.py:
2165         (CMakeChecker._check_list_order):
2166         This will ignore lines with variable substitution.
2167
2168 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2169
2170         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
2171         https://bugs.webkit.org/show_bug.cgi?id=124731
2172
2173         Reviewed by Zoltan Herczeg.
2174
2175         * Scripts/webkitpy/style/checkers/cpp.py:
2176         (check_spacing):
2177         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2178         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
2179
2180 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2181
2182         Remove codecs and os dependencies from filereader.py in webkitpy/style.
2183         https://bugs.webkit.org/show_bug.cgi?id=124719
2184
2185         Although TextFileReader requires a FileSystem it circumvents it in two places!
2186         We should use the FileSystem only and remove codecs and os imports.
2187
2188         Reviewed by Zoltan Herczeg.
2189
2190         * Scripts/webkitpy/common/system/filesystem.py:
2191         (FileSystem.open_stdin): Moved from TextFileReader
2192         * Scripts/webkitpy/style/filereader.py:
2193         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
2194         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
2195
2196 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2197
2198         check-webkit-style should check member initialization indentation.
2199         https://bugs.webkit.org/show_bug.cgi?id=124820
2200
2201         Reviewed by Zoltan Herczeg.
2202
2203         check-webkit-style should check member initialization indentation
2204         belongs to webkit coding style:
2205         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
2206
2207         * Scripts/webkitpy/style/checkers/cpp.py:
2208         (check_member_initialization_list): Add new method to check member
2209         initialization list.
2210         (check_style): Add the call of the new method.
2211         (check_language): Move self initialization checking into the new method.
2212         (CppChecker): Add a new category for initialization list.
2213         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2214         (CppStyleTest.test_runtime_selfinit):
2215         (CppStyleTest.test_deprecated_cast):
2216         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
2217         the new feature.
2218
2219 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
2220
2221         style-bot should reject Committer additions to committers.py
2222         https://bugs.webkit.org/show_bug.cgi?id=107574
2223
2224         Reviewed by Zoltan Herczeg.
2225
2226         The style check when executed in non-interactive mode (probably by a
2227         bot) will raise an additional error if the contributors.json file is
2228         modified. Non-interactive mode information is propagated to the
2229         Dispatcher, which creates a special JSON checker for the
2230         contributors.json file.
2231
2232         * Scripts/webkitpy/style/checker.py:
2233         (check_webkit_style_configuration):
2234         (CheckerDispatcher._create_checker):
2235         (CheckerDispatcher.dispatch):
2236         (StyleProcessorConfiguration.__init__):
2237         (StyleProcessor.process):
2238         * Scripts/webkitpy/style/checker_unittest.py:
2239         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
2240         (CheckerDispatcherDispatchTest.dispatch):
2241         (StyleProcessorConfigurationTest._style_checker_configuration):
2242         (StyleProcessor_EndToEndTest.test_init):
2243         (StyleProcessor_EndToEndTest.test_process):
2244         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
2245         (StyleProcessor_CodeCoverageTest.setUp):
2246         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2247         (JSONChecker.line_number_from_json_exception):
2248         (JSONContributorsChecker):
2249         (JSONContributorsChecker.check):
2250         * Scripts/webkitpy/style/error_handlers_unittest.py:
2251         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2252         * Scripts/webkitpy/style/optparser.py:
2253         (CommandOptionValues.__init__):
2254         (ArgumentParser._create_option_parser):
2255         (ArgumentParser.parse):
2256         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2257         (test_post):
2258         (test_upload):
2259         * Scripts/webkitpy/tool/steps/checkstyle.py:
2260         (CheckStyle.run):
2261
2262 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
2263
2264         [EFL][WK2] Fix build after API::Client changes
2265         https://bugs.webkit.org/show_bug.cgi?id=125206
2266
2267         Reviewed by Csaba Osztrogonác.
2268
2269         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2270         (TestWebKitAPI::TEST):
2271         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2272         (TestWebKitAPI::setViewClient):
2273
2274 2013-12-03  Dan Bernstein  <mitz@apple.com>
2275
2276         Fixed a test timing out after r160040.
2277
2278         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2279         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
2280         Updated for the delegate method rename.
2281
2282 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
2283
2284         REGRESSION: repro scripts disappear when you rerun tests
2285         https://bugs.webkit.org/show_bug.cgi?id=125184
2286
2287         Reviewed by Mark Hahnenberg.
2288         
2289         This bug made it difficult to quickly see if a test that recently failed is still
2290         failing while also running a new batch of tests.
2291
2292         Repro scripts are supposed to stay around until you delete them explicitly. This
2293         patch accomplishes that.
2294
2295         * Scripts/run-jsc-stress-tests:
2296
2297 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
2298
2299         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
2300         https://bugs.webkit.org/show_bug.cgi?id=125111
2301
2302         Reviewed by Filip Pizlo.
2303
2304         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
2305
2306         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
2307         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
2308
2309 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2310
2311         Add a script to automatically configure a git clone
2312         https://bugs.webkit.org/show_bug.cgi?id=110073
2313
2314         Revert the change to use https for now since git.webkit.org is setup with http.
2315
2316         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2317         (SetupGitClone.execute):
2318
2319 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2320
2321         Add a script to automatically configure a git clone
2322         https://bugs.webkit.org/show_bug.cgi?id=110073
2323
2324         Reviewed by Benjamin Poulain.
2325
2326         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
2327
2328         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
2329
2330         * Scripts/webkitpy/tool/commands/__init__.py:
2331         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
2332         (SetupGitClone):
2333         (SetupGitClone.execute):
2334
2335 2013-12-03  Anders Carlsson  <andersca@apple.com>
2336
2337         Deprecate WKNotificationProvider
2338         https://bugs.webkit.org/show_bug.cgi?id=125178
2339
2340         Reviewed by Sam Weinig.
2341
2342         Update for WebKit2 changes.
2343
2344         * WebKitTestRunner/TestController.cpp:
2345         (WTR::TestController::initialize):
2346         * WebKitTestRunner/WebNotificationProvider.cpp:
2347         (WTR::WebNotificationProvider::provider):
2348         * WebKitTestRunner/WebNotificationProvider.h:
2349
2350 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
2351
2352         [Win] Support 64-bit Application Support Libraries Location 
2353         https://bugs.webkit.org/show_bug.cgi?id=125179
2354
2355         Reviewed by Tim Horton.
2356
2357         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
2358         on Windows until an official distribution is available that properly creates registry settings
2359         to specify these locations.
2360
2361         * Scripts/webkitdirs.pm:
2362         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
2363         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
2364         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
2365         running 64-bit builds.
2366
2367 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
2368
2369         run-jsc-stress-tests only supports host environments that have make installed
2370         https://bugs.webkit.org/show_bug.cgi?id=124550
2371
2372         Reviewed by Darin Adler.
2373
2374         This might not be the case for all hosts, so this patch implements an alternate "backend" 
2375         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
2376         least somewhat competitive with the make-based test runner, the shell backend uses subshells
2377         run in the background to allow tests to run in parallel. Since the concurrency primitives 
2378         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
2379         of the make-based runner.
2380
2381         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
2382         the bundle and controls all of the parallel aspects of the shell-based test runner.
2383         * Scripts/run-jsc-stress-tests:
2384
2385 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2386
2387         Remove function from TextChecker
2388         https://bugs.webkit.org/show_bug.cgi?id=125148
2389
2390         Reviewed by Darin Adler.
2391
2392         The process_file_data is used only from the unit tests, so it is simply moved there.
2393
2394         * Scripts/webkitpy/style/checkers/text.py:
2395         (TextChecker.check):
2396         * Scripts/webkitpy/style/checkers/text_unittest.py:
2397         (TextStyleTestCase.process_file_data):
2398         (TextStyleTestCase.assertNoError):
2399         (TextStyleTestCase.assertError):
2400
2401 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2402
2403         Remove get_test() and reference test names directly instead.
2404         https://bugs.webkit.org/show_bug.cgi?id=124962
2405
2406         Reviewed by Csaba Osztrogonác.
2407
2408         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2409         (Base.__init__):
2410         (Base.get_basic_tests):
2411         (assert_exp):
2412         (MiscTests.test_multiple_results):
2413         (MiscTests.test_category_expectations):
2414         (MiscTests.test_get_modifiers):
2415         (MiscTests.test_get_expectations_string):
2416         (MiscTests.test_get_test_set):
2417         (MiscTests.test_parse_warning):
2418         (MiscTests.test_pixel_tests_flag.match):
2419
2420 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2421
2422         Style Checker false pass.
2423         https://bugs.webkit.org/show_bug.cgi?id=112456
2424
2425         Reviewed by Csaba Osztrogonác.
2426
2427         * Scripts/webkitpy/style/checkers/changelog.py:
2428         (ChangeLogChecker.check_entry):
2429         simple regex fix to check "No new tests (...)."
2430         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2431         (ChangeLogCheckerTest.test_no_new_tests):
2432
2433 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
2434
2435         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
2436         https://bugs.webkit.org/show_bug.cgi?id=125130
2437
2438         Reviewed by Geoffrey Garen.
2439
2440         * Scripts/run-jsc-stress-tests:
2441
2442 2013-12-02  Samuel White  <samuel_white@apple.com>
2443
2444         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
2445         https://bugs.webkit.org/show_bug.cgi?id=124561
2446
2447         Reviewed by Chris Fleizach.
2448
2449         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
2450
2451         * DumpRenderTree/AccessibilityUIElement.cpp:
2452         (uiElementCountForSearchPredicateCallback):
2453         (uiElementForSearchPredicateCallback):
2454         (AccessibilityUIElement::getJSClass):
2455         * DumpRenderTree/AccessibilityUIElement.h:
2456         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2457         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2458         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2459         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2460         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2461         (searchPredicateParameterizedAttributeForSearchCriteria):
2462         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2463         (AccessibilityUIElement::uiElementForSearchPredicate):
2464         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2465         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2466         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2467         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2468         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2469         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2470         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2471         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2472         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2473         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2474         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2475         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2476
2477 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2478
2479         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
2480         https://bugs.webkit.org/show_bug.cgi?id=124714
2481
2482         Reviewed by Ryosuke Niwa.
2483
2484         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2485         (write_test_result):
2486         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2487         (TestFailure.write_failure):
2488         (FailureText):
2489         (FailureText.write_failure):
2490         (FailureAudio):
2491         (FailureAudio.write_failure):
2492         (FailureCrash.write_failure):
2493         (FailureMissingResult):
2494         (FailureTextMismatch):
2495         (FailureMissingImageHash.write_failure):
2496         (FailureMissingImage.write_failure):
2497         (FailureImageHashMismatch.write_failure):
2498         (FailureReftestMismatch.write_failure):
2499         (FailureReftestMismatchDidNotOccur.write_failure):
2500         (FailureMissingAudio):
2501         (FailureAudioMismatch):
2502
2503 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
2504
2505         Remove the stderr_write attribute from StyleProcessorConfiguration
2506         https://bugs.webkit.org/show_bug.cgi?id=124703
2507
2508         Reviewed by Ryosuke Niwa.
2509
2510         Remove the stderr_write attribute from this class in checker and
2511         replace its use with calls to a logging module logger. We Should 
2512         use logging module instead of writing to stderr directly.
2513
2514         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
2515         (check_webkit_style_configuration):
2516         (CheckerDispatcher.dispatch): Remove FIXME comment.
2517         (StyleProcessorConfiguration):
2518         (StyleProcessorConfiguration.__init__):
2519         (StyleProcessorConfiguration.write_style_error):
2520         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
2521         There is an "ERROR" prefix in log messiges from now.
2522         (StyleProcessorConfigurationTest):
2523         (StyleProcessorConfigurationTest._style_checker_configuration):
2524         (StyleProcessorConfigurationTest.test_init):
2525         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
2526         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
2527         (StyleProcessor_EndToEndTest.with):
2528         (StyleProcessor_EndToEndTest.test_init):
2529         (StyleProcessor_EndToEndTest.test_process):
2530         (StyleProcessor_CodeCoverageTest.setUp):
2531         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
2532         (DefaultStyleErrorHandler.__call__):
2533         * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.
2534         There is an "ERROR" prefix in log messiges from now.
2535         (DefaultStyleErrorHandlerTest):
2536         (DefaultStyleErrorHandlerTest.setUp):
2537         (DefaultStyleErrorHandlerTest._mock_increment_error_count):
2538         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2539         (DefaultStyleErrorHandlerTest._check_initialized):
2540         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
2541         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
2542         (DefaultStyleErrorHandlerTest.test_line_numbers):
2543
2544 2013-12-02  Brian J. Burg  <burg@cs.washington.edu>
2545
2546         Add JavaScript style checker and teach checker.py about .js files
2547         https://bugs.webkit.org/show_bug.cgi?id=125049
2548
2549         Reviewed by Joseph Pecoraro.
2550
2551         Add a JavaScript file type, extension, and checker (JSChecker).
2552         Use TextChecker for JavaScript tests, libraries, website resources,
2553         etc. and use JSChecker for files within WebInspectorUI/UserInterface.
2554
2555         Amended tests for TextChecker to reflect the rule above.
2556
2557         * Scripts/webkitpy/style/checker.py:
2558         (_all_categories): Add categories defined by JSChecker.
2559         (FileType): Add file type for JS and re-number the enum.
2560         (CheckerDispatcher._file_type): Detect .js files as JavaScript.
2561         (CheckerDispatcher._create_checker):
2562         Create a JSChecker or TextChecker depending on the file's path.
2563
2564         * Scripts/webkitpy/style/checker_unittest.py:
2565         (CheckerDispatcherDispatchTest.assert_checker_js): Added.
2566         (CheckerDispatcherDispatchTest.test_js_paths): Added.
2567         (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
2568         that end in .js but should be checked with TextChecker.
2569         * Scripts/webkitpy/style/checkers/js.py: Added.
2570         (JSChecker):
2571         (JSChecker.__init__):
2572         (JSChecker.check):
2573         * Scripts/webkitpy/style/checkers/js_unittest.py: Added.
2574         (JSTestCase):
2575         (JSTestCase.assertNoError):
2576         (JSTestCase.assertNoError.error_for_test):
2577         (JSTestCase.assertError):
2578         (JSTestCase.assertError.error_for_test):
2579         (JSTestCase.test_no_error):
2580         (JSTestCase.test_error):
2581
2582 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2583
2584         run-jsc-stress-tests always copies the VM
2585         https://bugs.webkit.org/show_bug.cgi?id=125092
2586
2587         Reviewed by Filip Pizlo.
2588
2589         This can be slow, especially with full debug builds. It should just symlink the VM into the 
2590         bundle by default and do a full copy only when asked.
2591
2592         * Scripts/run-jsc-stress-tests:
2593
2594 2013-12-02  Brent Fulgham  <bfulgham@apple.com>
2595
2596         [Win] Port run-jsc-stress-tests
2597         https://bugs.webkit.org/show_bug.cgi?id=124801
2598
2599         Reviewed by Filip Pizlo.
2600
2601         * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
2602         command on Windows so that stress tests can run.
2603
2604 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2605
2606         Build fix after r159955
2607
2608         * Scripts/run-jsc-stress-tests:
2609
2610 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2611
2612         run-jsc-stress-tests should be able to package its tests and move them places
2613         https://bugs.webkit.org/show_bug.cgi?id=124549
2614
2615         Reviewed by Filip Pizlo.
2616
2617         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
2618         of grep -i -q
2619         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2620         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
2621         We now also copy whatever VM was specified, along with its associated framework, into this directory.
2622         All of the generated scripts now are completely relative within the results directory. This allows
2623         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
2624         tarball of the generated results directory. Also refactored several portions of the script into
2625         separate functions to make it easier to run them conditionally depending on which mode we're running in. 
2626
2627 2013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
2628
2629         [ATK] Support active state for listbox elements.
2630         https://bugs.webkit.org/show_bug.cgi?id=125009
2631
2632         Reviewed by Chris Fleizach.
2633
2634         Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
2635
2636         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2637         (AccessibilityUIElement::isSelectedOptionActive):
2638         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2639         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2640         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2641         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2642         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2643         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2644         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2645         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2646
2647 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
2648
2649         Unreviewed GTK gardening.
2650
2651         * Scripts/run-gtk-tests:
2652         (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
2653
2654 2013-12-01  Dan Bernstein  <mitz@apple.com>
2655
2656         [Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
2657         https://bugs.webkit.org/show_bug.cgi?id=125046
2658
2659         Reviewed by Sam Weinig.
2660
2661         * MiniBrowser/mac/AppDelegate.m:
2662         (-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
2663         (-[BrowserAppDelegate openDocument:]): Ditto.
2664         * MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
2665         interface to the implementation.
2666         * MiniBrowser/mac/WK2BrowserWindowController.m:
2667         (-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
2668         the policy client.
2669         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
2670         Moved policy client implementation into this delegate method.
2671         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
2672         Ditto.
2673         (-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
2674         Ditto.
2675
2676 2013-12-01  Dan Bernstein  <mitz@apple.com>
2677
2678         [Mac] Remove the MiniBrowser injected bundle
2679         https://bugs.webkit.org/show_bug.cgi?id=125041
2680
2681         Reviewed by Anders Carlsson.
2682
2683         It had no ops!
2684
2685         * MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
2686         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2687         * MiniBrowser/mac/AppDelegate.m:
2688         (-[BrowserAppDelegate init]):
2689         * MiniBrowser/mac/WebBundle/Info.plist: Removed.
2690         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2691
2692 2013-11-29  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2693
2694         check-webkit-style should check for extraneous newline between config.h and primary header.
2695         https://bugs.webkit.org/show_bug.cgi?id=124821
2696
2697         Reviewed by Csaba Osztrogonác.
2698
2699         * Scripts/webkitpy/style/checkers/cpp.py:
2700         (check_include_line):
2701         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2702         (OrderOfIncludesTest.test_check_line_break_after_own_header):
2703         (OrderOfIncludesTest):
2704         (OrderOfIncludesTest.test_check_line_break_before_own_header):
2705
2706 2013-11-29  Jozsef Berta  <jberta@inf.u-szeged.hu>
2707
2708         test-webkit-scripts should show the failing tests and use an appropriate exit code
2709         https://bugs.webkit.org/show_bug.cgi?id=124840
2710
2711         Reviewed by Ryosuke Niwa.
2712
2713         A fixme in test-webkit-scripts asked that the script should display success or failiure
2714         and exit with a 0 or 1 value accordingly after all of the tests have completed.
2715
2716         * Scripts/test-webkit-scripts:
2717         (ScriptsTester.run_test_script):
2718         The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
2719         because at this point we don't need to pass on more information other than success or failiure.
2720         (ScriptsTester.main):
2721         The return values are now stored for each script and when all tests have completed successfully,
2722         the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
2723
2724 2013-11-29  Krzysztof Czech  <k.czech@samsung.com>
2725
2726         [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
2727         https://bugs.webkit.org/show_bug.cgi?id=124923
2728
2729         Reviewed by Mario Sanchez Prada.
2730
2731         Added missing implementation of isAttributeSettable. Using
2732         ATK_STATE_EDITABLE for checking whether attribute is settable.
2733
2734         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2735         (AccessibilityUIElement::isAttributeSettable):
2736         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2737         (WTR::AccessibilityUIElement::isAttributeSettable):
2738
2739 2013-11-28  Commit Queue  <commit-queue@webkit.org>
2740
2741         Unreviewed, rolling out r159839.
2742         http://trac.webkit.org/changeset/159839
2743         https://bugs.webkit.org/show_bug.cgi?id=124974
2744
2745         run-webkit-tests doesn't generate pretty diff (Requested by
2746         Ossy on #webkit).
2747
2748         * Scripts/webkitpy/common/prettypatch.py:
2749         (PrettyPatch.__init__):
2750         (PrettyPatch.pretty_diff):
2751         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2752         (TestResultWriter.create_text_diff_and_write_result):
2753         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2754         (summarize_results):
2755         * Scripts/webkitpy/port/base.py:
2756         (Port.__init__):
2757         (Port.pretty_patch_available):
2758         (Port.check_pretty_patch):
2759         (Port.variable):
2760         (Port.variable.pretty_patch_text):
2761         * Scripts/webkitpy/port/base_unittest.py:
2762         (PortTest.test_pretty_patch_os_error):
2763         (PortTest.test_pretty_patch_script_error):
2764
2765 2013-11-28  Antti Koivisto  <antti@apple.com>
2766
2767         Remove feature: CSS variables
2768         https://bugs.webkit.org/show_bug.cgi?id=114119
2769
2770         Reviewed by Andreas Kling.
2771
2772         * Scripts/webkitperl/FeatureList.pm:
2773
2774 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2775
2776         Move PrettyPatch related code to prettypatch.py
2777         https://bugs.webkit.org/show_bug.cgi?id=124937
2778
2779         Reviewed by Ryosuke Niwa.
2780
2781         This code seems to have a better place here than in Port, since PrettyPatch already knows
2782         pretty_patch_path, and this also unifies the usage of PrettyPatch
2783
2784         * Scripts/webkitpy/common/prettypatch.py:
2785         (PrettyPatch.__init__):
2786         (PrettyPatch.pretty_diff):
2787         (PrettyPatch):
2788         (PrettyPatch.pretty_patch_available):
2789         (PrettyPatch.check_pretty_patch):
2790         (PrettyPatch.pretty_patch_text):
2791         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2792         (TestResultWriter.create_text_diff_and_write_result):
2793         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2794         (summarize_results):
2795         * Scripts/webkitpy/port/base.py:
2796         (Port.__init__):
2797         (Port.wdiff_available):
2798         (Port.check_image_diff):
2799         (Port.wdiff_text):
2800         * Scripts/webkitpy/port/base_unittest.py:
2801         (PortTest.test_pretty_patch_os_error):
2802         (PortTest.test_pretty_patch_script_error):
2803
2804 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2805
2806         Checkout should own the scm object in Host
2807         https://bugs.webkit.org/show_bug.cgi?id=124943
2808
2809         Reviewed by Ryosuke Niwa.
2810
2811         * Scripts/webkitpy/common/host.py:
2812         (Host.__init__):
2813         (Host.initialize_scm):
2814         (Host.scm):
2815
2816 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2817
2818         Do bytecode validation as part of testing
2819         https://bugs.webkit.org/show_bug.cgi?id=124913
2820
2821         Reviewed by Oliver Hunt.
2822
2823         * Scripts/run-jsc-stress-tests:
2824
2825 2013-11-27  Andres Gomez  <agomez@igalia.com>
2826
2827         [GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
2828         https://bugs.webkit.org/show_bug.cgi?id=124940
2829
2830         Reviewed by Martin Robinson.
2831
2832         xserver-font-utils is needed for building gtk port dependencies
2833         with jhbuild.
2834
2835         * gtk/install-dependencies: Added xserver-font-utils to jhbuild
2836         dependecies.
2837
2838 2013-11-27  Andres Gomez  <agomez@igalia.com>
2839
2840         [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
2841         https://bugs.webkit.org/show_bug.cgi?id=124938
2842
2843         Reviewed by Philippe Normand.
2844
2845         Added needed git dependency for building the gtk port with
2846         jhbuild. Also, the dependencies needed for building the gtk port
2847         are now sorted alphabetically.
2848
2849         * gtk/install-dependencies: Added git as jhbuild dependency and
2850         sorted dependencies alphabetically.
2851
2852 2013-11-27  Jozsef Berta  <jberta@inf.u-szeged.hu>
2853
2854         run_webkit_tests.py: error: no such option: --wincairo
2855         https://bugs.webkit.org/show_bug.cgi?id=124927
2856
2857         Reviewed by Ryosuke Niwa.
2858
2859         * BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
2860         the layout testing on wincairo, so it is turned off.
2861
2862 2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>
2863
2864         Nix upstreaming - Adding build files and supporting scripts
2865         https://bugs.webkit.org/show_bug.cgi?id=118367
2866
2867         Reviewed by Ryosuke Niwa.
2868
2869         * Scripts/build-webkit:
2870         * Scripts/run-nix-tests: Added.
2871         * Scripts/run-webkit-tests:
2872         * Scripts/update-webkit-libs-jhbuild:
2873         * Scripts/update-webkitnix-libs: Added.
2874         * Scripts/webkitdirs.pm:
2875         (determineArchitecture):
2876         (argumentsForConfiguration):
2877         (jscProductDir):
2878         (builtDylibPathForName):
2879         (determineIsNix):
2880         (isNix):
2881         (isAppleWebKit):
2882         (launcherPath):
2883         (launcherName):
2884         (checkRequiredSystemConfig):
2885         (copyInspectorFrontendFiles):
2886         (jhbuildWrapperPrefixIfNeeded):
2887         (buildCMakeProjectOrExit):
2888         (cmakeBasedPortName):
2889         * Scripts/webkitpy/common/config/ports.py:
2890         (DeprecatedPort.port):
2891         (EflWK2Port.build_webkit_command):
2892         (NixPort):
2893         (NixPort.build_webkit_command):
2894         * Scripts/webkitpy/port/factory.py:
2895         (platform_options):
2896         (PortFactory):
2897         * Scripts/webkitpy/port/nix.py: Added.
2898         (NixPort):
2899         (NixPort._wk2_port_name):
2900         (NixPort.determine_full_port_name):
2901         (NixPort.__init__):
2902         (NixPort._port_flag_for_scripts):
2903         (NixPort.setup_test_run):
2904         (NixPort.setup_environ_for_server):
2905         (NixPort.default_timeout_ms):
2906         (NixPort.clean_up_test_run):
2907         (NixPort._generate_all_test_configurations):
2908         (NixPort._path_to_driver):
2909         (NixPort._path_to_image_diff):
2910         (NixPort._image_diff_command):
2911         (NixPort._search_paths):
2912         (NixPort.show_results_html_file):
2913         (NixPort._port_specific_expectations_files):
2914         (NixPort.default_baseline_search_path):
2915         * Scripts/webkitpy/port/nix_unittest.py: Added.
2916         (NixPortTest):
2917         (NixPortTest._assert_search_path):
2918         (NixPortTest._assert_expectations_files):
2919         (NixPortTest.test_baseline_search_path):
2920         (NixPortTest.test_expectations_files):
2921         (NixPortTest.test_default_timeout_ms):
2922         * jhbuild/jhbuild-wrapper:
2923         (determine_platform):
2924         * nix/common.py: Added.
2925         (script_path):
2926         (top_level_path):
2927         * nix/jhbuild.modules: Added.
2928         * nix/jhbuildrc: Added.
2929
2930 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2931
2932         Record subtest values in Dromaeo tests
2933         https://bugs.webkit.org/show_bug.cgi?id=124498
2934
2935         Reviewed by Andreas Kling.
2936
2937         Supported parsing subtest results.
2938
2939         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
2940         which contains a dictionary with its name and an ordered list of subtest's metrics.
2941         (PerfTest.__init__): Initialize _metrics as a list.
2942         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
2943         (PerfTest._run_with_driver):
2944         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
2945
2946         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2947         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
2948         (TestPerfTest.test_parse_output): Ditto.
2949         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
2950         assertions to ensure subtest results are parsed properly.
2951         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
2952         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
2953
2954         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2955         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
2956         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
2957         adding new results.
2958
2959         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2960         (TestWithSubtestsData): Added.
2961         (TestDriver.run_test):
2962         (MainTest.test_run_test_with_subtests): Added.
2963
2964 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2965
2966         Enable HTML template element on Windows ports
2967         https://bugs.webkit.org/show_bug.cgi?id=124758
2968
2969         Reviewed by Andreas Kling.
2970
2971         * Scripts/webkitperl/FeatureList.pm:
2972
2973 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2974
2975         Remove replay performance tests as it's not actively maintained
2976         https://bugs.webkit.org/show_bug.cgi?id=124764
2977
2978         Reviewed by Andreas Kling.
2979
2980         Removed the feature.
2981
2982         * Scripts/webkitpy/performance_tests/perftest.py:
2983         (SingleProcessPerfTest.__init__):
2984         (PerfTestFactory):
2985         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2986         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2987         (PerfTestsRunner._parse_args):
2988         (PerfTestsRunner._collect_tests):
2989         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2990         (MainTest.test_collect_tests_with_ignored_skipped_list):
2991         (MainTest.test_default_args):
2992         * Scripts/webkitpy/thirdparty/__init__.py:
2993         (AutoinstallImportHook.find_module):
2994         (AutoinstallImportHook._install_unittest2):
2995         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2996         (ThirdpartyTest.test_imports):
2997
2998 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2999
3000         Enable aggressive DFG validation in testing
3001         https://bugs.webkit.org/show_bug.cgi?id=124911
3002
3003         Rubber stamped by Ryosuke Niwa.
3004         
3005         This enables validation testing in non-concurrent-JIT runs.
3006
3007         * Scripts/run-jsc-stress-tests:
3008
3009 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3010
3011         Moved methods which belong to Checkout into checkout.py
3012         https://bugs.webkit.org/show_bug.cgi?id=124889
3013
3014         Reviewed by Ryosuke Niwa.
3015
3016         * Scripts/webkitpy/common/checkout/checkout.py:
3017         (Checkout.scripts_directory):
3018         (Checkout):
3019         (Checkout.script_path):
3020         (Checkout.commit_message_for_this_commit):
3021         (Checkout.apply_patch):
3022         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3023         (test_commit_message_for_this_commit):
3024         (CheckoutTest.test_apply_patch):
3025         * Scripts/webkitpy/common/checkout/scm/scm.py:
3026         (SCM.absolute_path):
3027         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3028         (SCMTest._setup_webkittools_scripts_symlink):
3029         * Scripts/webkitpy/common/checkout/scm/svn.py:
3030         (SVN.create_patch):
3031
3032 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
3033
3034         [EFL] Use Config mode of find_package for EFL 1.8
3035         https://bugs.webkit.org/show_bug.cgi?id=124555
3036
3037         Reviewed by Gyuyoung Kim.
3038
3039         * MiniBrowser/efl/CMakeLists.txt:
3040         Added optional config mode and made version requirement optional.
3041
3042 2013-11-25  Andres Gomez  <agomez@igalia.com>
3043
3044         [GTK] Search functionality in MiniBrowser provides feedback on search fail
3045         https://bugs.webkit.org/show_bug.cgi?id=122681
3046
3047         Reviewed by Mario Sanchez Prada.
3048
3049         When using the search functionality in MiniBrowser, if the search
3050         fails, the entry background color gets red to report the user
3051         about the failing condition. When the entry is cleaned or the
3052         search is again succesful the background turns back to its
3053         original color.
3054
3055         * MiniBrowser/gtk/BrowserSearchBar.c:
3056         (setFailedStyleForEntry): Added.
3057         (doSearch): Sets the entry's background to its original style if
3058         there is no text to search.
3059         (findControllerFailedToFindTextCallback): Added.
3060         (findControllerFoundTextCallback): Added.
3061         (browser_search_bar_init): Creates and adds a new CSS provider to
3062         the text entry so we can change its style based on the success
3063         condition of the search.
3064         (browserSearchBarFinalize): Frees the new CSS provider.
3065         (browser_search_bar_new): Connects the two new handlers to the
3066         "failed-to-find-text" and "found-text" signals emitted by the
3067         WebKitFindController.
3068
3069 2013-11-25  Dan Bernstein  <mitz@apple.com>
3070
3071         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
3072         https://bugs.webkit.org/show_bug.cgi?id=124850
3073
3074         Reviewed by Brady Eidson.
3075
3076         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
3077
3078         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3079         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3080         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3081         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3082         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3083         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3084         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3085
3086 2013-11-25  Commit Queue  <commit-queue@webkit.org>
3087
3088         Unreviewed, rolling out r159752 and r159754.
3089         http://trac.webkit.org/changeset/159752
3090         http://trac.webkit.org/changeset/159754
3091         https://bugs.webkit.org/show_bug.cgi?id=124847
3092
3093         Broke linux test bots. (Requested by mhahnenberg on #webkit).
3094
3095         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
3096         * Scripts/run-javascriptcore-tests:
3097         * Scripts/run-jsc-stress-tests:
3098
3099 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
3100
3101         Followup fix after r159752
3102
3103         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
3104
3105 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
3106
3107         run-jsc-stress-tests should be able to package its tests and move them places
3108         https://bugs.webkit.org/show_bug.cgi?id=124549
3109
3110         Reviewed by Filip Pizlo.
3111
3112         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
3113         of grep -i -q
3114         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
3115         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
3116         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
3117         All of the generated scripts now are completely relative within the results directory. This allows 
3118         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
3119         tarball of the generated results directory. Also refactored several portions of the script into 
3120         separate functions to make it easier to run them conditionally depending on which mode we're running in.
3121
3122 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
3123
3124         EWS creates 0 byte sized log files
3125         https://bugs.webkit.org/show_bug.cgi?id=107606
3126
3127         Reviewed by Ryosuke Niwa.
3128
3129         There was a modification in r138264, that tried to make less log,
3130         because some of the messeges were duplicated. After this the EWS
3131         created the log file (with the same name as the bugID) but doesn't
3132         write anything into it, even if there were errors during the build.
3133         From now only creates the log file only if there is some error.
3134
3135         * Scripts/webkitpy/tool/bot/queueengine.py:
3136         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
3137         there is nothing to log. Open the log file only if a ScriptError was raised to
3138         avoid to make empty log files for bugs.
3139         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
3140         because of changes in r138264. Teeing is used for locally testing purposes and
3141         this feature is not used anymore.
3142         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
3143         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
3144         change.
3145         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3146         (LoggingDelegate): The order of the callbacks was changed by this patch.
3147         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
3148         so we have to update this test.
3149         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
3150         this patch.
3151         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3152         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
3153         to be able to handle it in QueueEngine.run. Without this change, the existing
3154         exception handler never run (the process_work_item method never raise ScriptError)
3155         We can get the error message only from the ScriptError at this point.
3156
3157 2013-11-22  Dean Jackson  <dino@apple.com>
3158
3159         Speculative Mountain Lion build fix.
3160
3161         * MiniBrowser/mac/AppDelegate.m:
3162         (-[BrowserAppDelegate openDocument:]):
3163
3164 2013-11-22  Anders Carlsson  <andersca@apple.com>
3165
3166         Fix Mountain Lion bug.
3167
3168         * MiniBrowser/mac/AppDelegate.m:
3169         (-[BrowserAppDelegate openDocument:]):
3170
3171 2013-11-22  Anders Carlsson  <andersca@apple.com>
3172
3173         MiniBrowser should use the blocks-based NSOpenPanel API
3174         https://bugs.webkit.org/show_bug.cgi?id=124786
3175
3176         Reviewed by Simon Fraser.
3177
3178         * MiniBrowser/mac/AppDelegate.m:
3179         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3180         Account for windows that don't have a BrowserWindowController.
3181
3182         (-[BrowserAppDelegate openDocument:]):
3183
3184 2013-11-22  Commit Queue  <commit-queue@webkit.org>
3185
3186         Unreviewed, rolling out r159690.
3187         http://trac.webkit.org/changeset/159690
3188         https://bugs.webkit.org/show_bug.cgi?id=124782
3189
3190         Broke webkitpy tests (Requested by ap on #webkit).
3191
3192         * Scripts/webkitpy/tool/bot/queueengine.py:
3193         (QueueEngine.run):
3194         (QueueEngine._open_work_log):
3195         (QueueEngine._ensure_work_log_closed):
3196         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3197         (AbstractEarlyWarningSystem.review_patch):
3198
3199 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
3200
3201         EWS creates 0 byte sized log files
3202         https://bugs.webkit.org/show_bug.cgi?id=107606
3203
3204         Reviewed by Ryosuke Niwa.
3205
3206         There was a modification in r138264, that tried to make less log, 
3207         because some of the messeges were duplicated. After this the EWS 
3208         created the log file (with the same name as the bugID) but doesn't 
3209         write anything into it, even if there were errors during the build. 
3210         From now only creates the log file only if there is some error.
3211
3212         * Scripts/webkitpy/tool/bot/queueengine.py:
3213         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
3214         there is nothing to log. Open the log file only if a ScriptError was raised to
3215         avoid to make empty log files for bugs.
3216         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
3217         because of changes in r138264. Teeing is used for locally testing purposes and
3218         this feature is not used anymore.
3219         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
3220         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
3221         change.
3222         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3223         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
3224         to be able to handle it in QueueEngine.run. Without this change, the existing
3225         exception handler never run (the process_work_item method never raise ScriptError)
3226         We can get the error message only from the ScriptError at this point.
3227
3228 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3229
3230         Remove ENABLE_WORKERS
3231         https://bugs.webkit.org/show_bug.cgi?id=105784
3232
3233         Reviewed by Darin Adler.
3234
3235         * Scripts/webkitperl/FeatureList.pm:
3236
3237 2013-11-21  Darin Adler  <darin@apple.com>
3238
3239         Try to fix buildbot Dashboard for people who have not hidden anything.
3240
3241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3242         Add a null check for hidden platforms.
3243
3244 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
3245
3246         Remove chrome/chromium related things from webkitpy.
3247         https://bugs.webkit.org/show_bug.cgi?id=124493
3248
3249         Reviewed by Darin Adler.
3250
3251         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3252         (PortTest.assert_mock_port_works):
3253         * Scripts/webkitpy/port/base.py:
3254         (Port.to.setup_environ_for_server):
3255         * Scripts/webkitpy/port/mac_unittest.py:
3256         (test_tests_for_other_platforms):
3257         * Scripts/webkitpy/port/mock_drt.py:
3258         (MockTestShell.output_for_test):
3259         * Scripts/webkitpy/tool/bot/irc_command.py:
3260         (Restart.execute):
3261         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3262         (IRCBotTest.test_help):
3263
3264 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3265
3266         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
3267         https://bugs.webkit.org/show_bug.cgi?id=124717
3268
3269         Reviewed by Ryosuke Niwa.
3270
3271         * Scripts/webkitpy/style/filereader.py:
3272         (TextFileReader.process_file):
3273         * Scripts/webkitpy/style/filereader_unittest.py:
3274         (TextFileReaderTest.test_process_file__does_not_exist):
3275
3276 2013-11-21  Mark Rowe  <mrowe@apple.com>
3277
3278         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
3279
3280         All modern versions of Xcode set it appropriately for our needs.
3281
3282         Reviewed by Alexey Proskuryakov.
3283
3284         * MiniBrowser/Configurations/Base.xcconfig:
3285         * WebKitTestRunner/Configurations/Base.xcconfig:
3286
3287 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
3288
3289         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
3290         https://bugs.webkit.org/show_bug.cgi?id=124676
3291
3292         Reviewed by Daniel Bates.
3293
3294         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
3295         elements when there were more then one occurrence of that argument.
3296         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
3297         {b, a}, when it should be {b, c}.
3298
3299         * Scripts/webkitdirs.pm:
3300         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
3301         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
3302         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
3303
3304 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3305
3306         Update build-webkit after r159550.
3307
3308         * Scripts/webkitperl/FeatureList.pm:
3309
3310 2013-11-21  Lucas Forschler  <lforschler@apple.com>
3311
3312         Bring a new bot online, replacing the previous ones.
3313         
3314         Unreviewed.
3315
3316         * BuildSlaveSupport/build.webkit.org-config/config.json:
3317
3318 2013-11-21  Dean Jackson  <dino@apple.com>
3319
3320         Don't fetch hidden platforms on build.webkit.org/dashboard
3321         https://bugs.webkit.org/show_bug.cgi?id=124750
3322
3323         Reviewed by Tim Horton.
3324
3325         If a platform is hidden, don't fetch its data. If it
3326         becomes unhidden, try to fetch immediately (unless
3327         you've recently fetched).
3328
3329         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3331
3332 2013-11-21  Commit Queue  <commit-queue@webkit.org>
3333
3334         Unreviewed, rolling out r159633.
3335         http://trac.webkit.org/changeset/159633
3336         https://bugs.webkit.org/show_bug.cgi?id=124726
3337
3338         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
3339
3340         * Scripts/webkitpy/style/checker.py:
3341         (check_webkit_style_configuration):
3342         (CheckerDispatcher.dispatch):
3343         (StyleProcessorConfiguration):
3344         (StyleProcessorConfiguration.__init__):
3345         (StyleProcessorConfiguration.write_style_error):
3346
3347 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
3348
3349         Remove the stderr_write attribute from StyleProcessorConfiguration.
3350         https://bugs.webkit.org/show_bug.cgi?id=124703
3351
3352         Reviewed by Brent Fulgham.
3353
3354         * Scripts/webkitpy/style/checker.py:
3355         (check_webkit_style_configuration):
3356         (CheckerDispatcher.dispatch):
3357         (StyleProcessorConfiguration):
3358         (StyleProcessorConfiguration.__init__):
3359         (StyleProcessorConfiguration.write_style_error):
3360
3361 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3362
3363         PerfTestRunner._generate_results_dict shouldn't depend on test objects
3364         https://bugs.webkit.org/show_bug.cgi?id=124623
3365
3366         Removed the dependency on test objects from results JSON generation.
3367         This allows single test.run to return metrics for multiple tests
3368
3369         Reviewed by Antti Koivisto.
3370
3371         * Scripts/webkitpy/performance_tests/perftest.py:
3372         (PerfTestMetric.__init__): Takes the test path and test name.
3373         (PerfTestMetric.path): Added.
3374         (PerfTestMetric.test_file_name): Added.
3375         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
3376         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
3377         The path is going to have the names of subtests at the end once we support them.
3378
3379         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3380         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
3381         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
3382         (TestPerfTestMetric.test_has_values): Ditto.
3383         (TestPerfTestMetric.test_append): Ditto.
3384
3385         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3386         (_generate_results_dict): Only use metrics.
3387         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
3388
3389 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
3390
3391         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
3392         https://bugs.webkit.org/show_bug.cgi?id=124697
3393
3394         Reviewed by Ryosuke Niwa.
3395
3396         * Scripts/webkitdirs.pm:
3397         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
3398         before trying to access to the first element.
3399
3400 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3401
3402         [GTK] Mark all deprecated symbols in GObject DOM bindings
3403         https://bugs.webkit.org/show_bug.cgi?id=124406
3404
3405         Reviewed by Gustavo Noronha Silva.
3406
3407         * Scripts/webkitpy/style/checker.py: Add special case for
3408         WebKitDOMDeprecated.
3409         * gtk/generate-gtkdoc:
3410         (get_webkit2_options): Use the prefix of the methods as namespace,
3411         since this is what gtkdoc expects to sort the index.
3412         (get_webkit1_options): Ditto.
3413         (get_webkitdom_options): Ditto.
3414         * gtk/generate-webkitdom-doc-files:
3415         (WebKitDOMDocGenerator): Add a global list of deleted objects.
3416         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
3417         the documentation for classes that are deprecated because they
3418         have been removed.
3419         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
3420         for deleted classes too.
3421         (WebKitDOMDocGeneratorSections.__init__): Build a list of
3422         deprecated symbols using the given symbols file.
3423         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
3424         deleted class corresponding to the given function.
3425         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
3426         dictionary of deprecated symbols for every class.
3427         (WebKitDOMDocGeneratorSections.write_section): Add also the
3428         deprecated symbols in every section.
3429         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
3430         sections for deleted classes too.
3431
3432 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
3433
3434         check-webkit-style should support C++11 rvalue references.
3435         https://bugs.webkit.org/show_bug.cgi?id=123406
3436
3437         Reviewed by Brent Fulgham.
3438
3439         * Scripts/webkitpy/style/checkers/cpp.py:
3440         (check_style):
3441         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3442         (Cpp11StyleTest):
3443         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
3444
3445 2013-11-20  Dean Jackson  <dino@apple.com>
3446
3447         Allow settings to be shown/hidden on build.webkit.org/dashboard
3448         https://bugs.webkit.org/show_bug.cgi?id=124694
3449
3450         Reviewed by Tim Horton.
3451
3452         In preparation for more options/buttons, allow the page to
3453         show or hide all the interactive things using a little gear icon
3454         in the top left corner.
3455
3456         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3457         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3458         (Settings.prototype.toggleSettingsDisplay):
3459         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3460         (div.cellButton.hide):
3461         (div.cellButton.unhide):
3462         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
3463         (.settings):
3464         (.settings:hover):
3465         (.settings-visible .settings):
3466
3467 2013-11-20  Dean Jackson  <dino@apple.com>
3468
3469         No need to base64 SVG on build.webkit.org/dashboard
3470         https://bugs.webkit.org/show_bug.cgi?id=124687
3471
3472         Reviewed by Tim Horton.
3473
3474         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3475         (.status-line.good .bubble.pictogram):
3476
3477 2013-11-20  Dean Jackson  <dino@apple.com>
3478
3479         Make links look more like links on build.webkit.org/dashboard
3480         https://bugs.webkit.org/show_bug.cgi?id=124686
3481
3482         Reviewed by Tim Horton.
3483
3484         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
3485         (.queue-view .queueLabel:hover):
3486         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3487         (.status-line.linked .label:hover):
3488
3489 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
3490
3491         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
3492         https://bugs.webkit.org/show_bug.cgi?id=124581
3493
3494         Reviewed by Daniel Bates.
3495
3496         Some subroutines are replicating code from checkForArgument**
3497         functions instead of reusing them as is being done by all other functions.
3498
3499         * Scripts/webkitdirs.pm:
3500         (determineXcodeSDK): Added.
3501         (determinePassedConfiguration): Added.
3502         (determinePassedArchitecture): Added.
3503         (checkForArgumentAndRemoveFromARGV): Added.
3504         (checkForArgumentAndRemoveFromARGVGettingValue): Added.
3505
3506 2013-11-20  Jozsef Berta  <jberta@inf.u-szeged.hu>
3507
3508         Delete baseline optimizer
3509         https://bugs.webkit.org/show_bug.cgi?id=122333
3510
3511         Reviewed by Ryosuke Niwa.
3512
3513         * Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
3514         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
3515         * Scripts/webkitpy/tool/commands/rebaseline.py:
3516         (RebaselineTest.execute):
3517         (AbstractParallelRebaselineCommand._files_to_add):
3518         (AbstractParallelRebaselineCommand._rebaseline):
3519         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3520         (TestRebaselineJson.test_rebaseline_all):
3521         (TestRebaselineJson.test_rebaseline_debug):
3522         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
3523
3524 2013-11-20  Anders Carlsson  <andersca@apple.com>
3525
3526         Enable PageLoadTest assertions again
3527         https://bugs.webkit.org/show_bug.cgi?id=124681
3528
3529         Reviewed by Tim Horton.
3530
3531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3532         Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.
3533
3534 2013-11-20  Mark Rowe  <mrowe@apple.com>
3535
3536         Remove some obsolete logic from WebKit.app.
3537
3538         Reviewed by Alexey Proskuryakov.
3539
3540         * WebKitLauncher/WebKitNightlyEnabler.m:
3541         (poseAsWebKitApp): Remove a pre-10.6 codepath.
3542         (enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.
3543
3544 2013-11-20  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3545
3546         Moved stray urls from svn.py and statusserver.py into common.config.urls
3547         https://bugs.webkit.org/show_bug.cgi?id=124650
3548
3549         Reviewed by Ryosuke Niwa.
3550
3551         * Scripts/webkitpy/common/checkout/scm/svn.py:
3552         (SVNRepository):
3553         * Scripts/webkitpy/common/config/urls.py:
3554         * Scripts/webkitpy/common/net/statusserver.py:
3555         (StatusServer.__init__):
3556         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3557         (_generate_results_dict):
3558
3559 2013-11-20  Commit Queue  <commit-queue@webkit.org>
3560
3561         Unreviewed, rolling out r159496.
3562         http://trac.webkit.org/changeset/159496
3563         https://bugs.webkit.org/show_bug.cgi?id=124641
3564
3565         It caused warning and build break with cmake lower than 2.8.8
3566         (Requested by ryuan on #webkit).
3567
3568         * MiniBrowser/efl/CMakeLists.txt:
3569
3570 2013-11-20  Gabor Rapcsanyi  <rgabor@webkit.org>
3571
3572         [EFL] libseccomp-2.0.0 doesn't support ARM architecture
3573         https://bugs.webkit.org/show_bug.cgi?id=124412
3574
3575         Reviewed by Gyuyoung Kim.
3576
3577         Update libseccomp to a newer 2.1.0 version.
3578
3579         * efl/jhbuild.modules:
3580
3581 2013-11-19  Mark Rowe  <mrowe@apple.com>
3582
3583         <rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.
3584
3585         Gestalt is deprecated on recent OS X versions so we should switch off it.
3586
3587         Reviewed by Sam Weinig.
3588
3589         * WebKitLauncher/main.m:
3590         (currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
3591         (currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
3592         two components, then join them back up.
3593         (main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
3594         the version we care about.
3595
3596 2013-11-19  Commit Queue  <commit-queue@webkit.org>
3597
3598         Unreviewed, rolling out r159538.
3599         http://trac.webkit.org/changeset/159538
3600         https://bugs.webkit.org/show_bug.cgi?id=124627
3601
3602         it broke run-jsc-stress-tests (Requested by mhahnenberg on
3603         #webkit).
3604
3605         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
3606         * Scripts/run-javascriptcore-tests:
3607         * Scripts/run-jsc-stress-tests:
3608
3609 2013-11-19  Mark Hahnenberg  <mhahnenberg@apple.com>
3610
3611         run-jsc-stress-tests should be able to package its tests and move them places
3612         https://bugs.webkit.org/show_bug.cgi?id=124549
3613
3614         Reviewed by Geoff Garen and Filip Pizlo.
3615
3616         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation 
3617         of grep -i -q 
3618         * Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
3619         * Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any
3620         other files that those tests require to run in any environment along with a fixed root directory into which these
3621         files and their expected directory structure are cloned. The default Bundle class is basically 
3622         a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows 
3623         how to translate local paths to bundle paths and does all the work of moving each test file into the right place 
3624         inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle 
3625         creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests 
3626         to use MovableBundle instead of just Bundle. 
3627
3628 2013-11-19  Dan Bernstein  <mitz@apple.com>
3629
3630         <rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5
3631
3632         Rubber-stamped by Mark Rowe.
3633
3634         Reverted r156840.
3635
3636         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
3637
3638 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3639
3640         Yet another build fix. Just allow any character.
3641         There are just too many special characters to be listed here.
3642
3643         * Scripts/webkitpy/performance_tests/perftest.py:
3644         (PerfTest._lines_to_ignore_in_parser_result):
3645         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3646         (TestPerfTest.test_parse_output_with_subtests)
3647
3648 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3649
3650         Another build fix. Allow ':' in subtest names.
3651
3652         * Scripts/webkitpy/performance_tests/perftest.py:
3653         (PerfTest._lines_to_ignore_in_parser_result):
3654         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3655         (TestPerfTest.test_parse_output_with_subtests)
3656
3657 2013-11-19  Ryuan Choi  <ryuan.choi@samsung.com>
3658
3659         [EFL] Use Config mode of find_package for EFL 1.8
3660         https://bugs.webkit.org/show_bug.cgi?id=124555
3661
3662         Reviewed by Gyuyoung Kim.
3663
3664         * MiniBrowser/efl/CMakeLists.txt: Introduced a config mode to find elementary.
3665
3666 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3667
3668         Build fix. Subtest names need to be more permissive.
3669
3670         * Scripts/webkitpy/performance_tests/perftest.py:
3671         (PerfTest._lines_to_ignore_in_parser_result):
3672         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3673         (TestPerfTest.test_parse_output_with_subtests)
3674
3675 2013-11-18  Mark Rowe  <mrowe@apple.com>
3676
3677         Use hw.activecpu for determining how many processes to spawn.
3678
3679         It's documented as the preferred way to determine the number of threads
3680         or processes to create in a SMP aware application.
3681
3682         Rubber-stamped by Tim Horton.
3683
3684         * Scripts/copy-webkitlibraries-to-product-directory:
3685         * Scripts/run-jsc-stress-tests:
3686         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3687
3688 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3689
3690         build.webkit.org/dashboard builder headers should link to the builder page
3691         https://bugs.webkit.org/show_bug.cgi?id=124553
3692
3693         Reviewed by Timothy Hatcher.
3694
3695         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3696         (BuildbotQueue.prototype.get overviewURL):
3697         Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
3698
3699         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3700         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
3701         (BuildbotBuilderQueueView.prototype.update):
3702         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3703         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3704         (BuildbotTesterQueueView.prototype.update.appendBuild):
3705         (BuildbotTesterQueueView.prototype.update):
3706         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
3707         (.queue-view .queueLabel):
3708         (.queue-view .queueLabel:not(:first-child)):
3709         Make the header a link instead of a label, and wire it up to overviewURL.
3710
3711 2013-11-18  Samuel White  <samuel_white@apple.com>
3712
3713         AX: Add ability to fetch only visible table rows.
3714         https://bugs.webkit.org/show_bug.cgi?id=124430
3715
3716         Reviewed by Chris Fleizach.
3717
3718         Adding method to fetch array of AccessibilityUIElements to help with test brevity and test breakage. Specifically, we
3719         have a good deal of churn any time we add or update an element attribute. This happens because the number of tests
3720         that rely on a simple element description text dump to verify a single attribute is non trivial. So any time you
3721         change add an attribute, you have to update all the tests that are now implicitly verifying this new attribute. But
3722         as the test guidelines state, our tests should be more focused and specific about what they test.
3723
3724         * DumpRenderTree/AccessibilityUIElement.cpp:
3725         (uiElementArrayAttributeValueCallback):
3726         (AccessibilityUIElement::uiElementArrayAttributeValue):
3727         (AccessibilityUIElement::getJSClass):
3728         * DumpRenderTree/AccessibilityUIElement.h:
3729         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3730         (AccessibilityUIElement::uiElementArrayAttributeValue):
3731         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3732         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3733         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3734         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3735         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3736         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3737         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3738         (WTR::AccessibilityUIElement::getUIElementsWithAttribute):
3739         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3740
3741 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
3742
3743         Simplify and reformat the output of performance tests inside test runners
3744         https://bugs.webkit.org/show_bug.cgi?id=124496
3745
3746         Reviewed by Antti Koivisto.
3747
3748         As a preparation to support subtests for Dromaeo and DoYouEvenBench, simplify the output
3749         performance tests generate. Instead of spitting out noise in PerfTestRunner (runner.js)
3750         and ignoring it in PerfTest._filter_output (perftest.py), simply avoid generating it in
3751         the first place.
3752
3753         Also modernize the output to adopt "metric" concept better and make it forward compatible
3754         with subtests.
3755
3756         With this patch, performance tests written using runner.js only produces empty lines or
3757         lines of the following format inside test runners (DumpRenderTree and WebKitTestRunner):
3758         <subtest name> -> [<value 1>, <value 2>, ...]
3759         :<metric name> -> [<value 1>, <value 2>, ...]
3760
3761         This greatly simplifies the parsing logic inside PerfTest._run_with_driver.
3762
3763         * Scripts/webkitpy/performance_tests/perftest.py:
3764         (PerfTest): Removed a bunch of regular expressions that are no longer used.
3765         (PerfTest._run_with_driver): Just parse the values and description and treat everything
3766         else as errors.
3767
3768         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3769         (TestPerfTest.test_parse_output): Removed the junk.
3770         (TestPerfTest._assert_failed_on_line): Extracted from test_parse_output_with_failing_line,
3771         which was removed in favor of the tests below.
3772         (TestPerfTest.test_parse_output_with_running_five_times): Added.
3773         (TestPerfTest.test_parse_output_with_detailed_info): Added.
3774         (TestPerfTest.test_parse_output_with_statistics): Added.
3775         (TestPerfTest.test_parse_output_with_description): Removed the junk.
3776         (TestPerfTest.test_parse_output_with_subtests): Ditto.
3777         (TestSingleProcessPerfTest.test_use_only_one_process): Ditto.
3778
3779         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3780         (EventTargetWrapperTestData): Ditto.
3781         (SomeParserTestData): Ditto.
3782         (MemoryTestData): Ditto.
3783
3784 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3785
3786         Occasionally, hundreds of tests fail with small text diffs on Mavericks
3787         https://bugs.webkit.org/show_bug.cgi?id=124312
3788
3789         Reviewed by Simon Fraser.
3790
3791         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3792         (Manager._set_up_run):
3793         * Scripts/webkitpy/port/base.py:
3794         (Port.to.reset_preferences):
3795         * Scripts/webkitpy/port/mac.py:
3796         (MacPort.reset_preferences):
3797         Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
3798         returning some of the functionality of 158652 after 159364 removed it.
3799
3800 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3801
3802         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
3803         https://bugs.webkit.org/show_bug.cgi?id=122909
3804
3805         Reviewed by Alexey Proskuryakov.
3806
3807         Put the checkmark SVG in the CSS file as a data URI so it loads immediately.
3808
3809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3810         (.status-line .bubble):
3811         (.status-line.good .bubble.pictogram):
3812
3813 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
3814
3815         Remove _lines_to_ignore_in_stderr, which was only used in Chromium port
3816         https://bugs.webkit.org/show_bug.cgi?id=124499
3817
3818         Reviewed by Csaba Osztrogonác.
3819
3820         Removed the code. I didn't like this hack back when it was added, and I don't like it today.
3821
3822         * Scripts/webkitpy/performance_tests/perftest.py:
3823         (PerfTest._should_ignore_line):
3824         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3825         (TestPerfTest): Removed the unit test.
3826
3827 2013-11-17  Filip Pizlo  <fpizlo@apple.com>
3828
3829         Unreviewed, fix this script for older Rubies where Pathname doesn't coerce to String
3830         quite as easily.
3831         
3832         With help from Andy Trick.
3833
3834         * Scripts/export-llvm-build:
3835
3836 2013-11-15  Filip Pizlo  <fpizlo@apple.com>
3837
3838         FTL should have an explicit notion of bytecode liveness
3839         https://bugs.webkit.org/show_bug.cgi?id=124181
3840
3841         Reviewed by Mark Hahnenberg.
3842
3843         * Scripts/run-jsc-stress-tests:
3844
3845 2013-11-16  Dan Bernstein  <mitz@apple.com>
3846
3847         No way for policy client to determine if a the response’s MIME type can be shown
3848         https://bugs.webkit.org/show_bug.cgi?id=124445
3849
3850         Reviewed by Sam Weinig.
3851
3852         * MiniBrowser/mac/WK2BrowserWindowController.m:
3853         (decidePolicyForResponse): Added canShowMIMEType parameter.
3854         (-[WK2BrowserWindowController awakeFromNib]): Updated for changes in the policy client.
3855
3856         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3857         (TestWebKitAPI::decidePolicyForResponse): Added canShowMIMEType parameter.
3858
3859         * WebKitTestRunner/TestController.cpp:
3860         (WTR::TestController::createWebViewWithOptions): Updated for changes in the policy client.
3861         (WTR::TestController::decidePolicyForResponse): Added canShowMIMEType parameter.
3862         * WebKitTestRunner/TestController.h:
3863
3864 2013-11-16  Tim Horton  <timothy_horton@apple.com>
3865
3866         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
3867         https://bugs.webkit.org/show_bug.cgi?id=122909
3868
3869         Reviewed by Timothy Hatcher.
3870
3871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/checkmark.svg: Added.
3872         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3873         (StatusLineView.prototype.set repeatCount):
3874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3875         (.status-line.good .bubble.pictogram):
3876         Use an SVG image instead of an obscure font for the checkboxes so they
3877         render identically on all platforms.
3878
3879 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3880
3881         Occasionally, hundreds of tests fail with small text diffs on Mavericks
3882         https://bugs.webkit.org/show_bug.cgi?id=124312
3883
3884         Reviewed by Alexey Proskuryakov.
3885
3886         Try reverting the part of r158652 that deleted all of the persistent
3887         defaults, in the thought that there might be some sort of race between
3888         processes causing some settings to be left in the wrong state.
3889
3890         * DumpRenderTree/mac/DumpRenderTree.mm:
3891         (setDefaultsToConsistentValuesForTesting):
3892         * WebKitTestRunner/mac/main.mm:
3893         (setDefaultsToConsistentValuesForTesting):
3894
3895 2013-11-15  Dan Bernstein  <mitz@apple.com>
3896
3897         Give the policy client the originating frame of a navigation action
3898         https://bugs.webkit.org/show_bug.cgi?id=124431
3899
3900         Reviewed by Anders Carlsson.
3901
3902         * MiniBrowser/mac/WK2BrowserWindowController.m:
3903         (decidePolicyForNavigationAction): Added originatingFrame parameter.
3904         (-[WK2BrowserWindowController awakeFromNib]): Updated for the new version of the policy
3905         client.
3906
3907         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3908         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
3909         (TestWebKitAPI::setPagePolicyClient): Updated for the new version of the policy client.
3910
3911         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3912         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
3913         (TestWebKitAPI::TEST): Updated for the new version of the policy client.
3914
3915         * WebKitTestRunner/TestController.cpp:
3916         (WTR::TestController::createWebViewWithOptions): Updated for the new version of the policy
3917         client.
3918         (WTR::TestController::decidePolicyForNavigationAction): Added originatingFrame parameter.
3919         * WebKitTestRunner/TestController.h:
3920
3921 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3922
3923         build.webkit.org/dashboard should provide a way to focus on a subset of bots
3924         https://bugs.webkit.org/show_bug.cgi?id=122676
3925
3926         Reviewed by Timothy Hatcher.
3927
3928         Add a small 'hide' button next to every platform logo, and a 'show all'
3929         button which only appears when at least one platform is hidden. Hidden
3930         platforms persist using localStorage.
3931
3932         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3933         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3934         (updateHiddenPlatforms):
3935         (documentReady.unhideButton):
3936         (documentReady.hideButton):
3937         (documentReady):
3938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: Added.
3939         (Settings.prototype.setObject):
3940         (Settings.prototype.getObject):
3941         (Settings.prototype.addSettingListener):
3942         (Settings.prototype.fireSettingListener):
3943         (Settings.prototype.toggleHiddenPlatform):
3944         (Settings.prototype.clearHiddenPlatforms):
3945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3946         (div.cellButton):
3947         (div.cellButton.hide):
3948         (.hidden):
3949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3950
3951 2013-11-15  Jer Noble  <jer.noble@apple.com>
3952
3953         MediaTime addition and subtraction operators have errors when the rhs is infinite.
3954         https://bugs.webkit.org/show_bug.cgi?id=124413
3955
3956         Reviewed by Eric Carlson.
3957
3958         Add a test for operator+ and operator- where an infinite value appears
3959         on the right-hand side:
3960         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3961         (TestWebKitAPI::TEST):
3962
3963         Add a LLDB summary provider for MediaTime which displays the rational
3964         time as well as the value in seconds:
3965         * lldb/lldb_webkit.py:
3966         (__lldb_init_module):
3967         (WTFMediaTime_SummaryProvider):
3968         (WTFHashTableProvider.has_children):
3969         (WTFMediaTimeProvider):
3970         (WTFMediaTimeProvider.__init__):
3971         (WTFMediaTimeProvider.timeValue):
3972         (WTFMediaTimeProvider.timeScale):
3973         (WTFMediaTimeProvider.isInvalid):
3974         (WTFMediaTimeProvider.isPositiveInfinity):
3975         (WTFMediaTimeProvider.isNegativeInfinity):
3976         (WTFMediaTimeProvider.isIndefinite):
3977
3978 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3979
3980         Make it possible to select revision numbers on build.webkit.org/dashboard
3981         https://bugs.webkit.org/show_bug.cgi?id=124400
3982
3983         Reviewed by Timothy Hatcher.
3984
3985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3986         (BuildbotQueueView.prototype.revisionLinksForIteration):
3987         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3988         (.selectable):
3989         Add a child span to the trac link, which has '-webkit-user-select: all' on it.
3990         This way, a Dashboard user can highlight revision numbers for easy copying,
3991         and doesn't even have to be precise about the selection.
3992
3993 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3994
3995         Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons
3996         https://bugs.webkit.org/show_bug.cgi?id=124399
3997
3998         Reviewed by Gustavo Noronha Silva.
3999
4000         Add new EFL and GTK icons (derived from Wikipedia's SVGs) to make new 1x and 2x icons,
4001         with the icons adjusted to have solid backgrounds, to not be squished, and to not
4002         intersect the ring, similar to the Mac icons.
4003
4004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png:
4005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Added.
4006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
4007         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png: Added.
4008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
4009         (documentReady.hideButton):
4010         (documentReady):
4011         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4012         (table.queue-grid tr.platform.linux-gtk img.logo):
4013         (table.queue-grid tr.platform.linux-efl img.logo):
4014
4015 2013-11-15  Stephane Jadaud  <sjadaud@sii.fr>
4016
4017         [GStreamer] Add support for Media Source API
4018         https://bugs.webkit.org/show_bug.cgi?id=99065
4019
4020         Reviewed by Philippe Normand.
4021
4022         * Scripts/webkitperl/FeatureList.pm:
4023
4024 2013-11-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4025
4026         [GTK] Bumping GStreamer version to 1.2.1 for the dependencies
4027         https://bugs.webkit.org/show_bug.cgi?id=124360
4028
4029         Reviewed by Philippe Normand.
4030
4031         * gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
4032
4033 2013-11-14  Brent Fulgham  <bfulgham@apple.com>
4034
4035         [Win] Improve support for command line builds of 64-bit JSC
4036         https://bugs.webkit.org/show_bug.cgi?id=124380
4037
4038         Reviewed by David Kilzer.
4039
4040         * Scripts/webkitdirs.pm:
4041         (argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
4042         'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
4043         (determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
4044         what the "$configurationForVisualStudio" value is for.
4045
4046 2013-11-14  Oliver Hunt  <oliver@apple.com>
4047
4048         Make CLoop easier to build, and make it work
4049         https://bugs.webkit.org/show_bug.cgi?id=124359
4050
4051         Reviewed by Geoffrey Garen.
4052
4053         Add --cloop support to forcibly enable to CLoop build
4054
4055         * Scripts/build-jsc:
4056         * Scripts/build-webkit:
4057
4058 2013-11-14  Lucas Forschler  <lforschler@apple.com>
4059
4060         Add webkit slave.
4061
4062         Unreviewed.
4063
4064         * BuildSlaveSupport/build.webkit.org-config/config.json:
4065
4066 2013-11-14  Tim Horton  <timothy_horton@apple.com>
4067
4068         build.webkit.org/dashboard can’t open different results in two new tabs
4069         https://bugs.webkit.org/show_bug.cgi?id=124383
4070
4071         Reviewed by Alexey Proskuryakov.
4072
4073         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
4074         (BuildbotQueueView.prototype.revisionLinksForIteration):
4075         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
4076         (StatusLineView.prototype._clicked):
4077         Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
4078         real pseudo-target and instead acts as a named target and will end up causing all link clicks
4079         to open in the same secondary tab).
4080
4081 2013-11-14  Anders Carlsson  <andersca@apple.com>
4082
4083         Remove duplicate entry.
4084
4085         * Scripts/webkitpy/common/config/contributors.json:
4086
4087 2013-11-14  Krzysztof Czech  <k.czech@samsung.com>
4088
4089         [ATK] Change WKTR/DRT AX methods to use nullptr 
4090         https://bugs.webkit.org/show_bug.cgi?id=124352
4091
4092         Reviewed by Anders Carlsson.
4093
4094         Change WKTR/DRT accessibility related methods to use nullptr.
4095
4096         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4097         (AccessibilityController::AccessibilityController):
4098         (AccessibilityController::elementAtPoint):
4099         (AccessibilityController::removeNotificationListener):
4100         (AccessibilityController::childElementById):
4101         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
4102         (AccessibilityNotificationHandler::AccessibilityNotificationHandler):
4103         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4104         (AccessibilityUIElement::elementAtPoint):
4105         (AccessibilityUIElement::linkedUIElementAtIndex):
4106         (AccessibilityUIElement::getChildAtIndex):
4107         (AccessibilityUIElement::titleUIElement):
4108         (AccessibilityUIElement::parentElement):
4109         (AccessibilityUIElement::subrole):
4110         (AccessibilityUIElement::roleDescription):
4111         (AccessibilityUIElement::orientation):
4112         (AccessibilityUIElement::ariaDropEffects):
4113         (AccessibilityUIElement::uiElementForSearchPredicate):
4114         (AccessibilityUIElement::cellForColumnAndRow):
4115         (AccessibilityUIElement::disclosedRowAtIndex):
4116         (AccessibilityUIElement::ariaOwnsElementAtIndex):
4117         (AccessibilityUIElement::ariaFlowToElementAtIndex):
4118         (AccessibilityUIElement::selectedRowAtIndex):
4119         (AccessibilityUIElement::rowAtIndex):
4120         (AccessibilityUIElement::disclosedByRow):
4121         (AccessibilityUIElement::removeNotificationListener):
4122         (AccessibilityUIElement::classList):
4123         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
4124         (WTR::AccessibilityController::logAccessibilityEvents):
4125         (WTR::AccessibilityController::resetToConsistentState):
4126         (WTR::childElementById):
4127         (WTR::AccessibilityController::accessibleElementById):
4128         (WTR::AccessibilityController::removeNotificationListener):
4129         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
4130         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
4131         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
4132         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4133         (WTR::AccessibilityUIElement::elementAtPoint):
4134         (WTR::AccessibilityUIElement::childAtIndex):
4135         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
4136         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
4137         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
4138         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
4139         (WTR::AccessibilityUIElement::rowAtIndex):
4140         (WTR::AccessibilityUIElement::selectedChildAtIndex):
4141         (WTR::AccessibilityUIElement::selectedRowAtIndex):
4142         (WTR::AccessibilityUIElement::titleUIElement):
4143         (WTR::AccessibilityUIElement::parentElement):
4144         (WTR::AccessibilityUIElement::disclosedByRow):
4145         (WTR::AccessibilityUIElement::uiElementAttributeValue):
4146         (WTR::AccessibilityUIElement::orientation):
4147         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
4148         (WTR::AccessibilityUIElement::cellForColumnAndRow):
4149         (WTR::AccessibilityUIElement::horizontalScrollbar):
4150         (WTR::AccessibilityUIElement::verticalScrollbar):
4151         (WTR::AccessibilityUIElement::removeNotificationListener):
4152         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
4153         (WTR::AccessibilityUIElement::previousTextMarker):
4154         (WTR::AccessibilityUIElement::nextTextMarker):
4155         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
4156         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
4157         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
4158         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
4159         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
4160         (WTR::AccessibilityUIElement::textMarkerForPoint):
4161         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
4162         (WTR::AccessibilityUIElement::textMarkerForIndex):
4163         (WTR::AccessibilityUIElement::supportedActions):
4164         (WTR::AccessibilityUIElement::pathDescription):
4165         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
4166         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
4167         (WTR::AccessibilityUIElement::classList):
4168
4169 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
4170
4171         run-perf-tests should warn loudly if you're using a Debug build.
4172         https://bugs.webkit.org/show_bug.cgi?id=105236
4173
4174         Reviewed by Csaba Osztrogonác.
4175
4176         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4177         (PerfTestsRunner.run):
4178
4179 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
4180
4181         Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
4182         https://bugs.webkit.org/show_bug.cgi?id=124143
4183
4184         Reviewed by Csaba Osztrogonác.
4185
4186         * Scripts/webkitpy/port/factory.py:
4187         (configuration_options):
4188
4189 2013-11-13  Anders Carlsson  <andersca@apple.com>
4190
4191         Add a Vector constructor that takes an std::initializer_list
4192         https://bugs.webkit.org/show_bug.cgi?id=124287
4193
4194         Reviewed by Antti Koivisto.
4195
4196         * TestWebKitAPI/Tests/WTF/Vector.cpp:
4197         (TestWebKitAPI::TEST):
4198
4199 2013-11-13  Mario Sanchez Prada  <mario.prada@samsung.com>
4200
4201         Unreviewed GTK gardening. Updated rebaseline unit tests to include WK2 bot.
4202
4203         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4204         (TestRebaselineTest.test_baseline_directory): Updated.
4205
4206 2013-11-13  Krzysztof Czech  <k.czech@samsung.com>
4207
4208         [ATK] Support compilation of EFL/GTK without accessibility
4209         https://bugs.webkit.org/show_bug.cgi?id=122448
4210
4211         Reviewed by Chris Fleizach.
4212
4213         Added missing HAVE(ACCESSIBILITY) guards and stubs to ATK's related files,
4214         so that in case of turning off the HAVE_ACCESSIBILITY macro EFL/GTK would compile properly.
4215
4216         * DumpRenderTree/AccessibilityController.h:
4217         * DumpRenderTree/AccessibilityUIElement.h:
4218         * DumpRenderTree/atk/AccessibilityCallbacks.h:
4219         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
4220         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
4221         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
4222         (WTR::AccessibilityController::rootElement):
4223         (WTR::AccessibilityController::focusedElement):
4224         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4225         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
4226         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
4227         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
4228         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4229         * WebKitTestRunner/PlatformEfl.cmake:
4230
4231 2013-11-12  Ryuan Choi  <ryuan.choi@samsung.com>
4232
4233         [EFL] Added libxss-dev to install-dependencies
4234         https://bugs.webkit.org/show_bug.cgi?id=124254
4235
4236         Reviewed by Gyuyoung Kim.
4237
4238         libxss-dev is required to build EFL packages.
4239         see building part in http://www.enlightenment.org/p.php?p=contribute
4240
4241         * efl/install-dependencies: Added libxss-dev to parameter of apt-get command.
4242
4243 2013-11-12  Tim Horton  <timothy_horton@apple.com>
4244
4245         After http://trac.webkit.org/changeset/159109, update
4246         rebaseline_unittest to use the new GTK bot names.
4247
4248         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4249         (TestRebaselineTest.test_baseline_directory):
4250
4251 2013-11-12  Denis Nomiyama  <d.nomiyama@samsung.com>
4252
4253         [GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py
4254         https://bugs.webkit.org/show_bug.cgi?id=124144
4255
4256         Reviewed by Gustavo Noronha Silva.
4257
4258         Updated the list of GTK builders in Tools/Scripts/webkitpy/port/builders.py
4259         according to http://build.webkit.org/builders.
4260
4261         * Scripts/webkitpy/port/builders.py:
4262
4263 2013-11-11  Samuel White  <samuel_white@apple.com>
4264
4265         AX: support helpText() in DumpRenderTree
4266         https://bugs.webkit.org/show_bug.cgi?id=40194
4267
4268         Reviewed by Chris Fleizach.
4269
4270         Implemented stubbed helpText methods so we can move aria-help.html back to LayoutTests/accessibility.
4271
4272         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4273         (AccessibilityUIElement::helpText):
4274
4275 2013-11-11  Anders Carlsson  <andersca@apple.com>
4276
4277         Remove block based APIs from the WebKit2 C API
4278         https://bugs.webkit.org/show_bug.cgi?id=124157
4279
4280         Reviewed by Sam Weinig.
4281
4282         Update for WK2 changes.
4283
4284         * MiniBrowser/mac/WK2BrowserWindowController.m:
4285         (dumpSource):
4286         (-[WK2BrowserWindowController dumpSourceToConsole:]):
4287
4288 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
4289
4290         The feeder queue will not feed patches older than one week.
4291         https://bugs.webkit.org/show_bug.cgi?id=107152
4292
4293         Reviewed by Csaba Osztrogonác.
4294
4295         The feeder queue will not feed patches older than one week.
4296         Unit test added to this scenario.
4297
4298         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4299         (BugzillaQueries._parse_attachment_ids_request_query):
4300           Handle date parameter.
4301         (BugzillaQueries):
4302         (BugzillaQueries._fetch_attachment_ids_request_query):
4303           Propagate date.
4304         (BugzillaQueries.fetch_attachment_ids_from_review_queue):
4305           Propagate date.
4306         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
4307         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
4308           Handle date.
4309         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4310         (test_request_page_parsing):
4311           Unit test added.
4312         * Scripts/webkitpy/tool/bot/feeders.py: