[Feature Queries] Enable Feature Queries on EFL/GTK
[WebKit-https.git] / Tools / ChangeLog
1 2014-08-01  Bear Travis  <betravis@adobe.com>
2
3         [Feature Queries] Enable Feature Queries on EFL/GTK
4         https://bugs.webkit.org/show_bug.cgi?id=134902
5
6         Reviewed by Benjamin Poulain.
7
8         Turn the feature on by default for the build script.
9
10         * Scripts/webkitperl/FeatureList.pm:
11
12 2014-08-01  Timothy Horton  <timothy_horton@apple.com>
13
14         Build fix for 32-bit after r171926.
15
16         * MiniBrowser/mac/SettingsController.h:
17         * MiniBrowser/mac/SettingsController.m:
18
19 2014-08-01  Tim Horton  <timothy_horton@apple.com>
20
21         Confusing build fix after r171926.
22
23         * MiniBrowser/mac/AppDelegate.h:
24         * MiniBrowser/mac/AppDelegate.m:
25         * MiniBrowser/mac/SettingsController.m:
26
27 2014-08-01  Tim Horton  <timothy_horton@apple.com>
28
29         Make it easer to add switches to MiniBrowser
30         https://bugs.webkit.org/show_bug.cgi?id=135499
31
32         Reviewed by Simon Fraser.
33
34         Add a single class to manage a set of persistent, global settings for MiniBrowser.
35         Add a new menu that contains items to toggle the aforementioned settings (moving them out of the Debug menu).
36
37         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
38         Add SettingsController.{m, h}.
39
40         * MiniBrowser/mac/AppDelegate.h:
41         Move _browserWindowControllers to the implementation.
42         Get rid of toggleUseWebKit2ByDefault, because SettingsController now takes care
43         of that; instead, we'll receive didChangeSettings.
44
45         * MiniBrowser/mac/AppDelegate.m:
46         Move the default URL, default URL preference key, and use-WebKit2-by-default
47         preference key into SettingsController.
48
49         (-[BrowserAppDelegate awakeFromNib]):
50         Add the dynamically-generated SettingsController menu just to the left of the Debug menu.
51
52         (-[BrowserAppDelegate newWindow:]):
53         Ask SettingsController if we should use WebKit2 by default, and what the initial URL to load is.
54
55         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
56         SettingsController now takes care of reading the default URL preference.
57         WK1BrowserWindowController now takes care of enabling the developer extras, via WebPreferences.
58
59         (-[BrowserAppDelegate didChangeSettings]):
60         When settings change, update the key equivalents for the new-window menu items, as they
61         might have changed (as use-WebKit2-by-default is one of the settings).
62
63         Dispatch settings change notifications to all live BrowserControllers.
64
65         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
66         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]): Deleted.
67         (-[BrowserAppDelegate _useWebKit2ByDefault]): Deleted.
68         (-[BrowserAppDelegate validateMenuItem:]): Deleted.
69         All menu item validation for settings is moved into SettingsController.
70
71         * MiniBrowser/mac/BrowserWindowController.h:
72         Simplify the BrowserWindowController interface; "toggling" settings will happen inside SettingsController,
73         the BrowserWindowController subclasses will be able to a) know when any setting changes, b) query the current setting state.
74
75         * MiniBrowser/mac/MainMenu.xib:
76         Remove the settings menu items from the "Debug" menu.
77
78         * MiniBrowser/mac/SettingsController.h: Added.
79         * MiniBrowser/mac/SettingsController.m: Added.
80         (+[SettingsController shared]):
81         (-[SettingsController menu]):
82
83         (-[SettingsController _addItemWithTitle:action:indented:]):
84         (-[SettingsController _addHeaderWithTitle:]):
85         NSMenuItem-creating helpers.
86
87         (-[SettingsController _populateMenu]):
88         Build the menu. Ideally this and the validation step would eventually be made more dynamic.
89
90         (-[SettingsController validateMenuItem:]):
91         Validate menu items; since they can be used to toggle the default state of a setting,
92         we'll always return YES. However, we will use this opportunity to set the 'checked' state
93         of each item.
94
95
96         (-[SettingsController _toggleBooleanDefault:]):
97         Toggle the given boolean default, and notify BrowserAppDelegate that something changed.
98
99         (-[SettingsController toggleUseWebKit2ByDefault:]):
100         (-[SettingsController useWebKit2ByDefault]):
101         (-[SettingsController toggleUseTransparentWindows:]):
102         (-[SettingsController useTransparentWindows]):
103         (-[SettingsController toggleUsePaginatedMode:]):
104         (-[SettingsController usePaginatedMode]):
105         (-[SettingsController toggleUseUISideCompositing:]):
106         (-[SettingsController useUISideCompositing]):
107         (-[SettingsController toggleShowLayerBorders:]):
108         (-[SettingsController layerBordersVisible]):
109         (-[SettingsController toggleShowTiledScrollingIndicator:]):
110         (-[SettingsController tiledScrollingIndicatorVisible]):
111         (-[SettingsController toggleEnableSubPixelCSSOMMetrics:]):
112         (-[SettingsController subPixelCSSOMMetricsEnabled]):
113         (-[SettingsController defaultURL]):
114         Toggle or return the current state of each preference.
115
116         * MiniBrowser/mac/WK1BrowserWindowController.m:
117         (-[WK1BrowserWindowController awakeFromNib]):
118         (-[WK1BrowserWindowController validateMenuItem:]):
119         (-[WK1BrowserWindowController windowWillClose:]):
120         (-[WK1BrowserWindowController find:]):
121         (-[WK1BrowserWindowController dumpSourceToConsole:]):
122         (-[WK1BrowserWindowController didChangeSettings]):
123         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
124         (-[WK1BrowserWindowController isPaginated]): Deleted.
125         (-[WK1BrowserWindowController togglePaginationMode:]): Deleted.
126         (-[WK1BrowserWindowController toggleTransparentWindow:]): Deleted.
127         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
128         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
129         (-[WK1BrowserWindowController layerBordersVisible]): Deleted.
130         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
131         * MiniBrowser/mac/WK2BrowserWindowController.m:
132         (-[WK2BrowserWindowController awakeFromNib]):
133         (-[WK2BrowserWindowController validateMenuItem:]):
134         (-[WK2BrowserWindowController forceRepaint:]):
135         (-[WK2BrowserWindowController windowWillClose:]):
136         (-[WK2BrowserWindowController didChangeSettings]):
137         (-[WK2BrowserWindowController isPaginated]): Deleted.
138         (-[WK2BrowserWindowController togglePaginationMode:]): Deleted.
139         (-[WK2BrowserWindowController toggleTransparentWindow:]): Deleted.
140         (-[WK2BrowserWindowController isUISideCompositingEnabled]): Deleted.
141         (-[WK2BrowserWindowController toggleUISideCompositing:]): Deleted.
142         (-[WK2BrowserWindowController layerBordersVisible]): Deleted.
143         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
144         (-[WK2BrowserWindowController tiledScrollingIndicatorVisible]): Deleted.
145         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]): Deleted.
146
147 2014-08-01  Tim Horton  <timothy_horton@apple.com>
148
149         MiniBrowser doesn't support data URLs
150         https://bugs.webkit.org/show_bug.cgi?id=135492
151
152         Reviewed by Simon Fraser.
153
154         * MiniBrowser/mac/BrowserWindowController.m:
155         (-[BrowserWindowController addProtocolIfNecessary:]):
156         Don't add http:// to data: URLs.
157
158         * MiniBrowser/mac/WK2BrowserWindowController.m:
159         (-[WK2BrowserWindowController fetch:]):
160         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
161         Percent-escape the contents of the address field before trying to make a URL.
162         Percent-unescape the URL when displaying it in the address field.
163         This is not great, but trivial and good-enough-for-Minibrowser.
164
165 2014-07-31  Ryuan Choi  <ryuan.choi@samsung.com>
166
167         [EFL][WK2] MiniBrower comes to crash when combo box is pressed
168         https://bugs.webkit.org/show_bug.cgi?id=135378
169
170         Reviewed by Gyuyoung Kim.
171
172         "clicked" signal of elm_menu is emitted after EwkView calls popup_menu_hide
173         and removes Ewk_Popup_Menu instance.
174
175         * MiniBrowser/efl/main.c:
176         (on_popup_menu_show):
177         (on_popup_menu_discarded): Deleted.
178
179 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
180
181         [Win] Use RC_PROJECTBUILDVERSION as build portion of version
182         https://bugs.webkit.org/show_bug.cgi?id=135478
183
184         Reviewed by David Kilzer.
185
186         Add new test suite for the version-stamp program.
187
188         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Added.
189
190 2014-07-31  Dan Bernstein  <mitz@apple.com>
191
192         Reverted r171893, because it broke http/tests/appcache/different-https-origin-resource-main.html,
193         which loads HTTPS content without calling the delegate.
194
195         Rubber-stamped by Alexey Proskuryakov.
196
197         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
198         (WTR::InjectedBundle::platformInitialize):
199         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
200         (WTR::InjectedBundle::platformInitialize):
201
202 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
203
204         Unreviewed typo correction (and build fix).
205
206         * MiniBrowser/mac/WK2BrowserWindowController.m:
207         (-[WK2BrowserWindowController awakeFromNib]): Use correct
208         property name (_fullScreenIsEnabled -> _fullScreenEnabled)
209
210 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
211
212         MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
213         https://bugs.webkit.org/show_bug.cgi?id=135482
214
215         Reviewed by Simon Fraser.
216
217         * MiniBrowser/mac/WK2BrowserWindowController.m:
218         (-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
219         feature.
220
221 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
222
223         [Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
224         https://bugs.webkit.org/show_bug.cgi?id=135472
225
226         Reviewed by Dan Bernstein.
227
228         We now handle server trust challenges, and don't need such hacks.
229
230         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
231         (WTR::InjectedBundle::platformInitialize):
232         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
233         (WTR::InjectedBundle::platformInitialize):
234
235 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
236
237         media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
238         on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
239         https://bugs.webkit.org/show_bug.cgi?id=135418
240
241         Reviewed by Anders Carlsson.
242
243         This was only happening in shared web process mode, because WKBundlePostMessage
244         has different behavior then. When there is no process, the message is dropped on
245         the floor in multiple process mode, but it's stored to be delivered after launch
246         in shared process mode.
247
248         So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
249         that was delivered immediately after launch, when there was nothing to reset.
250
251         We don't actually need to reset anything at this point, as the previous call has
252         already reset everything UI process side, and web process is brand new. All we need
253         is to reattach the page to a process, as invoke() expects one to exist.
254
255         * WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
256         * WebKitTestRunner/TestController.h:
257         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
258
259 2014-07-31  Dan Bernstein  <mitz@apple.com>
260
261         [WK2] Regression tests can't load HTTPS pages with NetworkProcess due to self-signed certificate
262         https://bugs.webkit.org/show_bug.cgi?id=115282
263
264         Reviewed by Sam Weinig.
265
266         * WebKitTestRunner/TestController.cpp:
267         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true for any
268         local host server trust protection space.
269         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Respond with a non-empty
270         credential to server trust challenges.
271
272 2014-07-31  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
273
274         [webkitpy] Make diff_text generate correct diff if there is no newline at the end of file
275         https://bugs.webkit.org/show_bug.cgi?id=135381
276
277         Reviewed by Csaba Osztrogonác.
278
279         * Scripts/webkitpy/port/base.py:
280         (Port.diff_text):
281         * Scripts/webkitpy/port/base_unittest.py:
282         (PortTest.test_diff_text):
283
284 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
285
286         Unreviewed. Fix GTK+ make distcheck.
287
288         * gtk/make-dist.py:
289         (ensure_version_if_possible): Use 4.0 instead of 3.0 as binary
290         version to find the pkg-config file.
291         * gtk/manifest.txt: Add missing resource to the tarball.
292
293 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
294
295         [GTK] make distcheck is building from sources dir instead of dist dir
296         https://bugs.webkit.org/show_bug.cgi?id=135457
297
298         Reviewed by Philippe Normand.
299
300         * gtk/make-dist.py:
301         (Distcheck.configure): Use dist_dir as source dir.
302         (Distcheck.check): Pass dist_dir to configure().
303
304 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
305
306         [GTK] Do not include files that are not in git in the tarball
307         https://bugs.webkit.org/show_bug.cgi?id=134804
308
309         Reviewed by Philippe Normand.
310
311         Skip all files in the source tree that are not under version control
312         except for files added from the build dir like the documentation.
313
314         * gtk/make-dist.py:
315         (Directory.__init__): Initialize the list of files under control version.
316         (Directory.list_cms_files): Helper function to list all files
317         under the control version for the current source root.
318         (Directory.should_skip_file): Return True for files that are not
319         under control version only when the source root is also under
320         control version.
321         (Directory.get_files): Filter the files also using should_skip_file().
322
323 2014-07-29  David Farler  <dfarler@apple.com>
324
325         iOS Simulator LayoutTestRelay
326         https://bugs.webkit.org/show_bug.cgi?id=135269
327
328         Reviewed by David Kilzer.
329
330         * LayoutTestRelay/Configurations/Base.xcconfig: Added.
331         * LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
332         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
333         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
334         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.
335         (-[LTPipeRelay inPipePath]):
336         (-[LTPipeRelay outPipePath]):
337         (-[LTPipeRelay errorPipePath]):
338         (-[LTPipeRelay outputStream]):
339         (-[LTPipeRelay initWithPrefix:]):
340         (-[LTPipeRelay setup]):
341         (-[LTPipeRelay tearDown]):
342         (-[LTPipeRelay connect]):
343         (-[LTPipeRelay disconnect]):
344         (-[LTPipeRelay createFIFOs]):
345         (-[LTPipeRelay destroyFIFOs]):
346         (-[LTPipeRelay relayStream:]):
347         (-[LTPipeRelay stream:handleEvent:]):
348         * LayoutTestRelay/LayoutTestRelay/LTRelay.h: Added.
349         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h: Added.
350         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: Added.
351         (-[LTRelayController uniqueAppPath]):
352         (-[LTRelayController uniqueAppURL]):
353         (-[LTRelayController uniqueAppIdentifier]):
354         (-[LTRelayController processName]):
355         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
356         (-[LTRelayController readFileHandle:]):
357         (-[LTRelayController receivedStandardOutputData:]):
358         (-[LTRelayController receivedStandardErrorData:]):
359         (-[LTRelayController disconnected]):
360         (-[LTRelayController connected]):
361         (-[LTRelayController crashWithMessage:]):
362         (-[LTRelayController launchSimulator]):
363         (-[LTRelayController bootDevice]):
364         (-[LTRelayController createUniqueApp]):
365         (-[LTRelayController killApp]):
366         (-[LTRelayController launchApp]):
367         (-[LTRelayController start]):
368         * LayoutTestRelay/LayoutTestRelay/main.m: Added.
369         (usage):
370         (getTestingSimDevice):
371         (getRequiredStringArgument):
372         (getRemainderArguments):
373         (main):
374         * LayoutTestRelay/Makefile: Added.
375         * Tools/Scripts/build-layouttestrelay: Added.
376
377 2014-07-29  Brent Fulgham  <bfulgham@apple.com>
378
379         [Win] Modify version numbering scheme to support 5-tuple versions
380         https://bugs.webkit.org/show_bug.cgi?id=135400
381         <rdar://problem/17849033>
382
383         Reviewed by David Kilzer.
384
385         Update test cases to recognize that we can only support Major
386         values from 0-65535, Minor values from 0-64, Tiny values from 0-999,
387         Micro values from 0-64, and Nano values from 0-999.
388
389         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Update
390         test expectations for physical limits.
391
392 2014-07-30  Carlos Garcia Campos  <cgarcia@igalia.com>
393
394         [GTK] GLib tests fail with recent GTK+ due to runtime warning about deprecated properties
395         https://bugs.webkit.org/show_bug.cgi?id=135411
396
397         Reviewed by Sergio Villar Senin.
398
399         Recent versions of GTK+ now warn at runtime when a deprecated
400         property or signal is used. A diagnostic mode was added that is
401         enabled by default, but that can be disabled by setting
402         G_ENABLE_DIAGNOSTIC=0. Runtime warnings are considered test
403         failures by gtester, so we need to run the tests with the
404         diganostic mode disabled.
405
406         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
407         (main):
408
409 2014-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
410
411         [GTK] Remove WebKitCertificateInfo from WebKit2GTK+ API
412         https://bugs.webkit.org/show_bug.cgi?id=134830
413
414         Reviewed by Gustavo Noronha Silva.
415
416         Update the SSL test for the API changes.
417
418         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
419         (testLoadFailedWithTLSErrors):
420
421 2014-07-24  David Farler  <dfarler@apple.com>
422
423         Add knowledge of the iOS Simulator to webkitpy
424         http://bugs.webkit.org/show_bug.cgi?id=133963
425
426         Reviewed by Simon Fraser.
427
428         * Scripts/webkitdirs.pm:
429         (argumentsForConfiguration): Add --ios-sim*
430         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
431         --runtime and --device-type args added.
432         * Scripts/webkitpy/port/base.py:
433         * Scripts/webkitpy/port/driver.py: Add simulator driver.
434         (IOSSimulatorDriver): Added.
435         * Scripts/webkitpy/port/factory.py: Add simulator platform.
436         * Scripts/webkitpy/port/ios.py: Added.
437
438 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
439
440         fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
441         https://bugs.webkit.org/show_bug.cgi?id=135398
442
443         Reviewed by Zalan Bujtas.
444
445         * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
446         "hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
447
448         * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
449         For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
450         sure why.
451
452 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
453
454         PPT: run-webkit-tests doesn't upload crash logs to bots
455         https://bugs.webkit.org/show_bug.cgi?id=135391
456
457         Reviewed by Joseph Pecoraro.
458
459         * WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):
460         Not a fix to be proud of, but better than not having it work at all.
461
462 2014-07-29  Adrian Perez de Castro  <aperez@igalia.com>
463
464         [GTK] Remove WebKitWebViewGroup from WebKit2 GTK+ API
465         https://bugs.webkit.org/show_bug.cgi?id=133729
466
467         Reviewed by Carlos Garcia Campos.
468
469         Removes WebKitWebViewGroup, effectively reverting the changes
470         introduced by r149117. The motivation for WebKitWebViewGroup
471         was using the user style sheet injection API, which has been
472         moved into WebKitUserContentManager, rendering it unneeded.
473
474         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Remove tests
475         for WebKitWebViewGroup.
476         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
477         (testWebViewSettings):
478         Restore the assertions that check that settings objects are
479         released. Add test for webkit_web_view_new_with_settings().
480         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Removed.
481
482 2014-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
483
484         Implement webkit_web_view_load_string() in WebKit2
485         https://bugs.webkit.org/show_bug.cgi?id=134735
486
487         Reviewed by Sergio Villar Senin.
488
489         Add /webkit2/WebKitWebView/load-bytes test case and simplify
490         TestDOMXPathNSResolver by using webkit_web_view_load_bytes()
491         instead of a soup server just to sent the Content-type header.
492
493         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
494         (testWebKitDOMXPathNSResolverNative):
495         (testWebKitDOMXPathNSResolverCustom):
496         (beforeAll):
497         (afterAll):
498         (serverCallback): Deleted.
499         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
500         (testLoadBytes):
501         (beforeAll):
502         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
503         (LoadTrackingTest::loadBytes):
504         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
505         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
506         (WebViewTest::loadBytes):
507         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
508
509 2014-07-28  Daniel Bates  <dabates@apple.com>
510
511         Add support for running the Clang static analyzer when building WebKit and JSC
512         https://bugs.webkit.org/show_bug.cgi?id=134955
513
514         Reviewed by Brent Fulgham.
515
516         * Scripts/build-jsc: Added command line options -[no]-analyze (disabled by default).
517         * Scripts/build-webkit: Add --analyze command line option to build-webkit to enable
518         running the Clang static analyzer.
519         * Scripts/webkitdirs.pm:
520         (XcodeStaticAnalyzerOption): Added.
521
522 2014-07-24  David Farler  <dfarler@apple.com>
523
524         Allow for multiple DumpRenderTree and WebKitTestRunner instances in the iOS Simulator
525         https://bugs.webkit.org/show_bug.cgi?id=135272
526
527         Reviewed by Simon Fraser.
528
529         * DumpRenderTree/mac/DumpRenderTree.mm:
530         (dumpRenderTree): Remove hard-coding of FIFO paths.
531         (-[DumpRenderTree applicationDidEnterBackground:]): Create background task.
532         (DumpRenderTreeMain): Set DumpRenderTree as UIApplication delegate.
533         * DumpRenderTree/mac/DumpRenderTreeMac.h: bgTask ivar.
534         * Scripts/old-run-webkit-tests: Update FIFO paths for ORWT.
535         * WebKitTestRunner/TestController.cpp: Remove hard-coding of FIFO paths.
536         * WebKitTestRunner/ios/TestControllerIOS.mm: Move dup2 calls to platformInitialize
537         * WebKitTestRunner/ios/mainIOS.mm: bgTask ivar.
538         (-[WebKitTestRunnerApp applicationDidEnterBackground:]): Create background task.
539         (main): Set WebKitTestRunnerApp as UIApplication delegate.
540
541 2014-07-24  David Farler  <dfarler@apple.com>
542
543         ImageDiff builds for the simulator when running iOS layout tests
544         https://bugs.webkit.org/show_bug.cgi?id=135270
545
546         Reviewed by Simon Fraser.
547
548         * Scripts/build-imagediff: Added.
549
550 2014-07-28  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
551
552         Followup fix after r171594
553         https://bugs.webkit.org/show_bug.cgi?id=135048
554
555         Reviewed by Csaba Osztrogonác.
556
557         * Scripts/sort-export-file: Removed extra newlines from help.
558
559 2014-07-25  Anders Carlsson  <andersca@apple.com>
560
561         WKNavigation's properties are either always nil or don't behave as documented
562         https://bugs.webkit.org/show_bug.cgi?id=135267
563         <rdar://problem/17730536>
564
565         Reviewed by Andreas Kling.
566
567         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
568         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
569         (TEST):
570         (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
571         (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
572
573 2014-07-25  Michael Catanzaro  <mcatanzaro@igalia.com>
574
575         [GTK] install-dependencies needs to install perl-CGI on Fedora
576         https://bugs.webkit.org/show_bug.cgi?id=135302
577
578         Reviewed by Martin Robinson.
579
580         * gtk/install-dependencies:
581         Add perl-CGI to yum dependencies needed for tests
582
583 2014-07-25  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
584
585         Add --dry-run option to sort-export-file
586         https://bugs.webkit.org/show_bug.cgi?id=135048
587
588         Reviewed by Csaba Osztrogonác.
589
590         Added --dry-run option to sort-export-file. Running the script with --dry-run
591         option does not sort the export files but creates a list of the files that
592         need to be sorted.
593
594         * Scripts/sort-export-file:
595         (sawError):
596
597 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
598
599         GTK jhbuild modules needs to build xserver with --disable-local-transport
600         https://bugs.webkit.org/show_bug.cgi?id=135262
601
602         Reviewed by Martin Robinson.
603
604         * gtk/jhbuild.modules:
605         Build X server with --disable-local-transport, since local transport
606         is only supported on Solaris, SCO, and System V. Fixes build on
607         Fedora.
608
609 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
610
611         [GTK] build-webkit script fails under jhbuild if ACLOCAL_FLAGS is unset
612         https://bugs.webkit.org/show_bug.cgi?id=135065
613
614         Reviewed by Martin Robinson.
615
616         * jhbuild/jhbuild-wrapper:
617         (ensure_jhbuild): do not assume jhbuild sets ACLOCAL_FLAGS
618
619 2014-07-23  Joseph Pecoraro  <pecoraro@apple.com>
620
621         Unreviewed iOS build fix after r171355.
622
623         * TestWebKitAPI/Configurations/Base.xcconfig:
624         Since all the Tests/WebKit2Cocoa tests are already explicitly skipped on iOS,
625         simplify to skipping all the tests in the directory. PlatformUtilities are not
626         building on iOS, which means we are missing necessary Util functions.
627
628 2014-07-23  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
629
630         [EFL] Fix build after r171454
631         https://bugs.webkit.org/show_bug.cgi?id=135191
632
633         Reviewed by Csaba Osztrogonác.
634
635         * MiniBrowser/efl/CMakeLists.txt: Add path to new EWebKit2.h location .
636
637 2014-07-23  Ryuan Choi  <ryuan.choi@samsung.com>
638
639         [EFL] Do not generate forwarding header for ewk headers
640         https://bugs.webkit.org/show_bug.cgi?id=135147
641
642         Reviewed by Gyuyoung Kim.
643
644         * WebKitTestRunner/EventSenderProxy.h:
645
646 2014-07-21  Sam Weinig  <sam@webkit.org>
647
648         [Cocoa] WKScriptMessageHandlers don't seem to function properly after navigating
649         https://bugs.webkit.org/show_bug.cgi?id=135148
650
651         Reviewed by Geoffrey Garen.
652
653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
654         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Added.
655         (-[SimpleNavigationDelegate webView:didFinishNavigation:]):
656         (-[ScriptMessageHandler userContentController:didReceiveScriptMessage:]):
657
658 2014-07-22  Brent Fulgham  <bfulgham@apple.com>
659
660         Correct handling of __VERSION_TEXT__ for 4+-tuple versions
661         https://bugs.webkit.org/show_bug.cgi?id=135161
662         <rdar://problem/17763546>
663
664         Reviewed by David Kilzer.
665
666         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
667         Add additional test cases to catch errors in multiple-tuple
668         version string handling.
669
670 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
671
672         Extend exception fuzzing to the LLInt
673         https://bugs.webkit.org/show_bug.cgi?id=135076
674
675         Reviewed by Oliver Hunt.
676
677         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
678
679 2014-07-22  Jochen Eisinger  <jochen@chromium.org>
680
681         Fix my email address in contributors.json
682         https://bugs.webkit.org/show_bug.cgi?id=135156
683
684         Reviewed by Gyuyoung Kim.
685
686         * Scripts/webkitpy/common/config/contributors.json:
687
688 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
689
690         Unreviewed test fix.
691
692         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Revert
693         to older Perl 5.8 syntax for iterating over hashes to allow tests to
694         run on Mountain Lion bots.
695
696 2014-07-21  Alexey Proskuryakov  <ap@apple.com>
697
698         https://bugs.webkit.org/show_bug.cgi?id=135137
699         build.webkit.org/dashboard: webkitperl failures show up as yellow, not red
700
701         Reviewed by Darin Adler.
702
703         webkitperl results are binary, handle them the same way we handle bindings test results.
704
705         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
706         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
707         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
708
709 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
710
711         [Win] Follow-up for r171324.
712
713         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Cygwin
714         perl reports itself as 'cygwin'; native Windows Perl reports as
715         'MSWin32'. We need to handle both cases.
716
717 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
718
719         Unreviewed build fix after r171319.
720
721         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: This test should
722         only execute on Windows. It will fail on other platforms, so give it a way to
723         successfully exit.
724
725 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
726
727         [Win] Extend auto-version.pl to support 5-tuple versions
728         https://bugs.webkit.org/show_bug.cgi?id=135124
729         <rdar://problem/17750334>
730
731         Reviewed by David Kilzer.
732
733         Add test cases for auto-version.pl.
734
735         * Scripts/webkitperl/auto-version_unittest: Added.
736         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Added.
737
738 2014-07-21  Dean Jackson  <dino@apple.com>
739
740         Allow MiniBrowser WK1 to do element fullscreen
741         https://bugs.webkit.org/show_bug.cgi?id=135125
742
743         Reviewed by Simon Fraser.
744
745         Allow WK1 windows to go fullscreen using the DOM API.
746
747         * MiniBrowser/mac/WK1BrowserWindowController.m:
748         (-[WK1BrowserWindowController awakeFromNib]): Enable the preference for
749         fullscreen.
750
751 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
752
753         [GTK] Documentation files are added twice to the tarball
754         https://bugs.webkit.org/show_bug.cgi?id=135115
755
756         Reviewed by Sergio Villar Senin.
757
758         * gtk/manifest.txt: Remove duplicated rules.
759
760 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
761
762         [GTK] Simplify make-dist command line arguments
763         https://bugs.webkit.org/show_bug.cgi?id=134832
764
765         Reviewed by Martin Robinson.
766
767         Remove --tarball-root and -o command line options and add
768         --version, since the version can be used to build both, the
769         tarball root and the output filename. When the version it's not
770         provided, the pkg-config file is used to get the version. Also
771         change the default value of build-dir to the current directory,
772         since it's very common to call make-dist.py from the build dir.
773
774         * gtk/make-dist.py:
775         (get_tarball_root_and_output_filename_from_arguments):
776
777 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
778
779         [GTK] Reduce the size of the tarball generated by distcheck
780         https://bugs.webkit.org/show_bug.cgi?id=134802
781
782         Reviewed by Martin Robinson.
783
784         Add more rules to the manifest to decide what files to add:
785
786           - Do not include platform specific directories of other ports.
787           - Do not include port specific cmake files.
788           - Do not include Objective-C sources.
789           - Do not include .orig and .rej files.
790           - Do not include mac specific sandbox files.
791           - Only include the resources we actually build.
792
793         * gtk/manifest.txt:
794
795 2014-07-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
796
797         [EFL] Enable mpg123 feature for gst-plugin-bad.
798         https://bugs.webkit.org/show_bug.cgi?id=135016
799
800         Reviewed by Laszlo Gombos.
801
802         enable-mpg123 feature is added to jhbuild in order to support playback of mp3 format.
803
804         * efl/install-dependencies:
805         * efl/jhbuild.modules:
806
807 2014-07-20  Dan Bernstein  <mitz@apple.com>
808
809         Test for <rdar://problems/17742611> -[_WKActivatedElementInfo image] is often empty
810         https://bugs.webkit.org/show_bug.cgi?id=135107
811
812         Reviewed by Sam Weinig.
813
814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
815         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMNode.mm: Added.
816         (-[RenderedImageFromDOMNodeFrameLoadDelegate webView:didFinishLoadForFrame:]):
817         (TestWebKitAPI::TEST):
818
819 2014-07-20  David Kilzer  <ddkilzer@apple.com>
820
821         Checker: Value stored to 'kernResult' is never read (LayoutTestHelper.m:164)
822         <http://webkit.org/b/135096>
823
824         Reviewed by Alexey Proskuryakov.
825
826         * DumpRenderTree/mac/LayoutTestHelper.m:
827         (lockDownDiscreteGraphics): Check the return values of
828         IOServiceOpen() and IOObjectRelease(), and log if not
829         KERN_SUCCESS.
830
831 2014-07-19  Anders Carlsson  <andersca@apple.com>
832
833         Update.
834
835         * Scripts/webkitpy/common/config/watchlist:
836
837 2014-07-18  Sam Weinig  <sam@webkit.org>
838
839         Revert accidental commit to MiniBrowser to make everything layer backed.
840
841         * MiniBrowser/mac/BrowserWindowController.m:
842         (-[BrowserWindowController windowDidLoad]):
843
844 2014-07-18  Dana Burkart  <dburkart@apple.com>
845
846         Add a new 'analyze' target to the makefile. This will make use of a new
847         'PATH_TO_SCAN_BUILD' which, if set will wrap xcodebuild in the clang
848         static analyzer.
849         https://bugs.webkit.org/show_bug.cgi?id=135057
850         <rdar://problem/10193187>
851
852         Reviewed by David Kilzer.
853
854         * Makefile:
855
856 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
857
858         Fix EFL+GTK.
859
860         * Scripts/run-jsc-stress-tests:
861
862 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
863
864         Exception fuzzing should work on iOS
865         https://bugs.webkit.org/show_bug.cgi?id=135070
866
867         Reviewed by Mark Hahnenberg.
868
869         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
870         (fail):
871         * Scripts/run-jsc-stress-tests:
872
873 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
874
875         run-jsc-stress-tests should be able to run helper-based tests in remote mode
876         https://bugs.webkit.org/show_bug.cgi?id=135064
877
878         Reviewed by Mark Hahnenberg.
879
880         * Scripts/run-jsc-stress-tests:
881
882 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
883
884         run-jsc-stress-tests: rename $copy to $doNotMessWithVMPath
885         https://bugs.webkit.org/show_bug.cgi?id=135061
886
887         Rubber stamped by Mark Hahnenberg.
888
889         * Scripts/run-jsc-stress-tests:
890
891 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
892
893         Refactor run-jsc-stress-tests VM copying code to remove some abstractions
894         https://bugs.webkit.org/show_bug.cgi?id=135059
895
896         Reviewed by Mark Lam.
897         
898         This is meant to make it easier for me to extend the copying functionality to copy things other than
899         the framework.
900
901         * Scripts/run-jsc-stress-tests:
902
903 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
904
905         Fix cloop build.
906
907         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
908
909 2014-07-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
910
911         Fix -v|--verbose option in sort-export-file script.
912         https://bugs.webkit.org/show_bug.cgi?id=135043
913
914         Reviewed by Tim Horton.
915
916         -v|--verbose option does not work. Option added to getOptionsResult.
917
918         * Scripts/sort-export-file:
919
920 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
921
922         Really remove dependency on ShellQuote.
923
924         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
925
926 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
927
928         Unreviewed, fix build for platforms that don't have ShellQuote.
929         
930         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Take a single argument that has the whole command string.
931         * Scripts/run-jsc-stress-tests: Do the escaping in Ruby.
932
933 2014-07-15  Filip Pizlo  <fpizlo@apple.com>
934
935         Need ability to fuzz exception throwing
936         https://bugs.webkit.org/show_bug.cgi?id=134945
937         <rdar://problem/17722027>
938
939         Reviewed by Sam Weinig.
940         
941         Adds a new script, js-exception-fuzz, which will run some jsc command-line using
942         exception fuzzing. This means that we will force exceptions to be thrown in random
943         places to see how the engine reacts. This is now integrated with the various test
944         drivers, so run-javascriptcore-tests will run some exception fuzzing tests by
945         default.
946
947         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Added.
948         (fail):
949         * Scripts/run-javascriptcore-tests:
950         * Scripts/run-jsc-stress-tests:
951
952 2014-07-17  Sam Weinig  <sam@webkit.org>
953
954         Fix failing API tests.
955
956         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
957         (-[ActiveOffscreenWindow isVisible]):
958         Override isVisible to make the NSWindows pretend they are visible.
959
960 2014-07-17  Alexey Proskuryakov  <ap@apple.com>
961
962         Disable button animations in regression tests
963         https://bugs.webkit.org/show_bug.cgi?id=133647
964         <rdar://problem/16677530>
965
966         Reviewed by Dean Jackson.
967
968         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
969         We already did this for WebKit2, let's do it for WebKit1 too.
970
971 2014-07-16  Alexey Proskuryakov  <ap@apple.com>
972
973         A test that hangs at cleanup stage confuses webkitpy hugely
974         https://bugs.webkit.org/show_bug.cgi?id=122475
975         <rdar://problem/17184354>
976
977         Reviewed by Anders Carlsson.
978
979         Terminate WebContent process if it freezes between tests. Ideally, we should report
980         this somehow, but this is better than blaming the wrong test.
981
982         * WebKitTestRunner/TestController.cpp:
983         (WTR::TestController::terminateWebContentProcess):
984         * WebKitTestRunner/TestController.h:
985         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
986
987 2014-07-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
988
989         Change style check path with EFL WK2's path in checker_unittest.py
990         https://bugs.webkit.org/show_bug.cgi?id=134967
991
992         Reviewed by Csaba Osztrogonác.
993
994         * Scripts/webkitpy/style/checker_unittest.py: Change ewk_view.h path.
995         (GlobalVariablesTest.test_path_rules_specifier):
996
997 2014-07-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
998
999         Unreviewed. Added myself to the list of committers.
1000
1001         * Scripts/webkitpy/common/config/contributors.json:
1002
1003 2014-07-15  Ryuan Choi  <ryuan.choi@samsung.com>
1004
1005         [EFL] Remove EFL WK1 directory from the checker.py
1006         https://bugs.webkit.org/show_bug.cgi?id=134954
1007
1008         Reviewed by Gyuyoung Kim.
1009
1010         * Scripts/webkitpy/style/checker.py:
1011
1012 2014-07-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1013
1014         Adding myself to contributors.json breaks a webkitpy test
1015         https://bugs.webkit.org/show_bug.cgi?id=134958
1016
1017         Reviewed by Ryosuke Niwa.
1018
1019         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1020         (IRCCommandTest.test_whois): Be more specific and include also the
1021         first name when asking for the whois of Xan in the unit test.
1022
1023 2014-07-14  Daniel Bates  <dabates@apple.com>
1024
1025         check-webkit-style should apply C++ rules to Objective-C++ files
1026         https://bugs.webkit.org/show_bug.cgi?id=134884
1027
1028         Reviewed by Joseph Pecoraro.
1029
1030         Fixes an issue where check-webkit-style doesn't apply applicable C++ rules to
1031         Objective-C++ files.
1032
1033         Currently check-webkit-style doesn't apply the following rules to Objective-C++
1034         files: build/using_std, runtime/max_min_macros, runtime/wtf_move, readability/null.
1035         Instead, we should teach check-webkit-style to apply these rules because, as
1036         its name implies, an Objective-C++ file may contain C++ code.
1037
1038         * Scripts/webkitpy/style/checkers/cpp.py:
1039         (_FileState.__init__): Add instance variable _is_objective_cpp to track whether a file has
1040         extension mm (i.e. an Objective-C++ file).
1041         (_FileState.is_objective_c_or_objective_cpp): Added; returns true if the file
1042         has extension m or mm or if the file has extension h and contains Objective-C directives.
1043         (check_for_null): No change in behavior; don't apply rule to Objective-C++ file.
1044         (check_identifier_name_in_declaration): Substitute _FileState.is_objective_c_or_objective_cpp() for
1045         _FileState.is_c_or_objective_c()
1046         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1047         (WebKitStyleTest.test_null_false_zero): Added test case for Objective-C++ file.
1048         (WebKitStyleTest.test_max_macro): Add test case for Objective-C and Objective-C++ file.
1049         (WebKitStyleTest.test_min_macro): Ditto.
1050         (WebKitStyleTest.test_wtf_move): Add test case for Objective-C++ file.
1051
1052 2014-07-14  Anders Carlsson  <andersca@apple.com>
1053
1054         Make shouldKeepCurrentBackForwardListItemInList part of WKPageLoaderClientV5 to avoid breaking ABI
1055         https://bugs.webkit.org/show_bug.cgi?id=134889
1056
1057         Reviewed by Beth Dakin.
1058
1059         Bump loader version number to 5.
1060
1061         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1062         (TestWebKitAPI::setPageLoaderClient):
1063         * WebKitTestRunner/TestController.cpp:
1064         (WTR::TestController::createWebViewWithOptions):
1065
1066 2014-07-14  Daniel Bates  <dabates@apple.com>
1067
1068         Teach check-webkit-style to suggest WTF::move() when it sees std::move()
1069         https://bugs.webkit.org/show_bug.cgi?id=134620
1070
1071         Reviewed by Joseph Pecoraro.
1072
1073         * Scripts/webkitpy/style/checkers/cpp.py:
1074         (check_max_min_macros): Fix up comment so that it reads well.
1075         (check_wtf_move): Added.
1076         (check_style): Modified to call check_wtf_move().
1077         (CppChecker): Add category "runtime/wtf_move".
1078         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1079         (WebKitStyleTest.test_wtf_move): Added.
1080
1081 2014-07-12  Peter Szanka  <h868064@stud.u-szeged.hu>
1082
1083         Style checker complains about namespace indentation when there is no namespace
1084         https://bugs.webkit.org/show_bug.cgi?id=105427
1085
1086         Reviewed by Darin Adler.
1087
1088         * Scripts/webkitpy/style/checkers/cpp.py:
1089         (check_namespace_indentation):
1090         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1091         (WebKitStyleTest.test_indentation):
1092
1093         The indentation level depends on the parantheses too, to avoid false warning in case of several statements inside macros.
1094
1095 2014-07-12  Daker Fernandes Pinheiro  <daker.pinheiro@openbossa.org>
1096
1097         Remove excessive nesting from _EnumState.process_clean_line at cpp style checker
1098         https://bugs.webkit.org/show_bug.cgi?id=125317
1099
1100         Reviewed by Darin Adler.
1101
1102         * Scripts/webkitpy/style/checkers/cpp.py:
1103         (_EnumState.process_clean_line):
1104
1105 2014-07-12  Brian Holt  <brian.holt@samsung.com>
1106
1107         Style Checker should prevent enums in bitfields
1108         https://bugs.webkit.org/show_bug.cgi?id=57352
1109
1110         Reviewed by Darin Adler.
1111
1112         Added check that enums are not used as types for bitfields
1113         and a unit test.
1114
1115         * Scripts/webkitpy/style/checkers/cpp.py:
1116         (check_language):
1117         (CppChecker):
1118         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1119         (CppStyleTest):
1120         (CppStyleTest.test_enum_bitfields):
1121         (CppStyleTest.test_plain_integral_bitfields):
1122
1123 2014-07-10  Myles C. Maxfield  <mmaxfield@apple.com>
1124
1125         [iOS] Pasting rich content does not perform a two-step paste
1126         https://bugs.webkit.org/show_bug.cgi?id=134795
1127
1128         Reviewed by Benjamin Poulain.
1129
1130         Two-step paste requires setting InputViewObeysDOMFocus on the UIWebBrowserView.
1131
1132         * DumpRenderTree/mac/DumpRenderTree.mm:
1133         (createWebViewAndOffscreenWindow):
1134
1135 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>
1136
1137         [GTK][CMake] Add a 'distcheck' target
1138         https://bugs.webkit.org/show_bug.cgi?id=130675
1139
1140         Reviewed by Gustavo Noronha Silva.
1141
1142         Add --check option to make-dist script that builds and installs the tarball.
1143
1144         * gtk/make-dist.py:
1145         (Distcheck.__init__):
1146         (Distcheck.extract_tarball): Extratc the tarball.
1147         (Distcheck.configure): Run cmake.
1148         (Distcheck.configure.create_dir): Helper function to create a directory.
1149         (Distcheck.build): Run make.
1150         (Distcheck.install): Run make install.
1151         (Distcheck.clean): Clean up the extracted tarball.
1152         (Distcheck.check): Run all previous methods in order.
1153         * gtk/manifest.txt: Add missing file.
1154
1155 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1156
1157         [GTK] Use the same default options for production builds that previous stable releases
1158         https://bugs.webkit.org/show_bug.cgi?id=134589
1159
1160         Reviewed by Martin Robinson.
1161
1162         Make sure all features enabled in production builds are also
1163         enabled in developer mode.
1164
1165         * Scripts/webkitperl/FeatureList.pm: Enable ACCELERATED_2D_CANVAS
1166         and CSS_FILTERS for the GTK port.
1167
1168 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
1169
1170         [Win] Remove uses of 'bash' in build system
1171         https://bugs.webkit.org/show_bug.cgi?id=134782
1172         <rdar://problem/17615533>
1173
1174         Reviewed by Dean Jackson.
1175
1176         Remove uses of 'bash' by replacing Windows-specific bash scripts
1177         with Perl equivalents.
1178
1179         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
1180         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
1181         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
1182         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
1183         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
1184         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
1185
1186 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
1187
1188         [Win] Remove use of 'grep' in build steps
1189         https://bugs.webkit.org/show_bug.cgi?id=134770
1190         <rdar://problem/17608783>
1191
1192         Reviewed by Tim Horton.
1193
1194         Replace uses of the grep command in Windows builds with the equivalent
1195         Perl program.
1196
1197         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
1198         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
1199         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
1200         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
1201         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
1202         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
1203
1204 2014-07-09  Commit Queue  <commit-queue@webkit.org>
1205
1206         Unreviewed, rolling out r170889.
1207         https://bugs.webkit.org/show_bug.cgi?id=134754
1208
1209         This patch is wrong (Requested by philn on #webkit).
1210
1211         Reverted changeset:
1212
1213         "[GTK] Gstreamer missing from the install-dependencies script"
1214         https://bugs.webkit.org/show_bug.cgi?id=134727
1215         http://trac.webkit.org/changeset/170889
1216
1217 2014-07-08  Brian J. Burg  <burg@cs.washington.edu>
1218
1219         resolve-ChangeLogs fails when WebKit repository is a git submodule
1220         https://bugs.webkit.org/show_bug.cgi?id=134734
1221
1222         Reviewed by David Kilzer.
1223
1224         When using resolve-ChangeLogs in a WebKit git repository with a
1225         non-default arrangement of GIT_DIR and GIT_WORK_TREE, incorrect
1226         paths are computed and the script fails mysteriously.
1227
1228         We were naively computing GIT_WORK_TREE as being one level above
1229         GIT_DIR, but this is not the case for submodules or a manually
1230         configured GIT_WORK_TREE or GIT_DIR location.
1231
1232         * Scripts/VCSUtils.pm:
1233         (gitTreeDirectory): Added. Find the equivalent of GIT_WORK_TREE.
1234         (determineVCSRoot): Calculate the working tree root directly.
1235
1236 2014-07-08  Tim Horton  <timothy_horton@apple.com>
1237
1238         [WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
1239         https://bugs.webkit.org/show_bug.cgi?id=134645
1240
1241         Reviewed by Dan Bernstein.
1242
1243         * MiniBrowser/mac/BrowserWindowController.h:
1244         * MiniBrowser/mac/MainMenu.xib:
1245         Add menu items for layer borders and the tiled scrolling indicator.
1246
1247         * MiniBrowser/mac/WK1BrowserWindowController.m:
1248         (-[WK1BrowserWindowController validateMenuItem:]):
1249         (-[WK1BrowserWindowController layerBordersAreVisible]):
1250         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]):
1251         Add getters/setters/validators for layer borders.
1252
1253         * MiniBrowser/mac/WK2BrowserWindowController.m:
1254         (-[WK2BrowserWindowController awakeFromNib]):
1255         (-[WK2BrowserWindowController validateMenuItem:]):
1256         (-[WK2BrowserWindowController layerBordersAreVisible]):
1257         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]):
1258         (-[WK2BrowserWindowController tiledScrollingIndicatorIsVisible]):
1259         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]):
1260         Add getters/setters/validators for layer borders and the tiled scrolling indicator.
1261
1262         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
1263         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
1264         Remove the WebKit2 version of the subpixel metrics pref, because it doesn't work, because
1265         nothing in WebKit2 reads this default, and there is no WebKit2 API for adjusting this preference.
1266
1267 2014-07-08  Adrian Perez de Castro  <aperez@igalia.com>
1268
1269         [GTK] Move user style sheet API out of WebKitWebViewGroup
1270         https://bugs.webkit.org/show_bug.cgi?id=134551
1271
1272         Reviewed by Carlos Garcia Campos.
1273
1274         Removes testing user style sheet injection from
1275         TestWebKitWebViewGroup and moves that into a new
1276         TestWebKitUserContentManager, adapting the existing tests to the new
1277         API. Also, it contains a new test case for
1278         webkit_web_view_new_with_user_content_manager().
1279
1280         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1281         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: Added.
1282         (UserContentManagerTest::UserContentManagerTest):
1283         (testWebViewNewWithUserContentManager):
1284         (isStyleSheetInjectedForURLAtPath):
1285         (fillURLListFromPaths):
1286         (removeOldInjectedStyleSheetsAndResetLists):
1287         (testUserContentManagerInjectedStyleSheet):
1288         (serverCallback):
1289         (beforeAll):
1290         (afterAll):
1291         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
1292         (beforeAll):
1293         (afterAll):
1294         (isStyleSheetInjectedForURLAtPath): Deleted.
1295         (fillURLListFromPaths): Deleted.
1296         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
1297         (testWebViewGroupInjectedStyleSheet): Deleted.
1298         (serverCallback): Deleted.
1299         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1300         (WebViewTest::WebViewTest):
1301         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1302
1303 2014-07-08  Ziran Sun  <ziran.sun@samsung.com>
1304
1305         [GTK] Gstreamer missing from the install-dependencies script
1306         https://bugs.webkit.org/show_bug.cgi?id=134727
1307
1308         Reviewed by Mario Sanchez Prada.
1309
1310         Added missing gstreamer dependencies for debian based systems.
1311
1312         * gtk/install-dependencies: Added 2 dependencies for apt-get.
1313
1314 2014-07-08  Myles C. Maxfield  <mmaxfield@apple.com>
1315
1316         Add myself to the watchlist for text-related files
1317         https://bugs.webkit.org/show_bug.cgi?id=134707
1318
1319         Reviewed by Timothy Horton.
1320
1321         * Scripts/webkitpy/common/config/watchlist:
1322
1323 2014-07-08  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1324
1325         Add option to specify output file location in sunspider.
1326         https://bugs.webkit.org/show_bug.cgi?id=134339
1327
1328         Reviewed by Darin Adler.
1329
1330         * Scripts/run-sunspider:
1331
1332 2014-07-07  Alex Christensen  <achristensen@webkit.org>
1333
1334         Unreviewed build fix.
1335
1336         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1337         Make Common.cpp excluded from both 32-bit and 64-bit builds.
1338
1339 2014-07-07  Simon Fraser  <simon.fraser@apple.com>
1340
1341         Have MiniBrowser log and reload if the Web Content Process crashes
1342         https://bugs.webkit.org/show_bug.cgi?id=134691
1343
1344         Reviewed by Tim Horton.
1345         
1346         Implement _webViewWebProcessDidCrash, log and reload when the web process
1347         crashes.
1348
1349         * MiniBrowser/mac/WK2BrowserWindowController.m:
1350         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]):
1351
1352 2014-07-07  Alberto Garcia  <berto@igalia.com>
1353
1354         update-webkitgtk-libs script fails by unsatisfied dependencies
1355         https://bugs.webkit.org/show_bug.cgi?id=134547
1356
1357         Reviewed by Martin Robinson.
1358
1359         Install libxcb-xfixes0-dev, needed to build Mesa.
1360
1361         * gtk/install-dependencies:
1362
1363 2014-07-06  Yoav Weiss  <yoav@yoav.ws>
1364
1365         Turn on img@sizes compile flag
1366         https://bugs.webkit.org/show_bug.cgi?id=134634
1367
1368         Reviewed by Benjamin Poulain.
1369
1370         * Scripts/webkitperl/FeatureList.pm: Turn on the img@sizes feature.
1371
1372 2014-07-06  Hyowon Kim  <hw1008.kim@samsung.com>
1373
1374         Unreviewed. Adding myself to committers.
1375
1376         * Scripts/webkitpy/common/config/contributors.json:
1377
1378 2014-07-05  KwangHyuk Kim  <hyuki.kim@samsung.com>
1379
1380         [EFL] Add libgeoclue-dev to Tools/efl/install-dependencies.
1381         https://bugs.webkit.org/show_bug.cgi?id=134648
1382
1383         Reviewed by Gyuyoung Kim.
1384
1385         As Geoclue is enabled for EFL, libgeoclue-dev is also added to Tools/efl/install-dependencies.
1386
1387         * efl/install-dependencies:
1388
1389 2014-07-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1390
1391         [EFL] Support Geolocation
1392         https://bugs.webkit.org/show_bug.cgi?id=134439
1393
1394         Reviewed by Antonio Gomes.
1395
1396         * Scripts/webkitperl/FeatureList.pm: Enable geolocation for EFL port.
1397
1398 2014-07-04  Shivakumar JM  <shiva.jm@samsung.com>
1399
1400         [EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar, if any.
1401         https://bugs.webkit.org/show_bug.cgi?id=134485
1402
1403         Reviewed by Gyuyoung Kim.
1404
1405         Use script_execute_callback to get selected/highlighted text and show in search bar.
1406
1407         * MiniBrowser/efl/main.c:
1408         (script_execute_callback):
1409         (on_key_down):
1410
1411 2014-07-04  Dan Bernstein  <mitz@apple.com>
1412
1413         Build fix after r170811.
1414
1415         * MiniBrowser/mac/WK2BrowserWindowController.m:
1416         (-[WK2BrowserWindowController reload:]):
1417
1418 2014-07-04  Timothy Horton  <timothy_horton@apple.com>
1419
1420         Typo in watchlist config means four specific people get Cc'd on everything
1421         https://bugs.webkit.org/show_bug.cgi?id=134626
1422
1423         Reviewed by Gyuyoung Kim.
1424
1425         * Scripts/webkitpy/common/config/watchlist:
1426         Remove leading pipe, which meant that this rule matched everything!
1427
1428 2014-07-03  Shivakumar JM  <shiva.jm@samsung.com>
1429
1430         [EFL][WK2] Enhance the Minibrowser to show text search count and close search bar.
1431         https://bugs.webkit.org/show_bug.cgi?id=134486
1432
1433         Reviewed by Gyuyoung Kim.
1434
1435         Use on_search_close_button_clicked() callback to close search bar and on_search_text_found() callback to show search count.
1436
1437         * MiniBrowser/efl/main.c:
1438         (search_box_show):
1439         (search_box_hide):
1440         (on_search_close_button_clicked):
1441         (on_search_text_found):
1442         (window_create):
1443
1444 2014-07-03  Daniel Bates  <dabates@apple.com>
1445
1446         Add WTF::move()
1447         https://bugs.webkit.org/show_bug.cgi?id=134500
1448
1449         Rubber-stamped by Anders Carlsson.
1450
1451         Substitute WTF::move() for std::move().
1452
1453         * DumpRenderTree/win/DRTDataObject.cpp:
1454         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1455         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1456         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1457         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1458         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1459         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added FIXME comments that explain that some of the sub-tests
1460         aren't actually testing move semantics in tests: MoveAssignmentFromSameType, MoveAssignmentFromSimilarType,
1461         ConstructionFromSameType, and ConstructionFromSimilarType.
1462         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1463
1464 2014-07-03  László Langó  <llango.u-szeged@partner.samsung.com>
1465
1466         [JavaScriptCore] Add --cmakeargs option to build-jsc.
1467         https://bugs.webkit.org/show_bug.cgi?id=134590
1468
1469         Reviewed by Ryosuke Niwa.
1470
1471         * Scripts/build-jsc:
1472
1473 2014-07-03  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1474
1475         Add option to specify jsc args in run-sunspider.
1476         https://bugs.webkit.org/show_bug.cgi?id=134341
1477
1478         Reviewed by Csaba Osztrogonác.
1479
1480         * Scripts/run-sunspider:
1481
1482 2014-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1483
1484         [GTK] Unreviewed gardening.
1485
1486         * Scripts/run-gtk-tests:
1487         (TestRunner): Report and mark flaky test WebKit2Gtk/TestCookieManager:persistent-storage
1488
1489 2014-07-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1490
1491         Clean up unused EFL buildbot information in BuildSlaveSupport and TestResultServer
1492         https://bugs.webkit.org/show_bug.cgi?id=134581
1493
1494         Reviewed by Tim Horton.
1495
1496         Should be removed unused EFL bot info.
1497
1498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1499         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1500         (EWS):
1501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1502         (WebKitBuildbot):
1503         * TestResultServer/static-dashboards/builders.jsonp:
1504         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1505         (test):
1506
1507 2014-07-02  Alex Christensen  <achristensen@webkit.org>
1508
1509         Unreviewed.  Moved self to reviewers list.
1510
1511         * Scripts/webkitpy/common/config/contributors.json:
1512         Moved self to reviewers list, added WebGL to expertise.
1513
1514 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1515
1516         [GTK] Make dist only works when run from the source directory
1517         https://bugs.webkit.org/show_bug.cgi?id=134543
1518
1519         Reviewed by Martin Robinson.
1520
1521         Since the paths in the manifest are relative to the source dir,
1522         and the script expects the current working directory to be the
1523         source directory, resolve all passed in relative paths while
1524         parsing the arguments and then change the current working
1525         directory.
1526
1527         * gtk/make-dist.py:
1528
1529 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1530
1531         [GTK] make dist is broken
1532         https://bugs.webkit.org/show_bug.cgi?id=134542
1533
1534         Reviewed by Martin Robinson.
1535
1536         * gtk/make-dist.py: Rename command line options to match what cmake uses.
1537         * gtk/manifest.txt: Remove WebKit1 references and add WebKitDOM documentation.
1538
1539 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1540
1541         [GTK] WebKitWebView::create should receive information about the navigation action
1542         https://bugs.webkit.org/show_bug.cgi?id=133680
1543
1544         Reviewed by Martin Robinson.
1545
1546         Add unit test to check the WebKitNavigationAction passed to
1547         WebKitWebView::create callback.
1548
1549         * MiniBrowser/gtk/BrowserWindow.c:
1550         (webViewCreate): Add WebKitNavigationAction parameter.
1551         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1552         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1553         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1554         (testWebViewCreateNavigationData):
1555         (beforeAll):
1556         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
1557         (createCallback):
1558
1559 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1560
1561         [GTK] Do not add forward declaration of class struct for interfaces
1562         https://bugs.webkit.org/show_bug.cgi?id=134297
1563
1564         Reviewed by Martin Robinson.
1565
1566         Add Iface symbol to documentation instead of Class for interfaces.
1567
1568         * gtk/webkitdom.py:
1569         (WebKitDOMDocGeneratorSections.write_section):
1570
1571 2014-07-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1572
1573         [GTK] XPathNSResolver should be exposed as an interface instead of as a class
1574         https://bugs.webkit.org/show_bug.cgi?id=134028
1575
1576         Reviewed by Gustavo Noronha Silva.
1577
1578         Add unit tests to check WebKitDOMXPathNSResolver API when using the
1579         native one and a user provided one.
1580
1581         * Scripts/webkitpy/style/checker.py: Add WebKitDOMXPathNSResolver
1582         to the list of GTK+ public API exceptions.
1583         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
1584         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Added.
1585         (webkitXPathNSResolverLookupNamespaceURI):
1586         (webkitXPathNSResolverDOMXPathNSResolverIfaceInit):
1587         (webkit_xpath_ns_resolver_init):
1588         (webkit_xpath_ns_resolver_class_init):
1589         (WebKitDOMXPathNSResolverTest::create):
1590         (WebKitDOMXPathNSResolverTest::webPageFromArgs):
1591         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1592         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1593         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1594         (WebKitDOMXPathNSResolverTest::runTest):
1595         (registerTests):
1596         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Added.
1597         (runTest):
1598         (testWebKitDOMXPathNSResolverNative):
1599         (testWebKitDOMXPathNSResolverCustom):
1600         (serverCallback):
1601         (beforeAll):
1602         (afterAll):
1603         * gtk/webkitdom.py:
1604         (WebKitDOMDocGeneratorSections.write_section): Add
1605         WebKitDOMXPathNSResolver to the list of interfaces.
1606
1607 2014-07-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1608
1609         Fix build break on EFL and GTK ports since r170683
1610         https://bugs.webkit.org/show_bug.cgi?id=134536
1611
1612         Unreviewed, build fix.
1613
1614         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1615
1616 2014-07-01  Sam Weinig  <sam@webkit.org>
1617
1618         [Cocoa][Mac] WKWebView should automatically set topContentInset when beneath a toolbar
1619         <rdar://problem/17523159>
1620         https://bugs.webkit.org/show_bug.cgi?id=134496
1621
1622         Reviewed by Beth Dakin.
1623
1624         * MiniBrowser/mac/BrowserWindowController.m:
1625         (-[BrowserWindowController windowDidLoad]):
1626         Use the NSFullSizeContentViewWindowMask bit on Yosemite and later to enable toolbar blurring.
1627
1628 2014-07-01  Zan Dobersek  <zdobersek@igalia.com>
1629
1630         [CMake] Add necessary support for building for the Wayland target
1631         https://bugs.webkit.org/show_bug.cgi?id=134160
1632
1633         Reviewed by Darin Adler.
1634
1635         * CMakeLists.txt: Only build the TestNetscapePlugIn target in case
1636         the X11 windowing target is enabled.
1637
1638 2014-07-01  Chris Fleizach  <cfleizach@apple.com>
1639
1640         AX: HTML indeterminate IDL attribute not mapped to checkbox value=2
1641         https://bugs.webkit.org/show_bug.cgi?id=134492
1642
1643         Reviewed by Andreas Kling.
1644
1645         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1646         (AccessibilityUIElement::isIndeterminate):
1647         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1648         (WTR::AccessibilityUIElement::isIndeterminate):
1649
1650 2014-07-01  Daniel Bates  <dabates@apple.com>
1651
1652         Remove unnecessary calls to std::move()
1653         https://bugs.webkit.org/show_bug.cgi?id=134493
1654
1655         Reviewed by Anders Carlsson.
1656
1657         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1658         (TestWebKitAPI::TEST):
1659         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1660         (TestWebKitAPI::TEST):
1661
1662 2014-07-01  Pratik Solanki  <psolanki@apple.com>
1663
1664         Unreviewed. Adding myself to the reviewers list to make commit bot happy.
1665
1666         * Scripts/webkitpy/common/config/contributors.json:
1667
1668 2014-07-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1669
1670         webkit-patch apply-from-bug / apply-attachment should not ask for credentials if none are required
1671         https://bugs.webkit.org/show_bug.cgi?id=40095
1672
1673         Reviewed by Csaba Osztrogonác.
1674
1675         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1676         (Bugzilla.fetch_attachment_contents): make a first fetch on bugzilla without authentication. If failing, use authentication (similar to fetch_bug_dictionary).
1677         (Bugzilla):
1678         (Bugzilla.bug_id_for_attachment_id): ditto.
1679
1680 2014-07-01  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1681
1682         [webkitpy] Refactor pluralizer in grammar.py
1683         https://bugs.webkit.org/show_bug.cgi?id=133067
1684
1685         Reviewed by Csaba Osztrogonác.
1686
1687         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1688         (LayoutTestRunner.run_tests):
1689         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1690         (Manager.run):
1691         * Scripts/webkitpy/layout_tests/views/printing.py:
1692         (Printer.print_found):
1693         (Printer.print_workers_and_shards):
1694         (Printer._print_one_line_summary):
1695         * Scripts/webkitpy/test/printer.py:
1696         (Printer.print_result):
1697         * Scripts/webkitpy/tool/bot/feeders.py:
1698         (EWSFeeder.feed):
1699         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1700         (FlakyTestReporter._lookup_bug_for_flaky_test):
1701         * Scripts/webkitpy/tool/bot/irc_command.py:
1702         (Rollout._check_diff_failure):
1703         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1704         (IRCCommandTest.test_rollout):
1705         * Scripts/webkitpy/tool/commands/download.py:
1706         (AbstractPatchProcessingCommand._process_patch.execute):
1707         (ProcessBugsMixin._fetch_list_of_patches_to_process):
1708         (ProcessURLsMixin._fetch_list_of_patches_to_process):
1709         * Scripts/webkitpy/tool/commands/queries.py:
1710         (WhatBroke.execute):
1711         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1712         (SuggestNominations._print_nominations):
1713         (SuggestNominations._print_counts):
1714         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1715         (_make_options):
1716         (test_basic):
1717         (test_with_verbose):
1718         * Scripts/webkitpy/tool/commands/upload.py:
1719         (PostCommits.execute):
1720         * Scripts/webkitpy/tool/grammar.py:
1721         (pluralize):
1722         * Scripts/webkitpy/tool/grammar_unittest.py:
1723         (GrammarTest.test_join_with_separators):
1724         (GrammarTest):
1725         (GrammarTest.test_plural):
1726         (GrammarTest.test_pluralize):
1727         * Scripts/webkitpy/tool/multicommandtool.py:
1728         (Command.check_arguments_and_execute):
1729         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1730         (ObsoletePatches.run):
1731         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1732         (PrepareChangeLogForRevert._message_for_revert):
1733
1734 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
1735
1736         [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
1737         https://bugs.webkit.org/show_bug.cgi?id=134133
1738
1739         Reviewed by Simon Fraser.
1740
1741         Replace it with CTFontManagerRegisterGraphicsFont
1742
1743         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1744         * DumpRenderTree/mac/DumpRenderTree.mm:
1745         (activateFontIOS):
1746
1747 2014-06-30  Michael Saboff  <msaboff@apple.com>
1748
1749         Add option to run-jsc-stress-testes to filter out tests that use large heaps
1750         https://bugs.webkit.org/show_bug.cgi?id=134458
1751
1752         Reviewed by Filip Pizlo.
1753
1754         Added new --memory-limited to filter out tests that have large heap usage.
1755         Such tests are either tagged with //@largeHeap or logic is added to their .yaml file.
1756
1757         * Scripts/run-jsc-stress-tests:
1758
1759 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
1760
1761         DRT in iOS sim crashes while loading fonts
1762         https://bugs.webkit.org/show_bug.cgi?id=134451
1763
1764         Reviewed by Geoffrey Garen.
1765
1766         The magic linker symbols had the same name, and were therefore being unified
1767         to a single font file. Then, adding the same file twice was failing.
1768
1769         * DumpRenderTree/mac/DumpRenderTree.mm:
1770         (activateFontsIOS):
1771
1772 2014-06-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1773
1774         Remove Qt cruft from webkitpy
1775         https://bugs.webkit.org/show_bug.cgi?id=134445
1776
1777         Reviewed by Csaba Osztrogonác.
1778
1779         * Scripts/webkitpy/common/config/ports.py:
1780         (DeprecatedPort.port):
1781         (QtPort): Deleted.
1782         (QtPort.build_webkit_command): Deleted.
1783         (QtPort.run_webkit_tests_command): Deleted.
1784         (QtWK2Port): Deleted.
1785         (QtWK2Port.build_webkit_command): Deleted.
1786         (QtWK2Port.run_webkit_tests_command): Deleted.
1787         * Scripts/webkitpy/common/config/ports_unittest.py:
1788         (DeprecatedPortTest): Deleted.
1789         (DeprecatedPortTest.test_qt_port): Deleted.
1790         (DeprecatedPortTest.test_qt_wk2_port): Deleted.
1791
1792 2014-06-29  Yoav Weiss  <yoav@yoav.ws>
1793
1794         Add support for HTMLImageElement's sizes attribute
1795         https://bugs.webkit.org/show_bug.cgi?id=133620
1796
1797         Reviewed by Dean Jackson.
1798
1799         Added an ENABLE_PICTURE_SIZES compile flag.
1800
1801         * Scripts/webkitperl/FeatureList.pm:
1802
1803 2014-06-27  Tim Horton  <timothy_horton@apple.com>
1804
1805         check-webkit-style should check the order of #imports as well as #includes
1806         https://bugs.webkit.org/show_bug.cgi?id=134428
1807
1808         Reviewed by Dan Bernstein.
1809
1810         * Scripts/webkitpy/style/checkers/cpp.py:
1811         Allow "import" in addition to "include", so that the sort order of headers in ObjC files is checked.
1812
1813 2014-06-27  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1814
1815         [EFL] Remove efl-wk2 from baseline search path
1816         https://bugs.webkit.org/show_bug.cgi?id=134391
1817
1818         Reviewed by Gyuyoung Kim.
1819
1820         As WebKit1 EFL is removed and platform/efl and platform/efl-wk2 baselines and test expectations files
1821         are merged efl-wk2 search path should be removed.
1822
1823         * Scripts/webkitpy/port/base.py:
1824         (Port.test_expectations_file_postion): Added method to determine port test expectations file position in expectations_dict.
1825         * Scripts/webkitpy/port/efl.py:
1826         (EflPort._search_paths): Changed baseline search paths from efl-wk2 -> wk2 -> efl -> generic is changed to: efl -> wk2 -> generic.
1827         (EflPort.test_expectations_file_postion): Added method to determine EFL port specific test expectation file position.
1828         * Scripts/webkitpy/port/port_testcase.py:
1829         (PortTestCase.test_expectations_ordering): Changed constant value to one returned from test_expectations_file_postion().
1830         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1831         (TestExpectationsTestCase.test_determine_port_from_expectations_path): Removed efl-wk2 test case.
1832         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1833         (TestRebaselineTest.test_baseline_directory): Changed directory name in assertion from platform/efl-wk2 to platform/efl.
1834
1835 2014-06-26  Dan Bernstein  <mitz@apple.com>
1836
1837         prepare-ChangeLog outputs (NS_ENUM): entries for Cocoa enums
1838         https://bugs.webkit.org/show_bug.cgi?id=134387
1839
1840         Reviewed by Tim Horton.
1841
1842         * Scripts/prepare-ChangeLog:
1843         (get_function_line_ranges_for_cpp): Don’t consider {CF,NS}_{ENUM,OPTIONS} as function names.
1844
1845 2014-06-26  Dan Bernstein  <mitz@apple.com>
1846
1847         prepare-ChangeLog mangles Objective-C selectors for methods with parameter types that contain colons
1848         https://bugs.webkit.org/show_bug.cgi?id=134383
1849
1850         Reviewed by Tim Horton.
1851
1852         * Scripts/prepare-ChangeLog:
1853         (method_decl_to_selector): Strip out the return type and parameter types before splitting at
1854         colons.
1855
1856 2014-06-26  Brady Eidson  <beidson@apple.com>
1857
1858         MiniBrowser should support a preference to override the default URL
1859         https://bugs.webkit.org/show_bug.cgi?id=134373
1860
1861         Reviewed by Darin Adler.
1862
1863         * MiniBrowser/mac/AppDelegate.m:
1864         (-[BrowserAppDelegate applicationDidFinishLaunching:]): See if there’s a pref
1865           overriding the default URL, and use it if there is.
1866
1867 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
1868
1869         [Win] Fix potential buffer overrun in DLLLauncher
1870         https://bugs.webkit.org/show_bug.cgi?id=134351
1871         <rdar://problem/17469185>
1872
1873         Reviewed by Darin Adler.
1874
1875         * win/DLLLauncher/DLLLauncherMain.cpp: Correct error
1876         in end-of-buffer calculation.
1877
1878 2014-06-26  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1879
1880         [EFL] Missing dependency between freetype6 and fontconfig libs.
1881         https://bugs.webkit.org/show_bug.cgi?id=134190
1882
1883         Reviewed by Gyuyoung Kim.
1884
1885         The external dependencies contain the freetype6 and the fontconfig libs.
1886         The fontconfig lib requires freetype, but the dependency is not set in
1887         the efl/jhbuild.modules file. So, during building the external libs,
1888         fontconfig uses the freetype package of the system, while WebKit
1889         binaries will use freetype from the WebKitBuild/Dependency directory.
1890         There are more similar dependencies that were not indicated in the
1891         jhbuild.modules file.
1892
1893         * efl/jhbuild.modules:
1894           Added dependencies between libs.
1895
1896 2014-06-25  Brent Fulgham  <bfulgham@apple.com>
1897
1898         [Win] Expose Cache Information to WinLauncher
1899         https://bugs.webkit.org/show_bug.cgi?id=134318
1900
1901         Reviewed by Dean Jackson.
1902
1903         * WinLauncher/Common.cpp: Update for new dialog.
1904         * WinLauncher/WinLauncher.cpp: Add support for WebCache
1905         and WebCoreStatistics.
1906         * WinLauncher/WinLauncher.h:
1907         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
1908         Update for new Cache Dialog.
1909         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to
1910         WTF.lib
1911         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
1912         for new Dialog.
1913
1914 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
1915
1916         [Win] Unreviewed gardening. Use consistent line-endings in file.
1917
1918         * WinLauncher/WinLauncher.h: Use '\n' EOL marker, not DOS-style
1919         '\r\n' EOL.
1920
1921 2014-06-25  László Langó  <llango.u-szeged@partner.samsung.com>
1922
1923         [JavaScriptCore] Make build-jsc output format better.
1924         https://bugs.webkit.org/show_bug.cgi?id=133547
1925
1926         Reviewed by Ryosuke Niwa.
1927
1928         * Scripts/build-jsc: Emit built time information on successful builds.
1929         (writeCongrats):
1930         * Scripts/build-webkit: Move formatBuildTime function into webkitdirs.pm.
1931         (cMakeArgsFromFeatures):
1932         (formatBuildTime): Deleted.
1933         * Scripts/webkitdirs.pm:
1934         (formatBuildTime):
1935
1936 2014-06-25  Chris Fleizach  <cfleizach@apple.com>
1937
1938         Add an undo group for each dictated utterance in WebKit
1939         https://bugs.webkit.org/show_bug.cgi?id=134086
1940
1941         Reviewed by Enrica Casucci.
1942
1943         Create a method for creating attributed strings with the undo insertion marker.
1944
1945         * DumpRenderTree/mac/TextInputController.m:
1946         (+[TextInputController isSelectorExcludedFromWebScript:]):
1947         (+[TextInputController webScriptNameForSelector:]):
1948         (-[TextInputController stringWithUndoGroupingInsertion:]):
1949
1950 2014-06-25  Michael Saboff  <msaboff@apple.com>
1951
1952         Provide javascript aware backtrace script for lldb
1953         https://bugs.webkit.org/show_bug.cgi?id=134276
1954
1955         Reviewed by Jer Noble.
1956
1957         * lldb/lldb_webkit.py:
1958         (__lldb_init_module):
1959         (btjs): New scripted command to display a backtrace that shows JavaScript frames with details.
1960
1961 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1962
1963         REGRESSION (r170426) Broke two python tests
1964         https://bugs.webkit.org/show_bug.cgi?id=134299
1965
1966         Reviewed by Csaba Osztrogonác.
1967
1968         * Scripts/webkitpy/port/efl.py:
1969         (EflPort._search_paths): Added search path for efl-wk2.
1970
1971 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1972
1973         [EFL] Remove WebKit1 related code from scripts
1974         https://bugs.webkit.org/show_bug.cgi?id=134195
1975
1976         Reviewed by Laszlo Gombos.
1977
1978         After removing WebKit1 from EFL port, still there is some code left related to DumpRenderTree, 
1979         EWebLauncher. Also running layout tests does not require adding -2/--webkit-test-runner switch.
1980
1981         * Scripts/run-launcher: MiniBrowser now runs as default without -2 switch.
1982         * Scripts/webkitdirs.pm:
1983         (builtDylibPathForName): Remove reference to libewebkit.so
1984         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1985         (_set_up_derived_options): Script runs WKTR by default.
1986         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1987         (PerfTestsRunner.__init__): Ditto.
1988         * Scripts/webkitpy/port/efl.py:
1989         (EflPort._search_paths): Remove efl-wk2 from baseline search path.
1990         (EflPort.show_results_html_file): Run MiniBrowser as result viewer.
1991
1992 2014-06-25  Laszlo Gombos  <l.gombos@samsung.com>
1993
1994         Remove build guard for progress element
1995         https://bugs.webkit.org/show_bug.cgi?id=134292
1996
1997         Reviewed by Benjamin Poulain.
1998
1999         * Scripts/webkitperl/FeatureList.pm:
2000
2001 2014-06-24  Tomas Popela  <tpopela@redhat.com>
2002
2003         [GTK] Some of DOM bindings macros are misnamed
2004         https://bugs.webkit.org/show_bug.cgi?id=121543
2005
2006         Reviewed by Carlos Garcia Campos.
2007
2008         As we are using WebKitDOM as a namespace we should unify all type macros
2009         to have WEBKIT_DOM_TYPE prefix instead of WEBKIT_TYPE_DOM. Also add
2010         more exceptions to decamelize function in GObject bindings generator
2011         to fix the names of bindings for BR, HR, UL, OL, DL and LI elements.
2012
2013         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
2014         * gtk/webkitdom.py:
2015         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
2016         (WebKitDOMDocGeneratorSections.write_section):
2017
2018 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
2019
2020         [EFL] Install Latin Modern Math on the bots
2021         https://bugs.webkit.org/show_bug.cgi?id=134153
2022
2023         Reviewed by Gyuyoung Kim.
2024
2025         * efl/jhbuild.modules: Switch back to https://github.com/ for the webkitgtk-test-fonts.
2026
2027 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
2028
2029         [EFL] [GTK] Use Latin Modern Math in the jhbuild environments.
2030         https://bugs.webkit.org/show_bug.cgi?id=134153
2031
2032         Reviewed by Martin Robinson.
2033
2034         * efl/jhbuild.modules: Use webkitgtk-test-fonts.git instead of the zip archive and upgrade to 0.0.5.
2035         * gtk/jhbuild.modules: Upgrade webkitgtk-test-fonts to 0.0.5.
2036
2037 2014-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2038
2039         Unreviewed, update my speciality.
2040
2041         * Scripts/webkitpy/common/config/contributors.json:
2042
2043 2014-06-24  Brent Fulgham  <bfulgham@apple.com>
2044
2045         [Win] Clean up and refactor WinLauncher
2046         https://bugs.webkit.org/show_bug.cgi?id=134209
2047
2048         Reviewed by Tim Thorton.
2049
2050         Relanding r170339 and r170340 with correct WinLauncher.h file.
2051
2052         * WinLauncher/Common.cpp: Copied from WinLauncher/WinLauncher.cpp.
2053         (PrintView):
2054         (ToggleMenuItem):
2055         (WndProc):
2056         (BackButtonProc):
2057         (ForwardButtonProc):
2058         (loadURL):
2059         (shouldUseFullDesktop): Deleted.
2060         (SimpleEventListener::SimpleEventListener): Deleted.
2061         (SimpleEventListener::handleEvent): Deleted.
2062         (WinLauncherWebHost::updateAddressBar): Deleted.
2063         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
2064         (WinLauncherWebHost::QueryInterface): Deleted.
2065         (WinLauncherWebHost::AddRef): Deleted.
2066         (WinLauncherWebHost::Release): Deleted.
2067         (updateMenuItemForHistoryItem): Deleted.
2068         (showLastVisitedSites): Deleted.
2069         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
2070         (resizeSubViews): Deleted.
2071         (setToDefaultPreferences): Deleted.
2072         (wWinMain): Deleted.
2073         (MyRegisterClass): Deleted.
2074         (LaunchInspector): Deleted.
2075         (NavigateForwardOrBackward): Deleted.
2076         (NavigateToHistory): Deleted.
2077         * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
2078         (DOMEventListener::Release):
2079         (WebScriptObject::WebScriptObject): Deleted.
2080         (WebScriptObject::~WebScriptObject): Deleted.
2081         (WebScriptObject::throwException): Deleted.
2082         (WebScriptObject::callWebScriptMethod): Deleted.
2083         (WebScriptObject::evaluateWebScript): Deleted.
2084         (WebScriptObject::removeWebScriptKey): Deleted.
2085         (WebScriptObject::stringRepresentation): Deleted.
2086         (WebScriptObject::webScriptValueAtIndex): Deleted.
2087         (WebScriptObject::setWebScriptValueAtIndex): Deleted.
2088         (WebScriptObject::setException): Deleted.
2089         (DOMEventListener::throwException): Deleted.
2090         (DOMEventListener::callWebScriptMethod): Deleted.
2091         (DOMEventListener::evaluateWebScript): Deleted.
2092         (DOMEventListener::removeWebScriptKey): Deleted.
2093         (DOMEventListener::stringRepresentation): Deleted.
2094         (DOMEventListener::webScriptValueAtIndex): Deleted.
2095         (DOMEventListener::setWebScriptValueAtIndex): Deleted.
2096         (DOMEventListener::setException): Deleted.
2097         (DOMEventListener::handleEvent): Deleted.
2098         * WinLauncher/DOMDefaultImpl.h:
2099         (WebScriptObject::QueryInterface): Deleted.
2100         (WebScriptObject::AddRef): Deleted.
2101         (WebScriptObject::Release): Deleted.
2102         (DOMObject::QueryInterface): Deleted.
2103         (DOMEventListener::QueryInterface): Deleted.
2104         (DOMEventListener::AddRef): Deleted.
2105         (DOMEventListener::Release): Deleted.
2106         * WinLauncher/WinLauncher.cpp:
2107         (WinLauncher::WinLauncher):
2108         (WinLauncher::init):
2109         (WinLauncher::prepareViews):
2110         (WinLauncher::setFrameLoadDelegate):
2111         (WinLauncher::setUIDelegate):
2112         (WinLauncher::setAccessibilityDelegate):
2113         (WinLauncher::mainFrame):
2114         (WinLauncher::seedInitialDefaultPreferences):
2115         (WinLauncher::setToDefaultPreferences):
2116         (updateMenuItemForHistoryItem):
2117         (WinLauncher::showLastVisitedSites):
2118         (WinLauncher::launchInspector):
2119         (WinLauncher::navigateForwardOrBackward):
2120         (WinLauncher::navigateToHistory):
2121         (WinLauncher::goBack):
2122         (WinLauncher::goForward):
2123         (WinLauncher::loadURL):
2124         (shouldUseFullDesktop): Deleted.
2125         (SimpleEventListener::SimpleEventListener): Deleted.
2126         (SimpleEventListener::handleEvent): Deleted.
2127         (WinLauncherWebHost::updateAddressBar): Deleted.
2128         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
2129         (WinLauncherWebHost::QueryInterface): Deleted.
2130         (WinLauncherWebHost::AddRef): Deleted.
2131         (WinLauncherWebHost::Release): Deleted.
2132         (showLastVisitedSites): Deleted.
2133         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
2134         (resizeSubViews): Deleted.
2135         (subclassForLayeredWindow): Deleted.
2136         (computeFullDesktopFrame): Deleted.
2137         (DllMain): Deleted.
2138         (getAppDataFolder): Deleted.
2139         (setToDefaultPreferences): Deleted.
2140         (setCacheFolder): Deleted.
2141         (createCrashReport): Deleted.
2142         (wWinMain): Deleted.
2143         (MyRegisterClass): Deleted.
2144         (AbortProc): Deleted.
2145         (getPrinterDC): Deleted.
2146         (initDocStruct): Deleted.
2147         (PrintView): Deleted.
2148         (ToggleMenuItem): Deleted.
2149         (LaunchInspector): Deleted.
2150         (NavigateForwardOrBackward): Deleted.
2151         (NavigateToHistory): Deleted.
2152         (WndProc): Deleted.
2153         (EditProc): Deleted.
2154         (BackButtonProc): Deleted.
2155         (ForwardButtonProc): Deleted.
2156         (About): Deleted.
2157         (loadURL): Deleted.
2158         (dllLauncherEntryPoint): Deleted.
2159         * WinLauncher/WinLauncher.h:
2160         (WinLauncher::standardPreferences):
2161         (WinLauncher::privatePreferences):
2162         (WinLauncher::hasWebView):
2163         (WinLauncher::usesLayeredWebView):
2164         (WinLauncherWebHost::WinLauncherWebHost): Deleted.
2165         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
2166         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): Deleted.
2167         (WinLauncherWebHost::didCommitLoadForFrame): Deleted.
2168         (WinLauncherWebHost::didReceiveTitle): Deleted.
2169         (WinLauncherWebHost::didChangeIcons): Deleted.
2170         (WinLauncherWebHost::didReceiveIcon): Deleted.
2171         (WinLauncherWebHost::didFailLoadWithError): Deleted.
2172         (WinLauncherWebHost::didChangeLocationWithinPageForFrame): Deleted.
2173         (WinLauncherWebHost::willPerformClientRedirectToURL): Deleted.
2174         (WinLauncherWebHost::didCancelClientRedirectForFrame): Deleted.
2175         (WinLauncherWebHost::willCloseFrame): Deleted.
2176         (WinLauncherWebHost::windowScriptObjectAvailable): Deleted.
2177         (WinLauncherWebHost::didClearWindowObject): Deleted.
2178         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2179         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2180         * WinLauncher/WinLauncherReplace.h:
2181         (processCrashReport):
2182         * WinLauncher/WinLauncherWebHost.cpp: Copied from WinLauncher/WinLauncher.cpp.
2183         (WinLauncherWebHost::updateAddressBar):
2184         (WinLauncherWebHost::QueryInterface):
2185         (WinLauncherWebHost::AddRef):
2186         (WinLauncherWebHost::Release):
2187         (WinLauncherWebHost::didFinishLoadForFrame):
2188         (shouldUseFullDesktop): Deleted.
2189         (updateMenuItemForHistoryItem): Deleted.
2190         (showLastVisitedSites): Deleted.
2191         (resizeSubViews): Deleted.
2192         (subclassForLayeredWindow): Deleted.
2193         (computeFullDesktopFrame): Deleted.
2194         (DllMain): Deleted.
2195         (getAppDataFolder): Deleted.
2196         (setToDefaultPreferences): Deleted.
2197         (setCacheFolder): Deleted.
2198         (createCrashReport): Deleted.
2199         (wWinMain): Deleted.
2200         (MyRegisterClass): Deleted.
2201         (AbortProc): Deleted.
2202         (getPrinterDC): Deleted.
2203         (initDocStruct): Deleted.
2204         (PrintView): Deleted.
2205         (ToggleMenuItem): Deleted.
2206         (LaunchInspector): Deleted.
2207         (NavigateForwardOrBackward): Deleted.
2208         (NavigateToHistory): Deleted.
2209         (WndProc): Deleted.
2210         (EditProc): Deleted.
2211         (BackButtonProc): Deleted.
2212         (ForwardButtonProc): Deleted.
2213         (About): Deleted.
2214         (loadURL): Deleted.
2215         (dllLauncherEntryPoint): Deleted.
2216         * WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
2217         (WinLauncherWebHost::WinLauncherWebHost):
2218         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
2219         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
2220         (WinLauncherWebHost::didCommitLoadForFrame):
2221         (WinLauncherWebHost::didReceiveTitle):
2222         (WinLauncherWebHost::didChangeIcons):
2223         (WinLauncherWebHost::didReceiveIcon):
2224         (WinLauncherWebHost::didFailLoadWithError):
2225         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
2226         (WinLauncherWebHost::willPerformClientRedirectToURL):
2227         (WinLauncherWebHost::didCancelClientRedirectForFrame):
2228         (WinLauncherWebHost::willCloseFrame):
2229         (WinLauncherWebHost::windowScriptObjectAvailable):
2230         (WinLauncherWebHost::didClearWindowObject):
2231         * WinLauncher/WinMain.cpp: Copied from WinLauncher/WinLauncher.cpp.
2232         (wWinMain):
2233         (MyRegisterClass):
2234         (shouldUseFullDesktop): Deleted.
2235         (SimpleEventListener::SimpleEventListener): Deleted.
2236         (SimpleEventListener::handleEvent): Deleted.
2237         (WinLauncherWebHost::updateAddressBar): Deleted.
2238         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
2239         (WinLauncherWebHost::QueryInterface): Deleted.
2240         (WinLauncherWebHost::AddRef): Deleted.
2241         (WinLauncherWebHost::Release): Deleted.
2242         (updateMenuItemForHistoryItem): Deleted.
2243         (showLastVisitedSites): Deleted.
2244         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
2245         (resizeSubViews): Deleted.
2246         (subclassForLayeredWindow): Deleted.
2247         (computeFullDesktopFrame): Deleted.
2248         (DllMain): Deleted.
2249         (getAppDataFolder): Deleted.
2250         (setToDefaultPreferences): Deleted.
2251         (setCacheFolder): Deleted.
2252         (createCrashReport): Deleted.
2253         (AbortProc): Deleted.
2254         (getPrinterDC): Deleted.
2255         (initDocStruct): Deleted.
2256         (PrintView): Deleted.
2257         (ToggleMenuItem): Deleted.
2258         (LaunchInspector): Deleted.
2259         (NavigateForwardOrBackward): Deleted.
2260         (NavigateToHistory): Deleted.
2261         (WndProc): Deleted.
2262         (EditProc): Deleted.
2263         (BackButtonProc): Deleted.
2264         (ForwardButtonProc): Deleted.
2265         (About): Deleted.
2266         (loadURL): Deleted.
2267         (dllLauncherEntryPoint): Deleted.
2268
2269 2014-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
2270
2271         [iOS] getsectdata() is deprecated and we use it in DRT
2272         https://bugs.webkit.org/show_bug.cgi?id=134122
2273
2274         Reviewed by Alexey Proskuryakov.
2275
2276         Migrate to using magic linker symbols.
2277
2278         No tests because there should be no behavior change
2279
2280         * DumpRenderTree/mac/DumpRenderTree.mm:
2281         (activateFontsIOS):
2282
2283 2014-06-24  Javier Fernandez  <jfernandez@igalia.com>
2284
2285         Name moving. Unreviewed.
2286
2287         * Scripts/webkitpy/common/config/contributors.json:
2288
2289 2014-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2290
2291         Remove EFL WK1 watch category
2292         https://bugs.webkit.org/show_bug.cgi?id=134231
2293
2294         Reviewed by Csaba Osztrogonác.
2295
2296         * Scripts/webkitpy/common/config/watchlist: Removed EFL WK1 category.
2297
2298 2014-06-24  Krzysztof Czech  <k.czech@samsung.com>
2299
2300         [ATK] Remove some unused code from DumpRenderTree
2301         https://bugs.webkit.org/show_bug.cgi?id=134191
2302
2303         Reviewed by Chris Fleizach.
2304
2305         DumpRenderTree's accessibility code could be removed since GTK and EFL has stopped supporting WK1.
2306
2307         * DumpRenderTree/atk/AccessibilityCallbacks.h: Removed.
2308         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Removed.
2309         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp: Removed.
2310         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Removed.
2311         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Removed.
2312         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Removed.
2313
2314 2014-06-23  Shivakumar JM  <shiva.jm@samsung.com>
2315
2316         [EFL][WK2] Search field is not shown properly on doing ctrl+f on Minibrowser.
2317         https://bugs.webkit.org/show_bug.cgi?id=134025
2318
2319         Reviewed by Gyuyoung Kim.
2320
2321         Use EVAS_HINT_FILL in evas_object_size_hint_align_set() api.
2322
2323         * MiniBrowser/efl/main.c:
2324         (window_create):
2325
2326 2014-06-23  Ryuan Choi  <ryuan.choi@samsung.com>
2327
2328         [EFL] Replace RefPtr<Evas_Object> with UniquePtrEfl
2329         https://bugs.webkit.org/show_bug.cgi?id=134236
2330
2331         Reviewed by Gyuyoung Kim.
2332
2333         * ImageDiff/efl/ImageDiff.cpp:
2334         (calculateDifference):
2335         (printImageDifferences):
2336         (readImageFromStdin):
2337         (main):
2338
2339 2014-06-23  Daniel Bates  <dabates@apple.com>
2340
2341         Rolling out r170340 and r170339.
2342
2343         Changeset r170339 broke the Apple Windows Debug and Release builds.
2344
2345         Reverted changesets:
2346
2347         "[Win] Build fix after r134209"
2348         http://trac.webkit.org/changeset/170340
2349
2350         "[Win] Clean up and refactor WinLauncher"
2351         https://bugs.webkit.org/show_bug.cgi?id=134209
2352         http://trac.webkit.org/changeset/170339
2353
2354 2014-06-23  Brent Fulgham  <bfulgham@apple.com>
2355
2356         [Win] Build fix after r134209
2357
2358         * WinLauncher/WinMain.cpp: Must include the resources file
2359         before Common.cpp.
2360
2361 2014-06-23  Brent Fulgham  <bfulgham@apple.com>
2362
2363         [Win] Clean up and refactor WinLauncher
2364         https://bugs.webkit.org/show_bug.cgi?id=134209
2365
2366         Reviewed by Tim Horton.
2367
2368         Make WinLauncher a class, and move all non-class driver functions
2369         into "Common.cpp" and "WinMain.cpp". These files are distinct
2370         to allow some internal tools to reuse the code in 'Common'.
2371
2372         * WinLauncher/Common.cpp: Added. Consists of code moved from
2373         'WinLauncher.cpp' that can be reused for other tools.
2374         (subclassForLayeredWindow):
2375         (computeFullDesktopFrame):
2376         (DllMain):
2377         (getAppDataFolder):
2378         (setCacheFolder):
2379         (createCrashReport):
2380         (AbortProc):
2381         (getPrinterDC):
2382         (initDocStruct):
2383         (PrintView):
2384         (ToggleMenuItem):
2385         (WndProc):
2386         (EditProc):
2387         (BackButtonProc):
2388         (ForwardButtonProc):
2389         (About):
2390         (loadURL):
2391         (dllLauncherEntryPoint):
2392         * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
2393         (DOMEventListener::Release):
2394         (WebScriptObject::WebScriptObject): Deleted.
2395         (WebScriptObject::~WebScriptObject): Deleted.
2396         (WebScriptObject::throwException): Deleted.
2397         (WebScriptObject::callWebScriptMethod): Deleted.
2398         (WebScriptObject::evaluateWebScript): Deleted.
2399         (WebScriptObject::removeWebScriptKey): Deleted.
2400         (WebScriptObject::stringRepresentation): Deleted.
2401         (WebScriptObject::webScriptValueAtIndex): Deleted.
2402         (WebScriptObject::setWebScriptValueAtIndex): Deleted.
2403         (WebScriptObject::setException): Deleted.
2404         (DOMEventListener::throwException): Deleted.
2405         (DOMEventListener::callWebScriptMethod): Deleted.
2406         (DOMEventListener::evaluateWebScript): Deleted.
2407         (DOMEventListener::removeWebScriptKey): Deleted.
2408         (DOMEventListener::stringRepresentation): Deleted.
2409         (DOMEventListener::webScriptValueAtIndex): Deleted.
2410         (DOMEventListener::setWebScriptValueAtIndex): Deleted.
2411         (DOMEventListener::setException): Deleted.
2412         (DOMEventListener::handleEvent): Deleted.
2413         * WinLauncher/DOMDefaultImpl.h:
2414         (WebScriptObject::QueryInterface): Deleted.
2415         (WebScriptObject::AddRef): Deleted.
2416         (WebScriptObject::Release): Deleted.
2417         (DOMObject::QueryInterface): Deleted.
2418         (DOMEventListener::QueryInterface): Deleted.
2419         (DOMEventListener::AddRef): Deleted.
2420         (DOMEventListener::Release): Deleted.
2421         * WinLauncher/WinLauncher.cpp: Converted stand-alone implementation
2422         into a C++ class and removed WinAPI code.
2423         (WinLauncher::WinLauncher):
2424         (WinLauncher::init):
2425         (WinLauncher::prepareViews):
2426         (WinLauncher::setFrameLoadDelegate):
2427         (WinLauncher::setUIDelegate):
2428         (WinLauncher::setAccessibilityDelegate):
2429         (WinLauncher::mainFrame):
2430         (WinLauncher::seedInitialDefaultPreferences):
2431         (WinLauncher::setToDefaultPreferences):
2432         (updateMenuItemForHistoryItem):
2433         (WinLauncher::showLastVisitedSites):
2434         (WinLauncher::launchInspector):
2435         (WinLauncher::navigateForwardOrBackward):
2436         (WinLauncher::navigateToHistory):
2437         (WinLauncher::goBack):
2438         (WinLauncher::goForward):
2439         (WinLauncher::loadURL):
2440         (shouldUseFullDesktop): Deleted.
2441         (SimpleEventListener::SimpleEventListener): Deleted.
2442         (SimpleEventListener::handleEvent): Deleted.
2443         (WinLauncherWebHost::updateAddressBar): Deleted.
2444         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
2445         (WinLauncherWebHost::QueryInterface): Deleted.
2446         (WinLauncherWebHost::AddRef): Deleted.
2447         (WinLauncherWebHost::Release): Deleted.
2448         (showLastVisitedSites): Deleted.
2449         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
2450         (resizeSubViews): Deleted.
2451         (subclassForLayeredWindow): Deleted.
2452         (computeFullDesktopFrame): Deleted.
2453         (DllMain): Deleted.
2454         (getAppDataFolder): Deleted.
2455         (setToDefaultPreferences): Deleted.
2456         (setCacheFolder): Deleted.
2457         (createCrashReport): Deleted.
2458         (wWinMain): Deleted.
2459         (MyRegisterClass): Deleted.
2460         (AbortProc): Deleted.
2461         (getPrinterDC): Deleted.
2462         (initDocStruct): Deleted.
2463         (PrintView): Deleted.
2464         (ToggleMenuItem): Deleted.
2465         (LaunchInspector): Deleted.
2466         (NavigateForwardOrBackward): Deleted.
2467         (NavigateToHistory): Deleted.
2468         (WndProc): Deleted.
2469         (EditProc): Deleted.
2470         (BackButtonProc): Deleted.
2471         (ForwardButtonProc): Deleted.
2472         (About): Deleted.
2473         (loadURL): Deleted.
2474         (dllLauncherEntryPoint): Deleted.
2475         * WinLauncher/WinLauncher.h: Removed.
2476         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2477         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2478         * WinLauncher/WinLauncherReplace.h:
2479         (processCrashReport):
2480         * WinLauncher/WinLauncherWebHost.cpp: Added.
2481         (SimpleEventListener::SimpleEventListener):
2482         (SimpleEventListener::handleEvent):
2483         (WinLauncherWebHost::updateAddressBar):
2484         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2485         (WinLauncherWebHost::QueryInterface):
2486         (WinLauncherWebHost::AddRef):
2487         (WinLauncherWebHost::Release):
2488         (WinLauncherWebHost::didFinishLoadForFrame):
2489         * WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
2490         Moved WinLauncherWebHost implementation from WinLauncher.cpp into
2491         its own set of files.
2492         (WinLauncherWebHost::WinLauncherWebHost):
2493         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
2494         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
2495         (WinLauncherWebHost::didCommitLoadForFrame):
2496         (WinLauncherWebHost::didReceiveTitle):
2497         (WinLauncherWebHost::didChangeIcons):
2498         (WinLauncherWebHost::didReceiveIcon):
2499         (WinLauncherWebHost::didFailLoadWithError):
2500         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
2501         (WinLauncherWebHost::willPerformClientRedirectToURL):
2502         (WinLauncherWebHost::didCancelClientRedirectForFrame):
2503         (WinLauncherWebHost::willCloseFrame):
2504         (WinLauncherWebHost::windowScriptObjectAvailable):
2505         (WinLauncherWebHost::didClearWindowObject):
2506         * WinLauncher/WinMain.cpp: Added. This consists of code from
2507         WinLauncher that is unique to the WinLauncher utility, and is
2508         not part of the WinLauncher class.
2509         (wWinMain):
2510         (MyRegisterClass):
2511
2512 2014-06-23  Simon Fraser  <simon.fraser@apple.com>
2513
2514         Enable the Web Inspector in MiniBrowser
2515         https://bugs.webkit.org/show_bug.cgi?id=134148
2516
2517         Reviewed by Joseph Pecoraro.
2518         
2519         Set the pref to enable Web Inspector in both WK1 and WK2 windows.
2520
2521         * MiniBrowser/mac/AppDelegate.m:
2522         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2523
2524 2014-06-21  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2525
2526         Disable gamepad feature on EFL and GTK ports by default
2527         https://bugs.webkit.org/show_bug.cgi?id=134169
2528
2529         Reviewed by Brady Eidson.
2530
2531         EFL and GTK ports disabled Gamepad feature now. Besides current implementation
2532         was treated to 'deprecated' status.
2533
2534         ENABLE_GAMEPAD_DEPRECATED is disabled for now. There is build break on EFL port.
2535
2536         * Scripts/webkitperl/FeatureList.pm:
2537
2538 2014-06-21  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2539
2540         [Inspector][EFL] Can't resume a special break point on EFL inspector
2541         https://bugs.webkit.org/show_bug.cgi?id=129294
2542
2543         Reviewed by Gyuyoung Kim.
2544
2545         Patch our EFL 1.9 with the fix landed in upstream EFL 1.10
2546         by Ryuan Choi - <https://phab.enlightenment.org/D790>
2547
2548         * efl/jhbuild.modules:
2549         * efl/patches/ecore.patch: Added.
2550
2551 2014-06-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2552
2553         Removing PAGE_VISIBILITY_API compile guard.
2554         https://bugs.webkit.org/show_bug.cgi?id=133844
2555
2556         Reviewed by Gavin Barraclough.
2557
2558         * Scripts/webkitperl/FeatureList.pm:
2559
2560 2014-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
2561
2562         [EFL] Remove DumpRenderTree/efl and EWebLauncher
2563         https://bugs.webkit.org/show_bug.cgi?id=134138
2564
2565         Reviewed by Gyuyoung Kim.
2566
2567         DumpRenderTree/efl and EWebLauncher are not necessary anymore because WebKit1 EFL will be removed.
2568
2569         * CMakeLists.txt:
2570         * DumpRenderTree/PlatformEfl.cmake: Removed.
2571         * DumpRenderTree/efl: Removed entire directory.
2572         * EWebLauncher: Ditto.
2573         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Renamed from Tools/DumpRenderTree/efl/FontManagement.cpp.
2574         (buildPath):
2575         (getCoreFontFiles):
2576         (addFontDirectory):
2577         (addFontFiles):
2578         (getCustomBuildDir):
2579         (getPlatformFontsPath):
2580         (addFontsToEnvironment):
2581         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Renamed from Tools/DumpRenderTree/efl/FontManagement.h.
2582         * WebKitTestRunner/PlatformEfl.cmake:
2583
2584 2014-06-20  Zalan Bujtas  <zalan@apple.com>
2585
2586         Name moving. Unreviewed.
2587
2588         * Scripts/webkitpy/common/config/contributors.json:
2589
2590 2014-06-20  Javier Fernandez  <jfernandez@igalia.com>
2591
2592         Unreviewed. Adding myself to committers.
2593
2594         * Scripts/webkitpy/common/config/contributors.json:
2595
2596 2014-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
2597
2598         Unreviewed. Adding myself to committers.
2599
2600         * Scripts/webkitpy/common/config/contributors.json:
2601
2602 2014-06-20  Tim Horton  <timothy_horton@apple.com>
2603
2604         Make WebKit2 more accessible in MiniBrowser
2605         https://bugs.webkit.org/show_bug.cgi?id=134099
2606
2607         Reviewed by Anders Carlsson.
2608
2609         * MiniBrowser/mac/AppDelegate.h:
2610         * MiniBrowser/mac/AppDelegate.m:
2611         (-[BrowserAppDelegate newWindow:]):
2612         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2613         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]):
2614         (-[BrowserAppDelegate _useWebKit2ByDefault]):
2615         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2616         (-[BrowserAppDelegate validateMenuItem:]):
2617         * MiniBrowser/mac/MainMenu.xib:
2618         Add a "Use WebKit2 By Default" menu item to the top of the Debug menu.
2619         When switched on, Cmd-N will make WebKit2 windows (and the default window will be WebKit2).
2620         Make the non-default new-window menu item always show up, because people often don't find it
2621         when you have to press option to have it show up.
2622
2623         * MiniBrowser/mac/BrowserWindowController.h:
2624         * MiniBrowser/mac/BrowserWindowController.m:
2625         (-[BrowserWindowController initWithWindow:]):
2626         
2627         * MiniBrowser/mac/WK1BrowserWindowController.m:
2628         (-[WK1BrowserWindowController validateMenuItem:]):
2629         * MiniBrowser/mac/WK2BrowserWindowController.m:
2630         (-[WK2BrowserWindowController validateMenuItem:]):
2631         Use the cached [menuItem action] like the earlier cases do.
2632
2633 2014-06-20  Daniel Bates  <dabates@apple.com>
2634
2635         Teach run-{safari, webkit-app} about iOS Simulator
2636         https://bugs.webkit.org/show_bug.cgi?id=133986
2637
2638         Reviewed by David Kilzer.
2639
2640         Extract the logic from old-run-webkit-tests to install and launch {DumpRenderTree, WebKitTestRunnerApp}.app
2641         into general-purpose routines in webkitdirs.pm so that they can be used both by script old-run-webkit-tests
2642         and run-safari.
2643
2644         * Scripts/old-run-webkit-tests:
2645         (installAndLaunchDumpToolAppUsingNotification): Extracted logic to install and launch {DumpRenderTree,
2646         WebKitTestRunnerApp}.app into webkitdirs::installAndLaunchIOSWebKitAppInSimulator() and modified code
2647         to call it.
2648         (openIPhoneSimulator): Deleted; moved logic to webkitdirs::openIOSSimulator().
2649         (quitIPhoneSimulator): Deleted; moved logic to webkitdirs::quitIOSSimulator().
2650         * Scripts/run-webkit-app: Modified to call runIOSWebKitApp() when the iOS simulator SDK is used
2651         (say, by specifying the optional command-line argument --simulator). For now, die() with an error
2652         when the iOS device SDK is used as we don't support launching an app on the device at this time.
2653         * Scripts/webkitdirs.pm:
2654         (xcodeSDKVersion): Added.
2655         (setupIOSWebKitEnvironment): Added.
2656         (installedMobileSafariBundle): Added.
2657         (mobileSafariBundle): Added.
2658         (plistPathFromBundle): Added.
2659         (appIdentiferFromBundle): Added.
2660         (appDisplayNameFromBundle): Added.
2661         (loadIPhoneSimulatorNotificationIfNeeded): Added.
2662         (openIOSSimulator): Added.
2663         (quitIOSSimulator): Added.
2664         (iosSimulatorDeviceByName): Added.
2665         (iosSimulatorRuntime): Added.
2666         (findOrCreateSimulatorForIOSDevice): Added.
2667         (runIOSWebKitAppInSimulator): Added.
2668         (installAndLaunchIOSWebKitAppInSimulator): Added.
2669         (runIOSWebKitApp): Added.
2670         (runSafari): Modified to call runIOSWebKitAppInSimulator() the iOS simulator SDK is used. For now,
2671         die() with an error when the iOS device SDK is used as we don't support launching Safari on the
2672         device at this time.
2673
2674 2014-06-19  Anders Carlsson  <andersca@apple.com>
2675
2676         Add WTF::Optional class
2677         https://bugs.webkit.org/show_bug.cgi?id=134083
2678
2679         Reviewed by Andreas Kling.
2680
2681         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2682         * TestWebKitAPI/Tests/WTF/Optional.cpp: Added.
2683         (TestWebKitAPI::TEST):
2684
2685 2014-06-20  Ion Rosca  <rosca@adobe.com>
2686
2687         Unreviewed. Adding myself to Committers list.
2688
2689         * Scripts/webkitpy/common/config/contributors.json:
2690
2691 2014-06-20  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2692
2693         [EFL] Add gstreamer as dependecy of EFL after r169785
2694         https://bugs.webkit.org/show_bug.cgi?id=134066
2695
2696         Reviewed by Gyuyoung Kim.
2697
2698         * efl/jhbuild.modules:
2699
2700 2014-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
2701
2702         [EFL] Merge url_utils.c to MiniBrowser
2703         https://bugs.webkit.org/show_bug.cgi?id=134095
2704
2705         Reviewed by Csaba Osztrogonác.
2706
2707         url_utils.c is simple code to share between EWebLauncher and MiniBrowser.
2708         This patch removes the dependency of url_utils.c from MiniBrowser to drop WebKit1 EFL port.
2709
2710         * MiniBrowser/efl/CMakeLists.txt:
2711         Remove the EWebLauncher/ from the includes and url_utils.h from the source lists.
2712         * MiniBrowser/efl/main.c:
2713         (has_scheme): Copied from url_utils.c
2714         (url_from_user_input): Ditto.
2715
2716 2014-06-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2717
2718         Fix webkitpy tests after EFL WK1 buildbot and EWS removal - r170172.
2719
2720         Reviewed by Csaba Osztrogonác.
2721
2722         * Scripts/webkitpy/common/config/ports_unittest.py:
2723         (DeprecatedPortTest.test_gtk_wk2_port):
2724         (DeprecatedPortTest.test_efl_port): Deleted.
2725         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2726         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2727         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2728         (TestRebaselineExpectations.test_rebaseline_expectations):
2729
2730 2014-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
2731
2732         [EFL][CMAKE] Disable WebKit1 build as a default
2733         https://bugs.webkit.org/show_bug.cgi?id=134093
2734
2735         Reviewed by Gyuyoung Kim.
2736
2737         * CMakeLists.txt:
2738
2739 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2740
2741         [GTK] webkit_dom_document_create_tree_walker impossible to use due to WebKitDOMNodeFilter
2742         https://bugs.webkit.org/show_bug.cgi?id=93002
2743
2744         Reviewed by Gustavo Noronha Silva.
2745
2746         Add unit tests to check WebKitDOMNodefilter API used from both
2747         TreeWalker and NodeIterator.
2748
2749         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+
2750         public headers and add WebKitDOMNodeFilter to the list of exceptions.
2751         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
2752         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Added.
2753         (webkitNodeFilterAcceptNode):
2754         (webkitNodeFilterDOMNodeFilterIfaceInit):
2755         (webkit_node_filter_init):
2756         (webkit_node_filter_class_init):
2757         (WebKitDOMNodeFilterTest::create):
2758         (WebKitDOMNodeFilterTest::webPageFromArgs):
2759         (WebKitDOMNodeFilterTest::testTreeWalker):
2760         (WebKitDOMNodeFilterTest::testNodeIterator):
2761         (WebKitDOMNodeFilterTest::runTest):
2762         (registerTests):
2763         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Added.
2764         (runTest):
2765         (testWebKitDOMNodeFilterTreeWalker):
2766         (testWebKitDOMNodeFilterNodeIterator):
2767         (beforeAll):
2768         (afterAll):
2769         * gtk/webkitdom.py:
2770         (WebKitDOMDocGeneratorSections.__init__):
2771         (WebKitDOMDocGeneratorSections._symbol_list):
2772         (WebKitDOMDocGeneratorSections.write_section):
2773
2774 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2775
2776         [GTK] Limit the amount of API exposed to GObject DOM bindings API
2777         https://bugs.webkit.org/show_bug.cgi?id=133726
2778
2779         Reviewed by Gustavo Noronha Silva.
2780
2781         Don't make fatal finding files without a .symbols file, since now
2782         only the stable DOM API has .symbols files.
2783
2784         * gtk/webkitdom.py:
2785         (get_all_webkitdom_symbol_files):
2786
2787 2014-06-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2788
2789         Remove efl wk1 buildbot and ews
2790         https://bugs.webkit.org/show_bug.cgi?id=134089
2791
2792         Reviewed by Benjamin Poulain.
2793
2794         EFL WK1 is not supported anymore. Removed all bots for EFL WK1 bots.
2795
2796         * BuildSlaveSupport/build.webkit.org-config/config.json:
2797         * QueueStatusServer/config/queues.py:
2798         * Scripts/webkitpy/common/config/ews.json:
2799         * Scripts/webkitpy/common/config/ports.py:
2800         (DeprecatedPort.port):
2801         (QtWK2Port.run_webkit_tests_command):
2802         (EflPort): Deleted.
2803         (EflPort.build_webkit_command): Deleted.
2804         * Scripts/webkitpy/port/builders.py:
2805         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2806         * TestResultServer/static-dashboards/loader_unittests.js:
2807
2808 2014-06-19  David Kilzer  <ddkilzer@apple.com>
2809
2810         check-webkit-style does not understand Obj-C literal syntax for NSDictionary
2811         <http://webkit.org/b/134061>
2812
2813         Reviewed by Dan Bernstein.
2814
2815         * Scripts/webkitpy/style/checkers/cpp.py:
2816         (check_spacing): Ignore '@' immediately before '{'.
2817         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2818         (CppStyleTest.test_spacing_before_braces): Add unit test for
2819         '^{' block syntax and '@{' Objective-C liternal NSDitionary
2820         syntax.
2821
2822 2014-06-18  Tim Horton  <timothy_horton@apple.com>
2823
2824         All of MiniBrowser's WKWebViews should share a configuration
2825         https://bugs.webkit.org/show_bug.cgi?id=134017
2826
2827         Reviewed by Anders Carlsson.
2828
2829         * MiniBrowser/mac/WK2BrowserWindowController.m:
2830         (-[WK2BrowserWindowController awakeFromNib]):
2831         Share a single WKWebViewConfiguration between all of MiniBrowser's views.
2832         This means that they'll share things like preferences, visited links, etc.
2833         It also means that we'll properly share processes once we hit the process limit.
2834
2835 2014-06-18  Zan Dobersek  <zdobersek@igalia.com>
2836
2837         [GTK] Bump the GLib and GTK+ dependencies in jhbuild-wayland.modules
2838         https://bugs.webkit.org/show_bug.cgi?id=133971
2839
2840         Reviewed by Martin Robinson.
2841
2842         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's required for
2843         building for the Wayland target. The latest 3.12 version is required to match
2844         the xdg_shell protocol version used in Weston 1.5. GLib dependency is bumped
2845         as well due to GTK+ depending on a newer version.
2846
2847 2014-06-17  Ryuan Choi  <ryuan.choi@samsung.com>
2848
2849         [EFL] Turn on NOSNIFF in FeatureList.pm
2850         https://bugs.webkit.org/show_bug.cgi?id=134010
2851
2852         Reviewed by Csaba Osztrogonác.
2853
2854         r164848 enabled NOSNIFF feature for EFL port but missed to change FeatureList.pm.
2855
2856         * Scripts/webkitperl/FeatureList.pm: Turn on NOSNIFF for the EFL port.
2857
2858 2014-06-17  Tim Horton  <timothy_horton@apple.com>
2859
2860         MiniBrowser should show Web Content process pids in the window title
2861         https://bugs.webkit.org/show_bug.cgi?id=134016
2862
2863         Reviewed by Sam Weinig.
2864
2865         * MiniBrowser/mac/WK2BrowserWindowController.m:
2866         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2867
2868 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2869
2870         [GTK] Fix the handling of resize events after r169505.
2871         https://bugs.webkit.org/show_bug.cgi?id=133517
2872
2873         Reviewed by Martin Robinson.
2874
2875         * Scripts/webkitpy/port/xvfbdriver.py:
2876         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
2877         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
2878         need at least 900x640 pixels to pass.
2879         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2880         (XvfbDriverTest.test_start_no_pixel_tests): Update resolution.
2881         (XvfbDriverTest.test_start_pixel_tests): Update resolution.
2882         (XvfbDriverTest.test_start_arbitrary_worker_number): Update resolution.
2883         (XvfbDriverTest.test_start_next_worker): Update resolution.
2884         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2885         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
2886         be requested over the main widget instead of the window.
2887         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
2888         the Mac port.
2889         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
2890         (WTR::PlatformWebView::setWindowFrame): Set the size and position
2891         of the Window and the web view.
2892
2893 2014-06-17  Matthew Mirman <mmirman@apple.com>
2894
2895         Unreviewed. Added myself to list of contributors.
2896
2897         * Scripts/webkitpy/common/config/contributors.json: Added myself.
2898
2899 2014-06-17  Commit Queue  <commit-queue@webkit.org>
2900
2901         Unreviewed, rolling out r170058.
2902         https://bugs.webkit.org/show_bug.cgi?id=133993
2903
2904         Caused 4 webkitpy failures on the bots (Requested by bradee-oh
2905         on #webkit).
2906
2907         Reverted changeset:
2908
2909         "[GTK] Fix the handling of resize events after r169505."
2910         https://bugs.webkit.org/show_bug.cgi?id=133517
2911         http://trac.webkit.org/changeset/170058
2912
2913 2014-06-17  Rebecca Hauck  <rhauck@adobe.com>
2914
2915         Update import-w3c-tests to reflect current W3C test repo directory structure
2916         https://bugs.webkit.org/show_bug.cgi?id=133460
2917
2918         Reviewed by Bem Jones-Bey.
2919
2920         Removed all references to test status, which are no longer reflected in the
2921         directory names in the W3C CSS test repo.  No tests are required for this 
2922         change, the existing tests pass.
2923
2924         * Scripts/webkitpy/w3c/test_importer.py:
2925         (main):
2926         (TestImporter.__init__):
2927         (TestImporter.find_importable_tests):
2928         (TestImporter.setup_destination_directory):
2929         (TestImporter.write_import_log):
2930         (TestImporter.update_test_status): Deleted.
2931
2932 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2933
2934         [GTK] Fix the handling of resize events after r169505.
2935         https://bugs.webkit.org/show_bug.cgi?id=133517
2936
2937         Reviewed by Martin Robinson.
2938
2939         * Scripts/webkitpy/port/xvfbdriver.py:
2940         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
2941         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
2942         need at least 900x640 pixels to pass.
2943         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2944         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
2945         be requested over the main widget instead of the window.
2946         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
2947         the Mac port.
2948         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
2949         (WTR::PlatformWebView::setWindowFrame): Set the size and position
2950         of the Window and the web view.
2951
2952 2014-06-17  Dan Bernstein  <mitz@apple.com>
2953
2954         String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
2955         https://bugs.webkit.org/show_bug.cgi?id=133968
2956
2957         Reviewed by Anders Carlsson.
2958
2959         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2960         (TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
2961         share an impl() with the original.
2962
2963 2014-06-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2964
2965         [EFL][WK2] Skip failing EFL API tests
2966         https://bugs.webkit.org/show_bug.cgi?id=133981
2967
2968         Reviewed by Csaba Osztrogonác.
2969
2970         UserMessage, WillLoad and test_ewk2_view have been failed since r169784.
2971
2972         * TestWebKitAPI/PlatformEfl.cmake:
2973
2974 2014-06-16  Ryuan Choi  <ryuan.choi@samsung.com>
2975
2976         [EFL][WK2] Remove workaround for icon display bug in MiniBrowser
2977         https://bugs.webkit.org/show_bug.cgi?id=133962
2978
2979         Reviewed by Gyuyoung Kim.
2980
2981         Since we bumped EFL to 1.9, this workaround is unnecessary.
2982
2983         * MiniBrowser/efl/main.c:
2984         (update_view_favicon):
2985
2986 2014-06-16  Gwang Yoon Hwang  <yoon@igalia.com>
2987
2988         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2989         https://bugs.webkit.org/show_bug.cgi?id=131472
2990
2991         Reviewed by Martin Robinson.
2992
2993         This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.
2994
2995         * Scripts/webkitpy/port/xvfbdriver.py:
2996         (XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2997         when running WebKitTestRunner with the Xvfb driver.
2998         * gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
2999         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
3000         installed.
3001         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
3002         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
3003         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
3004         deal.
3005
3006 2014-06-16  Tanay C  <tanay.c@samsung.com>
3007
3008         Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
3009         https://bugs.webkit.org/show_bug.cgi?id=133792
3010
3011         Reviewed by Gyuyoung Kim.
3012
3013         * MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones
3014         (show_file_entry_dialog):
3015         (window_create):
3016
3017 2014-06-16  Mario Sanchez Prada  <mario.prada@samsung.com>
3018
3019         [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
3020         https://bugs.webkit.org/show_bug.cgi?id=133512
3021
3022         Reviewed by Chris Fleizach.
3023
3024         Added support for connecting to AtkSelection's 'selection-changed'
3025         signal, and print it out as AXSelectedChildrenChanged in the tests.
3026
3027         Also removed some dead code, that became useless after r169487.
3028
3029         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3030         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.
3031
3032 2014-06-15  Ryuan Choi  <ryuan.choi@samsung.com>
3033
3034         [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
3035         https://bugs.webkit.org/show_bug.cgi?id=133841
3036
3037         Reviewed by Gyuyoung Kim.
3038
3039         * MiniBrowser/efl/main.c:
3040         (window_create):
3041
3042 2014-06-15  Dan Bernstein  <mitz@apple.com>
3043
3044         Set the svn:ignore property on an Xcode project to ignore user and workspace data.
3045
3046         * jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
3047
3048 2014-06-15  Anders Carlsson  <andersca@apple.com>
3049
3050         Fix build.
3051
3052         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3053         (callRunJavaScriptBlockAndRelease):
3054         (runJavaScriptInMainFrame):
3055         (TEST_F):
3056
3057 2014-06-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3058
3059         Create MSE and EME watchlist
3060         https://bugs.webkit.org/show_bug.cgi?id=133810
3061
3062         Reviewed by Eric Carlson.
3063
3064         * Scripts/webkitpy/common/config/watchlist: Create MSEEME
3065         definition and add Eric Carlson and myself to it.
3066
3067 2014-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3068
3069         [GTK] Remove all deprecated API from GObject DOM bindings
3070         https://bugs.webkit.org/show_bug.cgi?id=133728
3071
3072         Reviewed by Martin Robinson.
3073
3074         * gtk/webkitdom.py:
3075         (WebKitDOMDocGenerator): Remove all deleted classes from the list.
3076         (WebKitDOMDocGeneratorSections.__init__): Fix a typo in member initialization.
3077
3078 2014-06-12  Simon Fraser  <simon.fraser@apple.com>
3079
3080         [iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
3081         https://bugs.webkit.org/show_bug.cgi?id=133835
3082
3083         Reviewed by Tim Horton.
3084         
3085         Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
3086
3087         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3088         (-[WebKitTestRunnerWindow initWithFrame:]):
3089         (-[WebKitTestRunnerWindow setFrame:]):
3090
3091 2014-06-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3092
3093         [GTK] Performance tests should be always ran with WKTR.
3094         https://bugs.webkit.org/show_bug.cgi?id=133780
3095
3096         Reviewed by Ryosuke Niwa.
3097
3098         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3099         (PerfTestsRunner.__init__): Enable webkit_test_runner when port
3100         is GTK.
3101
3102 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
3103
3104         [GTK] REGRESSION: application name is not correctly appended to the UA
3105         https://bugs.webkit.org/show_bug.cgi?id=133793
3106
3107         Reviewed by Carlos Garcia Campos.
3108
3109         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3110         (testWebKitSettingsUserAgent):
3111
3112 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
3113
3114         [GTK] Unsupported browser in www.icloud.com
3115         https://bugs.webkit.org/show_bug.cgi?id=133403
3116
3117         Reviewed by Martin Robinson.
3118
3119         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
3120         (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
3121         quirk that was removed.
3122
3123 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
3124
3125         [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
3126         https://bugs.webkit.org/show_bug.cgi?id=133779
3127
3128         Reviewed by Benjamin Poulain.
3129         
3130         Tell the WebPage to use the testing viewport configuration from the injected bundle.
3131
3132         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3133         (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
3134         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3135         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
3136         on iOS.
3137
3138 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
3139
3140         WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
3141         https://bugs.webkit.org/show_bug.cgi?id=133770
3142
3143         Reviewed by Anders Carlsson.
3144         
3145         Push the per-test view configuration up to TestController, so that platforms
3146         can modify the behavior. This also allows platform-specific changes (e.g.
3147         for threaded scrolling) to made without #ifefs.
3148
3149         * WebKitTestRunner/TestController.cpp:
3150         (WTR::TestController::updateWebViewSizeForTest):
3151         (WTR::TestController::updateWindowScaleForTest):
3152         (WTR::shouldUseFixedLayout):
3153         (WTR::TestController::updateLayoutTypeForTest):
3154         (WTR::TestController::platformConfigureViewForTest):
3155         (WTR::TestController::configureViewForTest):
3156         * WebKitTestRunner/TestController.h:
3157         * WebKitTestRunner/TestInvocation.cpp:
3158         (WTR::TestInvocation::invoke):
3159         (WTR::sizeWebViewForCurrentTest): Deleted.
3160         (WTR::changeWindowScaleIfNeeded): Deleted.
3161         (WTR::shouldUseThreadedScrolling): Deleted.
3162         (WTR::updateThreadedScrollingForCurrentTest): Deleted.
3163         (WTR::shouldUseFixedLayout): Deleted.
3164         (WTR::updateLayoutType): Deleted.
3165         * WebKitTestRunner/TestInvocation.h:
3166         (WTR::TestInvocation::pathOrURL):
3167         * WebKitTestRunner/ios/TestControllerIOS.mm:
3168         (WTR::shouldMakeViewportFlexible):
3169         (WTR::TestController::platformConfigureViewForTest):
3170         * WebKitTestRunner/mac/TestControllerMac.mm:
3171         (WTR::shouldUseThreadedScrolling):
3172         (WTR::TestController::platformConfigureViewForTest):
3173
3174 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3175
3176         [EFL] Add dependencies packages to efl install-dependencies file
3177         https://bugs.webkit.org/show_bug.cgi?id=133720
3178
3179         Reviewed by Csaba Osztrogonác.
3180
3181         After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
3182         install doxygen and libssl-dev because efl 1.9 depends on those libraries.
3183
3184         * efl/install-dependencies:
3185
3186 2014-06-11  Zoltan Horvath  <zoltan@webkit.org>
3187
3188         Unreviewed. Moving myself to the list of reviewers.
3189
3190         * Scripts/webkitpy/common/config/contributors.json:
3191
3192 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3193
3194         [EFL] Drop to maintain EFL 32bit release bot
3195         https://bugs.webkit.org/show_bug.cgi?id=133710
3196
3197         Reviewed by Csaba Osztrogonác.
3198
3199         * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
3200
3201 2014-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3202
3203         [GTK] Use a different user agent string depending on the site
3204         https://bugs.webkit.org/show_bug.cgi?id=132681
3205
3206         Reviewed by Anders Carlsson.
3207
3208         Add a unit test to check user agent quirks.
3209
3210         * TestWebKitAPI/PlatformGTK.cmake:
3211         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
3212         (TestWebKitAPI::TEST):
3213         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3214         (testWebKitSettings): Site specific quirks setting is now enabled
3215         by default.
3216
3217 2014-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3218
3219         Unreviewed, update my list of email addresses in contributors.json.
3220
3221         * Scripts/webkitpy/common/config/contributors.json:
3222
3223 2014-06-10  Simon Fraser  <simon.fraser@apple.com>
3224
3225         Always switch to an sRGB screen color profile when running tests
3226         https://bugs.webkit.org/show_bug.cgi?id=133712
3227
3228         Reviewed by Tim Horton.
3229         
3230         Switch the screen color profile to sRGB when running tests, because even ref
3231         tests need the screen to use the correct color profile.
3232
3233         * DumpRenderTree/mac/LayoutTestHelper.m:
3234         (installLayoutTestColorProfile):
3235         * Scripts/webkitpy/port/mac.py:
3236         (MacPort.start_helper):
3237
3238 2014-06-10  Martin Hodovan  <mhodovan@partner.samsung.com>
3239
3240         [EFL] Bump EFL libraries to 1.9
3241         https://bugs.webkit.org/show_bug.cgi?id=125479
3242
3243         Reviewed by Gyuyoung Kim.
3244
3245         Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
3246         and László Langó <llango.u-szeged@partner.samsung.com>.
3247
3248         * ImageDiff/CMakeLists.txt:
3249         * MiniBrowser/efl/CMakeLists.txt:
3250         * efl/install-dependencies:
3251         * efl/jhbuild.modules:
3252         * efl/jhbuildrc:
3253
3254 2014-06-10  David Farler  <dfarler@apple.com>
3255
3256         old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
3257         https://bugs.webkit.org/show_bug.cgi?id=133663
3258
3259         Reviewed by David Kilzer.
3260
3261         * Scripts/old-run-webkit-tests:
3262         (installAndLaunchDumpToolAppUsingNotification):
3263         - Remove obsolete notification keys
3264         - Key off of mandatory device UDID (a UUID)
3265         - Create a device on demand via CoreSimulator if necessary
3266         -- Grab the UDID from the created device plist.
3267         * Scripts/webkitdirs.pm:
3268         (iOSSimulatorDevicesPath): Added
3269         (iOSSimulatorDevices): Added
3270         (createiOSSimulatorDevice): Added
3271         (deleteiOSSimulatorDevice): Added
3272
3273 2014-06-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3274
3275         [GTK][gtkdoc] remove -Wcast-align
3276         https://bugs.webkit.org/show_bug.cgi?id=133640
3277
3278         Apparently gcc warns that GParamSpec is not castable to
3279         GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
3280         though ARM hackers claim that those only need 4byte alignment. As long as gcc
3281         behaves that way, this warning is not very useful, also they break the Debian
3282         packaging.
3283
3284         This patch appends the compiler flag -Wno-align-cast for the gtkdoc
3285         scanner compilation, thus the compiler ignores the previous
3286         -Waling-cast flag.
3287
3288         Reviewed by Martin Robinson.
3289
3290         * gtk/generate-gtkdoc:
3291         (get_generator_for_config):
3292
3293 2014-06-09  Alexey Proskuryakov  <ap@apple.com>
3294
3295         Disable button animations in regression tests
3296         https://bugs.webkit.org/show_bug.cgi?id=133647
3297         <rdar://problem/16677530>
3298
3299         Reviewed by Tim Horton.
3300
3301         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3302         (WTR::InjectedBundle::platformInitialize):
3303
3304 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
3305
3306         Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
3307         https://bugs.webkit.org/show_bug.cgi?id=133650
3308
3309         Reviewed by Tim Horton.
3310         
3311         No point checking for a Windows-style path in Cocoa code.
3312
3313         * WebKitTestRunner/TestInvocation.cpp:
3314         (WTR::shouldUseThreadedScrolling):
3315
3316 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
3317
3318         Fix more latched scrolling test flakiness and slowness
3319         https://bugs.webkit.org/show_bug.cgi?id=133601
3320
3321         Reviewed by Brent Fulgham.
3322         
3323         Latched scrolling tests were flakey for two reasons. First, the EventSender
3324         wheel events were async from the web to the UI process, and the resulting
3325         synthetic events also async from the UI to the web process. Make them sync
3326         for testing.
3327         
3328         Secondly, the timer-based scrolling tree commit could result in the scrolling
3329         tree (specifically the frame node's notion of the scrollable area and content
3330         size) not being updated before the scrolling thread starts getting wheel events.
3331         Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
3332         
3333         Finally remove all the now-unnecessary timeouts from the tests.
3334
3335         * WebKitTestRunner/mac/EventSenderProxy.mm:
3336         (WTR::EventSenderProxy::mouseMoveTo):
3337         (WTR::EventSenderProxy::mouseScrollBy):
3338         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3339
3340 2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
3341
3342         [EFL] Add parameter to MiniBrowser to disable web security
3343         https://bugs.webkit.org/show_bug.cgi?id=121095
3344
3345         Reviewed by Gyuyoung Kim.
3346
3347         -w (--web-security) commandline allows to disable/enable web security (enabled by default).
3348         The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
3349         resources from other domains (cross-domain requests) such as access map location on another server.
3350         Another possibility is to launch in a webkit browser local file tests that will refer to the links
3351         in the http website loaded in an iframe. It will not be possible without deactivation of web security.
3352
3353         * MiniBrowser/efl/main.c:
3354         (window_create):
3355         (elm_main):
3356
3357 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
3358
3359         32-bit build fix.
3360
3361         * WebKitTestRunner/mac/EventSenderProxy.mm:
3362         (WTR::EventSenderProxy::mouseMoveTo):
3363         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3364
3365 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
3366
3367         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
3368
3369         * DumpRenderTree/mac/DumpRenderTree.mm:
3370         (createWebViewAndOffscreenWindow):
3371         * DumpRenderTree/mac/EventSendingController.mm:
3372         (-[EventSendingController mouseScrollByX:andY:continuously:]):
3373         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
3374         * WebKitTestRunner/mac/EventSenderProxy.mm:
3375         (WTR::EventSenderProxy::mouseScrollBy):
3376         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3377
3378 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
3379
3380         Latched scrolling tests are flakey on Mavericks
3381         https://bugs.webkit.org/show_bug.cgi?id=133578
3382         <rdar://problem/17180591>
3383
3384         Reviewed by Brent Fulgham.
3385         
3386         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
3387         be wrong on machines with more than one screen. This is because we use
3388         [NSScreen mainScreen] when computing the global coordinates of the events, but
3389         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
3390         
3391         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
3392         add comments clarifying why the coordinate math works (which is not obvious given
3393         the events have no target window).
3394         
3395         Some scrolling tests also dispatched events outside the 800x600 test window, so
3396         fix those tests, and add logging that will appear in test output when this happens.
3397
3398         * DumpRenderTree/mac/DumpRenderTree.mm:
3399         (createWebViewAndOffscreenWindow):
3400         * DumpRenderTree/mac/EventSendingController.mm:
3401         (-[EventSendingController mouseScrollByX:andY:continuously:]):
3402         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
3403         * WebKitTestRunner/mac/EventSenderProxy.mm:
3404         (WTR::EventSenderProxy::mouseMoveTo):
3405         (WTR::EventSenderProxy::mouseScrollBy):
3406         (WTR::EventSenderProxy::continuousMouseScrollBy):
3407         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3408
3409 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3410
3411         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
3412         https://bugs.webkit.org/show_bug.cgi?id=133533
3413
3414         Reviewed by Carlos Garcia Campos.
3415
3416         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
3417         (run): Remove the jhbuild-wrapper wrapper from here. It should be
3418         on Scripts/webkitpy/port/gtk.py.
3419         * Scripts/webkitpy/port/base.py:
3420         (Port.set_option): Add a set_option(name, value) function to set
3421         the optparse parameter "name" to the value "value", even if the
3422         parameter "name" is already initialized.
3423         * Scripts/webkitpy/port/gtk.py:
3424         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
3425         If another wrapper is specified via the option "-l --wrapper=x",
3426         then prepend the jhbuild-wrapper to the one specified.
3427
3428 2014-06-04  David Farler  <dfarler@apple.com>
3429
3430         Build ASan WebKit for iOS Simulator
3431         https://bugs.webkit.org/show_bug.cgi?id=133489
3432
3433         Reviewed by Darin Adler.
3434
3435         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3436         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3437         - Add missing ASan LDFLAGS.
3438         * asan/asan.xcconfig:
3439         - Split compiler-rt linker flags for OS X and iOS Simulator
3440
3441 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
3442
3443         Add myself (yoav@yoav.ws) to contributors.json
3444         https://bugs.webkit.org/show_bug.cgi?id=133492
3445
3446         * Scripts/webkitpy/common/config/contributors.json:
3447
3448 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3449
3450         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
3451         https://bugs.webkit.org/show_bug.cgi?id=133149
3452
3453         Reviewed by Csaba Osztrogonác.
3454
3455         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
3456
3457 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3458
3459         Add a verbose flag to binding tests
3460         https://bugs.webkit.org/show_bug.cgi?id=122303
3461
3462         Reviewed by Csaba Osztrogonác.
3463
3464         This patch will:
3465         - Add a verbose keyword argument to the BindingsTests constructor,
3466         - Add --no-verbose option to the run-bindigs-test.
3467         Verbose mode, which is on by default, prints positive results to stdout as before.
3468         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
3469
3470         Original patch from Matthew Hanson <matthew_hanson@apple.com>
3471
3472         * Scripts/run-bindings-tests:
3473         (main):
3474         * Scripts/webkitpy/bindings/main.py:
3475         (BindingsTests.__init__):
3476         (BindingsTests.detect_changes):
3477
3478 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
3479
3480         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
3481         https://bugs.webkit.org/show_bug.cgi?id=133455
3482
3483         Reviewed by Timothy Hatcher.
3484
3485         Since the perf. dashboard doesn't support following renamed benchmarks,
3486         keep reporting Speedometer results as DoYouEvenBench results.
3487
3488         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3489         (_generate_results_dict):
3490
3491 2014-05-31  Darin Adler  <darin@apple.com>
3492
3493         Viewport percentage tests that resize the viewport are flaky
3494         https://bugs.webkit.org/show_bug.cgi?id=133351
3495
3496         Reviewed by Anders Carlsson.
3497
3498         * DumpRenderTree/mac/DumpRenderTree.mm:
3499         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
3500         happens to be stored in the UI delegate object. This is part of resetting the
3501         window position.
3502
3503         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
3504         a frame rectangle. The size is stored in the size of the web view itself.
3505         * DumpRenderTree/mac/UIDelegate.mm:
3506         (-[UIDelegate resetWindowOrigin]): Added.
3507         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
3508         old version would store the frame, but not resize the web view!
3509         (-[UIDelegate webViewFrame:]): Get the size from the web view.
3510
3511         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3512         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
3513
3514         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3515         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
3516         the window.
3517
3518         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3519         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
3520         window gets resized too, not just the web view.
3521         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
3522
3523         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3524         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
3525         window gets resized too, not just the web view.
3526         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
3527
3528 2014-05-30  Michael Saboff  <msaboff@apple.com>
3529
3530         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
3531         https://bugs.webkit.org/show_bug.cgi?id=133409
3532
3533         Reviewed by Filip Pizlo.
3534
3535         Handle creating a tarball the same way as running remote when processing
3536         paths in prepareBundle.
3537
3538         * Scripts/run-jsc-stress-tests:
3539
3540 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
3541
3542         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
3543         https://bugs.webkit.org/show_bug.cgi?id=132280
3544
3545         Reviewed by Chris Fleizach.
3546
3547         Remove implementation of logAccessibilityEvents() for ATK based
3548         ports, as this has proved to be a flaky method of checking that
3549         ATK events are being properly emitted. Instead, it's better to use
3550         the addNotificationListener() functions and provide a JS callback
3551         to check that the right events are being emmitted from the tests.
3552
3553         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3554         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
3555         with dummy implementation.
3556         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3557         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
3558
3559 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
3560
3561         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
3562         https://bugs.webkit.org/show_bug.cgi?id=132280
3563
3564         Rubber stamped by Carlos Garcia Campos.
3565
3566         Fix two small issues with previous patch (r169483), that caused some tests to break.
3567
3568         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3569         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
3570         duplicated entry.
3571         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3572         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
3573
3574 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
3575
3576         [ATK] Added new accessibility signal: text-caret-moved.
3577         Make AccessibilityUIElement.setSelectedTextRange work
3578         as atk_text_set_caret_offset when given offset == 0.
3579         https://bugs.webkit.org/show_bug.cgi?id=132527
3580
3581         Reviewed by Mario Sanchez Prada.
3582
3583         text-caret-moved signal in accessibilityController is needed to
3584         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
3585         as LayoutTests. Add the signal to the controller.
3586
3587         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3588         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3589         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3590         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3591         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3592         (setSelectedTextRange): Change return type to bool.
3593         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3594         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
3595         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3596         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
3597         for extra arguments passed to handler and use it for text-caret-moved offset.
3598         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3599         Connect callback to new listener for ATK:AtkText:text-caret-moved.
3600         Refactor so that failures be reported.
3601         Initialize atk interfaces before trying to connect to them, see
3602         https://bugzilla.gnome.org/show_bug.cgi?id=729922
3603         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
3604         Simplify code by using a vector in place of dozen variables.
3605         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3606         Comment about not synchronizing with accessibilityController.
3607
3608 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3609
3610         [GTK] Add a WebKit2 Performance bot.
3611         https://bugs.webkit.org/show_bug.cgi?id=132862
3612
3613         Reviewed by Csaba Osztrogonác.
3614
3615         This adds a GTK WebKit2 perf bot.
3616
3617         * BuildSlaveSupport/build.webkit.org-config/config.json:
3618
3619 2014-05-29  Dan Bernstein  <mitz@apple.com>
3620
3621         Fixed the WebKitTestRunner build after r169452.
3622
3623         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3624         (WTR::InjectedBundle::initialize):
3625
3626 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
3627
3628         Unreviewed. Update my email addresses in contributors.json.
3629
3630         * Scripts/webkitpy/common/config/contributors.json:
3631
3632 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
3633
3634         Need an API test for bug #133193 (r169315)
3635         <https://bugs.webkit.org/show_bug.cgi?id=133324>
3636
3637         This adds an API test that ensures that calling "stop loading" during a
3638         "did fail provisional load" callback doesn't crash.
3639
3640         Reviewed by Andy Estes.
3641
3642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3643         Add new files to project.
3644
3645         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
3646         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3647         If the message is the "test done" message, record that.
3648         (TestWebKitAPI::setInjectedBundleClient):
3649         Register a function for the "did receive message from injected bundle"
3650         callback.
3651         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
3652         Assert that we received the message from the injected bundle, and set
3653         'done' to finish the test.
3654         (TestWebKitAPI::TEST):
3655         Create a WebView, register a page loader client for the "did fail
3656         provisional load" callback, and load a non-existent resource.
3657
3658         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
3659         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
3660         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
3661         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
3662         provisional load failed.
3663         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
3664         Register a page loader client for the "did fail provisional load"