d9f80cd351195c9c834358d90135876ba801ddc9
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
2
3         Move Debug Test262, Release Test262 and Performance queues to Sierra
4         https://bugs.webkit.org/show_bug.cgi?id=181692
5
6         Unreviewed
7
8 2018-01-16  Zach Li  <zachli@apple.com>
9
10         Add pop-up policy support in website policies.
11         https://bugs.webkit.org/show_bug.cgi?id=181544.
12         rdar://problem/30521400.
13
14         Reviewed by Alex Christensen.
15
16         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17         Added pop-up-check.html.
18
19         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
20
21         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
22         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
23         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
24         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
25         (TEST):
26
27 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
28
29         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
30         https://bugs.webkit.org/show_bug.cgi?id=181638
31         <rdar://problem/36508702>
32
33         Reviewed by Dan Bernstein.
34
35         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
36         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
37
38         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
39         (-[AttachmentUpdateObserver init]):
40         (-[AttachmentUpdateObserver sourceForIdentifier:]):
41         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
42         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
43         (TestWebKitAPI::TEST):
44         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
45
46 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
47
48         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
49
50         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
51
52         * glib/api_test_runner.py:
53         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
54         * glib/glib_test_runner.py:
55         (GLibTestRunner.run): Use given env.
56
57 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
58
59         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
60         https://bugs.webkit.org/show_bug.cgi?id=181676
61
62         Reviewed by Carlos Alberto Lopez Perez.
63
64         The option was removed in r226967.
65
66         * BuildSlaveSupport/build.webkit.org-config/steps.py:
67         (RunGtkAPITests):
68         (RunWPEAPITests):
69
70 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
71
72         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
73
74         The bots are still passing that option and the step is failing because it was removed in r226967.
75
76         * glib/api_test_runner.py:
77         (add_options):
78
79 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
80
81         [GTK][WPE] Improve the way glib tests are run
82         https://bugs.webkit.org/show_bug.cgi?id=181674
83
84         Reviewed by Žan Doberšek.
85
86         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
87         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
88         tests failing due to an expected assert in the test and unexpected crashes.
89         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
90         not showing the subtest name in stdout in case of timeouts.
91         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
92         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
93         of every test case.
94
95         * glib/api_test_runner.py:
96         (TestRunner._run_test_glib): Use GLibTestRunner.
97         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
98         (add_options):
99         * glib/glib_test_runner.py: Added.
100         (TestTimeout):
101         (Message):
102         (Message.__init__):
103         (Message.create):
104         (Message.create.read_unsigned):
105         (Message.create.read_double):
106         (Message.create.read_string):
107         (GLibTestRunner):
108         (GLibTestRunner.__init__):
109         (GLibTestRunner._process_data):
110         (GLibTestRunner._process_message):
111         (GLibTestRunner._read_from_pipe):
112         (GLibTestRunner._read_from_stderr):
113         (GLibTestRunner._start_timeout):
114         (GLibTestRunner._start_timeout._alarm_handler):
115         (GLibTestRunner._stop_timeout):
116         (GLibTestRunner._subtest_start):
117         (GLibTestRunner._subtest_message):
118         (GLibTestRunner._subtest_stderr):
119         (GLibTestRunner._subtest_end):
120         (GLibTestRunner.run):
121
122 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
123
124         Unreviewed, add Thibault to contributors.json
125
126         It's a bit weird to add someone here before their first contribution, but this affects
127         Bugzilla autocomplete, and that is serious business.
128
129         * Scripts/webkitpy/common/config/contributors.json:
130
131 2018-01-15  JF Bastien  <jfbastien@apple.com>
132
133         Remove makePoisonedUnique
134         https://bugs.webkit.org/show_bug.cgi?id=181630
135         <rdar://problem/36498623>
136
137         Reviewed by Mark Lam.
138
139         Update tests.
140
141         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
142         (TestWebKitAPI::TEST):
143         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
144         (TestWebKitAPI::TEST):
145
146 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
147
148         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
149         https://bugs.webkit.org/show_bug.cgi?id=181476
150
151         Reviewed by Michael Catanzaro.
152
153         Update to xorg-server 1.19.6 which depends on libxfont2, and change
154         the lists of packages to install libxfont2-devel (or equivalent).
155
156         * gtk/install-dependencies:
157         * gtk/jhbuild.modules:
158
159 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
160
161         [GTK][WPE] Add support for unit test expectations
162         https://bugs.webkit.org/show_bug.cgi?id=181589
163
164         Reviewed by Michael Catanzaro.
165
166         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
167         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
168         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
169         script itself is not a good idea either.
170
171         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
172         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
173         convenient methods to query them.
174
175         * Scripts/run-gtk-tests:
176         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
177         * Scripts/run-wpe-tests:
178         (WPETestRunner): Ditto.
179         * Scripts/webkitpy/common/test_expectations.py: Added.
180         (TestExpectations):
181         (TestExpectations.__init__):
182         (TestExpectations._port_name_for_expected):
183         (TestExpectations._expected_value):
184         (TestExpectations.skipped_tests):
185         (TestExpectations.skipped_subtests):
186         (TestExpectations._expectation_value):
187         (TestExpectations.is_slow):
188         (TestExpectations.get_expectation):
189         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
190         (MockTestExpectations):
191         (MockTestExpectations.__init__):
192         (MockTestExpectations.is_skip):
193         (ExpectationsTest):
194         (assert_exp):
195         (assert_not_exp):
196         (assert_bad_exp):
197         (assert_skip):
198         (test_basic):
199         (test_skip):
200         (test_flaky):
201         (test_build_type):
202         * TestWebKitAPI/glib/TestExpectations.json: Added.
203         * glib/api_test_runner.py:
204         (TestRunner): Remove SkippedTest implementation.
205         (TestRunner.__init__): Create a TestExpectations.
206         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
207         (TestRunner._should_run_test_program): Ditto.
208         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
209         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
210         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
211         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
212         (TestRunner.run_tests.report): Helper to write report to stdout.
213
214 2018-01-13  Mark Lam  <mark.lam@apple.com>
215
216         Replace all use of ConstExprPoisoned with Poisoned.
217         https://bugs.webkit.org/show_bug.cgi?id=181542
218         <rdar://problem/36442138>
219
220         Reviewed by JF Bastien.
221
222         1. Converted tests to using new uintptr_t& poison type.
223         2. Added tests for Poisoned comparison operators.
224
225         * TestWebKitAPI/CMakeLists.txt:
226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
227         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
228         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
229         (TestWebKitAPI::TEST):
230         (TestWebKitAPI::initializeTestPoison): Deleted.
231         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
232         (TestWebKitAPI::TEST):
233         (TestWebKitAPI::passWithRef):
234         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
235         (TestWebKitAPI::TEST):
236         (TestWebKitAPI::f1):
237         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
238         (TestWebKitAPI::TEST):
239         (TestWebKitAPI::poisonedPtrFoo):
240         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
241         (TestWebKitAPI::TEST):
242         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
243         (TestWebKitAPI::TEST):
244
245 2018-01-13  David Kilzer  <ddkilzer@apple.com>
246
247         check-webkit-style: false positive for [whitespace/braces] with os_log format string
248         <https://webkit.org/b/181606>
249
250         Reviewed by Darin Adler.
251
252         * Scripts/webkitpy/style/checkers/cpp.py:
253         (check_spacing): Modify regular expression to ignore
254         os_log format strings like '%{public}'.
255         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
256         (CppStyleTest.test_spacing_before_braces): Add os_log
257         format string test.
258
259 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
260
261         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
262         https://bugs.webkit.org/show_bug.cgi?id=181626
263
264         Reviewed by Joseph Pecoraro.
265
266         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
267         Additionally, write a new API test covering the change in r226915.
268
269         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
270         (webViewForTestingAttachments):
271         (TestWebKitAPI::TEST):
272
273 2018-01-12  Alex Christensen  <achristensen@webkit.org>
274
275         History state should be updated during client redirects with asynchronous policy decisions
276         https://bugs.webkit.org/show_bug.cgi?id=181358
277         <rdar://problem/35547689>
278
279         Reviewed by Andy Estes.
280
281         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
282         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
283         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
284         (TEST):
285
286 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
287
288         webkitpy: Refactor simulator code (Part 4)
289         https://bugs.webkit.org/show_bug.cgi?id=180555
290         <rdar://problem/36131381>
291
292         Reviewed by Aakash Jain.
293
294         Move new_simulated_device.py to simulated_device.py.
295
296         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
297         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
298         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
299         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
300         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
301
302 2018-01-12  Alex Christensen  <achristensen@webkit.org>
303
304         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
305         https://bugs.webkit.org/show_bug.cgi?id=181595
306
307         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
308         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
309         I change the < and > to $ to make this test pass and continue to test what it used to.
310
311         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
312         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
313         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
314
315 2018-01-11  Keith Miller  <keith_miller@apple.com>
316
317         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
318         https://bugs.webkit.org/show_bug.cgi?id=181573
319
320         Reviewed by Simon Fraser.
321
322         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
323
324 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
325
326         [WebAuthN] Import a CBOR coder from Chromium
327         https://bugs.webkit.org/show_bug.cgi?id=181522
328         <rdar://problem/36055729>
329
330         Reviewed by Brent Fulgham.
331
332         This patch also imports all unit tests into our API tests to ensure all
333         workarounds and modification against the original codebase doesn't change
334         any original functionalities.
335
336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
337         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
338         (TestWebKitAPI::TEST):
339         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
340         (TestWebKitAPI::TEST):
341         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
342         (TestWebKitAPI::eq):
343         Workarounds applied.
344         (TestWebKitAPI::TEST):
345
346 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
347
348         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
349         https://bugs.webkit.org/show_bug.cgi?id=181538
350         <rdar://problem/36440580>
351
352         Reviewed by Aakash Jain.
353
354         When disambiguating a device type, it is possible that the provided device type is sufficiently
355         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
356         will result in a failure to disambiguate the type.
357
358         * Scripts/webkitpy/xcode/new_simulated_device.py:
359         (SimulatedDeviceManager._disambiguate_device_type):
360
361 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
362
363         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
364         https://bugs.webkit.org/show_bug.cgi?id=181136
365         <rdar://problem/36116604>
366
367         Reviewed by Chris Dumez.
368
369         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
370         browsing sessions.
371
372         * Scripts/run-gtk-tests:
373         (GtkTestRunner): Unskip test now that it passes.
374         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
375         (TEST): Add new WebsiteDataStoreEphemeral test.
376
377 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
378
379         Unreviewed, rolling out r226816.
380
381         This change broke LayoutTests on the bots.
382
383         Reverted changeset:
384
385         "run-webkit-tests fails when there is a curly brace in Xcode
386         build output"
387         https://bugs.webkit.org/show_bug.cgi?id=181254
388         https://trac.webkit.org/changeset/226816
389
390 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
391
392         webkitpy: Fix flakey webserver tests
393         https://bugs.webkit.org/show_bug.cgi?id=181555
394         <rdar://problem/36448273>
395
396         Reviewed by Aakash Jain.
397
398         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
399         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
400         determine if a specific server is running.
401
402 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
403
404         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
405         https://bugs.webkit.org/show_bug.cgi?id=181561
406         <rdar://problem/36452652>
407
408         Reviewed by Aakash Jain.
409
410         BeautifulSoup.find may return None, this case should be gracefully handled.
411
412         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
413         (BugzillaQueries._parse_result_count):
414         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
415
416 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
417
418         run-webkit-tests fails when there is a curly brace in Xcode build output
419         https://bugs.webkit.org/show_bug.cgi?id=181254
420
421         Reviewed by Daniel Bates.
422
423         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
424         (MeteredStream.write):
425
426 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
427
428         webkitpy: Reimplement simulator code (Part 3)
429         https://bugs.webkit.org/show_bug.cgi?id=180555
430         <rdar://problem/36131381>
431
432         Reviewed by Aakash Jain.
433
434         Remove old simulator code.
435
436         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
437         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
438         * Scripts/webkitpy/xcode/simulator.py: Removed.
439         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
440
441 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
442
443         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
444         https://bugs.webkit.org/show_bug.cgi?id=181337
445         <rdar://problem/36324813>
446
447         Reviewed by Tim Horton.
448
449         Add 3 new API tests for attachment element dragging.
450
451         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
452         (-[TestWKWebView expectElementTag:toComeBefore:]):
453         (-[NSItemProvider expectType:withData:]):
454         (TestWebKitAPI::TEST):
455
456 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
457
458         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
459         https://bugs.webkit.org/show_bug.cgi?id=179621
460         <rdar://problem/35589585>
461
462         Unreviewed infrastructure fix.
463
464         * Scripts/webkitpy/port/mac.py:
465         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
466         list if we are the VERSION_MAX, which usually corresponds with future.
467
468 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
469
470         CodeBlocks should be in IsoSubspaces
471         https://bugs.webkit.org/show_bug.cgi?id=180884
472
473         Reviewed by Saam Barati.
474         
475         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
476         shouldn't take a long time due to benchmarks we don't optimize for.
477         
478         * Scripts/run-jsc-benchmarks:
479
480 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
481
482         Test gardening for GTK.
483         https://bugs.webkit.org/show_bug.cgi?id=181477
484
485         Unreviewed test gardening.
486
487         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
488         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
489
490 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
491
492         Add the new JSCOnly bot to the scheduler.
493         https://bugs.webkit.org/show_bug.cgi?id=181487
494
495         Unreviewed follow-up patch after r226729
496
497         On r226729 I missed to add the new JSCOnly bot the default scheduler.
498         This is needed to make the bot automatically pick each commit for testing.
499
500         * BuildSlaveSupport/build.webkit.org-config/config.json:
501
502 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
503
504         [Attachment Support] Support dragging attachment elements out as files on iOS
505         https://bugs.webkit.org/show_bug.cgi?id=181199
506         <rdar://problem/36299316>
507
508         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
509
510         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
511         attachment API tests.
512
513         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
514         (-[NSItemProvider expectType:withData:]):
515         (TestWebKitAPI::TEST):
516
517         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
518         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
519         -expectType:withData: helper to inspect the item providers created from the drag source.
520
521         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
522         (TestWebKitAPI::TEST):
523         * TestWebKitAPI/ios/DataInteractionSimulator.h:
524         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
525         (-[MockDragSession localContext]):
526         (-[MockDragSession setLocalContext:]):
527         (-[DataInteractionSimulator _resetSimulatedState]):
528         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
529         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
530         (-[DataInteractionSimulator _advanceProgress]):
531         (-[DataInteractionSimulator endDataTransfer]):
532
533         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
534         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
535         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
536         MockDragSession to hold on to a localContext.
537
538 2018-01-11  Ali Juma  <ajuma@chromium.org>
539
540         Unreviewed. Add Ali Juma as contributor
541
542         * Scripts/webkitpy/common/config/contributors.json:
543
544 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
545
546         Unreviewed. Update Selenium WebDriver imported tests.
547
548         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
549         environment variables.
550
551         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
552         (collect): Reorder the arguments to make pytest happy.
553         (run): Ditto.
554         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
555         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
556
557 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
558
559         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
560         https://bugs.webkit.org/show_bug.cgi?id=181492
561         <rdar://problem/36359679>
562
563         Reviewed by Alexey Proskuryakov. 
564
565 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
566
567         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
568         https://bugs.webkit.org/show_bug.cgi?id=181475
569
570         Reviewed by Michael Catanzaro.
571
572         * gtk/install-dependencies: Update package list for Arch Linux, extend
573         message shown at end of installation with additional tips.
574
575 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
576
577         REGRESSION(r222507): Composition highlight doesn't render when using IME
578         https://bugs.webkit.org/show_bug.cgi?id=181485
579         <rdar://problem/35896516>
580
581         Reviewed by Ryosuke Niwa.
582
583         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
584         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
585         allow rendering composition backgrounds (see InlineTextBox::paint).
586
587         * DumpRenderTree/ios/TextInputControllerIOS.m:
588         (+[TextInputController isSelectorExcludedFromWebScript:]):
589         (+[TextInputController webScriptNameForSelector:]):
590         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
591         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
592         * DumpRenderTree/mac/TextInputControllerMac.m:
593         (+[TextInputController isSelectorExcludedFromWebScript:]):
594         (+[TextInputController webScriptNameForSelector:]):
595         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
596         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
597         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
598         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
599         (WTR::TextInputController::setMarkedText):
600         * WebKitTestRunner/InjectedBundle/TextInputController.h:
601
602 2018-01-10  JF Bastien  <jfbastien@apple.com>
603
604         Poison small JSObject derivatives which only contain pointers
605         https://bugs.webkit.org/show_bug.cgi?id=181483
606         <rdar://problem/36407127>
607
608         Reviewed by Mark Lam.
609
610         Test the new move-assign and move-copy from unique_ptr, as well as
611         nullptr_t ctors.
612
613         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
614         (TestWebKitAPI::TEST):
615         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
616         (TestWebKitAPI::TEST):
617         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
618         (TestWebKitAPI::TEST):
619
620 2018-01-10  Chris Dumez  <cdumez@apple.com>
621
622         Multiple http/wpt/beacon/contentextensions/ test are flaky.
623         https://bugs.webkit.org/show_bug.cgi?id=179256
624         <rdar://problem/35401978>
625
626         Reviewed by Alex Christensen.
627
628         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
629         instance gets its own folder to avoid conflicts and flakiness.
630
631         * WebKitTestRunner/mac/TestControllerMac.mm:
632         (WTR::TestController::platformConfigureViewForTest):
633
634 2018-01-10  Tim Horton  <timothy_horton@apple.com>
635
636         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
637         https://bugs.webkit.org/show_bug.cgi?id=181269
638         <rdar://problem/35110344>
639
640         Reviewed by Simon Fraser.
641
642         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
643         (WTR::UIScriptController::beginBackSwipe):
644         (WTR::UIScriptController::completeBackSwipe):
645         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
646         (WTR::UIScriptController::beginBackSwipe):
647         (WTR::UIScriptController::completeBackSwipe):
648         (WTR::UIScriptController::overridePreference):
649         (WTR::UIScriptController::replaceTextAtRange):
650         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
651         (WTR::PlatformWebView::setNavigationGesturesEnabled):
652         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
653         (WTR::UIScriptController::beginBackSwipe):
654         (WTR::UIScriptController::completeBackSwipe):
655         Implement beginBackSwipe and completeBackSwipe on iOS (they already
656         exist on Mac) in terms of the new WKWebView testing SPI.
657
658 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
659
660         REGRESSION (r226715): ignore WARNING output in linter tests
661         https://bugs.webkit.org/show_bug.cgi?id=181486
662         <rdar://problem/36408847>
663
664         Reviewed by Aakash Jain.
665
666         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
667
668         * Scripts/webkitpy/common/system/outputcapture.py:
669         (OutputCapture.__init__): Pass logging level to be captured.
670         * Scripts/webkitpy/style/main_unittest.py:
671         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
672         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
673         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
674         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
675         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
676         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
677         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
678         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
679
680 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
681
682         Add a JSCOnly MIPS buildbot
683         https://bugs.webkit.org/show_bug.cgi?id=181487
684
685         Reviewed by Michael Catanzaro.
686
687         Add the new bot configs definitions for the master and update the unit tests.
688
689         * BuildSlaveSupport/build.webkit.org-config/config.json:
690         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
691
692 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
693
694         REGRESSION (r226715): don't re-check number of simulators in child processes
695         https://bugs.webkit.org/show_bug.cgi?id=181484
696         <rdar://problem/36407151>
697
698         Reviewed by Aakash Jain.
699
700         * Scripts/webkitpy/port/ios_simulator.py:
701         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
702         are already initialized.
703
704 2018-01-10  Commit Queue  <commit-queue@webkit.org>
705
706         Unreviewed, rolling out r226667 and r226673.
707         https://bugs.webkit.org/show_bug.cgi?id=181488
708
709         This caused a flaky crash. (Requested by mlewis13 on #webkit).
710
711         Reverted changesets:
712
713         "CodeBlocks should be in IsoSubspaces"
714         https://bugs.webkit.org/show_bug.cgi?id=180884
715         https://trac.webkit.org/changeset/226667
716
717         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
718         https://bugs.webkit.org/show_bug.cgi?id=180884
719         https://trac.webkit.org/changeset/226673
720
721 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
722
723         Follow-up fix to r226715
724         https://bugs.webkit.org/show_bug.cgi?id=180555
725         <rdar://problem/36131381>
726
727         Unreviewed infrastructure fix.
728
729         * Scripts/webkitpy/xcode/new_simulated_device.py:
730         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
731         of delete.
732
733 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
734
735         webkitpy: Refactor simulator code (Part 2)
736         https://bugs.webkit.org/show_bug.cgi?id=180555
737         <rdar://problem/36131381>
738
739         Reviewed by Aakash Jain.
740
741         The patch leverages the SimulatedDeviceManager when running layout tests.
742         This patch is primarily code removal, since much of the IOSSimulatorPort
743         was dedicated to managing simulators. The removed code is either now owned by the
744         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
745         boot multiple simulators which was made obsolete in Xcode 9.
746
747         * Scripts/webkitpy/layout_tests/controllers/manager.py:
748         (Manager._custom_device_for_test.in): Device names now have spaces in them,
749         strip those spaces.
750         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
751         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
752         * Scripts/webkitpy/port/ios.py:
753         (IOSPort.__init__): The _current_device idiom is no longer required since the
754         SimulatedDeviceManager keeps track of any previously booted devices.
755         (IOSPort.target_host): Even when only a single device is used, it will be accessed
756         through the array of managed devices.
757         (IOSPort.using_multiple_devices): Deleted.
758         * Scripts/webkitpy/port/ios_device.py:
759         (IOSDevicePort.using_multiple_devices): Deleted.
760         * Scripts/webkitpy/port/ios_simulator.py:
761         (IOSSimulatorPort): Remove constants required to manage simulators, change device
762         class strings so they can be parsed by the DeviceType class.
763         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
764         the number of simulators currently booted, the number of child processes specified
765         and the maximum number of simulators supported by this system.
766         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
767         devices owned by the SimulatedDeviceManager.
768         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
769         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
770         the maximum number of supported simulators on this system.
771         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
772         request for each child process and send this list to the SimulatedDeviceManager to
773         initialize the devices.
774         (IOSSimulatorPort.clean_up_test_run):
775         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
776         specified version of iOS.
777         (IOSSimulatorPort.reset_preferences):
778         (IOSSimulatorPort.simulator_runtime): Deleted.
779         (IOSSimulatorPort.simulator_device_type): Deleted.
780         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
781         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
782         (IOSSimulatorPort._create_simulators): Deleted.
783         (IOSSimulatorPort._quit_ios_simulator): Deleted.
784         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
785         (IOSSimulatorPort.using_multiple_devices): Deleted.
786         (IOSSimulatorPort._create_device): Deleted.
787         (IOSSimulatorPort.get_simulator_path): Deleted.
788         (IOSSimulatorPort._createSimulatorApps): Deleted.
789         (IOSSimulatorPort._createSimulatorApp): Deleted.
790         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
791         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
792         maximum number of simulators run on this system.
793         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
794         * Scripts/webkitpy/xcode/new_simulated_device.py:
795         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
796
797 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
798
799         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
800         https://bugs.webkit.org/show_bug.cgi?id=181474
801
802         Reviewed by Carlos Alberto Lopez Perez.
803
804         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
805         name as the name.
806
807         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
808         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
809         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
810
811 2018-01-09  Andy Estes  <aestes@apple.com>
812
813         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
814         https://bugs.webkit.org/show_bug.cgi?id=181459
815
816         Reviewed by Dan Bernstein.
817
818         * ImageDiff/cg/Configurations/Base.xcconfig:
819
820 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
821
822         font-display:fallback can cause a visual flash (which is supposed to be impossible)
823         https://bugs.webkit.org/show_bug.cgi?id=181374
824
825         Reviewed by Simon Fraser.
826
827         The test requires Palatino.
828
829         * DumpRenderTree/mac/DumpRenderTree.mm:
830         (allowedFontFamilySet):
831         * WebKitTestRunner/mac/TestControllerMac.mm:
832         (WTR::allowedFontFamilySet):
833
834 2018-01-09  Saam Barati  <sbarati@apple.com>
835
836         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
837         https://bugs.webkit.org/show_bug.cgi?id=181449
838
839         Reviewed by JF Bastien.
840
841         This allows me to Cmd+f in my terminal to search for things without
842         having the results become misaligned.
843
844         * Scripts/display-profiler-output:
845
846 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
847
848         [webkitpy] PlatformInfo should have default argument for casual use
849         https://bugs.webkit.org/show_bug.cgi?id=180827
850
851         Reviewed by David Kilzer.
852
853         PlatformInfo should be the only way to check platform specific thing instead
854         of sys.platform or other various checks. If there is something you want to check,
855         it should be placed in PlatformInfo.
856
857         Currently to instantiate PlatformInfo, it requires arguments, which is usually
858         sys, platform and Executive(). They are straight forward and should be handled
859         by default arguments. Then we can instantiate PlatformInfo more casual.
860
861         * Scripts/webkitpy/common/system/platforminfo.py:
862         (PlatformInfo): Use relative module path import
863         (PlatformInfo.__init__):
864         (PlatformInfo.executive): Lazy instantiation of Executive()
865         (PlatformInfo.total_bytes_memory): Accessing via above property
866         (PlatformInfo.xcode_sdk_version): Ditto
867         (PlatformInfo.xcode_simctl_list): Ditto
868         (PlatformInfo.xcode_version): Ditto
869         (PlatformInfo._win_version_str): Ditto
870         * Scripts/webkitpy/common/system/systemhost.py:
871         (SystemHost.__init__):
872         * Scripts/webkitpy/common/system/user.py:
873         (User.__init__):
874
875 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
876
877         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
878         https://bugs.webkit.org/show_bug.cgi?id=176443
879
880         Reviewed by Darin Adler.
881
882         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
883         (TEST):
884
885 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
886
887         check-webkit-style: Verify syntax for WK_API_AVAILABLE
888         https://bugs.webkit.org/show_bug.cgi?id=181394
889
890         Reviewed by Darin Adler.
891
892         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
893         as the second parameter instead of ios(WK_IOS_TBA). This generally
894         builds for iOS on EWS but not when using the public SDK. See r224057,
895         r223207 and r226211 for example. This patch adds a basic style check
896         for that macro to prevent this kind of mistake.
897
898         * Scripts/webkitpy/style/checkers/cpp.py:
899         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
900         (check_style): Run new style check.
901         (CppChecker): Add build type for the new style check.
902         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
903         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
904
905 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
906
907         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
908         https://bugs.webkit.org/show_bug.cgi?id=181420
909         <rdar://problem/36365827>
910
911         Reviewed by Alex Christensen.
912
913         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
914         of corresponding _WKAttachments.
915
916         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
917         (TestWebKitAPI::TEST):
918
919 2018-01-08  Alex Christensen  <achristensen@webkit.org>
920
921         Add WKNavigationDelegate SPI exposing WebProcess crash reason
922         https://bugs.webkit.org/show_bug.cgi?id=181410
923         <rdar://problem/36167199>
924
925         Reviewed by Wenson Hsieh.
926
927         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
928         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
929         (TEST):
930
931 2018-01-08  Alex Christensen  <achristensen@webkit.org>
932
933         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
934         https://bugs.webkit.org/show_bug.cgi?id=181408
935         <rdar://problem/35884960>
936
937         Reviewed by Tim Horton.
938
939         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
940         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
941
942 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
943
944         [Attachment Support] Expose file name and content type of WKAttachment
945         https://bugs.webkit.org/show_bug.cgi?id=181390
946         <rdar://problem/36336837>
947
948         Reviewed by Tim Horton.
949
950         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
951
952         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
953         (-[_WKAttachment synchronouslyRequestInfo:]):
954         (-[_WKAttachment synchronouslyRequestData:]):
955
956         Reimplement this in terms of -synchronouslyRequestInfo:.
957
958         (-[_WKAttachment expectRequestedDataToBe:]):
959         (TestWebKitAPI::TEST):
960
961 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
962
963         Copying, pasting, and then deleting an attachment element breaks attachment data requests
964         https://bugs.webkit.org/show_bug.cgi?id=181365
965         <rdar://problem/36340647>
966
967         Reviewed by Tim Horton.
968
969         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
970         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
971         detail.
972
973         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
974         (TestWebKitAPI::TEST):
975
976 2018-01-08  Youenn Fablet  <youenn@apple.com>
977
978         navigator.onLine does not work inside service workers
979         https://bugs.webkit.org/show_bug.cgi?id=181079
980         <rdar://problem/36178606>
981
982         Reviewed by Darin Adler.
983
984         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
985         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
986
987 2018-01-07  Saam Barati  <sbarati@apple.com>
988
989         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
990         https://bugs.webkit.org/show_bug.cgi?id=181372
991
992         Reviewed by Filip Pizlo.
993
994         Adding these sorting modes makes it easier to analyze functions
995         that recompile a lot and exit a lot.
996
997         * Scripts/display-profiler-output:
998
999 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
1000
1001         Unreviewed, remove my Cisco email from contributors.json
1002
1003         * Scripts/webkitpy/common/config/contributors.json:
1004
1005 2018-01-05  JF Bastien  <jfbastien@apple.com>
1006
1007         WebAssembly: poison JS object's secrets
1008         https://bugs.webkit.org/show_bug.cgi?id=181339
1009         <rdar://problem/36325001>
1010
1011         Reviewed by Mark Lam.
1012
1013         Update tests for swap(Poisoned<k, T>, T*)
1014
1015         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
1016         (TestWebKitAPI::TEST):
1017         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1018         (TestWebKitAPI::TEST):
1019         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1020         (TestWebKitAPI::TEST):
1021
1022 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1023
1024         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
1025         https://bugs.webkit.org/show_bug.cgi?id=181359
1026
1027         Reviewed by Tim Horton.
1028
1029         Ensure that these tests still pass using older SDKs.
1030
1031         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1032         (TestWebKitAPI::TEST):
1033
1034 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1035
1036         Rebase API test after r226469
1037         https://bugs.webkit.org/show_bug.cgi?id=181308
1038
1039         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
1040         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1041         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
1042
1043 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1044
1045         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
1046         https://bugs.webkit.org/show_bug.cgi?id=181217
1047
1048         Reviewed by Tim Horton.
1049
1050         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1051         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1052         (TEST):
1053
1054 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1055
1056         Add WKBundleFrameCreateFrameHandle
1057         https://bugs.webkit.org/show_bug.cgi?id=181232
1058         <rdar://problem/35926696>
1059
1060         Reviewed by Tim Horton.
1061
1062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1063         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
1064         (mouseDidMoveOverElement):
1065         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
1066         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1067         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
1068         (TEST):
1069
1070 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
1071
1072         iOS: Build fix after r226432.
1073         
1074         Unreviewed. Stop duplicating speakAs symbols for iOS.
1075
1076         * DumpRenderTree/AccessibilityUIElement.cpp:
1077         (AccessibilityUIElement::speakAs):
1078
1079 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
1080
1081         Unreviewed, added myself as WebKit reviewer
1082
1083         * Scripts/webkitpy/common/config/contributors.json:
1084
1085 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
1086
1087         WPE: Build fix after r226432.
1088
1089         Unreviewed. Rename ::speak() to ::speakAs().
1090         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1091         (WTR::AccessibilityUIElement::speakAs):
1092         (WTR::AccessibilityUIElement::speak): Deleted.
1093
1094 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
1095
1096         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
1097         https://bugs.webkit.org/show_bug.cgi?id=180361
1098
1099         Reviewed by Zalan Bujtas.
1100
1101         * DumpRenderTree/AccessibilityUIElement.cpp:
1102         (speakAsCallback):
1103         (AccessibilityUIElement::speakAs):
1104         (AccessibilityUIElement::getJSClass):
1105         (speakCallback): Deleted.
1106         (AccessibilityUIElement::speak): Deleted.
1107         * DumpRenderTree/AccessibilityUIElement.h:
1108         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1109         (AccessibilityUIElement::speakAs):
1110         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1111         (AccessibilityUIElement::speakAs):
1112         (AccessibilityUIElement::speak): Deleted.
1113         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1114         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1115         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1116         (WTR::AccessibilityUIElement::speakAs):
1117         (WTR::AccessibilityUIElement::speak): Deleted.
1118         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1119         (WTR::AccessibilityUIElement::speakAs):
1120         (WTR::AccessibilityUIElement::speak): Deleted.
1121
1122 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
1123
1124         REGRESSION (r226395): test-webkitperl test expectations incorrect
1125         https://bugs.webkit.org/show_bug.cgi?id=181307
1126         <rdar://problem/36306558>
1127
1128         Rubber-stamped by Aakash Jain.
1129
1130         r226395 added two lines towards the beginning of
1131         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
1132         numbers in the test expectations need to update.
1133
1134         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1135
1136 2018-01-04  Tim Horton  <timothy_horton@apple.com>
1137
1138         WKWebView loses minimum layout size overrides that happen while the process is terminated
1139         https://bugs.webkit.org/show_bug.cgi?id=181306
1140         <rdar://problem/34398288>
1141
1142         Reviewed by Dan Bernstein.
1143
1144         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1145         (TEST):
1146         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
1147         while the process is terminated results in the page getting the correct
1148         minimum layout size.
1149
1150 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
1151
1152         [MediaStream] Add Mock screen capture source
1153         https://bugs.webkit.org/show_bug.cgi?id=181291
1154         <rdar://problem/36298164>
1155
1156         Reviewed by Dean Jackson.
1157
1158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
1159         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1160         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1161
1162 2018-01-04  Lucas Forschler  <lforschler@apple.com>
1163
1164         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
1165
1166         Reviewed by Ling Ho.
1167
1168         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1169
1170 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1171
1172         [Attachment Support] Create attachment elements when dropping files on iOS
1173         https://bugs.webkit.org/show_bug.cgi?id=181192
1174         <rdar://problem/36280945>
1175
1176         Reviewed by Tim Horton.
1177
1178         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
1179         switch is enabled. See below for more details.
1180
1181         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1182         (-[NSItemProvider registerData:type:]):
1183         (platformCopyPNG):
1184         (TestWebKitAPI::TEST):
1185         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1186
1187         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
1188         source item provider when dragging rich text *without* attachments, so this should have been a check for just
1189         kUTTypeRTF instead.
1190
1191         (TestWebKitAPI::TEST):
1192
1193         Tests a few cases of inserting attachment elements via drop:
1194         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
1195             Instead of inserting the contents as inline web content, this should generate attachment elements.
1196         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
1197             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
1198             back to inserting the content as an attachment.
1199         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
1200             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
1201             or at the end).
1202
1203         * TestWebKitAPI/cocoa/TestWKWebView.h:
1204         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1205         (-[TestWKWebView objectByEvaluatingJavaScript:]):
1206
1207         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
1208         -stringByEvaluatingJavaScript to just turn around and call this.
1209
1210         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1211
1212 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
1213
1214         Replace hard-coded paths in shebangs with #!/usr/bin/env
1215         https://bugs.webkit.org/show_bug.cgi?id=181040
1216
1217         Reviewed by Alex Christensen.
1218
1219         * BuildSlaveSupport/build-launcher-app:
1220         * BuildSlaveSupport/build-launcher-dmg:
1221         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1222         * BuildSlaveSupport/built-product-archive:
1223         * BuildSlaveSupport/clean-build:
1224         * BuildSlaveSupport/delete-stale-build-files:
1225         * BuildSlaveSupport/download-built-product:
1226         * BuildSlaveSupport/gtk/buildbot/log/run:
1227         * BuildSlaveSupport/gtk/buildbot/run:
1228         * BuildSlaveSupport/gtk/pulseaudio/run:
1229         * BuildSlaveSupport/kill-old-processes:
1230         * BuildSlaveSupport/test-result-archive:
1231         * BuildSlaveSupport/win/kill-old-processes:
1232         * Scripts/SpacingHeuristics.pm:
1233         * Scripts/add-include:
1234         * Scripts/build-api-tests:
1235         * Scripts/build-dumprendertree:
1236         * Scripts/build-imagediff:
1237         * Scripts/build-jsc:
1238         * Scripts/build-webkit:
1239         * Scripts/build-webkittestrunner:
1240         * Scripts/check-Xcode-source-file-types:
1241         * Scripts/check-dom-results:
1242         * Scripts/check-for-exit-time-destructors:
1243         * Scripts/check-for-global-initializers:
1244         * Scripts/check-for-inappropriate-objc-class-names:
1245         * Scripts/check-for-weak-vtables-and-externals:
1246         * Scripts/clean-header-guards:
1247         * Scripts/compare-timing-files:
1248         * Scripts/configure-xcode-for-ios-development:
1249         * Scripts/copy-webkitlibraries-to-product-directory:
1250         * Scripts/create-exports:
1251         * Scripts/debug-minibrowser:
1252         * Scripts/debug-safari:
1253         * Scripts/debug-test-runner:
1254         * Scripts/do-file-rename:
1255         * Scripts/do-webcore-rename:
1256         * Scripts/dump-webkit-tests-run:
1257         * Scripts/ensure-valid-python:
1258         * Scripts/execAppWithEnv:
1259         * Scripts/extract-localizable-js-strings:
1260         * Scripts/filter-build-webkit:
1261         * Scripts/find-extra-includes:
1262         * Scripts/fix-blink-patch:
1263         * Scripts/generate-coverage-data:
1264         * Scripts/git-add-reviewer:
1265         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1266         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1267         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
1268         * Scripts/make-new-script-test:
1269         * Scripts/make-script-test-wrappers:
1270         * Scripts/package-root:
1271         * Scripts/parse-malloc-history:
1272         * Scripts/report-include-statistics:
1273         * Scripts/resolve-ChangeLogs:
1274         * Scripts/run-api-tests:
1275         * Scripts/run-bindings-tests:
1276         * Scripts/run-content-extension-tester:
1277         * Scripts/run-iexploder-tests:
1278         * Scripts/run-javascriptcore-tests:
1279         * Scripts/run-jsc:
1280         * Scripts/run-leaks:
1281         * Scripts/run-mangleme-tests:
1282         * Scripts/run-minibrowser:
1283         * Scripts/run-pageloadtest:
1284         * Scripts/run-regexp-tests:
1285         * Scripts/run-safari:
1286         * Scripts/run-sunspider:
1287         * Scripts/run-test-runner:
1288         * Scripts/run-webkit-app:
1289         * Scripts/run-webkit-httpd:
1290         * Scripts/run-webkit-websocketserver:
1291         * Scripts/set-webkit-configuration:
1292         * Scripts/show-pretty-diff:
1293         * Scripts/sort-Xcode-project-file:
1294         * Scripts/split-file-by-class:
1295         * Scripts/sunspider-compare-results:
1296         * Scripts/svn-apply:
1297         * Scripts/svn-unapply:
1298         * Scripts/test-webkit-scripts:
1299         * Scripts/test-webkitperl:
1300         * Scripts/update-iexploder-cssproperties:
1301         * Scripts/update-javascriptcore-test-results:
1302         * Scripts/update-webkit:
1303         * Scripts/update-webkit-auxiliary-libs:
1304         * Scripts/update-webkit-dependency:
1305         * Scripts/update-webkit-libs-jhbuild:
1306         * Scripts/update-webkit-localizable-strings:
1307         * Scripts/update-webkit-support-libs:
1308         * Scripts/update-webkitgtk-libs:
1309         * Scripts/update-webkitwpe-libs:
1310         * Scripts/webkit-build-directory:
1311         * Scripts/webkitperl/LoadAsModule.pm:
1312         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1313         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1314         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
1315         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
1316         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
1317         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1318         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1319         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1320         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1321         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1322         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
1323         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
1324         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
1325         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1326         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1327         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1328         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1329         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
1330         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
1331         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
1332         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
1333         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
1334         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
1335         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
1336         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1337         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1338         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
1339         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
1340         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1341         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1342         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1343         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1344         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1345         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1346         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1347         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1348         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1349         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1350         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1351         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1352         * ccache/ccache-clang:
1353         * ccache/ccache-clang++:
1354         * ccache/ccache-wrapper:
1355         * gtk/install-dependencies:
1356         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1357         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1358         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1359         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1360         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1361         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1362         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1363         * iExploder/iexploder-1.7.2/src/webserver.rb:
1364         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1365         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1366         * wpe/install-dependencies:
1367
1368 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1369
1370         filter-build-webkit filters out useful compiler error lines
1371         https://bugs.webkit.org/show_bug.cgi?id=179864
1372
1373         Reviewed by Tim Horton.
1374
1375         Don't filter out lines that contain information about build errors by always showing lines
1376         after a line that contains "note:" or "error:".
1377
1378         * Scripts/filter-build-webkit:
1379         (shouldShowSubsequentLine):
1380         (shouldIgnoreLine):
1381
1382 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1383
1384         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1385         https://bugs.webkit.org/show_bug.cgi?id=173915
1386
1387         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1388         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1389         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1390         empty string in this case.
1391
1392         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1393         (emitFormSubmissionEvent):
1394
1395 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1396
1397         [GTK] Add web process API to detect when form is submitted via JavaScript
1398         https://bugs.webkit.org/show_bug.cgi?id=173915
1399
1400         Reviewed by Carlos Garcia Campos.
1401
1402         Test it.
1403
1404         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1405         (FormSubmissionTest::FormSubmissionTest):
1406         (FormSubmissionTest::~FormSubmissionTest):
1407         (FormSubmissionTest::testFormSubmissionResult):
1408         (FormSubmissionTest::willSendDOMEventCallback):
1409         (FormSubmissionTest::willCompleteCallback):
1410         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1411         (testWebExtensionFormSubmissionSteps):
1412         (beforeAll):
1413         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1414         (DelayedSignal::DelayedSignal):
1415         (emitFormSubmissionEvent):
1416         (handleFormSubmissionCallback):
1417         (willSubmitFormCallback):
1418         (pageCreatedCallback):
1419
1420 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1421
1422         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1423         https://bugs.webkit.org/show_bug.cgi?id=181251
1424
1425         * Scripts/run-gtk-tests:
1426         (GtkTestRunner):
1427
1428 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1429
1430         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1431         https://bugs.webkit.org/show_bug.cgi?id=181136
1432
1433         * Scripts/run-gtk-tests:
1434         (GtkTestRunner):
1435
1436 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1437
1438         [macOS, iOS] Adopt new secure coding APIs in WebKit
1439         https://bugs.webkit.org/show_bug.cgi?id=181085
1440         <rdar://problem/34837397>
1441
1442         Reviewed by Tim Horton.
1443
1444         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1445         capable of supporting NSSecureCoding, so pass through the current coding routines.
1446
1447         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1448         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1449         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1450         routines if necessary.
1451         (TEST): Updated for NSSecureCoding.
1452         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1453         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1454
1455 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1456
1457         Remove std::chrono completely
1458         https://bugs.webkit.org/show_bug.cgi?id=181186
1459
1460         Reviewed by Alex Christensen.
1461
1462         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1463         (WTR::TestController::platformRunUntil):
1464
1465 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1466
1467         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1468         https://bugs.webkit.org/show_bug.cgi?id=181231
1469
1470         Reviewed by Alex Christensen.
1471
1472         Implement TestController APIs needed by ResourceLoadStatistics tests.
1473
1474         * WebKitTestRunner/TestController.cpp:
1475         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1476         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1477
1478 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1479
1480         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1481         https://bugs.webkit.org/show_bug.cgi?id=181219
1482
1483         Reviewed by Wenson Hsieh.
1484
1485         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1486
1487 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1488
1489         Add a WebAuthentication runtime feature flag
1490         https://bugs.webkit.org/show_bug.cgi?id=181220
1491         <rdar://problem/36055305>
1492
1493         Reviewed by Brent Fulgham.
1494
1495         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1496
1497         * DumpRenderTree/TestOptions.h:
1498         * DumpRenderTree/TestOptions.mm:
1499         (TestOptions::TestOptions):
1500         * DumpRenderTree/mac/DumpRenderTree.mm:
1501         (enableExperimentalFeatures):
1502         (setWebPreferencesForTestOptions):
1503         * WebKitTestRunner/TestController.cpp:
1504         (WTR::TestController::resetPreferencesToConsistentValues):
1505         (WTR::updateTestOptionsFromTestHeader):
1506         * WebKitTestRunner/TestOptions.h:
1507         (WTR::TestOptions::hasSameInitializationOptions const):
1508
1509 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1510
1511         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1512         https://bugs.webkit.org/show_bug.cgi?id=181143
1513         <rdar://problem/36200381>
1514
1515         Reviewed by Tim Horton.
1516
1517         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1518         attachment elements are enabled.
1519
1520         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1521         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1522         (TestWebKitAPI::TEST):
1523
1524 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1525
1526         Update Credential Management API for WebAuthentication
1527         https://bugs.webkit.org/show_bug.cgi?id=181082
1528         <rdar://problem/36055239>
1529
1530         Reviewed by Brent Fulgham.
1531
1532         Enable Credential Management API for testing.
1533
1534         * DumpRenderTree/TestOptions.h:
1535         * WebKitTestRunner/TestOptions.h:
1536
1537 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1538
1539         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1540         https://bugs.webkit.org/show_bug.cgi?id=168194
1541
1542         Reviewed by Carlos Garcia Campos.
1543
1544         Fix an assertion and unskip the test. The order that form controls are associated is not
1545         guaranteed.
1546
1547         * Scripts/run-gtk-tests:
1548         (GtkTestRunner):
1549         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1550         (didAssociateFormControlsCallback):
1551
1552 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1553
1554         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1555         https://bugs.webkit.org/show_bug.cgi?id=180897
1556         <rdar://problem/35535328>
1557
1558         Reviewed by Brent Fulgham.
1559
1560         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1561
1562         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1563         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1564         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1565         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1566         (websiteDataStoreTestWebView):
1567         (TEST):
1568
1569 == Rolled over to ChangeLog-2018-01-01 ==