d9f3efe4a484158372d3730ac104182d9d0c1238
[WebKit-https.git] / Tools / ChangeLog
1 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
2
3         run-benchmark should print out the results
4         https://bugs.webkit.org/show_bug.cgi?id=145398
5
6         Reviewed by Antti Koivisto.
7
8         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
9         of the output to catch early errors.
10
11         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
12         (BenchmarkResults): Added.
13         (BenchmarkResults.__init__): Added.
14         (BenchmarkResults.format): Added.
15         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
16         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
17         Uses the sample standard deviation to compute the significant figures for the value.
18         (BenchmarkResults._unit_from_metric): Added.
19         (BenchmarkResults._aggregate_results): Added.
20         (BenchmarkResults._aggregate_results_for_test): Added.
21         (BenchmarkResults._flatten_list): Added.
22         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
23         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
24         (BenchmarkResults._aggregate_values): Added.
25         (BenchmarkResults._lint_results): Added.
26         (BenchmarkResults._lint_subtest_results): Added.
27         (BenchmarkResults._lint_aggregator_list): Added.
28         (BenchmarkResults._lint_configuration): Added.
29         (BenchmarkResults._lint_values): Added.
30         (BenchmarkResults._is_numeric): Added.
31         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
32         (BenchmarkResultsTest):
33         (BenchmarkResultsTest.test_init):
34         (BenchmarkResultsTest.test_format):
35         (test_format_values_with_large_error):
36         (test_format_values_with_small_error):
37         (test_format_values_with_time):
38         (test_format_values_with_no_error):
39         (test_format_values_with_small_difference):
40         (test_aggregate_results):
41         (test_aggregate_results_with_gropus):
42         (test_aggregate_nested_results):
43         (test_lint_results):
44         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
45         (BenchmarkRunner.execute): Added a call to show_results
46         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
47         (BenchmarkRunner.show_results): Added.
48
49 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
50
51         run_benchmark should have an option to specify the number of runs
52         https://bugs.webkit.org/show_bug.cgi?id=145091
53
54         Reviewed by Antti Koivisto.
55
56         Added --count option.
57
58         * Scripts/run-benchmark:
59         (main):
60         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
61         (BenchmarkRunner.__init__):
62
63 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
64
65         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
66
67         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
68
69 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
70
71         Update results of WebKit1.StringTruncator after r184965.
72
73         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
74
75 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
76
77         Unreviewed, updated my list of email addresses.
78
79         * Scripts/webkitpy/common/config/contributors.json:
80
81 2015-05-27  Dean Jackson  <dino@apple.com>
82
83         img.currentSrc problem in strict mode with old picturefill
84         https://bugs.webkit.org/show_bug.cgi?id=144095
85         <rdar://problem/21087013>
86
87         Reviewed by Simon Fraser.
88
89         Add a PICTURE_SIZES flag.
90
91         * Scripts/webkitperl/FeatureList.pm:
92
93 2015-05-26  Dana Burkart  <dburkart@apple.com>
94
95         Fixes compatibility issues with recent dashboard cleanup.
96         https://bugs.webkit.org/show_bug.cgi?id=144814
97
98         Reviewed by Alexey Proskuryakov.
99
100         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
101         (BuildbotStaticAnalyzerQueueView):
102         (BuildbotStaticAnalyzerQueueView.prototype.update):
103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
104         (documentReady):
105
106 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
107
108         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
109         https://bugs.webkit.org/show_bug.cgi?id=143091
110         rdar://problem/19330328
111
112         Reviewed by Darin Adler and Timothy Hatcher.
113
114         We have many of these, which are hard to fit on the dashboard. Added a view that
115         collapses to a single green bubble when everything is good, and expands when there
116         are failures (or manually).
117
118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
119
120         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
121         (Buildbot.prototype.set isAuthenticated):
122         (Buildbot.prototype._normalizeQueueInfo):
123         (Buildbot.prototype._normalizeQueuesInfo):
124         (Buildbot.prototype.updateQueues):
125         Moved queue info normalization here from BuildbitQueue. The latter is a model class
126         that shouldn't have to know about presentation, and this lets us leep the knowledge
127         about combined queues out if it. Later, we can refactor existing code, and move out
128         all knowledge about headings and such.
129
130         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
131         Added the new view. It's not quite universal, and doesn't have as helpful popovers
132         as other views, but we can extend it when/if we use it for more than JSC.
133
134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
135         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
136
137         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
138         (documentReady): Added support for combined queues. These are currently always ending up
139         in Other column, but it's easy to customize in the future if we need to.
140
141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
142         (WebKitBuildbot): Added JSC queus.
143
144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
145         (.combined-queue-popover):
146         (.combined-queue-popover .revision):
147         Added styles for the combined view.
148
149 2015-05-26  Dan Bernstein  <mitz@apple.com>
150
151         Changed a file to use Unix line endings.
152
153         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
154
155 2015-05-26  Dan Bernstein  <mitz@apple.com>
156
157         <rdar://problem/21104551> Update build settings
158
159         Reviewed by Anders Carlsson.
160
161         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
162         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
163         * MiniBrowser/Configurations/DebugRelease.xcconfig:
164         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
165         * WebEditingTester/Configurations/DebugRelease.xcconfig:
166         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
167         * asan/asan.xcconfig:
168
169 2015-05-26  Anders Carlsson  <andersca@apple.com>
170
171         Fix build.
172
173         * WebKitTestRunner/mac/EventSenderProxy.mm:
174         (WTR::EventSenderProxy::mouseForceDown):
175         (WTR::EventSenderProxy::mouseForceUp):
176         (WTR::EventSenderProxy::mouseForceChanged):
177
178 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
179
180         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
181         https://bugs.webkit.org/show_bug.cgi?id=145342
182
183         Reviewed by Darin Adler.
184
185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
186         (BuildbotIteration.prototype._parseData):
187
188 2015-05-26  Milan Crha  <mcrha@redhat.com>
189
190         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
191         https://bugs.webkit.org/show_bug.cgi?id=138134
192
193         Reviewed by Žan Doberšek.
194
195         * gtk/generate-inspector-gresource-manifest.py:
196         (get_filenames): Command line with expanded resources exceeds 32KB, which
197         is a limit on Windows. It's better to expand wildcards inside the python script.
198
199 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
200
201         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
202         https://bugs.webkit.org/show_bug.cgi?id=140882
203
204         Reviewed by Gustavo Noronha Silva.
205
206         Make sure unit tests write IndexedDB databases to the temporary
207         directory, and add a test case to check that the directory is
208         correctly created at the expected path.
209
210         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
211         (testWebContextConfiguration):
212         (serverCallback):
213         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
214         (Test::Test):
215
216 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
217
218         [GTK] Enable IndexedDB
219         https://bugs.webkit.org/show_bug.cgi?id=98932
220
221         Reviewed by Žan Doberšek.
222
223         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
224
225 2015-05-24  Sam Weinig  <sam@webkit.org>
226
227         Crash when using a removed ScriptMessageHandler
228         <rdar://problem/20888499>
229         https://bugs.webkit.org/show_bug.cgi?id=145359
230
231         Reviewed by Dan Bernstein.
232
233         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
234         Add tests for removing script message handlers.
235
236 2015-05-23  Dan Bernstein  <mitz@apple.com>
237
238         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
239         https://bugs.webkit.org/show_bug.cgi?id=145345
240
241         Reviewed by Sam Weinig.
242
243         * DumpRenderTree/mac/Configurations/Base.xcconfig:
244         * LayoutTestRelay/Configurations/Base.xcconfig:
245         * TestWebKitAPI/Configurations/Base.xcconfig:
246         * WebKitTestRunner/Configurations/Base.xcconfig:
247
248 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
249
250         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
251         https://bugs.webkit.org/show_bug.cgi?id=144848
252
253         Reviewed by Darin Adler.
254
255         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
256
257         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
258
259 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
260
261         Fix one more merge error in static analyzer support.
262
263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
264         (BuildbotStaticAnalyzerQueueView):
265
266 2015-05-22  Dana Burkart  <dburkart@apple.com>
267
268         Fix internal dashboard breakage from recent commit.
269         https://bugs.webkit.org/show_bug.cgi?id=144814
270
271         Unreviewed build fix.
272
273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
274         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
275         (BuildbotStaticAnalyzerQueueView.prototype.update):
276
277 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
278
279         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
280         https://bugs.webkit.org/show_bug.cgi?id=130463
281         rdar://problem/20461342
282
283         Reviewed by Tim Horton.
284
285         This was more of a timing related flakiness than an actual OS version specific bug,
286         we weren't getting window visibility notifications.
287         
288         I will look into adding this function call to DumpRenderTree separately, layout tests
289         might actually rely on the broken behavior.
290
291         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
292         (TestWebKitAPI::TEST_F):
293         * TestWebKitAPI/mac/mainMac.mm:
294         (main):
295
296 2015-05-22  Dana Burkart  <dburkart@apple.com>
297
298         Add missing file from r184804 (mis-applied diff).
299         https://bugs.webkit.org/show_bug.cgi?id=144814
300
301         Reviewed by Alexey Proskuryakov.
302
303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
304         (BuildbotStaticAnalyzerQueueView):
305         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
306         (BuildbotStaticAnalyzerQueueView.prototype.update):
307
308 2015-05-22  Dana Burkart  <dburkart@apple.com>
309
310         Add support to the botwatchers dashboard for a static analyzer bot.
311         https://bugs.webkit.org/show_bug.cgi?id=144814
312
313         Reviewed by Alexey Proskuryakov.
314
315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
316         scan-build should be considered a productive step.
317
318         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
319         (BuildbotQueue):
320         Adds support for the staticAnalyzer property
321
322         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
323         (BuildbotTestResults.prototype._parseResults):
324         Get bug count from the scan-build step output
325
326         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
327         (documentReady):
328         Rename the performance column 'Other', and merge the current 'Other' column with it.
329
330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
331         (WebKitBuildbot):
332         Now that performance bots are part of the 'Other' column, give them better headings.
333
334 2015-05-22  Tim Horton  <timothy_horton@apple.com>
335
336         Turn on autosaving of toolbar configuration in MiniBrowser
337
338         Rubber-stamped by Dan Bernstein.
339
340         * MiniBrowser/mac/BrowserWindow.xib:
341
342 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
343
344         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
345         https://bugs.webkit.org/show_bug.cgi?id=145297
346
347         Reviewed by Tim Horton.
348
349         This is a refactoring to simplify code, and to make it more logical.
350
351         It is up to the view to decide how to present the queues, and whether to split
352         them into debug and release, or in some different way.
353
354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
355         (BuildbotBuilderQueueView.filterQueues):
356         (BuildbotBuilderQueueView):
357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
358         (BuildbotLeaksQueueView):
359         (BuildbotLeaksQueueView.prototype.update):
360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
361         (BuildbotPerformanceQueueView):
362         (BuildbotPerformanceQueueView.prototype.update):
363         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
364         (BuildbotQueueView):
365         (BuildbotQueueView.prototype._updateQueues):
366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
367         (BuildbotTesterQueueView):
368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
369         (documentReady):
370
371 2015-05-22  Tim Horton  <timothy_horton@apple.com>
372
373         Remove action menu support
374         https://bugs.webkit.org/show_bug.cgi?id=145305
375         <rdar://problem/21070771>
376
377         Reviewed by Anders Carlsson.
378
379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
380         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
381         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
382         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
383         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
384         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
385         Remove the tests.
386
387 2015-05-22  Dan Bernstein  <mitz@apple.com>
388
389         Removed the Use Shrink To Fit button from the toolbar’s default set.
390
391         Rubber-stamped by Tim Horton.
392
393         * MiniBrowser/mac/BrowserWindow.xib:
394
395 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
396
397         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
398         https://bugs.webkit.org/show_bug.cgi?id=128420
399
400         Reviewed by Chris Fleizach.
401
402         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
403         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
404
405 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
406
407         [EFL] Bump libsoup version to 2.50.0
408         https://bugs.webkit.org/show_bug.cgi?id=145127
409
410         Reviewed by Gyuyoung Kim.
411
412         * efl/jhbuild.modules:
413         * efl/patches/soup-clang-warning-fix1.patch: Removed.
414         * efl/patches/soup-clang-warning-fix2.patch: Removed.
415
416 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
417
418         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
419         https://bugs.webkit.org/show_bug.cgi?id=145117
420
421         Reviewed by Csaba Osztrogonác.
422
423         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
424         Tools/TestWebKitAPI/Tests/WTF/glib/.
425
426         * TestWebKitAPI/PlatformGTK.cmake:
427         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
428         (TestWebKitAPI::TEST):
429
430 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
431
432         [EFL] fix efreet error
433         https://bugs.webkit.org/show_bug.cgi?id=143670
434
435         Reviewed by Gyuyoung Kim.
436
437         Fix efreet error by using external variable efreet_cache_update.
438         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
439         efreet error for efreet_cache does not occur.
440
441         * MiniBrowser/efl/main.c:
442         (elm_main):
443
444 2015-05-20  Michael Saboff  <msaboff@apple.com>
445
446         Add option to run_jsc_stress_tests to disable JIT testing
447         https://bugs.webkit.org/show_bug.cgi?id=145233
448
449         Reviewed by Mark Lam.
450
451         Added --no-jit option.
452
453         * Scripts/run-jsc-stress-tests:
454
455 2015-05-20  Alex Christensen  <achristensen@webkit.org>
456
457         Use correct String for StringView in WTF API tests
458         https://bugs.webkit.org/show_bug.cgi?id=145226
459         rdar://problem/20361786
460
461         Reviewed by Benjamin Poulain.
462
463         * TestWebKitAPI/Tests/WTF/StringView.cpp:
464         (TestWebKitAPI::TEST):
465         Use patternHolder for pattern.
466
467 2015-05-20  Alex Christensen  <achristensen@webkit.org>
468
469         [Content Extensions] Relax restrictions on triggers that match everything.
470         https://bugs.webkit.org/show_bug.cgi?id=145069
471
472         Reviewed by Benjamin Poulain.
473
474         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
475         (TestWebKitAPI::TEST_F):
476         Update and add tests for new possibilities with .*
477
478 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
479
480         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
481         https://bugs.webkit.org/show_bug.cgi?id=144992
482
483         Reviewed by Gyuyoung Kim.
484
485         * MiniBrowser/efl/main.c:
486         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
487         (on_key_down):
488         (on_fullscreen_enter):
489         (on_fullscreen_exit):
490         (window_create):
491
492 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
493
494         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
495         https://bugs.webkit.org/show_bug.cgi?id=145109
496
497         Reviewed by Darin Adler.
498
499         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
500         (TestWebKitAPI::TEST):
501
502 2015-05-19  Anders Carlsson  <andersca@apple.com>
503
504         Add alternate menu items for performing operations on the default data store
505         https://bugs.webkit.org/show_bug.cgi?id=145184
506
507         Reviewed by Sam Weinig.
508
509         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
510         associated with a data store.
511
512         * MiniBrowser/mac/AppDelegate.m:
513         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
514         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
515         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
516         * MiniBrowser/mac/MainMenu.xib:
517
518 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
519
520         Fix tautological-compare warning in AtomicString.cpp
521         https://bugs.webkit.org/show_bug.cgi?id=145120
522
523         Reviewed by Alexey Proskuryakov.
524
525         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
526         (TestWebKitAPI::TEST): Removed always true assert.
527
528 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
529
530         [EFL] Fix unsequenced warning in MiniBrowser's main.c
531         https://bugs.webkit.org/show_bug.cgi?id=145123
532
533         Reviewed by Gyuyoung Kim.
534
535         * MiniBrowser/efl/main.c:
536         (on_key_down):
537
538 2015-05-18  Daniel Bates  <dabates@apple.com>
539
540         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
541         when staged non-empty file for commit
542         https://bugs.webkit.org/show_bug.cgi?id=145082
543
544         Reviewed by Darin Adler.
545
546         Fixes two issues when running prepare-ChangeLog:
547             1. The function above a deleted function is reported as changed.
548             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
549             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
550             included in this patch).
551
552         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
553         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
554         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
555         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
556         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
557         VCSUtil::parseChunkRange() has existing test coverage.
558
559         * Scripts/prepare-ChangeLog:
560         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
561         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
562         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
563         examine files that only have deletions. Currently this works as a side effect of the behavior of
564         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
565         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
566         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
567         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
568         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
569         We return (-1, -1) when the change represents a deletion.
570         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
571         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
572         We return (-1, -1) when the change represents an addition.
573         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
574         unit tests.
575
576 2015-05-18  Anders Carlsson  <andersca@apple.com>
577
578         Add ATS keys to MiniBrowser
579         https://bugs.webkit.org/show_bug.cgi?id=145141
580
581         Reviewed by Sam Weinig.
582
583         * MiniBrowser/mac/Info.plist:
584
585 2015-05-17  David Kilzer  <ddkilzer@apple.com>
586
587         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
588         <http://webkit.org/b/145100>
589
590         Reviewed by Darin Adler.
591
592         * Scripts/bisect-builds:
593         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
594         - Switch to using PROMPT_RESPONSE_* constants when testing the
595           value of $didReproduceBug.
596         - Add do { } while loops to implement 'retry' mode.
597         (promptForTest):
598         - Switch to returning PROMPT_RESPONSE_* constants.
599         - Add support for 'retry' response.
600
601 2015-05-16  Tanay C  <tanay.c@samsung.com>
602
603         [EFL][WK2] Minibrowser : Add search icon to search bar
604         https://bugs.webkit.org/show_bug.cgi?id=139773
605
606         Reviewed by Gyuyoung Kim.
607
608         * MiniBrowser/efl/main.c: 
609         (search_icon_show): Added.
610         (search_box_show): Modified.
611
612 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
613
614         run_benchmark should have an option to specify the number of runs
615         https://bugs.webkit.org/show_bug.cgi?id=145091
616
617         Reviewed by Stephanie Lewis.
618
619         Added --count option.
620
621         * Scripts/run-benchmark:
622         (main):
623         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
624         (BenchmarkRunner.__init__):
625
626 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
627
628         Temporarily disable failing API test.
629
630         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
631         (TestWebKitAPI::TEST):
632
633 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
634
635         User interruption while running of run-webkit-tests should also generate results.html
636         https://bugs.webkit.org/show_bug.cgi?id=122154
637
638         Reviewed by Csaba Osztrogonác.
639
640         Generation of results.html on execution of run-webkit-tests happens only
641         on completion of entire layout tests run. It should be created even when
642         the execution has been interrupted - either by user (by pressing Ctrl+C)
643         or because of other interruptions (like exit-after-n-failures option).
644
645         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
646         (LayoutTestRunner.run_tests):
647         * Scripts/webkitpy/layout_tests/controllers/manager.py:
648         (Manager.run):
649         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
650         (TestRunResults.__init__):
651         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
652         (main):
653         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
654         (RunTest.test_keyboard_interrupt):
655         (MainTest.test_exception_handling):
656
657 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
658
659         [buildbot] Fix the URL of the performance bots
660         https://bugs.webkit.org/show_bug.cgi?id=145043
661
662         Reviewed by Ryosuke Niwa.
663
664         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
665
666 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
667
668         Add a layout mode that scales down the view to try to fit the document
669         https://bugs.webkit.org/show_bug.cgi?id=145022
670         <rdar://problem/19790341>
671
672         Reviewed by Dean Jackson.
673
674         * MiniBrowser/mac/BrowserWindow.xib:
675         * MiniBrowser/mac/BrowserWindowController.h:
676         * MiniBrowser/mac/WK2BrowserWindowController.m:
677         (-[WK2BrowserWindowController toggleShrinkToFit:]):
678         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
679         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
680
681 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
682
683         [CMake] Don't read the LOCATION property of targets
684         https://bugs.webkit.org/show_bug.cgi?id=145018
685
686         Reviewed by Martin Robinson.
687
688         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
689         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
690         be the same at configure-time as it is at generate-time.
691
692         * TestWebKitAPI/CMakeLists.txt:
693
694 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
695
696         Add String literal overloads to equalIgnoringASCIICase()
697         https://bugs.webkit.org/show_bug.cgi?id=145008
698
699         Reviewed by Benjamin Poulain.
700
701         Test changes to WTF.
702
703         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
704         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
705         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
706         * TestWebKitAPI/Tests/WTF/StringView.cpp:
707         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
708         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
709
710 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
711
712         SharedBuffer::createWithContentsOfFile should use map file routines
713         https://bugs.webkit.org/show_bug.cgi?id=144192
714
715         Reviewed by Darin Adler.
716
717         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
718
719         * TestWebKitAPI/PlatformGTK.cmake:
720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
721         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
722         (TestWebKitAPI::FileSystemTest::tempFilePath):
723         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
724         (TestWebKitAPI::TEST_F):
725         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
726         (TestWebKitAPI::SharedBufferTest::tempFilePath):
727         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
728         (TestWebKitAPI::TEST_F):
729
730 2015-05-13  Alex Christensen  <achristensen@webkit.org>
731
732         [Content Extensions] Test interactions between multiple extensions and multiple domains.
733         https://bugs.webkit.org/show_bug.cgi?id=144967
734
735         Reviewed by Benjamin Poulain.
736
737         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
738         Xcode wanted to fix an alphabetization issue.
739         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
740         (TestWebKitAPI::TEST_F):
741         Test interactions that worked but were not explicitly tested before.
742
743 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
744
745         Unreviewed build fix.
746
747         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
748
749         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
750
751 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
752
753         Fix the previous commit, which made both bubbles green.
754
755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
756         (.status-line.good .bubble):
757         (.status-line.bad .bubble):
758         (.status-line.good .message):
759
760 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
761
762         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
763         https://bugs.webkit.org/show_bug.cgi?id=144929
764
765         Reviewed by Eric Carlson.
766
767         Tweaked colors as I see fit.
768
769         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
770         (.status-line.good .bubble):
771         (.status-line.bad .bubble):
772
773 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
774
775         [Mac] Share cookie storage between UI process and secondary processes
776         https://bugs.webkit.org/show_bug.cgi?id=144820
777         rdar://problem/20572830
778
779         Reviewed by Darin Adler.
780
781         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
782         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
783         for testing.
784
785 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
786
787         Fix internal build configuration issues
788         https://bugs.webkit.org/show_bug.cgi?id=144762
789
790         Reviewed by David Kilzer.
791
792         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
793
794         * DumpRenderTree/mac/Configurations/Base.xcconfig:
795         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
796         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
797         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
798         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
799         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
800         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
801         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
802
803 2015-05-12  David Kilzer  <ddkilzer@apple.com>
804
805         Switch to launching iOS Simulator using bundle ID
806         <rdar://problem/20916096>
807
808         This is required to fix the layout tests on internal bots.
809
810         * Scripts/webkitdirs.pm:
811         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
812         Simulator.  Add FIXME.
813         (quitIOSSimulator): Add FIXME.
814         * Scripts/webkitpy/port/ios.py:
815         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
816         launch iOS Simulator.  Add FIXME.
817         (IOSSimulatorPort.check_sys_deps): Add FIXME.
818
819 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
820
821         Fix run-javascriptcore-tests step on the WinCairo bot
822         https://bugs.webkit.org/show_bug.cgi?id=144866
823
824         Reviewed by Csaba Osztrogonác.
825
826         Catch exception when failing to create soft link, so we can fall back to copy.
827
828         * Scripts/run-jsc-stress-tests:
829
830 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
831
832         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
833         https://bugs.webkit.org/show_bug.cgi?id=116971
834
835         Reviewed by Chris Fleizach.
836
837         Implement rowAtIndex for ATK.
838
839         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
840         (WTR::AccessibilityUIElement::rowAtIndex):
841
842 2015-05-11  Dan Bernstein  <mitz@apple.com>
843
844         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
845
846         Reviewed by Alexey Proskuryakov.
847
848         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
849         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
850         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
851         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
852
853 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
854
855         Fix internal build configuration issues
856         https://bugs.webkit.org/show_bug.cgi?id=144762
857
858         Reviewed by Darin Adler.
859
860         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
861
862         * TestWebKitAPI/Configurations/Base.xcconfig:
863         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
864         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
865         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
866         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
867         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
868         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
869
870 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
871
872         [Win] Move Windows build target to Windows 7 (or newer)
873         https://bugs.webkit.org/show_bug.cgi?id=144890
874         <rdar://problem/20707307>
875
876         Reviewed by Anders Carlsson.
877
878         Update linked SDK and minimal Windows level to be compatible with
879         Windows 7 or newer.
880
881         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
882         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
883         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
884         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
885         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
886         * DumpRenderTree/config.h:
887         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
888         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
889         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
890         * WinLauncher/stdafx.h:
891
892 2015-05-11  Commit Queue  <commit-queue@webkit.org>
893
894         Unreviewed, rolling out r184119.
895         https://bugs.webkit.org/show_bug.cgi?id=144888
896
897         broke JSC tests on Apple Windows bots (Requested by kling on
898         #webkit).
899
900         Reverted changeset:
901
902         "Fix run-javascriptcore-tests step on the WinCairo bot"
903         https://bugs.webkit.org/show_bug.cgi?id=144866
904         http://trac.webkit.org/changeset/184119
905
906 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
907
908         run-benchmark should support Dromaeo
909         https://bugs.webkit.org/show_bug.cgi?id=144849
910
911         Reviewed by Chris Dumez.
912
913         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
914         they can take as much as 15 minutes to run each.
915
916         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
917         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
918         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
919         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
920
921 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
922
923         Build fix. jetstream has a local copy, not remote archive.
924
925         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
926
927 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
928
929         run-benchmark should support SunSpider, Kraken and Octane
930         https://bugs.webkit.org/show_bug.cgi?id=144840
931
932         Reviewed by Darin Adler.
933
934         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
935         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
936         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
937         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
938
939         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
940         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
941
942         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
943         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
944
945         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
946         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
947         now has the ability to run an arbitrary "create script".
948
949         * Scripts/run-benchmark:
950         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
951         This also overrides the remote archive URL specified in the plan.
952
953         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
954
955         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
956         JetStreamBenchmarkBuilder.
957
958         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
959         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
960         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
961         _runCreateScript and _applyPatch to clean after themselves.
962         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
963         JetStream, SunSpider, Kraken all use this feature.
964         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
965         the leaf directory name since the latter is not available when a remote ZIP file is used.
966         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
967         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
968         the benchmark name in the patches.
969
970         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
971
972         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
973         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
974         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
975         the browser opens by planName as the plan file no longer contains that.
976
977         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
978         the top directory of JetStream instead of its parent.
979         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
980         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
981         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
982         the top directory of JetStream instead of its parent.
983         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
984         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
985         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
986         done in JetStream.patch.
987         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
988         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
989         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
990         path from the top directory of JetStream as done in JetStream.patch.
991         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
992
993 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
994
995         Fix run-javascriptcore-tests step on the WinCairo bot
996         https://bugs.webkit.org/show_bug.cgi?id=144866
997
998         Reviewed by Darin Adler.
999
1000         * Scripts/run-jsc-stress-tests:
1001
1002 2015-05-11  Alex Christensen  <achristensen@webkit.org>
1003
1004         [Content Extensions] Support domain-specific rules and exceptions.
1005         https://bugs.webkit.org/show_bug.cgi?id=144833
1006
1007         Reviewed by Darin Adler.
1008
1009         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1010         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1011         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1012         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1013         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
1014         (TestWebKitAPI::mainDocumentRequest):
1015         (TestWebKitAPI::subResourceRequest):
1016         (TestWebKitAPI::TEST_F):
1017         (TestWebKitAPI::checkCompilerError):
1018         Added tests for parsing and functionality of if-domain and unless-domain.
1019
1020 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1021
1022         run-benchmark should support Chrome Canary and Firefox Nightly
1023         https://bugs.webkit.org/show_bug.cgi?id=144850
1024
1025         Reviewed by Darin Adler.
1026
1027         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
1028
1029         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
1030
1031         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
1032         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
1033         (OSXBrowserDriver):
1034         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
1035         (OSXBrowserDriver.closeBrowsers): Ditto.
1036         (OSXBrowserDriver.launchProcess): Ditto.
1037         (OSXBrowserDriver.terminateProcesses): Ditto.
1038         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1039         (OSXChromeDriver): Removed the unused self.chromePreferences.
1040         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
1041         (OSXChromeDriver.closeBrowsers): Ditto.
1042         (OSXChromeDriver.launchUrl):
1043         (OSXChromeCanaryDriver): Added.
1044         (OSXChromeCanaryDriver.launchUrl):
1045         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
1046         (OSXFirefoxDriver): Added.
1047         (OSXFirefoxDriver.launchUrl):
1048         (OSXFirefoxNightlyDriver): Added.
1049         (OSXFirefoxNightlyDriver.launchUrl):
1050         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1051         (OSXSafariDriver):
1052         (OSXSafariDriver.closeBrowsers):
1053
1054 2015-05-11  Tim Horton  <timothy_horton@apple.com>
1055
1056         Page overlay action context override should indicate the source of the request
1057         https://bugs.webkit.org/show_bug.cgi?id=144832
1058         <rdar://problem/20562594>
1059
1060         Reviewed by Darin Adler.
1061
1062         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
1063         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
1064
1065 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
1066
1067         [GTK] fast/events/page-visibility-transition-test.html is timing out
1068         https://bugs.webkit.org/show_bug.cgi?id=114789
1069
1070         Reviewed by Darin Adler.
1071
1072         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1073         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
1074         requests visibility changes.
1075
1076 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
1077
1078         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
1079         https://bugs.webkit.org/show_bug.cgi?id=144798
1080
1081         Reviewed by Darin Adler.
1082
1083         * efl/install-dependencies:
1084
1085 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
1086
1087         Make arguments of run-benchmark more user friendly
1088         https://bugs.webkit.org/show_bug.cgi?id=144835
1089
1090         Reviewed by Darin Adler.
1091
1092         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
1093         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
1094         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
1095         default values from --platform and --browser as they are required arguments.
1096
1097         * Scripts/run-benchmark:
1098         (main): Made --build-directory optional, and removed default values from --platform and --browser.
1099         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
1100         are not dynamically obtained via BrowserDriverFactory.
1101         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1102         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
1103         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
1104         run any benchmark in that case.
1105         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
1106         the specified file isn't a valid relative or an absolute path.
1107         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
1108         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
1109         and browsers.
1110         (BrowserDriverFactory.available_browsers): Ditto.
1111         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1112         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
1113         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
1114         browserBuildPath was None.
1115         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1116         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
1117         so that we can use locally built WebKit to launch Safari.
1118
1119 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
1120
1121         Remove the PICTURE_SIZES build flag
1122         https://bugs.webkit.org/show_bug.cgi?id=144679
1123
1124         Reviewed by Benjamin Poulain.
1125
1126         Removed the PICTURE_SIZES build time flag.
1127
1128         * Scripts/webkitperl/FeatureList.pm:
1129
1130 2015-05-09  David Kilzer  <ddkilzer@apple.com>
1131
1132         Layout tests broke due to unexpected simctl output
1133
1134         * Scripts/webkitpy/xcode/simulator.py:
1135         (Simulator._parse_devices): Handle new Device Pairs header.
1136         * Scripts/webkitpy/xcode/simulator_unittest.py:
1137         (test_device_pairs): Add unit test for Device Pairs header.
1138
1139 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
1140
1141         Remove convenience constructors for TextRun
1142         https://bugs.webkit.org/show_bug.cgi?id=144752
1143
1144         Reviewed by Anders Carlsson.
1145
1146         Test the StringView which takes a StringImpl*.
1147
1148         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1149         (StringView8Bit): Testing is8Bit() on StringView
1150
1151 2015-05-07  Sam Weinig  <sam@webkit.org>
1152
1153         [Content Extensions] Add simple tester that takes an extension and compiles it
1154         https://bugs.webkit.org/show_bug.cgi?id=144781
1155
1156         Reviewed by Dan Bates.
1157
1158         * ContentExtensionTester: Added.
1159         * ContentExtensionTester/Configurations: Added.
1160         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
1161         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
1162         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
1163         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
1164         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
1165         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
1166         * ContentExtensionTester/main.m: Added.
1167         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
1168
1169 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
1170
1171         Build fix.
1172
1173         Reviewed by Dan Bernstein.
1174
1175         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1176         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1177         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
1178         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
1179         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1180         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1181         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
1182         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
1183
1184 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
1185
1186         [GTK] Some tests fail because they do not assume the popup menu captures click events
1187         https://bugs.webkit.org/show_bug.cgi?id=40601
1188
1189         Reviewed by Carlos Garcia Campos.
1190
1191         Popdown all attached menus when moving between tests and between each new
1192         event sent to the WebView. This prevents context and popup menus from eating
1193         events.
1194
1195         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
1196         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
1197         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1198         (WTR::dispatchEvent): Popdown all menus between dispatching events.
1199         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
1200         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
1201         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1202         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
1203         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1204         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
1205         longer in the platform-independent file.
1206         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
1207
1208 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
1209
1210         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
1211         https://bugs.webkit.org/show_bug.cgi?id=144746
1212
1213         Reviewed by Carlos Garcia Campos.
1214
1215         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
1216
1217         * MiniBrowser/gtk/main.c:
1218         (main):
1219
1220 2015-05-08  Commit Queue  <commit-queue@webkit.org>
1221
1222         Unreviewed, rolling out r183996.
1223         https://bugs.webkit.org/show_bug.cgi?id=144806
1224
1225         ASan detected use-after free (Requested by ap on #webkit).
1226
1227         Reverted changeset:
1228
1229         "Remove convenience constructors for TextRun"
1230         https://bugs.webkit.org/show_bug.cgi?id=144752
1231         http://trac.webkit.org/changeset/183996
1232
1233 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
1234
1235         Remove convenience constructors for TextRun
1236         https://bugs.webkit.org/show_bug.cgi?id=144752
1237
1238         Reviewed by Anders Carlsson.
1239
1240         Test the StringView which takes a StringImpl*.
1241
1242         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1243         (StringView8Bit): Testing is8Bit() on StringView
1244
1245 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1246
1247         [GTK] WTR doesn't correctly handle the Escape key
1248         https://bugs.webkit.org/show_bug.cgi?id=144788
1249
1250         Reviewed by Martin Robinson.
1251
1252         Correctly handle 0x001B character code in GTK+ event sender to be
1253         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
1254         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
1255         to dismiss popup menus.
1256
1257         Fixes editing/selection/5354455-1.html.
1258
1259         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1260         (WTR::getGDKKeySymForKeyRef):
1261
1262 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1263
1264         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
1265         https://bugs.webkit.org/show_bug.cgi?id=144748
1266
1267         Reviewed by Sergio Villar Senin.
1268
1269         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1270         (testWebKitSettings): Check the new setting is correctly
1271         initialized and updated.
1272         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1273         (testWebContextSecurityFileXHR): Check XHR to local files is
1274         allowed from file URLs after changing the setting.
1275         (beforeAll): Add new test.
1276
1277 2015-05-08  Commit Queue  <commit-queue@webkit.org>
1278
1279         Unreviewed, rolling out r183945.
1280         https://bugs.webkit.org/show_bug.cgi?id=144789
1281
1282         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
1283
1284         Reverted changeset:
1285
1286         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
1287         https://bugs.webkit.org/show_bug.cgi?id=144746
1288         http://trac.webkit.org/changeset/183945
1289
1290 2015-05-07  Anders Carlsson  <andersca@apple.com>
1291
1292         Build fixes.
1293
1294         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
1295         (TestWebKitAPI::TEST):
1296         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
1297         (TestWebKitAPI::TEST):
1298         Add casts.
1299
1300 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
1301
1302         GC has trouble with pathologically large array allocations
1303         https://bugs.webkit.org/show_bug.cgi?id=144609
1304
1305         Reviewed by Geoffrey Garen.
1306         
1307         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
1308         and it's a frequently requested feature.
1309         
1310         Also add the ability to run a test pretending that your system has a particular RAM size.
1311         This is useful for GC tests, and the new GC test that I added uses this.
1312
1313         * Scripts/run-javascriptcore-tests:
1314         (runJSCStressTests):
1315         * Scripts/run-jsc-stress-tests:
1316
1317 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
1318
1319         [EFL] Bump EFL version to 1.14.0
1320         https://bugs.webkit.org/show_bug.cgi?id=144743
1321
1322         Reviewed by Darin Adler.
1323
1324         Bump EFL and elementary version to 1.14.0 and removed
1325         md5sum, because it isn't used at all if hash is present.
1326
1327         * efl/jhbuild.modules:
1328
1329 2015-05-07  Saam Barati  <saambarati1@gmail.com>
1330
1331         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
1332         https://bugs.webkit.org/show_bug.cgi?id=144753
1333
1334         Reviewed by Mark Lam.
1335
1336         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1337
1338 2015-05-07  Beth Dakin  <bdakin@apple.com>
1339
1340         New force-related DOM events should fire in WK1 views
1341         https://bugs.webkit.org/show_bug.cgi?id=144663
1342         -and corresponding-
1343         rdar://problem/20281886
1344
1345         Reviewed by Sam Weinig.
1346
1347         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
1348         now. Just send nil. 
1349         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1350         (TestWebKitAPI::buildAndPerformTest):
1351
1352 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1353
1354         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
1355         https://bugs.webkit.org/show_bug.cgi?id=144746
1356
1357         Reviewed by Martin Robinson.
1358
1359         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
1360
1361         * MiniBrowser/gtk/main.c:
1362         (main):
1363
1364 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
1365
1366         Revert "Introducing the Platform Abstraction Layer (PAL)"
1367         https://bugs.webkit.org/show_bug.cgi?id=144751
1368
1369         Unreviewed.
1370
1371         PAL should be a new target inside WebCore, rather than a top-level folder.
1372
1373         * Scripts/build-webkit: Add it to build-webkit.
1374
1375 2015-05-07  Ada Chan  <adachan@apple.com>
1376
1377         Add a test for WKPageCopySessionState() with filtering.
1378         https://bugs.webkit.org/show_bug.cgi?id=144666
1379
1380         Reviewed by Darin Adler.
1381
1382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1383         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
1384         (TestWebKitAPI::didFinishLoadForFrame):
1385         (TestWebKitAPI::setPageLoaderClient):
1386         (TestWebKitAPI::filterFirstItemCallback):
1387         (TestWebKitAPI::filterAllItemsCallback):
1388         (TestWebKitAPI::createSessionStates):
1389         (TestWebKitAPI::TEST):
1390
1391 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1392
1393         iOS build fix attempt
1394
1395         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
1396
1397         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1398
1399 2015-05-06  Matt Baker  <mattbaker@apple.com>
1400
1401         Unreviewed, updated my list of email addresses.
1402
1403         * Scripts/webkitpy/common/config/contributors.json:
1404
1405 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1406
1407         Do not link tools to WebKit2.framework
1408         https://bugs.webkit.org/show_bug.cgi?id=144699
1409
1410         Unreviewed build fix.
1411
1412         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1413         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1414         These linked to WebKit2 in two ways, eliminating the other one.
1415
1416 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
1417
1418         Introducing the Platform Abstraction Layer (PAL)
1419         https://bugs.webkit.org/show_bug.cgi?id=143358
1420
1421         Reviewed by Simon Fraser.
1422
1423         * Scripts/build-webkit: Add it to build-webkit.
1424
1425 2015-05-06  Alex Christensen  <achristensen@webkit.org>
1426
1427         Fix api tests after r183877.
1428
1429         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1430         (TestWebKitAPI::TEST_F):
1431         Generate all DFAs before compiling them.
1432
1433 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
1434
1435         Do not link tools to WebKit2.framework
1436         https://bugs.webkit.org/show_bug.cgi?id=144699
1437
1438         Reviewed by Tim Horton.
1439
1440         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1442         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1443
1444 2015-05-06  Alex Christensen  <achristensen@webkit.org>
1445
1446         [Content Extensions] Test splitting NFAs by max NFA size.
1447         https://bugs.webkit.org/show_bug.cgi?id=144659
1448
1449         Reviewed by Darin Adler.
1450
1451         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1452         (TestWebKitAPI::createNFAs):
1453         (TestWebKitAPI::TEST_F):
1454         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1455         (TestWebKitAPI::createNFAs):
1456
1457 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
1458
1459         Remove the remaining vestiges of SVG feature define
1460         https://bugs.webkit.org/show_bug.cgi?id=144655
1461
1462         Reviewed by Alexey Proskuryakov.
1463
1464         * Scripts/webkitperl/FeatureList.pm:
1465
1466 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
1467
1468         Add a layout mode for computing fixed layout size from a minimum size
1469         https://bugs.webkit.org/show_bug.cgi?id=144610
1470         <rdar://problem/19790341>
1471
1472         Reviewed by Simon Fraser.
1473
1474         * MiniBrowser/mac/BrowserWindow.xib:
1475         * MiniBrowser/mac/BrowserWindowController.h:
1476         * MiniBrowser/mac/WK1BrowserWindowController.m:
1477         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
1478         * MiniBrowser/mac/WK2BrowserWindowController.m:
1479         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
1480         Add a optional toolbar item to toggle a minimum view size of 1024x0.
1481
1482 2015-05-05  Alex Christensen  <achristensen@webkit.org>
1483
1484         [Content Extensions] Release input NSString when finished copying it.
1485         https://bugs.webkit.org/show_bug.cgi?id=144642
1486
1487         Reviewed by Brian Weinstein.
1488
1489         * WebKitTestRunner/mac/TestControllerMac.mm:
1490         (WTR::TestController::platformConfigureViewForTest):
1491         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
1492
1493 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
1494
1495         Unreviewed test fix after r183798.
1496
1497         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1498         (convertToDRTLabel): Mimic behavior of Mac accessibility output
1499         so we can share results.
1500
1501 2015-05-05  Alex Christensen  <achristensen@webkit.org>
1502
1503         [Content Extensions] Use less memory to store the json input.
1504         https://bugs.webkit.org/show_bug.cgi?id=144604
1505
1506         Reviewed by Benjamin Poulain.
1507
1508         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1509         (-[ExtensionManagerWindowController add:]):
1510         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1511         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1512         * WebKitTestRunner/mac/TestControllerMac.mm:
1513         (WTR::TestController::platformConfigureViewForTest):
1514
1515 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1516
1517         Unreviewed. Make myself a WebKit reviewer.
1518
1519         * Scripts/webkitpy/common/config/contributors.json:
1520
1521 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
1522
1523         [GTK] r183783 breaks build
1524         https://bugs.webkit.org/show_bug.cgi?id=144632
1525
1526         Reviewed by Martin Robinson.
1527
1528         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
1529
1530         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1531         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1532
1533 2015-05-05  Alex Christensen  <achristensen@webkit.org>
1534
1535         [Content Extensions] Combine NFAs properly and free memory as we compile.
1536         https://bugs.webkit.org/show_bug.cgi?id=144485
1537
1538         Reviewed by Benjamin Poulain.
1539
1540         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1541         (TestWebKitAPI::TEST_F):
1542         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
1543         Added tests for deep NFAs.
1544
1545 2015-05-04  Alex Christensen  <achristensen@webkit.org>
1546
1547         [Content Extensions] Use less memory when writing byte code to file
1548         https://bugs.webkit.org/show_bug.cgi?id=144602
1549
1550         Reviewed by Darin Adler.
1551
1552         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1553
1554 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1555
1556         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
1557         https://bugs.webkit.org/show_bug.cgi?id=144541
1558
1559         Reviewed by Žan Doberšek.
1560
1561         Add a test case to WorkQueue unit test, to check that sources of
1562         asynchronous IO operations running in the WorkQueue thread are
1563         dispatched by the WorkQueue main loop.
1564
1565         * TestWebKitAPI/PlatformGTK.cmake:
1566         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
1567         (TestWebKitAPI::TEST):
1568
1569 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
1570
1571         Correct '--show-webview' option for Tiled Drawing tests
1572         https://bugs.webkit.org/show_bug.cgi?id=144621
1573
1574         Reviewed by Simon Fraser.
1575
1576         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
1577         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
1578
1579         * WebKitTestRunner/mac/TestControllerMac.mm:
1580         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
1581         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
1582
1583 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
1584
1585         Large array shouldn't be slow
1586         https://bugs.webkit.org/show_bug.cgi?id=144617
1587
1588         Reviewed by Geoffrey Garen.
1589         
1590         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
1591         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
1592         long-running. So, hash-map sort of belongs here.
1593
1594         * Scripts/run-jsc-benchmarks:
1595
1596 2015-05-04  Doug Russell  <d_russell@apple.com>
1597
1598         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
1599         https://bugs.webkit.org/show_bug.cgi?id=144489
1600
1601         Reviewed by Chris Fleizach.
1602
1603         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
1604         on the returned control.
1605         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
1606         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
1607         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
1608         Add support for setSelectedVisibleTextRange() in accessibility tests.
1609
1610         * DumpRenderTree/AccessibilityUIElement.cpp:
1611         (setSelectedVisibleTextRangeCallback):
1612         (AccessibilityUIElement::setSelectedVisibleTextRange):
1613         (AccessibilityUIElement::getJSClass):
1614         (AccessibilityUIElement::textMarkerForIndex): Deleted.
1615         * DumpRenderTree/AccessibilityUIElement.h:
1616         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1617         (AccessibilityUIElement::setSelectedVisibleTextRange):
1618         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1619         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1620         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
1621         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1622         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1623         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1624         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1625         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1626         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1627         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1628         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1629
1630 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
1631
1632         [Win] Implement the "--show-webview" option for Windows
1633         https://bugs.webkit.org/show_bug.cgi?id=144589
1634
1635         Reviewed by Alex Christensen.
1636
1637         Add another runtime flag (--show-webview) that causes DumpRenderTree
1638         to draw its view on-screen, rather than the standard offscreen mode.
1639
1640         * DumpRenderTree/win/DumpRenderTree.cpp:
1641         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
1642         (initializeGlobalsFromCommandLineOptions): Recognize the new
1643         command-line argument, and set the global 'showWebView' state if
1644         appropriate.
1645
1646 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
1647
1648         Remove dead code from TestInvocationCairo.cpp
1649         https://bugs.webkit.org/show_bug.cgi?id=144564
1650
1651         Reviewed by Gyuyoung Kim.
1652
1653         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
1654
1655         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1656         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1657
1658 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
1659
1660         [GTK] Add libnotify in gtk install-dependencies
1661         https://bugs.webkit.org/show_bug.cgi?id=144379
1662
1663         Reviewed by Csaba Osztrogonác.
1664
1665         * gtk/install-dependencies:
1666
1667 2015-05-01  Dan Bernstein  <mitz@apple.com>
1668
1669         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
1670         https://bugs.webkit.org/show_bug.cgi?id=144501
1671
1672         Reviewed by Darin Adler.
1673
1674         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1675         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
1676         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
1677         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
1678
1679 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
1680
1681         check-webkit-style fails due to system pylint
1682         https://bugs.webkit.org/show_bug.cgi?id=144360
1683
1684         Reviewed by Darin Adler.
1685
1686         Make sure that the directory containing third party autoinstalled modules
1687         is at the beginning of the search path, to avoid conflicts with other
1688         versions of the same modules installed in the system (e.g. pylint).
1689
1690         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
1691         modules directory to sys.path, instead of appending it.
1692
1693 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
1694
1695         Unreviewed, updated my list of email addresses.
1696
1697         * Scripts/webkitpy/common/config/contributors.json: Updated.
1698
1699 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
1700
1701         USE(...) macro should expect unprefixed variables
1702         https://bugs.webkit.org/show_bug.cgi?id=144454
1703
1704         Reviewed by Daniel Bates.
1705
1706         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
1707         * DumpRenderTree/config.h: Ditto.
1708         * TestWebKitAPI/config.h: Ditto.
1709
1710 2015-05-01  Basile Clement  <basile_clement@apple.com>
1711
1712         Unreviewed. Add myself as a commiter in contributors.json.
1713
1714         * Scripts/webkitpy/common/config/contributors.json:
1715
1716 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
1717
1718         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
1719         https://bugs.webkit.org/show_bug.cgi?id=144487
1720
1721         Reviewed by Ryosuke Niwa.
1722
1723         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1724         (BenchmarkRunner.merge): Fix bug.
1725         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
1726
1727 2015-05-01  Brady Eidson  <beidson@apple.com>
1728
1729         Add API to disable meta refreshes.
1730         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
1731
1732         Reviewed by Alexey Proskuryakov.
1733
1734         * DumpRenderTree/mac/DumpRenderTree.mm:
1735         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
1736
1737 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
1738
1739         Provide a runtime flag to run-webkit-tests that shows the test view
1740         https://bugs.webkit.org/show_bug.cgi?id=144079.
1741
1742         Unreviewed correction to r183651.
1743
1744         * WebKitTestRunner/TestController.cpp:
1745         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
1746         flag is included in the options dictionary passed to the PlatformWebView.
1747
1748 2015-05-01  Antti Koivisto  <antti@apple.com>
1749
1750         Remove network process load serialization code
1751         https://bugs.webkit.org/show_bug.cgi?id=144448
1752
1753         Reviewed by Alexey Proskuryakov.
1754
1755         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1756         (WTR::InjectedBundle::beginTesting):
1757         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1758         (WTR::TestRunner::setSerializeHTTPLoads):
1759         (WTR::TestRunner::dispatchPendingLoadRequests):
1760
1761 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1762
1763         [GTK] Add libhyphen-dev to the build dependencies
1764         https://bugs.webkit.org/show_bug.cgi?id=144452
1765
1766         Reviewed by Martin Robinson.
1767
1768         * gtk/install-dependencies: Added hyphen as Fedora and Arch
1769         dependencies.
1770
1771 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
1772
1773         Provide a runtime flag to run-webkit-tests that shows the test view
1774         https://bugs.webkit.org/show_bug.cgi?id=144079.
1775
1776         Reviewed by Dean Jackson.
1777
1778         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
1779         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
1780         option:
1781         
1782         --additional-drt-flag="--show-webview"
1783
1784         * DumpRenderTree/mac/DumpRenderTree.mm:
1785         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
1786         '--show-webview' flag.
1787         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
1788         * WebKitTestRunner/Options.cpp:
1789         (WTR::Options::Options):
1790         (WTR::handleOptionShowWebView):
1791         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
1792         * WebKitTestRunner/Options.h:
1793         * WebKitTestRunner/TestController.cpp:
1794         (WTR::TestController::TestController):
1795         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
1796         * WebKitTestRunner/TestController.h:
1797         (WTR::TestController::shouldShowWebView):
1798         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1799         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
1800         options dictionary. If it is true, display the web view while running the test.
1801
1802 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
1803
1804         r183355 didn't trigger Mac tests
1805         https://bugs.webkit.org/show_bug.cgi?id=144464
1806
1807         Reviewed by Simon Fraser.
1808
1809         Update badly neglected filters and unit tests.
1810
1811         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1812         (_should_file_trigger_build):
1813         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1814         (ShouldBuildTest):
1815         (ShouldBuildTest.test_should_build):
1816
1817 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1818
1819         [GTK] Add libhyphen-dev to the build dependencies
1820         https://bugs.webkit.org/show_bug.cgi?id=144452
1821
1822         Reviewed by Martin Robinson.
1823
1824         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
1825         build dependencies.
1826
1827 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
1828
1829         [GTK] Testing dictionaries are not installed automatically
1830         https://bugs.webkit.org/show_bug.cgi?id=144460
1831
1832         Reviewed by Carlos Garcia Campos.
1833
1834         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
1835
1836 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
1837
1838         Fix return code issue, check return code of safari process and dump results to log
1839         https://bugs.webkit.org/show_bug.cgi?id=144436
1840
1841         Reviewed by Ryosuke Niwa.
1842
1843         * Scripts/run-benchmark:
1844         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1845         (BenchmarkRunner.dump): Correct typo.
1846         (BenchmarkRunner.wrap): Add results to console.
1847         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
1848         (OSXSafariDriver.prepareEnv):
1849         (OSXSafariDriver.launchUrl):
1850         (OSXSafariDriver.closeBrowsers):
1851
1852 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
1853
1854         Should no longer need to worry about very old versions of Xcode
1855         https://bugs.webkit.org/show_bug.cgi?id=144437
1856
1857         Reviewed by Dan Bernstein.
1858
1859         * Scripts/check-for-exit-time-destructors:
1860         * Scripts/check-for-global-initializers:
1861         * Scripts/check-for-weak-vtables-and-externals:
1862
1863 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
1864
1865         REGRESSION(183583): [Mac] make without SDKROOT has issues
1866         https://bugs.webkit.org/show_bug.cgi?id=144431
1867
1868         Reviewed by Dan Bernstein.
1869
1870         * Makefile:
1871         * WebKitTestRunner/Makefile:
1872         Assume an empty SDKROOT means an macosx variant, so only
1873         enable settings if the SDKROOT is not empty and does not
1874         contain "macosx".
1875
1876 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
1877
1878         Expand test infrastructure to support scrolling tests
1879         https://bugs.webkit.org/show_bug.cgi?id=143684
1880         <rdar://problem/20375516>
1881
1882         Reviewed by Simon Fraser.
1883
1884         * DumpRenderTree/mac/DumpRenderTree.mm:
1885         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
1886         reset before the next test run.
1887         * WebKitTestRunner/TestController.cpp:
1888         (WTR::TestController::resetStateToConsistentValues): Ditto."
1889
1890 2015-04-29  Alex Christensen  <achristensen@webkit.org>
1891
1892         Run javascriptcore tests on Windows without cygwin
1893         https://bugs.webkit.org/show_bug.cgi?id=144419
1894
1895         Reviewed by Brent Fulgham.
1896
1897         * Scripts/run-javascriptcore-tests:
1898         (runJSCStressTests):
1899         Just call ruby, not /usr/bin/env ruby.
1900
1901 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
1902
1903         [GTK] Add --enable-shared option to LLVM to build mesa
1904         https://bugs.webkit.org/show_bug.cgi?id=144393
1905
1906         Reviewed by Martin Robinson.
1907
1908         The updated mesa requires the shared LLVM libraries.
1909         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
1910         to LLVM configure script. It will provide shared libraries in addition to static libraries.
1911
1912         * gtk/jhbuild-optional.modules:
1913
1914 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
1915
1916         [GTK] Add support for automatic hyphenation
1917         https://bugs.webkit.org/show_bug.cgi?id=44478
1918
1919         Reviewed by Carlos Garcia Campos.
1920
1921         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
1922         all systems will use the same dictionaries for testing purposes.
1923
1924 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
1925
1926         Failure when building WebKit for appletvsimulator.
1927         https://bugs.webkit.org/show_bug.cgi?id=144356
1928
1929         Reviewed by Alexey Proskuryakov.
1930
1931         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
1932         make TVOS and WatchOS behave correctly.
1933
1934         * Makefile:
1935         * WebKitTestRunner/Makefile:
1936
1937 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
1938
1939         Use-after-free when invalidating WKPageForceRepaint callback
1940         https://bugs.webkit.org/show_bug.cgi?id=144401
1941         rdar://problem/20741111
1942
1943         Reviewed by Tim Horton.
1944
1945         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
1946
1947         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
1948         Don't do anything on error, because the context may be a stale pointer now.
1949
1950 2015-04-29  David Kilzer  <ddkilzer@apple.com>
1951
1952         check-webkit-style: Don't complain about returning value from Objective-C method call in header
1953         <http://webkit.org/b/144395>
1954
1955         Reviewed by Andy Estes.
1956
1957         * Scripts/webkitpy/style/checkers/cpp.py:
1958         (check_spacing): Update regex so 'return' is ignored if it
1959         precedes the whitespace and bracket.  Change category name to
1960         'whitespace/brackets'.  Add period to error message.
1961         (CppChecker): Add 'whitespace/brackets' as a category.
1962         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1963         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
1964         'CppChecker.categories' since that's where the list lives now.
1965         (CppStyleTest.test_spacing_before_brackets): Add tests for
1966         'whitespace/brackets' issues and non-issues.
1967
1968 2015-04-29  Alex Christensen  <achristensen@webkit.org>
1969
1970         Fix WinCairo bot.
1971
1972         * Scripts/webkitdirs.pm:
1973         (determinePassedConfiguration):
1974         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
1975
1976 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
1977
1978         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
1979         https://bugs.webkit.org/show_bug.cgi?id=132159
1980
1981         Reviewed by Darin Adler.
1982
1983         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
1984         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
1985
1986         * DumpRenderTree/mac/DumpRenderTree.mm:
1987         (fontWhitelist):
1988         (adjustFonts):
1989         (createWebViewAndOffscreenWindow):
1990         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1991         (WTR::activateFonts):
1992         * WebKitTestRunner/mac/TestControllerMac.mm:
1993         (WTR::allowedFontFamilySet):
1994         (WTR::systemHiddenFontFamilySet):
1995         (WTR::generateWhitelist):
1996         (WTR::TestController::platformInitializeContext):
1997
1998 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
1999
2000         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2001         https://bugs.webkit.org/show_bug.cgi?id=144155
2002
2003         Reviewed by Andreas Kling.
2004
2005         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
2006         Make sure that test window is "visible" before each test. While there is no concrete
2007         evidence that this is the problem indeed, the behavior is consistent with what would
2008         happen for an invisible window. Also, WKTR obviously needs to do this to protect
2009         against potential buggy tests that hide the window and don't show it.
2010
2011 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2012
2013         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
2014
2015         Latest changes in the inspector UI made this test fail. We were
2016         relying that the sidebar was always visible and the first 'li'
2017         element of the inspector was the one containing the title. This is
2018         no longer true, so better use document title that is not likely
2019         to change.
2020
2021         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2022         (openRemoteDebuggingSession):
2023
2024 2015-04-29  Andres Gomez  <agomez@igalia.com>
2025
2026         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
2027
2028         * Scripts/webkitpy/common/config/contributors.json:
2029
2030 2015-04-29  Andres Gomez  <agomez@igalia.com>
2031
2032         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
2033
2034         * Scripts/webkitpy/common/config/watchlist:
2035
2036 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
2037
2038         [EFL] Allow to run the tests on the native X display
2039         https://bugs.webkit.org/show_bug.cgi?id=144247
2040
2041         Reviewed by Gyuyoung Kim.
2042
2043         Added the USE_NATIVE_XDISPLAY option for the WTR.
2044         We can select the Xorg driver if environment variable is set up before running the tests.
2045
2046         * Scripts/webkitpy/port/efl.py:
2047         (EflPort._driver_class):
2048
2049 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
2050
2051         [GTK] Add libnotify-dev in gtk install-dependencies
2052         https://bugs.webkit.org/show_bug.cgi?id=144379
2053
2054         Reviewed by Žan Doberšek.
2055
2056         * gtk/install-dependencies:
2057
2058 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
2059
2060         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
2061         https://bugs.webkit.org/show_bug.cgi?id=143001
2062
2063         Reviewed by Gyuyoung Kim.
2064
2065         * WebKitTestRunner/TestController.cpp:
2066         (WTR::shouldUseFixedLayout):
2067
2068 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
2069
2070         Increase stablility of run-benchmark script
2071         https://bugs.webkit.org/show_bug.cgi?id=144361
2072
2073         Reviewed by Ryosuke Niwa.
2074
2075         * Scripts/run-benchmark:
2076         (main):
2077         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
2078         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2079         (GenericBenchmarkBuilder.clean):
2080         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
2081         (BenchmarkRunner.__init__):
2082         (BenchmarkRunner.execute):
2083         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2084         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
2085         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
2086         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
2087         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
2088         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
2089         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
2090         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2091         (HTTPServerDriver.fetchResult):
2092         (HTTPServerDriver):
2093         (HTTPServerDriver.killServer): Add kill server interface.
2094         (HTTPServerDriver.getReturnCode): Add get return code interface.
2095         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
2096         (SimpleHTTPServerDriver.serve):
2097         (SimpleHTTPServerDriver.fetchResult):
2098         (SimpleHTTPServerDriver):
2099         (SimpleHTTPServerDriver.killServer):
2100         (SimpleHTTPServerDriver.getReturnCode):
2101         * Scripts/webkitpy/benchmark_runner/utils.py:
2102         (forceRemove): Provide python version of 'rm -rf'.
2103
2104 2015-04-28  Sam Weinig  <sam@webkit.org>
2105
2106         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
2107         https://bugs.webkit.org/show_bug.cgi?id=144363
2108
2109         Reviewed by Alex Christensen.
2110
2111         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2112         (TestWebKitAPI::createNFAs):
2113         (TestWebKitAPI::TEST_F):
2114         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2115         (TestWebKitAPI::countLiveNodes):
2116         (TestWebKitAPI::createNFAs):
2117         (TestWebKitAPI::buildDFAFromPatterns):
2118         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
2119
2120 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2121
2122         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2123         https://bugs.webkit.org/show_bug.cgi?id=144304
2124
2125         Reviewed by Geoffrey Garen.
2126
2127         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
2128         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2129         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2130
2131 2015-04-28  Commit Queue  <commit-queue@webkit.org>
2132
2133         Unreviewed, rolling out r183514.
2134         https://bugs.webkit.org/show_bug.cgi?id=144359
2135
2136         It broke cloop test bots (Requested by mcatanzaro on #webkit).
2137
2138         Reverted changeset:
2139
2140         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
2141         https://bugs.webkit.org/show_bug.cgi?id=144304
2142         http://trac.webkit.org/changeset/183514
2143
2144 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2145
2146         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2147         https://bugs.webkit.org/show_bug.cgi?id=144304
2148
2149         Reviewed by Geoffrey Garen.
2150
2151         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
2152         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
2153         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2154         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2155
2156 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2157
2158         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
2159         https://bugs.webkit.org/show_bug.cgi?id=144319
2160
2161         Reviewed by Csaba Osztrogonác.
2162
2163         * TestWebKitAPI/CMakeLists.txt:
2164         * TestWebKitAPI/PlatformEfl.cmake:
2165
2166 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
2167
2168         Fix common typo "targetting" => "targeting"
2169         https://bugs.webkit.org/show_bug.cgi?id=144349
2170
2171         Reviewed by Daniel Bates.
2172
2173         * Scripts/webkitdirs.pm:
2174         (execMacWebKitAppForDebugging):
2175
2176 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2177
2178         [GTK][jhbuild] Mesa build failure with llvm 3.6
2179         https://bugs.webkit.org/show_bug.cgi?id=144250
2180
2181         Reviewed by Žan Doberšek.
2182
2183         Bump the version of Mesa to 10.5.4
2184
2185         * gtk/jhbuild.modules:
2186
2187 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
2188
2189         Disable App Nap in WebKitTestRunner UI process
2190         https://bugs.webkit.org/show_bug.cgi?id=144308
2191
2192         Reviewed by Daniel Bates.
2193
2194         * WebKitTestRunner/mac/main.mm:
2195         (disableAppNapInUIProcess):
2196         (main):
2197
2198 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2199
2200         [GTK] Update JHBuild Mesa download directory
2201         https://bugs.webkit.org/show_bug.cgi?id=144318
2202
2203         Update the download directory of Mesa module since the previous one
2204         doesn't exist any more.
2205
2206         Reviewed by Žan Doberšek.
2207
2208         * gtk/jhbuild.modules:
2209
2210 2015-04-28  Commit Queue  <commit-queue@webkit.org>
2211
2212         Unreviewed, rolling out r183477.
2213         https://bugs.webkit.org/show_bug.cgi?id=144334
2214
2215         Roll back the Mesa dependency bump in fear of uncaught
2216         regressions while the testing bots are no-op. (Requested by
2217         zdobersek on #webkit).
2218
2219         Reverted changeset:
2220
2221         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
2222         https://bugs.webkit.org/show_bug.cgi?id=144250
2223         http://trac.webkit.org/changeset/183477
2224
2225 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2226
2227         [GTK][jhbuild] Mesa build failure with llvm 3.6
2228         https://bugs.webkit.org/show_bug.cgi?id=144250
2229
2230         Reviewed by Žan Doberšek.
2231
2232         Bump the version of Mesa to 10.5.4
2233
2234         * gtk/jhbuild.modules:
2235
2236 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
2237
2238         Add '__init__.py' and fix known bug in benchmark runner.
2239         https://bugs.webkit.org/show_bug.cgi?id=144296
2240
2241         Reviewed by Ryosuke Niwa
2242
2243         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
2244         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
2245         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2246         (BenchmarkRunner.__init__):
2247         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
2248         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
2249         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
2250
2251 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2252
2253         More build fix.
2254
2255         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2256         (-[AccessibilityNotificationHandler _notificationReceived:]):
2257         Use -objectForKey:, not array subscript.
2258
2259 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2260
2261         Catch unexpected exits in DumpRenderTree
2262         https://bugs.webkit.org/show_bug.cgi?id=144288
2263
2264         Reviewed by Tim Horton.
2265
2266         * DumpRenderTree/mac/DumpRenderTree.mm:
2267         (atexitFunction):
2268         (DumpRenderTreeMain):
2269
2270 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2271
2272         Build fix
2273
2274         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2275         (-[AccessibilityNotificationHandler _notificationReceived:]):
2276         Use -objectForKey:, not array subscript.
2277
2278 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
2279
2280         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2281         https://bugs.webkit.org/show_bug.cgi?id=144155
2282
2283         Reviewed by Tim Horton.
2284
2285         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
2286         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
2287         and we clearly don't want App Nap while testing.
2288
2289 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
2290
2291         [CMake] Autogenerate cmakeconfig.h.cmake
2292         https://bugs.webkit.org/show_bug.cgi?id=143997
2293
2294         Reviewed by Csaba Osztrogonác.
2295
2296         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
2297         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
2298
2299 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
2300
2301         REGRESSION(r182879): Images and video can no longer be downloaded
2302         https://bugs.webkit.org/show_bug.cgi?id=144267
2303         <rdar://problem/20702844>
2304
2305         Reviewed by Simon Fraser.
2306
2307         Revise tests to check for proper download menu state.
2308         1. Downloading a loal image should be disabled.
2309         2. Downloading a local media file should be disabled.
2310         3. Downloading non-downloadable media should be disabled.
2311
2312         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2313         (TestWebKitAPI::TEST):
2314
2315 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2316
2317         Merge run-launcher into run-minibrowser
2318         https://bugs.webkit.org/show_bug.cgi?id=141928
2319
2320         Reviewed by Darin Adler.
2321
2322         * Scripts/run-iexploder-tests:
2323         (runSafariWithIExploder):
2324         * Scripts/run-launcher: Removed.
2325         * Scripts/run-minibrowser:
2326         * Scripts/webkitdirs.pm:
2327         (launcherPath):
2328         * Scripts/webkitpy/port/efl.py:
2329         (EflPort.show_results_html_file):
2330         * Scripts/webkitpy/port/efl_unittest.py:
2331         (EflPortTest.test_show_results_html_file):
2332         * Scripts/webkitpy/port/gtk.py:
2333         (GtkPort.print_leaks_summary):
2334         (GtkPort.show_results_html_file):
2335         (GtkPort): Deleted.
2336         * Scripts/webkitpy/port/gtk_unittest.py:
2337         (GtkPortTest.test_show_results_html_file):
2338
2339 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2340
2341         [buildbot] Fix the output of perf-test buildstep on timeout
2342         https://bugs.webkit.org/show_bug.cgi?id=144097
2343
2344         Reviewed by Ryosuke Niwa.
2345
2346         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2347         (RunAndUploadPerfTests.getText2):
2348         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2349         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
2350         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
2351
2352 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
2353
2354         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
2355         https://bugs.webkit.org/show_bug.cgi?id=143874
2356
2357         Reviewed by Gyuyoung Kim.
2358
2359         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
2360
2361 2015-04-24  Philippe Normand  <pnormand@igalia.com>
2362
2363         [JHBuild] Move to upstream OpenWebRTC
2364         https://bugs.webkit.org/show_bug.cgi?id=144145
2365
2366         Reviewed by Carlos Garcia Campos.
2367
2368         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
2369         and add a new simple patch to gst-plugins-base, required for
2370         OpenWebRTC build.
2371         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
2372         * gtk/jhbuild.modules: Ditto.
2373         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
2374
2375 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2376
2377         [ES6] Implement ES6 template literals
2378         https://bugs.webkit.org/show_bug.cgi?id=142691
2379
2380         Reviewed by Darin Adler.
2381
2382         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
2383
2384         * Scripts/webkitperl/FeatureList.pm:
2385
2386 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2387
2388         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
2389         https://bugs.webkit.org/show_bug.cgi?id=144217
2390
2391         Reviewed by Darin Adler.
2392
2393         * WebKitTestRunner/PlatformEfl.cmake:
2394
2395 2015-04-26  Doug Russell  <d_russell@apple.com>
2396
2397         AX: richer text change notifications (142719)
2398         https://bugs.webkit.org/show_bug.cgi?id=142719
2399
2400         Reviewed by Darin Adler.
2401
2402         Richer accessibility value change notifications. Introduce AXTextEditType,
2403         postTextStateChangeNotification and postTextReplacementNotification to give assistive
2404         tech apps more reliable context for responding to changes in web content. Also implement
2405         a mechanism to post value changes in password form fields in coalesced ticks to thwart
2406         analyzing the cadence of changes.
2407
2408         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
2409         and an overload of postTextReplacementNotification to give assistive tech apps more
2410         reliable context for responding to changes in web content selection. Also block posting
2411         selection changes on password fields.
2412
2413         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
2414         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2415         (-[AccessibilityNotificationHandler stopObserving]):
2416         (-[AccessibilityNotificationHandler _notificationReceived:]):
2417         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2418         (AccessibilityUIElement::removeNotificationListener):
2419         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2420         (-[AccessibilityNotificationHandler _notificationReceived:]):
2421         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2422         (WTR::AccessibilityUIElement::removeNotificationListener):
2423
2424 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
2425
2426         Add myself to contributors.json
2427         https://bugs.webkit.org/show_bug.cgi?id=144204
2428
2429         Reviewed by Darin Adler.
2430
2431         * Scripts/webkitpy/common/config/contributors.json:
2432
2433 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
2434
2435         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
2436         https://bugs.webkit.org/show_bug.cgi?id=144182
2437
2438         Reviewed by Simon Fraser.
2439
2440         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
2441
2442 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
2443
2444         https://bugs.webkit.org/show_bug.cgi?id=144038
2445
2446         Reviewed by Ryosuke Niwa
2447
2448         Add a script to run Speedometer and JetStream on a browser.
2449
2450         * Scripts/run-benchmark: Wrapper script to run benchmark.
2451         (main):
2452         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
2453         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
2454         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
2455         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
2456         (BenchmarkBuilderFactory):
2457         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
2458         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
2459         (GenericBenchmarkBuilder):
2460         (GenericBenchmarkBuilder.prepare):
2461         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
2462         (GenericBenchmarkBuilder._applyPatch):
2463         (GenericBenchmarkBuilder.clean):
2464         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
2465         (JetStreamBenchmarkBuilder):
2466         (JetStreamBenchmarkBuilder.prepare):
2467         (JetStreamBenchmarkBuilder._runCreateScript):
2468         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
2469         (BenchmarkRunner):
2470         (BenchmarkRunner.__init__):
2471         (BenchmarkRunner.execute):
2472         (BenchmarkRunner.dump):
2473         (BenchmarkRunner.wrap):
2474         (BenchmarkRunner.merge):
2475         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
2476         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
2477         (BrowserDriver):
2478         (BrowserDriver.prepareEnv):
2479         (BrowserDriver.launchUrl):
2480         (BrowserDriver.closeBrowser):
2481         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
2482         (BrowserDriverFactory):
2483         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
2484         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
2485         (OSXChromeDriver):
2486         (OSXChromeDriver.prepareEnv):
2487         (OSXChromeDriver.launchUrl):
2488         (OSXChromeDriver.closeBrowsers):
2489         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
2490         (OSXSafariDriver):
2491         (OSXSafariDriver.prepareEnv):
2492         (OSXSafariDriver.launchUrl):
2493         (OSXSafariDriver.closeBrowsers):
2494         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
2495         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
2496         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
2497         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
2498         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
2499         (GenericFactory):
2500         (GenericFactory.iterateGetItem):
2501         (GenericFactory.create):
2502         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
2503         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
2504         (ServerControl):
2505         (ServerControl.render_GET):
2506         (ServerControl.render_POST):
2507         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
2508         (HTTPServerDriver):
2509         (HTTPServerDriver.serve):
2510         (HTTPServerDriver.fetchResult):
2511         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
2512         (HTTPServerDriverFactory):
2513         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
2514         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
2515         (SimpleHTTPServerDriver):
2516         (SimpleHTTPServerDriver.depends):
2517         (SimpleHTTPServerDriver.__init__):
2518         (SimpleHTTPServerDriver.serve):
2519         (SimpleHTTPServerDriver.baseUrl):
2520         (SimpleHTTPServerDriver.fetchResult):
2521         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
2522         (ModuleNotFoundError):
2523         (loadModule):
2524         (getPathFromProjectRoot):
2525         (loadJSONFromFile):
2526         (TimeoutError):
2527         (timeout):
2528         (timeout.__init__):
2529         (timeout.handle_timeout):
2530         (timeout.__enter__):
2531         (timeout.__exit__):
2532
2533 2015-04-24  Commit Queue  <commit-queue@webkit.org>
2534
2535         Unreviewed, rolling out r183303.
2536         https://bugs.webkit.org/show_bug.cgi?id=144181
2537
2538         Change was incorrect, broke builds (Requested by smfr on
2539         #webkit).
2540
2541         Reverted changeset:
2542
2543         "Fix the build."
2544         http://trac.webkit.org/changeset/183303
2545
2546 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
2547
2548         Fix the build.
2549
2550         * MiniBrowser/mac/WK2BrowserWindowController.m:
2551         (-[WK2BrowserWindowController initWithConfiguration:]):
2552
2553 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
2554
2555         Disable ActionMenusPDFTest due to timeout on test bot
2556
2557         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2558         (TestWebKitAPI::TEST):
2559
2560 2015-04-24  Commit Queue  <commit-queue@webkit.org>
2561
2562         Unreviewed, rolling out r183266.
2563         https://bugs.webkit.org/show_bug.cgi?id=144164
2564
2565         Broke 32-bit build and a test. (Requested by ap on #webkit).
2566
2567         Reverted changeset:
2568
2569         "AX: richer text change notifications (142719)"
2570         https://bugs.webkit.org/show_bug.cgi?id=142719
2571         http://trac.webkit.org/changeset/183266
2572
2573 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
2574
2575         REGRESSION: WebKit2.ActionMenusTest API test fails
2576         https://bugs.webkit.org/show_bug.cgi?id=144149
2577         <rdar://problem/20677770>
2578
2579         Reviewed by Tim Horton.
2580
2581         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
2582         as the 'ActionMenusPDFTest'.
2583         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2584         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
2585         to match the hit test on the 'action-menu-target.pdf' test file.
2586
2587 2015-04-24  Daniel Bates  <dabates@apple.com>
2588
2589         Cleanup: Use @memoized for property IOSSimulator.testing_device
2590         https://bugs.webkit.org/show_bug.cgi?id=141715
2591
2592         Reviewed by Darin Adler.
2593
2594         Simplify the caching of the result of IOSSimulator.testing_device
2595         and make the code more readable by making use of the @memoized declarator
2596         instead of explicitly managing a private instance variable,
2597         IOSSimulator._testing_device, for the cached result.
2598
2599         * Scripts/webkitpy/port/ios.py:
2600         (IOSPort.determine_full_port_name):
2601         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
2602         (IOSSimulatorPort):
2603         (IOSSimulatorPort.testing_device): No need to cache the created device object in
2604         IOSSimulatorPort._testing_device since we are marking this function @memoized.
2605         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
2606         of caching in local variable since we only make use of this value exactly once in this function.
2607         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
2608         been used since being added in r178622. So, we can remove this constructor since
2609         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
2610
2611 2015-04-24  Anders Carlsson  <andersca@apple.com>
2612
2613         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
2614         https://bugs.webkit.org/show_bug.cgi?id=144158
2615
2616         Reviewed by Beth Dakin.
2617
2618         * MiniBrowser/mac/WK2BrowserWindowController.m:
2619         (-[WK2BrowserWindowController initWithConfiguration:]):
2620
2621 2015-04-24  Doug Russell  <d_russell@apple.com>
2622
2623         AX: richer text change notifications (142719)
2624         https://bugs.webkit.org/show_bug.cgi?id=142719
2625
2626         Reviewed by Darin Adler.
2627
2628         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
2629
2630         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
2631
2632         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
2633         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2634         (-[AccessibilityNotificationHandler stopObserving]):
2635         (-[AccessibilityNotificationHandler _notificationReceived:]):
2636         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2637         (AccessibilityUIElement::removeNotificationListener):
2638         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2639         (-[AccessibilityNotificationHandler _notificationReceived:]):
2640         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2641         (WTR::AccessibilityUIElement::removeNotificationListener):
2642
2643 2015-04-24  Darin Adler  <darin@apple.com>
2644
2645         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
2646         https://bugs.webkit.org/show_bug.cgi?id=128007
2647
2648         Reviewed by Anders Carlsson.
2649
2650         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
2651         * DumpRenderTree/win/UIDelegate.h: Ditto.
2652
2653         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
2654         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
2655
2656         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
2657
2658         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
2659         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
2660         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
2661         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
2662         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
2663         (WebKitDOMDOMWindowTest::create): Ditto.
2664         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2665         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
2666         of smart pointers to DelayedSIgnal objects.
2667         (uriChangedCallback): Ditto.
2668
2669 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
2670
2671         [Mac] Unreviewed test fix.
2672         https://bugs.webkit.org/show_bug.cgi?id=144149
2673
2674         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2675         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
2676         test.
2677
2678 2015-04-23  Darin Adler  <darin@apple.com>
2679
2680         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
2681         https://bugs.webkit.org/show_bug.cgi?id=144090
2682
2683         Reviewed by Anders Carlsson.
2684
2685         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
2686
2687 2015-04-23  Michael Saboff  <msaboff@apple.com>
2688
2689         lldb macro btjs sometimes can't get a frame description
2690         https://bugs.webkit.org/show_bug.cgi?id=144130
2691
2692         Reviewed by Filip Pizlo.
2693
2694         We look to execute ExecState::describeFrame().  It appears that in some contexts the
2695         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
2696         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
2697
2698         * lldb/lldb_webkit.py:
2699         (btjs):
2700
2701 2015-04-23  Alex Christensen  <achristensen@webkit.org>
2702
2703         Use less memory when compiling content extensions.
2704         https://bugs.webkit.org/show_bug.cgi?id=144051
2705
2706         Reviewed by Darin Adler and Benjamin Poulain.
2707
2708         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2709         (TestWebKitAPI::TEST_F):
2710         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2711         (TestWebKitAPI::countLiveNodes):
2712
2713 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2714
2715         [CMake] Clean up JSC JIT options
2716         https://bugs.webkit.org/show_bug.cgi?id=143998
2717
2718         Reviewed by Filip Pizlo.
2719
2720         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
2721         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
2722
2723 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
2724
2725         [Mac] Extend action menus to support PDF
2726         https://bugs.webkit.org/show_bug.cgi?id=143895
2727         <rdar://problem/19003333>
2728
2729         Reviewed by Tim Horton.
2730
2731         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
2732         of PDF content works.
2733
2734         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
2735         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
2736         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
2737         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2738         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
2739         Update to support PDF tests.
2740         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
2741         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
2742
2743 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2744
2745         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
2746
2747         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2748         (beforeAll):
2749         (testWebViewAudioOnlyUserMediaPermissionRequests):
2750
2751 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2752
2753         Add myself to watchlist
2754         https://bugs.webkit.org/show_bug.cgi?id=144041
2755
2756         Reviewed by Alex Christensen.
2757
2758         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
2759
2760         * Scripts/webkitpy/common/config/watchlist:
2761
2762 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2763
2764         [GTK] MiniBrowser should use NetworkProcess by default
2765         https://bugs.webkit.org/show_bug.cgi?id=143948
2766
2767         Reviewed by Sergio Villar Senin.
2768
2769         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
2770         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
2771
2772         * MiniBrowser/gtk/main.c:
2773         (main):
2774
2775 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
2776
2777         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
2778
2779         Unreviewed build fix.
2780
2781         * Scripts/prepare-ChangeLog:
2782         (get_function_line_ranges_for_cpp):
2783         Use grep instead of any to determine if a string is an element of an array.
2784
2785 2015-04-21  Anders Carlsson  <andersca@apple.com>
2786
2787         Fix block signatures
2788         https://bugs.webkit.org/show_bug.cgi?id=144002
2789
2790         Reviewed by Andreas Kling.
2791
2792         * MiniBrowser/mac/WK2BrowserWindowController.m:
2793         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2794
2795 2015-04-21  Philippe Normand  <pnormand@igalia.com>
2796
2797         [GTK] jhbuild should not use a branch for openwebrtc
2798         https://bugs.webkit.org/show_bug.cgi?id=143981
2799
2800         Reviewed by Carlos Garcia Campos.
2801
2802         * gtk/jhbuild.modules:
2803
2804 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
2805
2806         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
2807
2808         Unreviewed build fix.
2809
2810         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
2811         However, it has been exposed by List::MoreUtils since its inception. This patch uses
2812         the any function exposed by List::MoreUtils for greater compatibility.
2813
2814         * Scripts/prepare-ChangeLog:
2815         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
2816         the any function in all of versions of Perl used by our infrastructure.
2817
2818 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2819
2820         Remove unnecessary logs when resetting tests.
2821
2822         * WebKitTestRunner/mac/TestControllerMac.mm:
2823         (WTR::TestController::platformResetPreferencesToConsistentValues):
2824         In r183020 I added some logs when compiling or removing content extensions fails.
2825         We often try to remove a content extension that does not exist, and that is not a problem.
2826
2827 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
2828
2829         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
2830         https://bugs.webkit.org/show_bug.cgi?id=143897
2831
2832         Reviewed by David Kilzer.
2833
2834         This is a speculative fix that addresses two issues:
2835
2836         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
2837         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
2838
2839         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
2840         Before: (723, 729)
2841         After: (721, 720)
2842
2843         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
2844         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
2845
2846         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
2847         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
2848
2849         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
2850
2851         2. Creating git diffs from HEAD and not origin/master by default.
2852
2853         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
2854         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
2855
2856         * Scripts/prepare-ChangeLog:
2857         (originalFile):
2858         Use HEAD instead of origin/master in default Git case.
2859
2860         (generateFunctionLists):
2861         Ensure that the end line is not less than the start line.
2862
2863         (extractLineRangeAfterChange):
2864         Set the end line to the start line if the end line is less than the start line.
2865
2866         (extractLineRangeBeforeChange):
2867         Ditto.
2868
2869 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
2870
2871         Suppress warning in prepare-ChangeLog.
2872         https://bugs.webkit.org/show_bug.cgi?id=143882
2873
2874         Reviewed by David Kilzer.
2875
2876         Prune noisy prepare-ChangeLog output by using the List::Util::any function
2877         instead of the deprecated smartmatch operator.
2878
2879         * Scripts/prepare-ChangeLog:
2880         Import the List::Util::any function.
2881
2882         (get_function_line_ranges_for_cpp):
2883         Use the any function instead of smartmatch.
2884
2885 2015-04-20  Anders Carlsson  <andersca@apple.com>
2886
2887         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
2888         https://bugs.webkit.org/show_bug.cgi?id=143966
2889
2890         Reviewed by Dan Bernstein.
2891
2892         * MiniBrowser/mac/WK2BrowserWindowController.m:
2893         (dataTypes):
2894         (-[WK2BrowserWindowController fetchWebsiteData:]):
2895         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2896         (-[WK2BrowserWindowController clearWebsiteData:]):
2897
2898 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2899
2900         Fix content extension test flakiness.
2901         https://bugs.webkit.org/show_bug.cgi?id=143950
2902
2903         Reviewed by Brady Eidson.
2904
2905         * WebKitTestRunner/mac/TestControllerMac.mm:
2906         (WTR::TestController::platformResetPreferencesToConsistentValues):
2907         Remove the TestContentExtensions if it exists.
2908         (WTR::TestController::platformConfigureViewForTest):
2909         Log errors in case there are any.
2910
2911 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2912
2913         Properly report errors from _WKUserContentExtensionStore.
2914         https://bugs.webkit.org/show_bug.cgi?id=143808
2915
2916         Reviewed by Darin Adler.
2917
2918         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
2919         (TEST_F):
2920
2921 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2922
2923         Add a rule for NetworkCache to watchlist file
2924         https://bugs.webkit.org/show_bug.cgi?id=143945
2925
2926         Reviewed by Sergio Villar Senin.
2927
2928         And add myself to the list of watchers.
2929
2930         * Scripts/webkitpy/common/config/watchlist:
2931
2932 2015-04-19  Darin Adler  <darin@apple.com>
2933
2934         Update RefPtr documentation and deprecation
2935         https://bugs.webkit.org/show_bug.cgi?id=143936
2936
2937         Reviewed by Andreas Kling.
2938
2939         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
2940
2941 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2942
2943         Introduce bytecode intrinsics
2944         https://bugs.webkit.org/show_bug.cgi?id=143926
2945
2946         Reviewed by Filip Pizlo.
2947
2948         Change cpplint to accept emit_intrinsic_XXX.
2949
2950         * Scripts/webkitpy/style/checkers/cpp.py:
2951         (check_identifier_name_in_declaration):
2952
2953 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
2954
2955         Fix lldb_webkit.py to show StringImpls correctly
2956         https://bugs.webkit.org/show_bug.cgi?id=143920
2957
2958         Reviewed by Andreas Kling.
2959         
2960         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
2961
2962         * lldb/lldb_webkit.py:
2963         (WTFStringImplProvider.is_8bit):
2964
2965 2015-04-17  Daniel Bates  <dabates@apple.com>
2966
2967         Not able to build WebKit against iOS Simulator 8.3 SDK
2968         https://bugs.webkit.org/show_bug.cgi?id=143883
2969
2970         Reviewed by David Kilzer.
2971
2972         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
2973         so that Xcode uses them.
2974
2975         * Scripts/copy-webkitlibraries-to-product-directory:
2976
2977 2015-04-17  Beth Dakin  <bdakin@apple.com>
2978
2979         Force mouse events should go through normal mouse event handling code paths
2980         https://bugs.webkit.org/show_bug.cgi?id=143749
2981         -and corresponding-
2982         rdar://problem/20472895
2983
2984         Reviewed by Dean Jackson.
2985
2986         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
2987         Since there is not a way to create an NSEventTypePressure from scratch, we 
2988         subclass NSEvent and override all of the critical methods.
2989
2990         * WebKitTestRunner/EventSenderProxy.h:
2991         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2992         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2993         (WTR::EventSendingController::mouseForceDown):
2994         (WTR::EventSendingController::mouseForceUp):
2995         (WTR::EventSendingController::mouseForceChanged):
2996         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2997         * WebKitTestRunner/TestController.cpp:
2998         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2999         * WebKitTestRunner/mac/EventSenderProxy.mm:
3000         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3001         (-[EventSenderPressureEvent timestamp]):
3002         (-[EventSenderPressureEvent type]):
3003         (-[EventSenderPressureEvent locationInWindow]):
3004         (-[EventSenderPressureEvent location]):
3005         (-[EventSenderPressureEvent stage]):
3006         (-[EventSenderPressureEvent pressure]):
3007         (-[EventSenderPressureEvent phase]):
3008         (-[EventSenderPressureEvent eventNumber]):
3009         (WTR::EventSenderProxy::mouseForceDown):
3010         (WTR::EventSenderProxy::mouseForceUp):
3011         (WTR::EventSenderProxy::mouseForceChanged):
3012
3013 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
3014
3015         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
3016         https://bugs.webkit.org/show_bug.cgi?id=143885
3017
3018         Reviewed by Tim Horton.
3019
3020         Fixed a case where we have two builds with the same revision(s). An in order build
3021         is one for which the revision is strictly higher.
3022
3023         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3024         (BuildbotQueue.prototype._checkForInOrderResult):
3025         (BuildbotQueue.prototype.compareIterationsByRevisions):
3026
3027 2015-04-17  Commit Queue  <commit-queue@webkit.org>
3028
3029         Unreviewed, rolling out r182912 and r182920.
3030         https://bugs.webkit.org/show_bug.cgi?id=143881
3031
3032         Build breakage in some configurations (Requested by ap on
3033         #webkit).
3034
3035         Reverted changesets:
3036
3037         "Force mouse events should go through normal mouse event
3038         handling code paths"
3039         https://bugs.webkit.org/show_bug.cgi?id=143749
3040         http://trac.webkit.org/changeset/182912
3041
3042         http://trac.webkit.org/changeset/182920
3043
3044 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
3045
3046         [GTK] One more unreviewed fix after r182882.
3047
3048         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
3049
3050 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
3051
3052         [GTK] Unreviewed speculative clean build fix after r182882.
3053
3054         TestWebKitAPI's forwarding header generator depended on WeKit2's
3055         which generated SOUP related forwarding headers too.
3056
3057         This dependency isn't necessary and was removed by r182882 to make
3058         forwarding header generators parallelizable. But in this case
3059         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
3060         should generate SOUP related forwarding headers too similar to EFL.
3061
3062         * TestWebKitAPI/PlatformGTK.cmake:
3063         * WebKitTestRunner/PlatformGTK.cmake:
3064
3065 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3066
3067         [SOUP] Redirect to non HTTP destination is broken
3068         https://bugs.webkit.org/show_bug.cgi?id=143866
3069
3070         Reviewed by Sergio Villar Senin.
3071
3072         Add a unit test to check that redirect to a data URI works.
3073
3074         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3075         (testRedirectToDataURI):
3076         (serverCallback):
3077         (beforeAll):
3078
3079 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
3080
3081         Changes method of quitting iOS Simulator to be more correct.
3082         https://bugs.webkit.org/show_bug.cgi?id=143847
3083         <rdar://problem/20530344>
3084
3085         Reviewed by Darin Adler.
3086
3087         Fixes by addressing the app by ID rather than by name.
3088
3089         * Scripts/webkitdirs.pm:
3090         (quitIOSSimulator):
3091         * Scripts/webkitpy/port/ios.py:
3092         (IOSSimulatorPort.check_sys_deps):
3093
3094 2015-04-16  Anders Carlsson  <andersca@apple.com>
3095
3096         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
3097         https://bugs.webkit.org/show_bug.cgi?id=143844
3098
3099         Reviewed by Dan Bernstein.
3100
3101         * MiniBrowser/mac/AppDelegate.m:
3102         (-[BrowserAppDelegate newPrivateWindow:]):
3103         * MiniBrowser/mac/WK2BrowserWindowController.m:
3104         (-[WK2BrowserWindowController initWithConfiguration:]):
3105         (-[WK2BrowserWindowController fetchWebsiteData:]):
3106         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3107         (-[WK2BrowserWindowController clearWebsiteData:]):
3108
3109 2015-04-16  Alex Christensen  <achristensen@webkit.org>
3110
3111         32-bit build fix.
3112
3113         * WebKitTestRunner/mac/TestControllerMac.mm:
3114         (WTR::TestController::platformResetPreferencesToConsistentValues):
3115         (WTR::TestController::platformConfigureViewForTest):
3116         Added WK_API_ENABLED.
3117
3118 2015-04-16  Alex Christensen  <achristensen@webkit.org>
3119
3120         Removed unused WKUserContentFilterRef.
3121         https://bugs.webkit.org/show_bug.cgi?id=143852
3122
3123         Reviewed by Sam Weinig.
3124
3125         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
3126         * WebKitTestRunner/mac/TestControllerMac.mm:
3127         (WTR::TestController::platformResetPreferencesToConsistentValues):
3128         (WTR::TestController::platformConfigureViewForTest):
3129
3130 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
3131
3132         Unreviewed. Adding myself as a commiter in contributers.json.
3133
3134         * Scripts/webkitpy/common/config/contributors.json:
3135
3136 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
3137
3138         It is very hard to attach a debugger to WebProcess to debug tests
3139         https://bugs.webkit.org/show_bug.cgi?id=143837
3140
3141         Reviewed by Chris Dumez.
3142
3143         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
3144         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
3145
3146         Now it disables all timeouts in tools, as is best for debugging tests.
3147
3148         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
3149         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
3150
3151         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
3152         now has the same functionality.
3153
3154 2015-04-16  Beth Dakin  <bdakin@apple.com>
3155
3156         Force mouse events should go through normal mouse event handling code paths
3157         https://bugs.webkit.org/show_bug.cgi?id=143749
3158         -and corresponding-
3159         rdar://problem/20472895
3160
3161         Reviewed by Dean Jackson.
3162
3163         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
3164         Since there is not a way to create an NSEventTypePressure from scratch, we 
3165         subclass NSEvent and override all of the critical methods.
3166
3167         * WebKitTestRunner/EventSenderProxy.h:
3168         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3169         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3170         (WTR::EventSendingController::mouseForceDown):
3171         (WTR::EventSendingController::mouseForceUp):
3172         (WTR::EventSendingController::mouseForceChanged):
3173         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3174         * WebKitTestRunner/TestController.cpp:
3175         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3176         * WebKitTestRunner/mac/EventSenderProxy.mm:
3177         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3178         (-[EventSenderPressureEvent timestamp]):
3179         (-[EventSenderPressureEvent type]):
3180         (-[EventSenderPressureEvent locationInWindow]):
3181         (-[EventSenderPressureEvent location]):
3182         (-[EventSenderPressureEvent stage]):
3183         (-[EventSenderPressureEvent pressure]):
3184         (-[EventSenderPressureEvent phase]):
3185         (-[EventSenderPressureEvent eventNumber]):
3186         (WTR::EventSenderProxy::mouseForceDown):
3187         (WTR::EventSenderProxy::mouseForceUp):
3188         (WTR::EventSenderProxy::mouseForceChanged):
3189
3190 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
3191
3192         [EFL] Bump LLVM to version 3.6.0 on X86_64
3193         https://bugs.webkit.org/show_bug.cgi?id=143604
3194
3195         Reviewed by Gyuyoung Kim.
3196
3197         * efl/jhbuild.modules:
3198         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
3199         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
3200         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
3201         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
3202
3203 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
3204
3205         [EFL] Remove an unnecessary workaround from jhbuildrc
3206         https://bugs.webkit.org/show_bug.cgi?id=143823
3207
3208         Reviewed by Gyuyoung Kim.
3209
3210         * efl/jhbuildrc:
3211
3212 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
3213
3214         [GTK] Run forwarding headers generator unconditionally
3215         https://bugs.webkit.org/show_bug.cgi?id=143819
3216
3217         Reviewed by Carlos Garcia Campos.
3218
3219         * TestWebKitAPI/PlatformGTK.cmake:
3220         * WebKitTestRunner/PlatformGTK.cmake:
3221
3222 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3223
3224         [EFL] Add gnutls to jhbuild.module
3225         https://bugs.webkit.org/show_bug.cgi?id=143777
3226
3227         Reviewed by Csaba Osztrogonác.
3228
3229         EFL port has required at least 3.0.0 version of gnutls since r176712.
3230         However some old linux distributions don't support 3.0.0 version. Besides
3231         other projects sometimes need to use lower version of gnutls.
3232
3233         This patch supports to download gnutls through jhbuild, and use it.
3234
3235         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
3236         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
3237
3238 2015-04-15  Mark Lam  <mark.lam@apple.com>
3239
3240         Remove obsolete VMInspector debugging tool.
3241         https://bugs.webkit.org/show_bug.cgi?id=143798
3242
3243         Reviewed by Michael Saboff.
3244
3245         * TestWebKitAPI/CMakeLists.txt:
3246         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3247         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3249         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
3250
3251 2015-04-15  Jer Noble  <jer.noble@apple.com>
3252
3253         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
3254
3255         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3256
3257 2015-04-15  Jer Noble  <jer.noble@apple.com>
3258
3259         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
3260
3261         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3262         (TestWebKitAPI::TEST_F):
3263
3264 2015-04-15  Chris Dumez  <cdumez@apple.com>
3265
3266         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
3267         https://bugs.webkit.org/show_bug.cgi?id=143779
3268
3269         Reviewed by Brent Fulgham.
3270
3271         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
3272         similarly to what is done on Mac / WK1. Without this, PageCache could
3273         stay enabled after page cache tests and cause weird behaviors.
3274
3275         * DumpRenderTree/win/DumpRenderTree.cpp:
3276         (resetWebPreferencesToConsistentValues):
3277
3278 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
3279
3280         Re-enable custom dilation for antialiased fonts
3281         https://bugs.webkit.org/show_bug.cgi?id=143738
3282
3283         Reviewed by Tim Horton.
3284         
3285         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
3286         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
3287         a private WebKit pref. This pref defaults to YES, enabling the feature by default
3288         in WK1 as we do for WK2.
3289
3290         * DumpRenderTree/mac/DumpRenderTree.mm:
3291         (resetWebPreferencesToConsistentValues):
3292         * WebKitTestRunner/TestController.cpp:
3293         (WTR::TestController::resetPreferencesToConsistentValues):
3294
3295 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
3296
3297         Correct layering violation in DumpRenderTree Build
3298         https://bugs.webkit.org/show_bug.cgi?id=143732
3299
3300         Reviewed by Simon Fraser.
3301
3302         Correct a layering violation in DumpRenderTree by calling functions on the
3303         WebCoreTestSupport library, rather than attempting to work with WebCore
3304         types directly.
3305
3306         * DumpRenderTree/mac/EventSendingController.mm:
3307         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
3308         than WebCore itself.,
3309         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
3310
3311 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
3312
3313         Add a conservative DFA minimizer for the content extension matcher
3314         https://bugs.webkit.org/show_bug.cgi?id=143501
3315
3316         Reviewed by Alex Christensen.
3317
3318         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3319         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3320
3321 2015-04-14  Daniel Bates  <dabates@apple.com>
3322
3323         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
3324         https://bugs.webkit.org/show_bug.cgi?id=143693
3325         <rdar://problem/20530316>
3326
3327         Reviewed by Tim Horton.
3328
3329         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
3330         to use the fixed layout code on iOS at this time.
3331
3332         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
3333
3334 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
3335
3336         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
3337         https://bugs.webkit.org/show_bug.cgi?id=143705
3338
3339         Unreviewed change to watchlist file.
3340
3341         * Scripts/webkitpy/common/config/watchlist:
3342
3343 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
3344
3345         [EFL] favicon wasn't updated for google.com sometimes.
3346         https://bugs.webkit.org/show_bug.cgi?id=141940
3347
3348         Reviewed by Gyuyoung Kim.
3349
3350         As elm_entry_utf8_to_markup can include additional characters, parameter for the
3351         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
3352
3353         * MiniBrowser/efl/main.c:
3354         (on_url_changed):
3355
3356 2015-04-13  Tim Horton  <timothy_horton@apple.com>
3357
3358         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
3359         https://bugs.webkit.org/show_bug.cgi?id=143560
3360         <rdar://problem/16302047>
3361
3362         Reviewed by Darin Adler.
3363
3364         * MiniBrowser/mac/BrowserWindowController.h:
3365         * MiniBrowser/mac/MainMenu.xib:
3366         * MiniBrowser/mac/WK1BrowserWindowController.m:
3367         (-[WK1BrowserWindowController setScale:]):
3368         * MiniBrowser/mac/WK2BrowserWindowController.m:
3369         (viewScaleForMenuItemTag):
3370         (-[WK2BrowserWindowController setScale:]):
3371         (-[WK2BrowserWindowController validateMenuItem:]):
3372         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
3373         When in use, we resize the window so that the view fits correctly, and
3374         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
3375         layout size will not change when scaling down (but will update appropriately
3376         when the view is resized).
3377
3378 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
3379
3380         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
3381         https://bugs.webkit.org/show_bug.cgi?id=138630
3382
3383         Reviewed by Tim Horton.
3384
3385         Make sure that we always load at least one in order productive iteration.
3386
3387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3388         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
3389         is done loading at least one iteration that wasn't an out of order build.
3390         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
3391         when that's needed to check for out of order builds.
3392         (BuildbotQueue.prototype.update): Ditto.
3393         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
3394         result, and if it does not, load more iterations.
3395         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
3396         an in order iteration loaded too.
3397         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
3398         corrected to always sort loaded iterations before unloaded ones.
3399
3400 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
3401
3402         Expand test infrastructure to support scrolling tests
3403         https://bugs.webkit.org/show_bug.cgi?id=143286
3404         <rdar://problem/20375516>
3405
3406         Reviewed by Simon Fraser.
3407
3408         Extend the WK1 and WK2 test programs to support two new EventSender commands:
3409         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
3410         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
3411         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
3412         relevant rubberband, scroll, and scroll-snap animations are finished.
3413
3414         * DumpRenderTree/mac/EventSendingController.mm:
3415         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
3416         and 'monitorWheelEvents'.
3417         (+[EventSendingController webScriptNameForSelector:]): Ditto.
3418         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
3419         debugging test failures.
3420         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
3421         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
3422         function, then passes it to WebCore to be called once the test deferrals have been cleared.
3423         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
3424         'callAfterScrollingCompletes' method.
3425         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
3426         and 'monitorWheelEvents'.
3427         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3428         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
3429         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
3430         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
3431         'callAfterScrollingComplates' method.
3432         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3433
3434 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
3435
3436         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
3437         https://bugs.webkit.org/show_bug.cgi?id=143656
3438
3439         Reviewed by Darin Adler.
3440
3441         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3442         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3443
3444 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
3445
3446         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
3447         https://bugs.webkit.org/show_bug.cgi?id=142387
3448
3449         Reviewed by Carlos Garcia Campos.
3450
3451         Running mixed content is blocked by default since r181134. Updated
3452         the test case to reflect the new default settings.
3453
3454         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3455         (testInsecureContent):
3456
3457 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3458
3459         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
3460         https://bugs.webkit.org/show_bug.cgi?id=143667
3461
3462         Reviewed by Csaba Osztrogonác.
3463
3464         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
3465         since r169017. Added $hardwareConcurrencySupport for it.
3466
3467         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
3468
3469         * Scripts/webkitperl/FeatureList.pm:
3470
3471 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
3472
3473         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
3474         https://bugs.webkit.org/show_bug.cgi?id=143664
3475
3476         Reviewed by Gyuyoung Kim.
3477
3478         * Scripts/webkitperl/FeatureList.pm:
3479
3480 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3481
3482         [EFL] Enable Media Source
3483         https://bugs.webkit.org/show_bug.cgi?id=143635
3484
3485         Reviewed by Csaba Osztrogonác.
3486
3487         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
3488
3489 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
3490
3491         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
3492         https://bugs.webkit.org/show_bug.cgi?id=143646
3493
3494         Reviewed by David Kilzer.
3495
3496         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3497         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3498
3499 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
3500
3501         Use en_US spell checker for tests on Mac instead of Multilingual
3502         https://bugs.webkit.org/show_bug.cgi?id=143641
3503
3504         Reviewed by Dan Bernstein.
3505
3506         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3507         While at it, override NSUserDictionaryReplacementItems, so that user replacements
3508         cannot affect tests.
3509
3510         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
3511         Made this more like WebKit1 version.
3512
3513 2015-04-10  Tim Horton  <timothy_horton@apple.com>
3514
3515         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
3516         https://bugs.webkit.org/show_bug.cgi?id=143576
3517
3518         Reviewed by Simon Fraser.
3519
3520         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
3521         (TEST):
3522         Adopt.
3523
3524 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3525
3526         Update my email address and expertise.
3527         https://bugs.webkit.org/show_bug.cgi?id=143586
3528
3529         Unreviewed, just update my info.
3530
3531         * Scripts/webkitpy/common/config/contributors.json:
3532
3533 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
3534
3535         Flakiness Dashboard not loading insecure content if loaded with https URL
3536         https://bugs.webkit.org/show_bug.cgi?id=143570
3537
3538         Reviewed by Alexey Proskuryakov.
3539
3540         * TestResultServer/app.yaml:
3541         * TestResultServer/static-dashboards/loader.js:
3542         Switch to https scheme.
3543
3544 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
3545
3546         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
3547         https://bugs.webkit.org/show_bug.cgi?id=142907
3548
3549         Reviewed by Carlos Garcia Campos.
3550
3551         * TestWebKitAPI/PlatformEfl.cmake:
3552         * TestWebKitAPI/PlatformGTK.cmake:
3553         * WebKitTestRunner/PlatformEfl.cmake:
3554         * WebKitTestRunner/PlatformGTK.cmake:
3555
3556 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
3557
3558         [Mac] Unreviewed test fix after r182584
3559         https://bugs.webkit.org/show_bug.cgi?id=143452
3560
3561         Put both of these tests back to their original state now that the underlying
3562         problem is fixed.
3563
3564         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
3565         (TestWebKitAPI::TEST):
3566         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3567         (TestWebKitAPI::TEST):
3568
3569 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
3570
3571         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
3572         https://bugs.webkit.org/show_bug.cgi?id=143553
3573
3574         Reviewed by Ryosuke Niwa.
3575         
3576         Remove the spurious printVMs left over from an earlier change.
3577
3578         * Scripts/run-jsc-benchmarks:
3579
3580 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
3581
3582         [Mac] Unreviewed test fix after r182581
3583
3584         The behavior of control-left-click is controlled by a system preference.
3585         Our test bots have this turned off.
3586
3587         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
3588         (TestWebKitAPI::TEST):
3589         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3590         (TestWebKitAPI::TEST):
3591
3592 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
3593
3594         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
3595         https://bugs.webkit.org/show_bug.cgi?id=143452
3596         <rdar://problem/20437483>
3597
3598         Reviewed by Tim Horton.
3599
3600         Add a new API test to confirm that Cocoa mouse button press events are properly
3601         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
3602
3603         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
3604         some registered event handlers that the expected button press and context menu
3605         events are received.
3606
3607         The WK1 unit test creates an NSEvent with the desired button press state, and then
3608         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
3609         We check the resulting PlatformMouseEvent for proper state.
3610
3611         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
3612         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
3613         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
3614         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
3615         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
3616         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
3617         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
3618         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3619         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
3620         mouse down events.
3621         * TestWebKitAPI/mac/PlatformWebViewMac.h:
3622
3623 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
3624
3625         [GTK] Add pango to jhbuild-optional.modules
3626         https://bugs.webkit.org/show_bug.cgi?id=143537
3627
3628         Reviewed by Martin Robinson.
3629
3630         * gtk/jhbuild-optional.modules: Add pango.
3631
3632 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3633
3634         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
3635         https://bugs.webkit.org/show_bug.cgi?id=143530
3636
3637         Reviewed by Žan Doberšek.
3638
3639         Assume that the default value for display (:0) is reserved and start checking on :1
3640         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
3641         and for X server named Xorg.bin (previous bug 1376599)
3642
3643         * Scripts/webkitpy/port/xvfbdriver.py:
3644         (XvfbDriver._next_free_display)
3645         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3646         (XvfbDriverTest.test_start_no_pixel_tests):
3647         (XvfbDriverTest.test_start_pixel_tests):
3648         (XvfbDriverTest.test_start_arbitrary_worker_number):
3649         (XvfbDriverTest.test_next_free_display):
3650         (XvfbDriverTest.test_start_next_worker):
3651 2015-04-08  Alex Christensen  <achristensen@webkit.org>
3652
3653         Block popups from content extensions.
3654         https://bugs.webkit.org/show_bug.cgi?id=143497
3655
3656         Reviewed by Brady Eidson.
3657
3658         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3659         (TestWebKitAPI::TEST_F):
3660         Added popup test.
3661
3662 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
3663
3664         Add CMake build system for WinCairo port.
3665         https://bugs.webkit.org/show_bug.cgi?id=115944
3666
3667         Reviewed by Chris Dumez.
3668
3669         * CMakeLists.txt:
3670         * WinLauncher/CMakeLists.txt: Added.
3671
3672 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3673
3674         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
3675         https://bugs.webkit.org/show_bug.cgi?id=143521
3676
3677         Reviewed by Martin Robinson.
3678
3679         Add a way to detect unexpected web process crashes to WebViewTest,
3680         and a test case to testDOMCache to trigger the crash.
3681
3682         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3683         (WebKitDOMNodeTest::testDOMCache):
3684         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3685         (testWebKitWebViewProcessCrashed):
3686         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3687         (WebViewTest::WebViewTest):
3688         (WebViewTest::webProcessCrashed):
3689         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3690
3691 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
3692
3693         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
3694         rdar://problem/20461342
3695
3696         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3697
3698 2015-04-07  Commit Queue  <commit-queue@webkit.org>
3699
3700         Unreviewed, rolling out r182511.
3701         https://bugs.webkit.org/show_bug.cgi?id=143507
3702
3703         caused debug test failures (Requested by alexchristensen on
3704         #webkit).
3705
3706         Reverted changeset:
3707
3708         "Block popups from content extensions."
3709         https://bugs.webkit.org/show_bug.cgi?id=143497
3710         http://trac.webkit.org/changeset/182511
3711
3712 2015-04-07  Alex Christensen  <achristensen@webkit.org>
3713
3714         Block popups from content extensions.
3715         https://bugs.webkit.org/show_bug.cgi?id=143497
3716
3717         Reviewed by Brady Eidson.
3718
3719         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3720         (TestWebKitAPI::TEST_F):
3721         Added popup test.
3722
3723 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
3724
3725         Get the features.json files ready for open contributions
3726         https://bugs.webkit.org/show_bug.cgi?id=143436
3727
3728         Reviewed by Darin Adler.
3729
3730         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3731         (JSONFeaturesChecker.check):
3732         Extend the syntax checking a bit, but leave everything non-mandatory
3733         very loose until we figure what fields are important.
3734
3735 2015-04-07  Tim Horton  <timothy_horton@apple.com>
3736
3737         Expose and test fixedLayoutSize via modern WebKit SPI
3738         https://bugs.webkit.org/show_bug.cgi?id=143500
3739
3740         Reviewed by Simon Fraser.
3741
3742         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3743         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
3744         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
3745         (TEST):
3746         Add a test that verifies that fixedLayoutSize works at all, that
3747         it persists through a navigation, and that turning it back off reverts to
3748         laying out at the size of the view.
3749
3750 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3751
3752         Unreviewed. Add myself as a committer.
3753
3754         * Scripts/webkitpy/common/config/contributors.json:
3755
3756 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
3757
3758         [Win] Bots complain about missing /etc/catalog
3759         https://bugs.webkit.org/show_bug.cgi?id=143484
3760
3761         Reviewed by Chris Dumez.
3762
3763         The libxml2 build on Mac, iOS, and Windows does not provide the set
3764         of default catalog files. We do not actually need these for our
3765         purposes, but we get warnings and some bot flakiness because they
3766         are not present.
3767
3768         We can avoid both problems the same way the Mac and iOS ports do,
3769         by setting the XML_CATALOG_FILES environment variable to 'empty string',
3770         which avoid the warnings and bot problems.
3771
3772         * Scripts/webkitpy/port/win.py:
3773         (WinPort.setup_environ_for_server): Added.
3774
3775 2015-04-06  Sam Weinig  <sam@webkit.org>
3776
3777         Use content extensions in MiniBrowser.
3778         https://bugs.webkit.org/show_bug.cgi?id=143446
3779
3780         Reviewed by Alex Christensen.
3781
3782         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3783         * MiniBrowser/mac/AppDelegate.h:
3784         * MiniBrowser/mac/AppDelegate.m:
3785         (-[BrowserAppDelegate init]):
3786         (-[BrowserAppDelegate showExtensionsManager:]):
3787         (-[BrowserAppDelegate userContentContoller]):
3788         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
3789         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
3790         (-[ExtensionManagerWindowController init]):
3791         (-[ExtensionManagerWindowController windowDidLoad]):
3792         (-[ExtensionManagerWindowController add:]):
3793         (-[ExtensionManagerWindowController remove:]):
3794         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
3795         * MiniBrowser/mac/MainMenu.xib:
3796
3797 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3798
3799         web-platform-tests server should retrieve the modules file relatively to its docroot path
3800         https://bugs.webkit.org/show_bug.cgi?id=142742
3801
3802         Reviewed by Darin Adler.
3803
3804         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3805         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
3806
3807 2015-04-06  Commit Queue  <commit-queue@webkit.org>
3808
3809         Unreviewed, rolling out r182445.
3810         https://bugs.webkit.org/show_bug.cgi?id=143459
3811
3812         broke 32 bit build (Requested by alexchristensen on #webkit).
3813
3814         Reverted changeset:
3815
3816         "Use content extensions in MiniBrowser."
3817         https://bugs.webkit.org/show_bug.cgi?id=143446
3818         http://trac.webkit.org/changeset/182445
3819
3820 2015-04-06  Sam Weinig  <sam@webkit.org>
3821
3822         Use content extensions in MiniBrowser.
3823         https://bugs.webkit.org/show_bug.cgi?id=143446
3824
3825         Reviewed by Alex Christensen.
3826
3827         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3828         * MiniBrowser/mac/AppDelegate.h:
3829         * MiniBrowser/mac/AppDelegate.m:
3830         (-[BrowserAppDelegate init]):
3831         (-[BrowserAppDelegate showExtensionsManager:]):
3832         (-[BrowserAppDelegate userContentContoller]):
3833         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
3834         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
3835         (-[ExtensionManagerWindowController init]):
3836         (-[ExtensionManagerWindowController windowDidLoad]):
3837         (-[ExtensionManagerWindowController add:]):
3838         (-[ExtensionManagerWindowController remove:]):
3839         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
3840         * MiniBrowser/mac/MainMenu.xib:
3841
3842 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
3843
3844         [GTK] install-dependencies should prefer dnf to yum
3845         https://bugs.webkit.org/show_bug.cgi?id=143441
3846
3847         Reviewed by Martin Robinson.
3848
3849         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
3850
3851         * gtk/install-dependencies:
3852
3853 2015-04-06  Andy Estes  <aestes@apple.com>
3854
3855         [iOS] 'make clean' fails in Tools/WebKitTestRunner
3856         https://bugs.webkit.org/show_bug.cgi?id=143455
3857
3858         Reviewed by Dan Bernstein.
3859
3860         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
3861         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
3862
3863         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
3864
3865 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
3866
3867         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
3868         https://bugs.webkit.org/show_bug.cgi?id=143450
3869
3870         Reviewed by Anders Carlsson.
3871
3872         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
3873         Make sure that the view is actually closed, regardless of anything else that happens beneath.
3874         Also, removed unnecessary get() calls.
3875
3876 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
3877
3878         Reduce the dependency on Flash in regression tests
3879         https://bugs.webkit.org/show_bug.cgi?id=143391
3880
3881         Reviewed by Anders Carlsson.
3882
3883         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
3884         Only allow QuickTime and the test plug-in.
3885
3886 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3887
3888         W3C test importer should generate the modules installed dynamically to run wpt tests
3889         https://bugs.webkit.org/show_bug.cgi?id=142738
3890
3891         Reviewed by Ryosuke Niwa.
3892
3893         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
3894         The implementation is done within TestDownloader and it is activated for the WPT repository.
3895         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
3896
3897         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3898         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
3899         * Scripts/webkitpy/w3c/test_downloader.py:
3900         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
3901         (TestDownloader):
3902         (TestDownloader._git_submodules_description): Computes submodule description.
3903         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
3904         * Scripts/webkitpy/w3c/test_importer.py:
3905         (TestImporter.do_import): Added the possibility to post process the tests.
3906         (TestImporter):
3907         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
3908         (TestImporter.should_convert_test_harness_links): Updated according new options format.
3909         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3910         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
3911         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
3912         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
3913         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
3914         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
3915
3916 2015-04-05  Antti Koivisto  <antti@apple.com>
3917
3918         Bloom filter should support longer hashes
3919         https://bugs.webkit.org/show_bug.cgi?id=143419
3920
3921         Reviewed by Dan Bernstein.
3922
3923         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
3924         (TestWebKitAPI::generateRandomDigests):
3925         (TestWebKitAPI::TEST):
3926
3927 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
3928
3929         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
3930         https://bugs.webkit.org/show_bug.cgi?id=143372
3931
3932         Reviewed by Darin Adler.
3933
3934         * Scripts/run-jsc-stress-tests:
3935
3936 2015-04-03  Antti Koivisto  <antti@apple.com>
3937
3938         Add non-counting bloom filter class
3939         https://bugs.webkit.org/show_bug.cgi?id=143366
3940
3941         Reviewed by Sam Weinig.
3942
3943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3944         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
3945         (TestWebKitAPI::generateRandomHashes):
3946         (TestWebKitAPI::TEST):
3947
3948 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
3949
3950         FTL JIT tests should fail if LLVM library isn't available
3951         https://bugs.webkit.org/show_bug.cgi?id=143374
3952
3953         Reviewed by Mark Lam.
3954
3955         * Scripts/run-jsc-stress-tests:
3956
3957 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
3958
3959         [EFL] Speedup jhbuild with disable running autogen.sh
3960         https://bugs.webkit.org/show_bug.cgi?id=143369
3961
3962         Reviewed by Gyuyoung Kim.
3963
3964         * efl/jhbuild.modules:
3965
3966 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
3967
3968         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
3969         https://bugs.webkit.org/show_bug.cgi?id=143282
3970
3971         Reviewed by Daniel Bates.
3972
3973         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
3974
3975 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
3976
3977         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
3978         https://bugs.webkit.org/show_bug.cgi?id=143240
3979         rdar://problem/19990425
3980
3981         Reviewed by Tim Horton.
3982
3983         * DumpRenderTree/mac/LayoutTestHelper.m:
3984         (colorProfileURLForDisplay):
3985         (saveDisplayColorProfiles):
3986         Gracefully handle it when the current profile cannot be retrieved, fixing at
3987         least one case when LayoutTestHelper couldn't start.
3988
3989         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3990         (Manager._set_up_run):
3991         (Manager._force_pixel_tests_if_needed):
3992         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
3993         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
3994         Return and check an error from start_helper().
3995
3996 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
3997
3998         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
3999         https://bugs.webkit.org/show_bug.cgi?id=143321
4000
4001         Reviewed by Alexey Proskuryakov.
4002
4003         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
4004
4005 2015-04-01  Enrica Casucci  <enrica@apple.com>
4006
4007         Injected bundle messages should be at the page level.
4008         https://bugs.webkit.org/show_bug.cgi?id=143283
4009
4010         Reviewed by Alexey Proskuryakov.
4011
4012         Updating WebKitTestRunner to use the new page level messaging.
4013         The author of this patch is Tim Horton, I just finished it.
4014
4015         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4016         (WTR::EventSendingController::mouseDown):
4017         (WTR::EventSendingController::mouseUp):
4018         (WTR::EventSendingController::mouseMoveTo):
4019         (WTR::EventSendingController::leapForward):
4020         (WTR::EventSendingController::scheduleAsynchronousClick):
4021         (WTR::EventSendingController::keyDown):
4022         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
4023         (WTR::EventSendingController::mouseScrollBy):
4024         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
4025         (WTR::EventSendingController::continuousMouseScrollBy):
4026         (WTR::EventSendingController::addTouchPoint):
4027         (WTR::EventSendingController::updateTouchPoint):
4028         (WTR::EventSendingController::setTouchModifier):
4029         (WTR::EventSendingController::setTouchPointRadius):
4030         (WTR::EventSendingController::touchStart):
4031         (WTR::EventSendingController::touchMove):
4032         (WTR::EventSendingController::touchEnd):
4033         (WTR::EventSendingController::touchCancel):
4034         (WTR::EventSendingController::clearTouchPoints):
4035         (WTR::EventSendingController::releaseTouchPoint):
4036         (WTR::EventSendingController::cancelTouchPoint):
4037         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4038         (WTR::InjectedBundle::didReceiveMessage):
4039         (WTR::InjectedBundle::didReceiveMessageToPage):
4040         (WTR::InjectedBundle::done):
4041         (WTR::InjectedBundle::outputText):
4042         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
4043         (WTR::InjectedBundle::postAddChromeInputField):
4044         (WTR::InjectedBundle::postRemoveChromeInputField):
4045         (WTR::InjectedBundle::postFocusWebView):
4046         (WTR::InjectedBundle::postSetBackingScaleFactor):
4047         (WTR::InjectedBundle::postSetWindowIsKey):
4048         (WTR::InjectedBundle::postSimulateWebNotificationClick):
4049         (WTR::InjectedBundle::postSetAddsVisitedLinks):
4050         (WTR::InjectedBundle::setGeolocationPermission):
4051         (WTR::InjectedBundle::setMockGeolocationPosition):
4052         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
4053         (WTR::InjectedBundle::setUserMediaPermission):
4054         (WTR::InjectedBundle::setCustomPolicyDelegate):
4055         (WTR::InjectedBundle::setHidden):
4056         (WTR::InjectedBundle::setCacheModel):
4057         (WTR::InjectedBundle::shouldProcessWorkQueue):
4058         (WTR::InjectedBundle::processWorkQueue):
4059         (WTR::InjectedBundle::queueBackNavigation):
4060         (WTR::InjectedBundle::queueForwardNavigation):
4061         (WTR::InjectedBundle::queueLoad):
4062         (WTR::InjectedBundle::queueLoadHTMLString):
4063         (WTR::InjectedBundle::queueReload):
4064         (WTR::InjectedBundle::queueLoadingScript):
4065         (WTR::InjectedBundle::queueNonLoadingScript):
4066         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4067         (WTR::TestRunner::setHandlesAuthenticationChallenges):
4068         (WTR::TestRunner::setAuthenticationUsername):
4069         (WTR::TestRunner::setAuthenticationPassword):
4070         (WTR::TestRunner::secureEventInputIsEnabled):
4071         (WTR::TestRunner::setBlockAllPlugins):
4072         * WebKitTestRunner/TestController.cpp:
4073         (WTR::TestController::createWebViewWithOptions):
4074         (WTR::TestController::resetStateToConsistentValues):
4075         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
4076         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
4077         * WebKitTestRunner/TestController.h:
4078         * WebKitTestRunner/TestInvocation.cpp:
4079         (WTR::TestInvocation::invoke):
4080         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4081
4082 2015-04-01  Commit Queue  <commit-queue@webkit.org>
4083
4084         Unreviewed, rolling out r182174 and r182177.
4085         https://bugs.webkit.org/show_bug.cgi?id=143314
4086
4087         Try to correct EWS failures (Requested by bfulgham on
4088         #webkit).
4089
4090         Reverted changesets:
4091
4092         "Python SCM should be able to retrieve untracked files"
4093         https://bugs.webkit.org/show_bug.cgi?id=143135
4094         http://trac.webkit.org/changeset/182174
4095
4096         "[buildbot] clean-build script should remove untracked files
4097         and revert local changes too"
4098         https://bugs.webkit.org/show_bug.cgi?id=142400
4099         http://trac.webkit.org/changeset/182177
4100
4101 2015-04-01  Alex Christensen  <achristensen@webkit.org>
4102
4103         [Content Extensions] Properly handle regexes that match everything.
4104         https://bugs.webkit.org/show_bug.cgi?id=143281
4105
4106         Reviewed by Benjamin Poulain.
4107
4108         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4109         (TestWebKitAPI::testRequest):
4110         (TestWebKitAPI::makeBackend):
4111         (TestWebKitAPI::TEST_F):
4112         Removed duplicate code and added test.
4113
4114 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
4115
4116         Content Extensions: split the state machines to minimize prefix states
4117         https://bugs.webkit.org/show_bug.cgi?id=143253
4118
4119         Reviewed by Alex Christensen.
4120
4121         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4122         (TestWebKitAPI::TEST_F):
4123         (TestWebKitAPI::testPatternStatus):
4124
4125 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
4126
4127         Clean up Identifier factories to clarify the meaning of StringImpl*
4128         https://bugs.webkit.org/show_bug.cgi?id=143146
4129
4130         Reviewed by Filip Pizlo.
4131
4132         Simple API tests for StringImpl are added.
4133
4134         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4135         (TestWebKitAPI::TEST):
4136
4137 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
4138
4139         [EFL] Add AArch64 builder and tester bot to build.webkit.org
4140         https://bugs.webkit.org/show_bug.cgi?id=143092
4141
4142         Reviewed by Gyuyoung Kim.
4143
4144         * BuildSlaveSupport/build.webkit.org-config/config.json:
4145         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4146         (Factory.__init__):
4147         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4148
4149 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4150
4151         [buildbot] clean-build script should remove untracked files and revert local changes too
4152         https://bugs.webkit.org/show_bug.cgi?id=142400
4153
4154         Reviewed by Ryosuke Niwa.
4155
4156         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
4157         A helper routine SCM.discard_untracked_files is added for that purpose.
4158
4159         * BuildSlaveSupport/clean-build:
4160         (main): Making call to Scripts/clean-webkit
4161         * Scripts/clean-webkit: Added.
4162         (main): Revert changes and delete untracked files.
4163         * Scripts/webkitpy/common/checkout/scm/scm.py:
4164         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
4165         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4166         (SCMTest._shared_test_discard_untracked_files):
4167         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
4168
4169 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4170
4171         Python SCM should be able to retrieve untracked files
4172         https://bugs.webkit.org/show_bug.cgi?id=143135
4173
4174         Reviewed by Ryosuke Niwa.
4175
4176         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
4177         Ignored files may be included or not in this list according boolean passed to the function.
4178
4179         * Scripts/webkitpy/common/checkout/scm/git.py:
4180         (Git.untracked_files):
4181         * Scripts/webkitpy/common/checkout/scm/scm.py:
4182         (SCM.untracked_files):
4183         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4184         (SCMTest._shared_test_untracked_files):
4185         (test_untracked_files):
4186         (GitSVNTest.test_untracked_files):
4187         * Scripts/webkitpy/common/checkout/scm/svn.py:
4188         (SVN.untracked_files):
4189
4190 2015-03-30  Alex Christensen  <achristensen@webkit.org>
4191
4192         [Content Extensions] Correctly handle regular expressions matching everything
4193         https://bugs.webkit.org/show_bug.cgi?id=143235
4194
4195         Reviewed by Benjamin Poulain.
4196
4197         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4198         (TestWebKitAPI::checkCompilerError):
4199         (TestWebKitAPI::TEST_F):
4200         Test ContentExtensionErrors.
4201
4202 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
4203
4204         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
4205         https://bugs.webkit.org/show_bug.cgi?id=143241
4206         rdar://problem/20351297
4207
4208         Reviewed by Mark Lam.
4209
4210         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
4211
4212 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4213
4214         [CMake][EFL] Remove redundant library link and include path
4215         https://bugs.webkit.org/show_bug.cgi?id=143221
4216
4217         Reviewed by Csaba Osztrogonác.
4218
4219         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
4220
4221 2015-03-30  Sam Weinig  <sam@webkit.org>
4222
4223         [Content Extensions] Flesh out the UserContentExtensionStore
4224         https://bugs.webkit.org/show_bug.cgi?id=143123
4225
4226         Reviewed by Benjamin Poulain.
4227
4228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4229         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
4230         Add tests for _WKUserContentExtensionStore.
4231
4232 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
4233
4234         Update install-dependencies Fedora packages after r181624
4235         https://bugs.webkit.org/show_bug.cgi?id=143215
4236
4237         Add json-glib, libv4l, openssl and pulseaudio development packages to
4238         the Fedora list providing we need them to build WebKit dependencies
4239         for this distribution.
4240
4241         Reviewed by Philippe Normand.
4242
4243         * gtk/install-dependencies:
4244
4245 2015-03-30  Commit Queue  <commit-queue@webkit.org>
4246
4247         Unreviewed, rolling out r182119.
4248         https://bugs.webkit.org/show_bug.cgi?id=143196
4249
4250         problem with syntax (Requested by youenn on #webkit).
4251
4252         Reverted changeset:
4253
4254         "[buildbot] clean-build script should remove untracked files
4255         and revert local changes too"
4256         https://bugs.webkit.org/show_bug.cgi?id=142400
4257         http://trac.webkit.org/changeset/182119
4258
4259 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
4260
4261         Start the features.json files
4262         https://bugs.webkit.org/show_bug.cgi?id=143207
4263
4264         Reviewed by Darin Adler.
4265
4266         I kept the style checking light. We'll have to figure
4267         what is the best format for each field.
4268
4269         * Scripts/webkitpy/style/checker.py:
4270         (CheckerDispatcher._create_checker):
4271         * Scripts/webkitpy/style/checkers/jsonchecker.py:
4272         (JSONContributorsChecker.check):
4273         (JSONFeaturesChecker):
4274         (JSONFeaturesChecker.check):
4275
4276 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4277
4278         [buildbot] clean-build script should remove untracked files and revert local changes too
4279         https://bugs.webkit.org/show_bug.cgi?id=142400
4280
4281         Reviewed by Ryosuke Niwa.
4282
4283         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
4284
4285         * BuildSlaveSupport/clean-build:
4286         (main): Adding call to Tools/Scripts/clean-webkit.
4287         * Scripts/clean-webkit: Added.
4288         (main): Removes untracked and changed files.
4289         * Scripts/webkitpy/common/checkout/scm/git.py:
4290         (Git.untracked_files): Retrieves GIT untracked files.
4291         * Scripts/webkitpy/common/checkout/scm/scm.py:
4292         (SCM.untracked_files): Retrieves SVN untracked files.
4293         (SCM):
4294         (SCM.discard_untracked_files): Deletes untracked files/folders.
4295         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4296         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
4297         (test_untracked_files):
4298         (GitSVNTest.test_untracked_files):
4299         * Scripts/webkitpy/common/checkout/scm/svn.py:
4300         (SVN.untracked_files):
4301
4302 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4303
4304         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
4305         https://bugs.webkit.org/show_bug.cgi?id=143138
4306
4307         Reviewed by Csaba Osztrogonác.
4308
4309         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
4310         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
4311
4312         * ImageDiff/CMakeLists.txt:
4313         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
4314         * WebKitTestRunner/CMakeLists.txt: ditto.
4315
4316 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
4317
4318         Support building WTF on Windows without Cygwin
4319         https://bugs.webkit.org/show_bug.cgi?id=143084
4320
4321         Reviewed by Brent Fulgham.
4322
4323         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
4324         This patch also migrates to using File::Spec->catfile() for directory separators.
4325
4326         * Scripts/update-webkit-dependency:
4327         (wanted):
4328         * Scripts/update-webkit-support-libs:
4329         (wanted):
4330         (downloadExpectedVersionNumber):
4331         (zipFileVersion):
4332         (toUnixPath): Deleted.
4333         * Scripts/webkitdirs.pm:
4334         (determineSourceDir):
4335         (windowsSourceSourceDir):
4336         (windowsLibrariesDir):
4337         (windowsOutputDir):