d9a701830c3307a213b1aad1f5981289481295ed
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2
3         kill-old-processes doesn't do anything on linux
4         https://bugs.webkit.org/show_bug.cgi?id=82388
5
6         Disable kill-old-processes on the Qt bots not to kill each others.
7
8         Reviewed by Ryosuke Niwa.
9
10         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
11         (Factory.__init__):
12
13 2012-03-27  Hao Zheng  <zhenghao@chromium.org>
14
15         Handle DRT crash caused by Android OOM.
16         https://bugs.webkit.org/show_bug.cgi?id=82310
17
18         Reviewed by Tony Chang.
19
20         When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
21         is stopped silently and regarded as crashed. Re-run the test for
22         such crash.
23
24         Add some debug log to NRWT.
25
26         * Scripts/webkitpy/layout_tests/port/chromium.py:
27         (ChromiumDriver.run_test):
28         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
29         (ChromiumAndroidPort.__init__):
30         (ChromiumAndroidPort.get_last_stacktrace):
31         (ChromiumAndroidDriver.__init__):
32         (ChromiumAndroidDriver._start):
33         (ChromiumAndroidDriver.run_test):
34         (ChromiumAndroidDriver._get_drt_return_value):
35
36 2012-03-27  Ojan Vafai  <ojan@chromium.org>
37
38         Fix expected results for some unittest failures.
39
40         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
41
42 2012-03-27  Adrienne Walker  <enne@google.com>
43
44         [chromium] Fix --enabled-threaded-compositing flag in DRT
45         https://bugs.webkit.org/show_bug.cgi?id=82405
46
47         Reviewed by James Robinson.
48
49         --enable-threaded-compositing wasn't working because there was no way
50         to set the value before it was used in the TestShell constructor.
51
52         To avoid adding yet another boolean parameter to TestShell's
53         constructor, add an explicit initialize function that can operate on
54         any boolean settings that are set post-constructor.
55
56         * DumpRenderTree/chromium/DumpRenderTree.cpp:
57         (main):
58         * DumpRenderTree/chromium/TestShell.cpp:
59         (TestShell::TestShell):
60         (TestShell::initialize):
61         * DumpRenderTree/chromium/TestShell.h:
62         (TestShell):
63         (TestShell::setTestShellMode):
64
65 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
66
67         new-run-webkit-tests: suppress debug output from run-safari on results file
68         https://bugs.webkit.org/show_bug.cgi?id=82400
69
70         Reviewed by Ryosuke Niwa.
71
72         Send the run-safari output to /dev/null rather than the console.
73
74         * Scripts/webkitpy/layout_tests/port/mac.py:
75         (MacPort.show_results_html_file):
76
77 2012-03-27  Simon Fraser  <simon.fraser@apple.com>
78
79         Improve error reporting in run-javascriptcore-tests
80         https://bugs.webkit.org/show_bug.cgi?id=82379
81
82         Reviewed by Jessie Berlin.
83         
84         When the script dies, have it print out the reason for dying.
85
86         * Scripts/run-javascriptcore-tests:
87
88 2012-03-27  Eric Seidel  <eric@webkit.org>
89
90         Add Dave Barton to the Contributors list so I can more easily CC him on bugs
91         https://bugs.webkit.org/show_bug.cgi?id=82373
92
93         Reviewed by Ryosuke Niwa.
94
95         Dave's committer-status in in-progress, so until then
96         list him as a Contributor so at least I can more easily CC him on bugs.
97
98         * Scripts/webkitpy/common/config/committers.py:
99
100 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
101
102         [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
103         https://bugs.webkit.org/show_bug.cgi?id=82252
104
105         Reviewed by Gustavo Noronha Silva.
106
107         Appending the directory containing common.py may be problematic if
108         another path in sys.path also contains either a common.py or a
109         common/ module, so prepend to select our version instead. This is
110         the case with fail2ban, which has a common/ directory which may
111         end up being in Python's default path.
112
113         * efl/jhbuildrc:
114         * gtk/jhbuildrc:
115
116 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
117
118         test-webkitpy: prepare for better test run output
119         https://bugs.webkit.org/show_bug.cgi?id=82290
120
121         Reviewed by Adam Barth.
122
123         This code basically re-implements the output of the TextTestRunner default
124         runner code from unittest, although the implementation is quite
125         different, in preparation for changing the test output to be
126         metered and possibly running in parallel.
127
128         The output is almost identical to before, except that instead of
129         logging "test_regular (webkitpy.main.RunnerTest) passed" we log
130         "webkitpy.main.RunnerTest.test_regular passed". It has always
131         annoyed me that they invert the names to be harder to read and
132         so that you can't copy & paste back to the input for
133         test-webkitpy.
134
135         This patch is provided to add a skeleton for unit tests and for
136         comparison to an upcoming patch that will actually add new
137         functionality.
138
139         * Scripts/webkitpy/test/main.py:
140         (Tester.__init__):
141         (Tester._configure_logging):
142         (Tester._run_tests):
143         * Scripts/webkitpy/test/runner.py: Added.
144         (TestRunner):
145         (TestRunner.__init__):
146         (TestRunner.test_name):
147         (TestRunner.all_test_names):
148         (TestRunner.run):
149         (TestRunner.write_result):
150         (TestRunner.write_summary):
151         * Scripts/webkitpy/test/runner_unittest.py: Added.
152         (FakeModuleSuite):
153         (FakeModuleSuite.__init__):
154         (FakeModuleSuite.__str__):
155         (FakeModuleSuite.run):
156         (FakeTopSuite):
157         (FakeTopSuite.__init__):
158         (FakeLoader):
159         (FakeLoader.__init__):
160         (FakeLoader.top_suite):
161         (FakeLoader.loadTestsFromName):
162         (RunnerTest):
163         (RunnerTest.test_regular):
164         (RunnerTest.test_verbose):
165
166 2012-03-27  Gustavo Noronha Silva  <gns@gnome.org>
167
168         [GTK] Build gnutls without p11-kit support
169         https://bugs.webkit.org/show_bug.cgi?id=82212
170
171         Reviewed by Martin Robinson.
172
173         * gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
174         configure, to avoid requiring that dependency, which is not used
175         by libsoup and WebKit anyway
176
177 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
178
179         [Qt] Make debug build work on 32 bit
180         https://bugs.webkit.org/show_bug.cgi?id=82331
181
182         Use --no-keep-memory option of ld not to cache the symbol tables of input files in
183         memory to avoid memory exhaustion during the linking phase for x86-debug builds.
184
185         Reviewed by Tor Arne Vestbø.
186
187         * qmake/mkspecs/features/unix/default_post.prf:
188         * qmake/mkspecs/features/unix/default_pre.prf:
189
190 2012-03-23  Balazs Ankes  <bank@inf.u-szeged.hu>
191
192         Add png checking to check-webkit-style
193         https://bugs.webkit.org/show_bug.cgi?id=75824
194
195         Reviewed by NOBODY Tony Chang.
196
197         * Scripts/webkitpy/style/checker.py:
198         (_all_categories):
199         (FileType):
200         (CheckerDispatcher._should_skip_file_path):
201         (CheckerDispatcher._file_type):
202         (CheckerDispatcher._create_checker):
203         * Scripts/webkitpy/style/checker_unittest.py:
204         (CheckerDispatcherDispatchTest.test_none_paths):
205         * Scripts/webkitpy/style/checkers/png.py: Added.
206         (PNGChecker):
207         (PNGChecker.__init__):
208         (PNGChecker.check):
209         (PNGChecker._config_file_path):
210         * Scripts/webkitpy/style/checkers/png_unittest.py: Added.
211         (MockSCMDetector):
212         (MockSCMDetector.__init__):
213         (MockSCMDetector.display_name):
214         (MockSCMDetector.propget):
215         (PNGCheckerTest):
216         (PNGCheckerTest.test_init):
217         (PNGCheckerTest.test_init.mock_handle_style_error):
218         (PNGCheckerTest.test_check):
219         (PNGCheckerTest.test_check.mock_handle_style_error):
220         * Scripts/webkitpy/style/patchreader.py:
221         (PatchReader.check):
222
223 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
224
225         Unreviewed. Skip GTK+ unit tests that fail in the bots
226
227         * Scripts/run-gtk-tests:
228         (TestRunner): Add failing tests to the skipped list.
229
230 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
231
232         Unreviewed. Unskip all GTK+ unit test.
233
234         Currently, skipped tests contains the list of unit tests that have
235         failed in one or more bots. In this moment it's not possible to
236         skip just the test cases that fail, so the complete unit test is
237         skipped when a single test case fails. For that reason, we don't
238         know which test cases are actually failing for every skipped
239         test. We are planning to land a patch to allow skipping individual
240         test cases, but first we need to know which test cases are
241         currently failing in the bots to skip them. So, this patch simply
242         unskips all unit tests in order to watch the bots and get the list
243         of test cases failing. Failing tests will be skipped again as soon
244         as we have the new list of failing test cases.
245
246         * Scripts/run-gtk-tests:
247         (TestRunner): Reset the list of skipped tests.
248
249 2012-03-26  Scott Byer  <scottbyer@chromium.org>
250
251         Enable layout testing of the scroll animator.
252         https://bugs.webkit.org/show_bug.cgi?id=81858
253         Add a call to the InternalSettings that layout tests can use to
254         turn on scroll animation. Enable animation updates for the
255         Chromium platform DRT when scroll animation has been turned on in
256         a test. This should be a no-op for all current layout tests.
257
258         Reviewed by James Robinson.
259
260         * DumpRenderTree/chromium/WebViewHost.cpp:
261         (WebViewHost::serviceAnimation):
262         (WebViewHost::scheduleAnimation):
263         * DumpRenderTree/chromium/WebViewHost.h:
264         (WebViewHost):
265
266 2012-03-26  Dinu Jacob  <dinu.jacob@nokia.com>
267
268         [Qt][WK2] Support multi-file upload
269         https://bugs.webkit.org/show_bug.cgi?id=81589
270
271         Reviewed by Simon Hausmann.
272
273         Modified filePicker to support multi-file upload.
274
275         * MiniBrowser/qt/MiniBrowser.qrc:
276         * MiniBrowser/qt/icons/checkbox_checked.png: Added.
277         * MiniBrowser/qt/icons/checkbox_unchecked.png: Added.
278         * MiniBrowser/qt/js/MultiSelect.js: Added.
279         (values):
280         (isSelected):
281         (removeValue):
282         * MiniBrowser/qt/qml/CheckBox.qml: Added.
283         * MiniBrowser/qt/qml/FilePicker.qml:
284
285 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
286
287         Retry crashing tests serially at the end of NRWT on Apple Mac
288         https://bugs.webkit.org/show_bug.cgi?id=82233
289
290         Reviewed by Dirk Pranke.
291
292         * Scripts/webkitpy/layout_tests/controllers/manager.py:
293         (Manager.run):
294         * Scripts/webkitpy/layout_tests/port/base.py:
295         (Port.should_retry_crashes):
296         * Scripts/webkitpy/layout_tests/port/mac.py:
297         (MacPort.should_retry_crashes):
298
299 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
300
301         NRWT should retry failures serially
302         https://bugs.webkit.org/show_bug.cgi?id=82241
303
304         Reviewed by Dirk Pranke.
305
306         * Scripts/webkitpy/layout_tests/controllers/manager.py:
307         (Manager._run_tests): Add another parameter to specify the number of workers to use.
308         (Manager.run): Run the failures serially.
309
310 2012-03-26  Adrienne Walker  <enne@google.com>
311
312         Allow expectations on directories in virtual test suites
313         https://bugs.webkit.org/show_bug.cgi?id=82250
314
315         Reviewed by Dirk Pranke.
316
317         lookup_virtual_test_base was only returning valid results for files
318         and not directories. Fix by falling back to the virtual test suite
319         mapping if possible.
320
321         * Scripts/webkitpy/layout_tests/port/base.py:
322         (Port.lookup_virtual_test_base):
323         * Scripts/webkitpy/layout_tests/port/test.py:
324         (TestPort.skipped_tests):
325         (TestPort.virtual_test_suites):
326
327 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
328
329         Fix duplicated ChangeLog entry from r112171.
330
331         Unreviewed, build fix.
332
333 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
334
335         nrwt: remove --worker-model flag
336         https://bugs.webkit.org/show_bug.cgi?id=82112
337
338         Reviewed by Adam Barth.
339
340         The --worker-model=inline flag is basically redundant with the
341         --child-processes=1 flag (technically, you could one run child
342         process, but this is only useful for testing); this patch
343         removes this flag, which simplifies things and enables more
344         cleanup down the road.
345
346         * Scripts/webkitpy/layout_tests/controllers/manager.py:
347         (Manager._run_tests):
348         (Manager.print_config):
349         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
350         (get):
351         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
352         (make_broker):
353         (FunctionTests.test_get__inline):
354         (FunctionTests.test_get__processes):
355         (_TestsMixin.setUp):
356         (_TestsMixin.make_broker):
357         (InlineBrokerTests.setUp):
358         (MultiProcessBrokerTests.setUp):
359         * Scripts/webkitpy/layout_tests/port/base.py:
360         (Port.default_child_processes):
361         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
362         (ChromiumAndroidPort.check_sys_deps):
363         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
364         (ChromiumAndroidPortTest):
365         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
366         (MockDRTPortTest.make_port):
367         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
368         (PortTestCase):
369         (PortTestCase.make_port):
370         * Scripts/webkitpy/layout_tests/port/test.py:
371         (TestPort.default_child_processes):
372         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
373         (_set_up_derived_options):
374         (parse_args):
375         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
376         (parse_args):
377         (MainTest.test_batch_size):
378         (MainTest.test_child_processes_2):
379         (MainTest.test_child_processes_min):
380         (MainTest.test_exception_raised):
381         (MainTest.test_keyboard_interrupt):
382         (MainTest.test_exit_after_n_crashes):
383         (MainTest.assert_run_order):
384         (MainTest.test_run_order__inline):
385         (MainTest.test_virtual):
386
387 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
388
389         test-webkitpy: split test-finding code into a different module
390         https://bugs.webkit.org/show_bug.cgi?id=82253
391
392         Reviewed by Adam Barth.
393
394         Per suggestion from abarth, this change splits all the
395         filesystem-crawling, test-finding code in test-webkitpy out into
396         a separate module and switches to using a FileSystem object.
397         This makes things much more testable, so we also add tests :).
398
399         We also add a realpath() method to the Filesystem object, since
400         test-webkitpy needs that in order to be able to resolve symlinks
401         properly to determine whether a file is under a particular tree
402         or not.
403
404         * Scripts/webkitpy/common/system/filesystem.py:
405         (FileSystem.realpath):
406         * Scripts/webkitpy/common/system/filesystem_mock.py:
407         (MockFileSystem.realpath):
408         * Scripts/webkitpy/test/main.py:
409         (Tester.__init__):
410         (Tester.add_tree):
411         (Tester.run):
412         (Tester._run_tests):
413         (Tester._log_exception):
414         * Scripts/webkitpy/test/test_finder.py: Added.
415         (TestDirectoryTree):
416         (TestDirectoryTree.__init__):
417         (TestDirectoryTree.find_modules):
418         (TestDirectoryTree.find_modules.file_filter):
419         (TestDirectoryTree.to_module):
420         (TestDirectoryTree.clean):
421         (TestFinder):
422         (TestFinder.__init__):
423         (TestFinder.add_tree):
424         (TestFinder.additional_paths):
425         (TestFinder.clean_trees):
426         (TestFinder.is_module):
427         (TestFinder.to_module):
428         (TestFinder.find_names):
429         (TestFinder._exclude):
430         * Scripts/webkitpy/test/test_finder_unittest.py: Added.
431         (TestFinderTest):
432         (TestFinderTest.setUp):
433         (TestFinderTest.tearDown):
434         (TestFinderTest.test_additional_system_paths):
435         (TestFinderTest.test_is_module):
436         (TestFinderTest.test_to_module):
437         (TestFinderTest.test_clean):
438         (TestFinderTest.test_find_names):
439
440 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
441
442         [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
443         https://bugs.webkit.org/show_bug.cgi?id=82209
444
445         Reviewed by Martin Robinson.
446
447         Respecting the $MAKE environment variable when it is defined makes
448         building jhbuild more portable, as some platforms may have GNU
449         make as gmake, for example.
450
451         * jhbuild/jhbuild-wrapper:
452         (install_jhbuild):
453
454 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
455
456         add a Tree abstraction to test-webkitpy to better encapsulate things
457         https://bugs.webkit.org/show_bug.cgi?id=82158
458
459         Reviewed by Adam Barth.
460
461         There are no functional changes in this patch, but adding a
462         basic abstraction for the trees we are looking in for python
463         tests will allow me to add some features later on more easily
464         (like ignoring certain directories like webkitpy/thirdparty),
465         and it makes things slightly less hard-coded.
466
467         * Scripts/test-webkitpy:
468         * Scripts/webkitpy/test/main.py:
469         (Tester.__init__):
470         (Tester):
471         (Tester.add_tree):
472         (Tester._parse_args):
473         (Tester._configure):
474         (Tester.run):
475         (Tester._find_modules):
476         (Tester._run_tests):
477         (Tester._is_module):
478         (Tester._log_exception):
479         (TestDirectoryTree):
480         (TestDirectoryTree.__init__):
481         (TestDirectoryTree.find_modules):
482         (TestDirectoryTree.clean):
483
484 2012-03-26  Ojan Vafai  <ojan@chromium.org>
485
486         garden-o-matic should special case reftests
487         https://bugs.webkit.org/show_bug.cgi?id=81812
488
489         Reviewed by Adam Barth.
490
491         On the examine page, don't show a rebaseline button for reftests.
492         We still show it on the failure summary page because tests are grouped
493         together. Long-term, we should make sure webkit-patch rebaseline-test
494         never tries to rebaseline reftests.
495
496         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
497         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
499
500 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
501
502         clean up NRWT logging/metering, be less verbose
503         https://bugs.webkit.org/show_bug.cgi?id=73846
504
505         Reviewed by Ojan Vafai.
506
507         Re-land r112014 with a build fix for Python 2.6 compatibility.
508
509         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
510         (ManagerTest.test_http_locking):
511         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
512         (AbstractWorker.run):
513         * Scripts/webkitpy/layout_tests/controllers/worker.py:
514         (Worker.__init__):
515         (Worker._set_up_logging):
516         (Worker):
517         (Worker._set_up_host_and_port):
518         (Worker.run):
519         (Worker.cleanup):
520         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
521         (WorkerTest.test_default_platform_in_worker):
522         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
523         (run):
524         (main):
525         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
526         (MeteredStream):
527         (MeteredStream.implements):
528         (MeteredStream._erasure):
529         (MeteredStream._ensure_newline):
530         (MeteredStream.__init__):
531         (MeteredStream.__del__):
532         (MeteredStream.cleanup):
533         (MeteredStream.write_throttled_update):
534         (MeteredStream.write_update):
535         (MeteredStream.write):
536         (MeteredStream.writeln):
537         (MeteredStream._erase_last_partial_line):
538         (_LogHandler):
539         (_LogHandler.__init__):
540         (_LogHandler.emit):
541         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
542         (RegularTest):
543         (RegularTest.setUp):
544         (RegularTest.tearDown):
545         (RegularTest.time_fn):
546         (RegularTest.test_logging_not_included):
547         (RegularTest._basic):
548         (RegularTest.test_basic):
549         (RegularTest._log_after_update):
550         (RegularTest.test_log_after_update):
551         (TtyTest):
552         (TtyTest.test_basic):
553         (TtyTest.test_log_after_update):
554         (VerboseTest):
555         (VerboseTest.test_basic):
556         (VerboseTest.test_log_after_update):
557         * Scripts/webkitpy/layout_tests/views/printing.py:
558         (parse_print_options):
559         (Printer.__init__):
560         (Printer.cleanup):
561         (Printer.print_progress):
562         (Printer.print_update):
563         (Printer._write):
564         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
565         (Testprinter.get_printer):
566         (Testprinter.test_print_progress):
567         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
568         (PerfTestsRunner.__init__):
569         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
570         (test_run_test_pause_before_testing):
571
572 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
573
574         [jhbuild] Revert $MAKE environment hack introduced in r101929.
575         https://bugs.webkit.org/show_bug.cgi?id=82234
576
577         Reviewed by Martin Robinson.
578
579         The problem it was supposedly fixing was fixed in jhbuild itself
580         in git revision da8944d8ca987ca48c91b350257a530050406092, so we
581         can remove the workaround added to the script.
582
583         * jhbuild/jhbuild-wrapper:
584         (install_jhbuild):
585
586 2012-03-26  Leo Yang  <leo.yang@torchmobile.com.cn>
587
588         [BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
589         https://bugs.webkit.org/show_bug.cgi?id=82157
590
591         Reviewed by Rob Buis.
592
593         * Scripts/build-webkit:
594         Make ENABLE_FILE_SYSTEM default on for blackberry.
595
596 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
597
598         [jhbuild] Explicitly disable DTrace when building glib.
599         https://bugs.webkit.org/show_bug.cgi?id=82145
600
601         Reviewed by Gustavo Noronha Silva.
602
603         DTrace support is not really needed by WebKit, so disabling it
604         helps avoid some build errors on more exotic platforms (such as
605         FreeBSD).
606
607         * efl/jhbuild.modules:
608         * gtk/jhbuild.modules:
609
610 2012-03-26  Sheriff Bot  <webkit.review.bot@gmail.com>
611
612         Unreviewed, rolling out r111993.
613         http://trac.webkit.org/changeset/111993
614         https://bugs.webkit.org/show_bug.cgi?id=82184
615
616         It broke layout and API tests and made WTR crash (Requested by
617         Ossy on #webkit).
618
619         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
620         (WTR::PlatformWebView::PlatformWebView):
621
622 2012-03-25  Kevin Ollivier  <kevino@theolliviers.com>
623
624         [wx] Unreviewed build fix. Move WTF to its own static lib build.
625
626         * waf/build/settings.py:
627         (common_configure):
628
629 2012-03-24  Chris Fleizach  <cfleizach@apple.com>
630
631         AX: Support solution to handle invalid ax text marker
632         https://bugs.webkit.org/show_bug.cgi?id=82023
633
634         Reviewed by Oliver Hunt.
635
636         * DumpRenderTree/AccessibilityUIElement.cpp:
637         (indexForTextMarkerCallback):
638         (isTextMarkerValidCallback):
639         (textMarkerForIndexCallback):
640         (AccessibilityUIElement::indexForTextMarker):
641         (AccessibilityUIElement::isTextMarkerValid):
642         (AccessibilityUIElement::textMarkerForIndex):
643         (AccessibilityUIElement::getJSClass):
644         * DumpRenderTree/AccessibilityUIElement.h:
645         (AccessibilityUIElement):
646         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
647         (AccessibilityUIElement::indexForTextMarker):
648         (AccessibilityUIElement::textMarkerForIndex):
649         (AccessibilityUIElement::isTextMarkerValid):
650         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
651         (WTR::AccessibilityUIElement::indexForTextMarker):
652         (WTR::AccessibilityUIElement::isTextMarkerValid):
653         (WTR::AccessibilityUIElement::textMarkerForIndex):
654         (WTR):
655         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
656         (AccessibilityUIElement):
657         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
658         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
659         (WTR):
660         (WTR::AccessibilityUIElement::indexForTextMarker):
661         (WTR::AccessibilityUIElement::isTextMarkerValid):
662         (WTR::AccessibilityUIElement::textMarkerForIndex):
663
664 2012-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
665
666         Unreviewed, rolling out r112014.
667         http://trac.webkit.org/changeset/112014
668         https://bugs.webkit.org/show_bug.cgi?id=82138
669
670         Broke SnowLeopard, Chromium and GTK+ bots (Requested by kov on
671         #webkit).
672
673         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
674         (ManagerTest.test_http_locking):
675         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
676         (AbstractWorker.run):
677         * Scripts/webkitpy/layout_tests/controllers/worker.py:
678         (Worker.__init__):
679         (Worker.safe_init):
680         (Worker.run):
681         (Worker.cleanup):
682         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
683         (WorkerTest.test_default_platform_in_worker):
684         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
685         (run):
686         (main):
687         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
688         (MeteredStream):
689         (MeteredStream.is):
690         (MeteredStream.__init__):
691         (MeteredStream.write):
692         (MeteredStream.update):
693         (MeteredStream._overwrite):
694         (MeteredStream._reset):
695         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
696         (TestMeteredStream):
697         (TestMeteredStream.test_regular):
698         * Scripts/webkitpy/layout_tests/views/printing.py:
699         (_configure_logging):
700         (_restore_logging):
701         (Printer.__init__):
702         (Printer.cleanup):
703         (Printer.print_progress):
704         (Printer.print_update):
705         (Printer._write):
706         (Printer):
707         (Printer._update):
708         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
709         (TestUtilityFunctions.assertEmpty):
710         (TestUtilityFunctions):
711         (TestUtilityFunctions.assertNotEmpty):
712         (TestUtilityFunctions.assertWritten):
713         (TestUtilityFunctions.test_configure_logging):
714         (Testprinter.get_printer):
715         (Testprinter.test_print_progress):
716         (Testprinter.test_print_progress.mock_time):
717         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
718         (PerfTestsRunner.__init__):
719         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
720         (test_run_test_pause_before_testing):
721
722 2012-03-24  Kevin Ollivier  <kevino@theolliviers.com>
723
724         [wx] Unreviewed. Fix the build after WTF move.
725
726         * waf/build/build_utils.py:
727         (get_excludes):
728         (get_excludes_in_dirs):
729         * waf/build/settings.py:
730         (get_port_excludes):
731         (common_configure):
732
733 2012-03-24  Dirk Pranke  <dpranke@chromium.org>
734
735         clean up NRWT logging/metering, be less verbose
736         https://bugs.webkit.org/show_bug.cgi?id=73846
737
738         Reviewed by Ojan Vafai.
739
740         This patch totally rewrites the metered_stream module and
741         changes the way it and the printing module now interact with the
742         logging subsystem.
743
744         The printing module becomes a dumb layout_tests-specific wrapper around
745         the metered stream. All of the intelligence of how and when to
746         actually write (or erase) lines and how things interact with
747         logging moves into the metered stream.
748
749         As of now, anything written to the metered stream *bypasses the
750         logging system*. If a logger is passed to the meter constructor,
751         the metered stream will also attach a log handler so that all
752         messages fed to the logger will also be written to the metered
753         stream. This detangles the logic that used to exist where
754         sometimes the meter would write to the logger and sometimes the
755         logger would write to the meter.
756
757         All of this makes the logic generic and reusable for
758         test-webkitpy (coming in another patch). It also helps clarify
759         what the mysterious "configure_logging" parameter to the printer
760         constructor used to do (that parameter itself is gone now, and
761         by default the printer and metered_stream will not ever touch
762         the logging system; this makes a bunch of tests less fragile).
763
764         All of the above should produce no user-visible changes.
765
766         However, to also fix the bug in question, we change the message
767         format in --verbose mode to %H:%M:%S.%frac %pid %message,
768         eliminating the date, file:lineno, and level parameters. I am
769         making this change at the same time because it would be
770         difficult to write things consistently between the logs and the
771         metered stream if we were still logging the file:lineno.
772
773         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
774           Remove the configure_logging parameter
775         * Scripts/webkitpy/layout_tests/controllers/worker.py:
776           Use metered stream to configure the logging (we don't need a printer)
777           and be careful about when and how we manipulate the log level
778           and handlers on the root logger.
779         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
780           Pass in the root logger so that log messages are formatted
781           properly, and set the log level outside of any routines called
782           by unit tests so as to not interfere.
783         * Scripts/webkitpy/layout_tests/views/manager_worker_broker.py:
784           remove a duplicate log message.
785         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
786           complete rewrite :).
787         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
788           complete rewrite :).
789         * Scripts/webkitpy/layout_tests/views/printing.py:
790           move the logging configuration into metered_stream, and also
791           move the "when should I log progress messages" into metered stream.
792         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
793           remove tests that are no longer necessary.
794         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
795           remove the configure_logging parameter.
796         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
797           update the test; since the printer no longer writes to the log,
798           we need to check what is written to the regular_output instead.
799           (test_run_test_pause_before_testing):
800
801 2012-03-24  Gustavo Noronha Silva  <gns@gnome.org>
802
803         Add myself and Martin Robinson to:
804           * GStreamerGraphics
805           * GtkWebKit2PublicAPI
806           * SoupNetwork
807         and to the newly created WebKitGTKTranslations.
808
809         Rubber-stamped by Martin Robinson.
810
811         * Scripts/webkitpy/common/config/watchlist:
812
813 2012-03-24  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
814
815         [Qt][WK2] Implement PageClient::isViewWindowActive()
816         https://bugs.webkit.org/show_bug.cgi?id=81143
817
818         Reviewed by Kenneth Rohde Christiansen.
819
820         Fix the WrapperWindow from our PlatformWebView
821         so it correctly creates the platform related
822         stuff for QWindow, which is not created unless
823         QWindow::setVisible() or QWindow::show() are called.
824
825         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
826         (WTR::PlatformWebView::PlatformWebView):
827
828 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
829
830         nrwt: don't wait for safari to exit before exiting after showing the results file
831         https://bugs.webkit.org/show_bug.cgi?id=81845
832
833         Reviewed by Ryosuke Niwa.
834
835         Prior to this change, if you ran new-run-webkit-tests and
836         displayed the HTML results file at the end, we would block
837         waiting for the user to quit the browser. There doesn't seem to
838         be a need for that, and the Chromium ports don't do this.
839
840         Also, update the mac tests to capture the output and be quiet :).
841
842         * Scripts/webkitpy/common/system/executive_mock.py:
843           Make popen() testable, implement should_log for it.
844         * Scripts/webkitpy/layout_tests/port/mac.py:
845         (MacPort.show_results_html_file):
846         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
847           Silence some of the tests via outputcapture.
848
849 2012-03-23  Gustavo Noronha Silva  <gns@gnome.org>
850
851         [GTK] libgcrypt and p11-kit should not be in jhbuild modules
852         https://bugs.webkit.org/show_bug.cgi?id=82073
853
854         Reviewed by Martin Robinson.
855
856         * Scripts/webkitdirs.pm:
857         (jhbuildConfigurationChanged): new function that isolates the
858         jhbuild configuration change checking from the autogen logic.
859         (mustReRunAutogen): code for the new function lived here.
860         (buildAutotoolsProject): now calls jhbuildConfigurationChanged
861         itself, and cleans up the jhbuild root if configuration has
862         changed; it also forces autogen to be run in that case, to
863         make sure the new libraries are used.
864         * gtk/jhbuild.modules: removed libgcrypt and p11-kit.
865         * jhbuild/jhbuild-wrapper:
866         (ensure_jhbuild): this might be run inside a jhbuild environment,
867         in which case aclocal fails when trying to use the now deleted
868         aclocal directory in the jhbuild prefix, so work around that.
869
870 2012-03-23  Ojan Vafai  <ojan@chromium.org>
871
872         garden-o-matic scrolls to the top of the page when you click an accordion item
873         https://bugs.webkit.org/show_bug.cgi?id=82088
874
875         Reviewed by Adam Barth.
876
877         Check the scroll position and make sure that the clicked accordion item is visible.
878
879         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
880
881 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
882
883         LayoutTestHelper could get torn down earlier (mostly to reset color profile)
884         https://bugs.webkit.org/show_bug.cgi?id=80567
885
886         Reviewed by Ryosuke Niwa.
887
888         Move clean_up_run to occur right after we finish testing and
889         before we start processing the results. Also makes set_up_run()
890         and clean_up_run() private since there's no real need for
891         callers to be aware of them.
892
893         * Scripts/webkitpy/layout_tests/controllers/manager.py:
894         (Manager._set_up_run):
895         (Manager.run):
896         (Manager._clean_up_run):
897         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
898         (ManagerTest.test_http_locking):
899         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
900         (run):
901
902 2012-03-23  Dean Jackson  <dino@apple.com>
903
904         Disable CSS_SHADERS in Apple builds
905         https://bugs.webkit.org/show_bug.cgi?id=81996
906
907         Reviewed by Simon Fraser.
908
909         Default enableCSSShaders to be 0 on all builds that use
910         this script. Use the flag to turn it back on.
911
912         * Scripts/build-webkit:
913
914 2012-03-23  Tony Chang  <tony@chromium.org>
915
916         [chromium] rename newwtf target back to wtf
917         https://bugs.webkit.org/show_bug.cgi?id=82064
918
919         Reviewed by Adam Barth.
920
921         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
922
923 2012-03-23  Jessie Berlin  <jberlin@apple.com>
924
925         Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on
926         the Lion Intel WebKit2 Debug bots.
927         https://bugs.webkit.org/show_bug.cgi?id=81012.
928
929         Rubber-stamped by Dan Bernstein.
930
931         Add a step to kill the pasteboard server while we investigate what is causing these
932         assertion failures (to get the bots green).
933
934         * BuildSlaveSupport/kill-old-processes:
935
936 2012-03-22  Martin Robinson  <mrobinson@igalia.com>
937
938         [check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
939         https://bugs.webkit.org/show_bug.cgi?id=81986
940
941         Reviewed by David Levin.
942
943         Track whether or not errors are filtered in error handlers. If an
944         alphabetical sorting error is reported for a header and filtered, try
945         reporting it for the other potential source of the error. This ensures
946         that the style bot can still find new sorting errors in both potential
947         situations:
948
949             #include <foo.h> <-- 1. edited line
950             #include <baz.h> <-- 2. edited line
951
952         * Scripts/webkitpy/style/checkers/cpp.py:
953         (check_include_line): Potentially report the error for both lines,
954         if the first error is filtered.
955         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of
956         test that allows only reporting errors for certain lines. This verifies that
957         when one line of an ordering error is filtered, the error is reported on the
958         other line.
959         (ErrorCollector.__init__):
960         (ErrorCollector.__call__):
961         (CppStyleTestBase.perform_lint):
962         (CppStyleTestBase.perform_language_rules_check):
963         (CppStyleTestBase.assert_language_rules_check):
964         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
965         Added a new test that verifies that when one line of the two lines of an ordering
966         error occur, the error is reported on the other line.
967         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
968         (MockErrorHandler.__call__): Report True because the error is handled.
969         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
970         (ErrorCollector.__call__): Ditto.
971         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
972         (MockErrorHandler.__call__): Ditto.
973         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
974         (TestErrorHandler.__call__): Ditto.
975         * Scripts/webkitpy/style/checkers/xml_unittest.py:
976         (MockErrorHandler.__call__): Ditto.
977         * Scripts/webkitpy/style/error_handlers.py:
978         (DefaultStyleErrorHandler.__call__): Report True if the error is handled
979         and False if it is filtered.
980
981 2012-03-23  Patrick Gansterer  <paroga@webkit.org>
982
983         Build fix for WinCE after r111778.
984
985         * WinCELauncher/CMakeLists.txt:
986
987 2012-03-23  Peter Beverloo  <peter@chromium.org>
988
989         Unreviewed buildfix for the Chromium Android builder.
990
991         Disable the ImageDiff target for now. Android needs to build this for
992         host rather than for target (as other configurations do), but since the
993         WTF move the dependency chain got significantly more complicated.
994
995         I'll work out a proper fix in the following bug, but since several
996         things are broken due to this, this buildfix should be landed first.
997         https://bugs.webkit.org/show_bug.cgi?id=82039
998
999         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1000
1001 2012-03-23  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1002
1003         [EFL][DRT] Implement LayoutTestController's methods related with editing.
1004         https://bugs.webkit.org/show_bug.cgi?id=80136
1005
1006         Reviewed by Ryosuke Niwa.
1007
1008         Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
1009         setSelectTrailingWhitespaceEnabled.
1010
1011         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1012         (LayoutTestController::setSmartInsertDeleteEnabled):
1013         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
1014
1015 2012-03-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1016
1017         Convert hasGrammarMarker to use Internals interface
1018         https://bugs.webkit.org/show_bug.cgi?id=82004
1019
1020         Reviewed by Ryosuke Niwa.
1021
1022         Remove hasGrammarMarker functions, because it is able to work in the
1023         cross-port way through the Internals interface.
1024
1025         * DumpRenderTree/LayoutTestController.cpp:
1026         (LayoutTestController::staticFunctions):
1027         * DumpRenderTree/LayoutTestController.h:
1028         (LayoutTestController):
1029         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1030         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1031         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1032         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1033         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1034         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1035
1036 2012-03-22  Adam Barth  <abarth@webkit.org>
1037
1038         sync-master-with-upstream creates non-linear git history
1039         https://bugs.webkit.org/show_bug.cgi?id=82006
1040
1041         Reviewed by Julien Chaffraix.
1042
1043         Previously this script would create a merge commit at the HEAD of
1044         origin/master, causing your fork of WebKit to diverge from upstream.
1045         The new version of this script pushes directly from upstream to origin
1046         (without round-tripping through any local branches), avoiding this
1047         problem.
1048
1049         * Scripts/sync-master-with-upstream:
1050
1051 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
1052
1053         Unreviewed build fix. Add knowledge of the WTF project to
1054         the autotools build system scripts so that build-jsc works
1055         correctly for GTK+.
1056
1057         * Scripts/webkitdirs.pm:
1058         (buildAutotoolsProject): handle the WTF project, build the
1059         libWTF.la target.
1060         (buildGtkProject): add WTF to the list of supported projects.
1061
1062 2012-03-22  Eric Seidel  <eric@webkit.org>
1063
1064         Make svn-apply re-write JavaScriptCore/wtf to WTF/wtf
1065         https://bugs.webkit.org/show_bug.cgi?id=81984
1066
1067         Reviewed by Adam Barth.
1068
1069         * Scripts/VCSUtils.pm:
1070         (adjustPathForRecentRenamings):
1071
1072 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1073
1074         [CMake] Fix build-jsc after r111778 and r111797.
1075         https://bugs.webkit.org/show_bug.cgi?id=82001
1076
1077         Reviewed by Filip Pizlo.
1078
1079         Contrary to the comment in build-jsc, buildCMakeProjectOrExit()
1080         does return if no error occurred, and build-jsc failed with
1081         "building not defined for this platform".
1082
1083         * Scripts/build-jsc: Always exit after caling
1084         buildCMakeProjectOrExit().
1085         * Scripts/webkitdirs.pm:
1086         (buildCMakeProjectOrExit): Return 0 if no error occurred.
1087
1088 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1089
1090         [CMake] Unreviewed build fix after r111778.
1091
1092         * DumpRenderTree/efl/CMakeLists.txt: Replace
1093         ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include
1094         paths.
1095         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Use the right
1096         wtf include.
1097         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Ditto.
1098         * WinCELauncher/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf
1099         with ${WTF_DIR}/wtf in the include paths.
1100
1101 2012-03-22  Filip Pizlo  <fpizlo@apple.com>
1102
1103         Tools/Scripts/build-jsc doesn't work after WTF move
1104         https://bugs.webkit.org/show_bug.cgi?id=81999
1105
1106         Reviewed by Eric Seidel.
1107         
1108         For ports that require WTF and JSC to be built as two projects and where
1109         the machinery to build both does not already exist, teach the tool to do
1110         so for us.
1111
1112         * Scripts/build-jsc:
1113         (buildMyProject):
1114
1115 2012-03-22  Ojan Vafai  <ojan@chromium.org>
1116
1117         Fix accidental missing line in r111793.
1118
1119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1121         Remove base.values. It was unused and duplicates the builtin Object.values.
1122         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1123         Accidentally deleted this line before committing r111793.
1124
1125 2012-03-22  Ojan Vafai  <ojan@chromium.org>
1126
1127         Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page
1128         https://bugs.webkit.org/show_bug.cgi?id=81983
1129
1130         Reviewed by Adam Barth.
1131
1132         The dialogs get in the way if you are doing multiple rebaselines. Also,
1133         a number of people didn't realize that you could do multiple rebaselines
1134         in parallel. A non-modal dialog is just confusing.
1135
1136         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1138         If we're only rebaselining 1 test, show the test name in the initial message. Otherwise,
1139         show the number of tests being rebaselined.
1140
1141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1142         Turn MessageBox into StatusArea. StatusArea is a singleton and messages in the StatusArea are grouped
1143         by ID. That way, the results of each UI action (e.g. clicking rebaseline) are grouped together
1144         into a single area.
1145
1146         Once addFinalMessage has been called for all IDs, we show the close button. Clicking close
1147         also serves to clear all teh content in the StatusArea. 
1148
1149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1150         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1151
1152 2012-03-22  Tony Chang  <tony@chromium.org>
1153
1154         Unreviewed, fix chromium build after wtf move.
1155
1156         Only use newwtf, remove references to wtf.
1157
1158         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1159
1160 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
1161
1162         Actually move WTF files to their new home
1163         https://bugs.webkit.org/show_bug.cgi?id=81844
1164
1165         [Qt] Unreviewed buildfix after r111778.
1166
1167         * DumpRenderTree/qt/DumpRenderTree.pro:
1168
1169 2012-03-22  Dan Bernstein  <mitz@apple.com>
1170
1171         Font fallback in WebKitTestRunner depends on user settings
1172         https://bugs.webkit.org/show_bug.cgi?id=81978
1173
1174         Reviewed by Jessie Berlin.
1175
1176         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1177         (WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
1178         with a value consisting of the array ("en") to the override defaults
1179         dictionary. This is the same value used in DumpRenderTree, and it
1180         ensures that font fallback follows a consistent path that is not
1181         affected by the language preferences of the user running the test.
1182
1183 2012-03-22  Andy Estes  <aestes@apple.com>
1184
1185         check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
1186         https://bugs.webkit.org/show_bug.cgi?id=81971
1187
1188         Reviewed by Dan Bernstein.
1189
1190         Xcode will automatically link ObjC binaries against libarclite in some
1191         cases, which defines a class called __ARCLite__.
1192         check-for-inappropriate-objc-class-names shouldn't complain about this
1193         class name.
1194
1195         * Scripts/check-for-inappropriate-objc-class-names:
1196
1197 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
1198
1199         new-run-webkit-tests blames the wrong test for crashing
1200         https://bugs.webkit.org/show_bug.cgi?id=81951
1201
1202         Reviewed by Adam Barth.
1203
1204         NRWT wasn't extracting the WebProcess pid correct; should've
1205         used re.search instead of re.match :(. Add more tests!
1206
1207         * Scripts/webkitpy/layout_tests/port/mac.py:
1208         (MacPort._get_crash_log):
1209         * Scripts/webkitpy/layout_tests/port/webkit.py:
1210         (WebKitDriver.has_crashed):
1211         (WebKitDriver._check_for_driver_crash):
1212         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1213         (WebKitDriverTest.test_no_timeout):
1214         (WebKitDriverTest):
1215         (WebKitDriverTest.test_check_for_driver_crash):
1216         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
1217         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
1218         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
1219         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
1220         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
1221         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
1222
1223 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1224
1225         [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
1226         https://bugs.webkit.org/show_bug.cgi?id=81512
1227
1228         Adding missing implementation markerTextForListItem to EFL's
1229         LayoutTestController so that we can unskip related tests from
1230         the skip list.
1231
1232         Reviewed by Antonio Gomes.
1233
1234         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1235         (LayoutTestController::markerTextForListItem): Implemented.
1236
1237 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1238
1239         [EFL] Enable view mode media feature layout tests
1240         https://bugs.webkit.org/show_bug.cgi?id=81205
1241
1242         Adding missing implementation setViewModeMediaFeature to EFL's 
1243         LayoutTestController so that we can unskip view mode 
1244         media feature layout tests.
1245
1246         Reviewed by Antonio Gomes.
1247
1248         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1249         (LayoutTestController::setViewModeMediaFeature): Implemented.
1250
1251 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
1252
1253         nrwt: crash while stopping layout test helper on apple mac lion
1254         https://bugs.webkit.org/show_bug.cgi?id=81949
1255
1256         Reviewed by Eric Seidel.
1257
1258         stop_helper() didn't work right if the helper process wasn't
1259         still running or didn't respond properly to being shut down. Fix
1260         this and add some tests. Also add code to MockExecutive() to be
1261         able to mock executive.popen() properly.
1262
1263         * Scripts/webkitpy/common/system/executive_mock.py:
1264         (MockProcess.__init__):
1265         (MockProcess.wait):
1266         (MockExecutive.__init__):
1267         (MockExecutive.popen):
1268         * Scripts/webkitpy/common/system/systemhost_mock.py:
1269         (MockSystemHost.__init__):
1270         * Scripts/webkitpy/layout_tests/port/mac.py:
1271         (MacPort.start_helper):
1272         (MacPort.stop_helper):
1273         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1274         (test_get_crash_log):
1275         (test_helper_starts):
1276         (test_helper_fails_to_start):
1277         (test_helper_fails_to_stop):
1278         (test_helper_fails_to_stop.bad_waiter):
1279
1280 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
1281
1282         [GTK] Add make to the jhbuild moduleset
1283         https://bugs.webkit.org/show_bug.cgi?id=81769
1284
1285         Reviewed by Martin Robinson.
1286
1287         Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
1288         Add GNU make with custom patches to fix several issues:
1289
1290         - make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
1291           fix the argument list limit of GNU make when running make
1292           distcheck.
1293         - make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
1294           and Jeremy Devenport to fix parallel build issues present in
1295           GNU make 3.82
1296
1297         * gtk/jhbuild.modules: Added make with patches.
1298         * gtk/patches/make-3.82-arg-list-length.patch: Added.
1299         * gtk/patches/make-3.82-parallel-build.patch: Added.
1300
1301 2012-03-22  Kevin Ollivier  <kevino@theolliviers.com>
1302
1303         [wx] Unreviewed. Adding Source/WTF to the build and updating
1304         waf port list.
1305
1306         * DumpRenderTree/wscript:
1307         * waf/build/settings.py:
1308
1309 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
1310
1311         Re-land fix for r81603 yet again (!) with latest build fix.
1312         https://bugs.webkit.org/show_bug.cgi?id=81603
1313
1314         Unreviewed, build fix.
1315
1316         The latest problem was a bad sprintf() in
1317         BasePort._get_crash_log(). I've reworked that routine and added
1318         unit tests for coverage.
1319
1320         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1321         (SingleTestRunner._handle_error):
1322         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1323         (write_test_result):
1324         (TestResultWriter.write_crash_log):
1325         * Scripts/webkitpy/layout_tests/port/base.py:
1326         (Port.diff_text):
1327         (Port._get_crash_log):
1328         * Scripts/webkitpy/layout_tests/port/chromium.py:
1329         (ChromiumDriver.run_test):
1330         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1331         (ChromiumDriverTest.test_crash_log):
1332         * Scripts/webkitpy/layout_tests/port/driver.py:
1333         (DriverOutput.__init__):
1334         * Scripts/webkitpy/layout_tests/port/mac.py:
1335         (MacPort.is_lion):
1336         (MacPort._get_crash_log):
1337         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1338         (test_default_child_processes):
1339         (test_get_crash_log):
1340         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1341         (MockDRTPortTest.test_get_crash_log):
1342         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1343         (PortTestCase.test_get_crash_log):
1344         * Scripts/webkitpy/layout_tests/port/test.py:
1345         (TestDriver.run_test):
1346         * Scripts/webkitpy/layout_tests/port/webkit.py:
1347         (WebKitDriver.__init__):
1348         (WebKitDriver._start):
1349         (WebKitDriver.has_crashed):
1350         (WebKitDriver._check_for_driver_crash):
1351         (WebKitDriver.run_test):
1352
1353 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
1354
1355         [Qt] Enable support for handling database quota's in the MiniBrowser
1356         https://bugs.webkit.org/show_bug.cgi?id=81928
1357
1358         Reviewed by Simon Hausmann.
1359
1360         * MiniBrowser/qt/qml/BrowserWindow.qml:
1361
1362 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1363
1364         [EFL] Implement LayoutTestController::setEditingBehavior
1365         https://bugs.webkit.org/show_bug.cgi?id=81124
1366
1367         Adding missing implementation setEditingBehavior to EFL's
1368         LayoutTestController. This implementation allows us to
1369         unskip some tests from the skip list.
1370
1371         Reviewed by Martin Robinson.
1372
1373         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1374         (LayoutTestController::setEditingBehavior): Implemented.
1375
1376 2012-03-22  Carlos Garcia Campos  <cgarcia@bb-webkit-rel-64.local.igalia.com>
1377
1378         [GTK] Use the angle-bracket form to include wtf headers
1379         https://bugs.webkit.org/show_bug.cgi?id=81884
1380
1381         Reviewed by Eric Seidel.
1382
1383         Use #include <wtf/foo> instead of #include "foo".
1384
1385         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1386         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1387         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1388         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1389         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1390         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1391
1392 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
1393
1394         Unreviewed, add Michael Brüning and Allan Jensen to committers.py.
1395
1396         * Scripts/webkitpy/common/config/committers.py:
1397
1398 2012-03-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1399
1400         [Qt] Enable FAST_MOBILE_SCROLLING when scrolling is delegated.
1401         https://bugs.webkit.org/show_bug.cgi?id=81889
1402
1403         Reviewed by Kenneth Rohde Christiansen.
1404
1405         Enable FAST_MOBILE_SCROLLING feature.
1406
1407         * qmake/mkspecs/features/features.prf:
1408
1409 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1410
1411         [EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
1412         https://bugs.webkit.org/show_bug.cgi?id=81900
1413
1414         Reviewed by Gustavo Noronha Silva.
1415
1416         r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
1417         path which assumed a certain directory structure for the build
1418         directory which may noy be true.
1419
1420         Instead, hardcode the path to the downloaded fonts starting from the
1421         top-level source directory. While this solution is also far from
1422         perfect, it makes it more consistent and reliable, and easier to
1423         tackle at once with the rest of bug 81475.
1424
1425         * DumpRenderTree/efl/CMakeLists.txt:
1426
1427 2012-03-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1428
1429         [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
1430         https://bugs.webkit.org/show_bug.cgi?id=81888
1431
1432         Reviewed by Philippe Normand.
1433
1434         * Scripts/update-webkit-libs-jhbuild:
1435         (runJhbuild): Helper function to run jhbuild with a given command.
1436         Instead of running jhbuild directly, use the jhbuild-wrapper, so
1437         that we don't need to run it first to check whether jhbuild is
1438         installed or not.
1439         * efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
1440         * gtk/run-with-jhbuild: Ditto.
1441         * jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
1442         not only run.
1443
1444 2012-03-22  Philippe Normand  <pnormand@igalia.com>
1445
1446         Unreviewed, test-webkitpy fix after r111661.
1447
1448         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1449         (MainTest.test_crash_log):
1450         (MainTest.test_web_process_crash_log):
1451
1452 2012-03-22  Philippe Normand  <pnormand@igalia.com>
1453
1454         Unreviewed, test-webkitpy fix after r111642.
1455
1456         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1457         (ChromiumDriverTest.setUp):
1458         (ChromiumDriverTest.test_two_drivers):
1459
1460 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
1461
1462         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
1463         https://bugs.webkit.org/show_bug.cgi?id=81603
1464
1465         Unreviewed rolling out r111609 and part of r111615,
1466         because it broke NRWT on Qt-WK2 platform.
1467
1468         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1469         (SingleTestRunner._handle_error):
1470         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1471         (write_test_result):
1472         (TestResultWriter.write_crash_report):
1473         * Scripts/webkitpy/layout_tests/port/base.py:
1474         (Port.is_crash_reporter):
1475         (Port._driver_class):
1476         * Scripts/webkitpy/layout_tests/port/chromium.py:
1477         (ChromiumDriver.run_test):
1478         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1479         (ChromiumDriverTest.test_crashed_process_name):
1480         * Scripts/webkitpy/layout_tests/port/driver.py:
1481         (DriverOutput.__init__):
1482         * Scripts/webkitpy/layout_tests/port/mac.py:
1483         (MacPort):
1484         (MacPort.is_crash_reporter):
1485         (MacPort.release_http_lock):
1486         * Scripts/webkitpy/layout_tests/port/test.py:
1487         (TestDriver.run_test):
1488         * Scripts/webkitpy/layout_tests/port/webkit.py:
1489         (WebKitDriver.__init__):
1490         (WebKitDriver._start):
1491         (WebKitDriver.has_crashed):
1492         (WebKitDriver._check_for_driver_crash):
1493         (WebKitDriver.run_test):
1494
1495 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
1496
1497         [Qt] Add full platforms to Qt buildslaves
1498         https://bugs.webkit.org/show_bug.cgi?id=81877
1499
1500         Reviewed by Ryosuke Niwa.
1501
1502         * BuildSlaveSupport/build.webkit.org-config/config.json:
1503
1504 2012-03-21  Johnny Ding  <jnd@chromium.org>
1505
1506         Customize layout test timeout value for different ports.
1507         https://bugs.webkit.org/show_bug.cgi?id=79859
1508
1509         Reviewed by Ojan Vafai.
1510
1511         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1512         (Manager):
1513         * Scripts/webkitpy/layout_tests/port/base.py:
1514         (Port.default_test_timeout_ms):
1515         * Scripts/webkitpy/layout_tests/port/chromium.py:
1516         (ChromiumDriver.stop):
1517         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1518         (ChromiumAndroidPort.default_test_timeout_ms):
1519         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1520         (_set_up_derived_options):
1521
1522 2012-03-21  Mark Rowe  <mrowe@apple.com>
1523
1524         Fix the build.
1525
1526         Ensure that our test tools don't try and use RTTI unnecessarily.
1527
1528         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1529         * TestWebKitAPI/Configurations/Base.xcconfig:
1530         * WebKitTestRunner/Configurations/Base.xcconfig:
1531
1532 2012-03-21  Adam Barth  <abarth@webkit.org>
1533
1534         WebKit should have some scripts to smooth interactions with GitHub
1535         https://bugs.webkit.org/show_bug.cgi?id=81842
1536
1537         Reviewed by Eric Seidel.
1538
1539         These scripts support the workflow in
1540         https://trac.webkit.org/wiki/UsingGitHub by automating the
1541         configuration and syncing operations needed for a GitHub fork of WebKit
1542         to track the main WebKit repository.
1543
1544         * Scripts/configure-github-as-upstream: Added.
1545         * Scripts/sync-master-with-upstream: Added.
1546
1547 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
1548
1549         WTR - log the pid of a crashing WebProcess
1550         https://bugs.webkit.org/show_bug.cgi?id=81575
1551
1552         Reviewed by Alexey Proskuryakov.
1553
1554         This allows run-webkit-tests to find the right crash log for a
1555         given crashed WebProcess in WebKit2.
1556
1557         * WebKitTestRunner/TestController.cpp:
1558         (WTR::exceededDatabaseQuota):
1559         (WTR::TestController::createOtherPage):
1560         (WTR::TestController::initialize):
1561         (WTR::TestController::resetStateToConsistentValues):
1562         (WTR::TestController::runTest):
1563         (WTR::TestController::processDidCrash):
1564
1565 2012-03-21  Enrica Casucci  <enrica@apple.com>
1566
1567         WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
1568         https://bugs.webkit.org/show_bug.cgi?id=81835
1569         <rdar://problem/11082749>
1570
1571         Reviewed by Brady Eidson.
1572
1573         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
1574         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1575         (TestWebKitAPI::contextMenuCopyLink):
1576
1577 2012-03-21  Alexandru Chiculita  <achicu@adobe.com>
1578
1579         [CSS Shaders] Make CSS Shaders compile on Chromium
1580         https://bugs.webkit.org/show_bug.cgi?id=81435
1581
1582         Reviewed by Stephen White.
1583         
1584         I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
1585
1586         * DumpRenderTree/chromium/LayoutTestController.cpp:
1587         (LayoutTestController::overridePreference):
1588         * DumpRenderTree/chromium/WebPreferences.cpp:
1589         (WebPreferences::reset):
1590         (WebPreferences::applyTo):
1591         * DumpRenderTree/chromium/WebPreferences.h:
1592         (WebPreferences):
1593
1594 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
1595
1596         fix regression on gtk port introduced by r111609
1597         https://bugs.webkit.org/show_bug.cgi?id=81839
1598
1599         Reviewed by Philippe Normand.
1600
1601         r111609 should've initialized a couple of missing fields in
1602         WebKitDriver, and also should've checked for method overrides
1603         in the other ports :(.
1604
1605         * Scripts/webkitpy/layout_tests/port/gtk.py:
1606         (GtkDriver._start):
1607         * Scripts/webkitpy/layout_tests/port/webkit.py:
1608         (WebKitDriver.__init__):
1609         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1610         (MainTest.test_crash_log):
1611         (MainTest.test_web_process_crash_log):
1612
1613 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
1614
1615         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
1616         https://bugs.webkit.org/show_bug.cgi?id=81603
1617
1618         Reviewed by Adam Barth.
1619
1620         Add a new _get_crash_log() overridable method on the Port
1621         object to customize how we fetch crash logs per port.
1622         Mac will now slow-spin with a timeout waiting for the crash log, rather
1623         than waiting for the ReportCrash process to exit (it appears
1624         that the mac will manage multiple crashes with a single
1625         ReportCrash process, the process waits around longer than
1626         necessary, presumably to avoid thrashing if processes are
1627         repeatedly crashing).
1628
1629         Also, add the DriverOutput should contain the crash log and other info,
1630         which is created in a port-specific manner but can then be
1631         treated generically. Previously single_test_runner would get
1632         told that something crashed and attempt to do something to get
1633         the crash log, but it didn't have the information it needed to
1634         od the right thing; better to make the driver hand back the
1635         right info.
1636
1637         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1638         (SingleTestRunner._handle_error):
1639         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1640         (write_test_result):
1641         (TestResultWriter.write_crash_log):
1642         * Scripts/webkitpy/layout_tests/port/base.py:
1643         (Port.diff_text):
1644         (Port._get_crash_log):
1645         * Scripts/webkitpy/layout_tests/port/chromium.py:
1646         (ChromiumDriver.run_test):
1647         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1648         (ChromiumDriverTest.test_crash_log):
1649         * Scripts/webkitpy/layout_tests/port/driver.py:
1650         (DriverOutput.__init__):
1651         * Scripts/webkitpy/layout_tests/port/mac.py:
1652         (MacPort.is_lion):
1653         (MacPort._get_crash_log):
1654         * Scripts/webkitpy/layout_tests/port/test.py:
1655         (TestDriver.run_test):
1656         * Scripts/webkitpy/layout_tests/port/webkit.py:
1657         (WebKitDriver.__init__):
1658         (WebKitDriver._start):
1659         (WebKitDriver.has_crashed):
1660         (WebKitDriver._check_for_driver_crash):
1661         (WebKitDriver.run_test):
1662
1663 2012-03-21  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1664
1665         [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
1666         https://bugs.webkit.org/show_bug.cgi?id=81507
1667
1668         Now that we're only loading from one directory, no need to
1669         iterate over a list of directories anymore.
1670
1671         Reviewed by Martin Robinson.
1672
1673         * DumpRenderTree/efl/CMakeLists.txt:
1674         * DumpRenderTree/efl/FontManagement.cpp:
1675         (addFontDirectory):
1676         (addFontsToEnvironment):
1677
1678 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
1679
1680         webkitpy: get ServerProcess out of the reportcrash business
1681         https://bugs.webkit.org/show_bug.cgi?id=81600
1682
1683         Unreviewed, build fix.
1684
1685         Re-land r111307 and r111293 with another fix for a crash in NRWT;
1686         we need to check if the driver has crashed before attempting to
1687         read from it.
1688
1689
1690         * Scripts/webkitpy/layout_tests/port/server_process.py:
1691         (ServerProcess._reset):
1692         (ServerProcess._handle_possible_interrupt):
1693         (ServerProcess.write):
1694         (ServerProcess.read_stdout):
1695         (ServerProcess.has_crashed):
1696         (ServerProcess._read):
1697         (ServerProcess.stop):
1698         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1699         (TrivialMockPort.check_for_leaks):
1700         (TestServerProcess.test_broken_pipe):
1701         * Scripts/webkitpy/layout_tests/port/webkit.py:
1702         (WebKitPort._read_image_diff):
1703         (WebKitDriver.has_crashed):
1704         (WebKitDriver._check_for_driver_crash):
1705         (WebKitDriver.run_test):
1706         (WebKitDriver._read_block):
1707         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1708         (MockServerProcess.__init__):
1709         (MockServerProcess):
1710         (MockServerProcess.has_crashed):
1711
1712 2012-03-21  Zeno Albisser  <zeno@webkit.org>
1713
1714         [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
1715         https://bugs.webkit.org/show_bug.cgi?id=81750
1716
1717         Building WebCore on mac currently creates an archive that is bigger than
1718         4GB. But ranlib fails to create a symbol table for such a big archive,
1719         even on 64bit machines.
1720         Therefore we start using SVGAllInOne.cpp when building debug
1721         on mac. This reduces the size of the archive by about 300MB.
1722
1723         Reviewed by Tor Arne Vestbø.
1724
1725         * qmake/mkspecs/features/mac/default_pre.prf:
1726
1727 2012-03-21  Szilard Ledan  <szledan@inf.u-szeged.hu>
1728
1729         Updated the address list of committers.py.
1730
1731         Reviewed by Csaba Osztrogonác.
1732
1733         * Scripts/webkitpy/common/config/committers.py:
1734
1735 2012-03-21  W. James MacLean  <wjmaclean@chromium.org>
1736
1737         Updating my nick in committers file.
1738
1739         Unreviewed.
1740
1741         * Scripts/webkitpy/common/config/committers.py:
1742
1743 2012-03-21  Peter Beverloo  <peter@chromium.org>
1744
1745         [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
1746         https://bugs.webkit.org/show_bug.cgi?id=80861
1747
1748         Reviewed by Tony Chang.
1749
1750         Remove most Android-specific logic from webkitdirs.pm in favor of
1751         handling this during project generation time.
1752
1753         * Scripts/webkitdirs.pm:
1754         (buildChromiumMakefile):
1755
1756 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1757
1758         [GTK] Allow running javascript from location bar in MiniBrowser
1759         https://bugs.webkit.org/show_bug.cgi?id=81331
1760
1761         Reviewed by Martin Robinson.
1762
1763         * MiniBrowser/gtk/BrowserWindow.c:
1764         (activateUriEntryCallback): Use browser_window_load_uri().
1765         (browser_window_load_uri): Check whether uri starts with
1766         javascript: and run the given script, or just call
1767         webkit_web_view_load_uri() to load the given uri.
1768         * MiniBrowser/gtk/BrowserWindow.h:
1769         * MiniBrowser/gtk/main.c:
1770         (createBrowserWindow): Use browser_window_load_uri().
1771
1772 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1773
1774         [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
1775         https://bugs.webkit.org/show_bug.cgi?id=75543
1776
1777         Reviewed by Martin Robinson.
1778
1779         * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
1780         MiniBrowser CPP flags.
1781
1782 2012-03-20  Eric Seidel  <eric@webkit.org>
1783
1784         Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
1785         https://bugs.webkit.org/show_bug.cgi?id=80911
1786
1787         Reviewed by Adam Barth.
1788
1789         Update include paths for Source/WTF.
1790
1791         * DumpRenderTree/efl/CMakeLists.txt:
1792         * DumpRenderTree/qt/DumpRenderTree.pro:
1793         * QtTestBrowser/QtTestBrowser.pro:
1794         * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
1795
1796 2012-03-20  Adam Barth  <abarth@webkit.org>
1797
1798         svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
1799         https://bugs.webkit.org/show_bug.cgi?id=81567
1800
1801         Reviewed by Eric Seidel.
1802
1803         This temporary measure should help us avoid disrupting the folks
1804         working on WebAudio when we move the webaudio directory to Modules.
1805
1806         * Scripts/VCSUtils.pm:
1807         (adjustPathForRecentRenamings):
1808         (parseGitDiffHeader):
1809         (parseSvnDiffHeader):
1810
1811 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
1812
1813         Unreviewed, rolling out r111453.
1814         http://trac.webkit.org/changeset/111453
1815         https://bugs.webkit.org/show_bug.cgi?id=81600
1816
1817         still broken
1818
1819         * Scripts/webkitpy/layout_tests/port/server_process.py:
1820         (ServerProcess._reset):
1821         (ServerProcess.handle_interrupt):
1822         (ServerProcess.write):
1823         (ServerProcess._check_for_crash):
1824         (ServerProcess._handle_timeout):
1825         (ServerProcess._check_for_abort):
1826         (ServerProcess._read):
1827         (ServerProcess.stop):
1828         (ServerProcess):
1829         (ServerProcess.set_crashed):
1830         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1831         (TrivialMockPort.is_crash_reporter):
1832         (TestServerProcess.test_broken_pipe):
1833         * Scripts/webkitpy/layout_tests/port/webkit.py:
1834         (WebKitPort._read_image_diff):
1835         (WebKitDriver.has_crashed):
1836         (WebKitDriver._check_for_driver_crash):
1837         (WebKitDriver):
1838         (WebKitDriver._detected_crash):
1839         (WebKitDriver._subprocess_crashed):
1840         (WebKitDriver._crashed_process_name):
1841         (WebKitDriver.run_test):
1842         (WebKitDriver._read_block):
1843         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1844         (MockServerProcess.__init__):
1845
1846 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
1847
1848         webkitpy: get ServerProcess out of the reportcrash business
1849         https://bugs.webkit.org/show_bug.cgi?id=81600
1850
1851         Unreviewed, build fix.
1852
1853         Re-land r111307 and r111293 with fix for crash in NRWT; I
1854         was failing to set the crashing process name.
1855
1856         * Scripts/webkitpy/layout_tests/port/server_process.py:
1857         (ServerProcess._reset):
1858         (ServerProcess._handle_possible_interrupt):
1859         (ServerProcess.write):
1860         (ServerProcess.read_stdout):
1861         (ServerProcess.has_crashed):
1862         (ServerProcess._read):
1863         (ServerProcess.stop):
1864         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1865         (TrivialMockPort.check_for_leaks):
1866         (TestServerProcess.test_broken_pipe):
1867         * Scripts/webkitpy/layout_tests/port/webkit.py:
1868         (WebKitPort._read_image_diff):
1869         (WebKitDriver.has_crashed):
1870         (WebKitDriver._check_for_driver_crash):
1871         (WebKitDriver.run_test):
1872         (WebKitDriver._read_block):
1873         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1874         (MockServerProcess.__init__):
1875         (MockServerProcess):
1876         (MockServerProcess.has_crashed):
1877
1878 2012-03-20  Tim Horton  <timothy_horton@apple.com>
1879
1880         [mac] Restore color space switching code to run-webkit-tests
1881         https://bugs.webkit.org/show_bug.cgi?id=80571
1882         <rdar://problem/11008529>
1883
1884         Reviewed by Simon Fraser.
1885
1886         http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
1887         
1888         Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
1889         didn't exist until Lion.
1890
1891         * DumpRenderTree/mac/LayoutTestHelper.m:
1892         (installLayoutTestColorProfile):
1893         (restoreUserColorProfile):
1894
1895 2012-03-20  Adele Peterson  <adele@apple.com>
1896
1897         Update the last test to use EXPECT_WK_STREQ.
1898
1899         Reviewed by Dan Bernstein.
1900
1901         * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
1902
1903 2012-03-20  Adele Peterson  <adele@apple.com>
1904
1905         "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
1906         https://bugs.webkit.org/show_bug.cgi?id=81630
1907         <rdar://problem/10650660>
1908
1909         Reviewed by Alexey Proskuryakov.
1910
1911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1912         * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
1913         * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
1914         (-[AttributedStringTest webView:didFinishLoadForFrame:]):
1915         (TestWebKitAPI):
1916         (TestWebKitAPI::didFinishLoadForFrame):
1917         (TestWebKitAPI::TEST):
1918         * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
1919
1920 2012-03-20  Eric Seidel  <eric@webkit.org>
1921
1922         Add link on queues.webkit.org to kov's fancy queue-depth graph
1923         https://bugs.webkit.org/show_bug.cgi?id=81690
1924
1925         Reviewed by Adam Barth.
1926
1927         * QueueStatusServer/templates/recentstatus.html:
1928
1929 2012-03-20  Tim Horton  <timothy_horton@apple.com>
1930
1931         [mac] Restore color space switching code to run-webkit-tests
1932         https://bugs.webkit.org/show_bug.cgi?id=80571
1933         <rdar://problem/11008529>
1934
1935         Reviewed by Simon Fraser.
1936
1937         Make use of the layout test helper hooks to restore the Mac system-wide
1938         color profile switching code. This makes WkTR and DRT results match, and
1939         causes the main display's color profile to not affect results on Lion.
1940
1941         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1942         * DumpRenderTree/mac/LayoutTestHelper.m: Added.
1943         (installLayoutTestColorProfile):
1944         (restoreUserColorProfile):
1945         (simpleSignalHandler):
1946         (main):
1947         * Scripts/webkitpy/layout_tests/port/mac.py:
1948         (MacPort.release_http_lock):
1949         (MacPort):
1950         (MacPort._path_to_helper):
1951         (MacPort.start_helper):
1952         (MacPort.stop_helper):
1953         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1954         (WTR::PlatformWebView::PlatformWebView):
1955         (WTR::PlatformWebView::windowSnapshotImage):
1956
1957 2012-02-24  Darin Fisher  <darin@chromium.org>
1958
1959         Add more Chromium WebKit API reviewers
1960         https://bugs.webkit.org/show_bug.cgi?id=81576
1961
1962         Reviewed by Adam Barth and David Levin.
1963
1964         Simplify watchlist to lump all WebKit API into one.
1965
1966         * Scripts/webkitpy/common/config/watchlist:
1967
1968 2012-03-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1969
1970         Convert hasSpellingMarker to use Internals interface.
1971         https://bugs.webkit.org/show_bug.cgi?id=81300
1972
1973         Reviewed by Ryosuke Niwa.
1974
1975         Remove hasSpellingMarker functions, because it is able to work in the
1976         cross-port way through the Internals interface.
1977
1978         * DumpRenderTree/LayoutTestController.cpp:
1979         (LayoutTestController::staticFunctions):
1980         * DumpRenderTree/LayoutTestController.h:
1981         (LayoutTestController):
1982         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1983         * DumpRenderTree/chromium/LayoutTestController.cpp:
1984         (LayoutTestController::LayoutTestController):
1985         * DumpRenderTree/chromium/LayoutTestController.h:
1986         (LayoutTestController):
1987         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1988         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1989         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1990         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1991         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1992         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1993         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1994
1995 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
1996
1997         Add new Qt-WK2 performance tester bot to build.webkit.org
1998         https://bugs.webkit.org/show_bug.cgi?id=80842
1999
2000         Reviewed by Ryosuke Niwa.
2001
2002         * BuildSlaveSupport/build.webkit.org-config/config.json:
2003         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2004         (RunAndUploadPerfTestsWebKit2):
2005         (RunAndUploadPerfTestsWebKit2.start):
2006         (BuildAndPerfTestWebKit2Factory):
2007         (BuildAndPerfTestWebKit2Factory.__init__):
2008         (DownloadAndPerfTestWebKit2Factory):
2009         (DownloadAndPerfTestWebKit2Factory.__init__):
2010
2011 2012-03-20  Peter Beverloo  <peter@chromium.org>
2012
2013         [Chromium] Update to Android NDK r7b
2014         https://bugs.webkit.org/show_bug.cgi?id=81005
2015
2016         Reviewed by Adam Barth.
2017
2018         Update to version r7b of the Android NDK, release notes of which are
2019         available on the following page:
2020         http://developer.android.com/sdk/ndk/index.html
2021
2022         * Scripts/update-webkit-chromium:
2023
2024 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
2025
2026         x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
2027         https://bugs.webkit.org/show_bug.cgi?id=81502
2028
2029         Unreviewed.
2030
2031         * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
2032
2033 2012-03-19  Jessie Berlin  <jberlin@apple.com>
2034
2035         Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
2036         because they broke running the layout tests on mac.
2037
2038         * Scripts/webkitpy/layout_tests/port/webkit.py:
2039         (WebKitDriver._check_for_driver_crash):
2040
2041 2012-03-16  Martin Robinson  <mrobinson@igalia.com>
2042
2043         [GTK] Allow running run-gtk-tests during 'make distcheck'
2044         https://bugs.webkit.org/show_bug.cgi?id=81415
2045
2046         Reviewed by Philippe Normand.
2047
2048         Modify the build and run-gtk-tests so that it can run during 'make distcheck'
2049
2050         * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
2051         main command run during 'make check.'
2052         * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
2053         a requirement to run it. If jhbuild isn't around it will simply not start the
2054         SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
2055         main loop and simply use the main loop in a synchronous method to start SPI
2056         daemons. Did a bunch of general cleanup around these tasks.
2057
2058 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2059
2060         jhbuild: Use the multiprocessing module to get the number of CPUs.
2061         https://bugs.webkit.org/show_bug.cgi?id=81585
2062
2063         Reviewed by Martin Robinson.
2064
2065         Now that support for Python 2.5 has been dropped, we can safely
2066         use multiprocessing.cpu_count() to obtain the current number of
2067         CPUs in the system instead of running a webkitperl script for
2068         that.
2069
2070         * efl/common.py:
2071         (top_level_path):
2072         * efl/jhbuildrc:
2073         * gtk/common.py:
2074         (build_path):
2075         * gtk/jhbuildrc:
2076
2077 2012-03-19  Ojan Vafai  <ojan@chromium.org>
2078
2079         We should only add a live event listener once, not once per TestSelector.
2080         Adding one per TestSelector would cause accordion('option', 'active') to
2081         incorrectly be "false" if you examine multiple sets of tests.
2082
2083         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2084
2085 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2086
2087         Fix typo introduced in r111293.
2088
2089         Unreviewed, build fix.
2090
2091         * Scripts/webkitpy/layout_tests/port/webkit.py:
2092         (WebKitDriver._check_for_driver_crash):
2093
2094 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2095
2096         webkitpy: get ServerProcess out of the reportcrash business
2097         https://bugs.webkit.org/show_bug.cgi?id=81600
2098
2099         Reviewed by Adam Barth.
2100
2101         ServerProcess was half-aware that ReportCrash might run
2102         sometimes, and that the process ServerProcess was talking to
2103         might have its own crashing subprocesses; neither of these
2104         things really worked right and it made the logic convoluted, so
2105         this change makes handling crashes completely separate from the
2106         server_process code, so that it can focus on just I/O to the
2107         subprocess.
2108
2109         There should be no functional changes resulting from this patch.
2110
2111         * Scripts/webkitpy/layout_tests/port/server_process.py:
2112         (ServerProcess._reset):
2113         (ServerProcess._handle_possible_interrupt):
2114         (ServerProcess.write):
2115         (ServerProcess.read_stdout):
2116         (ServerProcess.has_crashed):
2117         (ServerProcess._read):
2118         (ServerProcess.stop):
2119         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2120         (TrivialMockPort.check_for_leaks):
2121         (TestServerProcess.test_broken_pipe):
2122         * Scripts/webkitpy/layout_tests/port/webkit.py:
2123         (WebKitPort._read_image_diff):
2124         (WebKitDriver.has_crashed):
2125         (WebKitDriver._check_for_driver_crash):
2126         (WebKitDriver.run_test):
2127         (WebKitDriver._read_block):
2128         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2129         (MockServerProcess.__init__):
2130         (MockServerProcess):
2131         (MockServerProcess.has_crashed):
2132
2133 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2134
2135         webkitpy: crashlog parsing is broken
2136         https://bugs.webkit.org/show_bug.cgi?id=81586
2137
2138         Reviewed by Adam Barth.
2139
2140         Seeking on a file opened through codecs() appears to not work
2141         correctly (at least on SL).
2142         
2143         The code was more complicated than it needed to be, so I have
2144         revamped it to just read a full crashlog at once and then look
2145         for matches. 
2146         
2147         I have also added the ability to optionally propagate
2148         errors back (which can be helpful to debug races when ReportCrash is
2149         still running and you need to see that you couldn't open some
2150         files, rather than just ignoring them).
2151
2152         * Scripts/webkitpy/common/system/crashlogs.py:
2153         (CrashLogs.find_newest_log):
2154         (CrashLogs._find_newest_log_darwin):
2155         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2156         (CrashLogsTest.test_find_log_darwin):
2157
2158 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2159
2160         webkitpy: clean up some port._filesystem references to not reference private members
2161         https://bugs.webkit.org/show_bug.cgi?id=81595
2162
2163         Reviewed by Eric Seidel.
2164
2165         There should be no functional changes in this patch, just some
2166         refactoring. Also, fixes a minor nit in write_image_diff_files(()
2167
2168         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2169         (SingleTestRunner.__init__):
2170         (SingleTestRunner._run_compare_test):
2171         (SingleTestRunner._run_rebaseline):
2172         (SingleTestRunner._save_baseline_data):
2173         (SingleTestRunner._handle_error):
2174         (SingleTestRunner._run_reftest):
2175         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2176         (write_test_result):
2177         (TestResultWriter.__init__):
2178         (TestResultWriter._make_output_directory):
2179         (TestResultWriter.output_filename):
2180         (TestResultWriter._output_testname):
2181         (TestResultWriter.write_output_files):
2182         (TestResultWriter.write_stderr):
2183         (TestResultWriter.write_crash_report):
2184         (TestResultWriter.create_text_diff_and_write_result):
2185         (TestResultWriter.write_image_diff_files):
2186         (copy_file):
2187         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2188         (TestResultWriterTest.test_reftest_diff_image):
2189
2190 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2191
2192         webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
2193         https://bugs.webkit.org/show_bug.cgi?id=81598
2194
2195         Reviewed by Eric Seidel.
2196
2197         "DumpRenderTree" shouldn't be hard-coded here, since some other
2198         process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
2199         
2200         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2201         (TestExpectations):
2202
2203 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2204
2205         webkitpy: allow instance data in TestFailure objects
2206         https://bugs.webkit.org/show_bug.cgi?id=81580
2207
2208         Reviewed by Tony Chang.
2209
2210         Current TestFailures are basically enums, but it would be nice,
2211         especially for crashes, if they contained the name and pid of
2212         the process that crashed.
2213
2214         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2215         (TestFailure.message):
2216         (FailureTimeout.message):
2217         (FailureCrash):
2218         (FailureCrash.__init__):
2219         (FailureCrash.message):
2220         (FailureMissingResult.message):
2221         (FailureTextMismatch.message):
2222         (FailureMissingImageHash.message):
2223         (FailureMissingImage.message):
2224         (FailureImageHashMismatch.message):
2225         (FailureImageHashIncorrect.message):
2226         (FailureReftestMismatch.message):
2227         (FailureReftestMismatchDidNotOccur.message):
2228         (FailureReftestNoImagesGenerated.message):
2229         (FailureMissingAudio.message):
2230         (FailureAudioMismatch.message):
2231         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
2232         (TestFailuresTest.test_equals):
2233         (TestFailuresTest):
2234         (TestFailuresTest.test_crashes):
2235
2236 2012-03-19  Brady Eidson  <beidson@apple.com>
2237
2238         <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
2239         Crash in 3rd party WebKit apps under XHR/Cache code
2240
2241         Reviewed by Antti Koivisto.
2242
2243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2244         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
2245         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
2246         (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2247         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2248         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2249         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2250         (TestWebKitAPI):
2251         (TestWebKitAPI::TEST):
2252
2253 2012-03-19  Brady Eidson  <beidson@apple.com>
2254
2255         <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
2256         REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
2257
2258         Reviewed by Enrica Casucci.
2259
2260         Bring up a context menu on a link, copy the link, then verify the pasteboard contents
2261         are in the correct format.
2262
2263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2264         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
2265         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
2266         (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
2267         (TestWebKitAPI::contextMenuCopyLink):
2268         (TestWebKitAPI::TEST):
2269
2270 2012-03-19  Ojan Vafai  <ojan@chromium.org>
2271
2272         Make the selected item in the accordion a link to the flakiness dashboard
2273         https://bugs.webkit.org/show_bug.cgi?id=81571
2274
2275         Reviewed by Dimitri Glazkov.
2276
2277         Also, make it so that you can select the text of the link, instead of the current behavior
2278         of acting as if you had clicked on the accordion header.
2279
2280         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2281         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2282
2283 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2284
2285         NRWT runs some tests that are skipped with -i command line option
2286         https://bugs.webkit.org/show_bug.cgi?id=81535
2287
2288         Reviewed by Ojan Vafai.
2289
2290         This change modifies the interaction of Skipped files and
2291         test_expectations files so that entries in Skipped files (and
2292         the -i command line) override *everything* in the expectations
2293         file.
2294
2295         Specifically, a directory in a Skipped file will cause all of
2296         the tests in the dir to be skipped even if individual tests in
2297         the dir are listed in the test_expectations.txt.
2298
2299         Skipped files also override anything in an overrides files.
2300
2301         This seems to make more intuitive sense, since if you list
2302         something in the Skips file (and even more specify it on the
2303         command line) you probably want it to be universally applied.
2304
2305         Theoretically we could add more precedence levels and have full
2306         paths in an expectations file override dirs in a Skipped file
2307         (but not the command line), but I don't know yet that that level
2308         of complexity is justified.
2309         
2310         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2311         (TestExpectations.__init__):
2312         (TestExpectations._add_skipped_tests):
2313         (TestExpectations._add_test):
2314         (TestExpectations._add_expectations):
2315         (TestExpectations._add_expectation_line):
2316         (TestExpectations._already_seen_better_match):
2317         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2318         (test_more_specific_override_resets_skip):
2319         (SkippedTests):
2320         (SkippedTests.get_exp):
2321         (SkippedTests.assert_exp):
2322         (SkippedTests.test_skipped_tests_work):
2323         (SkippedTests.test_duplicate_skipped_test_fails_lint):
2324         (SkippedTests.test_skipped_file_overrides_expectations):
2325         (SkippedTests.test_skipped_dir_overrides_expectations):
2326         (SkippedTests.test_skipped_file_overrides_overrides):
2327         (SkippedTests.test_skipped_dir_overrides_overrides):
2328
2329 2012-03-19  Eric Seidel  <eric@webkit.org>
2330
2331         Fix WTF header include discipline in Chromium WebKit
2332         https://bugs.webkit.org/show_bug.cgi?id=81281
2333
2334         Reviewed by James Robinson.
2335
2336         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2337         * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
2338
2339 2012-03-19  Andy Chen  <andchen@rim.com>
2340
2341         [BlackBerry] Add new layout test for text match marker
2342         https://bugs.webkit.org/show_bug.cgi?id=81531
2343
2344         Make the LayoutTestControllerBlackBerry::findString to test the
2345         BlackBerry port implementation.
2346
2347         Reviewed by Rob Buis.
2348
2349         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2350         (LayoutTestController::findString):
2351
2352 2012-03-19  Ojan Vafai  <ojan@chromium.org>
2353
2354         Don't show WONTFIX tests in garden-o-matic
2355         https://bugs.webkit.org/show_bug.cgi?id=81554
2356
2357         Reviewed by Dimitri Glazkov.
2358
2359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2360         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2361
2362 2012-03-19  Chris Fleizach  <cfleizach@apple.com>
2363
2364         platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
2365         https://bugs.webkit.org/show_bug.cgi?id=81530
2366
2367         Reviewed by Jessie Berlin.
2368
2369         Add rowAtIndex to WebKitTestRunner.
2370
2371         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2372         (WTR::AccessibilityUIElement::rowAtIndex):
2373         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2374         (AccessibilityUIElement):
2375         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2376         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2377         (WTR):
2378         (WTR::AccessibilityUIElement::rowAtIndex):
2379
2380 2012-03-19  Ojan Vafai  <ojan@chromium.org>
2381
2382         Change garden-o-matic All Failures tab to Expected Failures
2383         https://bugs.webkit.org/show_bug.cgi?id=81540
2384
2385         Reviewed by Dimitri Glazkov.
2386
2387         Also, fix some broken unittests that had just gotten stale.
2388
2389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
2391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2399
2400 2012-03-19  Hao Zheng  <zhenghao@chromium.org>
2401
2402         [chromium] DRT crashes at shutdown.
2403         https://bugs.webkit.org/show_bug.cgi?id=81504
2404
2405         Reviewed by James Robinson.
2406
2407         WebCompositor must be destroyed after WebView is properly destroyed,
2408         or some compositor objects like CCLayerTreeHost may not be destroyed.
2409         However, it is really hard to make the destruction order correct
2410         explicitly in ~TestShell. So move it out to DumpRenderTree.
2411
2412         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2413         (main):
2414         * DumpRenderTree/chromium/TestShell.cpp:
2415         (TestShell::~TestShell):
2416
2417 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2418
2419         add dpranke to webkitpy watchlist
2420         https://bugs.webkit.org/show_bug.cgi?id=81433
2421
2422         Reviewed by Benjamin Poulain.
2423
2424         * Scripts/webkitpy/common/config/watchlist:
2425
2426 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2427
2428         test-webkitpy is failing on SL/Python 2.6.1
2429         https://bugs.webkit.org/show_bug.cgi?id=81533
2430
2431         Reviewed by Ojan Vafai.
2432
2433         It appears that itertools.combinations() is buggy in 2.6.1; this
2434         backports the implementation from 2.7.
2435
2436         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2437         (TestConfigurationConverter.collapse_macros):
2438         (TestConfigurationConverter):
2439         (TestConfigurationConverter.combinations):
2440
2441 2012-03-19  David Michael Barr  <davidbarr@google.com>
2442
2443         Optimize the cleanup sequence in the start-queue.sh script
2444         https://github.com/abarth/webkit/pull/1
2445
2446         Reviewed by Adam Barth.
2447
2448         Updating the working copy is an expensive operation
2449         for a repository the size of WebKit.
2450         Attempt to reset only to the target revision.
2451
2452         * EWSTools/start-queue.sh:
2453
2454 2012-03-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
2455
2456         Adjust architecture type of the EFL build bot.
2457         https://bugs.webkit.org/show_bug.cgi?id=81452
2458
2459         Reviewed by Tony Chang.
2460
2461         * BuildSlaveSupport/build.webkit.org-config/config.json: The
2462         buildslave is a 64-bit machine, therefore describe it as being
2463         x86_64, not i386.
2464
2465 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
2466
2467         [Qt] printLoadedUrls prints "Object" instead of the actual URL.
2468         https://bugs.webkit.org/show_bug.cgi?id=81514
2469
2470         Reviewed by Simon Hausmann.
2471
2472         * MiniBrowser/qt/qml/BrowserWindow.qml:
2473
2474 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2475
2476         [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
2477         https://bugs.webkit.org/show_bug.cgi?id=81491
2478
2479         Reviewed by Philippe Normand.
2480
2481         For the find_path(), find_library() etc CMake calls to find the
2482         dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
2483         set, otherwise CMake cannot know the dependencies exist and will only
2484         look in the standard directories.
2485
2486         * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
2487         the jhbuild Root directory.
2488
2489 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2490
2491         [EFL] Add XDG env vars to jhbuildrc
2492         https://bugs.webkit.org/show_bug.cgi?id=81510
2493
2494         Needed to ensure correct glib behaviour in jhbuild environment.
2495
2496         Reviewed by Philippe Normand.
2497
2498         * efl/jhbuildrc:
2499
2500 2012-03-19  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2501
2502         Select best target for tap gesture.
2503         https://bugs.webkit.org/show_bug.cgi?id=78801
2504
2505         Reviewed by Kenneth Rohde Christiansen.
2506
2507         Add TOUCH_ADJUSTMENT to enabled features.
2508
2509         * qmake/mkspecs/features/features.prf:
2510
2511 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
2512
2513         [chromium] synthesize wheel events for fling on main thread
2514         https://bugs.webkit.org/show_bug.cgi?id=81458
2515
2516         Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
2517
2518         Reviewed by James Robinson.
2519
2520         * DumpRenderTree/chromium/EventSender.cpp:
2521         (EventSender::EventSender):
2522         (EventSender::gestureFlingCancel):
2523         (EventSender::gestureFlingStart):
2524         * DumpRenderTree/chromium/EventSender.h:
2525         (EventSender):
2526
2527 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
2528
2529         [Qt] Add command line option to set the user agent in the MiniBrowser
2530         https://bugs.webkit.org/show_bug.cgi?id=81508
2531
2532         Reviewed by Simon Hausmann.
2533
2534         * MiniBrowser/qt/BrowserWindow.cpp:
2535         (BrowserWindow::BrowserWindow):
2536         (BrowserWindow::webViewExperimental):
2537         * MiniBrowser/qt/BrowserWindow.h:
2538         (BrowserWindow):
2539         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2540         (printHelp):
2541         (MiniBrowserApplication::handleUserOptions):
2542         * MiniBrowser/qt/MiniBrowserApplication.h:
2543         (WindowOptions::WindowOptions):
2544         (WindowOptions::setUserAgent):
2545         (WindowOptions::userAgent):
2546         (WindowOptions):
2547
2548 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
2549
2550         [Qt] Remove dead user agent code from the MiniBrowser.
2551
2552         Reviewed by Simon Hausmann.
2553
2554         * MiniBrowser/qt/BrowserWindow.cpp:
2555         * MiniBrowser/qt/BrowserWindow.h:
2556         (BrowserWindow):
2557         * MiniBrowser/qt/MiniBrowser.qrc:
2558         * MiniBrowser/qt/useragentlist.txt: Removed.
2559
2560 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2561
2562         jhbuild: Call jhbuild's autogen.sh via bash.
2563         https://bugs.webkit.org/show_bug.cgi?id=81485
2564
2565         Reviewed by Philippe Normand.
2566
2567         jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
2568         this is usually true only on Linux systems, and even then bash for
2569         some reason might not be available in that location. It is safer to
2570         call bash directly and pass autogen.sh to it instead.
2571
2572         * jhbuild/jhbuild-wrapper:
2573         (install_jhbuild):
2574
2575 2012-03-19  Philippe Normand  <pnormand@igalia.com>
2576
2577         [GTK] Prefix run-launcher with run-with-jhbuild
2578         https://bugs.webkit.org/show_bug.cgi?id=81503
2579
2580         Reviewed by Hajime Morita.
2581
2582         * Scripts/run-launcher:
2583
2584 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2585
2586         [EFL] Prefix run-launcher with run-with-jhbuild
2587         https://bugs.webkit.org/show_bug.cgi?id=80026
2588
2589         Reviewed by Hajime Morita.
2590
2591         * Scripts/run-launcher:
2592
2593 2012-03-18  Csaba Osztrogonác  <ossy@webkit.org>
2594
2595         [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
2596         https://bugs.webkit.org/show_bug.cgi?id=81498
2597
2598         * qmake/mkspecs/features/unix/default_post.prf:
2599
2600 2012-03-17  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2601
2602         Unreviewed; switch to using my FreeBSD.org email address, the
2603         other one is going to disappear soon.
2604
2605         * Scripts/webkitpy/common/config/committers.py:
2606         * Scripts/webkitpy/common/config/watchlist:
2607
2608 2012-03-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
2609
2610         Unreviewed; fix webkitpy unit test failures after r111116.
2611
2612         It turns out that cmd_line in the patch in bug 80025 had the right
2613         signature when it was submitted, but r109242 added a few more
2614         required parameters, and since the method (and EflDriver) did not
2615         exist at the time we ended up committing a broken method.
2616
2617         * Scripts/webkitpy/layout_tests/port/efl.py:
2618         (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
2619         arguments.
2620
2621 2012-03-17  Charles Wei  <charles.wei@torchmobile.com.cn>
2622
2623         [BlackBerry] Enable Web Timing for performance profiling and improvement.
2624         https://bugs.webkit.org/show_bug.cgi?id=81085
2625
2626         Reviewed by Rob Buis.
2627
2628         * Scripts/build-webkit:
2629
2630 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2631
2632         Add a dependencies installation step for EFL to buildbot master.cfg
2633         https://bugs.webkit.org/show_bug.cgi?id=81337
2634
2635         Reviewed by Gustavo Noronha Silva.
2636
2637         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2638         (InstallEflDependencies):
2639         (Factory.__init__):
2640
2641 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2642
2643         [EFL] Prefixing run-webkit-tests with run-with-jhbuild
2644         https://bugs.webkit.org/show_bug.cgi?id=80025
2645
2646         Reviewed by Gustavo Noronha Silva.
2647
2648         * Scripts/webkitpy/layout_tests/port/efl.py:
2649         (EflDriver):
2650         (EflDriver.cmd_line):
2651         (EflPort._driver_class):
2652
2653 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2654
2655         [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
2656         https://bugs.webkit.org/show_bug.cgi?id=79904
2657
2658         build-webkit --efl will use jhbuild for fetching and building dependencies.
2659
2660         Reviewed by Gustavo Noronha Silva.
2661
2662         * Scripts/update-webkitefl-libs: Added.
2663         * Scripts/webkitdirs.pm:
2664         (jhbuildWrapperPrefixIfNeeded):
2665         (generateBuildSystemFromCMakeProject):
2666         (buildCMakeGeneratedProject):
2667         * efl/common.py: Added.
2668         (script_path):
2669         (top_level_path):
2670         (number_of_cpus):
2671         * efl/jhbuild.modules: Added.
2672         * efl/jhbuildrc: Added.
2673         * efl/run-with-jhbuild: Added.
2674
2675 2012-03-16  Stephanie Lewis  <slewis@apple.com>
2676
2677         https://bugs.webkit.org/show_bug.cgi?id=81065
2678         <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
2679         Fix crash preventing WebKitTestRunner from working in Release.  
2680         WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
2681         FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
2682         the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.
2683
2684         I removed ostringstream in favor of StringBuilder.  
2685
2686         Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
2687
2688         Reviewed by Geoff Garen.
2689
2690         Add DEBUG_DEFINES to set NDEBUG on release builds.
2691         * WebKitTestRunner/Configurations/Base.xcconfig:
2692         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2693
2694         Remove ostringstream member in favor of StringBuilder.
2695         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2696         (WTR::InjectedBundle::initialize):
2697         (WTR::InjectedBundle::beginTesting):
2698         (WTR::InjectedBundle::done):
2699         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2700         (WTF):
2701         (WTR::InjectedBundle::stringBuilder):
2702         (InjectedBundle):
2703
2704         Append output to StringBuilder.
2705         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2706         (WTR::hasPrefix):
2707         (WTR::dumpPath):
2708         (WTR::rangeToStr):
2709         (WTR::styleDecToStr):
2710         (WTR::frameToStr):
2711         (WTR::dumpFrameScrollPosition):
2712         (WTR::dumpFrameText):
2713         (WTR::dumpDescendantFramesText):
2714         (WTR::InjectedBundlePage::dump):
2715         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2716         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2717         (WTR::InjectedBundlePage::willSendRequestForFrame):
2718         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2719         (WTR::lastFileURLPathComponent):
2720         (WTR::InjectedBundlePage::willAddMessageToConsole):
2721         (WTR::InjectedBundlePage::willSetStatusbarText):
2722         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2723         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2724         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
2725         (WTR::InjectedBundlePage::shouldBeginEditing):
2726         (WTR::InjectedBundlePage::shouldEndEditing):
2727         (WTR::InjectedBundlePage::shouldInsertNode):
2728         (WTR::InjectedBundlePage::shouldInsertText):
2729         (WTR::InjectedBundlePage::shouldDeleteRange):
2730         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2731         (WTR::InjectedBundlePage::shouldApplyStyle):
2732         (WTR::InjectedBundlePage::didBeginEditing):
2733         (WTR::InjectedBundlePage::didEndEditing):
2734         (WTR::InjectedBundlePage::didChange):
2735         (WTR::InjectedBundlePage::didChangeSelection):
2736         (WTR::InjectedBundlePage::supportsFullScreen):
2737         (WTR::InjectedBundlePage::enterFullScreenForElement):
2738         (WTR::InjectedBundlePage::exitFullScreenForElement):
2739         (WTR::InjectedBundlePage::beganEnterFullScreen):
2740         (WTR::InjectedBundlePage::beganExitFullScreen):
2741         (WTR::dumpBackForwardListItem):
2742         (WTR::InjectedBundlePage::dumpBackForwardList):
2743         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2744         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
2745         (WTR::LayoutTestController::dumpConfigurationForViewport):
2746         
2747         Convert between WTF::String and WKStringRef.
2748         * WebKitTestRunner/StringFunctions.h:
2749         (WTR::toWTFString):
2750         (WTR):
2751         * WebKitTestRunner/TestInvocation.cpp:
2752         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2753
2754 2012-03-16  Eric Seidel  <eric@webkit.org>
2755
2756         Add a land-from-url command
2757         https://bugs.webkit.org/show_bug.cgi?id=81411
2758
2759         Reviewed by Adam Barth.
2760
2761         Very basic so far.  The goal is to make it landing smarter
2762         so that users don't have to bother to parse out the ids out of the urls.
2763
2764         * Scripts/webkitpy/common/config/urls.py:
2765         (parse_bug_id):
2766         (parse_attachment_id):
2767         * Scripts/webkitpy/common/config/urls_unittest.py:
2768         (URLsTest.test_parse_bug_id):
2769         (URLsTest):
2770         (URLsTest.test_parse_attachment_id):
2771         * Scripts/webkitpy/tool/commands/download.py:
2772         (ProcessURLsMixin):
2773         (ProcessURLsMixin._fetch_list_of_patches_to_process):
2774         (LandFromURL):
2775         * Scripts/webkitpy/tool/commands/download_unittest.py:
2776         (test_land_from_bug):
2777         (test_land_from_url):
2778
2779 2012-03-16  Dave Tharp  <dtharp@codeaurora.org>
2780
2781         build-webkit launcher instructions use wrong relative path for Qt
2782         https://bugs.webkit.org/show_bug.cgi?id=81357
2783
2784         Reviewed by Eric Seidel.
2785
2786         Ensure we are at the proper directory before generating run-launcher
2787         instructions.
2788
2789         * Scripts/build-webkit:
2790
2791 2012-03-16  Brady Eidson  <beidson@apple.com>
2792
2793         <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
2794         REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
2795
2796         Reviewed by Geoff Garen.
2797
2798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2799         * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
2800
2801 2012-03-16  Ojan Vafai  <ojan@chromium.org>
2802
2803         Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
2804         https://bugs.webkit.org/show_bug.cgi?id=81407
2805
2806         Reviewed by Adam Barth.
2807
2808         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2809         (summarize_results):
2810         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2811         (ResultSummaryTest.summarized_results):
2812         (ResultSummaryTest.test_no_svn_revision):
2813         (ResultSummaryTest.test_svn_revision):
2814         (ResultSummaryTest):
2815         (ResultSummaryTest.test_summarized_results_wontfix):
2816
2817 2012-03-16  Ojan Vafai  <ojan@chromium.org>
2818
2819         Have webkit-patch rebaseline-test update test_expectations.txt
2820         https://bugs.webkit.org/show_bug.cgi?id=81054
2821
2822         Recommit http://trac.webkit.org/changeset/110783 now that
2823         http://trac.webkit.org/changeset/111034 has landed.
2824
2825         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2826         (TestExpectations.remove_configuration_from_test):
2827         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2828         (RemoveConfigurationsTest):
2829         (RemoveConfigurationsTest.test_remove):
2830         (test_remove_line):
2831         * Scripts/webkitpy/tool/commands/rebaseline.py:
2832         (RebaselineTest._update_expectations_file):
2833         (RebaselineTest._rebaseline_test_and_update_expectations):
2834         (RebaselineTest):
2835         (RebaselineTest.execute):
2836         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2837         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2838         (test_rebaseline_updates_expectations_file):
2839
2840 2012-03-15  Ojan Vafai  <ojan@chromium.org>
2841
2842         Specifier collapsing when writing test expectations lines gets a number of cases wrong
2843         https://bugs.webkit.org/show_bug.cgi?id=81309
2844
2845         Reviewed by Dimitri Glazkov.
2846
2847         I've run this over all the lines in the current Chromium test_expectations.txt file,
2848         so I'm relatively confident we now cover all the cases.
2849
2850         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2851         (TestConfigurationConverter.__init__):
2852         (TestConfigurationConverter.collapse_macros):
2853         (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
2854         (TestConfigurationConverter):
2855         (TestConfigurationConverter.intersect_combination):
2856         (TestConfigurationConverter.symmetric_difference):
2857         (TestConfigurationConverter.to_specifiers_list):
2858         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2859         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2860         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2861         (make_mock_all_test_configurations_set):
2862         (TestConfigurationConverterTest.test_symmetric_difference):
2863         (TestConfigurationConverterTest.test_to_config_set):
2864         (TestConfigurationConverterTest.test_macro_expansion):
2865         (TestConfigurationConverterTest.test_to_specifier_lists):
2866         (TestConfigurationConverterTest.test_converter_macro_collapsing):
2867         * Scripts/webkitpy/layout_tests/port/chromium.py:
2868         (ChromiumPort):
2869         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2870         (ChromiumAndroidPort.__init__):
2871         The android port uses "arm" as it's architecture, which is technically correct,
2872         but considerably complicates making collapsing work. We probably should kill
2873         the concept of architecture entirely. The benefits are not worth the code
2874         complexity.
2875
2876         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2877         (ChromiumPortTest.test_all_test_configurations):
2878         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2879         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2880         (test_rebaseline_updates_expectations_file):
2881
2882 2012-03-16  Dinu Jacob  <dinu.jacob@nokia.com>
2883
2884         [Qt][Wk2] Assertion Failure and crash on file upload
2885         https://bugs.webkit.org/show_bug.cgi?id=80854
2886
2887         Reviewed by Simon Hausmann.
2888
2889         Added filePicker to WebView using experimental API.
2890
2891         * MiniBrowser/qt/MiniBrowser.qrc:
2892         * MiniBrowser/qt/icons/folder.png: Added.
2893         * MiniBrowser/qt/icons/titlebar.png: Added.
2894         * MiniBrowser/qt/icons/up.png: Added.
2895         * MiniBrowser/qt/qml/BrowserWindow.qml:
2896         * MiniBrowser/qt/qml/FilePicker.qml: Added.
2897
2898 2012-03-16  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2899
2900         Updating email for committer.py script.
2901
2902         * Scripts/webkitpy/common/config/committers.py:
2903
2904 2012-03-16  Robert Kroeger  <rjkroege@chromium.org>
2905
2906         [chromium] DRT: Add support for sending gesture scrolls without a begin
2907         https://bugs.webkit.org/show_bug.cgi?id=81292
2908
2909         Reviewed by Kent Tamura.
2910
2911         * DumpRenderTree/chromium/EventSender.cpp:
2912         (EventSender::EventSender):
2913         (EventSender::gestureScrollFirstPoint):
2914         * DumpRenderTree/chromium/EventSender.h:
2915         (EventSender):
2916
2917 2012-03-02  Carlos Garcia Campos  <cgarcia@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
2918
2919         [GTK] WebKitIconDatabase doesn't keep icons cached
2920         https://bugs.webkit.org/show_bug.cgi?id=56200
2921
2922         Reviewed by Martin Robinson.
2923
2924         Add support for favicons in GtkLauncher.
2925
2926         * GtkLauncher/main.c:
2927         (activateUriEntryCb):
2928         (iconLoadedCb):
2929         (createBrowser):
2930
2931 2012-03-16  Adam Barth  <abarth@webkit.org>
2932
2933         Remove sheriff-bot's last-green-revision command
2934         https://bugs.webkit.org/show_bug.cgi?id=81314
2935
2936         Reviewed by Eric Seidel.
2937
2938         This command is a cruel joke.  WebKit doesn't really ever have a
2939         last-green-revision.
2940
2941         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2942         (BuildBot._find_green_revision):
2943         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2944         (MockBuildBot.builder_statuses):
2945         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2946         (test_find_green_revision):
2947         * Scripts/webkitpy/tool/bot/irc_command.py:
2948         (IRCCommand.execute):
2949         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2950         (SheriffIRCBotTest.test_help):
2951         * Scripts/webkitpy/tool/commands/queries.py:
2952         (PatchesToReview.execute):
2953
2954 2012-03-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2955
2956         [Qt] Make gccdepends test aware of broken icecream deps generation
2957
2958         Icecream seems to build the files without passing -o to gcc with
2959         the original destination path, which means the target name in the
2960         dependency file is wrong.
2961
2962         Also, echo something to the final file instead of just touching it,
2963         so it's not deleted on every build.
2964
2965         Reviewed by Simon Hausmann.
2966
2967         * qmake/config.tests/gccdepends/gccdepends.pro:
2968
2969 2012-03-16  Kihong Kwon  <kihong.kwon@samsung.com>
2970
2971         Support for Battery Status API
2972         https://bugs.webkit.org/show_bug.cgi?id=62698
2973
2974         Add include directory and file.
2975         http://www.w3.org/TR/battery-status/
2976
2977         Reviewed by Adam Barth.
2978
2979         * Scripts/build-webkit:
2980
2981 2012-03-16  Kishore Bolisetty  <kbolisetty@innominds.com>
2982
2983         check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
2984         https://bugs.webkit.org/show_bug.cgi?id=81007
2985
2986         Reviewed by Adam Barth.
2987
2988         A dedidcated build slave is available for efl on build.webkit.org. 
2989         This change add's an entry for the elf port in list of available port builders.
2990         This is required because test_expectations.py when triggered, looks for a valid port object for the specified port. 
2991
2992         * Scripts/webkitpy/layout_tests/port/builders.py:
2993
2994 2012-03-16  Adam Barth  <abarth@webkit.org>
2995
2996         [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
2997         https://bugs.webkit.org/show_bug.cgi?id=81302
2998
2999         Reviewed by Eric Seidel.
3000
3001         This is a trivial patch, but the variable name turned up in a grep of
3002         webkitpy and looks like copy pasta.
3003
3004         * Scripts/webkitpy/common/net/statusserver.py:
3005         (StatusServer.next_work_item):
3006
3007 2012-03-16  Andrew Lo  <anlo@rim.com>
3008
3009         [BlackBerry] Enable PAGE_VISIBILITY_API
3010         https://bugs.webkit.org/show_bug.cgi?id=81257
3011
3012         Enable Page Visibility API for BlackBerry.
3013
3014         Reviewed by Rob Buis.
3015
3016         * Scripts/build-webkit:
3017
3018 2012-03-16  Zan Dobersek  <zandobersek@gmail.com>
3019
3020         [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
3021         https://bugs.webkit.org/show_bug.cgi?id=81232
3022
3023         Reviewed by Philippe Normand.
3024
3025         Use the newly-added helper method in DumpRenderTreeSupportGtk.
3026
3027         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3028         (LayoutTestController::computedStyleIncludingVisitedInfo):
3029
3030 2012-03-15  Eric Seidel  <eric@webkit.org>
3031
3032         Move parse_bug_id into config/urls in preparation for re-use elsewhere.
3033         https://bugs.webkit.org/show_bug.cgi?id=81313
3034
3035         Reviewed by Adam Barth.
3036
3037         * Scripts/webkitpy/common/checkout/changelog.py:
3038         (parse_bug_id_from_changelog):
3039         * Scripts/webkitpy/common/config/urls.py:
3040         (parse_bug_id):
3041         * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
3042         (URLsTest):
3043         (URLsTest.test_parse_bug_id):
3044         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3045         (test_parse_bug_id):
3046         * Scripts/webkitpy/tool/bot/irc_command.py:
3047         (_post_error_and_check_for_bug_url):
3048         * Scripts/webkitpy/tool/bot/sheriff.py:
3049         (Sheriff.post_rollout_patch):
3050         (Sheriff.post_chromium_deps_roll):
3051
3052 2012-03-15  Adam Barth  <abarth@webkit.org>
3053
3054         The commit-queue should fast-track patches that have already passed the testing EWS bots
3055         https://bugs.webkit.org/show_bug.cgi?id=81305
3056
3057         Reviewed by Eric Seidel.
3058
3059         If a patch has already passed the testing EWS bots (currently only the
3060         chromium-ews bot), we should be able to land the patch without running
3061         the tests again.  This patch is somewhat risky in that the tests might
3062         have been broken between when the EWS bots ran and when the
3063         commit-queue is processing the patch.  If that turns out to be a
3064         problem in practice, we'll tighten up this fast-track in some way,
3065         likely by making sure that the pass status is recent.
3066
3067         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3068         (CommitQueueTaskDelegate.did_pass_testing_ews):
3069         (CommitQueueTask._did_pass_tests_recently):
3070         (CommitQueueTask.run):
3071         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3072         (MockCommitQueue.did_pass_testing_ews):
3073         (test_fast_success_case):
3074         * Scripts/webkitpy/tool/commands/queues.py:
3075         (CommitQueue.did_pass_testing_ews):
3076         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3077         (test_did_pass_testing_ews):
3078
3079 2012-03-15  Kentaro Hara  <haraken@chromium.org>
3080
3081         [PerformanceTests] run-perf-tests should output correct units
3082         https://bugs.webkit.org/show_bug.cgi?id=78303
3083
3084         Reviewed by Ryosuke Niwa.
3085
3086         Previously run-perf-tests just supported "ms" for units.
3087         Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
3088         This patch fixes run-perf-tests so that they can support custom units.
3089         The default unit is "ms".
3090
3091         The test result looks like this:
3092
3093         $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
3094         RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
3095         median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
3096
3097         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3098         (PerfTestsRunner._process_parser_test_result):
3099
3100 2012-03-15  Brent Fulgham  <bfulgham@webkit.org>
3101
3102         [WinCairo] Unreviewed build change after wtf path changes.
3103
3104         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
3105         directories to look at the private header directory to find 'wtf'.
3106
3107 2012-03-15  Kent Tamura  <tkent@chromium.org>
3108
3109         REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
3110         https://bugs.webkit.org/show_bug.cgi?id=81293
3111
3112         Reviewed by Adam Barth.
3113
3114         r110595 introduced new format of the author field of ChangeLog entry:
3115         "Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>"
3116         Updte chanelog.py to support it.
3117
3118         * Scripts/webkitpy/common/checkout/changelog.py:
3119         (ChangeLogEntry._split_contributor_names):
3120         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3121         (test_parse_authors):
3122
3123 2012-03-15  Lynn Neir  <lynn.neir@skype.net>
3124
3125         Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
3126
3127         Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
3128
3129         Reviewed by Jessie Berlin.
3130
3131         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3132         (LayoutTestController::setValueForUser):
3133         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3134         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3135         (WTR::LayoutTestController::setValueForUser):
3136         (WTR):
3137         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3138         (LayoutTestController):
3139
3140 2012-03-15  Adam Barth  <abarth@webkit.org>
3141
3142         Update the start-queue.sh script to match what we're using on the bots
3143         https://bugs.webkit.org/show_bug.cgi?id=81277
3144
3145         Reviewed by Eric Seidel.
3146
3147         Over time we've added more magic git commands to clean up the local repo after
3148         it has been borked in various ways. The idea behind this sequence is to clear
3149         out any changes in the working copy and then to rebuild the master branch from
3150         origin/master.
3151
3152         This patch also removes the watchdog timer that we've stopped using on the
3153         bots.
3154
3155         This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
3156         Note: Eric and I are experimenting with GitHub to see if it might be
3157         useful for WebKit.  If you have thoughts on this topic, please feel
3158         free to grab Eric or me on #webkit to chat.  I assume that he and I are
3159         the only ones who care about this file so using this alternative
3160         process for this patch shouldn't cause any trouble.
3161
3162         * EWSTools/start-queue.sh:
3163
3164 2012-03-15  Adam Barth  <abarth@webkit.org>
3165
3166         The commit-queue can hang when the test_expectations.txt style check fails during commit
3167         https://bugs.webkit.org/show_bug.cgi?id=81251
3168
3169         Reviewed by Eric Seidel.
3170
3171         We forgot to check the --non-interactive flag, so we end up prompting
3172         the "user" who doesn't exist on the bot.  We might consider teaching
3173         the User class about non-interactive if we have this sort of bug again.
3174
3175         * Scripts/webkitpy/tool/steps/commit.py:
3176         (Commit.options):
3177         (Commit._check_test_expectations):
3178         (Commit.run):
3179         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3180         (CommitTest.test_check_test_expectations):
3181
3182 2012-03-15  Jessie Berlin  <jberlin@apple.com>
3183
3184         fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
3185         Mac WK2 because WebAudio is not enabled
3186         https://bugs.webkit.org/show_bug.cgi?id=81259
3187
3188         Reviewed by Dan Bernstein.
3189
3190         Enable WebAudio so that it appears in the window object in the tests.
3191         The webaudio tests are all still skipped in the Mac Skipped list.
3192
3193         * WebKitTestRunner/TestController.cpp:
3194         (WTR::TestController::resetStateToConsistentValues):
3195
3196 2012-03-15  David Levin  <levin@chromium.org>
3197
3198         Various autoresize fixes.
3199         https://bugs.webkit.org/show_bug.cgi?id=81199
3200
3201         Reviewed by Darin Fisher.
3202
3203         * DumpRenderTree/chromium/LayoutTestController.cpp:
3204         (LayoutTestController::reset): Stop using the deprecated api that was removed.
3205
3206 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3207
3208         [GTK] Actually use --release and --debug command line options in run-gtk-test
3209         https://bugs.webkit.org/show_bug.cgi?id=81234
3210
3211         Reviewed by Philippe Normand.
3212
3213         Actually handle --release and --debug command line options to
3214         create the build directory, falling back to current hack to detect
3215         whether it's a Release or Debug build when both options are missed.
3216
3217         * Scripts/run-gtk-tests:
3218         (TestRunner.__init__): Receive options too.
3219         (TestRunner._get_top_level_directory): Helper function to get the
3220         top level directory.
3221         (TestRunner._get_build_directory): Helper function to get the
3222         build directory depending on --release/--debug command line
3223         options or gessing it if both options are missing.
3224         (TestRunner._ensure_accessibility_daemon_is_running): Use
3225         self-options now.
3226         (TestRunner.run): Ditto.
3227         (TestRunner.run.run_tests): Pass options to the constructor
3228         instead of run().
3229
3230 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3231
3232         [GTK] Run unit tests with --verbose in the bots
3233         https://bugs.webkit.org/show_bug.cgi?id=81230
3234
3235         Reviewed by Martin Robinson.
3236
3237         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3238         (RunGtkAPITests): Add --verbose to run-gtk-test command.
3239
3240 2012-03-15  Kevin Ollivier  <kevino@theolliviers.com>
3241
3242         Move wx port to using export macros
3243         https://bugs.webkit.org/show_bug.cgi?id=77279
3244
3245         Reviewed by Hajime Morita.
3246
3247         * waf/build/settings.py:
3248         (common_configure):
3249
3250 2012-03-15  Philippe Normand  <pnormand@igalia.com>
3251
3252         Unreviewed, GTK build fix attempt after r110845.
3253
3254         * Scripts/run-gtk-tests: Added --release and --debug options.
3255
3256 2012-03-15  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3257
3258         Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
3259         https://bugs.webkit.org/show_bug.cgi?id=79673
3260
3261         Preparatory work for bringing jhbuild enabled build to EFL port.
3262
3263         Reviewed by Philippe Normand.
3264
3265         * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
3266         * Scripts/update-webkitgtk-libs:
3267         * gtk/run-with-jhbuild:
3268         * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
3269         (top_level_path):
3270         (jhbuild_installed):
3271         (jhbuild_cloned):
3272         (jhbuild_at_expected_revision):
3273         (update_jhbuild):
3274         (clone_jhbuild):
3275         (install_jhbuild):
3276         (update_webkit_libs_jhbuild):
3277         (determine_platform):
3278         (ensure_jhbuild):
3279
3280 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3281
3282         [GTK] Add command line options to run-gtk-tests script
3283         https://bugs.webkit.org/show_bug.cgi?id=81218
3284
3285         Reviewed by Philippe Normand.
3286
3287         Following command line options have been added:
3288
3289         -v, --verbose: to run gtester with --verbose. That would be used
3290         by the bots to make it easier to know which test case it failing.
3291
3292         --display: to use a different display for Xvfb
3293
3294         It's also possible to pass one or more tests as arguments.
3295
3296         * Scripts/run-gtk-tests:
3297         (TestRunner.__init__): Receive command line arguments.
3298         (TestRunner._get_tests): Get all the tests or the ones passed by
3299         command line arguments.
3300         (TestRunner._ensure_accessibility_daemon_is_running): Use display
3301         command line argument.
3302         (TestRunner.run): Pas command line options.
3303         (TestRunner.run.run_tests): Pass command line arguments.
3304
3305 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3306
3307         [GTK] WebKit2APITests/TestPrinting timeout in the bots
3308         https://bugs.webkit.org/show_bug.cgi?id=81211
3309
3310         Reviewed by Philippe Normand.
3311
3312         Add gtk+ patch to fix timeout in the bots. A similar patch has
3313         already landed in updatream gtk+, see
3314         http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
3315
3316         * gtk/jhbuild.modules:
3317         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
3318
3319 2012-03-14  Gustavo Noronha Silva  <gns@gnome.org>
3320
3321         sheriffbot should also be addressable with a comma in addition to colon
3322         https://bugs.webkit.org/show_bug.cgi?id=81101
3323
3324         Reviewed by Adam Barth.
3325
3326         * Scripts/webkitpy/common/net/irc/ircbot.py:
3327         (IRCBot.on_pubmsg):
3328
3329 2012-03-15  Alexander Færøy  <alexander.faeroy@nokia.com>
3330
3331         [Qt] MiniBrowser scroll indicators should not scroll out of view
3332         https://bugs.webkit.org/show_bug.cgi?id=81131
3333
3334         Reviewed by Kenneth Rohde Christiansen.
3335
3336         * MiniBrowser/qt/qml/ScrollIndicator.qml:
3337
3338 2012-03-14  Chris Fleizach  <cfleizach@apple.com>
3339
3340         AX: ARIA tables need to support selected rows attribute/select rows changed notification
3341         https://bugs.webkit.org/show_bug.cgi?id=79821
3342
3343         Reviewed by Beth Dakin.
3344
3345         * DumpRenderTree/AccessibilityUIElement.cpp:
3346         (rowAtIndexCallback):
3347         (AccessibilityUIElement::getJSClass):
3348         * DumpRenderTree/AccessibilityUIElement.h:
3349         (AccessibilityUIElement):
3350         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3351         (AccessibilityUIElement::rowAtIndex):
3352         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3353         (AccessibilityUIElement::rowAtIndex):
3354         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3355         (AccessibilityUIElement::rowAtIndex):
3356         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3357         (AccessibilityUIElement::rowAtIndex):
3358
3359 2012-03-14  Tim Horton  <timothy_horton@apple.com>
3360
3361         NRWT should respect --additional-platform-directory's Skipped list
3362         https://bugs.webkit.org/show_bug.cgi?id=81172
3363
3364         Reviewed by Timothy Hatcher.
3365
3366         Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
3367         from said path are already used, but the Skipped file is ignored.
3368
3369         * Scripts/webkitpy/layout_tests/port/webkit.py:
3370         (WebKitPort._skipped_file_search_paths):
3371         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3372         (test_skipped_file_search_paths):
3373
3374 2012-03-14  Ojan Vafai  <ojan@chromium.org>
3375
3376         Unreviewed, rolling out r110783.
3377         http://trac.webkit.org/changeset/110783
3378         https://bugs.webkit.org/show_bug.cgi?id=81054
3379
3380         Caused existing test expectation lines to expand to one for
3381         each test configuration.
3382
3383         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3384         (TestExpectations.has_warnings):
3385         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3386         (test_macro_overrides):
3387         * Scripts/webkitpy/tool/commands/rebaseline.py:
3388         (RebaselineTest._save_baseline):
3389         (RebaselineTest._rebaseline_test):
3390         (RebaselineTest.execute):
3391         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3392         (TestRebaseline.test_tests_to_update):
3393
3394 2012-03-13  Jon Lee  <jonlee@apple.com>
3395
3396         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
3397         https://bugs.webkit.org/show_bug.cgi?id=80922
3398         <rdar://problem/11035082>
3399
3400         Reviewed by Jian Li.
3401
3402         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
3403         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
3404         new API. Therefore, APIs that are common between the two will have:
3405         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
3406
3407         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
3408         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
3409
3410         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
3411         * DumpRenderTree/chromium/LayoutTestController.cpp:
3412         (LayoutTestController::grantDesktopNotificationPermission):
3413         (LayoutTestController::simulateDesktopNotificationClick):
3414         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3415         * DumpRenderTree/chromium/TestShell.cpp:
3416         (TestShell::TestShell):
3417         (TestShell::resetTestController):
3418         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3419         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3420
3421 2012-03-13  Ojan Vafai  <ojan@chromium.org>
3422
3423         Have webkit-patch rebaseline-test update test_expectations.txt
3424         https://bugs.webkit.org/show_bug.cgi?id=81054
3425
3426         Reviewed by Dirk Pranke.
3427
3428         This will allow us to use the All Failures tab in garden-o-matic
3429         to rebaseline tests without making test_expectations.txt stale.
3430
3431         It's conservative and only removes lines if the test is
3432         not flaky and fails in a way the rebaseline would fix (e.g.
3433         CRASH/TIMEOUT will not be touched).
3434
3435         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3436         (TestExpectations.remove_configuration_from_test):
3437         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3438         (RemoveConfigurationsTest):
3439         (RemoveConfigurationsTest.test_remove):
3440         (test_remove_line):
3441         * Scripts/webkitpy/tool/commands/rebaseline.py:
3442         (RebaselineTest._is_supported_port):
3443         (RebaselineTest):
3444         (RebaselineTest._update_expectations_file):
3445         (RebaselineTest._rebaseline_test_and_update_expectations):
3446         (RebaselineTest.execute):
3447         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3448         (TestRebaseline.test_rebaseline_updates_expectations_file):
3449
3450 2012-03-14  Jessie Berlin  <jberlin@apple.com>
3451
3452         Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
3453         https://bugs.webkit.org/show_bug.cgi?id=81167
3454
3455         Reviewed by Sam Weinig.
3456
3457         Do not use 0 as a key in a HashMap.
3458
3459         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3460         cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
3461
3462 2012-03-14  Ojan Vafai  <ojan@chromium.org>
3463
3464         Add the chromium lion bot to garden-o-matic and remove
3465         the platform_move_to in builders.py since the Chromium Lion
3466         port is now a normal port.
3467
3468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3469         * Scripts/webkitpy/layout_tests/port/builders.py:
3470
3471 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
3472
3473         Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
3474
3475         Unreviewed, build fix.
3476
3477         * Scripts/webkitpy/layout_tests/port/base.py:
3478         (Port.skipped_tests):
3479
3480 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
3481
3482         Please add a way to manually skip some tests in NRWT
3483         https://bugs.webkit.org/show_bug.cgi?id=81019
3484
3485         Reviewed by Ojan Vafai.
3486
3487         This patch implements the -i / --ignore-tests flag from ORWT
3488         and refactors the test_expectations.py code slightly to handle
3489         it.
3490
3491         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3492         (Manager.parse_expectations):
3493         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3494         (TestExpectations.__init__):
3495         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3496         (test_add_skipped_tests):
3497         (test_add_skipped_tests_duplicate):
3498         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3499         (parse_args):
3500         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3501         (MainTest.test_ignore_tests):
3502         (MainTest.test_ignore_tests.assert_ignored):
3503
3504 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
3505
3506         nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
3507         https://bugs.webkit.org/show_bug.cgi?id=81028
3508
3509         Reviewed by Ojan Vafai.
3510
3511         The mac port had incorrect lookups for 'mac-lion' and
3512         'mac-future' in some places. This patch fixes that and adds a
3513         bunch of tests.
3514
3515         * Scripts/webkitpy/layout_tests/port/mac.py:
3516         (MacPort.baseline_path):
3517         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3518         (MacTest.assert_skipped_file_search_paths):
3519         (MacTest.test_skipped_file_search_paths):
3520         (_assert_search_path):
3521         (test_baseline_search_path):
3522         * Scripts/webkitpy/layout_tests/port/webkit.py:
3523         (WebKitPort._skipped_file_search_paths):
3524
3525 2012-03-13  Jer Noble  <jer.noble@apple.com>
3526
3527         Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
3528         https://bugs.webkit.org/show_bug.cgi?id=81056
3529
3530         Reviewed by Jessie Berlin.
3531
3532         Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
3533
3534         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3535         (WTR::InjectedBundlePage::InjectedBundlePage):
3536         (WTR::InjectedBundlePage::beganEnterFullScreen):
3537         (WTR::InjectedBundlePage::beganExitFullScreen):
3538
3539 2012-03-14  Alexander Færøy  <alexander.faeroy@nokia.com>
3540
3541         The width and height of the scroll indicators in the MiniBrowser does
3542         not consider the offset margins.
3543         https://bugs.webkit.org/show_bug.cgi?id=81112
3544
3545         Reviewed by Kenneth Rohde Christiansen.
3546
3547         This patch fixes the issue by withdrawing two times the anchor
3548         margins.
3549
3550         * MiniBrowser/qt/qml/ScrollIndicator.qml:
3551
3552 2012-03-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3553
3554         [EFL] Implement LayoutTestController::clearBackForwardList
3555         https://bugs.webkit.org/show_bug.cgi?id=80142
3556
3557         Adding missing implementation clearBackForwardList to EFL's
3558         LayoutTestController. This implementation allows us to unskip 
3559         tests connected with history.
3560
3561         Reviewed by Antonio Gomes.
3562
3563         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3564         (LayoutTestController::clearBackForwardList): Implemented.
3565
3566 2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3567
3568         [EFL][DRT] Expose window.internals object
3569         https://bugs.webkit.org/show_bug.cgi?id=79900
3570
3571         Exposes window.internals for EFL's DRT. Makes possible to
3572         remove some tests from the skip list.
3573
3574         Reviewed by Antonio Gomes.
3575
3576         * DumpRenderTree/efl/CMakeLists.txt:
3577         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3578         (DumpRenderTreeChrome::onWindowObjectCleared):
3579
3580 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
3581
3582         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
3583         https://bugs.webkit.org/show_bug.cgi?id=78853
3584
3585         Reviewed by Adam Barth.
3586
3587         * Scripts/build-webkit:
3588         * qmake/mkspecs/features/features.prf:
3589
3590 2012-03-12  Antonio Gomes  <agomes@rim.com>
3591
3592         Convert nodesFromRect tests to use Internals interface
3593         https://bugs.webkit.org/show_bug.cgi?id=80886
3594
3595         Reviewed by Ryosuke Niwa.
3596
3597         This clean up allows to remove port specific bits of each
3598         DRT implementation that supports testing Document::nodesFromRect,
3599         in favor of making use of the 'Internals' interface to test it.
3600
3601         This makes its code conveniently more expansible and cleaner.
3602
3603         Also removed stubs from Win and EFL DRTs.
3604
3605         * DumpRenderTree/LayoutTestController.cpp:
3606         (LayoutTestController::staticFunctions):
3607         * DumpRenderTree/LayoutTestController.h:
3608         (LayoutTestController):
3609         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3610         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3611         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3612         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3613         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3614         (LayoutTestController):
3615         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3616
3617 2012-03-13  Ojan Vafai  <ojan@chromium.org>
3618
3619         Rebaselining for a new port doesn't work right with multiple fallback ports
3620         https://bugs.webkit.org/show_bug.cgi?id=80932
3621
3622         Reviewed by Adam Barth.
3623
3624         Since chromium-leopard also falls back to mac-leopard, we need to
3625         copy the existing result for both chromium-leopard and chromium-snowleopard
3626         before doing lion rebaselines.
3627
3628         * Scripts/webkitpy/layout_tests/port/builders.py:
3629         (fallback_port_names_for_new_port):
3630         * Scripts/webkitpy/tool/commands/rebaseline.py:
3631         (RebaselineTest):
3632         (RebaselineTest._copy_existing_baseline):
3633         (RebaselineTest._rebaseline_test):
3634         (RebaselineTest.execute):
3635         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3636         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3637         (GardeningHTTPRequestHandler.rebaseline):
3638         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3639         (GardeningServerTest.test_rebaseline_new_port):
3640
3641 2012-03-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3642
3643         [Qt] Tweak minibrowser UI
3644
3645         Add some margins to the scroll indicators, and set a dark background
3646         color so you see the page dimensions.
3647
3648         Reviewed by Antonio Gomes.
3649
3650         * MiniBrowser/qt/qml/BrowserWindow.qml:
3651         * MiniBrowser/qt/qml/ScrollIndicator.qml:
3652
3653 2012-03-13  ChangSeok Oh  <shivamidow@gmail.com>
3654
3655         [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
3656         https://bugs.webkit.org/show_bug.cgi?id=79601
3657
3658         Reviewed by Gustavo Noronha Silva.
3659
3660         Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
3661         createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
3662         and is taken over to sendKeyDown.
3663         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
3664         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
3665
3666         * DumpRenderTree/efl/EventSender.cpp:
3667         (KeyEventInfo::KeyEventInfo):
3668         (KeyEventInfo):
3669         (createKeyEventInfo):
3670         (sendKeyDown):
3671         (keyDownCallback):
3672         (sendAsynchronousKeyDown):
3673         (scheduleAsynchronousKeyDownCallback):
3674
3675 2012-03-12  Ojan Vafai  <ojan@chromium.org>
3676
3677         webkit-patch optimize-baselines sometimes creates a mac-future result
3678         https://bugs.webkit.org/show_bug.cgi?id=80717
3679
3680         Reviewed by Adam Barth.
3681
3682         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3683         (_baseline_search_hypergraph):
3684         (BaselineOptimizer._find_optimal_result_placement):
3685         (BaselineOptimizer._filter_virtual_ports):
3686         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3687         (BaselineOptimizerTest.test_no_add_mac_future):
3688
3689 2012-03-12  Jessie Berlin  <jberlin@apple.com>
3690
3691         More Windows build fixing.
3692
3693         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3694
3695 2012-03-12  Jessie Berlin  <jberlin@apple.com>
3696
3697         More Windows build fixing.
3698
3699         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3700         * DumpRenderTree/win/EditingDelegate.cpp:
3701         * DumpRenderTree/win/EventSender.cpp:
3702         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3703         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3704         * DumpRenderTree/win/UIDelegate.cpp:
3705
3706 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
3707
3708         remove the 'gpu' group from the flakiness dashboard
3709         https://bugs.webkit.org/show_bug.cgi?id=80353
3710
3711         Reviewed by Adam Barth.
3712
3713         Since those bots are obsolete, we don't need this any more.
3714
3715         * TestResultServer/static-dashboards/builders.js:
3716         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3717         (testPlatformAndBuildType):
3718         (testHtmlForTestTypeSwitcherGroup):
3719
3720 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
3721
3722         remove graphics_type from webkitpy.layout_tests.models.test_configuration
3723         https://bugs.webkit.org/show_bug.cgi?id=80643
3724
3725         Reviewed by Ojan Vafai.
3726
3727         Now that the chromium-gpu ports are gone, there's no need for
3728         the graphics_type CPU/GPU distinction. Most of this change is
3729         just updating tests accordingly.
3730
3731         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3732         (TestExpectationEditorTests):
3733         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3734         (TestConfiguration.__init__):
3735         (TestConfiguration.category_order):
3736         (TestConfiguration.__str__):
3737         (TestConfiguration.__repr__):
3738         (TestConfiguration.__hash__):
3739         (TestConfigurationConverter.to_specifiers_list):
3740         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3741         (make_mock_all_test_configurations_set):
3742         (TestConfigurationTest.test_items):
3743         (TestConfigurationTest.test_keys):
3744         (TestConfigurationTest.test_str):
3745         (TestConfigurationTest.test_repr):
3746         (TestConfigurationTest.test_hash):
3747         (TestConfigurationTest.test_hash.query_unknown_key):
3748         (TestConfigurationTest.test_eq):
3749         (TestConfigurationTest.test_values):
3750         (SpecifierSorterTest.test_specifier_priority):
3751         (SpecifierSorterTest.test_sort_specifiers):
3752         (TestConfigurationConverterTest.test_to_config_set):
3753         (TestConfigurationConverterTest.test_macro_expansion):
3754         (TestConfigurationConverterTest.test_to_specifier_lists):
3755         (TestConfigurationConverterTest.test_converter_macro_collapsing):
3756         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3757         (test_error_on_different_build_type):
3758         (TestExpectationSerializerTests.test_parsed_to_string):
3759         (TestExpectationSerializerTests.test_reconstitute_only_these):
3760         * Scripts/webkitpy/layout_tests/port/apple.py:
3761         (ApplePort._generate_all_test_configurations):
3762         * Scripts/webkitpy/layout_tests/port/base.py:
3763         (Port.__init__):
3764         (Port.name):
3765         (Port.version):
3766         (Port.test_configuration):
3767         * Scripts/webkitpy/layout_tests/port/builders.py:
3768         * Scripts/webkitpy/layout_tests/port/chromium.py:
3769         (ChromiumPort):
3770         (ChromiumPort._generate_all_test_configurations):
3771         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3772         (ChromiumLinuxPort.__init__):
3773         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3774         (ChromiumLinuxPortTest.test_check_illegal_port_names):
3775         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3776         (ChromiumMacPortTest.test_baseline_path):
3777         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3778         (ChromiumPortTest.test_all_test_configurations):
3779         * Scripts/webkitpy/layout_tests/port/efl.py:
3780         (EflPort._generate_all_test_configurations):
3781         * Scripts/webkitpy/layout_tests/port/gtk.py:
3782         (GtkPort._generate_all_test_configurations):
3783         * Scripts/webkitpy/layout_tests/port/qt.py:
3784         (QtPort._generate_all_test_configurations):
3785         * Scripts/webkitpy/layout_tests/port/test.py:
3786         (TestPort.all_test_configurations):
3787         (TestPort._all_build_types):
3788         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3789         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3790         (BuildCoverageExtrapolatorTest.test_extrapolate):
3791         (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
3792         (GardeningExpectationsUpdaterTest.test_add_new_expectation):
3793         (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
3794         (GardeningExpectationsUpdaterTest.test_pass_expectation):
3795         (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
3796         (GardeningExpectationsUpdaterTest.test_spurious_updates):
3797
3798 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
3799
3800         _runtime_feature_list isn't supported on Apple Mac DRT
3801         https://bugs.webkit.org/show_bug.cgi?id=80906
3802
3803         Reviewed by Eric Seidel.
3804
3805         It looks like this feature is actually only supported on the Win
3806         DRT port, so this patch reworks the code to make that clearer
3807         and reduce unnecessary overrides.
3808
3809         * Scripts/webkitpy/layout_tests/port/efl.py:
3810         (EflPort._path_to_webcore_library):
3811         * Scripts/webkitpy/layout_tests/port/gtk.py:
3812         (GtkPort._path_to_webcore_library):
3813         * Scripts/webkitpy/layout_tests/port/qt.py:
3814         (QtPort._skipped_file_search_paths):
3815         * Scripts/webkitpy/layout_tests/port/webkit.py:
3816         (WebKitPort._runtime_feature_list):
3817         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3818         (TestWebKitPort.__init__):
3819         (TestWebKitPort.all_test_configurations):
3820         (test_skipped_directories_for_features):
3821         * Scripts/webkitpy/layout_tests/port/win.py:
3822         (WinPort):
3823         (WinPort._runtime_feature_list):
3824         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3825         (WinPortTest.test_operating_system):
3826         (WinPortTest):
3827         (WinPortTest.test_runtime_feature_list):
3828
3829 2012-03-12  Peter Beverloo  <peter@chromium.org>
3830
3831         [Chromium] Temporary build-fix for the Android bot
3832         https://bugs.webkit.org/show_bug.cgi?id=80862
3833
3834         Reviewed by Adam Barth.
3835
3836         Manually set the environmental variables required to compile source
3837         files through the Android NDK instead of relying on the envsetup.sh
3838         script. A proper fix will be landed to Chromium ASAP, and following
3839         a Chromium roll into WebKit this code will be removed.
3840
3841         * Scripts/webkitdirs.pm:
3842         (buildChromiumMakefile):
3843
3844 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3845
3846         [Qt] Use right construct to detect config_test_gccdepends
3847
3848         Reviewed by Andreas Kling.
3849
3850         * qmake/mkspecs/features/default_pre.prf:
3851
3852 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3853
3854         [Qt] Expose location of WebKit's bin and imports dir through module file
3855
3856         Reviewed by Andreas Kling.
3857
3858         * qmake/qt_webkit.pri:
3859
3860 2012-03-12  Andras Becsi  <andras.becsi@nokia.com>
3861
3862         [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
3863         https://bugs.webkit.org/show_bug.cgi?id=80832
3864
3865         Reviewed by Tor Arne Vestbø.
3866
3867         Add a basic scroll indicator component to MiniBrowser so that it
3868         behaves similar to the ScrollDecorator QML component.
3869
3870         * MiniBrowser/qt/MiniBrowser.qrc:
3871         * MiniBrowser/qt/qml/BrowserWindow.qml:
3872         * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
3873
3874 2012-03-12  C Anthony Risinger  <anthony@xtfx.me>
3875
3876         [GTK] r110296 included an extra $ in @$(AM_V_GEN)
3877         https://bugs.webkit.org/show_bug.cgi?id=80809
3878
3879         Reviewed by Philippe Normand.
3880
3881         * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
3882
3883 2012-03-12  Ming Xie  <mxie@rim.com>
3884
3885         [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
3886         https://bugs.webkit.org/show_bug.cgi?id=80812
3887
3888         Reviewed by Rob Buis.
3889
3890         * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
3891         * Scripts/webkitdirs.pm:
3892         (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
3893
3894
3895 2012-03-12  Simon Hausmann  <simon.hausmann@nokia.com>
3896
3897         [Qt] Fix build with newer Qt 5.
3898
3899         Reviewed by Tor Arne Vestbø.
3900
3901         Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
3902         renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
3903         we should disable -Werror.
3904
3905         Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
3906         implicit load was removed recently.
3907
3908         * qmake/mkspecs/features/default_pre.prf:
3909         * qmake/mkspecs/features/unix/default_post.prf:
3910
3911 2012-03-11  Maciej Stachowiak  <mjs@apple.com>
3912
3913         Add --instruments option to sunspider to profile with Instruments
3914         https://bugs.webkit.org/show_bug.cgi?id=80783
3915
3916         Reviewed by Filip Pizlo.
3917
3918         * Scripts/run-sunspider:
3919
3920 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3921
3922         [Qt] [WK2] Support threaded renderer in WK2
3923         https://bugs.webkit.org/show_bug.cgi?id=76661
3924
3925         Remove disabling of threaded rendering.
3926
3927         Reviewed by Noam Rosenthal.
3928
3929         * MiniBrowser/qt/main.cpp:
3930         (main):
3931
3932 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
3933
3934         [WK2] run-perf-tests should be able to run with WTR
3935         https://bugs.webkit.org/show_bug.cgi?id=80042
3936
3937         Reviewed by Martin Robinson.
3938
3939         Add an option to PerfTestRunner to use WebKitTestRunner instead of
3940         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
3941         to avoid timing out when running performance tests.
3942
3943         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3944         (PerfTestsRunner._parse_args):
3945         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3946         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
3947         to true.
3948         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
3949         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
3950         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3951         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
3952         publicly accessible.
3953         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3954         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
3955         is required.
3956         * WebKitTestRunner/TestController.cpp:
3957         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
3958         to true.
3959         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
3960         if '--no-timeout' option is present.
3961         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
3962         value, or -1.0 if timeout should not occur.
3963         * WebKitTestRunner/TestController.h:
3964         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
3965         publicly accessible.
3966         * WebKitTestRunner/TestInvocation.cpp:
3967         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
3968         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
3969         Waiting for final message should not time out if not necessary.
3970         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3971         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
3972         * WebKitTestRunner/qt/TestControllerQt.cpp:
3973         (WTR::TestController::platformRunUntil): Ditto.
3974         * WebKitTestRunner/mac/TestControllerMac.mm:
3975         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
3976         is missing.
3977         * WebKitTestRunner/win/TestControllerWin.cpp:
3978         (WTR::TestController::platformRunUntil): Ditto.
3979
3980 2012-03-09  Jon Lee  <jonlee@apple.com>
3981
3982         Rename NotificationPresenter to NotificationClient
3983         https://bugs.webkit.org/show_bug.cgi?id=80488
3984         <rdar://problem/10965558>
3985
3986         Reviewed by Kentaro Hara.
3987
3988         Refactor to use renamed WebCore::NotificationClient.
3989         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3990         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3991
3992 2012-03-07  James Robinson  <jamesr@chromium.org>
3993
3994         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
3995         https://bugs.webkit.org/show_bug.cgi?id=80523
3996
3997         Reviewed by Darin Fisher.
3998
3999         * DumpRenderTree/chromium/WebViewHost.cpp:
4000         (WebViewHost::createGraphicsContext3D):
4001         * DumpRenderTree/chromium/WebViewHost.h:
4002         (WebViewHost):
4003
4004 2012-03-09  Eric Seidel  <eric@webkit.org>
4005
4006         build-webkit should build Source/WTF on Mac
4007         https://bugs.webkit.org/show_bug.cgi?id=80728
4008
4009         Reviewed by Adam Barth.
4010
4011         We'll add other ports to this list in future commits.
4012
4013         * Scripts/build-webkit:
4014
4015 2012-03-09  Jon Lee  <jonlee@apple.com>
4016
4017         Add support for ENABLE(LEGACY_NOTIFICATIONS)
4018         https://bugs.webkit.org/show_bug.cgi?id=80497
4019
4020         Reviewed by Adam Barth.
4021
4022         Prep for b80472: Update API for Web Notifications
4023         * Scripts/build-webkit:
4024         * qmake/mkspecs/features/features.prf:
4025
4026 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
4027
4028         Bash scripts should support LF endings only
4029         https://bugs.webkit.org/show_bug.cgi?id=79509
4030
4031         Reviewed by David Kilzer.
4032
4033         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
4034         * EWSTools/start-queue.sh: Added property svn:eol-style.
4035         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
4036         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
4037         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
4038         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
4039
4040 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
4041
4042         [BUILD] use detected python to run generate-gtkdoc
4043         https://bugs.webkit.org/show_bug.cgi?id=80695
4044
4045         Reviewed by Gustavo Noronha Silva.
4046
4047         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
4048
4049 2012-03-09  Nat Duca  <nduca@chromium.org>
4050
4051         Make check-webkit-style complain about "no new tests" lines in changelogs
4052         https://bugs.webkit.org/show_bug.cgi?id=80582
4053
4054         Reviewed by David Levin.
4055
4056         * Scripts/webkitpy/style/checkers/changelog.py:
4057         (ChangeLogChecker.check_entry):
4058         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
4059         (ChangeLogCheckerTest.test_no_new_tests):
4060
4061 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
4062
4063         Unreviewed, rolling out r110250.
4064         http://trac.webkit.org/changeset/110250
4065         https://bugs.webkit.org/show_bug.cgi?id=80682
4066
4067         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
4068         qt-linux at all. (Requested by Ossy on #webkit).
4069
4070         * Scripts/old-run-webkit-tests:
4071         * Scripts/webkitpy/layout_tests/port/qt.py:
4072         (QtPort):
4073         (QtPort.determine_full_port_name):
4074         (QtPort.baseline_search_path):
4075         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4076         (QtPortTest):
4077         (QtPortTest._assert_search_path):
4078         (QtPortTest.test_baseline_search_path):
4079
4080 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4081
4082         [Qt] Use Qt's module system for install rules and depending on QtWebKit
4083
4084         Instead of rolling our own install rules we now use the same approach as
4085         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
4086
4087         This ensures that we follow the same semantics as the rest of Qt on
4088         what sort of config options are enabled by default (create_cmake eg.).
4089         It also allows us to use QT += webkit instead of the workaround we had
4090         with CONFIG += qtwebkit.
4091
4092         We do however force Qt to always treat our build as a non-developer build,
4093         so the libraries will end up in the WebKit lib directory instead of the
4094         qtbase directory (as with a normal developer-build). This allows us to
4095         keep the webkit-build self-contained. If Qt is a developer build we still
4096         copy the module file manually to Qt, so that you don't have to install
4097         WebKit to make it available.
4098
4099         For non-developer builds of Qt, it is still possible to use the built
4100         WebKit libraries without having to install them, by having the variable
4101         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
4102         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
4103
4104         https://bugs.webkit.org/show_bug.cgi?id=80590
4105
4106         Reviewed by Simon Hausmann.
4107
4108         * DumpRenderTree/qt/DumpRenderTree.pro:
4109         * MiniBrowser/qt/BrowserWindow.cpp:
4110         * MiniBrowser/qt/MiniBrowser.pro:
4111         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4112         * MiniBrowser/qt/UrlLoader.cpp:
4113         * QtTestBrowser/QtTestBrowser.pro:
4114         * Tools.pro:
4115         * WebKitTestRunner/InjectedBundle/Target.pri:
4116         * WebKitTestRunner/Target.pri:
4117         * qmake/mkspecs/features/default_post.prf:
4118         * qmake/mkspecs/features/default_pre.prf:
4119         * qmake/mkspecs/features/functions.prf:
4120         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
4121         * qmake/mkspecs/features/qtwebkit.prf:
4122         * qmake/mkspecs/features/rpath.prf:
4123         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
4124         * qmake/qt_webkit.pri: Added.
4125
4126 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
4127
4128         Unreviewed. Update my email.
4129
4130         * Scripts/webkitpy/common/config/committers.py:
4131
4132 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
4133
4134         Recent changes to chromium.py etc. broke chromium_android.py
4135         https://bugs.webkit.org/show_bug.cgi?id=80623
4136
4137         Reviewed by Dirk Pranke.
4138
4139         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4140         (ChromiumAndroidDriver.__init__):
4141         (ChromiumAndroidDriver._start):
4142
4143 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
4144
4145         [Chromium] Exception running reftest with --no-pixel-tests
4146         https://bugs.webkit.org/show_bug.cgi?id=80642
4147
4148         Reviewed by Dirk Pranke.
4149
4150         * Scripts/webkitpy/layout_tests/port/chromium.py:
4151         (ChromiumDriver.__init__):
4152         (ChromiumDriver._wrapper_options):
4153
4154 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
4155
4156         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
4157         https://bugs.webkit.org/show_bug.cgi?id=72489
4158
4159         Reviewed by Dirk Pranke.
4160
4161         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
4162         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
4163         --platform will override the platform name and then we'll use it.
4164
4165         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
4166         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
4167         override it in the end.
4168
4169         * Scripts/old-run-webkit-tests:
4170         * Scripts/webkitpy/layout_tests/port/qt.py:
4171         (QtPort):
4172         (QtPort.determine_full_port_name):
4173         (QtPort.baseline_search_path):
4174         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4175         (QtPortTest):
4176         (QtPortTest._assert_search_path):
4177         (QtPortTest.test_baseline_search_path):
4178
4179 2012-03-08  Beth Dakin  <bdakin@apple.com>
4180
4181         https://bugs.webkit.org/show_bug.cgi?id=80463
4182         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
4183         -and corresponding-
4184         <rdar://problem/10970221>
4185
4186         Reviewed by Dan Bernstein.
4187
4188         New test!
4189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4190         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
4191         (TestWebKitAPI):
4192         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
4193         (TestWebKitAPI::setPageLoaderClient):
4194         (TestWebKitAPI::TEST):
4195         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
4196         (TestWebKitAPI):
4197         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
4198         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
4199         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
4200         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
4201
4202 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4203
4204         [Qt] Prospective Windows build fix
4205
4206         Don't assume that windows-builds will always run inside a cmd.exe shell.
4207
4208         * qmake/mkspecs/features/default_pre.prf:
4209
4210 2012-03-08  Dan Bernstein  <mitz@apple.com>
4211
4212         <rdar://problem/10981173> Dashboard regions should not be in device space
4213
4214         Reviewed by John Sullivan.
4215
4216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4217         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
4218         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
4219         (TestWebKitAPI):
4220         (TestWebKitAPI::TEST):
4221
4222 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
4223
4224         webkit-patch works oddly on local Git branches
4225         https://bugs.webkit.org/show_bug.cgi?id=76958
4226
4227         Reviewed by Ojan Vafai.
4228
4229         This change makes the '-g' flag to webkit-patch behave a
4230         little more consistently with git. The 'HEAD..' syntax
4231         is changed to 'HEAD....' (four dots), so as to not
4232         collide with the underlying git syntax. We also generalize
4233         the syntax to support any refname, so 'foo....' means
4234         diff against foo and include working copy changes.
4235
4236         This change also adds the 'UPSTREAM' shortcut to identify
4237         whatever the current upstream/tracking branch is; this is
4238         useful if you have multiple local branches stacked up.
4239
4240         * Scripts/webkitpy/common/checkout/scm/git.py:
4241         (Git._branch_from_ref):
4242         (Git):
4243         (Git._current_branch):
4244         (Git._upstream_branch):
4245         (Git.merge_base):
4246         (Git._commit_on_branch):
4247         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4248         (GitSVNTest._second_local_commit):
4249         (GitSVNTest._two_local_commits):
4250         (GitSVNTest.test_commit_with_message_git_commit_range):
4251         (GitSVNTest.test_upstream_branch):
4252         (GitSVNTest.test_create_patch_working_copy_only):
4253         (GitSVNTest.test_changed_files_local_plus_working_copy):
4254         (GitSVNTest.test_changed_files_working_copy_only):
4255         (GitSVNTest.test_changed_files_upstream):
4256         * Scripts/webkitpy/tool/steps/options.py:
4257         (Options):
4258
4259 2012-03-08  John Sullivan  <sullivan@apple.com>
4260
4261         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
4262
4263         Reviewed by Eric Carlson.
4264
4265         * Scripts/extract-localizable-strings:
4266         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
4267         with NSLocalized. Also improved an error message to include the troublesome token.
4268
4269 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
4270
4271         Unreviewed, rolling out r110115.
4272         http://trac.webkit.org/changeset/110115
4273         https://bugs.webkit.org/show_bug.cgi?id=80581
4274
4275         broke test-webkitpy (Requested by philn-tp on #webkit).
4276
4277         * Scripts/old-run-webkit-tests:
4278         * Scripts/webkitpy/layout_tests/port/qt.py:
4279         (QtPort):
4280         (QtPort.determine_full_port_name):
4281         (QtPort.baseline_search_path):
4282
4283 2012-03-08  Kentaro Hara  <haraken@chromium.org>
4284
4285         Unreviewed. Added myself to watchlist.
4286
4287         * Scripts/webkitpy/common/config/watchlist:
4288
4289 2012-03-07  Jessie Berlin  <jberlin@apple.com>
4290
4291         Clean Windows build fails after r110033
4292         https://bugs.webkit.org/show_bug.cgi?id=80553
4293
4294         Rubber-stamped by Jon Honeycutt and Eric Seidel.
4295
4296         Add the new JavaScriptCore include directory to some more vsprops files.
4297
4298         * DumpRenderTree/win/ImageDiffCommon.vsprops:
4299         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
4300         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
4301
4302 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
4303
4304         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
4305         https://bugs.webkit.org/show_bug.cgi?id=72489
4306
4307         Reviewed by Dirk Pranke.
4308
4309         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
4310         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
4311         --platform will override the platform name and then we'll use it.
4312
4313         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
4314         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
4315         override it in the end.
4316
4317         * Scripts/old-run-webkit-tests:
4318         * Scripts/webkitpy/layout_tests/port/qt.py:
4319         (QtPort):
4320         (QtPort.determine_full_port_name):
4321         (QtPort.baseline_search_path):
4322
4323 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
4324
4325         [Qt][WK2] MiniBrowser on desktop does not react to click events
4326         https://bugs.webkit.org/show_bug.cgi?id=80314
4327
4328         Reviewed by Kenneth Rohde Christiansen.
4329
4330         Do not enable touch mocking on desktop mode.
4331
4332         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4333         (MiniBrowserApplication::handleUserOptions):
4334
4335 2012-03-07  Ojan Vafai  <ojan@chromium.org>
4336
4337         Automatically move to the next test after rebaseline in the results view
4338         https://bugs.webkit.org/show_bug.cgi?id=80527
4339
4340         Reviewed by Dimitri Glazkov.
4341
4342         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
4343         * Bu