Resource Load Statistics: Report user interaction immediately, but only when needed
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-04  John Wilander  <wilander@apple.com>
2
3         Resource Load Statistics: Report user interaction immediately, but only when needed
4         https://bugs.webkit.org/show_bug.cgi?id=175090
5         <rdar://problem/33685546>
6
7         Reviewed by Chris Dumez.
8
9         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
10         (WTR::InjectedBundle::beginTesting):
11             Now calls WebCore::ResourceLoadObserver::clearState().
12
13 2017-08-03  Brian Burg  <bburg@apple.com>
14
15         Remove ENABLE(WEB_SOCKET) guards
16         https://bugs.webkit.org/show_bug.cgi?id=167044
17
18         Reviewed by Joseph Pecoraro.
19
20         * Scripts/webkitperl/FeatureList.pm:
21         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
22
23 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
24
25         REGRESSION(r219850): run-benchmark script broken on Linux
26         https://bugs.webkit.org/show_bug.cgi?id=175126
27
28         Reviewed by Stephanie Lewis.
29
30         The run-benchmark script dynamically generates the list of supported
31         browsers and platforms (currently Linux and OSX) by loading all
32         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
33         and getting the browser_name and platform variables from the
34         classes defined there.
35
36         This means that this classes should not raise an exception when
37         loaded on other platforms or otherwise they will broke the whole
38         script. Its fine if they raise an exception when executing any of
39         the methods they implement, but not when just loading/importing
40         the class.
41
42         Move the argument variable definitions that call on the platform
43         specific OSXBrowserDriver._screen_size() function from beeing
44         variables that are evaluated when loading the file, to be functions
45         that are only evaluated when the actual functionality needs to be
46         executed.
47
48         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
49         (OSXChromeDriver.launch_url):
50         (OSXChromeCanaryDriver.launch_url):
51         (create_args):
52         (create_chrome_options):
53         (create_window_size_arg):
54         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
55         (OSXFirefoxDriver.launch_url):
56         (OSXFirefoxNightlyDriver.launch_url):
57         (OSXFirefoxNightlyDriver.launch_driver):
58         (create_args):
59
60 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
61
62         [PAL] Move spi/cf directory into PAL
63         https://bugs.webkit.org/show_bug.cgi?id=175057
64
65         Reviewed by Antti Koivisto.
66
67         * Scripts/webkitpy/style/checker.py:
68         * Scripts/webkitpy/style/checker_unittest.py:
69         (GlobalVariablesTest.test_path_rules_specifier):
70
71         Ignore "readability/naming/underscores" style errors for sources
72         under the WebCore/PAL/pal/spi directory.
73
74         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
75
76 2017-08-03  Youenn Fablet  <youenn@apple.com>
77
78         Remove FETCH_API compilation guard
79         https://bugs.webkit.org/show_bug.cgi?id=175154
80
81         Reviewed by Chris Dumez.
82
83         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
84
85 2017-08-03  Lucas Forschler  <lforschler@apple.com>
86
87         Enable archive minification on iOS builds
88         https://bugs.webkit.org/show_bug.cgi?id=174718
89         
90         Reviewed by Aakash Jain.
91
92         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
93         (BuildFactory.__init__):
94
95 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
96
97         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
98         https://bugs.webkit.org/show_bug.cgi?id=175140
99
100         Reviewed by Alexey Proskuryakov.
101
102         We are having lately issues with JSC tests causing problems on
103         the GTK+ and WPE bots due to the high amount of memory some tests
104         need to run.
105
106         The best thing we can do now is to workaround this by disabling
107         all the tests marked as memoryLimited on the GTK and WPE bots.
108         We may revise this on the future.
109
110         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
111         (RunJavaScriptCoreTests.start):
112
113 2017-08-03  Brady Eidson  <beidson@apple.com>
114
115         Add SW IDLs and stub out basic functionality.
116         https://bugs.webkit.org/show_bug.cgi?id=175115
117
118         Reviewed by Chris Dumez.
119
120         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
121
122         * Scripts/webkitpy/bindings/main.py:
123
124 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
125
126         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
127         https://bugs.webkit.org/show_bug.cgi?id=159510
128
129         Reviewed by Daniel Bates.
130
131         Allow any https certificate when running tests.
132
133         * DumpRenderTree/win/DumpRenderTree.cpp:
134         (runTest):
135
136 2017-08-02  Youenn Fablet  <youenn@apple.com>
137
138         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
139         https://bugs.webkit.org/show_bug.cgi?id=175089
140
141         Reviewed by Chris Dumez.
142
143         * DumpRenderTree/TestOptions.mm:
144         (TestOptions::TestOptions): Using absolutePath if available.
145         * DumpRenderTree/mac/DumpRenderTree.mm:
146         (computeTestURL): Removing http/tests/ specific URL computation.
147         * Scripts/webkitpy/port/driver.py:
148         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
149
150 2017-08-02  Lucas Forschler  <lforschler@apple.com>
151
152         download-built-product should allow for a proxy option
153         https://bugs.webkit.org/show_bug.cgi?id=174875
154
155         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
156
157         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
158         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
159         
160
161 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
162
163         check-webkit-style: deleting lines in a file runs the linter on the whole file
164         https://bugs.webkit.org/show_bug.cgi?id=175078
165
166         Reviewed by David Kilzer.
167
168         Deleting lines in a file should not cause linter errors to be blamed on the patch.
169         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
170
171         * Scripts/webkitpy/style/checkers/test_expectations.py:
172         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
173         * Scripts/webkitpy/style/main_unittest.py:
174         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
175         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
176         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
177
178 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
179
180         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
181         https://bugs.webkit.org/show_bug.cgi?id=175075
182
183         Reviewed by David Kilzer.
184
185         We have no way of handling text files with illegal unicode characters. Allow the callers of
186         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
187         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
188
189         * Scripts/webkitpy/common/system/filesystem.py:
190         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
191         (FileSystem.write_text_file): Ditto.
192         * Scripts/webkitpy/common/system/filesystem_mock.py:
193         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
194         (MockFileSystem.write_text_file): Ditto.
195         * Scripts/webkitpy/common/system/filesystem_unittest.py:
196         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
197         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
198
199 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
200
201         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
202         https://bugs.webkit.org/show_bug.cgi?id=175072
203
204         Reviewed by Alexey Proskuryakov.
205
206         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
207         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
208
209 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
210
211         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
212         https://bugs.webkit.org/show_bug.cgi?id=175019
213
214         Reviewed by Darin Adler.
215
216         * TestWebKitAPI/CMakeLists.txt:
217
218 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
219
220         Enabling uploading archives to S3
221         https://bugs.webkit.org/show_bug.cgi?id=174198
222
223         Unreviewed unit test fix after r219235.
224
225         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
226
227 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
228
229         Fix JSCOnly ARM buildbots after r220047
230         https://bugs.webkit.org/show_bug.cgi?id=174993
231
232         Unreviewed fix after r220087.
233
234         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
235         (BuildAndRemoteJSCTestsFactory.__init__):
236
237 2017-08-01  Chris Dumez  <cdumez@apple.com>
238
239         Add initial support for navigator.sendBeacon
240         https://bugs.webkit.org/show_bug.cgi?id=175007
241         <rdar://problem/33547728>
242
243         Reviewed by Sam Weinig.
244
245         Enable the Beacon API at runtime in the context of layout tests since the
246         feature is currently disabled by default.
247
248         * DumpRenderTree/mac/DumpRenderTree.mm:
249         (enableExperimentalFeatures):
250         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
251         (WTR::InjectedBundle::beginTesting):
252         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
253         (WTR::TestRunner::setModernMediaControlsEnabled):
254         (WTR::TestRunner::setBeaconAPIEnabled):
255         * WebKitTestRunner/InjectedBundle/TestRunner.h:
256
257 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
258
259         Update Bot Watcher's Dashboard for Buildbot 0.9
260         https://bugs.webkit.org/show_bug.cgi?id=174777
261
262         Reviewed by Daniel Bates.
263
264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
265         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
266         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
267         in a dictionary.
268         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
269         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
271         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
272         (parseRevisionProperty): Ditto.
273         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
274         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
275         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
276         have changed in Buildbot 0.9.
277         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
278         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
279         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
280         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
281         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
282         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
283         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
284         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
285         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
286         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
287         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
288         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
289         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
290         (BuildbotQueue.prototype.get overviewURL): Ditto.
291         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
292         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
293         Buildbot 0.8 or 0.9.
294         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
295         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
296         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
297         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
298         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
299         Therefore we are fetching information for fixed number of build. 
300         Also iterating the loop incrementally since the build data is already reverse sorted.
301         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
302         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
303         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
305         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
306
307 2017-08-01  Devin Rousso  <drousso@apple.com>
308
309         Web Inspector: simplify WebInspector with WI
310         https://bugs.webkit.org/show_bug.cgi?id=175058
311
312         Reviewed by Joseph Pecoraro.
313
314         * Scripts/check-inspector-strings:
315         (extract_ui_strings):
316         * Scripts/extract-localizable-js-strings:
317
318 2017-08-01  Youenn Fablet  <youenn@apple.com>
319
320         Layout tests with 'https' suffix should be run over HTTPS
321         https://bugs.webkit.org/show_bug.cgi?id=174992
322
323         Reviewed by Chris Dumez.
324
325         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
326         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
327         Covered by corresponding unit tests.
328
329         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
330         (run_server):
331         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
332         (base_http_url):
333         (base_https_url):
334         (base_url): Deleted.
335         * Scripts/webkitpy/port/base.py:
336         (Port.to.web_platform_test_server_base_http_url):
337         (Port.to):
338         (Port.to.web_platform_test_server_base_https_url):
339         (Port.to.web_platform_test_server_base_url): Deleted.
340         * Scripts/webkitpy/port/driver.py:
341         (Driver.__init__):
342         (Driver.wpt_test_path_to_uri):
343         (Driver):
344         (Driver.http_test_path_to_uri):
345         (Driver.test_to_uri):
346         (Driver.uri_to_test):
347         * Scripts/webkitpy/port/driver_unittest.py:
348         (DriverTest.test_test_to_uri):
349         (DriverTest.test_uri_to_test):
350
351 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
352
353         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
354         https://bugs.webkit.org/show_bug.cgi?id=173998
355
356         Reviewed by Darin Adler.
357
358         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
359         detect mistakes in backward compatibility in the future when we change it.
360
361         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
362         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
363         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
364         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
365         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
366         internal key data slot.
367
368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
369         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
370         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
371         (getNextMessage):
372         (TEST):
373         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
374         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
375         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
376         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
377         These are the pre-baked databases.
378         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
379         This is the actual test that do all the reads and comparisons.
380         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
381         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
382         IndexedDB new stuffs. Then it can be used to bake the database again.
383
384 2017-08-01  Brady Eidson  <beidson@apple.com>
385
386         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
387         https://bugs.webkit.org/show_bug.cgi?id=175030
388
389         Reviewed by Andy Estes.
390
391         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
392         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
393
394 2017-08-01  Brady Eidson  <beidson@apple.com>
395
396         Part 2 of: Rename DatabaseProcess to StorageProcess.
397         https://bugs.webkit.org/show_bug.cgi?id=174880
398
399         Reviewed by Andy Estes.
400
401         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
402         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
403         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
404         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
405         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
406         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
407         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
408         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
409
410 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
411
412         Fix JSCOnly ARM buildbots after r220047
413         https://bugs.webkit.org/show_bug.cgi?id=174993
414
415         Reviewed by Saam Barati.
416
417         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
418         (BuildAndRemoteJSCTestsFactory.__init__):
419
420 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
421
422         [WTF] Introduce Private Symbols
423         https://bugs.webkit.org/show_bug.cgi?id=174935
424
425         Reviewed by Darin Adler.
426
427         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
428         (TestWebKitAPI::TEST):
429
430 2017-07-30  Darin Adler  <darin@apple.com>
431
432         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
433         https://bugs.webkit.org/show_bug.cgi?id=130653
434
435         Reviewed by Antti Koivisto.
436
437         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
438         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
439         when calling frameDidChangeLocation.
440         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
441         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
442         thus causing mysterious failures of a couple of tests. There are two remaining issues:
443         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
444         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
445         same logic flaw that causes "top loading frame" to get set to one of the subframes in
446         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
447         loading, subframe starts loading. It would be good to clean that up some day, but for now
448         this patch makes the two work identically rather than changing both.
449         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
450
451 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
452
453         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
454         https://bugs.webkit.org/show_bug.cgi?id=174963
455
456         Reviewed by Darin Adler.
457
458         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
459         RetainPtr<>. This patch changes them to all use auto.
460
461         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
462         (TestWebKitAPI::TEST):
463
464 2017-07-30  Brady Eidson  <beidson@apple.com>
465
466         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
467         https://bugs.webkit.org/show_bug.cgi?id=174958
468
469         Reviewed by Darin Adler.
470
471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
472         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
473         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
474         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
475         (runUntilTasksInFlight):
476         (TEST):
477
478 2017-07-28  Commit Queue  <commit-queue@webkit.org>
479
480         Unreviewed, rolling out r219990.
481         https://bugs.webkit.org/show_bug.cgi?id=174961
482
483         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
484         estes on #webkit).
485
486         Reverted changeset:
487
488         "Part 2 of: Rename DatabaseProcess to StorageProcess."
489         https://bugs.webkit.org/show_bug.cgi?id=174880
490         http://trac.webkit.org/changeset/219990
491
492 2017-07-28  Brady Eidson  <beidson@apple.com>
493
494         API tests that use URLSchemeHandler are failing.
495         https://bugs.webkit.org/show_bug.cgi?id=174950
496
497         Reviewed by Alex Christensen.
498
499         Fix the NoMIMEType test to be correct.
500
501         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
502         (-[SchemeHandler initWithData:mimeType:]):
503         (-[SchemeHandler webView:startURLSchemeTask:]):
504         (TEST):
505
506 2017-07-28  Daniel Bates  <dabates@apple.com>
507
508         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
509         https://bugs.webkit.org/show_bug.cgi?id=174876
510
511         Reviewed by Alex Christensen.
512
513         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
514         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
515         they provide a more direct way to test the platform abstraction.
516
517         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
518
519         * Scripts/prepare-ChangeLog:
520         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
521         of the current working directory.
522
523 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
524
525         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
526         https://bugs.webkit.org/show_bug.cgi?id=174930
527
528         Unreviewed test fix.
529
530         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
531
532         * Scripts/prepare-ChangeLog:
533         (get_function_line_ranges_for_cpp):
534
535 2017-07-28  JF Bastien  <jfbastien@apple.com>
536
537         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
538         https://bugs.webkit.org/show_bug.cgi?id=174930
539
540         Reviewed by Daniel Bates.
541
542         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
543         here also teach it about const and volatile overloads. I didn't do
544         reference and rvalue reference overloads because we don't really
545         use them, and the current parser throws away those characters and
546         it doesn't seem worth making it more complex.
547
548         * Scripts/prepare-ChangeLog:
549         (get_function_line_ranges_for_cpp):
550         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
551         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
552         (Foo::Arrow::arrow):
553         (Foo::Arrow::otherArrow):
554         (Foo::Arrow::otherArrow const):
555         (Foo::Arrow::otherArrow volatile):
556         (Foo::Arrow::otherArrow const volatile):
557
558 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
559
560         [GTK] Building with ENABLE_VIDEO=OFF fails
561         https://bugs.webkit.org/show_bug.cgi?id=174940
562
563         Reviewed by Alex Christensen.
564
565         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
566         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
567
568         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
569         (methodCallCallback): Add missing USE(GSTREAMER) guard.
570
571 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
572
573         [WPE] Implement EventSenderProxy in WTR
574         https://bugs.webkit.org/show_bug.cgi?id=173419
575
576         Reviewed by Žan Doberšek.
577
578         Add the implementation of EventSenderProxy to the WTR. This
579         allows us to extend the coverage of the test suite in WKWPE.
580
581         * WebKitTestRunner/EventSenderProxy.h:
582         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
583         libxkbcommon needed to deal with key events.
584         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
585         (WTR::EventSenderProxy::EventSenderProxy):
586         (WTR::senderButtonToWPEButton):
587         (WTR::EventSenderProxy::mouseDown):
588         (WTR::EventSenderProxy::mouseUp):
589         (WTR::EventSenderProxy::mouseMoveTo):
590         (WTR::EventSenderProxy::mouseScrollBy):
591         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
592         (WTR::EventSenderProxy::leapForward):
593         (WTR::wkEventModifiersToWPE):
594         (WTR::getXKBKeySymForKeyRef):
595         (WTR::EventSenderProxy::keyDown):
596         (WTR::EventSenderProxy::addTouchPoint):
597         (WTR::EventSenderProxy::updateTouchPoint):
598         (WTR::EventSenderProxy::setTouchModifier):
599         (WTR::EventSenderProxy::setTouchPointRadius):
600         (WTR::EventSenderProxy::getUpdatedTouchEvents):
601         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
602         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
603         (WTR::EventSenderProxy::touchStart):
604         (WTR::EventSenderProxy::touchMove):
605         (WTR::EventSenderProxy::touchEnd):
606         (WTR::EventSenderProxy::touchCancel):
607         (WTR::EventSenderProxy::clearTouchPoints):
608         (WTR::EventSenderProxy::releaseTouchPoint):
609         (WTR::EventSenderProxy::cancelTouchPoint):
610
611 2017-07-27  Brady Eidson  <beidson@apple.com>
612
613         Part 2 of: Rename DatabaseProcess to StorageProcess.
614         https://bugs.webkit.org/show_bug.cgi?id=174880
615
616         Reviewed by Andy Estes.
617
618         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
619         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
620         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
621         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
622         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
623         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
624         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
625         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
626
627 2017-07-26  Mark Lam  <mark.lam@apple.com>
628
629         Add ability to only run specific tests in run-javascriptcore-tests.
630         https://bugs.webkit.org/show_bug.cgi?id=174884
631
632         Reviewed by Saam Barati.
633
634         For example, if we only want to run testapi, we can do so as follows:
635             $ run-javascriptcore-tests --testapi
636
637         Previously, specifying --testapi effectively does nothing because we run all tests
638         by default.  Only --no-testapi had the effect of disabling the test set.  This
639         old behavior for --testapi is not very useful or meaningful.  We're now changing
640         it to mean that we will only run that test.
641
642         With this change, we can also run more than one set of tests.  For example, if we
643         only want to run testmasm and testair, we can do so as follows:
644             $ run-javascriptcore-tests --testmasm --testair
645
646         By default, if no specific test option is specified, run-javascriptcore-tests will
647         run all tests.
648
649         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
650         the mozilla tests (--mozilla-tests) even though both are run via the lower level
651         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
652         the other set will not run.  For example, the following only runs the mozilla tests:
653             $ run-javascriptcore-tests --mozilla-tests
654
655         Note also that --jit-stress-tests is not for choosing a different set of tests.
656         Instead, it is used for determining whether we run JIT'ed test configurations
657         on the jsc stress tests and mozilla tests.  As a result, specifying
658         --jit-stress-tests will not omit other tests.  For example, the following still
659         runs all tests:
660             $ run-javascriptcore-tests --jit-stress-tests
661
662         * Scripts/run-javascriptcore-tests:
663         (defaultStringForTestState):
664         (enableTestOrNot):
665         (runJSCStressTests):
666
667 2017-07-26  Mark Lam  <mark.lam@apple.com>
668
669         Make run-javascriptcore-test run testair, testb3, and testmasm.
670         https://bugs.webkit.org/show_bug.cgi?id=174837
671         <rdar://problem/33522927>
672
673         Reviewed by Saam Barati and Filip Pizlo.
674
675         1. Refactors code for running testapi so that we can use it to run other tests.
676         2. Added running of testmasm, testair, testb3.
677
678         Note: the existing testapi invocation code does not support remote invocation of
679         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
680         and testb3 also do not support remote invocation.  If we wish to add remote
681         invocation support, we should do that in a separate patch.
682
683         * Scripts/run-javascriptcore-tests:
684         (testPath):
685         (runTest):
686         (testapiPath): Deleted.
687
688 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
689
690         Remove duplicate code from Buildbot.js in dashboard
691         https://bugs.webkit.org/show_bug.cgi?id=174870
692
693         Reviewed by Daniel Bates.
694
695         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
696         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
697         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
698         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
699         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
700
701 2017-07-26  Brady Eidson  <beidson@apple.com>
702
703         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
704         https://bugs.webkit.org/show_bug.cgi?id=174851
705
706         Reviewed by Chris Dumez.
707
708         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
709         (TEST):
710
711 2017-07-26  Brian Burg  <bburg@apple.com>
712
713         Remove WEB_TIMING feature flag
714         https://bugs.webkit.org/show_bug.cgi?id=174795
715
716         Reviewed by Alex Christensen.
717
718         * Scripts/webkitperl/FeatureList.pm:
719         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
720
721 2017-07-26  Chris Dumez  <cdumez@apple.com>
722
723         Pressing the Escape key should not be a valid user gesture to enter fullscreen
724         https://bugs.webkit.org/show_bug.cgi?id=174864
725         <rdar://problem/33009088>
726
727         Reviewed by Geoffrey Garen.
728
729         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
730         WKTR.
731
732         * DumpRenderTree/mac/EventSendingController.mm:
733         (-[EventSendingController keyDown:withModifiers:withLocation:]):
734
735 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
736
737         Unreviewed, added Romain Bellessort to contributors.json.
738
739         * Scripts/webkitpy/common/config/contributors.json:
740
741 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
742
743         [WPE] WebGL2 support
744         https://bugs.webkit.org/show_bug.cgi?id=174249
745
746         Reviewed by Alex Christensen.
747
748         * Scripts/webkitperl/FeatureList.pm:
749         Enable WebGL2 for WPE when building through build-webkit.
750
751 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
752
753         Unreviewed. Fix GTK distcheck.
754
755         * gtk/make-dist.py:
756         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
757
758 2017-07-25  Brady Eidson  <beidson@apple.com>
759
760         ResourceLoadStatistics grandfathering happens much too often.
761         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
762
763         Reviewed by Chris Dumez.
764
765         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
766         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
767         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
768         (TEST):
769
770 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
771
772         Fix autoinstaller failing on autoinstall_everything
773         https://bugs.webkit.org/show_bug.cgi?id=174830
774
775         Reviewed by Joseph Pecoraro.
776
777         * Scripts/webkitpy/thirdparty/__init__.py:
778         (AutoinstallImportHook.find_module):
779         (AutoinstallImportHook.install_chromedriver):
780         (AutoinstallImportHook.install_geckodriver):
781         (AutoinstallImportHook._install_chromedriver): Deleted.
782         (AutoinstallImportHook._install_geckodriver): Deleted.
783
784 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
785
786         Replace --runtime with something for both ios-simulator and ios-device
787         https://bugs.webkit.org/show_bug.cgi?id=173775
788         <rdar://problem/32952164>
789
790         Reviewed by Aakash Jain.
791
792         Add --version flag for both iOS simulator and iOS device.
793
794         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
795         (parse_args): Add --version flag and move --no-install.
796         * Scripts/webkitpy/port/factory.py:
797         (platform_options): Move --no-intall to run_webkit_tests.py.
798         * Scripts/webkitpy/port/ios.py:
799         (IOSPort):
800         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
801         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
802         * Scripts/webkitpy/port/ios_device.py:
803         (IOSDevicePort.ios_version): Consult --version flag before checking connected
804         devices for iOS version.
805         * Scripts/webkitpy/port/ios_device_unittest.py:
806         (IOSDeviceTest.make_port): Set --version option so that we can generate test
807         expectation paths without devices connected.
808         (IOSDeviceTest.test_additional_platform_directory): Deleted.
809         (IOSDeviceTest.test_baseline_searchpath): Deleted.
810         (IOSDeviceTest.test_expectations_ordering): Deleted.
811         * Scripts/webkitpy/port/ios_simulator.py:
812         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
813         flag to specify a runtime.
814         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
815         flag and then use the default runtime.
816
817 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
818
819         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
820         https://bugs.webkit.org/show_bug.cgi?id=174815
821
822         Reviewed by Carlos Alberto Lopez Perez.
823
824         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
825         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
826         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
827         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
828         think), probably because of a newer CMake version.
829
830         * CMakeLists.txt:
831         * TestWebKitAPI/CMakeLists.txt:
832         * TestWebKitAPI/PlatformGTK.cmake:
833
834 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
835
836         Fix BenchmarkRunner to only import selenium when needed
837         https://bugs.webkit.org/show_bug.cgi?id=174808
838
839         Reviewed by Stephanie Lewis.
840
841         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
842         (LinuxChromeDriver.launch_driver):
843         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
844         (LinuxFirefoxDriver.launch_driver):
845         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
846         (OSXChromeDriver.launch_driver):
847         (OSXChromeCanaryDriver.launch_driver):
848         (create_chrome_options):
849         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
850         (OSXFirefoxDriver.launch_driver):
851         (OSXFirefoxNightlyDriver.launch_driver):
852         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
853         (OSXSafariDriver.launch_driver):
854         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
855         (WebDriverBenchmarkRunner._run_one_test):
856
857 2017-07-23  Darin Adler  <darin@apple.com>
858
859         More NeverDestroyed and related cleanup
860         https://bugs.webkit.org/show_bug.cgi?id=174745
861
862         Reviewed by Alex Christensen.
863
864         * DumpRenderTree/JavaScriptThreading.cpp:
865         (javaScriptThreadsMutex): Use NeverDestroyed instead of
866         DEPRECATED_DEFINE_STATIC_LOCAL.
867         (javaScriptThreads): Ditto.
868
869 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
870
871         Subclass Benchmark Runner script for WebDriver support
872         https://bugs.webkit.org/show_bug.cgi?id=174390
873
874         Reviewed by Dewei Zhu, Stephanie Lewis.
875
876         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
877
878         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
879         (BenchmarkBuilder.__init__):
880         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
881         (BenchmarkRunner.__init__):
882         (BenchmarkRunner._find_plan_file):
883         (BenchmarkRunner._run_one_test.and):
884         (BenchmarkRunner.execute):
885         (BenchmarkRunner._get_result): Deleted.
886         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
887         (parse_args):
888         (start):
889         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
890         (WebDriverBenchmarkRunner):
891         (WebDriverBenchmarkRunner._get_result):
892         (WebDriverBenchmarkRunner._run_one_test):
893         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
894         (WebServerBenchmarkRunner):
895         (WebServerBenchmarkRunner.__init__):
896         (WebServerBenchmarkRunner._get_result):
897         (WebServerBenchmarkRunner._run_one_test):
898
899 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
900
901         Add BenchmarkRunner patches with WebDriver support for each testing plan
902         https://bugs.webkit.org/show_bug.cgi?id=174443
903
904         Reviewed by Dewei Zhu, Stephanie Lewis.
905
906         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
907         (BenchmarkBuilder.__enter__):
908         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
909         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
910         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
911         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
912         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
913         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
914         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
915         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
916         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
917         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
918         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
919         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
920         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
921         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
922         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
923         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
924         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
925         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
926         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
927         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
928         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
929         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
930         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
931         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
932         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
933         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
934         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
935         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
936         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
937         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
938         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
939         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
940         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
941
942 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
943
944         Add functions to autoinstaller needed for Benchmark Runner script
945         https://bugs.webkit.org/show_bug.cgi?id=174331
946
947         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
948
949         Adds autoinstaller functions to install selenium and webdriver binaries
950         which will be used by the browser driver part of Benchmark Runner.
951
952         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
953         (BrowserDriver.restore_env):
954         (BrowserDriver):
955         (BrowserDriver.get_webdriver_binary_path):
956         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
957         (LinuxChromeDriver.launch_driver):
958         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
959         (LinuxFirefoxDriver.launch_driver):
960         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
961         (OSXChromeDriver.launch_driver):
962         (OSXChromeCanaryDriver.launch_driver):
963         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
964         (OSXFirefoxDriver.launch_driver):
965         (OSXFirefoxNightlyDriver.launch_driver):
966         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
967         * Scripts/webkitpy/benchmark_runner/utils.py:
968         (get_driver_binary_path):
969         * Scripts/webkitpy/common/system/autoinstall.py:
970         (AutoInstaller._unzip):
971         * Scripts/webkitpy/thirdparty/__init__.py:
972         (AutoinstallImportHook.find_module):
973         (AutoinstallImportHook._install_selenium):
974         (AutoinstallImportHook):
975         (AutoinstallImportHook._install_chromedriver):
976         (AutoinstallImportHook._install_geckodriver):
977         (AutoinstallImportHook.get_latest_pypi_url):
978         (AutoinstallImportHook.install_binary):
979         (autoinstall_everything):
980         (get_driver_filename):
981         (get_os_info):
982
983 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
984
985         Add WebDriver support in browser driver part of BenchmarkRunner
986         https://bugs.webkit.org/show_bug.cgi?id=174445
987
988         Reviewed by Stephanie Lewis.
989
990         Adds a launch_driver function to each BrowserDriver subclass. This
991         function sets up the arguments for the webdriver and launches the
992         webdriver specific to that browser.
993
994         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
995         (BrowserDriver.launch_webdriver):
996         (BrowserDriver):
997         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
998         (LinuxBrowserDriver.launch_webdriver):
999         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1000         (LinuxChromeDriver.launch_url):
1001         (LinuxChromeDriver):
1002         (LinuxChromeDriver.launch_driver):
1003         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
1004         (EpiphanyBrowserDriver.launch_url):
1005         (EpiphanyBrowserDriver):
1006         (EpiphanyBrowserDriver.launch_driver):
1007         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1008         (LinuxFirefoxDriver):
1009         (LinuxFirefoxDriver.launch_url):
1010         (LinuxFirefoxDriver.launch_driver):
1011         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
1012         (GTKMiniBrowserDriver.launch_url):
1013         (GTKMiniBrowserDriver):
1014         (GTKMiniBrowserDriver.launch_driver):
1015         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1016         (OSXBrowserDriver._launch_webdriver):
1017         (OSXBrowserDriver):
1018         (OSXBrowserDriver._screen_size):
1019         (OSXBrowserDriver._insert_url):
1020         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1021         (OSXChromeDriver):
1022         (OSXChromeDriver.launch_url):
1023         (OSXChromeDriver.launch_driver):
1024         (OSXChromeCanaryDriver):
1025         (OSXChromeCanaryDriver.launch_url):
1026         (OSXChromeCanaryDriver.launch_driver):
1027         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1028         (OSXFirefoxDriver):
1029         (OSXFirefoxDriver.launch_url):
1030         (OSXFirefoxDriver.launch_driver):
1031         (OSXFirefoxNightlyDriver):
1032         (OSXFirefoxNightlyDriver.launch_url):
1033         (OSXFirefoxNightlyDriver.launch_driver):
1034         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1035         (OSXSafariDriver.launch_driver):
1036
1037 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1038
1039         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
1040         https://bugs.webkit.org/show_bug.cgi?id=174793
1041
1042         Reviewed by Tim Horton.
1043
1044         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
1045         down. Without r219765, this test will dereference null and crash.
1046
1047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1048         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
1049         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
1050         (TEST):
1051
1052 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1053
1054         [Win] Implement Authentication dialog in MiniBrowser
1055         https://bugs.webkit.org/show_bug.cgi?id=174662
1056
1057         Reviewed by Alex Christensen.
1058
1059         * MiniBrowser/win/Common.cpp:
1060         (CustomUserAgent):
1061         (DisplayAuthDialog):
1062         (AuthDialogProc):
1063         * MiniBrowser/win/MiniBrowserLib.rc:
1064         * MiniBrowser/win/MiniBrowserLibResource.h:
1065         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1066         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1067
1068 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
1069
1070         Handle case where line_numbers is None instead of an array of line numbers
1071         https://bugs.webkit.org/show_bug.cgi?id=174775
1072
1073         Reviewed by Aakash Jain.
1074
1075         Added files set line_numbers to None in process_file.
1076
1077         * Scripts/webkitpy/style/filereader.py:
1078         (TextFileReader.process_file): Handle case where line_number is set to None.
1079         * Scripts/webkitpy/style/main_unittest.py:
1080         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
1081
1082 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1083
1084         [WPE] Add libepoxy to the Jhbuild moduleset
1085         https://bugs.webkit.org/show_bug.cgi?id=174711
1086
1087         Reviewed by Carlos Alberto Lopez Perez.
1088
1089         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
1090
1091 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1092
1093         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
1094         https://bugs.webkit.org/show_bug.cgi?id=174780
1095
1096         Reviewed by Carlos Garcia Campos.
1097
1098         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1099         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
1100         in case the eglplatform.h header doesn't provide that macro. This replicates
1101         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
1102
1103 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1104
1105         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
1106         https://bugs.webkit.org/show_bug.cgi?id=174758
1107
1108         Reviewed by Dan Bernstein.
1109
1110         Migrate position-information-related unit tests from the PositionInformationTests suite to
1111         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
1112
1113         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1114         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1115         (TestWebKitAPI::checkElementTypeAndBoundingRect):
1116         (TestWebKitAPI::TEST):
1117         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
1118         * TestWebKitAPI/cocoa/TestWKWebView.h:
1119         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1120         (-[TestWKWebView activatedElementAtPosition:]):
1121
1122 2017-07-22  Chris Dumez  <cdumez@apple.com>
1123
1124         REGRESSION(r204565): WKObject is broken
1125         https://bugs.webkit.org/show_bug.cgi?id=174736
1126         <rdar://problem/33246169>
1127
1128         Reviewed by Dan Bernstein.
1129
1130         Add API test that used to crash.
1131
1132         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1133         (TestWebKitAPI::TEST):
1134
1135 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1136
1137         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
1138         https://bugs.webkit.org/show_bug.cgi?id=174705
1139
1140         Reviewed by Mark Lam.
1141
1142         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1143         (TestWebKitAPI::testThreadGroup):
1144         (TestWebKitAPI::TEST):
1145
1146 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
1147
1148         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
1149         https://bugs.webkit.org/show_bug.cgi?id=174724
1150
1151         Reviewed by Aakash Jain.
1152
1153         * Scripts/webkitpy/port/ios_simulator.py:
1154         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
1155         simulator. Errors here should be treated the same as no simulators found.
1156
1157 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
1158
1159         [CMake] Add an option to stop build after generating project files
1160         https://bugs.webkit.org/show_bug.cgi?id=174664
1161
1162         Reviewed by Konstantin Tokarev.
1163
1164         Add "--generate-project-only" to stop build after generating project files.
1165
1166         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
1167         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
1168         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
1169         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
1170         (isGenerateProjectOnly): ditto
1171
1172 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1173
1174         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1175         https://bugs.webkit.org/show_bug.cgi?id=174501
1176
1177         Reviewed by Darin Adler.
1178
1179         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1180         (TestWebKitAPI::TEST):
1181
1182 2017-07-20  David Quesada  <david_quesada@apple.com>
1183
1184         Add SPI to notify WKNavigationDelegate about client redirects
1185         https://bugs.webkit.org/show_bug.cgi?id=174680
1186         rdar://problem/33184886
1187
1188         Reviewed by Brady Eidson.
1189
1190         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1191         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
1192         (TEST):
1193         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
1194
1195 2017-07-20  Brady Eidson  <beidson@apple.com>
1196
1197         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
1198         https://bugs.webkit.org/show_bug.cgi?id=174685
1199
1200         Reviewed by Andy Estes.
1201
1202         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1203         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
1204
1205 2017-07-20  Brady Eidson  <beidson@apple.com>
1206
1207         Deprecate WebIconDatabase in WebKitLegacy/mac.
1208         https://bugs.webkit.org/show_bug.cgi?id=174607
1209
1210         Reviewed by Alex Christensen.
1211
1212         * DumpRenderTree/mac/TestRunnerMac.mm:
1213
1214 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
1215
1216         lint-test-expectations should be run during style checking
1217         https://bugs.webkit.org/show_bug.cgi?id=173559
1218         <rdar://problem/32854941>
1219
1220         Reviewed by Aakash Jain.
1221
1222         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1223         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
1224         prevents identifying errors on specific lines in a file.
1225         * Scripts/webkitpy/style/main_unittest.py:
1226         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
1227         case where a linter error is in the file modified, but the line modified is not related to
1228         the linter error.
1229
1230 2017-07-20  Brady Eidson  <beidson@apple.com>
1231
1232         Remove WebIconDatabase from WebKitLegacy/win.
1233         https://bugs.webkit.org/show_bug.cgi?id=174608
1234
1235         Reviewed by Alex Christensen.
1236
1237         * DumpRenderTree/win/DumpRenderTree.cpp:
1238         (main):
1239         * DumpRenderTree/win/TestRunnerWin.cpp:
1240         (TestRunner::setIconDatabaseEnabled):
1241
1242 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
1243
1244         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
1245         https://bugs.webkit.org/show_bug.cgi?id=174671
1246
1247         Reviewed by Carlos Garcia Campos.
1248
1249         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1250         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
1251         priority for this source in order to have it dispatched on the same
1252         priority as the other WebKit-controlled GSource objects.
1253
1254 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1255
1256         lint-test-expectations should be run during style checking
1257         https://bugs.webkit.org/show_bug.cgi?id=173559
1258         <rdar://problem/32854941>
1259
1260         Reviewed by Daniel Bates.
1261
1262         Follow up fix addressing style and a few minor bugs.
1263
1264         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1265         (TestExpectationParser.__init__): Use lambda x: x instead of str
1266         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
1267         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
1268         reduce the calls of _shorten_filename, fix minor bug in appending the current
1269         expectation's line number instead of the previous ones, clarify treatment of None
1270         in file-to-line-number mapping.
1271         (TestExpectations._report_warnings): Collapse call.
1272         * Scripts/webkitpy/style/checkers/test_expectations.py:
1273         (TestExpectationsChecker.lint_test_expectations):
1274         * Scripts/webkitpy/style/filereader.py: Re-write comment.
1275         (TextFileReader.process_file): Add comment explaining treatment of None in
1276         file-to-line-number mapping.
1277         (TextFileReader.delete_file): Collapse call.
1278
1279 2017-07-19  Chris Dumez  <cdumez@apple.com>
1280
1281         Unreviewed attempt to fix API test failure after r219663.
1282
1283         The test was hard-coding an exception string and the string has changed slightly
1284         in r219663.
1285
1286         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1287         (TEST):
1288
1289 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
1290
1291         Don't write file URLs to iOS Pasteboard
1292         https://bugs.webkit.org/show_bug.cgi?id=174647
1293         <rdar://problem/33199730>
1294
1295         Reviewed by Wenson Hsieh.
1296
1297         Updating tests to reflect the lack of file URLs for images.
1298
1299         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1300         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
1301         (checkEstimatedSize):
1302         (TestWebKitAPI::TEST):
1303
1304 2017-07-19  Brady Eidson  <beidson@apple.com>
1305
1306         iBooks sometimes crashes when closing a book.
1307         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
1308
1309         Reviewed by Oliver Hunt.
1310
1311         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1312         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
1313         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
1314         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
1315         (TestWebKitAPI::TEST):
1316
1317         Add a "spin the runloop X number of times" utility:
1318         * TestWebKitAPI/Utilities.h:
1319         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1320         (TestWebKitAPI::Util::spinRunLoop):
1321
1322 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1323
1324         lint-test-expectations should be run during style checking
1325         https://bugs.webkit.org/show_bug.cgi?id=173559
1326         <rdar://problem/32854941>
1327
1328         Reviewed by David Kilzer.
1329
1330         Running the test expectation linter requires reading both files and lines not in the
1331         patch because, for example, deletion of a test can cause a lint failure even though
1332         no test expectations where modified. This means that the linter will occasionally warn
1333         about lines which were not changed in a given patch but whose error is related to a
1334         change made in that patch.
1335
1336         * Scripts/webkitpy/common/system/filesystem_mock.py:
1337         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
1338         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1339         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
1340         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
1341         content, description of the error and the name of the associated test.
1342         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
1343         (TestExpectationParser.__init__): Pass shorten_filename function to
1344         TestExpectationsParser to add a deleted file to the related_files dictionary.
1345         (TestExpectationParser._check_test_exists): If the test does not exist, add the
1346         missing path to the related_files dictionary.
1347         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
1348         files and line numbers related to this test expectation line. This will allow
1349         tracking linter errors in the style checker occurring across multiple files.
1350         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
1351         lines to related_files dictionary.
1352         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
1353         (TestExpectations._report_warnings): Construct warning object instead of string
1354         when adding to warnings list.
1355         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
1356         clean-up log.
1357         * Scripts/webkitpy/style/checker.py:
1358         (ProcessorBase.do_association_check): Add required function for processor classes.
1359         (StyleProcessor):
1360         (StyleProcessor.do_association_check): Run the TestExpectations linter when
1361         checking for errors between associated files.
1362         * Scripts/webkitpy/style/checkers/test_expectations.py:
1363         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
1364         (TestExpectationsChecker):
1365         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
1366         of modified files, the current working directory and the host, determine if the linter
1367         warning is associated with the changes.
1368         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
1369         style checker.
1370         * Scripts/webkitpy/style/filereader.py:
1371         (TextFileReader):
1372         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
1373         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
1374         (TextFileReader.process_file): Track both the number of files changed and which lines
1375         in those files were changed.
1376         (TextFileReader.do_association_check): Run the processor's association check on all
1377         modified or deleted files processed by TextFileReader.
1378         (TextFileReader.delete_file): Track deleted files in _files dictionary.
1379         (TextFileReader.count_delete_only_file): Deleted.
1380         * Scripts/webkitpy/style/filereader_unittest.py:
1381         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
1382         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
1383         * Scripts/webkitpy/style/main.py:
1384         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
1385         explicitly run the association check on the file reader.
1386         * Scripts/webkitpy/style/main_unittest.py:
1387         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
1388         embedded in the style checker.
1389         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
1390         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
1391         construct the TextFileReader object with a StyleProcessor used to run style checks on
1392         specific files.
1393         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
1394         testing the test expectation linter inside the style checker. This host must contain a
1395         mock file system with the basic structure of test expectations.
1396         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
1397         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
1398         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
1399         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
1400         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
1401         * Scripts/webkitpy/style/patchreader.py:
1402         (PatchReader.check): Specify which file was deleted, run the association check.
1403         * Scripts/webkitpy/style/patchreader_unittest.py:
1404         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
1405         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
1406         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
1407
1408 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1409
1410         [WTF] Implement WTF::ThreadGroup
1411         https://bugs.webkit.org/show_bug.cgi?id=174081
1412
1413         Reviewed by Mark Lam.
1414
1415         Add WTF::ThreadGroup tests.
1416
1417         * TestWebKitAPI/CMakeLists.txt:
1418         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1419         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1420         (TestWebKitAPI::testThreadGroup):
1421         (TestWebKitAPI::TEST):
1422
1423 2017-07-18  Andy Estes  <aestes@apple.com>
1424
1425         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1426         https://bugs.webkit.org/show_bug.cgi?id=174631
1427
1428         Reviewed by Tim Horton.
1429
1430         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1431         * MiniBrowser/Configurations/Base.xcconfig:
1432         * MobileMiniBrowser/Configurations/Base.xcconfig:
1433         * TestWebKitAPI/Configurations/Base.xcconfig:
1434         * WebKitTestRunner/Configurations/Base.xcconfig:
1435
1436 2017-07-18  Andy Estes  <aestes@apple.com>
1437
1438         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1439         https://bugs.webkit.org/show_bug.cgi?id=174631
1440
1441         Reviewed by Sam Weinig.
1442
1443         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1444         * MiniBrowser/Configurations/Base.xcconfig:
1445         * MobileMiniBrowser/Configurations/Base.xcconfig:
1446         * TestWebKitAPI/Configurations/Base.xcconfig:
1447         * WebKitTestRunner/Configurations/Base.xcconfig:
1448
1449 2017-07-18  Daniel Bates  <dabates@apple.com>
1450
1451         lldb: Add type summary for StringView
1452         https://bugs.webkit.org/show_bug.cgi?id=174637
1453
1454         Reviewed by Sam Weinig.
1455
1456         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
1457         StringView object will print output that has the form:
1458
1459             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
1460               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
1461               m_length = 2
1462               m_is8Bit = true
1463               m_underlyingString = 0x0000614000000a90
1464             }
1465
1466         * lldb/lldb_webkit.py:
1467         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
1468         (WTFStringView_SummaryProvider):
1469         (WTFStringViewProvider):
1470         (WTFStringViewProvider.__init__):
1471         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
1472         (WTFStringViewProvider.get_length): Access field StringView.m_length.
1473         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
1474         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
1475
1476 2017-07-18  Andy Estes  <aestes@apple.com>
1477
1478         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1479         https://bugs.webkit.org/show_bug.cgi?id=174631
1480
1481         Reviewed by Dan Bernstein.
1482
1483         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1484         * MiniBrowser/Configurations/Base.xcconfig:
1485         * MobileMiniBrowser/Configurations/Base.xcconfig:
1486         * TestWebKitAPI/Configurations/Base.xcconfig:
1487         * WebKitTestRunner/Configurations/Base.xcconfig:
1488
1489 2017-07-18  Devin Rousso  <drousso@apple.com>
1490
1491         Web Inspector: Add memoryCost to Inspector Protocol objects
1492         https://bugs.webkit.org/show_bug.cgi?id=174478
1493
1494         Reviewed by Joseph Pecoraro.
1495
1496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1497         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
1498         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
1499         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
1500         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
1501         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
1502         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
1503         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
1504         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
1505         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
1506         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
1507         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
1508         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
1509         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
1510         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
1511         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
1512         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
1513
1514 2017-07-18  Andy Estes  <aestes@apple.com>
1515
1516         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
1517         https://bugs.webkit.org/show_bug.cgi?id=174631
1518
1519         Reviewed by Darin Adler.
1520
1521         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1522         * MiniBrowser/Configurations/Base.xcconfig:
1523         * MobileMiniBrowser/Configurations/Base.xcconfig:
1524         * TestWebKitAPI/Configurations/Base.xcconfig:
1525         * WebKitTestRunner/Configurations/Base.xcconfig:
1526
1527 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1528
1529         Unreviewed, fix the iOS build.
1530
1531         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
1532
1533         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1534         (TestWebKitAPI::TEST):
1535
1536 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1537
1538         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
1539         https://bugs.webkit.org/show_bug.cgi?id=174585
1540         <rdar://problem/33302541>
1541
1542         Reviewed by Tim Horton.
1543
1544         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
1545         being dragged when initiating a drag.
1546
1547         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1548         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
1549         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1550         (TestWebKitAPI::TEST):
1551         * TestWebKitAPI/cocoa/TestWKWebView.h:
1552
1553         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
1554
1555         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1556         (-[TestWKWebView synchronouslyLoadHTMLString:]):
1557
1558 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1559
1560         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
1561         https://bugs.webkit.org/show_bug.cgi?id=174547
1562
1563         Reviewed by Alex Christensen.
1564
1565         * DumpRenderTree/PlatformWin.cmake:
1566         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1567
1568 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1569
1570         Update style checker to deal with "final"
1571         https://bugs.webkit.org/show_bug.cgi?id=174528
1572
1573         Reviewed by Alex Christensen.
1574         
1575         check-webkit-style shouldn't complain about an open brace to start a
1576         line after a function definition with "final" or "const final".
1577
1578         * Scripts/webkitpy/style/checkers/cpp.py:
1579         (check_braces):
1580         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1581         (CppStyleTest.test_brace_at_begin_of_line):
1582
1583 2017-07-17  Alex Christensen  <achristensen@webkit.org>
1584
1585         Modernize content extension code
1586         https://bugs.webkit.org/show_bug.cgi?id=174588
1587
1588         Reviewed by Sam Weinig.
1589
1590         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1591         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1592         (TestWebKitAPI::testRequest):
1593         (TestWebKitAPI::makeBackend):
1594         (TestWebKitAPI::TEST_F):
1595
1596 2017-07-17  Brady Eidson  <beidson@apple.com>
1597
1598         WKHTTPCookieStore observing only works on the default cookie store.
1599         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
1600
1601         Reviewed by Sam Weinig.
1602
1603         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1604         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
1605           called for the default store, a non-persistent store, and a custom store.
1606         (TEST):
1607
1608 2017-07-16  Sam Weinig  <sam@webkit.org>
1609
1610         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
1611         https://bugs.webkit.org/show_bug.cgi?id=174575
1612
1613         Reviewed by Brady Eidson.
1614
1615         * Scripts/svn-create-patch:
1616         (findModificationType):
1617         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
1618         default value of "unknown".
1619
1620         (generateFileList):
1621         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
1622         for untracked, which matches our old behavior.
1623
1624 2017-07-17  Charlie Turner  <cturner@igalia.com>
1625
1626         Add some missing build dependencies on Fedora
1627         https://bugs.webkit.org/show_bug.cgi?id=174578
1628
1629         Unreviewed dependency update.
1630
1631         * gtk/install-dependencies:
1632
1633 2017-07-16  Brady Eidson  <beidson@apple.com>
1634
1635         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
1636         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
1637
1638         Reviewed by Tim Horton.
1639
1640         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1641         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
1642         (TEST):
1643
1644 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
1645
1646         [GTK] Sort inspector GResource manifest to ensure reproducible builds
1647         https://bugs.webkit.org/show_bug.cgi?id=174540
1648
1649         Reviewed by Michael Catanzaro.
1650
1651         * gtk/generate-inspector-gresource-manifest.py:
1652         (get_filenames): sort list of input files
1653
1654 2017-07-15  Brady Eidson  <beidson@apple.com>
1655
1656         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
1657         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
1658
1659         Reviewed by Tim Horton.
1660
1661         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1662         (TEST): Make this test more reliable by clearing everything beforehand.
1663
1664 2017-07-15  David Kilzer  <ddkilzer@apple.com>
1665
1666         Make it possible to extend check-webkit-style with Apple-internal checkers
1667         <https://webkit.org/b/174464>
1668         <rdar://problem/25564402>
1669
1670         Reviewed by Darin Adler.
1671
1672         * Scripts/webkitpy/style/checker.py: Import apple_additions.
1673         (_all_categories): Add categories from apple_additions() if it
1674         exists.
1675         (CheckerDispatcher._create_checker): Create python checker
1676         from apple_additions() if it exists.
1677
1678 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1679
1680         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
1681         https://bugs.webkit.org/show_bug.cgi?id=174539
1682         <rdar://problem/33307395>
1683
1684         Reviewed by Darin Adler.
1685
1686         Adds a new unit test suite to cover action sheet popover presentation.
1687
1688         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1689         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
1690         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
1691         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
1692
1693         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
1694
1695         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
1696         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1697
1698         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
1699
1700         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1701         (TestWebKitAPI::TEST):
1702
1703 2017-07-15  Sam Weinig  <sam@webkit.org>
1704
1705         [Scripts] Make svn-create-patch work better when called in sub directories
1706         https://bugs.webkit.org/show_bug.cgi?id=174551
1707
1708         Reviewed by Darin Adler.
1709
1710         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
1711           by ensuring that the prefix is applied as is done in generateDiff.
1712         - Silence output of explanatory lines from svn stat (" > move to ...")
1713           that show up in STDERR when running svn-create-patch.
1714         - Add verbose logging that I found useful while debugging this issue.
1715
1716         * Scripts/svn-create-patch:
1717         (findBaseUrl):
1718         (findMimeType):
1719         (findSourceFileAndRevision):
1720         (generateDiff):
1721         (generateFileList):
1722         (manufacturePatchForAdditionWithHistory):
1723
1724 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
1725
1726         Unreviewed build fix after r219537.
1727
1728         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1729
1730 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1731
1732         Add iOS 11 SPI
1733         https://bugs.webkit.org/show_bug.cgi?id=174430
1734         <rdar://problem/33269288>
1735
1736         Reviewed by Tim Horton.
1737
1738         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
1739         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
1740         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
1741
1742 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1743
1744         Failing to install on iPad simulators
1745         https://bugs.webkit.org/show_bug.cgi?id=174532
1746         <rdar://problem/33328347>
1747
1748         Reviewed by Stephanie Lewis.
1749
1750         * Scripts/webkitpy/xcode/simulated_device.py:
1751         (SimulatedDevice.install_app): Place install command in retry try-except block.
1752
1753 2017-07-14  Jeff Miller  <jeffm@apple.com>
1754
1755         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1756         https://bugs.webkit.org/show_bug.cgi?id=174524
1757
1758         Reviewed by Sam Weinig.
1759
1760         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1761         (TEST):
1762         Renamed TestParameter to TestParameter1.
1763         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1764
1765         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1766         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1767         Observe changes for two bundle parameters.
1768
1769         (-[BundleParametersPlugIn dealloc]):
1770         Remove observers for two bundle parameters.
1771
1772 2017-07-14  Commit Queue  <commit-queue@webkit.org>
1773
1774         Unreviewed, rolling out r219510.
1775         https://bugs.webkit.org/show_bug.cgi?id=174525
1776
1777         Need to revert length() == 0 check for null string (Requested
1778         by yusukesuzuki on #webkit).
1779
1780         Reverted changeset:
1781
1782         "[WTF] Newly added AtomicStringImpl should use BufferInternal
1783         static string if StringImpl is static"
1784         https://bugs.webkit.org/show_bug.cgi?id=174501
1785         http://trac.webkit.org/changeset/219510
1786
1787 2017-07-14  Jer Noble  <jer.noble@apple.com>
1788
1789         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1790         https://bugs.webkit.org/show_bug.cgi?id=174514
1791
1792         Reviewed by Sam Weinig.
1793
1794         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1795         (TestWebKitAPI::TEST_F):
1796
1797 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1798
1799         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1800         https://bugs.webkit.org/show_bug.cgi?id=174501
1801
1802         Reviewed by Darin Adler.
1803
1804         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1805         (TestWebKitAPI::TEST):
1806
1807 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1808
1809         Bring mac expectations in-line with other platforms
1810         https://bugs.webkit.org/show_bug.cgi?id=174472
1811         <rdar://problem/33297388>
1812
1813         Reviewed by David Kilzer.
1814
1815         The override order for Mac test expectations does not conform to the pattern used by iOS,
1816         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1817
1818             platform/mac-wk2
1819             platform/wk2
1820             platform/mac-elcapitan
1821             platform/mac-sierra
1822             generic
1823
1824         After this change, El Capitan's baseline search path looks like this:
1825
1826             platform/mac-sierra-wk2
1827             platform/mac-sierra
1828             platform/mac-wk2
1829             platform/wk2
1830             generic
1831
1832         * Scripts/webkitpy/port/mac.py:
1833         (MacPort.__init__): If a specific version is specified in the port name, use that
1834         as the os version.
1835         (MacPort.default_baseline_search_path): Expectation search paths should work the
1836         same way they do on other ports. Port + version overrides port, port overrides generic
1837         and wk1/wk2 should override expectations for the two combined.
1838         * Scripts/webkitpy/port/mac_unittest.py:
1839         (MacTest.test_tests_for_other_platforms): Deleted.
1840         (MacTest._assert_search_path): Deleted.
1841         (MacTest.test_baseline_search_path): Deleted.
1842         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1843         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1844         (test_rebaseline_test_and_print_scm_changes): Ditto.
1845         (test_rebaseline_and_copy_test): Ditto.
1846         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1847         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1848         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1849
1850 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1851
1852         Fix style checker unit test
1853
1854         Unreviewed WebKit2 => WebKit fixup.
1855
1856         * Scripts/webkitpy/style/checker_unittest.py:
1857         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1858
1859 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1860
1861         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1862
1863         Unreviewed build fix.
1864
1865         r219492 missed one hunk from its partial revert of r219489.
1866         This patch reverts that hunk.
1867
1868         * TestWebKitAPI/CMakeLists.txt:
1869
1870 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1871
1872         Use the old WebKit/WebKit2 targets for CMake builds.
1873
1874         Unreviewed build fix.
1875
1876         We can update the target names to match the Framework names in a future patch.
1877         This is a partial revert of r219489.
1878
1879         * TestWebKitAPI/CMakeLists.txt:
1880         WebKitLegacy => WebKit
1881         WebKit => WebKit2
1882
1883 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1884
1885         Fix TestWebKit API.
1886         https://bugs.webkit.org/show_bug.cgi?id=174164
1887         rdar://problem/33137595
1888
1889         Reviewed by Dan Bernstein.
1890
1891         * TestWebKitAPI/CMakeLists.txt:
1892         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1893         * TestWebKitAPI/PlatformGTK.cmake:
1894
1895 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1896
1897         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1898         https://bugs.webkit.org/show_bug.cgi?id=174164
1899         rdar://problem/33137595
1900
1901         Reviewed by Dan Bernstein.
1902
1903         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1904         (ShouldBuildTest):
1905         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1906         * Scripts/build-webkit:
1907         * Scripts/do-file-rename:
1908         * Scripts/do-webcore-rename:
1909         * Scripts/update-webkit-localizable-strings:
1910         * Scripts/webkitpy/common/config/watchlist:
1911         * Scripts/webkitpy/style/checker.py:
1912         * Scripts/webkitpy/style/checkers/featuredefines.py:
1913         * gtk/make-dist.py:
1914         (ensure_version_if_possible):
1915         * gtk/manifest.txt.in:
1916
1917 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1918
1919         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
1920         https://bugs.webkit.org/show_bug.cgi?id=174162
1921         rdar://problem/33137594
1922
1923         Reviewed by Dan Bernstein.
1924
1925         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
1926
1927         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1928         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1929         * EWSTools/configure-clang-linux.sh:
1930         * Scripts/build-webkit:
1931         * Scripts/do-file-rename:
1932         * Scripts/do-webcore-rename:
1933         * Scripts/update-webkit-localizable-strings:
1934         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1935         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1936         * Scripts/webkitpy/style/checkers/featuredefines.py:
1937         * gtk/manifest.txt.in:
1938
1939 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
1940
1941         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
1942         https://bugs.webkit.org/show_bug.cgi?id=174438
1943         <rdar://problem/33277112>
1944
1945         Reviewed by Aakash Jain.
1946
1947         Given a patch, this will convert the changes from the path to the new directory structure.
1948
1949         * Scripts/rebase-patch-after-webkit-move: Added.
1950         (append_source): Append 'Source' to the provided path.
1951         (is_editable_line): Return true if a line the script expects to modify.
1952         (needs_rebase): Return if a line needs to be rebased based on it's content.
1953         (rebase_line): Rebase the provided line.
1954         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
1955         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
1956         were provided.
1957
1958 2017-07-12  Nan Wang  <n_wang@apple.com>
1959
1960         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1961         https://bugs.webkit.org/show_bug.cgi?id=174393
1962         <rdar://problem/33248006>
1963
1964         Reviewed by Chris Fleizach.
1965
1966         * DumpRenderTree/AccessibilityUIElement.cpp:
1967         (textMarkerRangeMatchesTextNearMarkersCallback):
1968         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1969         (AccessibilityUIElement::getJSClass):
1970         * DumpRenderTree/AccessibilityUIElement.h:
1971         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1972         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1973         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1974         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1975         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1976         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1977         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1978         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1979
1980 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1981
1982         Unreviewed, rolling out r219409.
1983
1984         The revision caused the Windows builds to fail.
1985
1986         Reverted changeset:
1987
1988         "AX: [iOS] Implement a way to retrieve a text marker range
1989         with desired text that is closest to a position"
1990         https://bugs.webkit.org/show_bug.cgi?id=174393
1991         http://trac.webkit.org/changeset/219409
1992
1993 2017-07-12  Nan Wang  <n_wang@apple.com>
1994
1995         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1996         https://bugs.webkit.org/show_bug.cgi?id=174393
1997         <rdar://problem/33248006>
1998
1999         Reviewed by Chris Fleizach.
2000
2001         * DumpRenderTree/AccessibilityUIElement.cpp:
2002         (textMarkerRangeMatchesTextNearMarkersCallback):
2003         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2004         (AccessibilityUIElement::getJSClass):
2005         * DumpRenderTree/AccessibilityUIElement.h:
2006         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2007         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2008         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2009         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2010         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2011         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2012         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2013         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2014
2015 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
2016
2017         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
2018         https://bugs.webkit.org/show_bug.cgi?id=174197
2019
2020         Reviewed by Darin Adler.
2021
2022         This bit me the first time I tried to submit a patch to WebKit, and still I have
2023         to manually edit the ChangeLog every time I use the script.
2024
2025         This generates a more convenient and standard ChangeLog entry.
2026
2027         * Scripts/prepare-ChangeLog:
2028         (generateNewChangeLogs):
2029
2030 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2031
2032         Unreviewed, rolling out r219401.
2033
2034         This revision rolled out the previous patch, but after talking
2035         with reviewer, a rebaseline is what was needed.Rolling back in
2036         before rebaseline.
2037
2038         Reverted changeset:
2039
2040         "Unreviewed, rolling out r219379."
2041         https://bugs.webkit.org/show_bug.cgi?id=174400
2042         http://trac.webkit.org/changeset/219401
2043
2044 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2045
2046         Unreviewed, rolling out r219379.
2047
2048         This revision caused a consistent failure in the test
2049         fast/dom/Window/property-access-on-cached-window-after-frame-
2050         removed.html.
2051
2052         Reverted changeset:
2053
2054         "Remove NAVIGATOR_HWCONCURRENCY"
2055         https://bugs.webkit.org/show_bug.cgi?id=174400
2056         http://trac.webkit.org/changeset/219379
2057
2058 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2059
2060         [WPE] Use libepoxy
2061         https://bugs.webkit.org/show_bug.cgi?id=172104
2062
2063         Reviewed by Michael Catanzaro.
2064
2065         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
2066         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
2067
2068 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2069
2070         [GTK][WPE] Align Jhbuild patches for GStreamer packages
2071         https://bugs.webkit.org/show_bug.cgi?id=174363
2072
2073         Reviewed by Michael Catanzaro.
2074
2075         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
2076         between the GTK+ and WPE port. There's no reason for the two ports to apply
2077         different patches over same versions of GStreamer releases.
2078
2079         This aligns the two ports on this specific issue. Next we'll look into
2080         creating a single GStreamer-specific Jhbuild moduleset that will allow us
2081         to keep these patches in a single place, avoiding duplicate files.
2082
2083         * gtk/jhbuild.modules:
2084         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2085         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
2086         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2087         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
2088
2089 2017-07-11  Dean Jackson  <dino@apple.com>
2090
2091         Remove NAVIGATOR_HWCONCURRENCY
2092         https://bugs.webkit.org/show_bug.cgi?id=174400
2093
2094         Reviewed by Sam Weinig.
2095
2096         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2097
2098 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
2099
2100         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
2101         https://bugs.webkit.org/show_bug.cgi?id=174239
2102
2103         Reviewed by Brady Eidson.
2104
2105         Create windows with specific features set and make sure those are properly reflected in the
2106         WKWindowFeatures object.
2107
2108         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2109         (resetToConsistentState):
2110         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2111         (TEST):
2112
2113 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
2114
2115         Do not duplicate files when deleting directories with svn 1.9
2116         https://bugs.webkit.org/show_bug.cgi?id=174339
2117         <rdar://problem/33226781>
2118
2119         Reviewed by David Kilzer.
2120
2121         * Scripts/svn-create-patch:
2122         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
2123         (generateFileList): Determine which files are deleted because they are part of a
2124         directory being deleted.
2125
2126 2017-07-11  Dean Jackson  <dino@apple.com>
2127
2128         Rolling out r219372.
2129
2130         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2131
2132 2017-07-11  Dean Jackson  <dino@apple.com>
2133
2134         Remove NAVIGATOR_HWCONCURRENCY
2135         https://bugs.webkit.org/show_bug.cgi?id=174400
2136
2137         Reviewed by Sam Weinig.
2138
2139         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2140
2141 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2142
2143         Teach build workers to fetch archives from S3.
2144         https://bugs.webkit.org/show_bug.cgi?id=174384
2145
2146         Reviewed by Aakash Jain.
2147
2148         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2149         (DownloadBuiltProduct):
2150
2151 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2152
2153         Configure buildbot to transfer all archives to S3.
2154         Previously this was Mac only, but it's time to expand!
2155         https://bugs.webkit.org/show_bug.cgi?id=174378
2156         
2157         Reviewed by Aakash Jain.
2158
2159         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2160         (BuildFactory.__init__):
2161
2162 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
2163
2164         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
2165         https://bugs.webkit.org/show_bug.cgi?id=174350
2166
2167         Reviewed by Xabier Rodriguez-Calvar.
2168
2169         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
2170         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
2171         patches are removed. The patches for gst-plugins-good are updated, removing
2172         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
2173         rtpbin elements that will help with the EMEv3 development.
2174
2175         * wpe/jhbuild.modules:
2176         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2177         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2178         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
2179         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2180         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2181         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2182         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2183         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2184         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2185
2186 2017-07-10  John Wilander  <wilander@apple.com>
2187
2188         Resource Load Statistics: Prune statistics in orders of importance
2189         https://bugs.webkit.org/show_bug.cgi?id=174215
2190         <rdar://problem/33164403>
2191
2192         Reviewed by Chris Dumez.
2193
2194         Nest infrastructure. Adds these functions:
2195         1. testRunner.setStatisticsLastSeen()
2196         2. setStatisticsMaxStatisticsEntries()
2197         3. setStatisticsPruneEntriesDownTo()
2198
2199         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2200         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2201         (WTR::TestRunner::setStatisticsLastSeen):
2202         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2203         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2204         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2205         * WebKitTestRunner/TestController.cpp:
2206         (WTR::TestController::setStatisticsLastSeen):
2207         (WTR::TestController::setMaxStatisticsEntries):
2208         (WTR::TestController::setPruneEntriesDownTo):
2209         * WebKitTestRunner/TestController.h:
2210         * WebKitTestRunner/TestInvocation.cpp:
2211         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2212         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2213         (WTR::TestController::setStatisticsLastSeen):
2214         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2215         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2216
2217 2017-07-03  Brian Burg  <bburg@apple.com>
2218
2219         Web Replay: remove some unused code
2220         https://bugs.webkit.org/show_bug.cgi?id=173903
2221
2222         Rubber-stamped by Joseph Pecoraro.
2223
2224         * Scripts/run-input-generator-tests: Removed.
2225         * Scripts/webkitpy/replay/__init__.py: Removed.
2226         * Scripts/webkitpy/replay/main.py: Removed.
2227
2228 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
2229
2230         [WPE] Fix layout test baseline and TestExpectations hierarchy
2231         https://bugs.webkit.org/show_bug.cgi?id=174092
2232
2233         Reviewed by Michael Catanzaro.
2234
2235         Like for the GTK+ port, override the default_baseline_search_path() and
2236         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
2237         Both methods operate on a short list of search paths that defaults to 'wpe' and
2238         'wk2', along with any other user-specified platform directory.
2239
2240         The test_expectations_file_position() method is overridden for testing purposes,
2241         and relevant unit tests are added.
2242
2243         * Scripts/webkitpy/port/wpe.py:
2244         (WPEPort._search_paths):
2245         (WPEPort):
2246         (WPEPort.default_baseline_search_path):
2247         (WPEPort._port_specific_expectations_files):
2248         (WPEPort.test_expectations_file_position):
2249         * Scripts/webkitpy/port/wpe_unittest.py:
2250         (WPEPortTest.test_default_baseline_search_path):
2251         (WPEPortTest):
2252         (WPEPortTest.test_port_specific_expectations_files):
2253
2254 2017-07-10  Chris Dumez  <cdumez@apple.com>
2255
2256         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
2257         https://bugs.webkit.org/show_bug.cgi?id=174301
2258
2259         Reviewed by Brent Fulgham.
2260
2261         Rename some of the testRunner API for clarity and to better match what it calls
2262         internally.
2263
2264         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2265         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2266         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2267         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2268         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2269         * WebKitTestRunner/TestController.cpp:
2270         (WTR::TestController::statisticsUpdateCookiePartitioning):
2271         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2272         * WebKitTestRunner/TestController.h:
2273         * WebKitTestRunner/TestInvocation.cpp:
2274         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2275         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2276         (WTR::TestController::statisticsUpdateCookiePartitioning):
2277         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2278
2279 2017-07-10  Charlie Turner  <cturner@igalia.com>
2280
2281         [GStreamer] Live twitch.tv videos do not play
2282         https://bugs.webkit.org/show_bug.cgi?id=174222
2283
2284         Reviewed by Michael Catanzaro.
2285
2286         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
2287         fixes videos not playing on twitch.tv.
2288
2289         * gtk/jhbuild.modules:
2290
2291 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
2292
2293         Add WebGL2 configuration option to build-webkit
2294         https://bugs.webkit.org/show_bug.cgi?id=174251
2295
2296         Reviewed by Michael Catanzaro.
2297
2298         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
2299         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
2300         is marked as enabled for the Apple Cocoa ports.
2301
2302 2017-07-08  Chris Dumez  <cdumez@apple.com>
2303
2304         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
2305         https://bugs.webkit.org/show_bug.cgi?id=174290
2306
2307         Reviewed by Brent Fulgham.
2308
2309         Rename testRunner API to match the new internal API names.
2310
2311         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2312         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2313         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2314         (WTR::TestRunner::statisticsSubmitTelemetry):
2315         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2316         * WebKitTestRunner/TestController.cpp:
2317         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2318         (WTR::TestController::statisticsSubmitTelemetry):
2319         * WebKitTestRunner/TestController.h:
2320         * WebKitTestRunner/TestInvocation.cpp:
2321         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2322         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2323         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2324         (WTR::TestController::statisticsSubmitTelemetry):
2325
2326 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2327
2328         Drop NOSNIFF compile flag
2329         https://bugs.webkit.org/show_bug.cgi?id=174289
2330
2331         Reviewed by Michael Catanzaro.
2332
2333         * Scripts/webkitperl/FeatureList.pm:
2334         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2335
2336 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2337
2338         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
2339         https://bugs.webkit.org/show_bug.cgi?id=174219
2340         <rdar://problem/32083177>
2341
2342         Reviewed by Ryosuke Niwa.
2343
2344         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
2345         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
2346         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
2347         place.
2348
2349         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
2350         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
2351         no action is taken when dropping.
2352
2353         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
2354         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2355         (TestWebKitAPI::TEST):
2356         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2357         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2358         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2359         (-[MockDragDropSession allowsMoveOperation]):
2360         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
2361         (-[MockDataInteractionSession initWithWindow:allowMove:]):
2362         (-[DataInteractionSimulator initWithWebView:]):
2363         (-[DataInteractionSimulator runFrom:to:]):
2364         (-[DataInteractionSimulator _advanceProgress]):
2365         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
2366         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
2367         (-[MockDataInteractionSession initWithWindow:]): Deleted.
2368
2369 2017-07-07  Commit Queue  <commit-queue@webkit.org>
2370
2371         Unreviewed, rolling out r219238, r219239, and r219241.
2372         https://bugs.webkit.org/show_bug.cgi?id=174265
2373
2374         "fast/workers/dedicated-worker-lifecycle.html is flaky"
2375         (Requested by yusukesuzuki on #webkit).
2376
2377         Reverted changesets:
2378
2379         "[WTF] Implement WTF::ThreadGroup"
2380         https://bugs.webkit.org/show_bug.cgi?id=174081
2381         http://trac.webkit.org/changeset/219238
2382
2383         "Unreviewed, build fix after r219238"
2384         https://bugs.webkit.org/show_bug.cgi?id=174081
2385         http://trac.webkit.org/changeset/219239
2386
2387         "Unreviewed, CLoop build fix after r219238"
2388         https://bugs.webkit.org/show_bug.cgi?id=174081
2389         http://trac.webkit.org/changeset/219241
2390
2391 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2392
2393         [GTK][WPE] Enable X-Content-Type-Options: nosniff
2394         https://bugs.webkit.org/show_bug.cgi?id=174250
2395
2396         Reviewed by Carlos Alberto Lopez Perez.
2397
2398         * Scripts/webkitperl/FeatureList.pm:
2399
2400 2017-07-07  Charlie Turner  <cturner@igalia.com>
2401         [GStreamer] vid.me videos do not play
2402         https://bugs.webkit.org/show_bug.cgi?id=172240
2403
2404         Reviewed by Xabier Rodriguez-Calvar.
2405
2406         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2407         have the existing libsoup build against GNOME to avoid header drift
2408         against GStreamer's linked Soup library.
2409
2410         * gtk/jhbuild.modules:
2411
2412 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2413
2414         Write a support script to enable buildbot to upload to S3
2415         https://bugs.webkit.org/show_bug.cgi?id=174196
2416         
2417         Reviewed by Stephanie Lewis.
2418
2419         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
2420         (uploadToS3):
2421         (archiveExists):
2422
2423 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2424
2425         Enabling uploading archives to S3.
2426         https://bugs.webkit.org/show_bug.cgi?id=174198
2427         
2428         Reviewed by Stephanie Lewis.
2429
2430         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2431         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2432         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2433         (TransferToS3): Transfer full and minified archives to S3
2434
2435 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2436
2437         [WTF] Implement WTF::ThreadGroup
2438         https://bugs.webkit.org/show_bug.cgi?id=174081
2439
2440         Reviewed by Mark Lam.
2441
2442         Add WTF::ThreadGroup tests.
2443
2444         * TestWebKitAPI/CMakeLists.txt:
2445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2446         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2447         (TestWebKitAPI::TEST):
2448
2449 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2450
2451         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2452         https://bugs.webkit.org/show_bug.cgi?id=174150
2453
2454         Reviewed by Mark Lam.
2455
2456         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2457         (TestWebKitAPI::TEST):
2458         * TestWebKitAPI/TestsController.cpp:
2459         (TestWebKitAPI::TestsController::TestsController):
2460
2461 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2462
2463         Enabling uploading archives to S3.
2464         https://bugs.webkit.org/show_bug.cgi?id=174198
2465         
2466         Reviewed by Lucas Forschler.
2467
2468         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2469         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2470         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2471         (TransferToS3): Transfer full and minified archives to S3
2472
2473 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2474
2475         [GTK][WPE] kill-old-process should kill more webkit related process
2476         https://bugs.webkit.org/show_bug.cgi?id=174220
2477
2478         Reviewed by Michael Catanzaro.
2479
2480         Generate list of possible webkit-related process names and add
2481         them to the list of process to kill.
2482         Also update the possible system related process for GTK+/WPE.
2483
2484         * BuildSlaveSupport/kill-old-processes:
2485         (listAllWebKitPrograms):
2486         (main):
2487
2488 2017-07-06  Chris Dumez  <cdumez@apple.com>
2489
2490         FileMonitor should not be ref counted
2491         https://bugs.webkit.org/show_bug.cgi?id=174166
2492
2493         Reviewed by Brent Fulgham.
2494
2495         Update the API tests to reflect the API change.
2496
2497         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2498         (TestWebKitAPI::TEST_F):
2499
2500 2017-07-06  Commit Queue  <commit-queue@webkit.org>
2501
2502         Unreviewed, rolling out r219194.
2503         https://bugs.webkit.org/show_bug.cgi?id=174207
2504
2505         it broke some layout tests (Requested by clopez on #webkit).
2506
2507         Reverted changeset:
2508
2509         "[GStreamer] vid.me videos do not play"
2510         https://bugs.webkit.org/show_bug.cgi?id=172240
2511         http://trac.webkit.org/changeset/219194
2512
2513 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2514
2515         Unreviewed, rolling out r219178.
2516
2517         This caused a consistent failure with the API test
2518         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2519
2520         Reverted changeset:
2521
2522         "[WTF] Clean up StringStatics.cpp by using
2523         LazyNeverDestroyed<> for Atoms"
2524         https://bugs.webkit.org/show_bug.cgi?id=174150
2525         http://trac.webkit.org/changeset/219178
2526
2527 2017-07-06  Alicia Boya García  <aboya@igalia.com>
2528
2529         Add CWD to Perl library path (no longer the default since 5.26.0)
2530         https://bugs.webkit.org/show_bug.cgi?id=174200
2531
2532         Reviewed by Michael Catanzaro.
2533
2534         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2535         (SetupGitClone._get_username_and_email):
2536
2537 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2538
2539         Unreviewed, update my email address.
2540
2541         * Scripts/webkitpy/common/config/contributors.json:
2542
2543 2017-07-06  Charlie Turner  <cturner@igalia.com>
2544         [GStreamer] vid.me videos do not play
2545         https://bugs.webkit.org/show_bug.cgi?id=172240
2546
2547         Reviewed by Xabier Rodriguez-Calvar.
2548
2549         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2550         have the existing libsoup build against GNOME to avoid header drift
2551         against GStreamer's linked Soup library.
2552
2553         * gtk/jhbuild.modules:
2554
2555 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2556
2557         [WTF] Move SoftLinking.h into WTF
2558         https://bugs.webkit.org/show_bug.cgi?id=174000
2559
2560         Reviewed by Alex Christensen.
2561
2562         * DumpRenderTree/mac/TestRunnerMac.mm:
2563         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2564         (test_primary_header):
2565         (ErrorCollector.__init__): Deleted.
2566         (ErrorCollector.__call__): Deleted.
2567         (ErrorCollector.results): Deleted.
2568         (ErrorCollector.result_list): Deleted.
2569         (ErrorCollector.verify_all_categories_are_seen): Deleted.
2570         (MockIo.open): Deleted.
2571         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
2572         (CppFunctionsTest.test_create_acronym): Deleted.
2573         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
2574         (CppFunctionsTest.test_parameter): Deleted.
2575         (CppFunctionsTest.test_single_line_view): Deleted.
2576         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
2577         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
2578         (CppFunctionsTest.test_parameter_list): Deleted.
2579         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
2580         (CppStyleTestBase.process_file_data): Deleted.
2581         (CppStyleTestBase.perform_lint): Deleted.
2582         (CppStyleTestBase.perform_single_line_lint): Deleted.
2583         (CppStyleTestBase.perform_multi_line_lint): Deleted.
2584         (CppStyleTestBase.perform_language_rules_check): Deleted.
2585         (CppStyleTestBase.perform_function_lengths_check): Deleted.
2586         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
2587         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
2588         (CppStyleTestBase.perform_include_what_you_use): Deleted.
2589         (CppStyleTestBase.perform_header_guard_check): Deleted.
2590         (CppStyleTestBase.assert_lint): Deleted.
2591         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
2592         (CppStyleTestBase.assert_multi_line_lint): Deleted.
2593         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
2594         (CppStyleTestBase.assert_language_rules_check): Deleted.
2595         (CppStyleTestBase.assert_include_what_you_use): Deleted.
2596         (CppStyleTestBase.assert_header_guard): Deleted.
2597         (CppStyleTestBase.assert_blank_lines_check): Deleted.
2598         (CppStyleTestBase.assert_positions_equal): Deleted.
2599         (FunctionDetectionTest.test_basic_function_detection): Deleted.
2600         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
2601         (FunctionDetectionTest.test_pure_function_detection): Deleted.
2602         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
2603         (FunctionDetectionTest.test_ignore_macros): Deleted.
2604         (FunctionDetectionTest.test_non_functions): Deleted.
2605         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
2606         (FunctionDetectionTest.test_parameter_list): Deleted.
2607         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
2608         (CppStyleTest.test_asm_lines_ignored): Deleted.
2609         (CppStyleTest.test_get_line_width): Deleted.
2610         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
2611         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
2612         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
2613         (CppStyleTest.test_position): Deleted.
2614         (CppStyleTest.test_rfind_in_lines): Deleted.
2615         (CppStyleTest.test_close_expression): Deleted.
2616         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
2617         (CppStyleTest.test_cstyle_cast): Deleted.
2618         (CppStyleTest.test_runtime_casting): Deleted.
2619         (CppStyleTest.test_runtime_selfinit): Deleted.
2620         (CppStyleTest.test_runtime_rtti): Deleted.
2621         (CppStyleTest.test_static_cast_readability): Deleted.
2622         (CppStyleTest.test_check_for_unnamed_params): Deleted.
2623         (CppStyleTest.void): Deleted.
2624         (CppStyleTest.test_deprecated_cast): Deleted.
2625         (CppStyleTest.test_mock_method): Deleted.
2626         (CppStyleTest.test_sizeof_type): Deleted.
2627         (CppStyleTest.cases): Deleted.
2628         (CppStyleTest.for): Deleted.
2629         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
2630         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
2631         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
2632         (CppStyleTest.test_include_what_you_use): Deleted.
2633         (CppStyleTest.test_files_belong_to_same_module): Deleted.
2634         (CppStyleTest.test_cleanse_line): Deleted.
2635         (CppStyleTest.test_multi_line_comments): Deleted.
2636         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
2637         (CppStyleTest.test_multiline_strings): Deleted.
2638         (CppStyleTest.test_platformh_comments): Deleted.
2639         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
2640         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
2641         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
2642         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
2643         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
2644         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
2645         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
2646         (CppStyleTest.test_check_posix_threading): Deleted.
2647         (CppStyleTest.test_insecure_string_operations): Deleted.
2648         (CppStyleTest.test_format_strings): Deleted.
2649         (CppStyleTest.test_insecure_temp_file): Deleted.
2650         (CppStyleTest.test_variable_length_array_detection): Deleted.
2651         (CppStyleTest.test_braces): Deleted.
2652         (CppStyleTest.test_check_check): Deleted.
2653         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
2654         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
2655         (CppStyleTest.test_spacing_for_fncall): Deleted.
2656         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
2657         (CppStyleTest.test_spacing_before_braces): Deleted.
2658         (CppStyleTest.test_spacing_between_braces): Deleted.
2659         (CppStyleTest.test_spacing_before_brackets): Deleted.
2660         (CppStyleTest.test_cpp_lambda_functions): Deleted.
2661         (CppStyleTest.test_objective_c_block): Deleted.
2662         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
2663         (CppStyleTest.test_spacing_around_else): Deleted.
2664         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
2665         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
2666         (CppStyleTest.test_operator_methods): Deleted.
2667         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
2668         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
2669         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
2670         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
2671         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
2672         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
2673         (CppStyleTest.test_space_after_comment_marker): Deleted.
2674         (CppStyleTest.test_newline_at_eof): Deleted.
2675         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
2676         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
2677         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
2678         (CppStyleTest.test_invalid_utf8): Deleted.
2679         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
2680         (CppStyleTest.test_is_blank_line): Deleted.
2681         (CppStyleTest.test_blank_lines_check): Deleted.
2682         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
2683         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
2684         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
2685         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
2686         (CppStyleTest.test_comma): Deleted.
2687         (CppStyleTest.test_declaration): Deleted.
2688         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
2689         (CppStyleTest.test_indent): Deleted.
2690         (CppStyleTest.test_indent.Foo): Deleted.
2691         (CppStyleTest.test_not_alabel): Deleted.
2692         (CppStyleTest.test_tab): Deleted.
2693         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
2694         (CppStyleTest.test_build_class): Deleted.
2695         (CppStyleTest.test_build_class.definitions): Deleted.
2696         (CppStyleTest.test_build_class.Foo): Deleted.
2697         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
2698         (CppStyleTest.test_build_end_comment): Deleted.
2699         (CppStyleTest.test_build_forward_decl): Deleted.
2700         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
2701         (CppStyleTest.test_build_header_guard): Deleted.
2702         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
2703         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
2704         (CppStyleTest.test_build_printf_format): Deleted.
2705         (CppStyleTest.test_runtime_printf_format): Deleted.
2706         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
2707         (CppStyleTest.test_build_storage_class): Deleted.
2708         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
2709         (CppStyleTest.test_build_storage_class.declaration): Deleted.
2710         (CppStyleTest.test_build_storage_class.after): Deleted.
2711         (CppStyleTest.test_build_storage_class.is): Deleted.
2712         (CppStyleTest.test_legal_copyright): Deleted.
2713         (CppStyleTest.test_invalid_increment): Deleted.
2714         (CppStyleTest.test_enum_bitfields): Deleted.
2715         (CppStyleTest.test_plain_integral_bitfields): Deleted.
2716         (CleansedLinesTest.test_init_empty): Deleted.
2717         (CleansedLinesTest.test_collapse_strings): Deleted.
2718         (OrderOfIncludesTest.tearDown): Deleted.
2719         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
2720         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
2721         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
2722         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
2723         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
2724         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
2725         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
2726         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
2727         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
2728         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
2729         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
2730         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
2731         (OrderOfIncludesTest.test_primary_header): Deleted.
2732         (OrderOfIncludesTest.test_public_primary_header): Deleted.
2733         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
2734         (OrderOfIncludesTest.test_classify_include): Deleted.
2735         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
2736         (CheckForFunctionLengthsTest.tearDown): Deleted.
2737         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
2738         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
2739         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
2740         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
2741         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
2742         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
2743         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
2744         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
2745         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
2746         (CheckForFunctionLengthsTest.function_body): Deleted.
2747         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
2748         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
2749         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
2750         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
2751         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
2752         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
2753         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
2754         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
2755         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
2756         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
2757         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
2758         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
2759         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
2760         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
2761         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
2762         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
2763         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
2764         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
2765         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
2766         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
2767         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
2768         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2769         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2770         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2771         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2772         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2773         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2774         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2775         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2776         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2777         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2778         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2779         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2780         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2781         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2782         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2783         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2784         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2785         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2786         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2787         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2788         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2789         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2790         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2791         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2792         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2793         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2794         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2795         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2796         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2797         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2798         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2799         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2800         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2801         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2802         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2803         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2804         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2805         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2806         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2807         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2808         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2809         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2810         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2811         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2812         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2813         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2814         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2815         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2816         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2817         (LeakyPatternTest.test_get_dc): Deleted.
2818         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2819         (LeakyPatternTest.test_own_get_dc): Deleted.
2820         (LeakyPatternTest.test_create_dc): Deleted.
2821         (LeakyPatternTest.test_create_compatible_dc): Deleted.
2822         (WebKitStyleTest.test_indentation): Deleted.
2823         (WebKitStyleTest.test_indentation.Foo): Deleted.
2824         (WebKitStyleTest.test_indentation.Document): Deleted.
2825         (WebKitStyleTest.test_spacing): Deleted.
2826         (WebKitStyleTest.test_line_breaking): Deleted.
2827         (WebKitStyleTest.test_braces): Deleted.
2828         (WebKitStyleTest.test_braces.MyClass): Deleted.
2829         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2830         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2831         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2832         (WebKitStyleTest.test_null_false_zero): Deleted.
2833         (WebKitStyleTest.test_directive_indentation): Deleted.
2834         (WebKitStyleTest.test_using_std): Deleted.
2835         (WebKitStyleTest.test_using_namespace): Deleted.
2836         (WebKitStyleTest.test_max_macro): Deleted.
2837         (WebKitStyleTest.test_min_macro): Deleted.
2838         (WebKitStyleTest.test_wtf_move): Deleted.
2839         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2840         (WebKitStyleTest.test_names): Deleted.
2841         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2842         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2843         (WebKitStyleTest.test_names.declarations): Deleted.
2844         (WebKitStyleTest.test_names.struct): Deleted.
2845         (WebKitStyleTest.test_names.VectorType): Deleted.
2846         (WebKitStyleTest.test_parameter_names): Deleted.
2847         (WebKitStyleTest.test_comments): Deleted.
2848         (WebKitStyleTest.test_webkit_export_check): Deleted.
2849         (WebKitStyleTest.test_member_initialization_list): Deleted.
2850         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2851         (WebKitStyleTest.test_other): Deleted.
2852         (CppCheckerTest.mock_handle_style_error): Deleted.
2853         (CppCheckerTest._checker): Deleted.
2854         (CppCheckerTest.test_init): Deleted.
2855         (CppCheckerTest.test_eq): Deleted.
2856         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2857         (CppCheckerTest.test_ne): Deleted.
2858         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2859         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2860         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2861         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2862         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2863         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2864
2865 2017-07-05  Saam Barati  <sbarati@apple.com>
2866
2867         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2868         https://bugs.webkit.org/show_bug.cgi?id=174188
2869         <rdar://problem/30581423>
2870
2871         Reviewed by Mark Lam.
2872
2873         * Scripts/run-jsc-stress-tests:
2874
2875 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2876
2877         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2878         https://bugs.webkit.org/show_bug.cgi?id=174150
2879
2880         Reviewed by Mark Lam.
2881
2882         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2883         (TestWebKitAPI::TEST):
2884
2885 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2886
2887         Remove copy of ICU headers from WebKit
2888         https://bugs.webkit.org/show_bug.cgi?id=116407
2889
2890         Reviewed by Alex Christensen.
2891
2892         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2893         * TestWebKitAPI/Configurations/Base.xcconfig:
2894         * WebKitTestRunner/Configurations/Base.xcconfig:
2895
2896 2017-07-05  Chris Dumez  <cdumez@apple.com>
2897
2898         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
2899         https://bugs.webkit.org/show_bug.cgi?id=174163
2900         <rdar://problem/33067518>
2901
2902         Reviewed by Alex Christensen.
2903
2904         Add API test coverage.
2905
2906         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2907         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
2908         (TEST):
2909
2910 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2911
2912         When dragging a selection, clearing the selection in dragstart should not crash the web process
2913         https://bugs.webkit.org/show_bug.cgi?id=174142
2914         <rdar://problem/33067501>
2915
2916         Reviewed by Tim Horton.
2917
2918         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
2919         drag is starting up.
2920
2921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2922         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
2923         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2924         (TestWebKitAPI::TEST):
2925
2926 2017-07-05  Daniel Bates  <dabates@apple.com>
2927
2928         Do not pass API::FrameInfo for source frame or clear out page of target frame on
2929         API navigation
2930         https://bugs.webkit.org/show_bug.cgi?id=174170
2931         <rdar://problem/33140328>
2932
2933         Reviewed by Brady Eidson.
2934
2935         Update tests as needed for the behavior change.
2936
2937         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
2938         (TEST):
2939
2940 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2941
2942         Add WebKitPrivateFrameworkStubs for iOS 11
2943         https://bugs.webkit.org/show_bug.cgi?id=173988
2944
2945         Reviewed by David Kilzer.
2946
2947         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
2948         should use the same directory for private framework stubs.
2949         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2950
2951 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
2952
2953         [MediaStream] Protect request and web view during gUM client callback
2954         https://bugs.webkit.org/show_bug.cgi?id=174096
2955         <rdar://problem/32833102>
2956
2957         Reviewed by Youenn Fablet.
2958
2959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2960         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2961
2962 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2963
2964         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
2965
2966         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2967
2968 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2969
2970         Unreviewed, rolling out r219128.
2971
2972         Spoke with engineer who originally submitted, Patch for APi
2973         test to follow.
2974
2975         Reverted changeset:
2976
2977         "Unreviewed, rolling out r219070."
2978         https://bugs.webkit.org/show_bug.cgi?id=174082
2979         http://trac.webkit.org/changeset/219128
2980
2981 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2982
2983         Unreviewed, rolling out r219070.
2984
2985         This revision caused consistent failures of the API test
2986         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
2987
2988         Reverted changeset:
2989
2990         "Pasting single words copied to UIPasteboard inserts URLs in
2991         editable areas"
2992         https://bugs.webkit.org/show_bug.cgi?id=174082
2993         http://trac.webkit.org/changeset/219070
2994
2995 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2996
2997         Remove unused EFL logo from bot watcher dashboard
2998         https://bugs.webkit.org/show_bug.cgi?id=174136
2999
3000         Reviewed by Alexey Proskuryakov.
3001
3002         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
3003         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
3004
3005 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3006
3007         [GTK] Add more GTK bots to dashboard
3008         https://bugs.webkit.org/show_bug.cgi?id=174129
3009
3010         Reviewed by Carlos Alberto Lopez Perez.
3011
3012         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
3013         them.
3014
3015         This also changes the sort order to put WPE above GTK so that it's not buried under all the
3016         less-essential GTK bots.
3017
3018         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3019         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3020         (WebKitBuildbot):
3021
3022 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3023
3024         [WPE] Add WPE to bot watcher dashboard
3025         https://bugs.webkit.org/show_bug.cgi?id=174119
3026
3027         Reviewed by Alexey Proskuryakov.
3028
3029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
3030         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
3031         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
3032         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3033         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3034         (WebKitBuildbot):
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3036         (table.queue-grid tr.platform.linux-wpe img.logo):
3037
3038 2017-07-03  Lucas Forschler  <lforschler@apple.com>
3039
3040         https://bugs.webkit.org/show_bug.cgi?id=174105
3041         
3042         Reviewed by Stephanie Lewis.
3043
3044         * BuildSlaveSupport/built-product-archive:
3045         (main): Add a -minify parser option
3046         (createZip): Pass along the optional Minify argument if requested
3047         (minifySource): This will trim down archives, logic limited to Mac platform.
3048
3049 2017-07-03  Matt Rajca  <mrajca@apple.com>
3050
3051         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
3052         https://bugs.webkit.org/show_bug.cgi?id=174103
3053
3054         Reviewed by Alex Christensen.
3055
3056         Added an API test.
3057
3058         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
3059         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3060         (TEST): Added test.
3061         * TestWebKitAPI/cocoa/TestWKWebView.h:
3062         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3063         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
3064
3065 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3066
3067         Unreviewed, rolling out r219103.
3068
3069         Caused multiple build failures.
3070
3071         Reverted changeset:
3072
3073         "Remove copy of ICU headers from WebKit"
3074         https://bugs.webkit.org/show_bug.cgi?id=116407
3075         http://trac.webkit.org/changeset/219103
3076
3077 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3078
3079         Remove copy of ICU headers from WebKit
3080         https://bugs.webkit.org/show_bug.cgi?id=116407
3081
3082         Reviewed by Alex Christensen.
3083
3084         Use WTF's copy of ICU headers.
3085
3086         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3087         * TestWebKitAPI/Configurations/Base.xcconfig:
3088         * WebKitTestRunner/Configurations/Base.xcconfig:
3089
3090 2017-07-03  Brady Eidson  <beidson@apple.com>
3091
3092         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3093         https://bugs.webkit.org/show_bug.cgi?id=174073
3094
3095         Reviewed by Andy Estes.
3096
3097         * DumpRenderTree/mac/TestRunnerMac.mm:
3098         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
3099
3100         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
3101         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3102
3103 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3104
3105         Unreviewed, rolling out r219083.
3106
3107         The revision caused an API failure on all testing platforms.
3108
3109         Reverted changeset:
3110
3111         "[MediaStream] Protect request and web view during gUM client
3112         callback"
3113         https://bugs.webkit.org/show_bug.cgi?id=174096
3114         http://trac.webkit.org/changeset/219083
3115
3116 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
3117
3118         webkitpy: Properly number duplicated crashlogs
3119         https://bugs.webkit.org/show_bug.cgi?id=172002
3120
3121         Reviewed by Aakash Jain.
3122
3123         * Scripts/webkitpy/common/system/crashlogs.py:
3124         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
3125         an increasing integer.
3126         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3127         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
3128         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
3129         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
3130
3131 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
3132
3133         WebContent processes crash when the network process crashes with pending connection requests
3134         https://bugs.webkit.org/show_bug.cgi?id=174065
3135         <rdar://problem/30359835>
3136
3137         Reviewed by Tim Horton.
3138
3139         Add a API to ensure UI process tries to relaunch a new network process when the network process
3140         crashes with pending network connection requests.
3141
3142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3143         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
3144         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3145         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3146         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
3147
3148 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
3149
3150         [MediaStream] Protect request and web view during gUM client callback
3151         https://bugs.webkit.org/show_bug.cgi?id=174096
3152         <rdar://problem/32833102>
3153
3154         Reviewed by Youenn Fablet.
3155
3156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3157         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3158
3159 2017-07-03  Andy Estes  <aestes@apple.com>
3160
3161         [Xcode] Add an experimental setting to build with ccache
3162         https://bugs.webkit.org/show_bug.cgi?id=173875
3163
3164         Reviewed by Tim Horton.
3165
3166         On systems that already have ccache(1) installed, this patch adds experimental support for
3167         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
3168
3169         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
3170         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
3171         find the toolchain from which to run clang, and then invokes ccache with the required
3172         arguments.
3173
3174         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
3175         precompiled headers to work properly [1].
3176
3177         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
3178         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
3179         during linking.
3180         
3181         [1] https://ccache.samba.org/manual.html#_precompiled_headers
3182
3183         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3184         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3185         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3186         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
3187         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
3188         * ccache/README.md: Added.
3189         * ccache/ccache-clang: Added.
3190         * ccache/ccache-clang++: Added.
3191         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
3192
3193 2017-07-03  Alex Christensen  <achristensen@webkit.org>
3194
3195         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3196         https://bugs.webkit.org/show_bug.cgi?id=174051
3197
3198         Reviewed by Tim Horton.
3199
3200         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3201         (TestWebKitAPI::TEST_F):
3202
3203 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3204
3205         Unreviewed, rolling out r219024.
3206
3207         This patch cause 3 didferent test to fail.
3208
3209         Reverted changeset:
3210
3211         "REGRESSION(r215096) Queries of URLs with non-special schemes
3212         should not percent-encode single quotes"
3213         https://bugs.webkit.org/show_bug.cgi?id=174051
3214         http://trac.webkit.org/changeset/219024
3215
3216 2017-07-03  Chris Dumez  <cdumez@apple.com>
3217
3218         Drop ResourceLoadStatisticsStore's statisticsLock
3219         https://bugs.webkit.org/show_bug.cgi?id=174080
3220
3221         Reviewed by Brent Fulgham.
3222
3223         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
3224
3225         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3226         (WTR::TestController::isStatisticsPrevalentResource):
3227         (WTR::TestController::isStatisticsHasHadUserInteraction):
3228         (WTR::TestController::isStatisticsGrandfathered):
3229
3230 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3231
3232         Pasting single words copied to UIPasteboard inserts URLs in editable areas
3233         https://bugs.webkit.org/show_bug.cgi?id=174082
3234         <rdar://problem/33046992>
3235
3236         Reviewed by Tim Horton.
3237
3238         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
3239
3240         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3241         (TestWebKitAPI::setUpWebViewForPasteboardTests):
3242         (TestWebKitAPI::TEST):
3243
3244 2017-07-02  Brady Eidson  <beidson@apple.com>
3245
3246         Add API test for all parts of WebKit1 API related to favicons.
3247         https://bugs.webkit.org/show_bug.cgi?id=174069
3248
3249         Reviewed by Andy Estes.
3250
3251         These two API tests cover all WebKit1 API related to icons.
3252         
3253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3254         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
3255         (mainResourceData):
3256         (defaultFaviconData):
3257         (customFaviconData):
3258         (imageFromData):
3259         (+[IconLoadingProtocol canInitWithRequest:]):
3260         (+[IconLoadingProtocol canonicalRequestForRequest:]):
3261         (-[IconLoadingProtocol startLoading]):
3262         (-[IconLoadingProtocol stopLoading]):
3263         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3264         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3265         (TestWebKitAPI::TEST):
3266
3267 2017-07-01  Dan Bernstein  <mitz@apple.com>
3268
3269         [iOS] Remove code only needed when building for iOS 9.x
3270         https://bugs.webkit.org/show_bug.cgi?id=174068
3271
3272         Reviewed by Tim Horton.
3273
3274         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3275         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3276         (WTR::initializeWebViewConfiguration):
3277         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3278         (-[HIDEventGenerator _createIOHIDEventType:]):
3279
3280 2017-07-01  Brady Eidson  <beidson@apple.com>
3281
3282         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
3283         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
3284
3285         Reviewed by Alex Christensen.
3286
3287         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3288
3289 2017-07-01  Dan Bernstein  <mitz@apple.com>
3290
3291         [macOS] Remove code only needed when building for OS X Yosemite
3292         https://bugs.webkit.org/show_bug.cgi?id=174067
3293
3294         Reviewed by Tim Horton.
3295
3296         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3297         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3298         * DumpRenderTree/mac/DumpRenderTree.mm:
3299         (setDefaultsToConsistentValuesForTesting):
3300         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3301         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3302         * MiniBrowser/Configurations/Base.xcconfig:
3303         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3304         * TestWebKitAPI/Configurations/Base.xcconfig:
3305         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3306         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3307         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
3308         (TestWebKitAPI::TEST_F):
3309         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3310         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3311         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3312         (TestWebKitAPI::TEST_F):
3313         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3314         (TestWebKitAPI::TEST):
3315         * WebKitTestRunner/Configurations/Base.xcconfig:
3316         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3317         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3318         (WTR::InjectedBundle::platformInitialize):
3319         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3320         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3321
3322 2017-07-01  Chris Dumez  <cdumez@apple.com>
3323
3324         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
3325         https://bugs.webkit.org/show_bug.cgi?id=174060
3326
3327         Reviewed by Brent Fulgham.
3328
3329         Port WebKitTestRunner over to the new Cocoa SPI.
3330
3331         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3332         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3333         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3334         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
3335         no-ops since this code runs in the WebContent process, not the
3336         UIProcess.
3337
3338         * WebKitTestRunner/TestController.cpp:
3339         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3340
3341 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3342
3343         Unreviewed mac build fix.
3344
3345         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3346         (TestWebKitAPI::TEST):
3347
3348 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3349
3350         Add API to get WKActivatedElementInfo
3351         https://bugs.webkit.org/show_bug.cgi?id=174001
3352         <rdar://problem/29165518>
3353         
3354         Tests for now SPI to get activatedElementInfo.
3355
3356         Reviewed by Tim Horton.
3357
3358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3359         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
3360         (TestWebKitAPI::TEST):
3361
3362 2017-06-30  Chris Dumez  <cdumez@apple.com>
3363
3364         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
3365         https://bugs.webkit.org/show_bug.cgi?id=174038
3366
3367         Reviewed by Brent Fulgham.
3368
3369         Fix typo in API name.
3370
3371         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3372         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3373         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3374         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3375         * WebKitTestRunner/TestController.cpp:
3376         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3377         * WebKitTestRunner/TestController.h:
3378         * WebKitTestRunner/TestInvocation.cpp:
3379         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3380
3381 2017-06-30  Alex Christensen  <achristensen@webkit.org>
3382
3383         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3384         https://bugs.webkit.org/show_bug.cgi?id=174051
3385         <rdar://problem/33002846>
3386
3387         Reviewed by Tim Horton.
3388
3389         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3390         (TestWebKitAPI::TEST_F):
3391
3392 2017-06-30  Daniel Bates  <dabates@apple.com>
3393
3394         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3395         https://bugs.webkit.org/show_bug.cgi?id=165160
3396         <rdar://problem/29451999>
3397
3398         Reviewed by Brady Eidson.
3399
3400         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
3401         for navigations and window creation.
3402
3403         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3404         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
3405         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3406         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
3407         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3408         (TEST):
3409
3410 2017-06-29  Jer Noble  <jer.noble@apple.com>
3411
3412         Make Legacy EME API controlled by RuntimeEnabled setting.
3413         https://bugs.webkit.org/show_bug.cgi?id=173994
3414
3415         Reviewed by Sam Weinig.
3416
3417         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3418
3419 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3420
3421         Follow-up fix for r218996
3422
3423         Unreviewed infrastructure fix.
3424
3425         Repeated calls to 'ios_version' make the log noisy, memoize the function.
3426
3427         * Scripts/webkitpy/port/ios_simulator.py:
3428         (IOSSimulatorPort): Memoize ios_version().
3429
3430 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3431
3432         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3433         https://bugs.webkit.org/show_bug.cgi?id=174017
3434         <rdar://problem/32959782>
3435
3436         Reviewed by Simon Fraser.
3437
3438         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
3439         changes, the caret would appear outside of the iframe.
3440
3441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3442         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
3443         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3444         (checkDragCaretRectIsContainedInRect):
3445         (TestWebKitAPI::TEST):
3446         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3447         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3448         (-[DataInteractionSimulator _resetSimulatedState]):
3449         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3450         (-[DataInteractionSimulator _advanceProgress]):
3451         (-[DataInteractionSimulator lastKnownDragCaretRect]):
3452
3453 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3454
3455         Add support for different versions of iOS when loading test expectations
3456         https://bugs.webkit.org/show_bug.cgi?id=173774
3457         <rdar://problem/32951132>
3458
3459         Rubber-stamped by Aakash Jain.
3460
3461         When running layout tests, we should support multiple version of iOS the same way we do Mac.
3462
3463         * Scripts/webkitpy/port/ios.py:
3464         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
3465         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
3466         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
3467         * Scripts/webkitpy/port/ios_device.py:
3468         (IOSDevicePort.ios_version): Ask connected devices for implementation.
3469         * Scripts/webkitpy/port/ios_device_unittest.py:
3470         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
3471         (IOSDeviceTest.test_baseline_searchpath): Ditto.
3472         (IOSDeviceTest.test_expectations_ordering): Ditto.
3473         * Scripts/webkitpy/port/ios_simulator.py:
3474         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
3475         ask the platform.
3476
3477 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
3478
3479         Fontconfig build breaks with glibc 2.15+
3480         https://bugs.webkit.org/show_bug.cgi?id=174019
3481
3482         Reviewed by Carlos Alberto Lopez Perez.
3483
3484         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
3485
3486         * wpe/jhbuild.modules:
3487         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
3488
3489 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3490
3491         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
3492         https://bugs.webkit.org/show_bug.cgi?id=174010
3493         <rdar://problem/32597802>
3494
3495         Reviewed by Tim Horton.
3496
3497         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
3498         snapshot fails for any reason.
3499
3500         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3501         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
3502         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3503         (TestWebKitAPI::TEST):
3504
3505 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
3506
3507         AX: Cannot call setValue() on contenteditable or ARIA text controls
3508         https://bugs.webkit.org/show_bug.cgi?id=173520
3509
3510         Reviewed by Ryosuke Niwa.
3511
3512         Add setValue() method to WKTR (already existed in DRT).
3513
3514         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3515         (WTR::AccessibilityUIElement::setValue):
3516         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3517         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3518         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3519         (WTR::AccessibilityUIElement::setValue):
3520
3521 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
3522
3523         getBoundingClientRect returns wrong value for combination of page zoom and scroll
3524         https://bugs.webkit.org/show_bug.cgi?id=173841
3525         rdar://problem/32983841
3526
3527         Reviewed by Dean Jackson.
3528
3529         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
3530         always did text zooming.
3531
3532         * MiniBrowser/mac/WK1BrowserWindowController.m:
3533         (-[WK1BrowserWindowController zoomIn:]):
3534         (-[WK1BrowserWindowController zoomOut:]):
3535         (-[WK1BrowserWindowController canResetZoom]):
3536         (-[WK1BrowserWindowController resetZoom:]):
3537
3538 2017-06-29  John Wilander  <wilander@apple.com>
3539
3540         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
3541         https://bugs.webkit.org/show_bug.cgi?id=173940
3542         <rdar://problem/33018125>
3543
3544         Reviewed by Brent Fulgham.
3545
3546         This change allows the TestController to turn off
3547         regular resource load statistics telemetry submission
3548         and to manually control when telemetry is calculated
3549         and submitted.
3550
3551         * WebKitTestRunner/TestController.cpp:
3552         (WTR::TestController::initialize):
3553             Turns off automatic resource load statistics telemetry submission.
3554
3555 2017-06-29  Commit Queue  <commit-queue@webkit.org>
3556
3557         Unreviewed, rolling out r218512.
3558         https://bugs.webkit.org/show_bug.cgi?id=173981
3559
3560         "It changes the behavior of the JS API's JSEvaluateScript
3561         which breaks TurboTax" (Requested by saamyjoon on #webkit).
3562
3563         Reverted changeset:
3564
3565         "test262: Completion values for control flow do not match the
3566         spec"
3567         https://bugs.webkit.org/show_bug.cgi?id=171265
3568         http://trac.webkit.org/changeset/218512
3569
3570 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
3571
3572         Add WebKitSystemInterface for iOS 11
3573         https://bugs.webkit.org/show_bug.cgi?id=173936
3574
3575         Reviewed by Lucas Forschler.
3576
3577         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
3578
3579 2017-06-28  Keith Miller  <keith_miller@apple.com>
3580
3581         VMTraps has some races
3582         https://bugs.webkit.org/show_bug.cgi?id=173941
3583
3584         Reviewed by Michael Saboff.
3585
3586         Add new testing mode for testing the Watchdog with our stress
3587         tests.
3588
3589         * Scripts/run-jsc-stress-tests:
3590
3591 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3592
3593    &n