d95473665cf5972817c85ebc2e228d8030d23e88
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-28  Lucas Forschler  <lforschler@apple.com>
2
3         Add additional Apple Mavericks test bots.
4         
5         Unreviewed.
6         
7         * BuildSlaveSupport/build.webkit.org-config/config.json:
8
9 2013-10-28  Bastien Nocera <hadess@hadess.net>
10
11         Name all the GLib timeout sources
12         https://bugs.webkit.org/show_bug.cgi?id=123229
13
14         Reviewed by Anders Carlsson.
15
16         Give a name to GLib timeout sources, this is helpful when
17         profiling WebKitGTK applications.
18
19 2013-10-28  Bastien Nocera <hadess@hadess.net>
20
21         Replace 0 timeouts g_timeout_add() by g_idle_add()
22         https://bugs.webkit.org/show_bug.cgi?id=123260
23
24         Reviewed by Carlos Garcia Campos.
25
26         A zero timeout should be equivalent to using g_idle_add_full(G_PRIORITY_DEFAULT, ...)
27         without the nagging feeling that the wrong API was used.
28
29         * DumpRenderTree/gtk/DumpRenderTree.cpp: Use g_idle_add() instead
30         of 0-timer.
31         (topLoadingFrameLoadFinished):
32         * DumpRenderTree/gtk/EventSender.cpp: Ditto.
33         (scheduleAsynchronousClickCallback):
34         (scheduleAsynchronousKeyDownCallback):
35
36 2013-10-25  Anton Obzhirov  <a.obzhirov@samsung.com>
37
38         [GTK] [WebKit2] CanHandleRequest API test fails
39         https://bugs.webkit.org/show_bug.cgi?id=88453
40
41         Reviewed by Martin Robinson.
42
43         * Scripts/run-gtk-tests:
44         (TestRunner):
45
46 2013-10-25  Ryosuke Niwa  <rniwa@webkit.org>
47
48         Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.
49
50         * Scripts/webkitpy/port/base.py:
51         (Port.repository_paths):
52
53 2013-10-25  Jer Noble  <jer.noble@apple.com>
54
55         [WTF] Add a multiplication operator (and a few others) to MediaTime
56         https://bugs.webkit.org/show_bug.cgi?id=123137
57
58         Reviewed by Eric Carlson.
59
60         Add tests for new MediaTime operators.
61
62         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
63         (TestWebKitAPI::TEST):
64
65 2013-10-24  Mark Rowe  <mrowe@apple.com>
66
67         Remove references to OS X 10.7 from Xcode configuration settings.
68
69         Now that we're not building for OS X 10.7 they're no longer needed.
70
71         Reviewed by Anders Carlsson.
72
73         * DumpRenderTree/mac/Configurations/Base.xcconfig:
74         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
75         * MiniBrowser/Configurations/Base.xcconfig:
76         * MiniBrowser/Configurations/DebugRelease.xcconfig:
77         * TestWebKitAPI/Configurations/Base.xcconfig:
78         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
79         * WebKitLauncher/Configurations/Base.xcconfig:
80         * WebKitTestRunner/Configurations/Base.xcconfig:
81         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
82
83 2013-10-24  Mark Rowe  <mrowe@apple.com>
84
85         <rdar://problem/15312643> Prepare for the mysterious future.
86
87         Reviewed by David Kilzer.
88
89         * DumpRenderTree/mac/Configurations/Base.xcconfig:
90         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
91         * MiniBrowser/Configurations/Base.xcconfig:
92         * MiniBrowser/Configurations/DebugRelease.xcconfig:
93         * TestWebKitAPI/Configurations/Base.xcconfig:
94         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
95         * WebKitLauncher/Configurations/Base.xcconfig:
96         * WebKitTestRunner/Configurations/Base.xcconfig:
97         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
98
99 2013-10-24  Daniel Bates  <dabates@apple.com>
100
101         Crash in WebCore::NavigationScheduler::startTimer()
102         https://bugs.webkit.org/show_bug.cgi?id=123288
103         <rdar://problem/14055644>
104
105         Reviewed by Alexey Proskuryakov.
106
107         Add API test.
108
109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
110         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html: Added.
111         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm: Added.
112
113 2013-10-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
114
115         [GTK] Disable css-image-orientation
116         https://bugs.webkit.org/show_bug.cgi?id=123257
117
118         Reviewed by Martin Robinson.
119
120         CSS image orientation isn't stable yet. So, test regression happen since r157909.
121         This feature should be enabled again after it is stable.
122
123         * Scripts/webkitperl/FeatureList.pm:
124
125 2013-10-24  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
126
127         Fix argument passing for jhbuild.
128         https://bugs.webkit.org/show_bug.cgi?id=123253
129
130         Reviewed by Gustavo Noronha Silva.
131
132         The update-webkit-libs-jhbuild previously didn't allowed
133         extra arguments to be passed to jhbuild.
134
135         * Scripts/update-webkit-libs-jhbuild:
136         (runJhbuild):
137         * Scripts/update-webkitefl-libs:
138
139 2013-10-24  Sanghyup Lee  <sh53.lee@samsung.com>
140
141         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
142         https://bugs.webkit.org/show_bug.cgi?id=123251
143
144         Reviewed by Csaba Osztrogonác.
145
146         Replace %llu by PRIu64 macro to print an uint64_t value and silent a
147         compilation warning on 64-Bit.
148
149         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
150         (onExceededDatabaseQuota):
151
152 2013-10-24  Ryuan Choi  <ryuan.choi@samsung.com>
153
154         [EFL] Build break with latest EFL 1.8 libraries.
155         https://bugs.webkit.org/show_bug.cgi?id=123245
156
157         Reviewed by Gyuyoung Kim.
158
159         After fixed build break on EFL 1.8 at r138326, EFL libraries are changed
160         Eo typedef and splitted header files which contain version macro.
161
162         * TestWebKitAPI/PlatformWebView.h: Changed Eo typedef.
163         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
164         * WebKitTestRunner/PlatformWebView.h: Ditto.
165
166 2013-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
167
168         [GObject bindings] Make EventTarget interface introspectable
169         https://bugs.webkit.org/show_bug.cgi?id=77835
170
171         Reviewed by Gustavo Noronha Silva.
172
173         * Scripts/webkitpy/style/checker.py: Add exceptions for custom
174         GObject DOM bindings headers.
175
176 2013-10-23  Lucas Forschler  <lforschler@apple.com>
177
178         Add two more mac bots to the Mavericks Test Queue.
179         
180         Unreviewed.
181         
182         * BuildSlaveSupport/build.webkit.org-config/config.json:
183
184 2013-10-23  Filip Pizlo  <fpizlo@apple.com>
185
186         Have a way of dealing with slow tests in run-jsc-stress-tests
187         https://bugs.webkit.org/show_bug.cgi?id=123221
188
189         Reviewed by Mark Hahnenberg.
190         
191         If you add the slow! command to //@ then all subsequent plans are prepended to the run list
192         rather than appended to it. This means that slow tests get queued up first and are less likely
193         to block completion.
194
195         * Scripts/run-jsc-stress-tests:
196
197 2013-10-23  Alex Christensen  <achristensen@webkit.org>
198
199         Explicitly build Win32 or x64 configuration on Windows.
200         https://bugs.webkit.org/show_bug.cgi?id=123206
201
202         Reviewed by Brent Fulgham.
203
204         * Scripts/webkitdirs.pm:
205         (jscPath):
206         (determineConfigurationForVisualStudio):
207         (determinePassedConfiguration):
208         Add |Win32 to the end of 32-bit Visual Studio build configurations.
209         (safariPath):
210         * Scripts/build-webkit:
211         * Scripts/old-run-webkit-tests:
212         * Scripts/run-api-tests:
213         (testToolPath):
214         * Scripts/run-javascriptcore-tests:
215         (testapiPath):
216         * Scripts/run-regexp-tests:
217         (testapiPath):
218         * Scripts/sunspider-compare-results:
219         (pathToBuiltJSC):
220         Use configuration instead of configurationForVisualStudio, which are now always different.
221
222 2013-10-23  Mark Lam  <mark.lam@apple.com>
223
224         Re-instate ProposedDatabases needed by detailsForNameAndOrigin().
225         https://bugs.webkit.org/show_bug.cgi?id=123131.
226
227         Reviewed by Geoffrey Garen.
228
229         Updated these files to allow database quotas to grow within a limit for
230         testing purposes.
231
232         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
233         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
234         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
235         (onExceededDatabaseQuota):
236         * DumpRenderTree/mac/UIDelegate.mm:
237         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
238         * DumpRenderTree/win/UIDelegate.cpp:
239         (UIDelegate::exceededDatabaseQuota):
240         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
241         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
242         * WebKitTestRunner/TestController.cpp:
243         (WTR::exceededDatabaseQuota):
244
245 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
246
247         It's valid to have a build ID of 0.
248
249         Reviewed by Tim Hatcher.
250
251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
252         (BuildbotIteration):
253
254 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
255
256         Remove Lion bots from the Dashboard.
257
258         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
259         (WebKitBuildbot):
260
261 2013-10-23  Mario Sanchez Prada  <mario.prada@samsung.com>
262
263         [GTK] Expose image links properly
264         https://bugs.webkit.org/show_bug.cgi?id=84044
265
266         Reviewed by Chris Fleizach.
267
268         Expose the accessible URL if present, as yet another attribute
269         for the AccessibilityUIElement wrapper. For coherence with what
270         the Mac port does (and what you would expect as the output of
271         the layout test), we strip the absolute URL path for relative
272         references, if it's the case, leaving the base of the URL path
273         out of the exposed string.
274
275         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
276         (attributesOfElement): Print the AXURL, if available.
277         (AccessibilityUIElement::url): Expose the URL if present. That
278         is, if the wrapped AtkObject implements AtkHyperlinkImpl.
279         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
280         (attributesOfElement): Print the AXURL, if available.
281         (WTR::AccessibilityUIElement::url): Expose the URL if present.
282         That is, if the wrapped AtkObject implements AtkHyperlinkImpl.
283
284 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
285
286         Remove Lion bots.
287
288         * BuildSlaveSupport/build.webkit.org-config/config.json:
289
290 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
291
292         Dashboard repaints constantly
293         https://bugs.webkit.org/show_bug.cgi?id=122133
294
295         Reviewed by Tim Horton.
296         
297         Pulsing shadows are really bad for battery life.
298
299         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
300         (.status-line.bad .bubble):
301         (.status-line.bad .message):
302
303 2013-10-22  Commit Queue  <commit-queue@webkit.org>
304
305         Unreviewed, rolling out r157835.
306         http://trac.webkit.org/changeset/157835
307         https://bugs.webkit.org/show_bug.cgi?id=123192
308
309         broke 32-bit builds (Requested by smfr on #webkit).
310
311         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
312         (TestWebKitAPI::TEST):
313
314 2013-10-22  Jer Noble  <jer.noble@apple.com>
315
316         [WTF] Add a multiplication operator (and a few others) to MediaTime
317         https://bugs.webkit.org/show_bug.cgi?id=123137
318
319         Reviewed by Eric Carlson.
320
321         Add tests for new MediaTime operators.
322
323         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
324         (TestWebKitAPI::TEST):
325
326 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
327
328         Educate webkitpy about Mavericks.
329
330         Reviewed by Ryosuke Niwa.
331
332         * Scripts/webkitpy/common/system/platforminfo.py:
333         (PlatformInfo._determine_mac_version):
334         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
335         (TestPlatformInfo.test_os_version):
336         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
337         (TestExpectationParser):
338         * Scripts/webkitpy/port/builders.py:
339         * Scripts/webkitpy/port/mac.py:
340         (MacPort):
341         * Scripts/webkitpy/port/mac_unittest.py:
342         (test_versions):
343         (test_baseline_search_path):
344         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
345         (TestRebaselineTest.test_baseline_directory):
346         (TestRebaselineExpectations.test_rebaseline_expectations):
347
348 2013-10-22  Stephanie Lewis  <slewis@apple.com>
349
350         Update the build trigger list for Mavericks.
351
352         Unreviewed.
353
354         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
355         (_should_file_trigger_build):
356
357 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
358
359         Add Mavericks bots to the dashboard.
360
361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
362         (WebKitBuildbot):
363
364 2013-10-22  Samuel White  <samuel_white@apple.com>
365
366         AX: Add paramAttrs to fetch start and end text markers in a given rect.
367         https://bugs.webkit.org/show_bug.cgi?id=122164
368
369         Reviewed by Chris Fleizach.
370
371         Added accessibility element hooks to test endTextMarkerForBounds and startTextMarkerForBounds.
372
373         * DumpRenderTree/AccessibilityUIElement.cpp:
374         (endTextMarkerForBoundsCallback):
375         (startTextMarkerForBoundsCallback):
376         (AccessibilityUIElement::endTextMarkerForBounds):
377         (AccessibilityUIElement::startTextMarkerForBounds):
378         (AccessibilityUIElement::getJSClass):
379         * DumpRenderTree/AccessibilityUIElement.h:
380         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
381         (AccessibilityUIElement::endTextMarkerForBounds):
382         (AccessibilityUIElement::startTextMarkerForBounds):
383         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
384         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
385         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
386         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
387         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
388         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
389         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
390         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
391         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
392         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
393         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
394
395 2013-10-22  Ryosuke Niwa  <rniwa@webkit.org>
396
397         There should be a way to specify additional repository paths in NRWT
398         https://bugs.webkit.org/show_bug.cgi?id=123135
399
400         Reviewed by Alexey Proskuryakov.
401
402         Added --additional-repository-name and --additional-repository-path options to NRWT.
403         These options allow us to submit addtional repository information, such as of Safari's
404         to the new flakiness dashboard.
405
406         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
407         (parse_args):
408         * Scripts/webkitpy/port/base.py:
409         (Port.repository_paths):
410
411 2013-10-22  Commit Queue  <commit-queue@webkit.org>
412
413         Unreviewed, rolling out r157774.
414         http://trac.webkit.org/changeset/157774
415         https://bugs.webkit.org/show_bug.cgi?id=123167
416
417         causes python test to fail (Requested by smfr on #webkit).
418
419         * Scripts/webkitpy/layout_tests/controllers/manager.py:
420         (Manager.run):
421         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
422         (TestExpectations.__init__):
423         (TestExpectations._add_expectations):
424         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
425         (parse_args):
426         (_set_up_derived_options):
427
428 2013-10-22  Lucas Forschler  <lforschler@apple.com>
429
430         Prepare WebKit Buildbot master for Mavericks.
431         This adds the following bot configurations:
432             Mavericks Release/Debug builders
433             Mavericks Release/Debug WK1 Testers
434             Mavericks Release/Debug WK2 Testers
435
436         Unreviewed.
437         
438         * BuildSlaveSupport/build.webkit.org-config/config.json:
439
440 2013-10-21  Tamas Gergely  <gertom@inf.u-szeged.hu>
441
442         Run tests as if they are expected to pass when --force is given.
443         https://bugs.webkit.org/show_bug.cgi?id=112890
444
445         Reviewed by Ryosuke Niwa.
446
447         The --force switch of new-run-webkit-tests is now forces all tests to
448         be run with 'PASS' as expected result.
449
450         * Scripts/webkitpy/layout_tests/controllers/manager.py:
451         (Manager.run):
452         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
453         (TestExpectations.__init__):
454         (TestExpectations._add_expectations):
455         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
456         (parse_args):
457         (_set_up_derived_options):
458
459 2013-10-21  Mark Rowe  <mrowe@apple.com>
460
461         Add a version of WebKitSystemInterface for Mavericks.
462
463         Reviewed by Ryosuke Niwa.
464
465         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
466         * Scripts/copy-webkitlibraries-to-product-directory:
467         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
468
469 2013-10-21  Anders Carlsson  <andersca@apple.com>
470
471         Navigation policy callback not called when performing the same fragment navigation twice
472         https://bugs.webkit.org/show_bug.cgi?id=123121
473         <rdar://problem/15230466>
474
475         Reviewed by Beth Dakin.
476
477         Add a test.
478
479         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
480         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
481         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
482         (+[WebKit1FragmentNavigationTestDelegate shared]):
483         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
484         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
485         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
486         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
487         (TestWebKitAPI::TEST):
488
489 2013-10-21  Dan Bernstein  <mitz@apple.com>
490
491         Style checker should allow a space after the @property keyword
492         https://bugs.webkit.org/show_bug.cgi?id=123117
493
494         Reviewed by Anders Carlsson.
495
496         * Scripts/webkitpy/style/checkers/cpp.py:
497         (check_spacing_for_function_call): Allow a space between @property and the following (
498         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
499         (CppStyleTest.test_spacing_for_fncall): Added a test case.
500
501 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
502
503         [WinCairo] Build does not start.
504         https://bugs.webkit.org/show_bug.cgi?id=123059
505
506         Reviewed by Csaba Osztrogonác.
507
508         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
509
510         * Scripts/build-webkit:
511
512 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
513
514         [Jhbuild] Bump the required Jhbuild revision
515         https://bugs.webkit.org/show_bug.cgi?id=123089
516
517         Reviewed by Carlos Garcia Campos.
518
519         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
520         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
521         in the Jhbuild source so a more recent revision of it should be used.
522
523 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
524
525         Mac build fix.
526
527         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
528
529 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
530
531         Enable webaudio/ tests on DRT/Mac
532         https://bugs.webkit.org/show_bug.cgi?id=86914
533
534         Reviewed by Darin Adler.
535
536         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
537         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
538         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
539         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
540
541         * DumpRenderTree/TestRunner.cpp:
542         (setAudioResultCallback): 
543         (TestRunner::staticFunctions):
544         * DumpRenderTree/TestRunner.h:
545         (TestRunner::audioResult):
546         (TestRunner::setAudioResult):
547         The function has a different name and argument type now, updated accordingly.
548         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
549
550         * DumpRenderTree/mac/DumpRenderTree.mm:
551         (dumpAudio): Updated for the new name of audioResult accessor.
552         (dump): Print the result in the format webkitpy currently expects.
553
554         * WebKitTestRunner/TestInvocation.cpp:
555         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
556         chunks made no sense.
557
558         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
559         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
560
561         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
562         so that "SourceProvider.h" can be found.
563
564 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
565
566         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
567         https://bugs.webkit.org/show_bug.cgi?id=123070
568
569         Reviewed by Alexey Proskuryakov.
570
571         * Scripts/webkitpy/layout_tests/controllers/manager.py:
572         (Manager.run):
573         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
574         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
575         in the test expectations when this argument is set to true.
576
577 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
578
579         Mac DumpRenderTree builds without NDEBUG even in release mode
580         https://bugs.webkit.org/show_bug.cgi?id=123066
581
582         Reviewed by Dan Bernstein.
583
584         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
585         * DumpRenderTree/mac/Configurations/Base.xcconfig:
586         Use the same pattern as WebCore and WebKitTestRunner.
587
588 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
589
590         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
591         https://bugs.webkit.org/show_bug.cgi?id=123064
592
593         Reviewed by Ryosuke Niwa.
594
595         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
596
597         * Scripts/webkitpy/common/config/ports.py: Added.
598         (DeprecatedPort):
599         (DeprecatedPort.name):
600         (DeprecatedPort.flag):
601         (DeprecatedPort.script_path):
602         (DeprecatedPort.script_shell_command):
603         (DeprecatedPort.port):
604         (DeprecatedPort.makeArgs):
605         (DeprecatedPort.update_webkit_command):
606         (DeprecatedPort.check_webkit_style_command):
607         (DeprecatedPort.prepare_changelog_command):
608         (DeprecatedPort.build_webkit_command):
609         (DeprecatedPort.run_javascriptcore_tests_command):
610         (DeprecatedPort.run_webkit_unit_tests_command):
611         (DeprecatedPort.run_webkit_tests_command):
612         (DeprecatedPort.run_python_unittests_command):
613         (DeprecatedPort.run_perl_unittests_command):
614         (DeprecatedPort.run_bindings_tests_command):
615         (MacPort):
616         (MacWK2Port):
617         (MacWK2Port.run_webkit_tests_command):
618         (WinPort):
619         (WinPort.run_bindings_tests_command):
620         (GtkPort):
621         (GtkPort.build_webkit_command):
622         (GtkPort.run_webkit_tests_command):
623         (GtkWK2Port):
624         (GtkWK2Port.build_webkit_command):
625         (GtkWK2Port.run_webkit_tests_command):
626         (QtPort):
627         (QtPort.build_webkit_command):
628         (QtPort.run_webkit_tests_command):
629         (QtWK2Port):
630         (QtWK2Port.build_webkit_command):
631         (QtWK2Port.run_webkit_tests_command):
632         (EflPort):
633         (EflPort.build_webkit_command):
634         (EflWK2Port):
635         (EflWK2Port.build_webkit_command):
636         * Scripts/webkitpy/common/config/ports_mock.py: Added.
637         (MockPort):
638         (MockPort.name):
639         (MockPort.check_webkit_style_command):
640         (MockPort.update_webkit_command):
641         (MockPort.build_webkit_command):
642         (MockPort.prepare_changelog_command):
643         (MockPort.run_python_unittests_command):
644         (MockPort.run_perl_unittests_command):
645         (MockPort.run_javascriptcore_tests_command):
646         (MockPort.run_webkit_unit_tests_command):
647         (MockPort.run_webkit_tests_command):
648         (MockPort.run_bindings_tests_command):
649         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
650         (DeprecatedPortTest):
651         (DeprecatedPortTest.test_mac_port):
652         (DeprecatedPortTest.test_gtk_port):
653         (DeprecatedPortTest.test_gtk_wk2_port):
654         (DeprecatedPortTest.test_efl_port):
655         (DeprecatedPortTest.test_qt_port):
656         (DeprecatedPortTest.test_qt_wk2_port):
657         * Scripts/webkitpy/port/base.py:
658         (Port._port_flag_for_scripts):
659         (Port._wk2_port_name):
660         * Scripts/webkitpy/port/base_unittest.py:
661         (PortTest.test_build_path):
662         * Scripts/webkitpy/port/efl_unittest.py:
663         (EflPortTest.test_show_results_html_file):
664         * Scripts/webkitpy/port/gtk_unittest.py:
665         (GtkPortTest.test_get_crash_log):
666         * Scripts/webkitpy/port/mac_unittest.py:
667         (test_64bit):
668         * Scripts/webkitpy/port/test.py:
669         (TestPort.virtual_test_suites):
670         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
671         (FlakyTestReporter.__init__):
672         * Scripts/webkitpy/tool/bot/irc_command.py:
673         (Rollout._update_working_copy):
674         * Scripts/webkitpy/tool/commands/download_unittest.py:
675         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
676         (AbstractEarlyWarningSystem.run_command):
677         * Scripts/webkitpy/tool/commands/queues.py:
678         (PatchProcessingQueue.begin_work_queue):
679         (CommitQueue.run_command):
680         * Scripts/webkitpy/tool/main.py:
681         (WebKitPatch.__init__):
682         (WebKitPatch.deprecated_port):
683         (WebKitPatch.handle_global_options):
684         * Scripts/webkitpy/tool/mocktool.py:
685         (MockTool.__init__):
686         (MockTool.deprecated_port):
687         * Scripts/webkitpy/tool/steps/build.py:
688         (Build.build):
689         * Scripts/webkitpy/tool/steps/checkstyle.py:
690         (CheckStyle.run):
691         * Scripts/webkitpy/tool/steps/commit.py:
692         (Commit._check_test_expectations):
693         * Scripts/webkitpy/tool/steps/preparechangelog.py:
694         (PrepareChangeLog.run):
695         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
696         (PrepareChangeLogForRevert.run):
697         * Scripts/webkitpy/tool/steps/runtests.py:
698         (RunTests.run):
699         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
700         (RunTestsTest.test_webkit_run_unit_tests):
701         * Scripts/webkitpy/tool/steps/steps_unittest.py:
702         (StepsTest.test_runtests_args):
703         * Scripts/webkitpy/tool/steps/update.py:
704         (Update._update_command):
705         * Scripts/webkitpy/tool/steps/update_unittest.py:
706         (UpdateTest.test_update_command_non_interactive):
707         (UpdateTest.test_update_command_interactive):
708
709 2013-10-19  Andreas Kling  <akling@apple.com>
710
711         RefPtr::releaseNonNull() incorrectly increments the refcount.
712         <https://webkit.org/b/123063>
713
714         Add an API test to verify that no extra refs are added when calling
715         RefPtr::releaseNonNull().
716
717         Reviewed by Anders Carlsson.
718
719 2013-10-18  Rik Cabanier <cabanier@adobe.com>
720         Add Rik Cabanier to list of committers
721         https://bugs.webkit.org/show_bug.cgi?id=123031
722
723         reviewed by Dirk Schulze.
724
725         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
726
727 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
728
729         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
730         https://bugs.webkit.org/show_bug.cgi?id=122970
731
732         Reviewed by Mario Sanchez Prada.
733
734         Removed an invalid signal to set an object state to layout-complete
735         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
736
737         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
738         (axObjectEventListener): Replaced layout-complete with load-complete.
739         (connectAccessibilityCallbacks): Connect callback to new listener for
740         ATK:AtkDocument:load-complete.
741         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
742         for ATK:AtkDocument:load-complete.
743         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
744         (axObjectEventListener): Replaced layout-complete with load-complete.
745         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
746         Connect callback to new listener for ATK:AtkDocument:load-complete.
747         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
748         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
749
750 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
751
752         [GTK] Generate API documentation for GObject DOM bindings
753         https://bugs.webkit.org/show_bug.cgi?id=121538
754
755         Reviewed by Gustavo Noronha Silva.
756
757         The .symbols file that is now generated for checking GObject DOM
758         bindings API compatibility while building can also be used to
759         generate the files needed to produce the gtk-doc
760         documentation. The new script generate-webkitdom-doc-files can
761         generate the docs.sgml and sections.txt files from the given list
762         of .symbols files.
763
764         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
765         and webkitdomgtk-sections.txt as well as rules to install the
766         generated WebKitDOMGTK documentation.
767         * gtk/generate-gtkdoc:
768         (webkitdom_docs_html_path): New helper function that returns the
769         path where the DOM API documentation has been generated.
770         (get_webkit2_options): Include DOM API docs to the list of xref
771         dependencies.
772         (get_webkit1_options): Ditto.
773         (get_webkitdom_options): Return the gtk-doc options to generate
774         the DOM API docs.
775         (get_webkitdom_options.derived_sources_path):
776         (get_webkitdom_options.src_path):
777         * gtk/generate-webkitdom-doc-files: Added.
778         (WebKitDOMDocGenerator):
779         (WebKitDOMDocGenerator.write_header):
780         (WebKitDOMDocGenerator.write_section):
781         (WebKitDOMDocGenerator.write_footer):
782         (WebKitDOMDocGeneratorDocs):
783         (WebKitDOMDocGeneratorDocs.write_header):
784         (write_section):
785         (write_footer):
786         (WebKitDOMDocGeneratorSections):
787         (WebKitDOMDocGeneratorSections.__init__):
788         (WebKitDOMDocGeneratorSections._dom_class):
789         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
790         (WebKitDOMDocGeneratorSections._symbol_list):
791         (WebKitDOMDocGeneratorSections.write_section):
792
793 2013-10-17  Alex Christensen  <achristensen@webkit.org>
794
795         Run JavaScriptCore tests again on Windows.
796         https://bugs.webkit.org/show_bug.cgi?id=122787
797
798         Reviewed by Tim Horton.
799
800         * Scripts/build-jsc:
801         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
802         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
803         * Scripts/webkitdirs.pm:
804         (determineConfigurationForVisualStudio):
805         (determineConfigurationProductDir):
806         Build directory should end with bin64 and configuration should end with |x64 on Win64.
807         (isAppleWinWebKit):
808         (copyInspectorFrontendFiles):
809         (setPathForRunningWebKitApp):
810         Separated WinCairo directories and options from AppleWin.
811
812 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
813
814         Unreviewed. Add myself as a reviewer.
815
816         * Scripts/webkitpy/common/config/contributors.json:
817
818 2013-10-17  Andreas Kling  <akling@apple.com>
819
820         Make it possible to assign a PassRef to a RefPtr.
821         <https://webkit.org/b/122943>
822
823         Added a small API test for RefPtr=(PassRef) so we know this code
824         will compile (and work.)
825
826         Reviewed by Antti Koivisto.
827
828 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
829
830         We need test coverage for just the Baseline JIT
831         https://bugs.webkit.org/show_bug.cgi?id=122929
832
833         Reviewed by Sam Weinig.
834         
835         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
836         variant.
837
838         * Scripts/run-jsc-stress-tests:
839
840 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
841
842         Support multiple repositories in submitting results to --results-server-host
843         https://bugs.webkit.org/show_bug.cgi?id=122935
844
845         Reviewed by Anders Carlsson.
846
847         Remoevd --got-revision and added the logic to extract revision information
848         from multiple repositories as done in run-perf-tests.
849
850         * Scripts/webkitpy/layout_tests/controllers/manager.py:
851         (Manager.upload_results):
852         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
853         (parse_args):
854
855 2013-10-16  Darin Adler  <darin@apple.com>
856
857         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
858         https://bugs.webkit.org/show_bug.cgi?id=122904
859
860         Reviewed by Anders Carlsson.
861
862         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
863
864 2013-10-16  Darin Adler  <darin@apple.com>
865
866         Need tests for RefPtr self-assignment and self-move-assignment.
867
868         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
869
870 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
871
872         [EFL] Minibrowser can't load child window's location
873         https://bugs.webkit.org/show_bug.cgi?id=122485
874
875         Reviewed by Gyuyoung Kim.
876
877         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
878             followed by an explicit call to ewk_view_url_set() where appropriate.
879         (on_key_down):
880         (on_window_create):
881         (window_create):
882         (elm_main):
883
884 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
885
886         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
887         https://bugs.webkit.org/show_bug.cgi?id=122872
888
889         Reviewed by Anders Carlsson.
890
891         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
892         failing.
893
894 2013-10-15  Dean Jackson  <dino@apple.com>
895
896         Add ENABLE_WEB_ANIMATIONS flag
897         https://bugs.webkit.org/show_bug.cgi?id=122871
898
899         Reviewed by Tim Horton.
900
901         Eventually might be http://dev.w3.org/fxtf/web-animations/
902         but this is just engine-internal work at the moment.
903
904         * Scripts/webkitperl/FeatureList.pm:
905
906 2013-10-15  Darin Adler  <darin@apple.com>
907
908         Add some API tests for Vector, RefPtr, and Ref
909         https://bugs.webkit.org/show_bug.cgi?id=122840
910
911         Reviewed by Andreas Kling.
912
913         * TestWebKitAPI/CMakeLists.txt: Added new files.
914         * TestWebKitAPI/GNUmakefile.am: Ditto.
915         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
916         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
918
919         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
920         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
921         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
922         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
923
924 2013-10-14  Roger Fong  <roger_fong@apple.com>
925
926         Adding myself to CC list for some components.
927
928         * Scripts/webkitpy/common/config/watchlist:
929
930 2013-10-13  Darin Adler  <darin@apple.com>
931
932         Deprecate or remove deleteAllValues functions; there are only a few call sites left
933         https://bugs.webkit.org/show_bug.cgi?id=122738
934
935         Reviewed by Anders Carlsson.
936
937         * DumpRenderTree/win/DRTDataObject.cpp:
938         (DRTDataObject::~DRTDataObject):
939         * DumpRenderTree/win/UIDelegate.cpp:
940         (DRTUndoStack::~DRTUndoStack):
941         (DRTUndoStack::clear):
942         Renamed deleteAllValues to deprecatedDeleteAllValues.
943
944         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
945
946 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
947
948         build.webkit.org/dashboard incorrectly shows interrupted builds as green
949         https://bugs.webkit.org/show_bug.cgi?id=122732
950
951         Reviewed by Tim Hatcher.
952
953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
954         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
955         I don't see it occur any time in recent history, but judging from what happens for
956         status 5 (RETRY), we can just finish this function normally.
957         Record overall text description for iteration as BuildbotIteration.text.
958
959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
960         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
961         but no tests failed, make it yellow, and use buildbot-provided description for it.
962
963 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
964
965         Remove Chromium specific code from flakiness dashboard
966         https://bugs.webkit.org/show_bug.cgi?id=122714
967
968         Reviewed by Sam Weinig.
969
970         Also removed code related to GPU tests and virtual suites.
971         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
972
973         * TestResultServer/model/jsonresults_unittest.py:
974         * TestResultServer/static-dashboards/builders.js:
975         * TestResultServer/static-dashboards/dashboard_base.js:
976         * TestResultServer/static-dashboards/flakiness_dashboard.html:
977         * TestResultServer/static-dashboards/flakiness_dashboard.js:
978         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
979         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
980         * TestResultServer/static-dashboards/history.js:
981         * TestResultServer/static-dashboards/loader.js:
982         * TestResultServer/static-dashboards/ui.js:
983         * TestResultServer/templates/uploadform.html:
984
985 2013-10-11  Timothy Hatcher  <timothy@apple.com>
986
987         Remove preference support for picking the old Web Inspector.
988         https://bugs.webkit.org/show_bug.cgi?id=122655
989
990         Reviewed by Alexey Proskuryakov.
991
992         * WebKitTestRunner/TestController.cpp:
993         (WTR::TestController::resetStateToConsistentValues):
994
995 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
996
997         Fix 64-bit build on everything but Windows.
998
999         Rubber stamped by Brent Fulgham.
1000
1001         * Scripts/webkitdirs.pm:
1002         (argumentsForConfiguration):
1003
1004 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1005
1006         Touch a file to see how auto-update works.
1007
1008         Rubber-stamped by Tim Hatcher.
1009
1010         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1011
1012 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1013
1014         LeaksViewer fails to present recent results list if current build is still updating svn
1015         https://bugs.webkit.org/show_bug.cgi?id=122670
1016
1017         Fixed an obvious mistake in the previous patch.
1018
1019         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1020         (RecentBuildsLoader.prototype.start):
1021
1022 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1023
1024         LeaksViewer fails to present recent results list if current build is still updating svn
1025         https://bugs.webkit.org/show_bug.cgi?id=122670
1026
1027         Reviewed by Adam Roben.
1028
1029         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1030         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
1031
1032 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
1033
1034         Unreviewed build fix for --64-bit target.
1035
1036         * Scripts/webkitdirs.pm:
1037         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
1038         been removed by this point.
1039         (hasArgument): Remove unused temporary.
1040
1041 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1042
1043         webkit-patch failure-reason has a quite low limit for 'too many failures'
1044         https://bugs.webkit.org/show_bug.cgi?id=122556
1045
1046         Reviewed by Darin Adler.
1047
1048         * Scripts/webkitpy/tool/commands/queries.py:
1049         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
1050         to match what the layout test runners use these days.
1051
1052 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1053
1054         webkit-patch failure-reason should allow specifying failures one is interested in
1055         https://bugs.webkit.org/show_bug.cgi?id=122554
1056
1057         Reviewed by Darin Adler.
1058
1059         * Scripts/webkitpy/tool/commands/queries.py:
1060         (FailureReason):
1061         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
1062         loop if the ones we're interested in been explained.
1063         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
1064         (FailureReason.execute): initialize failures to explain and the explained set.
1065
1066 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
1067
1068         Make sure that DataTypes.h is in the binary drop.
1069
1070         Rubber stamped by Michael Saboff.
1071
1072         * Scripts/export-llvm-build:
1073
1074 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
1075
1076         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
1077         https://bugs.webkit.org/show_bug.cgi?id=122566
1078
1079         Reviewed by Mark Rowe.
1080
1081         * Scripts/configure-llvm:
1082
1083 2013-10-10  Mark Rowe  <mrowe@apple.com>
1084
1085         <rdar://problem/13341666> WebKit should always build against an SDK.
1086
1087         Have all projects default to building against the OS X Internal SDK for the Production
1088         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
1089         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
1090
1091         Reviewed by Dan Bernstein.
1092
1093         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1094         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1095         * MiniBrowser/Configurations/Base.xcconfig:
1096         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1097         * TestWebKitAPI/Configurations/Base.xcconfig:
1098         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1099         * WebKitTestRunner/Configurations/Base.xcconfig:
1100         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1101
1102 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
1103
1104         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
1105
1106         * Scripts/run-gtk-tests:
1107         (TestRunner): skip TestInspectorServer.
1108
1109 2013-10-10  Andres Gomez  <agomez@igalia.com>
1110
1111         [GTK] Provide search functionality to MiniBrowser
1112         https://bugs.webkit.org/show_bug.cgi?id=117631
1113
1114         Reviewed by Carlos Garcia Campos.
1115
1116         Adds a search bar to MiniBrowser with the minimum functionality
1117         and a new button to the toolbar for showing the new search
1118         bar. Typical keyboard shortcuts are also added.
1119
1120         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
1121         (doSearch):
1122         (searchNext):
1123         (searchPrevious):
1124         (searchCloseButtonClickedCallback):
1125         (searchEntryMenuIconPressedCallback):
1126         (searchEntryClearIconReleasedCallback):
1127         (searchEntryChangedCallback):
1128         (searchEntryActivatedCallback):
1129         (searchPrevButtonClickedCallback):
1130         (searchNextButtonClickedCallback):
1131         (searchMenuCheckButtonToggledCallback):
1132         (browser_search_bar_init):
1133         (browserSearchBarFinalize):
1134         (browser_search_bar_class_init):
1135         (browser_search_bar_new):
1136         (browser_search_bar_add_accelerators):
1137         (browser_search_bar_open):
1138         (browser_search_bar_close):
1139         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
1140         * MiniBrowser/gtk/BrowserWindow.c:
1141         (webViewEnterFullScreen): Closes new search bar.
1142         (webViewLeaveFullScreen): Opens new search bar if previously
1143         visible.
1144         (searchCallback): Added. Shows and hides the new search bar.
1145         (browser_window_init): Added search button to the toolbar.
1146         (browserWindowConstructed): Creates the new search bar.
1147         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
1148
1149 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1150
1151         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
1152         https://bugs.webkit.org/show_bug.cgi?id=122552
1153
1154         Reviewed by Darin Adler.
1155
1156         * Scripts/webkitpy/common/checkout/commitinfo.py:
1157         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
1158         will cause UnicodeDecodeError for non-ascii characters.
1159
1160 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1161
1162         Would like a link to dashboard from build.webkit.org main page
1163         https://bugs.webkit.org/show_bug.cgi?id=122577
1164
1165         Reviewed by Tim Hatcher.
1166
1167         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
1168
1169 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
1170
1171         [Win] Check for MathML fonts and warn user if they are missing.
1172         https://bugs.webkit.org/show_bug.cgi?id=122568
1173
1174         Reviewed by Tim Horton.
1175
1176         * Scripts/webkitdirs.pm:
1177         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
1178         Windows-specific code I added previously.
1179         (fontExists): Added
1180         (checkInstalledTools): Add check for MathML fonts.
1181
1182 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1183
1184         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
1185         https://bugs.webkit.org/show_bug.cgi?id=122471
1186
1187         Reviewed by Tim Hatcher.
1188
1189         Added links to webkitpy, webkitperl and bindings-tests results.
1190
1191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1192         (Buildbot.prototype.apiTestResultsURLForIteration):
1193         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
1194         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
1195         (Buildbot.prototype.bindingsTestResultsURLForIteration):
1196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1197         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1198
1199 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1200
1201         Move some functions from WebKitBuildbot to Buildbot class.
1202
1203         Suggested by Tim Hatcher.
1204
1205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1206         (Buildbot.prototype.javascriptTestResultsURLForIteration):
1207         (Buildbot.prototype.apiTestResultsURLForIteration):
1208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1209         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1210
1211 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1212
1213         Add API tests to the Dashbord page.
1214
1215         https://bugs.webkit.org/show_bug.cgi?id=122283
1216
1217         Reviewed by Timothy Hatcher.
1218
1219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1220         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1222         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
1223
1224 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1225
1226         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
1227
1228         https://bugs.webkit.org/show_bug.cgi?id=122515
1229
1230         Reviewed by Alexey Proskuryakov.
1231
1232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1233         (BuildbotIteration.prototype.update):
1234
1235 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1236
1237         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
1238         https://bugs.webkit.org/show_bug.cgi?id=122573
1239
1240         Reviewed by Tim Hatcher.
1241
1242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1243         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
1244
1245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1246         (Buildbot.prototype.buildPageURLForIteration): Added.
1247
1248 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1249
1250         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
1251         https://bugs.webkit.org/show_bug.cgi?id=122569
1252
1253         Reviewed by Tim Hatcher.
1254
1255         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1256         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
1257         to be produced by the old Mozilla test harness that we don't use any more.
1258
1259 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1260
1261         Add GTK 64 bits release to the buildbot dashboard
1262         https://bugs.webkit.org/show_bug.cgi?id=122548
1263
1264         Reviewed by Darin Adler.
1265
1266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
1267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1268         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
1269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1270         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
1271
1272 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1273
1274         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
1275         https://bugs.webkit.org/show_bug.cgi?id=120638
1276
1277         Reviewed by Gustavo Noronha Silva.
1278
1279         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
1280         can check both the old and new APIs to retrieve text at a given offset.
1281
1282 2013-10-08  Alex Christensen  <achristensen@webkit.org>
1283
1284         Improved WinLauncher.
1285         https://bugs.webkit.org/show_bug.cgi?id=122536
1286
1287         Reviewed by Brent Fulgham.
1288
1289         * WinLauncher/PrintWebUIDelegate.cpp:
1290         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
1291         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1292         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
1293         * WinLauncher/WinLauncher.cpp:
1294         (createCrashReport): Use the executable name instead of "WinLauncher".
1295         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
1296         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
1297         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
1298
1299 2013-10-08  Mark Lam  <mark.lam@apple.com>
1300
1301         Fix ruby LoadError when running run-javascriptcore-tests.
1302         https://bugs.webkit.org/show_bug.cgi?id=122519.
1303
1304         Reviewed by Mark Hahnenberg.
1305
1306         The scripts needed to explicitly require 'rubygems' for older versions of ruby
1307         (versions before 1.9).
1308
1309         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
1310         * Scripts/run-jsc-stress-tests:
1311
1312 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1313
1314         Unreviewed, add my new email to contributors.json.
1315
1316         * Scripts/webkitpy/common/config/contributors.json:
1317
1318 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
1319
1320         Unreviewed build correction.
1321
1322         * Scripts/webkitpy/port/win.py:
1323         (WinPort.write_registry_value): Use string representation of error message to avoid
1324         format conversion problem.
1325
1326 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
1327
1328         [Win] Add checks for proper build and test environment
1329         https://bugs.webkit.org/show_bug.cgi?id=122466
1330
1331         Reviewed by Darin Adler.
1332
1333         This patch makes two changes:
1334         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
1335            error messages so that people know what to fix to get things working.
1336         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
1337            the various environment settings are properly configured for our test environment.
1338
1339         * Scripts/webkitdirs.pm:
1340         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
1341         caused problems in the past.
1342         (setupAppleWinEnv):
1343         * Scripts/webkitpy/port/win.py:
1344         (WinPort):
1345         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
1346         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
1347         DWORD, etc.)
1348         (WinPort.write_registry_string): Revise to call new generic registry write function.
1349         (WinPort.setup_crash_log_saving): Revise for new API
1350         (WinPort.restore_crash_log_saving): Ditto
1351         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
1352         servers from running.
1353         (WinPort.allow_error_dialogs): Ditto.
1354         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
1355         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
1356
1357 2013-10-08  Philippe Normand  <pnormand@igalia.com>
1358
1359         [GStreamer] enable v4l2 plugin
1360         https://bugs.webkit.org/show_bug.cgi?id=122503
1361
1362         Reviewed by Martin Robinson.
1363
1364         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
1365         we updated our GStreamer version to 1.0.8.
1366
1367 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1368
1369         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
1370         https://bugs.webkit.org/show_bug.cgi?id=122104
1371
1372         Reviewed by Chris Fleizach.
1373
1374         Updated stringAttributeValue to double check that the exposure of
1375         aria-invalid as a state is consistent with its exposure as a text
1376         attribute as well, when it applies (implementations of AtkText).
1377
1378         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1379         (AccessibilityUIElement::stringAttributeValue): Add double check.
1380         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1381         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1382
1383 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
1384
1385         run-jsc-stress-tests progress meter should update more quickly on older Rubies
1386         https://bugs.webkit.org/show_bug.cgi?id=122459
1387
1388         Reviewed by Darin Adler.
1389
1390         * Scripts/run-jsc-stress-tests:
1391
1392 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1393
1394         [buildbot] parse tests that are reported as crashed correctly for GTK+
1395         https://bugs.webkit.org/show_bug.cgi?id=122476
1396
1397         Reviewed by Martin Robinson.
1398
1399         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1400         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
1401         as a failure of the API tests.
1402
1403 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1404
1405         Unreviewed. Skipping API test that is causing the next one to crash,
1406         see https://bugs.webkit.org/show_bug.cgi?id=121970.
1407
1408         * Scripts/run-gtk-tests:
1409         (TestRunner):
1410
1411 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1412
1413         [GTK] run-gtk-tests does not distinguish between failure and crashes
1414         https://bugs.webkit.org/show_bug.cgi?id=122135
1415
1416         Reviewed by Martin Robinson.
1417
1418         The GTK+ API test runner does not distinguish between failures and crashes. This change
1419         makes it do that, so it's easier for us to spot the more important/higher priority crash
1420         case.
1421
1422         * Scripts/run-gtk-tests:
1423         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
1424         so we have more information on how the process ended.
1425         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
1426         (TestRunner.run_tests): report crashes.
1427
1428 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1429
1430         [GTK] Missing packages for APT on install-dependencies
1431         https://bugs.webkit.org/show_bug.cgi?id=121555
1432
1433         Reviewed by Martin Robinson.
1434
1435         * gtk/install-dependencies: add packages that are needed for
1436         building WebKit itself and the jhbuild dependencies.
1437
1438 2013-10-07  Anders Carlsson  <andersca@apple.com>
1439
1440         Fix test failures.
1441
1442         * Scripts/webkitpy/port/base.py:
1443         (Port.to.start_helper):
1444         * Scripts/webkitpy/port/mock_drt.py:
1445         (MockDRTPort.start_helper):
1446
1447 2013-10-07  Anders Carlsson  <andersca@apple.com>
1448
1449         Always force discrete mode when running layout tests
1450         https://bugs.webkit.org/show_bug.cgi?id=122465
1451
1452         Reviewed by Tim Horton.
1453
1454         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
1455         
1456         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1457         Link with IOKit.
1458
1459         * DumpRenderTree/mac/LayoutTestHelper.m:
1460         (installLayoutTestColorProfile):
1461         Check installColorProfile.
1462
1463         (restoreUserColorProfile):
1464         Check installColorProfile.
1465
1466         (lockDownDiscreteGraphics):
1467         New function to force discrete graphics.
1468
1469         (main):
1470         Add '--install-color-profile' option.
1471
1472         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1473         (Manager._set_up_run):
1474         Always start the helper, but pass self._options.pixel_tests to it.
1475
1476         * Scripts/webkitpy/port/mac.py:
1477         (MacPort.start_helper):
1478         Pass --install-color-profile' to the helper if pixel_tests is true.
1479
1480 2013-10-07  Timothy Hatcher  <timothy@apple.com>
1481
1482         Properly count binding test failures as failures.
1483
1484         Fix the total for multiple failures in different steps too by avoiding undefined.
1485
1486         https://bugs.webkit.org/show_bug.cgi?id=122232
1487
1488         Reviewed by Alexey Proskuryakov.
1489
1490         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1491         (BuildbotTestResults):
1492         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1493         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1494
1495 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1496
1497         [GTK] Fails to build with jhbuild with newer system glib
1498         https://bugs.webkit.org/show_bug.cgi?id=122132
1499
1500         Reviewed by Martin Robinson.
1501
1502         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
1503         started relying on. glib is not a dependency that should change test results, and is provided in
1504         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
1505         should not be an issue.
1506
1507         * gtk/jhbuild.modules:
1508
1509 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1510
1511         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
1512         https://bugs.webkit.org/show_bug.cgi?id=122437
1513
1514         Reviewed by Antoine Quint.
1515
1516         * Scripts/run-jsc-stress-tests:
1517
1518 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1519
1520         Unreviewed, fix build on old Rubies.
1521
1522         * Scripts/run-jsc-stress-tests:
1523
1524 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1525
1526         Unified test infrastructure via the jsc shell
1527         https://bugs.webkit.org/show_bug.cgi?id=120696
1528
1529         Reviewed by Oliver Hunt.
1530         
1531         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
1532         output (silent or noisy) and different styles of test failure (just bad exit code,
1533         text diff, filtering for some magical text, etc.). This allows me to get rid of the
1534         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
1535         running in run-jsc-stress-tests.
1536         
1537         Also removes all of the code paths that defended against not having shellwords. Just
1538         install the shellwords gem if you want to run tests.
1539         
1540         Also removes the non-parallel test running code. No reason for it to exist anymore.
1541         
1542         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
1543         as part of this patch, and left three more as new bugzillas.
1544
1545         * Scripts/create-mozilla-js-test-list: Added.
1546         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
1547         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
1548         * Scripts/run-javascriptcore-tests:
1549         * Scripts/run-jsc-stress-tests:
1550
1551 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1552
1553         run-jsc-stress-tests should be less verbose
1554         https://bugs.webkit.org/show_bug.cgi?id=122397
1555
1556         Reviewed by Sam Weinig.
1557         
1558         It now just prints something like:
1559         
1560          965/1831 ....
1561         
1562         Where the first number is the number of tests that completed, the second number is the
1563         number of tests total, and the dots are the number of tests running right now - which is
1564         useful towards the end when you're waiting for the last slow tests to finish.
1565         
1566         It will also print out the output from failing tests and it will print a line for skipped
1567         tests (to annoy you into getting them into a shape where they can be unskipped). For
1568         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
1569
1570         * Scripts/run-jsc-stress-tests:
1571
1572 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1573
1574         Allow skipping of run-jsc-stress-tests that are configured using yaml files
1575         https://bugs.webkit.org/show_bug.cgi?id=122385
1576
1577         Reviewed by Sam Wieinig.
1578         
1579         Make tests run via YAML be able to do the parse-for-commands trick that allows
1580         us to skip tests and do other custom per-test stuff.
1581
1582         * Scripts/jsc-stress-test-helpers/layout-test-helper:
1583         * Scripts/run-jsc-stress-tests:
1584
1585 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1586
1587         Unreviewed, fix tests on older Rubies.
1588
1589         * Scripts/run-jsc-stress-tests:
1590
1591 2013-10-05  Anders Carlsson  <andersca@apple.com>
1592
1593         Don't filter the weak symbols.
1594
1595         * Scripts/check-for-weak-vtables-and-externals:
1596
1597 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1598
1599         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
1600         https://bugs.webkit.org/show_bug.cgi?id=122376
1601
1602         Reviewed by Mark Hahnenberg.
1603
1604         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
1605         * Scripts/run-javascriptcore-tests:
1606         (printThingsFound):
1607         * Scripts/run-jsc-stress-tests:
1608
1609 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1610
1611         It should be even easier to run and debug a failing JSC stress test
1612         https://bugs.webkit.org/show_bug.cgi?id=122337
1613
1614         Reviewed by Oliver Hunt.
1615         
1616         If a test fails, you can now just say:
1617
1618         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
1619
1620         and get the reproduction. You don't have to set any environment variables like before.
1621         Also if you want to debug the failing test you can now just say:
1622
1623         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
1624
1625         Broadly, any arguments passed to the reproduction script are prepended to the command to
1626         run the test. This is sort of quirky and won't work for some tests (for example the
1627         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
1628         them and that's good enough for now.
1629
1630         * Scripts/run-jsc-stress-tests:
1631
1632 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1633
1634         [Windows] Correct run-path when using 64-bit binaries.
1635
1636         Reviewed by David Kilzer.
1637
1638         * Scripts/webkitdirs.pm:
1639         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
1640         directory. Otherwise use the existing 'bin32' directory.
1641
1642 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1643
1644         Teach webkitdirs.pm to honor the --64-bit flag
1645         https://bugs.webkit.org/show_bug.cgi?id=122357
1646
1647         Reviewed by David Kilzer.
1648
1649         * Scripts/webkitdirs.pm:
1650         (argumentsForConfiguration): Modify to check if --64-bit is supplied
1651         by the user.
1652         (findMatchingArguments): Added.
1653         (hasArgument): Added.
1654         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
1655         findMatchingArguments subroutine.
1656
1657 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1658
1659         Update svn-config for new Visual Studio extensions
1660         https://bugs.webkit.org/show_bug.cgi?id=122344
1661
1662         Reviewed by Brent Fulgham.
1663
1664         * svn-config: Add new Visual Studio extensions.
1665
1666 2013-10-04  Alex Christensen  <achristensen@webkit.org>
1667
1668         Made WinLauncher have better error handling, crash reporting, and modifiability.
1669         https://bugs.webkit.org/show_bug.cgi?id=122319
1670
1671         Reviewed by Brent Fulgham.
1672
1673         * WinLauncher/WinLauncher.cpp:
1674         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1675         Don't display the numerous "Cancelled" messages that are obviously from the user.
1676         (createCrashReport): Added.
1677         (dllLauncherEntryPoint):
1678         Made main loop back into while loop and write a crash report if it crashes.
1679         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1680         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1681         Added WinLauncherReplace.h.
1682         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1683         Added linking to DbgHelp.lib.
1684         * WinLauncher/WinLauncherReplace.h:
1685         Added to make modifying WinLauncher behaviour and appearance easy.
1686         (processCrashDump): Added.
1687
1688 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
1689
1690         remove dpranke from webkitpy watchlist
1691         https://bugs.webkit.org/show_bug.cgi?id=122331
1692
1693         Reviewed by Brent Fulgham.
1694
1695         * Scripts/webkitpy/common/config/watchlist:
1696
1697 2013-10-04  Tim Horton  <timothy_horton@apple.com>
1698
1699         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1700         https://bugs.webkit.org/show_bug.cgi?id=122299
1701
1702         Reviewed by Beth Dakin.
1703
1704         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1705         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1706         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
1707
1708 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1709
1710         Watchlist is broken after <http://trac.webkit.org/r156880>
1711
1712         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
1713
1714 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1715
1716         Remove Qt features from build and test tools
1717         https://bugs.webkit.org/show_bug.cgi?id=122312
1718
1719         Reviewed by Anders Carlsson.
1720
1721         * Scripts/build-dumprendertree:
1722         * Scripts/build-jsc:
1723         * Scripts/build-webkit:
1724         * Scripts/build-webkittestrunner:
1725         * Scripts/old-run-webkit-tests:
1726         (openDumpTool):
1727         (buildPlatformResultHierarchy):
1728         (buildPlatformTestHierarchy):
1729         (readSkippedFiles):
1730         * Scripts/run-launcher:
1731         * Scripts/run-qtwebkit-tests: Removed.
1732         * Scripts/run-webkit-tests:
1733         (useNewRunWebKitTests):
1734         * Scripts/update-webkit:
1735         * Scripts/webkit-build-directory:
1736         * Scripts/webkitdirs.pm:
1737         (argumentsForConfiguration):
1738         (jscProductDir):
1739         (builtDylibPathForName):
1740         (isAppleWebKit):
1741         (launcherPath):
1742         (launcherName):
1743         (checkRequiredSystemConfig):
1744         (setupCygwinEnv):
1745         (copyInspectorFrontendFiles):
1746         (setPathForRunningWebKitApp):
1747         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1748         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1749         (BaselineOptimizerTest.test_mac_future):
1750         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1751         (BaselineOptimizerTest.test_common_directory_includes_root):
1752         (BaselineOptimizerTest.test_virtual_ports_filtered):
1753         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1754         (test_parse_reviewer_text):
1755         * Scripts/webkitpy/common/config/watchlist:
1756         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1757         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
1758         * Scripts/webkitpy/port/base.py:
1759         (Port.__init__):
1760         (Port._port_flag_for_scripts):
1761         (Port._wk2_port_name):
1762         * Scripts/webkitpy/port/builders.py:
1763         * Scripts/webkitpy/port/factory.py:
1764         (platform_options):
1765         (PortFactory):
1766         (PortFactory._default_port):
1767         * Scripts/webkitpy/port/factory_unittest.py:
1768         (FactoryTest.test_gtk):
1769         * Scripts/webkitpy/port/qt.py: Removed.
1770         * Scripts/webkitpy/port/qt_unittest.py: Removed.
1771         * Scripts/webkitpy/style/checker.py:
1772         * Scripts/webkitpy/style/checker_unittest.py:
1773         (GlobalVariablesTest.test_path_rules_specifier):
1774         * Scripts/webkitpy/style/checkers/cmake.py:
1775         (CMakeChecker):
1776         * Scripts/webkitpy/style/checkers/cpp.py:
1777         (_classify_include):
1778         (check_include_line):
1779         (check_identifier_name_in_declaration):
1780         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1781         (OrderOfIncludesTest.test_classify_include):
1782         (WebKitStyleTest.test_names):
1783         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1784         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1785         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1786         (TestRebaselineTest.test_baseline_directory):
1787         * Scripts/webkitpy/tool/main.py:
1788         (WebKitPatch):
1789
1790 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1791
1792         Unreviewed. Add myself to some watchlists.
1793
1794         * Scripts/webkitpy/common/config/watchlist:
1795
1796 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1797
1798         Remove Qt builders from the flakiness dashboard.
1799
1800         * TestResultServer/static-dashboards/builders.jsonp:
1801         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1802         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1803         * TestResultServer/static-dashboards/loader_unittests.js:
1804
1805 2013-10-03  Tim Horton  <timothy_horton@apple.com>
1806
1807         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1808         https://bugs.webkit.org/show_bug.cgi?id=122299
1809
1810         Reviewed by Beth Dakin.
1811
1812         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1813         Disable threaded scrolling.
1814
1815         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1816         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1817         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
1818
1819 2013-10-03  Anders Carlsson  <andersca@apple.com>
1820
1821         Use numeric strings in the OS version dictionary
1822         https://bugs.webkit.org/show_bug.cgi?id=122300
1823
1824         Reviewed by Mark Rowe.
1825
1826         * Scripts/webkitpy/common/system/platforminfo.py:
1827         (PlatformInfo._determine_mac_version):
1828
1829 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
1830
1831         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
1832
1833         Rubber-stamped by Tim Horton.
1834
1835         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1836         (LeaksViewer._displayURLPrompt):
1837
1838 2013-10-03  Dan Bernstein  <mitz@apple.com>
1839
1840         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
1841         https://bugs.webkit.org/show_bug.cgi?id=122260
1842
1843         Reviewed by Alexey Proskuryakov.
1844
1845         For the API to work, the tests need to be compiled with a newer version of the LLVM
1846         compiler. Until the bots are updated to that version, disable the tests on 10.8.
1847
1848         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1849
1850 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1851
1852         [ATK] Expose aria-invalid as a text attribute (not object attribute)
1853         https://bugs.webkit.org/show_bug.cgi?id=122015
1854
1855         Reviewed by Chris Fleizach.
1856
1857         Adapted DRT and WKTR to check the exposure of the aria-invalid
1858         attribute as a text attribute, instead of an object attribute.
1859
1860         Also, done some refactoring of the code to try to keep things
1861         simpler and more coherent, by defining new helper functions,
1862         simplifying code, moving static variables and functions into
1863         unnammed namespaces and so on, without altering the logic other
1864         than for checking the text attribute for aria-invalid.
1865
1866         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1867         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
1868         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
1869         Also, never return an empty string if not falling through any of
1870         the cases checked here, and return the original attribute instead.
1871         (atkAttributeValueToCoreAttributeValue): New helper function to
1872         match the attributes values returned by the ATK wrapper with the
1873         values expected by the layout tests. Moved the mappings for the
1874         values of AXSortDirection here as well.
1875         (getAttributeSet): New helper function to retrieve a list of
1876         attributes (an AtkAttributeSet) from an AtkObject using the right
1877         API depending on whether we want the object attributes or the text
1878         attributes (in case the object implements AtkText).
1879         (getAttributeSetValueForId): Simplified by using getAttributeSet
1880         and atkAttributeValueToCoreAttributeValue. Also, added a new
1881         parameter to indicater whether we are interested in object
1882         attributes or text attributes.
1883         (getAtkAttributeSetAsString): Ditto.
1884         (attributesOfElement): Updated to pass the new required parameter
1885         to getAtkAttributeSetAsString, indicating that we want the object
1886         attributes in this case, for backwards compatibility.
1887         (indexRangeInTable): Moved up in the file into the unnammed namespace.
1888         (alterCurrentValue): Ditto.
1889         (AccessibilityUIElement::stringAttributeValue): After moving most
1890         of the code here to the new helper functions, simplified it by
1891         just checking whether the required attribute is provided as an
1892         object attribute or, if that's not the case, as a text attribute.
1893         (AccessibilityUIElement::isAttributeSupported): Ditto.
1894         (AccessibilityUIElement::intValue): Updated to pass the new
1895         required parameter to getAttributeSetValueForId, indicating that
1896         we want the object attributes in this case.
1897         (AccessibilityUIElement::hasPopup): Ditto.
1898
1899         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1900         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
1901         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
1902         (WTR::getAttributeSet): Ditto.
1903         (WTR::getAttributeSetValueForId): Ditto.
1904         (WTR::getAtkAttributeSetAsString): Ditto.
1905         (WTR::attributesOfElement): Ditto.
1906         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1907         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
1908         (WTR::AccessibilityUIElement::intValue): Ditto.
1909         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1910
1911 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1912
1913         EWS build fix after the Qt EWS removal.
1914
1915         * QueueStatusServer/model/attachment.py:
1916         (Attachment._calculate_queue_positions):
1917
1918 2013-10-02  Anders Carlsson  <andersca@apple.com>
1919
1920         Remove Qt code from Tools/
1921         https://bugs.webkit.org/show_bug.cgi?id=122227
1922
1923         Reviewed by Andreas Kling.
1924
1925         * DumpRenderTree/WorkQueue.cpp:
1926         * DumpRenderTree/blackberry/src.pro: Removed.
1927         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
1928         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
1929         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
1930         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
1931         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
1932         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
1933         * DumpRenderTree/qt/EventSenderQt.h: Removed.
1934         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
1935         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
1936         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
1937         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
1938         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
1939         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
1940         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
1941         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
1942         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
1943         * DumpRenderTree/qt/resources/user.css: Removed.
1944         * DumpRenderTree/qt/testplugin.cpp: Removed.
1945         * DumpRenderTree/qt/testplugin.h: Removed.
1946         * ImageDiff/ImageDiff.pro: Removed.
1947         * ImageDiff/qt/ImageDiff.cpp: Removed.
1948         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
1949         * MiniBrowser/qt/BrowserWindow.h: Removed.
1950         * MiniBrowser/qt/MiniBrowser.pro: Removed.
1951         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
1952         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
1953         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
1954         * MiniBrowser/qt/UrlLoader.cpp: Removed.
1955         * MiniBrowser/qt/UrlLoader.h: Removed.
1956         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
1957         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
1958         * MiniBrowser/qt/icons/contents_width.png: Removed.
1959         * MiniBrowser/qt/icons/favicon.png: Removed.
1960         * MiniBrowser/qt/icons/find.png: Removed.
1961         * MiniBrowser/qt/icons/folder.png: Removed.
1962         * MiniBrowser/qt/icons/info.png: Removed.
1963         * MiniBrowser/qt/icons/next.png: Removed.
1964         * MiniBrowser/qt/icons/plus.png: Removed.
1965         * MiniBrowser/qt/icons/previous.png: Removed.
1966         * MiniBrowser/qt/icons/refresh.png: Removed.
1967         * MiniBrowser/qt/icons/stop.png: Removed.
1968         * MiniBrowser/qt/icons/titlebar.png: Removed.
1969         * MiniBrowser/qt/icons/touch.png: Removed.
1970         * MiniBrowser/qt/icons/touchpoint.png: Removed.
1971         * MiniBrowser/qt/icons/up.png: Removed.
1972         * MiniBrowser/qt/js/MultiSelect.js: Removed.
1973         * MiniBrowser/qt/main.cpp: Removed.
1974         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
1975         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
1976         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
1977         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
1978         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
1979         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
1980         * MiniBrowser/qt/qml/Dialog.qml: Removed.
1981         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
1982         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
1983         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
1984         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
1985         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
1986         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
1987         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
1988         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
1989         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
1990         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
1991         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
1992         * MiniBrowser/qt/raw/Target.pri: Removed.
1993         * MiniBrowser/qt/raw/View.cpp: Removed.
1994         * MiniBrowser/qt/raw/View.h: Removed.
1995         * MiniBrowser/qt/utils.cpp: Removed.
1996         * MiniBrowser/qt/utils.h: Removed.
1997         * QtTestBrowser/QtTestBrowser.pro: Removed.
1998         * QtTestBrowser/QtTestBrowser.qrc: Removed.
1999         * QtTestBrowser/cookiejar.cpp: Removed.
2000         * QtTestBrowser/cookiejar.h: Removed.
2001         * QtTestBrowser/favicon.png: Removed.
2002         * QtTestBrowser/fpstimer.cpp: Removed.
2003         * QtTestBrowser/fpstimer.h: Removed.
2004         * QtTestBrowser/launcherwindow.cpp: Removed.
2005         * QtTestBrowser/launcherwindow.h: Removed.
2006         * QtTestBrowser/locationedit.cpp: Removed.
2007         * QtTestBrowser/locationedit.h: Removed.
2008         * QtTestBrowser/mainwindow.cpp: Removed.
2009         * QtTestBrowser/mainwindow.h: Removed.
2010         * QtTestBrowser/qttestbrowser.cpp: Removed.
2011         * QtTestBrowser/urlloader.cpp: Removed.
2012         * QtTestBrowser/urlloader.h: Removed.
2013         * QtTestBrowser/useragentlist.txt: Removed.
2014         * QtTestBrowser/utils.cpp: Removed.
2015         * QtTestBrowser/utils.h: Removed.
2016         * QtTestBrowser/webinspector.h: Removed.
2017         * QtTestBrowser/webpage.cpp: Removed.
2018         * QtTestBrowser/webpage.h: Removed.
2019         * QtTestBrowser/webview.cpp: Removed.
2020         * QtTestBrowser/webview.h: Removed.
2021         * TestWebKitAPI/DerivedSources.pri: Removed.
2022         * TestWebKitAPI/InjectedBundle.pri: Removed.
2023         * TestWebKitAPI/PlatformWebView.h:
2024         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
2025         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
2026         * TestWebKitAPI/Tests.pri: Removed.
2027         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
2028         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2029         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
2030         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
2031         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
2032         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
2033         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
2034         * TestWebKitAPI/qt/main.cpp: Removed.
2035         * Tools.pro: Removed.
2036         * WebKitTestRunner/DerivedSources.pri: Removed.
2037         * WebKitTestRunner/EventSenderProxy.h:
2038         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
2039         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
2040         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2041         (WTR::InjectedBundlePage::resetAfterTest):
2042         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2043         (WTR::InjectedBundlePage::didClearWindowForFrame):
2044         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
2045         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2046         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
2047         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
2048         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
2049         * WebKitTestRunner/PlatformWebView.h:
2050         * WebKitTestRunner/Target.pri: Removed.
2051         * WebKitTestRunner/TestController.cpp:
2052         (WTR::TestController::resetStateToConsistentValues):
2053         * WebKitTestRunner/TestController.h:
2054         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
2055         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
2056         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
2057         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
2058         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
2059         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
2060         * WebKitTestRunner/qt/main.cpp: Removed.
2061         * WebKitTestRunner/qt/resources/user.css: Removed.
2062         * qmake/.qmake.cache: Removed.
2063         * qmake/.qmake.conf: Removed.
2064         * qmake/README: Removed.
2065         * qmake/config.tests/README: Removed.
2066         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
2067         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
2068         * qmake/config.tests/gccdepends/empty.cpp: Removed.
2069         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
2070         * qmake/config.tests/glx/glx.cpp: Removed.
2071         * qmake/config.tests/glx/glx.pro: Removed.
2072         * qmake/config.tests/gnuld/gnuld.pro: Removed.
2073         * qmake/config.tests/gnuld/main.cpp: Removed.
2074         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
2075         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
2076         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
2077         * qmake/config.tests/libXrender/libXrender.pro: Removed.
2078         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
2079         * qmake/config.tests/libwebp/libwebp.pro: Removed.
2080         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
2081         * qmake/config.tests/libxml2/libxml2.pro: Removed.
2082         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
2083         * qmake/config.tests/libxslt/libxslt.pro: Removed.
2084         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
2085         * qmake/config.tests/libzlib/libzlib.pro: Removed.
2086         * qmake/dump-features.pl: Removed.
2087         * qmake/mkspecs/features/configure.prf: Removed.
2088         * qmake/mkspecs/features/default_post.prf: Removed.
2089         * qmake/mkspecs/features/default_pre.prf: Removed.
2090         * qmake/mkspecs/features/features.prf: Removed.
2091         * qmake/mkspecs/features/features.pri: Removed.
2092         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
2093         * qmake/mkspecs/features/functions.prf: Removed.
2094         * qmake/mkspecs/features/gprof.prf: Removed.
2095         * qmake/mkspecs/features/mac/default_post.prf: Removed.
2096         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
2097         * qmake/mkspecs/features/minimal_qt.prf: Removed.
2098         * qmake/mkspecs/features/production_build.prf: Removed.
2099         * qmake/mkspecs/features/rpath.prf: Removed.
2100         * qmake/mkspecs/features/unix/default_post.prf: Removed.
2101         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
2102         * qmake/mkspecs/features/unix/icc.prf: Removed.
2103         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
2104         * qmake/mkspecs/features/valgrind.prf: Removed.
2105         * qmake/mkspecs/features/webkit_modules.prf: Removed.
2106         * qmake/mkspecs/features/win32/default_post.prf: Removed.
2107         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
2108         * qmake/mkspecs/modules/angle.prf: Removed.
2109         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
2110         * qmake/mkspecs/modules/webcore.prf: Removed.
2111         * qmake/mkspecs/modules/webkit1.prf: Removed.
2112         * qmake/mkspecs/modules/webkit2.prf: Removed.
2113         * qmake/mkspecs/modules/wtf.prf: Removed.
2114
2115 2013-10-02  Tim Horton  <timothy_horton@apple.com>
2116
2117         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
2118         https://bugs.webkit.org/show_bug.cgi?id=121859
2119         <rdar://problem/15069359>
2120
2121         Reviewed by Anders Carlsson.
2122
2123         * WebKitTestRunner/TestInvocation.cpp:
2124         (WTR::shouldUseThreadedScrolling):
2125         (WTR::updateThreadedScrollingForCurrentTest):
2126         (WTR::TestInvocation::invoke):
2127         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2128         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
2129         (WTR::PlatformWebView::PlatformWebView):
2130         (WTR::PlatformWebView::viewSupportsOptions):
2131         Rename the tiled drawing switch to threaded scrolling, since that's really
2132         all it switches now that we use tiled drawing everywhere.
2133
2134         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
2135         and to more closely match the case we're interested in testing.
2136
2137 2013-10-02  Anders Carlsson  <andersca@apple.com>
2138
2139         Move AHEM____.TTF from qt/fonts/ to fonts/.
2140
2141         Rubber-stamped by Andreas Kling.
2142
2143         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2144         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
2145
2146 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
2147
2148         Remove Qt bots and EWS from trunk.
2149         https://bugs.webkit.org/show_bug.cgi?id=122210.
2150
2151         Reviewed by Allan Sandfeld Jensen.
2152
2153         Remove Qt buil dbots.
2154
2155         * BuildSlaveSupport/build.webkit.org-config/config.json:
2156         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2157         (appendCustomBuildFlags):
2158         (RunGtkAPITests.getText2):
2159         (Factory.__init__):
2160         (TestFactory.__init__):
2161         (BuildAndTestFactory.__init__):
2162         (loadBuilderConfig):
2163         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2164
2165 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
2166
2167         Remove Qt bots and EWS from trunk.
2168         https://bugs.webkit.org/show_bug.cgi?id=122210.
2169
2170         Reviewed by Allan Sandfeld Jensen.
2171
2172         Remove Qt EWS bots.
2173
2174         * QueueStatusServer/config/queues.py:
2175         * Scripts/webkitpy/common/config/ews.json:
2176
2177 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2178
2179         Fix singular labels for test failures.
2180
2181         https://bugs.webkit.org/show_bug.cgi?id=122200
2182
2183         Reviewed by Joseph Pecoraro.
2184
2185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2186         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2187
2188 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2189
2190         Don't keep appending iterations each time the queue updates.
2191
2192         https://bugs.webkit.org/show_bug.cgi?id=122198
2193
2194         Reviewed by Joseph Pecoraro.
2195
2196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2197         (BuildbotQueue.prototype.update):
2198
2199 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2200
2201         Properly sort iterations in the Dashboard by revision for out-of-order queues.
2202
2203         https://bugs.webkit.org/show_bug.cgi?id=122196
2204
2205         Reviewed by Brent Fulgham.
2206
2207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2208         (BuildbotIteration):
2209         (BuildbotIteration.prototype.update):
2210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2211         (BuildbotQueue.prototype.update):
2212         (BuildbotQueue.prototype.sortIterations):
2213
2214 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2215
2216         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
2217
2218         Also fix some URLs to not have extras slashes and add a page title.
2219
2220         https://bugs.webkit.org/show_bug.cgi?id=122192
2221
2222         Reviewed by Joseph Pecoraro.
2223
2224         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2225         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2227         (WebKitBuildbot.prototype.buildLogURLForIteration):
2228         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
2229         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
2230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2231
2232 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
2233
2234         [Mac] Set NSApplication current event while sending events directly to views
2235         https://bugs.webkit.org/show_bug.cgi?id=122179
2236
2237         Reviewed by Darin Adler.
2238
2239         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
2240         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
2241         use the current event.
2242
2243         * DumpRenderTree/mac/EventSendingController.mm:
2244         (-[EventSendingController mouseDown:withModifiers:]):
2245         (-[EventSendingController mouseUp:withModifiers:]):
2246         (-[EventSendingController mouseMoveToX:Y:]):
2247         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2248         (-[EventSendingController contextClick]):
2249         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2250         * WebKitTestRunner/mac/EventSenderProxy.mm:
2251         (WTR::EventSenderProxy::mouseDown):
2252         (WTR::EventSenderProxy::mouseUp):
2253         (WTR::EventSenderProxy::mouseMoveTo):
2254         (WTR::EventSenderProxy::keyDown):
2255         (WTR::EventSenderProxy::mouseScrollBy):
2256         Update the current event. We were already using the SPI in WebKit.
2257
2258 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
2259
2260         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
2261         https://bugs.webkit.org/show_bug.cgi?id=122183
2262
2263         Reviewed by Timothy Hatcher.
2264
2265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2266         (BuildbotIteration.prototype.update):
2267
2268 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2269
2270         Tweaks to the Buildbot Dashboard
2271
2272         https://bugs.webkit.org/show_bug.cgi?id=122169
2273
2274         Reviewed by Alexey Proskuryakov.
2275
2276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2277         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2279         (BuildbotQueueView.prototype.revisionLinksForIteration):
2280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2281         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
2283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2285         (WebKitBuildbot.prototype.buildLogURLForIteration):
2286         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2287
2288 2013-10-01  Commit Queue  <commit-queue@webkit.org>
2289
2290         Unreviewed, rolling out r156725.
2291         http://trac.webkit.org/changeset/156725
2292         https://bugs.webkit.org/show_bug.cgi?id=122176
2293
2294         broke all the mismatch tests again (Requested by thorton on
2295         #webkit).
2296
2297         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2298         (WTR::PlatformWebView::PlatformWebView):
2299
2300 2013-10-01  Alex Christensen  <achristensen@webkit.org>
2301
2302         Implemented createWebViewWithRequest in WinLauncher.
2303         https://bugs.webkit.org/show_bug.cgi?id=122069
2304
2305         Reviewed by Brent Fulgham.
2306
2307         * WinLauncher/PrintWebUIDelegate.cpp:
2308         (PrintWebUIDelegate::createWebViewWithRequest): Added.
2309         * WinLauncher/PrintWebUIDelegate.h:
2310         Removed createWebViewWithRequest stub.
2311
2312 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2313
2314         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2315         https://bugs.webkit.org/show_bug.cgi?id=122006
2316         <rdar://problem/15095197>
2317
2318         Reviewed by Dean Jackson.
2319
2320         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2321         (WTR::PlatformWebView::PlatformWebView):
2322         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2323         where the window server snapshot API returns blank snapshots.
2324
2325         Re-landing after r156724, this should not break everything now.
2326
2327 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2328
2329         [mac] 1x emulation on Retina hardware shouldn't use SPI
2330         https://bugs.webkit.org/show_bug.cgi?id=122152
2331         <rdar://problem/15119384>
2332
2333         Reviewed by Anders Carlsson.
2334
2335         * DumpRenderTree/mac/DumpRenderTree.mm:
2336         (createWebViewAndOffscreenWindow):
2337         (main):
2338         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2339         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2340         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2341         (WTR::PlatformWebView::PlatformWebView):
2342         * WebKitTestRunner/mac/main.mm:
2343         (main):
2344         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
2345
2346 2013-09-30  Sam Weinig  <sam@webkit.org>
2347
2348         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
2349         https://bugs.webkit.org/show_bug.cgi?id=116474
2350
2351         Reviewed by Ryosuke Niwa.
2352
2353         * Scripts/webkitpy/style/checkers/cpp.py:
2354         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2355
2356 2013-09-30  Sam Weinig  <sam@webkit.org>
2357
2358         Remove support for DOMFileSystem
2359         https://bugs.webkit.org/show_bug.cgi?id=122137
2360
2361         Reviewed by Anders Carlsson.
2362
2363         * Scripts/webkitperl/FeatureList.pm:
2364         * Scripts/webkitpy/style/checkers/cpp.py:
2365         (check_spacing):
2366         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2367         (CppStyleTest.test_spacing_for_binary_ops):
2368         * qmake/mkspecs/features/features.pri:
2369
2370 2013-09-30  Mark Rowe  <mrowe@apple.com>
2371
2372         More build fixage for builds with SDKs.
2373
2374         * WebKitTestRunner/Configurations/Base.xcconfig:
2375         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2376
2377 2013-09-30  Timothy Hatcher  <timothy@apple.com>
2378
2379         Add initial version of a new Buildbot dashboard view.
2380
2381         https://bugs.webkit.org/show_bug.cgi?id=122131
2382
2383         Reviewed by Alexey Proskuryakov.
2384
2385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
2386         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
2387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
2388         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
2389         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
2390         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
2391         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
2393         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
2395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
2396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
2397         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
2398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
2399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
2400         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
2401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
2402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
2403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
2404         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
2405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
2406         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
2408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
2409         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
2410         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
2411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
2413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
2414         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
2415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
2416         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
2417
2418 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
2419
2420         Remove the code guarded by STYLE_SCOPED
2421         https://bugs.webkit.org/show_bug.cgi?id=122123
2422
2423         Reviewed by Anders Carlsson.
2424
2425         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2426         (resetDefaultsToConsistentValues):
2427         * Scripts/webkitperl/FeatureList.pm:
2428         * qmake/mkspecs/features/features.pri:
2429
2430 2013-09-30  Mark Rowe  <mrowe@apple.com>
2431
2432         Fix the build when building against an SDK.
2433
2434         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
2435         the compiler command lines. It can't know to do this for the system framework search paths
2436         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
2437
2438         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2439         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2440
2441 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
2442
2443         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
2444
2445         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
2446         it to be double-freed.
2447
2448         * WinLauncher/WinLauncher.cpp:
2449         (EditProc): Be explicit about type passed to loadURL.
2450         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
2451         that reallocating the BSTR is done with the knowledge of the smart pointer.
2452
2453 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2454
2455         [Qt] Fix force_static_libs_as_shared in WebKit2
2456         https://bugs.webkit.org/show_bug.cgi?id=121961
2457
2458         Reviewed by Csaba Osztrogonác.
2459
2460         Get rid of the unused WebKit2QML library
2461
2462         * qmake/mkspecs/features/webkit_modules.prf:
2463         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
2464
2465 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
2466
2467         [EFL] Fix incorrect click counting in EventSenderProxy
2468         https://bugs.webkit.org/show_bug.cgi?id=122098
2469
2470         Reviewed by Gyuyoung Kim.
2471
2472         Previously used two types of recording time, which conflicted with each other.
2473
2474         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2475         (WTR::EventSenderProxy::mouseUp):
2476
2477 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
2478
2479         [webkitpy] Make the Xvfb screen depth overridable
2480         https://bugs.webkit.org/show_bug.cgi?id=122089
2481
2482         Reviewed by Gyuyoung Kim.
2483
2484         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
2485         was set. The default value that's used if the variable wasn't set is 24.
2486
2487         * Scripts/webkitpy/port/xvfbdriver.py:
2488         (XvfbDriver._xvfb_screen_depth):
2489         (XvfbDriver._start):
2490         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2491         (XvfbDriverTest.make_driver):
2492         (XvfbDriverTest.test_start_no_pixel_tests):
2493         (XvfbDriverTest.test_start_pixel_tests):
2494         (XvfbDriverTest.test_start_arbitrary_worker_number):
2495         (XvfbDriverTest.test_next_free_display):
2496         (XvfbDriverTest.test_start_next_worker):
2497
2498 2013-09-29  Mark Rowe  <mrowe@apple.com>
2499
2500         Fix the Lion build.
2501
2502         Ensure that C++ and Objective-C++ files build with the right compiler flags.
2503
2504         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2505         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2506
2507 2013-09-28  Mark Rowe  <mrowe@apple.com>
2508
2509         Fix some failures with newer versions of clang.
2510
2511         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
2512         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
2513         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
2514         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
2515         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
2516
2517         Reviewed by Dan Bernstein.
2518
2519         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2520         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2521         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2522         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2523         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2524         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2525         * WebKitTestRunner/Configurations/Base.xcconfig:
2526         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2527         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2528         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2529         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2530
2531 2013-09-27  Commit Queue  <commit-queue@webkit.org>
2532
2533         Unreviewed, rolling out r156569.
2534         http://trac.webkit.org/changeset/156569
2535         https://bugs.webkit.org/show_bug.cgi?id=122035
2536
2537         broke a lot of mismatch tests (Requested by thorton on
2538         #webkit).
2539
2540         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2541         (WTR::PlatformWebView::PlatformWebView):
2542
2543 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2544
2545         Don't retry failures on Apple MountainLion Release WK1 tester
2546         https://bugs.webkit.org/show_bug.cgi?id=122026
2547
2548         Reviewed by Mark Rowe.
2549
2550         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
2551         on this bot.
2552
2553 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2554
2555         Don't hardcode builder specific configuration in buildbot master.cfg
2556         https://bugs.webkit.org/show_bug.cgi?id=122023
2557
2558         Reviewed by Mark Rowe.
2559
2560         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
2561         property to Qt Mountain Lion Release, making it run pixel tests.
2562
2563         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2564         (RunWebKitTests.start): Use additionalArguments.
2565         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
2566
2567 2013-09-27  Tim Horton  <timothy_horton@apple.com>
2568
2569         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2570         https://bugs.webkit.org/show_bug.cgi?id=122006
2571         <rdar://problem/15095197>
2572
2573         Reviewed by Dean Jackson.
2574
2575         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2576         (WTR::PlatformWebView::PlatformWebView):
2577         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2578         where the window server snapshot API returns blank snapshots.
2579
2580 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2581
2582         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
2583         https://bugs.webkit.org/show_bug.cgi?id=106924
2584
2585         Reviewed by Chris Fleizach.
2586
2587         Consider headings levels as values to be returned in intValue()
2588         both in DRT and WKTR, so we can share more tests with other ports.
2589
2590         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2591         (AccessibilityUIElement::intValue): Consider headings too.
2592         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2593         (WTR::AccessibilityUIElement::intValue): Ditto.
2594
2595 2013-09-26  Darin Adler  <darin@apple.com>
2596
2597         rename KURL to URL
2598         https://bugs.webkit.org/show_bug.cgi?id=16214
2599
2600         Reviewed by Andreas Kling.
2601
2602         * many files: Renamed, using script.
2603
2604 2013-09-27  Darin Adler  <darin@apple.com>
2605
2606         Fix Python scripts test failures.
2607
2608         * Scripts/webkitpy/style/checkers/cpp.py:
2609         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
2610         now, not by the checker itself.
2611
2612 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
2613
2614         [GTK][WK2] Logging of accessibility events is not disabled between tests
2615         https://bugs.webkit.org/show_bug.cgi?id=121957
2616
2617         Reviewed by Mario Sanchez Prada.
2618
2619         Fixed an issue in AccessibilityNotificationHandler where the destructor
2620         was not disconnecting accessibility event callbacks if logging was on.
2621         The decision of disconnecting events can solely rely on the existence of
2622         notification handlers because logging uses the global notification
2623         handler.
2624
2625         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2626         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
2627         disconnection when logging is on.
2628
2629 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
2630
2631         Add general CMakeLists.txt for DRT
2632         https://bugs.webkit.org/show_bug.cgi?id=119268
2633
2634         Reviewed by Gyuyoung Kim.
2635
2636         The new file allows better sharing between ports.
2637
2638         * CMakeLists.txt:
2639         * DumpRenderTree/CMakeLists.txt: Added.
2640         * DumpRenderTree/PlatformEfl.cmake: Added.
2641         * DumpRenderTree/efl/CMakeLists.txt: Removed.
2642
2643 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2644
2645         [Qt] Fix force_static_libs_as_shared in WebKit2
2646         https://bugs.webkit.org/show_bug.cgi?id=121961
2647
2648         Reviewed by Csaba Osztrogonác.
2649
2650         Reenable force_static_libs_as_shared when building WebKit2.
2651
2652         * qmake/mkspecs/features/default_post.prf:
2653
2654 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2655
2656         [Qt] Mock implementations of positioning and orientation not used
2657         https://bugs.webkit.org/show_bug.cgi?id=121956
2658
2659         Reviewed by Csaba Osztrogonác.
2660
2661         Move production_build checks to sanitizeFeatures where its value is actually known.
2662
2663         * qmake/mkspecs/features/features.prf:
2664         * qmake/mkspecs/features/features.pri:
2665
2666 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2667
2668         [ATK] Normalize checks in entry points for DRT and WKTR
2669         https://bugs.webkit.org/show_bug.cgi?id=121959
2670
2671         Reviewed by Chris Fleizach.
2672
2673         Always check if we have a proper instance of AtkObject,
2674         implementing the interfaces that we might need for each case, at
2675         the entry point of every method of AccessibilityUIElement for ATK,
2676         and do those checks in an uniform way across DRT and WKTR, to
2677         avoid confusion and issues when modifying these files in the future.
2678
2679         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2680         (AccessibilityUIElement::getChildren): Use normalized checks.
2681         (AccessibilityUIElement::getChildrenWithRange): Ditto.
2682         (AccessibilityUIElement::rowCount): Ditto.
2683         (AccessibilityUIElement::columnCount): Ditto.
2684         (AccessibilityUIElement::childrenCount): Ditto.
2685         (AccessibilityUIElement::elementAtPoint): Ditto.
2686         (AccessibilityUIElement::getChildAtIndex): Ditto.
2687         (AccessibilityUIElement::allAttributes): Ditto.
2688         (AccessibilityUIElement::titleUIElement): Ditto.
2689         (AccessibilityUIElement::parentElement): Ditto.
2690         (AccessibilityUIElement::attributesOfChildren): Ditto.
2691         (AccessibilityUIElement::role): Ditto.
2692         (AccessibilityUIElement::title): Ditto.
2693         (AccessibilityUIElement::description): Ditto.
2694         (AccessibilityUIElement::stringValue): Ditto.
2695         (AccessibilityUIElement::language): Ditto.
2696         (AccessibilityUIElement::x): Ditto.
2697         (AccessibilityUIElement::y): Ditto.
2698         (AccessibilityUIElement::width): Ditto.
2699         (AccessibilityUIElement::height): Ditto.
2700         (AccessibilityUIElement::orientation): Ditto.
2701         (AccessibilityUIElement::intValue): Ditto.
2702         (AccessibilityUIElement::minValue): Ditto.
2703         (AccessibilityUIElement::maxValue): Ditto.
2704         (indexRangeInTable): Ditto.
2705         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
2706         (AccessibilityUIElement::stringAttributeValue): Ditto.
2707         (alterCurrentValue): Ditto.
2708         (AccessibilityUIElement::press): Ditto.
2709         (AccessibilityUIElement::documentEncoding): Ditto.
2710         (AccessibilityUIElement::documentURI): Ditto.
2711         (AccessibilityUIElement::hasPopup): Ditto.
2712
2713         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2714         (WTR::indexRangeInTable): Use normalized checks.
2715         (WTR::alterCurrentValue): Ditto.
2716         (WTR::AccessibilityUIElement::getChildren): Ditto.
2717         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
2718         (WTR::AccessibilityUIElement::childrenCount): Ditto.
2719         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
2720         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
2721         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
2722         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
2723         (WTR::AccessibilityUIElement::parentElement): Ditto.
2724         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2725         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2726         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2727         (WTR::AccessibilityUIElement::role): Ditto.
2728         (WTR::AccessibilityUIElement::title): Ditto.
2729         (WTR::AccessibilityUIElement::description): Ditto.
2730         (WTR::AccessibilityUIElement::orientation): Ditto.
2731         (WTR::AccessibilityUIElement::stringValue): Ditto.
2732         (WTR::AccessibilityUIElement::language): Ditto.
2733         (WTR::AccessibilityUIElement::x): Ditto.
2734         (WTR::AccessibilityUIElement::y): Ditto.
2735         (WTR::AccessibilityUIElement::width): Ditto.
2736         (WTR::AccessibilityUIElement::height): Ditto.
2737         (WTR::AccessibilityUIElement::intValue): Ditto.
2738         (WTR::AccessibilityUIElement::minValue): Ditto.
2739         (WTR::AccessibilityUIElement::maxValue): Ditto.
2740         (WTR::AccessibilityUIElement::rowCount): Ditto.
2741         (WTR::AccessibilityUIElement::columnCount): Ditto.
2742         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
2743         (WTR::AccessibilityUIElement::press): Ditto.
2744         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2745         (WTR::AccessibilityUIElement::documentURI): Ditto.
2746         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2747
2748 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2749
2750         [ATK] accessibility/aria-sort.html is failing after r156409
2751         https://bugs.webkit.org/show_bug.cgi?id=121947
2752
2753         Reviewed by Chris Fleizach.
2754
2755         Implement AccessibilityUIElement::isSupported for the ATK
2756         platforms, just by checking whether we have an associated object
2757         attribute exposed for the wrapper object matching the required
2758         attribute in the layout test (e.g "AXSortDirection" -> "sort").
2759
2760         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2761         (AccessibilityUIElement::isAttributeSupported): Implemented.
2762         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2763         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
2764
2765 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
2766
2767         [MediaStream] make MediaStream testable
2768         https://bugs.webkit.org/show_bug.cgi?id=121967
2769
2770         Reviewed by Dean Jackson.
2771
2772         * DumpRenderTree/mac/UIDelegate.mm:
2773         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
2774             user media request policy delegate.
2775
2776 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
2777
2778         build-webkit --inspector-frontend should copy WebInspectorUI files
2779         https://bugs.webkit.org/show_bug.cgi?id=117851
2780
2781         Reviewed by Joseph Pecoraro.
2782
2783         Change the --inspector-frontend build option to additionally build/copy 
2784         WebInspectorUI by setting it as the only project that needs to be built.
2785
2786         * Scripts/build-webkit:
2787
2788 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2789
2790         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2791         https://bugs.webkit.org/show_bug.cgi?id=121951
2792
2793         Reviewed by Carlos Garcia Campos.
2794
2795         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2796         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2797         500 layout tests that trigger accelerated compositing to be used.
2798
2799         * Scripts/webkitpy/port/xvfbdriver.py:
2800         (XvfbDriver._start):
2801         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
2802         (XvfbDriverTest.test_start_no_pixel_tests):
2803         (XvfbDriverTest.test_start_pixel_tests):
2804         (XvfbDriverTest.test_start_arbitrary_worker_number):
2805         (XvfbDriverTest.test_next_free_display):
2806         (XvfbDriverTest.test_start_next_worker):
2807
2808 2013-09-26  Tim Horton  <timothy_horton@apple.com>
2809
2810         Tiled drawing should not imply threaded scrolling
2811         https://bugs.webkit.org/show_bug.cgi?id=121874
2812         <rdar://problem/15071494>
2813
2814         Reviewed by Sam Weinig.
2815
2816         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2817         (WTR::PlatformWebView::PlatformWebView):
2818         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
2819
2820 2013-09-26  Commit Queue  <commit-queue@webkit.org>
2821
2822         Unreviewed, rolling out r156457.
2823         http://trac.webkit.org/changeset/156457
2824         https://bugs.webkit.org/show_bug.cgi?id=121960
2825
2826         Broke webkitpy tests. (Requested by kling on #webkit).
2827
2828         * Scripts/webkitpy/port/xvfbdriver.py:
2829         (XvfbDriver._start):
2830
2831 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2832
2833         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2834         https://bugs.webkit.org/show_bug.cgi?id=121951
2835
2836         Reviewed by Carlos Garcia Campos.
2837
2838         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2839         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2840         500 layout tests that trigger accelerated compositing to be used.
2841
2842         * Scripts/webkitpy/port/xvfbdriver.py:
2843         (XvfbDriver._start):
2844
2845 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2846
2847         Removed check for Apple Application Support directory in WinCairo port.
2848         https://bugs.webkit.org/show_bug.cgi?id=121869
2849
2850         Reviewed by Brent Fulgham.
2851
2852         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2853         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2854         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2855         Use DLLLauncherWinCairo.props for WinCairo ports.
2856         * win/DLLLauncher/DLLLauncherMain.cpp:
2857         (wWinMain):
2858         Don't call modifyPath to check for AAS in the WinCairo port.
2859         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
2860
2861 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2862
2863         Enabled AssembleBuildLogs on WinCairo port.
2864         https://bugs.webkit.org/show_bug.cgi?id=121923
2865
2866         Reviewed by Brent Fulgham.
2867
2868         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2869         Fixed reference to README, added WinCairo configurations.
2870         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
2871         Fixed reference to README.
2872         * win/AssembleBuildLogs/AssembleLogs.cmd:
2873         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
2874         * win/AssembleBuildLogs/README: Fixed spelling.
2875
2876 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2877
2878         [WIN] Fix MSVC C4146 compiler warning
2879         https://bugs.webkit.org/show_bug.cgi?id=121838
2880
2881         Reviewed by Brent Fulgham.
2882
2883         Fix some variables from unsinged to int to fix the compiler warning
2884         "unary minus operator applied to unsigned type, result still unsigned".
2885
2886         * DumpRenderTree/WorkQueueItem.h:
2887         (BackItem::BackItem):
2888         (ForwardItem::ForwardItem):
2889         * DumpRenderTree/win/DumpRenderTree.cpp:
2890         (createWebViewAndOffscreenWindow):
2891
2892 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
2893
2894         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
2895         https://bugs.webkit.org/show_bug.cgi?id=121256
2896
2897         Reviewed by Martin Robinson.
2898
2899         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
2900         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
2901
2902         * BuildSlaveSupport/build.webkit.org-config/config.json:
2903
2904 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2905
2906         Add style checker for CMake lists
2907         https://bugs.webkit.org/show_bug.cgi?id=121764
2908
2909         Reviewed by Ryosuke Niwa.
2910
2911         Add an additional check to make sure that list of files are sorted.
2912         Exclude lists of include directories for now, since the order
2913         can be importent for compilation of some files.
2914
2915         * Scripts/webkitpy/style/checkers/cmake.py:
2916         (CMakeChecker.check):
2917         (CMakeChecker._check_indent):
2918         (CMakeChecker):
2919         (CMakeChecker._check_list_order):
2920         (CMakeChecker._list_item_path):
2921         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2922         (CMakeCheckerTest.test_check):
2923
2924 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2925
2926         CMakeChecker takes unusually long time to run
2927         https://bugs.webkit.org/show_bug.cgi?id=105662
2928
2929         Reviewed by Ryosuke Niwa.
2930
2931         Move the caching mechanism for regular expression of the C++ checker into
2932         a common file and use it for the CMake and ChangeLog checkers too.
2933
2934         * Scripts/webkitpy/style/checkers/changelog.py:
2935         (ChangeLogChecker.check_entry):
2936         * Scripts/webkitpy/style/checkers/cmake.py:
2937         (CMakeChecker._process_line):
2938         (CMakeChecker._check_no_space_cmds):
2939         (CMakeChecker._check_one_space_cmds):
2940         (CMakeChecker._check_non_lowercase_cmd):
2941         * Scripts/webkitpy/style/checkers/common.py:
2942         (match):
2943         (search):
2944         (searchIgnorecase):
2945         (sub):
2946         (subn):
2947         * Scripts/webkitpy/style/checkers/cpp.py:
2948
2949 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2950
2951         [Qt] Fix build with Qt 5.2 QtPosition module
2952         https://bugs.webkit.org/show_bug.cgi?id=121089
2953
2954         Reviewed by Simon Hausmann.
2955
2956         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
2957         that might depend on them.
2958
2959         * qmake/mkspecs/features/default_pre.prf:
2960         * qmake/mkspecs/features/features.prf:
2961
2962 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
2963
2964         [ATK] Fix style issues in AccessibilityUIElementAtk
2965         https://bugs.webkit.org/show_bug.cgi?id=121898
2966
2967         Reviewed by Chris Fleizach.
2968
2969         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
2970         instead of { 0, { { 0 } } } to initialize a GValue.
2971
2972         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2973         (AccessibilityUIElement::clickPointX): Remove suffix.
2974         (AccessibilityUIElement::clickPointY): Ditto.
2975         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
2976         (AccessibilityUIElement::minValue): Ditto.
2977         (AccessibilityUIElement::maxValue): Ditto.
2978         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
2979         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2980         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
2981         (WTR::AccessibilityUIElement::x): Ditto.
2982         (WTR::AccessibilityUIElement::y): Ditto.
2983         (WTR::AccessibilityUIElement::width): Ditto.
2984         (WTR::AccessibilityUIElement::height): Ditto.
2985         (WTR::AccessibilityUIElement::clickPointX): Ditto.
2986         (WTR::AccessibilityUIElement::clickPointY): Ditto.
2987         (WTR::AccessibilityUIElement::intValue): Ditto.
2988         (WTR::AccessibilityUIElement::minValue): Ditto.
2989         (WTR::AccessibilityUIElement::maxValue): Ditto.
2990
2991 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
2992
2993         [EFL] accessibility/loading-iframe-sends-notification.html is failing
2994         https://bugs.webkit.org/show_bug.cgi?id=112003
2995
2996         Reviewed by Mario Sanchez Prada.
2997
2998         Enabled addNotificationListener and removeNotificationListener for EFL port.
2999
3000         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3001         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3002         (WTR::AccessibilityController::removeNotificationListener):
3003
3004 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
3005
3006         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
3007         https://bugs.webkit.org/show_bug.cgi?id=121844
3008
3009         Reviewed by Mark Hahnenberg.
3010
3011         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
3012
3013 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
3014
3015         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
3016         https://bugs.webkit.org/show_bug.cgi?id=121854
3017
3018         Reviewed by Anders Carlsson.
3019
3020         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3021         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
3022         settings in underlying frameworks.
3023
3024 2013-09-24  Mark Rowe  <mrowe@apple.com>
3025
3026         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
3027
3028         Reviewed by Dan Bernstein.
3029
3030         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3031         * MiniBrowser/Configurations/Base.xcconfig:
3032         * TestWebKitAPI/Configurations/Base.xcconfig:
3033         * WebKitLauncher/Configurations/Base.xcconfig:
3034         * WebKitTestRunner/Configurations/Base.xcconfig:
3035
3036 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
3037
3038         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
3039         https://bugs.webkit.org/show_bug.cgi?id=121674
3040
3041         Reviewed by Mario Sanchez Prada.
3042
3043         Implemented the global notification listener for
3044         AccessibilityController. The signal is generated by
3045         AXObjectCache::postPlatformNotification() and received by
3046         axObjectEventListener(). axObjectEventListener will then invoke
3047         JSObjectCallAsFunction() with the respective callback function.
3048
3049         There is no additional test for this patch since its implementation will
3050         be tested by an accessibility layout test that is currently failing
3051         (accessibility/loading-iframe-sends-notification.html).
3052
3053         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
3054         stub implementations of addNotificationListener and
3055         removeNotificationListener for the GTK port.
3056         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3057         (WTR::AccessibilityController::addNotificationListener): Creates the
3058         notification handler and sets the notification function callback.
3059         (WTR::AccessibilityController::removeNotificationListener): Removes the
3060         global handler.
3061
3062 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
3063
3064         [GTK] fast/images/exif-orientation-composited.html is failing
3065         https://bugs.webkit.org/show_bug.cgi?id=119731
3066
3067         Reviewed by Carlos Garcia Campos.
3068
3069         Add handling respect image orientation property in DRT.
3070
3071         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3072         (TestRunner::overridePreference):
3073
3074 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
3075
3076         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
3077         https://bugs.webkit.org/show_bug.cgi?id=121787
3078
3079         Reviewed by Gustavo Noronha Silva.
3080
3081         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
3082         with the Wayland target enabled to version 3.10.0.
3083
3084 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
3085
3086         use NOMINMAX instead of #define min min
3087         https://bugs.webkit.org/show_bug.cgi?id=73563
3088
3089         Reviewed by Brent Fulgham.
3090
3091         Use NOMINMAX instead of #define min/max as a cleaner
3092         way of ensuring that Windows system header files don't
3093         define min/max as macro in the first place.
3094
3095         * DumpRenderTree/DumpRenderTreePrefix.h:
3096         * DumpRenderTree/cg/ImageDiffCG.cpp:
3097         * DumpRenderTree/config.h:
3098         * DumpRenderTree/win/ImageDiffCairo.cpp:
3099         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3100         * WebKitTestRunner/config.h:
3101
3102 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
3103
3104         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
3105         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
3106
3107         Reviewed by Alexey Proskuryakov.
3108
3109         Previously, initalizing a WebPreference would change the cache model
3110         to WebCacheModelDocumentBrowser. That behavior was due to a stale
3111         preference file on disk.
3112
3113         This patch fixes the tests by resetting the default, and using the proper
3114         default values after initializing WebPreference.
3115
3116         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3117         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
3118         to the previous runs.
3119
3120         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3121         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
3122         cache model to the one required.
3123
3124         * TestWebKitAPI/ios/mainIOS.mm:
3125         (main): Reset the preferences before testing.
3126         * TestWebKitAPI/mac/mainMac.mm:
3127         (main): Ditto.
3128
3129 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
3130
3131         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
3132         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
3133
3134         Reviewed by Alexey Proskuryakov.
3135
3136         Previously, initalizing a WebPreference would change the cache model
3137         to WebCacheModelDocumentBrowser. That behavior was due to a stale
3138         preference file on disk.
3139
3140         This patch fixes the tests by resetting the default, and using the proper
3141         default values after initializing WebPreference.
3142
3143         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3144         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
3145         to the previous runs.
3146
3147         * TestWebKitAPI/ios/mainIOS.mm:
3148         (main): Reset the preferences before testing.
3149         * TestWebKitAPI/mac/mainMac.mm:
3150         (main): Ditto.
3151
3152 2013-09-23  Anders Carlsson  <andersca@apple.com>
3153
3154         ListHashSet should work with move-only types
3155         https://bugs.webkit.org/show_bug.cgi?id=121802
3156
3157         Reviewed by Andreas Kling.
3158
3159         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3160         (TestWebKitAPI::TEST):
3161         Add a test for move-only types.
3162
3163 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
3164
3165         Added --64-bit option for Windows build.
3166         https://bugs.webkit.org/show_bug.cgi?id=121799
3167
3168         Reviewed by Brent Fulgham.
3169
3170         * Scripts/webkitdirs.pm:
3171         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
3172         (isWin64): Added.
3173         (determineIsWin64): Added.
3174
3175 2013-09-23  Anders Carlsson  <andersca@apple.com>
3176
3177         ListHashSet should use std::reverse_iterator for reverse iterators
3178         https://bugs.webkit.org/show_bug.cgi?id=121795
3179
3180         Reviewed by Antti Koivisto.
3181
3182         Add test for reverse iterators.
3183
3184         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3185         (TestWebKitAPI::TEST):
3186
3187 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
3188
3189         [EFL] accessibility/aria-invalid is failing
3190         https://bugs.webkit.org/show_bug.cgi?id=111986
3191
3192         Reviewed by Mario Sanchez Prada.
3193
3194         Adds possibility to retrieve JS context.
3195         This is part of the implementation of AccessibilityUIElement::addNotificationListener
3196         from 119883 and 120421.
3197
3198         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3199         (axObjectEventListener):
3200         (addAccessibilityNotificationHandler):
3201         (removeAccessibilityNotificationHandler):
3202         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3203         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3204         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3205
3206 2013-09-20  Mark Rowe  <mrowe@apple.com>
3207
3208         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
3209
3210         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
3211
3212         Reviewed by David Kilzer.
3213
3214         * Scripts/webkitdirs.pm:
3215         (checkRequiredSystemConfig):
3216
3217 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3218
3219         [ATK] Do not expose aria-help in ATK based platforms
3220         https://bugs.webkit.org/show_bug.cgi?id=121675
3221
3222         Reviewed by Chris Fleizach.
3223
3224         Remove the implementations for AccessibilityUIElement::helpText()
3225         from DRT and WKTR for GTK and EFL, since they are based on the
3226         AccessibilityObject::helpText() method and the 'aria-help'
3227         attributes, which is wrong since they should not depend on that
3228         but in ATK specific API (see also http://webkit.org/b/121684).
3229
3230         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3231         (AccessibilityUIElement::helpText): Added a new and empty
3232         implementation, now that we are no longer using this in ATK.
3233         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
3234         as the only function provided here was helpText().
3235         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
3236         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
3237         removed from the list of sources to compile.
3238         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
3239         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3240         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
3241         based in DumpRenderTreeSupportGtk with an empty one.
3242
3243 2013-09-20  Dan Bernstein  <mitz@apple.com>
3244
3245         Make extract-localizable-strings available to WebCore clients
3246         https://bugs.webkit.org/show_bug.cgi?id=121699
3247
3248         Reviewed by Darin Adler.
3249
3250         * Scripts/extract-localizable-strings: Copied to
3251         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
3252         executes the script from its new location. This is a temporary measure until certain code
3253         that is external to WebKit is adapted to the new location.
3254         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
3255         from its new location.
3256
3257 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
3258
3259         Nuke remaining VS2005 tools from the tree.
3260         https://bugs.webkit.org/show_bug.cgi?id=121691
3261
3262         Reviewed by Brent Fulgham.
3263
3264         * CLWrapper/CLWrapper.cpp: Removed.
3265         * CLWrapper/CLWrapper.sln: Removed.
3266         * CLWrapper/CLWrapper.vcproj: Removed.
3267         * MIDLWrapper/MIDLWrapper.cpp: Removed.
3268         * MIDLWrapper/MIDLWrapper.sln: Removed.
3269         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
3270         * Scripts/parallelcl: Removed.
3271         * vcbin/cl.exe: Removed.
3272         * vcbin/midl.exe: Removed.
3273
3274 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3275
3276         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
3277         https://bugs.webkit.org/show_bug.cgi?id=121294
3278
3279         Reviewed by Martin Robinson.
3280
3281         Provide a new patch to deal with the issue in the GTK+ module from
3282         the internal jhbuild environment. This issue has been reported
3283         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
3284
3285         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
3286         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
3287
3288 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3289
3290         [ATK][WTR] accessibility/aria-invalid.html times out
3291         https://bugs.webkit.org/show_bug.cgi?id=121668
3292
3293         Reviewed by Mario Sanchez Prada.
3294
3295         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
3296         false in case of aria-invalid event with empty value.
3297
3298         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3299         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
3300         case of aria-invalid event with empty value.
3301
3302 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3303
3304         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
3305         https://bugs.webkit.org/show_bug.cgi?id=120421
3306
3307         Reviewed by Mario Sanchez Prada.
3308
3309         Implemented the notification listener for AccessibilityUIElement for
3310         WebKitTestRunner. The signal is generated by
3311         AXObjectCache::postPlatformNotification() and received by
3312         axObjectEventListener(). axObjectEventListener() will then invoke
3313         JSObjectCallAsFunction() with the respective callback function. The
3314         notification handlers are stored in HashMap in
3315         AccessibilityNotificationHandlerAtk.cpp.
3316
3317         Moved ATK signal handling (printAccessibilityEvent and
3318         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
3319
3320         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
3321         include path.
3322         * WebKitTestRunner/GNUmakefile.am:
3323         Added AccessibilityNotificationHandlerAtk.cpp/h.
3324         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
3325         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3326         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
3327         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3328         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
3329         notification handler for GTK+ and EFL.
3330         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3331         Moved printAccessibilityEvent and axObjectEventListener to
3332         AccessibilityNotificationHandlerAtk.cpp.
3333         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
3334         IDs to AccessibilityNotificationHandlerAtk.cpp.
3335         (WTR::AccessibilityController::resetToConsistentState): Moved listener
3336         IDs to AccessibilityNotificationHandlerAtk.cpp.
3337         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
3338         (WTR::printAccessibilityEvent): Prints accessibility events. This
3339         function was moved from AccessibilityControllerAtk.cpp.
3340         (WTR::axObjectEventListener): Callback for signals. This function was
3341         moved from AccessibilityControllerAtk.cpp.
3342         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
3343         Initialize element and function callback.
3344         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
3345         Removes handler from HashMap and disconnects callbacks if necessary.
3346         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
3347         logging mode and connects callbacks.
3348         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3349         Sets the notification callback and connects callback to signals.
3350         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3351         Removes the notification callback from HashMap.
3352         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3353         Connects axObjectEventListener to ATK signals.
3354         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
3355         Disconnects callback.
3356         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
3357         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
3358         of AccessibilityNotificationHandler.
3359         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
3360         element.
3361         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
3362         element.
3363         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
3364         Gets the notification callback.
3365         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3366         (WTR::AccessibilityUIElement::addNotificationListener): Creates
3367         notification handler, set the platform element and the notification
3368         callback.
3369         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
3370         notification handler.
3371         * WebKitTestRunner/PlatformEfl.cmake:
3372         Added AccessibilityNotificationHandlerAtk.cpp.
3373
3374 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3375
3376         Update features.pri
3377         https://bugs.webkit.org/show_bug.cgi?id=121670
3378
3379         Reviewed by Jocelyn Turcotte.
3380
3381         Remove feature flags that no longer exists and new ones added to FeatureList.pm
3382
3383         * qmake/mkspecs/features/features.pri:
3384
3385 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
3386
3387         [GTK][WK2] accessibility/selection-states.html is failing
3388         https://bugs.webkit.org/show_bug.cgi?id=116972
3389
3390         Reviewed by Mario Sanchez Prada.
3391
3392         isSelectable() was not exposed in Accessibility.
3393
3394         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3395
3396 2013-09-19  Dan Bernstein  <mitz@apple.com>
3397
3398         Attempted build fix after r156114.
3399
3400         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
3401
3402 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
3403
3404         REGRESSION (r129451): run-safari --no-saved-state is broken
3405         https://bugs.webkit.org/show_bug.cgi?id=121566
3406
3407         Undo a last minute change that doesn't actually work.
3408
3409         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
3410         via command line, <rdar://problem/15032886>.
3411
3412 2013-09-19  Dan Bernstein  <mitz@apple.com>
3413
3414         Add a style guideline regarding spacing in range-based for loops
3415         https://bugs.webkit.org/show_bug.cgi?id=121620
3416
3417         Reviewed by Anders Carlsson.
3418
3419         * Scripts/webkitpy/style/checkers/cpp.py:
3420         (check_spacing): Added checking that there are spaces around the colon in a range-based for
3421         loop.
3422         (CppChecker): Added whitespace/colon to the categories set.
3423         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3424         (WebKitStyleTest.test_spacing): Added two tests for the new check.
3425
3426 2013-09-18  Sam Weinig  <sam@webkit.org>
3427
3428         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
3429         https://bugs.webkit.org/show_bug.cgi?id=121588
3430
3431         Reviewed by Anders Carlsson.
3432
3433         * DumpRenderTree/TestRunner.cpp:
3434         * ImageDiff/efl/ImageDiff.cpp:
3435         * TestWebKitAPI/JavaScriptTest.cpp:
3436         * TestWebKitAPI/PlatformUtilities.cpp:
3437         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3438         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3439         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3440         * WebKitTestRunner/StringFunctions.h:
3441         * WebKitTestRunner/TestInvocation.cpp:
3442         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3443         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3444
3445 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
3446
3447         W3C Test Import script reformats test HTML
3448         https://bugs.webkit.org/show_bug.cgi?id=119159
3449
3450         Reviewed by Dirk Pranke.
3451
3452         Completely rewrite the test conversion process to minimize
3453         reformatting when adding prefixes, etc. This isn't 100% perfect, there
3454         are still places where it will end up changing the formatting, but it
3455         is much better than before. Most notably, the public interface to the
3456         test converter has changed: now one calls a method instead of creating
3457         an instance of the test converter class. This is because the test
3458         converter class now has state, so one really needs a new instance for
3459         each test.
3460
3461         Note that this also lays some simple groundwork for being able to use
3462         a MockHost in the tests.
3463
3464         * Scripts/webkitpy/w3c/test_converter.py:
3465         (convert_for_webkit):
3466         (_W3CTestConverter):
3467         (_W3CTestConverter.__init__):
3468         (_W3CTestConverter.output):
3469         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3470         (_W3CTestConverter.convert_style_data):
3471         (_W3CTestConverter.convert_attributes_if_needed):
3472         (_W3CTestConverter.handle_starttag):
3473         (_W3CTestConverter.handle_endtag):
3474         (_W3CTestConverter.handle_startendtag):
3475         (_W3CTestConverter.handle_data):
3476         (_W3CTestConverter.handle_entityref):
3477         (_W3CTestConverter.handle_charref):
3478         (_W3CTestConverter.handle_comment):
3479         (_W3CTestConverter.handle_decl):
3480         (_W3CTestConverter.handle_pi):
3481         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3482         (W3CTestConverterTest):
3483         (W3CTestConverterTest.fake_dir_path):
3484         (W3CTestConverterTest.test_read_prefixed_property_list):
3485         (verify_no_conversion_happened):
3486         * Scripts/webkitpy/w3c/test_importer.py:
3487         (TestImporter.import_tests):
3488
3489 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3490
3491         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
3492         https://bugs.webkit.org/show_bug.cgi?id=121578
3493
3494         Rubber stamped by Geoffrey Garen.
3495
3496         * Scripts/run-layout-jsc:
3497
3498 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3499
3500         Unreviewed, fix for Ruby 1.8.
3501
3502         * Scripts/run-jsc-stress-tests:
3503
3504 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3505
3506         run-jsc-stress-tests should make it easier to look at error spew from tests
3507         https://bugs.webkit.org/show_bug.cgi?id=121531
3508
3509         Reviewed by Mark Hahnenberg.
3510         
3511         This makes two changes:
3512         
3513         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
3514         
3515         - The same spew also goes to the console but is prefixed by the test's name.
3516         
3517         This required some tee and awk hacks, and then some sh hacks to work around the fact
3518         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
3519         operator will only see a failure of bar failed. So to pass output to tee and awk, I
3520         needed to do weird things.
3521
3522         * Scripts/run-jsc-stress-tests:
3523
3524 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
3525
3526         REGRESSION (r129451): run-safari --no-saved-state is broken
3527         https://bugs.webkit.org/show_bug.cgi?id=121566
3528
3529         Reviewed by Mark Rowe.
3530
3531         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
3532         Check arguments, not the newly created empty array. Pass a value that silences warnings.
3533         While at it, removed a check for Snow Leopard.
3534
3535 2013-09-18  Alex Christensen  <achristensen@webkit.org>
3536
3537         Improved WinLauncher's URL handling.
3538         https://bugs.webkit.org/show_bug.cgi?id=121535
3539
3540         Reviewed by Brent Fulgham.
3541
3542         * WinLauncher/WinLauncher.cpp:
3543         (EditProc):
3544         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
3545         (loadURL):
3546         Prepend "http://" to URLs with no scheme.
3547
3548 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3549
3550         DFG should support Int52 for local variables
3551         https://bugs.webkit.org/show_bug.cgi?id=121064
3552
3553         Reviewed by Oliver Hunt.
3554
3555         * Scripts/run-jsc-stress-tests:
3556
3557 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
3558
3559         [Win] TestWebKitAPI does not compile.
3560         https://bugs.webkit.org/show_bug.cgi?id=121485
3561
3562         Reviewed by Brent Fulgham.
3563
3564         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
3565         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
3566         to return null, which is the case we want to test.
3567
3568         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3569         (TestWebKitAPI::TEST):
3570
3571 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
3572
3573         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
3574         https://bugs.webkit.org/show_bug.cgi?id=121495
3575
3576         Reviewed by Chris Fleizach.
3577
3578         Adapted DRT and WKTR to deal with the new names for the ATK object
3579         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
3580
3581         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3582         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
3583         (AccessibilityUIElement::stringAttributeValue): Ditto.
3584         (AccessibilityUIElement::hasPopup): Ditto.
3585         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3586         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
3587         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
3588         (WTR::AccessibilityUIElement::hasPopup): Ditto.
3589
3590 2013-09-18  Commit Queue  <commit-queue@webkit.org>
3591
3592         Unreviewed, rolling out r156019 and r156020.
3593         http://trac.webkit.org/changeset/156019
3594         http://trac.webkit.org/changeset/156020
3595         https://bugs.webkit.org/show_bug.cgi?id=121540
3596
3597         Broke tests (Requested by ap on #webkit).
3598
3599         * Scripts/run-jsc-stress-tests:
3600
3601 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
3602
3603         Unreviewed. Add myself as a committer.
3604
3605         * Scripts/webkitpy/common/config/contributors.json:
3606
3607 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
3608
3609         Unreviewed. Add myself as a committer.
3610
3611         * Scripts/webkitpy/common/config/contributors.json:
3612
3613 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3614
3615         DFG should support Int52 for local variables
3616         https://bugs.webkit.org/show_bug.cgi?id=121064
3617
3618         Reviewed by Oliver Hunt.
3619
3620         * Scripts/run-jsc-stress-tests:
3621
3622 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
3623
3624         Added back and forward buttons to WinLauncher.
3625         https://bugs.webkit.org/show_bug.cgi?id=121212
3626
3627         Reviewed by Brent Fulgham.
3628
3629         * WinLauncher/WinLauncher.cpp:
3630         (resizeSubViews):
3631         Move new back and forward buttons to correct positions before URL bar.
3632         (dllLauncherEntryPoint): 
3633         Store the default button window procedure and replace with my button procedures.
3634         (EditProc): Updated style and renamed from MyEditProc.
3635         (BackButtonProc): Added.
3636         (ForwardButtonProc): Added.
3637
3638 2013-09-17  Michael Saboff  <msaboff@apple.com>
3639
3640         Unreviewed typo fix after r155999
3641