1 2011-12-22 David Kilzer <ddkilzer@apple.com>
3 TestWebKitAPI: initialize the main thread before running tests
4 <http://webkit.org/b/75064>
6 Reviewed by Adam Roben.
8 * TestWebKitAPI/TestsController.cpp:
9 (TestWebKitAPI::TestsController::TestsController): Call
10 WTF::initializeMainThread() to prevent assertions in Debug
13 2011-12-22 David Kilzer <ddkilzer@apple.com>
15 run-api-tests: dumpAllTests() should not use global variables
17 Reviewed by Adam Roben.
19 Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
21 * Scripts/run-api-tests: Renamed $dump to $dumpTests.
22 (dumpTestsBySuite): Rename from dumpAllTests() and pass in
23 global data as an argument. Sort suite names and test names
24 alphabetically to match output when running tests.
26 2011-12-22 Leo Yang <leo.yang@torchmobile.com.cn>
28 [BlackBerry] Enable blob for the BlackBerry porting
29 https://bugs.webkit.org/show_bug.cgi?id=75074
31 Reviewed by George Staikos.
33 * Scripts/build-webkit:
35 2011-12-22 Kentaro Hara <haraken@chromium.org>
37 Add unittests for the Perl parser of prepare-ChangeLog
38 https://bugs.webkit.org/show_bug.cgi?id=74994
40 Reviewed by David Kilzer.
42 This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
44 Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
46 * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
47 Runs unittests specified in @testFiles.
48 You can reset expected results by specifying a --reset-results option.
49 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
50 Contains simple methods.
57 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
58 This test result is generated by the --reset-results option.
60 2011-12-21 Eric Seidel <eric@webkit.org>
62 Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
63 so that they appear in the bugzilla autocomplete CC list.
64 I also removed the "radar" irc nick (which I believe does not exist)
65 and removed the uneeded [] around the radar bugzilla email.
69 * Scripts/webkitpy/common/config/committers.py:
71 2011-12-21 Daniel Bates <dbates@rim.com>
73 Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
74 https://bugs.webkit.org/show_bug.cgi?id=74985
76 Reviewed by Eric Seidel.
79 * Scripts/webkitdirs.pm:
80 (cmakeBasedPortName): Added.
82 2011-12-21 Daniel Bates <dbates@rim.com>
84 Extract BlackBerry CMake arguments from build-webkit into separate function
85 https://bugs.webkit.org/show_bug.cgi?id=74981
89 Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
90 the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
91 and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
92 This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
93 that we can pass them to the CMake build system when building JavaScriptCore.
95 * Scripts/build-webkit: Move construction of CMake argument list from here to
96 webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
97 since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
98 call it from build-webkit.
99 * Scripts/webkitdirs.pm:
100 (blackberryCMakeArguments): Added.
101 (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
104 2011-12-21 Daniel Bates <dbates@webkit.org>
106 Extract WinCE CMake arguments from build-webkit into separate function
107 https://bugs.webkit.org/show_bug.cgi?id=74983
109 Reviewed by Rob Buis.
111 Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
112 WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
113 This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
114 that we can pass it to the CMake build system when building JavaScriptCore.
116 * Scripts/build-webkit:
117 * Scripts/webkitdirs.pm:
118 (cmakeBasedPortArguments): Added.
120 2011-12-21 Kentaro Hara <haraken@chromium.org>
122 In prepare-ChangeLog, replace constant global variables with "use constant"
123 https://bugs.webkit.org/show_bug.cgi?id=74992
125 Reviewed by Ryosuke Niwa.
127 This patch replaces the following constant global variables with "use constant"s.
131 - %supportedTestExtensions
133 * Scripts/prepare-ChangeLog:
134 (changeLogNameFromArgs):
135 (changeLogEmailAddressFromArgs):
136 (resolveConflictedChangeLogs):
137 (generateNewChangeLogs):
140 (createPatchCommand):
141 (findOriginalFileFromSvn):
142 (determinePropertyChanges):
144 (reviewerAndDescriptionForGitCommit):
146 2011-12-20 Dirk Pranke <dpranke@chromium.org>
148 nrwt: rename field references from _fs to _filesystem
149 https://bugs.webkit.org/show_bug.cgi?id=74898
151 Reviewed by Adam Barth.
153 This is a simple cleanup; most of the code uses
154 self._filesystem, but some used self._fs; this change renames
155 the latter to the former to be more consistent.
157 * Scripts/webkitpy/layout_tests/controllers/manager.py:
159 (Manager.collect_tests):
160 (Manager._strip_test_dir_prefix):
161 (Manager._split_into_chunks_if_necessary):
162 (Manager.results_directory):
163 (Manager._clobber_old_results):
164 (Manager._upload_json_files):
165 (Manager.print_config):
166 (Manager._copy_results_html_file):
167 (Manager._show_results_html_file):
168 (Manager._log_worker_stack):
169 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
170 (JSONLayoutResultsGenerator._normalize_results_json):
171 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
172 (JSONResultsGeneratorBase.__init__):
173 (JSONResultsGeneratorBase.generate_json_output):
174 (JSONResultsGeneratorBase.generate_times_ms_file):
175 (JSONResultsGeneratorBase.upload_json_files):
176 (JSONResultsGeneratorBase._get_svn_revision):
177 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
180 2011-12-20 Kentaro Hara <haraken@chromium.org>
182 Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
183 https://bugs.webkit.org/show_bug.cgi?id=74836
185 Reviewed by David Kilzer.
187 webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
188 This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
189 for unit-testing of other Perl scripts. We are planning to use it for unit-testing
190 of prepare-ChangeLog.
192 Using LoadAsModule.pm, you can load a Perl script as follows.
193 The first argument is the arbitrary package name you want to use, and the second argument
194 is the name of the Perl script you want to load.
196 use LoadAsModule qw(RunLeaks run-leaks);
197 RunLeaks::someFunctionDefinedInRunLeaks(...);
199 Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
200 Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
201 Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
203 * Scripts/webkitperl/LoadAsModule.pm: Added.
204 * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
207 * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
208 * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
209 * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
211 2011-12-20 Balazs Kelemen <kbalazs@webkit.org>
213 [Qt] WK2 Debugging quirks need some improvement
214 https://bugs.webkit.org/show_bug.cgi?id=74859
216 Reviewed by Simon Hausmann.
218 Improvements added to make debugging WebKit2 more
219 confortable and efficient:
220 1. Unify debugging quirks. From now all of them are controlled
221 by the QT_WEBKIT2_DEBUG environment variable.
222 2. Disable crash handlers for WebKitTestRunner if debugging quirks
223 are used to make it possible to use postmortem debugging via core dumps
224 which is extremely useful for debugging bugs triggered by layout tests.
225 3. Disable test timeout for WebKitTestRunner if debugging quirks
226 are used because that makes debugging impossible.
228 * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
229 (WTR::InjectedBundle::platformInitialize):
230 * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
231 (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
232 * WebKitTestRunner/qt/TestControllerQt.cpp:
233 (WTR::TestController::platformRunUntil):
235 2011-12-20 Rafael Brandao <rafael.lobo@openbossa.org>
237 [Qt][WK2] Implement favicon support
238 https://bugs.webkit.org/show_bug.cgi?id=71082
240 Reviewed by Simon Hausmann.
242 A favorite icon was added on MiniBrowser's url bar as example.
243 We display a default icon when the page doesn't have an icon ready.
245 * MiniBrowser/qt/MiniBrowser.qrc:
246 * MiniBrowser/qt/icons/favicon.png: Added.
247 * MiniBrowser/qt/qml/BrowserWindow.qml:
249 2011-12-19 Sam Weinig <sam@webkit.org>
251 Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
252 https://bugs.webkit.org/show_bug.cgi?id=74907
254 Reviewed by Dan Bernstein.
256 Add ScrollByLineCommands API test.
258 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
259 * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
260 * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
262 2011-12-19 Dirk Pranke <dpranke@chromium.org>
264 webkitpy: remove port.executive, port.filesystem, port.user properties
265 https://bugs.webkit.org/show_bug.cgi?id=74896
267 Reviewed by Eric Seidel.
269 Following on the refactoring of the port and host objects, this
270 removes the public executive, filesystem, and user properties
271 from the Port interface (protected versions of executive and
272 filesystem still exist). There is still some more clean up to
273 make the code more consistent and rearrange some other files to
274 talk to Hosts directly instead of getting them off of the Port
277 * Scripts/webkitpy/layout_tests/controllers/manager.py:
279 (Manager.results_directory):
280 (Manager._log_worker_stack):
281 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
282 (ManagerTest.test_fallback_path_in_config):
283 * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
284 (_InlineManager.start_worker):
285 (_InlineWorkerConnection.__init__):
286 * Scripts/webkitpy/layout_tests/controllers/worker.py:
288 * Scripts/webkitpy/layout_tests/models/test_configuration.py:
289 (TestConfiguration.from_port):
290 * Scripts/webkitpy/layout_tests/port/base.py:
293 (Port.show_results_html_file):
294 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
295 (PortTest.test_layout_tests_skipping):
296 (PortTest.test_test_dirs):
297 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
298 (_set_up_derived_options):
299 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
300 (PerfTestsRunner.__init__):
301 * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
302 (HtmlGenerator.__init__):
303 (HtmlGenerator.show_html):
305 * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
306 (TestHtmlGenerator.make_generator):
308 2011-12-19 Daniel Bates <dbates@webkit.org>
310 Pass command line arguments to GDB when debugging a Mac WebKit application
311 https://bugs.webkit.org/show_bug.cgi?id=72829
313 Reviewed by David Kilzer.
315 Pass through any command line arguments given to debug-{safari, minibrowser}
316 to GDB so that they may influence the application instance launched by GDB.
318 * Scripts/webkitdirs.pm:
319 (execMacWebKitAppForDebugging):
321 2011-12-19 Dirk Pranke <dpranke@chromium.org>
323 webkitpy: remove executive,filesystem,user parameters from Port constructor
324 https://bugs.webkit.org/show_bug.cgi?id=74878
326 Reviewed by Eric Seidel.
328 This change concludes the refactoring that makes Host a required
329 parameter for Port and ensures that all access to filesystem,
330 executives, etc. is going through the Host.
332 * Scripts/webkitpy/layout_tests/port/base.py:
335 2011-12-19 Dirk Pranke <dpranke@chromium.org>
337 webkitpy: finish refactoring port classes to make a host mandatory
338 https://bugs.webkit.org/show_bug.cgi?id=74566
340 Reviewed by Eric Seidel.
342 This change makes all Port objects take a required (System)Host
343 parameter, and updates the TestPort object to no longer create a
344 mock filesystem or add files to the existing filesystem by
347 * Scripts/webkitpy/layout_tests/port/base.py:
349 * Scripts/webkitpy/layout_tests/port/factory.py:
350 (PortFactory.__init__):
351 (PortFactory._get_kwargs):
352 * Scripts/webkitpy/layout_tests/port/test.py:
353 (TestInstance.__init__):
355 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
359 (MainTest.test_single_file):
360 (MainTest.test_stderr_is_saved):
361 (MainTest.test_test_list):
362 (MainTest.test_test_list_with_prefix):
363 (MainTest.test_missing_and_unexpected_results):
364 (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
365 (MainTest.test_crash_with_stderr):
366 (MainTest.test_no_image_failure_with_image_diff):
367 (MainTest.test_crash_log):
368 (MainTest.test_web_process_crash_log):
369 (MainTest.test_exit_after_n_failures_upload):
370 (MainTest.test_results_directory_absolute):
371 (MainTest.test_results_directory_relative):
372 (MainTest.test_retries_directory):
373 (MainTest.test_tolerance.get_port_for_run):
374 (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
375 (EndToEndTest.test_end_to_end):
376 (EndToEndTest.test_reftest_with_two_notrefs):
377 (RebaselineTest.test_reset_results):
378 (RebaselineTest.test_missing_results):
379 (RebaselineTest.test_new_baseline):
380 * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
381 (Rebaseliner.__init__):
384 * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
385 (test_host_port_and_filesystem):
386 (TestRebaseliner.make_rebaseliner):
387 (TestRealMain.test_all_platforms):
388 (TestHtmlGenerator.make_generator):
390 2011-12-19 Dirk Pranke <dpranke@chromium.org>
392 webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
393 https://bugs.webkit.org/show_bug.cgi?id=74562
395 Reviewed by Eric Seidel.
397 Apart from a minor change to style/checkers/test_expectations.py
398 to take a host as a parameter to a TestExpectationsChecker(),
399 there are only refactoring changes to unit tests here.
401 * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
402 (TestResultWriterTest.test_reftest_diff_image):
403 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
404 (JSONGeneratorTest._test_json_generation):
405 (JSONGeneratorTest.test_test_timings_trie):
406 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
408 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
409 (PortTest.make_port):
410 (PortTest.test_layout_tests_skipping):
411 (PortTest.test_test_dirs):
412 (PortTest.test_additional_platform_directory):
413 (PortTest.test_uses_test_expectations_file):
414 (PortTest.test_find_no_paths_specified):
415 (PortTest.test_find_one_test):
416 (PortTest.test_find_glob):
417 (PortTest.test_find_with_skipped_directories):
418 (PortTest.test_find_with_skipped_directories_2):
419 (PortTest.test_parse_reftest_list):
420 * Scripts/webkitpy/layout_tests/port/dryrun.py:
421 (DryRunPort.__init__):
422 * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
424 (FactoryTest.tearDown):
425 (FactoryTest.assert_port):
426 (FactoryTest.assert_platform_port):
427 (FactoryTest.test_unknown_specified):
428 (FactoryTest.test_unknown_default):
429 * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
430 (GetGoogleChromePortTest._verify_expectations_overrides):
431 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
432 (MockDRTPortTest.make_port):
433 (MockDRTTest.assertTest):
434 (MockDRTTest.test_main):
435 (MockChromiumDRTTest.test_pixeltest__fails):
436 * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
437 (QtPortTest._assert_search_path):
438 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
439 (TestWebKitPort.__init__):
440 (WebKitPortTest.test_skipped_directories_for_symbols):
441 (test_skipped_directories_for_features):
442 (test_skipped_layout_tests):
443 (test_skipped_file_search_paths):
445 (test_test_expectations):
447 (test_linux_distro_detection):
448 (test_apache_config_file_name_for_platform):
449 (test_path_to_apache_config_file):
450 (WebKitDriverTest.test_read_block):
451 * Scripts/webkitpy/style/checkers/test_expectations.py:
452 (TestExpectationsChecker.__init__):
453 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
454 (TestExpectationsTestCase._expect_port_for_expectations_path):
455 (TestExpectationsTestCase.assert_lines_lint):
456 * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
457 (get_test_config.TestMacPort):
459 2011-12-19 Raphael Kubo da Costa <kubo@profusion.mobi>
461 [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
462 https://bugs.webkit.org/show_bug.cgi?id=74854
464 Reviewed by Csaba Osztrogonác.
466 Since r101052, libewebkit.so is built in a different location, so we
467 need to adjust the path returned by builtDylibPathForName.
469 usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
470 port also respects Release/Debug configurations.
472 These changes should make run-launcher finally work correctly with
475 * Scripts/webkitdirs.pm:
476 (usesPerConfigurationBuildDirectory):
477 (builtDylibPathForName):
479 2011-12-19 Simon Hausmann <simon.hausmann@nokia.com>
481 [Qt][WK2] Add support for modal event loop processing for WTR
482 https://bugs.webkit.org/show_bug.cgi?id=74852
484 Reviewed by Kenneth Rohde Christiansen.
486 Rewrote event loop processing: Instead of terminating the event loop
487 in notifyDone() - something no other platform does - we now respect the
488 "bool& condition" parameter passed to platformRunUntil. This ensures
489 proper termination even when the condition is changed from within a
490 nested event loop, because only when we _exit_ from the nested event
491 loop we will check the condition and terminate the test properly.
493 In addition this patch implements TestController::runModal by means of
494 a nested event loop, which is passed to the platform webview that is
495 supposed to be modal. It is that view's responsibility to exit the
496 loop, upon destruction. I believe that's similar to how it works on the Mac,
497 where it doesn't seem that NSApp's runModalForWindow is terminate via
498 abort/stopModal but simply because the window is closed.
500 * WebKitTestRunner/PlatformWebView.h:
501 (WTR::PlatformWebView::setModalEventLoop):
502 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
503 (WTR::PlatformWebView::PlatformWebView):
504 (WTR::PlatformWebView::~PlatformWebView):
505 * WebKitTestRunner/qt/TestControllerQt.cpp:
506 (WTR::TestController::notifyDone):
507 (WTR::TestController::platformRunUntil):
508 (WTR::TestController::runModal):
510 2011-12-18 Kentaro Hara <haraken@chromium.org>
512 REGRESSION(r103149): prepare-ChangeLog outputs a warning
513 https://bugs.webkit.org/show_bug.cgi?id=74808
515 Reviewed by David Kilzer.
517 Added the prototype declaration of main() to avoid warning messages.
518 Sorted subroutine declarations in the alphabetical order.
520 * Scripts/prepare-ChangeLog:
522 2011-12-17 Adenilson Cavalcanti <cavalcantii@gmail.com>
524 [Qt] Fix QtTestBrowser compilation with QtWidgets module
525 https://bugs.webkit.org/show_bug.cgi?id=74791
527 Reviewed by Andreas Kling.
529 * QtTestBrowser/QtTestBrowser.pro:
531 2011-12-17 Kentaro Hara <haraken@chromium.org>
533 Remove top-level code completely from prepare-ChangeLog
534 https://bugs.webkit.org/show_bug.cgi?id=74698
536 Reviewed by Darin Adler.
538 We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
539 This patch just moves all top-level code into main().
541 * Scripts/prepare-ChangeLog:
544 2011-12-16 Dean Jackson <dino@apple.com>
546 Move webkit-bug-importer to Contributor. It won't
547 autocomplete as an Account.
548 See https://bugs.webkit.org/show_bug.cgi?id=74739
553 * Scripts/webkitpy/common/config/committers.py:
555 2011-12-16 Dean Jackson <dino@apple.com>
557 Add webkit-bug-importer@group.apple.com to accounts
558 so that it autocompletes in bugzilla.
562 * Scripts/webkitpy/common/config/committers.py:
564 2011-12-16 Philippe Normand <pnormand@igalia.com>
566 Unreviewed, skipping 3 failing GTK API tests.
568 * Scripts/run-gtk-tests:
570 2011-12-16 Philippe Normand <pnormand@igalia.com>
572 Unreviewed, GTK API tests build fix attempt.
574 * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
576 2011-12-16 Philippe Normand <pnormand@igalia.com>
578 Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
580 * Scripts/run-gtk-tests:
582 2011-12-16 Simon Hausmann <simon.hausmann@nokia.com>
584 [Qt] Fix the build for newer Qt5
585 https://bugs.webkit.org/show_bug.cgi?id=74703
587 Reviewed by Csaba Osztrogonác.
589 * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
590 * DumpRenderTree/qt/EventSenderQt.cpp:
591 (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
592 * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
593 (WTR::EventSenderProxy::sendTouchEvent):
594 * MiniBrowser/qt/MiniBrowserApplication.cpp:
595 (MiniBrowserApplication::sendTouchEvent): Ditto.
596 (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
598 2011-12-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
600 [Qt] Detect and force clean build when feature defines are added
604 https://bugs.webkit.org/show_bug.cgi?id=74689
606 * Scripts/webkitdirs.pm:
608 2011-12-16 Kentaro Hara <haraken@chromium.org>
610 [Refactoring] Remove all global variables from prepare-ChangeLog
611 https://bugs.webkit.org/show_bug.cgi?id=74681
613 Reviewed by Ryosuke Niwa.
615 We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
616 manner. This bug is one of the incremental refactorings to remove all top-level
617 code and global variables from prepare-ChangeLog. In this patch,
618 we make the following global variables be used only through parameter passing.
619 This patch removes all global variables from prepare-ChangeLog.
624 * Scripts/prepare-ChangeLog:
625 (generateFunctionLists):
626 (changeLogNameFromArgs):
627 (changeLogEmailAddressFromArgs):
628 (generateNewChangeLogs):
633 (createPatchCommand):
637 2011-12-15 Philippe Normand <pnormand@igalia.com>
639 [GTK] Rounding errors on 32-bit machines causes tests to fail
640 https://bugs.webkit.org/show_bug.cgi?id=72254
642 Initial patch by vanuan@gmail.com.
643 Reviewed by Martin Robinson.
645 * Scripts/webkitdirs.pm:
646 (runAutogenForAutotoolsProjectIfNecessary): Pass additional
647 CXXFLAGS to autogen in an attempt to harmonize floating point
648 values between 32-bit and 64-bit architectures.
650 2011-12-16 Martin Robinson <mrobinson@igalia.com>
652 [GTK] Make distcheck fails during the install
653 https://bugs.webkit.org/show_bug.cgi?id=74274
655 No review, since this is a build fix.
657 * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
658 step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
659 always runs. This means that the gtkdoc step was always running when make was
660 invoked. Generating gtkdoc during 'make install' was triggering a race condition
661 with the library file. Later we can fix generate-forwarding-headers and unbreak
662 'make docs,' but this bandaid is sufficient to let us release.
664 2011-12-15 Eric Seidel <eric@webkit.org>
666 NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
667 https://bugs.webkit.org/show_bug.cgi?id=74650
669 Reviewed by Adam Barth.
671 * Scripts/webkitpy/common/system/platforminfo.py:
672 (PlatformInfo._compute_bytes_from_vm_stat_output):
673 * Scripts/webkitpy/layout_tests/port/base.py:
674 (Port.default_child_processes):
675 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
676 (PortTest.test_default_child_processes):
678 2011-12-15 Filip Pizlo <fpizlo@apple.com>
680 bencher script should support remote benchmarking on platforms that don't have ruby
681 https://bugs.webkit.org/show_bug.cgi?id=74659
683 Rubber-stamped by Sam Weinig.
685 Added the ability to have bencher generate a benchmarking playload that consists of
686 copies of all of the benchmarks, optionally copies of all of the frameworks and
687 binaries to run all of the VMs, and a sh script that runs the benchmarks in random
688 order, which then spits out a raw results file that bencher can parse.
690 In normal operating mode, you never see this, as it just generates the payload and
691 script internally, runs it, parses the results, and spits them out.
693 The --remote mode has been changed to use this style, so any remote host that has
694 sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
695 a sh-compatible shell can be used for remote benchmarking.
697 The feature to include VMs in the benchmarking payload is by default only activated
698 when using --remote, but it can also be activated when doing local benchmarking; the
699 benefit is that you remove any pathname-related performance pathologies. All VMs
700 become equal because they are all located in
701 /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
704 Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
705 through DumpRenderTree. This is only a bit slower than running in jsc.
709 2011-12-15 Dirk Pranke <dpranke@chromium.org>
711 webkitpy: clean up TestPort to (mostly) not create a new filesystem
712 https://bugs.webkit.org/show_bug.cgi?id=74556
714 This change modifies the TestPort to be ready to add tests to an
715 existing filesystem instead of creating a new filesystem; we
716 leave unit_test_filesystem() in for now for compatibility.
718 * Scripts/webkitpy/common/host_mock.py:
720 - call add_unit_tests_to_mock_filesystem by default to make
721 the MockHost more generally useful for layout_test unit tests.
722 * Scripts/webkitpy/layout_tests/port/test.py:
723 (TestInstance.__init__):
724 (add_unit_tests_to_mock_filesystem):
726 (unit_test_filesystem):
728 (TestPort._set_default_overriding_none):
730 2011-12-15 Dirk Pranke <dpranke@chromium.org>
732 webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
733 https://bugs.webkit.org/show_bug.cgi?id=74551
735 This is some minor cleanup prior to making all of the host/port
736 changes described in bug 74138.
738 * Scripts/webkitpy/common/host_mock.py:
740 - make sure the scm object is initialized with the same mock
741 executive and filesystem objects.
743 * Scripts/webkitpy/common/system/filesystem_mock.py:
744 (MockFileSystem.clear_written_files):
745 - add a routine that will be useful in testing.
746 (MockFileSystem.maybe_make_directory):
747 (MockFileSystem.write_binary_file):
748 - fix bugs to make sure directories are created properly.
749 * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
751 - add clarifying comments.
752 * Scripts/webkitpy/layout_tests/port/mock_drt.py:
753 (MockDRTPort.__init__):
755 - add clarifying comments.
757 2011-12-15 Anders Carlsson <andersca@apple.com>
759 Regression (r102866): Navigating away from or closing a page with a plugin crashes
760 https://bugs.webkit.org/show_bug.cgi?id=74655
762 Reviewed by Sam Weinig.
764 Add a bunch of tests.
766 * TestWebKitAPI/Tests/WTF/Functional.cpp:
768 2011-12-15 Stephanie Lewis <slewis@apple.com>
770 https://bugs.webkit.org/show_bug.cgi?id=74469
771 Escape paths to svn commands so our tools can handle filenames with @ symbols.
773 Reviewed by Adam Roben.
775 * Scripts/VCSUtils.pm:
776 (scmMoveOrRenameFile):
777 (scmAddExecutableBit):
778 (scmRemoveExecutableBit):
780 (svnRevisionForDirectory):
781 (pathRelativeToSVNRepositoryRootForPath):
783 (escapeSubversionPath):
784 * Scripts/parse-malloc-history:
786 * Scripts/prepare-ChangeLog:
789 (findOriginalFileFromSvn):
790 (determinePropertyChanges):
791 * Scripts/resolve-ChangeLogs:
800 * Scripts/svn-create-patch:
803 (findSourceFileAndRevision):
806 (manufacturePatchForAdditionWithHistory):
807 * Scripts/svn-unapply:
811 2011-12-15 Michael Bruning <michael.bruning@nokia.com>
813 [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
814 https://bugs.webkit.org/show_bug.cgi?id=74617
816 Reviewed by Kenneth Rohde Christiansen.
818 * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
819 for viewport info button, adjusted height and added rounded corners.
821 2011-12-15 Andy Estes <aestes@apple.com>
823 TestFailures: store the name of the buildbot results directory in a property
824 https://bugs.webkit.org/show_bug.cgi?id=74663
826 Reviewed by Adam Barth.
828 Store the name of the results directory as a property on Buildbot's
829 prototype. This allows subclasses of Buildbot to customize the results
832 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
833 (Buildbot.prototype.resultsDirectoryURL):
835 2011-12-15 Tony Chang <tony@chromium.org>
837 [chromium] pass --delete_unversioned_trees to gclient on the bots
838 https://bugs.webkit.org/show_bug.cgi?id=74565
840 Reviewed by Kenneth Russell.
842 It was temporarily removed in r102891 to keep the bots green. Now
843 that the bots have cycled, we can add it back.
845 * Scripts/update-webkit-chromium:
847 2011-12-15 Kentaro Hara <haraken@chromium.org>
849 [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
850 https://bugs.webkit.org/show_bug.cgi?id=74497
852 Reviewed by Ryosuke Niwa.
854 We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
855 manner. This bug is one of the incremental refactorings to remove all top-level
856 code and global variables from prepare-ChangeLog. In this patch,
857 we make the following global variables be used only through parameter passing.
865 * Scripts/prepare-ChangeLog:
866 (fetchBugDescriptionFromURL):
867 (generateNewChangeLogs):
868 (reviewerAndDescriptionForGitCommit):
870 2011-12-15 Raphael Kubo da Costa <kubo@profusion.mobi>
872 [EFL] Add a few more web database functions to ewk_settings.
873 https://bugs.webkit.org/show_bug.cgi?id=72148
875 Reviewed by Antonio Gomes.
877 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
878 (LayoutTestController::clearAllDatabases):
879 (LayoutTestController::setDatabaseQuota):
881 2011-12-15 Martin Kosiba <mkosiba@google.com>
883 Fix find on web pages with -webkit-user-select: none for Chromium
884 https://bugs.webkit.org/show_bug.cgi?id=72281
886 Reviewed by Ryosuke Niwa.
888 Provided a partial findString implementation. This doesn't support
889 all of the FindOptions since they're not exposed via WebFindOptions.
891 * DumpRenderTree/chromium/LayoutTestController.cpp:
892 (LayoutTestController::LayoutTestController):
893 (LayoutTestController::findString):
894 * DumpRenderTree/chromium/LayoutTestController.h:
896 2011-12-15 Kenneth Russell <kbr@google.com>
898 [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
899 https://bugs.webkit.org/show_bug.cgi?id=74581
901 Reviewed by Darin Fisher.
903 * DumpRenderTree/chromium/LayoutTestController.cpp:
904 (LayoutTestController::overridePreference):
905 * DumpRenderTree/chromium/WebPreferences.cpp:
906 (WebPreferences::reset):
907 (WebPreferences::applyTo):
908 * DumpRenderTree/chromium/WebPreferences.h:
910 2011-12-15 Kenneth Rohde Christiansen <kenneth@webkit.org>
912 [Qt] Improve the look of the viewport info overlay
914 Reviewed by Tor Arne Vestbø.
916 * MiniBrowser/qt/qml/ViewportInfoItem.qml:
918 2011-12-15 Igor Oliveira <igor.oliveira@openbossa.org>
920 [Qt] Support requestAnimationFrame API
921 https://bugs.webkit.org/show_bug.cgi?id=74528
923 Add build-option for requestAnimationFrame feature.
925 Reviewed by Kenneth Rohde Christiansen.
927 * qmake/mkspecs/features/features.prf:
929 2011-12-15 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
931 [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
933 Reviewed by Simon Hausmann.
935 * qmake/mkspecs/features/webcore.prf:
937 2011-12-15 Michael Brüning <michael.bruning@nokia.com>
939 [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
940 https://bugs.webkit.org/show_bug.cgi?id=72893
942 Reviewed by Kenneth Rohde Christiansen.
944 This patch extends QQuickWebViewExperimental by a property named
945 viewportInfo, which contains the viewport scalability and
946 layout and contents size information. This property is exposed to
947 QML through the experimental extension for QQuickWebView.
949 * MiniBrowser/qt/MiniBrowser.pro:
950 * MiniBrowser/qt/MiniBrowser.qrc:
951 * MiniBrowser/qt/icons/info.png: Added.
952 * MiniBrowser/qt/qml/BrowserWindow.qml:
953 * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
955 2011-12-15 Shinya Kawanaka <shinyak@google.com>
957 [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
958 https://bugs.webkit.org/show_bug.cgi?id=74586
960 Reviewed by Hajime Morita.
962 No new tests. Covered by existing tests.
964 * DumpRenderTree/chromium/WebViewHost.cpp:
965 (WebViewHost::requestCheckingOfText):
966 Returns immediately if text is empty.
968 2011-12-15 Alexander Færøy <ahf@0x90.dk>
970 [Qt] QtWebKit fails to build on Mac OS X after r102776
971 https://bugs.webkit.org/show_bug.cgi?id=74593
973 Reviewed by Simon Hausmann.
975 CONFIG =+ link_pkgconfig is needed such that the correct parameters
976 are passed to the compiler.
978 * DumpRenderTree/qt/DumpRenderTree.pro:
980 2011-12-14 Tony Chang <tony@chromium.org>
982 [chromium] Remove redundant third_party entries from chromium DEPS
983 https://bugs.webkit.org/show_bug.cgi?id=74472
985 Reviewed by Kenneth Russell.
987 * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
989 2011-12-14 Kentaro Hara <haraken@chromium.org>
991 [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
992 VCSUtils::isGit() and VCSUtils::isSVN().
993 https://bugs.webkit.org/show_bug.cgi?id=74485
995 Reviewed by David Kilzer.
997 We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
998 manner. This bug is one of the incremental refactorings to remove all top-level
999 code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
1000 with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
1001 assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
1002 just by looking at the current working directory.
1004 * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
1008 (createPatchCommand):
1013 (statusDescription):
1016 2011-12-14 Sam Weinig <weinig@apple.com>
1018 Remove whitespace from InheritedPropertySheets attributes in
1019 vsprops files to appease the Visual Studio project migrator.
1021 Reviewed by Adam Roben.
1023 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
1024 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
1025 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
1026 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1027 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1028 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1029 * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
1030 * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
1031 * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
1032 * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1033 * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1034 * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1035 * DumpRenderTree/win/ImageDiffDebug.vsprops:
1036 * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
1037 * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
1038 * DumpRenderTree/win/ImageDiffProduction.vsprops:
1039 * DumpRenderTree/win/ImageDiffRelease.vsprops:
1040 * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1041 * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
1042 * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
1043 * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
1044 * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1045 * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1046 * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1047 * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1048 * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1049 * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
1050 * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
1051 * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
1052 * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1053 * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1054 * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1055 * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
1056 * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
1057 * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
1058 * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1059 * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1060 * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1061 * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
1062 * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
1063 * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
1064 * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1065 * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1066 * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1067 * WinLauncher/WinLauncherDebug.vsprops:
1068 * WinLauncher/WinLauncherDebugAll.vsprops:
1069 * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
1070 * WinLauncher/WinLauncherProduction.vsprops:
1071 * WinLauncher/WinLauncherRelease.vsprops:
1072 * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1073 * record-memory-win/record-memory-winDebug.vsprops:
1074 * record-memory-win/record-memory-winDebugAll.vsprops:
1075 * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
1076 * record-memory-win/record-memory-winProduction.vsprops:
1077 * record-memory-win/record-memory-winRelease.vsprops:
1078 * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1080 2011-12-14 Anders Carlsson <andersca@apple.com>
1084 Move CHECKs out of the destructor.
1086 * TestWebKitAPI/Tests/WTF/Functional.cpp:
1087 (TestWebKitAPI::B::~B):
1088 (TestWebKitAPI::TEST):
1090 2011-12-14 Anders Carlsson <andersca@apple.com>
1092 binding a member function should ref/deref the object pointer if needed
1093 https://bugs.webkit.org/show_bug.cgi?id=74552
1095 Reviewed by Sam Weinig.
1099 * TestWebKitAPI/Tests/WTF/Functional.cpp:
1100 (TestWebKitAPI::B::B):
1101 (TestWebKitAPI::B::~B):
1102 (TestWebKitAPI::B::ref):
1103 (TestWebKitAPI::B::deref):
1104 (TestWebKitAPI::B::f):
1105 (TestWebKitAPI::B::g):
1106 (TestWebKitAPI::TEST):
1108 2011-12-14 Hajime Morrita <morrita@chromium.org>
1110 JS_INLINE and WTF_INLINE should be visible from WebCore
1111 https://bugs.webkit.org/show_bug.cgi?id=73191
1113 Reviewed by Kevin Ollivier.
1115 Removed macro definitions which is now provided by Platform.h
1117 * DumpRenderTree/chromium/config.h:
1118 * DumpRenderTree/config.h:
1119 * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
1120 * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
1121 * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
1122 * TestWebKitAPI/config.h:
1123 * WebKitTestRunner/config.h:
1125 2011-12-14 Kentaro Hara <haraken@chromium.org>
1127 Unreviewed, rolling out r102761.
1128 http://trac.webkit.org/changeset/102761
1129 https://bugs.webkit.org/show_bug.cgi?id=74485
1131 we came up with a better fix than this (see comments in bug
1134 * Scripts/prepare-ChangeLog:
1135 (generateFunctionLists):
1139 (createPatchCommand):
1143 (statusDescription):
1146 2011-12-14 Anders Carlsson <andersca@apple.com>
1148 Work around a bug in the MSVC2005 compiler
1149 https://bugs.webkit.org/show_bug.cgi?id=74550
1151 Reviewed by Sam Weinig.
1155 * TestWebKitAPI/Tests/WTF/Functional.cpp:
1157 2011-12-14 Csaba Osztrogonác <ossy@webkit.org>
1159 [Qt] Test fonts are not used with Qt5
1160 https://bugs.webkit.org/show_bug.cgi?id=72513
1162 My last unreviewed buildfix for this crazy bug.
1164 * qmake/mkspecs/features/features.prf:
1166 2011-12-14 Anders Carlsson <andersca@apple.com>
1168 Another attempt at fixing the Windows build.
1170 Disable all the tests until I can figure out what's going on here.
1172 * TestWebKitAPI/Tests/WTF/Functional.cpp:
1174 2011-12-14 Anders Carlsson <andersca@apple.com>
1176 Fix the Windows build.
1178 Disable some of the tests for now.
1180 * TestWebKitAPI/Tests/WTF/Functional.cpp:
1182 2011-12-14 Anders Carlsson <andersca@apple.com>
1184 bind should handle member functions
1185 https://bugs.webkit.org/show_bug.cgi?id=74529
1187 Reviewed by Sam Weinig.
1191 * TestWebKitAPI/Tests/WTF/Functional.cpp:
1192 (TestWebKitAPI::A::A):
1193 (TestWebKitAPI::A::f):
1194 (TestWebKitAPI::A::addF):
1195 (TestWebKitAPI::TEST):
1197 2011-12-14 Anders Carlsson <andersca@apple.com>
1199 Add unary and binary bind overloads
1200 https://bugs.webkit.org/show_bug.cgi?id=74524
1202 Reviewed by Sam Weinig.
1206 * TestWebKitAPI/Tests/WTF/Functional.cpp:
1207 (TestWebKitAPI::TEST):
1208 (TestWebKitAPI::multiplyByTwo):
1209 (TestWebKitAPI::multiplyByOneAndAHalf):
1210 (TestWebKitAPI::multiply):
1211 (TestWebKitAPI::subtract):
1213 2011-12-14 Holger Hans Peter Freyther <holger@moiji-mobile.com>
1215 [Qt] Test fonts are not used with Qt5
1216 https://bugs.webkit.org/show_bug.cgi?id=72513
1218 MIPS and SH4 buildfix after r102776 and r102795.
1220 Reviewed by Csaba Osztrogonác.
1222 * qmake/mkspecs/features/features.prf:
1224 2011-12-14 Csaba Osztrogonác <ossy@webkit.org>
1226 [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
1228 * qmake/mkspecs/features/features.prf:
1230 2011-12-14 Andreas Kling <kling@webkit.org>
1232 Make my e-mail address a little more awesome.
1234 * Scripts/webkitpy/common/config/committers.py:
1236 2011-12-14 Csaba Osztrogonác <ossy@webkit.org>
1238 [Qt] Rollout r102769, because it broke Qt-4.8 builds.
1240 * qmake/mkspecs/features/webcore.prf:
1242 2011-12-14 Balazs Kelemen <kbalazs@webkit.org>
1244 [Qt] Test fonts are not used with Qt5
1245 https://bugs.webkit.org/show_bug.cgi?id=72513
1247 Reviewed by Simon Hausmann.
1249 Don't depend on Q_WS_X11 anymore since it's not the Qt5
1250 way to detect the platform. Make the guards depend
1251 on our own configtest for fontconfig. For Qt4 we can still
1252 use the preassumption that we have it on Linux.
1254 * DumpRenderTree/qt/DumpRenderTree.pro:
1255 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1256 (WebCore::DumpRenderTree::open):
1257 (WebCore::DumpRenderTree::initializeFonts):
1258 * DumpRenderTree/qt/DumpRenderTreeQt.h:
1259 * DumpRenderTree/qt/main.cpp:
1260 (main): Additionally remove a nonsense piece of code that was
1261 trying to reset the font settings - which is not necessary -
1262 after we have already returned from main.
1263 * WebKitTestRunner/InjectedBundle/Target.pri:
1264 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1265 (WTR::activateFonts):
1266 * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
1267 from WTR. It is not needed. We set up the fonts via the injected bundle.
1268 * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
1270 * qmake/config.tests/fontconfig/fontconfig.pro: Added.
1271 * qmake/mkspecs/features/features.prf:
1272 * qmake/sync.profile:
1274 2011-12-14 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1276 [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
1280 https://bugs.webkit.org/show_bug.cgi?id=74413
1282 Reviewed by Simon Hausmann.
1284 * qmake/mkspecs/features/webcore.prf:
1286 2011-12-14 Pierre Rossi <pierre.rossi@gmail.com>
1288 [Qt] Mobile theme could use a little refresh
1289 https://bugs.webkit.org/show_bug.cgi?id=74293
1291 Have MiniBrowser use the mobile theme when not
1294 Reviewed by Kenneth Rohde Christiansen.
1296 * MiniBrowser/qt/MiniBrowserApplication.cpp:
1297 (MiniBrowserApplication::handleUserOptions):
1299 2011-12-14 João Paulo Rechi Vita <jprvita@openbossa.org>
1301 [Qt] [Gardening] Remove qt-4.7 layout tests dir
1302 https://bugs.webkit.org/show_bug.cgi?id=74426
1304 Building trunk now depends on Qt >= 4.8, so no need to keep this directory
1307 Reviewed by Csaba Osztrogonác.
1309 * Scripts/webkitpy/layout_tests/port/qt.py:
1310 (QtPort.qt_version):
1311 (QtPort.baseline_search_path):
1312 (QtPort._skipped_file_search_paths):
1313 * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1314 (QtPortTest._assert_search_path):
1316 2011-12-14 Kentaro Hara <haraken@chromium.org>
1318 [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
1319 through parameter passing
1320 https://bugs.webkit.org/show_bug.cgi?id=74485
1322 Reviewed by Ryosuke Niwa.
1324 We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1325 manner. This bug is one of the incremental refactorings to remove all top-level
1326 code and global variables from prepare-ChangeLog. In this patch,
1327 we make the following global variables be used only through parameter passing.
1331 * Scripts/prepare-ChangeLog:
1332 (generateFunctionLists):
1337 (createPatchCommand):
1342 (statusDescription):
1345 2011-12-14 Alexander Færøy <alexander.faeroy@nokia.com>
1347 [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
1348 https://bugs.webkit.org/show_bug.cgi?id=74417
1350 Reviewed by Simon Hausmann.
1352 Based on original patch by Kenneth Christiansen.
1354 Already covered by current tests.
1356 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1357 (WebCore::DumpRenderTree::DumpRenderTree):
1358 (WebCore::DumpRenderTree::~DumpRenderTree):
1359 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1360 (LayoutTestController::setMockDeviceOrientation):
1362 2011-12-03 Philippe Normand <pnormand@igalia.com>
1364 [GTK] Bad text rendering since r101343
1365 https://bugs.webkit.org/show_bug.cgi?id=73744
1367 Reviewed by Martin Robinson.
1369 Turn cairo hint metrics off for better font metrics reporting in
1370 the tests. This is especially important for SVG.
1372 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1373 (initializeGtkFontSettings):
1374 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1375 (WTR::initializeGtkSettings):
1377 2011-12-13 Kentaro Hara <haraken@chromium.org>
1379 [Refactoring] Remove several global variables from prepare-ChangeLog
1380 https://bugs.webkit.org/show_bug.cgi?id=74389
1382 Reviewed by David Kilzer.
1384 We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1385 manner. This bug is one of the incremental refactorings to remove all top-level
1386 code and global variables from prepare-ChangeLog. In this patch,
1387 we make the following global variables being used only through parameter passing.
1394 * Scripts/prepare-ChangeLog:
1396 (generateNewChangeLogs):
1399 (firstDirectoryOrCwd):
1401 2011-12-13 Anders Carlsson <andersca@apple.com>
1403 Add a very bare-bones implementation of bind and Function to WTF
1404 https://bugs.webkit.org/show_bug.cgi?id=74462
1406 Reviewed by Sam Weinig.
1408 Add basic tests for WTF::Function and WTF::bind.
1410 * TestWebKitAPI/TestWebKitAPI.gypi:
1411 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1412 * TestWebKitAPI/Tests/Functional.cpp: Added.
1413 (TestWebKitAPI::returnFortyTwo):
1414 (TestWebKitAPI::TEST):
1415 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1417 2011-12-13 Robin Dunn <robin@alldunn.com>
1419 [wx] Add a URL argument to wxWebView constructor.
1420 https://bugs.webkit.org/show_bug.cgi?id=74316
1422 Reviewed by Kevin Ollivier.
1424 * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1426 * wx/browser/browser.cpp:
1429 2011-12-13 Raphael Kubo da Costa <kubo@profusion.mobi>
1431 watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
1432 https://bugs.webkit.org/show_bug.cgi?id=74430
1434 Reviewed by David Levin.
1436 * Scripts/webkitpy/common/config/watchlist:
1438 2011-12-13 Peter Beverloo <peter@chromium.org>
1440 [Chromium] Pull in FreeType and decrease check-out complexity for Android
1441 https://bugs.webkit.org/show_bug.cgi?id=74401
1443 Decrease the check-out complexity by removing the need to first run
1444 "update-webkit-chromium --chromium" prior to running it with
1445 "--chromium-android", which was caused by an unversioned third_party/
1446 directory being created. This moves the Android NDK to Source/WebKit/
1447 chromium/, coming from third_party/ in that directory.
1449 Reviewed by Adam Barth.
1451 * Scripts/update-webkit-chromium:
1452 * Scripts/webkitdirs.pm:
1453 (buildChromiumMakefile):
1455 2011-12-13 Andy Wingo <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
1457 build-jsc passing incorrect args to buildGtkProject
1458 https://bugs.webkit.org/show_bug.cgi?id=74308
1460 Reviewed by Gustavo Noronha Silva.
1462 * Scripts/build-webkit: Instead of invoking buildGtkProject with
1463 another argument about webkit2, unshift a --disable-webkit2
1464 argument onto the buildArgs.
1465 * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
1466 arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
1467 and build-jsc are run one after the other.
1469 2011-12-13 Csaba Osztrogonác <ossy@webkit.org>
1471 [Qt] REGRESSION(102679): It broke Qt5-WK1 build
1472 https://bugs.webkit.org/show_bug.cgi?id=74413
1474 Unreviewed buildfix.
1476 * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
1478 2011-12-13 Csaba Osztrogonác <ossy@webkit.org>
1480 [Qt] Unreviewed speculativ debug buildfix after r102679.
1482 * QtTestBrowser/QtTestBrowser.pro:
1483 * QtTestBrowser/main.cpp:
1485 2011-12-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1487 [Qt] Get rid of layering violations in includes
1489 WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
1490 in the webcore.prf, but rather in each target that specificly needs
1491 headers in these location. We used to include them directly in webcore
1492 since we had layering violations between WebCore and WebKit, but now
1493 that they are gone there's no reason to do that.
1495 Reviewed by Simon Hausmann.
1497 * DumpRenderTree/qt/DumpRenderTree.pro:
1498 * QtTestBrowser/launcherwindow.h:
1499 * WebKitTestRunner/InjectedBundle/Target.pri:
1500 * qmake/mkspecs/features/webcore.prf:
1501 * qmake/mkspecs/features/webkit2.prf:
1503 2011-12-13 János Badics <dicska@gmail.com>
1505 [NRWT] It crashes intermittently when there are WebProcess crashes
1506 https://bugs.webkit.org/show_bug.cgi?id=73451
1508 Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
1510 Reviewed by Kenneth Rohde Christiansen.
1512 * Scripts/webkitpy/layout_tests/port/server_process.py:
1513 (ServerProcess._check_for_crash):
1515 2011-12-13 Carlos Garcia Campos <cgarcia@igalia.com>
1517 Unreviewed. Fix GTK+ API docs build.
1519 * gtk/generate-gtkdoc:
1520 (get_webkit2_options): Ignore WebKitUIClient since it's private
1523 2011-12-13 Kenichi Ishibashi <bashi@chromium.org>
1525 Reviewed, removed one of my email addresses to use the apprpriate one.
1527 * Scripts/webkitpy/common/config/committers.py:
1529 2011-12-12 Ádám Kallai <Kallai.Adam@stud.u-szeged.hu>
1531 [Qt] Fix skip list search path and expected file search path in ORWT
1532 https://bugs.webkit.org/show_bug.cgi?id=74281
1534 Expected file search path fixed.
1536 Print all used skipped list and expected search path in verbose mode similar to NRWT.
1538 Reviewed by Csaba Osztrogonác.
1540 * Scripts/old-run-webkit-tests:
1541 (buildPlatformResultHierarchy):
1542 (buildPlatformTestHierarchy):
1545 2011-12-12 Nándor Huszka <huszka.nandor@stud.u-szeged.hu>
1547 [Qt] Missing layoutTestController.dumpWillCacheResponse
1548 https://bugs.webkit.org/show_bug.cgi?id=74287
1550 Reviewed by Csaba Osztrogonác.
1552 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1553 (LayoutTestController::reset):
1554 (LayoutTestController::dumpWillCacheResponse):
1555 * DumpRenderTree/qt/LayoutTestControllerQt.h:
1557 2011-12-12 Martin Robinson <mrobinson@igalia.com>
1559 [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
1560 https://bugs.webkit.org/show_bug.cgi?id=73771
1562 Reviewed by Gustavo Noronha Silva.
1564 When using a fallback font during testing, always use DejaVu Sans. This prevents
1565 falling back to DejaVu Serif on some systems.
1567 * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
1569 2011-12-08 Pierre Rossi <pierre.rossi@gmail.com>
1571 Add myself as a committer
1573 * Scripts/webkitpy/common/config/committers.py:
1575 2011-12-12 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1577 [Qt] [WK2] Support customizing popup menus with QML
1578 https://bugs.webkit.org/show_bug.cgi?id=73560
1580 Reviewed by Tor Arne Vestbø.
1582 Add an Item Selector to our WebView using the experimental API.
1584 * MiniBrowser/qt/MiniBrowser.pro:
1585 * MiniBrowser/qt/MiniBrowser.qrc:
1586 * MiniBrowser/qt/qml/BrowserWindow.qml:
1587 * MiniBrowser/qt/qml/ItemSelector.qml: Added.
1589 2011-12-12 Alexander Færøy <alexander.faeroy@nokia.com>
1591 [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
1592 https://bugs.webkit.org/show_bug.cgi?id=74283
1594 Reviewed by Simon Hausmann.
1596 * MiniBrowser/qt/MiniBrowserApplication.cpp:
1597 (MiniBrowserApplication::sendTouchEvent):
1599 2011-12-12 Kentaro Hara <haraken@chromium.org>
1601 [Refactoring] In prepare-ChangeLog, move into a method the top-level code
1602 to show ChangeLogs diff and open ChangeLogs in an editor
1603 https://bugs.webkit.org/show_bug.cgi?id=74266
1605 Reviewed by Ryosuke Niwa.
1607 We are planning to write unit-tests for prepare-ChangeLog
1608 in a run-leaks_unittest manner. This patch is one of the incremental
1609 refactorings to remove all top-level code and global variables from
1612 * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
1613 Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
1614 Renamed @changed_files to @changedFiles.
1615 Renamed %conflict_files to %conflictFiles.
1616 (generateFunctionLists):
1620 2011-12-11 Kentaro Hara <haraken@chromium.org>
1622 [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
1623 https://bugs.webkit.org/show_bug.cgi?id=74257
1625 Reviewed by Ryosuke Niwa.
1627 We are planning to write unit-tests for prepare-ChangeLog
1628 in a run-leaks_unittest/ manner. This patch is one of the incremental
1629 refactorings to remove all top-level code and global variables from
1632 * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
1633 into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
1634 into resolveConflictedChangeLogs().
1635 (getLatestChangeLogs):
1636 (resolveConflictedChangeLogs):
1638 2011-12-11 Kentaro Hara <haraken@chromium.org>
1640 [Refactoring] Move top-level code to generate a new ChangeLog into a method
1641 https://bugs.webkit.org/show_bug.cgi?id=74253
1643 Reviewed by David Kilzer.
1645 The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
1646 which requires to remove top-level code and global variables. This patch is one of
1647 the incremental refactorings for that.
1649 * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
1650 (generateFunctionLists):
1652 (generateNewChangeLogs):
1653 (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
1655 2011-12-10 Kentaro Hara <haraken@chromium.org>
1657 [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
1658 https://bugs.webkit.org/show_bug.cgi?id=74175
1660 Reviewed by Ryosuke Niwa.
1662 The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1663 This requires to remove top-level code. This patch is one of the incremental refactorings
1666 * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
1669 2011-12-10 Andreas Kling <kling@webkit.org>
1671 Add my Apple e-mail to committers.py.
1673 * Scripts/webkitpy/common/config/committers.py:
1675 2011-12-09 Dirk Pranke <dpranke@chromium.org>
1677 chromium win build: revert build_webkit_exes_from_webkit_gyp change
1678 https://bugs.webkit.org/show_bug.cgi?id=74225
1680 This change sets build_webkit_exes_from_webkit_gyp back to 1;
1681 the "All.gyp" solution doesn't work on windows.
1683 * Scripts/webkitdirs.pm:
1686 2011-12-09 Hugo Parente Lima <hugo.lima@openbossa.org>
1688 [Qt] Click's count is limited to three continuous clicks.
1689 https://bugs.webkit.org/show_bug.cgi?id=45666
1691 Reviewed by Kenneth Rohde Christiansen.
1693 Update m_time at every call to leapForward, so double clicks
1694 event are correctly sent by EventSender.
1696 * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1697 (WTR::EventSenderProxy::updateClickCountForButton):
1698 (WTR::EventSenderProxy::leapForward):
1700 2011-12-09 Kentaro Hara <haraken@chromium.org>
1702 [Refactoring] Reduce top-level code in prepare-ChangeLog
1703 https://bugs.webkit.org/show_bug.cgi?id=74172
1705 Reviewed by Ryosuke Niwa.
1707 The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1708 This requires to remove top-level code. This patch is one of the incremental refactorings
1711 * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
1712 (generateFunctionLists):
1714 2011-12-09 Sam Weinig <sam@webkit.org>
1716 Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
1717 https://bugs.webkit.org/show_bug.cgi?id=74218
1719 Reviewed by Anders Carlsson.
1721 Add a test of the WKConnectionRef API.
1723 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1724 * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
1725 (TestWebKitAPI::didCreateConnection):
1726 (TestWebKitAPI::connectionDidReceiveMessage):
1727 (TestWebKitAPI::connectionDidClose):
1728 (TestWebKitAPI::TEST):
1729 * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
1730 (TestWebKitAPI::connectionDidReceiveMessage):
1731 (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
1732 (TestWebKitAPI::WKConnectionTest::initialize):
1734 2011-12-09 David Levin <levin@chromium.org>
1736 Hash* iterators should allow comparison between const and const versions.
1737 https://bugs.webkit.org/show_bug.cgi?id=73370
1739 Reviewed by Darin Adler.
1741 * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
1742 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1743 * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1744 * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
1745 (TestWebKitAPI::TEST): Add a test for the new functionality.
1747 2011-12-09 Dirk Pranke <dpranke@chromium.org>
1749 chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
1750 https://bugs.webkit.org/show_bug.cgi?id=74212
1752 Reviewed by Tony Chang.
1754 The change introduced in r102201 to split the executables out of
1755 WebKit.gyp apparently doesn't work right on Windows, since
1756 WebKit.gyp and Tools.gyp refer to dependent projects by
1757 different relative paths (it appears gyp doesn't normalize the
1758 paths). This change moves Tools.gyp to be in the same directory
1759 as WebKit.gyp (and All.gyp), which should fix this and
1760 conveniently will also solve the problem of how to add Tools.gyp
1761 to the chromium DEPS file.
1763 * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
1765 2011-12-09 Kentaro Hara <haraken@chromium.org>
1767 [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
1768 https://bugs.webkit.org/show_bug.cgi?id=74173
1770 Reviewed by Ryosuke Niwa.
1772 The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1773 This requires to remove top-level code. This patch is one of the incremental refactorings
1776 * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
1777 (fetchBugDescriptionFromURL):
1779 2011-12-09 Tony Chang <tony@chromium.org>
1781 Switch the chromium mac bots to using skia test results
1782 https://bugs.webkit.org/show_bug.cgi?id=74201
1784 Reviewed by Ryosuke Niwa.
1786 This is reverting http://trac.webkit.org/changeset/97781 and changing
1787 the name in master.cfg to no longer have cg in the name.
1789 * BuildSlaveSupport/build.webkit.org-config/config.json:
1790 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1791 (appendCustomBuildFlags):
1792 (RunWebKitTests.start):
1794 2011-12-09 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
1796 [Qt] Remove a wrongly placed ASSERT.
1798 Reviewed by Tor Arne Vestbø.
1800 * MiniBrowser/qt/MiniBrowserApplication.cpp:
1801 (MiniBrowserApplication::notify):
1803 2011-12-09 Cary Clark <caryclark@google.com>
1805 layout_test update to accommodate new use_skia=1 default on Chromium-Mac
1806 https://bugs.webkit.org/show_bug.cgi?id=74118
1808 Reviewed by Adam Barth.
1810 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1812 * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1813 (ChromiumMacPort.__init__):
1814 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1815 (ChromiumMacPortTest.test_versions):
1816 (ChromiumMacPortTest.test_graphics_type):
1818 2011-12-09 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1820 [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
1822 The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
1823 this failed when moving files in the source tree, as the .d file would contain
1824 stale dependencies on the old source file location. By keeping the object files
1825 (and hence the depdendency files) in a proper tree structure inside the objects
1826 directory we can prevent this failure.
1828 A side benefit is that we can also have objects with the same name inside the
1831 Reviewed by Simon Hausmann.
1833 * qmake/mkspecs/features/unix/default_pre.prf:
1835 2011-12-09 Csaba Osztrogonác <ossy@webkit.org>
1837 Unreviewed. Update unit test after r102412.
1839 * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1840 (IRCCommandTest.test_whois):
1842 2011-12-09 Kentaro Hara <haraken@chromium.org>
1844 REGRESSION(r102105): run-bindings-tests should output full diff results
1845 https://bugs.webkit.org/show_bug.cgi?id=74166
1847 Reviewed by Adam Barth.
1849 Since r102105, the output of run-bindings-tests is truncated to 500 characters.
1850 run-bindings-tests should output full diff results.
1852 * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
1853 (BindingsTests.generate_from_idl):
1854 (BindingsTests.generate_supplemental_dependency):
1855 (BindingsTests.detect_changes):
1857 2011-12-09 Simon Hausmann <simon.hausmann@nokia.com>
1859 [Qt] Fix compilation with newly separated Qt 5 QtQuick module
1860 https://bugs.webkit.org/show_bug.cgi?id=73990
1862 Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
1864 Fix QtQuick includes after move from QtDeclarative to QtQuick.
1866 * MiniBrowser/qt/BrowserWindow.h:
1867 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1869 2011-12-08 Adam Klein <adamk@chromium.org>
1871 [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
1872 https://bugs.webkit.org/show_bug.cgi?id=73492
1874 Reviewed by Adam Barth.
1876 Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
1877 keypress event without any script on the stack.
1879 * DumpRenderTree/chromium/EventSender.cpp:
1880 (EventSender::EventSender):
1881 (EventSender::keyDown):
1882 (KeyDownTask::KeyDownTask):
1883 (KeyDownTask::runIfValid):
1884 (EventSender::scheduleAsynchronousKeyDown):
1885 * DumpRenderTree/chromium/EventSender.h:
1887 2011-12-08 Hayato Ito <hayato@chromium.org>
1889 [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
1890 https://bugs.webkit.org/show_bug.cgi?id=73980
1892 Reviewed by Tony Chang.
1895 (guess_string_length):
1896 (ustring_to_string):
1897 (lstring_to_string):
1898 (LCharStringPrinter):
1899 (LCharStringPrinter.to_string):
1900 (WTFStringImplPrinter.get_length):
1901 (WTFStringImplPrinter.to_string):
1902 (WTFStringImplPrinter.is_8bit):
1903 (WTFStringPrinter.stringimpl_ptr):
1904 (WTFStringPrinter.get_length):
1905 (WTFStringPrinter.to_string):
1906 (add_pretty_printers.lookup_function):
1908 2011-12-08 Pierre Rossi <pierre.rossi@gmail.com>
1910 Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
1911 https://bugs.webkit.org/show_bug.cgi?id=73916
1913 Reviewed by Kent Tamura.
1915 * qmake/mkspecs/features/features.prf:
1917 2011-12-08 Adrienne Walker <enne@google.com>
1919 Unreviewed contributor additions to committers.py.
1921 * Scripts/webkitpy/common/config/committers.py:
1923 2011-12-08 David Reveman <reveman@chromium.org>
1925 [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
1926 https://bugs.webkit.org/show_bug.cgi?id=74017
1928 Reviewed by James Robinson.
1930 Add support for command line flag enable-per-tile-painting in DumpRenderTree.
1932 * DumpRenderTree/chromium/DumpRenderTree.cpp:
1934 * DumpRenderTree/chromium/TestShell.cpp:
1935 (TestShell::TestShell):
1936 (TestShell::resetWebSettings):
1937 * DumpRenderTree/chromium/TestShell.h:
1938 (TestShell::setAcceleratedPaintingEnabled):
1939 (TestShell::setPerTilePaintingEnabled):
1940 * DumpRenderTree/chromium/WebPreferences.cpp:
1941 (WebPreferences::reset):
1942 (WebPreferences::applyTo):
1943 * DumpRenderTree/chromium/WebPreferences.h:
1944 * Scripts/webkitpy/layout_tests/port/chromium.py:
1945 (ChromiumDriver._wrapper_options):
1946 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1949 2011-12-08 Dirk Pranke <dpranke@chromium.org>
1951 create a "SystemHost" object for webkitpy to slim down the Host object
1952 https://bugs.webkit.org/show_bug.cgi?id=72680
1954 Reviewed by Eric Siedel.
1956 This creates a SystemHost object that other objects that should
1957 only have dependencies on functionality in webkitpy.common.system
1958 can use; this will allow them to not require a full Host.
1960 * Scripts/webkitpy/common/host.py:
1961 * Scripts/webkitpy/common/host_mock.py:
1962 * Scripts/webkitpy/common/system/systemhost.py: Added.
1963 * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
1965 2011-12-08 Chris Fleizach <cfleizach@apple.com>
1967 AX: platform/mac/accessibility/search-with-frames.html crashes
1968 https://bugs.webkit.org/show_bug.cgi?id=74093
1970 Reviewed by Darin Adler.
1972 Take care of the case when an incoming element is null.
1974 * DumpRenderTree/AccessibilityUIElement.cpp:
1975 (uiElementForSearchPredicateCallback):
1976 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1977 (AccessibilityUIElement::uiElementForSearchPredicate):
1978 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1979 (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1981 2011-12-08 Alexander Færøy <ahf@0x90.dk>
1983 [Qt] Visualize mock point ID's in the MiniBrowser
1984 https://bugs.webkit.org/show_bug.cgi?id=74098
1986 Reviewed by Tor Arne Vestbø.
1988 * MiniBrowser/qt/BrowserWindow.cpp:
1989 (BrowserWindow::updateVisualMockTouchPoints):
1990 * MiniBrowser/qt/qml/MockTouchPoint.qml:
1992 2011-12-08 Dominic Mazzoni <dmazzoni@google.com>
1994 Accessibility: AccessibilityController should support listening to notifications on all elements.
1995 https://bugs.webkit.org/show_bug.cgi?id=72866
1997 Adds addNotificationListener and removeNotificationListener methods
1998 to AccessibilityController, to listen to notifications on any element
1999 rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
2000 implementations are all contained in this change.
2002 On Mac, refactors AccessibilityNotificationHandler into its own
2003 source file that can be used by both AccessibilityController and
2004 AccessibilityUIElement. (Both DRT and WKTR.)
2006 Reviewed by Chris Fleizach.
2008 * DumpRenderTree/AccessibilityController.cpp:
2009 (addNotificationListenerCallback):
2010 (removeNotificationListenerCallback):
2011 (AccessibilityController::getJSClass):
2012 * DumpRenderTree/AccessibilityController.h:
2013 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2014 * DumpRenderTree/chromium/AccessibilityController.cpp:
2015 (AccessibilityController::AccessibilityController):
2016 (AccessibilityController::notificationReceived):
2017 (AccessibilityController::addNotificationListenerCallback):
2018 (AccessibilityController::removeNotificationListenerCallback):
2019 * DumpRenderTree/chromium/AccessibilityController.h:
2020 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2021 (AccessibilityController::addNotificationListener):
2022 (AccessibilityController::removeNotificationListener):
2023 * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2024 (AccessibilityController::~AccessibilityController):
2025 (AccessibilityController::addNotificationListener):
2026 (AccessibilityController::removeNotificationListener):
2027 * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
2028 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
2029 (-[NSString createJSStringRef]):
2030 (-[AccessibilityNotificationHandler init]):
2031 (-[AccessibilityNotificationHandler setPlatformElement:]):
2032 (-[AccessibilityNotificationHandler dealloc]):
2033 (-[AccessibilityNotificationHandler setCallback:]):
2034 (-[AccessibilityNotificationHandler startObserving]):
2035 (-[AccessibilityNotificationHandler _notificationReceived:]):
2036 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2037 (AccessibilityUIElement::addNotificationListener):
2038 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2039 (notificationListenerProc):
2040 (AccessibilityController::addNotificationListener):
2041 (AccessibilityController::removeNotificationListener):
2042 (AccessibilityController::winNotificationReceived):
2043 (AccessibilityController::winAddNotificationListener):
2044 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2045 (AccessibilityUIElement::addNotificationListener):
2046 * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2047 (WTR::AccessibilityController::addNotificationListener):
2048 (WTR::AccessibilityController::removeNotificationListener):
2049 * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2050 (WTR::AccessibilityController::logAccessibilityEvents):
2051 * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2052 (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
2053 * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2054 (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2055 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2056 * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
2057 (WTR::AccessibilityController::addNotificationListener):
2058 (WTR::AccessibilityController::removeNotificationListener):
2059 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
2060 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
2061 (-[NSString createJSStringRef]):
2062 (-[AccessibilityNotificationHandler init]):
2063 (-[AccessibilityNotificationHandler setPlatformElement:]):
2064 (-[AccessibilityNotificationHandler dealloc]):
2065 (-[AccessibilityNotificationHandler setCallback:]):
2066 (-[AccessibilityNotificationHandler startObserving]):
2067 (-[AccessibilityNotificationHandler _notificationReceived:]):
2068 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2069 (WTR::AccessibilityUIElement::AccessibilityUIElement):
2070 (WTR::AccessibilityUIElement::verticalScrollbar):
2071 (WTR::AccessibilityUIElement::addNotificationListener):
2072 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2074 2011-12-08 Csaba Osztrogonác <ossy@webkit.org>
2076 [Qt][WK2] Unreviewed buildfix after r102352.
2078 * qmake/mkspecs/features/webkit2.prf:
2080 2011-12-08 Adam Roben <aroben@apple.com>
2082 Make finding crash logs by PID work on Snow Leopard
2084 Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
2085 were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
2086 read the first line of the crash log and pull the PID out of there.
2088 Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
2091 Reviewed by Darin Adler.
2093 * Scripts/webkitpy/common/system/crashlogs.py:
2094 (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
2095 name and PID for the log, rather than checking the Lion-only app_description extended
2096 attribute. We now also reject the log if the process name doesn't match what we expect.
2098 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2099 (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
2101 (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
2102 unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
2103 (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
2104 the new make_mock_crash_report_darwin function. Also added tests for files that can't be
2105 read, files that actually contain a crash log for some other process, and files that are
2108 * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
2111 * Scripts/webkitpy/common/system/filesystem_mock.py:
2112 (MockFileSystem.__init__): Removed xattr support, which is now unused.
2113 (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
2114 ReadableTextFileObject. This function was completely broken before!
2115 (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
2116 bugs like the above.
2117 (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
2118 things like readline() and seek().
2120 (ReadableTextFileObject.close):
2121 (ReadableTextFileObject.read):
2122 Added. We override the superclass implementation to account for using a StringIO object.
2124 (ReadableTextFileObject.readline):
2125 (ReadableTextFileObject.seek):
2126 Added. These just call through to StringIO.
2128 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2129 (MainTest.test_crash_log):
2130 (MainTest.test_web_process_crash_log):
2131 Changed to use make_mock_crash_report_darwin.
2133 2011-12-06 Jon Lee <jonlee@apple.com>
2135 [WK2] Add permissions support (73960)
2136 https://bugs.webkit.org/show_bug.cgi?id=73960
2137 <rdar://problem/10357008>
2139 Reviewed by Darin Adler.
2141 Add null function item to comply with added callback to WKPageUIClient.
2143 * MiniBrowser/mac/BrowserWindowController.m:
2144 (-[BrowserWindowController awakeFromNib]):
2145 * WebKitTestRunner/TestController.cpp:
2146 (WTR::TestController::createOtherPage):
2147 (WTR::TestController::initialize):
2149 2011-12-08 Alexander Færøy <alexander.faeroy@nokia.com>
2151 [Qt] Visualize mock points in the Qt MiniBrowser
2152 https://bugs.webkit.org/show_bug.cgi?id=74074
2154 Reviewed by Tor Arne Vestbø.
2156 * MiniBrowser/qt/BrowserWindow.cpp:
2157 (BrowserWindow::updateVisualMockTouchPoints):
2158 * MiniBrowser/qt/BrowserWindow.h:
2159 * MiniBrowser/qt/MiniBrowser.qrc:
2160 * MiniBrowser/qt/MiniBrowserApplication.cpp:
2161 (MiniBrowserApplication::notify):
2162 (MiniBrowserApplication::sendTouchEvent):
2163 * MiniBrowser/qt/MiniBrowserApplication.h:
2164 * MiniBrowser/qt/icons/touchpoint.png: Added.
2165 * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
2167 2011-12-08 Simon Hausmann <simon.hausmann@nokia.com>
2169 [Qt] WebKitTestRunner crashes with debug builds
2170 https://bugs.webkit.org/show_bug.cgi?id=74090
2172 Reviewed by Tor Arne Vestbø.
2174 * WebKitTestRunner/qt/TestControllerQt.cpp:
2175 (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
2176 to ensure WTF/JSC threading is initialized.
2178 2011-12-08 Dirk Pranke <dpranke@chromium.org>
2180 fix build-webkit --chromium after breakage in r102201
2181 https://bugs.webkit.org/show_bug.cgi?id=74031
2183 Reviewed by Tony Chang.
2185 * Scripts/webkitdirs.pm:
2188 2011-12-08 Kentaro Hara <haraken@chromium.org>
2190 Unreviewed, rolling out r102280.
2191 http://trac.webkit.org/changeset/102280
2192 https://bugs.webkit.org/show_bug.cgi?id=74031
2194 Chromium/Windows build is broken
2196 * Scripts/webkitdirs.pm:
2199 2011-12-08 Nayan Kumar K <nayankk@motorola.com>
2201 Adding myself to committers list.
2205 * Scripts/webkitpy/common/config/committers.py:
2207 2011-12-07 Michael Saboff <msaboff@apple.com>
2209 StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
2210 https://bugs.webkit.org/show_bug.cgi?id=73995
2212 Reenabled failing tests that the code part of the patch fixes.
2214 Reviewed by Geoffrey Garen.
2216 * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2217 (TestWebKitAPI::TEST):
2219 2011-12-07 MORITA Hajime <morrita@google.com>
2221 [filter-build-webkit] should not emit reset color when --no-color is given
2222 https://bugs.webkit.org/show_bug.cgi?id=73992
2224 Reviewed by Daniel Bates.
2226 Stop printing control sequences when --no-color is given.
2227 After this change, the filter runs nicely even on environments
2228 like Emacs compilation-mode which cannot understand the control sequence.
2230 * Scripts/filter-build-webkit:
2233 2011-12-07 Eric Seidel <eric@webkit.org>
2235 Use free memory to determine if we have space for DRT instances instead of total memory
2236 https://bugs.webkit.org/show_bug.cgi?id=74021
2238 Reviewed by Adam Barth.
2240 This will hopefully make the Mac buildbots behave better.
2242 I also reduced the expected memory needed per DRT now that
2243 we're properly accounting for the system memory in our calculations.
2245 * Scripts/webkitpy/common/system/platforminfo.py:
2246 (PlatformInfo.total_bytes_memory):
2247 (PlatformInfo._compute_free_bytes_from_vm_stat_output):
2248 * Scripts/webkitpy/common/system/platforminfo_mock.py:
2249 (MockPlatformInfo.total_bytes_memory):
2250 * Scripts/webkitpy/layout_tests/port/base.py:
2251 (Port.default_child_processes):
2252 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2253 (PortTest.test_default_child_processes):
2255 2011-12-07 Dirk Pranke <dpranke@chromium.org>
2257 fix build-webkit --chromium after breakage in r102201
2258 https://bugs.webkit.org/show_bug.cgi?id=74031
2260 Reviewed by Tony Chang.
2262 r102201 introduced a change to the chromium build that splits
2263 the executables out of WebKit.gyp into other gyp files, and adds
2264 a new "All.gyp" that builds everything. However, I forgot to
2265 update the build script to use All.gyp.
2267 * Scripts/webkitdirs.pm:
2270 2011-12-07 Tom Zakrajsek <tomz@codeaurora.org>
2272 Moved myself to the committers list.
2274 * Scripts/webkitpy/common/config/committers.py:
2276 2011-11-30 Simon Hausmann <simon.hausmann@nokia.com>
2278 [Qt] Fix debug shlib build with V8.
2280 Reviewed by Tor Arne Vestbø.
2282 * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
2285 2011-11-30 Simon Hausmann <simon.hausmann@nokia.com>
2287 [Qt] V8 build fixes.
2289 Reviewed by Tor Arne Vestbø.
2291 * qmake/mkspecs/features/javascriptcore.prf: Don't add
2292 Source/Thirdparty to the include search path here.
2293 * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
2294 used when building WebCore as well as using it, because header files like
2295 GraphicsContext3D.h include stuff from ThirdParty.
2297 2011-12-07 Peter Beverloo <peter@chromium.org>
2299 [Chromium] Fix project file generation for the Android bot after r102201
2300 https://bugs.webkit.org/show_bug.cgi?id=73996
2302 The gyp refactoring in r102201 was didn't explicitly exclude
2303 the Android operating system in Tools/Tools.gyp, which broke
2304 as gcc_version is not defined for that configuration.
2306 Reviewed by Andreas Kling.
2310 2011-12-07 Vsevolod Vlasov <vsevik@chromium.org>
2312 Unreviewed. Disabled failing tests on chromium.
2314 * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2315 (TestWebKitAPI::TEST):
2317 2011-12-06 Dirk Pranke <dpranke@chromium.org>
2319 binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
2320 https://bugs.webkit.org/show_bug.cgi?id=73382
2322 Reviewed by Tony Chang.
2324 XCode (and hence GYP) can't handle circular dependencies between
2325 files (and projects). Accordingly, although the binaries in
2326 WebKit.gyp depend on webkit_support and webkit_support depends
2327 on webkit, we don't mention the latter dependency in the file.
2328 To fix this, this change moves the binaries like DRT into a new
2329 GYP file, and modifies gyp_webkit to build from that file
2330 instead of WebKit.gyp.
2334 2011-12-06 Adam Roben <aroben@apple.com>
2336 Add a pid parameter to CrashLogs.find_newest_log
2338 When a PID is passed, only crash logs corresponding to a crashed process with that PID are
2341 Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
2342 process whose crash log you want to find
2344 Reviewed by Dirk Pranke.
2346 * Scripts/webkitpy/common/system/crashlogs.py:
2347 (CrashLogs.find_newest_log): Added an optional pid parameter.
2348 (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
2349 candidate log's app_description extended attribute to see if that log corresponds to a
2350 crashed process with the specified PID.
2352 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2353 (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
2354 contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
2355 respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
2357 * Scripts/webkitpy/common/system/filesystem.py:
2358 (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
2359 systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
2362 * Scripts/webkitpy/common/system/filesystem_mock.py:
2363 (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
2364 (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
2367 * Scripts/webkitpy/tool/commands/queries.py:
2368 (CrashLog): Added help text. Added an optional PID parameter.
2369 (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
2371 2011-12-06 Adam Roben <aroben@apple.com>
2373 Wait for Crash Reporter to finish even when it lets the crashed process die quickly
2375 NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
2376 alive beyond the normal timeout limit. In cases where the crashed process was able to die
2377 faster, NRWT would assume that Crash Reporter had finished even though it often was still
2378 running, which would lead to an incorrect crash log being picked up.
2380 Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
2382 Reviewed by Dirk Pranke.
2384 * Scripts/webkitpy/layout_tests/port/server_process.py:
2385 (ServerProcess._reset):
2386 (ServerProcess.write):
2387 (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
2388 .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
2391 (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
2392 .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
2393 we bail out of handling the failure as a timeout if we find out that the process in fact
2394 crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
2396 (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
2397 finish running (unless directed otherwise) so we can be sure the crash log has been saved to
2400 * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2401 (TrivialMockPort.is_crash_reporter): Added.
2403 * Scripts/webkitpy/layout_tests/port/webkit.py:
2404 (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
2405 that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
2407 2011-12-06 Adam Barth <abarth@webkit.org>
2409 NRWT fails on unreleased versions of Mac OS X
2410 https://bugs.webkit.org/show_bug.cgi?id=72748
2412 Reviewed by Dirk Pranke.
2414 Hopefully this patch will make NRWT work on future versions on Mac OS X.
2415 Most of the infrastructure was already in place, but there were some
2416 asserts that failed. I've tested this patch by haxoring the version
2417 detection logic to simulate an unknown version. We might need to
2418 iterate based on feedback from folks with a real future version.
2420 * Scripts/webkitpy/layout_tests/port/apple.py:
2421 (ApplePort.__init__):
2422 - mac-future is an allowed port_name that's used internally by
2423 webkitpy to represent future versions of Mac OS X.
2424 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2426 - Test that we don't throw exceptions when dealing with future
2427 versions of Mac OS X.
2428 * Scripts/webkitpy/layout_tests/port/webkit.py:
2429 (WebKitPort._expectations_from_skipped_files):
2430 - Demote this logging message to "debug". It's expected that
2431 mac-future doesn't have a Skipped file.
2432 * Scripts/webkitpy/layout_tests/port/mac.py:
2434 * Scripts/webkitpy/layout_tests/port/win.py:
2436 - Re-order some code in these constructors so that
2437 self._operating_system is available to the ApplePort constructor.
2439 2011-12-06 Tommy Widenflycht <tommyw@google.com>
2441 Added myself as a committer.
2443 * Scripts/webkitpy/common/config/committers.py:
2445 2011-12-06 Peter Beverloo <peter@chromium.org>
2447 Added myself as a committer.
2449 * Scripts/webkitpy/common/config/committers.py:
2451 2011-12-06 Kentaro Hara <haraken@chromium.org>
2453 [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
2454 https://bugs.webkit.org/show_bug.cgi?id=73637
2456 Reviewed by Adam Barth.
2458 This patch replaces subprocess.Popen() with Executive, similar to other
2459 Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
2460 works well for cases where no exception is raised, no exception is raised
2461 but diff is found, and ScriptError is raised.
2463 * Scripts/run-bindings-tests:
2465 * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
2466 (BindingsTests.__init__):
2467 (BindingsTests.generate_from_idl):
2468 (BindingsTests.generate_supplemental_dependency):
2469 (BindingsTests.detect_changes):
2471 2011-12-05 Alexander Færøy <alexander.faeroy@nokia.com>
2473 [Qt] MiniBrowser should default to touch behavior
2474 https://bugs.webkit.org/show_bug.cgi?id=73863
2476 Reviewed by Chang Shu.
2478 MiniBrowser currently defaults to the traditional desktop behaviour
2479 instead of touch behaviour which is prefered.
2481 * MiniBrowser/qt/BrowserWindow.cpp:
2482 (BrowserWindow::BrowserWindow):
2483 * MiniBrowser/qt/MiniBrowserApplication.cpp:
2485 (MiniBrowserApplication::handleUserOptions):
2486 * MiniBrowser/qt/MiniBrowserApplication.h:
2487 (WindowOptions::WindowOptions):
2488 (WindowOptions::setUseTraditionalDesktopBehavior):
2489 (WindowOptions::useTraditionalDesktopBehavior):
2491 2011-12-05 Raphael Kubo da Costa <kubo@profusion.mobi>
2493 webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
2494 https://bugs.webkit.org/show_bug.cgi?id=73878
2496 Reviewed by Tony Chang.
2498 r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
2499 r98785 made webkit.py always use m_data16, which does not work when
2500 the string is an 8-bit string (such as KURL::string()).
2502 I was not able to directly call StringImpl::is8Bit() in the Python
2503 code, so I just reproduced the implementation there.
2506 (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2507 (WTFStringPrinter.to_string):
2508 (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2509 (JSCUStringPrinter.to_string):
2511 2011-12-05 Eric Seidel <eric@webkit.org>
2513 Up the "expected ram for each DRT instance" to 400MB instead of 300MB
2514 in hopes of making the Snow Leopard bot stop timing out.
2518 * Scripts/webkitpy/layout_tests/port/base.py:
2519 (Port.default_child_processes):
2520 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2521 (PortTest.test_default_child_processes):
2523 2011-12-05 Eric Seidel <eric@webkit.org>
2525 NRWT creates too many workers on RAM-limited machines
2526 https://bugs.webkit.org/show_bug.cgi?id=73847
2528 Reviewed by Dirk Pranke.
2530 Make NRWT restrict its number of workers when there isn't enough
2531 RAM to support them.
2532 Also re-enable parallel testing on the Mac bots which were
2533 failing due to not enough ram.
2535 * Scripts/run-webkit-tests:
2536 (platformIsReadyForParallelTesting):
2537 * Scripts/webkitpy/common/host.py:
2539 * Scripts/webkitpy/common/system/executive_mock.py:
2540 (MockExecutive.cpu_count):
2541 * Scripts/webkitpy/common/system/platforminfo.py:
2542 (PlatformInfo.__init__):
2543 (PlatformInfo.display_name):
2544 * Scripts/webkitpy/common/system/platforminfo_mock.py:
2545 (MockPlatformInfo.display_name):
2546 * Scripts/webkitpy/layout_tests/port/base.py:
2547 (Port.default_child_processes):
2548 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2549 (PortTest.test_default_child_processes):
2550 (PortTest.test_pretty_patch_os_error):
2552 2011-12-05 Hugo Parente Lima <hugo.lima@openbossa.org>
2554 Last mouse event could be lost if a JS call to eventSender.leapForward is made
2555 https://bugs.webkit.org/show_bug.cgi?id=73366
2557 Reviewed by Kenneth Rohde Christiansen.
2559 Empty the entire event queue when requested besides using
2560 sendEvent instead of postEvent to make sure all events were
2563 * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2564 (WTR::EventSenderProxy::EventSenderProxy):
2565 (WTR::EventSenderProxy::sendOrQueueEvent):
2566 (WTR::EventSenderProxy::replaySavedEvents):
2568 2011-12-05 Adam Barth <abarth@webkit.org>
2570 [Chromium] Remove no-longer-used forwarding headers in the WebKit API
2571 https://bugs.webkit.org/show_bug.cgi?id=73845
2573 Reviewed by Darin Fisher.
2575 Update includes to point to the new header locations.
2577 * DumpRenderTree/chromium/AccessibilityController.cpp:
2578 * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2579 * DumpRenderTree/chromium/CppBoundClass.cpp:
2580 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2581 * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2582 * DumpRenderTree/chromium/DRTDevToolsClient.h:
2583 * DumpRenderTree/chromium/EventSender.cpp:
2584 * DumpRenderTree/chromium/EventSender.h:
2585 * DumpRenderTree/chromium/GamepadController.h:
2586 * DumpRenderTree/chromium/LayoutTestController.cpp:
2587 * DumpRenderTree/chromium/LayoutTestController.h:
2588 * DumpRenderTree/chromium/MockSpellCheck.cpp:
2589 * DumpRenderTree/chromium/NotificationPresenter.cpp:
2590 * DumpRenderTree/chromium/PlainTextController.cpp:
2591 * DumpRenderTree/chromium/Task.cpp:
2592 * DumpRenderTree/chromium/TestNavigationController.h:
2593 * DumpRenderTree/chromium/TestShell.cpp:
2594 * DumpRenderTree/chromium/TestWebPlugin.cpp:
2595 * DumpRenderTree/chromium/TestWebPlugin.h:
2596 * DumpRenderTree/chromium/TextInputController.cpp:
2597 * DumpRenderTree/chromium/WebPermissions.cpp:
2598 * DumpRenderTree/chromium/WebPreferences.h:
2599 * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2600 * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2601 * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2602 * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2603 * DumpRenderTree/chromium/WebViewHost.cpp:
2605 2011-12-05 Ryosuke Niwa <rniwa@webkit.org>
2607 Add Aharon Lanin to the contributors list.
2609 * Scripts/webkitpy/common/config/committers.py:
2611 2011-12-05 Jarred Nicholls <jarred@sencha.com>
2613 Moving myself from contributors to committers.
2615 * Scripts/webkitpy/common/config/committers.py:
2617 2011-12-05 Raphael Kubo da Costa <kubo@profusion.mobi>
2619 Add myself as a committer.
2621 * Scripts/webkitpy/common/config/committers.py:
2623 2011-12-05 Michael Brüning <michael.bruning@nokia.com>
2625 [Qt] Rename QQuickWebView::canStop property to just loading
2626 https://bugs.webkit.org/show_bug.cgi?id=73813
2628 Reviewed by Kenneth Rohde Christiansen.
2630 Replaced references to WebView.canStop with WebView.loading.
2632 * MiniBrowser/qt/qml/BrowserWindow.qml:
2634 2011-12-05 Dirk Pranke <dpranke@chromium.org>
2636 run-webkit-tests: limit --child-processes properly on apple mac
2637 https://bugs.webkit.org/show_bug.cgi?id=73856
2639 Reviewed by Adam Roben.
2641 Fix typos in r102013 so that we correctly pass --child-processes=1 on
2642 the apple mac bots temporarily.
2644 * Scripts/run-webkit-tests:
2645 (platformIsReadyForParallelTesting):
2647 2011-12-05 Ryosuke Niwa <rniwa@webkit.org>
2649 Temporarily set --child-process=1 on Mac because 20+ tests are timing out
2650 https://bugs.webkit.org/show_bug.cgi?id=73840
2652 Reviewed by Simon Fraser.
2654 Temporarily go back to single process mode on Mac.
2656 * Scripts/run-webkit-tests:
2657 (platformIsReadyForParallelTesting):
2659 2011-12-05 Adam Roben <aroben@apple.com>
2661 Redeploy apple-macpro-7 and apple-xserve-1
2663 These slaves have been sitting idle since we removed our Leopard builders in r97496.
2665 Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
2668 Reviewed by Sam Weinig.
2670 * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
2671 apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
2672 allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
2675 2011-12-05 Kenneth Rohde Christiansen <kenneth@webkit.org>
2677 [Qt] Make the UI of the MiniBrowser slightly nicer
2679 Rubberstamped by Simon Hausmann.
2681 - Add proper padding
2682 - Show feedback when pressing on the toolbar icons
2683 - Make the text entry better looking
2685 * MiniBrowser/qt/qml/BrowserWindow.qml:
2687 2011-12-05 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
2689 NRWT should handle duplicated expectations
2690 https://bugs.webkit.org/show_bug.cgi?id=69750
2692 Reviewed by Dirk Pranke.
2694 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2695 (TestExpectations.__init__):
2696 (TestExpectations._report_errors):
2697 (TestExpectations._add_expectations):
2698 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2699 (test_add_skipped_tests):
2700 * Scripts/webkitpy/layout_tests/port/base.py:
2701 (Port.skipped_tests):
2702 * Scripts/webkitpy/layout_tests/port/webkit.py:
2703 (WebKitPort.test_expectations):
2704 (WebKitPort.skipped_tests):
2705 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2706 (test_test_expectations):
2708 2011-12-04 Eric Seidel <eric@webkit.org>
2710 After success with Mac, Win and Gtk, turning on parallel testing
2711 by default for all platforms (except Qt).
2713 We'll add more platforms to the blacklist if we see problems.
2717 * Scripts/run-webkit-tests:
2718 (platformIsReadyForParallelTesting):
2720 2011-12-04 Sam Weinig <sam@webkit.org>
2722 Add tests for RetainPtr::adoptNS/adoptCF
2723 https://bugs.webkit.org/show_bug.cgi?id=73470
2725 Reviewed by Adam Roben and Darin Adler.
2727 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2728 * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
2729 (TestWebKitAPI::TEST):
2730 Test that adopting using adoptCF creates a RetainPtr with a
2731 value whose retain count is 1.
2733 * TestWebKitAPI/Tests/WTF/ns: Added.
2734 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
2735 (TestWebKitAPI::TEST):
2736 Test that adopting using adoptNS creates a RetainPtr with a
2737 value whose retain count is 1.
2739 2011-12-04 Martin Robinson <mrobinson@igalia.com>
2741 [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
2742 https://bugs.webkit.org/show_bug.cgi?id=73748
2744 Reviewed by Gustavo Noronha Silva.
2746 * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
2748 2011-12-04 Philippe Normand <pnormand@igalia.com>
2750 Another GTK build fix after r101922.
2752 Rubber-stamped by Martin Robinson.
2754 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2755 (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
2757 2011-12-04 Xan Lopez <xlopez@igalia.com>
2759 Fix compiler warning in LayoutTestController
2761 Reviewed by Philippe Normand.
2763 * DumpRenderTree/LayoutTestController.cpp:
2764 (LayoutTestController::LayoutTestController): fix warning.
2766 2011-12-04 Alexandre Mazari <scaroo@gmail.com>
2768 Add missing methods used by fast/notifications tests to LayoutTestController
2769 https://bugs.webkit.org/show_bug.cgi?id=63616
2771 Reviewed by Martin Robinson.
2773 Add missing simulateDesktopNotificationClick method used by
2774 fast/notifications. Provide a default implementation for
2775 areDesktopNotificationPermissionRequestsIgnored and
2776 ignoreDesktopNotificationPermissionRequests.
2778 * DumpRenderTree/LayoutTestController.cpp:
2779 (LayoutTestController::LayoutTestController): call into the port implementation.
2780 (simulateDesktopNotificationClickCallback): ditto.
2781 (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
2782 (LayoutTestController::staticFunctions): declare new methods.
2783 (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
2784 * DumpRenderTree/LayoutTestController.h:
2785 (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
2786 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2787 (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
2788 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2789 (LayoutTestController::simulateDesktopNotificationClick): ditto.
2790 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2791 (LayoutTestController::simulateDesktopNotificationClick): ditto.
2792 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2793 (LayoutTestController::simulateDesktopNotificationClick): ditto.
2794 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2795 (LayoutTestController::simulateDesktopNotificationClick): ditto.
2797 2011-12-03 Mario Sanchez Prada <msanchez@igalia.com>
2799 [GTK] Don't log document events in DRT
2800 https://bugs.webkit.org/show_bug.cgi?id=73746
2802 Reviewed by Martin Robinson.
2804 Stop connecting globally to document-related events.
2806 * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2807 (connectAccessibilityCallbacks): Removed connections.
2808 (disconnectAccessibilityCallbacks): Removed disconnections.
2810 2011-12-03 Dan Bernstein <mitz@apple.com>
2812 Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
2814 Reviewed by Darin Adler.
2816 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2817 * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
2818 (TestWebKitAPI::TEST):
2820 2011-12-03 Philippe Normand <pnormand@igalia.com>
2822 Another GTK build fix after r101922.
2824 Rubber-stamped by Martin James Robinson.
2826 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2827 (LayoutTestController::pathToLocalResource): return value needs to
2830 2011-12-03 Martin Robinson <mrobinson@igalia.com>
2832 Small fix for my previous patch. Do not try to delete a member
2833 of a dictionary that does not exist.
2835 Reviewed by Gustavo Noronha Silva.
2837 * gtk/run-with-jhbuild:
2838 (install_and_run_jhbuild):
2840 2011-12-03 Martin Robinson <mrobinson@igalia.com>
2842 Fix jhbuild installation for people who have unusual MAKE environment
2843 variables such as 'make -j4' as the jhbuild build does not handle it.
2845 Reviewed by Gustavo Noronha Silva.
2847 * gtk/run-with-jhbuild:
2848 (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
2850 2011-12-03 Martin Robinson <mrobinson@igalia.com>
2852 Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
2853 when run for the first time.
2855 Reviewed by Gustavo Noronha Silva.
2857 * Scripts/update-webkitgtk-libs: Fix first run.
2859 2011-12-03 Philippe Normand <pnormand@igalia.com>
2861 Unreviewed, GTK build fix after r101922.
2863 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2864 (LayoutTestController::pathToLocalResource): Added sentinel in
2865 g_build_filename call.
2867 2011-12-03 Philippe Normand <pnormand@igalia.com>
2869 GTK API tests build fix. Run the tests inside jhbuild.
2871 Rubber-stamped by Gustavo Noronha Silva.
2873 * Scripts/run-gtk-tests:
2874 (TestRunner.__init__):
2875 (TestRunner.run._error_handler):
2879 2011-12-03 Martin Robinson <mrobinson@igalia.com>
2881 Small build fix. Properly specify the path to the locally installed jhbuild.
2883 * Scripts/update-webkitgtk-libs: Fix jhbuild path.
2885 2011-12-03 Martin Robinson <mrobinson@igalia.com>
2887 [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2888 https://bugs.webkit.org/show_bug.cgi?id=67256
2890 Reviewed by Philippe Normand.
2892 Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing
2893 WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
2894 which points to the more generic top-level path of the WebKit checkout. This code is
2895 duplicated between WK1 and WK2 harnesses because we do not currently have a way to
2898 If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
2899 location. This will cause the fallback to fail if you build into a non-typical location
2900 or even fake it with a symlink. In this case it's important to use the environment variable.
2902 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2903 (getTopLevelPath): Added.
2904 (initializeFonts): Use the new helper to get the font path.
2905 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
2906 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2907 (LayoutTestController::pathToLocalResource):Use the new helper to normalize
2909 * Scripts/webkitpy/layout_tests/port/gtk.py:
2910 (GtkPort.setup_environ_for_server):Pass the top-level path of the
2911 checkout instead of passing the font path.
2912 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2913 (WTR::getTopLevelPath): Added this helper.
2914 (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
2916 2011-12-02 David Levin <levin@chromium.org>
2918 Rename WTF class from TemporarilyChange to TemporaryChange.
2919 https://bugs.webkit.org/show_bug.cgi?id=73479
2921 Reviewed by Eric Seidel.
2923 * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
2924 * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
2925 * TestWebKitAPI/TestWebKitAPI.gypi:
2926 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2927 * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
2928 (TestWebKitAPI::TEST):
2929 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2931 2011-12-02 Tony Chang <tony@chromium.org>
2933 [NRWT] reftest asserts intermittently on the Qt-WK2 bot
2934 https://bugs.webkit.org/show_bug.cgi?id=73453
2936 Reviewed by Ryosuke Niwa.
2938 We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
2939 The verbose output will include the failure reason.
2941 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
2942 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2943 (write_test_result):
2944 * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
2945 * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
2946 (determine_result_type):
2947 (FailureReftestNoImagesGenerated.__init__):
2948 (FailureReftestNoImagesGenerated):
2949 (FailureReftestNoImagesGenerated.message):
2950 * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
2951 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
2952 (MainTest.test_run_singly_actually_runs_tests):
2953 (MainTest.test_unexpected_failures):
2954 (EndToEndTest.test_end_to_end):
2956 2011-12-02 Ryosuke Niwa <rniwa@webkit.org>
2958 ChangeLog should be able to parse annotated changelogs
2959 https://bugs.webkit.org/show_bug.cgi?id=72703
2961 Reviewed by Eric Seidel.
2963 Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
2964 and extract the revision number for each entry.
2966 Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
2968 * Scripts/webkitpy/common/checkout/changelog.py:
2969 * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2970 * Scripts/webkitpy/common/checkout/scm/git.py:
2971 * Scripts/webkitpy/common/checkout/scm/scm.py:
2972 * Scripts/webkitpy/common/checkout/scm/svn.py:
2974 2011-12-02 Eric Seidel <eric@webkit.org>
2976 Enable parallel testing for Win and Gtk bots
2977 after confirming with Lucas and Martin the bots should be OK.
2979 Unreviewed. (I ran the idea by Lucas and Martin.)
2981 * Scripts/run-webkit-tests:
2982 (platformIsReadyForParallelTesting):
2984 2011-12-02 Martin Robinson <mrobinson@igalia.com>
2986 Try to fix the GTK+ build.
2988 * gtk/jhbuild.modules: Properly specify the glib-networking
2989 dependency for soup.
2991 2011-12-02 Martin Robinson <mrobinson@igalia.com>
2993 Fix a syntax error in the committers.py file.
2995 * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
2997 2011-12-02 Ryosuke Niwa <rniwa@webkit.org>
2999 Add Alan Stearns and Peter Linss to the contributors list.
3001 * Scripts/webkitpy/common/config/committers.py:
3003 2011-12-02 Kent Tamura <tkent@chromium.org>
3005 [Chromium] Fix compilation warnings for ASSERT()
3006 https://bugs.webkit.org/show_bug.cgi?id=73623
3008 Reviewed by Tony Chang.
3010 * DumpRenderTree/chromium/ImageDiff.cpp:
3011 - Fix fprintf format: %s -> %d for __LINE__
3012 - Do nothing for ASSERT() if NDEBUG.
3014 2011-12-02 Eric Seidel <eric@webkit.org>
3016 Enable parallel testing for all Mac bots.
3020 * Scripts/run-webkit-tests:
3021 (platformIsReadyForParallelTesting):
3023 2011-12-02 Eric Seidel <eric@webkit.org>
3025 Enable parallel testing for run-webkit-tests on Mac Lion.
3026 I plan to move all the machines to parallel testing shortly
3027 but we're starting with Lion.
3031 * Scripts/run-webkit-tests:
3032 (platformIsReadyForParallelTesting):
3034 2011-12-02 Kausalya Madhusudhanan <kmadhusu@chromium.org>
3036 Added helper method to identify whether the page has custom page size style.
3037 https://bugs.webkit.org/show_bug.cgi?id=73585
3039 Reviewed by Darin Fisher.
3041 * DumpRenderTree/chromium/LayoutTestController.cpp:
3042 (LayoutTestController::LayoutTestController):
3043 (LayoutTestController::hasCustomPageSizeStyle):
3044 * DumpRenderTree/chromium/LayoutTestController.h:
3046 2011-12-01 Ryosuke Niwa <rniwa@webkit.org>
3048 [NRWT] reftest should support having multiple references per test
3049 https://bugs.webkit.org/show_bug.cgi?id=73613
3051 Reviewed by Dirk Pranke.
3053 Add a support for having multiple reference files for a single test.
3055 Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
3056 at least one of expected mismatches, we compare expected mismatches first in order to minimize
3057 the number of reference files to open on DRT.
3059 * Scripts/webkitpy/layout_tests/controllers/manager.py:
3060 (interpret_test_failures): Remove checks no longer applicable.
3061 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3062 (ResultSummaryTest.test_interpret_test_failures): Ditto.
3063 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3064 (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
3065 (SingleTestRunner._driver_input):
3066 (SingleTestRunner.run):
3067 (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
3068 * Scripts/webkitpy/layout_tests/models/test_input.py:
3069 (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
3070 * Scripts/webkitpy/layout_tests/port/base.py:
3071 (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
3072 (_parse_reftest_list): Now supports parsing multiple entries for a single test.
3073 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3074 (PortTest.test_parse_reftest_list):
3075 * Scripts/webkitpy/layout_tests/port/test.py:
3076 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3077 (MainTest.test_unexpected_failures):
3078 (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
3079 (EndToEndTest.test_end_to_end):
3080 (EndToEndTest.test_reftest_with_two_notrefs): Added.
3082 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
3084 Build libsoup without gnome dependencies (like keyring).
3086 * gtk/jhbuild.modules:
3088 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
3090 Also build gcrypt and p11-kit, and make them dependencies of
3093 * gtk/jhbuild.modules:
3095 2011-12-02 Kevin Ollivier <kevino@theolliviers.com>
3097 [wx] Unreviewed build fixes for Windows build.
3099 * waf/build/wxpresets.py:
3101 2011-12-01 Eric Seidel <eric@webkit.org>
3103 Reviewed by Adam Barth.
3105 webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
3106 https://bugs.webkit.org/show_bug.cgi?id=32006
3108 I decided not to make it warn, and just have it re-open the bug.
3109 That's not that different from today's behavior which will
3110 just silently attach the patch.
3112 This patch makes behavior between upload and land-safely consistent
3113 (previously one would assign patches and the other would not)
3114 as well as adds the ability for both to ensure that the bug is open.
3116 To test this I had to add a few more methods to MockBugzilla which
3117 (positively) affected a few other test results.
3119 I also made AbstractStep keep a cached copy of the Bug object
3120 and used the cached copy where appropriate (including for 'bug_title').
3121 This should reduce the number of bug fetches we perform.
3123 * Scripts/webkitpy/tool/commands/download_unittest.py:
3124 * Scripts/webkitpy/tool/commands/upload.py:
3125 * Scripts/webkitpy/tool/commands/upload_unittest.py:
3126 * Scripts/webkitpy/tool/mocktool.py:
3127 * Scripts/webkitpy/tool/steps/__init__.py:
3128 * Scripts/webkitpy/tool/steps/abstractstep.py:
3129 * Scripts/webkitpy/tool/steps/closebug.py:
3130 * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
3131 * Scripts/webkitpy/tool/steps/postdiff.py:
3132 * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
3133 * Scripts/webkitpy/tool/steps/preparechangelog.py:
3134 * Scripts/webkitpy/tool/steps/steps_unittest.py:
3135 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3137 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
3139 Also pass --no-interact to jhbuild when updating dependencies.
3141 * Scripts/update-webkitgtk-libs:
3143 2011-12-02 Alice Boxhall <aboxhall@chromium.org>
3145 Make _build_path check more thoroughly that build paths exist.
3146 https://bugs.webkit.org/show_bug.cgi?id=73601
3148 Reviewed by Ojan Vafai.
3150 * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3151 (ChromiumMacPort._build_path):
3153 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
3155 Add libffi to the jhbuild modules list as a glib dependency.
3157 Rubber-stamped by Martin Robinson.
3159 * gtk/jhbuild.modules:
3161 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
3163 Build fix. Use internal pcre on glib, make gnutls a dependency of
3164 glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
3165 in non-interactive mode.
3167 * Scripts/update-webkitgtk-libs:
3168 * gtk/jhbuild.modules:
3169 * gtk/run-with-jhbuild:
3171 2011-12-02 Adam Roben <aroben@apple.com>
3175 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3176 (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
3177 in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
3178 searching for "Tests that timed out:" etc. This makes our check less strict, but it
3179 shouldn't matter given the kinds of content we parse.
3181 2011-12-02 Adam Roben <aroben@apple.com>
3183 Fix names of failed/timed out tests in run-api-tests output
3185 Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
3188 We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
3190 Reviewed by Simon Fraser.
3192 * Scripts/run-api-tests:
3193 (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
3196 2011-11-29 Martin Robinson <mrobinson@igalia.com>
3198 [GTK] generate-gtkdoc should respect build type
3199 https://bugs.webkit.org/show_bug.cgi?id=73296
3201 Reviewed by Philippe Normand.
3203 * Scripts/webkitdirs.pm:
3204 (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
3205 * gtk/common.py: If --build is passed give preference to the Debug build directory.
3207 2011-12-02 Tony Chang <tony@chromium.org>
3209 [nrwt] fix wdiff output
3210 https://bugs.webkit.org/show_bug.cgi?id=73604
3212 Reviewed by Adam Barth.
3214 * Scripts/webkitpy/layout_tests/port/base.py:
3216 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3217 (PortTest.test_wdiff_text):
3219 2011-12-02 Adam Roben <aroben@apple.com>
3221 Teach build.webkit.org to display how many unit tests failed or timed out
3223 Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
3226 We now display something like "5 unit tests failed or timed out". Eventually we might want
3227 to split out how many failure vs. timeouts there were.
3229 Reviewed by Darin Adler.
3231 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3232 (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
3233 classes that may want to subclass it.
3234 (RunUnitTests): Changed to inherit from TestWithFailureCount.
3235 (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
3236 timed out:" and "Tests that failed:" lines, if present.
3238 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3240 (StubRemoteCommand):
3241 Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
3243 (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
3244 the test run correctly.
3246 (RunUnitTestsTest.test_no_failures_or_timeouts):
3247 (RunUnitTestsTest.test_one_failure):
3248 (RunUnitTestsTest.test_multiple_failures):
3249 (RunUnitTestsTest.test_one_timeout):
3250 (RunUnitTestsTest.test_multiple_timeouts):
3251 (RunUnitTestsTest.test_multiple_failures_and_timeouts):
3254 2011-12-02 Adam Roben <aroben@apple.com>
3256 Teach prepare-ChangeLog to treat master.cfg as a Python file
3258 Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
3259 in buildbot's master.cfg
3261 Reviewed by Darin Adler.
3263 * Scripts/prepare-ChangeLog:
3264 (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
3267 2011-12-02 Martin Robinson <mrobinson@igalia.com>
3269 [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
3270 https://bugs.webkit.org/show_bug.cgi?id=73669
3272 Reviewed by Gustavo Noronha Silva.
3274 Add a wrapper script that knows how to install jhbuild and also to wrap commands
3275 in the jhbuild shell.
3277 * Scripts/webkitdirs.pm:
3278 (runAutogenForAutotoolsProject): Use the new wrapper script.
3279 (mustReRunAutogen): Ditto.
3280 (buildAutotoolsProject): Ditto.
3281 * Scripts/webkitpy/layout_tests/port/gtk.py:
3282 (GtkDriver.cmd_line): Ditto.
3283 * gtk/run-with-jhbuild: Added.
3285 2011-12-01 Adam Roben <aroben@apple.com>
3287 Teach check-webkit-style how to check the syntax of JSON files
3289 Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3291 I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
3292 patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
3293 2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
3294 been removed, since its output differs by platform.
3296 Reviewed by Darin Adler.
3298 * Scripts/webkitpy/style/checker.py:
3299 (_all_categories): Added JSONChecker's categories to the set of all categories.
3300 (FileType): Added a JSON type. Incremented other types.
3301 (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3302 (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3304 * Scripts/webkitpy/style/checker_unittest.py:
3305 (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3306 (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3308 * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3309 which would have matched our other checkers, because I couldn't figure out how to call
3310 "json.loads" without hitting namespace conflicts.)
3311 (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3312 just the modified lines from a patch.
3313 (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3315 (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3316 try to extract a line number.
3318 * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3319 (MockErrorHandler.__init__):
3320 (MockErrorHandler.turn_off_line_filtering):
3321 (MockErrorHandler.__call__):
3322 Helper class. Copied from xml_unittest.py.
3324 (JSONCheckerTest.test_line_number_from_json_exception): Test the
3325 line_number_from_json_exception helper method.
3327 (JSONCheckerTest.assert_no_error):
3328 (JSONCheckerTest.assert_error):
3329 Helper methods to assert that we did or didn't get an error.
3331 (JSONCheckerTest.mock_handle_style_error): Helper method.
3333 (JSONCheckerTest.test_conflict_marker):
3334 (JSONCheckerTest.test_single_quote):
3335 (JSONCheckerTest.test_init):
3336 (JSONCheckerTest.test_no_error):
3339 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
3341 [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
3342 https://bugs.webkit.org/show_bug.cgi?id=73664
3344 Reviewed by Martin Robinson.
3346 This patch adds our HTTP library and its main dependencies; this
3347 should not affect layout or rendering.
3349 * gtk/jhbuild.modules:
3351 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
3353 [GTK] Also run DumpRenderTree under jhbuild
3354 https://bugs.webkit.org/show_bug.cgi?id=73646
3356 Reviewed by Martin Robinson.
3358 * Scripts/webkitpy/layout_tests/port/gtk.py:
3359 (GtkDriver.cmd_line):
3361 2011-12-02 Hajime Morrita <morrita@chromium.org>
3363 Unreviewed, rolling out r101751 and r101775.
3364 http://trac.webkit.org/changeset/101751
3365 http://trac.webkit.org/changeset/101775
3366 https://bugs.webkit.org/show_bug.cgi?id=73191
3368 breaks Windows build
3370 * DumpRenderTree/chromium/config.h:
3371 * DumpRenderTree/config.h:
3372 * TestWebKitAPI/config.h:
3373 * WebKitTestRunner/config.h:
3375 2011-12-02 Kentaro Hara <haraken@chromium.org>
3377 Move run-bindings-tests implementation to webkitpy/bindings/main.py
3378 https://bugs.webkit.org/show_bug.cgi?id=73619
3380 Reviewed by Adam Barth.
3382 As run-bindings-tests has been growing, this patch just moves its implementation
3383 to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
3385 No change in behavior.
3387 * Scripts/run-bindings-tests:
3389 * Scripts/webkitpy/bindings/__init__.py: Added.
3390 * Scripts/webkitpy/bindings/main.py: Added.
3391 (BindingsTests.__init__):
3392 (BindingsTests.generate_from_idl):
3393 (BindingsTests.generate_supplemental_dependency):
3394 (BindingsTests.detect_changes):
3395 (BindingsTests.run_tests):
3397 2011-12-01 Ilya Tikhonovsky <loislo@chromium.org>
3399 Tools/Scripts: eliminate find_test_files from Port class.
3400 https://bugs.webkit.org/show_bug.cgi?id=73553
3402 rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
3403 I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
3404 Also I'll move _is_test_file() and related functions close to Port.tests().
3406 Reviewed by Dirk Pranke.
3408 * Scripts/webkitpy/layout_tests/port/base.py:
3410 (Port.is_reference_html_file):
3411 (Port._has_supported_extension):
3412 (Port._is_test_file):
3413 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3414 (PortTest.test_find_no_paths_specified):
3415 (PortTest.test_find_one_test):
3416 (PortTest.test_find_glob):
3417 (PortTest.test_find_with_skipped_directories):
3418 (PortTest.test_find_with_skipped_directories_2):
3419 (PortTest.test_is_test_file):
3420 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3421 (_default_tests_paths):
3422 (ChromiumGpuLinuxPort.tests):
3423 (ChromiumGpuCgMacPort.tests):
3424 (ChromiumGpuMacPort.tests):
3425 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3426 (ChromiumGpuTest.test_default_tests_paths.test_paths):
3427 (ChromiumGpuTest.test_default_tests_paths):
3428 (ChromiumGpuTest.test_test_files.test_paths):
3430 (ChromiumGpuTest.test_test_files):
3431 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3432 (get_tests_run.RecordingTestDriver.run_test):
3433 * Scripts/webkitpy/tool/commands/rebaseline.py:
3434 (OptimizeBaselines._optimize_baseline):
3435 (OptimizeBaselines.execute):
3436 (AnalyzeBaselines._analyze_baseline):
3437 (AnalyzeBaselines.execute):
3439 2011-12-01 Hajime Morrita <morrita@chromium.org>
3441 JS_INLINE and WTF_INLINE should be visible from WebCore
3442 https://bugs.webkit.org/show_bug.cgi?id=73191
3444 Reviewed by Kevin Ollivier.
3446 Removed macro definitions which is now provided by Platform.h
3448 * DumpRenderTree/chromium/config.h:
3449 * DumpRenderTree/config.h:
3450 * TestWebKitAPI/config.h:
3451 * WebKitTestRunner/config.h:
3453 2011-12-01 Hayato Ito <hayato@chromium.org>
3455 Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
3456 https://bugs.webkit.org/show_bug.cgi?id=73406
3458 Reviewed by Ryosuke Niwa.
3460 WebKitPort's image_diff uses tolerance='0.1' in default.
3461 When reftests fail, we should use tolerace=0 when diff-ing images.
3463 Since ImageDiff on chromium port doesn't use tolerance value as of now,
3464 this change doesn't affect chromium port's behavior.
3466 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3467 (write_test_result):
3468 * Scripts/webkitpy/layout_tests/port/base.py:
3470 * Scripts/webkitpy/layout_tests/port/chromium.py:
3471 (ChromiumPort.diff_image):
3472 * Scripts/webkitpy/layout_tests/port/test.py:
3473 (TestPort.diff_image):
3474 * Scripts/webkitpy/layout_tests/port/webkit.py:
3475 (WebKitPort.diff_image):
3476 (WebKitPort._start_image_diff_process):
3477 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3478 (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
3480 2011-12-01 Adam Klein <adamk@chromium.org>
3482 Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
3483 https://bugs.webkit.org/show_bug.cgi?id=73599
3485 Reviewed by Ojan Vafai.
3487 * TestResultServer/static-dashboards/builders.js:
3488 * TestResultServer/static-dashboards/dashboard_base.js:
3490 (htmlForTestTypeSwitcher):
3491 * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3492 (testHtmlForTestTypeSwitcherGroup):
3494 2011-12-01 Ryosuke Niwa <rniwa@webkit.org>
3496 Parse reftest.list and extract types of ref tests
3497 https://bugs.webkit.org/show_bug.cgi?id=66837
3499 Reviewed by Dirk Pranke.
3501 Add support for reftest.list to base port.
3503 * Scripts/webkitpy/common/find_files.py:
3505 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3506 (SingleTestRunner.__init__):
3507 * Scripts/webkitpy/layout_tests/port/base.py:
3508 (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
3509 to a dictionary of {test path: ("==" or "!=", reference file path)}
3510 (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
3511 (Port._reference_file_for): Added; obtains the reference file name given a test name.
3512 (Port.is_reftest): Added; Calls _reference_file_for.
3513 (Port.reftest_expected_filename): Calls _reference_file_for.
3514 (Port.reftest_expected_mismatch_filename): Ditto.
3515 (Port.find_test_files):
3516 (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
3517 -expected, -expected-mismach, -ref, or -notref as a reference file.
3519 (_parse_reftest_list): Added.
3520 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3521 (PortTest.test_is_test_file):
3522 (PortTest.test_parse_reftest_list):
3523 * Scripts/webkitpy/layout_tests/port/dryrun.py:
3524 (DryrunDriver.run_test):
3525 * Scripts/webkitpy/layout_tests/port/test.py:
3526 (unit_test_filesystem.add_test_file):
3527 (unit_test_filesystem.add_file):
3528 (unit_test_filesystem):
3529 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3530 (get_tests_run.RecordingTestDriver.run_test):
3531 (MainTest.test_unexpected_failures):
3532 (MainTest.test_missing_and_unexpected_results):
3533 (EndToEndTest.test_end_to_end):
3534 * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3535 (Rebaseliner._compile_rebaselining_tests):
3537 2011-12-01 Sheriff Bot <webkit.review.bot@gmail.com>
3539 Unreviewed, rolling out r101711.
3540 http://trac.webkit.org/changeset/101711
3541 https://bugs.webkit.org/show_bug.cgi?id=73605
3543 Broke 3 webkitpy tests (Requested by rniwa on #webkit).
3545 * Scripts/webkitpy/style/checker.py:
3548 (CheckerDispatcher._file_type):
3549 (CheckerDispatcher._create_checker):
3550 * Scripts/webkitpy/style/checker_unittest.py:
3551 (CheckerDispatcherDispatchTest.assert_checker_cpp):
3552 (CheckerDispatcherDispatchTest.test_cpp_paths):
3553 * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
3554 * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
3556 2011-12-01 Gustavo Noronha Silva <gns@gnome.org>
3558 Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
3560 * Scripts/webkitpy/common/config/watchlist:
3562 2011-12-01 Martin Robinson <mrobinson@igalia.com>
3564 [GTK] Read fonts from the jhbuild root
3565 https://bugs.webkit.org/show_bug.cgi?id=73487
3567 Reviewed by Gustavo Noronha Silva.
3569 Read fonts from the jhbuild root instead of from the system. This will ensure
3570 that all testers use the same fonts instead of leaving this up to luck.
3572 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3573 (initializeFonts): Load fonts from jhbuild root.
3574 * Scripts/webkitpy/layout_tests/port/gtk.py:
3575 (GtkPort.setup_environ_for_server): Pass an environment variable containing
3576 the path to the jhbuild root.
3577 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3578 (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
3580 2011-12-01 Adam Roben <aroben@apple.com>
3582 Teach check-webkit-style how to check the syntax of JSON files
3584 Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3586 Reviewed by Darin Adler.
3588 * Scripts/webkitpy/style/checker.py:
3589 (_all_categories): Added JSONChecker's categories to the set of all categories.
3590 (FileType): Added a JSON type. Incremented other types.
3591 (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3592 (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3594 * Scripts/webkitpy/style/checker_unittest.py:
3595 (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3596 (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3598 * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3599 which would have matched our other checkers, because I couldn't figure out how to call
3600 "json.loads" without hitting namespace conflicts.)
3601 (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3602 just the modified lines from a patch.
3603 (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3605 (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3606 try to extract a line number.
3608 * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3609 (MockErrorHandler.__init__):
3610 (MockErrorHandler.turn_off_line_filtering):
3611 (MockErrorHandler.__call__):
3612 Helper class. Copied from xml_unittest.py.
3614 (JSONCheckerTest.test_line_number_from_json_exception): Test the
3615 line_number_from_json_exception helper method.
3617 (JSONCheckerTest.assert_no_error):
3618 (JSONCheckerTest.assert_error):
3619 Helper methods to assert that we did or didn't get an error.
3621 (JSONCheckerTest.mock_handle_style_error): Helper method.
3623 (JSONCheckerTest.test_conflict_marker):
3624 (JSONCheckerTest.test_single_quote):
3625 (JSONCheckerTest.test_init):
3626 (JSONCheckerTest.test_missing_closing_brace):
3627 (JSONCheckerTest.test_no_error):
3630 2011-12-01 Martin Robinson <mrobinson@igalia.com>
3632 [GTK] Add a helper function to find the current executable's path
3633 https://bugs.webkit.org/show_bug.cgi?id=73473
3635 Reviewed by Gustavo Noronha Silva.
3637 Update MiniBrowser to not pass the binary directory as an environment variable.
3638 This means that you can move the binaries around without it breaking.
3640 * MiniBrowser/gtk/main.c:
3641 (main): No longer set the environment variable.
3642 * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
3643 * WebKitTestRunner/gtk/main.cpp: Ditto.
3645 2011-12-01 Gustavo Noronha Silva <gns@gnome.org>
3647 Unreviewed. Fix bad file =(.
3649 * gtk/jhbuild.modules:
3650 * Scripts/webkitdirs.pm:
3651 (runAutogenForAutotoolsProject):
3653 2011-12-01 Gustavo Noronha Silva <gns@gnome.org>