[jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
2
3         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
4         https://bugs.webkit.org/show_bug.cgi?id=137390
5
6         Reviewed by Carlos Garcia Campos.
7
8         * Scripts/update-webkit-libs-jhbuild:
9
10 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
11
12         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
13         https://bugs.webkit.org/show_bug.cgi?id=137391
14
15         Reviewed by Martin Robinson.
16
17         Add a custom command to only re-generate
18         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
19
20         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
21
22 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
23
24         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
25         https://bugs.webkit.org/show_bug.cgi?id=135502
26
27         Reviewed by Martin Robinson.
28
29         When writing to stdout/stderr fails due to a UnicodeDecodeError
30         exception, try again without encoding the output.
31
32         * gtk/gtkdoc.py:
33         (GTKDoc._run_command):
34
35 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
36
37         Bugzilla status bubble displays an exception showing attachment 175738
38         https://bugs.webkit.org/show_bug.cgi?id=137410
39
40         Reviewed by Tim Horton.
41
42         * QueueStatusServer/app.yaml: Update version.
43
44         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
45         Don't fail even if expected status message is missing.
46
47         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
48         the field in the same way it's defined in QueueStatus table.
49
50 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
51
52         Record latest message in PatchLog for quick access
53         https://bugs.webkit.org/show_bug.cgi?id=137405
54
55         Fixing a typo.
56
57         * QueueStatusServer/app.yaml:
58         * QueueStatusServer/handlers/releasepatch.py:
59
60 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
61
62         Record latest message in PatchLog for quick access
63         https://bugs.webkit.org/show_bug.cgi?id=137405
64
65         Reviewed by Ryosuke Niwa.
66
67         It's no SQL...
68
69         * QueueStatusServer/handlers/releasepatch.py:
70         * QueueStatusServer/handlers/updatestatus.py:
71         * QueueStatusServer/loggers/recordpatchevent.py:
72         * QueueStatusServer/model/patchlog.py:
73
74 2014-10-02  David Farler  <dfarler@apple.com>
75
76         -asan-blacklist option also renamed to generic -fsanitize-blacklist
77         https://bugs.webkit.org/show_bug.cgi?id=137377
78
79         Reviewed by Daniel Bates.
80
81         * asan/asan.xcconfig:
82         -asan-blacklist -> -fsanitize-blacklist
83
84         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
85
86 2014-10-03  Roger Fong  <roger_fong@apple.com>
87
88         [Windows] Include batch size argument to layout tests on Windows.
89
90         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
91         (RunWebKitTests.start): 
92         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
93         These crashes seem to happen on random tests though generally in a spread out fashion.
94         It seems possible that the DRT instance is being clobbered somehow after running too many
95         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
96
97 2014-10-03  Roger Fong  <roger_fong@apple.com>
98
99         [Windows] Settle for 2 chid processes running NRWT on Windows.
100
101         * Scripts/webkitpy/port/win.py:
102         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
103
104 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
105
106         [GTK] Bump up and patch dependencies to allow building for aarch64
107         https://bugs.webkit.org/show_bug.cgi?id=137147
108
109         Reviewed by Martin Robinson.
110
111         The currently used versions of pixman, libffi, librsvg, glib,
112         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
113         and/or build for aarch64, so they are bumped up and patched where
114         necessary. Wherever possible, the same versions and patches were used as
115         for the EFL port bump-up
116         (https://bugs.webkit.org/show_bug.cgi?id=135885).
117
118         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
119         regression by crashing http/tests/media/video-redirect.html . A patch
120         already in upstream fixes that bug.
121
122         This change does not touch xserver, which also needs bumping up, but 
123         will be dealt with later.
124
125         * gtk/jhbuild.modules:
126         Specified versions and patches necessary to correctly build for aarch64.
127         * gtk/patches/gst-events-arent-gstobjects.patch:
128         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
129         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
130         Added. Patches gst-plugins-base to configure correctly for aarch64.
131         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
132         Added. Bumps up config.guess and config.sub in librsvg to recognize
133         aarch64.
134         * gtk/patches/libxml2-2.9.0-dtd.patch:
135         Removed. Not necessary for libxml2 v2.9.1 anymore.
136
137 2014-09-28  Sam Weinig  <sam@webkit.org>
138
139         Remove RefPtrHashMap
140         https://bugs.webkit.org/show_bug.cgi?id=137200
141
142         Reviewed by Darin Adler.
143
144         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
145         (TestWebKitAPI::TEST):
146         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
147         a minimum of refcount churn occurs.
148
149 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
150
151         Remove workarounds for versions of Python before 2.7
152         https://bugs.webkit.org/show_bug.cgi?id=137338
153
154         Reviewed by Csaba Osztrogonác.
155
156         * Scripts/webkitpy/common/system/autoinstall.py:
157         (AutoInstaller._extract_targz):
158         (AutoInstaller._unzip):
159         (AutoInstaller): Deleted.
160         (AutoInstaller._extract_all): Deleted.
161         * Scripts/webkitpy/common/webkitunittest.py:
162         (TestCase.setUp): Deleted.
163         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
164         (TestConfigurationConverter.collapse_macros):
165         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
166         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
167         (TestConfigurationConverter):
168         (TestConfigurationConverter.combinations): Deleted.
169         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
170         * Scripts/webkitpy/port/base.py:
171
172 2014-10-03  Commit Queue  <commit-queue@webkit.org>
173
174         Unreviewed, rolling out r174264.
175         https://bugs.webkit.org/show_bug.cgi?id=137392
176
177         It broke run-webkit-tests (Requested by ebalazsfalvi on
178         #webkit).
179
180         Reverted changeset:
181
182         "Remove workarounds for versions of Python before 2.7"
183         https://bugs.webkit.org/show_bug.cgi?id=137338
184         http://trac.webkit.org/changeset/174264
185
186 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
187
188         Remove workarounds for versions of Python before 2.7
189         https://bugs.webkit.org/show_bug.cgi?id=137338
190
191         Reviewed by Csaba Osztrogonác.
192
193         * Scripts/webkitpy/common/system/autoinstall.py:
194         (AutoInstaller._extract_targz):
195         (AutoInstaller._unzip):
196         (AutoInstaller): Deleted.
197         (AutoInstaller._extract_all): Deleted.
198         * Scripts/webkitpy/common/webkitunittest.py:
199         (TestCase.setUp): Deleted.
200         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
201         (TestConfigurationConverter.collapse_macros):
202         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
203         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
204         (TestConfigurationConverter):
205         (TestConfigurationConverter.combinations): Deleted.
206         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
207         * Scripts/webkitpy/port/base.py:
208         * Scripts/webkitpy/port/driver.py:
209         (ContentBlock.__init__):
210         * Scripts/webkitpy/port/server_process.py:
211         (ServerProcess._reset):
212
213 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
214
215         Remove autoinstaller workaround for python 2.6
216         https://bugs.webkit.org/show_bug.cgi?id=137343
217
218         Reviewed by Daniel Bates.
219
220         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
221         2.6, nor Snow Leopard is supported anymore, so the workaround is not
222         needed anymore.
223
224         * Scripts/webkitpy/common/system/autoinstall.py:
225         (AutoInstaller.install):
226         * Scripts/webkitpy/test/main.py:
227         (Tester._run_tests):
228         * Scripts/webkitpy/thirdparty/__init__.py:
229         (AutoinstallImportHook._install_mechanize):
230         (AutoinstallImportHook._install_pep8):
231         (AutoinstallImportHook._install_pylint):
232         (AutoinstallImportHook._install_buildbot):
233         (AutoinstallImportHook._install_coverage):
234         (AutoinstallImportHook._install_eliza):
235         (AutoinstallImportHook._install_irc):
236         (AutoinstallImportHook._install):
237         (autoinstall_everything):
238
239 2014-10-02  Daniel Bates  <dabates@apple.com>
240
241         Use version number 101000 instead of 10100 for OS X Yosemite
242         https://bugs.webkit.org/show_bug.cgi?id=137372
243
244         Reviewed by Mark Rowe.
245
246         The version number for OS X Yosemite is 101000.
247
248         * DumpRenderTree/mac/TextInputController.m:
249
250 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
251
252         update-work-items should never delete items
253         https://bugs.webkit.org/show_bug.cgi?id=137366
254
255         Reviewed by Ryosuke Niwa.
256
257         As we don't just replace the whole list any more, indicate which items are high
258         priority, and which are not. Hight priority ones will be prepended to the queue,
259         others will be appended.
260
261         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
262         But hopefully we will never have many rollouts competing like that.
263
264         * QueueStatusServer/app.yaml: Update version.
265
266         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
267         priority and regular items separately. Removed some error handling that used to
268         end up in returning status 500 - an uncaught exception does that automatically.
269
270         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
271
272         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
273
274         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
275         priority items.
276
277         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
278         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
279         line that complicated testing.
280
281         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
282
283         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
284         priority items into separate lists.
285
286         * Scripts/webkitpy/common/net/statusserver_mock.py:
287         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
288         * Scripts/webkitpy/tool/commands/queues_unittest.py:
289         Updated tests.
290
291 2014-10-02  Brendan Long  <b.long@cablelabs.com>
292
293         Annoying build warnings in WTFString API tests
294         https://bugs.webkit.org/show_bug.cgi?id=137360
295
296         Reviewed by Darin Adler.
297
298         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
299         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
300
301 2014-10-02  Roger Fong  <roger_fong@apple.com>
302
303         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
304
305         * Scripts/webkitpy/port/win.py:
306         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
307
308 2014-10-02  David Farler  <dfarler@apple.com>
309
310         Move ASan arguments from LLVM (-mllvm) to the frontend
311         https://bugs.webkit.org/show_bug.cgi?id=137365
312
313         Reviewed by David Kilzer.
314
315         * asan/asan.xcconfig:
316         Remove the -mllvm prefix to the asan-blacklist argument, moving it
317         to the clang frontend.
318
319         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
320
321 2014-10-02  Commit Queue  <commit-queue@webkit.org>
322
323         Unreviewed, rolling out r174120.
324         https://bugs.webkit.org/show_bug.cgi?id=137350
325
326         While number of failures is reasonable with 2 processes, test
327         results seem to be inconsistent between runs (Requested by
328         rfong on #webkit).
329
330         Reverted changeset:
331
332         "[Windows] Back to 2 child processes for NRWT on Windows."
333         http://trac.webkit.org/changeset/174120
334
335 2014-10-02  Jeff Miller  <jeffm@apple.com>
336
337         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
338         https://bugs.webkit.org/show_bug.cgi?id=137347
339
340         Reviewed by Dan Bernstein.
341
342         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
343         Use WebKitSystemInterfaceYosemite on OS X 10.10.
344
345         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
346         Ditto.
347
348 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
349
350         [GTK] [JHBuild] Switch sourceware.org mirror to http.
351
352         Unreviewed.
353
354         The ftp access is recently failing to work as expected, and the
355         bots fail to download the file.
356         The same mirror is available via http and seems to work better.
357
358         * gtk/jhbuild.modules:
359
360 2014-10-01  Commit Queue  <commit-queue@webkit.org>
361
362         Unreviewed, rolling out r174185.
363         https://bugs.webkit.org/show_bug.cgi?id=137334
364
365         Patch that adds logging causes webkitpy failures (Requested by
366         rfong on #webkit).
367
368         Reverted changeset:
369
370         "commitqueuetasks_unittest references a non-existent member
371         variable"
372         https://bugs.webkit.org/show_bug.cgi?id=137303
373         http://trac.webkit.org/changeset/174185
374
375 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
376
377         EWS and Commit Queue should know better than to spew 500 failed
378         results in the case of extremely red patches.
379         https://bugs.webkit.org/show_bug.cgi?id=137324
380
381         Reviewed by Alexey Proskuryakov.
382
383         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
384         Adds a check for did_exceed_test_failure_limit.
385         (AbstractEarlyWarningSystem._failing_tests_message):
386         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
387         Alters the task mock to respond properly to
388         results_from_patch_test_run(patch)
389         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
390         * Scripts/webkitpy/tool/commands/queues.py:
391         Adds a check for did_exceed_test_failure_limit.
392         (CommitQueue._failing_tests_message):
393
394 2014-10-01  Daniel Bates  <dabates@apple.com>
395
396         Unreviewed, rolling out r174192.
397
398         Revert the unit test fix in r174192 since we reverted r174187
399         in r174194 due to correctness issues. See
400         <http://webkit.org/b/137329> for more details.
401
402         Reverted changeset:
403
404         "Test fix after r174187"
405         http://trac.webkit.org/changeset/174192
406
407 2014-10-01  Mark Rowe  <mrowe@apple.com>
408
409         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
410
411         Reviewed by Dan Bernstein.
412
413         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
414         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
415         for the LLVM components when on Yosemite.
416
417 2014-10-01  Commit Queue  <commit-queue@webkit.org>
418
419         Unreviewed, rolling out r174187.
420         https://bugs.webkit.org/show_bug.cgi?id=137329
421
422         webkitpy failures, and thorton says the patch is wrong
423         (Requested by dethbakin on #webkit).
424
425         Reverted changeset:
426
427         "[Windows] Increase layout test timeout for Windows following
428         r174162."
429         http://trac.webkit.org/changeset/174187
430
431 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
432
433         Test fix after r174187
434
435         * Scripts/webkitpy/port/win_unittest.py:
436         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
437
438 2014-10-01  Roger Fong  <roger_fong@apple.com>
439
440         [Windows] Increase layout test timeout for Windows following r174162.
441
442         * Scripts/webkitpy/port/win.py:
443         (WinPort.default_timeout_ms):
444
445 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
446
447         commitqueuetasks_unittest references a non-existent member variable
448         when mock-reporting flaky tests.
449         https://bugs.webkit.org/show_bug.cgi?id=137303
450
451         Reviewed by Daniel Bates.
452
453         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
454         (MockCommitQueue.report_flaky_tests):
455         Makes the appropriate name change.
456         (test_simple_flaky_test_failure):
457         Adds a unit test to make sure that the code is excercised.
458
459 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
460
461         EWS is inconclusively spinning forever on a patch that breaks 500+
462         tests
463         https://bugs.webkit.org/show_bug.cgi?id=137223
464
465         Reviewed by Tim Horton.
466
467         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
468         Checks to see whether the tests have exceeded the failure limit, and
469         only spins off another test if they have not exceeded the limit.
470         (PatchAnalysisTask._test_patch):
471
472 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
473
474         Unreviewed, add Katie Madonna as a contributor.
475
476         * Scripts/webkitpy/common/config/contributors.json:
477
478 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
479
480         commitqueuetasks_unittest does not construct FailingTestCommitQueue
481         objects properly in its test cases.
482         https://bugs.webkit.org/show_bug.cgi?id=137281
483
484         Reviewed by Daniel Bates.
485
486         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
487         (FailingTestCommitQueue.test_results):
488         Adds an assert to make FailingTestCommitQueue harder to mis-use.
489         (test_double_flaky_test_failure):
490         Nests the intended test failure strings into one-length lists.
491         (test_red_test_failure):
492         Nests the intended test failure strings into one-length lists.
493
494 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
495
496         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
497         https://bugs.webkit.org/show_bug.cgi?id=136987
498
499         Reviewed by Daniel Bates.
500
501         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
502         Specify the default encoding for all WebKit developers to get consistent results.
503
504 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
505
506         EWS is too eager to say that a patch does not apply to trunk of repository
507         https://bugs.webkit.org/show_bug.cgi?id=137290
508
509         Reviewed by Ryosuke Niwa.
510
511         * QueueStatusServer/app.yaml: Updated app version.
512
513         * QueueStatusServer/handlers/statusbubble.py:
514         (StatusBubble._build_bubble):
515         (StatusBubble._build_bubbles_for_attachment):
516         Rewrote to make more sense.
517
518 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
519
520         Remove thirdparty/unittest2 from webkitpy
521         https://bugs.webkit.org/show_bug.cgi?id=137251
522
523         Reviewed by Brent Fulgham.
524
525         Additionally ordered imports in related webkitpy files and
526         removed unnecessary shebangs from unittest files.
527
528         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
529         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
530         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
531         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
532         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
533         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
534         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
535         * Scripts/webkitpy/common/config/committers_unittest.py:
536         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
537         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
538         * Scripts/webkitpy/common/config/ports_unittest.py:
539         * Scripts/webkitpy/common/config/urls_unittest.py:
540         * Scripts/webkitpy/common/editdistance_unittest.py:
541         * Scripts/webkitpy/common/find_files_unittest.py:
542         * Scripts/webkitpy/common/lru_cache_unittest.py:
543         * Scripts/webkitpy/common/memoized_unittest.py:
544         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
545         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
546         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
547         * Scripts/webkitpy/common/net/credentials_unittest.py:
548         * Scripts/webkitpy/common/net/failuremap_unittest.py:
549         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
550         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
551         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
552         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
553         * Scripts/webkitpy/common/net/statusserver_unittest.py:
554         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
555         * Scripts/webkitpy/common/newstringio_unittest.py:
556         * Scripts/webkitpy/common/prettypatch_unittest.py:
557         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
558         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
559         * Scripts/webkitpy/common/system/environment_unittest.py:
560         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
561         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
562         * Scripts/webkitpy/common/system/executive_unittest.py:
563         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
564         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
565         * Scripts/webkitpy/common/system/filesystem_unittest.py:
566         * Scripts/webkitpy/common/system/logtesting.py:
567         * Scripts/webkitpy/common/system/logutils_unittest.py:
568         * Scripts/webkitpy/common/system/outputcapture.py:
569         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
570         * Scripts/webkitpy/common/system/outputtee_unittest.py:
571         * Scripts/webkitpy/common/system/path_unittest.py:
572         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
573         * Scripts/webkitpy/common/system/profiler_unittest.py:
574         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
575         * Scripts/webkitpy/common/system/user_unittest.py:
576         * Scripts/webkitpy/common/system/workspace_unittest.py:
577         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
578         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
579         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
580         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
581         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
582         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
583         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
584         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
585         * Scripts/webkitpy/common/webkitunittest.py:
586         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
587         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
588         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
589         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
590         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
591         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
592         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
593         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
594         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
595         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
596         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
597         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
598         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
599         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
600         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
601         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
602         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
603         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
604         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
605         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
606         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
607         * Scripts/webkitpy/port/base_unittest.py:
608         * Scripts/webkitpy/port/builders_unittest.py:
609         * Scripts/webkitpy/port/config_unittest.py:
610         * Scripts/webkitpy/port/driver_unittest.py:
611         * Scripts/webkitpy/port/efl_unittest.py:
612         * Scripts/webkitpy/port/factory_unittest.py:
613         * Scripts/webkitpy/port/gtk_unittest.py:
614         * Scripts/webkitpy/port/http_lock_unittest.py:
615         * Scripts/webkitpy/port/image_diff_unittest.py:
616         * Scripts/webkitpy/port/leakdetector_unittest.py:
617         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
618         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
619         * Scripts/webkitpy/port/mock_drt_unittest.py:
620         * Scripts/webkitpy/port/port_testcase.py:
621         * Scripts/webkitpy/port/server_process_unittest.py:
622         * Scripts/webkitpy/port/westondriver_unittest.py:
623         * Scripts/webkitpy/port/win_unittest.py:
624         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
625         * Scripts/webkitpy/style/checker_unittest.py:
626         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
627         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
628         * Scripts/webkitpy/style/checkers/common_unittest.py:
629         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
630         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
631         * Scripts/webkitpy/style/checkers/js_unittest.py:
632         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
633         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
634         * Scripts/webkitpy/style/checkers/png_unittest.py:
635         * Scripts/webkitpy/style/checkers/python_unittest.py:
636         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
637         * Scripts/webkitpy/style/checkers/text_unittest.py:
638         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
639         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
640         * Scripts/webkitpy/style/checkers/xml_unittest.py:
641         * Scripts/webkitpy/style/error_handlers_unittest.py:
642         * Scripts/webkitpy/style/filereader_unittest.py:
643         * Scripts/webkitpy/style/filter_unittest.py:
644         * Scripts/webkitpy/style/main_unittest.py:
645         * Scripts/webkitpy/style/optparser_unittest.py:
646         * Scripts/webkitpy/style/patchreader_unittest.py:
647         * Scripts/webkitpy/test/finder_unittest.py:
648         * Scripts/webkitpy/test/main.py: Ordered imports.
649         * Scripts/webkitpy/test/main_unittest.py:
650         * Scripts/webkitpy/test/printer.py: Ordered imports.
651         (Printer.configure):
652         * Scripts/webkitpy/test/runner_unittest.py:
653         * Scripts/webkitpy/test/skip_unittest.py:
654         * Scripts/webkitpy/thirdparty/__init__.py:
655         (AutoinstallImportHook._install_irc):
656         (AutoinstallImportHook._install_unittest2): Deleted.
657         * Scripts/webkitpy/thirdparty/__init___unittest.py:
658         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
659         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
660         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
661         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
662         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
663         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
664         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
665         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
666         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
667         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
668         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
669         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
670         * Scripts/webkitpy/tool/commands/download_unittest.py:
671         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
672         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
673         * Scripts/webkitpy/tool/commands/queries_unittest.py:
674         * Scripts/webkitpy/tool/commands/queuestest.py:
675         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
676         * Scripts/webkitpy/tool/grammar_unittest.py:
677         * Scripts/webkitpy/tool/mocktool_unittest.py:
678         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
679         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
680         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
681         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
682         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
683         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
684         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
685         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
686         * Scripts/webkitpy/tool/steps/commit_unittest.py:
687         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
688         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
689         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
690         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
691         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
692         * Scripts/webkitpy/tool/steps/steps_unittest.py:
693         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
694         * Scripts/webkitpy/tool/steps/update_unittest.py:
695         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
696         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
697         * Scripts/webkitpy/w3c/test_converter_unittest.py:
698         * Scripts/webkitpy/w3c/test_importer_unittest.py:
699         * Scripts/webkitpy/w3c/test_parser_unittest.py:
700
701 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
702
703         LayoutTestResults and ExpectedFailures should know about the
704         interrupted flag from the json results file
705         https://bugs.webkit.org/show_bug.cgi?id=137229
706
707         Reviewed by Daniel Bates.
708
709         Changes LayoutTestResults to use the interrupted flag instead of
710         counting failures.
711
712         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
713         (BuilderTest._install_fetch_build._mock_fetch_build):
714         (BuilderTest.test_latest_layout_test_results):
715         * Scripts/webkitpy/common/net/layouttestresults.py:
716         Removes notion of failure_limit_count, and adds
717         did_exceed_test_failure_limit.
718
719         (LayoutTestResults.results_from_string):
720         (LayoutTestResults.__init__):
721         (LayoutTestResults.did_exceed_test_failure_limit):
722         (LayoutTestResults): Deleted.
723         (LayoutTestResults.set_failure_limit_count): Deleted.
724         (LayoutTestResults.failure_limit_count): Deleted.
725         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
726         Removes unit test for failure_limit_count logic.
727
728         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
729         * Scripts/webkitpy/common/net/resultsjsonparser.py:
730         Instead of providing a class method that returns a list of
731         TestResults objects, resultsjsonparser now provides a class
732         ParsedJSONResults that serves as an interface between the results.json
733         file and the rest of webkitpy.
734
735         (ParsedJSONResults):
736         (ParsedJSONResults.__init__):
737         (ParsedJSONResults.did_exceed_test_failure_limit):
738         (ParsedJSONResults.test_results):
739         (ResultsJSONParser): Deleted.
740         (ResultsJSONParser.parse_results_json): Deleted.
741         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
742         Updates the unit test so that it can test the new ResultsJSONParser
743         class.
744
745         (ParsedJSONResultsTest):
746         (test_basic):
747         (ResultsJSONParserTest): Deleted.
748         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
749         Updates the unit test to instantiate ResultsJSONParser objects rather
750         than simple lists of TestResult objects.
751
752         (MockCommitQueue.test_results):
753         (FailingTestCommitQueue.test_results):
754         (test_flaky_test_failure):
755         (test_failed_archive):
756         * Scripts/webkitpy/tool/bot/expectedfailures.py:
757         Updates ExpectedFailures to use the did_exceed_test_failure_limit
758         method rather than counting the number of failed tests.
759
760         (ExpectedFailures._should_trust):
761         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
762         Updates MockResults to more closely resemble the updated
763         LayoutTestResults class.
764
765         (MockResults.__init__):
766         (MockResults.did_exceed_test_failure_limit):
767         (ExpectedFailuresTest.test_can_trust_results):
768         (ExpectedFailuresTest.test_unexpected_failures_observed):
769         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
770         (MockResults.failure_limit_count): Deleted.
771         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
772         Removes a FIXME regarding the use of the
773         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
774
775         (LayoutTestResultsReader.results):
776         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
777         Updates test to not check the now-nonexistant failure_count_limit
778         method.
779
780         (test_missing_unit_test_results_path):
781         (test_layout_test_results):
782         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
783         Accounts for name change: ResultsJSONParserTest ->
784         ParsedJSONParserTest.
785
786         (RebaselineTestTest.test_gather_baselines):
787
788 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
789
790         [EFL] Rename TEST_THEME_DIR macro
791         https://bugs.webkit.org/show_bug.cgi?id=137244
792
793         Reviewed by Csaba Osztrogonác.
794
795         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
796         DEFAULT_THEME_DIR is better than it.
797
798         * MiniBrowser/efl/main.c:
799         (window_create):
800         * TestWebKitAPI/efl/PlatformWebView.cpp:
801         (TestWebKitAPI::PlatformWebView::PlatformWebView):
802         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
803         (WTR::PlatformWebView::PlatformWebView):
804
805 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
806
807         Windows EWS went purple when it failed to build
808         https://bugs.webkit.org/show_bug.cgi?id=137267
809
810         Reviewed by Ryosuke Niwa.
811
812         * QueueStatusServer/app.yaml: Update the version.
813
814         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
815         Make it work for style and win-ews queues.
816
817 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
818
819         It should be fun and easy to run every possible JavaScript benchmark from the command line
820         https://bugs.webkit.org/show_bug.cgi?id=137245
821
822         Reviewed by Oliver Hunt.
823         
824         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
825         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
826         having their own private scripts for doing benchmark runs, and didn't share them in the open
827         source community, because of fears about the shady licensing of the benchmarks suites that
828         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
829         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
830         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
831         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
832         but some of them are. The non-public tests are exclusively those that were not made by any
833         WebKit contributor, but which JSC/WebKit devs found useful for testing.
834
835         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
836         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
837         checked into WebKit svn at all) can be run by passing the path to them via a configuration
838         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
839         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
840         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
841         probably never be checked in because there is no license text anywhere in that benchmark.
842         A valid ~/.run-jsc-benchmarks file will just be something like:
843         
844             {
845                 "OctanePath": "/path/to/Octane2",
846                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
847             }
848         
849         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
850         run-jsc-benchmarks will just gracefully avoid running that test suite.
851         
852         Finally, a word about policy: it is understood that different organizations that do
853         development on JSC may find themselves having internal benchmarks that they cannot share
854         because of weird licensing. It happens - usually because the organization doing JSC
855         development found some test in the wild that is owned by someone else and therefore cannot
856         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
857         that add support for some new kind of benchmark suite even if the suite is not made public
858         as part of the same patch - so long as the patch isn't too invasive. An example of
859         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
860         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
861         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
862         completely open-sourced and committed to the WebKit repo - but the reality is that this
863         can't always be done safely.
864
865         * Scripts/bencher: Removed.
866         * Scripts/run-jsc-benchmarks: Added.
867
868 2014-09-30  Roger Fong  <roger_fong@apple.com>
869
870         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
871
872         * Scripts/webkitpy/port/drdiver.py:
873         (Driver.stop):
874         * Scripts/webkitpy/port/server_process.py:
875         (ServerProcess.stop):
876
877 2014-09-30  Roger Fong  <roger_fong@apple.com>
878
879         [Windows] Back to 2 child processes for NRWT on Windows.
880
881         * Scripts/webkitpy/port/win.py:
882         (WinPort.default_child_processes):
883         Changing the number of processes to 1 did not have an effect on the layout test results. 
884         It does introduce an issue with one of the workers hanging indefinitely and causing the 
885         layout tests to timeout as a whole occasionally, but we should just fix that.
886
887 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
888
889         Remove an accidentally committed line..
890
891         * QueueStatusServer/handlers/statusbubble.py:
892         (StatusBubble._build_bubble):
893
894 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
895
896         build.webkit.org/dashboard: Switch EWS view to using actual retry count
897         https://bugs.webkit.org/show_bug.cgi?id=137240
898
899         Reviewed by Ryosuke Niwa.
900
901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
902         (EWSQueue.prototype.loadDetailedStatus):
903         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
904         (EWSQueueView.prototype._popoverContentForEWSQueue):
905         Use the new retry_count data member from JSON.
906
907         * QueueStatusServer/app.yaml: Updating the version.
908
909         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
910         Instead of message_count, produce retry_count.
911
912 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
913
914         EWS doesn't need to show all the bubbles when a patch fails to apply
915         https://bugs.webkit.org/show_bug.cgi?id=137256
916
917         Reviewed by Ryosuke Niwa.
918
919         * QueueStatusServer/app.yaml: Updated app version.
920
921         * QueueStatusServer/handlers/statusbubble.py:
922         (StatusBubble._build_bubble):
923         (StatusBubble._build_bubbles_for_attachment):
924         (StatusBubble.get):
925         * QueueStatusServer/templates/statusbubble.html:
926         When some queues fail to apply, and no queues had meaningful output (meaning that
927         they will almost certainly fail to apply later), we can show a single bubble
928         telling the user just that.
929
930 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
931
932         [EFL] Bump EFL version to 1.11.2
933         https://bugs.webkit.org/show_bug.cgi?id=137118
934
935         Reviewed by Gyuyoung Kim.
936
937         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
938         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
939
940         * efl/jhbuild.modules:
941         * efl/patches/ecore.patch: Removed.
942
943 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
944
945         REGRESSION(r173929): [GTK] TestInspector fails after r173929
946         https://bugs.webkit.org/show_bug.cgi?id=137247
947
948         Reviewed by Philippe Normand.
949
950         Wait until can-attach property changes before trying to attach the
951         inspector after resizing the view.
952
953         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
954         (testInspectorDefault):
955
956 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
957
958         Require Python 2.7 version
959         https://bugs.webkit.org/show_bug.cgi?id=137112
960
961         Reviewed by Csaba Osztrogonác.
962
963         * Scripts/ensure-valid-python:
964         (checkPythonVersion):
965         * Scripts/webkitpy/common/version_check.py:
966
967 2014-09-30  Martin Hock  <mhock@apple.com>
968
969         Skip a JSC test after r174036.
970         https://bugs.webkit.org/show_bug.cgi?id=137236
971
972         Reviewed by Csaba Osztrogonác.
973
974         * Scripts/run-javascriptcore-tests:
975
976 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
977
978         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
979         https://bugs.webkit.org/show_bug.cgi?id=137212
980
981         This moves TestNetscapePlugin to a new folder (lib/plugins).
982         We should not use the same directory for TestNetscapePlugin and
983         the other libraries, because we end up scanning all the .so in the
984         lib dir for every test.
985
986         Reviewed by Carlos Garcia Campos.
987
988         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
989         * Scripts/webkitpy/port/efl.py:
990         (EflPort.setup_environ_for_server): Update plugin path.
991         * Scripts/webkitpy/port/gtk.py:
992         (GtkPort.setup_environ_for_server): Update plugin path.
993         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
994
995 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
996
997         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
998
999         Rubber-stamped by Tim Horton.
1000
1001         * QueueStatusServer/app.yaml:
1002         * QueueStatusServer/handlers/statusbubble.py:
1003         (StatusBubble._build_bubble):
1004
1005 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1006
1007         Typo fix, suggested by Tim Horton.
1008
1009         * QueueStatusServer/handlers/statusbubble.py:
1010         (StatusBubble._build_message_for_provisional_failure):
1011
1012 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1013
1014         Improve Bugzilla status bubbles
1015         https://bugs.webkit.org/show_bug.cgi?id=137232
1016
1017         Reviewed by Ryosuke Niwa.
1018
1019         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
1020
1021         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
1022         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
1023         that are stuck, as it was only confusing that they disappeared after 99.
1024
1025         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
1026         by old bubbles. We need a lot more information to determine color, so the implementation
1027         can not be here.
1028
1029         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
1030         always have a link for consistency. Added code to convert timestamps in tooltips
1031         to local time zone.
1032
1033 2014-09-29  Commit Queue  <commit-queue@webkit.org>
1034
1035         Unreviewed, rolling out r174045.
1036         https://bugs.webkit.org/show_bug.cgi?id=137231
1037
1038         Introduced a crash during page loading tests on Mac (Requested
1039         by rniwa on #webkit).
1040
1041         Reverted changeset:
1042
1043         "Replace OSObjectPtr with RetainPtr/adoptOS"
1044         https://bugs.webkit.org/show_bug.cgi?id=137158
1045         http://trac.webkit.org/changeset/174045
1046
1047 2014-09-29  Tim Horton  <timothy_horton@apple.com>
1048
1049         Add Jake as a contributor.
1050
1051         * Scripts/webkitpy/common/config/contributors.json:
1052
1053 2014-09-29  Roger Fong  <roger_fong@apple.com>
1054
1055         [Windows] Skip a javascriptcore test following r174036.
1056
1057         * Scripts/run-javascriptcore-tests:
1058
1059 2014-09-29  Roger Fong  <roger_fong@apple.com>
1060
1061         [Windows] Reduce number of processes used by NRWT on Windows to 1.
1062
1063         * Scripts/webkitpy/port/win.py:
1064         (WinPort.default_child_processes):
1065         Reduce number of processes to 1 so we can get a good baseline for what failures
1066         we should be expecting to see from the Windows bots.
1067
1068 2014-09-29  Darin Adler  <darin@apple.com>
1069
1070         Tweak and tighten SVG font converter
1071         https://bugs.webkit.org/show_bug.cgi?id=136956
1072
1073         Reviewed by Myles Maxfield.
1074
1075         I was investigating behavior of String::toInt, String::toDouble, and
1076         String::toFloat for various failure cases, and decided to start some
1077         unit tests for those functions here.
1078
1079         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1080         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
1081         StringToDouble testing.
1082
1083 2014-09-29  Philippe Normand  <pnormand@igalia.com>
1084
1085         [GTK][CMake] TestWebCore target build sometimes fail
1086         https://bugs.webkit.org/show_bug.cgi?id=137207
1087
1088         Reviewed by Csaba Osztrogon.
1089
1090         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
1091         headers are generated before the TestWebCore target is built.
1092
1093 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1094
1095         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
1096         https://bugs.webkit.org/show_bug.cgi?id=137209
1097
1098         Reviewed by Philippe Normand.
1099
1100         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
1101         from the WebCore test sources.
1102
1103 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
1104
1105         Allow webkit-patch upload to respect the --directory argument with git checkouts
1106         https://bugs.webkit.org/show_bug.cgi?id=137166
1107
1108         Reviewed by Darin Adler.
1109
1110         We simply hadn't plumbed it through.
1111
1112         * Scripts/webkitpy/common/checkout/scm/detection.py:
1113         (SCMDetector.detect_scm_system):
1114         * Scripts/webkitpy/common/checkout/scm/git.py:
1115         (Git.__init__):
1116         (Git.changed_files):
1117
1118 2014-09-26  Sam Weinig  <sam@webkit.org>
1119
1120         Replace OSObjectPtr with RetainPtr/adoptOS
1121         https://bugs.webkit.org/show_bug.cgi?id=137158
1122
1123         Reviewed by Dan Bernstein.
1124
1125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1126         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
1127         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
1128         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
1129
1130 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
1131
1132         Disable function.arguments
1133         https://bugs.webkit.org/show_bug.cgi?id=137167
1134
1135         Rubber stamped by Geoffrey Garen
1136         
1137         Enable the feature by default during tests.
1138
1139         * Scripts/run-jsc-stress-tests:
1140
1141 2014-09-26  Beth Dakin  <bdakin@apple.com>
1142
1143         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
1144         https://bugs.webkit.org/show_bug.cgi?id=137089
1145
1146         Reviewed by Tim Horton.
1147
1148         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
1149         tests run at 1x, but that code does not seem to execute at the right time for 
1150         these tests, so if we just ensure we start out at 1x, that appears to fix these 
1151         tests and does not break the HiDPI tests either.
1152         * WebKitTestRunner/TestController.cpp:
1153         (WTR::TestController::createWebViewWithOptions):
1154
1155 2014-09-26  Roger Fong  <roger_fong@apple.com>
1156
1157         [Windows] Decrease default number of child processes used by Windows.
1158
1159         * Scripts/webkitpy/port/win.py:
1160         (WinPort.default_child_processes):
1161         Having too many seems to cause many tests to crash or timeout. 
1162         We may even need to make it have only 1 child process if we’re still seeing problems after this.
1163
1164 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1165
1166         Mac EWS bots do not keep logs as promised
1167         https://bugs.webkit.org/show_bug.cgi?id=137151
1168
1169         Reviewed by Ryosuke Niwa.
1170
1171         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
1172
1173 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1174
1175         Get rid of webkit-queues dashboard
1176         https://bugs.webkit.org/show_bug.cgi?id=137141
1177
1178         Reviewed by Ryosuke Niwa.
1179
1180         * QueueStatusServer/app.yaml: Updated version.
1181
1182         * QueueStatusServer/templates/dashboard.html: Removed.
1183         * QueueStatusServer/handlers/dashboard.py: Removed.
1184         * QueueStatusServer/main.py:
1185         Kill it!
1186
1187         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
1188         (.status-cell): Deleted.
1189         (.status-cell:hover): Deleted.
1190         (.status-cell.pass): Deleted.
1191         (.status-cell.fail): Deleted.
1192         (.status-cell.pending): Deleted.
1193         (.status-cell.error): Deleted.
1194         * QueueStatusServer/stylesheets/dashboard.css: Removed.
1195         * QueueStatusServer/templates/activebots.html:
1196         * QueueStatusServer/templates/patch.html:
1197         * QueueStatusServer/templates/queuestatus.html:
1198         * QueueStatusServer/templates/recentstatus.html:
1199         Renamed dashboard.css to common.css, and removed dashboard-only rules.
1200
1201 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1202
1203         Get rid of Retry status in webkit-queues
1204         https://bugs.webkit.org/show_bug.cgi?id=137135
1205
1206         Reviewed by Ryosuke Niwa.
1207
1208         * QueueStatusServer/config/messages.py: Removed Retry.
1209
1210         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
1211         no longer needs to check the latest status. It just always both unlocks the patch
1212         and removes it from WorkItems.
1213
1214         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
1215         I don't understand why we even needed to check for retries here, but now that there
1216         are no retries, that code can go to /dev/null.
1217
1218         * QueueStatusServer/loggers/recordpatchevent.py:
1219         (RecordPatchEvent.started):
1220         (RecordPatchEvent.retrying): Deleted.
1221         Fixed retry counting, it should work for all queues now.
1222
1223         * QueueStatusServer/model/queuestatus.py:
1224         (QueueStatus.is_retry_request): Deleted. These are no more.
1225
1226         * Scripts/webkitpy/common/net/statusserver_mock.py:
1227         (MockStatusServer.release_lock):
1228         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1229         Did whatever it took to keep passing the tests. The particular test doesn't seem
1230         quite right, but whatever.
1231
1232         * Scripts/webkitpy/tool/commands/queues.py:
1233         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
1234         and let others pick up. Also, added explicit returns for clarity.
1235         (AbstractPatchQueue._did_retry): Deleted.
1236
1237 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1238
1239         [EFL] Fix the gst-libav build on ARM Thumb2
1240         https://bugs.webkit.org/show_bug.cgi?id=137022
1241
1242         Reviewed by Zoltan Herczeg.
1243
1244         * efl/jhbuild.modules:
1245         * efl/patches/gst-libav.patch: Added.
1246
1247 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
1248
1249         [EFL] Bump up dependencies not to conflict with the GTK port.
1250         https://bugs.webkit.org/show_bug.cgi?id=137143
1251
1252         Reviewed by Gyuyoung Kim.
1253
1254         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
1255         installing and removing different versions of libgnutls-dev, thus
1256         hindering the development for both ports on the same machine. GTK is
1257         using the newer version of the package, now bumping up EFL to use the 
1258         same.
1259
1260         * efl/install-dependencies:
1261
1262 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
1263
1264         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
1265         https://bugs.webkit.org/show_bug.cgi?id=136854
1266
1267         Reviewed by Gyuyoung Kim.
1268
1269         'Escape' key should exit fullscreen first and then should be used to stop page load.
1270
1271         * MiniBrowser/efl/main.c:
1272         (on_key_down):
1273
1274 2014-09-25  Dean Jackson  <dino@apple.com>
1275
1276         Add Said to the contributors list so his name completes in bugzilla.
1277
1278         * Scripts/webkitpy/common/config/contributors.json:
1279
1280 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
1281
1282         EWS only repeats its cycle every two hours
1283         https://bugs.webkit.org/show_bug.cgi?id=137129
1284
1285         Reviewed by Ryosuke Niwa.
1286
1287         * QueueStatusServer/app.yaml: Updated version.
1288
1289         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
1290
1291         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
1292         the patch from work items.
1293
1294         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
1295
1296         * QueueStatusServer/main.py: Added release-lock.
1297
1298         * QueueStatusServer/model/activeworkitems.py:
1299         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
1300
1301         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
1302         we don't want it to be immediately picked up again, it's better to give other patches
1303         a chance.
1304
1305         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
1306         these interactive versions, but OK.
1307
1308         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
1309         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
1310         or svn is down).
1311
1312         * Scripts/webkitpy/tool/commands/queues.py:
1313         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
1314         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
1315         meaning that these handlers could never do the right thing. We'd either get a duplicate
1316         _did_fail, or try to unlock an already unlocked patch.
1317         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
1318         making it eligible for retry immediately.
1319
1320         * Scripts/webkitpy/common/net/statusserver.py:
1321         (StatusServer._post_release_lock):
1322         (StatusServer.release_lock):
1323         Added a call to release-lock.
1324
1325 2014-09-25  Roger Fong  <roger_fong@apple.com>
1326
1327         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
1328
1329         * Scripts/webkitpy/common/system/path.py:
1330         (_CygPath.convert):
1331
1332 2014-09-25  Roger Fong  <roger_fong@apple.com>
1333
1334         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
1335
1336         * Scripts/webkitpy/common/system/path.py:
1337         (_CygPath.convert):
1338
1339 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1340
1341         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
1342         https://bugs.webkit.org/show_bug.cgi?id=136377
1343
1344         Reviewed by Philippe Normand.
1345
1346         * Scripts/webkitdirs.pm:
1347         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
1348
1349 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
1350
1351         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
1352         https://bugs.webkit.org/show_bug.cgi?id=137117
1353
1354         Tools/efl/install-dependencies relies on apt-get to install packages.
1355         Unfortunately, if a package does not exist (e.g., for a given
1356         architecture) then apt-get install is not able to ignore the missing
1357         package and install the rest but fails to run entirely (and there
1358         seems to be no intent to change this behaviour).
1359
1360         On ARM64, the luajit package is missing and currently it needs manual
1361         editing of install-dependencies to get the script install as much as it
1362         can.
1363
1364         This patch separates the installation of the universally available
1365         packages from those which might not be available for all architectures.
1366
1367         Reviewed by Gyuyoung Kim.
1368
1369         * efl/install-dependencies:
1370
1371 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
1372
1373         Remove WinCE port from trunk
1374         https://bugs.webkit.org/show_bug.cgi?id=136951
1375
1376         Reviewed by Alex Christensen.
1377
1378         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1379         (_should_file_trigger_build):
1380         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1381         (ShouldBuildTest):
1382         * CMakeLists.txt:
1383         * DumpRenderTree/win/DRTDataObject.cpp:
1384         (DRTDataObject::CopyMedium):
1385         * Scripts/build-webkit:
1386         * Scripts/webkit-build-directory:
1387         * Scripts/webkitdirs.pm:
1388         (argumentsForConfiguration):
1389         (builtDylibPathForName):
1390         (isAppleWinWebKit):
1391         (launcherPath):
1392         (launcherName):
1393         (shouldRemoveCMakeCache):
1394         (cmakeBasedPortArguments):
1395         (cmakeBasedPortName):
1396         (isCMakeBuild):
1397         (isWinCE): Deleted.
1398         (determineIsWinCE): Deleted.
1399         * Scripts/webkitperl/FeatureList.pm:
1400         * Scripts/webkitpy/port/port_testcase.py:
1401         (test_apache_config_file_name_for_platform):
1402         * TestWebKitAPI/config.h:
1403         * WinCELauncher/CMakeLists.txt: Removed.
1404         * WinCELauncher/main.cpp: Removed.
1405         * gtk/manifest.txt:
1406
1407 2014-09-23  David Farler  <dfarler@apple.com>
1408
1409         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
1410         https://bugs.webkit.org/show_bug.cgi?id=136895
1411
1412         Reviewed by David Kilzer.
1413
1414         Create Device, DeviceType, and Runtime data classes.
1415         Create Simulator class represent simctl output.
1416
1417         Wherever possible, use structured data classes anywhere a raw
1418         identifier or UDID string was used for a cleaner implementation
1419         and to encapsulate the inherent fragility of scraping simctl output.
1420
1421         Create a suitably named testing device if one doesn't exist.
1422
1423         Finally, accurately handle having multiple simulator runtimes (SDKs)
1424         installed in the active Xcode.app bundle.
1425
1426         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1427         (_set_up_derived_options):
1428         * Scripts/webkitpy/port/driver.py:
1429         (IOSSimulatorDriver.cmd_line):
1430         Construct DeviceType and Runtime objects from identifiers passed at the
1431         command line, still providing sensible defaults for 32- and 64-bit testing.
1432         * Scripts/webkitpy/port/ios.py:
1433         (IOSSimulatorPort.__init__):
1434         (IOSSimulatorPort.setup_test_run):
1435         (IOSSimulatorPort):
1436         (IOSSimulatorPort.testing_device):
1437         Cache the testing device once it is created or found.
1438         (IOSSimulatorPort.reset_preferences):
1439         Get the device path from the Device object instead of consructing it
1440         in the port class.
1441         (IOSSimulatorPort.simulator_udid): Deleted.
1442         Get the UDID from the testing_device :: Device object itself.
1443         * Scripts/webkitpy/xcode/simulator.py:
1444         Created Device, DeviceType, Runtime, and Simulator classes.
1445         (get_runtimes): Deleted.
1446         (get_devices): Deleted.
1447         (get_device_types): Deleted.
1448         (get_latest_runtime): Deleted.
1449
1450 2014-09-24  Roger Fong  <roger_fong@apple.com>
1451
1452         [Windows] Tentative fix for Windows test bots.
1453
1454         * Scripts/webkitpy/common/system/path.py:
1455         (_CygPath.convert):
1456
1457 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
1458
1459         Change more build.webkit.org links to https
1460         https://bugs.webkit.org/show_bug.cgi?id=137049
1461
1462         Reviewed by Csaba Osztrogonác.
1463
1464         Fix appspot, svn.webkit.org and Trac links.
1465
1466         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1467         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
1468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1470         (ViewController.prototype._domForBuildName):
1471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1473         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1474         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1475         (.):
1476         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1477         (EWS):
1478         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1479         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
1480         (TestHistory):
1481         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1482
1483 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
1484
1485         Update the list of u-szeged contributors.
1486
1487         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
1488
1489         * Scripts/webkitpy/common/config/contributors.json:
1490
1491 2014-09-23  Roger Fong  <roger_fong@apple.com>
1492
1493         [Windows] More debugging for the Windows bots.
1494
1495         * Scripts/webkitpy/common/system/path.py:
1496         (_CygPath):
1497
1498 2014-09-23  Roger Fong  <roger_fong@apple.com>
1499
1500         Unreviewed. Fix for r173899, those tabs should be spaces.
1501
1502         * Scripts/webkitpy/port/driver.py:
1503         (Driver._command_from_driver_input):
1504         (Driver): Deleted.
1505
1506 2014-09-23  Roger Fong  <roger_fong@apple.com>
1507
1508         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
1509
1510         * Scripts/webkitpy/port/driver.py:
1511         (Driver):
1512
1513 2014-09-23  Jer Noble  <jer.noble@apple.com>
1514
1515         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
1516         https://bugs.webkit.org/show_bug.cgi?id=137031
1517
1518         Reviewed by Joseph Pecoraro.
1519
1520         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
1521         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
1522         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
1523         ChangeLog locations before passing them to createCommitMessage().
1524
1525         * Scripts/commit-log-editor:
1526
1527 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1528
1529         W3C test importer should detect manual and reference tests according their filenames
1530         https://bugs.webkit.org/show_bug.cgi?id=133852
1531
1532         Reviewed by Bem Jones-Bey.
1533
1534         * Scripts/webkitpy/w3c/test_parser.py:
1535         (TestParser.analyze_test): Adding checks based on WPT filename rules.
1536         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
1537         (TestParser):
1538         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
1539         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
1540         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1541         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
1542
1543 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
1544
1545         Unreviewed, add Rebecca Hauck as a contributor.
1546
1547         * Scripts/webkitpy/common/config/contributors.json:
1548
1549 2014-09-23  David Kilzer  <ddkilzer@apple.com>
1550
1551         Switch build.webkit.org URLs to https
1552
1553         Reviewed by Lucas Forschler and Alexey Proskuryakov.
1554
1555         * TestResultServer/app.yaml: Update version to this commit
1556         revision.
1557
1558         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1559         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1560         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1561         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
1562         (WebKitBuildbot):
1563         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1564         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1565         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1566         (.):
1567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1568         (WebKitBuildbot):
1569         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1570         * Scripts/webkitpy/common/config/urls.py:
1571         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1572         (test_builder_with_name):
1573         * Scripts/webkitpy/tool/commands/queries.py:
1574         (TreeStatus):
1575         * TestResultServer/generate_builders_json.py:
1576         (main):
1577         * TestResultServer/generate_builders_json_unittest.py:
1578         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
1579         (GenerateBuildersJsonTest):
1580         (GenerateBuildersJsonTest.test_generate_json_data):
1581         * TestResultServer/static-dashboards/builders.jsonp:
1582         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1583         (loadExpectationsLayoutTests):
1584         * TestResultServer/static-dashboards/timeline_explorer.js:
1585
1586 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1587
1588         W3C test importer should copy .htaccess files
1589         https://bugs.webkit.org/show_bug.cgi?id=136850
1590
1591         Reviewed by Bem Jones-Bey.
1592
1593         * Scripts/webkitpy/w3c/test_importer.py:
1594         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
1595         (TestImporter):
1596         (TestImporter.find_importable_tests): Making use of new helper function.
1597
1598 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
1599
1600         Trying to revive bot watcher's dashboard after HSTS.
1601
1602         Unreviewed.
1603
1604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1605         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
1606
1607 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1608
1609         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
1610         https://bugs.webkit.org/show_bug.cgi?id=137026
1611
1612         Reviewed by Csaba Osztrogonác.
1613
1614         * BuildSlaveSupport/wait-for-SVN-server.py:
1615         (getLatestSVNRevision):
1616         (waitForSVNRevision):
1617
1618 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1619
1620         Remove unlinkZeroFiles from build-webkit
1621         https://bugs.webkit.org/show_bug.cgi?id=137018
1622
1623         Reviewed by Csaba Osztrogonác.
1624
1625         * Scripts/build-webkit:
1626         (unlinkZeroFiles): Deleted.
1627
1628 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
1629
1630         [GTK] Minibrowser : Add keyboard support for stop page load
1631         https://bugs.webkit.org/show_bug.cgi?id=136857
1632
1633         Reviewed by Philippe Normand.
1634
1635         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
1636
1637         * MiniBrowser/gtk/BrowserWindow.c:
1638         (stopPageLoad): Callback to stop page load.
1639         (browser_window_init):
1640
1641 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
1642
1643         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
1644         https://bugs.webkit.org/show_bug.cgi?id=136813
1645
1646         Reviewed by Gyuyoung Kim.
1647
1648         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
1649
1650         * MiniBrowser/efl/main.c:
1651         (on_key_down):
1652
1653 2014-09-22  Daniel Bates  <dabates@apple.com>
1654
1655         [Cocoa] Add UI delegate callback when window.close() is called
1656         https://bugs.webkit.org/show_bug.cgi?id=137008
1657         <rdar://problem/17801001>
1658
1659         Reviewed by Anders Carlsson.
1660
1661         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
1662         for window opened via JavaScript (i.e. window.open()).
1663
1664         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1665         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
1666         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
1667
1668 2014-09-22  Youenn Fablet  <youennf@gmail.com>
1669
1670         W3C importer should import html files within resources folders
1671         https://bugs.webkit.org/show_bug.cgi?id=127548
1672
1673         Reviewed by Ryosuke Niwa.
1674         
1675         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
1676
1677         * Scripts/webkitpy/w3c/test_importer.py:
1678         (TestImporter.find_importable_tests):
1679
1680 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1681
1682         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
1683         https://bugs.webkit.org/show_bug.cgi?id=136998
1684
1685         Reviewed by Philippe Normand.
1686
1687         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1688         (testWebViewCanShowMIMEType): Remove the check of PDF as
1689         unsupported MIME type.
1690
1691 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1692
1693         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
1694
1695         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
1696         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
1697
1698         * Scripts/webkitpy/common/config/watchlist: Use
1699         Source/WebCore/platform/gtk/po/ as directory to watch for
1700         WebKitGTKTranslations rule and add berto and myself to the list of
1701         watchers.
1702
1703 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
1704
1705         Fix syntaxError in watchlist since r173594
1706         https://bugs.webkit.org/show_bug.cgi?id=136996
1707
1708         Reviewed by Philippe Normand.
1709
1710         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
1711
1712 2014-09-20  Sam Weinig  <sam@webkit.org>
1713
1714         Make possible HashSet<std::unique_ptr<>>
1715         https://bugs.webkit.org/show_bug.cgi?id=136166
1716
1717         Reviewed by Darin Adler.
1718
1719         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
1720         * TestWebKitAPI/Counters.cpp: Added.
1721         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
1722         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
1723         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
1724         translation unit.
1725     
1726         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1727         Add new files.
1728
1729         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1730         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
1731
1732         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1733         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
1734
1735 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1736
1737         run-webkit-tests should count tests submitted as absolute paths once
1738         https://bugs.webkit.org/show_bug.cgi?id=136848
1739
1740         Reviewed by Darin Adler.
1741
1742         * Scripts/webkitpy/port/base.py:
1743         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
1744
1745 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
1746
1747         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
1748         https://bugs.webkit.org/show_bug.cgi?id=136974
1749
1750         Reviewed by Chris Fleizach.
1751
1752         * DumpRenderTree/AccessibilityUIElement.cpp:
1753         (selectTextWithCriteriaCallback):
1754         Be sure to release the string if it was allocated.
1755
1756 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
1757
1758         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
1759         https://bugs.webkit.org/show_bug.cgi?id=136966
1760
1761         Reviewed by Daniel Bates.
1762
1763         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1764         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
1765
1766 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1767
1768         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
1769         https://bugs.webkit.org/show_bug.cgi?id=136917
1770
1771         Reviewed by Darin Adler.
1772
1773         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
1774
1775         * TestWebKitAPI/PlatformEfl.cmake:
1776         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
1777         (TestWebKitAPI::didFinishLoadForFrame):
1778         (TestWebKitAPI::TEST):
1779         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
1780
1781 2014-09-19  Daniel Bates  <dabates@apple.com>
1782
1783         Always assume internal SDK when building configuration Production
1784         https://bugs.webkit.org/show_bug.cgi?id=136925
1785         <rdar://problem/18362399>
1786
1787         Reviewed by Dan Bernstein.
1788
1789         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1790         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1791         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1792         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1793
1794 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1795
1796         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
1797         https://bugs.webkit.org/show_bug.cgi?id=136847
1798
1799         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
1800
1801         Reviewed by Alexey Proskuryakov.
1802
1803         * WebKitTestRunner/TestController.cpp:
1804         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
1805
1806 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1807
1808         [GTK] Missing inspector files in the tarball
1809         https://bugs.webkit.org/show_bug.cgi?id=136952
1810
1811         Reviewed by Gustavo Noronha Silva.
1812
1813         * gtk/manifest.txt: Add
1814         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
1815         to the tarball.
1816
1817 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1818
1819         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
1820         https://bugs.webkit.org/show_bug.cgi?id=136632
1821
1822         Reviewed by Gustavo Noronha Silva.
1823
1824         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
1825         the gtk icons.
1826         * gtk/manifest.txt: Only include the free icons in the tarball.
1827
1828 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1829
1830         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
1831         https://bugs.webkit.org/show_bug.cgi?id=136943
1832
1833         Reviewed by Philippe Normand.
1834
1835         Update the script to receive the list of files from the command
1836         line instead of scanning the given directories.
1837
1838         * gtk/generate-inspector-gresource-manifest.py:
1839         (get_filenames): Convert filenames to use relative paths.
1840         (find_all_files_in_directory): Deleted.
1841         (find_all_files_in_directory.select_file): Deleted.
1842
1843 2014-09-18  Tanay C  <tanay.c@samsung.com>
1844
1845         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
1846         https://bugs.webkit.org/show_bug.cgi?id=136739
1847
1848         Reviewed by Gyuyoung Kim.
1849
1850         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
1851         (on_mouse_wheel): Modified.
1852
1853 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1854
1855         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
1856         https://bugs.webkit.org/show_bug.cgi?id=136923
1857
1858         Reviewed by Gustavo Noronha Silva.
1859
1860         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1861         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
1862         the source.
1863
1864 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
1865
1866         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
1867         https://bugs.webkit.org/show_bug.cgi?id=136856
1868
1869         Reviewed by Darin Adler.
1870
1871         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1872         (RunLLINTCLoopTests.countFailures):
1873         (Run32bitJSCTests.countFailures):
1874         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1875         (RunLLINTCLoopTestsTest.test_failures):
1876         (RunLLINTCLoopTestsTest.test_failure):
1877         (RunLLINTCLoopTestsTest.test_no_failure):
1878         (Run32bitJSCTestsTest.test_failures):
1879         (Run32bitJSCTestsTest.test_failure):
1880         (Run32bitJSCTestsTest.test_no_failure):
1881
1882 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
1883
1884         GMainLoopSource is exposed to race conditions
1885         https://bugs.webkit.org/show_bug.cgi?id=135800
1886
1887         Reviewed by Carlos Garcia Campos.
1888
1889         Add unit tests for GMainLoopSource.
1890
1891         The tests check correct behavior of GMainLoopSource in various conditions --
1892         from the most simple rescheduling to rescheduling during dispatch, cancelling
1893         or destroying the GMainLoopSource during dispatch, proper destroy callback
1894         dispatching etc.
1895
1896         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
1897         State of the GMainLoopSource object (either ready, sheduled or active) is
1898         thoroughly tested throughout the lifetime of that object.
1899
1900         Still missing are tests for socket callbacks, which are a bit trickier because
1901         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
1902         are also not tested thoroughly, simply because it is at the moment impossible
1903         to test that the objects are actually destroyed when the corresponding source
1904         is finally deleted.
1905
1906         * TestWebKitAPI/PlatformGTK.cmake:
1907         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
1908         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1909         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1910         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1911         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1912         (TestWebKitAPI::GMainLoopSourceTest::finish):
1913         (TestWebKitAPI::GMainLoopSourceTest::source):
1914         (TestWebKitAPI::TEST):
1915
1916 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
1917
1918         Unreviewed, Update my email in contributors.json
1919
1920         * Scripts/webkitpy/common/config/contributors.json:
1921
1922 2014-09-17  Daniel Bates  <dabates@apple.com>
1923
1924         Unreviewed, rolling out r173695.
1925
1926         Broke building third-party Legacy WebKit apps; will
1927         investigate offline
1928
1929         Reverted changeset:
1930
1931         "[iOS] Make WebCore build with public iOS SDK"
1932         https://bugs.webkit.org/show_bug.cgi?id=136487
1933         http://trac.webkit.org/changeset/173695
1934
1935 2014-09-17  Daniel Bates  <dabates@apple.com>
1936
1937         [iOS] Make WebCore build with public iOS SDK
1938         https://bugs.webkit.org/show_bug.cgi?id=136487
1939
1940         Reviewed by David Kilzer.
1941
1942         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
1943
1944         * DumpRenderTree/mac/CheckedMalloc.cpp:
1945
1946 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1947
1948         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
1949         https://bugs.webkit.org/show_bug.cgi?id=136889
1950
1951         Reviewed by Gustavo Noronha Silva.
1952
1953         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1954         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
1955         event was added to the events vector.
1956         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1957         (loadFailedCallback): Do not assume the web view URI is the
1958         failing URI when the load fails before the committed state.
1959         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
1960         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
1961         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
1962         (LoadTrackingTest::loadFailedWithTLSErrors): Add
1963         LoadFailedWithTLSErrors event to the events vector.
1964         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1965
1966 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
1967
1968         [EFL][GTK] Remove WebKit1 related codes
1969         https://bugs.webkit.org/show_bug.cgi?id=136853
1970
1971         Reviewed by Csaba Osztrogonác.
1972
1973         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
1974         from scripts.
1975
1976         * BuildSlaveSupport/build.webkit.org-config/config.json:
1977         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1978         (Compile32bitJSC):
1979         (BuildAndTestWebKit2Factory):
1980         (CompileWebKit1Only): Deleted.
1981         (CompileWebKit2Only): Deleted.
1982         (BuildAndTestWebKit1OnlyFactory): Deleted.
1983         (BuildAndTestWebKit2OnlyFactory): Deleted.
1984         * Scripts/build-webkit:
1985         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1986         * Scripts/webkitpy/common/config/ports.py:
1987         (GtkWK2Port.build_webkit_command):
1988         (EflWK2Port.build_webkit_command):
1989         * Scripts/webkitpy/common/config/ports_unittest.py:
1990         (DeprecatedPortTest.test_gtk_wk2_port):
1991         * Scripts/webkitpy/port/efl.py:
1992         (EflPort.build_webkit_command):
1993         * Scripts/webkitpy/port/gtk.py:
1994         (GtkPort._built_libraries_path):
1995         (GtkPort._search_paths):
1996         (GtkPort.test_expectations_file_position):
1997         (GtkPort.build_webkit_command):
1998         (GtkPort.run_webkit_tests_command):
1999         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
2000
2001 2014-09-16  Daniel Bates  <dabates@apple.com>
2002
2003         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
2004         https://bugs.webkit.org/show_bug.cgi?id=136862
2005
2006         Reviewed by David Kilzer.
2007
2008         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2009         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2010         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
2011         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
2012
2013 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2014
2015         Mac queue slaves should reboot every so often
2016         https://bugs.webkit.org/show_bug.cgi?id=136791
2017
2018         Reviewed by Alexey Proskuryakov.
2019
2020         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
2021
2022         * EWSTools/start-queue-mac.sh:
2023
2024 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2025
2026         Unreviewed gardening, skip one more tests on Windows.
2027
2028         * Scripts/run-javascriptcore-tests:
2029
2030 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2031
2032         JSC test gardening
2033         https://bugs.webkit.org/show_bug.cgi?id=136823
2034
2035         Reviewed by Geoffrey Garen.
2036
2037         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
2038
2039 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2040
2041         Remove shouldAbortEarly cruft from master.cfg
2042         https://bugs.webkit.org/show_bug.cgi?id=136779
2043
2044         Reviewed by Csaba Osztrogonác.
2045
2046         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2047         (ConfigureBuild.start):
2048         (RunWebKitTests.start):
2049         (RunWebKit2Tests.start): Deleted.
2050
2051 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2052
2053         Remove ORWT related crufts from webkitdirs.pm
2054         https://bugs.webkit.org/show_bug.cgi?id=136821
2055
2056         Reviewed by Alexey Proskuryakov.
2057
2058         * Scripts/webkitdirs.pm:
2059         (isPerianInstalled): Deleted.
2060         (determineIPhoneSimulatorVersion): Deleted.
2061         (iPhoneSimulatorVersion): Deleted.
2062         (isSnowLeopard): Deleted.
2063         (isLion): Deleted.
2064         (quitIOSSimulator): Deleted.
2065
2066 2014-09-15  Roger Fong  <roger_fong@apple.com>
2067
2068         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
2069         https://bugs.webkit.org/show_bug.cgi?id=25160
2070
2071         * Scripts/run-javascriptcore-tests:
2072
2073 2014-09-15  Lucas Forschler  <lforschler@apple.com>
2074
2075         Add another Apple build slave to the Mountain Lion Debug WK1 queue
2076         
2077         Rubber stamped by Matt Hanson.
2078         
2079         * BuildSlaveSupport/build.webkit.org-config/config.json:
2080
2081 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2082
2083         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
2084         https://bugs.webkit.org/show_bug.cgi?id=136822
2085
2086         Reviewed by Gyuyoung Kim.
2087
2088         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
2089         initialized as we already does it in PlatformWebView::PlatformWebView
2090         calling ewk_init(). The reason for that was to ensure testing for example,
2091         WTF where creating the view is not mandatory.
2092
2093         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
2094         in order to properly initalize and release EWebKit.
2095
2096         * TestWebKitAPI/PlatformEfl.cmake:
2097         * TestWebKitAPI/efl/PlatformWebView.cpp:
2098         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2099         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2100         * TestWebKitAPI/efl/main.cpp:
2101         (main):
2102
2103 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
2104
2105         [WinCairo] Make it easier to enable/disable GStreamer.
2106         https://bugs.webkit.org/show_bug.cgi?id=135766
2107
2108         Reviewed by Brent Fulgham.
2109
2110         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
2111
2112         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
2113
2114 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
2115
2116         Web Inspector: remind about rebaselining generator test results
2117         https://bugs.webkit.org/show_bug.cgi?id=136759
2118
2119         Reviewed by Joseph Pecoraro.
2120
2121         For now, we can implement this as a watchlist message. Add watchlist
2122         groups and messages for the inspector and web replay generators.
2123
2124         * Scripts/webkitpy/common/config/watchlist:
2125
2126 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
2127
2128         build.webkit.org/dashboard: Overlapping text when status is long
2129         https://bugs.webkit.org/show_bug.cgi?id=136794
2130
2131         Reviewed by Timothy Hatcher.
2132
2133         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2134         (.status-line): Replaces height with min-height.
2135
2136 2014-09-12  Timothy Hatcher  <timothy@apple.com>
2137
2138         Make Brian Burg a WebKit reviewer.
2139
2140         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
2141
2142 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
2143
2144         Multiple EWS or commit bots can pick up processing of the same patch
2145         https://bugs.webkit.org/show_bug.cgi?id=136793
2146
2147         Reviewed by Ryosuke Niwa.
2148
2149         Change timeout from one hour to two hours. This will let bots finish, and in the
2150         unlikely event of a bot being frozen, will only delay patch processing restart by
2151         one hour.
2152
2153         * QueueStatusServer/app.yaml:
2154         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
2155
2156 2014-09-11  Andy Estes  <aestes@apple.com>
2157
2158         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
2159         https://bugs.webkit.org/show_bug.cgi?id=136768
2160
2161         Reviewed by Tim Horton.
2162
2163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2164         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
2165         (TestWebKitAPI::TEST):
2166
2167 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2168
2169         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
2170         https://bugs.webkit.org/show_bug.cgi?id=136669
2171
2172         Reviewed by Antti Koivisto.
2173
2174         * Scripts/run-gtk-tests:
2175         (TestRunner): Unskip SSL test.
2176
2177 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
2178
2179         Strip extraneous AVFoundation and CoreMedia logging
2180         https://bugs.webkit.org/show_bug.cgi?id=136747
2181
2182         Reviewed by Jer Noble.
2183
2184         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2185         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
2186
2187         * Scripts/webkitpy/port/base.py:
2188         (Port.stderr_patterns_to_strip): Base class, empty list
2189
2190         * Scripts/webkitpy/port/driver.py:
2191         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
2192
2193         * Scripts/webkitpy/port/ios.py:
2194         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
2195
2196         * Scripts/webkitpy/port/mac.py:
2197         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
2198
2199
2200 2014-09-11  Michael Saboff  <msaboff@apple.com>
2201
2202         lldb_webkit.py:btjs doesn't work with release builds
2203         https://bugs.webkit.org/show_bug.cgi?id=136760
2204
2205         Reviewed by Jer Noble.
2206
2207         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
2208         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
2209         we can't get a valid result from trying either call.  In that case, we fallback to
2210         just showing the PC.  Also added check for both entry points.  If neither is found,
2211         we issue a warning and output the stack trace without JavaScript annotations.
2212
2213         * lldb/lldb_webkit.py:
2214         (btjs):
2215
2216 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
2217
2218         webkitpy test failures from import-w3c-tests
2219         https://bugs.webkit.org/show_bug.cgi?id=136752
2220
2221         Reviewed by Bem Jones-Bey.
2222
2223         This patch fixes a bug in import-w3c-tests where we were appending
2224         the wrong set of files to the copy_list. This also updates the tests
2225         to clear the failures introduced in the patch for bug 135929.
2226
2227         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2228         (W3CTestConverterTest.test_read_prefixed_property_list):
2229         * Scripts/webkitpy/w3c/test_parser.py:
2230         (TestParser.analyze_test):
2231         (TestParser.support_files):
2232         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2233
2234 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
2235
2236         Blink merge: Speculative fix for windows run-webkit-tests hangs
2237         https://bugs.webkit.org/show_bug.cgi?id=136727
2238
2239         Reviewed by Csaba Osztrogonác.
2240
2241         Merged from Blink (patch by Dirk Pranke):
2242         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
2243
2244         * Scripts/webkitpy/common/system/executive.py:
2245         (Executive.kill_process):
2246
2247 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2248
2249         Added myself as a committer.
2250
2251         Unreviewed.
2252
2253         * Scripts/webkitpy/common/config/contributors.json:
2254
2255 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
2256
2257         [JavaScriptCore] Fix FTL on platform EFL.
2258         https://bugs.webkit.org/show_bug.cgi?id=133571
2259
2260         Reviewed by Filip Pizlo.
2261
2262         * efl/install-dependencies: Revert r169181.
2263         * efl/jhbuild.modules: Clone and build a custom branch.
2264         This branch contains some fix for FTL of platform EFL.
2265         The branch is a fork of llvm r206311.
2266
2267 2014-09-10  Tanay C  <tanay.c@samsung.com>
2268
2269         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
2270         https://bugs.webkit.org/show_bug.cgi?id=136698
2271
2272         Reviewed by Gyuyoung Kim.
2273
2274         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
2275         (on_mouse_wheel): Added.
2276         (window_free):
2277         (window_create):
2278
2279 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
2280
2281         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
2282         https://bugs.webkit.org/show_bug.cgi?id=136284
2283
2284         Reviewed by Gyuyoung Kim.
2285
2286         * MiniBrowser/efl/main.c:
2287         (window_create):
2288
2289 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
2290
2291         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
2292         https://bugs.webkit.org/show_bug.cgi?id=135929
2293
2294         Reviewed by Bem Jones-Bey.
2295
2296         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
2297         were made when this script was originally written with respect to relative paths
2298         in ref files. This patch updates import-w3c-tests to update paths in ref files if
2299         they move relative to the test file.
2300
2301
2302         * Scripts/webkitpy/w3c/test_converter.py:
2303         (convert_for_webkit):
2304         (_W3CTestConverter.__init__):
2305         (_W3CTestConverter.convert_reference_relpaths):
2306         (_W3CTestConverter.convert_style_data):
2307         (_W3CTestConverter.convert_attributes_if_needed):
2308         * Scripts/webkitpy/w3c/test_importer.py:
2309         (TestImporter.find_importable_tests):
2310         (TestImporter.import_tests):
2311         * Scripts/webkitpy/w3c/test_parser.py:
2312         (TestParser.load_file):
2313         (TestParser.analyze_test):
2314         (TestParser.support_files):
2315
2316 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2317
2318         [GTK] allow overwriting destination of download
2319         https://bugs.webkit.org/show_bug.cgi?id=136372
2320
2321         Reviewed by Carlos Garcia Campos.
2322
2323         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2324         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
2325         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
2326         (createFileAtDestination): Added
2327         (testDownloadOverwriteDestinationAllowed): Added
2328         (testDownloadOverwriteDestinationDisallowed): Added
2329         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
2330         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
2331         (beforeAll): New tests
2332
2333 2014-08-05  David Farler  <dfarler@apple.com>
2334
2335         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
2336         https://bugs.webkit.org/show_bug.cgi?id=135551
2337
2338         Reviewed by Daniel Bates.
2339
2340         Prevent printing invalid Unicode strings going to stderr.
2341         Also, make filesystem.py more tolerant about receiving
2342         Unicode (encoded as UTF-8) when writing to files, in the
2343         rare case that an NSError description will make it to
2344         stderr, such as -[LTRelayController createUniqueApp].
2345
2346         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2347         (-[LTRelayController launchSimulator]): Removed.
2348         (-[LTRelayController createUniqueApp]):
2349         Don't explicitly try to uninstall the app. It is automatically handled
2350         when installing an app with the same bundle identifier.
2351         (-[LTRelayController start]):
2352         (-[LTRelayController bootDevice]): Removed.
2353         The device already boots as a part of starting the simulator. Attempting
2354         to boot a second time may cause spurious stderr output.
2355         * Scripts/webkitpy/port/driver.py:
2356         (IOSSimulatorDriver._setup_environ_for_driver):
2357         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
2358         Open the iOS Simulator once instead of the LayoutTestRelay trying
2359         to do it.
2360         * Scripts/webkitpy/port/ios.py:
2361         (IOSSimulatorPort._get_crash_log):
2362         Make sure stderr is at least an empty string.
2363         (IOSSimulatorPort):
2364         (IOSSimulatorPort.developer_dir):
2365         New property for setting up DEVELOPER_DIR in the driver environment.
2366
2367 2014-09-09  Dan Bernstein  <mitz@apple.com>
2368
2369         Clean up the MiniBrowser Xcode project
2370         https://bugs.webkit.org/show_bug.cgi?id=136684
2371
2372         Reviewed by Tim Horton.
2373
2374         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
2375         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
2376         WebKit2.framework. Upgraded project file version.
2377
2378 2014-09-09  Daniel Bates  <dbates@webkit.org>
2379
2380         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
2381         https://bugs.webkit.org/show_bug.cgi?id=136379
2382
2383         Reviewed by David Kilzer.
2384
2385         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
2386         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
2387         and sets a property on F (say, the executable bit).
2388
2389         * Scripts/svn-apply:
2390         (patch): Only add file if the diff has text chunks.
2391         * Scripts/svn-unapply:
2392         (patch): Only delete added file if the diff has text chunks.
2393
2394 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2395
2396         [GTK] Unreviewed GTK gardening.
2397
2398         * Scripts/run-gtk-tests:
2399         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
2400
2401 2014-09-09  Christophe Dumez  <cdumez@apple.com>
2402
2403         Update my email in contributors.json
2404         https://bugs.webkit.org/show_bug.cgi?id=136671
2405
2406         Reviewed by Andreas Kling.
2407
2408         * Scripts/webkitpy/common/config/contributors.json:
2409
2410 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2411
2412         [EFL] Enable fixed layout by default
2413         https://bugs.webkit.org/show_bug.cgi?id=136607
2414
2415         Reviewed by Csaba Osztrogonác.
2416
2417         Fixed layout is being used by Tizen platform by default. However, the feature
2418         has still many defects now. So, we need to enable it by default, then should fix
2419         those bugs. 
2420
2421         * MiniBrowser/efl/main.c:
2422
2423 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2424
2425         Remove FILTERS flag
2426         https://bugs.webkit.org/show_bug.cgi?id=136571
2427
2428         Reviewed by Darin Adler.
2429
2430         * Scripts/webkitperl/FeatureList.pm:
2431
2432 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
2433
2434         Dashboard metrics should ignore commits that didn't trigger builds
2435         https://bugs.webkit.org/show_bug.cgi?id=136618
2436
2437         Reviewed by Darin Adler.
2438
2439         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
2440         other platforms etc. It does not make sense to count wait time for these, as it
2441         can be arbitrarily long.
2442
2443         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
2444
2445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2446         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
2447
2448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2449         We used to walk the timeline to see which revisions are fully tested, but that's not
2450         correct. A revision that's only tested by a subset of queues finishes independently
2451         of another that's tested by another subset. Now, we just search for the answer for
2452         each revision individually.
2453
2454         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
2455         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
2456         the analyzer now reports. Removed best time, which is more confusing than meaningful.
2457
2458 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2459
2460         Remove EWebLauncher from webkitdirs.pm
2461         https://bugs.webkit.org/show_bug.cgi?id=136622
2462
2463         Reviewed by Gyuyoung Kim.
2464
2465         * Scripts/webkitdirs.pm:
2466         (launcherName):
2467
2468 2014-09-06  Sam Weinig  <sam@webkit.org>
2469
2470         XPCPtr should be converted into an all purpose smart pointer for os_objects
2471         https://bugs.webkit.org/show_bug.cgi?id=136602
2472
2473         Reviewed by Darin Adler.
2474
2475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2476         * TestWebKitAPI/Tests/WTF/darwin: Added.
2477         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
2478         Add basic unit tests for OSObjectPtr.
2479
2480 2014-09-06  Saam Barati  <saambarati1@gmail.com>
2481
2482         Unreviewed. Add myself as a committer.
2483
2484         * Scripts/webkitpy/common/config/contributors.json:
2485
2486 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2487
2488         Unreviewed, EFL build fix when SHARED_CORE is on.
2489
2490         * TestWebKitAPI/PlatformEfl.cmake:
2491
2492 2014-09-05  Lucas Forschler  <lforschler@apple.com>
2493
2494         <https://webkit.org/b/136586> Add bots to Apple build/test queues
2495         
2496         Reviewed by Daniel Bates.
2497
2498         * BuildSlaveSupport/build.webkit.org-config/config.json:
2499
2500 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
2501
2502         Buildbot metrics page gives wrong results after a new bot gets added
2503         https://bugs.webkit.org/show_bug.cgi?id=136516
2504
2505         Reviewed by Tim Horton.
2506
2507         Part 2: Fix elapsed times.
2508
2509         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2510         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
2511         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
2512
2513 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2514
2515         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
2516         https://bugs.webkit.org/show_bug.cgi?id=136562
2517
2518         Reviewed by Martin Robinson.
2519
2520         * Scripts/run-gtk-tests:
2521         (TestRunner): Remove failure expectations for tests that now pass.
2522
2523 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2524
2525         Dashboard metrics page wastes a lot of time sorting iterations
2526         https://bugs.webkit.org/show_bug.cgi?id=136559
2527
2528         Reviewed by Tim Horton.
2529
2530         Also fixes comments here and there, and adds a missing "var".
2531
2532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2533         (BuildbotIteration.prototype._parseData):
2534         (BuildbotIteration.prototype._updateWithData):
2535         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2536         (BuildbotQueue.prototype.loadAll):
2537         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2538         (Analyzer.prototype._countTimes):
2539
2540 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2541
2542         [GTK] Unreviewed GTK gardening.
2543
2544         * Scripts/run-gtk-tests:
2545         (TestRunner): Skip tests failing since r173272.
2546
2547 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
2548
2549         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
2550         https://bugs.webkit.org/show_bug.cgi?id=136561
2551
2552         Reviewed by Tim Horton.
2553         
2554         Log for calloc() and CGBitmapContextCreate() failures.
2555
2556         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2557         (createBitmapContext):
2558         (createBitmapContextFromWebView):
2559
2560 2014-09-04  Andy Estes  <aestes@apple.com>
2561
2562         Fix the Mac Production build after r173283.
2563
2564         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
2565
2566 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2567
2568         [Win] webkitpy test suite frequently fails to complete
2569         https://bugs.webkit.org/show_bug.cgi?id=136546
2570
2571         Reviewed by Daniel Bates.
2572
2573         Properly convert the ASCII crash log produced by ntsd into
2574         a unicode string as early as possible so that we handle it
2575         properly when generating our logs and other test support output.
2576
2577         We were mixing ASCII/unicode strings under Windows, which was
2578         causing test system failures when we processed some crash logs.
2579
2580         Also do a better job of handling garbage pid entries in the
2581         Cygwin lock files.
2582
2583         * Scripts/webkitpy/common/system/crashlogs.py:
2584         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
2585         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
2586         handle the strings as unicode from that point on.
2587         * Scripts/webkitpy/port/http_lock.py:
2588         (HttpLock._current_lock_pid): Add logging and handle case of
2589         the current_pid failing to cleanly convert to 'int'.
2590         * Scripts/webkitpy/port/win.py:
2591         (WinPort): Add 64-bit architecture as a known target for the
2592         Windows build.
2593
2594 2014-09-04  Andy Estes  <aestes@apple.com>
2595
2596         Address additional review feedback after landing r173283.
2597
2598         Reviewed by Daniel Bates.
2599
2600         * DumpRenderTree/config.h: Removed redundant includes.
2601         * TestWebKitAPI/config.h: Ditto.
2602         * WebKitTestRunner/config.h: Ditto.
2603
2604 2014-09-03  Andy Estes  <aestes@apple.com>
2605
2606         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
2607         https://bugs.webkit.org/show_bug.cgi?id=136521
2608
2609         Reviewed by Anders Carlsson.
2610
2611         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
2612         * TestWebKitAPI/config.h: Ditto.
2613         * WebKitTestRunner/config.h: Ditto.
2614
2615 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2616
2617         REGRESSION: Dashboard metrics page aggregation counts performance bots
2618         https://bugs.webkit.org/show_bug.cgi?id=136539
2619
2620         Reviewed by Tim Horton.
2621
2622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2623
2624 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2625
2626         [Win] Perl test fix.
2627
2628         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
2629         VersionStamp.exe tool, not just the driver script.
2630
2631 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2632
2633         Remove CSS_FILTERS flag
2634         https://bugs.webkit.org/show_bug.cgi?id=136529
2635
2636         Reviewed by Dirk Schulze.
2637
2638         * Scripts/webkitperl/FeatureList.pm:
2639
2640 2014-09-04  Commit Queue  <commit-queue@webkit.org>
2641
2642         Unreviewed, rolling out r173201.
2643         https://bugs.webkit.org/show_bug.cgi?id=136538
2644
2645         Improves the situation but also introduces additional crashes.
2646         (Requested by zdobersek on #webkit).
2647
2648         Reverted changeset:
2649
2650         "GMainLoopSource is exposed to race conditions"
2651         https://bugs.webkit.org/show_bug.cgi?id=135800
2652         http://trac.webkit.org/changeset/173201
2653
2654 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2655
2656         Buildbot metrics page gives wrong results after a new bot gets added
2657         https://bugs.webkit.org/show_bug.cgi?id=136516
2658
2659         Part 1: Fix red/green counters. Dashboard is considered green at a given time
2660         if all the bots that ever had results before this time are green.
2661
2662         This doesn't (and cannot) address situations where the bot gets removed and then
2663         re-added. It also gives wrong results after a bot gets removed, because it doesn't
2664         know that it was ever displayed on the dashboard.
2665
2666         Reviewed by Darin Adler.
2667
2668         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2669         (Analyzer.prototype._dashboardIsAllGreen):
2670         (Analyzer.prototype._updateStretchOfRedCounters):
2671         (Analyzer.prototype._countPercentageOfGreen):
2672         (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
2673
2674 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2675
2676         [Win] Unreviewed test fix.
2677
2678         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
2679         test if user doesn't have the VersionStamp.exe program.
2680
2681 2014-09-03  Dana Burkart  <dburkart@apple.com>
2682
2683         Unreviewed. Add myself as a committer.
2684
2685         * Scripts/webkitpy/common/config/contributors.json:
2686
2687 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2688
2689         build.webkit.org/dashboard performance popover is unstyled
2690         https://bugs.webkit.org/show_bug.cgi?id=136499
2691
2692         Reviewed by Tim Horton.
2693
2694         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2695         (.performance-popover):
2696         (.performance-popover .dashboard-link):
2697
2698 2014-09-03  Saam Barati  <saambarati1@gmail.com>
2699
2700         Create tests for type profiling
2701         https://bugs.webkit.org/show_bug.cgi?id=136161
2702
2703         Reviewed by Geoffrey Garen.
2704
2705         Have run-javascriptcore-tests run the newly created
2706         tests for the type profiler.
2707
2708         * Scripts/run-javascriptcore-tests:
2709         * Scripts/run-jsc-stress-tests:
2710
2711 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2712
2713         [Win] Revise test environment for Windows build.
2714         https://bugs.webkit.org/show_bug.cgi?id=136486
2715
2716         Reviewed by David Kilzer.
2717
2718         The various calls to get the Safari path really only have
2719         meaning on the Mac. Other ports get access to the build
2720         and test environment separately, so remove the various
2721         checks in the Safari-specific code to simplify things.
2722
2723         Remove some 64-bit hacks used on Windows now that the
2724         various tools know how to find the 64-bit runtime environment.
2725
2726         * Scripts/run-javascriptcore-tests: 
2727         * Scripts/webkitdirs.pm:
2728         (safariPathFromSafariBundle): Revise to expect Mac.
2729         (installedSafariPath): Ditto.
2730         (safariPath): Ditto.
2731         (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
2732         (setPathForRunningWebKitApp): Get rid of unused SafariPath
2733         argument for Windows runs.
2734
2735 2014-09-03  Dana Burkart  <dburkart@apple.com>
2736
2737         Dashboard should show performance bots.
2738         https://bugs.webkit.org/show_bug.cgi?id=136386
2739
2740         Reviewed by Alexey Proskuryakov.
2741
2742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2743         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
2744         (BuildbotIteration.prototype._parseData):
2745         Support possible performance failures.
2746
2747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2748         New QueueView to manage the way we present performance data.
2749
2750         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2751         (BuildbotQueue):
2752         Support new 'performance' and 'performanceTestName' keys.
2753
2754
2755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2756         Add performance column to the main page.
2757
2758         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2759         (WebKitBuildbot):
2760         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2761         (body):
2762         Make sure everything fits on 13 inch screens.
2763
2764         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2765
2766 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
2767
2768         GMainLoopSource is exposed to race conditions
2769         https://bugs.webkit.org/show_bug.cgi?id=135800
2770
2771         Reviewed by Carlos Garcia Campos.
2772
2773         Add a unit test for GMainLoopSource that tests different
2774         types of rescheduling tasks on already-active sources.
2775
2776         * TestWebKitAPI/PlatformGTK.cmake:
2777         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
2778         (GMainLoopSourceTest::GMainLoopSourceTest):
2779         (GMainLoopSourceTest::~GMainLoopSourceTest):
2780         (GMainLoopSourceTest::runLoop):
2781         (GMainLoopSourceTest::finish):
2782         (GMainLoopSourceTest::source):
2783         (testGMainLoopSourceBasicRescheduling):
2784         (testGMainLoopSourceReentrantRescheduling):
2785         (testGMainLoopSourceDifferentThreadRescheduling):
2786         (beforeAll):
2787         (afterAll):
2788         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
2789         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
2790         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
2791         (TestWebKitAPI::GMainLoopSourceTest::finish):
2792         (TestWebKitAPI::GMainLoopSourceTest::source):
2793         (TestWebKitAPI::TEST):
2794
2795 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
2796
2797         Make sure WK1 prefs are initialized in MiniBrowser
2798         https://bugs.webkit.org/show_bug.cgi?id=136465
2799
2800         Reviewed by Tim Horton.
2801         
2802         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
2803         for WK2 windows, to make sure that WebPreferences are updated (to get
2804         layer borders to work consistently).
2805
2806         * MiniBrowser/mac/WK1BrowserWindowController.m:
2807         (-[WK1BrowserWindowController awakeFromNib]):
2808
2809 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
2810
2811         check-webkit-style should complain about C++ comments in Platform.h
2812         https://bugs.webkit.org/show_bug.cgi?id=133802
2813
2814         Reviewed by Csaba Osztrogonác.
2815
2816         * Scripts/webkitpy/style/checkers/cpp.py:
2817         (check_platformh_comments):
2818         (_process_lines):
2819         (CppChecker):
2820         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2821         (CppStyleTest.test_platformh_comment):
2822
2823 2014-09-02  Brendan Long  <self@brendanlong.com>
2824
2825         [Gtk] Make install-dependencies work on Arch Linux
2826         https://bugs.webkit.org/show_bug.cgi?id=136374
2827
2828         Reviewed by Philippe Normand.
2829
2830         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
2831
2832 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
2833
2834         Provide column numbers to DTrace willExecute/didExecute probes
2835         https://bugs.webkit.org/show_bug.cgi?id=136434
2836
2837         Reviewed by Antti Koivisto.
2838
2839         Create a directory for DTrace scripts. Add an example script that
2840         shows how to use static probes provided by JavaScriptCore's profiler.
2841
2842         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
2843
2844 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2845
2846         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
2847         https://bugs.webkit.org/show_bug.cgi?id=136431
2848
2849         Reviewed by Martin Robinson.
2850
2851         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
2852         Add missing dependencies for librsvg (glib and cairo).
2853
2854 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2855
2856         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
2857         https://bugs.webkit.org/show_bug.cgi?id=136425
2858
2859         Reviewed by Martin Robinson.
2860
2861         * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
2862
2863 2014-09-01  Ryuan Choi  <ryuan.choi@samsung.com>
2864
2865         Update my list of email addresses in contributors.json
2866         https://bugs.webkit.org/show_bug.cgi?id=136424
2867
2868         Reviewed by Gyuyoung Kim.
2869
2870         * Scripts/webkitpy/common/config/contributors.json:
2871
2872 2014-08-30  Filip Pizlo  <fpizlo@apple.com>
2873
2874         [RJST] eager-no-cjit should really mean eager
2875         https://bugs.webkit.org/show_bug.cgi?id=136407
2876
2877         Reviewed by Mark Hahnenberg.
2878         
2879         At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
2880         and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
2881         after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
2882         all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
2883         threshold setting that NO_CJIT_OPTIONS was currently setting
2884         (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
2885         NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
2886         
2887         Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
2888
2889         * Scripts/run-jsc-stress-tests:
2890
2891 2014-08-29  Daniel Bates  <dabates@apple.com>
2892
2893         [iOS] Configure Xcode to build a command line tool for the iOS Simulator
2894         https://bugs.webkit.org/show_bug.cgi?id=136388
2895
2896         Reviewed by David Kilzer.
2897
2898         Add a script, called configure-xcode-for-ios-development, to configure Xcode to
2899         support building a command line tool for the iOS Simulator. You must run this
2900         script as root.
2901
2902         The script uses the xcspec files in the OS X SDK to create xcspec files in the
2903         iOS Simulator SDK with the product- and package- type definitions to build a
2904         command line tool, if applicable.
2905
2906         * Scripts/configure-xcode-for-ios-development: Added.
2907
2908 2014-08-29  Tim Horton  <timothy_horton@apple.com>
2909
2910         Remove Windows WebKit2 code from TestWebKitAPI
2911         https://bugs.webkit.org/show_bug.cgi?id=136385
2912
2913         Reviewed by Alexey Proskuryakov.
2914
2915         * TestWebKitAPI/PlatformUtilities.h:
2916         * TestWebKitAPI/PlatformWebView.h:
2917         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
2918         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2919         (TestWebKitAPI::TEST): Deleted.
2920         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2921         (TestWebKitAPI::TEST):
2922         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2923         (TestWebKitAPI::TEST):
2924         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
2925         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
2926         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
2927         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
2928         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
2929         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
2930         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
2931
2932 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2933
2934         [JSC] Some JSC tests are dependent on the machine time zone.
2935         https://bugs.webkit.org/show_bug.cgi?id=136363
2936
2937         Reviewed by Filip Pizlo.
2938
2939         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
2940         Unskip the tests that were skipped on r99580.
2941
2942 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2943
2944         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
2945         https://bugs.webkit.org/show_bug.cgi?id=135560
2946
2947         Reviewed by Gyuyoung Kim.
2948
2949         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
2950
2951 2014-08-28  Daniel Bates  <dabates@apple.com>
2952
2953         [Win] update-webkit should update auxiliary libs by default
2954
2955         Reviewed by Dan Bernstein.
2956
2957         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
2958         from updating the Windows auxiliary libs by default. We should make update-webkit update the
2959         Windows auxiliary libs by default. This will make its behavior match its usage text.
2960
2961         * Scripts/update-webkit:
2962
2963 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
2964
2965         build-webkit --inspector-frontend tries to copy files from old inspector path
2966         https://bugs.webkit.org/show_bug.cgi?id=136346
2967
2968         Reviewed by Timothy Hatcher.
2969
2970         Remove the old code path for copying inspector resources. It doesn't work.
2971         Complain if this option is passed to CMake-based builds.
2972
2973         * Scripts/build-webkit:
2974         * Scripts/webkitdirs.pm:
2975         (copyInspectorFrontendFiles): Deleted.
2976
2977 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
2978
2979         Dashboard metrics page could show longest stretch of red
2980         https://bugs.webkit.org/show_bug.cgi?id=136334
2981
2982         Reviewed by Sam Weinig.
2983
2984         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2985         (Analyzer.prototype._updateStretchOfRedCounters):
2986         (Analyzer.prototype._countPercentageOfGreen):
2987         When counting percentage of green, also keep track of how long the page was red.
2988
2989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
2990         (MetricsView.prototype._update.addDivider):
2991         (MetricsView.prototype._update.appendQueueResults):
2992         Show it in aggregate queues (can't think of a reason to have it in individual ones).
2993
2994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
2995         Changed to use an explicit divider element between green time and performance groups,
2996         as there are too many combinations to easily express in CSS.
2997
2998 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2999
3000         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
3001         https://bugs.webkit.org/show_bug.cgi?id=136248
3002
3003         Reviewed by Gustavo Noronha Silva.
3004
3005         Add new test case for webkit_uri_response_get_http_headers().
3006
3007         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3008         (testURIResponseHTTPHeaders):
3009         (serverCallback):
3010         (beforeAll):
3011
3012 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3013
3014         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
3015         https://bugs.webkit.org/show_bug.cgi?id=131668
3016
3017         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3018         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
3019
3020 2014-08-27  Zalan Bujtas  <zalan@apple.com>
3021
3022         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
3023         https://bugs.webkit.org/show_bug.cgi?id=136264
3024
3025         Reviewed by Simon Fraser.
3026         
3027         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
3028         functions. ->snappedIntSize()/snapSizeToDevicePixel().
3029         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
3030
3031         Covered by existing tests.
3032
3033         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3034         (TestWebKitAPI::TEST): Deleted.
3035
3036 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3037
3038         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
3039         https://bugs.webkit.org/show_bug.cgi?id=131668
3040
3041         Reviewed by Daniel Bates.
3042
3043         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
3044         to not just hardcode.
3045
3046         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3047         (EWS.prototype.queueStatusURL): Added.
3048
3049         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3050         (EWSQueue.prototype.get statusPageURL): Use the above function.
3051         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
3052
3053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
3054         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
3055         are no patches in the queue. The popover has other useful information, such as charts
3056         link and bot status.
3057
3058 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3059
3060         https://bugs.webkit.org/show_bug.cgi?id=136317
3061         Dashboard metrics page sometimes shows 0 for best time
3062
3063         Reviewed by Tim Horton.
3064
3065         This also affects regular dashboard display in a good way - iterations that failed
3066         due to infrastructure misbehavior will more reliably show up as yellow and not red.
3067
3068         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3069         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
3070         updated if we rename steps.
3071         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
3072         do it once.
3073         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
3074         that failed e.g. at downloading built archive step are not productive.
3075
3076 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
3077
3078         [Win] Unreviewed gardening.
3079
3080         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
3081         of logs assembled into the final build output.
3082
3083 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3084
3085         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
3086         https://bugs.webkit.org/show_bug.cgi?id=136196
3087
3088         Reviewed by Timothy Hatcher.
3089
3090         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
3091         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
3092         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
3093         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
3094         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
3095         A date range picker control with dependencies.
3096         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
3097         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
3098         (it didn't happen again upon re-opening the picker).
3099         - Made made style tweaks to match Dashboard UI.
3100
3101         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3102         Don't create objects that are not needed by the given app, and thus are not loaded at all.
3103
3104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
3105         Math to count all the things. Only supports open source tree and trunk at the moment,
3106         but written with internal tree and branches in mind.
3107
3108         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
3109         Like dashboard Main.js, draws the UI and creates all necessary objects.
3110
3111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
3112         A view for table cells.
3113
3114         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3115         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
3116         Metrics page has individual platforms initially scrolled away form the view, so 
3117         it needs to scroll down to reveal what's being configured.
3118
3119         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3120         Added Array.prototype.average and Array.prototype.median.
3121
3122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3123         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
3124         in settings mode.
3125
3126         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
3127         Additional style rules.
3128
3129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
3130         The metrics page.
3131
3132 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3133
3134         Remove networkinfo watch category in watchlist
3135         https://bugs.webkit.org/show_bug.cgi?id=136279
3136
3137         Reviewed by Alexey Proskuryakov.
3138
3139         Network info was removed. So, it is not needed anymore.
3140
3141         * Scripts/webkitpy/common/config/watchlist:
3142
3143 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3144
3145         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
3146         https://bugs.webkit.org/show_bug.cgi?id=136281
3147
3148         Reviewed by Tim Horton.
3149
3150         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3151         Track and expose whether the itertion is being loaded. Made update() a no-op if
3152         the iteration is already being loaded.
3153
3154         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3155         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
3156         loading everything at once, ask the queue to load a little more. We can always repeat
3157         if we still don't have enough data.
3158
3159         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3160         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
3161         10 more iterations intelligently.
3162
3163 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3164
3165         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
3166         https://bugs.webkit.org/show_bug.cgi?id=136283
3167
3168         Reviewed by Tim Horton.
3169
3170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3171         Don't.
3172
3173 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3174
3175         build.webkit.org/dashboard raises an exception after a hidden platform is removed
3176         https://bugs.webkit.org/show_bug.cgi?id=136282
3177
3178         Reviewed by Tim Horton.
3179
3180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3181         (updateHiddenPlatforms): Check that the platform is still valid.
3182
3183 2014-08-26  Matt Lilek  <mrl@apple.com>
3184
3185         Add WebKit SPI to control the navigator.standalone property
3186         https://bugs.webkit.org/show_bug.cgi?id=136189
3187
3188         Reviewed by Andy Estes.
3189
3190         Add API test for WKPreferences
3191
3192         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3193         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3194         (TEST):
3195
3196 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3197
3198         Remove ENABLE_DRT environment variable to enable SHARED_CORE
3199         https://bugs.webkit.org/show_bug.cgi?id=136205
3200
3201         Reviewed by Andrei Bucur.
3202
3203         EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
3204         use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
3205
3206         * Scripts/webkitdirs.pm:
3207         (generateBuildSystemFromCMakeProject):
3208
3209 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
3210
3211         [Win] Version stamp should include package-level version
3212         https://bugs.webkit.org/show_bug.cgi?id=136266
3213         <rdar://problem/18134138>
3214
3215         Reviewed by David Kilzer.
3216
3217         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
3218         tests for the full 3+ digit version.
3219         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
3220         Confirm that the final output DLL uses the 3+ digit version.
3221
3222 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
3223
3224         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
3225         https://bugs.webkit.org/show_bug.cgi?id=136258
3226         <rdar://problem/18134138>
3227
3228         Reviewed by Tim Horton.
3229
3230         Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
3231         values from passing through the 32-bit OLE_HANDLE data type.
3232
3233         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3234         (AccessibilityController::rootElement):
3235         * DumpRenderTree/win/DumpRenderTree.cpp:
3236         (resetWebViewToConsistentStateBeforeTesting):
3237         (runTest):
3238         (createWebViewAndOffscreenWindow):
3239         * DumpRenderTree/win/FrameLoadDelegate.h:
3240         (FrameLoadDelegate::didReceiveIcon):
3241         * DumpRenderTree/win/TestRunnerWin.cpp:
3242         (TestRunner::setWindowIsKey):
3243         * DumpRenderTree/win/UIDelegate.cpp:
3244         (UIDelegate::trackCustomPopupMenu):
3245         (UIDelegate::drawHeaderInRect):
3246         (UIDelegate::drawFooterInRect):
3247         (UIDelegate::webViewClose):
3248         (UIDelegate::webViewFocus):
3249         (UIDelegate::webViewSetCursor):
3250         (UIDelegate::drawBackground):
3251         * DumpRenderTree/win/UIDelegate.h:
3252         (UIDelegate::webViewFirstResponder):
3253         (UIDelegate::makeFirstResponder):
3254         (UIDelegate::contextMenuItemsForElement):
3255         (UIDelegate::addCustomMenuDrawingData):
3256         (UIDelegate::cleanUpCustomMenuDrawingData):
3257         (UIDelegate::webViewLostFocus):
3258         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3259         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
3260         * WinLauncher/PrintWebUIDelegate.cpp:
3261         (PrintWebUIDelegate::drawHeaderInRect):
3262         (PrintWebUIDelegate::drawFooterInRect):
3263         * WinLauncher/PrintWebUIDelegate.h:
3264         (PrintWebUIDelegate::webViewFirstResponder):
3265         (PrintWebUIDelegate::makeFirstResponder):
3266         (PrintWebUIDelegate::contextMenuItemsForElement):
3267         (PrintWebUIDelegate::trackCustomPopupMenu):
3268         (PrintWebUIDelegate::addCustomMenuDrawingData):
3269         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
3270         * WinLauncher/WinLauncher.cpp:
3271         (WinLauncher::prepareViews):
3272         * WinLauncher/WinLauncherWebHost.h:
3273         (WinLauncherWebHost::didReceiveIcon):
3274
3275 2014-08-26  Daniel Bates  <dabates@apple.com>
3276
3277         Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
3278
3279         Rubber-stamped by Tim Horton.
3280
3281         The Windows and iOS ports are the only ports that make use of WebCore headers
3282         in DumpRenderTree.
3283
3284         * DumpRenderTree/config.h:
3285
3286 2014-08-26  Dan Bernstein  <mitz@apple.com>
3287
3288         runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
3289         https://bugs.webkit.org/show_bug.cgi?id=136254
3290
3291         Reviewed by Tim Horton.
3292
3293         * Scripts/webkitdirs.pm:
3294         (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
3295         not the invoking script.
3296
3297 2014-08-26  Krzysztof Czech  <k.czech@samsung.com>
3298
3299         [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
3300         https://bugs.webkit.org/show_bug.cgi?id=136127
3301
3302         Reviewed by Gyuyoung Kim.
3303
3304         Add espeak dependency.
3305
3306         * efl/install-dependencies:
3307
3308 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3309
3310         Remove a little more accidentally landed code from r172891.
3311
3312         iteration.branch also wasn't meant to be landed.
3313
3314         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3315         (BuildbotIteration.prototype._parseData):
3316
3317 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3318
3319         REGRESSION (r172891): Internal dashboard is broken.
3320
3321         Removing some accidentally landed code - I needed "changes" for another patch, but
3322         not here, and then I decided to not use it anyway.
3323
3324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3325         (BuildbotIteration.prototype._parseData):
3326
3327 2014-08-25  Daniel Bates  <dabates@apple.com>
3328
3329         Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
3330         (https://bugs.webkit.org/show_bug.cgi?id=136108)
3331
3332         Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
3333         so that we can compile DumpRenderTree for iOS.
3334
3335         * DumpRenderTree/config.h:
3336
3337 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3338
3339         Make build.webkit.org/dashboard work with changeset_show_files=location
3340         https://bugs.webkit.org/show_bug.cgi?id=136237
3341
3342         Reviewed by Tim Horton.
3343
3344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3345         (Trac.prototype._convertCommitInfoElementToObject): Remove location information
3346         from description before getting title, and also actually parse the location into
3347         result object when available.
3348
3349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3350         (String.prototype.startsWith): Added.
3351
3352 2014-08-25  Tanay C  <tanay.c@samsung.com>
3353
3354         [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
3355         https://bugs.webkit.org/show_bug.cgi?id=135795
3356
3357         Reviewed by Gyuyoung Kim.
3358
3359         * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
3360         (history_list_hide): Hiding and dereferencing the history list and items
3361         (on_key_down):
3362         (on_mouse_down):
3363         (on_back_button_clicked): Early return for longpress 
3364         (on_forward_button_clicked): Early return for longpress 
3365         (list_item_label_get): Populate item labels
3366         (on_list_item_select): Navigates on selection from history list
3367         (navigation_button_longpress_process): Populates the history list and displays it
3368         (on_forward_button_longpress):
3369         (on_back_button_longpress):
3370         (window_create): Add the widget for history list
3371
3372 2014-08-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3373
3374         [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
3375         https://bugs.webkit.org/show_bug.cgi?id=136152
3376
3377         Reviewed by Philippe Normand.
3378
3379         * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
3380         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
3381         Cherry pick upstream patches daa194 and 4e3d101.
3382
3383 2014-08-24  Zan Dobersek  <zdobersek@igalia.com>
3384
3385         GenericHashTraits::peek() is producing copies of passed-in temporary values
3386         https://bugs.webkit.org/show_bug.cgi?id=131461
3387
3388         Reviewed by Darin Adler.
3389
3390         Add a test case that checks the number of copies and moves of the mapped objects
3391         when calling HashMap::get(). Exactly one copy of the mapped value should be
3392         performed when there exists a value that is mapped to the specified key, and
3393         exactly one move and no copies of the empty value should be performed when there
3394         isn't any mapped value for the specified key.
3395
3396         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
3397         (CopyMoveCounter::TestingScope::TestingScope):
3398         (CopyMoveCounter::CopyMoveCounter):
3399         (CopyMoveCounter::operator=):
3400         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3401         (TestWebKitAPI::TEST):
3402
3403 2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
3404
3405         [EFL] Introduce DEVELOPER_MODE
3406         https://bugs.webkit.org/show_bug.cgi?id=135884
3407
3408         Reviewed by Gyuyoung Kim.
3409
3410         * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
3411         (generateBuildSystemFromCMakeProject):
3412
3413 2014-08-24  Alexey Proskuryakov  <ap@apple.com>
3414
3415         build.webkit.org/dashboard unnecessarily loads results of hidden queues
3416         https://bugs.webkit.org/show_bug.cgi?id=136195
3417
3418         Reviewed by Tim Horton.
3419
3420         This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
3421
3422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3424         Don't start an update just because a queue object was created. Periodic updates
3425         are triggered by views, so it only makes sense to do the same for the initial update.
3426
3427         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3428         Now that Trac object doesn't auto-load, start loading here.
3429
3430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3431         (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
3432         a data member added by subclasses later. With this.platform being undefined, it
3433         always looked like this queue was not hidden.
3434         (QueueView.prototype._updateHiddenState): Start an immediate update, too.
3435
3436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3437         (Trac): Don't load anything here, the client may choose to load a custom date range.
3438         (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
3439
3440 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
3441
3442         build.webkit.org/dashboard: Further improve Trac loading
3443         https://bugs.webkit.org/show_bug.cgi?id=136174
3444
3445         Reviewed by Timothy Hatcher.
3446
3447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3448         (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
3449         error, the oldest commit within the range wasn't returned. The correct argument for
3450         "no limit" is 0.
3451         (Trac.prototype.load): Added a function to load a specific time range.
3452         (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
3453         positioned with regards to ones that were already known.
3454
3455 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
3456
3457         build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
3458         https://bugs.webkit.org/show_bug.cgi?id=136182
3459
3460         Reviewed by Timothy Hatcher.
3461
3462         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3463         Make it possible to create a complete BuildbotIteration object with JSON, not only by
3464         loading data from the network.
3465
3466         An iteration has three states:
3467         1. Just created, it only knows the revision, and whether it's already finished.
3468         BuildbotIteration constructor used to create these.
3469         2. A complete JSON report loaded from buildbot. The new constructor form creates these.
3470         3. Data about tests is fetched.
3471
3472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3473         Make it possible to pull all data from a buildbot queue. This needs to be better
3474         optimized eventually, as it's somewhat slow.
3475
3476 2014-08-22  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3477
3478         Remove LevelDB.
3479         https://bugs.webkit.org/show_bug.cgi?id=136170
3480
3481         Reviewed by Gyuyoung Kim.
3482
3483         * Scripts/webkitpy/common/config/watchlist:
3484         * Scripts/webkitpy/style/checker.py:
3485
3486 2014-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3487
3488         [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
3489         https://bugs.webkit.org/show_bug.cgi?id=136153
3490
3491         Reviewed by Martin Robinson.
3492
3493         * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
3494
3495 2014-08-21  Alex Christensen  <achristensen@webkit.org>
3496
3497         [Win] Another unreviewed build fix.
3498
3499         * DumpRenderTree/config.h:
3500         Defined WEBCORE_EXPORT on Windows.
3501
3502 2014-08-21  Rohit Kumar  <kumar.rohit@samsung.com>
3503
3504         [EFL][WK2] Minibrowser : Add stop button to abort page load
3505         https://bugs.webkit.org/show_bug.cgi?id=136122
3506
3507         Reviewed by Gyuyoung Kim.
3508
3509         * MiniBrowser/efl/main.c:
3510         (on_key_down):
3511         (on_stop_button_clicked): Callback for stop button press.
3512         (window_create):
3513
3514 2014-08-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3515
3516         [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
3517         https://bugs.webkit.org/show_bug.cgi?id=134070
3518
3519         Reviewed by Martin Robinson.
3520
3521         * Scripts/webkitpy/port/base.py:
3522         (Port.__init__): Set default _jhbuild_wrapper variable.
3523         (Port._should_use_jhbuild): Implement generic check.
3524         * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
3525         to make it consistent with the other ports.
3526         * Scripts/webkitpy/port/gtk.py:
3527         (GtkPort.__init__): Use the new _should_use_jhbuild() method.
3528         (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
3529         querying the jhbuild with printenv. Also check that the path contains
3530         the libraries we expect. Preload this path only for XvfbDriver.
3531         * Scripts/webkitpy/port/xvfbdriver.py:
3532         (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
3533         (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
3534         configured at setup_environ_for_server()
3535         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3536         (XvfbDriverTest.make_driver): Get the port default environment.
3537         (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
3538         should include the environment that is passed when running Xvfb.
3539         (XvfbDriverTest.test_start_pixel_tests): Ditto.
3540         (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
3541         (XvfbDriverTest.test_start_next_worker): Ditto.
3542         * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
3543         prevent future problems when the version is raised. Add also a
3544         comment with a warning.
3545         * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
3546         that has the llvm optimized Gallium libGL libraries.
3547
3548 2014-08-21  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3549
3550         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
3551         https://bugs.webkit.org/show_bug.cgi?id=136125
3552
3553         Reviewed by Csaba Osztrogonác.
3554
3555         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3556         (RunLLINTCLoopTests.countFailures):
3557         (Run32bitJSCTests.countFailures):
3558         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3559         (RunLLINTCLoopTestsTest):
3560         (RunLLINTCLoopTestsTest.assertResults):
3561         (RunLLINTCLoopTestsTest.test_failures):
3562         (RunLLINTCLoopTestsTest.test_failure):
3563         (RunLLINTCLoopTestsTest.test_no_failure):
3564         (Run32bitJSCTestsTest):
3565         (Run32bitJSCTestsTest.assertResults):
3566         (Run32bitJSCTestsTest.test_failures):
3567         (Run32bitJSCTestsTest.test_failure):
3568         (Run32bitJSCTestsTest.test_no_failure):
3569
3570 2014-08-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3571
3572         Unreviewed, EFL build fix since r172814.
3573
3574         * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
3575
3576 2014-08-20  Alex Christensen  <achristensen@webkit.org>
3577
3578         Introducing WEBCORE_EXPORT macro.
3579         https://bugs.webkit.org/show_bug.cgi?id=136108
3580
3581         Reviewed by Antti Koivisto.
3582
3583         * TestWebKitAPI/config.h:
3584         Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.
3585
3586 2014-08-20  Rebecca Hauck  <rhauck@adobe.com>
3587
3588         import-w3c-tests doesn't import .svg support files
3589         https://bugs.webkit.org/show_bug.cgi?id=135928
3590
3591         Reviewed by Bem Jones-Bey.
3592
3593         This patch fixes the W3C import script to not treat all
3594         files with an xml mimetype as convertible tests, which
3595         was causing SVG support files to not be imported.
3596
3597         * Scripts/webkitpy/w3c/test_importer.py:
3598         (TestImporter.find_importable_tests):
3599
3600 2014-08-19  Dan Bernstein  <mitz@apple.com>
3601
3602         update-webkit should not check for the presence of Apple’s Internal directory
3603         Last part of https://bugs.webkit.org/show_bug.cgi?id=135815
3604
3605         Reviewed by Tim Horton.
3606
3607         * Scripts/update-webkit:
3608
3609 2014-08-19  Zalan Bujtas  <zalan@apple.com>
3610
3611         Remove ENABLE(SUBPIXEL_LAYOUT).
3612         https://bugs.webkit.org/show_bug.cgi?id=136077
3613
3614         Reviewed by Simon Fraser.
3615
3616         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
3617
3618         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3619
3620 2014-08-19  Akos Kiss  <akiss@inf.u-szeged.hu>
3621
3622         Let the caller define JSC_timeout for run-javascriptcore-tests
3623         https://bugs.webkit.org/show_bug.cgi?id=136068
3624
3625         Reviewed by Csaba Osztrogonác.
3626
3627         Keep the 60 second timeout for jsc tests as the default setting but
3628         don't override the value of JSC_timeout if already set.
3629
3630         * Scripts/run-javascriptcore-tests:
3631
3632 2014-08-19  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3633
3634         Remove obsolete run-javascriptcore-tests result parsing from master.cfg
3635         https://bugs.webkit.org/show_bug.cgi?id=136039
3636
3637         Reviewed by Csaba Osztrogonác.
3638
3639         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3640         (RunJavaScriptCoreTests.commandComplete):
3641         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3642         (RunJavaScriptCoreTestsTest.test_no_failure_new_output):
3643         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
3644    &n