1 2013-04-28 Seokju Kwon <seokju.kwon@gmail.com>
3 Remove support for Chromium from webkitdirs.pm
4 https://bugs.webkit.org/show_bug.cgi?id=115338
6 Reviewed by Darin Adler.
8 * Scripts/webkitdirs.pm:
9 (determineBaseProductDir):
10 (argumentsForConfiguration):
11 (builtDylibPathForName):
15 2013-04-28 Zan Dobersek <zdobersek@igalia.com>
17 Rename TestRunner's setAudioData to setAudioResult
18 https://bugs.webkit.org/show_bug.cgi?id=115326
20 Reviewed by Darin Adler.
22 Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
23 than the previous one. The change is a simple rename, there's no change in the method's functionality. The
24 affected tests are adjusted accordingly.
26 * DumpRenderTree/qt/TestRunnerQt.cpp:
27 (TestRunnerQt::setAudioResult):
28 * DumpRenderTree/qt/TestRunnerQt.h:
30 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
31 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
32 (WTR::TestRunner::setAudioResult):
33 * WebKitTestRunner/InjectedBundle/TestRunner.h:
36 2013-04-28 Zan Dobersek <zdobersek@igalia.com>
38 [WKTR] Tests dumping audio data shouldn't dump pixels
39 https://bugs.webkit.org/show_bug.cgi?id=115270
41 Reviewed by Benjamin Poulain.
43 Prevent dumping the pixel output when Web Audio tests are dumping output data
44 as the testing output. Pixel output in these tests has no real meaning and is
47 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
48 (WTR::TestRunner::setAudioData):
50 2013-04-27 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
52 [EFL] Unreviewed Intel bots fix after r149231.
54 * efl/jhbuild.modules: Disable the libxml Python bindings since the
55 bots don't have Python's development files installed. libxml should
56 detect this kind of thing better.
58 2013-04-26 Ryuan Choi <ryuan.choi@samsung.com>
60 [EFL] Build break using jhbuild on ubuntu 13.04
61 https://bugs.webkit.org/show_bug.cgi?id=115225
63 Reviewed by Gyuyoung Kim.
65 libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
66 libxml 2.9.0 has a bug to make regression which r138422 mentioned.
67 So this patch bumped libxml version to 2.9.1.
69 * efl/jhbuild.modules:
71 2013-04-26 Jeffrey Pfau <jpfau@apple.com>
73 delete-stale-build-files does not clear .d files
74 http://bugs.webkit.org/show_bug.cgi?id=115293
76 Reviewed by Ryosuke Niwa.
78 * BuildSlaveSupport/delete-stale-build-files:
79 (main): Add .d to the file type list
81 2013-04-26 Roger Fong <roger_fong@apple.com>
83 Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
84 Make the DebugSuffix configuration use _debug dependencies.
86 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
87 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
88 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
89 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
90 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
91 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
92 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
93 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
94 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
95 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
96 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
97 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
98 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
99 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
100 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
101 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
102 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
103 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
104 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
105 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
106 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
107 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
108 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
109 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
110 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
111 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
112 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
113 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
114 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
115 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
116 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
117 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
118 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
119 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
120 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
121 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
122 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
123 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
124 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
125 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
126 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
127 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
128 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
129 * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
130 * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
131 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
132 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
133 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
134 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
135 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
136 * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
137 * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
138 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
139 * win/AssembleBuildLogs/AssembleLogs.cmd:
140 * win/record-memory/record-memory.vcxproj:
141 * win/record-memory/record-memoryDebug.props:
142 * win/record-memory/record-memoryDebugWinCairo.props:
143 * win/record-memory/record-memoryProduction.props:
144 * win/record-memory/record-memoryRelease.props:
145 * win/record-memory/record-memoryReleaseWinCairo.props:
147 2013-04-26 Zan Dobersek <zdobersek@igalia.com>
149 [GTK] Clean up the TestWebKitAPI GNUmakefile.am
150 https://bugs.webkit.org/show_bug.cgi?id=115233
152 Reviewed by Martin Robinson.
154 Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
155 WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
156 Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
157 Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
158 be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
160 * TestWebKitAPI/GNUmakefile.am:
162 2013-04-25 Andy Estes <aestes@apple.com>
164 [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
165 https://bugs.webkit.org/show_bug.cgi?id=115223
167 Reviewed by Darin Adler.
171 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
172 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
173 (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
174 when it loads a request with a custom protocol.
175 * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
176 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
177 NSURLProtocol subclass to TestProtocol.{h, mm} and did some
178 miscellaneous cleanup.
179 * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
180 * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
181 (+[TestProtocol canInitWithRequest:]):
182 (+[TestProtocol canonicalRequestForRequest:]):
183 (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
184 (+[TestProtocol scheme]):
185 (-[TestProtocol startLoading]):
186 (-[TestProtocol stopLoading]):
188 2013-04-26 Martin Robinson <mrobinson@igalia.com>
190 Remove the remaining Skia #ifdefs
191 https://bugs.webkit.org/show_bug.cgi?id=114886
193 Reviewed by Benjamin Poulain.
195 * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
196 (createBitmapContextFromWebView): Remove Skia #ifdef references.
198 2013-04-26 Mary Wu <mary.wu@torchmobile.com.cn>
200 [BlackBerry] Clean up load interface in WebPage
201 https://bugs.webkit.org/show_bug.cgi?id=113267
203 Reviewed by Rob Buis.
205 Update DumpRenderTree with change of load() interface in WebPage.
206 RIM Bug# 315535, internally reviewed by Joe Mason.
208 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
209 (BlackBerry::WebKit::DumpRenderTree::runTest):
211 2013-04-26 Zan Dobersek <zdobersek@igalia.com>
213 Remove the HeapGraphSerializer unit test
214 https://bugs.webkit.org/show_bug.cgi?id=115231
216 Reviewed by Andreas Kling.
218 Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
219 specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
221 * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
223 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
225 Remove support for Chromium from build/update scripts
226 https://bugs.webkit.org/show_bug.cgi?id=115218
228 Reviewed by Darin Adler.
230 * Scripts/build-webkit:
232 * Scripts/update-webkit:
234 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
236 Remove support for Chromium from api-test
237 https://bugs.webkit.org/show_bug.cgi?id=115211
239 Reviewed by Dirk Pranke.
241 * Scripts/build-api-tests:
242 * Scripts/run-api-tests:
243 (isSupportedPlatform):
245 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
247 Get rid of Chromium in build-dumprendertree
248 https://bugs.webkit.org/show_bug.cgi?id=115212
250 Reviewed by Dirk Pranke.
252 * Scripts/build-dumprendertree:
254 2013-04-25 Alexey Proskuryakov <ap@apple.com>
256 Pass relatedPage when creating a page in WebKitTestRunner
257 https://bugs.webkit.org/show_bug.cgi?id=115206
259 Reviewed by Geoffrey Garen.
261 To make sure that window.open() opens in the same process even when using multiple processes.
263 * WebKitTestRunner/PlatformWebView.h:
264 * WebKitTestRunner/TestController.cpp:
265 (WTR::TestController::createOtherPage):
266 (WTR::TestController::createWebViewWithOptions):
267 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
268 (WTR::PlatformWebView::PlatformWebView):
269 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
270 (WTR::PlatformWebView::PlatformWebView):
271 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
272 (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
273 (WTR::PlatformWebView::PlatformWebView):
274 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
275 (WTR::PlatformWebView::PlatformWebView):
276 * WebKitTestRunner/win/PlatformWebViewWin.cpp:
277 (WTR::PlatformWebView::PlatformWebView):
279 2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
281 Fix autocompletion for Benjamin. The Bugzilla email address must come first.
283 * Scripts/webkitpy/common/config/contributors.json:
285 2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
287 Build fix. Forgot to merge args.
289 * Scripts/webkitpy/tool/bot/irc_command.py:
292 2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
294 webkitbot should recognize its own nickname in greetings.
295 https://bugs.webkit.org/show_bug.cgi?id=115196
297 Reviewed by Andreas Kling.
299 Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
301 * Scripts/webkitpy/tool/bot/irc_command.py:
304 2013-04-25 Xavier Castano <xcastanho@igalia.com>
306 [GTK] Tools/gtk/install-dependencies added ragel dependency
307 https://bugs.webkit.org/show_bug.cgi?id=115163
309 Reviewed by Xan Lopez.
311 The install-dependencies script was missing a dependency on ragel
312 which is expected when building HarfBuzz.
314 * gtk/install-dependencies: Added a dependency on ragel for both
317 2013-04-25 Eduardo Lima Mitev <elima@igalia.com>
319 [GTK] Remove pango from optional jhbuild dependencies
320 https://bugs.webkit.org/show_bug.cgi?id=115162
322 Reviewed by Martin Robinson.
324 Pango is not needed since revision r148293 that lowers the pango
325 dependency to 1.30, which is available in most distributions.
327 * gtk/jhbuild-optional.modules: Removes description of pango module.
329 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
331 Remove Chromium-specific cases from FeatureList.pm
332 https://bugs.webkit.org/show_bug.cgi?id=115169
334 Reviewed by Andreas Kling.
336 * Scripts/webkitperl/FeatureList.pm:
338 2013-04-24 Seokju Kwon <seokju.kwon@gmail.com>
340 Remove checking chromium from run-webkit-tests
341 https://bugs.webkit.org/show_bug.cgi?id=115139
343 Reviewed by Benjamin Poulain.
345 * Scripts/run-webkit-tests:
346 (useNewRunWebKitTests):
348 2013-04-24 Simon Fraser <simon.fraser@apple.com>
350 Pixel tests in SVG are all broken in WK2
351 https://bugs.webkit.org/show_bug.cgi?id=114218
353 Reviewed by Darin Adler.
355 Window snapshots in WebKitTestRunner on Mac are window-sized
356 (800x600), which is wrong for the W3C SVG tests that require a
359 Fix by resizing the window, as well as the web view in
360 PlatformWebView::resizeTo() so that window snapshots are correctly
363 Also do some drive-by cleanup of the window size constants in both
364 DRT and WTR to remove magic numbers, and make the code more similar.
366 * DumpRenderTree/TestRunner.cpp:
367 (TestRunner::setShouldPaintBrokenImage):
368 * DumpRenderTree/TestRunner.h:
369 * DumpRenderTree/efl/DumpRenderTree.cpp:
370 * DumpRenderTree/gtk/DumpRenderTree.cpp:
371 (webInspectorShowWindow):
372 * DumpRenderTree/mac/DumpRenderTree.mm:
373 (createWebViewAndOffscreenWindow):
374 (sizeWebViewForCurrentTest):
375 * DumpRenderTree/mac/DumpRenderTreeMac.h:
376 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
377 (createPagedBitmapContext):
378 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
379 (DumpRenderTree::DumpRenderTree):
380 (DumpRenderTree::open):
381 * DumpRenderTree/qt/TestRunnerQt.cpp:
382 * DumpRenderTree/qt/TestRunnerQt.h:
383 * DumpRenderTree/win/DumpRenderTree.cpp:
384 (sizeWebViewForCurrentTest):
385 * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
386 * WebKitTestRunner/TestController.cpp:
387 (WTR::TestController::resetStateToConsistentValues):
388 * WebKitTestRunner/TestController.h:
389 * WebKitTestRunner/TestInvocation.cpp:
390 (WTR::sizeWebViewForCurrentTest):
391 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
392 (WTR::PlatformWebView::PlatformWebView):
393 (WTR::PlatformWebView::resizeTo):
395 2013-04-24 Byungwoo Lee <bw80.lee@samsung.com>
397 [EFL] Fix build error after r148963.
398 https://bugs.webkit.org/show_bug.cgi?id=115126
400 Reviewed by Laszlo Gombos.
402 Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
404 * TestWebKitAPI/PlatformEfl.cmake:
406 2013-04-24 Carlos Garcia Campos <cgarcia@igalia.com>
408 [GTK] Use stamp files for generate-forwarding-headers makefile rules
409 https://bugs.webkit.org/show_bug.cgi?id=115118
411 Reviewed by Martin Robinson.
413 Use a stamp file for the TestWebKitAPI and WebKitTestRunner
414 forwarding generator rules and don't call it for soup since there
415 aren't soup directories in TestWebKitAPI and WebKitTestRunner.
417 * TestWebKitAPI/GNUmakefile.am:
418 * WebKitTestRunner/GNUmakefile.am:
420 2013-04-24 Simon Pena <simon.pena@samsung.com>
422 [GTK] Update build dependencies
423 https://bugs.webkit.org/show_bug.cgi?id=115111
425 Reviewed by Martin Robinson.
427 The install-dependencies script was missing a dependency on EGL,
428 which is expected when building Cairo.
430 * gtk/install-dependencies: Added a dependency on libegl1-mesa
431 for both apt and yum.
433 2013-04-24 Seokju Kwon <seokju.kwon@gmail.com>
435 Remove the Chromium-specific helper from run_webkit_tests.py
436 https://bugs.webkit.org/show_bug.cgi?id=114996
438 Reviewed by Dirk Pranke.
440 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
443 2013-04-24 Sergio Correia <sergio.correia@openbossa.org>
445 [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
446 https://bugs.webkit.org/show_bug.cgi?id=114850
448 Reviewed by Andreas Kling.
450 Revision r148312 fixed WebPageProxy cleanup and also changed the process
451 termination semantics when requested by the user so that a client is not
452 notified of a crash anymore, since there was no crash anyway.
454 That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
455 relied on being notified of a crash after calling WKPageTerminate(). As
456 a result of not being notified of such non-existent crash, the test would
457 timeout right after making the terminate call.
459 This patch adds an InjectedBundle to be used for simulating a crash, by
460 calling abort() upon receiving a "Crash" message, and thus we are able to
461 keep testing the crash callback.
463 This patch also re-enables the WKViewClientWebProcessCallbacks test, which
464 had been disabled in revisions r148858 and r148855, since it was failing.
466 * TestWebKitAPI/PlatformEfl.cmake:
467 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
468 (TestWebKitAPI::TEST):
469 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
471 (WKViewClientWebProcessCallbacksTest):
472 (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
473 (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
475 2013-04-24 Christophe Dumez <ch.dumez@sisa.samsung.com>
477 [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
478 https://bugs.webkit.org/show_bug.cgi?id=115095
480 Reviewed by Antonio Gomes.
482 Use different subfolders under DumpRenderTree Temp folder for every
483 functionality (icon database, cache, localstorage, ...). This makes
484 sure there is no conflict between the functionalities.
486 In EFL's case, libsoup cache was causing problems for the icon
487 database if sharing the same folder.
489 * WebKitTestRunner/TestController.cpp:
490 (WTR::TestController::initialize):
492 == Rolled over to ChangeLog-2013-04-24 ==