Enable SVG page loading performance tests
[WebKit-https.git] / Tools / ChangeLog
1 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Enable SVG page loading performance tests
4         https://bugs.webkit.org/show_bug.cgi?id=83861
5
6         Reviewed by Adam Barth.
7
8         Add support for page loading tests. These are tests without any test running harnesses, and we use
9         DriverOutput's test_timeout to measure the loading time.
10
11         Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.
12
13         * Scripts/webkitpy/performance_tests/perftest.py:
14         (PerfTest.run):
15         (PerfTest):
16         (PerfTest.run_failed):
17         (PerfTest.parse_output):
18         (PerfTest.output_statistics):
19         (ChromiumStylePerfTest.parse_output):
20         (PageLoadingPerfTest): Added.
21         (PageLoadingPerfTest.__init__):
22         (PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
23         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
24         (MockPrinter):
25         (MockPrinter.__init__):
26         (MockPrinter.write):
27         (MainTest):
28         (MainTest.test_parse_output):
29         (MainTest.test_parse_output_with_failing_line):
30         (TestPageLoadingPerfTest):
31         (TestPageLoadingPerfTest.assertWritten):
32         (TestPageLoadingPerfTest.MockDriver):
33         (TestPageLoadingPerfTest.MockDriver.__init__):
34         (TestPageLoadingPerfTest.MockDriver.run_test):
35         (TestPageLoadingPerfTest.test_run):
36         (TestPageLoadingPerfTest.test_run_with_bad_output):
37         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
38         (PerfTestsRunner):
39         (PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
40         (PerfTestsRunner._collect_tests):
41         (PerfTestsRunner._run_tests_set):
42         (PerfTestsRunner._run_single_test):
43         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
44         (test_collect_tests_with_page_load_svg):
45         (test_collect_tests_with_page_load_svg.add_file):
46
47 2012-04-10  Brady Eidson  <beidson@apple.com>
48
49         <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600
50         Need WebKit2 API to notify whether history loads are in the page cache
51
52         Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
53         callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
54
55         Reviewed by Darin Adler.
56
57         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
58         (TestWebKitAPI::didFinishLoadForFrame):
59         (TestWebKitAPI::willGoToBackForwardListItem):
60         (TestWebKitAPI::setPageLoaderClient):
61         (TestWebKitAPI::TEST):
62         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
63         (ShouldGoToBackForwardListItemTest):
64         (TestWebKitAPI::shouldGoToBackForwardListItemCallback):
65         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
66         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
67         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
68
69         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
70         (WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
71
72 2012-04-13  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
73
74         Group EFL bots into a category on the buildbot master
75         https://bugs.webkit.org/show_bug.cgi?id=82712
76
77         Reviewed by Adam Roben.
78
79         Creating a new category definition on the buildbot frontend.
80
81         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
82         (loadBuilderConfig): Determine category for EFL bots
83         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
84
85 2012-04-13  Sheriff Bot  <webkit.review.bot@gmail.com>
86
87         Unreviewed, rolling out r113714.
88         http://trac.webkit.org/changeset/113714
89         https://bugs.webkit.org/show_bug.cgi?id=83887
90
91         It is behaving strange on the bots and needs more
92         investigation. (Requested by jeez_ on #webkit).
93
94         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
95         (WTR::PlatformWebView::PlatformWebView):
96
97 2012-04-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
98
99         webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
100         https://bugs.webkit.org/show_bug.cgi?id=83690
101
102         Reviewed by Tor Arne Vestbø.
103
104         Typing part of an email and pressing <TAB> will bash-complete it using the list in
105         Tools/Scripts/webkitpy/common/config/committers.py
106
107         * Scripts/webkit-tools-completion.sh:
108
109 2012-04-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
110
111         [EFL] Add API for color chooser
112         https://bugs.webkit.org/show_bug.cgi?id=83692
113
114         Enables INPUT_TYPE_COLOR by default on the EFL port.
115
116         Reviewed by Kenneth Rohde Christiansen.
117
118         * Scripts/build-webkit:
119
120 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
121
122         Extract PerfTest class from PerfTestRunner
123         https://bugs.webkit.org/show_bug.cgi?id=83847
124
125         Reviewed by Hajime Morita.
126
127         Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
128         that was previously represented by a tuple.
129
130         Also moved the logic to determine whether a given test is chromium style or not from run() to
131         _collect_tests(). And moved the output parsing algorithms for parser style and chromium style
132         tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
133         add new types of tests more easily.
134
135         * Scripts/webkitpy/performance_tests/perftest.py: Added.
136         (PerfTest):
137         (PerfTest.__init__):
138         (PerfTest.test_name):
139         (PerfTest.dirname):
140         (PerfTest.path_or_url):
141         (PerfTest._should_ignore_line_in_parser_test_result):
142         (PerfTest.parse_output):
143         (ChromiumStylePerfTest):
144         (ChromiumStylePerfTest.__init__):
145         (ChromiumStylePerfTest.parse_output):
146         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
147         (PerfTestsRunner._collect_tests):
148         (PerfTestsRunner.run):
149         (PerfTestsRunner._run_tests_set):
150         (PerfTestsRunner._run_single_test):
151         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
152         (run_test):
153         (_tests_for_runner):
154         (test_run_test_set_with_json_output):
155         (test_run_test_set_with_json_source):
156         (test_run_test_set_with_multiple_repositories):
157         (_collect_tests_and_sort_test_name):
158         (test_collect_tests):
159         (test_collect_tests_with_skipped_list):
160
161 2012-04-12  Balazs Kelemen  <kbalazs@webkit.org>
162
163         [Qt] Fix WebKit1 build with V8
164         https://bugs.webkit.org/show_bug.cgi?id=83322
165
166         Reviewed by Adam Barth.
167
168         * DumpRenderTree/qt/DumpRenderTree.pro:
169         * qmake/mkspecs/features/default_post.prf:
170         * qmake/mkspecs/features/default_pre.prf:
171         * qmake/mkspecs/features/features.prf:
172
173 2012-04-12  Dirk Pranke  <dpranke@chromium.org>
174
175         test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
176         https://bugs.webkit.org/show_bug.cgi?id=83583
177
178         Reviewed by Philippe Normand
179
180         Updated the unit test to ignore the hours and minutes of the
181         localtime for time(0), since we can't easily guarantee which
182         timezone we're in or what timezone rules were in effect on
183         1/1/1970; this should be mostly fine since we can trust that
184         time.localtime() will work, although there is the possibility
185         that we'll screw up the time formatting of which field is the
186         hours and which is the minutes.
187
188         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
189         (VerboseTest):
190         (VerboseTest.test_basic):
191         (VerboseTest.test_log_after_update):
192
193 2012-04-12  Dominik Rottsches  <dominik.rottsches@linux.intel.com>
194
195         Add an EFL Debug Buildbot to the master configuration
196         https://bugs.webkit.org/show_bug.cgi?id=82711
197
198         Forgot to add EFL Linux Debug to scheduler.
199
200         Reviewed by Philippe Normand.
201
202         * BuildSlaveSupport/build.webkit.org-config/config.json:
203
204 2012-04-12  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
205
206         Add an EFL Debug Buildbot to the master configuration
207         https://bugs.webkit.org/show_bug.cgi?id=82711
208
209         Reviewed by Philippe Normand.
210
211         Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.
212
213         * BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
214
215 2012-04-12  George Staikos  <staikos@webkit.org>
216
217         Enable the fullscreen API for BlackBerry.
218         https://bugs.webkit.org/show_bug.cgi?id=83757
219
220         Reviewed by Antonio Gomes.
221
222         * Scripts/build-webkit:
223
224 2012-04-12  Simon Pena  <spena@igalia.com>
225
226         [GTK] Test runner crashes without recent versions of pulseaudio-utils
227         https://bugs.webkit.org/show_bug.cgi?id=83774
228
229         Reviewed by Philippe Normand.
230
231         Besides checking that pactl is available, check also that its output
232         is the expected one, and handle gracefully when it isn't, when
233         trying to unload pulseaudio modules.
234
235         * Scripts/webkitpy/layout_tests/port/gtk.py:
236         (GtkPort._unload_pulseaudio_module):
237         (GtkPort._restore_pulseaudio_module):
238
239 2012-03-05  Pierre Rossi  <pierre.rossi@gmail.com>
240
241         [Qt] Use QRawFont when building with Qt 5
242         https://bugs.webkit.org/show_bug.cgi?id=78001
243
244         Flip the QRawFont switch for Qt 5.
245
246         Reviewed by Simon Hausmann.
247
248         * qmake/mkspecs/features/features.prf:
249
250 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
251
252         Web Inspector: Disabling Inspector causes build failure on Windows
253         https://bugs.webkit.org/show_bug.cgi?id=83557
254
255         Reviewed by Pavel Feldman.
256
257         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
258         This change brings all such API calls under the guard.
259
260         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
261         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
262         (WTR):
263         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
264         (LayoutTestController):
265         * WebKitTestRunner/TestInvocation.cpp:
266         (WTR::TestInvocation::invoke):
267
268 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
269
270         Fix regression introduced in r113927.
271
272         Unreviewed, build fix.
273
274         I failed to rename skipped_tests() to skipped_layout_tests()
275         everywhere it needed to be renamed. The unit tests didn't catch
276         this because the TestPort was one of the places that didn't get
277         renamed :(.
278
279         * Scripts/webkitpy/layout_tests/controllers/manager.py:
280         (Manager.parse_expectations):
281         * Scripts/webkitpy/layout_tests/port/test.py:
282         (TestPort.skipped_layout_tests):
283         * Scripts/webkitpy/tool/commands/queries.py:
284         (PrintExpectations._model):
285
286 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
287
288         new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
289         https://bugs.webkit.org/show_bug.cgi?id=47528
290
291         Reviewed by Adam Barth.
292
293         The skipped-ports command has been replaced by 'webkit-patch
294         print-expectations', which offers the equivalent functionality
295         via 'webkit-patch print-expectations --platform \* -t skip'
296         (and other features, of course).
297         
298         This also allows me to fix a nasty layering violation where the
299         chromium port had to know about the TestExpectations objects in
300         order to implement the command properly.
301
302         Lastly, this allows me to rename skipped_tests() to
303         skipped_layout_tests() to more consistent with
304         skipped_perf_tests().
305         
306         This patch removes skips_layout_test() from the Port interface,
307         because that can't be implemented without the port knowing about
308         Expectations objects (and skipped-ports was the only thing using it).
309
310         * Scripts/webkitpy/layout_tests/port/base.py:
311         (Port.skipped_layout_tests):
312         (Port.skipped_perf_tests):
313         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
314         (PortTest.test_default_configuration_notfound):
315         * Scripts/webkitpy/layout_tests/port/chromium.py:
316         (ChromiumPort.test_expectations_overrides):
317         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
318         (ChromiumPortTest.test_path_to_image_diff):
319         * Scripts/webkitpy/layout_tests/port/webkit.py:
320         (WebKitPort.skipped_layout_tests):
321         * Scripts/webkitpy/tool/commands/queries.py:
322         (execute):
323         * Scripts/webkitpy/tool/commands/queries_unittest.py:
324         (QueryCommandsTest.test_tree_status):
325
326 2012-04-11  Mark Rowe  <mrowe@apple.com>
327
328         Remove a fprintf from LayoutTestController.
329
330         This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
331         It was added for no apparent reason by Ryosuke in r113651.
332
333         * DumpRenderTree/LayoutTestController.cpp:
334         (LayoutTestController::redirectionDestinationForURL):
335
336 2012-04-11  Nico Weber  <thakis@chromium.org>
337
338         [mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
339         https://bugs.webkit.org/show_bug.cgi?id=83709
340
341         Reviewed by Anders Carlsson.
342
343         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
344         (handleEventCarbon):
345
346 2012-04-11  Rafael Brandao  <rafael.lobo@openbossa.org>
347
348         Adding myself to committers.py
349         https://bugs.webkit.org/show_bug.cgi?id=83711
350
351         Unreviewed update to committers.py.
352
353         * Scripts/webkitpy/common/config/committers.py:
354
355 2012-04-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
356
357         [EFL] LayoutTestController needs implementation of pageProperty
358         https://bugs.webkit.org/show_bug.cgi?id=82449
359
360         Add missing implementation pageProperty to EFL's LayoutTestController
361         in order to unskip printing/page-rule-selection.html
362
363         Reviewed by Antonio Gomes.
364
365         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
366         (LayoutTestController::pageProperty):
367
368 2012-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
369
370         Unreviewed, rolling out r113836.
371         http://trac.webkit.org/changeset/113836
372         https://bugs.webkit.org/show_bug.cgi?id=83705
373
374         Broke all the WebKit2 inspector tests (Requested by andersca
375         on #webkit).
376
377         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
378         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
379         (WTR::LayoutTestController::showWebInspector):
380         (WTR::LayoutTestController::closeWebInspector):
381         (WTR::LayoutTestController::evaluateInWebInspector):
382         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
383         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
384         (LayoutTestController):
385         * WebKitTestRunner/TestInvocation.cpp:
386         (WTR::TestInvocation::invoke):
387
388 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
389
390         Web Inspector: Disabling Inspector causes build failure on Windows
391         https://bugs.webkit.org/show_bug.cgi?id=83557
392
393         Reviewed by Pavel Feldman.
394
395         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
396         This change brings all such API calls under the guard.
397
398         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
399         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
400         (WTR):
401         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
402         (LayoutTestController):
403         * WebKitTestRunner/TestInvocation.cpp:
404         (WTR::TestInvocation::invoke):
405
406 2012-04-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
407
408         [Qt][WK2] Manage graphics buffers in the web process
409         https://bugs.webkit.org/show_bug.cgi?id=78675
410  
411         Make graphics surface available only for Qt 5, attempting to fix
412         the Qt-mac build.
413
414         Unreviewed build fix.
415
416         * qmake/mkspecs/features/features.prf:
417
418 2012-04-11  Philippe Normand  <pnormand@igalia.com>
419
420         Unreviewed, GTK NRWT follow-up fix after r113849.
421
422         * Scripts/webkitpy/layout_tests/port/gtk.py:
423         (GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.
424
425 2012-04-11  Simon Pena  <spena@igalia.com>
426
427         [GTK] media/event-attributes.html fails
428         https://bugs.webkit.org/show_bug.cgi?id=71662
429
430         Reviewed by Philippe Normand.
431
432         PulseAudio's module "module-stream-restore" allows saving the volume
433         of a stream, restoring it the next time it runs.
434         This affects the tests, since DumpRenderTree's volume settings are
435         saved between test runs, and tests relying on specific volume values
436         would miss some volumeChange events (or get additional ones).
437
438         This patch hooks on the existing GtkPort setup_test_run method and
439         creates a new clean_up_test_run method, so PulseAudio's module is
440         unloaded (if found) before running the tests, and restored (if it
441         was there previously) after they finished, ensuring the tests run in
442         the right environment.
443
444         * Scripts/webkitpy/layout_tests/controllers/manager.py:
445         (Manager._clean_up_run): Invoke the port implementation of
446         clean_up_test_run.
447         * Scripts/webkitpy/layout_tests/port/base.py:
448         (Port.clean_up_test_run): Add an empty implementation of
449         clean_up_test_run.
450         * Scripts/webkitpy/layout_tests/port/gtk.py:
451         (GtkPort._unload_pulseaudio_module): Unloads the offending
452         pulseaudio module, if found.
453         (GtkPort):
454         (GtkPort._restore_pulseaudio_module): Restores the offending
455         pulseaudio module, if it was there previously.
456         (GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
457         (GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.
458
459 2012-04-11  Andras Becsi  <andras.becsi@nokia.com>
460
461         Fix the build with gcc 4.7.0
462         https://bugs.webkit.org/show_bug.cgi?id=83584
463
464         Reviewed by Alexey Proskuryakov.
465
466         * qmake/mkspecs/features/unix/default_post.prf:
467         The -fuse-ld=gold option is not supported with upstream gcc.
468
469 2012-04-11  Ryosuke Niwa  <rniwa@webkit.org>
470
471         Refactor PerfTestRunner to include file extensions in test names
472         https://bugs.webkit.org/show_bug.cgi?id=83677
473
474         Reviewed by Hajime Morita.
475
476         Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.
477
478         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
479         (PerfTestsRunner._collect_tests):
480         (PerfTestsRunner._run_tests_set):
481         (PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
482         We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', '', test_name)" here.
483         (PerfTestsRunner._run_single_test):
484         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
485         (run_test):
486         (_tests_for_runner):
487         (test_run_test_set):
488         (test_run_test_set_kills_drt_per_run):
489         (test_run_test_pause_before_testing):
490         (test_run_test_set_for_parser_tests):
491         (test_collect_tests):
492         (test_collect_tests_with_skipped_list):
493
494 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
495
496         Web Inspector: Disabling Inspector causes build failure on Windows
497         https://bugs.webkit.org/show_bug.cgi?id=83557
498
499         Reviewed by Pavel Feldman.
500
501         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
502         This change brings all such API calls under the guard.
503
504         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
505         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
506         (WTR):
507         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
508         (LayoutTestController):
509         * WebKitTestRunner/TestInvocation.cpp:
510         (WTR::TestInvocation::invoke):
511
512 2012-04-10  Kent Tamura  <tkent@chromium.org>
513
514         Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.
515
516         * Scripts/webkitpy/common/config/watchlist:
517         * Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
518
519 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
520
521         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
522         https://bugs.webkit.org/show_bug.cgi?id=82799
523
524         Reviewed by Ojan Vafai.
525
526         The tests we were skipping in _mark_interrupted_tests_as_skipped
527         had incorrectly-constructed TestResults, and so they were not
528         being treated as failures. The JSON generator doesn't record
529         tests that are passed or skiped in incremental_results, so you
530         couldn't tell these tests were being skipped at all.
531
532         This change changes _mark_interrupted_tests_as_skipped() to
533         treat the skipped tests as failures; this is arguably still
534         incorrect but is minimally invasive for now. We probably need to
535         revisit how we are uploading information about tests that are
536         skipped and passed altogether in a separate change.
537
538         This change also cleans up a couple of other nits that were
539         unnecessary or broken in this same code path.
540
541         * Scripts/webkitpy/layout_tests/controllers/manager.py:
542         (Manager._mark_interrupted_tests_as_skipped):
543         (Manager._upload_json_files): Deletes the check for
544         chromium-mac-leopard (as it is no longer necessary).
545         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
546         (JSONLayoutResultsGenerator.__init__): Here we were
547         recalculating the failure type unnecessarily.
548         * Scripts/webkitpy/layout_tests/models/test_failures.py:
549         (determine_result_type):
550         (FailureEarlyExit): Adds a new failure type so we can tell what
551         happened.
552         (FailureEarlyExit.message):
553         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
554         (MainTest.test_exit_after_n_failures_upload): Add more checks to
555         ensure that we are recording the SKIP correctly; this is less
556         than ideal, because we can't actually test the contents of
557         incremental_results.json. We should fix that at some point.
558
559 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
560
561         make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
562         https://bugs.webkit.org/show_bug.cgi?id=83401
563
564         Reviewed by Adam Barth.
565
566         Last patch in the series - no longer look in mac-leopard,
567         mac-snowleopard, or mac-lion.
568
569         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
570         (ChromiumMacPort):
571         * TestResultServer/static-dashboards/flakiness_dashboard.html:
572
573 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
574
575         webkit-patch: add a print-expectations command
576         https://bugs.webkit.org/show_bug.cgi?id=83347
577
578         Reviewed by Adam Barth.
579
580         This command will print the expected results for a given set of
581         tests on a given set of ports matching a given set of keywords.
582
583         Example output (printing all the tests not expected to pass, and their
584         expected results, on a Mac):
585
586         $ webkit-patch print-expectations -x pass fast/html
587         // For mac-snowleopard
588         fast/html/details-open4.html = TEXT
589         fast/html/details-open2.html = TEXT
590         fast/html/details-no-summary4.html = TEXT
591         fast/html/details-open-javascript.html = TEXT
592         $
593
594         You can also print full test-expectatons.txt lines using --full and a
595         CSV-style report (which can be useful for post-processing) using --csv.
596
597         It will replace the 'skipped-files' command (which will be
598         removed in a subsequent patch) and is a more general (and
599         cleaner and properly layered) solution.
600
601         Also add an update() command to MockOptions() to make overriding keywords easier.
602
603         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
604         (TestExpectationSerializer.to_string):
605         (TestExpectationSerializer):
606         (TestExpectationSerializer.to_csv):
607         (TestExpectationSerializer._format_result):
608         (TestExpectationLine.create_passing_expectation):
609         (TestExpectationsModel.get_test_set_for_keyword):
610         (TestExpectationsModel.has_keyword):
611         (TestExpectations.model):
612         * Scripts/webkitpy/tool/commands/queries.py:
613         (execute):
614         (PrintExpectations):
615         (PrintExpectations.__init__):
616         (PrintExpectations.execute):
617         (PrintExpectations._filter_tests):
618         (PrintExpectations._format_lines):
619         (PrintExpectations._model):
620         * Scripts/webkitpy/tool/commands/queries_unittest.py:
621         (TestPrintExpectations): Added.
622         * Scripts/webkitpy/tool/mocktool.py:
623         (MockOptions):
624         (MockOptions.__init__):
625         (MockOptions.update): Added.
626
627 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
628
629         webkitpy: refactor handling of --platform and related options
630         https://bugs.webkit.org/show_bug.cgi?id=83525
631
632         Reviewed by Adam Barth.
633
634         This change moves to centralize handling of --platform, --debug,
635         --gtk, and other similar flags into a central place next to the
636         code that actually uses those flags in PortFactory to get the
637         right Port object.
638
639         * Scripts/webkitpy/layout_tests/port/__init__.py:
640         * Scripts/webkitpy/layout_tests/port/factory.py:
641         (port_options):
642         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
643         (parse_args):
644         * Scripts/webkitpy/tool/commands/queries.py:
645         (PrintBaselines.__init__):
646
647 2012-04-10  Ojan Vafai  <ojan@chromium.org>
648
649         Add a chromeless view to the individual tests view
650         https://bugs.webkit.org/show_bug.cgi?id=83541
651
652         Reviewed by Daniel Bates.
653
654         This is the view suitable to inlining in other contexts (e.g. garden-o-matic).
655
656         * TestResultServer/static-dashboards/flakiness_dashboard.html:
657         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
658         (testHtmlForIndividualTestOnAllBuilders):
659         (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
660         (testHtmlForIndividualTestOnAllBuildersWithChrome):
661         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
662         (testHtmlForIndividualTests):
663         (htmlEscape):
664         (runTests):
665
666 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
667
668         remove 'win' from chromium-win, chromium-linux fallback paths
669         https://bugs.webkit.org/show_bug.cgi?id=83613
670
671         Reviewed by Ojan Vafai.
672
673         The chromium ports no longer need to look at the apple 'win'
674         directory for baseline results.
675
676         Also remove the old '-gpu-' entries from the flakiness dashboard
677         map since I'm touching lines nearby.
678
679         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
680         (ChromiumLinuxPort):
681         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
682         (ChromiumWinPort):
683         * TestResultServer/static-dashboards/flakiness_dashboard.html:
684
685 2012-04-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
686
687         [Qt][WK2] Manage graphics buffers in the web process
688         https://bugs.webkit.org/show_bug.cgi?id=78675
689
690         Enable graphics surfaces on Mac for Qt.
691
692         Reviewed by Kenneth Rohde Christiansen.
693
694         * qmake/mkspecs/features/features.prf:
695
696 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
697
698         [CMake] Enable USE_FOLDERS property
699         https://bugs.webkit.org/show_bug.cgi?id=83571
700
701         Reviewed by Daniel Bates.
702
703         Setting the FOLDER property on targets gives more structure
704         to the generated Visual Studio solutions.
705         This does not affect other CMake generators.
706
707         * DumpRenderTree/efl/CMakeLists.txt:
708         * EWebLauncher/CMakeLists.txt:
709         * WinCELauncher/CMakeLists.txt:
710
711 2012-04-10  David Dorwin  <ddorwin@chromium.org>
712
713         Add Encrypted Media Extensions methods to HTMLMediaElement
714         https://bugs.webkit.org/show_bug.cgi?id=82971
715
716         Reviewed by Adam Barth.
717
718         The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
719         Implementation is based on v0.1 of the draft proposal at
720         http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.
721
722         * DumpRenderTree/chromium/TestShell.cpp:
723         (TestShell::TestShell):
724
725 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
726
727         [EFL][DRT] Catch the "title,changed" signal
728         https://bugs.webkit.org/show_bug.cgi?id=82174
729
730         Reviewed by Gustavo Noronha Silva.
731
732         EFL's DumpRenderTree now catches the "title,changed" signal, and
733         prints out the needed information.
734
735         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
736         (DumpRenderTreeChrome::onTitleChanged):
737
738 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
739
740         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
741         https://bugs.webkit.org/show_bug.cgi?id=82443
742
743         Reviewed by Philippe Normand.
744
745         EFL's DRT needs to support LayoutTestController's
746         willSendRequestReturnsNull() and return NULL when expected. This
747         allows for several tests to be removed from the skip list.
748
749         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
750         (DumpRenderTreeChrome::onWillSendRequest):
751
752 2012-04-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
753
754         [EFL] LayoutTestController needs implementation of addUserStyleSheet
755         https://bugs.webkit.org/show_bug.cgi?id=82446
756
757         Adding missing implementation addUserStyleSheet to EFL's LayoutTestController 
758         so that we can unskip related tests from the skip list. 
759
760         Reviewed by Antonio Gomes.
761
762         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
763         (LayoutTestController::addUserStyleSheet): Implemented.
764
765 2012-04-10  Philip Rogers  <pdr@google.com>
766
767         Adding myself to committers.py!
768
769         Unreviewed update to committers.py.
770
771         * Scripts/webkitpy/common/config/committers.py:
772
773 2012-04-10  Dinu Jacob  <dinu.jacob@nokia.com>
774
775         [Qt][WK2] Title in MiniBrowser is not updated for a page with no title
776         https://bugs.webkit.org/show_bug.cgi?id=82483
777
778         Reviewed by Kenneth Rohde Christiansen.
779
780         Set window title to default if there is no page title.
781
782         * MiniBrowser/qt/BrowserWindow.cpp:
783         (BrowserWindow::BrowserWindow):
784         (BrowserWindow::onTitleChanged):
785         * MiniBrowser/qt/BrowserWindow.h:
786         (BrowserWindow):
787
788 2012-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
789
790         [Qt][WK2] Implement PageClient::isViewWindowActive()
791         https://bugs.webkit.org/show_bug.cgi?id=81143
792
793         Reviewed by Kenneth Rohde Christiansen.
794
795         Fix the WrapperWindow from our PlatformWebView
796         so it correctly creates the platform related
797         stuff for QWindow, which is not created unless
798         QWindow::setVisible() or QWindow::show() are called.
799
800         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
801         (WTR::PlatformWebView::PlatformWebView):
802
803 2012-04-10  Balazs Kelemen  <kbalazs@webkit.org>
804
805         [Qt][WK2] TestNetscapePlugin is broken
806         https://bugs.webkit.org/show_bug.cgi?id=83024
807
808         Reviewed by Csaba Osztrogonác.
809
810         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
811         Fix X11 availability check. embedded is always true with QPA.
812         * Tools.pro:
813         Build the test plugin if plugins are enabled for WebKit2.
814         * qmake/mkspecs/features/features.prf:
815         * qmake/mkspecs/features/functions.prf:
816         Added a convenience function to determine availability
817         of X11 libraries.
818
819 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
820
821         [WIN] Fix build without precompiled header.
822
823         * DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
824
825 2012-04-10  Arko Saha  <arko@motorola.com>
826
827         Unreviewed: adding myself to committers.py.
828
829         * Scripts/webkitpy/common/config/committers.py:
830
831 2012-04-09  Kaustubh Atrawalkar  <kaustubh@motorola.com>
832
833         Unreviewed: adding myself to committers.py.
834
835         * Scripts/webkitpy/common/config/committers.py:
836
837 2012-04-09  Sheriff Bot  <webkit.review.bot@gmail.com>
838
839         Unreviewed, rolling out r113656.
840         http://trac.webkit.org/changeset/113656
841         https://bugs.webkit.org/show_bug.cgi?id=83542
842
843         test is broken on chromium-win (Requested by simonjam on
844         #webkit).
845
846         * DumpRenderTree/chromium/WebViewHost.cpp:
847         (WebViewHost::dispatchIntent):
848
849 2012-04-09  Takashi Toyoshima  <toyoshim@chromium.org>
850
851         Update pywebsocket to 0.7.4.
852         https://bugs.webkit.org/show_bug.cgi?id=83461
853
854         Reviewed by Kent Tamura.
855
856         This version supports TLS by using ssl in addition to pyOpenSSL.
857         Other functional difrerences from 0.7.2 are:
858          - strict Sec-WebSocket-Key validation conforming RFC 4648
859          - compression ratio logging in debug
860
861         * Scripts/webkitpy/thirdparty/__init__.py:
862         (AutoinstallImportHook._install_pywebsocket):
863
864 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
865
866         add a webkit-patch print-baselines command
867         https://bugs.webkit.org/show_bug.cgi?id=83348
868
869         Reviewed by Adam Barth.
870
871         This adds a simple 'print-baselines' command to webkit-patch
872         that can be used in one of two forms: to print where the
873         baselines for a given test (or set of tests) on a single port
874         will be found, or to generate a report for multiple ports.
875
876         Example of the former:
877
878         $ webkit-patch print-baselines fast/html/keygen.html
879         // For mac-snowleopard
880         platform/mac/fast/html/keygen-expected.txt
881         platform/mac/fast/html/keygen-expected.png
882         $
883
884         The latter is most useful for finding out which fallback dirs are
885         used by which ports for which tests, for example,
886         'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
887         No example output is given because the reports are pretty wordy :).
888
889         * Scripts/webkitpy/layout_tests/port/base.py:
890         (Port.baseline_extensions): Added.
891         (Port.expected_baseline_dict): Added.
892         * Scripts/webkitpy/tool/commands/queries.py:
893         (PrintBaselines):
894         (PrintBaselines.__init__):
895         (PrintBaselines.execute):
896         (PrintBaselines._print_baselines):
897         (PrintBaselines._platform_for_path):
898
899 2012-04-09  Florin Malita  <fmalita@chromium.org>
900
901         Unreviewed: adding myself to committers.py.
902
903         * Scripts/webkitpy/common/config/committers.py:
904
905 2012-04-09  Ming Xie  <mxie@rim.com>
906
907         [BlackBerry] Allow simulator to use GLES2 acceleration
908         https://bugs.webkit.org/show_bug.cgi?id=81672
909
910         Reviewed by Rob Buis.
911
912         * Scripts/webkitdirs.pm:
913         (blackberryCMakeArguments):
914
915 2012-04-09  Dana Jansens  <danakj@chromium.org>
916
917         Mark myself as a committer
918         https://bugs.webkit.org/show_bug.cgi?id=83510
919
920         Reviewed by Adrienne Walker.
921
922         * Scripts/webkitpy/common/config/committers.py:
923
924 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
925
926         nrwt is failing to upload test results on the chromium-mac-leopard bots
927         https://bugs.webkit.org/show_bug.cgi?id=83230
928
929         Unreviewed, build fix.
930
931         It looks like the change in r113399 to use the per-request
932         timeout variable didn't actually work, so I am removing the
933         timeout code altogether and counting on the idea that upload
934         just isn't likely to take that long and the timeouts and
935         retransmits are largely unused and largely unnecessary. We'll
936         see if this breaks anywhere else.
937
938         * Scripts/webkitpy/common/net/file_uploader.py:
939         (FileUploader.__init__):
940         (FileUploader._upload_data.callback):
941         (FileUploader):
942
943 2012-04-09  Rob Buis  <rbuis@rim.com>
944
945         [BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
946         https://bugs.webkit.org/show_bug.cgi?id=83469
947
948         Reviewed by Dirk Schulze.
949
950         Remove WTF:: prefixes and fix a warning with the length variable.
951
952         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
953         (jsStringRefToWebCoreString):
954         (LayoutTestController::execCommand):
955         (LayoutTestController::isCommandEnabled):
956         (LayoutTestController::setUserStyleSheetLocation):
957         (LayoutTestController::counterValueForElementById):
958         (LayoutTestController::overridePreference):
959         (LayoutTestController::setMockGeolocationError):
960         (LayoutTestController::findString):
961
962 2012-04-09  Patrick Gansterer  <paroga@webkit.org>
963
964         Build fix for WinCE after r113570.
965
966         * Scripts/build-webkit: Do not use FastMalloc for WinCE.
967
968 2012-04-09  Eric Carlson  <eric.carlson@apple.com>
969
970         Subscribe eric.carlson@apple.com to Media-related changes
971         https://bugs.webkit.org/show_bug.cgi?id=83421
972
973         Reviewed by Dan Bernstein.
974
975         * Scripts/webkitpy/common/config/watchlist:
976
977 2012-04-09  Martin Robinson  <mrobinson@igalia.com>
978
979         check-webkit-style should ignore NULL usage in gtk_style_context_get_style
980         https://bugs.webkit.org/show_bug.cgi?id=83412
981
982         Reviewed by David Levin.
983
984         Accept NULL as an argument for gtk_style_context_get_style, because it's
985         used as a sentinel in a variable argument list. 
986
987         * Scripts/webkitpy/style/checkers/cpp.py:
988         (check_for_null): Add an exception.
989         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
990         (WebKitStyleTest.test_null_false_zero): Add a test for the exception.
991
992 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
993
994         webkitpy: use the filesystem object properly in fileuploader
995         https://bugs.webkit.org/show_bug.cgi?id=83326
996
997         Reviewed by Adam Barth.
998
999         We should be using the filesystem object rather than the codecs
1000         object.
1001
1002         * Scripts/webkitpy/common/net/file_uploader.py:
1003         (FileUploader.upload_as_multipart_form_data):
1004
1005 2012-04-09  Eric Seidel  <eric@webkit.org>
1006
1007         Enable webkit_unit_tests for commit queue and EWS while tracking failures
1008         https://bugs.webkit.org/show_bug.cgi?id=83329
1009
1010         Unreviewed.  Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
1011
1012         line 62, in _create_unit_test_results
1013          return UnitTestResults.results_from_string(results_xml)
1014          NameError: global name 'UnitTestResults' is not defined
1015
1016         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1017         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1018         (LayoutTestResultsReaderTest.test_create_unit_test_results):
1019
1020 2012-04-08  Adam Barth  <abarth@webkit.org>
1021
1022         The port object is missing unit_tests_results_path
1023         https://bugs.webkit.org/show_bug.cgi?id=83448
1024
1025         Unreviewed.
1026
1027         This is causing the cr-linux-ews to throw an exception.
1028
1029         * Scripts/webkitpy/common/config/ports.py:
1030         (DeprecatedPort.unit_tests_results_path):
1031
1032 2012-04-07  Patrick Gansterer  <paroga@webkit.org>
1033
1034         [CMake] Cleanup WTF include directories
1035         https://bugs.webkit.org/show_bug.cgi?id=82716
1036
1037         Reviewed by Eric Seidel.
1038
1039         * DumpRenderTree/efl/CMakeLists.txt:
1040         * WinCELauncher/CMakeLists.txt:
1041
1042 2012-04-07  Rob Buis  <rbuis@rim.com>
1043
1044         [BlackBerry] Add Battery Status API support
1045         https://bugs.webkit.org/show_bug.cgi?id=82615
1046
1047         Reviewed by George Staikos.
1048
1049         Enable BATTERY_STATUS.
1050
1051         * Scripts/build-webkit:
1052
1053 2012-04-06  Ami Fischman  <fischman@chromium.org>
1054
1055         Subscribe feature-media-reviews@c.o to Media-related changes.
1056         https://bugs.webkit.org/show_bug.cgi?id=83397
1057
1058         Reviewed by David Levin.
1059
1060         * Scripts/webkitpy/common/config/committers.py:
1061         * Scripts/webkitpy/common/config/watchlist:
1062
1063 2012-04-06  Adrienne Walker  <enne@google.com>
1064
1065         [chromium] Add virtual test suite for threaded compositing
1066         https://bugs.webkit.org/show_bug.cgi?id=82263
1067
1068         Reviewed by James Robinson.
1069
1070         Add compositing/visibility as a virtual test suites to test threaded
1071         compositing with. This is a reasonable smoke test of 9 tests, none of
1072         which have any expectations in the non-threaded case.
1073
1074         To fix many of the remaining tests in this virtual test suite, there
1075         will need to be some serious refactoring to merge the conflict between
1076         the way CCScheduler wants to draw frames and the way DRT also wants to
1077         control things. So, in the short term, enable a few simple tests that
1078         are known to be passing.
1079
1080         * Scripts/webkitpy/layout_tests/port/chromium.py:
1081         (ChromiumPort.virtual_test_suites):
1082
1083 2012-04-06  Enrica Casucci  <enrica@apple.com>
1084
1085         Provide Obj-C private API to simplify markup.
1086         https://bugs.webkit.org/show_bug.cgi?id=83334
1087         <rdar://problem/11033861>
1088
1089         Reviewed by Sam Weinig.
1090
1091         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1092         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.
1093         (-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):
1094         * TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.
1095
1096 2012-04-06  Dirk Pranke  <dpranke@chromium.org>
1097
1098         new-run-webkit-tests: fix bugs in 'mock' drt implementation
1099         https://bugs.webkit.org/show_bug.cgi?id=83341
1100
1101         Reviewed by Eric Seidel.
1102
1103         The current implementation crashed in some circumstances for
1104         reference tests and files that were missing expected results.
1105         This patch fixes those cases and adds more unit tests; it is a
1106         precursor to adding unit tests each port that actually uses this
1107         code, in order to get better coverage of the port/*
1108         implementations.
1109
1110         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1111         (parse_options):
1112         (MockDRT.input_from_line):
1113         (MockDRT.output_for_test):
1114         (MockDRT.run_one_test):
1115         (MockChromiumDRT.input_from_line):
1116         (MockChromiumDRT.output_for_test):
1117         (MockChromiumDRT.run_one_test):
1118         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1119         (MockDRTTest.make_input_output):
1120         (MockDRTTest.expected_output):
1121         (MockDRTTest):
1122         (MockDRTTest.assertTest):
1123         (MockDRTTest.test_missing_image):
1124         (MockDRTTest.test_missing_text):
1125         (MockDRTTest.test_reftest_match):
1126         (MockDRTTest.test_reftest_mismatch):
1127         (MockChromiumDRTTest.expected_output):
1128
1129 2012-04-06  James Robinson  <jamesr@chromium.org>
1130
1131         Enable webkit_unit_tests for commit queue and EWS while tracking failures
1132         https://bugs.webkit.org/show_bug.cgi?id=83329
1133
1134         Reviewed by Adam Barth.
1135
1136         This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
1137         the commit queue and EWS can reject patches that cause regressions.
1138
1139         * Scripts/webkitpy/common/config/ports.py:
1140         (ChromiumPort.run_webkit_unit_tests_command):
1141         * Scripts/webkitpy/common/config/ports_mock.py:
1142         (MockPort.unit_tests_results_path):
1143         * Scripts/webkitpy/common/net/layouttestresults.py:
1144         (LayoutTestResults.__init__):
1145         (LayoutTestResults.failing_tests):
1146         (LayoutTestResults):
1147         (LayoutTestResults.add_unit_test_failures):
1148         * Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.
1149         (UnitTestResults):
1150         (UnitTestResults.results_from_string):
1151         * Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.
1152         (UnitTestResultsTest):
1153         (UnitTestResultsTest.test_nostring):
1154         (UnitTestResultsTest.test_emptystring):
1155         (UnitTestResultsTest.test_nofailures):
1156         (test_onefailure):
1157         (test_multiple_failures_per_test):
1158         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1159         (MockCommitQueue.test_results):
1160         (MockCommitQueue.archive_last_test_results):
1161         (FailingTestCommitQueue.test_results):
1162         (test_flaky_test_failure):
1163         (test_failed_archive):
1164         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1165         (LayoutTestResultsReader._create_unit_test_results):
1166         (LayoutTestResultsReader.results):
1167         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1168         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1169         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1170         (PatchAnalysisTaskDelegate.test_results):
1171         (PatchAnalysisTaskDelegate.archive_last_test_results):
1172         (PatchAnalysisTask._test):
1173         (PatchAnalysisTask._build_and_test_without_patch):
1174         (PatchAnalysisTask._test_patch):
1175         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1176         (AbstractEarlyWarningSystem.test_results):
1177         (AbstractEarlyWarningSystem.archive_last_test_results):
1178         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1179         (EarlyWarningSytemTest._test_testing_ews):
1180         * Scripts/webkitpy/tool/commands/queues.py:
1181         (CommitQueue.test_results):
1182         (CommitQueue.archive_last_test_results):
1183         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1184         (CommitQueueTest.test_commit_queue):
1185         (test_rollout):
1186         (test_manual_reject_during_processing):
1187         * Scripts/webkitpy/tool/steps/runtests.py:
1188         (RunTests.run):
1189         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1190         (RunTestsTest.test_webkit_run_unit_tests):
1191
1192 2012-04-06  Aaron Colwell  <acolwell@chromium.org>
1193
1194         Enable MediaSource feature for DumpRenderTree so
1195         MediaSource LayoutTests will pass for Chromium.
1196         https://bugs.webkit.org/show_bug.cgi?id=83053
1197
1198         Reviewed by Dimitri Glazkov.
1199
1200         * DumpRenderTree/chromium/TestShell.cpp:
1201         (TestShell::TestShell):
1202
1203 2012-04-06  George Staikos  <staikos@webkit.org>
1204
1205         Turn on vibration support for BlackBerry.
1206
1207         Reviewed by Rob Buis.
1208
1209         * Scripts/build-webkit:
1210
1211 2012-04-06  Dan Bernstein  <mitz@apple.com>
1212
1213         <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access
1214
1215         Reviewed by Sam Weinig.
1216
1217         * Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.
1218
1219 2012-04-05  Dirk Pranke  <dpranke@chromium.org>
1220
1221         nrwt is failing to upload test results on the chromium-mac-leopard bots
1222         https://bugs.webkit.org/show_bug.cgi?id=83230
1223
1224         Reviewed by Ojan Vafai.
1225
1226         This should fix things properly; FileUploader() was setting the
1227         socket default timeout value, and apparently that doesn't work
1228         properly with urllib. Also, the class had a bad try/finally
1229         block that was causing the exceptions to be swallowed :(.
1230
1231         * Scripts/webkitpy/common/net/file_uploader.py:
1232         (FileUploader.__init__):
1233         (FileUploader._upload_data.callback):
1234         (FileUploader):
1235         (FileUploader._upload_data):
1236         * Scripts/webkitpy/common/net/networktransaction.py:
1237         (NetworkTimeout.__str__):
1238         (NetworkTransaction.run):
1239         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1240         (JSONResultsGeneratorBase.upload_json_files):
1241
1242 2012-04-05  Patrick Gansterer  <paroga@webkit.org>
1243
1244         [Qt] Correct <wtf/*.h> include paths.
1245         https://bugs.webkit.org/show_bug.cgi?id=83270
1246
1247         Reviewed by Eric Seidel.
1248
1249         Modify the #include declerations so that the
1250         wtf types are included using the full path.
1251
1252         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1253
1254 2012-04-05  Philippe Normand  <pnormand@igalia.com>
1255
1256         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
1257         https://bugs.webkit.org/show_bug.cgi?id=83176
1258
1259         Reviewed by Tony Chang.
1260
1261         Refactored the test to use os.path.join() to specify the
1262         core_pattern value of the empty crash log mock.
1263
1264         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1265         (GtkPortTest):
1266         (GtkPortTest.assertLinesEqual):
1267         (GtkPortTest.test_get_crash_log):
1268         (_mock_gdb_output):
1269
1270 2012-04-05  Csaba Osztrogonác  <ossy@webkit.org>
1271
1272         [Qt] Fix includes after QtDeclarative -> QtQML renaming
1273         https://bugs.webkit.org/show_bug.cgi?id=82195
1274
1275         Relanding r112651, because Qt5 is updated everywhere.
1276
1277         * MiniBrowser/qt/BrowserWindow.cpp:
1278         (BrowserWindow::updateVisualMockTouchPoints):
1279         * MiniBrowser/qt/main.cpp:
1280         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1281         (WTR::WrapperWindow::handleStatusChanged):
1282         * qmake/mkspecs/features/unix/default_post.prf:
1283
1284 2012-04-05  Pierre Rossi  <pierre.rossi@gmail.com>
1285
1286         [Qt] WK1/WK2 layout test results are diverging
1287         https://bugs.webkit.org/show_bug.cgi?id=82720
1288
1289         The resolving of default font families was altered in Qt5.
1290         This directly affects the font picked by DRT for layout
1291         tests. Since we want to keep the Qt4 and Qt5 results in line,
1292         we can trick DRT in picking the same font as before for now.
1293
1294         Reviewed by Csaba Osztrogonác.
1295
1296         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1297         (WebKit::initializeTestFonts):
1298
1299 2012-04-05  Kinuko Yasuda  <kinuko@chromium.org>
1300
1301         Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
1302         https://bugs.webkit.org/show_bug.cgi?id=82592
1303
1304         Reviewed by David Levin.
1305
1306         Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.
1307
1308         * DumpRenderTree/chromium/EventSender.cpp:
1309         (EventSender::beginDragWithFiles):
1310
1311 2012-04-04  Tim Horton  <timothy_horton@apple.com>
1312
1313         [mac] WKTR should always keep its windows offscreen
1314         https://bugs.webkit.org/show_bug.cgi?id=83244
1315         <rdar://problem/11188764>
1316
1317         Reviewed by Simon Fraser.
1318
1319         We don't want to allow windows onto the main display; intercept attempts to
1320         change WebKitTestRunnerWindow's frame origin and prevent it from happening.
1321
1322         Also keep around and respond with a new "fake" origin, in case someone is
1323         expecting it to change (I couldn't find any tests that expected this, however).
1324
1325         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1326         (-[WebKitTestRunnerWindow setFrameOrigin:]):
1327         (-[WebKitTestRunnerWindow setFrame:display:animate:]):
1328         (-[WebKitTestRunnerWindow setFrame:display:]):
1329         (-[WebKitTestRunnerWindow frame]):
1330
1331 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1332
1333         Fix typo introduced in r113271.
1334
1335         Unreviewed, build fix.
1336
1337         * Scripts/webkitpy/common/net/file_uploader.py:
1338         (FileUploader._upload_data.callback):
1339         (FileUploader):
1340
1341 2012-04-04  Scott Graham  <scottmg@google.com>
1342
1343         [Chromium, DRT] Bounds check indices on gamepadController
1344         https://bugs.webkit.org/show_bug.cgi?id=83192
1345
1346         Invalid test data would cause bad array accesses. Add simple checks to
1347         ignore such invalid data.
1348
1349         Reviewed by Kent Tamura.
1350
1351         * DumpRenderTree/chromium/GamepadController.cpp:
1352         (GamepadController::connect):
1353         (GamepadController::disconnect):
1354         (GamepadController::setId):
1355         (GamepadController::setButtonCount):
1356         (GamepadController::setButtonData):
1357         (GamepadController::setAxisCount):
1358         (GamepadController::setAxisData):
1359
1360 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1361
1362         nrwt is failing to upload test results on the chromium-mac-leopard bots
1363         https://bugs.webkit.org/show_bug.cgi?id=83230
1364
1365         Reviewed by Ojan Vafai.
1366
1367         More debugging info and a possible fix - stop messing with the
1368         default network timeout, and don't swallow URLErrors.
1369
1370         * Scripts/webkitpy/common/net/file_uploader.py:
1371         (FileUploader._upload_data):
1372         * Scripts/webkitpy/common/net/networktransaction.py:
1373         (NetworkTransaction.run):
1374         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1375         (JSONResultsGeneratorBase.upload_json_files):
1376
1377 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1378
1379         nrwt is failing to upload test results on the chromium-mac-leopard bots
1380         https://bugs.webkit.org/show_bug.cgi?id=83230
1381
1382         Reviewed by Ojan Vafai.
1383
1384         * Scripts/webkitpy/common/net/file_uploader.py:
1385         (FileUploader.__init__):
1386         (FileUploader._upload_data.callback):
1387         (FileUploader):
1388         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1389         (Manager._upload_json_files):
1390         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1391         (JSONResultsGeneratorBase.upload_json_files):
1392
1393 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1394
1395         WKTR needs to implement layoutTestController.setPageVisibility()
1396         https://bugs.webkit.org/show_bug.cgi?id=69554
1397
1398         Reviewed by Simon Fraser.
1399
1400         This patch implements the layoutTestController.setPageVisibility
1401         so WKTR supports the Page Visibility API implementation by using InjectedBundle
1402         to set the visibility state directly to Page.
1403
1404         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1405         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1406         (WTR::LayoutTestController::setPageVisibility):
1407         (WTR):
1408         (WTR::LayoutTestController::resetPageVisibility):
1409         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1410         (LayoutTestController):
1411
1412 2012-04-04  Adam Barth  <abarth@webkit.org>
1413
1414         [Chromium] TestWebKitAPI links in WebCore twice
1415         https://bugs.webkit.org/show_bug.cgi?id=83177
1416
1417         Reviewed by Dimitri Glazkov.
1418
1419         This is causing link errors in the Windows component build. This patch
1420         moves the dependencies a bit lower down in the dependency diagram in
1421         the hopes of removing the duplicate symbols.
1422
1423         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1424
1425 2012-04-04  Christophe Dumez  <christophe.dumez@intel.com>
1426
1427         [EFL][DRT] Catch the "resource,request,willsend" signal
1428         https://bugs.webkit.org/show_bug.cgi?id=82192
1429
1430         Reviewed by Gustavo Noronha Silva.
1431
1432         EFL's DumpRenderTree now catches the "resource,request,willsend"
1433         signal in order to implement the "Blocked access to external URL"
1434         behavior and avoid potential network-related timeouts in the tests.
1435
1436         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1437         (DumpRenderTreeChrome::createView):
1438         (DumpRenderTreeChrome::onWillSendRequest):
1439         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1440         (DumpRenderTreeChrome):
1441
1442 2012-04-04  Patrick Gansterer  <paroga@webkit.org>
1443
1444         [EFL][DRT] Correct <wtf/*.h> include paths.
1445         https://bugs.webkit.org/show_bug.cgi?id=83168
1446
1447         Reviewed by Eric Seidel.
1448
1449         Modify the #include declarations so that the 
1450         wtf types are included using the full path.
1451
1452         * DumpRenderTree/efl/DumpRenderTree.cpp:
1453
1454 2012-04-04  Philippe Normand  <pnormand@igalia.com>
1455
1456         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
1457         https://bugs.webkit.org/show_bug.cgi?id=83176
1458
1459         Reviewed by Tony Chang.
1460
1461         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1462         (test_get_crash_log): Skip the test on non-linux platforms.
1463
1464 2012-04-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1465
1466         [EFL] DRT support for computedStyleIncludingVisitedInfo
1467         https://bugs.webkit.org/show_bug.cgi?id=82190
1468
1469         Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
1470         LayoutTestController so that we can unskip related tests from the skip list.
1471
1472         Reviewed by Antonio Gomes.
1473
1474         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1475         (LayoutTestController::computedStyleIncludingVisitedInfo):
1476
1477 2012-04-04  Raphael Kubo da Costa  <rakuco@webkit.org>
1478
1479         Unreviewed; update my email address once again in the committers
1480         and watch list.
1481
1482         * Scripts/webkitpy/common/config/committers.py: Prefer my
1483         webkit.org email over my FreeBSD.org one.
1484         * Scripts/webkitpy/common/config/watchlist: Ditto.
1485
1486 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1487
1488         [Qt][WK2] QtWebKit2 should support Page Visibility API
1489         https://bugs.webkit.org/show_bug.cgi?id=81164
1490
1491         Reviewed by Kenneth Rohde Christiansen.
1492
1493         Enabling Page Visiblity API for Qt WebKit2.
1494
1495         * qmake/mkspecs/features/features.prf:
1496
1497 2012-04-04  Andras Becsi  <andras.becsi@nokia.com>
1498
1499         [Qt][WK2] Make the WebView a subclass of Flickable
1500         https://bugs.webkit.org/show_bug.cgi?id=83033
1501
1502         Reviewed by Kenneth Rohde Christiansen.
1503
1504         Remove workaround in MiniBrowser and the ScrollIndicator
1505         now that the WebView is a Flickable.
1506
1507         * MiniBrowser/qt/MiniBrowser.pro:
1508         * MiniBrowser/qt/qml/BrowserWindow.qml:
1509         * MiniBrowser/qt/qml/ScrollIndicator.qml:
1510         * WebKitTestRunner/Target.pri:
1511
1512 2012-04-04  Csaba Osztrogonác  <ossy@webkit.org>
1513
1514         REGRESSION(r113144): It made run-webkit-tests always fail
1515         https://bugs.webkit.org/show_bug.cgi?id=83142
1516
1517         Unreviewed trivial fix after r113144.
1518
1519         * Scripts/run-webkit-tests:
1520
1521 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1522
1523         I really hope this is the last build fix. Apparently exec doesn't quite arguments with
1524         double quotations on Windows. Use system instead.
1525
1526         Hopefully, this won't break anything.
1527
1528         * Scripts/run-webkit-tests:
1529
1530 2012-04-03  Keishi Hattori  <keishi@webkit.org>
1531
1532         Disable ENABLE_DATALIST for now
1533         https://bugs.webkit.org/show_bug.cgi?id=82871
1534
1535         Reviewed by Kent Tamura.
1536
1537         * Scripts/build-webkit: Disabled ENABLE_DATALIST.
1538
1539 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1540
1541         Sigh... this isn't going well. I can't even reproduce this issue locally.
1542         Another speculative fix.
1543
1544         * Scripts/run-webkit-tests:
1545
1546 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1547
1548         I don't know why I'm so sloppy today. Another build fix.
1549
1550         * Scripts/run-webkit-tests:
1551
1552 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1553
1554         Hopefully the last build fix for Chromium Windows.
1555
1556         Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.
1557
1558         * Scripts/run-webkit-tests:
1559
1560 2012-04-03  Dirk Pranke  <dpranke@chromium.org>
1561
1562         [Chromium] Lots of timeouts causing Mac10.6 to exit early.
1563         https://bugs.webkit.org/show_bug.cgi?id=83076
1564
1565         Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).
1566
1567         Add logic to the apple mac and chromium mac code to not use
1568         too many workers; it looks like the xserves (and possibly mac
1569         pros) count hyperthreaded cores when they really shouldn't and
1570         we end up using too many workers at a time; this leads to tests
1571         thrashing and timing out.
1572
1573         This change is a temporary fix to make the bots happy while I
1574         look into more profiling and other fixes.
1575
1576         * Scripts/webkitpy/layout_tests/port/mac.py:
1577         (ChromiumMacPort.default_child_processes):
1578
1579         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1580         (ChromiumMacPort.default_child_processes):
1581
1582 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
1583
1584         WebKitTestRunner's EventSender is leaky
1585         https://bugs.webkit.org/show_bug.cgi?id=83099
1586
1587         Reviewed by Beth Dakin.
1588         
1589         Fix leaks of WKNumbers by using the adoptWK idiom, and make
1590         all the code consistent.
1591
1592         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1593         (WTR::EventSendingController::mouseDown):
1594         (WTR::EventSendingController::mouseUp):
1595         (WTR::EventSendingController::mouseMoveTo):
1596         (WTR::EventSendingController::leapForward):
1597         (WTR::EventSendingController::keyDown):
1598         (WTR::EventSendingController::mouseScrollBy):
1599         (WTR::EventSendingController::addTouchPoint):
1600         (WTR::EventSendingController::updateTouchPoint):
1601         (WTR::EventSendingController::setTouchModifier):
1602         (WTR::EventSendingController::releaseTouchPoint):
1603         (WTR::EventSendingController::cancelTouchPoint):
1604
1605 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1606
1607         Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.
1608
1609         * Scripts/run-webkit-tests:
1610         (useNewRunWebKitTests):
1611
1612 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1613
1614         kill-old-processes should kill apache2 and httpd
1615         https://bugs.webkit.org/show_bug.cgi?id=83065
1616
1617         Reviewed by Tony Chang.
1618
1619         Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.
1620
1621         * BuildSlaveSupport/kill-old-processes:
1622
1623 2012-04-03  Tony Chang  <tony@chromium.org>
1624
1625         run the same test steps on test only bots as on build-and-test bots
1626         https://bugs.webkit.org/show_bug.cgi?id=83090
1627
1628         Reviewed by Ryosuke Niwa.
1629
1630         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1631         (TestFactory.__init__):
1632
1633 2012-04-03  Ami Fischman  <fischman@chromium.org>
1634
1635         Add a Media watchlist.
1636         https://bugs.webkit.org/show_bug.cgi?id=83071
1637
1638         Reviewed by David Levin.
1639
1640         * Scripts/webkitpy/common/config/watchlist:
1641
1642 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
1643
1644         Fix large leak in WebKitTestRunner
1645         https://bugs.webkit.org/show_bug.cgi?id=83084
1646
1647         Reviewed by Beth Dakin.
1648         
1649         Fix a leak of the bimap backing store created when doing pixel and
1650         ref tests. This leak was causing serious thrash on the test bots.
1651         
1652         We don't need to allocate memory for CGBitmapContextCreate(); if we
1653         pass NULL, it will allocate and manage its own backing store.
1654
1655         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1656         (WTR::createCGContextFromImage):
1657
1658 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1659
1660         Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.
1661
1662         * BuildSlaveSupport/built-product-archive:
1663         (unzipArchive):
1664
1665 2012-04-03  Ojan Vafai  <ojan@chromium.org>
1666
1667         Give more human friendly error message when builders fail to load or have stale data.
1668         https://bugs.webkit.org/show_bug.cgi?id=83058
1669
1670         Reviewed by Eric Seidel.
1671
1672         * TestResultServer/static-dashboards/dashboard_base.js:
1673         (addError):
1674         (addBuilderLoadErrors):
1675         (handleLocationChange):
1676         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1677
1678 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1679
1680         Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.
1681
1682         * BuildSlaveSupport/built-product-archive:
1683         (extractBuiltProduct):
1684
1685 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1686
1687         Yet another build fix after r113067. Don't trigger Chromium testers right away
1688         since they're now triggered by builders.
1689
1690         * BuildSlaveSupport/build.webkit.org-config/config.json:
1691
1692 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1693
1694         Another build fix after r113067 for Mac port.
1695         It turned out that archiving the entire build directory doesn't work.
1696
1697         * BuildSlaveSupport/built-product-archive:
1698         (createZipManually):
1699         (createZip):
1700         (archiveBuiltProduct):
1701
1702 2012-04-03  Mike Lattanzio  <mlattanzio@rim.com>
1703
1704         [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
1705         https://bugs.webkit.org/show_bug.cgi?id=82643
1706
1707         Update LayoutTestController to accomodate the new find API.
1708         It now provides caseSensitive functionality to DRT.
1709
1710         Internal Review by Andy Chen.
1711
1712         Reviewed by Rob Buis.
1713
1714         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1715         (LayoutTestController::findString):
1716
1717 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1718
1719         Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
1720         because download-built-product creates the build directory as needed.
1721
1722         This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.
1723
1724         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1725         (TestFactory.__init__):
1726
1727 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1728
1729         Build fix after r113067. Don't delete the build directory.
1730
1731         * BuildSlaveSupport/built-product-archive:
1732         (extractBuiltProduct):
1733
1734 2012-04-02  Ojan Vafai  <ojan@chromium.org>
1735
1736         Load all builder lists from the buildbot json
1737         https://bugs.webkit.org/show_bug.cgi?id=82998
1738
1739         Reviewed by Adam Barth.
1740
1741         Also, remove an unnecessary list of test types. Now we don't hard-code
1742         builder names anywhere and we only have a single hard-coded list of
1743         test types.
1744
1745         * TestResultServer/static-dashboards/builders.js:
1746         (BuilderMaster.prototype.logPath):
1747         (BuilderMaster.prototype.builderJsonPath):
1748         (requestBuilderList.xhr.onload):
1749         (requestBuilderList.xhr.onerror):
1750         (isChromiumDepsFyiGpuTestRunner):
1751         (isChromiumTipOfTreeGpuTestRunner):
1752         (isChromiumDepsGTestRunner):
1753         (isChromiumDepsCrosGTestRunner):
1754         (isChromiumTipOfTreeGTestRunner):
1755         (onBuilderListLoad):
1756         (loadBuildersList):
1757         * TestResultServer/static-dashboards/dashboard_base.js:
1758         (parseCrossDashboardParameters):
1759         (currentBuilderGroupCategory):
1760         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1761         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1762         (testHtmlForTestsWithExpectationsButNoFailures):
1763         (testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
1764         (testGenerateChromiumDepsGTestBuildersFromBuilderList):
1765         (testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
1766         (testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):
1767         * TestResultServer/static-dashboards/timeline_explorer.html:
1768
1769 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
1770
1771         Chromium testers should extract builds instead of building on their own
1772         https://bugs.webkit.org/show_bug.cgi?id=82996
1773
1774         Reviewed by Tony Chang.
1775
1776         Make Chromium builders triggger Chromium testers and make testers download and extract builds
1777         from the buildbot master instead of building binaries on their own.
1778
1779         Add download-built-product to wrap curl used in the download-built-product step since Windows
1780         does not provide "curl" natively.
1781
1782         * BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make
1783         Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.
1784         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1785         (DownloadBuiltProduct): Call download-built-product instead of curl.
1786         * BuildSlaveSupport/built-product-archive:
1787         (createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
1788         needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
1789         (archiveBuiltProduct): Zip the configuration build directory on Mac port.
1790         (unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
1791         (extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.
1792         * BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.
1793
1794 2012-04-03  Martin Robinson  <mrobinson@igalia.com>
1795
1796         [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
1797         https://bugs.webkit.org/show_bug.cgi?id=82473
1798
1799         Reviewed by Philippe Normand.
1800
1801         Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
1802         was ever run.
1803
1804         * gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
1805         check if the user has ever run update-gtk-libs and, if so, then use jhbuild.
1806
1807 2012-04-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1808
1809         [EFL] DRT support for setInteractiveFormValidationEnabled
1810         https://bugs.webkit.org/show_bug.cgi?id=82050
1811
1812         Enable interactive form validation and unskip tests from the
1813         skip list.
1814
1815         Reviewed by Antonio Gomes.
1816
1817         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1818         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1819
1820 2012-04-03  Philippe Normand  <pnormand@igalia.com>
1821
1822         Unreviewed, another test-webkitpy fix-up after r113037.
1823
1824         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock
1825         crash dump depending on current environment.
1826
1827 2012-04-03  Philippe Normand  <pnormand@igalia.com>
1828
1829         Unreviewed, test-webkitpy build fix after r113037.
1830
1831         * Scripts/webkitpy/layout_tests/port/gtk.py:
1832         (GtkPort._get_crash_log):
1833
1834 2012-04-03  Philippe Normand  <pnormand@igalia.com>
1835
1836         [GTK] crash log reports support
1837         https://bugs.webkit.org/show_bug.cgi?id=81659
1838
1839         Reviewed by Martin Robinson.
1840
1841         Removed the daemontools crashmon/xvfb scripts and implemented the crash
1842         log reporting in the NRWT Gtk port. To get proper crash logs one
1843         needs to set the core pattern like this:
1844         echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
1845         Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
1846         environment variable.
1847
1848         * BuildSlaveSupport/gtk/README:
1849         * BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
1850         * BuildSlaveSupport/gtk/crashmon/log/run: Removed.
1851         * BuildSlaveSupport/gtk/crashmon/run: Removed.
1852         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1853         * BuildSlaveSupport/gtk/xvfb/log/run: Removed.
1854         * BuildSlaveSupport/gtk/xvfb/run: Removed.
1855         * Scripts/new-run-webkit-tests:
1856         * Scripts/webkitpy/layout_tests/port/gtk.py:
1857         (GtkDriver.stop):
1858         (GtkPort.show_results_html_file):
1859         (GtkPort):
1860         (GtkPort._get_gdb_output):
1861         (GtkPort._get_crash_log):
1862         (GtkPort._get_crash_log.match_filename):
1863         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1864         (GtkPortTest):
1865         (test_show_results_html_file):
1866         (assertLinesEqual):
1867         (_mock_gdb_output):
1868         (test_get_crash_log):
1869
1870 2012-04-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1871
1872         Enable and connect the WebInspectorServer with WebKit2 pages.
1873         https://bugs.webkit.org/show_bug.cgi?id=73094
1874
1875         Reviewed by Simon Hausmann.
1876
1877         Enable developer extras on pages in MiniBrowser for Qt.
1878
1879         * MiniBrowser/qt/qml/BrowserWindow.qml:
1880
1881 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
1882
1883         [EFL] LayoutTestController needs implementation of setDefersLoading
1884         https://bugs.webkit.org/show_bug.cgi?id=82890
1885
1886         Reviewed by Philippe Normand.
1887
1888         Implement setDefersLoading() in EFL's LayoutTestController so that the
1889         corresponding test case can be removed from the skip list.
1890
1891         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1892         (LayoutTestController::setDefersLoading):
1893
1894 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
1895
1896         [EFL] LayoutTestController needs implementation of goBack
1897         https://bugs.webkit.org/show_bug.cgi?id=81914
1898
1899         Reviewed by Philippe Normand.
1900
1901         Implement goBack() in EFL's LayoutTestController by calling
1902         ewk_frame_back().
1903
1904         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1905         (LayoutTestController::goBack):
1906
1907 2012-04-03  Alexander Shalamov  <alexander.shalamov@intel.com>
1908
1909         [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
1910         https://bugs.webkit.org/show_bug.cgi?id=82589
1911
1912         Add missing implementation for pageSizeAndMarginsInPixels to EFL's LayoutTestController
1913         in order to unskip printing/page-format-data.html
1914
1915         Reviewed by Philippe Normand.
1916
1917         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1918         (LayoutTestController::pageSizeAndMarginsInPixels):
1919
1920 2012-04-03  Simon Pena  <spena@igalia.com>
1921
1922         [GTK] DRT missing didRunInsecureContent notification
1923         https://bugs.webkit.org/show_bug.cgi?id=59367
1924
1925         Reviewed by Philippe Normand.
1926
1927         Connect DumpRenderTree to WebFrame's "insecure-content-run", in both
1928         the main WebFrame or any other WebFrame created later. Added
1929         "didRunInsecureContent" notification in the callback in order to
1930         get the LayoutTests passing.
1931
1932         * DumpRenderTree/gtk/DumpRenderTree.cpp: Connect
1933         to WebFrame's "insecure-content-run" signal and add
1934         didRunInsecureContent notification in the callback to get the
1935         LayoutTests passing.
1936         (didRunInsecureContent):
1937         (createWebView):
1938
1939 2012-04-03  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1940
1941         rebaseline-server: Make it possible to not launch a browser with the server.
1942         https://bugs.webkit.org/show_bug.cgi?id=82999
1943
1944         Reviewed by Adam Barth.
1945
1946         Add the `--no-show-results' option, which lets one decide not to
1947         launch a web browser when running the rebaseline server.  This is
1948         especially useful if the default browser is not the wanted one, or
1949         if the rebaseline server page is already open.
1950
1951         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
1952         (AbstractLocalServerCommand.__init__):
1953         (AbstractLocalServerCommand.execute):
1954
1955 2012-04-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1956
1957         EFL's LayoutTestController disableImageLoading implementation.
1958         https://bugs.webkit.org/show_bug.cgi?id=82848
1959
1960         Reviewed by Hajime Morita.
1961
1962         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1963         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1964         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1965         (LayoutTestController::disableImageLoading):
1966
1967 2012-04-02  Alexander Shalamov  <alexander.shalamov@intel.com>
1968
1969         [EFL] LayoutTestController needs implementation of isPageBoxVisible
1970         https://bugs.webkit.org/show_bug.cgi?id=82591
1971
1972         Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
1973         in order to unskip printing/page-format-data.html
1974
1975         Reviewed by Hajime Morita.
1976
1977         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1978         (LayoutTestController::isPageBoxVisible):
1979
1980 2012-04-02  Simon Fraser  <simon.fraser@apple.com>
1981
1982         run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
1983         https://bugs.webkit.org/show_bug.cgi?id=82962
1984
1985         Reviewed by Dirk Pranke.
1986
1987         Ensure that _build_path() returns an absolute path.
1988
1989         Eric Seidel also had to deploy MockConfig in a bunch of places
1990         in order to correct previous testing errors where we were
1991         pretending that "Mock Output from child process" (returned by MockExecutive.run_command)
1992         was a real path.  The real Config object calls run_command("webkit-build-directory")
1993         to read the WebKit build directory from the webkitdirs.pm perl code.
1994         MockConfig abstracts this away and always returns "/mock-build" during
1995         testing.  This change is much larger than one would think necessary
1996         because of needing to deploy this MockConfig class.
1997
1998         * Scripts/webkitpy/layout_tests/port/webkit.py:
1999         (WebKitPort._build_path):
2000
2001 2012-04-02  Ojan Vafai  <ojan@chromium.org>
2002
2003         Fix snafu in r112971. We were never calling parseParameter for builder.
2004
2005         * TestResultServer/static-dashboards/dashboard_base.js:
2006
2007 2012-04-02  Ojan Vafai  <ojan@chromium.org>
2008
2009         Generate the lists of all layout test builders from the buildbot json
2010         https://bugs.webkit.org/show_bug.cgi?id=82924
2011
2012         Reviewed by Mihai Parparita.
2013
2014         In order to make this work, cleaned up a lot of existing technical debt.
2015         -Got rid of expectations builder. This concept is outdated and just dead code.
2016         -Split hash parameter parsing into two functions. One for dashboard_base
2017         (crossDashboardParameters) and one for the specific dashboard html file
2018         (dashboardSpecificParameters). In the old world, parseParameters needed to
2019         be called twice and depended on it's own output the first time through.
2020         Now we only need to parse crossDashboardParameters first and crossDashboardParameters
2021         doesn't depend on the output of crossDashboardParameters.
2022         -Lots of variable/method renames due to the above.
2023         -g_defaultDashboardSpecificStateValues now has to list all possible hash parameters
2024         for that dashboard.
2025
2026         * TestResultServer/static-dashboards/aggregate_results.html:
2027         * TestResultServer/static-dashboards/builders.js:
2028         (BuilderGroup):
2029         (BuilderGroup.prototype.setup):
2030         (jsonRequest.xhr.onload):
2031         (jsonRequest.xhr.onerror):
2032         (isWebkitTestRunner):
2033         (isChromiumWebkitTipOfTreeTestRunner):
2034         (isChromiumWebkitDepsTestRunner):
2035         (generateBuildersFromBuilderList):
2036         (onLayoutTestBuilderListLoad):
2037         (onErrorLoadingBuilderList):
2038         (loadBuildersList):
2039         * TestResultServer/static-dashboards/dashboard_base.js:
2040         (handleValidHashParameterWrapper):
2041         (queryHashAsMap):
2042         (parseParameter):
2043         (parseCrossDashboardParameters):
2044         (parseDashboardSpecificParameters):
2045         (parseParameters):
2046         (diffStates):
2047         (defaultValue):
2048         (isLayoutTestResults):
2049         (isGPUTestResults):
2050         (currentBuilderGroupCategory):
2051         (currentBuilderGroup):
2052         (initBuilders):
2053         Now that we've split parameter parseing, these methods no longer need
2054         to take an optional state. They can always just use the global cross-dashboard state.
2055
2056         (pathToBuilderResultsFile):
2057         (appendJSONScriptElementFor):
2058         (appendJSONScriptElements):
2059         (handleResourceLoadError):
2060         (haveJsonFilesLoaded):
2061         (combinedDashboardState):
2062         (setQueryParameter):
2063         (permaLinkURLHash):
2064         (toggleQueryParameter):
2065         (queryParameterValue):
2066         (selectHTML):
2067         (htmlForTestTypeSwitcher):
2068         (g_handleBuildersListLoaded):
2069         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2070         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2071         (testPlatformAndBuildType):
2072         (testSubstringList):
2073         (testHtmlForTestTypeSwitcherGroup):
2074         (testLookupVirtualTestSuite):
2075         (testBaseTest):
2076         (generateBuildersFromBuilderListHelper):
2077         (testGenerateChromiumWebkitTipOfTreeBuildersFromBuilderList):
2078         (testGenerateChromiumWebkitDepsBuildersFromBuilderList):
2079         (assertObjectsDeepEqual):
2080         (testQueryHashAsMap):
2081         (testDiffStates):
2082         * TestResultServer/static-dashboards/timeline_explorer.html:
2083         * TestResultServer/static-dashboards/treemap.html:
2084
2085 2012-04-02  Tony Chang  <tony@chromium.org>
2086
2087         check-webkit-style errors when removing .png files
2088         https://bugs.webkit.org/show_bug.cgi?id=82933
2089
2090         Reviewed by David Levin.
2091
2092         * Scripts/webkitpy/style/patchreader.py:
2093         (PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).
2094         * Scripts/webkitpy/style/patchreader_unittest.py:
2095         (test_check_patch_with_png_deletion):
2096
2097 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2098
2099         Unreviewed, rolling out r112948.
2100         http://trac.webkit.org/changeset/112948
2101         https://bugs.webkit.org/show_bug.cgi?id=82961
2102
2103         Someone else already checked in a similar change (Requested by
2104         sundiamonde on #webkit).
2105
2106         * Scripts/webkitpy/layout_tests/port/webkit.py:
2107         (WebKitDriver._start):
2108
2109 2012-04-02  Adam Barth  <abarth@webkit.org>
2110
2111         garden-o-matic isn't able to rebaseline audio failures
2112         https://bugs.webkit.org/show_bug.cgi?id=82957
2113
2114         Reviewed by Chris Rogers.
2115
2116         This patch just adds "wav" to the list of test suffixes and updates the
2117         unit tests to show that we're rebaselining audio tests results now too.
2118
2119         * Scripts/webkitpy/tool/commands/rebaseline.py:
2120         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2121         (test_rebaseline_updates_expectations_file):
2122
2123 2012-04-02  Adam Barth  <abarth@webkit.org>
2124
2125         garden-o-matic should let you listen to audio failures
2126         https://bugs.webkit.org/show_bug.cgi?id=82953
2127
2128         Reviewed by Chris Rogers.
2129
2130         Now that we've actually got an audio failure on the bots, we can clean
2131         up the last stray bugs.  This patch doesn't have any tests because I'm
2132         lame.
2133
2134         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2135         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2136         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2137         (.):
2138
2139 2012-04-02  Stephanie Lewis  <slewis@apple.com>
2140
2141         run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
2142         https://bugs.webkit.org/show_bug.cgi?id=82552
2143
2144         Reviewed by Dirk Pranke.
2145
2146         Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.
2147
2148         * Scripts/webkitpy/layout_tests/port/webkit.py:
2149         (WebKitDriver._start):
2150
2151 2012-04-02  Dirk Pranke  <dpranke@chromium.org>
2152
2153         NRWT is not printing out the builder it's uploading JSON files for
2154         https://bugs.webkit.org/show_bug.cgi?id=82834
2155
2156         Reviewed by Ojan Vafai.
2157
2158         Handle log messages of the form log.info("%s", arg) properly ...
2159         I didn't even know you could do that :).
2160
2161         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2162         (_LogHandler.emit):
2163         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2164         (RegularTest.test_log_args):
2165         (VerboseTest.test_log_args):
2166
2167 2012-04-02  Tim Horton  <timothy_horton@apple.com>
2168
2169         [mac] LayoutTestHelper crashes if there is no main display
2170         https://bugs.webkit.org/show_bug.cgi?id=82944
2171         <rdar://problem/11162954>
2172
2173         Reviewed by Simon Fraser.
2174
2175         If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
2176         a null dictionary, so we shouldn't go ahead and try to read from it.
2177
2178         * DumpRenderTree/mac/LayoutTestHelper.m:
2179         (installLayoutTestColorProfile):
2180
2181 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
2182
2183         [Qt][WK2] Set up plugin process on Unix
2184         https://bugs.webkit.org/show_bug.cgi?id=72121
2185
2186         Reviewed by Simon Hausmann.
2187
2188         * qmake/mkspecs/features/features.prf: Reenable plugins
2189         and turn on plugin process.
2190
2191 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2192
2193         Unreviewed, rolling out r112868, r112879, and r112881.
2194         http://trac.webkit.org/changeset/112868
2195         http://trac.webkit.org/changeset/112879
2196         http://trac.webkit.org/changeset/112881
2197         https://bugs.webkit.org/show_bug.cgi?id=82901
2198
2199         "Build fail on bots." (Requested by kbalazs on #webkit).
2200
2201         * MiniBrowser/gtk/GNUmakefile.am:
2202         * qmake/mkspecs/features/features.prf:
2203
2204 2012-04-02  Philippe Normand  <pnormand@igalia.com>
2205
2206         [GTK] Enable shadow-dom in build-webkit.
2207
2208         Rubber-stamped by Gustavo Noronha Silva.
2209
2210         * Scripts/build-webkit: Enable shadow-dom build, this is need to
2211         have a working build currently.
2212
2213 2012-04-02  Andreas Kling  <kling@webkit.org>
2214
2215         Adding Zalan Bujtas to committers list.
2216
2217         * Scripts/webkitpy/common/config/committers.py:
2218
2219 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
2220
2221         [Qt][WK2] Set up plugin process on Unix
2222         https://bugs.webkit.org/show_bug.cgi?id=72121
2223
2224         Reviewed by Simon Hausmann.
2225
2226         * qmake/mkspecs/features/features.prf: Reenable plugins
2227         and turn on plugin process.
2228
2229 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2230
2231         Unreviewed, rolling out r112651.
2232         http://trac.webkit.org/changeset/112651
2233         https://bugs.webkit.org/show_bug.cgi?id=82887
2234
2235         It doesn't work with older Qt5 (Requested by Ossy on #webkit).
2236
2237         * MiniBrowser/qt/BrowserWindow.cpp:
2238         (BrowserWindow::updateVisualMockTouchPoints):
2239         * MiniBrowser/qt/main.cpp:
2240         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2241         (WTR::WrapperWindow::handleStatusChanged):
2242         * qmake/mkspecs/features/unix/default_post.prf:
2243
2244 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2245
2246         [GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
2247         https://bugs.webkit.org/show_bug.cgi?id=82877
2248
2249         Reviewed by Philippe Normand.
2250
2251         * Scripts/run-gtk-tests:
2252         (TestRunner.run_tests): Use replace instead of lstrip to remove
2253         the programs_path from the full path of unit tests.
2254
2255 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2256
2257         Unreviewed. Skip flaky unit tests.
2258
2259         * Scripts/run-gtk-tests:
2260         (TestRunner):
2261
2262 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
2263
2264         webkitpy rebaseline.
2265
2266         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2267         (test_run_test_set_with_json_output):
2268         (test_run_test_set_with_json_source):
2269
2270 2012-04-01  Ryosuke Niwa  <rniwa@webkit.org>
2271
2272         perf-o-matic should store test results' units
2273         https://bugs.webkit.org/show_bug.cgi?id=82852
2274
2275         Reviewed by Kentaro Hara.
2276
2277         Include units in the results JSON.
2278
2279         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2280         (PerfTestsRunner._process_chromium_style_test_result):
2281         (PerfTestsRunner._process_parser_test_result):
2282
2283 2012-04-01  Tony Tseung  <tseung@apple.com>
2284
2285         Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
2286         composite fonts from existing physical fonts.
2287         <rdar://problem/10717370>
2288         https://bugs.webkit.org/show_bug.cgi?id=82810
2289             
2290         A new test font of this kind as been added to the test tools for running the webkit-tests
2291
2292         Reviewed by Dan Bernstein.
2293
2294         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2295         Added new dependency SampleFont.sfont
2296         
2297         * DumpRenderTree/fonts/SampleFont.sfont: Added.
2298         
2299         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2300         * DumpRenderTree/mac/DumpRenderTree.mm:
2301         (allowedFontFamilySet):
2302         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
2303         
2304         (activateTestingFonts):
2305         Added the registration of the Composite Font Referene sample font
2306         
2307         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2308         (WTR::allowedFontFamilySet):
2309         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
2310
2311         (WTR::activateFonts):
2312         Added the registration of the Composite Font Referene sample font
2313
2314         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2315         Added new dependency SampleFont.sfont
2316
2317         * WebKitTestRunner/fonts/SampleFont.sfont: Added.
2318
2319 2012-04-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2320
2321         Support the Network Information API
2322         https://bugs.webkit.org/show_bug.cgi?id=73528
2323
2324         Reviewed by Adam Barth.
2325
2326         Add network information API feature to build script.
2327
2328         * Scripts/build-webkit:
2329
2330 2012-03-31  Ojan Vafai  <ojan@chromium.org>
2331
2332         Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
2333         https://bugs.webkit.org/show_bug.cgi?id=82839
2334
2335         Reviewed by Adam Barth.
2336
2337         Also, update various hard-coded lists for WIN7 and Lion ports.
2338         This is necessary since the new list of builders grabbed off the
2339         buildbot includes Lion.
2340
2341         * TestResultServer/static-dashboards/builders.js:
2342         (generateWebkitBuildersFromBuilderList):
2343         (xhr.onreadystatechange):
2344         Don't use dashboard_base's request method to avoid layering violation.
2345
2346         * TestResultServer/static-dashboards/dashboard_base.js:
2347         (parseParameters):
2348         (initBuilders):
2349         (haveJsonFilesLoaded):
2350         (g_handleBuildersListLoaded):
2351         Block loading the JSON files for each builder until we actually have a list of builders.
2352
2353         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2354         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2355         (testPlatformAndBuildType):
2356         (testGenerateWebkitBuildersFromBuilderList):
2357         * TestResultServer/static-dashboards/timeline_explorer.html:
2358         * TestResultServer/static-dashboards/treemap.html:
2359         Delay generating the page until the builder list has loaded.
2360
2361 2012-03-31  Ojan Vafai  <ojan@chromium.org>
2362
2363         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
2364         https://bugs.webkit.org/show_bug.cgi?id=82799
2365
2366         Reviewed by Eric Seidel.
2367
2368         If we don't run a test, mark it as skipped.
2369
2370         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2371         (Manager._mark_interrupted_tests_as_skipped):
2372         (Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
2373         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2374         (ManagerTest.test_interrupt_if_at_failure_limits):
2375
2376 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2377
2378         One more build fix after r112781 for Chromium Windows.
2379         Don't copy zip .idb files.
2380
2381         * BuildSlaveSupport/built-product-archive:
2382         (copyBuildFiles):
2383
2384 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2385
2386         Yet another build fix after r112781 for Chromium Windows.
2387         Run webkit-build-directory by perl explicitly.
2388
2389         * BuildSlaveSupport/built-product-archive:
2390         (determineWebKitBuildDirectory):
2391
2392 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2393
2394         Fix the syntax error in master.cfg after r112734.
2395
2396         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2397         (unitTestsSupported):
2398
2399 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2400
2401         Another build fix after r112781.
2402
2403         * BuildSlaveSupport/built-product-archive:
2404         (createZip):
2405
2406 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2407
2408         Build fix after r112781.
2409
2410         * BuildSlaveSupport/built-product-archive:
2411         (createZipManually):
2412         (createZip):
2413
2414 2012-03-30  Ryosuke Niwa  <rniwa@webkit.org>
2415
2416         Chromium bots should upload archived built files
2417         https://bugs.webkit.org/show_bug.cgi?id=82666
2418
2419         Reviewed by Tony Chang.
2420
2421         * BuildSlaveSupport/build.webkit.org-config/config.json:
2422         * BuildSlaveSupport/built-product-archive:
2423         (main):
2424         (determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
2425         call out to webkit-build-directory.
2426         (removeDirectoryIfExists): Extracted.
2427         (copyBuildFiles): Added to avoid archiving useless intermedinate files.
2428         (createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
2429         (createZipManually.addToArchive):
2430         (createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
2431         (archiveBuiltProduct): Add support for Chromium port.
2432         * Scripts/webkit-build-directory: Add support for --platform options.
2433
2434 2012-03-30  Dan Bernstein  <mitz@apple.com>
2435
2436         Reverted r112767, because it caused many vertical text tests to fail.
2437
2438         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2439         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
2440         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2441         * DumpRenderTree/mac/DumpRenderTree.mm:
2442         (allowedFontFamilySet):
2443         (activateTestingFonts):
2444         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2445         (WTR::allowedFontFamilySet):
2446         (WTR::activateFonts):
2447         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2448         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
2449
2450 2012-03-30  Malcolm MacLeod  <malcolm.macleod@tshwanedje.com>
2451
2452         [wx] Move wxWebKit API into WebKit namespace.
2453         https://bugs.webkit.org/show_bug.cgi?id=82740
2454
2455         Reviewed by Kevin Ollivier.
2456
2457         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2458         (LayoutWebViewEventHandler::LayoutWebViewEventHandler):
2459         (LayoutWebViewEventHandler::bindEvents):
2460         (LayoutWebViewEventHandler::OnLoadEvent):
2461         (LayoutWebViewEventHandler::OnAlertEvent):
2462         (LayoutWebViewEventHandler::OnConfirmEvent):
2463         (LayoutWebViewEventHandler::OnPromptEvent):
2464         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
2465         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
2466         (LayoutWebViewEventHandler::OnWindowObjectClearedEvent):
2467         (LayoutWebViewEventHandler):
2468         (dumpFramesAsText):
2469         (dump):
2470         (MyApp::OnInit):
2471         * wx/browser/browser.cpp:
2472         (MyApp::OnInit):
2473
2474 2012-03-30  Eli Fidler  <efidler@rim.com>
2475
2476         Enable OpenType Sanitizer for BlackBerry port.
2477         https://bugs.webkit.org/show_bug.cgi?id=82782
2478
2479         Reviewed by Eric Seidel.
2480
2481         * Scripts/webkitdirs.pm:
2482         (blackberryCMakeArguments): add OTS to include path
2483
2484 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
2485
2486         run-webkit-tests needs to set DYLD_LIBRARY_PATH as well
2487         as DYLD_FRAMEWORK_PATH, so that libWebCoreTestSupport.dylib
2488         is found.
2489
2490         <rdar://problem/11158581>
2491         
2492         Reviewed by Mark Rowe.
2493
2494         * Scripts/webkitpy/layout_tests/port/webkit.py:
2495         (WebKitDriver._start):
2496
2497 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
2498
2499         Disable run-api-tests on release mac builds
2500         https://bugs.webkit.org/show_bug.cgi?id=82788
2501
2502         Reviewed by Ryosuke Niwa.
2503         
2504         TestWebKitAPI crashes every time in release builds currently
2505         (https://bugs.webkit.org/show_bug.cgi?id=82652) so disable
2506         run-api-tests on mac release builders.
2507
2508         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2509         (unitTestsSupported):
2510
2511 2012-03-30  Chang Shu  <cshu@webkit.org>
2512
2513         Unreviewed. Update my email.
2514
2515         * Scripts/webkitpy/common/config/committers.py:
2516
2517 2012-03-30  Chris Fleizach  <cfleizach@apple.com>
2518
2519         AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&)
2520         https://bugs.webkit.org/show_bug.cgi?id=82745
2521
2522         Reviewed by Simon Fraser.
2523
2524         * DumpRenderTree/AccessibilityUIElement.cpp:
2525         (rangeForPositionCallback):
2526         (AccessibilityUIElement::rangeForPosition):
2527         (AccessibilityUIElement::getJSClass):
2528         * DumpRenderTree/AccessibilityUIElement.h:
2529         (AccessibilityUIElement):
2530         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2531         (AccessibilityUIElement::rangeForPosition):
2532         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2533         (WTR::AccessibilityUIElement::rangeForPosition):
2534         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2535         (AccessibilityUIElement):
2536         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2537         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2538         (WTR::AccessibilityUIElement::rangeForPosition):
2539         (WTR):
2540
2541 2012-03-30  David Barr  <davidbarr@chromium.org>
2542
2543         Split up top-level .gitignore and .gitattributes
2544         https://bugs.webkit.org/show_bug.cgi?id=82687
2545
2546         Reviewed by Tor Arne Vestbø.
2547
2548         * .gitattributes: Added.
2549         * .gitignore: Added.
2550         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Added.
2551         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Added.
2552
2553 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
2554
2555         Actually remove the ChromiumOS GTK builder, like r112673 said it would.
2556
2557         * TestResultServer/static-dashboards/builders.js:
2558
2559 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
2560
2561         Update ChromiumOS bot names in builders.js to reflect changes made by
2562         http://crrev.com/129835
2563         
2564         Also removes the ChromiumOS GTK builder, which was removed by
2565         http://crrev.com/129835
2566
2567         * TestResultServer/static-dashboards/builders.js:
2568
2569 2012-03-30  Vineet Chaudhary  <rgf748@motorola.com>
2570
2571         [GTK] Disable introspection build in the at-spi2-core module.
2572         https://bugs.webkit.org/show_bug.cgi?id=82729
2573
2574         Reviewed by Philippe Normand.
2575
2576         This change is a follow-up of bug 82395 which initially disabled for other modules of the set.
2577
2578         * gtk/jhbuild.modules: Disable introspection.
2579
2580 2012-03-30  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2581
2582         Add a "preview" state to Page Visibility API implementation
2583         https://bugs.webkit.org/show_bug.cgi?id=81355
2584
2585         Reviewed by Adam Barth.
2586
2587         Updating the Page Visibility API implementation to the current spec version.
2588
2589         * DumpRenderTree/chromium/LayoutTestController.cpp:
2590         (LayoutTestController::setPageVisibility):
2591
2592 2012-03-30  Keishi Hattori  <keishi@webkit.org>
2593
2594         Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
2595         https://bugs.webkit.org/show_bug.cgi?id=80972
2596
2597         Reviewed by Kent Tamura.
2598
2599         * Scripts/build-webkit:
2600         * qmake/mkspecs/features/features.prf:
2601
2602 2012-03-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
2603
2604         [Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
2605         https://bugs.webkit.org/show_bug.cgi?id=82195
2606
2607         Reviewed by Simon Hausmann.
2608
2609         * MiniBrowser/qt/BrowserWindow.cpp:
2610         (BrowserWindow::updateVisualMockTouchPoints):
2611         * MiniBrowser/qt/main.cpp:
2612         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2613         (WTR::WrapperWindow::handleStatusChanged):
2614         * qmake/mkspecs/features/unix/default_post.prf:
2615
2616 2012-03-30  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2617
2618         [EFL] Implement LayoutTestController::setMinimumTimerInterval
2619         https://bugs.webkit.org/show_bug.cgi?id=81220
2620
2621         Add missing implementation setMinimumTimerInterval to EFL's
2622         LayoutTestController so that we can unskip related tests from the skip list.
2623
2624         Reviewed by Philippe Normand.
2625
2626         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2627         (LayoutTestController::setMinimumTimerInterval):
2628
2629 2012-03-29  Dan Bernstein  <mitz@apple.com>
2630
2631         Removed “Intel” from the Lion builders’ names.
2632
2633         Rubber-stamped by Mark Rowe.
2634
2635         * BuildSlaveSupport/build.webkit.org-config/config.json:
2636         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2637         (LeaksViewer._displayURLPrompt):
2638
2639 2012-03-29  Mihai Parparita  <mihaip@chromium.org>
2640
2641         [Chromium] Add sharded ChromiumOS debug bots to builders.js
2642         https://bugs.webkit.org/show_bug.cgi?id=82639
2643
2644         Reviewed by Eric Seidel.
2645
2646         The bots were sharded by http://crrev.com/129613, update builders.js
2647         to reflect this.
2648
2649         * TestResultServer/static-dashboards/builders.js:
2650
2651 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
2652
2653         remove support for junit-style xml output from test-webkitpy
2654         https://bugs.webkit.org/show_bug.cgi?id=82279
2655
2656         Reviewed by Eric Seidel.
2657
2658         This was added when we were looking into integrating w/ Jenkins
2659         rather than buildbot, but I believe that project got shelved, so
2660         this is unused. We can always add it back in later as necessary.
2661
2662         * Scripts/webkitpy/test/main.py:
2663         (Tester._parse_args):
2664         (Tester._run_tests):
2665         * Scritps/webkitpy/thirdparty/__init__.py:
2666
2667 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
2668
2669         new-run-webkit-tests: crashes when it fails to decode a stack trace
2670         https://bugs.webkit.org/show_bug.cgi?id=82673
2671
2672         Unreviewed, build fix.
2673
2674         We are assuming the stdout/stderr output from the driver is utf-8
2675         encoded when we get stack traces; this may not be a valid
2676         assumption generally, but if we do get strings that aren't valid
2677         utf-8, we would crash. Now we will ignore any decoding errors.
2678
2679         * Scripts/webkitpy/layout_tests/port/base.py:
2680         (Port._get_crash_log):
2681         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2682         (PortTestCase.test_get_crash_log):
2683
2684 2012-03-29  Simon Fraser  <simon.fraser@apple.com>
2685
2686         Scripts fail to detect when a tool crashes
2687         https://bugs.webkit.org/show_bug.cgi?id=82659
2688
2689         Reviewed by Mark Rowe.
2690         
2691         Have exitStatus() detect when the process fail to exit cleanly
2692         (possibly because of a crash), and return a non-zero exit code
2693         in that case.
2694
2695         * Scripts/VCSUtils.pm:
2696         (exitStatus):
2697
2698 2012-03-29  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2699
2700         [GTK][EFL] run-javascriptcore-tests should be run through jhbuild
2701         https://bugs.webkit.org/show_bug.cgi?id=82581
2702
2703         Reviewed by Martin Robinson.
2704
2705         Running Javascriptcore tests through jhbuild
2706         for consistency with run-webkit-tests and in order to
2707         avoid confusing libraries when facing regressions.
2708
2709         * Scripts/run-javascriptcore-tests:
2710
2711 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
2712
2713         test-webkitpy: add --timing
2714         https://bugs.webkit.org/show_bug.cgi?id=82550
2715
2716         Reviewed by Eric Seidel.
2717
2718         This patch adds a --timing option that will display the time
2719         each test takes. It also removes the --silent option, since
2720         probably no one ever used it, and cleans up the logging
2721         option parsing code to be easier to follow.
2722
2723         * Scripts/webkitpy/test/main.py:
2724         (Tester._parse_args):
2725         (Tester._configure):
2726         * Scripts/webkitpy/test/runner.py:
2727         (TestRunner.write_result):
2728         * Scripts/webkitpy/test/runner_unittest.py:
2729         (RunnerTest.test_regular):
2730         (RunnerTest.test_verbose):
2731         (RunnerTest):
2732         (RunnerTest.test_timing):
2733
2734 2012-03-29  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2735
2736         HashMap<>::add should return a more descriptive object
2737         https://bugs.webkit.org/show_bug.cgi?id=71063
2738
2739         Reviewed by Ryosuke Niwa.
2740
2741         Update code to use AddResult instead of a pair.
2742
2743         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2744         (LayoutTestController::evaluateScriptInIsolatedWorld):
2745         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2746         (LayoutTestController::evaluateScriptInIsolatedWorld):
2747         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2748         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld):
2749
2750 2012-03-29  Ilya Tikhonovsky  <loislo@chromium.org>
2751
2752         Web Inspector: chromium: DRT --no-timeout option doesn't work.
2753         https://bugs.webkit.org/show_bug.cgi?id=82608
2754
2755         Initial value for m_timeout was initialized in constructor and was overwritten in DRT::main.
2756         This was broken by r112354 and the sequence became opposite.
2757
2758         Reviewed by Yury Semikhatsky.
2759
2760         * DumpRenderTree/chromium/TestShell.cpp:
2761         (TestShell::TestShell):
2762         (TestShell::initialize):
2763
2764 2012-03-29  Vineet Chaudhary  <rgf748@motorola.com>
2765
2766         Remove custom bindings form Internals.idl of attribute type Array.
2767         https://bugs.webkit.org/show_bug.cgi?id=82319
2768
2769         Reviewed by Kentaro Hara.
2770
2771         Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp as no longer required.
2772
2773         * GNUmakefile.am:
2774
2775 2012-03-28  Mark Rowe  <mrowe@apple.com>
2776
2777         Fix --no-saved-state.
2778
2779         Ignore the flag before Lion, rather than making it specific to Lion.
2780
2781         Rubber-stamped by Dan Bernstein.
2782
2783         * Scripts/webkitdirs.pm:
2784         (argumentsForRunAndDebugMacWebKitApp):
2785
2786 2012-03-28  Dave Tharp  <dtharp@codeaurora.org>
2787
2788         Add dtharp to contributors list
2789         https://bugs.webkit.org/show_bug.cgi?id=82545
2790
2791         Reviewed by Adam Barth.
2792
2793         Adding dtharp as Contributor.
2794
2795         * Scripts/webkitpy/common/config/committers.py:
2796
2797 2012-03-28  Stuart Eichert  <stuart.eichert@palm.com>
2798
2799         build-webkit : the word "pass" is spelled incorrectly as "passs"
2800         https://bugs.webkit.org/show_bug.cgi?id=82532
2801
2802         Reviewed by Julien Chaffraix.
2803
2804         Corrected spelling of the word "pass" in build-webkit.
2805
2806         * Scripts/build-webkit:
2807
2808 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
2809
2810         new-run-webkit-tests doesn't log correctly after retrying failures
2811         https://bugs.webkit.org/show_bug.cgi?id=82541
2812
2813         Unreviewed, build fix.
2814
2815         r112189 introduced a regression where we would accidentally
2816         delete the log handler after we retried any failing tests - that
2817         meant that any log messages around uploading the results got
2818         dropped.
2819
2820         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2821         (Manager._run_tests):
2822
2823 2012-03-28  Kevin Ollivier  <kevino@theolliviers.com>
2824
2825         [wx] Unreviewed. Build fix, move WTF back into JSCore target
2826         until issues with JSCore not linking in all WTF symbols are resolved.
2827
2828         * waf/build/settings.py:
2829
2830 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
2831
2832         download-built-product build step should detect 404 errors
2833         https://bugs.webkit.org/show_bug.cgi?id=82491
2834
2835         Reviewed by Ryosuke Niwa.
2836         
2837         Pass --fail to curl so that it reports 404 errors.
2838
2839         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2840         (DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
2841         * BuildSlaveSupport/built-product-archive:
2842         (extractBuiltProduct): Remove trailing whitespace.
2843
2844 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
2845
2846         flakiness dashboard should only keep the last 500 runs
2847         https://bugs.webkit.org/show_bug.cgi?id=82530
2848
2849         Reviewed by Ojan Vafai.
2850
2851         If a bot has an overly large amount of failing tests, then
2852         storing 750 runs' worth takes a lot of memory and CPU time to
2853         process and we end up getting killed by AppEngine; this cases
2854         data corruption and confusion down the road when we have to
2855         retry the upload of the data and the tests show up as multiple
2856         runs.
2857
2858         * TestResultServer/model/jsonresults.py:
2859         (JsonResults.update_file):
2860
2861 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
2862
2863         extract-built-product build step should fail if unzipping fails
2864         https://bugs.webkit.org/show_bug.cgi?id=82493
2865
2866         Reviewed by Simon Fraser.
2867
2868         Forward non-zero exit code from subprocesses so that the master can detect any failures
2869         and bail out early.
2870
2871         * BuildSlaveSupport/built-product-archive:
2872         (main):
2873
2874 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
2875
2876         test-webkitpy should support files, directories, and packages as command line args
2877         https://bugs.webkit.org/show_bug.cgi?id=76765
2878
2879         Reviewed by Adam Barth.
2880
2881         This patch adds support for specifying files, directories, and
2882         packages to test-webkitpy along with the already existing
2883         support for modules, test classes, and individual test names.
2884
2885         Also, fix a bug in filesystem_mock where we wouldn't normalize a
2886         path containing a reference to the current directory properly,
2887         for example, '/foo/./bar.py'.
2888
2889         * Scripts/webkitpy/common/system/filesystem_mock.py:
2890         (MockFileSystem.normpath):
2891         * Scripts/webkitpy/test/main.py:
2892         (Tester._configure_logging):
2893         (Tester._run_tests):
2894         * Scripts/webkitpy/test/test_finder.py:
2895         (TestDirectoryTree.find_modules):
2896         (TestDirectoryTree.subpath):
2897         (TestFinder.is_dotted_name):
2898         (TestFinder.find_names):
2899         (TestFinder):
2900         (TestFinder._find_names_for_arg):
2901         (TestFinder._find_in_trees):
2902         (TestFinder._default_names):
2903         * Scripts/webkitpy/test/test_finder_unittest.py:
2904         (TestFinderTest.setUp):
2905         (TestFinderTest.tearDown):
2906         (TestFinderTest.check_names):
2907         (TestFinderTest.test_default_names):
2908         (TestFinderTest):
2909         (TestFinderTest.test_paths):
2910
2911 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
2912
2913         Fix inspector tests when running in internal builds.
2914
2915         <rdar://problem/11050694>
2916
2917         Reviewed by Tim Hatcher.
2918
2919         * DumpRenderTree/mac/DumpRenderTree.mm:
2920         (resetDefaultsToConsistentValues):
2921         * WebKitTestRunner/TestController.cpp:
2922         (WTR::TestController::resetStateToConsistentValues):
2923
2924 2012-03-28  David Kilzer  <ddkilzer@apple.com>
2925
2926         Use xcrun to find nm and ranlib on OS X builds
2927         <http://webkit.org/b/82466>
2928
2929         Reviewed by Dan Bernstein.
2930
2931         * Scripts/build-webkit: Use xcrun to find ranlib.
2932         * Scripts/webkitdirs.pm:
2933         (determineNmPath): Added.  Use xcrun to find nm on OS X.
2934         (nmPath): Added.
2935         * Scripts/webkitperl/features.pm:
2936         (libraryContainsSymbol): Use nmPath().
2937
2938 2012-03-28  Ojan Vafai  <ojan@chromium.org>
2939
2940         Add history navigation to garden-o-matic
2941         https://bugs.webkit.org/show_bug.cgi?id=82495
2942
2943         Reviewed by Dimitri Glazkov.
2944
2945         Also, maintain scroll offsets when returning to a tab. This makes addressing
2946         expected failures considerably easier when dealing with below-the-fold tests.
2947
2948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2949         -Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
2950         switching.
2951         -Modify window.location with the tabName in the hash. Can't use pushState because this is served
2952         from a file URL and Chrome puts each different file URL in it's own origin.
2953
2954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2955         Remove the href so that clicking on the accordion item does not modify window.location.hash.
2956
2957         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2958         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2959
2960 2012-03-28  Philippe Normand  <pnormand@igalia.com>
2961
2962         [GTK] generate-gtk-doc doesn't cope with custom build directory
2963         https://bugs.webkit.org/show_bug.cgi?id=82448
2964
2965         Reviewed by Martin Robinson.
2966
2967         Pass the product directory in generate-gtkdoc arguments from
2968         build-webkit.
2969
2970         * Scripts/webkitdirs.pm:
2971         (buildAutotoolsProject):
2972         * gtk/common.py:
2973         (get_build_path):
2974
2975 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2976
2977         [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
2978         https://bugs.webkit.org/show_bug.cgi?id=82341
2979
2980         Reviewed by Martin Robinson.
2981
2982         Add --skipped=skip|ignore|only command line option.
2983
2984         * Scripts/run-gtk-tests:
2985         (TestRunner._test_cases_to_skip): Return the list of test cases
2986         to skip for the given test depending on the skipped action.
2987         (TestRunner._should_run_test): Decide whether to run the test or
2988         not depending on the skipped action.
2989         (TestRunner.run_tests): Only show the list of skipped tests when
2990         skipped action is 'skip'.
2991
2992 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2993
2994         [GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
2995         https://bugs.webkit.org/show_bug.cgi?id=82333
2996
2997         Reviewed by Martin Robinson.
2998
2999         * Scripts/run-gtk-tests:
3000         (TestRunner.SkippedTest): Add SkippedTest class to store more
3001         information about skipped tests.
3002         (TestRunner._setup_testing_environment): Use SkippedTest to add
3003         TestWebKitAccessibility to the skipped list.
3004         (TestRunner._find_skipped_test): Return the SkippedTest object for
3005         a given test path.
3006         (TestRunner._test_cases_to_skip): Returns the list of test cases
3007         that should be skipped for a given test path.
3008         (TestRunner._should_run_test): Helper funtion to decide whether
3009         the given test path should be run or not. Tests in the skipped
3010         list that don't have a list of failing test cases are not run at
3011         all. Tests in the skipped list that contain a list of test cases
3012         are run with gtester -s to skip the individual test cases.
3013         (TestRunner._run_test): Helper funtion to run a given test.
3014         (TestRunner.run_tests): Build the list of tests to run based on
3015         _should_run_test() and use helper function _run_test() to run
3016         every test.
3017
3018 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3019
3020         [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
3021         https://bugs.webkit.org/show_bug.cgi?id=52810
3022
3023         Reviewed by Simon Hausmann.
3024
3025         Use SSE2 floating point math on 32 bit instead of the default
3026         387 to make layout test result same on 32 and on 64 bit builds.
3027
3028         * qmake/mkspecs/features/unix/default_post.prf:
3029
3030 2012-03-28  Sergio Villar Senin  <svillar@igalia.com>
3031
3032         [Soup] DNS prefetching spams resolver, shoots self in the foot
3033         https://bugs.webkit.org/show_bug.cgi?id=41630
3034
3035         Reviewed by Martin Robinson.
3036
3037         Bump libsoup and glib dependencies.
3038
3039         * efl/jhbuild.modules:
3040         * gtk/jhbuild.modules:
3041
3042 2012-03-28  Gustavo Noronha Silva  <gns@gnome.org>
3043
3044         [GTK] Disable introspection for jhbuild modules
3045         https://bugs.webkit.org/show_bug.cgi?id=82395
3046
3047         Reviewed by Philippe Normand.
3048
3049         * efl/jhbuild.modules: add --disable-introspection to all modules
3050         that support it
3051         * gtk/jhbuild.modules: ditto.
3052
3053 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3054
3055         [Qt] Unreviewed, fix API tests after adding full platforms. (r111658)
3056
3057         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3058         (BuildAndTestFactory.__init__):
3059
3060 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3061
3062         [Qt] Unreviewed typo fix after r112383.
3063
3064         * Scripts/run-qtwebkit-tests:
3065         (Main.check_crash_occurences):
3066
3067 2012-03-28  Ádám Kallai  <kadam@inf.u-szeged.hu>
3068
3069         [Qt] run-qtwebkit-tests should report crashes
3070         https://bugs.webkit.org/show_bug.cgi?id=76905
3071
3072         Added checking of crashing tests. Now final summary includes the total number of crashing tests too.
3073         Made unit test for this modification by János Badics <jbadics@inf.u-szeged.hu>.
3074
3075         Reviewed by Csaba Osztrogonác.
3076
3077         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3078         (RunQtAPITests.commandComplete):
3079         (RunQtAPITests.evaluateCommand):
3080         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3081         (RunQtAPITestsTest):
3082         (test_failure):
3083         (test_crash):
3084         * Scripts/run-qtwebkit-tests:
3085         (Main.announce_results_html):
3086         (Main):
3087         (Main.check_crash_occurences):
3088         (Main.convert_to_stdout):
3089         (Main.convert_to_html):
3090
3091 2012-03-28  Kwonjin Jeong  <gram@company100.net>
3092
3093         Add support for Intel compiler on Linux QT port.
3094         https://bugs.webkit.org/show_bug.cgi?id=81077
3095
3096         Reviewed by Tor Arne Vestbø.
3097
3098         * qmake/mkspecs/features/default_post.prf:
3099         Don't hide symbols when building with Intel compiler.
3100         The symbols are needed when building QtWebKit tests.
3101
3102         * qmake/mkspecs/features/unix/icc.prf:
3103         Added to ignore icc-specific warnings.
3104         This feature is used with command-line arguments for build-webkit script.
3105
3106 2012-03-28  Philippe Normand  <pnormand@igalia.com>
3107
3108         Unreviewed, trivial update-webkit-libs-jhbuild system call fix.
3109
3110         * Scripts/update-webkitgtk-libs: This script is written in
3111         Perl. Not Python. So use perl vocabulary to refer to command line arguments.
3112
3113 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
3114
3115         kill-old-processes doesn't do anything on linux
3116         https://bugs.webkit.org/show_bug.cgi?id=82388
3117
3118         Reviewed by Tony Chang.
3119
3120         Kill cc1plus, ld, etc... on linux. Also ps aux + grep to kill old run-webkit-tests processes.
3121         This should help stabilizing Chromium linux bots.
3122
3123         * BuildSlaveSupport/kill-old-processes:
3124
3125 2012-03-28  Philippe Normand  <pnormand@igalia.com>
3126
3127         [GTK] jhbuild wrongly tricked into clean-up
3128         https://bugs.webkit.org/show_bug.cgi?id=82216
3129
3130         Reviewed by Gustavo Noronha Silva.
3131
3132         Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
3133         build tree. Also when checking if the jhbuild configuration
3134         changed use absolute md5sum paths.
3135
3136         * Scripts/webkitdirs.pm:
3137         (runAutogenForAutotoolsProjectIfNecessary):
3138         (jhbuildConfigurationChanged):
3139         (buildAutotoolsProject):
3140
3141 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3142
3143         kill-old-processes doesn't do anything on linux
3144         https://bugs.webkit.org/show_bug.cgi?id=82388
3145
3146         One more attempt to disable kill-old-processes on the Qt bots not to kill each others.
3147
3148         The platform in Factory comes from config.json, accordingly platform is fullplatform,
3149         for example: qt-4.8, qt-5.0-wk2. We have to check only the prefix of platform.
3150
3151         Reviewed by Ryosuke Niwa.
3152
3153         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3154         (Factory.__init__):
3155
3156 2012-03-28  Hao Zheng  <zhenghao@chromium.org>
3157
3158         Make Chromium port for Android use hardware gpu path default.
3159         https://bugs.webkit.org/show_bug.cgi?id=82033
3160
3161         Reviewed by Dirk Pranke.
3162
3163         Skip canvas tests, which are run in virtual gpu test suites.
3164
3165         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3166         (ChromiumAndroidPort.__init__):
3167         (ChromiumAndroidPort.skipped_tests):
3168
3169 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3170
3171         kill-old-processes doesn't do anything on linux
3172         https://bugs.webkit.org/show_bug.cgi?id=82388
3173
3174         Disable kill-old-processes on the Qt bots not to kill each others.
3175
3176         Reviewed by Ryosuke Niwa.
3177
3178         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3179         (Factory.__init__):
3180
3181 2012-03-27  Hao Zheng  <zhenghao@chromium.org>
3182
3183         Handle DRT crash caused by Android OOM.
3184         https://bugs.webkit.org/show_bug.cgi?id=82310
3185
3186         Reviewed by Tony Chang.
3187
3188         When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
3189         is stopped silently and regarded as crashed. Re-run the test for
3190         such crash.
3191
3192         Add some debug log to NRWT.
3193
3194         * Scripts/webkitpy/layout_tests/port/chromium.py:
3195         (ChromiumDriver.run_test):
3196         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3197         (ChromiumAndroidPort.__init__):
3198         (ChromiumAndroidPort.get_last_stacktrace):
3199         (ChromiumAndroidDriver.__init__):
3200         (ChromiumAndroidDriver._start):
3201         (ChromiumAndroidDriver.run_test):
3202         (ChromiumAndroidDriver._get_drt_return_value):
3203
3204 2012-03-27  Ojan Vafai  <ojan@chromium.org>
3205
3206         Fix expected results for some unittest failures.
3207
3208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3209
3210 2012-03-27  Adrienne Walker  <enne@google.com>
3211
3212         [chromium] Fix --enabled-threaded-compositing flag in DRT
3213         https://bugs.webkit.org/show_bug.cgi?id=82405
3214
3215         Reviewed by James Robinson.
3216
3217         --enable-threaded-compositing wasn't working because there was no way
3218         to set the value before it was used in the TestShell constructor.
3219
3220         To avoid adding yet another boolean parameter to TestShell's
3221         constructor, add an explicit initialize function that can operate on
3222         any boolean settings that are set post-constructor.
3223
3224         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3225         (main):
3226         * DumpRenderTree/chromium/TestShell.cpp:
3227         (TestShell::TestShell):
3228         (TestShell::initialize):
3229         * DumpRenderTree/chromium/TestShell.h:
3230         (TestShell):
3231         (TestShell::setTestShellMode):
3232
3233 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
3234
3235         new-run-webkit-tests: suppress debug output from run-safari on results file
3236         https://bugs.webkit.org/show_bug.cgi?id=82400
3237
3238         Reviewed by Ryosuke Niwa.
3239
3240         Send the run-safari output to /dev/null rather than the console.
3241
3242         * Scripts/webkitpy/layout_tests/port/mac.py:
3243         (MacPort.show_results_html_file):
3244
3245 2012-03-27  Simon Fraser  <simon.fraser@apple.com>
3246
3247         Improve error reporting in run-javascriptcore-tests
3248         https://bugs.webkit.org/show_bug.cgi?id=82379
3249
3250         Reviewed by Jessie Berlin.
3251         
3252         When the script dies, have it print out the reason for dying.
3253
3254         * Scripts/run-javascriptcore-tests:
3255
3256 2012-03-27  Eric Seidel  <eric@webkit.org>
3257
3258         Add Dave Barton to the Contributors list so I can more easily CC him on bugs
3259         https://bugs.webkit.org/show_bug.cgi?id=82373
3260
3261         Reviewed by Ryosuke Niwa.
3262
3263         Dave's committer-status in in-progress, so until then
3264         list him as a Contributor so at least I can more easily CC him on bugs.
3265
3266         * Scripts/webkitpy/common/config/committers.py:
3267
3268 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3269
3270         [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
3271         https://bugs.webkit.org/show_bug.cgi?id=82252
3272
3273         Reviewed by Gustavo Noronha Silva.
3274
3275         Appending the directory containing common.py may be problematic if
3276         another path in sys.path also contains either a common.py or a
3277         common/ module, so prepend to select our version instead. This is
3278         the case with fail2ban, which has a common/ directory which may
3279         end up being in Python's default path.
3280
3281         * efl/jhbuildrc:
3282         * gtk/jhbuildrc:
3283
3284 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
3285
3286         test-webkitpy: prepare for better test run output
3287         https://bugs.webkit.org/show_bug.cgi?id=82290
3288
3289         Reviewed by Adam Barth.
3290
3291         This code basically re-implements the output of the TextTestRunner default
3292         runner code from unittest, although the implementation is quite
3293         different, in preparation for changing the test output to be
3294         metered and possibly running in parallel.
3295
3296         The output is almost identical to before, except that instead of
3297         logging "test_regular (webkitpy.main.RunnerTest) passed" we log
3298         "webkitpy.main.RunnerTest.test_regular passed". It has always
3299         annoyed me that they invert the names to be harder to read and
3300         so that you can't copy & paste back to the input for
3301         test-webkitpy.
3302
3303         This patch is provided to add a skeleton for unit tests and for
3304         comparison to an upcoming patch that will actually add new
3305         functionality.
3306
3307         * Scripts/webkitpy/test/main.py:
3308         (Tester.__init__):
3309         (Tester._configure_logging):
3310         (Tester._run_tests):
3311         * Scripts/webkitpy/test/runner.py: Added.
3312         (TestRunner):
3313         (TestRunner.__init__):
3314         (TestRunner.test_name):
3315         (TestRunner.all_test_names):
3316         (TestRunner.run):
3317         (TestRunner.write_result):
3318         (TestRunner.write_summary):
3319         * Scripts/webkitpy/test/runner_unittest.py: Added.
3320         (FakeModuleSuite):
3321         (FakeModuleSuite.__init__):
3322         (FakeModuleSuite.__str__):
3323         (FakeModuleSuite.run):
3324         (FakeTopSuite):
3325         (FakeTopSuite.__init__):
3326         (FakeLoader):
3327         (FakeLoader.__init__):
3328         (FakeLoader.top_suite):
3329         (FakeLoader.loadTestsFromName):
3330         (RunnerTest):
3331         (RunnerTest.test_regular):
3332         (RunnerTest.test_verbose):
3333
3334 2012-03-27  Gustavo Noronha Silva  <gns@gnome.org>
3335
3336         [GTK] Build gnutls without p11-kit support
3337         https://bugs.webkit.org/show_bug.cgi?id=82212
3338
3339         Reviewed by Martin Robinson.
3340
3341         * gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
3342         configure, to avoid requiring that dependency, which is not used
3343         by libsoup and WebKit anyway
3344
3345 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3346
3347         [Qt] Make debug build work on 32 bit
3348         https://bugs.webkit.org/show_bug.cgi?id=82331
3349
3350         Use --no-keep-memory option of ld not to cache the symbol tables of input files in
3351         memory to avoid memory exhaustion during the linking phase for x86-debug builds.
3352
3353         Reviewed by Tor Arne Vestbø.
3354
3355         * qmake/mkspecs/features/unix/default_post.prf:
3356         * qmake/mkspecs/features/unix/default_pre.prf:
3357
3358 2012-03-23  Balazs Ankes  <bank@inf.u-szeged.hu>
3359
3360         Add png checking to check-webkit-style
3361         https://bugs.webkit.org/show_bug.cgi?id=75824
3362
3363         Reviewed by NOBODY Tony Chang.
3364
3365         * Scripts/webkitpy/style/checker.py:
3366         (_all_categories):
3367         (FileType):
3368         (CheckerDispatcher._should_skip_file_path):
3369         (CheckerDispatcher._file_type):
3370         (CheckerDispatcher._create_checker):
3371         * Scripts/webkitpy/style/checker_unittest.py:
3372         (CheckerDispatcherDispatchTest.test_none_paths):
3373         * Scripts/webkitpy/style/checkers/png.py: Added.
3374         (PNGChecker):
3375         (PNGChecker.__init__):
3376         (PNGChecker.check):
3377         (PNGChecker._config_file_path):
3378         * Scripts/webkitpy/style/checkers/png_unittest.py: Added.
3379         (MockSCMDetector):
3380         (MockSCMDetector.__init__):
3381         (MockSCMDetector.display_name):
3382         (MockSCMDetector.propget):
3383         (PNGCheckerTest):
3384         (PNGCheckerTest.test_init):
3385         (PNGCheckerTest.test_init.mock_handle_style_error):
3386         (PNGCheckerTest.test_check):
3387         (PNGCheckerTest.test_check.mock_handle_style_error):
3388         * Scripts/webkitpy/style/patchreader.py:
3389         (PatchReader.check):
3390
3391 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3392
3393         Unreviewed. Skip GTK+ unit tests that fail in the bots
3394
3395         * Scripts/run-gtk-tests:
3396         (TestRunner): Add failing tests to the skipped list.
3397
3398 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3399
3400         Unreviewed. Unskip all GTK+ unit test.
3401
3402         Currently, skipped tests contains the list of unit tests that have
3403         failed in one or more bots. In this moment it's not possible to
3404         skip just the test cases that fail, so the complete unit test is
3405         skipped when a single test case fails. For that reason, we don't
3406         know which test cases are actually failing for every skipped
3407         test. We are planning to land a patch to allow skipping individual
3408         test cases, but first we need to know which test cases are
3409         currently failing in the bots to skip them. So, this patch simply
3410         unskips all unit tests in order to watch the bots and get the list
3411         of test cases failing. Failing tests will be skipped again as soon
3412         as we have the new list of failing test cases.
3413
3414         * Scripts/run-gtk-tests:
3415         (TestRunner): Reset the list of skipped tests.
3416
3417 2012-03-26  Scott Byer  <scottbyer@chromium.org>
3418
3419         Enable layout testing of the scroll animator.
3420         https://bugs.webkit.org/show_bug.cgi?id=81858
3421         Add a call to the InternalSettings that layout tests can use to
3422         turn on scroll animation. Enable animation updates for the
3423         Chromium platform DRT when scroll animation has been turned on in
3424         a test. This should be a no-op for all current layout tests.
3425
3426         Reviewed by James Robinson.
3427
3428         * DumpRenderTree/chromium/WebViewHost.cpp:
3429         (WebViewHost::serviceAnimation):
3430         (WebViewHost::scheduleAnimation):
3431         * DumpRenderTree/chromium/WebViewHost.h:
3432         (WebViewHost):
3433
3434 2012-03-26  Dinu Jacob  <dinu.jacob@nokia.com>
3435
3436         [Qt][WK2] Support multi-file upload
3437         https://bugs.webkit.org/show_bug.cgi?id=81589
3438
3439         Reviewed by Simon Hausmann.
3440
3441         Modified filePicker to support multi-file upload.
3442
3443         * MiniBrowser/qt/MiniBrowser.qrc:
3444         * MiniBrowser/qt/icons/checkbox_checked.png: Added.
3445         * MiniBrowser/qt/icons/checkbox_unchecked.png: Added.
3446         * MiniBrowser/qt/js/MultiSelect.js: Added.
3447         (values):
3448         (isSelected):
3449         (removeValue):
3450         * MiniBrowser/qt/qml/CheckBox.qml: Added.
3451         * MiniBrowser/qt/qml/FilePicker.qml:
3452
3453 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
3454
3455         Retry crashing tests serially at the end of NRWT on Apple Mac
3456         https://bugs.webkit.org/show_bug.cgi?id=82233
3457
3458         Reviewed by Dirk Pranke.
3459
3460         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3461         (Manager.run):
3462         * Scripts/webkitpy/layout_tests/port/base.py:
3463         (Port.should_retry_crashes):
3464         * Scripts/webkitpy/layout_tests/port/mac.py:
3465         (MacPort.should_retry_crashes):
3466
3467 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
3468
3469         NRWT should retry failures serially
3470         https://bugs.webkit.org/show_bug.cgi?id=82241
3471
3472         Reviewed by Dirk Pranke.
3473
3474         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3475         (Manager._run_tests): Add another parameter to specify the number of workers to use.
3476         (Manager.run): Run the failures serially.
3477
3478 2012-03-26  Adrienne Walker  <enne@google.com>
3479
3480         Allow expectations on directories in virtual test suites
3481         https://bugs.webkit.org/show_bug.cgi?id=82250
3482
3483         Reviewed by Dirk Pranke.
3484
3485         lookup_virtual_test_base was only returning valid results for files
3486         and not directories. Fix by falling back to the virtual test suite
3487         mapping if possible.
3488
3489         * Scripts/webkitpy/layout_tests/port/base.py:
3490         (Port.lookup_virtual_test_base):
3491         * Scripts/webkitpy/layout_tests/port/test.py:
3492         (TestPort.skipped_tests):
3493         (TestPort.virtual_test_suites):
3494
3495 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
3496
3497         Fix duplicated ChangeLog entry from r112171.
3498
3499         Unreviewed, build fix.
3500
3501 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
3502
3503         nrwt: remove --worker-model flag
3504         https://bugs.webkit.org/show_bug.cgi?id=82112
3505
3506         Reviewed by Adam Barth.
3507
3508         The --worker-model=inline flag is basically redundant with the
3509         --child-processes=1 flag (technically, you could one run child
3510         process, but this is only useful for testing); this patch
3511         removes this flag, which simplifies things and enables more
3512         cleanup down the road.
3513
3514         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3515         (Manager._run_tests):
3516         (Manager.print_config):
3517         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3518         (get):
3519         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3520         (make_broker):
3521         (FunctionTests.test_get__inline):
3522         (FunctionTests.test_get__processes):
3523         (_TestsMixin.setUp):
3524         (_TestsMixin.make_broker):
3525         (InlineBrokerTests.setUp):
3526         (MultiProcessBrokerTests.setUp):
3527         * Scripts/webkitpy/layout_tests/port/base.py:
3528         (Port.default_child_processes):
3529         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3530         (ChromiumAndroidPort.check_sys_deps):
3531         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3532         (ChromiumAndroidPortTest):
3533         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3534         (MockDRTPortTest.make_port):
3535         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3536         (PortTestCase):
3537         (PortTestCase.make_port):
3538         * Scripts/webkitpy/layout_tests/port/test.py:
3539         (TestPort.default_child_processes):
3540         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3541         (_set_up_derived_options):
3542         (parse_args):
3543         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3544         (parse_args):
3545         (MainTest.test_batch_size):
3546         (MainTest.test_child_processes_2):
3547         (MainTest.test_child_processes_min):
3548         (MainTest.test_exception_raised):
3549         (MainTest.test_keyboard_interrupt):
3550         (MainTest.test_exit_after_n_crashes):
3551         (MainTest.assert_run_order):
3552         (MainTest.test_run_order__inline):
3553         (MainTest.test_virtual):
3554
3555 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
3556
3557         test-webkitpy: split test-finding code into a different module
3558         https://bugs.webkit.org/show_bug.cgi?id=82253
3559
3560         Reviewed by Adam Barth.
3561
3562         Per suggestion from abarth, this change splits all the
3563         filesystem-crawling, test-finding code in test-webkitpy out into
3564         a separate module and switches to using a FileSystem object.
3565         This makes things much more testable, so we also add tests :).
3566
3567         We also add a realpath() method to the Filesystem object, since
3568         test-webkitpy needs that in order to be able to resolve symlinks
3569         properly to determine whether a file is under a particular tree
3570         or not.
3571
3572         * Scripts/webkitpy/common/system/filesystem.py:
3573         (FileSystem.realpath):
3574         * Scripts/webkitpy/common/system/filesystem_mock.py:
3575         (MockFileSystem.realpath):
3576         * Scripts/webkitpy/test/main.py:
3577         (Tester.__init__):
3578         (Tester.add_tree):
3579         (Tester.run):
3580         (Tester._run_tests):
3581         (Tester._log_exception):
3582         * Scripts/webkitpy/test/test_finder.py: Added.
3583         (TestDirectoryTree):
3584         (TestDirectoryTree.__init__):
3585         (TestDirectoryTree.find_modules):
3586         (TestDirectoryTree.find_modules.file_filter):
3587         (TestDirectoryTree.to_module):
3588         (TestDirectoryTree.clean):
3589         (TestFinder):
3590         (TestFinder.__init__):
3591         (TestFinder.add_tree):
3592         (TestFinder.additional_paths):
3593         (TestFinder.clean_trees):
3594         (TestFinder.is_module):
3595         (TestFinder.to_module):
3596         (TestFinder.find_names):
3597         (TestFinder._exclude):
3598         * Scripts/webkitpy/test/test_finder_unittest.py: Added.
3599         (TestFinderTest):
3600         (TestFinderTest.setUp):
3601         (TestFinderTest.tearDown):
3602         (TestFinderTest.test_additional_system_paths):
3603         (TestFinderTest.test_is_module):
3604         (TestFinderTest.test_to_module):
3605         (TestFinderTest.test_clean):
3606         (TestFinderTest.test_find_names):
3607
3608 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3609
3610         [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
3611         https://bugs.webkit.org/show_bug.cgi?id=82209
3612
3613         Reviewed by Martin Robinson.
3614
3615         Respecting the $MAKE environment variable when it is defined makes
3616         building jhbuild more portable, as some platforms may have GNU
3617         make as gmake, for example.
3618
3619         * jhbuild/jhbuild-wrapper:
3620         (install_jhbuild):
3621
3622 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
3623
3624         add a Tree abstraction to test-webkitpy to better encapsulate things
3625         https://bugs.webkit.org/show_bug.cgi?id=82158
3626
3627         Reviewed by Adam Barth.
3628
3629         There are no functional changes in this patch, but adding a
3630         basic abstraction for the trees we are looking in for python
3631         tests will allow me to add some features later on more easily
3632         (like ignoring certain directories like webkitpy/thirdparty),
3633         and it makes things slightly less hard-coded.
3634
3635         * Scripts/test-webkitpy:
3636         * Scripts/webkitpy/test/main.py:
3637         (Tester.__init__):
3638         (Tester):
3639         (Tester.add_tree):
3640         (Tester._parse_args):
3641         (Tester._configure):
3642         (Tester.run):
3643         (Tester._find_modules):
3644         (Tester._run_tests):
3645         (Tester._is_module):
3646         (Tester._log_exception):
3647         (TestDirectoryTree):
3648         (TestDirectoryTree.__init__):
3649         (TestDirectoryTree.find_modules):
3650         (TestDirectoryTree.clean):
3651
3652 2012-03-26  Ojan Vafai  <ojan@chromium.org>
3653
3654         garden-o-matic should special case reftests
3655         https://bugs.webkit.org/show_bug.cgi?id=81812
3656
3657         Reviewed by Adam Barth.
3658
3659         On the examine page, don't show a rebaseline button for reftests.
3660         We still show it on the failure summary page because tests are grouped
3661         together. Long-term, we should make sure webkit-patch rebaseline-test
3662         never tries to rebaseline reftests.
3663
3664         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3666         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3667
3668 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
3669
3670         clean up NRWT logging/metering, be less verbose
3671         https://bugs.webkit.org/show_bug.cgi?id=73846
3672
3673         Reviewed by Ojan Vafai.
3674
3675         Re-land r112014 with a build fix for Python 2.6 compatibility.
3676
3677         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3678         (ManagerTest.test_http_locking):
3679         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3680         (AbstractWorker.run):
3681         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3682         (Worker.__init__):
3683         (Worker._set_up_logging):
3684         (Worker):
3685         (Worker._set_up_host_and_port):
3686         (Worker.run):
3687         (Worker.cleanup):
3688         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
3689         (WorkerTest.test_default_platform_in_worker):
3690         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3691         (run):
3692         (main):
3693         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3694         (MeteredStream):
3695         (MeteredStream.implements):
3696         (MeteredStream._erasure):
3697         (MeteredStream._ensure_newline):
3698         (MeteredStream.__init__):
3699         (MeteredStream.__del__):
3700         (MeteredStream.cleanup):
3701         (MeteredStream.write_throttled_update):
3702         (MeteredStream.write_update):
3703         (MeteredStream.write):
3704         (MeteredStream.writeln):
3705         (MeteredStream._erase_last_partial_line):
3706         (_LogHandler):
3707      &n