Remove the custom web page preview code
[WebKit-https.git] / Tools / ChangeLog
1 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2
3         TestWebKitAPI build is broken when ASan is enabled
4         https://bugs.webkit.org/show_bug.cgi?id=139902
5
6         Reviewed by Darin Adler.
7
8         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
9         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
10         Inherit linker flags from DebugRelease, which respects ASAN.
11
12 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
13
14         Sort the Xcode project file.
15
16         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17
18 2014-12-22  Lucas Forschler  <lforschler@apple.com>
19
20         Update apple-mac-114 to bot629.
21         
22         Unreviewed.
23         
24         * BuildSlaveSupport/build.webkit.org-config/config.json:
25
26 2014-12-22  Lucas Forschler  <lforschler@apple.com>
27
28         Replace Apple bot104 with bot124.
29         
30         Unreviewed.
31         
32         * BuildSlaveSupport/build.webkit.org-config/config.json:
33
34 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
35
36         URTBF after r177639.
37
38         * TestWebKitAPI/CMakeLists.txt:
39
40 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
41
42         [EFL] MiniBrowser steals web view's focus
43         https://bugs.webkit.org/show_bug.cgi?id=139482
44
45         Reviewed by Gyuyoung Kim.
46
47         Although we set focus on ewk_view while MiniBrowser initialization
48         Ecore steals it in a favor of main window. As a result
49         focused element on web page is unable to receive events.
50
51         * MiniBrowser/efl/main.c:
52         (window_create):
53         Prevent window from stealing web view's focus on start up.
54
55 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
56
57         [Win] Revise DRT logic to match Mac.
58
59         Rubberstamped by Anders Carlsson.
60
61         Update the Windows logic to perform initialization of preferences and WebKit
62         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
63         the same circumstances as the Mac version.
64
65         * DumpRenderTree/win/DumpRenderTree.cpp:
66         (dump):
67         (resetWebPreferencesToConsistentValues):
68         (setDefaultsToConsistentValuesForTesting):
69         (resetWebViewToConsistentStateBeforeTesting):
70         (sizeWebViewForCurrentTest):
71         (runTest):
72         (createWebViewAndOffscreenWindow):
73         (allocateGlobalControllers):
74         (prepareConsistentTestingEnvironment):
75         (main):
76         (resetDefaultsToConsistentValues): Deleted.
77
78 2014-12-19  Roger Fong  <roger_fong@apple.com>
79
80         Unreviewed. Rollout r177605.
81
82         * EWSTools/start-queue-win.sh:
83
84 2014-12-19  Roger Fong  <roger_fong@apple.com>
85
86         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
87
88         * EWSTools/start-queue-win.sh:
89
90 2014-12-19  Daniel Bates  <dabates@apple.com>
91
92         [iOS] Add WebKitSystemInterface for iOS 8.1
93         https://bugs.webkit.org/show_bug.cgi?id=139831
94
95         Reviewed by Alexey Proskuryakov.
96
97         Implement support in copy-webkitlibraries-to-product-directory to copy
98         WebKitSystemInterface for iOS to the product directory and have build-webkit
99         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
100
101         * Scripts/build-webkit:
102         * Scripts/copy-webkitlibraries-to-product-directory:
103
104 2014-12-19  Daniel Bates  <dabates@apple.com>
105
106         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
107         https://bugs.webkit.org/show_bug.cgi?id=139829
108
109         Reviewed by Alexey Proskuryakov.
110
111         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
112         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
113         expects the Xcode SDK to be specified using the --sdk-name command line argument.
114
115         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
116         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
117         logic to both avoid duplicating effort and make the command line options for
118         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
119         with the approach used in other WebKit tools.
120
121         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
122         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
123         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
124
125         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
126         improve the readability of the code.
127         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
128         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
129         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
130         be included in a library.
131         (unpackIfNecessary): Modified to call executeRanlib().
132
133 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
134
135         REGRESSION (177368): Some tests started to immediately time out
136         https://bugs.webkit.org/show_bug.cgi?id=139826
137
138         Reviewed by Daniel Bates.
139
140         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
141         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
142         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
143         ends in a load failure, we don't dump, so we used to leak the timer.
144         
145         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
146         Added a comment.
147
148 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
149
150         [Win] Add accessor for serializing HTTP loads
151         https://bugs.webkit.org/show_bug.cgi?id=139817
152
153         Reviewed by Mark Lam.
154
155         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
156         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
157         remove some redundant code from the destructor.
158
159 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
160
161         Clean up a fix for performance test bot failing to build
162         https://bugs.webkit.org/show_bug.cgi?id=139818
163
164         Reviewed by Csaba Osztrogonác.
165
166         The "_1" in step name was annoying.
167
168         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
169         (CleanBuildIfScheduled.start):
170         (RunAndUploadPerfTests):
171         (DownloadAndPerfTestFactory.__init__):
172         (DownloadAndPerfTestWebKit2Factory.__init__):
173         (CleanBuildUnconditionally): Deleted.
174         (CleanBuildUnconditionally.start): Deleted.
175
176 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
177
178         REGRESSION(r177535): It broke the GTK performance bot
179         https://bugs.webkit.org/show_bug.cgi?id=139811
180
181         Reviewed by Carlos Garcia Campos.
182
183         Trigger clean build only on mac platform.
184
185         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
186         (DownloadAndPerfTestFactory.__init__):
187         (DownloadAndPerfTestWebKit2Factory.__init__):
188
189 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
190
191         Unreviewed, moved myself to the list of committers.
192
193         * Scripts/webkitpy/common/config/contributors.json:
194
195 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
196
197         [Win] Update DumpRenderTree to more closely match Mac version
198         https://bugs.webkit.org/show_bug.cgi?id=139799
199
200         Reviewed by Tim Horton.
201
202         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
203         (AccessibilityController::accessibleElementById): Correct
204         use of BSTR to avoid leak.
205         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
206         update to match Mac version more closely.
207         (dumpFramesAsText):
208         (dump):
209         (resetDefaultsToConsistentValues):
210         (resetWebViewToConsistentStateBeforeTesting):
211         (sizeWebViewForCurrentTest):
212         (runTest):
213         (openWindows):
214         (windowToWebViewMap):
215         (createWebViewAndOffscreenWindow):
216         (sharedCFURLCache):
217         (initializeGlobalsFromCommandLineOptions):
218         (main):
219         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
220         (TestRunner::addDisallowedURL):
221         (TestRunner::applicationCacheDiskUsageForOrigin):
222         (TestRunner::syncLocalStorage):
223         (TestRunner::localStorageDiskUsageForOrigin):
224         (TestRunner::observeStorageTrackerNotifications):
225         (TestRunner::clearApplicationCacheForOrigin):
226         (TestRunner::originsWithApplicationCache):
227         (TestRunner::deleteAllLocalStorage):
228         (TestRunner::setStorageDatabaseIdleInterval):
229         (TestRunner::closeIdleLocalStorageDatabases):
230         (TestRunner::originsWithLocalStorage):
231         (TestRunner::deleteLocalStorageForOrigin):
232         (TestRunner::copyDecodedHostName):
233         (TestRunner::copyEncodedHostName):
234         (TestRunner::keepWebHistory):
235         (TestRunner::numberOfPendingGeolocationPermissionRequests):
236         (TestRunner::setAppCacheMaximumSize):
237         (TestRunner::setCustomPolicyDelegate):
238         (TestRunner::goBack):
239         (TestRunner::setDefersLoading):
240         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
241         (TestRunner::setMockDeviceOrientation):
242         (TestRunner::setMockGeolocationPosition):
243         (TestRunner::setMockGeolocationPositionUnavailableError):
244         (TestRunner::setIconDatabaseEnabled):
245         (TestRunner::setMainFrameIsFirstResponder):
246         (TestRunner::setSpatialNavigationEnabled):
247         (TestRunner::setPluginsEnabled):
248         (TestRunner::setAutomaticLinkDetectionEnabled):
249         (TestRunner::setUseDashboardCompatibilityMode):
250         (TestRunner::dispatchPendingLoadRequests):
251         (TestRunner::findString):
252         (TestRunner::setCacheModel):
253         (TestRunner::apiTestNewWindowDataLoadBaseURL):
254         (TestRunner::setWebViewEditable):
255         (TestRunner::authenticateSession):
256         (TestRunner::abortModal):
257         (TestRunner::setSerializeHTTPLoads):
258         (TestRunner::addChromeInputField):
259         (TestRunner::removeChromeInputField):
260         (TestRunner::focusWebView):
261         (TestRunner::setBackingScaleFactor):
262         (TestRunner::grantWebNotificationPermission):
263         (TestRunner::denyWebNotificationPermission):
264         (TestRunner::removeAllWebNotificationPermissions):
265         (TestRunner::simulateWebNotificationClick):
266
267 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
268
269         Add strong typing to RefCounter interface, return value as a bool.
270         https://bugs.webkit.org/show_bug.cgi?id=139776
271
272         Reviewed by Geoff Garen.
273
274         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
275         This means there is no compile time type checking to prevent mistakes. Update the count()
276         method to token<>(), templated on type used to identify the token being returned.
277         Calls to token<T>() will return a result of type RefCounter::Token<T>.
278
279         There are a few problems with the fact the counter will return you an exact count of the
280         number of outstanding tokens:
281           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
282             to do so if the value is only readable as a boolean.
283           - It is desirable to provide the value as an argument to the callback, however to make
284             this useful for integer values it is also necessary to indicate the direction of change
285             (0->1 is often interesting where 2->1 is not).
286           - There is a mismatch between the precision of returning a count, and the inherent
287             imprecision of a token based mechanism, where it may be difficult to guarantee
288             absolutely no unnecessary refcount churn, and thus unintentional counter values.
289
290         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
291         (TestWebKitAPI::TEST):
292             - update API test.
293
294 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
295
296         Disable retries on Mac Release WK2 testers
297         https://bugs.webkit.org/show_bug.cgi?id=139798
298
299         Reviewed by Simon Fraser.
300
301         * BuildSlaveSupport/build.webkit.org-config/config.json:
302
303 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
304
305         Perf tests frequently fail saying "build not up to date"
306         https://bugs.webkit.org/show_bug.cgi?id=139786
307
308         Illegitimately yet authoritatively reviewed by Lucas Forschler.
309
310         Undo the rest of the first fix, and implement the behavior differently.
311
312         is_clean isn't automatically forwarded from config.json to properties.
313
314         * BuildSlaveSupport/build.webkit.org-config/config.json:
315         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
316         (CleanBuildUnconditionally):
317         (CleanBuildUnconditionally.start):
318         (DownloadAndPerfTestFactory.__init__):
319         (DownloadAndPerfTestWebKit2Factory.__init__):
320
321 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
322
323         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
324         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
325         found nothing.
326
327         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
328         (BuildAndPerfTestFactory):
329         (BuildAndPerfTestWebKit2Factory):
330
331 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
332
333         Perf tests frequently fail saying "build not up to date"
334         https://bugs.webkit.org/show_bug.cgi?id=139786
335
336         Reviewed by Ryosuke Niwa.
337
338         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
339         directory to get rid of stale precompiled headers, and let it rebuild
340         DumpRenderTree each time, that's fast.
341
342         Also, removed unused "build and perf test" code.
343
344         * BuildSlaveSupport/build.webkit.org-config/config.json:
345
346 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
347
348         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
349
350         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
351         it easier to see what steps are missing when running under Windows.
352
353         * DumpRenderTree/win/TestRunnerWin.cpp:
354         (TestRunner::callShouldCloseOnWebView):
355         (TestRunner::clearAllApplicationCaches):
356         (TestRunner::applicationCacheDiskUsageForOrigin):
357         (TestRunner::syncLocalStorage):
358         (TestRunner::localStorageDiskUsageForOrigin):
359         (TestRunner::observeStorageTrackerNotifications):
360         (TestRunner::clearApplicationCacheForOrigin):
361         (TestRunner::originsWithApplicationCache):
362         (TestRunner::clearAllDatabases):
363         (TestRunner::deleteAllLocalStorage):
364         (TestRunner::setStorageDatabaseIdleInterval):
365         (TestRunner::closeIdleLocalStorageDatabases):
366         (TestRunner::originsWithLocalStorage):
367         (TestRunner::deleteLocalStorageForOrigin):
368         (TestRunner::numberOfPendingGeolocationPermissionRequests):
369         (jsStringRefToWString):
370         (TestRunner::setAppCacheMaximumSize):
371         (TestRunner::setDatabaseQuota):
372         (TestRunner::goBack):
373         (TestRunner::setDefersLoading):
374         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
375         (TestRunner::setAutomaticLinkDetectionEnabled):
376         (TestRunner::dispatchPendingLoadRequests):
377         (TestRunner::overridePreference):
378         (TestRunner::removeAllVisitedLinks):
379         (TestRunner::waitForPolicyDelegate):
380         (TestRunner::resetPageVisibility):
381         (TestRunner::setPageVisibility):
382         (TestRunner::grantWebNotificationPermission):
383         (TestRunner::denyWebNotificationPermission):
384         (TestRunner::removeAllWebNotificationPermissions):
385         (TestRunner::simulateWebNotificationClick):
386         (TestRunner::simulateLegacyWebNotificationClick):
387
388 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
389
390         [Win] Correct Windows tests after Bug 139149 (edit)
391         https://bugs.webkit.org/show_bug.cgi?id=139781
392
393         Reviewed by Anders Carlsson.
394
395         * DumpRenderTree/win/TestRunnerWin.cpp:
396         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
397         interface.
398
399 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
400
401         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
402         https://bugs.webkit.org/show_bug.cgi?id=139748
403
404         Reviewed by Daniel Bates.
405         
406         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
407         have all been updated.
408
409         * Scripts/webkitpy/port/factory.py:
410         (platform_options):
411
412 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
413
414         Build more of TestWebKitAPI for iOS
415         https://bugs.webkit.org/show_bug.cgi?id=139747
416
417         Reviewed by Daniel Bates.
418         
419         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
420         which excluded some tests that should be run for iOS.
421         
422         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
423         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
424         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
425         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
426         
427         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
428         to share code between Mac and iOS.
429
430         * TestWebKitAPI/Configurations/Base.xcconfig:
431         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
432         * TestWebKitAPI/InjectedBundleController.cpp:
433         * TestWebKitAPI/InjectedBundleMain.cpp:
434         * TestWebKitAPI/JavaScriptTest.cpp:
435         * TestWebKitAPI/PlatformUtilities.cpp:
436         * TestWebKitAPI/PlatformUtilities.h:
437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
438         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
439         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
440         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
441         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
442         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
443         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
444         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
445         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
446         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
447         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
448         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
449         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
450         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
451         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
452         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
453         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
454         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
455         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
456         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
457         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
458         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
459         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
460         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
461         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
462         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
463         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
464         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
465         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
466         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
467         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
468         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
469         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
470         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
471         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
472         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
473         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
474         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
475         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
476         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
477         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
478         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
479         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
480         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
481         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
482         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
483         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
484         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
485         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
486         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
487         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
488         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
489         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
490         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
491         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
492         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
493         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
494         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
495         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
496         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
497         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
498         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
499         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
500         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
501         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
502         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
503         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
504         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
505         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
506         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
507         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
508         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
509         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
510         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
511         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
512         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
513         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
514         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
515         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
516         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
517         (TestWebKitAPI::TEST):
518         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
519         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
520         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
521         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
522         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
523         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
524         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
525         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
526         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
527         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
528         (TEST):
529         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
530         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
531         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
532         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
533         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
534         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
535         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
536         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
537         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
538         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
539         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
540         (TestWebKitAPI::Util::run):
541         (TestWebKitAPI::Util::sleep):
542         (TestWebKitAPI::Util::toSTD):
543         * TestWebKitAPI/config.h:
544         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
545         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
546         (TestWebKitAPI::Util::run): Deleted.
547         (TestWebKitAPI::Util::sleep): Deleted.
548         (TestWebKitAPI::Util::toSTD): Deleted.
549
550 2014-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
551
552         [GTK] Add support for FTL JIT on ARM64
553         https://bugs.webkit.org/show_bug.cgi?id=139677
554
555         Reviewed by Csaba Osztrogonác.
556
557         * gtk/jhbuild-optional.modules:
558         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
559         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
560
561 2014-12-18  Adrian Perez de Castro  <aperez@igalia.com>
562
563         [GTK] Implement webkit_web_view_is_playing_audio()
564         https://bugs.webkit.org/show_bug.cgi?id=138918
565
566         Reviewed by Carlos Garcia Campos.
567
568         Add test case case for webkit_web_view_is_playing_audio() and the
569         WebKitWebView::is-playing-audio property.
570
571         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
572         (urlForResource): Utility function to get URLs pointing to resources
573         under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
574         (testWebViewIsPlayingAudio): Added.
575         (beforeAll):
576         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
577         (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
578         API tests resources directory, or the WebKit2 C API tests resources
579         directory. The default value of the flag is to use the WebKit2 GTK
580         one, to avoid having to change existing tests.
581         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
582         (isPlayingAudioChanged): Added.
583         (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
584         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
585
586 2014-12-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
587
588         [GTK] [EFL] Enable per_test_timeout
589         https://bugs.webkit.org/show_bug.cgi?id=139771
590
591         Reviewed by Csaba Osztrogonác.
592
593         This is needed to make WKTR use either the default port timeout, or the
594         user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
595         Otherwise WTR will use the default (30 seconds after r177363 and r177471).
596
597         * Scripts/webkitpy/port/efl.py:
598         (EflPort.supports_per_test_timeout): Enabled.
599         * Scripts/webkitpy/port/gtk.py:
600         (GtkPort.supports_per_test_timeout): Enabled.
601
602 2014-12-17  Lucas Forschler  <lforschler@apple.com>
603
604         Move Apple buildbot slaves to their new home.
605         
606         Reviewed by Roger Fong.
607
608         * BuildSlaveSupport/build.webkit.org-config/config.json:
609
610 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
611
612         REGRESSION (r177363): Gtk and Efl testing is broken
613         https://bugs.webkit.org/show_bug.cgi?id=139734
614
615         Reviewed by Simon Fraser.
616
617         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
618         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
619         affected both script and tool timeout. This is still the right place for this logic,
620         but it would be a larger refactoring than I can do right now.
621
622         * Scripts/webkitpy/port/base.py:
623         (Port.supports_per_test_timeout): Added a FIXME.
624         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
625         to avoid making tests take more time.
626
627         * Scripts/webkitpy/port/driver.py:
628         (Driver.run_test): Adjust script timeout here.
629         (Driver._check_for_driver_timeout): Fix the timeout detection.
630         (Driver._read_block): Actually use the timeout detection code.
631
632         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
633         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
634
635         * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
636         Update results for the new default.
637
638         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
639         (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
640         actually a good one.
641
642 2014-12-17  Commit Queue  <commit-queue@webkit.org>
643
644         Unreviewed, rolling out r177456.
645         https://bugs.webkit.org/show_bug.cgi?id=139749
646
647         Broke webkitpy and Mac tests (Requested by ap on #webkit).
648
649         Reverted changeset:
650
651         "REGRESSION (r177363): Gtk and Efl testing is broken"
652         https://bugs.webkit.org/show_bug.cgi?id=139734
653         http://trac.webkit.org/changeset/177456
654
655 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
656
657         REGRESSION (r177363): Gtk and Efl testing is broken
658         https://bugs.webkit.org/show_bug.cgi?id=139734
659
660         Reviewed by Simon Fraser.
661
662         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
663         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
664         affected both script and tool timeout. This is still the right place for this logic,
665         but it would be a larger refactoring than I can do right now.
666
667         * Scripts/webkitpy/port/base.py:
668         (Port.supports_per_test_timeout): Added a FIXME.
669         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
670         to avoid making tests take more time.
671
672         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
673
674         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
675         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
676
677 2014-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
678
679         [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
680         https://bugs.webkit.org/show_bug.cgi?id=139725
681
682         Reviewed by Martin Robinson.
683
684         The timeout is already in milliseconds, so we don't need to do any conversion.
685
686         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
687         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
688
689 2014-12-17  Hunseop Jeong  <hs85.jeong@samsung.com>
690
691         [EFL]Fix build warning in MiniBrowser
692         https://bugs.webkit.org/show_bug.cgi?id=139723
693
694         Reviewed by Darin Adler.
695
696         The warning is caused by the compiler wanting the first argument to be a
697         string literal, not a dynamically created string.
698
699         * MiniBrowser/efl/main.c:
700         (quit):
701
702 2014-12-16  Sam Weinig  <sam@webkit.org>
703
704         TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
705         https://bugs.webkit.org/show_bug.cgi?id=139718
706
707         Reviewed by Mark Rowe.
708
709         Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
710         files into a static lib which the command line utility can link link against.
711         This will allow us to create a TestWebKitAPI.app that can run on iOS.
712
713         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
714         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
716
717 2014-12-16  Alexey Proskuryakov  <ap@apple.com>
718
719         Sort out timeout implementations in DRT and WKTR
720         https://bugs.webkit.org/show_bug.cgi?id=139671
721
722         Remove an obsolete test that doesn't capture how run-webkit-tests interacts
723         with the tool.
724
725         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
726         (RunTest.test_hung_thread):
727
728 2014-12-15  Alexey Proskuryakov  <ap@apple.com>
729
730         Sort out timeout implementations in DRT and WKTR
731         https://bugs.webkit.org/show_bug.cgi?id=139671
732
733         Reviewed by Simon Fraser.
734
735         Test timeout implementation had many deficiencies, please see the bug for details.
736         Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
737         [ Slow ] modifiers should work a lot better.
738
739         * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
740         * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
741         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
742         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
743         DumpRenderTree already read the --timeout option from command line, and webkitpy
744         was already configured to pass it on Mac and iOS. Let's actually use it.
745         TestCommand already had the same 30 second default, so this doesn't change behavior
746         when DRT is ran manually without the option.
747         Windows DumpRenderTree will need to be fixed separately (that's easy).
748
749         * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
750         Don't print the timeout message to stdout to match WebKitTestRunner. It would be
751         slightly better to use stderr in both, as this is an out of band message, but
752         that's a larger refactoring, and the difference is minimal in practice.
753
754         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
755         (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
756         different. We want the tool to reliably detect timeouts that can be detected, and
757         not race with the script for that.
758
759         * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
760         timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
761         is honored inmore cases, that could make tests run slower.
762         * Scripts/webkitpy/port/driver.py:
763         (Driver.__init__):
764         (Driver.run_test):
765         (Driver.cmd_line):
766         (Driver._check_for_driver_timeout):
767         Detect tests that have the timeout output, and make these have the proper Timeout result.
768
769         * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
770         incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
771
772         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
773         (WTR::TestRunner::setCustomTimeout): Deleted.
774         * WebKitTestRunner/InjectedBundle/TestRunner.h:
775         (WTR::TestRunner::setCustomTimeout):
776         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
777         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
778         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
779         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
780         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
781         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
782         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
783         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
784         Updated to use a timeout passed from UI process, which used to be ignored.
785
786         * WebKitTestRunner/TestController.cpp:
787         (WTR::TestController::TestController):
788         (WTR::TestController::runUntil):
789         (WTR::TestController::getCustomTimeout): Deleted.
790         * WebKitTestRunner/TestController.h:
791         Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
792         Changed default message timeouts to match new run-webkit-tests timeout. These don't
793         affect ports where timeout is passed per test (shouldn't they all be like that?).
794
795         * WebKitTestRunner/TestInvocation.cpp:
796         (WTR::TestInvocation::invoke):
797         (WTR::TestInvocation::setCustomTimeout): Deleted.
798         * WebKitTestRunner/TestInvocation.h:
799         (WTR::TestInvocation::setCustomTimeout):
800         (WTR::TestInvocation::customTimeout):
801         Ditto.
802
803 2014-12-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
804
805         [EFL] Add logging domain for MiniBrowser
806         https://bugs.webkit.org/show_bug.cgi?id=139642
807
808         Reviewed by Gyuyoung Kim.
809
810         Similarly to EWebKit2, provide logging facility for MiniBrowser
811         based on Eina Log module to have a convenient way to display
812         all/subset/none messages for EFL based libraries and MiniBrowser.
813
814         Usage:
815         1. Disable all messages:
816            EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
817
818         2. Enable all messages:
819            EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
820
821         3. Enable MiniBrowser and EWebkit2 messages only:
822            EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
823
824         More information and examples you can find here:
825         http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
826
827         * MiniBrowser/efl/main.c:
828         (on_mouse_wheel):
829         (on_window_resize):
830         (save_page_contents_callback):
831         (script_execute_callback):
832         (on_key_down):
833         (on_download_request):
834         (on_download_finished):
835         (on_download_failed):
836         (quit):
837         (on_refresh_button_clicked):
838         (on_stop_button_clicked):
839         (navigation_button_longpress_process):
840         (on_popup_menu_item_clicked):
841         (popup_menu_populate):
842         (on_popup_menu_show):
843         (on_window_create):
844         (context_menu_item_selected_cb):
845         (context_menu_populate):
846         (on_context_menu_show):
847         (on_context_menu_hide):
848         (on_navigation_policy_decision):
849         (window_create):
850         (parse_cookies_policy):
851         (elm_main):
852         (has_scheme):
853         (list_item_label_get):
854         (on_popup_menu_hide):
855         (on_window_close):
856         (on_home_button_clicked):
857         Replace locally info() macro with newly introduced
858         one which uses Eina Log module. There is no logic change.
859
860 2014-12-15  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
861
862         [EFL] FTL JIT not working on ARM64
863         https://bugs.webkit.org/show_bug.cgi?id=139295
864
865         Reviewed by Michael Saboff.
866
867         Added patches for llvm to add ARM64 support for FTL JIT
868
869         * efl/jhbuild.modules:
870         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
871         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
872
873 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
874
875         Move Said to the committers section.
876
877         * Scripts/webkitpy/common/config/contributors.json:
878
879 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
880
881         Implement Data Detectors immediate actions for WebKit2
882         https://bugs.webkit.org/show_bug.cgi?id=139617
883         <rdar://problem/19198539>
884
885         Reviewed by Beth Dakin.
886
887         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
888         (TestWebKitAPI::TEST):
889         Temporarily disable the action menu tests while the
890         underlying code is in flux.
891
892 2014-12-14  Andreas Kling  <akling@apple.com>
893
894         Replace PassRef with Ref/Ref&& across the board.
895         <https://webkit.org/b/139587>
896
897         Reviewed by Darin Adler.
898
899         * TestWebKitAPI/Tests/WTF/Ref.cpp:
900         (TestWebKitAPI::passWithRef):
901         (TestWebKitAPI::TEST):
902         (TestWebKitAPI::passWithPassRef): Deleted.
903         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
904         (TestWebKitAPI::TEST):
905         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
906         (TestWebKitAPI::TEST):
907         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
908         (TestWebKitAPI::createTestValue):
909
910 2014-12-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
911
912         [EFL] MiniBrowser's window_create may return NULL
913         https://bugs.webkit.org/show_bug.cgi?id=139585
914
915         Reviewed by Gyuyoung Kim.
916
917         Move NULL checking before using object which window_create
918         returns.
919
920         * MiniBrowser/efl/main.c:
921         (elm_main):
922
923 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
924
925         Layout Test http/tests/loading/307-after-303-after-post.html is flaky
926         https://bugs.webkit.org/show_bug.cgi?id=73030
927
928         Reviewed by Anders Carlsson.
929
930         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
931         database to empty to avoid having it fetch default favicons at random times.
932         DumpRenderTree also disables it, and also it has a way for tests to temporarily
933         enable it.
934
935 2014-12-12  Lucas Forschler  <lforschler@apple.com>
936
937         Update Apple owned build slaves after infrastructure update.
938         
939         Reviewed by Ryosuke Niwa.
940
941         * BuildSlaveSupport/build.webkit.org-config/config.json:
942
943 2014-12-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
944
945         [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
946         https://bugs.webkit.org/show_bug.cgi?id=139537
947
948         Reviewed by Carlos Garcia Campos.
949
950         * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
951         of get_dependencies_path().
952         * jhbuild/jhbuildutils.py:
953         (get_dependencies_path): Fix the function to return the new
954         dependencies path: DependenciesPORT.
955         (enter_jhbuild_environment_if_available): Pass the port name
956         when invoking get_dependencies_path().
957
958 2014-12-10  Lucas Forschler  <lforschler@apple.com>
959
960         Update Apple owned build slaves.
961         
962         Rubber-stamped by Dana Burkart.
963         
964         * BuildSlaveSupport/build.webkit.org-config/config.json:
965
966 2014-12-10  Daniel Bates  <dabates@apple.com>
967
968         [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
969         timeout instead of test failure
970         https://bugs.webkit.org/show_bug.cgi?id=139525
971
972         Reviewed by Zalan Bujtas.
973
974         Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
975         run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
976         output.
977
978         Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
979         for the WebThread to spin its run loop before dumping its output. A test that
980         calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
981         before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
982         by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
983         because run-webkit-tests may terminate a DumpRenderTree.app process when it
984         exceeds its process time limit (defaults to 35ms) regardless of whether such
985         a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
986
987         * Scripts/webkitpy/port/ios.py:
988         (IOSSimulatorPort.default_timeout_ms):
989
990 2014-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
991
992         [GTK][WK2] Add HTML5 Notifications support
993         https://bugs.webkit.org/show_bug.cgi?id=61140
994
995         Reviewed by Carlos Garcia Campos.
996
997         * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
998         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
999         (testWebViewNotification):
1000         (beforeAll):
1001         * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
1002         (permissionRequestDialogCallback):
1003         (webViewDecidePermissionRequest):
1004         (geolocationRequestDialogCallback): Deleted.
1005
1006 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
1007
1008         Fix webkitpy test expectation
1009
1010         Not sure what I messed up, but TOTAL_SKIPS was not right.
1011
1012         * Scripts/webkitpy/port/test.py:
1013
1014 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
1015
1016         Remove virtual test support from webkitpy
1017         https://bugs.webkit.org/show_bug.cgi?id=139427
1018
1019         Reviewed by Alexey Proskuryakov.
1020
1021         It seems that the only concrete client of virtual tests is the unit tests :D
1022
1023         This patch tries to clean as much useless code as possible.
1024
1025         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1026         (RunTest.test_tolerance):
1027         (RunTest.test_virtual): Deleted.
1028         * Scripts/webkitpy/layout_tests/views/printing.py:
1029         (Printer._print_test_trace):
1030         * Scripts/webkitpy/port/base.py:
1031         (Port.expected_filename):
1032         (Port.tests):
1033         (Port.test_isfile):
1034         (Port.test_isdir):
1035         (Port.sample_process):
1036         (Port.find_system_pid):
1037         (Port.test_expectations_file_position):
1038         (Port.virtual_test_suites): Deleted.
1039         (Port): Deleted.
1040         (Port.populated_virtual_test_suites): Deleted.
1041         (Port._virtual_tests): Deleted.
1042         (Port.lookup_virtual_test_base): Deleted.
1043         (Port.lookup_virtual_test_args): Deleted.
1044         (VirtualTestSuite): Deleted.
1045         (VirtualTestSuite.__init__): Deleted.
1046         (VirtualTestSuite.__repr__): Deleted.
1047         * Scripts/webkitpy/port/base_unittest.py:
1048         (PortTest.test_test_exists):
1049         (PortTest.test_test_isfile):
1050         (PortTest.test_test_isdir):
1051         (PortTest.test_tests):
1052         * Scripts/webkitpy/port/driver.py:
1053         (DriverProxy.run_test): Deleted.
1054         * Scripts/webkitpy/port/test.py:
1055         (TestPort._skipped_tests_for_unsupported_features):
1056         (TestPort.all_baseline_variants):
1057         (TestPort.virtual_test_suites): Deleted.
1058         * Scripts/webkitpy/tool/commands/queries.py:
1059         (PrintBaselines.__init__):
1060         (PrintBaselines.execute):
1061         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1062         (PrintBaselinesTest.test_basic):
1063         (PrintBaselinesTest.test_multiple):
1064         (PrintBaselinesTest.test_csv):
1065
1066 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
1067
1068         Blink Merge: Remove 'http_lock' code from webkitpy
1069         https://bugs.webkit.org/show_bug.cgi?id=136722
1070
1071         Reviewed by Alexey Proskuryakov.
1072
1073         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
1074         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
1075
1076         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1077         (LayoutTestRunner.__init__):
1078         (LayoutTestRunner.run_tests):
1079         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
1080         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
1081         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1082         (FakePrinter.flush):
1083         (LayoutTestRunnerTests._runner):
1084         (LayoutTestRunnerTests._run_tests):
1085         (LayoutTestRunnerTests.test_servers_started):
1086         (LockCheckingRunner): Deleted.
1087         (LockCheckingRunner.__init__): Deleted.
1088         (LockCheckingRunner.handle_finished_list): Deleted.
1089         (LayoutTestRunnerTests.test_http_locking): Deleted.
1090         * Scripts/webkitpy/port/base.py:
1091         (Port.__init__):
1092         (Port.to.http_server_supports_ipv6):
1093         (Port.to.stop_websocket_server):
1094         (Port.to.acquire_http_lock): Deleted.
1095         (Port.to.release_http_lock): Deleted.
1096         * Scripts/webkitpy/port/http_lock.py: Removed.
1097         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
1098         * Scripts/webkitpy/port/ios.py:
1099         (IOSSimulatorPort.show_results_html_file):
1100         (IOSSimulatorPort.acquire_http_lock): Deleted.
1101         (IOSSimulatorPort): Deleted.
1102         (IOSSimulatorPort.release_http_lock): Deleted.
1103         * Scripts/webkitpy/port/mac.py:
1104         (MacPort.show_results_html_file):
1105         (MacPort): Deleted.
1106         (MacPort.acquire_http_lock): Deleted.
1107         (MacPort.release_http_lock): Deleted.
1108         * Scripts/webkitpy/port/mock_drt.py:
1109         (MockDRTPort.start_websocket_server):
1110         (MockDRTPort.stop_websocket_server):
1111         (MockDRTPort.acquire_http_lock): Deleted.
1112         (MockDRTPort.release_http_lock): Deleted.
1113         * Scripts/webkitpy/port/mock_drt_unittest.py:
1114         (MockDRTPortTest.test_uses_apache):
1115         (MockDRTPortTest.integration_test_http_lock): Deleted.
1116         * Scripts/webkitpy/port/port_testcase.py:
1117         (PortTestCase.assert_servers_are_up):
1118         (PortTestCase.integration_test_http_lock): Deleted.
1119         * Scripts/webkitpy/port/test.py:
1120         (TestPort.start_websocket_server):
1121         (TestPort.stop_websocket_server):
1122         (TestPort.acquire_http_lock): Deleted.
1123         (TestPort.release_http_lock): Deleted.
1124
1125 2014-12-09  Alberto Garcia  <berto@igalia.com>
1126
1127         convertToUTF8String converts null string to empty string
1128         https://bugs.webkit.org/show_bug.cgi?id=133904
1129
1130         Reviewed by Carlos Garcia Campos.
1131
1132         Test that trying to get the value of a non-existent attribute
1133         returns 0 instead of an empty string.
1134
1135         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1136         (WebKitDOMNodeTest::testInsertion):
1137
1138 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
1139
1140         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
1141         https://bugs.webkit.org/show_bug.cgi?id=139070
1142
1143         Reviewed by Carlos Garcia Campos.
1144
1145         * gtk/jhbuild.modules:
1146
1147 2014-12-08  Tim Horton  <timothy_horton@apple.com>
1148
1149         Add action menu tests
1150         https://bugs.webkit.org/show_bug.cgi?id=139156
1151
1152         Reviewed by Dean Jackson.
1153
1154         * TestWebKitAPI/PlatformWebView.h:
1155         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1156         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1157         Add a mechanism allowing tests to provide their own WKView subclass.
1158
1159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1160         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
1161         Add a file with lots of menu targets.
1162
1163         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
1164         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1165         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
1166         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
1167         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
1168
1169         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
1170
1171         (TestWebKitAPI::didFinishLoadForFrameCallback):
1172         (TestWebKitAPI::didFinishDownloadCallback):
1173         (TestWebKitAPI::didCreateDownloadDestinationCallback):
1174         Watch downloads and ensure that they match the content we expect.
1175
1176         (TestWebKitAPI::watchPasteboardForString):
1177         (TestWebKitAPI::watchPasteboardForImage):
1178         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
1179         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
1180         (TestWebKitAPI::javaScriptStringCallback):
1181         (TestWebKitAPI::javaScriptBoolCallback):
1182         (TestWebKitAPI::callJavaScriptReturningString):
1183         (TestWebKitAPI::callJavaScriptReturningBool):
1184         (TestWebKitAPI::watchEditableAreaForString):
1185         (TestWebKitAPI::waitForVideoReady):
1186         (TestWebKitAPI::retrieveSelection):
1187         (TestWebKitAPI::retrieveSelectionInElement):
1188         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
1189         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
1190         Add many helpers for testing, especially to make asynchronous things synchronous.
1191
1192         (TestWebKitAPI::windowPointForTarget):
1193         (TestWebKitAPI::inset8):
1194         Hard-code points in action-menu-targets.html for hit testing.
1195
1196         (TestWebKitAPI::TEST):
1197         Add a suite of tests for WebKit2 action menus.
1198
1199         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
1200         (TestWebKitAPI::createActionContextForPhoneNumber):
1201         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
1202         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
1203         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
1204         (TestWebKitAPI::ActionMenuTest::drawRect):
1205         (TestWebKitAPI::ActionMenuTest::didCreatePage):
1206         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
1207         so that we can test that infrastructure.
1208
1209 2014-12-08  Philippe Normand  <pnormand@igalia.com>
1210
1211         [GTK] UserMedia Permission Request API
1212         https://bugs.webkit.org/show_bug.cgi?id=136449
1213
1214         Reviewed by Carlos Garcia Campos.
1215
1216         The GTK version of the MiniBrowser has gained UserMedia permission
1217         request support.
1218
1219         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
1220         requires user permission to access audio/video devices.
1221         (permissionRequestDialogCallback):
1222         (webViewDecidePermissionRequest):
1223         (geolocationRequestDialogCallback): Deleted.
1224
1225 2014-12-08  Anders Carlsson  <andersca@apple.com>
1226
1227         Add a stubbed out method for clearing out the website data store
1228         https://bugs.webkit.org/show_bug.cgi?id=139404
1229
1230         Reviewed by Antti Koivisto.
1231
1232         Add a debug menu item for testing clearing of website data.
1233
1234         * MiniBrowser/mac/MainMenu.xib:
1235         * MiniBrowser/mac/WK2BrowserWindowController.m:
1236         (-[WK2BrowserWindowController clearWebsiteData:]):
1237
1238 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
1239
1240         Update style checker to deal with "const override"
1241         https://bugs.webkit.org/show_bug.cgi?id=139371
1242
1243         Reviewed by Csaba Osztrogonác.
1244
1245         check-webkit-style shouldn't complain about an open brace to start a
1246         line after a function definition with const override.
1247
1248         * Scripts/webkitpy/style/checkers/cpp.py:
1249         (check_braces):
1250         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1251         (CppStyleTest.test_brace_at_begin_of_line):
1252
1253 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1254
1255         [GTK] Fix GObject DOM bindings API break tests after r176920
1256         https://bugs.webkit.org/show_bug.cgi?id=139368
1257
1258         Reviewed by Gustavo Noronha Silva.
1259
1260         Remove the @version from the symbol name before comparing.
1261
1262         * gtk/check-for-webkitdom-api-breaks:
1263         (read_expected_api):
1264
1265 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1266
1267         Remove the option to automatically update the GObject DOM bindings symbols file
1268         https://bugs.webkit.org/show_bug.cgi?id=139366
1269
1270         Reviewed by Martin Robinson.
1271
1272         It's currently broken, because symbols now need to be in a
1273         specific order. Now that the symbols file only contains stable
1274         API, it's not a problem to manually update it every time new API
1275         is added.
1276
1277         * gtk/check-for-webkitdom-api-breaks:
1278         (read_expected_api):
1279         (check_api):
1280         (write_expected_api): Deleted.
1281
1282 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1283
1284         [GTK] Use GMainLoopSource in WebKitTestRunner
1285         https://bugs.webkit.org/show_bug.cgi?id=138831
1286
1287         Reviewed by Sergio Villar Senin.
1288
1289         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1290         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1291         (WTR::TestRunner::platformInitialize):
1292         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1293         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1294         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
1295         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1296         (WTR::TestController::notifyDone):
1297         (WTR::TestController::platformRunUntil):
1298         (WTR::cancelTimeout): Deleted.
1299
1300 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1301
1302         [GTK] Missing API detected in GObject DOM bindings after r176630
1303         https://bugs.webkit.org/show_bug.cgi?id=139201
1304
1305         Reviewed by Gustavo Noronha Silva.
1306
1307         Handle deprecated symbols again when generating the GObject DOM
1308         bindings documentation.
1309
1310         * gtk/webkitdom.py:
1311         (WebKitDOMDocGenerator):
1312         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
1313         (WebKitDOMDocGenerator.generate):
1314         (WebKitDOMDocGeneratorSections.__init__):
1315         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
1316         (WebKitDOMDocGeneratorSections.write_section):
1317
1318 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
1319
1320         [EFL][jhbuild] Fix libsoup build with clang
1321         https://bugs.webkit.org/show_bug.cgi?id=139088
1322
1323         Reviewed by Gyuyoung Kim.
1324
1325         * efl/jhbuild.modules:
1326         * efl/patches/soup-clang-warning-fix1.patch: Added.
1327         * efl/patches/soup-clang-warning-fix2.patch: Added.
1328
1329 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
1330
1331         [Mac] DumpRenderTree sets storage directory incorrectly
1332         https://bugs.webkit.org/show_bug.cgi?id=139347
1333
1334         Reviewed by Dan Bernstein.
1335
1336         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1337         Don't use user defaults to pass per-instance paths, as user defaults are shared
1338         across all instances.
1339
1340 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
1341
1342         AX: I cannot activate links on the mobile version of news.google.com
1343         https://bugs.webkit.org/show_bug.cgi?id=139330
1344
1345         Reviewed by Simon Fraser.
1346
1347         Implement press for iOS.
1348
1349         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1350         (AccessibilityUIElement::press):
1351
1352 2014-12-05  Daniel Bates  <dabates@apple.com>
1353
1354         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
1355         https://bugs.webkit.org/show_bug.cgi?id=139326
1356
1357         Reviewed by Anders Carlsson.
1358
1359         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
1360         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
1361         using the same scale factor as used in WebKit.
1362
1363         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1364         (createBitmapContextFromWebView):
1365
1366 2014-12-05  Anders Carlsson  <andersca@apple.com>
1367
1368         REGRESSION (r176677): All tests crash on Windows
1369         https://bugs.webkit.org/show_bug.cgi?id=139321
1370
1371         Reviewed by Alexey Proskuryakov.
1372
1373         * DumpRenderTree/win/DumpRenderTree.cpp:
1374         (runTest):
1375         Don't call CFRelease on the url while we have an outstanding pointer to its string,
1376         and use the right number of bytes when allocating the testURL buffer.
1377
1378 2014-12-05  Daniel Bates  <dabates@apple.com>
1379
1380         [iOS] DumpRenderTree produces many reference test mismatches
1381         https://bugs.webkit.org/show_bug.cgi?id=139314
1382
1383         Reviewed by Simon Fraser.
1384
1385         Fixes an issue where the scale factor used to render the snapshot taken by
1386         DumpRenderTree may differ from the device scale factor. In particular, the
1387         scale factor used to render a snapshot of a test may differ from the scale
1388         factor used to render the snapshot of its expected result.
1389
1390         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
1391         snapshot the UIWebBrowserView. This SPI always render using a scale factor
1392         of one when the backing store for the LegacyTileLayer objects were out-of-
1393         date regardless of the device scale factor. Instead we should use UIImage
1394         and CALayer API to perform the snapshot with respect to the device scale
1395         factor.
1396
1397         Additionally write iOS pixel dump support logic in terms of existing
1398         DumpRenderTree abstractions so as to support generating and comparing
1399         pixel dump checksums as well as make the iOS code more consistent with
1400         the logic used by other ports.
1401
1402         * DumpRenderTree/PixelDumpSupport.cpp:
1403         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
1404         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1405         (BitmapContext::createFromUIImage): Added.
1406         (BitmapContext::pixelData): Added.
1407         (BitmapContext::BitmapContext): Added.
1408         (computeMD5HashStringForBitmapContext): Added.
1409         (dumpBitmap): Added.
1410         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
1411         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
1412
1413 2014-12-05  Anders Carlsson  <andersca@apple.com>
1414
1415         Give all web pages a website data store
1416         https://bugs.webkit.org/show_bug.cgi?id=139317
1417
1418         Reviewed by Tim Horton.
1419
1420         * MiniBrowser/mac/AppDelegate.m:
1421         (-[BrowserAppDelegate newPrivateWindow:]):
1422         Don't release the controller - it's implicitly retained by the window.
1423
1424 2014-12-05  Daniel Bates  <dabates@apple.com>
1425
1426         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
1427         https://bugs.webkit.org/show_bug.cgi?id=137581
1428         <rdar://problem/18642906>
1429
1430         Reviewed by Simon Fraser.
1431
1432         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
1433         of the test that proceeded the currently running test.
1434
1435         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1436         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
1437         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
1438         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
1439
1440 2014-12-05  Jer Noble  <jer.noble@apple.com>
1441
1442         [WTF] MediaTime should support round-tripping from and to doubles.
1443         https://bugs.webkit.org/show_bug.cgi?id=139248
1444
1445         Reviewed by Eric Carlson.
1446
1447         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
1448         the MediaTimes after this change.
1449
1450         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1451         (WTF::operator<<):
1452         (TestWebKitAPI::TEST):
1453         * lldb/lldb_webkit.py:
1454         (WTFMediaTime_SummaryProvider):
1455         (WTFMediaTimeProvider.timeValueAsDouble):
1456         (WTFMediaTimeProvider.isIndefinite):
1457         (WTFMediaTimeProvider):
1458         (WTFMediaTimeProvider.hasDoubleValue):
1459
1460 2014-12-05  Anders Carlsson  <andersca@apple.com>
1461
1462         Add a private browsing mode to MiniBrowser
1463         https://bugs.webkit.org/show_bug.cgi?id=139308
1464
1465         Reviewed by Sam Weinig.
1466
1467         * MiniBrowser/mac/AppDelegate.m:
1468         (defaultConfiguration):
1469         (-[BrowserAppDelegate newWindow:]):
1470         (-[BrowserAppDelegate newPrivateWindow:]):
1471         * MiniBrowser/mac/MainMenu.xib:
1472         * MiniBrowser/mac/WK2BrowserWindowController.h:
1473         * MiniBrowser/mac/WK2BrowserWindowController.m:
1474         (-[WK2BrowserWindowController awakeFromNib]):
1475         (-[WK2BrowserWindowController initWithConfiguration:]):
1476         (-[WK2BrowserWindowController dealloc]):
1477         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1478
1479 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
1480
1481         Run http tests parallel
1482         https://bugs.webkit.org/show_bug.cgi?id=138958
1483
1484         Reviewed by Daniel Bates.
1485
1486         Remove the concept of "locked shard". Now http tests are just like any other tests.
1487         We start HTTP and WebSocket servers at the start if we need them, and terminate them
1488         when done with all the tests (not when the last http test runs, which is unnecessarily
1489         unpredictable).
1490
1491         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
1492         patch, they used to take over 15 minutes.
1493
1494         As part of the fix, we no longer pass the number of servers to Apache. I don't
1495         think that these parameters did what we wanted them to do; Apache handles the load
1496         just fine without them.
1497
1498         The change applies to all platforms. I fixed everything I could find on Mac, and
1499         Ossy told me that he's been running http tests in parallel for a long time. If
1500         there is increased instability for some ports, it will need to be fixed - there is
1501         generally nothing special about http tests at this point, and most code is
1502         cross-platform in WebKit2.
1503
1504         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1505         (LayoutTestRunner.__init__):
1506         (LayoutTestRunner.run_tests):
1507         (LayoutTestRunner.start_servers_with_lock):
1508         (LayoutTestRunner._handle_started_test):
1509         (Worker.handle):
1510         (Sharder.__init__):
1511         (Sharder.shard_tests):
1512         (Sharder._shard_every_file):
1513         (Sharder._shard_by_directory):
1514         (LayoutTestRunner._handle_finished_test_list): Deleted.
1515         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
1516         (Sharder._shard_in_two): Deleted.
1517         (Sharder): Deleted.
1518         (Sharder._resize_shards): Deleted.
1519         (Sharder._resize_shards.divide_and_round_up): Deleted.
1520         (Sharder._resize_shards.extract_and_flatten): Deleted.
1521         (Sharder._resize_shards.split_at): Deleted.
1522         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1523         (FakePrinter.print_workers_and_shards):
1524         (LayoutTestRunnerTests.test_servers_started.start_http_server):
1525         (LayoutTestRunnerTests.test_servers_started):
1526         (SharderTests.get_shards):
1527         (SharderTests.test_shard_by_dir):
1528         (SharderTests.test_shard_every_file):
1529         (SharderTests): Deleted.
1530         (SharderTests.test_shard_in_two): Deleted.
1531         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
1532         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
1533         (SharderTests.test_multiple_locked_shards): Deleted.
1534         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1535         (ManagerTest.test_needs_servers.get_manager):
1536         (ManagerTest.integration_test_needs_servers.get_manager):
1537         (ManagerTest.test_look_for_new_crash_logs.get_manager):
1538         (ManagerTest):
1539         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1540         (_set_up_derived_options):
1541         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1542         (RunTest.test_batch_size):
1543         (RunTest.test_max_locked_shards): Deleted.
1544         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1545         (LayoutTestApacheHttpd.__init__):
1546         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1547         (TestLayoutTestApacheHttpd.test_start_cmd):
1548         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1549         (Lighttpd.__init__):
1550         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1551         (HttpServerBase.__init__):
1552         * Scripts/webkitpy/layout_tests/views/printing.py:
1553         (Printer.print_workers_and_shards):
1554         * Scripts/webkitpy/port/base.py:
1555         (Port.default_child_processes):
1556         (Port.to.start_http_server):
1557         (Port.default_max_locked_shards): Deleted.
1558         * Scripts/webkitpy/port/port_testcase.py:
1559         (PortTestCase.make_port):
1560         (PortTestCase.test_default_max_locked_shards): Deleted.
1561         * Scripts/webkitpy/port/test.py:
1562         (TestPort.start_http_server):
1563
1564 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
1565
1566         Don't lock perf tests in run-webkit-tests
1567         https://bugs.webkit.org/show_bug.cgi?id=139264
1568
1569         Reviewed by Daniel Bates.
1570
1571         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1572         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1573         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1574         * Scripts/webkitpy/layout_tests/models/test_input.py:
1575         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1576
1577 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
1578
1579         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
1580         https://bugs.webkit.org/show_bug.cgi?id=139243
1581
1582         Reviewed by Anders Carlsson.
1583
1584         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
1585         chance to allow untrusted certificates.
1586
1587         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
1588         Set up more client objects for secondary windows. We may be able to share some of the
1589         code with main view creation function, but it's not exactly the same (notably, we
1590         do not focus a secondary window when it's done loading).
1591
1592 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
1593
1594         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
1595         https://bugs.webkit.org/show_bug.cgi?id=139071
1596
1597         Reviewed by Chris Fleizach.
1598
1599         Add string value for ATK_ROLE_STATIC in roleToString.
1600
1601         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1602
1603 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
1604
1605         check-webkit-style is confused by ternary expression inside first member initializer
1606         https://bugs.webkit.org/show_bug.cgi?id=136442
1607
1608         Reviewed by Csaba Osztrogonác.
1609
1610         * Scripts/webkitpy/style/checkers/cpp.py:
1611         (check_member_initialization_list):
1612
1613 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1614
1615         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
1616         https://bugs.webkit.org/show_bug.cgi?id=139220
1617
1618         Reviewed by Philippe Normand.
1619
1620         * gtk/jhbuild.modules:
1621         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1622
1623 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1624
1625         Remove unused JSC runtime options
1626         https://bugs.webkit.org/show_bug.cgi?id=133070
1627
1628         Reviewed by Csaba Osztrogonác.
1629
1630         * Scripts/run-jsc-stress-tests:
1631
1632 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1633
1634         [EFL] Add subtle crypto to the build system
1635         https://bugs.webkit.org/show_bug.cgi?id=138612
1636
1637         Reviewed by Csaba Osztrogonác.
1638
1639         * Scripts/webkitperl/FeatureList.pm:
1640
1641 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
1642
1643         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
1644         https://bugs.webkit.org/show_bug.cgi?id=139005
1645
1646         Reviewed by Chris Fleizach.
1647
1648         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1649         Add mapping for ATK_ROLE_CAPTION to roleToString
1650
1651 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1652
1653         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1654         https://bugs.webkit.org/show_bug.cgi?id=139149
1655
1656         Reviewed by Anders Carlsson.
1657
1658         WebKit2 already cleared application caches between runs (although it wasn't entirely
1659         effective without WebCore changes in this patch).
1660
1661         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
1662
1663         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
1664         function is not implemented on Windows, see below).
1665
1666         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
1667         Ameded a FIXME.
1668
1669 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
1670
1671         Generalize PageActivityAssertionToken
1672         https://bugs.webkit.org/show_bug.cgi?id=139106
1673
1674         Reviewed by Sam Weinig.
1675
1676         Add an API test for WTF::RefCounter.
1677
1678         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1679         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
1680         (TestWebKitAPI::TEST):
1681             - added RefCounter test.
1682
1683 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1684
1685         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
1686         https://bugs.webkit.org/show_bug.cgi?id=139174
1687
1688         Reviewed by Simon Fraser.
1689
1690         * DumpRenderTree/TestRunner.cpp:
1691         * DumpRenderTree/TestRunner.h:
1692         Renamed testPathOrURL to testURL, because this variable always contains a URL.
1693
1694         * DumpRenderTree/mac/DumpRenderTree.mm:
1695         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
1696         (testPathFromURL): Moved from FrameLoadDelegate.mm.
1697         (runTest): Set crash reporter information here, as we know the exact test URL.
1698
1699         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1700         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
1701         reporter information here.
1702
1703         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1704         * DumpRenderTree/mac/TestRunnerMac.mm:
1705         Updated for testPathOrURL renaming.
1706
1707         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1708         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
1709         test URL until load starts, so save it into TestRunner now. A new TestRunner object
1710         is created for each test.
1711
1712         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1713         (WTR::TestRunner::testURL):
1714         (WTR::TestRunner::setTestURL):
1715         Make TestRunner know the test name. For now, it's good enough to have it once load
1716         starts, but if we ever need it earlier, we can send it with BeginTest message.
1717
1718         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1719         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1720         Use test URL, not currently loading URL for CrashReporter.
1721
1722         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1723         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
1724         (WebKit1 already had it right).
1725
1726         * DumpRenderTree/win/DumpRenderTree.cpp:
1727         (sizeWebViewForCurrentTest):
1728         (runTest):
1729         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1730         (ResourceLoadDelegate::willSendRequest):
1731         Changed Windows DumpRenderTree to also use URL in TestRunner.
1732
1733 2014-12-02  Daniel Bates  <dabates@apple.com>
1734
1735         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
1736         https://bugs.webkit.org/show_bug.cgi?id=139143
1737
1738         Reviewed by David Kilzer.
1739
1740         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
1741         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
1742         crashes. Run-webkit-tests will record as crashing the test associated with the
1743         DumpRenderTree instance that wrote that string.
1744
1745         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
1746         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
1747         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
1748         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
1749         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
1750         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
1751         about a crash.
1752
1753         Additionally, update the crash message format written to standard error when LayoutTestRelay
1754         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
1755         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
1756         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
1757         when they crash in their test machinery logic/UI process code.
1758
1759         * DumpRenderTree/mac/DumpRenderTree.mm:
1760         (writeCrashedMessageOnFatalError): Added.
1761         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
1762         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
1763         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1764         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
1765         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
1766         the crash logs for WebKitTestRunner/DumpRenderTree.app.
1767         * Scripts/webkitpy/port/driver.py:
1768         (Driver.__init__): Update comment.
1769         (Driver._check_for_driver_crash): Ditto.
1770         * Scripts/webkitpy/port/ios.py:
1771         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
1772         regular expression. This constant is used as an optimization to avoid compiling the same
1773         regular expression across invocations of _get_crash_log().
1774         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
1775         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
1776         closer to where they are used.
1777
1778 2014-12-01  Anders Carlsson  <andersca@apple.com>
1779
1780         Remove WKBundleRemoveAllVisitedLinks
1781         https://bugs.webkit.org/show_bug.cgi?id=139163
1782
1783         Reviewed by Sam Weinig.
1784
1785         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
1786
1787         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1788         (WTR::InjectedBundle::beginTesting):
1789         * WebKitTestRunner/TestInvocation.cpp:
1790         (WTR::TestInvocation::invoke):
1791
1792 2014-12-02  Anders Carlsson  <andersca@apple.com>
1793
1794         Fix Windows build.
1795
1796         * DumpRenderTree/win/DumpRenderTree.cpp:
1797         (setAlwaysAcceptCookies):
1798
1799 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1800
1801         [EFL] Remove edbus dependency from jhbuild
1802         https://bugs.webkit.org/show_bug.cgi?id=139130
1803
1804         Reviewed by Gyuyoung Kim.
1805
1806         After http://trac.webkit.org/changeset/176555 we
1807         don't need it anymore.
1808
1809         * efl/jhbuild.modules:
1810
1811 2014-12-02  Philippe Normand  <pnormand@igalia.com>
1812
1813         [jhbuild] wrong Dependencies path
1814         https://bugs.webkit.org/show_bug.cgi?id=139176
1815
1816         Reviewed by Martin Robinson.
1817
1818         * Scripts/webkitpy/port/base.py:
1819         (Port._should_use_jhbuild):
1820
1821 2014-12-02  Philippe Normand  <pnormand@igalia.com>
1822
1823         [GStreamer] Bump internal jhbuild versions to 1.4.4
1824         https://bugs.webkit.org/show_bug.cgi?id=138866
1825
1826         Reviewed by Carlos Garcia Campos.
1827
1828         * gtk/jhbuild.modules:
1829         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
1830         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
1831         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1832
1833 2014-12-01  Commit Queue  <commit-queue@webkit.org>
1834
1835         Unreviewed, rolling out r176566.
1836         https://bugs.webkit.org/show_bug.cgi?id=139124
1837
1838         It broke the GTK performance tests. (Requested by clopez on
1839         #webkit).
1840
1841         Reverted changeset:
1842
1843         "[GTK] Use GMainLoopSource in WebKitTestRunner"
1844         https://bugs.webkit.org/show_bug.cgi?id=138831
1845         http://trac.webkit.org/changeset/176566
1846
1847 2014-11-29  Anders Carlsson  <andersca@apple.com>
1848
1849         Crash when calling WKPageClose on the originated page from within createNewPage callback
1850         https://bugs.webkit.org/show_bug.cgi?id=139099
1851         <rdar://problem/19052564>
1852
1853         Reviewed by Sam Weinig.
1854
1855         Add a test.
1856
1857         * TestWebKitAPI/PlatformWebView.h:
1858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1859         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
1860         (TestWebKitAPI::runJavaScriptAlert):
1861         (TestWebKitAPI::createNewPage):
1862         (TestWebKitAPI::TEST):
1863         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
1864         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1865         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1866
1867 2014-11-28  Commit Queue  <commit-queue@webkit.org>
1868
1869         Unreviewed, rolling out r176564.
1870         https://bugs.webkit.org/show_bug.cgi?id=139093
1871
1872         massive failures on release test bot (Requested by philn on
1873         #webkit).
1874
1875         Reverted changeset:
1876
1877         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
1878         https://bugs.webkit.org/show_bug.cgi?id=138866
1879         http://trac.webkit.org/changeset/176564
1880
1881 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1882
1883         [GTK] Use GMainLoopSource in WebKitTestRunner
1884         https://bugs.webkit.org/show_bug.cgi?id=138831
1885
1886         Reviewed by Sergio Villar Senin.
1887
1888         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1889         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1890         (WTR::TestRunner::platformInitialize):
1891         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1892         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1893         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
1894         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1895         (WTR::TestController::notifyDone):
1896         (WTR::TestController::platformRunUntil):
1897         (WTR::cancelTimeout): Deleted.
1898
1899 2014-11-24  Philippe Normand  <pnormand@igalia.com>
1900
1901         [GStreamer] Bump internal jhbuild versions to 1.4.4
1902         https://bugs.webkit.org/show_bug.cgi?id=138866
1903
1904         Reviewed by Carlos Garcia Campos.
1905
1906         * gtk/jhbuild.modules:
1907         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
1908         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
1909         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1910
1911 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1912
1913         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
1914         https://bugs.webkit.org/show_bug.cgi?id=138834
1915
1916         Reviewed by Sergio Villar Senin.
1917
1918         It makes everyting simpler and the tests run faster too, since we
1919         don't need to spawn the private bus and wait until the DBus name
1920         is registered. The web extension registers a new JavaSCript class
1921         with a status method to run the tests, similar to the DBus
1922         method. In the UI process side, tests use webkit_web_view_run_java_script()
1923         instead of sending a DBus message.
1924
1925         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1926         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1927         (WebKitDOMNodeFilterTest::create):
1928         (WebKitDOMNodeFilterTest::testTreeWalker):
1929         (WebKitDOMNodeFilterTest::testNodeIterator):
1930         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
1931         (WebKitDOMNodeFilterTest::runTest): Deleted.
1932         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1933         (WebKitDOMNodeTest::create):
1934         (WebKitDOMNodeTest::testHierarchyNavigation):
1935         (WebKitDOMNodeTest::testInsertion):
1936         (WebKitDOMNodeTest::testTagNames):
1937         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
1938         (WebKitDOMNodeTest::runTest): Deleted.
1939         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1940         (WebKitDOMXPathNSResolverTest::create):
1941         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1942         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1943         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
1944         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
1945         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
1946         (WebKitFrameTest::create):
1947         (WebKitFrameTest::testMainFrame):
1948         (WebKitFrameTest::testURI):
1949         (WebKitFrameTest::testJavaScriptContext):
1950         (WebKitFrameTest::webPageFromArgs): Deleted.
1951         (WebKitFrameTest::runTest): Deleted.
1952         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1953         (testWebKitDOMNodeHierarchyNavigation):
1954         (testWebKitDOMNodeInsertion):
1955         (testWebKitDOMNodeTagNames):
1956         (beforeAll):
1957         (afterAll):
1958         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
1959         (runTest):
1960         (beforeAll):
1961         (afterAll):
1962         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
1963         (testWebKitDOMXPathNSResolverNative):
1964         (testWebKitDOMXPathNSResolverCustom):
1965         (beforeAll):
1966         (afterAll):
1967         (runTest): Deleted.
1968         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
1969         (webkitFrameTestRun):
1970         (beforeAll):
1971         (afterAll):
1972         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1973         (testsMap):
1974         (WebProcessTest::add):
1975         (WebProcessTest::create):
1976         (runTest):
1977         (windowObjectClearedCallback):
1978         (webkit_web_extension_initialize):
1979         (methodCallCallback): Deleted.
1980         (webkit_web_extension_initialize_with_user_data): Deleted.
1981         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1982         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
1983         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
1984         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1985         (WebViewTest::runWebProcessTest):
1986         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1987
1988 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
1989
1990         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
1991         https://bugs.webkit.org/show_bug.cgi?id=139086
1992
1993         Reviewed by Gyuyoung Kim.
1994
1995         * efl/jhbuild.modules:
1996         * efl/patches/libseccomp-pick-up-CC.patch: Added.
1997
1998 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
1999
2000         [EFL] Add warning if CMake version is too old for building with ninja.
2001         https://bugs.webkit.org/show_bug.cgi?id=139055
2002
2003         Reviewed by Gyuyoung Kim.
2004
2005         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
2006         that version in their repositories.
2007
2008         * efl/install-dependencies:
2009
2010 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
2011
2012         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
2013         https://bugs.webkit.org/show_bug.cgi?id=139044
2014
2015         Reviewed by Chris Fleizach.
2016
2017         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
2018         The proposed solution will enable the use of this method for the object table.
2019         Existing test shows the result.
2020
2021         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2022         (WTR::AccessibilityUIElement::columnHeaders):
2023
2024 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
2025
2026         [EFL] Remove E_Dbus dependency
2027         https://bugs.webkit.org/show_bug.cgi?id=136355
2028
2029         Reviewed by Gyuyoung Kim.
2030
2031         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
2032
2033 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
2034
2035         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
2036         https://bugs.webkit.org/show_bug.cgi?id=139047
2037
2038         Reviewed by Carlos Garcia Campos.
2039
2040         * efl/jhbuild.modules:
2041         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
2042         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
2043         * gtk/jhbuild-optional.modules:
2044         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
2045         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
2046
2047 2014-11-25  Tanay C  <tanay.c@samsung.com>
2048
2049         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
2050         https://bugs.webkit.org/show_bug.cgi?id=138090
2051
2052         Reviewed by Carlos Garcia Campos.
2053
2054         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
2055         (browserWindowZoomIn): Added.
2056         (browserWindowZoomOut): Added.
2057         (scrollEventCallback): Added.
2058         (zoomInCallback): Modified.
2059         (zoomOutCallback): Modified.
2060         (browserWindowConstructed): Modified.
2061
2062 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
2063
2064         [EFL] REGRESSION(r176514): It made performance tests fail
2065         https://bugs.webkit.org/show_bug.cgi?id=139037
2066
2067         Reviewed by Gyuyoung Kim.
2068
2069         * Scripts/webkitpy/port/efl.py:
2070         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
2071         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
2072         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
2073
2074 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2075
2076         [GTK] update-webkitgtk-libs fails to build fontconfig
2077         https://bugs.webkit.org/show_bug.cgi?id=139032
2078
2079         Reviewed by Martin Robinson.
2080
2081         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
2082         fontconfig will try to generate documentation and fail.
2083
2084         * gtk/install-dependencies:
2085
2086 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2087
2088         Unreviewed. Fix GTK+ make distcheck.
2089
2090         * gtk/manifest.txt: Remove deleted files.
2091
2092 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
2093
2094         [EFL] Utilize Eail library to support accessibility in EFL
2095         https://bugs.webkit.org/show_bug.cgi?id=137742
2096
2097         Reviewed by Gyuyoung Kim.
2098
2099         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
2100
2101         * efl/jhbuild-optional.modules: Added.
2102         * efl/jhbuild.modules:
2103
2104 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2105
2106         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
2107         https://bugs.webkit.org/show_bug.cgi?id=139023
2108
2109         Reviewed by Sergio Villar Senin.
2110
2111         Rename WebKitWebView/default-context as WebKitWebView/web-context
2112         and check we are always using the right context for new web views.
2113
2114         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2115         (testWebViewWebContext):
2116         (beforeAll):
2117         (testWebViewDefaultContext): Deleted.
2118
2119 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2120
2121         [GTK] Add API to override the default local storage directory
2122         https://bugs.webkit.org/show_bug.cgi?id=138828
2123
2124         Reviewed by Gustavo Noronha Silva.
2125
2126         Add test to check that the local storage directory is created at
2127         the path given on construction.
2128
2129         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2130         (testWebContextConfiguration):
2131         (beforeAll):
2132         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2133         (Test::Test):
2134         (Test::~Test): Deleted.
2135
2136 2014-11-21  Zalan Bujtas  <zalan@apple.com>
2137
2138         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
2139         https://bugs.webkit.org/show_bug.cgi?id=138981
2140
2141         Reviewed by Simon Fraser.
2142
2143         * MiniBrowser/mac/SettingsController.h:
2144         * MiniBrowser/mac/SettingsController.m:
2145         (-[SettingsController _populateMenu]):
2146         (-[SettingsController validateMenuItem:]):
2147         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
2148         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
2149         * MiniBrowser/mac/WK1BrowserWindowController.m:
2150         (-[WK1BrowserWindowController didChangeSettings]):
2151         * MiniBrowser/mac/WK2BrowserWindowController.m:
2152         (-[WK2BrowserWindowController didChangeSettings]):
2153
2154 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
2155
2156         Remove http lock code from webkitperl
2157         https://bugs.webkit.org/show_bug.cgi?id=138959
2158
2159         Reviewed by Alexey Proskuryakov.
2160
2161         * Scripts/webkitperl/httpd.pm:
2162         (cleanUp):
2163         (extractLockNumber): Deleted.
2164         (getLockFiles): Deleted.
2165         (getNextAvailableLockNumber): Deleted.
2166         (getLockNumberForCurrentRunning): Deleted.
2167         (waitForHTTPDLock): Deleted.
2168         (scheduleHttpTesting): Deleted.
2169         (getWaitTime): Deleted.
2170
2171 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
2172
2173         [EFL] The option value of fixed layout is false in MiniBrowser
2174         https://bugs.webkit.org/show_bug.cgi?id=138830
2175
2176         Reviewed by Gyuyoung Kim.
2177
2178         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
2179
2180         * MiniBrowser/efl/main.c:
2181
2182 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
2183
2184         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
2185         https://bugs.webkit.org/show_bug.cgi?id=138871
2186
2187         Reviewed by Carlos Garcia Campos.
2188
2189         Add a test case for the convenience API for posting user messages
2190         added to the DOM bindings.
2191
2192         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2193         (testUserContentManagerMessageFromConvenienceDOMBindings):
2194         (beforeAll):
2195         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2196         (documentLoadedCallback):
2197
2198 2014-11-19  Dana Burkart  <dburkart@apple.com>
2199
2200         Work around the fact that different masters may have different names for their codebases.
2201         https://bugs.webkit.org/show_bug.cgi?id=138878
2202
2203         Reviewed by Mark Rowe.
2204
2205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2206         (parseRevisionProperty): Changed.
2207         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
2208         opensource / internal codebase naming convention.
2209
2210 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
2211
2212         AX: Screen braille input doesn't work on forms.
2213         https://bugs.webkit.org/show_bug.cgi?id=138804
2214
2215         Unreviewed build fix.
2216
2217         * DumpRenderTree/AccessibilityUIElement.cpp:
2218         (AccessibilityUIElement::setValue):
2219
2220 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
2221
2222         AX: Screen braille input doesn't work on forms.
2223         https://bugs.webkit.org/show_bug.cgi?id=138804
2224
2225         Reviewed by Mario Sanchez Prada.
2226
2227         Add a method to setValue through the AX API in DRT.
2228
2229         * DumpRenderTree/AccessibilityUIElement.cpp:
2230         (setValueCallback):
2231         (AccessibilityUIElement::getJSClass):
2232         * DumpRenderTree/AccessibilityUIElement.h:
2233         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2234         (AccessibilityUIElement::setValue):
2235         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2236         (AccessibilityUIElement::setValue):
2237
2238 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
2239
2240         Remove the WinCairo buildbot
2241         https://bugs.webkit.org/show_bug.cgi?id=138805
2242
2243         Reviewed by Alex Christensen.
2244
2245         * BuildSlaveSupport/build.webkit.org-config/config.json:
2246         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2247         (appendCustomBuildFlags):
2248         * BuildSlaveSupport/test-result-archive:
2249         (archiveTestResults):
2250
2251 2014-11-18  Daniel Bates  <dabates@apple.com>
2252
2253         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2254         SPI are not available in public SDK
2255         https://bugs.webkit.org/show_bug.cgi?id=138802
2256
2257         Reviewed by David Kilzer.
2258
2259         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
2260
2261         * DumpRenderTree/mac/CheckedMalloc.cpp:
2262
2263 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2264
2265         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
2266
2267         Forgot to fix this test before landing.
2268
2269         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2270         (testWebViewDefaultContext):
2271
2272 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2273
2274         [GTK] Add API to create a WebKitWebContext
2275         https://bugs.webkit.org/show_bug.cgi?id=138826
2276
2277         Reviewed by Gustavo Noronha Silva.
2278
2279         Use a different WebKitWebContext for every test to ensure test
2280         cases are independent to each other. Tests using DBus to
2281         communicate with the injected bundle extension now use a unique
2282         name for the well known DBus name.
2283
2284         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2285         (beforeAll): Remove comment about the order of the tests and
2286         move the success test before the failed one now that tests don't
2287         depend on each others.
2288         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2289         (beforeAll): Remove call to set the web extensions directory,
2290         since this is now done for all test in the Test constructor.
2291         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2292         (beforeAll): Do not create a temporary directory, a temporary data
2293         directory is now created for all tests.
2294         (afterAll):
2295         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2296         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
2297         to the web process test runner.
2298         (testWebKitDOMNodeInsertion): Ditto.
2299         (testWebKitDOMNodeTagNames): Ditto.
2300         (beforeAll): Remove call to set the web extensions directory.
2301         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
2302         (runTest): Pass the web extension ID to the web process test runner.
2303         (beforeAll): Remove call to set the web extensions directory.
2304         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
2305         (runTest): Pass the web extension ID to the web process test runner.
2306         (beforeAll): Remove call to set the web extensions directory.
2307         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2308         (createFileAtDestination): Use Test::dataDirectory() as base dir
2309         for temporary files.
2310         (beforeAll): Do not create a temporary directory.
2311         (afterAll):
2312         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
2313         (webkitFrameTestRun): Pass the web extension ID to the web process
2314         test runner.
2315         (beforeAll): Remove call to set the web extensions directory.
2316         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2317         (beforeAll): Remove call to set the web extensions directory.
2318         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2319         (testProcessPerWebView): Use local member instead of global variable.
2320         (testMultiprocessWebViewCreateReadyClose): Ditto.
2321         (beforeAll): Do not connect to initialize-web-extensions, Test now
2322         connects to the signal for all tests and calls a virtual method
2323         that test can override.
2324         (afterAll):
2325         (initializeWebExtensions): Deleted.
2326         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2327         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
2328         for temporary files.
2329         (beforeAll): Do not create a temporary directory.
2330         (afterAll):
2331         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2332         (beforeAll): Remove call to set the web extensions directory.
2333         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2334         (beforeAll): Remove comment about the tests order.
2335         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2336         (testWebExtensionGetTitle): Build the DBus service name using the
2337         web extension ID.
2338         (testDocumentLoadedSignal): Ditto.
2339         (testWebKitWebViewProcessCrashed): Ditto.
2340         (testWebExtensionIsolatedWorld): Ditto.
2341         (beforeAll): Remove initialization-user-data test, since now all
2342         tests are passing user data to the web extension.
2343         (testWebExtensionInitializationUserData): Deleted.
2344         (initializeWebExtensions): Deleted.
2345         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2346         (testSetDirectory): Use the web context member inherited from Test.
2347         (testClearDatabase): Ditto.
2348         (testGetFaviconURI): Ditto.
2349         (beforeAll): Do not create a temporary directory.
2350         (afterAll):
2351         (webkitFaviconDatabaseFinalizedCallback): Deleted.
2352         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2353         (UserContentManagerTest::UserContentManagerTest):
2354         (beforeAll): Remove call to set the web extensions directory.
2355         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2356         (testWebContextDefault): Check also that a newly create web
2357         context is not the default web context.
2358         (testWebContextSpellChecker): Use the web context member inherited
2359         from Test.
2360         (testWebContextLanguages): Ditto.
2361         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2362         (methodCallCallback): Remove GetInitializationUserData method.
2363         (webkit_web_extension_initialize_with_user_data): Always create
2364         the DBus name using the user data provided.
2365         (makeBusName): Deleted.
2366         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2367         (webkit_web_extension_initialize_with_user_data): Create the DBus
2368         name using the user data provided.
2369         (webkit_web_extension_initialize): Deleted.
2370         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
2371         (Test::dataDirectory): Return the temporary data directory.
2372         (removeNonEmptyDirectory): Also remove directories recursively.
2373         (main): Remove the disk cache directory initialization, since this
2374         is now done in the Test constructor.
2375         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2376         (Test::initializeWebExtensionsCallback): Call the virtual method
2377         initializeWebExtensions()
2378         (Test::Test): Create a new WebKitWebContext and initialize it.
2379         (Test::~Test): Disconnect initialize-web-extensions signal.
2380         (Test::initializeWebExtensions): Set the web extensions directory
2381         and user data.
2382         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
2383         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
2384         (WebProcessTestRunner::runTest): Build the DBus proxy using a
2385         unique name created with the Test web extension ID.
2386         (WebProcessTestRunner::proxy): Deleted.
2387         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
2388         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2389         (WebViewTest::WebViewTest): Create the web view with the Test web
2390         context.
2391         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
2392         content manager parameter to the constructor.
2393
2394 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
2395
2396         [GTK] Mesa build fails over llvm-3.5
2397         https://bugs.webkit.org/show_bug.cgi?id=138825
2398
2399         Reviewed by Gustavo Noronha Silva.
2400
2401         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
2402
2403         * gtk/jhbuild.modules:
2404         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
2405
2406 2014-11-17  Daniel Bates  <dabates@apple.com>
2407
2408         Unreviewed, rolling out r176232.
2409
2410         Broke the Mac build. Will investigate offline.
2411
2412         Reverted changeset:
2413
2414         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
2415         MobileGestalt"
2416         https://bugs.webkit.org/show_bug.cgi?id=138802
2417         http://trac.webkit.org/changeset/176232
2418
2419 2014-11-17  Daniel Bates  <dabates@apple.com>
2420
2421         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2422         SPI are not available in public SDK
2423         https://bugs.webkit.org/show_bug.cgi?id=138802
2424
2425         Reviewed by David Kilzer.
2426
2427         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
2428
2429         * DumpRenderTree/mac/CheckedMalloc.cpp:
2430
2431 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
2432
2433         Having 30+ flaky failures breaks EWS
2434         https://bugs.webkit.org/show_bug.cgi?id=138743
2435
2436         Reviewed by Alexey Proskuryakov.
2437
2438         Adds tests to ensure that the problem has been solved.
2439         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2440         (test_first_failure_limit):
2441         (test_first_failure_limit_with_some_tree_redness):
2442         (test_second_failure_limit):
2443         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
2444         (test_first_and_second_failure_limit):
2445         (test_first_and_clean_failure_limit):
2446         (test_first_second_and_clean_failure_limit):
2447         (test_very_red_tree_retry): Deleted.
2448         Really this was renamed to test_first_second_and_clean_failure_limit.
2449         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2450         Makes the appropriate changes to PatchAnalysisTask to make sure that
2451         even when the first test run hits the failure limit, it will still try
2452         a second run.
2453         (PatchAnalysisTask._results_failed_different_tests):
2454         (PatchAnalysisTask._test_patch):
2455         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
2456
2457 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
2458
2459         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
2460         https://bugs.webkit.org/show_bug.cgi?id=136018
2461
2462         Reviewed by Carlos Garcia Campos.
2463
2464         It is possible that the order of -L arguments in the output of
2465         pkg-config is wrong, which causes the linker to find the wrong
2466         version (usually older version) of libraries when running
2467         gtkdoc-scangobj.
2468
2469         * gtk/gtkdoc.py:
2470         (GTKDoc._run_gtkdoc_scangobj):
2471
2472 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2473
2474         Bump EFL version to 1.12.0
2475         https://bugs.webkit.org/show_bug.cgi?id=138733
2476
2477         Reviewed by Gyuyoung Kim.
2478
2479         * efl/jhbuild.modules:
2480
2481 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
2482
2483         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
2484         https://bugs.webkit.org/show_bug.cgi?id=138771
2485
2486         Reviewed by Chris Fleizach.
2487
2488         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
2489
2490         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2491
2492 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
2493
2494         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
2495         https://bugs.webkit.org/show_bug.cgi?id=138767
2496
2497         Reviewed by Chris Fleizach.
2498
2499         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
2500
2501         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2502
2503 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
2504
2505         Add shortcut macros to Mac TestExpectations
2506         https://bugs.webkit.org/show_bug.cgi?id=138729
2507
2508         Reviewed by Simon Fraser.
2509
2510         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
2511         Add version macros for current OS versions.
2512
2513 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
2514
2515         https://bugs.webkit.org/show_bug.cgi?id=138628
2516         A patch that doesn't apply is stuck in commit queue
2517
2518         Rubber-stamped by David Kilzer.
2519
2520         This also hopefully fixes other issues:
2521         - a patch that has cq+ flag set by a non-committer kills commit queue;
2522         - EWS never reports failing tests, and keeps spinning instead.
2523
2524         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2525         (Bugzilla.set_flag_on_attachment):
2526         (Bugzilla.obsolete_attachment):
2527         Apply the fix from r174797 to more places.
2528
2529 2014-11-13  Dan Bernstein  <mitz@apple.com>
2530
2531         Policy client not called for navigations through the page cache
2532         https://bugs.webkit.org/show_bug.cgi?id=138703
2533
2534         Reviewed by Alexey Proskuryakov.
2535
2536         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2537         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
2538         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2539
2540 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
2541
2542         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
2543         https://bugs.webkit.org/show_bug.cgi?id=137867
2544
2545         Reviewed by Chris Fleizach.
2546
2547         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
2548         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
2549         able to test for the presence of ATK_ROLE_INVALID.
2550
2551         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2552         (WTR::AccessibilityUIElement::role):
2553
2554 2014-11-13  Juergen Ributzka  <juergen@apple.com>
2555
2556         Update the "combineModules" script to handel more LLVM metadata.
2557         https://bugs.webkit.org/show_bug.cgi?id=138514
2558
2559         Reviewed by Filip Pizlo.
2560
2561         * ReducedFTL/combineModules.rb:
2562
2563 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2564
2565         Allow constructing a base PassRef with a derived Ref
2566         https://bugs.webkit.org/show_bug.cgi?id=138701
2567
2568         Reviewed by Andreas Kling
2569
2570         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2571         (TestWebKitAPI::passWithPassRef):
2572         (TestWebKitAPI::passWithPassRefPtr):
2573         (TestWebKitAPI::TEST):
2574
2575 2014-11-05  Ada Chan  <adachan@apple.com>
2576
2577         Implement new plug-in API for muting plug-ins
2578         https://bugs.webkit.org/show_bug.cgi?id=138105
2579
2580         Reviewed by Anders Carlsson.
2581
2582         Add a new plug-in test for the mute API.
2583
2584         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2585         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
2586         (SetMuted::SetMuted):
2587         (SetMuted::isMuted):
2588         (SetMuted::cachedIsMuted):
2589         (SetMuted::ScriptableObject::hasProperty):
2590         (SetMuted::ScriptableObject::getProperty):
2591         (SetMuted::ScriptableObject::pluginTest):
2592         (SetMuted::NPP_New):
2593         (SetMuted::NPP_GetValue):
2594         (SetMuted::NPP_SetValue):
2595
2596 2014-11-12  Philippe Normand  <pnormand@igalia.com>
2597
2598         Unreviewed, GTK gardening.
2599
2600         * Scripts/run-gtk-tests:
2601         (TestRunner): Skip the UserMediaBasic test because it depends on
2602         constraints validation which is going to be fixed in bug #136449.
2603
2604 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2605
2606         [GTK] Expose user script messages to GObject DOM bindings
2607         https://bugs.webkit.org/show_bug.cgi?id=138411
2608
2609         Reviewed by Philippe Normand.
2610
2611         Add a test case to check that user script messages sent using the
2612         DOM bindings API are also received in the UI process.
2613
2614         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2615         (UserScriptMessageTest::waitUntilMessageReceived):
2616         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
2617         (testUserContentManagerScriptMessageFromDOMBindings):
2618         (beforeAll):
2619         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2620         (documentLoadedCallback):
2621
2622 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2623
2624         Unreviewed. Fix GTK+ clean build after r175930.
2625
2626         Partial rollout of r175930 to not build the new unit test that
2627         broke clean builds in GTK+ port.
2628
2629         * TestWebKitAPI/PlatformGTK.cmake:
2630
2631 2014-09-01  Philippe Normand  <pnormand@igalia.com>
2632
2633         [WK2] UserMediaClient support
2634         https://bugs.webkit.org/show_bug.cgi?id=123158
2635
2636         Reviewed by Benjamin Poulain.
2637
2638         Simple API test for the UserMedia permission request API. The
2639         required test infrastructure is also added, inspired by the
2640         Geolocation infrastructure.
2641
2642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
2643         Permission request.
2644         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
2645         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
2646         (TestWebKitAPI::TEST):
2647         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
2648         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
2649         helper method to set the permission request result without user interaction.
2650         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
2651         (WTR::InjectedBundle::setUserMediaPermission):
2652         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
2653         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
2654         (WTR::TestRunner::setUserMediaPermission):
2655         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2656         * WebKitTestRunner/TestController.cpp:
2657         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
2658         request handler.
2659         (WTR::TestController::createOtherPage): Enable the new UserMedia
2660         permission request handler.
2661         (WTR::TestController::createWebViewWithOptions): Ditto.
2662         (WTR::TestController::resetPreferencesToConsistentValues): Enable
2663         MediaStream support, this is needed for getUserMedia.
2664         (WTR::TestController::resetStateToConsistentValues): clear
2665         UserMedia permissions list and flags.
2666         (WTR::TestController::setUserMediaPermission): Set permission
2667         request result and distpatch it.
2668         (WTR::TestController::handleUserMediaPermissionRequest): Save
2669         request and dispatch it.
2670         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
2671         Dispatch cached permission requests.
2672         * WebKitTestRunner/TestController.h:
2673         * WebKitTestRunner/TestInvocation.cpp:
2674         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2675
2676 2014-11-11  David Kilzer  <ddkilzer@apple.com>
2677
2678         webkit-patch --suggest-reviewers is broken with newer versions of git
2679         <http://webkit.org/b/138627>
2680
2681         Reviewed by Michael Saboff with feedback from Daniel Bates.
2682
2683         * Scripts/webkitpy/common/checkout/scm/git.py:
2684         (Git._changes_files_for_commit): Strip blank lines instead of
2685         assuming there is always a blank line at the beginning of the
2686         list.
2687
2688 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
2689
2690         DRT and WKTR touch disk cache
2691         https://bugs.webkit.org/show_bug.cgi?id=138622
2692
2693         Reviewed by Geoffrey Garen.
2694
2695         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
2696         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
2697         because this function uses the shared cache.
2698
2699         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
2700         Create an empty shared cache to prevent a default one from being created on disk.
2701
2702 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
2703
2704         [CSS Grid Layout] Limit the size of explicit/implicit grid
2705         https://bugs.webkit.org/show_bug.cgi?id=136217
2706
2707         Reviewed by Andreas Kling.
2708
2709         Added a new unit test for the CSS parser. Right now it only checks
2710         that we properly clamp the maximum number of tracks on a grid to a
2711         maximum of 1 million.
2712
2713         * TestWebKitAPI/CMakeLists.txt:
2714         * TestWebKitAPI/PlatformEfl.cmake:
2715         * TestWebKitAPI/PlatformGTK.cmake:
2716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2717         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
2718         (TestWebKitAPI::computeNumberOfTracks): Helper function.
2719         (TestWebKitAPI::TEST): Added a
2720         CSSPropertyParserTest.GridTrackLimits test case.
2721
2722 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2723
2724         webkitpy test fix after r175867
2725         https://bugs.webkit.org/show_bug.cgi?id=138607
2726
2727         Reviewed by Philippe Normand.
2728
2729         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2730         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2731
2732 2014-11-10  Philippe Normand  <pnormand@igalia.com>
2733
2734         webkitpy: demangle C++ symbols from crash log stderr
2735         https://bugs.webkit.org/show_bug.cgi?id=138565
2736
2737         Reviewed by Alexey Proskuryakov.
2738
2739         * Scripts/webkitpy/port/linux_get_crash_log.py:
2740         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
2741         with c++filt.
2742
2743 2014-11-10  Philippe Normand  <pnormand@igalia.com>
2744
2745         [GTK] fix up the GDB backtrace report tool
2746         https://bugs.webkit.org/show_bug.cgi?id=138564
2747
2748         Reviewed by Carlos Garcia Campos.
2749
2750         * Scripts/webkitpy/port/gtk.py:
2751         (GtkPort._get_crash_log): Match the process name reported by the
2752         driver with the GTK port WebProcess executable filename.
2753         * Scripts/webkitpy/port/linux_get_crash_log.py:
2754         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
2755         program.
2756         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
2757         pattern to workaround the 16 characters size limit of %e.
2758
2759 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
2760
2761         Unreviewed, moved myself to the list of committers.
2762
2763         * Scripts/webkitpy/common/config/contributors.json:
2764
2765 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2766
2767         [EFL] Fix the test font path after r175555.
2768
2769         Reviewed by Csaba Osztrogonác.
2770
2771         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
2772
2773 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
2774
2775         Fix the exception fuzz helper to generate targets in the correct range
2776         https://bugs.webkit.org/show_bug.cgi?id=138544
2777
2778         Reviewed by Filip Pizlo.
2779
2780         Currently, the script generates exception fuzz targets in the range of
2781         0..($checkCount-1). However, target 0 is never hit, while target 1 is
2782         always outside of the outermost try block of the tests, which therefore
2783         prints unexpected output and results in false failures when fired at.
2784         Additionally, target $checkCount is never generated.
2785
2786         This patch fixes the script to generate targets in the range of
2787         2..$checkCount.
2788
2789         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2790
2791 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2792
2793         make-passwords-json.py should generarate everything needed for testing
2794         https://bugs.webkit.org/show_bug.cgi?id=138503
2795
2796         Reviewed by Ryosuke Niwa.
2797
2798         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
2799         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
2800         Additionally generate auth.json, credentials.cfg and committers.cfg too.
2801         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
2802         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2803         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
2804         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
2805
2806 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2807
2808         [GTK] generate-gtkdoc should ignore invalid files
2809         https://bugs.webkit.org/show_bug.cgi?id=138542
2810
2811         Reviewed by Darin Adler.
2812
2813         * gtk/generate-gtkdoc:
2814         (files_to_ignore.file_should_be_ignored): Return True to ignore
2815         invalid files.
2816
2817 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2818
2819         Delete cookies between tests
2820         https://bugs.webkit.org/show_bug.cgi?id=138528
2821
2822         Reviewed by Sam Weinig.
2823
2824         * DumpRenderTree/mac/DumpRenderTree.mm:
2825         (resetWebPreferencesToConsistentValues):
2826         * WebKitTestRunner/TestController.cpp:
2827         (WTR::TestController::resetPreferencesToConsistentValues):
2828         Do it.
2829
2830         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2831         (WTR::InjectedBundle::beginTesting):
2832         Added a FIXME.
2833
2834 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2835
2836         [GTK] Run layout tests using the network process
2837         https://bugs.webkit.org/show_bug.cgi?id=138428
2838
2839         Reviewed by Martin Robinson.
2840
2841         Shared secondary process is the default in the GTK+ port, but we
2842         should run the tests using the network process to ensure
2843         everything works with the network process. In the future, the
2844         shared secondary process model might be a special case of multiple
2845         processes with 1 as maximum number of processes, but always using
2846         the network process.
2847
2848         * WebKitTestRunner/TestController.cpp:
2849         (WTR::TestController::initialize):
2850
2851 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2852
2853         [GTK] Allow to create a view with a related page in WTR
2854         https://bugs.webkit.org/show_bug.cgi?id=138501
2855
2856         Reviewed by Martin Robinson.
2857
2858         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
2859         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
2860         related page to WKViewCreate.
2861         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2862         (WTR::PlatformWebView::PlatformWebView): Pass the given related
2863         page to WKViewCreate.
2864
2865 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2866
2867         WTR crashes after running a test when NetworkProcess enabled
2868         https://bugs.webkit.org/show_bug.cgi?id=138500
2869
2870         Reviewed by Alexey Proskuryakov.
2871
2872         WebNotificationProvider destructor is calling
2873         WKNotificationManagerSetProvider, but m_notificationManager is
2874         null because removeNotificationManager was already called.
2875
2876         * WebKitTestRunner/WebNotificationProvider.cpp:
2877         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
2878         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
2879
2880 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
2881
2882         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
2883         regarding incorrect call to PatchAnalysisTask.report_failure
2884         https://bugs.webkit.org/show_bug.cgi?id=138229
2885
2886         Reviewed by Daniel Bates.
2887
2888         * Scripts/webkitpy/common/net/layouttestresults.py:
2889         Makes sure test_results returns a list.
2890         (LayoutTestResults.test_results):
2891         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2892         Makes unit tests also check to make sure
2893         task.results_from_patch_test_run() and
2894         task.results_from_test_run_without_patch return instances of
2895         LayoutTestResults.
2896         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2897         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2898         Condenses duplicate code into _should_defer_patch_or_throw, and
2899         removes the now-unused _clean_tree_results member.
2900         (PatchAnalysisTask.__init__):
2901         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
2902         (PatchAnalysisTask._should_defer_patch_or_throw):
2903         (PatchAnalysisTask._test_patch):
2904         (PatchAnalysisTask.results_from_patch_test_run):
2905         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
2906         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2907         Removes needless call to results_from_test_run_without_patch
2908         (AbstractEarlyWarningSystem._failing_tests_message):
2909         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2910         Changes order of test failure messages to be in the order that they
2911         appear.
2912         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2913         * Scripts/webkitpy/tool/commands/queues.py:
2914         Removes needless call to results_from_test_run_without_patch.
2915         (CommitQueue._failing_tests_message):
2916         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2917         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
2918
2919 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
2920
2921         Unreviewed. Reorder my e-mail addresses in contributors.json
2922
2923         * Scripts/webkitpy/common/config/contributors.json:
2924
2925 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
2926
2927         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
2928         https://bugs.webkit.org/show_bug.cgi?id=138475
2929
2930         Reviewed by Ryosuke Niwa.
2931
2932         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
2933         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
2934         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
2935         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
2936
2937         * Scripts/webkitpy/common/checkout/scm/git.py:
2938         (Git._run_git_svn_find_rev):
2939         Add comment mentioning that svn_revisions need to begin with 'r'.
2940         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
2941         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
2942         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
2943
2944 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2945
2946         [GTK] Add context menu API to Web Process Extensions
2947         https://bugs.webkit.org/show_bug.cgi?id=138311
2948
2949         Reviewed by Gustavo Noronha Silva.
2950
2951         Add tests cases for WebKitWebPage::context-menu signal.
2952
2953         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2954         (testContextMenuWebExtensionMenu):
2955         (testContextMenuWebExtensionNode):
2956         (beforeAll):
2957         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2958         (serializeContextMenu):
2959         (serializeNode):
2960         (contextMenuCallback):
2961         (pageCreatedCallback):
2962
2963 2014-11-06  Commit Queue  <commit-queue@webkit.org>
2964
2965         Unreviewed, rolling out r175690.
2966         https://bugs.webkit.org/show_bug.cgi?id=138460
2967
2968         We are not ready to run layout tests using the network process
2969         yet (Requested by KaL on #webkit).
2970
2971         Reverted changeset:
2972
2973         "[GTK] Run layout tests using the network process"
2974         https://bugs.webkit.org/show_bug.cgi?id=138428
2975         http://trac.webkit.org/changeset/175690
2976
2977 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2978
2979         [GTK] Run layout tests using the network process
2980         https://bugs.webkit.org/show_bug.cgi?id=138428
2981
2982         Reviewed by Martin Robinson.
2983
2984         Shared secondary process is the default in the GTK+ port, but we
2985         should run the tests using the network process to ensure
2986         everything works with the network process. In the future, the
2987         shared secondary process model might be a special case of multiple
2988         processes with 1 as maximum number of processes, but always using
2989         the network process.
2990
2991         * WebKitTestRunner/TestController.cpp:
2992         (WTR::TestController::initialize):
2993
2994 2014-11-05  Dan Bernstein  <mitz@apple.com>
2995
2996         Remove the unused deletion UI feature
2997         https://bugs.webkit.org/show_bug.cgi?id=138442
2998
2999         Rubber-stamped by Alexey Proskuryakov.
3000
3001         * DumpRenderTree/mac/EditingDelegate.mm:
3002         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
3003         delegate method that’s been removed.
3004
3005 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
3006
3007         fast/dom/remove-body-during-body-replacement2.html fails on WK2
3008         https://bugs.webkit.org/show_bug.cgi?id=138334
3009
3010         Reviewed by Anders Carlsson.
3011
3012         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
3013         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
3014         -makeFirstResponder calls, which may or may not be needed for other reasons, but
3015         it also needs to reset internal focus explicitly.
3016
3017         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
3018         WebKit behavior appears wrong, but it matches Firefox.
3019
3020         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3021         (WTR::InjectedBundlePage::resetAfterTest):
3022
3023 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3024
3025         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
3026         https://bugs.webkit.org/show_bug.cgi?id=137862
3027
3028         Reviewed by Gustavo Noronha Silva.
3029
3030         Add a test case to check that WebKitWebResource::failed-with-tls-errors
3031         is emitted when a subresource load fails due to TLS errors.
3032
3033         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3034         (TLSSubresourceTest::resourceLoadStartedCallback):
3035         (TLSSubresourceTest::TLSSubresourceTest):
3036         (TLSSubresourceTest::subresourceFailedCallback):
3037         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
3038         (TLSSubresourceTest::subresourceLoadStarted):
3039         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
3040         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
3041         (testSubresourceLoadFailedWithTLSErrors):
3042         (httpsServerCallback):
3043         (httpServerCallback):
3044         (beforeAll):
3045
3046 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
3047
3048         Build fix for some compiler versions.
3049
3050         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
3051         unhappy because this is a getter, and these shouldn't have side effects.
3052
3053 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3054
3055         Add a method for performing cherrypick-merges.
3056         https://bugs.webkit.org/show_bug.cgi?id=138375
3057
3058         Reviewed by Ryosuke Niwa.
3059
3060         Adds support for cherrypick-merges.
3061
3062         * Scripts/webkitpy/common/checkout/scm/git.py:
3063         (Git.cherrypick_merge): Added.
3064
3065 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3066
3067         Add a way to ascertain the SVN URL associated with a Git branch.
3068         https://bugs.webkit.org/show_bug.cgi?id=138374
3069
3070         Reviewed by Ryosuke Niwa.
3071
3072         The svn_url method returns the SVN URL associated with the current Git branch.
3073
3074         * Scripts/webkitpy/common/checkout/scm/git.py:
3075         (Git.svn_url): Added.
3076
3077 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3078
3079         Add the ability to search for modifications that are staged for commit.
3080         https://bugs.webkit.org/show_bug.cgi?id=138373
3081
3082         Reviewed by Ryosuke Niwa and Daniel Bates.
3083
3084         This makes is easy to do identify files that require merge post-processing,
3085         in addition to stand-alone utility.
3086
3087         * Scripts/webkitpy/common/checkout/scm/git.py:
3088         (Git.modifications_staged_for_commit): Added.
3089
3090 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3091
3092         Add a branch keyword argument to _run_git_svn_find_rev.
3093         https://bugs.webkit.org/show_bug.cgi?id=138372
3094
3095         Reviewed by Ryosuke Niwa.
3096
3097         The addition of this keyword argument allows clients to determine the Git hash
3098         of commits made on an SVN branch, provided that branch has been fetched locally.
3099
3100         * Scripts/webkitpy/common/checkout/scm/git.py:
3101         (Git._run_git_svn_find_rev):
3102         Add a branch keyword argument that is added to the end of the command, if present.
3103
3104 2014-11-04  Chris Dumez  <cdumez@apple.com>
3105
3106         Add ptr() method to Ref class
3107         https://bugs.webkit.org/show_bug.cgi?id=138361
3108
3109         Reviewed by Darin Adler.
3110
3111         Use the new Ref::ptr() method.
3112
3113         * TestWebKitAPI/Tests/WTF/Ref.cpp:
3114         (TestWebKitAPI::TEST):
3115
3116 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3117
3118         [jhbuild] Make it possible to build GTK/EFL in same repository
3119         https://bugs.webkit.org/show_bug.cgi?id=137448
3120
3121         Reviewed by Martin Robinson.
3122
3123         * Scripts/webkitdirs.pm:
3124         (getJhbuildPath):
3125         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
3126         (getPlatformFontsPath):
3127         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3128         (WTR::getFontsPath):
3129         * jhbuild/jhbuild-wrapper:
3130         (determine_platform):
3131         (install_jhbuild):
3132         * jhbuild/jhbuildrc_common.py:
3133         (init):
3134
3135 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
3136
3137         [EFL] Bump LLVM to version 3.5.0
3138         https://bugs.webkit.org/show_bug.cgi?id=138312
3139
3140         Reviewed by Csaba Osztrogonác.
3141
3142         * efl/jhbuild.modules:
3143         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
3144         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
3145
3146 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
3147
3148         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
3149         https://bugs.webkit.org/show_bug.cgi?id=138257
3150
3151         Reviewed by Tim Horton.
3152         
3153         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
3154         the user to toggle region page overlays on and off. Two overlays are available,
3155         for the non-fast scrollable region, and the region of element with wheel
3156         event handlers.
3157
3158         * MiniBrowser/mac/SettingsController.h:
3159         * MiniBrowser/mac/SettingsController.m:
3160         (-[SettingsController _populateMenu]):
3161         (-[SettingsController validateMenuItem:]):
3162         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
3163         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
3164         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
3165         (-[SettingsController toggleDebugOverlay:]):
3166         (-[SettingsController debugOverlayVisible:]):
3167         * MiniBrowser/mac/WK2BrowserWindowController.m:
3168         (-[WK2BrowserWindowController didChangeSettings]):
3169
3170 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
3171
3172         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
3173         https://bugs.webkit.org/show_bug.cgi?id=138323
3174
3175         Reviewed by Zalan Bujtas.
3176
3177         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
3178
3179 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3180
3181         [ninja] Don't remove response files for verbose builds
3182         https://bugs.webkit.org/show_bug.cgi?id=137816
3183
3184         Reviewed by Csaba Osztrogonác.
3185
3186         * Scripts/webkitdirs.pm:
3187         (determineNinjaVersion):
3188         (buildCMakeGeneratedProject):
3189
3190 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
3191
3192         [GTK] Fix the build of FTL JIT
3193         https://bugs.webkit.org/show_bug.cgi?id=138298
3194
3195         Reviewed by Carlos Garcia Campos.
3196
3197         * gtk/jhbuild-optional.modules:
3198         Bump up LLVM version to 3.5.0 release and apply patches.
3199         * gtk/patches/llvm-elf-add-stackmaps.patch:
3200         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
3201         trunk.
3202         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
3203         Added. Ensures that PC-relative relocations in EH frames are not
3204         truncated to 32 bits on x86_64.
3205
3206 2014-10-31  Michael Saboff  <msaboff@apple.com>
3207
3208         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
3209         https://bugs.webkit.org/show_bug.cgi?id=138268
3210
3211         Reviewed by Andreas Kling.
3212
3213         Added a --arch and --os option to set or override the values that are
3214         normally computed based on examining the JavaScriptCore we want to test.
3215
3216         * Scripts/run-jsc-stress-tests:
3217
3218 2014-10-31  Dan Bernstein  <mitz@apple.com>
3219
3220         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
3221         https://bugs.webkit.org/show_bug.cgi?id=138259
3222
3223         Reviewed by Geoff Garen.
3224
3225         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
3226         going to be empty to silence the warning.
3227
3228 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
3229
3230         [GTK] Support script message handlers WebKitUserContentManager
3231         https://bugs.webkit.org/show_bug.cgi?id=133730
3232
3233         Reviewed by Carlos Garcia Campos.
3234
3235         Support user script message handlers in WebKitUserContentManager.
3236         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
3237         an option is added to the CMake build files. The option is disabled
3238         globally by default, and the WebKitGTK port enables it. On the API
3239         level, two new methods to register and unregister names are provided
3240         in the "window.webkit" namespace, and on message reception the
3241         "WebKitUserContentManager::script-message-received" signal is
3242         emitted, using the registered names as signal detail.
3243
3244         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3245         Add test case for user script message handlers.
3246         (scriptMessageReceived):
3247         (testUserContentManagerScriptMessageReceived):
3248         (beforeAll):
3249
3250 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
3251
3252         bisect-builds should support WebKit clients other than Safari
3253         https://bugs.webkit.org/show_bug.cgi?id=138225
3254
3255         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
3256
3257         The -a / --application optional argument allows the user to specify which application (or application bundle)
3258         should be run against the WebKit nightly builds.
3259
3260         Reviewed by David Kilzer.
3261
3262         * Scripts/bisect-builds:
3263         Swap out $safariPath for the more general $applicationPath
3264         Leave --safari-path as a commandline option for backwards compatibility
3265         (mountAndRunNightly):
3266         Use File::Spec->cat correctly (one directory per argument)
3267         Use open --wait-apps instead of running the target application directly
3268
3269 2014-10-30  Dana Burkart  <dburkart@apple.com>
3270
3271         <rdar://problem/18821260> Perpare for the mysterious future
3272
3273         Reviewed by Lucas Forschler.
3274
3275         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3276         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3277         * LayoutTestRelay/Configurations/Base.xcconfig:
3278         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3279         * MiniBrowser/Configurations/Base.xcconfig:
3280         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3281         * TestWebKitAPI/Configurations/Base.xcconfig:
3282         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3283         * WebKitLauncher/Configurations/Base.xcconfig:
3284         * WebKitTestRunner/Configurations/Base.xcconfig:
3285         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3286
3287 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
3288
3289         Update safariVersion to safariVersionString
3290         https://bugs.webkit.org/show_bug.cgi?id=138193
3291
3292         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
3293         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
3294
3295         Rubber-stamped by David Kilzer.
3296
3297         * Scripts/bisect-builds:
3298         (makeNightlyList):
3299         Compare safariVersionString to a string literal, instead of safariVersion.
3300
3301 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
3302
3303         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
3304         https://bugs.webkit.org/show_bug.cgi?id=137775
3305
3306         Reviewed by Carlos Garcia Campos.
3307
3308         * MiniBrowser/gtk/BrowserWindow.c:
3309         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
3310         (browser_window_init):
3311
3312 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
3313
3314         CommitQueue and EWS should reject any patches that result in consistent test
3315         failures that aren't present on the tree.
3316         https://bugs.webkit.org/show_bug.cgi?id=138184
3317
3318         Reviewed by Alexey Proskuryakov.
3319
3320         * Scripts/webkitpy/layout_tests/models/test_results.py:
3321         Adds a simple hashing function to allow for set operations to handle
3322         TestResult objects properly.
3323         (TestResult.__hash__):
3324         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3325         Adds one unit test, and modifies others to agree with the notion that
3326         patches that introduce new test failures (but also have flakyness)
3327         should be rejected rather than spin.
3328         (MockCommitQueue.report_flaky_tests):
3329         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
3330         (test_double_flaky_test_failure):
3331         (test_two_flaky_tests):
3332         (test_very_flaky_patch):
3333         (test_very_flaky_patch_with_some_tree_redness):
3334         (test_different_test_failures):
3335         (test_different_test_failures_with_some_tree_redness):
3336         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
3337         (test_mildly_flaky_patch):
3338         (test_mildly_flaky_patch_with_some_tree_redness):
3339         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3340         Makes PatchAnalysisTask reject said patches.
3341         (PatchAnalysisTask._test_patch):
3342
3343 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3344
3345         WinCairoRequirements.zip cannot be downloaded from dropbox
3346         https://bugs.webkit.org/show_bug.cgi?id=138113
3347
3348         Reviewed by Alexey Proskuryakov.
3349
3350         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
3351
3352 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
3353
3354         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
3355         https://bugs.webkit.org/show_bug.cgi?id=138193
3356
3357         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
3358         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
3359
3360         It also does a bit of refactoring, including distinguishing between versions and version strings and
3361         saving versions to local variables instead of using eval in each conditional.
3362
3363         Reviewed by David Kilzer.
3364
3365         * Scripts/bisect-builds:
3366         (makeNightlyList):
3367         Restrict the set of nightlies to r174650 and above when running Yosemite.
3368         Restrict the set of nightlies to r157846 and above when running Mavericks.
3369         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
3370
3371 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
3372
3373         [EFL] build-webkit should try harder to avoid re-running cmake
3374         https://bugs.webkit.org/show_bug.cgi?id=137949
3375
3376         Reviewed by Martin Robinson.
3377
3378         * Scripts/webkitdirs.pm:
3379         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
3380         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
3381
3382 2014-10-28  Daniel Bates  <dabates@apple.com>
3383
3384         Unify logic in RunTests.run() to run the Python unit tests
3385         https://bugs.webkit.org/show_bug.cgi?id=138160
3386
3387         Reviewed by Martin Robinson.
3388
3389         Unify the interactive and non-interactive code path for running the Python unit tests
3390         in step RunTests so as to remove duplicate code to compute the the path to the script
3391         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
3392
3393         No new tests since no functionality was changed.
3394
3395         * Scripts/webkitpy/port/base.py:
3396         (Port.python_unittest_results_directory):
3397         * Scripts/webkitpy/tool/steps/runtests.py:
3398         (RunTests.run):
3399
3400 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
3401
3402         Make runtest.py call test-webkitpy with the --json flag when in
3403         non-interactive mode.
3404         https://bugs.webkit.org/show_bug.cgi?id=137667
3405
3406         Reviewed by Daniel Bates.
3407
3408         * Scripts/webkitpy/port/base.py:
3409         Adds the python_unittest_results_directory method.
3410         (Port.python_unittest_results_directory):
3411         * Scripts/webkitpy/tool/steps/runtests.py:
3412         Changes RunTests to call test-webkitpy with the --json flag if the
3413         --non-interactive flag is set.
3414         (RunTests):
3415         (RunTests.run):
3416
3417 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
3418
3419         import-w3c-tests should use re.escape() wherever it's handling file paths
3420         https://bugs.webkit.org/show_bug.cgi?id=137934
3421
3422         This patch adds re.escape() to a few places where we're doing string
3423         conversions. This prevents errors when attribute values coincidentally
3424         have character sequences that can be interpreted as regular expressions.
3425
3426         Reviewed by Bem Jones-Bey.
3427
3428         * Scripts/webkitpy/w3c/test_converter.py:
3429         (_W3CTestConverter.convert_attributes_if_needed):
3430
3431 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3432
3433         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
3434         https://bugs.webkit.org/show_bug.cgi?id=138130
3435
3436         Reviewed by Csaba Osztrogonác.
3437
3438         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3439
3440 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
3441
3442         Fix link to Arch Linux Wiki
3443         https://bugs.webkit.org/show_bug.cgi?id=138010
3444
3445         Reviewed by Benjamin Poulain.
3446
3447         * gtk/install-dependencies:
3448
3449 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
3450
3451         Test regressions are not detected when image result is missing
3452         https://bugs.webkit.org/show_bug.cgi?id=138070
3453
3454         Reviewed by Simon Fraser.
3455
3456         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3457         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3458         Count these as regressions, not as flaky tests.
3459
3460         * Scripts/webkitpy/port/test.py:
3461         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3462         Test it.
3463
3464 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
3465
3466         Add Conrad Shultz to the contributors list.
3467
3468         * Scripts/webkitpy/common/config/contributors.json:
3469
3470 2014-10-24  Dan Bernstein  <mitz@apple.com>
3471
3472         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
3473         https://bugs.webkit.org/show_bug.cgi?id=138046
3474
3475         Reviewed by Alexey Proskuryakov.
3476
3477         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3478         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
3479         401. Otherwise, we’ll retry normally in 45 seconds.
3480
3481 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
3482
3483         [GTK] Implement is_selected method on WebKitHitTestResult
3484         https://bugs.webkit.org/show_bug.cgi?id=137110
3485
3486         Reviewed by Tim Horton.
3487
3488         Add tests for new context SELECTION on WebKitHitTestResult.
3489
3490         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3491         (testContextMenuDefaultMenu):
3492         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3493         (testWebViewMouseTarget):
3494
3495 2014-10-23  Roger Fong  <roger_fong@apple.com>
3496
3497         [Win] Skip failing JSC tests following r175078
3498         https://bugs.webkit.org/show_bug.cgi?id=130967.
3499
3500         * Scripts/run-javascriptcore-tests:
3501
3502 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
3503
3504         commitqueuetask_unittest.py should be made more concise.
3505         https://bugs.webkit.org/show_bug.cgi?id=137985
3506
3507         Reviewed by Alexey Proskuryakov.
3508
3509         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3510         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
3511         (MockCommitQueue.__init__):
3512         (MockCommitQueue.report_flaky_tests):
3513         (MockCommitQueue):
3514         (MockCommitQueue.get_reported_flaky_tests):
3515         (MockSimpleTestPlanCommitQueue.__init__):
3516         (MockSimpleTestPlanCommitQueue.run_command):
3517         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
3518         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
3519         (test_land_failure):
3520         (test_failed_archive):
3521         (test_double_flaky_test_failure):
3522         (test_test_failure):
3523         (test_red_test_failure):
3524         (test_very_red_tree_retry):
3525         (test_red_tree_patch_rejection):
3526         (test_one_flaky_test):
3527         (test_tree_more_red_than_patch):
3528         (MockCommitQueue.test_results): Deleted.
3529         (test_simple_flaky_test_failure): Deleted.
3530         (_expect_validate): Deleted.
3531         (_expect_validate.MockDelegate): Deleted.
3532         (_expect_validate.MockDelegate.refetch_patch): Deleted.
3533         (_expect_validate.MockDelegate.expected_failures): Deleted.
3534         (_mock_patch): Deleted.
3535         (test_validate): Deleted.
3536         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3537         Fixes a bug that slipped through the cracks prior to this change.
3538         (PatchAnalysisTask._test_patch):
3539
3540 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
3541
3542         Flakiness dashboard should support OS X Yosemite
3543         https://bugs.webkit.org/show_bug.cgi?id=137986
3544
3545         Reviewed by Ryosuke Niwa.
3546
3547         * TestResultServer/app.yaml:
3548         * TestResultServer/static-dashboards/builders.jsonp:
3549         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3550
3551 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
3552
3553         commitqueuetask should include more tests to ensure that the behavior
3554         of PatchAnalysisTask._test_patch() is well defined
3555         https://bugs.webkit.org/show_bug.cgi?id=137977
3556
3557         Reviewed by Alexey Proskuryakov.
3558
3559         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3560         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
3561         and more readable to define tests that are meant to test the behaviour
3562         of PatchAnalysisTask._test_patch(), and adds several unit tests.
3563         (FailingTestCommitQueue.test_results):
3564         (PatchAnalysisResult):
3565         (MockSimpleTestPlanCommitQueue):
3566         (MockSimpleTestPlanCommitQueue.__init__):
3567         (MockSimpleTestPlanCommitQueue.run_command):
3568         (MockSimpleTestPlanCommitQueue._mock_test_result):
3569         (MockSimpleTestPlanCommitQueue.test_results):
3570         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
3571         (test_flaky_test_failure):
3572         (test_failed_archive):
3573         (test_two_flaky_tests):
3574         (test_one_flaky_test):
3575         (test_very_flaky_patch):
3576         (test_very_flaky_patch_with_some_tree_redness):
3577         (test_different_test_failures):
3578         (test_different_test_failures_with_some_tree_redness):
3579         (test_mildly_flaky_patch):
3580         (test_mildly_flaky_patch_with_some_tree_redness):
3581         (test_tree_more_red_than_patch):
3582
3583 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
3584
3585         PatchAnalysisTask._test_patch() needs refactoring
3586         https://bugs.webkit.org/show_bug.cgi?id=137904
3587
3588         Reviewed by Alexey Proskuryakov.
3589
3590         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3591         Fixes several small bugs, and makes minor changes to accomodate the
3592         changes in PatchAnalysisTask.
3593         (MockCommitQueue.refetch_patch):
3594         (MockCommitQueue.test_results):
3595         (test_flaky_test_failure):
3596         (test_failed_archive):
3597         (test_very_red_tree_retry):
3598         (_expect_validate.MockDelegate.refetch_patch):
3599         (MockCommitQueue.expected_failures): Deleted.
3600         (_expect_validate.MockDelegate.expected_failures): Deleted.
3601         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
3602         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
3603         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3604         Removes the unexpected_failures member, adds the _clean_tree_results
3605         member, adds a helper function for _test_patch, and refactors
3606         _test_patch to be more readable.
3607         (PatchAnalysisTask.__init__):
3608         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
3609         (PatchAnalysisTask._test_patch):
3610         (PatchAnalysisTask.results_from_test_run_without_patch):
3611         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3612         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
3613         (AbstractEarlyWarningSystem.begin_work_queue):
3614         (AbstractEarlyWarningSystem._failing_tests_message):
3615         (AbstractEarlyWarningSystem.command_failed):
3616         (AbstractEarlyWarningSystem.expected_failures): Deleted.
3617         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3618         Makes changes to accomodate the changes made to PatchAnalysisTask.
3619         (AbstractEarlyWarningSystemTe