d7d316a1bb7d564604009ca4928de1f8a524129c
[WebKit-https.git] / Tools / ChangeLog
1 2014-02-10  Filip Pizlo  <fpizlo@apple.com>
2
3         Make it possible to run tests with --llvmSimpleOpt=false
4         https://bugs.webkit.org/show_bug.cgi?id=128571
5
6         Reviewed by Mark Lam.
7         
8         This also makes it so all run functions for the FTL are safe to call with FTL disabled,
9         because they do their own $enableFTL check.
10
11         * Scripts/run-jsc-stress-tests:
12
13 2014-02-10  Gavin Barraclough  <barraclough@apple.com>
14
15         Remove WKPageSetVisibilityState
16         https://bugs.webkit.org/show_bug.cgi?id=128551
17
18         Reviewed by Anders Carlsson.
19
20         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
21         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
22         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
23             - visibilityState of offs-creen WKView is automatically prerender.
24         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
25         (WTR::InjectedBundle::setHidden):
26         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
27         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
28         (WTR::TestRunner::setPageVisibility):
29         (WTR::TestRunner::resetPageVisibility):
30         * WebKitTestRunner/TestController.cpp:
31         * WebKitTestRunner/TestController.h:
32         * WebKitTestRunner/TestInvocation.cpp:
33         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
34             - removed calls to WKPageSetVisibilityState.
35
36 2014-02-10  Carlos Garcia Campos  <cgarcia@igalia.com>
37
38         [GLIB] Add GUniqueOutPtr and use it instead of GOwnPtr
39         https://bugs.webkit.org/show_bug.cgi?id=127554
40
41         Reviewed by Gustavo Noronha Silva.
42
43         Use GUniqueOutPtr instead of GOwnPtr.
44
45         * DumpRenderTree/gtk/DumpRenderTree.cpp:
46         * DumpRenderTree/gtk/EventSender.cpp:
47         (createKeyPressEvent):
48         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
49         (TestWebKitAPI::returnOutChar):
50         (TestWebKitAPI::TEST):
51         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
52         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
53         (testInspectorServerPageList):
54         (openRemoteDebuggingSession):
55         (sendIncompleteRequest):
56         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
57         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
58         (testWebExtensionWindowObjectCleared):
59         (testWebExtensionIsolatedWorld):
60         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
61         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
62         (testWebViewRunJavaScript):
63         (testWebViewSave):
64         (testWebViewPageVisibility):
65         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
66         (isStyleSheetInjectedForURLAtPath):
67         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
68         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
69         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
70         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
71         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
72         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
73         (TestWebKitAPI::doKeyStroke):
74         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
75         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
76         (WebKitTestBus::run):
77         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
78         (resourceGetDataCallback):
79         (WebViewTest::keyStroke):
80         (onSnapshotReady):
81         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
82         (WTR::EventSenderProxy::keyDown):
83
84 2014-02-10  Carlos Garcia Campos  <cgarcia@igalia.com>
85
86         [GTK] Add API to create a webview related to another one
87         https://bugs.webkit.org/show_bug.cgi?id=128498
88
89         Reviewed by Gustavo Noronha Silva.
90
91         * MiniBrowser/gtk/BrowserWindow.c:
92         (webViewCreate): Use webkit_web_view_new_with_related_view() when
93         creating a new web view for window.open().
94         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
95         (testMultiprocessWebViewCreateReadyClose): Add test case to check
96         that window.open() works when creating the new WebView related to
97         the existing one, and that no new web process is spawned when
98         using webkit_web_view_new_with_related_view().
99         (beforeAll):
100
101 2014-02-10  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
102
103         If not running on Mac, build-webkit should not print Safari related output
104         https://bugs.webkit.org/show_bug.cgi?id=127169
105
106         Reviewed by Darin Adler.
107
108         * Scripts/build-webkit:
109         (writeCongrats):
110         * Scripts/webkitdirs.pm:
111         (isAppleWebKit):
112         (isAppleMacWebKit):
113         (isAppleWinWebKit):
114         (launcherName):
115
116 2014-02-10  Diego Pino Garcia  <dpino@igalia.com>
117
118         [GTK] Minibrowser: During text search, make navigation through list of matched words circular
119         https://bugs.webkit.org/show_bug.cgi?id=128463
120
121         Reviewed by Carlos Garcia Campos.
122
123         Initialize search options to WEBKIT_FIND_OPTIONS_WRAP_AROUND to make navigation
124         circular.
125
126         * MiniBrowser/gtk/BrowserSearchBar.c:
127         (doSearch):
128
129 2014-02-10  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
130
131         Code cleanup: Remove BUILDING_ON / TARGETING definitions.
132         https://bugs.webkit.org/show_bug.cgi?id=128242
133
134         Reviewed by Brent Fulgham.
135
136         The BUILDING_ON_* and TARGETING_* macros have not been used for a while.
137         According to the FIXME: they are removed.
138
139         * DumpRenderTree/config.h:
140
141 2014-02-10  Zan Dobersek  <zdobersek@igalia.com>
142
143         Fix a few mistakes that landed with r163749.
144
145         Rubber-stamped by Carlos Garcia Campos.
146
147         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
148         (WTR::EventSenderProxy::addTouchPoint): Avoid using the GUniquePtr<GdkEvent> after it's been moved
149         into the event vector since moving it invalidates the variable.
150
151 2014-02-09  Carlos Garnacho  <carlosg@gnome.org>
152
153         [GTK] Fix modifiers on EventSenderProxy::keyDown
154         https://bugs.webkit.org/show_bug.cgi?id=128496
155
156         Reviewed by Carlos Garcia Campos.
157
158         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
159         (WTR::EventSenderProxy::keyDown): do not attempt to doubly transform modifiers
160         into GTK+ ones.
161
162 2014-02-09  Carlos Garnacho  <carlosg@gnome.org>
163
164         [GTK] Enable touch features
165         https://bugs.webkit.org/show_bug.cgi?id=98931
166
167         Reviewed by Carlos Garcia Campos.
168
169         * WebKitTestRunner/EventSenderProxy.h:
170         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
171         (WTR::updateEventCoordinates):
172         (WTR::EventSenderProxy::createTouchEvent):
173         (WTR::EventSenderProxy::addTouchPoint):
174         (WTR::EventSenderProxy::updateTouchPoint):
175         (WTR::EventSenderProxy::sendUpdatedTouchEvents):
176         (WTR::EventSenderProxy::setTouchPointRadius):
177         (WTR::EventSenderProxy::setTouchModifier): Implement touch event proxying.
178
179 2014-02-08  Andreas Kling  <akling@apple.com>
180
181         Let Instruments time profiler run until tests finish.
182         <https://webkit.org/b/128488>
183
184         Pass "-T 0" to iprofiler to ensure that we get a time profile of the
185         entire performance test run instead of just the first 10 seconds.
186
187         Reviewed by Brady Eidson.
188
189         * Scripts/webkitpy/common/system/profiler.py:
190         (IProfiler.attach_to_pid):
191
192 2014-02-08  Rajaram Gaunker  <zimbabao@gmail.com>
193
194         [GTK] Add stdlib include file to fix ImageDiff build with libc++
195         https://bugs.webkit.org/show_bug.cgi?id=128454
196
197         Reviewed by Darin Adler.
198
199         * ImageDiff/gtk/ImageDiff.cpp:
200
201 2014-02-08  Diego Pino Garcia  <dpino@igalia.com>
202
203         [GTK] Minibrowser: Matched words of a searched text are not highlighted after reopening search bar
204         https://bugs.webkit.org/show_bug.cgi?id=128380
205
206         Reviewed by Carlos Garcia Campos.
207
208         When open the search bar, perform last search if there is any.
209
210         * MiniBrowser/gtk/BrowserSearchBar.c:
211         (browser_search_bar_open):
212
213 2014-02-08  Adrian Perez de Castro  <aperez@igalia.com>
214
215         [GTK] Make process model names properly meaningful
216         https://bugs.webkit.org/show_bug.cgi?id=128389
217
218         Reviewed by Carlos Garcia Campos.
219
220         The name WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
221         is misleading because there are situations in which web views may
222         share the same web process even when multi-process mode is enabled;
223         for example when opening a related view and both interact using JS.
224
225         * MiniBrowser/gtk/main.c:
226         (main):
227         Update usage of WebKitProcessModel enum values.
228         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
229         (beforeAll):
230         Ditto.
231
232 2014-02-08  Diego Pino Garcia  <dpino@igalia.com>
233
234         [GTK] build-webkit script always generate-gtk-doc even if '--disable-gtk-doc' param is passed
235         https://bugs.webkit.org/show_bug.cgi?id=128376
236
237         Reviewed by Carlos Garcia Campos.
238
239         * Scripts/webkitdirs.pm:
240         (buildAutotoolsProject):
241
242 2014-02-06  Filip Pizlo  <fpizlo@apple.com>
243
244         More FTL build scaffolding
245         https://bugs.webkit.org/show_bug.cgi?id=128330
246
247         Reviewed by Geoffrey Garen.
248
249         * Scripts/copy-webkitlibraries-to-product-directory:
250
251 2014-02-07  Tim Horton  <timothy_horton@apple.com>
252
253         Touch Minibrowser for a hopeful build fix.
254
255         * MiniBrowser/mac/WK2BrowserWindowController.m:
256
257 2014-02-07  Krzysztof Czech  <k.czech@samsung.com>
258
259         Build fix after r163632
260
261         Unreviewed EFL build fix
262
263         Added empty stub to WKTR to not break EFL build.
264
265         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
266         (WTR::AccessibilityUIElement::selectTextWithCriteria):
267
268 2014-02-07  Samuel White  <samuel_white@apple.com>
269
270         AX: Find and select text with respect to insertion point using accessibility API.
271         https://bugs.webkit.org/show_bug.cgi?id=128026
272
273         Reviewed by Chris Fleizach.
274
275         Added method to AccessibilityUIElement to enable testing of accessibility text selection.
276
277         * DumpRenderTree/AccessibilityUIElement.cpp:
278         (selectTextWithCriteriaCallback):
279         (AccessibilityUIElement::getJSClass):
280         * DumpRenderTree/AccessibilityUIElement.h:
281         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
282         (AccessibilityUIElement::selectTextWithCriteria):
283         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
284         (AccessibilityUIElement::selectTextWithCriteria):
285         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
286         (selectTextParameterizedAttributeForCriteria):
287         (AccessibilityUIElement::selectTextWithCriteria):
288         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
289         (AccessibilityUIElement::selectTextWithCriteria):
290         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
291         (WTR::AccessibilityUIElement::selectTextWithCriteria):
292         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
293         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
294         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
295         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
296         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
297         (WTR::AccessibilityUIElement::selectTextWithCriteria):
298         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
299         (WTR::selectTextParameterizedAttributeForCriteria):
300         (WTR::AccessibilityUIElement::selectTextWithCriteria):
301
302 2014-02-07  Manuel Rego Casasnovas  <rego@igalia.com>
303
304         [GTK] Disable gtk-doc in EWS
305         https://bugs.webkit.org/show_bug.cgi?id=128370
306
307         Reviewed by Carlos Garcia Campos.
308
309         Disable gtk-doc generation in EWS due to http://webkit.org/b/128369.
310
311         * Scripts/webkitpy/common/config/ports.py:
312         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
313         (GtkWK2Port.build_webkit_command): Ditto.
314         * Scripts/webkitpy/common/config/ports_unittest.py:
315         (DeprecatedPortTest.test_gtk_port): Ditto.
316         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
317
318 2014-02-07  Jinwoo Song  <jinwoo7.song@samsung.com>
319
320         [EFL][WK2] WebView should be able to configure to set fixed layout
321         https://bugs.webkit.org/show_bug.cgi?id=128300
322
323         Reviewed by Gyuyoung Kim.
324
325         * MiniBrowser/efl/main.c:
326         (window_create):
327         (elm_main): Add command argument option to use fixed layout.
328
329 2014-02-06  Ryosuke Niwa  <rniwa@webkit.org>
330
331         Fix DoYouEvenBench after r163429.
332
333         * Scripts/webkitpy/performance_tests/perftest.py:
334
335 2014-02-06  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
336
337         Add support for multiple sources for AutoInstaller
338         https://bugs.webkit.org/show_bug.cgi?id=124848
339
340         Reviewed by Ryosuke Niwa.
341
342         The autoinstaller in the webkitpy currently fails if the download source of a package is unavailable.
343         This patch adds support for multiple sources to the script. The sources are provided in three environment variables.
344         If it exists, the script will look at a local cache. If not, it will try to download the package from the original url.
345         If it fails, it gets a mirror from the corresponding environment variable.(One for sourceforge.org and one for pypi.python.org)
346
347         * Scripts/webkitpy/common/system/autoinstall.py:
348         (AutoInstaller._copy_unpackaged_files_from_local_cache):  If the package is not packaged in its original form,
349         this method will copy it to the scratch directory. Otherwise it would be deleted from the cache, which we do not want.
350         (AutoInstaller._prepare_package): If the package is not zipped or tarred, and the file is in the cache, the
351         _copy_unpackaged_files_from_local_cache function is called.
352         (AutoInstaller._parse_colon_separated_mirrors_from_env): This will read the mirrors from the environment variables if possible,
353         and prepares them for further use.
354         (AutoInstaller):
355         (AutoInstaller._replace_domain_with_next_mirror): If the original download url fails, it is replaced by a mirror provided
356         in the environment variables. The function identifies the original source, and replaces it with a mirror. If it can't be done,
357         the return url will be None, indicating that no mirrors are provided, or none of them could be reached.
358         (AutoInstaller._download_to_stream): The timeout for one try is now limited to 30 seconds. Without this, the script waited for
359         roughly 4 minutes before retrying. After three failiures the script will try to switch to a mirror.
360         (AutoInstaller._check_package_in_local_autoinstall_cache): This method searches the cache for the currently downloaded module.
361         If it's found there, its path is returned.
362         (AutoInstaller._download):  Before downloading the module, it is looked up in the cache. If it's not found there,
363         the script will continue with the download, and cache the module.
364
365 2014-02-06  Benjamin Poulain  <benjamin@webkit.org>
366
367         Remove run-test-webkit-api
368         https://bugs.webkit.org/show_bug.cgi?id=118145
369
370         Reviewed by Csaba Osztrogonác.
371
372         Having two scripts doing the same thing is confusing. There are also cases failing
373         on run-test-webkit-api since it does not restart a new process for each test.
374
375         * Scripts/run-test-webkit-api: Removed.
376         * Scripts/webkitdirs.pm:
377
378 2014-02-06  Commit Queue  <commit-queue@webkit.org>
379
380         Unreviewed, rolling out r163530.
381         http://trac.webkit.org/changeset/163530
382         https://bugs.webkit.org/show_bug.cgi?id=128311
383
384         It broke run-gtk-tests (Requested by Ossy on #webkit).
385
386         * efl/common.py: Copied from Tools/gtk/jhbuildrc.
387         (script_path):
388         (top_level_path):
389         * efl/jhbuildrc:
390         * gtk/common.py:
391         (script_path):
392         (top_level_path):
393         * gtk/find-make-dist-errors:
394         (get_missing_headers):
395         * gtk/generate-gtkdoc:
396         (get_webkit2_options):
397         (get_webkit1_options.src_path):
398         (get_webkit1_options):
399         (get_webkitdom_options.src_path):
400         (get_webkitdom_options):
401         * gtk/generate-inspector-gresource-manifest.py:
402         * gtk/jhbuildrc:
403         * jhbuild/jhbuildrc_common.py: Removed.
404         * nix/common.py: Copied from Tools/nix/jhbuildrc.
405         (script_path):
406         (top_level_path):
407         * nix/jhbuildrc:
408
409 2014-02-06  Denis Nomiyama  <d.nomiyama@samsung.com>
410
411         Unreviewed. Add myself as a committer.
412
413         * Scripts/webkitpy/common/config/contributors.json:
414
415 2014-02-06  Peter Szanka  <h868064@stud.u-szeged.hu>
416
417         Extract common parts from jhbuildrc files.
418         https://bugs.webkit.org/show_bug.cgi?id=125986
419
420         Reviewed by Csaba Osztrogonác.
421
422         * efl/common.py: Removed.
423         * efl/jhbuildrc:
424         * gtk/common.py:
425         (binary_build_path):
426         * gtk/find-make-dist-errors:
427         (get_missing_headers):
428         * gtk/generate-gtkdoc:
429         (get_webkit2_options):
430         (get_webkit1_options.src_path):
431         (get_webkit1_options):
432         (get_webkitdom_options.src_path):
433         (get_webkitdom_options):
434         * gtk/generate-inspector-gresource-manifest.py:
435         * gtk/jhbuildrc:
436         * jhbuild/jhbuildrc_common.py: Added.
437         (script_path):
438         (top_level_path):
439         (init):
440         * nix/common.py: Removed.
441         * nix/jhbuildrc:
442
443 2014-02-06  Csaba Osztrogonác  <ossy@webkit.org>
444
445         Unreviewed fix after r163520, remove Andrei from committers list, because
446         he is reviewer now, and webkit-patch doesn't like duplicated entries.
447
448         * Scripts/webkitpy/common/config/contributors.json:
449
450 2014-02-06  Andrei Bucur  <abucur@adobe.com>
451
452         Adding myself as a reviewer.
453
454         Unreviewed.
455
456         * Scripts/webkitpy/common/config/contributors.json:
457
458 2014-02-05  Zan Dobersek  <zdobersek@igalia.com>
459
460         Remove the WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS macro
461         https://bugs.webkit.org/show_bug.cgi?id=128267
462
463         Reviewed by Andreas Kling.
464
465         Remove the COMPILER_SUPPORTS(CXX_GENERALIZED_INITIALIZERS) as the underlying macro is also
466         being removed since the feature is supported by all the compilers the project approves.
467
468         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
469         (TestWebKitAPI::TEST):
470         * TestWebKitAPI/Tests/WTF/Vector.cpp:
471         (TestWebKitAPI::TEST):
472
473 2014-02-05  Jinwoo Song  <jinwoo7.song@samsung.com>
474
475         [EFL][WK2] Remove legacy behavior mode in MiniBrowser
476         https://bugs.webkit.org/show_bug.cgi?id=128298
477
478         Reviewed by Gyuyoung Kim.
479
480         MiniBrowser is crashing when the legacy mode is set in creating webview.
481         As EFL application cannot use this API for creating webview after r146265,
482         it would be better to remove this invalid option.
483
484         * MiniBrowser/efl/main.c:
485         (window_create): Do not create webview with WKViewCreate API.
486         (elm_main): Remove 'legacy' option.
487
488 2014-02-05  Andreas Kling  <akling@apple.com>
489
490         Remove ENABLE(DIRECTORY_UPLOAD).
491         <https://webkit.org/b/128275>
492
493         Rubber-stamped by Ryosuke Niwa.
494
495         * Scripts/webkitperl/FeatureList.pm:
496
497 2014-02-05  Filip Pizlo  <fpizlo@apple.com>
498
499         Rename useExperimentalFTL to useFTLJIT.
500
501         Rubber stamped by Mark Hahnenberg.
502
503         * Scripts/run-jsc-stress-tests:
504
505 2014-02-05  Filip Pizlo  <fpizlo@apple.com>
506
507         JSC on Mac should pull LLVM from prefix=/usr/local/LLVMForJavaScriptCore and not /usr/local
508         https://bugs.webkit.org/show_bug.cgi?id=128269
509
510         Reviewed by Mark Hahnenberg.
511
512         * Scripts/copy-webkitlibraries-to-product-directory:
513
514 2014-02-05  Manuel Rego Casasnovas  <rego@igalia.com>
515
516         Create CSS Grid Layout watchlist
517         https://bugs.webkit.org/show_bug.cgi?id=128241
518
519         Reviewed by Andreas Kling.
520
521         Add Sergio Villar, Javier Fernandez and myself to it.
522
523         Add Javier Fernandez as contributor.
524
525         * Scripts/webkitpy/common/config/contributors.json:
526         * Scripts/webkitpy/common/config/watchlist:
527
528 2014-02-05  Alexey Proskuryakov  <ap@apple.com>
529
530         Copying failing test paths from build.webkit.org/dashboard popovers also copies non-selectable links
531         https://bugs.webkit.org/show_bug.cgi?id=128236
532
533         Reviewed by Timothy Hatcher.
534
535         Work around bug 80159 - copying should always respect user-select:none, but it doesn't yet.
536
537         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
538         When copying, temporarily make non-selectable parts invisible, and put text of
539         the selection onto pasteboard. Since we immediately make everything visible again,
540         there is even no blinking.
541
542 2014-02-05  Nick Diego Yamane  <nick.yamane@openbossa.org>
543
544         Unreviewed. Add myself to contributors.json
545
546         * Scripts/webkitpy/common/config/contributors.json:
547
548 2014-02-05  Sergio Correia  <sergio.correia@openbossa.org>
549
550         Unreviewed. Add myself to contributor and watch lists
551
552         * Scripts/webkitpy/common/config/contributors.json:
553         * Scripts/webkitpy/common/config/watchlist:
554
555 2014-02-05  Alberto Garcia  <berto@igalia.com>
556
557         Unreviewed. Add myself to some watchlists.
558
559         * Scripts/webkitpy/common/config/watchlist:
560
561 2014-02-05  Gabor Rapcsanyi  <rgabor@webkit.org>
562
563         Fix WaitForSVNServer build step after r163372.
564
565         Rubber-stamped by Csaba Osztrogonác.
566
567         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
568         (WaitForSVNServer.evaluateCommand): add missing return SUCCESS
569
570 2014-02-05  Csaba Osztrogonác  <ossy@webkit.org>
571
572         Remove ENABLE(SVG) guards
573         https://bugs.webkit.org/show_bug.cgi?id=127991
574
575         Reviewed by Sam Weinig.
576
577         * Scripts/webkitperl/FeatureList.pm:
578         * TestWebKitAPI/GNUmakefile.am:
579
580 2014-02-04  Andreas Kling  <akling@apple.com>
581
582         Remove <iframe seamless> support.
583         <https://webkit.org/b/128213>
584
585         Rubber-stamped by Antti Koivisto.
586
587         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
588         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
589         * DumpRenderTree/gtk/DumpRenderTree.cpp:
590         (resetDefaultsToConsistentValues):
591         * DumpRenderTree/mac/DumpRenderTree.mm:
592         (resetWebPreferencesToConsistentValues):
593         * DumpRenderTree/win/DumpRenderTree.cpp:
594         (resetDefaultsToConsistentValues):
595         * Scripts/webkitperl/FeatureList.pm:
596         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
597         (WTR::InjectedBundle::beginTesting):
598
599 2014-02-04  Filip Pizlo  <fpizlo@apple.com>
600
601         Fix build when the script is called from Xcode.
602
603         * Scripts/copy-webkitlibraries-to-product-directory:
604
605 2014-02-04  Filip Pizlo  <fpizlo@apple.com>
606
607         DFG PutByVal on typed arrays should detect OutOfBounds sooner
608         https://bugs.webkit.org/show_bug.cgi?id=128162
609
610         Reviewed by Mark Hahnenberg.
611         
612         Add a defautNoEagerRun, which is intended to be used for convergence tests.
613
614         * Scripts/run-jsc-stress-tests:
615
616 2014-02-04  Filip Pizlo  <fpizlo@apple.com>
617
618         export-llvm-build should work with git checkouts
619         https://bugs.webkit.org/show_bug.cgi?id=128217
620
621         Reviewed by Mark Hahnenberg.
622         
623         If svn export fails, just do ditto.
624
625         * Scripts/export-llvm-build:
626
627 2014-02-04  Carlos Garnacho  <carlosg@gnome.org>
628
629         [Automake] Add missing $(feature_defines) when generating InjectedBundle bindings
630         https://bugs.webkit.org/show_bug.cgi?id=128170
631
632         Reviewed by Carlos Garcia Campos.
633
634         * WebKitTestRunner/GNUmakefile.am: Add missing $(feature_defines) when
635         generating the InjectedBundle bindings. So the various ENABLE_* defines
636         are available there.
637
638 2014-02-04  Carlos Garnacho  <carlosg@gnome.org>
639
640         [GTK] Ensure generated events have given modifiers GDK understands
641         https://bugs.webkit.org/show_bug.cgi?id=128171
642
643         Reviewed by Carlos Garcia Campos.
644
645         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
646         (WTR::webkitModifiersToGDKModifiers): Move around
647         (WTR::EventSenderProxy::createMouseButtonEvent):
648         (WTR::EventSenderProxy::keyDown): Use webkitModifiersToGDKModifiers to
649         translate WKEventModifiers.
650
651 2014-02-04  Gabor Rapcsanyi  <rgabor@webkit.org>
652
653         Fine tuning the ARM EFL bots
654         https://bugs.webkit.org/show_bug.cgi?id=128168
655
656         Reviewed by Csaba Osztrogonác.
657
658         * BuildSlaveSupport/build.webkit.org-config/config.json: Add custom SVN mirror.
659         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
660         (WaitForSVNServer): Make it not to halt before the first repository checkout.
661         (WaitForSVNServer.evaluateCommand):
662         (Factory.__init__): Disable kill-old-processes step on EFL ARM bots, because these
663         bots run on the same machine and they kill the processes of each other.
664
665 2014-02-03  Ryosuke Niwa  <rniwa@webkit.org>
666
667         kill-old-processes doesn't kill plugin processes
668         https://bugs.webkit.org/show_bug.cgi?id=128138
669
670         Reviewed by Andreas Kling.
671
672         Add plugin process names to the list of processes to kill.
673
674         * BuildSlaveSupport/kill-old-processes:
675         (main):
676
677 2014-02-03  Dean Jackson  <dino@apple.com>
678
679         Feature flag for shape-inside
680         https://bugs.webkit.org/show_bug.cgi?id=128001
681
682         Reviewed by Simon Fraser.
683
684         Add CSS_SHAPE_INSIDE flag, and -css-shape-inside build
685         flag.
686
687         * Scripts/webkitperl/FeatureList.pm:
688
689 2014-02-03  Zoltan Horvath  <zoltan@webkit.org>
690
691         Unreviewed. Reorder my e-mail addresses in contributors.json,
692         so bugzilla will auto complete my actual bugzilla username.
693
694         * Scripts/webkitpy/common/config/contributors.json:
695
696 2014-02-03  Daniel Bates  <dabates@apple.com>
697
698         WebKit Bot Watcher's Dashboard: Defer subsequent resource loads from access-restricted build bot when
699         iteration fails to load with HTTP 401 status code
700         https://bugs.webkit.org/show_bug.cgi?id=128077
701
702         Reviewed by Alexey Proskuryakov.
703
704         Similar to the fix for <https://bugs.webkit.org/show_bug.cgi?id=127849>, we should only prompt for
705         the HTTP credentials of a build bot so long as an earlier authentication request wasn't cancelled
706         (i.e. failed with an HTTP 401 Unauthorized status code). Currently an authentication dialog will be
707         presented for an iteration each time the update queue timer fires until a person successfully
708         authenticates. Instead we should update the authentication status of the build bot on receiving an
709         HTTP 401 response code such that we defer subsequent requests to load any resource from the access-
710         restricted build bot when the queue update timer fires.
711
712         A person must explicitly click the "unauthorized" status line shown for the queue associated with the
713         iteration in the dashboard and authenticate successfully for the iteration to be loaded once an
714         authentication request for an iteration is cancelled.
715
716         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
717         (BuildbotIteration.prototype.update): Early return if the associated Buildbot was given invalid credentials.
718         Also notify the associated Buildbot and update the queue view when a load failed with an HTTP 401 status code.
719         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
720         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
721         (BuildbotQueueView): Modified to call BuildbotQueueView.prototype._unauthorizedAccess instead of
722         QueueView.prototype._updateSoon when event BuildbotQueue.Event.UnauthorizedAccess is received.
723         (BuildbotQueueView.prototype._unauthorizedAccess): Added.
724
725 2014-02-03  Daniel Bates  <dabates@apple.com>
726
727         WebKit Bot Watcher's Dashboard: Teach JSON.load() to interpret third argument as either an
728         option dictionary or a failure callback
729         https://bugs.webkit.org/show_bug.cgi?id=128080
730
731         Reviewed by Alexey Proskuryakov.
732
733         Currently JSON.load() takes a failure callback function as its third argument and
734         an option dictionary as its fourth argument. So, a caller that wants to ignore errors
735         and pass an option dictionary must pass null or a reference to an empty function for
736         the value of third argument. Instead, we should make the third argument polymorphic for
737         convenience. Then a caller can either pass a failure callback function or an option dictionary.
738
739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
740
741 2014-02-03  Krzysztof Czech  <k.czech@samsung.com>
742
743         [ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR
744         https://bugs.webkit.org/show_bug.cgi?id=127908
745
746         Reviewed by Chris Fleizach.
747
748         Updated AccessibilityUIElement both in WKTR and DRT so that aria-controls support could be tested properly.
749         Added empty stubs to not break mac builds.
750
751         * DumpRenderTree/AccessibilityUIElement.cpp:
752         (ariaControlsElementAtIndexCallback):
753         (AccessibilityUIElement::getJSClass):
754         * DumpRenderTree/AccessibilityUIElement.h:
755         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
756         (accessibilityElementAtIndex):
757         (AccessibilityUIElement::disclosedRowAtIndex):
758         (AccessibilityUIElement::ariaOwnsElementAtIndex):
759         (AccessibilityUIElement::ariaFlowToElementAtIndex):
760         (AccessibilityUIElement::ariaControlsElementAtIndex):
761         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
762         (AccessibilityUIElement::ariaControlsElementAtIndex):
763         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
764         (AccessibilityUIElement::ariaControlsElementAtIndex):
765         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
766         (AccessibilityUIElement::ariaControlsElementAtIndex):
767         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
768         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
769         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
770         (WTR::accessibilityElementAtIndex):
771         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
772         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
773         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
774         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
775         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
776         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
777         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
778         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
779
780 2014-02-02  Daniel Bates  <dabates@apple.com>
781
782         WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
783         https://bugs.webkit.org/show_bug.cgi?id=127849
784
785         I inadvertently used the equality operator instead of the identity operator when comparing the
786         value of the error HTTP status code with the numeric literal 401.
787
788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
789         (BuildbotQueue.prototype.update):
790
791 2014-02-02  Daniel Bates  <dabates@apple.com>
792
793         Attempt to fix production dashboard after <http://trac.webkit.org/changeset/163222>
794
795         Actually pass option dictionary to JSON.load(); JSON.load() takes four arguments with the
796         last-most argument being the option dictionary.
797
798         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
799         (BuildbotIteration.prototype.update):
800
801 2014-02-01  Filip Pizlo  <fpizlo@apple.com>
802
803         JSC profiler's stub info profiling support should work again
804         https://bugs.webkit.org/show_bug.cgi?id=128057
805
806         Reviewed by Mark Lam.
807
808         * Scripts/display-profiler-output: Just make sure that there's always a space between the origin stack dump and the top bytecode index.
809
810 2014-02-01  Filip Pizlo  <fpizlo@apple.com>
811
812         JSC profiler should show reasons for jettison
813         https://bugs.webkit.org/show_bug.cgi?id=128047
814
815         Reviewed by Geoffrey Garen.
816         
817         Gave the tool a "log" command, that tells you all of the interesting things
818         that happened to a piece of bytecode, from the standpoint of optimization.
819         It's a great summary view for seeing how our tier-up machinery works.
820         
821         This uses a lot of information that was already available, plus the newly
822         added jettisonReason field.
823
824         * Scripts/display-profiler-output:
825
826 2014-01-31  Ryosuke Niwa  <rniwa@webkit.org>
827
828         Remove inline member functions of FrameSelection that access m_selection
829         https://bugs.webkit.org/show_bug.cgi?id=127986
830
831         Reviewed by Enrica Casucci.
832
833         * TestWebKitAPI/Configurations/Base.xcconfig:
834
835 2014-01-31  Anders Carlsson  <andersca@apple.com>
836
837         Another attempt at fixing the build.
838
839         * TestWebKitAPI/Configurations/Base.xcconfig:
840
841 2014-01-31  Oliver Hunt  <oliver@apple.com>
842
843         Rollout r163195 and related patches
844
845         * DumpRenderTree/CMakeLists.txt:
846         * WebKitTestRunner/CMakeLists.txt:
847         * WinCELauncher/CMakeLists.txt:
848
849 2014-01-31  Daniel Bates  <dabates@apple.com>
850
851         Attempt to fix Production Dashboard after <http://trac.webkit.org/changeset/163213>
852         (https://bugs.webkit.org/show_bug.cgi?id=127849)
853
854         Reviewed by David Farler.
855
856         Pass credentials when querying build bot iteration. 
857
858         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
859         (BuildbotIteration.prototype.update):
860         (BuildbotIteration.prototype.loadLayoutTestResults):
861
862 2014-01-31  Anders Carlsson  <andersca@apple.com>
863
864         Fix iOS build.
865
866         * TestWebKitAPI/Configurations/Base.xcconfig:
867
868 2014-01-31  Simon Fraser  <simon.fraser@apple.com>
869
870         WebKitTestRunner project doesn't show Mac as a valid destination architecture.
871         
872         Make sure that SUPPORTED_PLATFORMS is defined in Base.xcconfig.
873         
874         Also add BaseTarget.xcconfig to the project.
875
876         * WebKitTestRunner/Configurations/Base.xcconfig:
877         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
878
879 2014-01-31  Daniel Bates  <dabates@apple.com>
880
881         WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
882         https://bugs.webkit.org/show_bug.cgi?id=127849
883
884         Reviewed by Alexey Proskuryakov.
885
886         Currently whenever the dashboard updates the status of a queue whose Buildbot requires authentication
887         it will cause a browser to prompt for credentials once per update until valid credentials are provided.
888         Instead we should keep track of Buildbots that respond with an HTTP 401 Unauthorized status code to avoid
889         subsequently querying them and hence cause a browser to prompt for credentials. Together with an optional
890         hint provided when instantiating a Buildbot object as to whether it requires authentication, we can make
891         the dashboard prompt for HTTP credentials exactly once per page load for each queue whose associated
892         Buildbot requires authentication.
893
894         Queues whose Buildbot wasn't authenticated will show in the dashboard as "unauthorized". Clicking on
895         this status message will cause the browser to prompt for credentials.
896
897         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
898         (Buildbot): Initialize instance variable authenticationStatus to Buildbot.AuthenticationStatus.Unauthenticated.
899         (Buildbot.prototype.get needsAuthentication): Added.
900         (Buildbot.prototype.get authenticationStatus): Added.
901         (Buildbot.prototype.get isAuthenticated): Added.
902         (Buildbot.prototype.set isAuthenticated): Added.
903         (Buildbot.prototype.updateQueues): Added.
904         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
905         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Modified to call
906         BuildbotQueueView.prototype._appendUnauthorizedLineView() to update the view and show status of the queue as
907         "unauthorized" if the Buildbot associated with the queue is either unauthenticated or was given invalid credentials.
908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
909         (BuildbotQueue.prototype.update): Return immediately if the associated Buildbot requires authentication.
910         Additionally, if the JSON load fails with an HTTP 401 Unauthorized access error (say, credentials were
911         invalidated) then update the authentication status of the Buildbot to avoid subsequently prompting a
912         person for credentials the next time the queue update timer fires.
913         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
914         (BuildbotQueueView): Register as a listener for event BuildbotQueue.Event.UnauthorizedAccess on each queue
915         so that the view can be updated to show status "unauthorized".
916         (BuildbotQueueView.prototype._appendUnauthorizedLineView): Added.
917         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
918         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added new status, StatusLineView.Status.Unauthorized.
920         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
921         (.status-line.unauthorized .bubble): Added.
922         (.status-line.unauthorized .bubble.pictogram): Added.
923         (.status-line.unauthorized .message): Added.
924
925 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
926
927         Unreviewed, really make --copy-libraries a no-able option.
928         
929         * Scripts/build-jsc:
930
931 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
932
933         Unreviewed, really add the --copy-libraries option.
934
935         * Scripts/build-jsc:
936
937 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
938
939         Unreviewed, fix the script for older Rubies.
940
941         * Scripts/export-llvm-build:
942
943 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
944
945         Having a custom LLVM checkout should always override all other ways of getting LLVM
946         https://bugs.webkit.org/show_bug.cgi?id=128015
947
948         Reviewed by Oliver Hunt.
949
950         * Scripts/copy-webkitlibraries-to-product-directory:
951
952 2014-01-31  Daniel Bates  <dabates@apple.com>
953
954         WebKit Bot Watcher's Dashboard: Teach JSON.load() to take optional failure callback function
955         https://bugs.webkit.org/show_bug.cgi?id=127924
956
957         Reviewed by Alexey Proskuryakov.
958
959         Towards providing better error handling when a JSON load fails with a non-200 HTTP status
960         code, we should teach JSON.load() to take an optional failure callback function and invoke
961         it when either a load error or a JSON parsing error occurs.
962
963         As a side benefit of having a failure callback function a caller can separate the error handling
964         logic for a JSON load or parse error from the logic of handling a successful parsing of JSON content.
965
966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
967         (BuildbotIteration.prototype.loadLayoutTestResults): Move JSON parser error logic into failure
968         callback function.
969         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
970         (JSON.load): Modified to take optional failure callback function called failureCallback.
971
972 2014-01-29  Oliver Hunt  <oliver@apple.com>
973
974         Make it possible to implement JS builtins in JS
975         https://bugs.webkit.org/show_bug.cgi?id=127887
976
977         Reviewed by Michael Saboff.
978
979         CMake updates
980
981         * DumpRenderTree/CMakeLists.txt:
982         * WebKitTestRunner/CMakeLists.txt:
983         * WinCELauncher/CMakeLists.txt:
984
985 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
986
987         Allow more flexibility for copy-webkitlibraries-to-product-directory
988         https://bugs.webkit.org/show_bug.cgi?id=128010
989
990         Reviewed by Oliver Hunt.
991         
992         It's now the case that copy-webkitlibraries-to-product-directory does nothing by
993         default, but you can tell it to either copy WebKitSystemInterface (--wksi) or LLVM
994         (--llvm). You can also tell it where to get LLVM from.
995
996         * Scripts/build-jsc:
997         * Scripts/build-webkit:
998         * Scripts/copy-webkitlibraries-to-product-directory:
999
1000 2014-01-31  David Farler  <dfarler@apple.com>
1001
1002         DumpRenderTree iOS fails to link: missing rowHeaders and columnHeaders in AccessibilityUIElement
1003         https://bugs.webkit.org/show_bug.cgi?id=128004
1004
1005         Reviewed by Chris Fleizach.
1006
1007         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1008         (AccessibilityUIElement::columnHeaders): Stub added.
1009         (AccessibilityUIElement::rowHeaders): Stub added.
1010
1011 2014-01-31  Zoltan Horvath  <zoltan@webkit.org>
1012
1013         Unreviewed. Update my contributors.json entry.
1014
1015         * Scripts/webkitpy/common/config/contributors.json:
1016
1017 2014-01-31  Anders Carlsson  <andersca@apple.com>
1018
1019         REGRESSION: WebKit2.PageLoadBasic API test is failing
1020         https://bugs.webkit.org/show_bug.cgi?id=127892
1021
1022         Reviewed by Dan Bernstein.
1023
1024         Re-enable test.
1025
1026         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1027
1028 2014-01-31  Csaba Osztrogonác  <ossy@webkit.org>
1029
1030         [jhbuild] Disable escape sequences in EWS output
1031         https://bugs.webkit.org/show_bug.cgi?id=127922
1032
1033         Reviewed by Alexey Proskuryakov.
1034
1035         * Scripts/webkitpy/common/system/environment.py:
1036         (Environment.disable_gcc_smartquotes):
1037         (Environment):
1038         (Environment.disable_jhbuild_VT100_output):
1039         * Scripts/webkitpy/tool/commands/download_unittest.py:
1040         * Scripts/webkitpy/tool/steps/build.py:
1041         (Build.build):
1042
1043 2014-01-30  Martin Robinson  <mrobinson@igalia.com>
1044
1045         [GTK] [CMake] Add support for building against GTK+ 2
1046         https://bugs.webkit.org/show_bug.cgi?id=127959
1047
1048         Reviewed by Anders Carlsson.
1049
1050         * DumpRenderTree/PlatformGTK.cmake: Use the new API version variable and don't use GTK3 directly.
1051         * GtkLauncher/CMakeLists.txt: Ditto.
1052         * ImageDiff/PlatformGTK.cmake: Ditto.
1053         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Ditto.
1054
1055 2014-01-30  Anders Carlsson  <andersca@apple.com>
1056
1057         Add webView:didFinishLoadingNavigation: delegate method
1058         https://bugs.webkit.org/show_bug.cgi?id=127976
1059
1060         Reviewed by Dan Bernstein.
1061
1062         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1063         (-[NavigationDelegate webView:didCommitNavigation:]):
1064         (-[NavigationDelegate webView:didFinishLoadingNavigation:]):
1065
1066 2014-01-30  Anders Carlsson  <andersca@apple.com>
1067
1068         Add a webView:didCommitNavigation: delegate method
1069         https://bugs.webkit.org/show_bug.cgi?id=127972
1070
1071         Reviewed by Dan Bernstein.
1072
1073         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1074         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
1075         (-[NavigationDelegate webView:didCommitNavigation:]):
1076
1077 2014-01-30  Anders Carlsson  <andersca@apple.com>
1078
1079         Add a webView:didFailProvisionalNavigation:withError: delegate method
1080         https://bugs.webkit.org/show_bug.cgi?id=127968
1081
1082         Reviewed by Dan Bernstein.
1083
1084         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1085         (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
1086         (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1087         (TEST):
1088
1089 2014-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1090
1091         The test server build fixes.
1092
1093         * TestResultServer/model/jsonresults.py:
1094         (JsonResults.merge):
1095         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1096
1097 2014-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1098
1099         NRWT shouldn't say "Finished writing JSON files" if it failed to to so
1100         https://bugs.webkit.org/show_bug.cgi?id=127966
1101
1102         Reviewed by Alexey Proskuryakov.
1103
1104         Don't say "Finished writing JSON files" if we had failed to generate the JSON file.
1105         Also explicitly say this is for test results server as we're generating two JSON files.
1106
1107         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1108         (Manager._upload_json_files):
1109         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1110         (JSONLayoutResultsGenerator.__init__): Don't generate JSON file implicitly inside the constructor.
1111         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1112         (JSONResultsGenerator.generate_json_output): Return a boolean indicating whether the generation
1113         had succeeded or not.
1114
1115 2014-01-30  Filip Pizlo  <fpizlo@apple.com>
1116
1117         copy-webkitlibraries-to-product-directory should accept command-line arguments for extra work required for optional features rather than relying on environment variables
1118         https://bugs.webkit.org/show_bug.cgi?id=120221
1119
1120         Reviewed by Mark Hahnenberg.
1121
1122         * Scripts/build-jsc:
1123         * Scripts/build-webkit:
1124         * Scripts/copy-webkitlibraries-to-product-directory:
1125
1126 2014-01-30  Anders Carlsson  <andersca@apple.com>
1127
1128         Add a webView:didStartProvisionalNavigation: delegate method
1129         https://bugs.webkit.org/show_bug.cgi?id=127965
1130
1131         Reviewed by Dan Bernstein.
1132
1133         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1134         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
1135         (TEST):
1136
1137 2014-01-30  Chris Fleizach  <cfleizach@apple.com>
1138
1139         WebKitTestRunner fails to link - missing rowHeaders and columnHeaders
1140         https://bugs.webkit.org/show_bug.cgi?id=127917
1141
1142         Reviewed by Andy Estes.
1143
1144         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1145         (WTR::AccessibilityUIElement::rowHeaders):
1146         (WTR::AccessibilityUIElement::columnHeaders):
1147
1148 2014-01-30  Martin Robinson  <mrobinson@igalia.com>
1149
1150         [GTK] [CMake] Add a "make dist" target
1151         https://bugs.webkit.org/show_bug.cgi?id=116378
1152
1153         Reviewed by Gustavo Noronha Silva.
1154
1155         Added a script that reads a manifest file an produces a tarball. Also add
1156         the manifest.
1157
1158         * gtk/make-dist.py: Added.
1159         * gtk/manifest.txt: Added.
1160
1161 2014-01-30  David Farler  <dfarler@apple.com>
1162
1163         Move OTHER_LDFLAGS erasure to DumpRenderTreeLibrary.xcconfig.
1164         https://bugs.webkit.org/show_bug.cgi?id=127935
1165
1166         Reviewed by Andy Estes.
1167
1168         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1169         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
1170         Move OTHER_LDFLAGS erasure to the static library's xcconfig.
1171
1172 2014-01-30  David Farler  <dfarler@apple.com>
1173
1174         DumpRenderTree fails to build with ASAN: -fsanitize=address passed to static DRT target
1175         https://bugs.webkit.org/show_bug.cgi?id=127935
1176
1177         Reviewed by Andy Estes.
1178
1179         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1180         Clear OTHER_LDFLAGS at the project level for the static library target.
1181         No other linker flags were inherited from DebugRelease.
1182
1183 2014-01-30  David Farler  <dfarler@apple.com>
1184
1185         package-root shouldn't prefix simulator roots with the SDK path
1186         http://bugs.webkit.org/show_bug.cgi?id=127923
1187
1188         Reviewed by Dan Bernstein.
1189
1190         * Scripts/package-root: Don't add an install path prefix.
1191
1192 2014-01-30  Gabor Rapcsanyi  <rgabor@webkit.org>
1193
1194         Add ARM EFL Linux builder bots to Apple buildmaster
1195         https://bugs.webkit.org/show_bug.cgi?id=127472
1196
1197         Reviewed by Csaba Osztrogonác.
1198
1199         There is no ARM buildslaves after removing the Qt builders.
1200
1201         * BuildSlaveSupport/build.webkit.org-config/config.json:
1202
1203 2014-01-30  Andy Estes  <aestes@apple.com>
1204
1205         REGRESSION (r163037): WebKit2.PageLoadBasic API test failing on Mountain Lion
1206         https://bugs.webkit.org/show_bug.cgi?id=127934
1207
1208         Disable the failing test on Mountain Lion.
1209
1210         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1211         (TestWebKitAPI::TEST):
1212
1213 2014-01-30  Anders Carlsson  <andersca@apple.com>
1214
1215         Add WKNavigationDelegate class
1216         https://bugs.webkit.org/show_bug.cgi?id=127927
1217
1218         Reviewed by Dan Bernstein.
1219
1220         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1221         (TEST):
1222
1223 2014-01-30  David Farler  <dfarler@apple.com>
1224
1225         Enable iOS Tools builds by default
1226         https://bugs.webkit.org/show_bug.cgi?id=127919
1227
1228         Reviewed by Andy Estes.
1229
1230         * Makefile:
1231         Build all the tools except MiniBrowser on iOS
1232         * Scripts/build-webkit:
1233         Ditto.
1234         Build WebKitTestRunnerApp target on iOS.
1235
1236 2014-01-30  David Farler  <dfarler@apple.com>
1237
1238         Make TestWebKitAPI build and run for iOS
1239         https://bugs.webkit.org/show_bug.cgi?id=127925
1240
1241         Reviewed by Andy Estes.
1242
1243         * TestWebKitAPI/Configurations/Base.xcconfig:
1244         - Don't warn on 64-32 bit conversion on x86_64 and arm64
1245         - Don't build mac/*
1246         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1247         - Link WebKit2 on all platforms
1248
1249 2014-01-30  David Farler  <dfarler@apple.com>
1250
1251         package-root should copy ./usr from the build products directory
1252         https://bugs.webkit.org/show_bug.cgi?id=127878
1253
1254         Reviewed by Daniel Bates.
1255
1256         * Scripts/package-root:
1257         Copy ./usr in addition to the frameworks.
1258
1259 2014-01-30  Andrei Bucur  <abucur@adobe.com>
1260
1261         Remove the ACCELERATED_COMPOSITING flag
1262         https://bugs.webkit.org/show_bug.cgi?id=127833
1263
1264         Reviewed by Antti Koivisto.
1265
1266         Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
1267         mandatory.
1268
1269         * DumpRenderTree/efl/DumpRenderTree.cpp:
1270         (initEcoreEvas):
1271         * EWebLauncher/main.c:
1272         (windowCreate):
1273         * MiniBrowser/efl/main.c:
1274         (elm_main):
1275         * TestWebKitAPI/efl/PlatformWebView.cpp:
1276         (TestWebKitAPI::initEcoreEvas):
1277         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1278         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1279         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1280         (WTR::initEcoreEvas):
1281
1282 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1283
1284         Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
1285         https://bugs.webkit.org/show_bug.cgi?id=127845
1286
1287         Reviewed by Joseph Pecoraro.
1288
1289         * Scripts/webkitperl/FeatureList.pm:
1290
1291 2014-01-29  Anders Carlsson  <andersca@apple.com>
1292
1293         -[WKWebView loadRequest:] should return a WKNavigation
1294         https://bugs.webkit.org/show_bug.cgi?id=127873
1295
1296         Reviewed by Dan Bernstein.
1297
1298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1299         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: Added.
1300         (TEST):
1301
1302 2014-01-29  Tim Horton  <timothy_horton@apple.com>
1303
1304         WebKit2 View Gestures (Swipe): Update rubberBandsAt{Left,Right} when WebKit swipe is enabled
1305         https://bugs.webkit.org/show_bug.cgi?id=127855
1306         <rdar://problem/15933878>
1307
1308         Reviewed by Anders Carlsson.
1309
1310         * MiniBrowser/mac/WK2BrowserWindowController.m:
1311         (-[WK2BrowserWindowController awakeFromNib]):
1312         Enable swipe in MiniBrowser for testing purposes.
1313
1314 2014-01-29  Daniel Bates  <dabates@apple.com>
1315
1316         Fix JSONP requests made by the WebKit Bot Watcher's Dashboard following <http://trac.webkit.org/changeset/163034>
1317         (https://bugs.webkit.org/show_bug.cgi?id=127784)
1318
1319         Use dot-notation instead of array index notation to access the dictionary value for key jsonpCallbackName
1320         in the specified options dictionary.
1321
1322         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1323         (JSON.load):
1324
1325 2014-01-29  Daniel Bates  <dabates@apple.com>
1326
1327         WebKit Bot Watcher's Dashboard: Add support for using HTTP authentication with Buildbot
1328         https://bugs.webkit.org/show_bug.cgi?id=127784
1329
1330         Reviewed by Alexey Proskuryakov.
1331
1332         Implement support for querying a Buildbot that requires HTTP authentication to access it.
1333
1334         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1335         (Buildbot): Add optional argument, options, to pass a dictionary of Buildbot options.
1336         For now, we only support a single option, needsAuthentication, to indicate whether the
1337         Buildbots requires HTTP authentication (defaults to false - HTTP authentication is
1338         not required).
1339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1340         (BuildbotIteration.prototype.loadLayoutTestResults): Modified to pass JSONP callback name
1341         to JSON.load() using the option dictionary.
1342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1343         (BuildbotQueue.prototype.update): Modified to pass withCredentials to JSON.load().
1344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1345         (JSON.load): Removed optional argument jsonpCallbackName and added optional argument options,
1346         which is a dictionary. The argument jsonpCallbackName is now specified as an entry in the
1347         options dictionary. Added boolean options withCredentials to toggle querying with HTTP
1348         authentication credentials.
1349
1350 2014-01-29  Alexey Proskuryakov  <ap@apple.com>
1351
1352         build.webkit.org/dashboard links to an old failing build rather than the most recent
1353         https://bugs.webkit.org/show_bug.cgi?id=127765
1354         <rdar://problem/15795228>
1355
1356         Reviewed by Timothy Hatcher.
1357
1358         This patch changes builder view to not show how many failures there were in a row,
1359         because it is not very relevant, and complicates the UI. Instead, we just show the
1360         latest failing build and the latest successful one.
1361
1362         The patch also removes commit history popovers from revisions that can not be correlated
1363         with any change. These popovers are only helpful in the first line, when there is
1364         another line for comparison below. In this case, it's useful to see what changed
1365         between the revisions, but even then, only if it was an actual failure, not a buildbot
1366         exception.
1367
1368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1369         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1372         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1373         (BuildbotQueueView.prototype._revisionPopoverContentForIteration):
1374         (BuildbotQueueView.prototype.revisionContentForIteration):
1375         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1376         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1377
1378 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1379
1380         Remove ENABLE(JAVASCRIPT_DEBUGGER) guards
1381         https://bugs.webkit.org/show_bug.cgi?id=127840
1382
1383         Reviewed by Mark Lam.
1384
1385         * Scripts/webkitperl/FeatureList.pm:
1386
1387 2014-01-29  Krzysztof Czech  <k.czech@samsung.com>
1388
1389         [ATK] Expose aria-describedby with ATK_RELATION_DESCRIBED_BY
1390         https://bugs.webkit.org/show_bug.cgi?id=121684
1391
1392         Reviewed by Mario Sanchez Prada.
1393
1394         Implementing helpText by using relation ATK_RELATION_DESCRIBED_BY.
1395
1396         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1397         (AccessibilityUIElement::helpText):
1398         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1399         (WTR::AccessibilityUIElement::helpText):
1400
1401 2014-01-27  Chris Fleizach  <cfleizach@apple.com>
1402
1403         AX: Support @scope in HTML tables
1404         https://bugs.webkit.org/show_bug.cgi?id=127688
1405
1406         Reviewed by Mario Sanchez Prada.
1407
1408         Add support for rowHeaders and columnHeaders.
1409
1410         * DumpRenderTree/AccessibilityUIElement.cpp:
1411         (convertElementsToObjectArray):
1412         (columnHeadersCallback):
1413         (rowHeadersCallback):
1414         (uiElementArrayAttributeValueCallback):
1415         (AccessibilityUIElement::columnHeaders):
1416         (AccessibilityUIElement::rowHeaders):
1417         (AccessibilityUIElement::getJSClass):
1418         * DumpRenderTree/AccessibilityUIElement.h:
1419         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1420         (AccessibilityUIElement::rowHeaders):
1421         (AccessibilityUIElement::columnHeaders):
1422         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1423         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1424         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1425         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
1426         (WTR::AccessibilityUIElement::rowHeaders):
1427         (WTR::AccessibilityUIElement::columnHeaders):
1428         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1429         (WTR::convertElementsToObjectArray):
1430         (WTR::AccessibilityUIElement::rowHeaders):
1431         (WTR::AccessibilityUIElement::columnHeaders):
1432         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
1433
1434 2014-01-28  Daniel Bates  <dabates@apple.com>
1435
1436         Teach Buildbot dashboard to parse alternative revision format
1437         https://bugs.webkit.org/show_bug.cgi?id=127561
1438
1439         Reviewed by Alexey Proskuryakov.
1440
1441         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
1442         returns a dictionary for the value of property got_revision.
1443
1444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1445         (isMultiCodebaseGotRevisionProperty): Added.
1446         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
1447         string or a dictionary.
1448         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
1449         the OpenSource and Internal revision numbers.
1450
1451 2014-01-28  Adrian Perez de Castro  <aperez@igalia.com>
1452
1453         [GTK] Add API to allow setting the process model in WebKitWebContext
1454         https://bugs.webkit.org/show_bug.cgi?id=125463
1455
1456         Reviewed by Carlos Garcia Campos.
1457
1458         Implements accessors in WebKitWebContext for the process model.
1459         The default behavior is unchanged, and a single web process is
1460         used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
1461         as the process model will make use one web process for each
1462         WebKitWebView. This also enables the network process. Setting
1463         the process model must be done as early as possible, before the
1464         very first web process is spawned.
1465
1466         * MiniBrowser/gtk/main.c:
1467         (main):
1468         Enable multiple process mode if the MINIBROWSER_MULTIPROCESS
1469         environment variable is defined and not empty.
1470         * TestWebKitAPI/GNUmakefile.am:
1471         Add new TestMultiprocess test case.
1472         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1473         Add new TestMultiprocess test case.
1474         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: Added.
1475         (loadChanged):
1476         (testMultipleSecondaryProcesses):
1477         (initializeWebExtensions):
1478         (beforeAll):
1479         (afterAll):
1480         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1481         (methodCallCallback):
1482         Implement the GetProcessIdentifier D-Bus method.
1483         (makeBusName):
1484         Choose a different bus name when the web extension is used
1485         from TestMultiprocess.
1486         (webkit_web_extension_initialize_with_user_data):
1487         Use makeBusName() to choose the bus name.
1488
1489 2014-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1490
1491         [SOUP] Remove soupURIToKURL
1492         https://bugs.webkit.org/show_bug.cgi?id=127104
1493
1494         Reviewed by Martin Robinson.
1495
1496         * TestWebKitAPI/GNUmakefile.am: Add soup cppflags to WebCore unit
1497         tests, because URL.h now includes GUniquePtrSoup.h.
1498         * TestWebKitAPI/CMakeLists.txt: Ditto.
1499         * WebKitTestRunner/PlatformEfl.cmake: Add soup cppflags to WTR,
1500         because URL.h now includes GUniquePtrSoup.h.
1501
1502 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1503
1504         [GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
1505         https://bugs.webkit.org/show_bug.cgi?id=127614
1506
1507         Reviewed by Gustavo Noronha Silva.
1508
1509         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring
1510         back the custom URI scheme WebView check.
1511
1512 2014-01-27  Tim Horton  <timothy_horton@apple.com>
1513
1514         Revert yet one more tiny part of r162629 that didn't get reverted in r162883
1515
1516         * WebKitTestRunner/TestController.cpp:
1517         (WTR::TestController::pluginLoadPolicy):
1518         * WebKitTestRunner/TestController.h:
1519
1520 2014-01-27  Tim Horton  <timothy_horton@apple.com>
1521
1522         Revert one more tiny part of r162629 that didn't get reverted in r162883.
1523
1524         ... which was also causing test failures!
1525
1526         * WebKitTestRunner/TestController.cpp:
1527         (WTR::TestController::createWebViewWithOptions):
1528
1529 2014-01-27  David Farler  <dfarler@apple.com>
1530
1531         iOS DumpRenderTree.app dies loading fonts
1532         https://bugs.webkit.org/show_bug.cgi?id=127730
1533
1534         Reviewed by Daniel Bates.
1535
1536         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1537         - Add Ahem to the __DATA section
1538         * DumpRenderTree/mac/DumpRenderTree.mm:
1539         (activateFontsIOS):
1540         - Load "WeightWatcher100" instead.
1541
1542 2014-01-27  Alexey Proskuryakov  <ap@apple.com>
1543
1544         [Mac] Extra logging output from run-safari --no-saved-state
1545         https://bugs.webkit.org/show_bug.cgi?id=127732
1546
1547         Reviewed by Daniel Bates.
1548
1549         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that
1550         disables saved state without logging.
1551
1552 2014-01-27  Tim Horton  <timothy_horton@apple.com>
1553
1554         Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.
1555
1556         We're leaving the parts that make us use PDFPlugin instead of showing the blocked
1557         plugin indicator intact, though.
1558
1559         * WebKitTestRunner/TestController.cpp:
1560         (WTR::TestController::createWebViewWithOptions):
1561
1562 2014-01-27  Andy Estes  <aestes@apple.com>
1563
1564         Scrub WebKit API headers of WTF macros
1565         https://bugs.webkit.org/show_bug.cgi?id=127706
1566
1567         Reviewed by David Kilzer.
1568
1569         * Scripts/check-for-inappropriate-macros-in-external-headers: Modified
1570         the regex to require a '(' after the macro name in order to be
1571         considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
1572         from being flagged as an ENABLE() macro.
1573
1574 2014-01-27  Commit Queue  <commit-queue@webkit.org>
1575
1576         Unreviewed, rolling out r162846.
1577         http://trac.webkit.org/changeset/162846
1578         https://bugs.webkit.org/show_bug.cgi?id=127695
1579
1580         "Broke the WebKit Bot Watcher's Dashboard; will fix offline"
1581         (Requested by dydz on #webkit).
1582
1583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1584         (BuildbotIteration.prototype.update.):
1585
1586 2014-01-27  Daniel Bates  <dabates@apple.com>
1587
1588         Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
1589         https://bugs.webkit.org/show_bug.cgi?id=127564
1590
1591         Reviewed by Alexey Proskuryakov.
1592
1593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1594         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1595
1596 2014-01-27  Daniel Bates  <dabates@apple.com>
1597
1598         Teach Buildbot dashboard to parse alternative revision format
1599         https://bugs.webkit.org/show_bug.cgi?id=127561
1600
1601         Reviewed by Alexey Proskuryakov.
1602
1603         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
1604         returns a dictionary for the value of property got_revision.
1605
1606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1607         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
1608         string or a dictionary.
1609         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
1610         the OpenSource and Internal revision numbers.
1611
1612 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1613
1614         [GTK] Implement custom URI schemes with CustomProtocols
1615         https://bugs.webkit.org/show_bug.cgi?id=127091
1616
1617         Reviewed by Gustavo Noronha Silva.
1618
1619         Temporarily disable the WebKitWebView check until we figure out
1620         how to implement it with CustomProtocols.
1621
1622         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1623
1624 2014-01-26  Alexey Proskuryakov  <ap@apple.com>
1625
1626         REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
1627
1628         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
1629         Fixed an incorrect ifdef.
1630
1631 2014-01-26  Brendan Long  <b.long@cablelabs.com>
1632
1633         [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
1634         https://bugs.webkit.org/show_bug.cgi?id=110602
1635
1636         Reviewed by Philippe Normand.
1637
1638         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1639         (getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
1640         (initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
1641
1642 2014-01-24  Andy Estes  <aestes@apple.com>
1643
1644         [iOS] Upstream changes in Tools/DumpRenderTree
1645         https://bugs.webkit.org/show_bug.cgi?id=127412
1646
1647         Reviewed by Simon Fraser.
1648
1649         Upstream all iOS changes. Added a new target called DumpRenderTree.app,
1650         which builds the DumpRenderTree static library into an app bundle as
1651         expected by the iOS Simulator.
1652
1653         * DumpRenderTree/AccessibilityTextMarker.h:
1654         * DumpRenderTree/AccessibilityUIElement.h:
1655         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1656         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
1657         * DumpRenderTree/DumpRenderTreePrefix.h:
1658         * DumpRenderTree/PixelDumpSupport.cpp:
1659         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1660         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1661         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
1662         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1663         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1664         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1665         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1666         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
1667         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
1668         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
1669         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
1670         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
1671         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
1672         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1673         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
1674         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1675         * DumpRenderTree/TestRunner.cpp:
1676         * DumpRenderTree/TestRunner.h:
1677         * DumpRenderTree/cg/ImageDiffCG.cpp:
1678         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1679         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1680         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1681         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
1682         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
1683         * DumpRenderTree/ios/Info.plist: Added.
1684         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
1685         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
1686         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
1687         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
1688         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
1689         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
1690         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
1691         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
1692         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
1693         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
1694         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
1695         * DumpRenderTree/ios/PerlSupport/Makefile: Added.
1696         * DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
1697         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1698         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1699         * DumpRenderTree/mac/AppleScriptController.m:
1700         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1701         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1702         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1703         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
1704         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
1705         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
1706         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
1707         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1708         * DumpRenderTree/mac/DumpRenderTree.mm:
1709         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1710         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1711         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1712         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1713         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1714         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1715         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1716         * DumpRenderTree/mac/EditingDelegate.h:
1717         * DumpRenderTree/mac/EventSendingController.h:
1718         * DumpRenderTree/mac/EventSendingController.mm:
1719         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1720         * DumpRenderTree/mac/HistoryDelegate.h:
1721         * DumpRenderTree/mac/LayoutTestHelper.m:
1722         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1723         * DumpRenderTree/mac/NavigationController.h:
1724         * DumpRenderTree/mac/ObjCPlugin.h:
1725         * DumpRenderTree/mac/ObjCPlugin.m:
1726         * DumpRenderTree/mac/ObjCPluginFunction.h:
1727         * DumpRenderTree/mac/PolicyDelegate.h:
1728         * DumpRenderTree/mac/ResourceLoadDelegate.h:
1729         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1730         * DumpRenderTree/mac/TestRunnerMac.mm:
1731         * DumpRenderTree/mac/TextInputController.h:
1732         * DumpRenderTree/mac/TextInputController.m:
1733         * DumpRenderTree/mac/UIDelegate.h:
1734         * DumpRenderTree/mac/UIDelegate.mm:
1735
1736 2014-01-25  Darin Adler  <darin@apple.com>
1737
1738         Call deprecatedCharacters instead of characters at more call sites
1739         https://bugs.webkit.org/show_bug.cgi?id=127631
1740
1741         Reviewed by Sam Weinig.
1742
1743         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1744         (TestWebKitAPI::expectBuilderContent):
1745         (TestWebKitAPI::expectEmpty):
1746         (TestWebKitAPI::TEST):
1747         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1748         (TestWebKitAPI::TEST):
1749         Use the new name.
1750
1751 2014-01-25  Anders Carlsson  <andersca@apple.com>
1752
1753         Modernize HashTable threading code
1754         https://bugs.webkit.org/show_bug.cgi?id=127621
1755
1756         Reviewed by Darin Adler.
1757
1758         Explicitly include headers that used to be brought in by HashTable.h
1759
1760         * DumpRenderTree/JavaScriptThreading.cpp:
1761
1762 2014-01-24  Eric Carlson  <eric.carlson@apple.com>
1763
1764         Unreviewed. Add Philip Jägenstedt to watch and contributor lists.
1765
1766         * Scripts/webkitpy/common/config/contributors.json:
1767         * Scripts/webkitpy/common/config/watchlist:
1768
1769 2014-01-23  David Farler  <dfarler@apple.com>
1770
1771         Make WebKitTestRunner work with iOS
1772         https://bugs.webkit.org/show_bug.cgi?id=127448
1773
1774         Reviewed by Simon Fraser.
1775
1776         Combined patch from Simon below with some additional xcconfig cleanups,
1777         rebasing and stubbing out a couple of new functions that popped up
1778         since then.
1779
1780         2013-12-03  Simon Fraser  <simon.fraser@apple.com>
1781
1782                 <rdar://problem/15515469> Get WebKitTestRunner working on iOS
1783
1784                 Get WebKitTestRunner limping on iOS. Main parts:
1785                 - Stub out lots of accessibility-related functions.
1786                 - Stub out EventSender
1787                 - Create target to make a bundled app that runs in the simulator,
1788                   and copy the injected bundle library into it.
1789                 - Make a UIWindow and WKView to load tests in
1790
1791                 It runs, load tests, and dumps results to output. More work will be
1792                 required once we can execute it via the webkitpy scripts.
1793
1794         * WebKitTestRunner/Configurations/Base.xcconfig:
1795         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1796         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1797         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1798         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.
1799         (WTR::AccessibilityController::addNotificationListener):
1800         (WTR::AccessibilityController::removeNotificationListener):
1801         (WTR::AccessibilityController::platformName):
1802         (WTR::AccessibilityController::logAccessibilityEvents):
1803         (WTR::AccessibilityController::resetToConsistentState):
1804         (WTR::findAccessibleObjectById):
1805         (WTR::AccessibilityController::accessibleElementById):
1806         * WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
1807         * WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1808         (WTR::AccessibilityTextMarker::isEqual):
1809         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.
1810         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1811         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1812         (WTR::AccessibilityUIElement::isEqual):
1813         (WTR::AccessibilityUIElement::getLinkedUIElements):
1814         (WTR::AccessibilityUIElement::getDocumentLinks):
1815         (WTR::AccessibilityUIElement::getChildren):
1816         (WTR::AccessibilityUIElement::getChildrenWithRange):
1817         (WTR::AccessibilityUIElement::childrenCount):
1818         (WTR::AccessibilityUIElement::elementAtPoint):
1819         (WTR::AccessibilityUIElement::indexOfChild):
1820         (WTR::AccessibilityUIElement::childAtIndex):
1821         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1822         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1823         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1824         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1825         (WTR::AccessibilityUIElement::rowAtIndex):
1826         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1827         (WTR::AccessibilityUIElement::selectedChildrenCount):
1828         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1829         (WTR::AccessibilityUIElement::titleUIElement):
1830         (WTR::AccessibilityUIElement::parentElement):
1831         (WTR::AccessibilityUIElement::disclosedByRow):
1832         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1833         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1834         (WTR::AccessibilityUIElement::attributesOfChildren):
1835         (WTR::AccessibilityUIElement::allAttributes):
1836         (WTR::AccessibilityUIElement::stringAttributeValue):
1837         (WTR::AccessibilityUIElement::numberAttributeValue):
1838         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
1839         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1840         (WTR::AccessibilityUIElement::boolAttributeValue):
1841         (WTR::AccessibilityUIElement::isAttributeSettable):
1842         (WTR::AccessibilityUIElement::isAttributeSupported):
1843         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1844         (WTR::AccessibilityUIElement::role):
1845         (WTR::AccessibilityUIElement::subrole):
1846         (WTR::AccessibilityUIElement::roleDescription):
1847         (WTR::AccessibilityUIElement::title):
1848         (WTR::AccessibilityUIElement::description):
1849         (WTR::AccessibilityUIElement::orientation):
1850         (WTR::AccessibilityUIElement::stringValue):
1851         (WTR::AccessibilityUIElement::language):
1852         (WTR::AccessibilityUIElement::helpText):
1853         (WTR::AccessibilityUIElement::x):
1854         (WTR::AccessibilityUIElement::y):
1855         (WTR::AccessibilityUIElement::width):
1856         (WTR::AccessibilityUIElement::height):
1857         (WTR::AccessibilityUIElement::clickPointX):
1858         (WTR::AccessibilityUIElement::clickPointY):
1859         (WTR::AccessibilityUIElement::intValue):
1860         (WTR::AccessibilityUIElement::minValue):
1861         (WTR::AccessibilityUIElement::maxValue):
1862         (WTR::AccessibilityUIElement::valueDescription):
1863         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1864         (WTR::AccessibilityUIElement::isPressActionSupported):
1865         (WTR::AccessibilityUIElement::isIncrementActionSupported):
1866         (WTR::AccessibilityUIElement::isDecrementActionSupported):
1867         (WTR::AccessibilityUIElement::isEnabled):
1868         (WTR::AccessibilityUIElement::isRequired):
1869         (WTR::AccessibilityUIElement::isFocused):
1870         (WTR::AccessibilityUIElement::isSelected):
1871         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1872         (WTR::AccessibilityUIElement::isIndeterminate):
1873         (WTR::AccessibilityUIElement::isExpanded):
1874         (WTR::AccessibilityUIElement::isChecked):
1875         (WTR::AccessibilityUIElement::hierarchicalLevel):
1876         (WTR::AccessibilityUIElement::classList):
1877         (WTR::AccessibilityUIElement::speak):
1878         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1879         (WTR::AccessibilityUIElement::ariaDropEffects):
1880         (WTR::AccessibilityUIElement::lineForIndex):
1881         (WTR::AccessibilityUIElement::rangeForLine):
1882         (WTR::AccessibilityUIElement::rangeForPosition):
1883         (WTR::AccessibilityUIElement::boundsForRange):
1884         (WTR::AccessibilityUIElement::stringForRange):
1885         (WTR::AccessibilityUIElement::attributedStringForRange):
1886         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1887         (WTR::uiElementCountForSearchPredicate):
1888         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1889         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1890         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1891         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1892         (WTR::AccessibilityUIElement::attributesOfColumns):
1893         (WTR::AccessibilityUIElement::attributesOfRows):
1894         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1895         (WTR::AccessibilityUIElement::attributesOfHeader):
1896         (WTR::AccessibilityUIElement::rowCount):
1897         (WTR::AccessibilityUIElement::columnCount):
1898         (WTR::AccessibilityUIElement::indexInTable):
1899         (WTR::AccessibilityUIElement::rowIndexRange):
1900         (WTR::AccessibilityUIElement::columnIndexRange):
1901         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1902         (WTR::AccessibilityUIElement::horizontalScrollbar):
1903         (WTR::AccessibilityUIElement::verticalScrollbar):
1904         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1905         (WTR::AccessibilityUIElement::selectedTextRange):
1906         (WTR::AccessibilityUIElement::setSelectedTextRange):
1907         (WTR::AccessibilityUIElement::increment):
1908         (WTR::AccessibilityUIElement::decrement):
1909         (WTR::AccessibilityUIElement::showMenu):
1910         (WTR::AccessibilityUIElement::press):
1911         (WTR::AccessibilityUIElement::setSelectedChild):
1912         (WTR::AccessibilityUIElement::accessibilityValue):
1913         (WTR::AccessibilityUIElement::documentEncoding):
1914         (WTR::AccessibilityUIElement::documentURI):
1915         (WTR::AccessibilityUIElement::url):
1916         (WTR::AccessibilityUIElement::addNotificationListener):
1917         (WTR::AccessibilityUIElement::removeNotificationListener):
1918         (WTR::AccessibilityUIElement::isFocusable):
1919         (WTR::AccessibilityUIElement::isSelectable):
1920         (WTR::AccessibilityUIElement::isMultiSelectable):
1921         (WTR::AccessibilityUIElement::isVisible):
1922         (WTR::AccessibilityUIElement::isOffScreen):
1923         (WTR::AccessibilityUIElement::isCollapsed):
1924         (WTR::AccessibilityUIElement::isIgnored):
1925         (WTR::AccessibilityUIElement::hasPopup):
1926         (WTR::AccessibilityUIElement::takeFocus):
1927         (WTR::AccessibilityUIElement::takeSelection):
1928         (WTR::AccessibilityUIElement::addSelection):
1929         (WTR::AccessibilityUIElement::removeSelection):
1930         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1931         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1932         (WTR::AccessibilityUIElement::previousTextMarker):
1933         (WTR::AccessibilityUIElement::nextTextMarker):
1934         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1935         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1936         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1937         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1938         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1939         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1940         (WTR::AccessibilityUIElement::textMarkerForPoint):
1941         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1942         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1943         (WTR::AccessibilityUIElement::indexForTextMarker):
1944         (WTR::AccessibilityUIElement::isTextMarkerValid):
1945         (WTR::AccessibilityUIElement::textMarkerForIndex):
1946         (WTR::AccessibilityUIElement::startTextMarker):
1947         (WTR::AccessibilityUIElement::endTextMarker):
1948         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1949         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1950         (WTR::AccessibilityUIElement::pathDescription):
1951         (WTR::AccessibilityUIElement::supportedActions):
1952         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1953         (WTR::activateFonts):
1954         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.
1955         (WTR::EventSenderProxy::EventSenderProxy):
1956         (WTR::EventSenderProxy::~EventSenderProxy):
1957         (WTR::EventSenderProxy::updateClickCountForButton):
1958         (WTR::EventSenderProxy::mouseDown):
1959         (WTR::EventSenderProxy::mouseUp):
1960         (WTR::EventSenderProxy::mouseMoveTo):
1961         (WTR::EventSenderProxy::leapForward):
1962         (WTR::EventSenderProxy::keyDown):
1963         (WTR::EventSenderProxy::mouseScrollBy):
1964         (WTR::EventSenderProxy::continuousMouseScrollBy):
1965         (WTR::EventSenderProxy::addTouchPoint):
1966         (WTR::EventSenderProxy::updateTouchPoint):
1967         (WTR::EventSenderProxy::setTouchModifier):
1968         (WTR::EventSenderProxy::setTouchPointRadius):
1969         (WTR::EventSenderProxy::touchStart):
1970         (WTR::EventSenderProxy::touchMove):
1971         (WTR::EventSenderProxy::touchEnd):
1972         (WTR::EventSenderProxy::touchCancel):
1973         (WTR::EventSenderProxy::clearTouchPoints):
1974         (WTR::EventSenderProxy::releaseTouchPoint):
1975         (WTR::EventSenderProxy::cancelTouchPoint):
1976         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1977         (WTR::InjectedBundle::platformInitialize):
1978         * WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1979         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1980         * WebKitTestRunner/Makefile:
1981         * WebKitTestRunner/TestController.cpp:
1982         (WTR::TestController::initialize):
1983         * WebKitTestRunner/TestController.h:
1984         * WebKitTestRunner/TestInvocation.cpp:
1985         (WTR::TestInvocation::invoke):
1986         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1987         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1988         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
1989         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.
1990         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
1991         (-[AppDelegate applicationWillResignActive:]):
1992         (-[AppDelegate applicationDidEnterBackground:]):
1993         (-[AppDelegate applicationWillEnterForeground:]):
1994         (-[AppDelegate applicationDidBecomeActive:]):
1995         (-[AppDelegate applicationWillTerminate:]):
1996         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
1997         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
1998         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
1999         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
2000         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
2001         * WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.
2002         (main):
2003         * WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
2004         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
2005         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.
2006         (-[WebKitTestRunnerAppTests setUp]):
2007         (-[WebKitTestRunnerAppTests tearDown]):
2008         (-[WebKitTestRunnerAppTests testExample]):
2009         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
2010         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2011         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2012         * WebKitTestRunner/iOS.xcconfig: Added.
2013         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.
2014         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
2015         (-[TestRunnerWKView _shouldUseTiledDrawingArea]):
2016         (-[WebKitTestRunnerWindow isKeyWindow]):
2017         (-[WebKitTestRunnerWindow setFrameOrigin:]):
2018         (-[WebKitTestRunnerWindow setFrame:]):
2019         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
2020         (-[WebKitTestRunnerWindow backingScaleFactor]):
2021         (WTR::PlatformWebView::PlatformWebView):
2022         (WTR::PlatformWebView::resizeTo):
2023         (WTR::PlatformWebView::~PlatformWebView):
2024         (WTR::PlatformWebView::page):
2025         (WTR::PlatformWebView::focus):
2026         (WTR::PlatformWebView::windowFrame):
2027         (WTR::PlatformWebView::setWindowFrame):
2028         (WTR::PlatformWebView::didInitializeClients):
2029         (WTR::PlatformWebView::addChromeInputField):
2030         (WTR::PlatformWebView::removeChromeInputField):
2031         (WTR::PlatformWebView::makeWebViewFirstResponder):
2032         (WTR::PlatformWebView::windowSnapshotImage):
2033         (WTR::PlatformWebView::viewSupportsOptions):
2034         * WebKitTestRunner/ios/TestControllerIOS.mm: Added.
2035         (WTR::TestController::notifyDone):
2036         (WTR::TestController::platformInitialize):
2037         (WTR::TestController::platformDestroy):
2038         (WTR::TestController::initializeInjectedBundlePath):
2039         (WTR::TestController::initializeTestPluginDirectory):
2040         (WTR::TestController::platformRunUntil):
2041         (WTR::TestController::platformInitializeContext):
2042         (WTR::TestController::runModal):
2043         (WTR::TestController::platformLibraryPathForTesting):
2044         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
2045         (createCFURLResponseFromResponseData):
2046         (supportedNonImageMIMETypes):
2047         * WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
2048         (-[WebKitTestRunnerApp _runTestController]):
2049         (-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
2050         (main):
2051
2052 2014-01-24  Enrique Ocaña González  <eocanha@igalia.com>
2053
2054         [GTK] Put cache files in XDG_CACHE_HOME
2055         https://bugs.webkit.org/show_bug.cgi?id=123458
2056
2057         Reviewed by Martin Robinson.
2058
2059         * GtkLauncher/main.c:
2060         (createBrowser):
2061
2062 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
2063
2064         Remove CSS Custom Filters code and tests
2065         https://bugs.webkit.org/show_bug.cgi?id=127382
2066
2067         Reviewed by Simon Fraser.
2068
2069         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2070         (resetDefaultsToConsistentValues):
2071         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2072         (TestRunner::overridePreference):
2073
2074 2014-01-23  Tim Horton  <timothy_horton@apple.com>
2075
2076         PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
2077         https://bugs.webkit.org/show_bug.cgi?id=127415
2078         <rdar://problem/12482452>
2079
2080         Reviewed by Sam Weinig.
2081
2082         Adopt the new page loader client plugin load callback.
2083
2084         * WebKitTestRunner/TestController.cpp:
2085         (WTR::TestController::createWebViewWithOptions):
2086         (WTR::TestController::pluginLoadPolicy):
2087         * WebKitTestRunner/TestController.h:
2088
2089 2014-01-23  peavo@outlook.com  <peavo@outlook.com>
2090
2091         [Curl] There is no way to specify cache folder.
2092         https://bugs.webkit.org/show_bug.cgi?id=125028
2093
2094         Reviewed by Brent Fulgham.
2095
2096         Enable disc cache in WinLauncher by setting cache folder location.
2097
2098         * WinLauncher/WinLauncher.cpp:
2099         (getAppDataFolder): Added function to get app data folder.
2100         (setCacheFolder): Added function to set cache folder.
2101         (createCrashReport): Use new getAppDataFolder function.
2102         (wWinMain): Use function setCacheFolder to set cache folder location.
2103
2104 2014-01-23  Daniel Bates  <dabates@apple.com>
2105
2106         build-webkit --sdk=iphonesimulator doesn't think it's building iOS
2107         https://bugs.webkit.org/show_bug.cgi?id=127379
2108
2109         Reviewed by Simon Fraser.
2110
2111         Teach build-webkit to recognize --sdk=X.
2112
2113         Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
2114         considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
2115         help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
2116         of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).
2117
2118         * Scripts/webkitdirs.pm:
2119         (checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
2120         (checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().
2121         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
2122
2123 2014-01-23  Commit Queue  <commit-queue@webkit.org>
2124
2125         Unreviewed, rolling out r162612.
2126         http://trac.webkit.org/changeset/162612
2127         https://bugs.webkit.org/show_bug.cgi?id=127488
2128
2129         broke the build (Requested by mhahnenberg on #webkit).
2130
2131         * Scripts/build-jsc:
2132         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
2133         * jsc-cli/jsc-cli/CLIInstance.h: Removed.
2134         * jsc-cli/jsc-cli/CLIInstance.m: Removed.
2135         * jsc-cli/jsc-cli/JSModule.h: Removed.
2136         * jsc-cli/jsc-cli/JSModule.m: Removed.
2137         * jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
2138         * jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
2139         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
2140         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
2141         * jsc-cli/jsc-cli/RunLoopThread.h: Removed.
2142         * jsc-cli/jsc-cli/RunLoopThread.m: Removed.
2143         * jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
2144         * jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
2145         * jsc-cli/jsc-cli/main.m: Removed.
2146
2147 2014-01-23  Mark Hahnenberg  <mhahnenberg@apple.com>
2148
2149         Basic framework for a modern jsc CLI
2150         https://bugs.webkit.org/show_bug.cgi?id=127435
2151
2152         Reviewed by Geoffrey Garen.
2153
2154         The most basic components of a modern jsc command line interface consist of the following:
2155
2156         - A simple REPL to enter commands and receive results
2157         - The ability to define a module (which consists of various internal methods as well as a 
2158           set of externally visible methods)
2159         - The ability to load other modules at runtime
2160         - The ability to interact with the underlying platform to perform various "privileged" 
2161           functions (e.g. opening files, printing to the stdout, etc.)
2162         
2163         The basic architecture will look something like the following:
2164         - If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL 
2165           on the main thread and start a secondary thread with a run loop to handle various inputs 
2166           from the REPL thread.
2167         - If the tool is given a script to run, it will evaluate that script (and any scripts that 
2168           it might transitively load) within the run loop on the secondary thread while the main 
2169           thread blocks until it has completed.
2170
2171         * Scripts/build-jsc:
2172         * jsc-cli: Added.
2173         * jsc-cli/jsc-cli: Added.
2174         * jsc-cli/jsc-cli.xcodeproj: Added.
2175         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
2176         * jsc-cli/jsc-cli/CLIInstance.h: Added.
2177         * jsc-cli/jsc-cli/CLIInstance.m: Added.
2178         (-[CLIInstance init]):
2179         (-[CLIInstance loadFile:]):
2180         (-[CLIInstance run]):
2181         * jsc-cli/jsc-cli/JSModule.h: Added.
2182         * jsc-cli/jsc-cli/JSModule.m: Added.
2183         (coreModules):
2184         (isCoreModule):
2185         (classForModule):
2186         (coreModuleFullPath):
2187         (resolveModuleAsFile):
2188         (resolveModuleAsDirectory):
2189         (nodeModulePaths):
2190         (resolveAsNodeModule):
2191         (+[JSModule resolve:atPath:]):
2192         (globalModuleCache):
2193         (isCached):
2194         (cachedModule):
2195         (cacheModule):
2196         (+[JSModule require:atPath:]):
2197         (+[JSModule require:atPath:inContext:]):
2198         (-[JSModule platformObjectInContext:]):
2199         (-[JSModule initWithId:filename:context:]):
2200         (-[JSModule dealloc]):
2201         (-[JSModule didStartLoading]):
2202         (-[JSModule didFinishLoading]):
2203         (-[JSModule require:]):
2204         (-[JSModule exports]):
2205         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
2206         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
2207         (jsThreadMain):
2208         (+[JSRunLoopThread threadMain]):
2209         (-[JSRunLoopThread initWithFiles:andContext:]):
2210         (-[JSRunLoopThread startRunLoop]):
2211         (-[JSRunLoopThread start]):
2212         (-[JSRunLoopThread join]):
2213         (-[JSRunLoopThread didReceiveInput:]):
2214         (-[JSRunLoopThread performCallback:withError:]):
2215         (-[JSRunLoopThread performCallback:withArguments:]):
2216         (-[JSRunLoopThread didFinishRunLoopInitialization]):
2217         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
2218         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
2219         (-[ReadEvalPrintLoop initWithJSThread:]):
2220         (prompt):
2221         (escapeStringForOutput):
2222         (-[ReadEvalPrintLoop processNextInput]):
2223         (-[ReadEvalPrintLoop run]):
2224         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
2225         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
2226         (+[RunLoopThread threadMain]):
2227         (-[RunLoopThread init]):
2228         (-[RunLoopThread dealloc]):
2229         (-[RunLoopThread didFinishRunLoopInitialization]):
2230         (-[RunLoopThread start]):
2231         (-[RunLoopThread join]):
2232         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
2233         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
2234         (scriptInputSourceScheduleRoutine):
2235         (scriptInputSourcePerformRoutine):
2236         (scriptInputSourceCancelRoutine):
2237         (-[ScriptInputSource initWithContext:]):
2238         (-[ScriptInputSource dealloc]):
2239         (-[ScriptInputSource addToCurrentRunLoop]):
2240         (-[ScriptInputSource removeFromRemoteRunLoop]):
2241         (-[ScriptInputSource didReceiveScript:]):
2242         (-[ScriptInputSource didReceiveSignal]):
2243         (-[ScriptInputSource runScriptRemotely:]):
2244         (-[ScriptInputSource finishAsyncCallback:withResult:]):
2245         * jsc-cli/jsc-cli/main.m: Added.
2246         (main):
2247
2248 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
2249
2250         Remove a FIXME comment that is already fixed.
2251         https://bugs.webkit.org/show_bug.cgi?id=127468
2252
2253         Reviewed by Csaba Osztrogonác.
2254
2255         * Scripts/webkitpy/style/filereader.py:
2256         (TextFileReader.__init__):
2257
2258 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2259
2260         [GLIB] Use GUniquePtr instead of GOwnPtr
2261         https://bugs.webkit.org/show_bug.cgi?id=127431
2262
2263         Reviewed by Martin Robinson.
2264
2265         GUniquePtr is a template alias of std::unique_ptr with a custom
2266         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
2267         where the output pointer is needed, but it will also be replaced soon.
2268
2269         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2270         (printAccessibilityEvent):
2271         (axObjectEventListener):
2272         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2273         (indexRangeInTable):
2274         (AccessibilityUIElement::role):
2275         (AccessibilityUIElement::title):
2276         (AccessibilityUIElement::description):
2277         (AccessibilityUIElement::stringValue):
2278         (AccessibilityUIElement::language):
2279         (AccessibilityUIElement::lineForIndex):
2280         (AccessibilityUIElement::selectedTextRange):
2281         (AccessibilityUIElement::url):
2282         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
2283         (AccessibilityController::accessibleElementById):
2284         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2285         (AccessibilityController::accessibleElementById):
2286         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2287         (getOutputDir):
2288         (getFontsPath):
2289         (initializeFonts):
2290         (dumpFramesAsText):
2291         (compareHistoryItems):
2292         (dumpHistoryItem):
2293         (soupURIToStringPreservingPassword):
2294         (resetDefaultsToConsistentValues):
2295         (temporaryDatabaseDirectory):
2296         (webViewTitleChanged):
2297         (webFrameLoadStatusNotified):
2298         (pathFromSoupURI):
2299         (convertWebResourceToURLPath):
2300         (urlSuitableForTestResult):
2301         (descriptionSuitableForTestResult):
2302         (willSendRequestCallback):
2303         (frameLoadEventCallback):
2304         * DumpRenderTree/gtk/EditingCallbacks.cpp:
2305         (dumpNodePath):
2306         (dumpRange):
2307         (shouldApplyStyle):
2308         * DumpRenderTree/gtk/EventSender.cpp:
2309         (contextClickCallback):
2310         (beginDragWithFilesCallback):
2311         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2312         (TestRunner::pathToLocalResource):
2313         (TestRunner::queueLoad):
2314         (TestRunner::removeOriginAccessWhitelistEntry):
2315         (TestRunner::setMockGeolocationPositionUnavailableError):
2316         (TestRunner::setIconDatabaseEnabled):
2317         (TestRunner::findString):
2318         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2319         (TestRunner::overridePreference):
2320         (TestRunner::addUserScript):
2321         (TestRunner::addUserStyleSheet):
2322         (TestRunner::setTextDirection):
2323         * DumpRenderTree/gtk/TextInputController.cpp:
2324         (setMarkedTextCallback):
2325         (insertTextCallback):
2326         (doCommandCallback):
2327         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2328         (LoadHTMLStringItem::invoke):
2329         * TestWebKitAPI/PlatformGTK.cmake:
2330         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2331         (WebKitDOMNodeTest::testTagNames):
2332         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
2333         (testBackForwardListLimitAndCache):
2334         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2335         (testContextMenuSmartSeparators):
2336         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2337         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2338         (testDownloadLocalFile):
2339         (testDownloadLocalFileError):
2340         (addContentDispositionHTTPHeaderToResponse):
2341         (serverCallback):
2342         (testDownloadRemoteFileError):
2343         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2344         (startTestServer):
2345         (testInspectorServerPageList):
2346         (openRemoteDebuggingSession):
2347         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2348         (testPrintOperationPrint):
2349         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2350         (addCacheHTTPHeadersToResponse):
2351         (serverCallback):
2352         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2353         (httpsServerCallback):
2354         (httpServerCallback):
2355         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2356         (testWebViewJavaScriptDialogs):
2357         (testWebViewWindowProperties):
2358         (testWebViewFileChooserRequest):
2359         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2360         (testWebExtensionWindowObjectCleared):
2361         (testWebExtensionIsolatedWorld):
2362         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
2363         (startTestServer):
2364         (checkAtspiAccessible):
2365         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2366         (serverCallback):
2367         (testClearDatabase):
2368         (testGetFaviconURI):
2369         (webkitFaviconDatabaseFinalizedCallback):
2370         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2371         (testWebContextGetPlugins):
2372         (testWebContextURIScheme):
2373         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2374         (testWebViewRunJavaScript):
2375         (testWebViewMode):
2376         (testWebViewPageVisibility):
2377         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
2378         (isStyleSheetInjectedForURLAtPath):
2379         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2380         (testWebViewEditorCutCopyPasteNonEditable):
2381         (testWebViewEditorCutCopyPasteEditable):
2382         (testWebViewEditorSelectAllNonEditable):
2383         (testWebViewEditorSelectAllEditable):
2384         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2385         (sendRequestCallback):
2386         (methodCallCallback):
2387         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
2388         (TestWebKitAPI::Util::createInjectedBundlePath):
2389         (TestWebKitAPI::Util::createURLForResource):
2390         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
2391         (TestWebKitAPI::doKeyStroke):
2392         (TestWebKitAPI::doMouseButtonEvent):
2393         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2394         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2395         (loadFailedCallback):
2396         (LoadTrackingTest::loadURI):
2397         (LoadTrackingTest::loadHtml):
2398         (LoadTrackingTest::loadPlainText):
2399         (LoadTrackingTest::loadRequest):
2400         (LoadTrackingTest::reload):
2401         (LoadTrackingTest::goBack):
2402         (LoadTrackingTest::goForward):
2403         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2404         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
2405         (registerGResource):
2406         (removeNonEmptyDirectory):
2407         (main):
2408         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2409         (Test::getWebKit1TestResoucesDir):
2410         (Test::getResourcesDir):
2411         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
2412         (WebKitTestBus::run):
2413         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2414         (WebKitTestServer::WebKitTestServer):
2415         (WebKitTestServer::getURIForPath):
2416         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
2417         (WebProcessTestRunner::runTest):
2418         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2419         (resourceGetDataCallback):
2420         (WebViewTest::mainResourceData):
2421         (WebViewTest::mouseMoveTo):
2422         (WebViewTest::keyStroke):
2423         (WebViewTest::doMouseButtonEvent):
2424         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2425         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2426         (WTR::AccessibilityController::accessibleElementById):
2427         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2428         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2429         (WTR::AccessibilityUIElement::role):
2430         (WTR::AccessibilityUIElement::title):
2431         (WTR::AccessibilityUIElement::description):
2432         (WTR::AccessibilityUIElement::stringValue):
2433         (WTR::AccessibilityUIElement::language):
2434         (WTR::AccessibilityUIElement::lineForIndex):
2435         (WTR::AccessibilityUIElement::selectedTextRange):
2436         (WTR::AccessibilityUIElement::url):
2437         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2438         (WTR::getOutputDir):
2439         (WTR::getFontsPath):
2440         (WTR::initializeFontConfigSetting):
2441         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2442         (WTR::topLevelPath):
2443         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2444         (WTR::TestRunner::pathToLocalResource):
2445         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2446         (WTR::TestController::initializeInjectedBundlePath):
2447         (WTR::TestController::initializeTestPluginDirectory):
2448
2449 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
2450
2451         [GTK] [CMake] run-webkit-tests should support the CMake build
2452         https://bugs.webkit.org/show_bug.cgi?id=126503
2453
2454         Reviewed by Daniel Bates.
2455
2456         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
2457         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
2458
2459         * Scripts/run-launcher: Work properly with the gtkcmake flag.
2460         * Scripts/webkitpy/port/gtk.py:
2461         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
2462         file to detect a CMake build.
2463         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
2464         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
2465         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
2466         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
2467         (GtkPort._path_to_driver): Use the new helper.
2468         (GtkPort._path_to_image_diff): Use the new helper.
2469         (GtkPort._path_to_webcore_library): Use the new helper.
2470         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
2471
2472 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
2473
2474         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
2475         https://bugs.webkit.org/show_bug.cgi?id=127417
2476
2477         Reviewed by Gyuyoung Kim.
2478
2479         * EWebLauncher/main.c:
2480         (on_key_down): Removed shortcut to test pre render.
2481
2482 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
2483
2484         Remove CSS3_TEXT_DECORATION define
2485         https://bugs.webkit.org/show_bug.cgi?id=127333
2486
2487         This is required for unprefixing the text-decoration-* CSS properties.
2488
2489         Reviewed by Simon Fraser.
2490
2491         * Configurations/FeatureDefines.xcconfig:
2492
2493 2014-01-22  Andy Estes  <aestes@apple.com>
2494
2495         [iOS] Prepare for upstreaming DumpRenderTree changes
2496         https://bugs.webkit.org/show_bug.cgi?id=127412
2497
2498         Reviewed by Simon Fraser.
2499
2500         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
2501         an application bundle. Instead of upstreaming a separate target for the
2502         app that duplicates the 'Compile Sources' phase of the tool, separate
2503         out the compilation into a static library target that both the
2504         command-line tool and the app can link against. Also, perform some
2505         unrelated cleanup.
2506
2507         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
2508         project file format from 2.4- to 3.2-compatible. Removed the
2509         'Copy Headers' build phase and removed all files from the
2510         'Compile Sources' build phase of DumpRenderTree. Added some files that
2511         were missing from the project. Created a 'DumpRenderTree (Library)'
2512         target for building the static library and made the 'DumpRenderTree'
2513         target depend on it. Added a 'Compile Sources' build phase to this
2514         target that builds the same files the DumpRenderTree target used to.
2515         Created DumpRenderTreeMain.mm as the only source file of the
2516         DumpRenderTree target, since targets won't link a binary without at
2517         least one source file. Made DumpRenderTree (Library) use
2518         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
2519         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
2520         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
2521         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
2522         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
2523         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
2524         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
2525         This is needed to correctly link a static library containing an Objective-C
2526         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
2527         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
2528         * DumpRenderTree/mac/DumpRenderTree.mm:
2529         (DumpRenderTreeMain): Renamed from main.
2530         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
2531         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
2532         (main): Called DumpRenderTreeMain from main.
2533
2534 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
2535
2536         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
2537         https://bugs.webkit.org/show_bug.cgi?id=127073
2538
2539         Reviewed by Daniel Bates.
2540
2541         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
2542         the new isCMakeBuild conditional. This allows us to share more code between ports.
2543         Pass the build arguments to the removeCMakeCache function.
2544         * Scripts/webkitdirs.pm:
2545         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
2546         because it's now shared with the CMake build.
2547         (cachedArgumentFileOutOfDate): Renamed.
2548         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
2549         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
2550         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
2551         as well as checking if build-webkit has been run with different arguments.
2552         (removeCMakeCache): Call shouldRemoveCMakeCache now.
2553         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
2554         (isCMakeBuild): Added.
2555
2556 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
2557
2558         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
2559         https://bugs.webkit.org/show_bug.cgi?id=127119
2560
2561         Reviewed by Mario Sanchez Prada.
2562
2563         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
2564
2565         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2566         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2567         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2568         (resetDefaultsToConsistentValues):
2569         (webViewWindowObjectCleared):
2570         (main):
2571         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2572         (WTR::AccessibilityController::platformName):
2573         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2574         (WTR::AccessibilityUIElement::isIndeterminate):
2575
2576 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2577
2578
2579         [GTK] Add GUniquePtr
2580         https://bugs.webkit.org/show_bug.cgi?id=127170
2581
2582         Reviewed by Gustavo Noronha Silva.
2583
2584         Add unit tests for GUniquePtr.
2585
2586         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
2587         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
2588         (log):
2589         (takeLogStr):
2590         (TestWebKitAPI::TEST):
2591
2592 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
2593
2594         Remove Nix files from Tools
2595         https://bugs.webkit.org/show_bug.cgi?id=127418
2596
2597         Reviewed by Csaba Osztrogonác.
2598
2599         * Scripts/build-webkit:
2600         * Scripts/update-webkit-libs-jhbuild:
2601         * Scripts/webkitdirs.pm:
2602         (determineArchitecture):
2603         (argumentsForConfiguration):
2604         (jscProductDir):
2605         (builtDylibPathForName):
2606         (isAppleWebKit):
2607         (launcherPath):
2608         (launcherName):
2609         (checkRequiredSystemConfig):
2610         (copyInspectorFrontendFiles):
2611         (jhbuildWrapperPrefixIfNeeded):
2612         (buildCMakeProjectOrExit):
2613         (cmakeBasedPortName):
2614         * Scripts/webkitpy/common/config/ports.py:
2615         (DeprecatedPort.port):
2616         (EflWK2Port.build_webkit_command):
2617         * Scripts/webkitpy/port/factory.py:
2618         (platform_options):
2619         (PortFactory):
2620         * Scripts/webkitpy/port/nix.py: Removed.
2621         * Scripts/webkitpy/port/nix_unittest.py: Removed.
2622
2623 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
2624
2625         Add Ian and Ricky to the contributor list
2626
2627         * Scripts/webkitpy/common/config/contributors.json:
2628         I am too old to remember all those email addresses :)
2629
2630 2014-01-21  David Farler  <dfarler@apple.com>
2631
2632         Upstream package-root for iOS
2633
2634         Reviewed by Daniel bates.
2635
2636         * Scripts/package-root: Added.
2637         (usage):
2638         * Scripts/webkitdirs.pm:
2639         (XcodeSDKPath): Added function.
2640
2641 2014-01-21  Daniel Bates  <dabates@apple.com>
2642
2643         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
2644         https://bugs.webkit.org/show_bug.cgi?id=127368
2645
2646         Reviewed by Tim Horton.
2647
2648         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
2649         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
2650         Tools.
2651
2652         * Makefile:
2653
2654 2014-01-21  Daniel Bates  <dabates@apple.com>
2655
2656         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
2657         https://bugs.webkit.org/show_bug.cgi?id=127364
2658
2659         Reviewed by Simon Fraser.
2660
2661         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
2662         projects fail to build because we need to upstream the relevant iOS changes.
2663         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
2664         aren't building TestWebKitAPI.
2665
2666         * Scripts/build-webkit:
2667
2668 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2669
2670         Unreviewed, remove myself from some watchlist entries.
2671
2672         * Scripts/webkitpy/common/config/watchlist:
2673
2674 2014-01-21  Zalan Bujtas  <zalan@apple.com>
2675
2676         Use 64 as the default value for the subpixel denominator.
2677
2678         Reviewed by Simon Fraser.
2679
2680         * lldb/lldb_webkit.py:
2681         (WebCoreLayoutUnitProvider.to_string):
2682
2683 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
2684
2685         [GTK] Fix a c++11 compliance issue for fontconfig
2686         https://bugs.webkit.org/show_bug.cgi?id=127283
2687
2688         Reviewed by Martin Robinson.
2689
2690         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
2691         hotfix until bumping fontconfig up.
2692
2693         * gtk/jhbuild.modules:
2694         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2695
2696 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2697
2698         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
2699         like run_webkit_test does
2700         https://bugs.webkit.org/show_bug.cgi?id=127349
2701
2702         Reviewed by Csaba Osztrogonác.
2703
2704         * Scripts/run-jsc-stress-tests:
2705
2706 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
2707
2708         [GTK] Allow passing extra data to web extensions
2709         https://bugs.webkit.org/show_bug.cgi?id=125990
2710
2711         Reviewed by Carlos Garcia Campos.
2712
2713         Allow passing additional information to the injected bundle. On top
2714         of the string containing the path to the web extensions directory,
2715         a GVariant can be set with additional data using
2716         webkit_web_context_set_web_extensions_initialization_user_data().
2717         Also, a new initialize-web-extensions signal is emitted before
2718         launching a new WebProcess to allow setting different user data
2719         for each process. The GVariant is serialized as a string, passed
2720         to the injected bundle, and the injected bundle deserializes back
2721         the data, which is passed to web extensions which define the
2722         webkit_web_extension_initialize_with_user_data() function (for
2723         backwards compatibility, webkit_web_extension_initialize() is
2724         used as a fallback.)
2725
2726         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2727         (initializeWebExtensions): Handles the initialize-web-extensions
2728         signal, and sets the web extensions directory and the initialization
2729         user data.
2730         (testWebExtensionInitializationUserData): New test case for checking
2731         the user data passed on initialization to web extensions.
2732         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2733         (methodCallCallback): Added implementation for the
2734         GetInitializationUserData D-Bus method, used by
2735         testWebExtensionInitializationUserData().
2736         (webkit_web_extension_initialize_with_user_data): Define the
2737         initialization function with the additional user data parameter.
2738
2739 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
2740
2741         Change my email address in contributors.json.
2742
2743         Unreviewed.
2744
2745         * Scripts/webkitpy/common/config/contributors.json:
2746
2747 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
2748
2749         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
2750         https://bugs.webkit.org/show_bug.cgi?id=127291
2751
2752         Reviewed by Mario Sanchez Prada.
2753
2754         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
2755
2756         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2757         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2758         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2759         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2760
2761 2014-01-20  Zalan Bujtas  <zalan@apple.com>
2762
2763         Force float division when calculating CSS px value.
2764
2765         Reviewed by Simon Fraser.
2766
2767         Note that in Python 3, this is the default behavior.
2768
2769         * lldb/lldb_webkit.py:
2770         (WebCoreLayoutUnitProvider.to_string):
2771
2772 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2773
2774         build.webkit.org/dashboard should display information about patches in EWS
2775         https://bugs.webkit.org/show_bug.cgi?id=127006
2776
2777         Reviewed by Ryosuke Niwa.
2778
2779         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2780         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
2781         (Bugzilla.prototype.detailsURLForAttachment):
2782         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
2783         which is needed when one wants to do something with a patch EWS is stuck on.
2784
2785         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2786         Create a Bugzilla instance.
2787
2788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2789         (EWS.prototype.jsonQueueLengthURL):
2790         (EWS.prototype.jsonQueueStatusURL):
2791         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
2792
2793         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2794         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
2795         of second guessing.
2796         (EWSQueue.prototype.get chartsPageURL): Added.
2797         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
2798         additional data already loaded (it's reset with every update).
2799         (EWSQueue.prototype.get patches): Get patch queue.
2800         (EWSQueue.prototype.get bots): Get bots.
2801         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
2802         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
2803
2804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2805         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
2806         in the queue.
2807         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
2808         (EWSQueueView.prototype.addTextToRow): Ditto.
2809         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
2810         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
2811         (EWSQueueView.prototype._addDividerToPopover): Ditto.
2812         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
2813         relative string.
2814         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
2815         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
2816         it when done.
2817
2818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2819         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
2820         Changed a few difficult to read padding styles to padding-left.
2821
2822 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2823
2824         Fix webkitpy tests.
2825
2826         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
2827         Added a mock implementation, as we now call this function.
2828
2829 2014-01-20  Darin Adler  <darin@apple.com>
2830
2831         Update style checker and tests to deal with override instead of OVERRIDE
2832         https://bugs.webkit.org/show_bug.cgi?id=127175
2833
2834         Reviewed by Anders Carlsson.
2835
2836         * Scripts/webkitpy/style/checkers/cpp.py:
2837         (check_braces): Use override instead of OVERRIDE.
2838         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2839         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
2840
2841 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2842
2843         EWS should provide better information to Dashboard via JSON
2844         https://bugs.webkit.org/show_bug.cgi?id=127265
2845
2846         Reviewed by Ryosuke Niwa.
2847
2848         * QueueStatusServer/app.yaml: Updated version.
2849
2850         * QueueStatusServer/main.py:
2851         * QueueStatusServer/handlers/queuelengthjson.py:
2852         Added a way to cheaply get only the queue length, which is all the dashboard
2853         needs unless a popover is opened.
2854
2855         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
2856         that we will need. Changed some field names to be more meaningful. Fixed bot listing
2857         to understand that a bot can be reprurposed and used in a different queue.
2858
2859 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2860
2861         Make uploading results to EWS work despite robots.txt
2862         https://bugs.webkit.org/show_bug.cgi?id=127296
2863
2864         Reviewed by Ryosuke Niwa.
2865
2866         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
2867         checking robots.txt.
2868
2869         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
2870         Removed a comment saying that we would want to stop doing this. Not checking
2871         robots.txt is more efficient than checking it.
2872
2873 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
2874
2875         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
2876         https://bugs.webkit.org/show_bug.cgi?id=127214
2877
2878         Reviewed by Gyuyoung Kim.
2879
2880         Followed the changes of API.
2881
2882         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2883         (drtViewAdd):
2884         * EWebLauncher/main.c:
2885         (windowCreate):
2886
2887 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
2888
2889         [EFL][WK2] Add touch events option to MiniBrowser.
2890         https://bugs.webkit.org/show_bug.cgi?id=127262
2891
2892         Reviewed by Gyuyoung Kim.
2893
2894         As a default, touch events are disabled and mouse events are enabled.
2895         If touch events option sets to true, touch events are enabled and mouse
2896         events are disabled.
2897
2898         * MiniBrowser/efl/main.c:
2899         (window_create):
2900         (elm_main):
2901
2902 2014-01-19  Zalan Bujtas  <zalan@apple.com>
2903
2904         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
2905         https://bugs.webkit.org/show_bug.cgi?id=126080
2906
2907         Reviewed by Sam Weinig.
2908
2909         This changes the output of printing LayoutUnits to be in px but it also
2910         preserves the original LayoutUnit value.
2911
2912         This will lead to lldb output like: (and it works even when subpixel is disabled)
2913
2914         (const WebCore::LayoutRect) $0 = {
2915             m_location = { x = 2.25px (144), y = 1px (64)}
2916             m_size = { width = 13.75px (880), height = 20px (1280) }
2917
2918
2919         And gdb output like:
2920
2921         m_frameRect = {
2922             m_location = LayoutPoint(0px (0), 0px(0)),
2923             m_size = LayoutSize(8px (512), 5px (320))
2924         }
2925
2926         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
2927
2928         * gdb/webkit.py:
2929         (WebCoreLayoutUnitPrinter):
2930         (WebCoreLayoutUnitPrinter.__init__):
2931         (WebCoreLayoutUnitPrinter.to_string):
2932         (WebCoreLayoutSizePrinter):
2933         (WebCoreLayoutSizePrinter.__init__):
2934         (WebCoreLayoutSizePrinter.to_string):
2935         (WebCoreLayoutPointPrinter):
2936         (WebCoreLayoutPointPrinter.__init__):
2937         (WebCoreLayoutPointPrinter.to_string):
2938         (add_pretty_printers):
2939         * lldb/lldb_webkit.py:
2940         (__lldb_init_module):
2941         (WebCoreLayoutUnit_SummaryProvider):
2942         (WebCoreLayoutSize_SummaryProvider):
2943         (WebCoreLayoutPoint_SummaryProvider):
2944         (WebCoreLayoutUnitProvider):
2945         (WebCoreLayoutUnitProvider.__init__):
2946         (WebCoreLayoutUnitProvider.to_string):
2947         (WebCoreLayoutSizeProvider):
2948         (WebCoreLayoutSizeProvider.__init__):
2949         (WebCoreLayoutSizeProvider.get_width):
2950         (WebCoreLayoutSizeProvider.get_height):
2951         (WebCoreLayoutPointProvider):
2952         (WebCoreLayoutPointProvider.__init__):
2953         (WebCoreLayoutPointProvider.get_x):
2954         (WebCoreLayoutPointProvider.get_y):
2955
2956 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2957
2958         Add robots.txt to http://webkit-queues.appspot.com
2959         https://bugs.webkit.org/show_bug.cgi?id=127240
2960
2961         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
2962
2963 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2964
2965         Add robots.txt to http://webkit-queues.appspot.com
2966         https://bugs.webkit.org/show_bug.cgi?id=127240
2967
2968         Reviewed by Ryosuke Niwa.
2969
2970         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
2971
2972         * QueueStatusServer/robots.txt: Added.
2973
2974 2014-01-18  Alberto Garcia  <berto@igalia.com>
2975
2976         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
2977         https://bugs.webkit.org/show_bug.cgi?id=127217
2978
2979         Reviewed by Daniel Bates.
2980
2981         The syntax File::Temp->tempdir() was explicitly made invalid
2982         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
2983         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
2984
2985         Use File::Temp::tempdir() instead.
2986
2987         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2988
2989 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2990
2991         build.webkit.org/dashboard should have image diff links in test results popovers
2992         https://bugs.webkit.org/show_bug.cgi?id=127188
2993
2994         Reviewed by Timothy Hatcher.
2995
2996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2997         (Buildbot.prototype.layoutTestImagesURLForIteration):
2998         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
2999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3000         (BuildbotIteration.prototype.loadLayoutTestResults):
3001         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3002         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
3003         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
3004         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
3005
3006 2014-01-18  Anders Carlsson  <andersca@apple.com>
3007
3008         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
3009         https://bugs.webkit.org/show_bug.cgi?id=127225
3010
3011         Reviewed by Andreas Kling.
3012
3013         This concludes the removal of over 8.8 million lines of threaded parser code.
3014
3015         * Scripts/webkitperl/FeatureList.pm:
3016
3017 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
3018
3019         build.webkit.org/dashboard should have diff links in test results popovers
3020         https://bugs.webkit.org/show_bug.cgi?id=126986
3021
3022         Reviewed by Tim Horton.
3023
3024         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3025         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
3026         (Buildbot.prototype.layoutTestStderrURLForIteration):
3027         (Buildbot.prototype.layoutTestDiffURLForIteration):
3028         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
3029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3030         (BuildbotIteration.prototype.loadLayoutTestResults):
3031         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3032         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
3033
3034 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
3035
3036         Add the bare minimum support for branches to the bot-watchers dashboard
3037         https://bugs.webkit.org/show_bug.cgi?id=127124
3038
3039         This patch simply introduces the notion of branches into the bot-watchers dashboard.
3040         Subsequent patches will build functionality on top of this simple bit of infrastructure.
3041
3042         Reviewed by Timothy Hatcher.
3043
3044         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3045         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
3046         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3047         Initialize the Dashboard.Branch object
3048
3049 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
3050
3051         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
3052         https://bugs.webkit.org/show_bug.cgi?id=127141
3053
3054         Reviewed by Alexey Proskuryakov.
3055
3056         Make sure to reset the notification handler each time.
3057
3058         * DumpRenderTree/AccessibilityController.cpp:
3059         (AccessibilityController::resetToConsistentState):
3060         * DumpRenderTree/AccessibilityController.h:
3061         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3062         (AccessibilityController::platformResetToConsistentState):
3063         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3064         (AccessibilityController::platformResetToConsistentState):
3065         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3066         (AccessibilityController::~AccessibilityController):
3067         (AccessibilityController::platformResetToConsistentState):
3068         (AccessibilityController::removeNotificationListener):
3069         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3070         (AccessibilityController::platformResetToConsistentState):
3071
3072 2014-01-17  Alberto Garcia  <berto@igalia.com>
3073
3074         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
3075         https://bugs.webkit.org/show_bug.cgi?id=82329
3076
3077         Reviewed by Carlos Garcia Campos.
3078
3079         Unskip, this is working fine now.
3080
3081         * Scripts/run-gtk-tests:
3082         (TestRunner):
3083
3084 2014-01-17  Alberto Garcia  <berto@igalia.com>
3085
3086         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
3087         https://bugs.webkit.org/show_bug.cgi?id=82328
3088
3089         Reviewed by Carlos Garcia Campos.
3090
3091         This was caused by the icon database being corrupted in the
3092         Release bot. After removing it the test works fine so it can be
3093         run again.
3094
3095         * Scripts/run-gtk-tests:
3096         (TestRunner):
3097
3098 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
3099
3100         Test results popovers at http://build.webkit.org/dashboard should link to stderr
3101         https://bugs.webkit.org/show_bug.cgi?id=126929
3102
3103         Reviewed by Timothy Hatcher.
3104
3105         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3106         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
3107         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
3108
3109         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3110         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
3111
3112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3113         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
3114         Add a link to stderr output if present.
3115
3116         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3117         (.test-results-popover .additional-link): Style with light grey (will use the same style
3118         for diff links).
3119
3120 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
3121
3122         Automate DoYouEvenBench
3123         https://bugs.webkit.org/show_bug.cgi?id=124497
3124
3125         Reviewed by Geoffrey Garen.
3126
3127         * Scripts/webkitpy/performance_tests/perftest.py:
3128         (PerfTestMetric.__init__): Added the aggregator name as an argument.
3129         (PerfTestMetric.aggregator): Added.
3130         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
3131         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
3132         should be parsed as the metric and the aggregator respectively.
3133         (PerfTest._run_with_driver): Pass in the aggregator name.
3134         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
3135         which generates subtests of subtests within a single test file.
3136
3137         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3138         (test_parse_output_with_subtests_and_total): Added.
3139
3140         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3141         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
3142
3143         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3144         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
3145
3146 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
3147
3148         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
3149         https://bugs.webkit.org/show_bug.cgi?id=127141
3150
3151         Reviewed by Alexey Proskuryakov.
3152
3153         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
3154
3155         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3156         (AccessibilityController::~AccessibilityController):
3157
3158 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
3159
3160         EWS shouldn't comment on Bugzilla for failing builds or style errors
3161         https://bugs.webkit.org/show_bug.cgi?id=127079
3162
3163         Reviewed by Anders Carlsson.
3164
3165         Since patch authors and reviewers could retrieve this information from bubbles,
3166         we shouldn't spam the Bugzilla with useless comments.
3167
3168         We still post style errors but not python paths we used since it's a pure noise.
3169
3170         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3171         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
3172         * Scripts/webkitpy/tool/commands/queues.py:
3173         (StyleQueue.review_patch):
3174
3175 2014-01-15  Roger Fong  <roger_fong@apple.com>
3176
3177         Add support for handling WebGL load policies.
3178         https://bugs.webkit.org/show_bug.cgi?id=126935
3179         <rdar://problem/15790448>.
3180
3181         Reviewed by Timothy Horton.
3182
3183         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
3184         (WTR::TestController::createWebViewWithOptions):
3185
3186 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3187
3188         Remove workaround for compilers not supporting explicit override control
3189         https://bugs.webkit.org/show_bug.cgi?id=127111
3190
3191         Reviewed by Anders Carlsson.
3192
3193         Now all compilers support explicit override control, this workaround can be removed.
3194
3195         * DumpRenderTree/gtk/fonts/fonts.conf:
3196         * Scripts/do-webcore-rename:
3197         Removed this rename operation from the list of contemplated future renames.
3198         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
3199         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
3200         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
3201         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
3202         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3203
3204 2014-01-16  Oliver Hunt  <oliver@apple.com>
3205
3206         Stop run-jsc from consuming stderr output
3207         https://bugs.webkit.org/show_bug.cgi?id=127115
3208
3209         Reviewed by Mark Lam.
3210
3211         Simple patch to make run-jsc easier to deal with
3212
3213         * Scripts/run-jsc:
3214
3215 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
3216
3217         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
3218         https://bugs.webkit.org/show_bug.cgi?id=126323
3219
3220         Reviewed by Csaba Osztrogonác.
3221
3222         * gtk/generate-feature-defines-files:
3223
3224 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3225
3226         [EFL][WK2] Implement TestController::setHidden
3227         https://bugs.webkit.org/show_bug.cgi?id=127036
3228
3229         Reviewed by Gyuyoung Kim.
3230
3231         WebKitTestRunner needs TestController::setHidden implementation to
3232         properly handle page visibility API layout tests after r161105.
3233
3234         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3235         (WTR::TestController::setHidden):
3236
3237 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
3238
3239         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
3240         https://bugs.webkit.org/show_bug.cgi?id=127083
3241
3242         Reviewed by Carlos Garcia Campos.
3243
3244         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
3245         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
3246
3247         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
3248         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
3249         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
3250         BrowserWindow object is being finalized, preventing the callback from firing.
3251
3252         * MiniBrowser/gtk/BrowserWindow.c:
3253         (resetEntryProgress):
3254         (webViewLoadProgressChanged):
3255         (browserWindowFinalize):
3256
3257 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
3258
3259         DumpRenderTree doesn't disable web preferences autosave
3260         https://bugs.webkit.org/show_bug.cgi?id=127062
3261
3262         Reviewed by Dan Bernstein.
3263
3264         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
3265         Do it.
3266
3267 2014-01-15  Dean Jackson  <dino@apple.com>
3268
3269         Improve filter-build-webkit, especially for iOS builds
3270         https://bugs.webkit.org/show_bug.cgi?id=81046
3271
3272         Reviewed by Joseph Pecoraro.
3273
3274         Lots of updates to the filtering rules, mostly from the
3275         iOS build output. Other highlights include:
3276         - ignoring escape sequences for color ouput
3277         - detecting escaped spaces in file name regexps
3278
3279         * Scripts/filter-build-webkit:
3280         (shouldIgnoreLine):
3281
3282 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3283
3284         [GTK] Web process sometimes crashes when printing in synchronous mode
3285         https://bugs.webkit.org/show_bug.cgi?id=126979
3286
3287         Reviewed by Gustavo Noronha Silva.
3288
3289         * Scripts/run-gtk-tests:
3290         (TestRunner): Unskip
3291         /webkit2/WebKitPrintOperation/close-after-print.
3292
3293 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
3294
3295         [EFL] Change test font installed path to webkitgtk-font-tests
3296         https://bugs.webkit.org/show_bug.cgi?id=126723
3297
3298         Reviewed by Gyuyoung Kim.
3299
3300         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
3301         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
3302         hard-coded in FontManagement.cpp#105
3303
3304         * DumpRenderTree/PlatformEfl.cmake:
3305         * WebKitTestRunner/PlatformEfl.cmake:
3306         * efl/jhbuild.modules:
3307
3308 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
3309
3310         Make DoYouEvenBench runnable by run-perf-tests
3311         https://bugs.webkit.org/show_bug.cgi?id=127030
3312
3313         Reviewed by Andreas Kling.
3314
3315         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
3316         ":Total" to appear at the end of a test name. We don't do anything with it for now.
3317
3318         * Scripts/webkitpy/performance_tests/perftest.py:
3319         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
3320         to the JSON in a follow up patch for the perf dashboard.
3321         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
3322
3323 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3324
3325         [GTK] UI process crashes when the web process crashes while printing
3326         https://bugs.webkit.org/show_bug.cgi?id=126977
3327
3328         Reviewed by Gustavo Noronha Silva.
3329
3330         Add new test case to check that closing the window right after
3331         printing works. It's skipped for now, because this patch only
3332         fixes the UI process crash, but not the web process one.
3333
3334         * Scripts/run-gtk-tests:
3335         (TestRunner): Skip
3336         /webkit2/WebKitPrintOperation/close-after-print.
3337         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
3338         (testPrintOperationPrintPrinter):
3339         (findPrintToFilePrinter):
3340         (testPrintOperationPrint):
3341         (testPrintOperationErrors):
3342         (testPrintOperationCloseAfterPrint):
3343         (beforeAll):
3344
3345 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
3346
3347         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
3348         https://bugs.webkit.org/show_bug.cgi?id=127002
3349
3350         Reviewed by David Kilzer.
3351
3352         * Scripts/webkitdirs.pm:
3353         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
3354
3355 2014-01-14  Commit Queue  <commit-queue@webkit.org>
3356
3357         Unreviewed, rolling out r162000.
3358         http://trac.webkit.org/changeset/162000
3359         https://bugs.webkit.org/show_bug.cgi?id=127009
3360
3361         API versioning is wrong (Requested by rfong on #webkit).
3362
3363         * MiniBrowser/mac/WK2BrowserWindowController.m:
3364         (-[WK2BrowserWindowController awakeFromNib]):
3365         * WebKitTestRunner/TestController.cpp:
3366         (WTR::TestController::createOtherPage):
3367         (WTR::TestController::createWebViewWithOptions):
3368
3369 2014-01-13  Roger Fong  <roger_fong@apple.com>
3370
3371         Add support for handling WebGL load policies.
3372         https://bugs.webkit.org/show_bug.cgi?id=126935
3373         <rdar://problem/15790448>.
3374
3375         Reviewed by Brent Fulgham.
3376
3377         * MiniBrowser/mac/WK2BrowserWindowController.m:
3378         (-[WK2BrowserWindowController awakeFromNib]):
3379         * WebKitTestRunner/TestController.cpp:
3380         (WTR::TestController::createWebViewWithOptions):
3381
3382 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
3383
3384         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
3385         https://bugs.webkit.org/show_bug.cgi?id=120110
3386
3387         Reviewed by Martin Robinson.
3388
3389         Skip the FontConfig settings initialization in WebKitTestRunner if the
3390         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
3391         This is useful when profiling the WebKitTestRunner execution, where at the startup
3392         this step takes considerable amount of time and disturbs the profiling output.
3393
3394         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3395         (WTR::initializeFontConfigSetting):
3396
3397 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
3398
3399         Add ENABLE(WEB_REPLAY) feature flag to the build system
3400         https://bugs.webkit.org/show_bug.cgi?id=126949
3401
3402         Reviewed by Joseph Pecoraro.
3403
3404         * Scripts/webkitperl/FeatureList.pm:
3405
3406 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
3407
3408         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
3409         https://bugs.webkit.org/show_bug.cgi?id=126702
3410
3411         Reviewed by Alexey Proskuryakov.
3412
3413         Resolve regression and remove a FIXME comment that is already fixed.
3414
3415         * Scripts/webkitpy/common/system/filesystem.py:
3416         (FileSystem.open_text_file_for_reading):
3417         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3418         (RealFileSystemTest.test_read_and_write_file):
3419         * Scripts/webkitpy/style/filereader.py:
3420         (TextFileReader._read_lines):
3421         * Scripts/webkitpy/style/filereader_unittest.py:
3422         (TextFileReaderTest.test_count_delete_only_file):
3423         (TextFileReaderTest):
3424         (TextFileReaderTest.test_process_malformed_file):
3425
3426 2014-01-02  Brian Holt  <brian.holt@samsung.com>
3427
3428         [GTK] Parse Valgrind xml leak files
3429         https://bugs.webkit.org/show_bug.cgi?id=119446
3430
3431         Reviewed by Alejandro G. Castro.
3432
3433         Parse the xml files generated by Valgrind to yield useful
3434         information about the memory leaks.
3435
3436         * Scripts/webkitpy/port/gtk.py:
3437         (GtkPort.__init__):
3438         (GtkPort.setup_test_run): Clear the previous output files before new
3439         run.
3440         (GtkPort.print_leaks_summary):
3441
3442         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
3443         Parse the xml files generated by Valgrind and summarise leaks
3444         into an easily understandable list.
3445         (get_text_of):
3446         (get_CDATA_of):
3447         (gather_frames):
3448         (ValgrindError):
3449         (ValgrindError.__init__):
3450         (ValgrindError.__str__):
3451         (ValgrindError.unique_string):
3452         (ValgrindError.error_hash):
3453         (ValgrindError.__hash__):
3454         (ValgrindError.__eq__):
3455         (LeakDetectorValgrind):
3456         (LeakDetectorValgrind.__init__):
3457         (LeakDetectorValgrind._parse_leaks_output):
3458         (LeakDetectorValgrind.leaks_files_in_results_directory):
3459         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
3460         (LeakDetectorValgrind.parse_and_print_leaks_detail):
3461
3462         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
3463         (make_mock_valgrind_output):
3464         (make_mock_incomplete_valgrind_output):
3465         (make_mock_valgrind_results):
3466         (make_mock_valgrind_results_incomplete):
3467         (make_mock_valgrind_results_empty):
3468         (make_mock_valgrind_results_misformatted):
3469         (mock_run_cppfilt_command):
3470         (LeakDetectorValgrindTest):
3471         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
3472         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
3473         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
3474         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
3475         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
3476         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
3477         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
3478         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
3479
3480 2014-01-13  Lucas Forschler  <lforschler@apple.com>
3481
3482         Update the LLINT CLoop Bot build infrastructure
3483         https://bugs.webkit.org/show_bug.cgi?id=126604
3484         
3485         Unreviewed.
3486         
3487         * BuildSlaveSupport/build.webkit.org-config/config.json:
3488         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3489         (CompileLLINTCLoop):
3490         (RunLLINTCLoopTests):
3491         (BuildAndTestLLINTCLoopFactory):
3492         (BuildAndTestLLINTCLoopFactory.__init__):
3493
3494 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
3495
3496         [EFL][WK2] Disable failing API tests
3497         https://bugs.webkit.org/show_bug.cgi?id=126960
3498
3499         Reviewed by Gyuyoung Kim.
3500
3501         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
3502
3503         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
3504         (TestWebKitAPI::TEST):
3505
3506 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
3507
3508         Remove wdiff
3509         https://bugs.webkit.org/show_bug.cgi?id=124766
3510
3511         Reviewed by Ryosuke Niwa.
3512
3513         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3514         (ResultsJSONParserTest):
3515         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3516         (TestResultWriter):
3517         (TestResultWriter.create_text_diff_and_write_result):
3518         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3519         (summarize_results):
3520         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3521         (RunTest.test_output_diffs):
3522         * Scripts/webkitpy/port/base.py:
3523         (Port.__init__):
3524         (Port.driver_stop_timeout):
3525         (Port.check_image_diff):
3526         (Port.repository_paths):
3527         (Port._path_to_lighttpd_php):
3528         * Scripts/webkitpy/port/base_unittest.py:
3529         (PortTest.test_default_child_processes):
3530         (PortTest.test_pretty_patch_script_error):
3531         * Scripts/webkitpy/port/port_testcase.py:
3532         (PortTestCase.test_diff_image_crashed):
3533         * Scripts/webkitpy/port/test.py:
3534         (TestPort.operating_system):
3535
3536 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
3537
3538         Build fix for the GTK+ CMake port
3539
3540         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
3541
3542 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
3543
3544         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
3545         https://bugs.webkit.org/show_bug.cgi?id=126881
3546
3547         Reviewed by Carlos Garcia Campos.
3548
3549         * MiniBrowser/gtk/BrowserWindow.c:
3550         (browser_window_new):
3551         Explicitly cast GtkWindow** to gpointer* in call to
3552         g_object_add_weak_pointer to avoid compiler warnings.
3553
3554 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3555
3556         Remove parsing of old-run-webkit-tests output from master.cfg
3557         https://bugs.webkit.org/show_bug.cgi?id=126690
3558
3559         Reviewed by Csaba Osztrogonác.
3560
3561         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3562         Removed parsing of ORWT output, as it is not used anymore.
3563         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3564         Updated unit tests accordingly.
3565
3566 2014-01-13  Commit Queue  <commit-queue@webkit.org>
3567
3568         Unreviewed, rolling out r161808.
3569         http://trac.webkit.org/changeset/161808
3570         https://bugs.webkit.org/show_bug.cgi?id=126874
3571
3572         This patch make several files to be always regenerated on
3573         every make (Requested by KaL on #webkit).
3574
3575         * WebKitTestRunner/GNUmakefile.am:
3576
3577 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
3578
3579         [GTK] Make MiniBrowser windows non-transient by default
3580         https://bugs.webkit.org/show_bug.cgi?id=126840
3581
3582         Reviewed by Carlos Garcia Campos.
3583
3584         Instead of making new browser windows transient as soon as they are
3585         created, save the pointer to the parent window and set the transient
3586         state later on when handling the "run-as-modal" signal. This makes
3587         it easier to use the MiniBrowser to do tests involving multiple
3588         windows, and will be useful as well when multi-web-process mode is
3589         enabled for the GTK port.
3590
3591         * MiniBrowser/gtk/BrowserWindow.c:
3592         (webViewRunAsModal): Set the parent window using
3593         gtk_window_set_transient_for() using the saved parent
3594         window.
3595         (browser_window_new): Save the parent window using
3596         g_object_set_data() instead of making the new window
3597         transient immediately.
3598
3599 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
3600
3601         [EFL][WK2] Make API tests work again
3602         https://bugs.webkit.org/show_bug.cgi?id=126769
3603
3604         Reviewed by Gyuyoung Kim.
3605
3606         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
3607         [E]WebKit2, respectively, and this causes problems because the logic to find
3608         where WebProcess is to look in the same directory of the running process and
3609         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
3610
3611         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
3612         Gtk port, which allows us to look for WebProcess initially in this directory,
3613         if it's defined.
3614
3615         * TestWebKitAPI/efl/main.cpp:
3616         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
3617
3618 2014-01-12  Daniel Bates  <dabates@apple.com>
3619
3620         [iOS] Fix the build
3621
3622         For now, ensure we