d70a96416682754925703a1d5216e384af62fc85
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
2
3         [Qt] Allow to use WebCore imagedecoders
4         https://bugs.webkit.org/show_bug.cgi?id=32410
5
6         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
7
8         Reviewed by Simon Hausmann.
9
10         * qmake/mkspecs/features/features.prf:
11
12 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
13
14         [Qt] Add Qt5 way to force 96 DPI for tests
15         https://bugs.webkit.org/show_bug.cgi?id=79364
16
17         Reviewed by Simon Hausmann.
18
19         * DumpRenderTree/qt/main.cpp:
20         (main):
21         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
22         (WTR::activateFonts):
23
24 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
25
26         [GTK] MiniBrowser should reload the view then the reload button is clicked
27         https://bugs.webkit.org/show_bug.cgi?id=79472
28
29         Reviewed by Philippe Normand.
30
31         * MiniBrowser/gtk/BrowserWindow.c:
32         (reloadCallback): Call webkit_web_view_reload().
33         (browser_window_init): Connect reload item clicked even to
34         reloadCallback instead of activateUriEntryCallback.
35
36 2012-02-24  Kentaro Hara  <haraken@chromium.org>
37
38         Add performance tests for DOM attribute getters and setters
39         https://bugs.webkit.org/show_bug.cgi?id=79208
40
41         Reviewed by Ryosuke Niwa.
42
43         We want to allow perf tests to output info messages
44         that do not affect the test results. To accomplish this,
45         this patch modifies perftestsrunner.py so that it ignores
46         a line that starts from "Info:".
47
48         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
49         (PerfTestsRunner):
50
51 2012-02-24  Andrew Lo  <anlo@rim.com>
52
53         [BlackBerry] Enable requestAnimationFrame
54         https://bugs.webkit.org/show_bug.cgi?id=79408
55
56         Enable requestAnimationFrame for BlackBerry.
57
58         Reviewed by Rob Buis.
59
60         * Scripts/build-webkit:
61
62 2012-02-24  Adam Barth  <abarth@webkit.org>
63
64         style-queue tries to apply the patch twice
65         https://bugs.webkit.org/show_bug.cgi?id=79459
66
67         Reviewed by Eric Seidel.
68
69         Previously, we applied the patch using both apply-patch and
70         check-style.  This patch introduces a check-style-local to mirror the
71         apply-watchlist-local, which operates on the current working diff.
72
73         This patch also cleans up some other bugs I found by running the queue
74         locally for a while.  The queue still prints out a slightly
75         less-than-ideal message on the bugs when it find an error, but it's ok
76         for now.  We'll need to iterate a bit.
77
78         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
79         (StyleQueueTask.validate):
80         (StyleQueueTask._check_style):
81         * Scripts/webkitpy/tool/commands/download.py:
82         (CheckStyleLocal):
83         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
84         (EarlyWarningSytemTest._default_expected_stderr):
85         (EarlyWarningSytemTest._test_testing_ews):
86         * Scripts/webkitpy/tool/commands/queues.py:
87         (AbstractReviewQueue.handle_script_error):
88         (StyleQueue.review_patch):
89         * Scripts/webkitpy/tool/commands/queues_unittest.py:
90         * Scripts/webkitpy/tool/commands/queuestest.py:
91         (QueuesTest.assert_queue_outputs):
92
93 2012-02-23  Adam Barth  <abarth@webkit.org>
94
95         should_proceed_with_work_item is unused and can be removed
96         https://bugs.webkit.org/show_bug.cgi?id=79416
97
98         Reviewed by Eric Seidel.
99
100         We used to use this function to check whether the tree is red.  Now, we
101         don't use external measures of whether to proceed with work items.
102         Instead, we analyze them with the idea in mind that the tree might be
103         red.
104
105         * Scripts/webkitpy/tool/bot/queueengine.py:
106         (QueueEngineDelegate.next_work_item):
107         (QueueEngine.run):
108         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
109         (LoggingDelegate):
110         (LoggingDelegate.next_work_item):
111         (RaisingDelegate.process_work_item):
112         (QueueEngineTest.test_terminating_error):
113         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
114         (AbstractEarlyWarningSystem.__init__):
115         * Scripts/webkitpy/tool/commands/queues.py:
116         (AbstractQueue.next_work_item):
117         (FeederQueue.next_work_item):
118         (CommitQueue.next_work_item):
119         (AbstractReviewQueue.next_work_item):
120         (StyleQueue.__init__):
121         * Scripts/webkitpy/tool/commands/queues_unittest.py:
122         (FeederQueueTest.test_feeder_queue):
123         (CommitQueueTest.test_commit_queue):
124         (test_commit_queue_failure):
125         (test_commit_queue_failure_with_failing_tests):
126         (test_rollout):
127         (test_rollout_lands):
128         (StyleQueueTest.test_style_queue_with_style_exception):
129         (test_style_queue_with_watch_list_exception):
130         * Scripts/webkitpy/tool/commands/queuestest.py:
131         (QueuesTest.assert_queue_outputs):
132         * Scripts/webkitpy/tool/commands/sheriffbot.py:
133         (SheriffBot.next_work_item):
134
135 2012-02-23  Adrienne Walker  <enne@google.com>
136
137         Unreviewed, add Stephen Chenney to committers.py as a contributor.
138
139         * Scripts/webkitpy/common/config/committers.py:
140
141 2012-02-23  Adam Barth  <abarth@webkit.org>
142
143         style-queue logs bogus messages to the QueueStatusServer
144         https://bugs.webkit.org/show_bug.cgi?id=79424
145
146         Reviewed by Eric Seidel.
147
148         Copy/paste error.
149
150         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
151         (StyleQueueTask._check_style):
152         (StyleQueueTask._apply_watch_list):
153         * Scripts/webkitpy/tool/commands/queues_unittest.py:
154
155 2012-02-23  Eric Seidel  <eric@webkit.org>
156
157         Use self._filesystem in more places in the SCM classes
158         https://bugs.webkit.org/show_bug.cgi?id=79415
159
160         Reviewed by Adam Barth.
161
162         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
163         (SCMDetectorTest.test_detect_scm_system):
164         * Scripts/webkitpy/common/checkout/scm/git.py:
165         (Git.find_checkout_root):
166         (Git.to_object_name):
167         * Scripts/webkitpy/common/checkout/scm/scm.py:
168         (SCM.__init__):
169         (SCM.in_working_directory):
170         * Scripts/webkitpy/common/checkout/scm/svn.py:
171         (SVN.find_uuid):
172         (SVN.find_checkout_root):
173
174 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
175
176         Unreviewed, rolling out r108685.
177         http://trac.webkit.org/changeset/108685
178         https://bugs.webkit.org/show_bug.cgi?id=79414
179
180         Broke Chromium builds (Requested by enne on #webkit).
181
182         * qmake/mkspecs/features/features.prf:
183
184 2012-02-23  Adam Barth  <abarth@webkit.org>
185
186         style-queue shouldn't spam bugs if it fails to update its working copy
187         https://bugs.webkit.org/show_bug.cgi?id=79412
188
189         Reviewed by Eric Seidel.
190
191         This patch moves style-queue over to the new PatchAnalysisTask
192         infrastructure, which is smarter about retrying patches when update
193         fails.
194
195         * Scripts/webkitpy/common/system/executive_mock.py:
196         (MockExecutive.run_and_throw_if_fail):
197         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
198         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
199         (UnableToApplyPatch):
200         (UnableToApplyPatch.__init__):
201         (PatchAnalysisTask.__init__):
202         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
203         (StyleQueueTaskDelegate):
204         (StyleQueueTaskDelegate.parent_command):
205         (StyleQueueTask):
206         (StyleQueueTask.validate):
207         (StyleQueueTask._check_style):
208         (StyleQueueTask._apply_watch_list):
209         (StyleQueueTask.run):
210         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
211         * Scripts/webkitpy/tool/commands/queues.py:
212         (StyleQueue):
213         (StyleQueue.should_proceed_with_work_item):
214         (StyleQueue.review_patch):
215         (StyleQueue.run_command):
216         (StyleQueue.command_passed):
217         (StyleQueue.command_failed):
218         (StyleQueue.expected_failures):
219         (StyleQueue.refetch_patch):
220         * Scripts/webkitpy/tool/commands/queues_unittest.py:
221         (StyleQueueTest.test_style_queue_with_style_exception):
222         (test_style_queue_with_watch_list_exception):
223
224 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
225
226         [Qt] Allow to use WebCore imagedecoders
227         https://bugs.webkit.org/show_bug.cgi?id=32410
228
229         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
230
231         Reviewed by Simon Hausmann.
232
233         * qmake/mkspecs/features/features.prf:
234
235 2012-02-23  Eric Seidel  <eric@webkit.org>
236
237         Remove old broken find_checkout_root tests now that find_checkout_root is gone
238         https://bugs.webkit.org/show_bug.cgi?id=79405
239
240         Reviewed by Adam Barth.
241
242         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
243         (SCMDetectorTest):
244         (SCMDetectorTest.test_find_checkout_root):
245         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
246         (SVNTestRepository.tear_down):
247
248 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
249
250         [Qt][WK2] Implement proxy authentication dialog.
251         https://bugs.webkit.org/show_bug.cgi?id=79350
252
253         Reviewed by Simon Hausmann.
254
255         * MiniBrowser/qt/MiniBrowser.qrc:
256         * MiniBrowser/qt/qml/BrowserWindow.qml:
257         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
258
259 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
260
261         [wx] Build fix, add recently added source dirs.
262
263         * waf/build/settings.py:
264
265 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
266
267         [Qt] Add support for touch cancellation
268         https://bugs.webkit.org/show_bug.cgi?id=79348
269
270         Reviewed by Kenneth Rohde Christiansen.
271
272         Added straight-forward touch cancellation event sending to Qt WK1 DRT
273         and WK2 WTR.
274
275         * DumpRenderTree/qt/EventSenderQt.cpp:
276         (EventSender::touchCancel):
277         (EventSender::cancelTouchPoint):
278         * DumpRenderTree/qt/EventSenderQt.h:
279         (EventSender):
280         * WebKitTestRunner/EventSenderProxy.h:
281         (EventSenderProxy):
282         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
283         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
284         (WTR::EventSendingController::touchCancel):
285         (WTR):
286         (WTR::EventSendingController::cancelTouchPoint):
287         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
288         (EventSendingController):
289         * WebKitTestRunner/TestController.cpp:
290         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
291         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
292         (WTR::EventSenderProxy::touchCancel):
293         (WTR):
294         (WTR::EventSenderProxy::cancelTouchPoint):
295
296 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
297
298         Unreviewed, rolling out r108626.
299         http://trac.webkit.org/changeset/108626
300         https://bugs.webkit.org/show_bug.cgi?id=79370
301
302         broke qt-wk2 bot, somehow the workaround does not work on the
303         bot (Requested by Ossy on #webkit).
304
305         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
306         (WTR::WrapperWindow::handleStatusChanged):
307         (WTR::PlatformWebView::resizeTo):
308
309 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
310
311         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
312         https://bugs.webkit.org/show_bug.cgi?id=78481
313
314         Reviewed by Gustavo Noronha Silva.
315
316         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
317         to create gdk press key event.
318         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
319         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
320
321         * DumpRenderTree/gtk/EventSender.cpp:
322         (scheduleAsynchronousClickCallback):
323         (createKeyPressEvent):
324         (sendKeyDown):
325         (keyDownCallback):
326         (sendAsynchronousKeyDown):
327         (scheduleAsynchronousKeyDownCallback):
328
329 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
330
331         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
332         https://bugs.webkit.org/show_bug.cgi?id=76546
333
334         Reviewed by Simon Hausmann.
335
336         Co-authored with Simon Hausmann.
337
338         Revert the workaround introduced in r107868 and reintroduce
339         the qml binding so we can test the code path that we are more
340         interested in. The reason that it did not work before is that
341         we don't have an active platform window which we now workaround
342         by propagating the resize through QWindowSystemInterface.
343
344         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
345         (WTR::WrapperWindow::handleStatusChanged):
346         (WTR::PlatformWebView::resizeTo):
347
348 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
349
350         Unreviewed, rolling out r108577.
351         http://trac.webkit.org/changeset/108577
352         https://bugs.webkit.org/show_bug.cgi?id=79359
353
354         It doesn't work as expected (Requested by Ossy on #webkit).
355
356         * DumpRenderTree/qt/EventSenderQt.cpp:
357         (EventSender::postEvent):
358         * DumpRenderTree/qt/EventSenderQt.h:
359         (EventSender):
360
361 2012-02-23  Philippe Normand  <pnormand@igalia.com>
362
363         [GTK] FullScreen signals
364         https://bugs.webkit.org/show_bug.cgi?id=76181
365
366         Reviewed by Martin Robinson.
367
368         Use the two new entering/leaving fullscreen signals to hide/show
369         the tool bar, the status bar and ask the user's permission before
370         entering fullscreen.
371
372         * GtkLauncher/main.c:
373         (webViewFullscreenMessageWindowClose):
374         (webViewWindowStateEvent):
375         (hide_widget):
376         (show_widget):
377         (webViewEnteringFullScreen):
378         (webViewLeavingFullScreen):
379         (createBrowser):
380         (createWindow):
381
382 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
383
384         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
385         https://bugs.webkit.org/show_bug.cgi?id=79076
386
387         Reviewed by Andreas Kling.
388
389         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
390         (builtDylibPathForName):
391
392 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
393
394         [Qt] Add eventSender.gestureTap
395         https://bugs.webkit.org/show_bug.cgi?id=66173
396
397         Reviewed by Kenneth Rohde Christiansen.
398
399         * DumpRenderTree/qt/EventSenderQt.cpp:
400         (EventSender::gestureTap):
401         * DumpRenderTree/qt/EventSenderQt.h:
402
403 2012-02-22  Brady Eidson  <beidson@apple.com>
404
405         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
406         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
407
408         Reviewed by Anders Carlsson.
409
410         Update our tools to the new form of the PageLoadClient.
411
412         * MiniBrowser/mac/BrowserWindowController.m:
413         (-[BrowserWindowController awakeFromNib]): 
414
415         * WebKitTestRunner/TestController.cpp:
416         (WTR::TestController::initialize):
417
418 2012-02-22  Daniel Bates  <dbates@webkit.org>
419
420         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
421         https://bugs.webkit.org/show_bug.cgi?id=79277
422
423         Reviewed by Adam Barth.
424
425         Pass command line argument no-saved-state to run-safari to disable Safari
426         state restoration for the session on OS 10.7.
427
428         * Scripts/webkitpy/layout_tests/port/mac.py:
429         (MacPort.show_results_html_file):
430         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
431         (test_show_results_html_file):
432
433 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
434
435         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
436         https://bugs.webkit.org/show_bug.cgi?id=77759
437
438         Reviewed by Tony Chang.
439
440         Fixes build with gcc 4.7.
441
442         r100432 added the include only for ANDROID; this changes the ifdef to
443         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
444         longer implicitly includes unistd.h from standard headers and other
445         unix platforms are likely to get gcc 4.7 as well in the future.
446
447         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
448
449 2012-02-22  Philippe Normand  <pnormand@igalia.com>
450
451         Unreviewed, rolling out r108522.
452         http://trac.webkit.org/changeset/108522
453         https://bugs.webkit.org/show_bug.cgi?id=76181
454
455         Broke 4 fullscreen tests on GTK.
456
457         * GtkLauncher/main.c:
458         (createBrowser):
459         (createWindow):
460
461 2012-02-20  Philippe Normand  <pnormand@igalia.com>
462
463         [GTK] FullScreen signals
464         https://bugs.webkit.org/show_bug.cgi?id=76181
465
466         Reviewed by Martin Robinson.
467
468         Use the two new entering/leaving fullscreen signals to hide/show
469         the tool bar, the status bar and ask the user's permission before
470         entering fullscreen.
471
472         * GtkLauncher/main.c:
473         (webViewFullscreenMessageWindowClose):
474         (webViewWindowStateEvent):
475         (hide_widget):
476         (show_widget):
477         (webViewEnteringFullScreen):
478         (webViewLeavingFullScreen):
479         (createBrowser):
480         (createWindow):
481
482 2012-02-22  Rob Flack  <flackr@chromium.org>
483
484         Update Linux ChromiumOS builders in flakiness dashboard.
485         https://bugs.webkit.org/show_bug.cgi?id=79238
486
487         Reviewed by Ojan Vafai.
488
489         * TestResultServer/static-dashboards/builders.js:
490
491 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
492
493         webkitpy: test_function_length_check_definition_huge_lines is slow
494         https://bugs.webkit.org/show_bug.cgi?id=79185
495
496         Reviewed by Adam Barth.
497
498         This test takes ~3 seconds to run, apparently because we're
499         running a test on a 10,000 line function :). Dropping the
500         function length to 640 still exercises the code path and
501         provides a 10x speedup.
502
503         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
504         (CppStyleTest):
505         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
506
507 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
508
509         webkitpy: speed up FileLockTest.test_lock_lifecycle
510         https://bugs.webkit.org/show_bug.cgi?id=79189
511
512         Reviewed by Adam Barth.
513
514         The unit test had a second lock trying to acquire a
515         lock already held, and a hard-coded timeout of one second.
516         I have changed the timeouts to a tenth of a second (which
517         is probably still fine) and changed the hard-spin on
518         the lock to a slow-spin every hundredth of a second.
519
520         * Scripts/webkitpy/common/system/file_lock.py:
521         (FileLock.acquire_lock):
522         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
523         (FileLockTest.setUp):
524         (FileLockTest.test_stuck_lock):
525
526 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
527
528         build-webkit should use environment variable at number of CPU
529         detection on all platform
530         https://bugs.webkit.org/show_bug.cgi?id=79227
531
532         Reviewed by Martin Robinson.
533
534         * Scripts/webkitdirs.pm:
535         (determineNumberOfCPUs):
536
537 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
538
539         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
540         https://bugs.webkit.org/show_bug.cgi?id=78960
541
542         Reviewed by Csaba Osztrogonác.
543
544         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
545         (LayoutTestController::overridePreference):
546
547 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
548
549         [chromium] Build WebKit with MEDIA_STREAM disabled.
550         https://bugs.webkit.org/show_bug.cgi?id=79214
551
552         Reviewed by Kent Tamura.
553
554         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
555         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
556         * DumpRenderTree/chromium/WebViewHost.cpp:
557         (WebViewHost::createMediaPlayer):
558         * DumpRenderTree/chromium/WebViewHost.h:
559         (WebViewHost):
560
561 2012-02-22  Zeno Albisser  <zeno@webkit.org>
562
563         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
564         https://bugs.webkit.org/show_bug.cgi?id=79124
565
566         WebKitTestRunnerPrefix.h should also be included
567         when building with clang.
568
569         Reviewed by Kenneth Rohde Christiansen.
570
571         * WebKitTestRunner/Target.pri:
572
573 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
574
575         <style scoped>: Add runtime-flag
576         https://bugs.webkit.org/show_bug.cgi?id=79074
577
578         Enable the runtime-flag for DRT. 
579
580         Reviewed by Dimitri Glazkov.
581
582         * DumpRenderTree/chromium/TestShell.cpp:
583         (TestShell::TestShell):
584
585 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
586
587         Unreviewed, rolling out r107351.
588         http://trac.webkit.org/changeset/107351
589         https://bugs.webkit.org/show_bug.cgi?id=53600
590
591         Several issues introduced in WebKitGTK+ API
592
593         * DumpRenderTree/gtk/DumpRenderTree.cpp:
594         (createWebView):
595         * GtkLauncher/main.c:
596         (createWebViewCb):
597         (createBrowser):
598         (createWindow):
599         (main):
600
601 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
602
603         JSC should be a triple-tier VM
604         https://bugs.webkit.org/show_bug.cgi?id=75812
605         <rdar://problem/10079694>
606
607         Reviewed by Gavin Barraclough.
608
609         Changed EFL's build system to include a new directory in JavaScriptCore.
610
611         * DumpRenderTree/efl/CMakeLists.txt:
612
613 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
614
615         [chromium] Fix image drag out on Chromium
616         https://bugs.webkit.org/show_bug.cgi?id=79158
617
618         Reviewed by Tony Chang.
619
620         * DumpRenderTree/chromium/EventSender.cpp:
621         (EventSender::dumpFilenameBeingDragged):
622         (EventSender::beginDragWithFiles):
623         * DumpRenderTree/chromium/WebViewHost.cpp:
624         (addDRTFakeFileToDataObject):
625
626 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
627
628         webkitpy: speed up hot filesystem_mock functions
629         https://bugs.webkit.org/show_bug.cgi?id=79159
630
631         Reviewed by Adam Barth.
632
633         Profiling run_webkit_tests_integrationtest.py revealed that
634         isdir(), normpath(), and join() are called a lot and were very
635         slow.This patch speeds them up substantially, shaving 20 seconds
636         off of the execution time.
637
638         * Scripts/webkitpy/common/system/filesystem_mock.py:
639         (MockFileSystem.isdir):
640         (MockFileSystem._slow_but_correct_join):
641         (MockFileSystem.join):
642         (MockFileSystem.listdir):
643         (MockFileSystem._slow_but_correct_normpath):
644         (MockFileSystem.normpath):
645         (MockFileSystem.write_binary_file):
646         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
647         (MockFileSystemTest.quick_check):
648         (MockFileSystemTest):
649         (MockFileSystemTest.test_join):
650         (MockFileSystemTest.test_normpath):
651         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
652         (get_test_config): Call write_binary_file() instead of updating
653           filesystem.files directly, so that we create directories as
654           needed.
655
656 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
657
658         nrwt: make the delay between starting workers configurable per-port
659         https://bugs.webkit.org/show_bug.cgi?id=79148
660
661         Reviewed by Eric Seidel.
662
663         Because of bug 79147, we have to sleep a bit in between starting
664         DRTs; however, doing so across the board slows down the Test
665         port. Making this configurable shaves 10 seconds off of
666         run_webkit_tests_integrationtest.py
667         
668         * Scripts/webkitpy/layout_tests/controllers/manager.py:
669         (Manager._run_tests):
670         * Scripts/webkitpy/layout_tests/port/base.py:
671         (Port.worker_startup_delay_secs):
672         * Scripts/webkitpy/layout_tests/port/test.py:
673         (TestPort.worker_startup_delay_secs):
674
675 2012-02-21  Jon Lee  <jonlee@apple.com>
676
677         Bring notifications support to WK1 mac
678         https://bugs.webkit.org/show_bug.cgi?id=78783
679         <rdar://problem/10610578>
680
681         Reviewed by Anders Carlsson.
682
683         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
684         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
685         (-[UIDelegate timerFired]):
686
687 2012-02-21  Kentaro Hara  <haraken@chromium.org>
688
689         Enable the IDL attribute checker in run-bindings-tests
690         https://bugs.webkit.org/show_bug.cgi?id=79091
691
692         Reviewed by Adam Barth.
693
694         We have enabled the IDL attribute checker in Chromium in r108322.
695         This patch enables the IDL attribute checker in run-bindings-tests.
696
697         No tests. I manually checked that [Custommm], [CallWith=],
698         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
699         run-bindings-tests failures.
700
701         * Scripts/webkitpy/bindings/main.py:
702         (BindingsTests.generate_supplemental_dependency):
703
704 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
705
706         Add rafaelw as a committer.
707
708         Unreviewed.
709
710         * Scripts/webkitpy/common/config/committers.py:
711
712 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
713
714         webkitpy: update names after deleting message_broker
715         https://bugs.webkit.org/show_bug.cgi?id=79000
716
717         Reviewed by Eric Seidel.
718
719         Part 3 of 3 in deleting message_broker.py; this change just
720         adjusts the names for the newly merged symbols so that they are
721         private as appropriate.
722
723         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
724         (get):
725         (_Broker):
726         (_BrokerConnection):
727         (_BrokerConnection.__init__):
728         (AbstractWorker.__init__):
729         (_ManagerConnection):
730         (_ManagerConnection.__init__):
731         (_WorkerConnection):
732         (_WorkerConnection.__init__):
733
734 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
735
736         webkitpy: merge message_broker.py into manager_worker_broker.py
737         https://bugs.webkit.org/show_bug.cgi?id=78999
738
739         Reviewed by Tony Chang.
740
741         This is pretty much a straight cut-and-paste of one file into
742         another (broken up so that docstrings and imports are in the
743         right place).
744
745         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
746         (BrokerClient):
747         (BrokerClient.is_done):
748         (BrokerClient.name):
749         (Broker):
750         (Broker.__init__):
751         (Broker.add_topic):
752         (Broker._get_queue_for_topic):
753         (Broker.post_message):
754         (Broker.run_message_loop):
755         (Broker.run_all_pending):
756         (Broker._run_loop):
757         (Broker._dispatch_message):
758         (_Message):
759         (_Message.loads):
760         (_Message.__init__):
761         (_Message.dumps):
762         (_Message.__repr__):
763         (BrokerConnection):
764         (BrokerConnection.__init__):
765         (BrokerConnection.run_message_loop):
766         (BrokerConnection.post_message):
767         (BrokerConnection.raise_exception):
768         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
769
770 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
771
772         webkitpy: prepare to delete message_broker.py
773         https://bugs.webkit.org/show_bug.cgi?id=78997
774
775         Reviewed by Eric Seidel.
776
777         This is part 1 of 3 changes to fix bug 78187. This change
778         prepares the code for merging message_broker.py into
779         manager_worker_broker.py; the tests in message_broker_unittest
780         are merged into manager_worker_broker_unittest, the symbols
781         needed by the tests are exported from manager_worker_broker.py,
782         and manager_worker_broker itself is updated to refer to the
783         symbols directly (without the module prefix).
784
785         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
786         (get):
787         (AbstractWorker):
788         (AbstractWorker.__init__):
789         (_ManagerConnection):
790         (_ManagerConnection.__init__):
791         (_WorkerConnection):
792         (_WorkerConnection.__init__):
793         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
794         (InterfaceTest.test_brokerclient_is_abstract):
795         (InterfaceTest.test_brokerclient_is_abstract.methods):
796         (MessageTest):
797         (MessageTest.test__no_body):
798         (MessageTest.test__body):
799         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
800
801 2012-02-21  Sam Weinig  <sam@webkit.org>
802
803         Attempt to fix the Snow Leopard build.
804
805         * DumpRenderTree/mac/Configurations/Base.xcconfig:
806         * MiniBrowser/Configurations/Base.xcconfig:
807         * TestWebKitAPI/Configurations/Base.xcconfig:
808         * WebKitTestRunner/Configurations/Base.xcconfig:
809
810 2012-02-21  Sam Weinig  <sam@webkit.org>
811
812         Use libc++ when building with Clang on Mac
813         https://bugs.webkit.org/show_bug.cgi?id=78981
814
815         Reviewed by Dan Bernstein.
816
817         * DumpRenderTree/mac/Configurations/Base.xcconfig:
818         * MiniBrowser/Configurations/Base.xcconfig:
819         * TestWebKitAPI/Configurations/Base.xcconfig:
820         * WebKitTestRunner/Configurations/Base.xcconfig:
821
822 2012-02-21  Adam Roben  <aroben@apple.com>
823
824         Roll out r108309, r108323, and r108326
825
826         They broke the 32-bit Lion build.
827
828         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
829
830         * DumpRenderTree/efl/CMakeLists.txt:
831
832 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
833
834         [Qt][WK2] Get rid of the dependency to QtWidgets
835         https://bugs.webkit.org/show_bug.cgi?id=76276
836
837         Reviewed by Simon Hausmann.
838
839         * MiniBrowser/qt/MiniBrowser.pro:
840         * MiniBrowser/qt/MiniBrowserApplication.cpp:
841         (MiniBrowserApplication::MiniBrowserApplication):
842         (MiniBrowserApplication::notify):
843         (MiniBrowserApplication::sendTouchEvent):
844         * MiniBrowser/qt/MiniBrowserApplication.h:
845         (MiniBrowserApplication):
846         * QtTestBrowser/locationedit.h:
847         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
848         (WTR::activateFonts):
849         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
850
851 2012-02-20  Adam Barth  <abarth@webkit.org>
852
853         mastercfg_unittest.py fails without simplejson
854         https://bugs.webkit.org/show_bug.cgi?id=79070
855
856         Reviewed by Csaba Osztrogonác.
857
858         Now that we require Python 2.6 (and higher) we can import json rather
859         than simplejson.  We still need to use the simplejson name because
860         that's what the master.cfg script expects.
861
862         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
863         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
864
865 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
866
867         JSC should be a triple-tier VM
868         https://bugs.webkit.org/show_bug.cgi?id=75812
869         <rdar://problem/10079694>
870
871         Reviewed by Gavin Barraclough.
872
873         Changed EFL's build system to include a new directory in JavaScriptCore.
874
875         * DumpRenderTree/efl/CMakeLists.txt:
876
877 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
878
879         Update pywebsocket to 0.7.2
880         https://bugs.webkit.org/show_bug.cgi?id=79066
881
882         This version includes vendor-prefixed deflate-frame extension support.
883
884         Reviewed by Kent Tamura.
885
886         * Scripts/webkitpy/thirdparty/__init__.py:
887         (AutoinstallImportHook._install_pywebsocket):
888
889 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
890
891         [UNIX] Plugin information fields are not interpreted as UTF-8
892         https://bugs.webkit.org/show_bug.cgi?id=78635
893
894         Reviewed by Gustavo Noronha Silva.
895
896         Interpret plugin metadata as UTF8 aways. This matches the behavior
897         of Chromium and the Totem plugin.
898
899         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
900         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
901
902 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
903
904         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
905         https://bugs.webkit.org/show_bug.cgi?id=78935
906
907         Reviewed by Gustavo Noronha Silva.
908
909         Move the TestNetscapePlugin headers to a more appropriate directory and update
910         the build files to match.
911
912         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
913         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
914         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
915         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
916         * GNUmakefile.am: Ditto.
917
918 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
919
920         Add a new API for the Vibration API(W3C).
921         https://bugs.webkit.org/show_bug.cgi?id=72010
922
923         Reviewed by Hajime Morita.
924
925         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
926
927 2012-02-20  János Badics  <dicska@gmail.com>
928
929         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
930         https://bugs.webkit.org/show_bug.cgi?id=71816
931
932         RunQtAPITests will notify if a timeout occurs during testing.
933         Added unittest to the master.cfg
934
935         Reviewed by Csaba Osztrogonác.
936
937         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
938         (RunQtAPITests.evaluateCommand):
939         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
940         (RunQtAPITestsTest):
941         (RunQtAPITestsTest.assertResults):
942         (RunQtAPITestsTest.test_timeout):
943         (test_success):
944         (test_failure):
945         (test_timeout_and_failure):
946
947 2012-02-20  Andy Wingo  <wingo@igalia.com>
948
949         Add wingo as a committer.
950
951         Unreviewed.
952
953         * Scripts/webkitpy/common/config/committers.py: Add myself to the
954         committers list.
955
956 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
957
958         [chromium] check that we're not running multiple modal dialogs at the same time
959         https://bugs.webkit.org/show_bug.cgi?id=78486
960
961         Reviewed by Kent Tamura.
962
963         * DumpRenderTree/chromium/TestShell.cpp:
964         (TestShell::TestShell):
965         * DumpRenderTree/chromium/TestShell.h:
966         (TestShell::setIsDisplayingModalDialog):
967         (TestShell::isDisplayingModalDialog):
968         (TestShell):
969         * DumpRenderTree/chromium/WebViewHost.cpp:
970         (WebViewHost::runModal):
971
972 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
973
974         Fix WebKit2GTK+ for 'make distcheck'.
975
976         Instead of conditionally including WebKit2 GNUmakefiles, always
977         include them and conditionally activate the final targets.
978
979         * MiniBrowser/gtk/GNUmakefile.am:
980         * WebKitTestRunner/GNUmakefile.am:
981
982 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
983
984         Enable video option for EFL port in build-webkit.
985         https://bugs.webkit.org/show_bug.cgi?id=79006
986
987         Reviewed by Daniel Bates.
988
989         * Scripts/build-webkit:
990
991 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
992
993         [EFL] Use modifier keys to execute pre-rendering.
994         https://bugs.webkit.org/show_bug.cgi?id=77933
995
996         Reviewed by Chang Shu.
997
998         Use modifier key to execute pre-rendering instead of using reserved function keys.
999
1000         * EWebLauncher/main.c:
1001         (on_key_down):
1002
1003 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1004
1005         Fix one more dangling reference to worker_connection.name, delete unused code.
1006
1007         Unreviewed, build fix.
1008
1009         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1010         (Manager.update):
1011         (_WorkerState.__init__):
1012
1013 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1014
1015         Add a change that should've been in r108005.
1016
1017         Unreviewed, build fix.
1018
1019         In the refactoring/cleanup in r108005 I should've changed the
1020         implementation of WorkerConnection to make it match BrokerClient
1021         (and everything else) so that objects had a name() method
1022         instead of a name property.
1023
1024         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1025         (Manager._run_tests):
1026         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1027         (_WorkerConnection.__init__):
1028         (_WorkerConnection.name):
1029         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1030         (_TestWorker.__init__):
1031         (_TestsMixin.name):
1032         (_TestsMixin.test_name):
1033         (_TestsMixin.test_cancel):
1034         (_TestsMixin.test_unknown_message):
1035
1036 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1037
1038         webkitpy: remove webkitpy.common.array_stream
1039         https://bugs.webkit.org/show_bug.cgi?id=78952
1040
1041         Reviewed by Eric Seidel.
1042
1043         Turns out array_stream didn't really do anything that StringIO
1044         didn't do (at least as of Python 2.6). This change removes it
1045         and updates all of the callers. Where possible, I changed the
1046         test assertions in order to capture the intent more clearly,
1047         e.g., instead of calling self.assertTrue('foo' in stream.get()),
1048         we have self.assertContainsLine(stream, 'foo'), and instead of
1049         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
1050         the latter isn't that much more readable, but StringIO doesn't
1051         export an empty() method.
1052
1053         * Scripts/webkitpy/common/array_stream.py: Removed.
1054         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
1055         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1056         (passing_run):
1057         (run_and_capture):
1058         (StreamTestingMixin):
1059         (StreamTestingMixin.assertContains):
1060         (StreamTestingMixin.assertContainsLine):
1061         (StreamTestingMixin.assertEmpty):
1062         (StreamTestingMixin.assertNotEmpty):
1063         (LintTest):
1064         (LintTest.test_lint_test_files):
1065         (LintTest.test_lint_test_files__errors):
1066         (MainTest):
1067         (MainTest.test_child_process_1):
1068         (MainTest.test_child_processes_2):
1069         (MainTest.test_child_processes_min):
1070         (MainTest.test_help_printing):
1071         (MainTest.test_hung_thread):
1072         (MainTest.test_no_tests_found):
1073         (MainTest.test_no_tests_found_2):
1074         (MainTest.test_repeat_each_iterations_num_tests):
1075         (MainTest.test_test_list):
1076         (MainTest.test_unexpected_failures):
1077         (MainTest.test_worker_model__inline_with_child_processes):
1078         (MainTest.test_additional_platform_directory):
1079         (RebaselineTest):
1080         (RebaselineTest.assertBaselines):
1081         (RebaselineTest.test_reset_results):
1082         (RebaselineTest.test_missing_results):
1083         (RebaselineTest.test_new_baseline):
1084         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1085         (MeteredStream.update):
1086         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1087         (TestMeteredStream.test_regular):
1088         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1089         (TestUtilityFunctions.assertEmpty):
1090         (TestUtilityFunctions):
1091         (TestUtilityFunctions.assertNotEmpty):
1092         (TestUtilityFunctions.assertWritten):
1093         (TestUtilityFunctions.test_configure_logging):
1094         (Testprinter.assertEmpty):
1095         (Testprinter):
1096         (Testprinter.assertNotEmpty):
1097         (Testprinter.assertWritten):
1098         (Testprinter.reset):
1099         (Testprinter.get_printer):
1100         (Testprinter.test_help_printer):
1101         (Testprinter.do_switch_tests.do_helper):
1102         (Testprinter.test_print_one_line_summary):
1103         (Testprinter.test_print_test_result):
1104         (Testprinter.test_print_progress):
1105         (Testprinter.test_write_nothing):
1106         (Testprinter.test_write_misc):
1107         (Testprinter.test_write_everything):
1108         (Testprinter.test_write_verbose):
1109         (Testprinter.test_print_unexpected_results):
1110         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1111         (MainTest.assertWritten):
1112         (create_runner):
1113         (test_run_test_set):
1114         (test_run_test_set_kills_drt_per_run):
1115         (test_run_test_set_for_parser_tests):
1116         (test_run_test_set_with_json_output):
1117         (test_run_test_set_with_json_source):
1118         (test_run_test_set_with_multiple_repositories):
1119         (test_upload_json):
1120
1121 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
1122
1123         [wx] Add the WebCore/page/scrolling directory to the build dirs.
1124
1125         * waf/build/settings.py:
1126
1127 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
1128
1129         [wx] Unreviewed build fix. Don't error out or hang if we have
1130         downloaded dependencies but server update check fails.
1131
1132         * waf/build/build_utils.py:
1133         (download_if_newer):
1134
1135 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1136
1137         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
1138         https://bugs.webkit.org/show_bug.cgi?id=69444
1139
1140         Reviewed by Tony Chang.
1141
1142         Currently if a test's image checksum doesn't match the checksum
1143         in the baseline, but the images themselves match according to
1144         ImageDiff, new-run-webkit-tests ignores the problem. This is
1145         probably bad, but it's not yet clear what the right thing to do
1146         is. This patch will log a warning to stderr, at least (but the
1147         test will still pass).
1148
1149         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1150         (SingleTestRunner._compare_image):
1151         (SingleTestRunner._run_reftest):
1152         * Scripts/webkitpy/layout_tests/port/test.py:
1153         (unit_test_list):
1154         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1155
1156 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1157
1158         NRWT does not report failure for a skipped test
1159         https://bugs.webkit.org/show_bug.cgi?id=78750
1160
1161         Reviewed by Eric Seidel.
1162
1163         If a test is listed in a Skipped file and you run it anyway
1164         with --force, and the test fails, currently NRWT will print
1165         "test ran as expected"; this is confusing, because you probably
1166         expect the test to fail and yet this might lead you to think the
1167         test passed. This patch changes the expected behavior to "PASS",
1168         so tests that fail will be reported.
1169
1170         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1171         (result_was_expected):
1172         (TestExpectationParser):
1173         (TestExpectationParser.expectation_for_skipped_test):
1174         (TestExpectations):
1175         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1176         (test_add_skipped_tests):
1177         * Scripts/webkitpy/layout_tests/port/test.py:
1178         (unit_test_list): Add some tests that are expected to be in a Skipped file.
1179         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
1180
1181 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1182
1183         webkitpy: fix test code after bug 78181
1184         https://bugs.webkit.org/show_bug.cgi?id=78870
1185
1186         Reviewed by Adam Barth.
1187
1188         I forgot to update the test code as per Tony's suggestion in
1189         bug 78181 (r108005). This change does that, and in doing so
1190         it revealed a subtle bug in _InlineWorkerConnection.run() that
1191         I am fixing as part of this (_alive would not be cleared if an
1192         exception was thrown).
1193
1194         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1195         (_InlineWorkerConnection.run):
1196         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1197         (_TestWorker.__init__):
1198         (_TestWorker.handle_stop):
1199         (_TestWorker.handle_test):
1200         (_TestWorker.run):
1201         (_TestsMixin.handle_exception):
1202         (_TestsMixin.test_unknown_message):
1203
1204 2012-02-17  Adam Roben  <aroben@apple.com>
1205
1206         Mac build fix after r108119
1207
1208         * DumpRenderTree/mac/DumpRenderTree.mm:
1209         (runThread):
1210         (runPthread):
1211         (testThreadIdentifierMap):
1212         Updated to match current WTF threading APIs.
1213
1214 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1215
1216         revert r107147 - breaks webkit-patch on Mac SL
1217         https://bugs.webkit.org/show_bug.cgi?id=78866
1218
1219         Reviewed by Adam Barth.
1220
1221         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
1222         which is the version that ships on Mac SL. Reverting this
1223         change until we no longer have to worry about that version.
1224
1225         * Scripts/webkitpy/common/system/autoinstall.py:
1226         (AutoInstaller):
1227         (AutoInstaller._extract_all): Added a comment about SL.
1228         (AutoInstaller._unzip):
1229
1230 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
1231
1232         CSS regions enabled by default
1233         https://bugs.webkit.org/show_bug.cgi?id=78525
1234
1235         Reviewed by David Hyatt.
1236
1237         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
1238         CSSRegions are still enabled by default.
1239         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
1240
1241         * DumpRenderTree/chromium/LayoutTestController.cpp:
1242         (LayoutTestController::overridePreference):
1243         * DumpRenderTree/chromium/WebPreferences.cpp:
1244         (WebPreferences::reset):
1245         (WebPreferences::applyTo):
1246         * DumpRenderTree/chromium/WebPreferences.h:
1247         (WebPreferences):
1248         * DumpRenderTree/mac/DumpRenderTree.mm:
1249         (resetDefaultsToConsistentValues):
1250
1251 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
1252
1253         Some API tests erroneously use = instead of == (causing build failures)
1254         https://bugs.webkit.org/show_bug.cgi?id=78915
1255
1256         Reviewed by Sam Weinig.
1257
1258         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1259         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
1260         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
1261
1262 2012-02-17  Peter Beverloo  <peter@chromium.org>
1263
1264         [Chromium] Include TestShellLinux.cpp in the build for Android
1265         https://bugs.webkit.org/show_bug.cgi?id=78865
1266
1267         Reviewed by Eric Seidel.
1268
1269         Android will be re-using the TestShellLinux.cpp file. I already
1270         added this r104033, but it seems to have gotten lost in the
1271         recent refactorings.
1272
1273         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1274
1275 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1276
1277         Unreviewed, disable video build on EFL until it can be
1278         supported by EFL build bot.
1279
1280         * Scripts/build-webkit:
1281
1282 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1283
1284         [GTK] Implement zoom in/out in MiniBrowser
1285         https://bugs.webkit.org/show_bug.cgi?id=75253
1286
1287         Reviewed by Gustavo Noronha Silva.
1288
1289         * MiniBrowser/gtk/BrowserWindow.c:
1290         (browserWindowCanZoomIn):
1291         (browserWindowCanZoomOut):
1292         (browserWindowUpdateZoomActions):
1293         (webViewZoomLevelChanged):
1294         (zoomInCallback):
1295         (zoomOutCallback):
1296         (browser_window_init):
1297         (browserWindowConstructed):
1298
1299 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
1300
1301         layoutTestController.display() is flaky for SVG tests
1302         https://bugs.webkit.org/show_bug.cgi?id=78021
1303
1304         Reviewed by Adam Roben.
1305
1306         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
1307         Size the web view before running the test, not when dumping.
1308         All platforms handle this correctly now.
1309
1310         * DumpRenderTree/win/DumpRenderTree.cpp:
1311         (dump):
1312         (sizeWebViewForCurrentTest):
1313         (runTest):
1314
1315 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1316
1317         [GTK] Make install is broken when building without --enable-gtk-doc
1318         https://bugs.webkit.org/show_bug.cgi?id=78828
1319
1320         Reviewed by Martin Robinson.
1321
1322         * gtk/generate-gtkdoc:
1323         (rebase_installed_docs): Check documentation has been generated
1324         before trying to rebase it.
1325
1326 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
1327
1328         nrwt: simplify worker interface
1329         https://bugs.webkit.org/show_bug.cgi?id=78181
1330
1331         Reviewed by Tony Chang.
1332
1333         This change moves code in name(), is_done(), run(), and cancel()
1334         from Worker to AbstractWorker, since the logic is pretty much
1335         boilerplate code that any implementation would want to use.
1336
1337         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1338         (get.should):
1339         (AbstractWorker.__init__):
1340         (AbstractWorker):
1341         (AbstractWorker.name):
1342         (AbstractWorker.stop_handling_messages):
1343         (AbstractWorker.run):
1344         (AbstractWorker.is_done):
1345         (AbstractWorker.cancel):
1346         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1347         (Worker.__init__):
1348         (Worker.run):
1349         (Worker.handle_stop):
1350
1351 2012-02-16  Michael Saboff  <msaboff@apple.com>
1352
1353         ENH: Add ability to run subset of JavaScript layout tests with JSC
1354         https://bugs.webkit.org/show_bug.cgi?id=78764
1355
1356         Reviewed by Gavin Barraclough.
1357
1358         New simple test drive shell script that runs a defined
1359         list of javascript tests using jsc and the standalone-{pre,post}.js
1360         wrappers.
1361
1362         * Scripts/run-fast-jsc: Added.
1363
1364 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
1365
1366         Add new Qt performance tester bot to build.webkit.org
1367         https://bugs.webkit.org/show_bug.cgi?id=78795
1368
1369         Reviewed by Adam Roben.
1370
1371         * BuildSlaveSupport/build.webkit.org-config/config.json:
1372
1373 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
1374
1375         Disable inspector on WinCE.
1376
1377         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
1378
1379         * Scripts/build-webkit:
1380
1381 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
1382
1383         WinCE build fix after r107656.
1384
1385         Disable FTPDIR on WinCE, since it does not compile there.
1386
1387         * Scripts/build-webkit:
1388
1389 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
1390
1391         Build fix after r107863.
1392
1393         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1394
1395 2012-02-15  Tony Chang  <tony@chromium.org>
1396
1397         [chromium] add linux dbg back to garden-o-matic
1398         https://bugs.webkit.org/show_bug.cgi?id=78752
1399
1400         Reviewed by Adam Barth.
1401
1402         This reflects the current linux debug bot name (there's only one bot).
1403         I'm also remove the mac clang builder since it doesn't exist (mac
1404         always uses clang now).
1405
1406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1407         * Scripts/webkitpy/layout_tests/port/builders.py:
1408
1409 2012-02-15  Sam Weinig  <sam@webkit.org>
1410
1411         Add style check for ctype functions that are generally frowned upon in WebKit
1412         https://bugs.webkit.org/show_bug.cgi?id=78748
1413
1414         Reviewed by Anders Carlsson.
1415
1416         Not every platform has DisallowCType.h to check for uses of the ctype.h
1417         functions, so add a style check for them as well.
1418
1419         * Scripts/webkitpy/style/checkers/cpp.py:
1420         (check_ctype_functions):
1421         (check_style):
1422         (CppChecker):
1423         Add check.
1424
1425         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1426         (WebKitStyleTest.test_ctype_fucntion):
1427         Add checker.
1428
1429 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
1430
1431         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
1432         https://bugs.webkit.org/show_bug.cgi?id=76546
1433
1434         Reviewed by Simon Hausmann.
1435
1436         Resize the web view programatically because the declarative property binding
1437         does not work. Seems like our qml environment is not initialized fully but it
1438         needs more investigation.
1439
1440         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1441         (WTR::WrapperWindow::handleStatusChanged):
1442         (WTR::PlatformWebView::resizeTo):
1443
1444 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
1445
1446         webkitpy: add a worker_args concept to start_worker()
1447         https://bugs.webkit.org/show_bug.cgi?id=78572
1448
1449         Reviewed by Tony Chang.
1450
1451         This change replaces the three NRWT-specific arguments passed
1452         through the broker to the worker with a generic WorkerArguments
1453         wrapper class and a separate set_inline_arguments() call that can
1454         be used to pass additional data to the worker when it is running
1455         in the same process as the manager (this is needed for testing).
1456         With the addition of set_inline_arguments() we also no longer
1457         need to pass an optional argument to the worker.run() call.
1458
1459         Note that this method is *only* implemented on inline workers,
1460         so calling this on a regular (child process) worker will result
1461         in a runtime error.
1462
1463         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1464         (Manager._run_tests):
1465         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1466         (AbstractWorker.__init__):
1467         (AbstractWorker.run):
1468         (_ManagerConnection.start_worker):
1469         (_InlineManager.start_worker):
1470         (_InlineManager.set_inline_arguments):
1471         (_InlineManager.run_message_loop):
1472         (_MultiProcessManager.start_worker): Reworked signature.
1473         (_WorkerConnection.__init__):
1474         (_InlineWorkerConnection.__init__):
1475         (_InlineWorkerConnection.set_inline_arguments): New method.
1476         (_InlineWorkerConnection):
1477         (_InlineWorkerConnection.run):
1478         (_Process.run):
1479         (_MultiProcessWorkerConnection.__init__):
1480         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1481         (_TestWorker.__init__):
1482         (_TestWorker.set_inline_arguments):
1483         (_TestWorker.handle_test):
1484         (_TestWorker.run):
1485         (_TestsMixin.test_cancel):
1486         (_TestsMixin.test_done):
1487         (_TestsMixin.test_unknown_message):
1488         (InlineBrokerTests): New class for more testing.
1489         (InlineBrokerTests.setUp):
1490         (InlineBrokerTests.test_inline_arguments): New test.
1491         (InterfaceTest.test_managerconnection_is_abstract):
1492         (InterfaceTest.test_workerconnection_is_abstract):
1493         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1494         (WorkerArguments):
1495         (WorkerArguments.__init__):
1496         (Worker.__init__):
1497         (Worker.set_inline_arguments):
1498         (Worker):
1499         (Worker.run):
1500         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
1501         (WorkerTest.test_default_platform_in_worker):
1502
1503 2012-02-15  Adam Klein  <adamk@chromium.org>
1504
1505         Unreviewed, rolling out r107704.
1506         http://trac.webkit.org/changeset/107704
1507         https://bugs.webkit.org/show_bug.cgi?id=78486
1508
1509         Caused layout test crashes in debug builds.
1510
1511         Specific crashing tests:
1512
1513         fast/events/show-modal-dialog-onblur-onfocus.html
1514         fast/harness/show-modal-dialog.html
1515         inspector/console/console-long-eval-crash.html
1516
1517         * DumpRenderTree/chromium/TestShell.cpp:
1518         (TestShell::TestShell):
1519         * DumpRenderTree/chromium/TestShell.h:
1520         (TestShell):
1521         * DumpRenderTree/chromium/WebViewHost.cpp:
1522         (WebViewHost::runModal):
1523
1524 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
1525
1526         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
1527         https://bugs.webkit.org/show_bug.cgi?id=76347
1528
1529         Reviewed by Kenneth Rohde Christiansen.
1530
1531         * MiniBrowser/qt/MiniBrowser.qrc:
1532         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
1533         * MiniBrowser/qt/qml/BrowserWindow.qml:
1534         * MiniBrowser/qt/qml/DialogLineInput.qml:
1535
1536 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
1537
1538         [Qt] Fix WebGL in QtTestBrowser
1539
1540         Reviewed by Tor Arne Vestbø.
1541
1542         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
1543         the options for enabling GL we also pass them on properly.
1544
1545 2012-02-14  Sam Weinig  <sam@webkit.org>
1546
1547         Add #include of unistd.h on the mac for getcwd. 
1548
1549         Reviewed by Anders Carlsson.
1550
1551         This is necessary when building with libc++.
1552
1553         * WebKitTestRunner/TestInvocation.cpp:
1554
1555 2012-02-14  Sam Weinig  <sam@webkit.org>
1556
1557         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
1558         https://bugs.webkit.org/show_bug.cgi?id=78663
1559
1560         Reviewed by Anders Carlsson.
1561
1562         * DumpRenderTree/DumpRenderTreePrefix.h:
1563         * DumpRenderTree/cg/ImageDiffCG.cpp:
1564
1565 2012-02-14  Adam Barth  <abarth@webkit.org>
1566
1567         Implement an adb-based driver for the ChromiumAndroidPort
1568         https://bugs.webkit.org/show_bug.cgi?id=78627
1569
1570         Reviewed by Eric Seidel.
1571
1572         This driver mostly just wires up the ChromiumDriver through adb.  In
1573         some cases, it translates protocol elements, such as URIs, so that the
1574         rest of webkitpy is insulated from the "remoteness" of the target device.
1575
1576         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1577         (ChromiumAndroidPort.start_helper):
1578         (ChromiumAndroidPort._driver_class):
1579         (ChromiumAndroidPort._update_version):
1580         (ChromiumAndroidPort._get_stderr):
1581         (ChromiumAndroidPort):
1582         (ChromiumAndroidPort._get_last_stacktrace):
1583         (ChromiumAndroidPort._teardown_performance):
1584         (ChromiumAndroidDriver):
1585         (ChromiumAndroidDriver.__init__):
1586         (ChromiumAndroidDriver._start):
1587         (ChromiumAndroidDriver.run_test):
1588         (ChromiumAndroidDriver.stop):
1589         (ChromiumAndroidDriver._test_shell_command):
1590         (ChromiumAndroidDriver._write_command_and_read_line):
1591         (ChromiumAndroidDriver._output_image):
1592         (ChromiumAndroidDriver._has_crash_hint):
1593
1594 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1595
1596         webkitpy: the real_name() method in the Port class is no longer needed
1597         https://bugs.webkit.org/show_bug.cgi?id=78651
1598
1599         Reviewed by Eric Seidel.
1600
1601         The change in bug 78565 / r107718 made it no longer necessary
1602         (we can use options.platform instead).
1603
1604         * Scripts/webkitpy/layout_tests/port/base.py:
1605         (Port.name):
1606         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1607         (MockDRTPort.__init__):
1608
1609 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1610
1611         webkitpy: clean up options, port handling in manager_worker_broker
1612         https://bugs.webkit.org/show_bug.cgi?id=78568
1613
1614         Reviewed by Tony Chang.
1615
1616         manager_worker_broker no longer needs options or port objects
1617         directly, so we make them only be passed in start_worker().
1618
1619         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1620         (Manager._run_tests):
1621         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1622         (get):
1623         (_ManagerConnection.__init__):
1624         (_ManagerConnection.start_worker):
1625         (_InlineManager.__init__):
1626         (_InlineManager.start_worker):
1627         (_InlineManager.run_message_loop):
1628         (_MultiProcessManager.__init__):
1629         (_MultiProcessManager):
1630         (_MultiProcessManager.start_worker):
1631         (_InlineWorkerConnection.__init__):
1632         (_InlineWorkerConnection.run):
1633         (_Process.__init__):
1634         (_MultiProcessWorkerConnection.__init__):
1635         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1636         (make_broker):
1637         (_TestWorker.run):
1638         (_TestsMixin.test_cancel):
1639         (_TestsMixin.test_done):
1640         (_TestsMixin.test_unknown_message):
1641         (MultiProcessBrokerTests.setUp):
1642         (InterfaceTest.test_managerconnection_is_abstract):
1643         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
1644         (Broker.__init__):
1645
1646 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1647
1648         nrwt: add a unit test for regression introduced in bug 78565
1649         https://bugs.webkit.org/show_bug.cgi?id=78646
1650
1651         Reviewed by Tony Chang.
1652
1653         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
1654         (FakeConnection):
1655         (FakeConnection.run_message_loop):
1656         (FakeConnection.post_message):
1657         (WorkerTest):
1658         (WorkerTest.test_default_platform_in_worker):
1659
1660 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1661
1662         NRWT is broken for the default port
1663         https://bugs.webkit.org/show_bug.cgi?id=78640
1664     
1665         Reviewed by Tony Chang.
1666
1667         The change in r107718 (bug 78565) broke NRWT if you didn't
1668         specify any sort of --platform flag or equivalent. I didn't
1669         catch this because it's a full integration test (which we don't
1670         have an automated test for) and I missed this command line
1671         variant when testing interactively.
1672
1673         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1674         (Worker.run):
1675
1676 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
1677
1678         Last character display for passwords in Android.
1679         https://bugs.webkit.org/show_bug.cgi?id=78532
1680
1681         Reviewed by Adam Barth.
1682
1683         * DumpRenderTree/chromium/WebPreferences.cpp:
1684         (WebPreferences::applyTo):
1685
1686 2012-02-14  Adam Barth  <abarth@webkit.org>
1687
1688         Finish implementing start_helper for ChromiumAndroidPort
1689         https://bugs.webkit.org/show_bug.cgi?id=78582
1690
1691         Reviewed by Eric Seidel.
1692
1693         This patch contains the remaining odds and ends for the start_helper function.
1694
1695         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1696         (ChromiumAndroidPort.start_helper):
1697         (ChromiumAndroidPort._synchronize_datetime):
1698         (ChromiumAndroidPort):
1699         (ChromiumAndroidPort._check_version):
1700         (ChromiumAndroidPort._run_adb_command):
1701         (ChromiumAndroidPort._copy_device_file):
1702
1703 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1704
1705         webkitpy: create ports in Workers, not in manager_worker_broker
1706         https://bugs.webkit.org/show_bug.cgi?id=78565
1707
1708         Reviewed by Tony Chang.
1709
1710         We will now create the Port object (if necessary) in the Worker
1711         directly, so that the manager_worker_broker module doesn't need
1712         all of this layout_test-specific logic. Part of the fixes for
1713         bug 78171.
1714
1715         These changes are all well-tested by the existing tests in
1716         run_webkit_tests_integrationtest.py.
1717
1718         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1719         (_Process.run):
1720         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1721         (Worker.__init__):
1722         (Worker.safe_init):
1723         (Worker.run):
1724         (Worker.cleanup):
1725         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1726         (parse_args):
1727         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
1728
1729 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
1730
1731         [chromium] check that we're not running multiple modal dialogs at the same time
1732         https://bugs.webkit.org/show_bug.cgi?id=78486
1733
1734         Reviewed by Kent Tamura.
1735
1736         * DumpRenderTree/chromium/TestShell.cpp:
1737         (TestShell::TestShell):
1738         * DumpRenderTree/chromium/TestShell.h:
1739         (TestShell::setIsDisplayingModalDialog):
1740         (TestShell::isDisplayingModalDialog):
1741         (TestShell):
1742         * DumpRenderTree/chromium/WebViewHost.cpp:
1743         (WebViewHost::runModal):
1744
1745 2012-02-14  Adam Barth  <abarth@webkit.org>
1746
1747         Enable the GPU codepath in the chromium-android port
1748         https://bugs.webkit.org/show_bug.cgi?id=78580
1749
1750         Reviewed by James Robinson.
1751
1752         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
1753         Android always uses the GPU codepath, so we set the GPU flags on the
1754         main chromium-android port instead.
1755
1756         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1757         (ChromiumAndroidPort.__init__):
1758
1759 2012-02-14  Adam Barth  <abarth@webkit.org>
1760
1761         NRWT should expose --adb-args flag for Android
1762         https://bugs.webkit.org/show_bug.cgi?id=78579
1763
1764         Reviewed by Eric Seidel.
1765
1766         This flag is already wired up to the ChromiumAndroidPort.
1767
1768         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1769         (parse_args):
1770
1771 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
1772
1773         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
1774         https://bugs.webkit.org/show_bug.cgi?id=78541
1775         <rdar://problem/10036695>
1776
1777         Reviewed by Kent Tamura.
1778
1779         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
1780         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
1781         After each test, reset to using new protocol.
1782
1783 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
1784
1785         Convert svg/animations to use SMIL methods for driving the timeline
1786         https://bugs.webkit.org/show_bug.cgi?id=78422
1787
1788         Reviewed by Dirk Schulze.
1789
1790         Remove no longer needed SVG specific animation sampling functionality from DRT.
1791         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
1792
1793         * DumpRenderTree/LayoutTestController.cpp:
1794         (LayoutTestController::staticFunctions):
1795         * DumpRenderTree/LayoutTestController.h:
1796         (LayoutTestController):
1797         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1798         * DumpRenderTree/chromium/LayoutTestController.cpp:
1799         (LayoutTestController::LayoutTestController):
1800         * DumpRenderTree/chromium/LayoutTestController.h:
1801         (LayoutTestController):
1802         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1803         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1804         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1805         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1806         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1807         (LayoutTestController):
1808         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1809         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1810
1811 2012-02-13  Rob Flack  <flackr@chromium.org>
1812
1813         Add Linux ChromiumOS test results to flakiness dashboard.
1814         https://bugs.webkit.org/show_bug.cgi?id=78495
1815
1816         Reviewed by Ojan Vafai.
1817
1818         * TestResultServer/static-dashboards/builders.js:
1819         * TestResultServer/static-dashboards/dashboard_base.js:
1820
1821 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
1822
1823         [GTK] Mutation Observers build is broken
1824         https://bugs.webkit.org/show_bug.cgi?id=78433
1825
1826         Reviewed by Martin Robinson.
1827
1828         Enabled mutation observers as a default feature for GTK port, too.
1829
1830         * Scripts/build-webkit:
1831
1832 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
1833
1834         Allow to configure ENABLE_FTPDIR in build-webkit
1835         https://bugs.webkit.org/show_bug.cgi?id=65098
1836
1837         Reviewed by Eric Seidel.
1838
1839         Allow to disable ENABLE_FTPDIR by command line.
1840         Remove ENABLE_FTPDIR from --minimal build
1841
1842         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
1843         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
1844         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
1845
1846 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
1847
1848         Add shinyak as committer.
1849
1850         Unreviewed.
1851
1852         * Scripts/webkitpy/common/config/committers.py:
1853
1854 2012-02-13  Adam Barth  <abarth@webkit.org>
1855
1856         Implement start/stop_helper for ChromiumAndroidPort
1857         https://bugs.webkit.org/show_bug.cgi?id=78558
1858
1859         Reviewed by Dirk Pranke.
1860
1861         These functions (and their dependencies) set up the Android device for
1862         testing.
1863
1864         This patch also includes a few tweaks on the previous patch recommended
1865         by dpranke.
1866
1867         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1868         (ChromiumAndroidPort.__init__):
1869         (ChromiumAndroidPort.start_helper):
1870         (ChromiumAndroidPort.stop_helper):
1871         (ChromiumAndroidPort._shut_down_http_server):
1872         (ChromiumAndroidPort):
1873         (ChromiumAndroidPort._push_executable):
1874         (ChromiumAndroidPort._push_fonts):
1875         (ChromiumAndroidPort._restore_system_font):
1876         (ChromiumAndroidPort._push_test_resources):
1877         (ChromiumAndroidPort._push_to_device):
1878         (ChromiumAndroidPort._pull_from_device):
1879         (ChromiumAndroidPort._kill_device_process):
1880         (ChromiumAndroidPort._setup_performance):
1881         (ChromiumAndroidPort._teardown_performance):
1882         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1883         (ChromiumAndroidPortTest):
1884         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1885         (PortTestCase):
1886         (PortTestCase.make_port):
1887         (PortTestCase.test_default_worker_model):
1888
1889 2012-02-13  Adam Barth  <abarth@webkit.org>
1890
1891         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
1892         https://bugs.webkit.org/show_bug.cgi?id=78550
1893
1894         Reviewed by Eric Seidel.
1895
1896         Much of this code just forwards to the "host" port, which seems like a
1897         reasonable thing to do.
1898
1899         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1900         (ChromiumAndroidPort.__init__):
1901         (ChromiumAndroidPort.stop_helper):
1902         (ChromiumAndroidPort):
1903         (ChromiumAndroidPort._build_path):
1904         (ChromiumAndroidPort._path_to_apache):
1905         (ChromiumAndroidPort._path_to_apache_config_file):
1906         (ChromiumAndroidPort._path_to_driver):
1907         (ChromiumAndroidPort._path_to_helper):
1908         (ChromiumAndroidPort._path_to_image_diff):
1909         (ChromiumAndroidPort._path_to_lighttpd):
1910         (ChromiumAndroidPort._path_to_lighttpd_modules):
1911         (ChromiumAndroidPort._path_to_lighttpd_php):
1912         (ChromiumAndroidPort._path_to_wdiff):
1913         (ChromiumAndroidPort._shut_down_http_server):
1914         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1915         (ChromiumAndroidPortTest):
1916         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1917         (PortTestCase):
1918         (PortTestCase.make_port):
1919         (PortTestCase.test_default_worker_model):
1920
1921 2012-02-13  Adam Barth  <abarth@webkit.org>
1922
1923         chromium_android.py should implement "virtual" methods from ChromiumPort
1924         https://bugs.webkit.org/show_bug.cgi?id=78545
1925
1926         Reviewed by Dirk Pranke.
1927
1928         This patch adds basic implementations that specialize a bunch of
1929         functions from ChromiumPort.
1930
1931         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1932         (ChromiumAndroidPort):
1933         (ChromiumAndroidPort.__init__):
1934         (ChromiumAndroidPort.default_child_processes):
1935         (ChromiumAndroidPort.baseline_search_path):
1936         (ChromiumAndroidPort.check_build):
1937         (ChromiumAndroidPort.check_sys_deps):
1938         (ChromiumAndroidPort.default_worker_model):
1939         (ChromiumAndroidPort.test_expectations):
1940         (ChromiumAndroidPort.start_http_server):
1941         (ChromiumAndroidPort.stop_http_server):
1942         (ChromiumAndroidPort.start_helper):
1943         (ChromiumAndroidPort.stop_helper):
1944
1945 2012-02-13  Adam Barth  <abarth@webkit.org>
1946
1947         Add a skeleton ChromiumAndroid port to webkitpy
1948         https://bugs.webkit.org/show_bug.cgi?id=78543
1949
1950         Reviewed by Eric Seidel.
1951
1952         This patch just adds an empty ChromiumAndroid port object to webkitpy
1953         and wires it up to the factory objects.  An actual implementation will
1954         follow.
1955
1956         * Scripts/webkitpy/layout_tests/port/chromium.py:
1957         (ChromiumPort):
1958         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
1959         (ChromiumAndroidPort):
1960         (ChromiumAndroidPort.__init__):
1961         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1962         (ChromiumPortTest.test_all_test_configurations):
1963         * Scripts/webkitpy/layout_tests/port/factory.py:
1964         (PortFactory):
1965
1966 2012-02-13  Adam Barth  <abarth@webkit.org>
1967
1968         NRWT's HTTP servers should support additional directories for resources
1969         https://bugs.webkit.org/show_bug.cgi?id=78528
1970
1971         Reviewed by Eric Seidel.
1972
1973         This functionality will be used by the Chromium-Android port.
1974
1975         * Scripts/webkitpy/layout_tests/port/base.py:
1976         (Port.to.start_http_server):
1977         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1978         (LayoutTestApacheHttpd.__init__):
1979         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1980         (Lighttpd.__init__):
1981         (Lighttpd._prepare_config):
1982
1983 2012-02-13  Ami Fischman  <fischman@chromium.org>
1984
1985         Add fischman as committer.
1986
1987         Unreviewed
1988
1989         * Scripts/webkitpy/common/config/committers.py:
1990
1991 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
1992
1993         [EFL] Drop support for the Curl network backend.
1994         https://bugs.webkit.org/show_bug.cgi?id=77874
1995
1996         Reviewed by Eric Seidel.
1997
1998         Nobody seems to be maintaining the Curl backend in WebCore, the
1999         EFL port developers all seem to be using the Soup backend and the
2000         port itself has many features which are only implemented for the
2001         latter.
2002
2003         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
2004         and always add the required include directories.
2005         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
2006         include directories and link to them.
2007
2008 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
2009
2010         [WebSocket] Update pywebsocket to 0.7.1
2011         https://bugs.webkit.org/show_bug.cgi?id=78484
2012
2013         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
2014
2015         Reviewed by Kent Tamura.
2016
2017         * Scripts/webkitpy/thirdparty/__init__.py:
2018         (AutoinstallImportHook._install_pywebsocket):
2019
2020 2012-02-12  Kangil Han  <kangil.han@samsung.com>
2021
2022         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
2023         https://bugs.webkit.org/show_bug.cgi?id=78091
2024
2025         Reviewed by Hajime Morita.
2026
2027         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
2028         This patch will activate around 1,900 test cases from skipped list in EFL port.
2029
2030         * DumpRenderTree/efl/EventSender.cpp:
2031         (textZoom):
2032         (pageZoom):
2033         (textZoomInCallback):
2034         (textZoomOutCallback):
2035         (zoomPageInCallback):
2036         (zoomPageOutCallback):
2037
2038 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
2039
2040         KeywordLookupGenerator.py script fails in some cases
2041         https://bugs.webkit.org/show_bug.cgi?id=77886
2042
2043         Reviewed by Benjamin Poulain.
2044
2045         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
2046         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
2047         (GlobalVariablesTest.test_path_rules_specifier):
2048
2049 2012-02-12  Joe Thomas  <joethomas@motorola.com>
2050
2051         Add toText and isTextNode helpers in Text class.
2052         https://bugs.webkit.org/show_bug.cgi?id=78140
2053
2054         Unit test case for the new style checker introduced.
2055
2056         Reviewed by Adam Barth.
2057
2058         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2059         (CppStyleTest):
2060         (CppStyleTest.test_static_cast_readability): Added a unit test case.
2061
2062 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2063
2064         Enable features supported by EFL port in build-webkit.
2065         https://bugs.webkit.org/show_bug.cgi?id=78348
2066
2067         Reviewed by Ryosuke Niwa.
2068
2069         Sync build-webkit with OptionEfl.cmake, as some features enabled in
2070         OptionEfl.cmake are not enabled in build-webkit.
2071
2072         * Scripts/build-webkit:
2073
2074 2012-02-12  Joe Thomas  <joethomas@motorola.com>
2075
2076         Add toText and isTextNode helpers in Text class.
2077         https://bugs.webkit.org/show_bug.cgi?id=78140
2078
2079         Added a style checker to use toText rather than static_cast<Text*>.
2080
2081         Reviewed by Adam Barth.
2082
2083         * Scripts/webkitpy/style/checkers/cpp.py:
2084         (check_language): Style checker for static_cast<Text*>.
2085
2086 2012-02-12  Philippe Normand  <pnormand@igalia.com>
2087
2088         Unreviewed, disable Mutation observers build on GTK until it can
2089         actually build.
2090
2091         * Scripts/build-webkit:
2092
2093 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
2094
2095         Add back WTFURL to WebKit
2096         https://bugs.webkit.org/show_bug.cgi?id=77291
2097
2098         Reviewed by Adam Barth.
2099
2100         Add a flag to build-webkit to easily build WebKit with WTFURL.
2101
2102         * Scripts/build-webkit:
2103
2104 2012-02-10  Adam Klein  <adamk@chromium.org>
2105
2106         Enable MUTATION_OBSERVERS by default on all platforms
2107         https://bugs.webkit.org/show_bug.cgi?id=78196
2108
2109         Reviewed by Ojan Vafai.
2110
2111         * Scripts/build-webkit:
2112
2113 2012-02-10  Adam Barth  <abarth@webkit.org>
2114
2115         Move garden-o-matic's All Failures out of experimental
2116         https://bugs.webkit.org/show_bug.cgi?id=78395
2117
2118         Reviewed by Dimitri Glazkov.
2119
2120         Several folks have tried this feature and found it useful.
2121
2122         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2123
2124 2012-02-10  Tim Horton  <timothy_horton@apple.com>
2125
2126         NRWT should categorize options in --help
2127         https://bugs.webkit.org/show_bug.cgi?id=76221
2128
2129         Reviewed by Eric Seidel.
2130         
2131         Use optparse's OptionGroup mechanism to logically group NRWT's options,
2132         providing a better experience when scanning all the options.
2133
2134         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2135         (parse_args):
2136
2137 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2138
2139         [Qt][WK2] Refactor on Qt5 Layout tests' structure
2140         https://bugs.webkit.org/show_bug.cgi?id=77450
2141
2142         Reviewed by Csaba Osztrogonác.
2143
2144         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
2145         to qt-5.0-wk2 and qt-5.0-wk1.
2146
2147         * Scripts/old-run-webkit-tests:
2148         (buildPlatformResultHierarchy):
2149         (readSkippedFiles):
2150         * Scripts/webkitpy/layout_tests/port/qt.py:
2151         (QtPort._wk2_port_name):
2152         (QtPort._skipped_file_search_paths):
2153         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2154         (QtPortTest.test_baseline_search_path):
2155         * Scripts/webkitpy/layout_tests/port/webkit.py:
2156         (WebKitPort._wk2_port_name):
2157
2158 2012-02-09  Philippe Normand  <pnormand@igalia.com>
2159
2160         [GTK] EWS command-line option to run the tests
2161         https://bugs.webkit.org/show_bug.cgi?id=78211
2162
2163         Reviewed by Adam Barth.
2164
2165         New --run-tests option (defaults to False) for the EWS commands.
2166
2167         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2168         (AbstractEarlyWarningSystem):
2169         (AbstractEarlyWarningSystem.__init__):
2170         (AbstractEarlyWarningSystem.review_patch):
2171         (ChromiumLinuxEWS):
2172         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2173         (EarlyWarningSytemTest._test_builder_ews):
2174
2175 2012-02-09  Eric Seidel  <eric@webkit.org>
2176
2177         Rename compare_text and compare_audio to make it clear that they're !=
2178         https://bugs.webkit.org/show_bug.cgi?id=78301
2179
2180         Reviewed by Adam Barth.
2181
2182         I also removed the maybe_create_directory function which was redundant.
2183
2184         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2185         (Manager.set_up_run):
2186         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2187         (TestResultWriter._make_output_directory):
2188         * Scripts/webkitpy/layout_tests/port/base.py:
2189         (Port.do_text_results_differ):
2190         (Port.do_audio_results_differ):
2191         (Port.diff_text):
2192         (Port.driver_name):
2193         (Port.skips_perf_test):
2194         * Scripts/webkitpy/layout_tests/port/win.py:
2195         (WinPort.do_text_results_differ):
2196         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2197         (WinPortTest.test_do_text_results_differ):
2198         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2199         (LayoutTestApacheHttpd.__init__):
2200         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2201         (HttpServerBase.__init__):
2202         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2203         (Rebaseliner._diff_baselines):
2204
2205 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
2206
2207         [GTK] Add DRT support for modal dialogs
2208         https://bugs.webkit.org/show_bug.cgi?id=53600
2209
2210         Reviewed by Martin Robinson.
2211
2212         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
2213         Most significantly, when creating a new web view in GtkLauncher, the window
2214         of the web view opener is passed around. In DumpRenderTree, the window of
2215         the main web view is always considered as the opener. This is required so
2216         the modal dialog's toplevel can be made transient for the opener's toplevel.
2217
2218         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2219         (webViewRunModalDialog):
2220         (createWebView):
2221         * GtkLauncher/main.c:
2222         (createWebViewCb):
2223         (runModalDialogCb):
2224         (createBrowser):
2225         (createWindow):
2226         (main):
2227
2228 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
2229
2230         [Gtk] security/set-form-autocomplete-attribute.html fails
2231         https://bugs.webkit.org/show_bug.cgi?id=78261
2232
2233         Reviewed by Martin Robinson.
2234
2235         Use the new helper in DumpRenderTreeSupportGtk to properly
2236         test whether an element performs autocompletion.
2237
2238         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2239         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2240
2241 2012-02-09  James Robinson  <jamesr@chromium.org>
2242
2243         [chromium] Enable mock scrollbars for compositing layout tests
2244         https://bugs.webkit.org/show_bug.cgi?id=78299
2245
2246         Reviewed by Dirk Pranke.
2247
2248         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
2249         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
2250         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
2251
2252         * DumpRenderTree/chromium/TestShell.cpp:
2253         (TestShell::runFileTest):
2254         * DumpRenderTree/chromium/WebPreferences.cpp:
2255         (WebPreferences::reset):
2256         (WebPreferences::applyTo):
2257         * DumpRenderTree/chromium/WebPreferences.h:
2258         (WebPreferences):
2259
2260 2012-02-09  Eric Seidel  <eric@webkit.org>
2261
2262         Remove more uses of "os" from our webkitpy code
2263         https://bugs.webkit.org/show_bug.cgi?id=78292
2264
2265         Reviewed by Adam Barth.
2266
2267         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2268         (MockCheckout.__init__):
2269         (MockCheckout.is_path_to_changelog):
2270         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2271         * Scripts/webkitpy/common/system/filesystem_mock.py:
2272         (MockFileSystem._split):
2273         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2274         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2275         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2276         * Scripts/webkitpy/layout_tests/port/webkit.py:
2277         * Scripts/webkitpy/tool/bot/queueengine.py:
2278         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2279         * Scripts/webkitpy/tool/commands/download.py:
2280         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2281         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2282         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2283         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2284         * Scripts/webkitpy/tool/commands/upload.py:
2285         (CreateBug.prompt_for_bug_title_and_comment):
2286         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2287         * Scripts/webkitpy/tool/steps/attachtobug.py:
2288         (AttachToBug.run):
2289         * Scripts/webkitpy/tool/steps/checkstyle.py:
2290         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2291         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2292         * Scripts/webkitpy/tool/steps/editchangelog.py:
2293         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2294         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2295         (PrepareChangeLogTest.test_ensure_bug_url):
2296         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2297         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2298         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2299         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2300
2301 2012-02-09  Eric Seidel  <eric@webkit.org>
2302
2303         Remove the cr-mac-ews (it's long been dead)
2304         https://bugs.webkit.org/show_bug.cgi?id=78267
2305
2306         Reviewed by Adam Barth.
2307
2308         * QueueStatusServer/model/queues.py:
2309         (Queue):
2310         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2311         (ChromiumWindowsEWS):
2312         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2313         (EarlyWarningSytemTest._test_builder_ews):
2314         (EarlyWarningSytemTest._test_testing_ews):
2315
2316 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
2317
2318         some tests in webkitpy are being run three times
2319         https://bugs.webkit.org/show_bug.cgi?id=78283
2320
2321         Reviewed by Ryosuke Niwa.
2322
2323         It turns out that if you import a class derived from
2324         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
2325         the unittest framework treats it as if the class was defined in
2326         the file (as well in the original file). This led us to running
2327         the tests in ChangeLogTest three times.
2328
2329         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2330         (PrepareChangeLogTest):
2331         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2332         (_assert_message_for_revert_output):
2333
2334 2012-02-09  Adam Barth  <abarth@webkit.org>
2335
2336         Remove extraneous line in previous patch.  I forgot to remove this
2337         before landing.
2338
2339         * Scripts/webkitpy/layout_tests/port/driver.py:
2340         (DriverProxy.start):
2341
2342 2012-02-09  Adam Barth  <abarth@webkit.org>
2343
2344         run-perf-tests should have an option to pause before running tests so we can attach Instruments
2345         https://bugs.webkit.org/show_bug.cgi?id=78271
2346
2347         Reviewed by Ryosuke Niwa.
2348
2349         This lets me attach instruments to profile the performance of the test.
2350
2351         * Scripts/webkitpy/layout_tests/port/chromium.py:
2352         (ChromiumDriver.start):
2353         * Scripts/webkitpy/layout_tests/port/driver.py:
2354         (Driver.start):
2355         (DriverProxy.start):
2356         * Scripts/webkitpy/layout_tests/port/server_process.py:
2357         (ServerProcess.start):
2358         * Scripts/webkitpy/layout_tests/port/test.py:
2359         (TestDriver.start):
2360         * Scripts/webkitpy/layout_tests/port/webkit.py:
2361         (WebKitDriver.start):
2362         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2363         (get_tests_run.RecordingTestDriver.start):
2364         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2365         (PerfTestsRunner._parse_args):
2366         (PerfTestsRunner._run_tests_set):
2367         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2368         (start):
2369         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2370         (test_run_test_set_kills_drt_per_run):
2371         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
2372         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
2373
2374 2012-02-09  Adam Barth  <abarth@webkit.org>
2375
2376         run-perf-tests --chromium should run the chromium port
2377         https://bugs.webkit.org/show_bug.cgi?id=78266
2378
2379         Reviewed by Ryosuke Niwa.
2380
2381         This patch makes run-perf-tests work more like run-webkit-tests.
2382
2383         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2384         (PerfTestsRunner._parse_args):
2385
2386 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2387
2388         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
2389         https://bugs.webkit.org/show_bug.cgi?id=77466
2390
2391         Reviewed by Dirk Pranke.
2392
2393         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
2394         is set or if we should raise an error. A unit test was added.
2395
2396         * Scripts/webkitpy/layout_tests/port/qt.py:
2397         (QtPort.operating_system):
2398         (QtPort):
2399         (QtPort.check_sys_deps):
2400         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2401         (QtPortTest.test_operating_system):
2402         (QtPortTest):
2403         (QtPortTest.test_check_sys_deps):
2404
2405 2012-02-09  Eric Seidel  <eric@webkit.org>
2406
2407         Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
2408         https://bugs.webkit.org/show_bug.cgi?id=78263
2409
2410         Reviewed by Adam Barth.
2411
2412         * Scripts/webkitpy/common/config/ports.py:
2413         (DeprecatedPort):
2414         (DeprecatedPort.name):
2415         (DeprecatedPort.flag):
2416         (DeprecatedPort.script_path):
2417         (DeprecatedPort.script_shell_command):
2418         (DeprecatedPort.port):
2419         (DeprecatedPort.makeArgs):
2420         (DeprecatedPort.update_webkit_command):
2421         (DeprecatedPort.check_webkit_style_command):
2422         (DeprecatedPort.prepare_changelog_command):
2423         (DeprecatedPort.build_webkit_command):
2424         (DeprecatedPort.run_javascriptcore_tests_command):
2425         (DeprecatedPort.run_webkit_unit_tests_command):
2426         (DeprecatedPort.run_webkit_tests_command):
2427         (DeprecatedPort.run_python_unittests_command):
2428         (DeprecatedPort.run_perl_unittests_command):
2429         (DeprecatedPort.layout_tests_results_path):
2430         (MacPort):
2431         (WinPort):
2432         (GtkPort):
2433         (GtkPort.build_webkit_command):
2434         (GtkPort.run_webkit_tests_command):
2435         (QtPort):
2436         (QtPort.build_webkit_command):
2437         (EflPort):
2438         (EflPort.build_webkit_command):
2439         (ChromiumPort):
2440         (ChromiumPort.update_webkit_command):
2441         (ChromiumPort.build_webkit_command):
2442         (ChromiumPort.run_webkit_tests_command):
2443         (ChromiumPort.run_javascriptcore_tests_command):
2444         (ChromiumXVFBPort):
2445         (ChromiumXVFBPort.run_webkit_tests_command):
2446         * Scripts/webkitpy/common/config/ports_unittest.py:
2447         (DeprecatedPortTest):
2448         (DeprecatedPortTest.test_mac_port):
2449         (DeprecatedPortTest.test_gtk_port):
2450         (DeprecatedPortTest.test_qt_port):
2451         (DeprecatedPortTest.test_chromium_port):
2452         (DeprecatedPortTest.test_chromium_xvfb_port):
2453         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2454         (AbstractEarlyWarningSystem.__init__):
2455         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2456         * Scripts/webkitpy/tool/main.py:
2457         (WebKitPatch):
2458         (WebKitPatch.handle_global_options):
2459         * Scripts/webkitpy/tool/steps/abstractstep.py:
2460         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2461         (StepsTest.test_runtests_args):
2462
2463 2012-02-09  Jochen Eisinger  <jochen@chromium.org>
2464
2465         [chromium] always initialize makeArgs in buildChromiumNinja
2466         https://bugs.webkit.org/show_bug.cgi?id=78231
2467
2468         Reviewed by Tony Gentilcore.
2469
2470         * Scripts/webkitdirs.pm:
2471         (buildChromiumNinja):
2472
2473 2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2474
2475         [GTK] Show url of current hovered link in MiniBrowser
2476         https://bugs.webkit.org/show_bug.cgi?id=78098
2477
2478         Reviewed by Martin Robinson.
2479
2480         * MiniBrowser/gtk/BrowserWindow.c:
2481         (webViewMouseTargetChanged): Check whether hit test result is a
2482         link and use the url to update the status bar text.
2483         (browserWindowConstructed): Connect to
2484         WebKitWebView::mouse-target-changed signal.
2485
2486 2012-02-09  Rob Buis  <rbuis@rim.com>
2487
2488         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2489         https://bugs.webkit.org/show_bug.cgi?id=78042
2490
2491         Reviewed by Antonio Gomes.
2492
2493         Upstream final part of our DRT implementation.
2494
2495         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
2496         * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
2497         * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
2498         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
2499         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
2500
2501 2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
2502
2503         kill-old-processes should kill gcc and clang
2504         https://bugs.webkit.org/show_bug.cgi?id=78189
2505
2506         Reviewed by Eric Seidel.
2507
2508         Added a bunch of processes names of gcc and clang to the list.
2509
2510         * BuildSlaveSupport/kill-old-processes:
2511
2512 2012-02-07  MORITA Hajime  <morrita@google.com>
2513
2514         Replacement text should be available from the marker.
2515         https://bugs.webkit.org/show_bug.cgi?id=77934
2516
2517         Made the mock requestCheckingOfText() implementation to return
2518         a replacement text for each misspelled word if available.
2519
2520         Reviewed by Kent Tamura.
2521
2522         * DumpRenderTree/chromium/WebViewHost.cpp:
2523         (WebViewHost::finishLastTextCheck):
2524
2525 2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2526
2527         [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
2528         https://bugs.webkit.org/show_bug.cgi?id=78146
2529
2530         Reviewed by Ryosuke Niwa.
2531
2532         Our DumpRenderTree should support --no-timeout and --timeout options in order
2533         to be able to use run-perf-tests and have a Performance Bot.
2534         This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
2535         and the necessary code to handle such command line arguments to our DumpRenderTree.
2536
2537         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2538         (WebCore::DumpRenderTree::setTimeout):
2539         (WebCore):
2540         (WebCore::DumpRenderTree::setShouldTimeout):
2541         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2542         (DumpRenderTree):
2543         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2544         (LayoutTestController::LayoutTestController):
2545         (LayoutTestController::waitUntilDone):
2546         (LayoutTestController::notifyDone):
2547         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2548         (LayoutTestController::setTimeout):
2549         (LayoutTestController::setShouldTimeout):
2550         (LayoutTestController):
2551         * DumpRenderTree/qt/main.cpp:
2552         (isOption):
2553         (printUsage):
2554         (main):
2555
2556 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2557
2558         Rubber-stamped by Martin Robinson.
2559
2560         * gtk/common.py:
2561         (get_build_path): Move test for current directory being a valid
2562         directory up so it takes precedence over WebKitBuild/Release and
2563         WebKitBuild/Debug when they exist as well.
2564
2565 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2566
2567         [GTK] doc rebasing does not respect DESTDIR
2568         https://bugs.webkit.org/show_bug.cgi?id=78177
2569
2570         Reviewed by Martin Robinson.
2571
2572         * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
2573         calling it for rebasing.
2574         * gtk/generate-gtkdoc:
2575         (get_common_options): Handle the new --virtual-root option.
2576         * gtk/gtkdoc.py:
2577         (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
2578         it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
2579
2580 2012-02-08  Adam Barth  <abarth@webkit.org>
2581
2582         Remove Python 2.5 support from WebKit
2583         https://bugs.webkit.org/show_bug.cgi?id=71593
2584
2585         Reviewed by Eric Seidel.
2586
2587         This is the last vestige of our Python 2.5 support.
2588
2589         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2590         (AbstractQueueTest.test_log_from_script_error_for_upload):
2591
2592 2012-02-08  Adam Barth  <abarth@webkit.org>
2593
2594         version_check.py should inform users that we don't support Python 2.5 anymore
2595         https://bugs.webkit.org/show_bug.cgi?id=78179
2596
2597         Reviewed by Eric Seidel.
2598
2599         We don't support Python 2.5 anymore.
2600
2601         * Scripts/webkitpy/common/version_check.py:
2602
2603 2012-02-08  Adam Barth  <abarth@webkit.org>
2604
2605         test_configuration.py shouldn't re-implement itertools
2606         https://bugs.webkit.org/show_bug.cgi?id=78178
2607
2608         Reviewed by Eric Seidel.
2609
2610         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2611         (TestConfigurationConverter.to_specifiers_list):
2612         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2613         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2614         (TestConfigurationConverter):
2615
2616 2012-02-08  Adam Barth  <abarth@webkit.org>
2617
2618         webkitpy should reply upon the multiprocessing package existing
2619         https://bugs.webkit.org/show_bug.cgi?id=78176
2620
2621         Reviewed by Eric Seidel.
2622
2623         Now that we don't support Python 2.5, this import can't fail.
2624
2625         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2626         (get):
2627         (_Process):
2628         (_Process.__init__):
2629         (_Process.run):
2630         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2631         (FunctionTests.test_get__processes):
2632         (MultiProcessBrokerTests.setUp):
2633         * Scripts/webkitpy/layout_tests/port/base.py:
2634         (Port.__init__):
2635         (Port.default_worker_model):
2636         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2637         (ChromiumMacPort.check_build):
2638         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2639         (PortTestCase.test_default_worker_model):
2640         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2641
2642 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2643
2644         Unreviewed typo fix that makes docs build again for the gtk2-based
2645         library.
2646
2647         * gtk/generate-gtkdoc:
2648
2649 2012-02-08  Adam Barth  <abarth@webkit.org>
2650
2651         Don't re-implement ZipFile.extractall
2652         https://bugs.webkit.org/show_bug.cgi?id=78173
2653
2654         Reviewed by Eric Seidel.
2655
2656         We can use ZipFile.extractall now that we don't support Python 2.5.
2657
2658         * Scripts/webkitpy/common/system/autoinstall.py:
2659         (AutoInstaller._extract_targz):
2660         (AutoInstaller._unzip):
2661
2662 2012-02-08  Adam Barth  <abarth@webkit.org>
2663
2664         Remove the ospath compat shim from webkitpy
2665         https://bugs.webkit.org/show_bug.cgi?id=78170
2666
2667         Reviewed by Eric Seidel.
2668
2669         We no longer need this compat shim now that we don't support Python 2.5.
2670
2671         * Scripts/webkitpy/common/checkout/scm/git.py:
2672         * Scripts/webkitpy/common/checkout/scm/svn.py:
2673         * Scripts/webkitpy/common/system/filesystem.py:
2674         (FileSystem.relpath):
2675         * Scripts/webkitpy/common/system/filesystem_mock.py:
2676         (MockFileSystem.relpath):
2677         * Scripts/webkitpy/common/system/ospath.py: Removed.
2678         * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
2679
2680 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2681
2682         Build fix attempt after r107053.
2683
2684         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2685         (test_collect_tests):
2686
2687 2012-02-08  Adam Barth  <abarth@webkit.org>
2688
2689         Remove simplejson because it's no longer used by webkitpy
2690         https://bugs.webkit.org/show_bug.cgi?id=78164
2691
2692         Reviewed by Eric Seidel.
2693
2694         All the importers of this code were removed in a previous patch.
2695
2696         * Scripts/webkitpy/thirdparty/simplejson: Removed.
2697         * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
2698         * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
2699         * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
2700         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
2701         * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
2702         * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
2703         * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
2704         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
2705         * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
2706         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
2707
2708 2012-02-08  Adam Barth  <abarth@webkit.org>
2709
2710         webkitpy still imports simplejson
2711         https://bugs.webkit.org/show_bug.cgi?id=78161
2712
2713         Reviewed by Eric Seidel.
2714
2715         We no longer support Python 2.5, so we can rely upon Python's built-in
2716         JSON package.
2717
2718         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2719         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2720         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
2721         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2722         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2723         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2724         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2725         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2726         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2727         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2728         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2729
2730 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2731
2732         [GTK] Fails to build docs with non-standard build directories
2733         https://bugs.webkit.org/show_bug.cgi?id=78118
2734
2735         * gtk/common.py:
2736         (get_build_path): add comment to document changes done in r107098,
2737         as requested by the reviewer and forgotten by me.
2738
2739 2012-02-08  Adam Barth  <abarth@webkit.org>
2740
2741         Stop importing with_statement from the mysterious future
2742         https://bugs.webkit.org/show_bug.cgi?id=78156
2743
2744         Reviewed by Eric Seidel.
2745
2746         The future is now!  (Well, at least 2008, when Python 2.6 was released,
2747         is no longer the __future__.)
2748
2749         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2750         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2751         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2752         * Scripts/webkitpy/common/net/credentials_unittest.py:
2753         * Scripts/webkitpy/common/net/file_uploader.py:
2754         * Scripts/webkitpy/common/newstringio_unittest.py:
2755         * Scripts/webkitpy/common/system/autoinstall.py:
2756         * Scripts/webkitpy/common/system/crashlogs.py:
2757         * Scripts/webkitpy/common/system/fileset.py:
2758         * Scripts/webkitpy/common/system/filesystem.py:
2759         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2760         * Scripts/webkitpy/common/system/path.py:
2761         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
2762         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2763         * Scripts/webkitpy/layout_tests/port/base.py:
2764         (of):
2765         * Scripts/webkitpy/layout_tests/port/gtk.py:
2766         * Scripts/webkitpy/layout_tests/port/test.py:
2767         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2768         * Scripts/webkitpy/style/filereader_unittest.py:
2769         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2770         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2771         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2772         * Scripts/webkitpy/tool/commands/queues.py:
2773         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2774         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2775
2776 2012-02-08  Rob Buis  <rbuis@rim.com>
2777
2778         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2779         https://bugs.webkit.org/show_bug.cgi?id=78042
2780
2781         Reviewed by Antonio Gomes.
2782
2783         Upstream more parts of our DRT implementation.
2784
2785         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
2786         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
2787         * DumpRenderTree/blackberry/EventSender.cpp: Added.
2788         * DumpRenderTree/blackberry/EventSender.h: Added.
2789         * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
2790         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
2791
2792 2012-02-08  Dirk Pranke  <dpranke@chromium.org>
2793
2794         check-webkit-style failing with "Path does not exist."
2795         https://bugs.webkit.org/show_bug.cgi?id=77873
2796
2797         Reviewed by Ojan Vafai.
2798
2799         This change fixes the way the style checker determines which
2800         Port class to use for a given test_expectations.txt path; the
2801         previous version used a heuristic that didn't really work in the
2802         first place.
2803
2804         * Scripts/webkitpy/style/checkers/test_expectations.py:
2805         (TestExpectationsChecker._determine_port_from_expectations_path):
2806         (TestExpectationsChecker.__init__):
2807         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2808         (TestExpectationsTestCase._expect_port_for_expectations_path):
2809         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2810
2811 2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>
2812
2813         nrwt: make --skip-pixel-test-if-no-baseline option
2814         https://bugs.webkit.org/show_bug.cgi?id=70484
2815
2816         Reviewed by Dirk Pranke.
2817
2818         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2819         (SingleTestRunner.__init__):
2820         (SingleTestRunner._should_fetch_expected_checksum):
2821         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2822         (Worker.handle_test_list):
2823         * Scripts/webkitpy/layout_tests/models/test_input.py:
2824         (TestInput.__init__):
2825         * Scripts/webkitpy/layout_tests/port/webkit.py:
2826         (WebKitDriver.cmd_line):
2827         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2828         (_set_up_derived_options):
2829         (parse_args):
2830         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2831         (MainTest.test_skip_pixel_test_if_no_baseline_option):
2832         * WebKitTestRunner/TestController.cpp:
2833         (WTR::TestController::TestController):
2834         (WTR::TestController::initialize):
2835         (WTR::TestController::runTest):
2836         * WebKitTestRunner/TestController.h:
2837         (TestController):
2838         * WebKitTestRunner/TestInvocation.cpp:
2839         (WTR::TestInvocation::TestInvocation):
2840         (WTR::TestInvocation::setIsPixelTest):
2841         * WebKitTestRunner/TestInvocation.h:
2842         (WTR::TestInvocation::setSkipPixelTestOption):
2843         (TestInvocation):
2844
2845 2012-02-08  Rob Buis  <rbuis@rim.com>
2846
2847         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2848         https://bugs.webkit.org/show_bug.cgi?id=78042
2849
2850         Reviewed by Antonio Gomes.
2851
2852         Add implementation for our DumpRenderTree solution.
2853
2854         * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
2855         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
2856
2857 2012-02-08  Antti Koivisto  <antti@apple.com>
2858
2859         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
2860         https://bugs.webkit.org/show_bug.cgi?id=78080
2861
2862         Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
2863         
2864         Add API test.
2865
2866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2867         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
2868         (TestWebKitAPI):
2869         (TestWebKitAPI::TEST):
2870
2871 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2872
2873         [GTK] Fails to build docs with non-standard build directories
2874         https://bugs.webkit.org/show_bug.cgi?id=78118
2875
2876         Reviewed by Martin Robinson.
2877
2878         * gtk/common.py:
2879         (get_build_path): also try the current directory as a valid build
2880         dir, which makes non-standard build directories such as build-2.0
2881         and build-3.0 work
2882
2883 2012-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2884
2885         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
2886         https://bugs.webkit.org/show_bug.cgi?id=78099
2887
2888         Reviewed by Martin Robinson.
2889
2890         * MiniBrowser/gtk/BrowserWindow.c:
2891         (webViewDecidePolicy): Check whether it's a link clicked with the
2892         middle mouse button and load the request in a new window.
2893         (browserWindowConstructed): Connect to
2894         WebKitWebView::decide-policy signal.
2895
2896 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2897
2898         Revert a part of the change in r106687 as a build fix.
2899
2900         Since Chromium port doesn't checkout the entire WebKit trunk,
2901         we can't run "svn info" on webkit_base.
2902
2903         * Scripts/webkitpy/layout_tests/port/base.py:
2904         (Port.repository_paths):
2905
2906 2012-02-07  Ryosuke Niwa  <rniwa@webkit.org>
2907
2908         run-perf-tests doesn't recognize paths that start with PerformanceTests
2909         https://bugs.webkit.org/show_bug.cgi?id=78012
2910
2911         Reviewed by Adam Barth.
2912
2913         Use resolve paths using filesystem.relpath before passing it to find_files.find.
2914
2915         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2916         (PerfTestsRunner):
2917         (PerfTestsRunner._collect_tests):
2918         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2919         (test_collect_tests):
2920         (test_collect_tests.add_file):
2921
2922 2012-02-07  Justin Novosad  <junov@chromium.org>
2923
2924         [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
2925         https://bugs.webkit.org/show_bug.cgi?id=78039
2926
2927         Reviewed by Stephen White.
2928
2929         Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
2930
2931         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2932         (main):
2933         * DumpRenderTree/chromium/TestShell.cpp:
2934         (TestShell::TestShell):
2935         (TestShell::resetWebSettings):
2936         (TestShell::runFileTest):
2937         * DumpRenderTree/chromium/TestShell.h:
2938         (TestShell::setDeferred2dCanvasEnabled):
2939         (TestShell):
2940         * DumpRenderTree/chromium/WebPreferences.cpp:
2941         (WebPreferences::reset):
2942         (WebPreferences::applyTo):
2943         * DumpRenderTree/chromium/WebPreferences.h:
2944         (WebPreferences):
2945
2946 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2947
2948         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
2949         https://bugs.webkit.org/show_bug.cgi?id=77928
2950
2951         Reviewed by Daniel Bates.
2952
2953         CMake has used *Programs* directory for executable. In addition, shared libraries are being
2954         built in source directory. It is better to set common places in order to maintain executable
2955         and libraries. *bin* is for executable and *lib* is for library.
2956
2957         * DumpRenderTree/efl/CMakeLists.txt:
2958         * EWebLauncher/CMakeLists.txt:
2959         * Scripts/run-launcher:
2960         * Scripts/webkitdirs.pm:
2961         (jscProductDir):
2962         * Scripts/webkitpy/layout_tests/port/efl.py:
2963         (EflPort._path_to_driver):
2964         (EflPort._path_to_image_diff):
2965
2966 2012-02-07  Adam Klein  <adamk@chromium.org>
2967
2968         Add JSC support for delivering mutations when the outermost script context exits
2969         https://bugs.webkit.org/show_bug.cgi?id=70289
2970
2971         Reviewed by Eric Seidel.
2972
2973         * DumpRenderTree/mac/EventSendingController.mm: Add support for
2974         eventSender.scheduleAsynchronousKeyDown.
2975         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2976         (+[EventSendingController webScriptNameForSelector:]):
2977         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
2978         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
2979         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
2980
2981 2012-02-07  Chris Rogers  <crogers@google.com>
2982
2983         Add Chris Rogers to reviewers section
2984         https://bugs.webkit.org/show_bug.cgi?id=78016
2985
2986         Reviewed by Adam Barth.
2987
2988         * Scripts/webkitpy/common/config/committers.py:
2989
2990 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
2991
2992         layoutTestController.display() is flaky for SVG tests
2993         https://bugs.webkit.org/show_bug.cgi?id=78021
2994
2995         Reviewed by Dan Bernstein.
2996
2997         Fix race condition in repaint rect tracking. When running a test using the repaint.js
2998         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
2999         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
3000         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
3001         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
3002         the repaint test already run, thus invalidating the previously tracked repaint rects.
3003
3004         * DumpRenderTree/mac/DumpRenderTree.mm:
3005         (dump):
3006         (runTest):
3007
3008 2012-02-07  Hans Wennborg  <hans@chromium.org>
3009
3010         Chromium: remove WebSpeechInputResult::set
3011         https://bugs.webkit.org/show_bug.cgi?id=77977
3012
3013         Reviewed by Darin Fisher.
3014
3015         It was renamed to assign() in r106475.
3016
3017         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3018         (makeRectResult):
3019
3020 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3021
3022         [Qt] Give emulated touch-point a radius
3023         https://bugs.webkit.org/show_bug.cgi?id=77985
3024         
3025         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
3026
3027         Reviewed by Kenneth Rohde Christiansen.
3028
3029         * MiniBrowser/qt/BrowserWindow.cpp:
3030         (BrowserWindow::updateVisualMockTouchPoints):
3031         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3032         (MiniBrowserApplication::notify):
3033         * MiniBrowser/qt/qml/MockTouchPoint.qml:
3034
3035 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
3036
3037         [GTK] Include gdk-pixbuf in the jhbuild modules
3038         https://bugs.webkit.org/show_bug.cgi?id=77980
3039
3040         Reviewed by Gustavo Noronha Silva.
3041
3042         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
3043
3044 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
3045
3046         [Qt] Prevent early test termination with newer Qt 5
3047         https://bugs.webkit.org/show_bug.cgi?id=77945
3048
3049         Reviewed by Csaba Osztrogonác.
3050
3051         QTBUG-24120 tracks a regression in Qt that would make layout tests
3052         terminate early. This patch works around it in a Qt 4 + 5 safe manner
3053         by disabling the quitOnLastWindowClosed feature, which we don't want/need
3054         for DRT anyway.
3055
3056         * DumpRenderTree/qt/main.cpp:
3057         (main): Don't quit on last window closed.
3058
3059 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
3060
3061         Fix some miscellaneous 'make dist' error for WebKitGTK+.
3062
3063         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
3064         files should not be distributed.
3065
3066 2012-02-02  Hajime Morrita  <morrita@chromium.org>
3067
3068         [PerformanceTests] Each Dromaeo test needs its landing html.
3069         https://bugs.webkit.org/show_bug.cgi?id=77504
3070
3071         Reviewed by Ryosuke Niwa.
3072
3073         Added an ignorable pattern which happens in some Dromaeo tests.
3074
3075         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3076         (PerfTestsRunner):
3077
3078 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
3079
3080         [GTK] Add missing pango include dir to fix build
3081         https://bugs.webkit.org/show_bug.cgi?id=77832
3082
3083         Reviewed by Martin Robinson.
3084
3085         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
3086
3087 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
3088
3089         [GTK] Fix remaining errors in GTK+ WebKit2 API
3090         https://bugs.webkit.org/show_bug.cgi?id=77890
3091
3092         Reviewed by Gustavo Noronha Silva.
3093
3094         Verify that WebKit2 GTK+ test files are not skipped during style checks.
3095         Skip soup_server_new when checking for NULL versus 0 usage.
3096
3097         * Scripts/webkitpy/style/checker_unittest.py:
3098         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3099         * Scripts/webkitpy/style/checkers/cpp.py:
3100         (check_for_null):
3101
3102 2012-02-06  Eric Seidel  <eric@webkit.org>
3103
3104         webkit-patch apply-from-bug should be able to apply non-reviewed patches
3105         https://bugs.webkit.org/show_bug.cgi?id=77883
3106
3107         Reviewed by Adam Barth.
3108
3109         This is very helpful if you use bugzilla as a replacement for git-stash.
3110         Makes it simpler to re-apply the patch w/o having to look up the patch id.
3111
3112         * Scripts/webkitpy/tool/commands/download.py:
3113         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3114         * Scripts/webkitpy/tool/commands/download_unittest.py:
3115         (DownloadCommandsTest.test_apply_from_bug):
3116
3117 2012-02-06  Philippe Normand  <pnormand@igalia.com>
3118
3119         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
3120         https://bugs.webkit.org/show_bug.cgi?id=77866
3121
3122         Reviewed by Martin Robinson.
3123
3124         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
3125         errors in some gstreamer source code files defining new GStreamer elements.
3126         * Scripts/webkitpy/style/checker_unittest.py:
3127         (GlobalVariablesTest.test_path_rules_specifier):
3128
3129 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3130
3131         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
3132         https://bugs.webkit.org/show_bug.cgi?id=77869
3133
3134         Reviewed by Philippe Normand.
3135
3136         * gtk/gtkdoc.py:
3137         (GTKDoc.rebase_installed_docs): Check html_dir exists.
3138
3139 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3140
3141         [Qt] Don't version QtWebKit.experimental.
3142         https://bugs.webkit.org/show_bug.cgi?id=77739
3143
3144         Reviewed by Tor Arne Vestbø.
3145
3146         * MiniBrowser/qt/qml/BrowserWindow.qml:
3147
3148 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3149
3150         [GTK] Fix several gtkdoc-fixxref warnings
3151         https://bugs.webkit.org/show_bug.cgi?id=77613
3152
3153         Reviewed by Martin Robinson.
3154
3155         * gtk/generate-gtkdoc:
3156         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
3157         of ignored files, since it's private.
3158         * gtk/gtkdoc.py:
3159         (GTKDoc._ignored_files_basenames): Helper function that returns a
3160         string with the list of ignored files basenames separated by a
3161         spaces, as expected by several gtkdoc commands.
3162         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
3163         --ignore-headers option.
3164         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
3165         --ignore-files option.
3166
3167 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3168
3169         [GTK] Fix xrefs after installing API documentation
3170         https://bugs.webkit.org/show_bug.cgi?id=77551
3171
3172         Reviewed by Martin Robinson.
3173
3174         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
3175         api docs.
3176         * gtk/common.py:
3177         (prefix_of_pkg_config_file): Get the prefix variable of the given
3178         pkg-config file.
3179         (gtk_version_of_pkg_config_file): Get the gtk version required by
3180         the given pkg-config file.
3181         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
3182         installed documentation.
3183         (get_gtkdoc_module_paths): Get paths where API doc is installed
3184         for the dependencies of the given pkg-config file.
3185         (get_common_xref_deps): Get API doc directories of dependencies
3186         common to WebKit1 and WebKit2.
3187         (get_webkit2_options): Add cross_reference_deps option.
3188         (get_webkit1_options): Ditto
3189         (rebase_installed_docs): Helper function to create a generator for
3190         the given pkg-config file and options and call rebase_installed_docs.
3191         * gtk/gtkdoc.py:
3192         (GTKDoc.__init__): Initialize cross_reference_deps.
3193         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
3194         dependencies.
3195         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
3196         links of installed documentation.
3197         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
3198         file.
3199
3200 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
3201
3202         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
3203         https://bugs.webkit.org/show_bug.cgi?id=77672
3204
3205         Reviewed by Dirk Pranke.
3206
3207         Test repetitions must be taken into account when working out
3208         the statistics shown by run-webkit-tests.
3209
3210         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3211         (Manager.prepare_lists_and_print_output):
3212         (Manager._print_result_summary):
3213         * Scripts/webkitpy/layout_tests/models/result_summary.py:
3214         (ResultSummary.__init__):
3215         (ResultSummary.add):
3216         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3217         (MainTest.test_repeat_each_iterations_num_tests):
3218
3219 2012-02-05  Dan Bernstein  <mitz@apple.com>
3220
3221         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
3222         https://bugs.webkit.org/show_bug.cgi?id=77823
3223
3224         Reviewed by Anders Carlsson.
3225
3226         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3227         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
3228
3229 2012-02-04  Dan Bernstein  <mitz@apple.com>
3230
3231         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
3232         https://bugs.webkit.org/show_bug.cgi?id=77822
3233
3234         Reviewed by Sam Weinig.
3235
3236         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3237         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
3238
3239 2012-02-04  Sam Weinig  <sam@webkit.org>
3240
3241         Add ability to send WKURLRequests in WebKit2 API user messages
3242         https://bugs.webkit.org/show_bug.cgi?id=77819
3243
3244         Reviewed by Anders Carlsson.
3245
3246         Add testing for round-tripping WKTypes from the UIProcess,
3247         to the WebProcess, and back.
3248
3249         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
3250           More can easily be added.
3251
3252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3253         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
3254         (TestWebKitAPI):
3255         (WebKit2UserMessageRoundTripTest):
3256         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
3257         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
3258         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
3259         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
3260         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
3261         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
3262         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
3263         (TestWebKitAPI::TEST_F):
3264         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
3265         (TestWebKitAPI):
3266         (UserMessageTest):
3267         (TestWebKitAPI::UserMessageTest::UserMessageTest):
3268         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
3269         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3270         (TestWebKitAPI::PlatformWebView::resizeTo):
3271         (TestWebKitAPI):
3272         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3273         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3274
3275 2012-02-04  Dan Bernstein  <mitz@apple.com>
3276
3277         <rdar://problem/10772406> WKPreferences instances cannot be copied
3278         https://bugs.webkit.org/show_bug.cgi?id=77816
3279
3280         Reviewed by Sam Weinig.
3281
3282         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3283         (TestWebKitAPI::TEST):
3284
3285 2012-02-04  Adam Barth  <abarth@webkit.org>
3286
3287         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
3288         https://bugs.webkit.org/show_bug.cgi?id=77802
3289
3290         Reviewed by Eric Seidel.
3291
3292         This patch refactors our directory grouping code into base.js where it
3293         can be shared between failures.js and notifications.js.  It then adds
3294         an Examine action to each group of failures that triggers the "results"
3295         view.
3296
3297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3298         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3300         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3301         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3302         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
3303
3304 2012-02-04  Ojan Vafai  <ojan@chromium.org>
3305
3306         check-webkit-style is throwing an exception
3307         https://bugs.webkit.org/show_bug.cgi?id=77744
3308
3309         Reviewed by David Levin.
3310
3311         If the test_list is None, then we don't need to check for unsupported
3312         feature tests to skip.
3313
3314         * Scripts/webkitpy/layout_tests/port/webkit.py:
3315         (WebKitPort._has_test_in_directories):
3316         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3317         (test_skipped_tests_for_unsupported_features_empty_test_list):
3318
3319 2012-02-03  Adam Barth  <abarth@webkit.org>
3320
3321         List of all failures in garden-o-matic should actually list all the failures
3322         https://bugs.webkit.org/show_bug.cgi?id=77796
3323
3324         Reviewed by Eric Seidel.
3325
3326         This patch wires a bit more data into the new "All Failures" tab.  I've
3327         also iterated on how we enable this experimental feature.  The tab is
3328         still just a dumb list, but we'll make it smarter.
3329
3330         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3331         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3332         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3334
3335 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3336
3337         Windows build fix after r106692.
3338
3339         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3340         (PortTest.test_reference_files):
3341
3342 2012-02-03  Beth Dakin  <bdakin@apple.com>
3343
3344         https://bugs.webkit.org/show_bug.cgi?id=77782
3345         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than 
3346         once on some pages with frames
3347         -and corresponding-
3348         <rdar://problem/10798474>
3349
3350         Reviewed by Sam Weinig.
3351
3352         One new test.
3353         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3354         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
3355         (TestWebKitAPI):
3356         (TestWebKitAPI::didForceRepaint):
3357         (TestWebKitAPI::didFinishLoadForFrame):
3358         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3359         (TestWebKitAPI::setPageLoaderClient):
3360         (TestWebKitAPI::TEST):
3361         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
3362         (TestWebKitAPI):
3363         (NewFirstVisuallyNonEmptyLayoutFramesTest):
3364         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
3365         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
3366         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
3367
3368 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
3369
3370         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
3371         https://bugs.webkit.org/show_bug.cgi?id=77781
3372
3373         Reviewed by Eric Seidel.
3374
3375         This change fixes a couple of issues discovered while debugging
3376         test-webkitpy; both calling exit() instead of sys.exit() --
3377         which is discouraged in program code instead of the interpreter
3378         -- and a particular usage of outputcapture were stdin to get whacked
3379         and preventing debugging.
3380        
3381         This change introduces a couple of common _exit() methods that
3382         will standardize how webkit-patch exit's, in case we need to do
3383         something different in the future.
3384
3385         * Scripts/webkitpy/common/system/deprecated_logging.py:
3386         (error):
3387         * Scripts/webkitpy/common/system/outputcapture.py:
3388         (OutputCapture.assert_outputs):
3389         * Scripts/webkitpy/tool/bot/queueengine.py:
3390         (QueueEngine.exit_after_handled_error):
3391         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3392         (AbstractSequencedCommand.execute):
3393         * Scripts/webkitpy/tool/commands/queues.py:
3394         (StyleQueue.handle_script_error):
3395         * Scripts/webkitpy/tool/commands/upload.py:
3396         (MarkBugFixed.execute):
3397         * Scripts/webkitpy/tool/multicommandtool.py:
3398         (Command._exit):
3399         * Scripts/webkitpy/tool/steps/abstractstep.py:
3400         (AbstractStep._exit):
3401         * Scripts/webkitpy/tool/steps/checkstyle.py:
3402         (CheckStyle.run):
3403         * Scripts/webkitpy/tool/steps/commit.py:
3404         (Commit._check_test_expectations):
3405         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3406         (ConfirmDiff.run):
3407
3408 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3409
3410         Perf bot build fix.
3411
3412         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3413         (PerfTestsRunner._generate_json):
3414
3415 2012-02-03  Adam Barth  <abarth@webkit.org>
3416
3417         Add a blank "Expected Failures" tab to garden-o-matic
3418         https://bugs.webkit.org/show_bug.cgi?id=77793
3419
3420         Reviewed by Eric Seidel.
3421
3422         This tab will help us explore and manage our expected failures.  The
3423         tab is hidden by default via a new "experimental features" flag.
3424
3425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
3430         (#unexpected):
3431         (#onebar.partytime #unexpected):
3432
3433 2012-02-03  Lucas Forschler  <lforschler@apple.com>
3434
3435         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
3436         https://bugs.webkit.org/show_bug.cgi?id=77785
3437
3438         Fix the build bots.
3439         
3440         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
3441
3442         * Scripts/update-webkit-support-libs:
3443         (downloadExpectedVersionNumber):
3444
3445 2012-02-03  Lucas Forschler  <lforschler@apple.com>
3446
3447         Add a Mac Lion Performance bot.
3448         https://bugs.webkit.org/show_bug.cgi?id=77765
3449
3450         Reviewed by Adam Roben.
3451
3452         This will update the master configuration in the following ways:
3453             Add a new performance slave (apple-xseve-11)
3454             Add a new Factory to download a build and run perf tests.
3455             
3456         * BuildSlaveSupport/build.webkit.org-config/config.json:
3457         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3458         (DownloadAndPerfTestFactory):
3459         (DownloadAndPerfTestFactory.__init__):
3460
3461 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
3462
3463         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
3464         https://bugs.webkit.org/show_bug.cgi?id=77752
3465
3466         Reviewed by James Robinson.
3467
3468         Delete unneeded file accidentally checked in in r106481.
3469
3470         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
3471
3472 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3473
3474         Ref Tests should support plain SVG files
3475         https://bugs.webkit.org/show_bug.cgi?id=77685
3476
3477         Reviewed by Tony Chang.
3478
3479         Don't assume reference files always use .html as the extension.
3480         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
3481
3482         Also fix various bugs in MockFileSystem and TestPort.
3483
3484         * Scripts/webkitpy/common/system/filesystem_mock.py:
3485         (MockFileSystem.isdir):
3486         * Scripts/webkitpy/layout_tests/port/base.py:
3487         (Port.reference_files):
3488         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3489         (PortTest.test_is_test_file):
3490         (PortTest.test_reference_files):
3491         * Scripts/webkitpy/layout_tests/port/test.py:
3492         (TestInstance.__init__):
3493
3494 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3495
3496         perf-o-matic should store chromium svn revision
3497         https://bugs.webkit.org/show_bug.cgi?id=77725
3498
3499         Reviewed by Dirk Pranke.
3500
3501         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
3502         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
3503         is implemented in terms of newly added svn_revision.
3504
3505         * Scripts/webkitpy/common/checkout/scm/git.py:
3506         (Git.svn_revision):
3507         * Scripts/webkitpy/common/checkout/scm/scm.py:
3508         (SCM.head_svn_revision):
3509         (SCM):
3510         (SCM.svn_revision):
3511         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3512         (MockSCM.svn_revision):
3513         * Scripts/webkitpy/common/checkout/scm/svn.py:
3514         (SVN.svn_revision):
3515         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3516         (JSONLayoutResultsGenerator.__init__):
3517         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3518         (JSONResultsGeneratorBase._insert_generic_metadata):
3519         * Scripts/webkitpy/layout_tests/port/base.py:
3520         (Port.repository_paths):
3521         * Scripts/webkitpy/layout_tests/port/chromium.py:
3522         (ChromiumPort.repository_paths):
3523         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3524         (PerfTestsRunner._generate_json):
3525         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3526         (test_run_test_set_with_json_output):
3527         (test_run_test_set_with_json_source):
3528         (test_run_test_set_with_multiple_repositories):
3529
3530 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3531
3532         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
3533         https://bugs.webkit.org/show_bug.cgi?id=77632
3534
3535         Reviewed by Kenneth Rohde Christiansen.
3536
3537         * MiniBrowser/qt/BrowserWindow.cpp:
3538         (BrowserWindow::BrowserWindow):
3539         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3540         (MiniBrowserApplication::sendTouchEvent):
3541         (MiniBrowserApplication::handleUserOptions):
3542         * MiniBrowser/qt/MiniBrowserApplication.h:
3543         (WindowOptions):
3544         (WindowOptions::WindowOptions):
3545         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3546         (WTR::PlatformWebView::PlatformWebView):
3547         * WebKitTestRunner/qt/main.cpp:
3548         (main):
3549         * qmake/mkspecs/features/default_post.prf:
3550
3551 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
3552
3553         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
3554         https://bugs.webkit.org/show_bug.cgi?id=77723
3555
3556         Reviewed by Tor Arne Vestbø.
3557
3558         * Tools.pro: Compile WTR again on all platforms with WK2.
3559
3560 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
3561
3562         Ensure that inspector disabled build works
3563         https://bugs.webkit.org/show_bug.cgi?id=77604
3564
3565         Reviewed by Tor Arne Vestbø.
3566
3567         * qmake/mkspecs/features/features.prf:
3568
3569 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
3570
3571         [chromium] add support for --makeargs to the ninja-based build
3572         https://bugs.webkit.org/show_bug.cgi?id=77688
3573
3574         Reviewed by Adam Barth.
3575
3576         * Scripts/webkitdirs.pm:
3577         (buildChromiumNinja):
3578
3579 2012-02-02  Eric Seidel  <eric@webkit.org>
3580
3581         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
3582         https://bugs.webkit.org/show_bug.cgi?id=75145
3583
3584         Reviewed by Dirk Pranke.
3585
3586         * Scripts/webkitpy/layout_tests/port/mac.py:
3587         (MacPort.default_child_processes):
3588         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3589         (test_operating_system):
3590         (test_default_child_processes):
3591
3592 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
3593
3594        nrwt shouldn't blow up when there are errors in test_expectations.txt
3595        https://bugs.webkit.org/show_bug.cgi?id=73603
3596
3597        Reviewed by Ojan Vafai.
3598
3599        This change removes the distinction between 'errors' and 'warnings'
3600        in the test expectations parser. Now, any problem is a
3601        'warning', and if we are linting the file, warnings become fatal (errors).
3602
3603         This will allow a normal run-webkit-tests run to proceed even if
3604         there are bad lines.
3605
3606         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3607         (ParseError.__init__):
3608         (ParseError.__str__):
3609         (ParseError.__repr__):
3610         (TestExpectationSerializer.to_string):
3611         (TestExpectationParser._parse_modifiers):
3612         (TestExpectationParser._parse_expectations):
3613         (TestExpectationParser._check_modifiers_against_expectations):
3614         (TestExpectationParser._tokenize):
3615         (TestExpectationLine.__init__):
3616         (TestExpectationLine.is_invalid):
3617         (TestExpectationsModel.add_expectation_line):
3618         (TestExpectationsModel._already_seen_better_match):
3619         (TestExpectations.__init__):
3620         (TestExpectations._report_warnings):
3621         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
3622         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3623         (assert_bad_expectations):
3624         (test_parse_warning):
3625         (test_overrides__duplicate):
3626         (ExpectationSyntaxTests.test_missing_expectation):
3627         (ExpectationSyntaxTests.test_missing_colon):
3628         (ExpectationSyntaxTests.test_too_many_colons):
3629         (ExpectationSyntaxTests.test_too_many_equals_signs):
3630         (ExpectationSyntaxTests.test_unrecognized_expectation):
3631         (SemanticTests.test_bug_format):
3632         (SemanticTests.test_bad_bugid):
3633         (SemanticTests.test_slow_and_timeout):
3634         (test_ambiguous):
3635         (test_more_modifiers):
3636         (test_order_in_file):
3637         (test_macro_overrides):
3638         (RebaseliningTest.assertRemove):
3639         (TestExpectationParserTests.test_tokenize_blank):
3640         (TestExpectationParserTests.test_tokenize_missing_colon):
3641         (TestExpectationParserTests.test_tokenize_extra_colon):
3642         (TestExpectationParserTests.test_tokenize_empty_comment):
3643         (TestExpectationParserTests.test_tokenize_comment):
3644         (TestExpectationParserTests.test_tokenize_missing_equal):
3645         (TestExpectationParserTests.test_tokenize_extra_equal):
3646         (TestExpectationParserTests.test_tokenize_valid):
3647         (TestExpectationParserTests.test_tokenize_valid_with_comment):
3648         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
3649         (TestExpectationSerializerTests.test_unparsed_to_string):
3650         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3651         (lint):
3652         * Scripts/webkitpy/style/checkers/test_expectations.py:
3653         (TestExpectationsChecker.check_test_expectations):
3654
3655 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3656
3657         Unreviewed, rolling out r106543.
3658         http://trac.webkit.org/changeset/106543
3659         https://bugs.webkit.org/show_bug.cgi?id=77671
3660
3661         Made tests less stable (Requested by rniwa on #webkit).
3662
3663         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3664         (PerfTestsRunner):
3665         (PerfTestsRunner.__init__):
3666         (PerfTestsRunner._run_tests_set):
3667         (PerfTestsRunner._run_single_test):
3668         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3669         (MainTest.TestDriver.run_test):
3670         (run_test):
3671
3672 2012-02-02  Beth Dakin  <bdakin@apple.com>
3673
3674         https://bugs.webkit.org/show_bug.cgi?id=77664
3675         Add API tests for didNewFirstVisuallyNonEmptyLayout
3676
3677         Reviewed by Darin Adler.
3678
3679         Two new tests.
3680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3681         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
3682         (TestWebKitAPI):
3683         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3684         (TestWebKitAPI::setPageLoaderClient):
3685         (TestWebKitAPI::TEST):
3686         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
3687         (TestWebKitAPI):
3688         (TestWebKitAPI::didForceRepaint):
3689         (TestWebKitAPI::didFinishLoadForFrame):
3690         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3691         (TestWebKitAPI::setPageLoaderClient):
3692         (TestWebKitAPI::TEST):
3693         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
3694         (TestWebKitAPI):
3695         (NewFirstVisuallyNonEmptyLayoutFailsTest):
3696         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
3697         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
3698         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
3699         (TestWebKitAPI):
3700         (NewFirstVisuallyNonEmptyLayoutTest):
3701         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
3702         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
3703
3704 2012-02-02  Michael Saboff  <msaboff@apple.com>
3705
3706         Add Michael Saboff to reviewers list.
3707
3708         Rubber-stamped by Gavin Barraclough.
3709
3710         * Scripts/webkitpy/common/config/committers.py:
3711
3712 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3713
3714         Add myself as a committer
3715
3716         Unreviewed
3717