1 2011-04-20 Leo Yang <leo.yang@torchmobile.com.cn>
5 Adding myself to committers.py.
7 * Scripts/webkitpy/common/config/committers.py:
9 2011-04-20 Adam Barth <abarth@webkit.org>
11 Reviewed by Eric Seidel.
13 webkit-patch upload should assign the bug to you
14 https://bugs.webkit.org/show_bug.cgi?id=33699
16 This patch only re-assigns the bug if it is currently unassigned. We
17 can be more aggressive in the future if people want us to be more
20 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
21 * Scripts/webkitpy/tool/commands/upload_unittest.py:
22 * Scripts/webkitpy/tool/mocktool.py:
23 * Scripts/webkitpy/tool/steps/postdiff.py:
25 2011-04-20 Peter Gal <galpeter@inf.u-szeged.hu>
27 Reviewed by Csaba Osztrogonác.
29 Modify builder.html template to allow easy access
30 to list more builds on the builder's page.
32 https://bugs.webkit.org/show_bug.cgi?id=59008
34 * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
36 2011-04-20 Peter Gal <galpeter@inf.u-szeged.hu>
38 Reviewed by Csaba Osztrogonác.
40 Add the default template for builder page.
42 https://bugs.webkit.org/show_bug.cgi?id=59008
44 * BuildSlaveSupport/build.webkit.org-config/templates/builder.html: Added.
46 2011-04-20 Ojan Vafai <ojan@chromium.org>
48 Reviewed by Eric Seidel.
50 move page generation into a single function
51 https://bugs.webkit.org/show_bug.cgi?id=59027
53 Now executing the script doesn't create any state. We should then
54 be able to write tests for this by setting custom results data.
56 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
58 2011-04-20 Ojan Vafai <ojan@chromium.org>
60 Reviewed by Eric Seidel.
62 move global state into a shared object
63 https://bugs.webkit.org/show_bug.cgi?id=59023
65 This makes the code more testable.
67 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
69 2011-04-20 Ojan Vafai <ojan@chromium.org>
71 Reviewed by Tony Chang.
73 move global state into a shared object
74 https://bugs.webkit.org/show_bug.cgi?id=59023
76 This makes the code more testable.
78 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
80 2011-04-20 Ojan Vafai <ojan@chromium.org>
82 Reviewed by Eric Seidel.
84 add expandAll/collapseAll links
85 https://bugs.webkit.org/show_bug.cgi?id=59011
87 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
89 2011-04-20 Kevin Ollivier <kevino@theolliviers.com>
91 [wx] Unreviewed build fixes for wx 2.9.1, Cocoa and 64-bit builds.
93 * Scripts/webkitdirs.pm:
94 * wx/build/build_utils.py:
95 * wx/build/settings.py:
96 * wx/install-unix-extras:
97 * wx/packaging/build-mac-installer.py:
98 * wx/packaging/build-win-installer.py:
100 2011-04-20 Adam Roben <aroben@apple.com>
102 Replace old-run-webkit-tests's win-7 platform with win-7sp0
104 It was an error that we had a win-7 platform to begin with. Windows 7 was the most recent
105 version of Windows we cared about, so its results should just go in win. But now that
106 Windows 7 SP1 exists (and has different results for some tests), we need a place to store
107 results for Windows 7 without SP1 (and older versions of Windows).
109 Part of <http://webkit.org/b/56617> Several tests fail on Windows 7 SP1 due to font
110 differences from Windows 7 "SP0"
112 Reviewed by David Kilzer.
114 * Scripts/old-run-webkit-tests: Replaced win-7 with win-7sp0. Newer versions of Windows 7
117 * Scripts/webkitdirs.pm:
118 (isWindows7SP0): Added. Replaces isWindows7, because that function had no remaining callers.
120 2011-04-20 Adam Roben <aroben@apple.com>
122 Teach webkitdirs::winVersion about build numbers
124 The build number isn't currently used, but soon will be.
126 As a bonus, winVersion now works on non-Cygwin variants of Perl!
128 Fixes <http://webkit.org/b/58991> Need a way to distinguish between Windows 7 and Windows 7
131 Reviewed by Anders Carlsson.
133 * Scripts/webkitdirs.pm:
134 (isAnyWindows): Added. Returns true if we're running on any Windows-ish Perl.
135 (determineWinVersion): Use `cmd /c ver` to get the version number, including the build
136 number. Parse the version number into a hash, similar to how osXVersion() works.
141 Updated for changes to winVersion().
143 2011-04-20 W. James MacLean <wjmaclean@chromium.org>
145 Reviewed by Kenneth Russell.
147 Add support for composite-to-texture to DumpRenderTree.
148 https://bugs.webkit.org/show_bug.cgi?id=58675
150 * DumpRenderTree/chromium/DumpRenderTree.cpp:
152 * DumpRenderTree/chromium/TestShell.cpp:
153 (TestShell::TestShell):
154 (TestShell::resetWebSettings):
155 * DumpRenderTree/chromium/TestShell.h:
156 (TestShell::setCompositeToTexture):
157 * DumpRenderTree/chromium/WebPreferences.cpp:
158 (WebPreferences::reset):
159 (WebPreferences::applyTo):
160 * DumpRenderTree/chromium/WebPreferences.h:
162 2011-04-19 Eric Seidel <eric@webkit.org>
164 Reviewed by Adam Barth.
166 The commit-queue is confused when non-layout tests fail
167 https://bugs.webkit.org/show_bug.cgi?id=58955
169 As seen in http://queues.webkit.org/results/8474435
171 It fails to create an archive of the layout test results
172 and then throws an exception.
174 I've fixed this by making it catch the exception as well
175 as made it so it never calls that path in the common case.
177 I've updated MockFileSystem to understand rmtree's affect on
178 directories as well as files.
180 * Scripts/webkitpy/common/system/filesystem_mock.py:
181 * Scripts/webkitpy/common/system/workspace.py:
182 * Scripts/webkitpy/tool/commands/queues.py:
183 * Scripts/webkitpy/tool/commands/queues_unittest.py:
184 * Scripts/webkitpy/tool/mocktool.py:
186 2011-04-19 Ojan Vafai <ojan@chromium.org>
188 Fix check for whether a failure is expected to deal with
189 flaky tests and FAIL expectations.
190 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
192 2011-04-19 Ojan Vafai <ojan@chromium.org>
194 Reviewed by Eric Seidel.
196 don't show missing text results for tests that only dump image results
197 https://bugs.webkit.org/show_bug.cgi?id=58931
199 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
200 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
202 2011-04-19 Ojan Vafai <ojan@chromium.org>
204 Reviewed by Eric Seidel.
206 don't show failures table if there are only new tests
207 https://bugs.webkit.org/show_bug.cgi?id=58929
209 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
211 2011-04-19 Ojan Vafai <ojan@chromium.org>
213 Reviewed by Eric Seidel.
215 don't show failures table if there are only new tests
216 https://bugs.webkit.org/show_bug.cgi?id=58929
218 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
220 2011-04-19 Ojan Vafai <ojan@chromium.org>
222 Fix unittest failures from http://trac.webkit.org/changeset/84294.
224 * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
225 * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
227 2011-04-18 Ojan Vafai <ojan@chromium.org>
229 Reviewed by Eric Seidel.
231 switch new-run-webkit-tests to using the new results file
232 https://bugs.webkit.org/show_bug.cgi?id=58861
234 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
235 * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
236 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
238 2011-04-19 Renata Hodovan <reni@webkit.org>
240 Reviewed by Eric Seidel.
242 Move the alignment related macros from Vector.h to new Alignment.h.
243 https://bugs.webkit.org/show_bug.cgi?id=56000
245 Adding the new file to the forwarding headers of Tools.
247 * DumpRenderTree/ForwardingHeaders/wtf/Alignment.h: Added.
249 2011-04-19 Kevin Ollivier <kevino@theolliviers.com>
251 [wx] Unreviewed build fix for Win / wx 2.9 wxPython installation.
253 * wx/packaging/build-win-installer.py:
254 * wx/packaging/wxWebKitInstaller.iss.in:
256 2011-04-19 Adam Roben <aroben@apple.com>
258 Skip another accelerated-compositing-sensitive test when accelerated compositing is disabled
260 * Scripts/old-run-webkit-tests: Skip media/controls-without-preload.html on Windows when
261 accelerated compositing is disabled.
263 2011-04-19 Ojan Vafai <ojan@chromium.org>
265 Remove accidentally committed debug code.
266 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
268 2011-04-19 Brent Fulgham <bfulgham@webkit.org>
270 Unreviewed build correction.
272 Avoid duplicate stub implementation of test routine
275 * WebKitTestRunner/win/TestInvocationWin.cpp: Exclude
276 WinCairo from using this stub.
278 2011-04-18 Ojan Vafai <ojan@chromium.org>
280 Reviewed by Eric Seidel.
282 make results file work with audio and reftests
283 https://bugs.webkit.org/show_bug.cgi?id=58860
285 Also fix bug with timeout tests and store a bit in the JSON
286 for new image tests instead of loading the image result to check if it's there.
288 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
289 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
291 2011-04-19 Jer Noble <jer.noble@apple.com>
293 Reviewed by Adam Roben.
295 REGRESSION (r84206): 50 tests failing on SnowLeopard Intel Release (WebKit2 Tests) due to extra "supportsFullScreen() == true" output
296 https://bugs.webkit.org/show_bug.cgi?id=58890
298 Add a layoutTestController flag which controls when full screen callbacks are written to stdout.
301 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpFullScreenCallbacks().
302 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
303 (WTR::InjectedBundlePage::supportsFullScreen): Only write to stdout if shouldDumpFullScreenCallbacks is set.
304 (WTR::InjectedBundlePage::enterFullScreenForElement): Ditto.
305 (WTR::InjectedBundlePage::exitFullScreenForElement): Ditto.
306 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
307 (WTR::LayoutTestController::LayoutTestController): Initialize new ivar.
308 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
309 (WTR::LayoutTestController::dumpFullScreenCallbacks): Added.
310 (WTR::LayoutTestController::shouldDumpFullScreenCallbacks): Added.
312 2011-04-19 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
314 Reviewed by Andreas Kling.
316 [Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
317 https://bugs.webkit.org/show_bug.cgi?id=35086
319 fast/xmlhttprequest/xmlhttprequest-no-file-access.html caused
320 a DRT sideeffect problem, because the resetSettings didn't set
321 the default value of LocalContentCanAccessFileUrls.
323 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
324 (WebCore::WebPage::resetSettings):
326 2011-04-18 Zan Dobersek <zandobersek@gmail.com>
328 Reviewed by Martin Robinson.
330 [GTK] Need support for dumping focus rectangles in pixel results
331 https://bugs.webkit.org/show_bug.cgi?id=53647
333 Dump the selection rect if it has been requested.
335 * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
336 (createBitmapContextFromWebView):
338 2011-04-18 Eric Seidel <eric@webkit.org>
340 Reviewed by Adam Barth.
342 test-webkitpy should run the ActiveWorkItems tests
343 https://bugs.webkit.org/show_bug.cgi?id=58859
345 Also make the unit tests pass. :)
347 * QueueStatusServer/model/activeworkitems.py:
348 * QueueStatusServer/model/queue.py:
349 * QueueStatusServer/model/workitems.py:
351 2011-04-18 Eric Seidel <eric@webkit.org>
353 Reviewed by Adam Barth.
355 queues.webkit.org should show trailing-days pass counts for queues
356 https://bugs.webkit.org/show_bug.cgi?id=58812
358 This lets us see if each bot is pulling its own weight or not.
359 Before I wrote this patch our suspicious was that one of the
360 cq bots was doing most of the work. Turns out they're actually
361 pretty even in their recent pass counts.
363 * QueueStatusServer/handlers/queuestatus.py:
364 * QueueStatusServer/index.yaml:
365 * QueueStatusServer/templates/queuestatus.html:
367 2011-04-18 Dirk Pranke <dpranke@chromium.org>
369 Reviewed by Eric Seidel.
371 new-run-webkit-tests: obsolete old threading code, part 1
372 https://bugs.webkit.org/show_bug.cgi?id=58752
374 This patch removes support for the 'old-inline' and
375 'old-threads' worker models, and deletes the corresponding code.
376 Now that the new code is stable, this stuff is no longer
379 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Removed.
380 * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
381 * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
382 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
383 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
384 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
386 2011-04-18 Dirk Pranke <dpranke@chromium.org>
388 Reviewed by Eric Seidel.
390 new-run-webkit-tests: add an --additional-drt-flag option
391 https://bugs.webkit.org/show_bug.cgi?id=58680
393 NRWT has a bunch of command line flags that exist to pass
394 custom flags to DRT, especially on chromium. It would be nice
395 if there was a generic mechanism to pass through flags so we
396 didn't have all the custom ones.
398 * Scripts/webkitpy/layout_tests/port/chromium.py:
399 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
400 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
401 * Scripts/webkitpy/layout_tests/port/test.py:
402 * Scripts/webkitpy/layout_tests/port/webkit.py:
403 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
405 2011-04-05 Jer Noble <jer.noble@apple.com>
407 Reviewed by Sam Weinig.
409 WebKit2: WKTR should support WebKit2 full screen APIs
410 https://bugs.webkit.org/show_bug.cgi?id=56318
412 Respond to enterFullScreenForElement() and exitFullScreenForElement(), allowing
413 WKTR to test the LayoutTest/fullscreen/ tests.
415 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
416 (WTR::InjectedBundlePage::InjectedBundlePage): Add support for WKBundlePageFullScreenClient.
417 (WTR::InjectedBundlePage::supportsFullScreen): Added.
418 (WTR::InjectedBundlePage::enterFullScreenForElement): Added.
419 (WTR::InjectedBundlePage::exitFullScreenForElement): Added.
420 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
421 * WebKitTestRunner/TestController.cpp:
422 (WTR::TestController::resetStateToConsistentValues): Enable the full screen preference.
424 2011-04-18 Dirk Pranke <dpranke@chromium.org>
426 Reviewed by Tony Chang.
428 new-run-webkit-tests: remove chromium-specific relpath hack for --results-directory
429 https://bugs.webkit.org/show_bug.cgi?id=58388
431 * Scripts/webkitpy/layout_tests/port/chromium.py:
433 2011-04-18 Evan Martin <evan@chromium.org>
435 Reviewed by Eric Seidel.
437 [chromium] expose title direction to webkit client
438 https://bugs.webkit.org/show_bug.cgi?id=58823
440 * DumpRenderTree/chromium/LayoutTestController.cpp:
441 (LayoutTestController::LayoutTestController):
442 (LayoutTestController::reset):
443 * DumpRenderTree/chromium/LayoutTestController.h:
444 (LayoutTestController::setTitleTextDirection):
445 Add member and setter to let us stash the title direction at load time.
447 * DumpRenderTree/chromium/WebViewHost.cpp:
448 (WebViewHost::didReceiveTitle):
449 * DumpRenderTree/chromium/WebViewHost.h:
450 Adapt to new API; push the title into layoutTestController when we
453 2011-04-18 Dirk Pranke <dpranke@chromium.org>
457 Re-land r84112. It was rolled out in r84127 but it didn't need
458 to be. Only r84111 actually broke things.
460 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
461 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
463 2011-04-18 Dirk Pranke <dpranke@chromium.org>
465 Reviewed by Tony Chang.
467 new-run-webkit-tests: don't run more processes than necessary
468 https://bugs.webkit.org/show_bug.cgi?id=58751
470 Previously NRWT would start up 1 process for each processor on
471 the machine by default, which was a waste if we were only
472 running a few shards of tests.
474 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
475 * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
476 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
478 2011-04-18 Ojan Vafai <ojan@chromium.org>
480 Reviewed by Eric Seidel.
482 include links to actual.png files for new pixel tests
483 https://bugs.webkit.org/show_bug.cgi?id=58831
485 Load image elements to confirm whether the files exist.
486 Image elements will load without being appended to the DOM.
488 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
490 2011-04-18 Ojan Vafai <ojan@chromium.org>
492 Reviewed by Eric Seidel.
494 add a zoomed view for pixel results to the new results html file
495 https://bugs.webkit.org/show_bug.cgi?id=58827
497 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
499 2011-04-18 Ojan Vafai <ojan@chromium.org>
501 Reviewed by Eric Seidel.
503 add labels to results html page
504 https://bugs.webkit.org/show_bug.cgi?id=58803
506 -fix iframe size to be the size of the png results
507 -fix a bunch of aesthetic nits
508 -fix some incorrectly styled code
510 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
512 2011-04-18 Chang Shu <cshu@webkit.org>
514 Reviewed by Eric Seidel.
516 WebKitTestRunner needs layoutTestController.pathToLocalResource
517 https://bugs.webkit.org/show_bug.cgi?id=42541
519 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
520 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
521 * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
522 (WTR::LayoutTestController::pathToLocalResource):
523 * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
524 (WTR::LayoutTestController::pathToLocalResource):
525 * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
526 (WTR::LayoutTestController::pathToLocalResource):
528 2011-04-18 Timothy Hatcher <timothy@apple.com>
530 Make update-webkit-localizable-strings put WebKit/win strings in WebCore
531 now that all localized strings in WebKit/win use WEB_UI_STRING.
533 https://webkit.org/b/58747
535 Reviewed by Dan Bernstein.
537 * Scripts/update-webkit-localizable-strings: Remove the code that updated WebKit/win differently.
539 2011-04-18 Patrick Gansterer <paroga@webkit.org>
541 Reviewed by Adam Roben.
543 [WIN] Use WCHAR instead of TCHAR
544 https://bugs.webkit.org/show_bug.cgi?id=58755
546 We always use the UNICODE versions of windows functions, so
547 the usage of TCHAR makes no sense and mixing them is bad style.
549 * WinLauncher/PrintWebUIDelegate.cpp:
550 Also fix various style issues (including indentation and removal of ugly C-casts).
551 * WinLauncher/WinLauncher.cpp:
553 2011-04-18 Dominic Cooney <dominicc@chromium.org>
555 Reviewed by Andreas Kling.
557 Add layoutTestController.shadowRoot to Qt DRT.
558 https://bugs.webkit.org/show_bug.cgi?id=58759
560 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
561 (LayoutTestController::shadowRoot): Added.
562 * DumpRenderTree/qt/LayoutTestControllerQt.h:
564 2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
566 Unreviewed, rolling out r84111.
567 http://trac.webkit.org/changeset/84111
568 https://bugs.webkit.org/show_bug.cgi?id=58771
570 Chromium linux layout tests are broken. (Requested by loislo2
573 * Scripts/webkitpy/layout_tests/port/chromium.py:
574 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
575 * Scripts/webkitpy/layout_tests/port/mock_drt.py:
577 2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
579 Unreviewed, rolling out r84112.
580 http://trac.webkit.org/changeset/84112
581 https://bugs.webkit.org/show_bug.cgi?id=58770
583 Chromium linux layout tests are broken. (Requested by loislo2
586 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
587 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
589 2011-04-17 Daniel Bates <dbates@webkit.org>
591 Reviewed by Eric Seidel and Adam Barth.
593 webkit-patch land hangs if svn prompts for credentials
594 https://bugs.webkit.org/show_bug.cgi?id=31500
596 Prompt for username and password when using git-svn and there aren't cached SVN credentials.
598 * Scripts/webkitpy/common/checkout/scm.py:
599 - Added mixin class SVNRepository and made both class SVN and Git inherit from it.
600 - Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value
601 for argument realm; modified call sites as needed.
602 - Modified AuthenticationError constructor to take optional prompt_for_password argument.
603 - Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument.
604 - Modified Git._commit_on_branch() to take optional username and password argument.
605 - Modified Git.push_local_commits_to_server() to take optional username and password
606 argument and to call has_authorization_for_realm().
607 * Scripts/webkitpy/common/checkout/scm_unittest.py:
608 - Modified SVNTest.test_commit_without_authorization() to take dummy realm argument.
609 - Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to
610 SVN.has_authorization_for_realm().
611 * Scripts/webkitpy/common/net/credentials.py:
612 - Modified Credentials.read_credentials() to call User.prompt_password() instead
613 of using getpass.getpass() directly.
614 * Scripts/webkitpy/common/system/user.py:
615 - Added User.prompt_password().
616 * Scripts/webkitpy/tool/steps/commit.py:
617 - Modified Commit.run() to prompt for a password if needed.
619 2011-04-17 Dirk Pranke <dpranke@chromium.org>
621 Reviewed by Ojan Vafai.
623 new-run-webkit-tests: save stderr into the layout-test-results dir
624 https://bugs.webkit.org/show_bug.cgi?id=58690
626 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
627 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
629 2011-04-17 Dirk Pranke <dpranke@chromium.org>
631 Reviewed by Ojan Vafai.
633 new-run-webkit-tests: read stderr from chromium DRT separately
634 https://bugs.webkit.org/show_bug.cgi?id=58708
636 * Scripts/webkitpy/layout_tests/port/chromium.py:
637 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
638 * Scripts/webkitpy/layout_tests/port/mock_drt.py:
640 2011-04-17 Patrick Gansterer <paroga@webkit.org>
642 Reviewed by Adam Barth.
644 Rename PLATFORM(CA) to USE(CA)
645 https://bugs.webkit.org/show_bug.cgi?id=58742
647 * DumpRenderTree/mac/DumpRenderTree.mm:
648 (resetDefaultsToConsistentValues):
650 2011-04-17 Patrick Gansterer <paroga@webkit.org>
652 Reviewed by Adam Barth.
654 Rename PLATFORM(CG) to USE(CG)
655 https://bugs.webkit.org/show_bug.cgi?id=58729
657 * DumpRenderTree/PixelDumpSupport.cpp:
658 * DumpRenderTree/chromium/WebViewHost.cpp:
659 (WebViewHost::paintRect):
660 * DumpRenderTree/config.h:
661 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
662 (createBitmapContextFromWebView):
663 * TestWebKitAPI/PlatformWebView.h:
664 * WebKitTestRunner/config.h:
665 * WebKitTestRunner/win/TestInvocationWin.cpp:
667 2011-04-16 Patrick Gansterer <paroga@webkit.org>
669 Reviewed by Eric Seidel.
671 Rename PLATFORM(CAIRO) to USE(CAIRO)
672 https://bugs.webkit.org/show_bug.cgi?id=55192
674 * DumpRenderTree/PixelDumpSupport.cpp:
675 * DumpRenderTree/config.h:
676 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
677 (createBitmapContextFromWebView):
678 * WebKitTestRunner/config.h:
680 2011-04-16 Ojan Vafai <ojan@chromium.org>
682 Reviewed by Eric Seidel.
684 show diffs+test inline in the results page
685 https://bugs.webkit.org/show_bug.cgi?id=58723
687 Put each row in it's own tbody and sort based on tbodies. That way
688 we can append the results to the tbody inline as another table row.
690 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
692 2011-04-16 Ojan Vafai <ojan@chromium.org>
694 Reviewed by Eric Seidel.
696 handle new tests in the new results html file
697 https://bugs.webkit.org/show_bug.cgi?id=58715
699 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
701 2011-04-15 Dirk Pranke <dpranke@chromium.org>
703 Reviewed by Ojan Vafai.
705 old-run-webkit-tests: save the list of tests actually run to a file
706 https://bugs.webkit.org/show_bug.cgi?id=58692
708 * Scripts/old-run-webkit-tests:
710 2011-04-15 Dirk Pranke <dpranke@chromium.org>
712 Reviewed by Ojan Vafai.
714 fix MockFileSystem.abspath() on windows
715 https://bugs.webkit.org/show_bug.cgi?id=58713
717 The existing code was borked on Windows if a path was passed
718 in using a drive letter (e.g., "d:\foo.txt"), and would go
719 into an infinite recursive loop. While win paths shouldn't
720 normally be passed into the mock filesystem, this just
721 bulletproofs things a bit (note that "/foo.txt" is considered
722 an absolute path on windows python as well.
724 * Scripts/webkitpy/common/system/filesystem_mock.py:
726 2011-04-15 Ojan Vafai <ojan@chromium.org>
728 Reviewed by Eric Seidel.
730 show stderr files and httpd log files
731 https://bugs.webkit.org/show_bug.cgi?id=58714
733 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
734 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
736 2011-04-15 Shishir Agrawal <shishir@chromium.org>
738 Reviewed by James Robinson.
740 Add a flag to guard Page Visibility API changes.
741 https://bugs.webkit.org/show_bug.cgi?id=58464
743 * Scripts/build-webkit:
745 2011-04-15 Chang Shu <cshu@webkit.org>
747 Reviewed by Alexey Proskuryakov.
749 When a message with url embedded is added to console, the "file:" scheme
750 and path should be stripped.
751 https://bugs.webkit.org/show_bug.cgi?id=58665
753 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
754 (WTR::lastFileURLPathComponent):
755 (WTR::InjectedBundlePage::willAddMessageToConsole):
757 2011-04-15 Jeff Miller <jeffm@apple.com>
759 Reviewed by Sam Weinig.
761 Add takeFocus callback to WKPageUIClient
762 https://bugs.webkit.org/show_bug.cgi?id=58686
764 Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.
766 * MiniBrowser/mac/BrowserWindowController.m:
767 (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
768 * MiniBrowser/win/BrowserView.cpp:
769 (BrowserView::create): Added empty takeFocus entry.
770 * WebKitTestRunner/TestController.cpp:
771 (WTR::TestController::createOtherPage): Added empty takeFocus entry.
772 (WTR::TestController::initialize): Added empty takeFocus entry.
774 2011-04-15 Ojan Vafai <ojan@chromium.org>
776 Reviewed by Eric Seidel.
778 only show pretty-diff/wdiff if they were generated
779 https://bugs.webkit.org/show_bug.cgi?id=58682
781 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
782 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
783 * Scripts/webkitpy/layout_tests/port/base.py:
785 2011-04-15 Andreas Kling <kling@webkit.org>
787 Reviewed by Antonio Gomes.
789 [Qt] DRT: Default custom policy delegate decision should be Ignore.
791 If layoutTestController.setCustomPolicyDelegate() is called with only
792 one argument, the second ("permissive") should default to false.
794 * DumpRenderTree/qt/LayoutTestControllerQt.h:
796 2011-04-15 Ojan Vafai <ojan@chromium.org>
798 Reviewed by Eric Seidel.
800 fix path to layout test in new results file
801 https://bugs.webkit.org/show_bug.cgi?id=58618
803 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
804 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
806 2011-04-15 Ojan Vafai <ojan@chromium.org>
808 Reviewed by Eric Seidel.
810 fix sorting in new results file
811 https://bugs.webkit.org/show_bug.cgi?id=58616
813 -Fix the custom sort to return -1, 0, 1 instead of true/false.
814 -Secondary sort by test name when sort values are equal.
815 -Sort by test name by default.
817 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
819 2011-04-15 Dmitry Lomov <dslomov@google.com>
821 Reviewed by David Levin.
823 check-webkit-style shouldn't complain about not including a primary header file
825 https://bugs.webkit.org/show_bug.cgi?id=39514
827 * Scripts/webkitpy/style/checkers/cpp.py:
828 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
830 2011-04-15 Eric Seidel <eric@webkit.org>
832 Reviewed by Mihai Parparita.
834 queues.webkit.org should display when a bot last rebooted
835 https://bugs.webkit.org/show_bug.cgi?id=58562
837 There is more repeated code here than I would like. I fear
838 my django-fu isn't quite up to snuff.
840 * QueueStatusServer/handlers/queuestatus.py:
841 * QueueStatusServer/templates/queuestatus.html:
843 2011-04-14 Alok Priyadarshi <alokp@chromium.org>
845 Reviewed by Adam Barth.
847 Remove dependency on chromium skia::PlatformCanvas
848 https://bugs.webkit.org/show_bug.cgi?id=57563
850 Fixed compile error on Mac when using Core Graphics.
852 * DumpRenderTree/chromium/WebViewHost.cpp:
853 (WebViewHost::paintRect):
855 2011-04-14 Alok Priyadarshi <alokp@chromium.org>
857 Reviewed by James Robinson.
859 Remove dependency on chromium skia::PlatformCanvas
860 https://bugs.webkit.org/show_bug.cgi?id=57563
862 * DumpRenderTree/chromium/TestShell.cpp:
864 (TestShell::dumpImage):
865 * DumpRenderTree/chromium/TestShell.h:
866 * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
867 (WebThemeControlDRTWin::WebThemeControlDRTWin):
868 (WebThemeControlDRTWin::draw):
869 (WebThemeControlDRTWin::drawTextField):
870 (WebThemeControlDRTWin::drawProgressBar):
871 * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
872 * DumpRenderTree/chromium/WebViewHost.cpp:
873 (WebViewHost::canvas):
874 * DumpRenderTree/chromium/WebViewHost.h:
876 2011-04-14 Keith Kyzivat <keith.kyzivat@nokia.com>
878 Reviewed by Laszlo Gombos.
880 [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
881 https://bugs.webkit.org/show_bug.cgi?id=58007
883 Adds flag to start the test browsers maximized.
884 Symbian started maximized on QtTestBrowser - made MiniBrowser follow
886 Also fixes some ToggleFullScreen issues so that prior window state is
889 * MiniBrowser/qt/BrowserWindow.cpp:
890 (BrowserWindow::BrowserWindow):
891 (BrowserWindow::toggleFullScreenMode):
892 * MiniBrowser/qt/MiniBrowserApplication.cpp:
893 (MiniBrowserApplication::handleUserOptions):
894 * MiniBrowser/qt/MiniBrowserApplication.h:
895 (WindowOptions::WindowOptions):
896 * QtTestBrowser/launcherwindow.cpp:
897 (LauncherWindow::init):
898 (LauncherWindow::toggleFullScreenMode):
899 * QtTestBrowser/launcherwindow.h:
900 (WindowOptions::WindowOptions):
901 * QtTestBrowser/main.cpp:
902 (LauncherApplication::handleUserOptions):
904 2011-04-14 Ojan Vafai <ojan@chromium.org>
906 Reviewed by Eric Seidel.
908 add checkbox to only show unexpected results to new results file
909 https://bugs.webkit.org/show_bug.cgi?id=58606
911 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
913 2011-04-13 Brent Fulgham <bfulgham@webkit.org>
915 Reviewed by Martin Robinson.
917 [WinCairo] Implement ImageDiff Logic.
918 http://bugs.webkit.org/show_bug.cgi?id=58486
920 * DumpRenderTree/win/ImageDiffCairo.cpp: Added.
923 (createImageFromStdin):
924 (releaseMallocBuffer):
925 (createDifferenceImage):
929 * DumpRenderTree/win/ImageDiff.vcproj: Updated for new
930 ImageDiffCairo.cpp (excluding from Apple builds).
931 * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use
932 new ImageDiffWinCairoCommon.vsprops file.
933 * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use
934 new ImageDiffWinCairoCommon.vsprops file.
935 * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added.
936 * Scripts/old-run-webkit-tests: Make sure proper executable
937 is built and executed for WinCairo port.
939 2011-04-14 Ojan Vafai <ojan@chromium.org>
941 Reviewed by Eric Seidel.
943 only show expected failure type for ports that use an expectations file
944 https://bugs.webkit.org/show_bug.cgi?id=58588
946 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
947 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
949 2011-04-14 Eric Seidel <eric@webkit.org>
951 Reviewed by Adam Barth.
953 commit-queue fails to catch IOError when results.html is missing
954 https://bugs.webkit.org/show_bug.cgi?id=58589
956 * Scripts/webkitpy/tool/commands/queues.py:
957 * Scripts/webkitpy/tool/commands/queues_unittest.py:
959 2011-04-14 Kevin Ollivier <kevino@theolliviers.com>
961 [wx] Unreviewed build fix for Mac installation script.
963 * wx/packaging/build-mac-installer.py:
965 2011-04-14 Ojan Vafai <ojan@chromium.org>
967 Reviewed by Tony Chang.
969 sort columns in the new json_results.html file
970 https://bugs.webkit.org/show_bug.cgi?id=58581
972 Also fix padding on TDs and the path to layout tests.
974 * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
976 2011-04-14 Eric Seidel <eric@webkit.org>
978 Reviewed by Dimitri Glazkov.
980 queues.webkit.org should display when a bot last passed a patch
981 https://bugs.webkit.org/show_bug.cgi?id=58546
983 I am suspicious that some of our commit-queue instances are never
984 actually passing anything.
986 This will let us know if those bots are never passing patches.
988 * QueueStatusServer/handlers/queuestatus.py:
989 * QueueStatusServer/index.yaml:
990 * QueueStatusServer/templates/queuestatus.html:
992 2011-04-14 Dirk Pranke <dpranke@chromium.org>
994 Reviewed by Adam Roben.
996 REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
997 https://bugs.webkit.org/show_bug.cgi?id=58545
999 Remove platform-specific overrides; the default behavior should
1000 be working everywhere now, I think.
1002 * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1003 * Scripts/webkitpy/layout_tests/port/mac.py:
1005 2011-04-14 Eric Seidel <eric@webkit.org>
1007 Reviewed by Adam Barth.
1009 commit-queues are hitting an exception trying to land when the tree is red
1010 https://bugs.webkit.org/show_bug.cgi?id=58558
1012 Just an un-tested (and thus broken) code path from yesterday's changes.
1014 * Scripts/webkitpy/common/net/layouttestresults.py:
1015 * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1016 * Scripts/webkitpy/tool/commands/queues.py:
1017 * Scripts/webkitpy/tool/commands/queues_unittest.py:
1019 2011-04-14 Kevin Ollivier <kevino@theolliviers.com>
1021 [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
1023 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1024 (LayoutTestController::shadowRoot):
1025 * wx/build/wxpresets.py:
1027 2011-04-14 Victoria Kirst <vrk@google.com>
1029 Reviewed by James Robinson.
1031 [chromium] Failing GPU video tests
1032 https://bugs.webkit.org/show_bug.cgi?id=57926
1034 Added/updated GPU directory names for rebaseline tool.
1036 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1038 2011-04-13 Daniel Bates <dbates@rim.com>
1040 Reviewed by Adam Barth.
1042 Perl unit test removeEOL.pl should print test case name on failure
1043 https://bugs.webkit.org/show_bug.cgi?id=58513
1045 * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as
1046 second argument of Test::Simple::ok().
1048 2011-04-13 Kent Tamura <tkent@chromium.org>
1050 Reviewed by Eric Seidel.
1052 gdb-safari should pass arguments to safari.
1053 https://bugs.webkit.org/show_bug.cgi?id=58439
1056 gdb-safari --debug LayoutTests/.../foo.html
1058 * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
1060 2011-04-13 Dirk Pranke <dpranke@chromium.org>
1062 Unreviewed, build fix.
1063 https://bugs.webkit.org/show_bug.cgi?id=52763
1065 r83799 broke test-webkitpy because it assumed we always have
1066 access to a real filesystem (we don't during the unit tests).
1067 Stubbing out the copy for now but we might need a better
1068 solution at some point.
1070 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1072 2011-04-13 Dirk Pranke <dpranke@chromium.org>
1074 Reviewed by Tony Chang.
1076 new-run-webkit-tests --run-singly option is busted
1077 https://bugs.webkit.org/show_bug.cgi?id=55909
1079 Python's broken lexical scoping strikes again :(.
1081 * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
1082 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1084 2011-04-13 Ojan Vafai <ojan@chromium.org>
1086 Reviewed by Eric Seidel.
1088 generated unexpected_results.html from unexpected_results.json
1089 https://bugs.webkit.org/show_bug.cgi?id=52763
1091 Eventually, we'll merge this with results.html and have a single richer results page.
1092 For now, I just want to get something checked in that we can iterate on.
1094 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
1095 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1097 2011-04-13 Eric Seidel <eric@webkit.org>
1099 Reviewed by Adam Barth.
1101 Up the failure limit to allow the commit-queue to actually land when the tree is red
1102 https://bugs.webkit.org/show_bug.cgi?id=58499
1104 This change increases the --exit-after-N-failures limit used by the commit-queue
1105 from 1 to 10. This will cause the code added in bug 58494 to actually get
1106 exercised and the queues should start being able to land when the trees are red.
1108 When testing I found that test_runtests_leopard_commit_queue_hack_command was the
1109 only unit test to actually detect this change! Since we don't actually
1110 run on leopard anymore, I removed the hack code and repurposed the test.
1112 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1113 * Scripts/webkitpy/tool/steps/runtests.py:
1114 * Scripts/webkitpy/tool/steps/steps_unittest.py:
1116 2011-04-13 Eric Seidel <eric@webkit.org>
1118 Reviewed by Adam Barth.
1120 commit-queue should be able to land when tree is red
1121 https://bugs.webkit.org/show_bug.cgi?id=58494
1123 There is some yak hair on my hands, I will admit.
1125 This change is mostly about adding an ExpectedFailures
1126 class to track when the bots are red and we should be
1127 ignoring failures when landing from the commit-queue.
1129 However, to make intelligent decisions about patches we
1130 need to know whether the run hit the --exit-after-N-failures limit
1131 or not. Right now that information is not saved off in results.html
1132 so we have to pull the information from RunTests.
1134 I've plumbed the --exit-after-N-failures information into
1135 LayoutTestResults for now to make the ExpectedFailures code cleaner.
1137 As a result of adding all these additional calls to delegate.layout_test_results()
1138 I broke some of our flaky test detection tests and had to re-write them
1139 to not depend on the number of layout_test_results code.
1141 At the same time I updated the commit-queue to use the newer filesystem
1142 API (to allow us to use MockFileSystem) which required further changes
1143 to the layout tests. Changes were required in either case, since
1144 we're now calling layout_test_results() in more cases, which previously
1145 would try and hit the disk (until I moved it to use tool.filesystem).
1147 I should note that *all* of this code is disabled for now, since our
1148 --exit-after-N-failures limit is currently 1! (Thus were always in the
1149 case where we can't actually tell if the layout test results are legit.)
1150 I will up that limit in a second patch (which may require a couple more unit test tweaks).
1152 * Scripts/webkitpy/common/net/layouttestresults.py:
1153 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1154 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1155 * Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
1156 * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
1157 * Scripts/webkitpy/tool/commands/queues.py:
1158 * Scripts/webkitpy/tool/commands/queues_unittest.py:
1159 * Scripts/webkitpy/tool/commands/queuestest.py:
1160 * Scripts/webkitpy/tool/steps/runtests.py:
1162 2011-04-13 Brent Fulgham <bfulgham@webkit.org>
1164 Unreviewed build correction.
1166 * TestWebKitAPI/PlatformWebView.h: Limit include of
1167 <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
1169 2011-04-13 Mihai Parparita <mihaip@chromium.org>
1171 Reviewed by Eric Seidel.
1173 [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
1174 https://bugs.webkit.org/show_bug.cgi?id=58489
1176 r83743 added --additional-platform-directory to old-run-webkit-tests,
1177 rename the equivalent flag in new-run-webkit-tests to be consistent.
1179 * Scripts/webkitpy/layout_tests/port/base.py:
1180 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1181 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1182 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1184 2011-04-13 Mihai Parparita <mihaip@chromium.org>
1186 Reviewed by Eric Seidel.
1188 Rebaseline queue server
1189 https://bugs.webkit.org/show_bug.cgi?id=57891
1191 Adds a simple rebaseline queue server (meant to run at
1192 http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
1193 builders and their failing tests, and allows those tests to be added to
1194 a per-builer rebaseline queue.
1196 A subsequent change will add a mode to NRWT (and/or a wrapper script)
1197 for pulling the tests to be rebaselined from the server and running them
1198 with --reset-results (the initial use-case is for the GPU hardware bots,
1199 which do not have checked-in baselines, therefore there is no need for a
1202 * RebaselineQueueServer/app.yaml: Added.
1203 * RebaselineQueueServer/handlers/__init__.py: Added.
1204 * RebaselineQueueServer/handlers/builderqueue.py: Added.
1205 * RebaselineQueueServer/handlers/pages.py: Added.
1206 * RebaselineQueueServer/index.yaml: Added.
1207 * RebaselineQueueServer/main.py: Added.
1208 * RebaselineQueueServer/model/__init__.py: Added.
1209 * RebaselineQueueServer/model/queueentry.py: Added.
1210 * RebaselineQueueServer/static/builder-frame-empty.html: Added.
1211 * RebaselineQueueServer/static/styles.css: Added.
1212 * RebaselineQueueServer/templates/builder-picker.html: Added.
1213 * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
1214 * RebaselineQueueServer/templates/builder-queue-list.html: Added.
1215 * RebaselineQueueServer/templates/home.html: Added.
1217 2011-04-13 Dirk Pranke <dpranke@chromium.org>
1219 Reviewed by Mihai Parparita.
1221 nrwt: enable multiple processes by default on Chromium Win.
1222 https://bugs.webkit.org/show_bug.cgi?id=55163
1224 Re-land r79268; it should be more stable now and will hopefully
1227 * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1228 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1230 2011-04-13 Dirk Pranke <dpranke@chromium.org>
1232 Reviewed by Ojan Vafai.
1234 new-run-webkit-tests: configure logging in child processes properly
1235 https://bugs.webkit.org/show_bug.cgi?id=58296
1237 Logging propagated properly from manager to worker processes on
1238 Unix but not on Windows; this fixes that.
1240 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1241 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
1243 2011-04-13 Dirk Pranke <dpranke@chromium.org>
1245 Reviewed by Ojan Vafai.
1247 new-run-webkit-tests: suppress extraneous pretty patch warnings
1248 https://bugs.webkit.org/show_bug.cgi?id=58295
1250 NRWT wasn't being careful about when it logged messages from
1251 PrettyPatch not being available; it should only log during
1252 check_build(), and be silent otherwise. This was causing us to
1253 get multiple errors at runtime, which was confusing.
1255 * Scripts/webkitpy/layout_tests/port/base.py:
1256 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1257 * Scripts/webkitpy/layout_tests/port/chromium.py:
1259 2011-04-13 Dirk Pranke <dpranke@chromium.org>
1261 Reviewed by Jian Li.
1263 add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
1264 https://bugs.webkit.org/show_bug.cgi?id=58461
1266 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1268 2011-04-13 Tony Chang <tony@chromium.org>
1270 Unreviewed, fix NRWT. Stack:
1272 return super(ChromiumPort, self).results_directory(self)
1273 TypeError: results_directory() takes exactly 1 argument (2 given)
1275 * Scripts/webkitpy/layout_tests/port/chromium.py:
1277 2011-04-13 Adam Roben <aroben@apple.com>
1279 Teach ORWT about extra platform-specific directories to be searched before the default ones
1281 Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
1282 platform-specific results
1284 Reviewed by Anders Carlsson.
1286 * Scripts/old-run-webkit-tests:
1287 (top-level): Added @additionalPlatformDirectories and hooked up
1288 --additional-platform-directories to populate it.
1289 (buildPlatformResultHierarchy): Prepend the additional platform directories to the default
1290 list (after filtering out any of the additional directories that don't exist).
1292 2011-04-13 Lucas Forschler <lforschler@apple.com>
1294 Reviewed by Adam Roben.
1296 Add the /T command to taskkill.exe.
1297 This will kill spawned child processes.
1299 * BuildSlaveSupport/win/kill-old-processes:
1301 2011-04-13 Lucas Forschler <lforschler@apple.com>
1303 Reviewed by Adam Roben.
1305 Sort kill list alphabeticaly.
1306 Fixed capitalization on VcBuildHelper.
1308 * BuildSlaveSupport/win/kill-old-processes:
1310 2011-04-13 Lucas Forschler <lforschler@apple.com>
1312 Reviewed by Adam Roben.
1314 https://bugs.webkit.org/show_bug.cgi?id=58384
1315 Update kill-old-processes to include a few new ones.
1317 * BuildSlaveSupport/win/kill-old-processes:
1319 2011-04-13 Gustavo Noronha Silva <gns@gnome.org>
1321 Reviewed by Martin Robinson.
1323 [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
1324 https://bugs.webkit.org/show_bug.cgi?id=58297
1326 Do not disable flash specifically when built with GTK+ 3 -
1327 PluginPackage should do the right thing while loading plugins.
1329 * GtkLauncher/main.c:
1332 2011-04-12 Kent Tamura <tkent@chromium.org>
1334 Reviewed by Dimitri Glazkov.
1336 [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
1337 https://bugs.webkit.org/show_bug.cgi?id=57426
1339 * DumpRenderTree/chromium/WebPreferences.cpp:
1340 (WebPreferences::applyTo): Disable the validation message timer.
1342 2011-04-12 James Kozianski <koz@chromium.org>
1346 Adding myself to committers.py.
1348 * Scripts/webkitpy/common/config/committers.py:
1350 2011-04-12 Brent Fulgham <bfulgham@webkit.org>
1352 Unreviewed build correction for WinCairo bot after r83639.
1353 https://bugs.webkit.org/show_bug.cgi?id=51790
1355 Correct typo for the new "update-webkit-wincairo-libs" script.
1357 * Scripts/build-webkit: Incorrectly calling the
1358 update-webkit-cairo-libs which does not exist.
1360 2011-04-12 Alice Liu <alice.liu@apple.com>
1362 Reviewed by Jon Honeycutt.
1364 A change that should have been part of http://trac.webkit.org/changeset/83628
1366 * DumpRenderTree/win/DumpRenderTree.cpp:
1367 (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
1369 2011-04-12 Dirk Pranke <dpranke@chromium.org>
1371 Reviewed by Tony Chang.
1373 new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
1374 https://bugs.webkit.org/show_bug.cgi?id=58272
1376 NRWT was interpreting the --results-directory cmd line arg as
1377 relative to the build directory, not the current working
1378 directory (ORWT uses the latter, which is much more intuitive).
1380 This patch fixes the base case, but includes an override for
1381 Chromium that is needed until the bots can be updated.
1383 * Scripts/webkitpy/layout_tests/port/base.py:
1384 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1385 * Scripts/webkitpy/layout_tests/port/chromium.py:
1386 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1387 * Scripts/webkitpy/layout_tests/port/test.py:
1388 * Scripts/webkitpy/layout_tests/port/webkit.py:
1389 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1390 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1392 2011-04-12 Philippe Normand <pnormand@igalia.com>
1394 Unreviewed, roll out r83621 as it broke the GTK build.
1396 [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
1397 https://bugs.webkit.org/show_bug.cgi?id=58333
1399 * Scripts/build-jsc:
1400 * Scripts/build-webkit:
1402 2011-04-12 Carl Lobo <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
1404 Reviewed by Adam Roben.
1406 Patch to download the WinCairo dependancies as part of build-webkit.
1407 https://bugs.webkit.org/show_bug.cgi?id=51790
1409 This patch downloads the dependancies from
1410 http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip
1411 checking the modification timestamp etc.
1413 * Tools/Scripts/build-webkit
1414 * Tools/Scripts/update-webkit: Modified to understand the --wincairo
1415 flag, and to update WinCairo dependencies when used.
1416 * Tools/Scripts/update-webkit-cairo-libs: added
1417 * Tools/Scripts/update-webkit-dependency: added
1418 * Tools/Scripts/update-webkit-auxiliary-libs
1420 2011-04-12 Jeff Miller <jeffm@apple.com>
1422 Reviewed by Adam Roben.
1424 WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
1425 https://bugs.webkit.org/show_bug.cgi?id=56020
1427 Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
1428 since WebKit will do this for us. If we didn't do this, TranslateMessage() would be called twice,
1429 which would generate two characters for every keypress (for example). I didn't bother doing this for
1430 WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
1432 Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
1434 * MiniBrowser/win/main.cpp:
1435 (shouldTranslateMessage): Added.
1436 (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
1437 * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
1438 * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
1439 * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
1440 (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
1441 (TestWebKitAPI::runAndWatchForWMChar): Added.
1442 (TestWebKitAPI::TEST): Added.
1443 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1444 (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
1445 (TestWebKitAPI::Util::shouldTranslateMessage): Added.
1446 * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1447 (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
1448 * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
1450 2011-04-12 Dirk Pranke <dpranke@chromium.org>
1452 Reviewed by Tony Chang.
1454 new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
1455 https://bugs.webkit.org/show_bug.cgi?id=58290
1457 This is some preliminary refactoring for bug 58272.
1459 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1460 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1461 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1462 * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
1463 * Scripts/webkitpy/layout_tests/port/test.py:
1464 * Scripts/webkitpy/layout_tests/port/chromium.py:
1465 * Scripts/webkitpy/layout_tests/port/base.py:
1466 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1468 2011-04-12 Dirk Pranke <dpranke@chromium.org>
1470 Reviewed by Eric Seidel.
1472 webkitpy: fix mock_filesystem abspath to handle relative paths
1473 and add filesystem.chdir() and filesystem.getcwd() to be able
1474 to test this and mock it out.
1476 https://bugs.webkit.org/show_bug.cgi?id=58288
1478 * Scripts/webkitpy/common/system/filesystem.py:
1479 * Scripts/webkitpy/common/system/filesystem_mock.py:
1480 * Scripts/webkitpy/common/system/filesystem_unittest.py:
1482 2011-04-12 Alice Liu <alice.liu@apple.com>
1484 Reviewed by Sam Weinig.
1486 https://bugs.webkit.org/show_bug.cgi?id=58292
1487 Provide new setting to allow site icon loading despite disabling automatic image loading in general.
1489 * DumpRenderTree/mac/DumpRenderTree.mm:
1490 (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
1492 2011-04-12 Thouraya ANDOLSI <thouraya.andolsi@st.com>
1494 Reviewed by Eric Seidel.
1496 [Qt] Enable JIT build for SH4 platforms.
1497 https://bugs.webkit.org/show_bug.cgi?id=58317
1500 * DumpRenderTree/qt/DumpRenderTree.pro:
1501 * QtTestBrowser/QtTestBrowser.pro:
1502 * Scripts/webkitdirs.pm:
1504 2011-04-12 Tony Chang <tony@chromium.org>
1506 Reviewed by Andreas Kling.
1508 [Qt] embed checksums in PNGs written by Qt-DRT
1509 https://bugs.webkit.org/show_bug.cgi?id=58173
1511 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1512 (WebCore::DumpRenderTree::dump):
1514 2011-04-12 Eric Seidel <eric@webkit.org>
1516 Reviewed by Adam Barth.
1518 commit-queue should upload failure diffs when tests fail
1519 https://bugs.webkit.org/show_bug.cgi?id=58348
1521 This change was mostly just plumbing. We were already saving
1522 this information for flaky test reporting. I just made it possible
1523 for normal failures to report archives as well.
1525 I did a little abstraction work to try and share some code between
1526 flakytestreporter.py and this new code. There is still more we could do.
1528 In making this change I also went through and updated the various
1529 places we have urls hard-coded in our python and pointed them at
1532 * Scripts/webkitpy/common/checkout/scm.py:
1533 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1534 * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1535 * Scripts/webkitpy/common/net/statusserver.py:
1536 * Scripts/webkitpy/layout_tests/port/base.py:
1537 * Scripts/webkitpy/tool/bot/botinfo.py: Added.
1538 * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
1539 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1540 * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1541 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1542 * Scripts/webkitpy/tool/commands/queues.py:
1544 2011-04-12 Daniel Bates <dbates@rim.com>
1546 Rubber-stamped by Eric Seidel.
1548 svn-apply and/or patch(1) has trouble applying patches that makes changes to files
1549 with Windows line endings
1550 https://bugs.webkit.org/show_bug.cgi?id=53625
1552 Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
1553 applied to an SCM checkout on a Windows file system and vice-versa.
1555 This issue manifests itself due to custom SCM settings as well as differences in
1556 gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
1557 into svn-apply/unapply to compensate for differences in line endings by converting
1558 the line endings in a patch to match the line endings in the target file (if it exists).
1560 * Scripts/VCSUtils.pm:
1561 - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
1562 content read from the specified file handle. Obviously, this heuristic will not work
1563 for files with mixed line endings, but I don't envision such files to be the norm. If
1564 this turns out to be an issue then we can improve the heuristic.
1565 - Added firstEOLInFile().
1566 - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
1567 In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
1568 endings in the diff instead of the line endings in the target file.
1569 - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
1570 re-used in parseDiff().
1571 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
1572 to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
1573 mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
1574 * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
1575 * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
1577 2011-04-12 Sam Weinig <sam@webkit.org>
1579 Reviewed by Adam Roben.
1581 REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
1582 https://bugs.webkit.org/show_bug.cgi?id=58336
1584 * WebKitTestRunner/TestController.cpp:
1585 (WTR::TestController::resetStateToConsistentValues):
1586 Remove cache clearing as that is causing tests to crash on Windows 7.
1588 2011-04-11 Sam Weinig <sam@webkit.org>
1590 Reviewed by Anders Carlsson.
1592 REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
1593 <rdar://problem/8981346>
1594 https://bugs.webkit.org/show_bug.cgi?id=54159
1596 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1597 (WTR::InjectedBundlePage::InjectedBundlePage):
1598 (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1599 (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
1600 (WTR::InjectedBundlePage::decidePolicyForResponse):
1601 (WTR::InjectedBundlePage::unableToImplementPolicy):
1602 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1603 Add short-circuited policy client which matches WebKit1.
1605 * WebKitTestRunner/TestController.cpp:
1606 (WTR::TestController::resetStateToConsistentValues):
1607 Clear the cache between tests to ensure consistent results.
1609 2011-04-11 George Guo <George.Guo@nokia.com>
1611 Reviewed by Eric Seidel.
1613 prepare-ChangeLog support email input but -h did not show the option
1614 https://bugs.webkit.org/show_bug.cgi?id=58164
1616 Add email option to -h to improve the usability
1618 * Scripts/prepare-ChangeLog:
1620 2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
1622 Reviewed by Eric Carlson.
1624 Rename MediaControls to MediaControlRootElement.
1625 https://bugs.webkit.org/show_bug.cgi?id=58250
1627 * Scripts/do-webcore-rename: Documented the renaming.
1629 2011-04-11 Sam Weinig <sam@webkit.org>
1633 * MiniBrowser/win/BrowserView.cpp:
1634 (BrowserView::create):
1636 2011-04-11 Sam Weinig <sam@webkit.org>
1638 Reviewed by Anders Carlsson.
1640 Move focus management out of WebKit via the UIClient
1641 <rdar://problem/8784068>
1642 https://bugs.webkit.org/show_bug.cgi?id=58278
1644 * MiniBrowser/mac/BrowserWindowController.m:
1645 (-[BrowserWindowController awakeFromNib]):
1646 * WebKitTestRunner/TestController.cpp:
1647 (WTR::TestController::createOtherPage):
1648 (WTR::TestController::initialize):
1649 Add stubs for new UIClient functions.
1651 2011-02-03 Martin Robinson <mrobinson@igalia.com>
1653 Reviewed by Eric Seidel.
1655 [GTK] The GTK+ DRT needs an implementation of the PlainTextController
1656 https://bugs.webkit.org/show_bug.cgi?id=53605
1658 Add an implementation of the PlainTextController for the GTK+ DRT.
1660 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1661 (addControllerToWindow): Added this helper method.
1662 (webViewWindowObjectCleared): Use the new helper to add EventSender
1663 and the PlainTextController to the window object.
1664 * GNUmakefile.am: Added PlainTextController source files.
1665 * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
1666 on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
1667 until that functionality exists somewhere in the WebKitGTK+ stack.
1668 * DumpRenderTree/gtk/PlainTextController.h: Added.
1670 2011-04-11 Yael Aharon <yael.aharon@nokia.com>
1676 * Scripts/webkitpy/common/config/committers.py:
1678 2011-04-11 Dirk Pranke <dpranke@chromium.org>
1680 Reviewed by Adam Roben.
1682 new-run-webkit-tests: fix crash when running under windows cmd.exe
1683 https://bugs.webkit.org/show_bug.cgi?id=58197
1685 We would intermittently crash when running NRWT directly under
1686 cmd.exe on windows because we were sharing the stdin file
1687 descriptor between the python process and the http server.
1688 cmd.exe really didn't like that, and there was no reason to
1689 share the descriptor, so we now use a PIPE instead.
1691 * Scripts/webkitpy/layout_tests/port/http_server.py:
1693 2011-04-11 Dirk Pranke <dpranke@chromium.org>
1695 Reviewed by Ojan Vafai.
1697 new-run-webkit-tests: add unit tests for Port.diff_image()
1698 https://bugs.webkit.org/show_bug.cgi?id=58196
1700 Add the unit tests for the fix in bug 58195.
1702 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1703 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1704 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1706 2011-04-11 Dirk Pranke <dpranke@chromium.org>
1708 Reviewed by Tony Chang.
1710 new-run-webkit-tests: implement support for audio, take two
1711 https://bugs.webkit.org/show_bug.cgi?id=58195
1713 Attempt to re-land the fix for bug 58101 (which was initially
1714 landed in r83330, but rolled out). This is the same patch but
1715 fixes crashes in Port.diff_image() caused by the change for
1716 empty image files being None instead of ''.
1718 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1719 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1720 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1721 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1722 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1723 * Scripts/webkitpy/layout_tests/port/base.py:
1724 * Scripts/webkitpy/layout_tests/port/chromium.py:
1725 * Scripts/webkitpy/layout_tests/port/dryrun.py:
1726 * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1727 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1728 * Scripts/webkitpy/layout_tests/port/test.py:
1729 * Scripts/webkitpy/layout_tests/port/webkit.py:
1731 2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
1733 Reviewed by Xan Lopez.
1735 [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
1736 https://bugs.webkit.org/show_bug.cgi?id=57854
1738 Implement missing features in GTK's DRT.
1740 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1741 (indexRangeInTable): New helper function to get the range string
1742 for the current cell inside the parent table, either from the
1743 point of view of rows or columns.
1744 (AccessibilityUIElement::rowIndexRange): Implemented by relying on
1745 the new helper function indexRangeInTable().
1746 (AccessibilityUIElement::columnIndexRange): Ditto.
1748 2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
1750 Reviewed by Chris Fleizach.
1752 [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
1753 https://bugs.webkit.org/show_bug.cgi?id=57826
1755 Implement missing feature in GTK's DRT.
1757 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1758 (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
1759 relying on the analogous function from the AtkTable interface.
1761 2011-04-05 Timothy Hatcher <timothy@apple.com>
1763 Fix the extract-localizable-strings script errors that started after
1764 WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
1766 * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
1768 2011-04-11 Tony Chang <tony@chromium.org>
1770 Reviewed by Eric Seidel.
1772 fix crc computation on 64 bit machines
1773 https://bugs.webkit.org/show_bug.cgi?id=58243
1775 unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
1777 * DumpRenderTree/CyclicRedundancyCheck.cpp:
1780 * DumpRenderTree/CyclicRedundancyCheck.h:
1781 * DumpRenderTree/PixelDumpSupport.cpp:
1782 (appendIntToVector):
1783 (convertChecksumToPNGComment):
1785 2011-04-10 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
1787 Reviewed by Eric Seidel.
1789 Require no undefined symbols during compilation.
1791 [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
1792 https://bugs.webkit.org/show_bug.cgi?id=54896
1794 Add -Wl,--no-undefined to catch missing symbols early.
1796 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1797 * WebKitTestRunner/qt/WebKitTestRunner.pro:
1799 2011-04-10 Kevin Ollivier <kevino@theolliviers.com>
1801 [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
1803 * wx/build/settings.py:
1805 2011-04-10 Kevin Ollivier <kevino@theolliviers.com>
1807 [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
1809 * wx/build/settings.py:
1811 2011-04-10 David Levin <levin@chromium.org>
1813 Reviewed by Dimitri Glazkov.
1815 REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
1816 https://bugs.webkit.org/show_bug.cgi?id=58201
1818 * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
1819 and filed bug 58202.
1821 2011-04-09 David Levin <levin@chromium.org>
1823 Unreviewed, rolling out r83394.
1824 http://trac.webkit.org/changeset/83394
1825 https://bugs.webkit.org/show_bug.cgi?id=53625
1827 Patch was incorrect as noted in the bug.
1829 * Scripts/svn-apply:
1831 2011-04-09 David Levin <levin@chromium.org>
1833 Reviewed by Adam Barth.
1835 svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
1836 https://bugs.webkit.org/show_bug.cgi?id=53625
1838 * Scripts/svn-apply: Ensure that the portions of patches
1839 which are for vcproj/vsprops files has DOS line endings.
1841 2011-04-09 Dirk Pranke <dpranke@chromium.org>
1843 Reviewed by Tony Chang.
1845 It looks like NRWT has not been stopping DRT/TestShell
1846 instances properly on windows, probably for a long time.
1847 This would go a long way to explaining why we often have
1848 processes lying around :)
1850 https://bugs.webkit.org/show_bug.cgi?id=57807
1852 * Scripts/webkitpy/layout_tests/port/chromium.py:
1853 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1855 2011-04-09 Keith Kyzivat <keith.kyzivat@nokia.com>
1857 Reviewed by Laszlo Gombos.
1859 [Qt] Don't link against fontconfig or X11 if embedded
1860 https://bugs.webkit.org/show_bug.cgi?id=58104
1862 * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
1863 * QtTestBrowser/QtTestBrowser.pro: ditto
1864 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
1865 * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
1867 2011-04-08 Jon Honeycutt <jhoneycutt@apple.com>
1869 http/tests/loading/preload-append-scan.php is failing on Windows
1870 https://bugs.webkit.org/show_bug.cgi?id=58178
1872 Reviewed by Brian Weinstein.
1874 * DumpRenderTree/win/DumpRenderTree.cpp:
1875 (lastPathComponent):
1876 Use CFURL API to find the last path component, rather than
1877 PathFindFileName(), because the latter will include the query string.
1879 2011-04-08 Jian Li <jianli@chromium.org>
1881 Unreviewed, rolling out r83327, r83330 since these patches are very
1882 likely to break chromium webkit mac10.6 builders.
1884 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1885 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1886 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1887 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1888 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1889 * Scripts/webkitpy/layout_tests/port/base.py:
1890 * Scripts/webkitpy/layout_tests/port/chromium.py:
1891 * Scripts/webkitpy/layout_tests/port/dryrun.py:
1892 * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1893 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1894 * Scripts/webkitpy/layout_tests/port/test.py:
1895 * Scripts/webkitpy/layout_tests/port/webkit.py:
1897 2011-04-08 Vincent Scheib <scheib@chromium.org>
1899 Reviewed by Eric Seidel.
1901 add chromium-gpu-linux-x86_64 to the recognized list of ports
1902 https://bugs.webkit.org/show_bug.cgi?id=58099
1904 Add chromium-gpu-linux-x86_64 to fix assert.
1906 * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1908 2011-04-08 Alpha Lam <hclam@chromium.org>
1910 Unreviewed, rolling out r83335.
1911 http://trac.webkit.org/changeset/83335
1912 https://bugs.webkit.org/show_bug.cgi?id=53556
1914 GTK and QT bots are broken
1916 * Scripts/build-webkit:
1918 2011-04-07 Anna Cavender <annacc@chromium.org>
1920 Reviewed by Eric Carlson.
1922 Setup ENABLE(TRACK) feature define
1923 https://bugs.webkit.org/show_bug.cgi?id=53556
1925 * Scripts/build-webkit:
1927 2011-04-08 Dirk Pranke <dpranke@chromium.org>
1929 Reviewed by Adam Roben.
1931 new-run-webkit-tests: configure a NRWT test bot for Mac SL
1932 https://bugs.webkit.org/show_bug.cgi?id=58114
1934 This change removes the old new-run-webkit-tests entry and
1935 updates it for a new test-only bot.
1937 * BuildSlaveSupport/build.webkit.org-config/config.json:
1939 2011-04-08 Dominic Cooney <dominicc@google.com>
1941 Reviewed by Adam Roben.
1943 Make layoutTestController.shadowRoot return null, not undefined,
1944 when its argument is invalid.
1945 https://bugs.webkit.org/show_bug.cgi?id=58121
1947 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1948 (LayoutTestController::shadowRoot):
1949 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1950 (WTR::LayoutTestController::shadowRoot):
1952 2011-04-08 Pere Martir <pere.martir4@gmail.com>
1954 Reviewed by Adam Roben.
1956 Locate NSTD.EXE in 64-bit Windows
1957 https://bugs.webkit.org/show_bug.cgi?id=57847
1959 * Scripts/old-run-webkit-tests:
1961 2011-04-08 Adam Roben <aroben@apple.com>
1965 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
1967 2011-04-07 Adam Roben <aroben@apple.com>
1969 Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
1971 Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
1974 Reviewed by Anders Carlsson.
1976 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1977 (pluginLogWithArguments): Moved code to format and log the message here...
1978 (pluginLog): ...from here.
1980 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
1982 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1983 (PluginTest::log): Added. Calls through to pluginLogWithArguments.
1985 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
1987 * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
1988 (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
1990 (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
1992 (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
1993 can be used to invoke our setWillBeDestroyed function.
1994 (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
1995 anything unexpected happens).
1996 (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
1997 NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
1998 NPP_SetWindow was *not* called during destruction.
1999 (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
2000 method, setWillBeDestroyed.
2001 (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
2004 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2005 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2006 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2010 * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
2011 WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
2013 2011-04-08 Mario Sanchez Prada <msanchez@igalia.com>
2015 Reviewed by Martin Robinson.
2017 [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
2018 https://bugs.webkit.org/show_bug.cgi?id=58039
2020 Implement missing functions in GTK's DRT.
2022 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2023 (AccessibilityUIElement::increment): Implemented.
2024 (AccessibilityUIElement::decrement): Implemented.
2026 2011-04-08 Dominic Cooney <dominicc@google.com>
2028 Reviewed by Kent Tamura.
2030 Make WK2 layoutTestController.shadowRoot return undefined, not
2031 null, when its argument is not an element.
2032 https://bugs.webkit.org/show_bug.cgi?id=58121
2034 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2035 (WTR::LayoutTestController::shadowRoot):
2037 2011-04-07 Dirk Pranke <dpranke@chromium.org>
2039 Reviewed by Mihai Parparita.
2041 Change reference port for Mac GPU baselines from
2042 Leopard to SnowLeopard, XP to Win7, and Linux-x86
2045 https://bugs.webkit.org/show_bug.cgi?id=58099
2047 * Scripts/webkitpy/layout_tests/port/chromium.py:
2049 2011-04-07 Andrew Scherkus <scherkus@chromium.org>
2051 Revert ENABLE_TRACK patch due to compile failures.
2053 * Scripts/build-webkit:
2055 2011-04-07 Tony Chang <tony@chromium.org>
2057 Reviewed by Eric Seidel.
2059 update DRT to embed checksums in png files
2060 https://bugs.webkit.org/show_bug.cgi?id=57871
2062 We insert the bytes for the comment in printPNG rather than at encode
2063 time because each platform does its own PNG encoding (either using CG
2064 or cairo). Putting this in pringPNG avoids having to duplicate this
2065 code, although it's not as clean as doing it at encoding time.
2067 We insert the comment right after the IHDR chunk of the PNG.
2069 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2070 * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
2071 (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
2072 (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
2073 * DumpRenderTree/CyclicRedundancyCheck.h: Added.
2074 * DumpRenderTree/PixelDumpSupport.cpp:
2075 (dumpWebViewAsPixelsAndCompareWithExpected):
2076 (convertChecksumToPNGComment): Generate the bytes to insert.
2077 (printPNG): Insert the png comment before the first IDAT section.
2078 * DumpRenderTree/PixelDumpSupport.h:
2079 * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
2082 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2085 * DumpRenderTree/win/DumpRenderTree.vcproj:
2088 2011-04-07 Jeff Miller <jeffm@apple.com>
2090 Reviewed by Adam Roben.
2092 Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
2093 https://bugs.webkit.org/show_bug.cgi?id=58058
2095 * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2096 (TestWebKitAPI::TEST): Add tests for WKStringGetLength() and WKStringGetCharactersPtr().
2098 2011-04-07 Chang Shu <cshu@webkit.org>
2100 Reviewed by Darin Adler.
2102 WebKitTestRunner needs layoutTestController.isPageBoxVisible
2103 https://bugs.webkit.org/show_bug.cgi?id=42695
2105 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2106 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2107 (WTR::LayoutTestController::isPageBoxVisible):
2108 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2110 2011-04-07 Adam Roben <aroben@apple.com>
2114 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
2116 2011-04-07 Adam Roben <aroben@apple.com>
2118 Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
2120 commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
2121 (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
2122 hook we have, so we have to do our work there. I added a new addCustomURLs method which can
2123 be overridden by subclasses to provide extra URLs before we call up to the base class (after
2124 which adding more URLs is no longer possible).
2126 Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
2129 Reviewed by John Sullivan.
2131 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2132 (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
2133 (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
2134 method is never called for MasterShellCommands.
2135 (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
2136 with this method (which is).
2138 2011-04-07 Adam Roben <aroben@apple.com>
2140 Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
2142 This matches how most of our other build steps work, so is good just for improving
2143 consistency between build steps. It should also make it possible for
2144 ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
2145 trying to do this in finished() after we had called up to the base class, but that was
2146 apparently too late to add more URLs.)
2148 Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
2151 Reviewed by John Sullivan.
2153 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2154 (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
2155 call setText to get the right text to show up for this step. This matches how most of our
2156 other build steps work.
2157 (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
2158 This is how most of our other build steps work.
2159 (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
2160 function, to match the base class.
2162 2011-04-07 Adam Barth <abarth@webkit.org>
2164 Reviewed by Maciej Stachowiak.
2166 webkit-patch shouldn't state the whole working copy when calling check-webkit-style
2167 https://bugs.webkit.org/show_bug.cgi?id=58022
2169 Previously, we were ignoring the args variable! This patch fixes the
2170 regression introduced in http://trac.webkit.org/changeset/82771.
2172 * Scripts/webkitpy/tool/commands/download_unittest.py:
2173 * Scripts/webkitpy/tool/mocktool.py:
2174 * Scripts/webkitpy/tool/steps/checkstyle.py:
2176 2011-04-07 Maciej Stachowiak <mjs@apple.com>
2178 Reviewed by Adam Barth.
2180 REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
2181 https://bugs.webkit.org/show_bug.cgi?id=58017
2183 * Scripts/webkitpy/common/checkout/scm.py:
2184 * Scripts/webkitpy/common/checkout/scm_unittest.py:
2186 2011-04-06 Chang Shu <cshu@webkit.org>
2188 Reviewed by Darin Adler.
2190 WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
2191 https://bugs.webkit.org/show_bug.cgi?id=57984
2193 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2194 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2195 (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
2196 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2198 2011-04-06 Chris Rogers <crogers@google.com>
2200 Reviewed by Tony Chang.
2202 Add web audio support to DumpRenderTree (mac port)
2203 https://bugs.webkit.org/show_bug.cgi?id=57969
2205 * DumpRenderTree/LayoutTestController.cpp:
2206 (LayoutTestController::LayoutTestController):
2207 (setEncodedAudioDataCallback):
2208 (LayoutTestController::staticFunctions):
2209 * DumpRenderTree/LayoutTestController.h:
2210 (LayoutTestController::dumpAsAudio):
2211 (LayoutTestController::setDumpAsAudio):
2212 (LayoutTestController::encodedAudioData):
2213 (LayoutTestController::setEncodedAudioData):
2214 * DumpRenderTree/mac/DumpRenderTree.mm:
2218 2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
2220 Reviewed by Kenneth Rohde Christiansen.
2222 [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
2223 https://bugs.webkit.org/show_bug.cgi?id=56086
2225 Add the missing method.
2227 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2228 (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
2229 * DumpRenderTree/qt/DumpRenderTreeQt.h:
2230 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2231 (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2233 2011-04-06 Dai Mikurube <dmikurube@chromium.org>
2235 Reviewed by David Levin.
2237 Add QUOTA build flag for unified quota API
2238 https://bugs.webkit.org/show_bug.cgi?id=57918
2240 * Scripts/build-webkit: Added QUOTA build flag
2242 2011-04-06 Dirk Pranke <dpranke@chromium.org>
2244 Reviewed by Tony Chang.
2246 Adjust the apple webkit port's default timeout to match
2247 old-run-webkit-tests at 35 seconds.
2249 https://bugs.webkit.org/show_bug.cgi?id=37738
2251 * Scripts/webkitpy/layout_tests/port/mac.py:
2253 2011-04-06 Scott Cameron <sccameron@rim.com>
2255 Reviewed by Eric Seidel.
2257 Remove global variable $httpdPath and replace with the return value of
2258 getHTTPDPath(). Also remove unnecessary calls to getHTTPDPath().
2259 https://bugs.webkit.org/show_bug.cgi?id=53499
2261 * Scripts/run-iexploder-tests:
2262 * Scripts/webkitperl/httpd.pm:
2264 2011-04-06 Kevin Ollivier <kevino@theolliviers.com>
2266 Reviewed by Darin Adler.
2268 Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
2270 https://bugs.webkit.org/show_bug.cgi?id=27551
2272 * DumpRenderTree/config.h:
2273 * WebKitAPITest/config.h:
2274 * WebKitTestRunner/config.h:
2276 2011-04-06 Tony Chang <tony@chromium.org>
2278 Reviewed by Darin Adler.
2280 teach run-webkit-tests to read checksums from png files
2281 https://bugs.webkit.org/show_bug.cgi?id=57993
2283 * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
2284 no .checksum and look for the checksum in there.
2286 2011-04-06 David Dorwin <ddorwin@chromium.org>
2288 Reviewed by David Levin.
2290 Enable fullscreen layout tests for Chromium
2291 https://bugs.webkit.org/show_bug.cgi?id=55726
2293 Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
2295 * DumpRenderTree/chromium/WebPreferences.cpp:
2296 (WebPreferences::applyTo):
2298 2011-04-06 Adam Roben <aroben@apple.com>
2300 Add a "view leaks" link to builds on SnowLeopard Intel Leaks
2302 Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
2304 Reviewed by David Kilzer.
2306 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2307 (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
2308 build's results directory here...
2309 (ExtractTestResults.finished): ...from here.
2310 (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
2311 (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
2312 leaks" link to point to Leaks Viewer for this build.
2313 (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
2314 but it seemed good to add for consistency with BuildAndTestFactory.
2315 (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
2316 (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
2317 that we'll get a "view leaks" link.
2319 2011-04-06 Zan Dobersek <zandobersek@gmail.com>
2321 Reviewed by Eric Seidel.
2323 [Gtk] plugins/set-status.html fails
2324 https://bugs.webkit.org/show_bug.cgi?id=57844
2326 Allow an empty status text to be dumped.
2328 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2329 (webViewStatusBarTextChanged):
2331 2011-04-06 Chang Shu <cshu@webkit.org>
2333 Reviewed by Darin Adler.
2335 WebKitTestRunner needs layoutTestController.pageNumberForElementById
2336 https://bugs.webkit.org/show_bug.cgi?id=42329
2338 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2339 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2340 (WTR::LayoutTestController::pageNumberForElementById):
2341 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2343 2011-04-06 Sergio Villar Senin <svillar@igalia.com>
2345 Reviewed by Martin Robinson.
2347 [GTK] DumpRenderTree: do not try to free NULL SoupURIs
2348 https://bugs.webkit.org/show_bug.cgi?id=57932
2350 Some Layout tests have invalid URIs that do not generate valid
2351 SoupURI instances. Do not try to free those NULL SoupURIs.
2353 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2354 (willSendRequestCallback):
2356 2011-04-06 Csaba Osztrogonác <ossy@webkit.org>
2358 Reviewed by Andreas Kling.
2360 ORWT shouldn't generate diff files for tests without expected files
2361 https://bugs.webkit.org/show_bug.cgi?id=57846
2363 * Scripts/old-run-webkit-tests:
2365 2011-04-05 Kevin Ollivier <kevino@theolliviers.com>
2367 [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
2370 * wx/install-unix-extras:
2372 2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
2374 Unreviewed, rolling out r82978, r82999, and r83001.
2375 http://trac.webkit.org/changeset/82978
2376 http://trac.webkit.org/changeset/82999
2377 http://trac.webkit.org/changeset/83001
2378 https://bugs.webkit.org/show_bug.cgi?id=57913
2380 Does not work in Python 2.5 (Requested by abarth on #webkit).
2382 * Scripts/webkitpy/common/system/executive.py:
2383 * Scripts/webkitpy/common/system/executive_unittest.py:
2385 2011-04-05 Chang Shu <cshu@webkit.org>
2387 Reviewed by Darin Adler.
2389 WebKitTestRunner needs layoutTestController.numberOfPages
2390 https://bugs.webkit.org/show_bug.cgi?id=42694
2392 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2393 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2394 (WTR::LayoutTestController::numberOfPages):
2395 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2397 2011-04-05 Tony Chang <tony@chromium.org>
2399 Reviewed by Mihai Parparita.
2401 [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
2402 https://bugs.webkit.org/show_bug.cgi?id=57889
2404 * Scripts/webkitpy/layout_tests/port/chromium.py:
2405 * Scripts/webkitpy/layout_tests/port/test.py:
2406 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2408 2011-04-05 Adam Barth <abarth@webkit.org>
2410 Silly with statement, from the future!
2412 * Scripts/webkitpy/common/system/executive.py:
2414 2011-04-05 Adam Barth <abarth@webkit.org>
2416 Reviewed by Tony Chang.
2418 Don't use Exception.message because it's deprecated
2419 https://bugs.webkit.org/show_bug.cgi?id=57892
2421 Suppress the warning for now. When we move to Python 3, we might need
2422 to something more dramatic.
2424 * Scripts/webkitpy/common/system/executive.py:
2426 2011-04-05 Mihai Parparita <mihaip@chromium.org>
2428 Reviewed by Ojan Vafai.
2430 Add builders.js to dashboard file list
2431 https://bugs.webkit.org/show_bug.cgi?id=57899
2433 Add file added by http://crrev.com/80538 to dashboard file list.
2435 * TestResultServer/handlers/dashboardhandler.py:
2437 2011-04-05 MORITA Hajime <morrita@google.com>
2439 Reviewed by Adam Barth.
2441 webkit-patch should print git's stderr when git svn dcommit fail
2442 http://webkit.org/b/57861
2444 * Scripts/webkitpy/common/checkout/scm.py:
2446 2011-04-05 Mihai Parparita <mihaip@chromium.org>
2448 Reviewed by Tony Chang.
2450 Add --baseline-search-path to NRWT
2451 https://bugs.webkit.org/show_bug.cgi?id=56233
2453 Add NRWT option to specify additional directories to look for baselines
2454 (will be used by hardware GPU bots which will have local per-bot
2455 expectations for some tests)
2457 * Scripts/webkitpy/common/system/filesystem_mock.py:
2458 * Scripts/webkitpy/layout_tests/port/base.py:
2459 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2460 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2462 2011-04-05 Adam Roben <aroben@apple.com>
2464 Strip off /results.html from results URLs before trying to load leaks files from them
2466 r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
2467 files, rather than pointing to the directory that contains them. This is more convenient for
2468 people browsing build.webkit.org, but confused Leaks Viewer.
2470 Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
2473 Reviewed by Joseph Pecoraro.
2475 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2476 (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
2478 2011-04-05 Carol Szabo <carol@webkit.org>
2482 Updated my info in committers.py
2484 Scripts\webkitpy\common\config\committers.py
2486 2011-04-05 Csaba Osztrogonác <ossy@webkit.org>
2488 Reviewed by Laszlo Gombos.
2490 [Qt] Make WebKitLibraries optional for building QtWebKit
2491 https://bugs.webkit.org/show_bug.cgi?id=57542
2493 * Scripts/build-webkit:
2495 2011-04-05 Chang Shu <cshu@webkit.org>
2497 Reviewed by Laszlo Gombos.
2499 [Qt] MiniBrowser defaultUrl does not work
2500 https://bugs.webkit.org/show_bug.cgi?id=57021
2502 Match the behavior and coding of MiniBrowser to QtTestBrowser.
2503 * MiniBrowser/qt/main.cpp:
2506 2011-04-05 Jade Han <jade.han@nokia.com>
2508 Reviewed by Laszlo Gombos.
2510 [Qt] [Symbian] Disable WebKitTestRunner for Symbian
2511 https://bugs.webkit.org/show_bug.cgi?id=54977
2513 This change is a preparation to enable building webkit2 for Symbian.
2514 Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
2518 2011-04-05 Zoltan Horvath <zoltan@webkit.org>
2520 Reviewed by Andreas Kling.
2522 [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
2523 https://bugs.webkit.org/show_bug.cgi?id=57832
2525 Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
2527 * MiniBrowser/qt/UrlLoader.cpp:
2528 (UrlLoader::UrlLoader):
2530 2011-04-05 Zoltan Horvath <zoltan@webkit.org>
2532 [Qt] Linux Release minimal build fix after r82919.
2534 * MiniBrowser/qt/BrowserWindow.cpp:
2535 (BrowserWindow::loadURLListFromFile):
2536 * QtTestBrowser/launcherwindow.cpp:
2537 (LauncherWindow::loadURLListFromFile):
2539 2011-04-05 Zoltan Horvath <zoltan@webkit.org>
2541 Reviewed by Andreas Kling.
2543 [Qt] Make URL loader accessible from testbrowser's menus
2544 https://bugs.webkit.org/show_bug.cgi?id=57823
2546 Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
2548 * MiniBrowser/qt/BrowserWindow.cpp:
2549 (BrowserWindow::BrowserWindow):
2550 (BrowserWindow::loadURLListFromFile):
2551 (BrowserWindow::~BrowserWindow):
2552 * MiniBrowser/qt/BrowserWindow.h:
2553 * QtTestBrowser/launcherwindow.cpp:
2554 (LauncherWindow::LauncherWindow):
2555 (LauncherWindow::~LauncherWindow):
2556 (LauncherWindow::createChrome):
2557 (LauncherWindow::loadURLListFromFile):
2558 * QtTestBrowser/launcherwindow.h:
2560 2011-04-04 Sam Weinig <sam@webkit.org>
2562 Reviewed by Brian Weinstein.
2564 Remove duplicate API from WKContext
2565 <rdar://problem/8727879>
2566 https://bugs.webkit.org/show_bug.cgi?id=57815
2568 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2569 * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
2570 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2571 Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
2573 2011-04-04 Tony Chang <tony@chromium.org>
2575 Reviewed by Ojan Vafai.
2577 [chromium] don't write .checksum files if a fallback platform has an embedded checksum
2578 https://bugs.webkit.org/show_bug.cgi?id=57783
2580 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2581 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2583 2011-04-04 Kevin Ollivier <kevino@theolliviers.com>
2585 [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
2588 * Scripts/webkitdirs.pm:
2590 2011-04-04 Martin Robinson <mrobinson@igalia.com>
2592 Reviewed by Gustavo Noronha Silva.
2595 https://bugs.webkit.org/show_bug.cgi?id=31517
2597 Add support to the DRT for turning on WebGL when a layout tests requests it.
2599 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2600 (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
2602 2011-04-04 Chang Shu <cshu@webkit.org>
2604 Reviewed by Darin Adler.
2606 WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
2607 https://bugs.webkit.org/show_bug.cgi?id=57572
2609 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2610 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2611 (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
2612 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2614 2011-04-04 Keith Kyzivat <keith.kyzivat@nokia.com>
2616 Reviewed by Csaba Osztrogonác.
2618 [Qt] DumpRenderTree breaks compilation in some uClibc environments
2619 https://bugs.webkit.org/show_bug.cgi?id=57602
2621 * DumpRenderTree/qt/main.cpp:
2624 2011-04-04 Kevin Ollivier <kevino@theolliviers.com>
2626 [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
2628 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2629 (LayoutTestController::shadowRoot):
2631 2011-04-04 Pavel Podivilov <podivilov@chromium.org>
2633 Unreviewed, fix exception in rebaseline tool.
2635 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2637 2011-04-02 Beth Dakin <bdakin@apple.com>
2639 Rubber-stamped by Geoff Garen.
2642 * DumpRenderTree/mac/DumpRenderTree.mm:
2643 (resetWebViewToConsistentStateBeforeTesting):
2645 2011-04-02 Beth Dakin <bdakin@apple.com>
2647 Rubber-stamped by Geoff Garen.
2649 Need to reset the scale, much like zoom.
2650 * DumpRenderTree/mac/DumpRenderTree.mm:
2651 (resetWebViewToConsistentStateBeforeTesting):
2653 2011-04-02 Sam Weinig <sam@webkit.org>
2655 Reviewed by Beth Dakin.
2657 https://bugs.webkit.org/show_bug.cgi?id=57605
2658 Frame::pageScaleFactor() should not affect getBoundingClientRect() or
2661 <rdar://problem/9194541>
2663 Add DRT support for the scaleWebView SPI.
2664 * DumpRenderTree/mac/EventSendingController.mm:
2665 (+[EventSendingController isSelectorExcludedFromWebScript:]):
2666 (+[EventSendingController webScriptNameForSelector:]):
2667 (-[EventSendingController scalePageBy:atX:andY:]):
2668 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2669 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2670 (WTR::EventSendingController::scalePageBy):
2671 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2672 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2673 (WTR::InjectedBundlePage::reset):
2675 2011-04-02 Dominic Cooney <dominicc@google.com>
2677 Reviewed by Martin Robinson.
2679 Add layoutTestController.shadowRoot to GTK DumpRenderTree.
2680 https://bugs.webkit.org/show_bug.cgi?id=57551
2682 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2683 (LayoutTestController::shadowRoot):
2685 2011-04-02 Patrick Gansterer <paroga@webkit.org>
2687 Reviewed by Eric Seidel.
2689 Remove AbstractStep._run_script and move script names to ports.py
2690 https://bugs.webkit.org/show_bug.cgi?id=57704
2692 Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
2694 * Scripts/webkitpy/common/config/ports.py:
2695 * Scripts/webkitpy/tool/commands/download_unittest.py:
2696 * Scripts/webkitpy/tool/commands/roll_unittest.py:
2697 * Scripts/webkitpy/tool/commands/upload_unittest.py:
2698 * Scripts/webkitpy/tool/steps/abstractstep.py:
2699 * Scripts/webkitpy/tool/steps/checkstyle.py:
2700 * Scripts/webkitpy/tool/steps/preparechangelog.py:
2701 * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2702 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2704 2011-04-02 Patrick Gansterer <paroga@webkit.org>
2706 Reviewed by Eric Seidel.
2708 Emulate shebang on Win32
2709 https://bugs.webkit.org/show_bug.cgi?id=55927
2711 Scripts on Windows work only if they are called with the explicit interpreter.
2712 Read the first line of scripts to detect the correct executable.
2714 * Scripts/webkitpy/common/config/ports.py:
2715 * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
2716 * Scripts/webkitpy/common/system/executive_unittest.py:
2718 2011-04-01 Adam Barth <abarth@webkit.org>
2720 Reviewed by Eric Seidel.
2722 apos entities shouldn't show up in ChangeLogs when using webkit-patch
2723 https://bugs.webkit.org/show_bug.cgi?id=57692
2725 Previously, we were using BeautifulSoup to process XML from
2726 bugs.webkit.org, but that's incorrect. We should be using
2727 BeautifulStoneSoup to process the XML. We were getting the '
2728 entity wrong because ' is an XML entity but not an HTML entity.
2730 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2731 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2733 2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
2735 Unreviewed, rolling out r82721.
2736 http://trac.webkit.org/changeset/82721
2737 https://bugs.webkit.org/show_bug.cgi?id=57687
2739 This patch introduced assertion failures on the GTK+ bots.
2740 (Requested by mrobinson on #webkit).
2742 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2743 (LayoutTestController::shadowRoot):
2745 2011-04-01 Csaba Osztrogonác <ossy@webkit.org>
2747 Unreviewed buildfix.
2749 [Qt][WK2] Build Webkit2 using "-2" option on Qt
2750 https://bugs.webkit.org/show_bug.cgi?id=55074
2752 * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
2753 (The isWK2() function removes it from @ARGV, but not from @options.)
2755 2011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com>
2757 Reviewed by Csaba Osztrogonác.
2759 [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
2760 https://bugs.webkit.org/show_bug.cgi?id=57666
2762 * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
2764 2011-04-01 Dirk Pranke <dpranke@chromium.org>
2766 Reviewed by Adam Barth.
2768 new-run-webkit-tests: fix feature detection, skipped platform lists on mac
2770 We apparently never implemented the code to skip tests based on
2771 what was compiled into DRT. Also, change the logic used to skip
2772 platform directories to match what old-run-webkit-tests does:
2773 skip every test not in a directory in the baseline search path.
2775 https://bugs.webkit.org/show_bug.cgi?id=57662
2777 * Scripts/webkitpy/layout_tests/port/mac.py:
2778 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2779 * Scripts/webkitpy/layout_tests/port/webkit.py:
2781 2011-03-29 Mark Rowe <mrowe@apple.com>
2783 Reviewed by Jon Honeycutt.
2785 <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
2787 Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
2789 * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2790 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2791 * Scripts/webkitpy/layout_tests/port/mac.py:
2792 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2794 2011-04-01 Chang Shu <cshu@webkit.org>
2796 Reviewed by Csaba Osztrogonác.
2798 [Qt][WK2] Build Webkit2 using "-2" option on Qt
2799 https://bugs.webkit.org/show_bug.cgi?id=55074
2801 * Scripts/build-webkit:
2803 2011-04-01 Dirk Pranke <dpranke@chromium.org>
2805 Reviewed by Tony Chang.
2807 new-run-webkit-tests: remove spurious port version override in webkit.py
2808 base.py provides a default implementation so this is just
2811 https://bugs.webkit.org/show_bug.cgi?id=57667
2813 * Scripts/webkitpy/layout_tests/port/webkit.py:
2814 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2816 2011-04-01 Csaba Osztrogonác <ossy@webkit.org>
2818 Reviewed by Adam Roben.
2820 Make view results on waterfall direct link to results.html
2821 https://bugs.webkit.org/show_bug.cgi?id=57671
2823 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
2824 * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
2826 2011-04-01 Sam Weinig <sam@webkit.org>
2830 * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2831 (TestWebKitAPI::TEST):
2832 * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2833 (TestWebKitAPI::flushMessages):
2835 2011-04-01 Sam Weinig <sam@webkit.org>
2837 Reviewed by Adam Roben.
2839 Add adoptWK to WKRetainPtr.h
2840 https://bugs.webkit.org/show_bug.cgi?id=57670
2842 * TestWebKitAPI/PlatformUtilities.h:
2843 * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2844 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2845 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2846 * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2847 * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2848 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2849 * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2850 * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2851 (TestWebKitAPI::createSessionStateContainingFormData):
2852 * WebKitTestRunner/StringFunctions.h:
2853 Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
2855 2011-04-01 Sam Weinig <sam@webkit.org>
2857 Reviewed by Adam Roben.
2859 Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
2861 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2862 (WTR::LayoutTestController::shadowRoot):
2863 Make judicious use of adoptWK().
2865 2011-04-01 Sam Weinig <sam@webkit.org>
2867 Reviewed by Timothy Hatcher.
2869 Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
2871 * Scripts/extract-localizable-strings:
2873 2011-04-01 Anders Carlsson <andersca@apple.com>
2875 Reviewed by Sam Weinig.
2877 Shockwave plug-in doesn't accept mouse events
2878 https://bugs.webkit.org/show_bug.cgi?id=57653
2879 <rdar://problem/8483273>
2883 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2884 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2885 (PluginTest::indicateTestFailure):
2886 Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
2888 (PluginTest::NPN_ConvertPoint):
2889 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2890 * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
2891 (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2892 Call indicateTestFailure.
2894 * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
2895 * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
2896 (ConvertPoint::ConvertPoint):
2897 (ConvertPoint::testConvert):
2898 (ConvertPoint::NPP_New):
2900 2011-04-01 Dominic Cooney <dominicc@google.com>
2902 Reviewed by Martin Robinson.
2904 Add layoutTestController.shadowRoot to GTK DumpRenderTree.
2905 https://bugs.webkit.org/show_bug.cgi?id=57551
2907 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2908 (LayoutTestController::shadowRoot):
2910 2011-04-01 Sam Weinig <sam@webkit.org>
2912 Reviewed by Anders Carlsson.
2914 WebKitTestRunner needs layoutTestController.shadowRoot
2915 https://bugs.webkit.org/show_bug.cgi?id=57661
2917 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2918 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2919 (WTR::LayoutTestController::shadowRoot):
2920 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2921 Implement layoutTestController.shadowRoot for WebKit2.
2923 2011-04-01 Chang Shu <cshu@webkit.org>
2925 Reviewed by Darin Adler.
2927 WebKitTestRunner needs layoutTestController.setDatabaseQuota
2928 https://bugs.webkit.org/show_bug.cgi?id=57568
2930 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2931 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2932 (WTR::LayoutTestController::setDatabaseQuota):
2933 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2935 2011-04-01 Dirk Pranke <dpranke@chromium.org>
2937 Reviewed by Tony Chang.
2939 This patch completes the cleanup of
2940 rebaseline-chromium-webkit-tests to work with all of the
2941 variants of a platform (we can now rebaseline gpu- and non-gpu
2942 files at the same time).
2944 When the rebaselining is complete, any lines declared as
2945 REBASELINE in the expectations file that matches a test that was
2946 actually rebaselined will be deleted, even if only one of the
2947 variants was actually rebaselined. This may cause odd problems,
2948 but is better than where we're at today.
2950 This change removes the -g flag and deprecates -w. The -g flag is gone
2951 because GPU baselines are handled just like any other variant.
2952 The -w flag is deprecated because this tool now only works
2953 against the canaries, since that's the only place we have a full
2954 set of bots. It will be trivial to change this to
2955 build.webkit.org if we decide that's where we want them to be.
2957 Also, this patch deletes a lot of cruft that is no longer needed
2958 in the test_expectations code and the port-specific code.
2960 https://bugs.webkit.org/show_bug.cgi?id=55191
2962 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2963 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2964 * Scripts/webkitpy/layout_tests/port/base.py:
2965 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2966 * Scripts/webkitpy/layout_tests/port/chromium.py:
2967 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2968 * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2969 * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2970 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2971 * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2972 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2973 * Scripts/webkitpy/layout_tests/port/mac.py:
2974 * Scripts/webkitpy/layout_tests/port/test.py:
2975 * Scripts/webkitpy/layout_tests/port/webkit.py:
2976 * Scripts/webkitpy/layout_tests/port/win.py:
2977 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2978 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2980 2011-04-01 Dirk Pranke <dpranke@chromium.org>
2982 Reviewed by Adam Barth.
2984 rebaseline-chromium-webkit-tests does not work correctly with
2985 version-specific baselines. This patch updates the tool to use
2986 all of the version-specific bots on the canaries, and will now
2987 attempt to rebaseline all of the versions by default, although
2988 it will not update both GPU and CPU versions.
2990 Also, it will no longer modify the test_expectations.txt file
2991 *at all*. You will have to manually delete the REBASELINE lines
2992 after running the tool and determining that it did what you
2993 wanted it to do. This should be fixed in a separate bug - see
2996 https://bugs.webkit.org/show_bug.cgi?id=55608
2998 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2999 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3000 * Scripts/webkitpy/layout_tests/port/chromium.py:
3001 * Scripts/webkitpy/layout_tests/port/test.py:
3002 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3003 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3005 2011-03-31 Tony Chang <tony@chromium.org>
3007 Reviewed by Ojan Vafai.
3009 [chromium] update the rebaseline tool to know about pngs with checksums
3010 https://bugs.webkit.org/show_bug.cgi?id=57481
3012 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
3013 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3015 2011-04-01 Adam Roben <aroben@apple.com>
3017 Retrieve revision numbers from the build's got_revision property in Leaks Viewer
3019 Previously, we were getting the revision of the first revision that triggered a build.
3020 Choosing the last revision would have been more accurate. But got_revision is what is used
3021 everywhere else on build.webkit.org, and should work even when there were no changes that
3022 triggered a build (e.g., if someone clicked the Force Build button).
3024 Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
3027 Reviewed by Anders Carlsson.
3029 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3030 (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
3031 property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
3033 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
3034 (Array.prototype.first): Added this helper function to return the first element in an array
3035 that matches the given predicate, or null if no such element exists.
3037 2011-03-31 Adam Roben <aroben@apple.com>
3039 Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
3041 Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
3043 Reviewed by Darin Adler.
3045 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3046 (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
3047 URL on its own line.
3049 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3050 (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
3051 progression, and added a new test that uses a short bug URL while I was at it.
3053 2011-04-01 Adam Roben <aroben@apple.com>
3055 Mark .vcproj/.vsprops/.sln files as being Windows-only
3057 Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
3059 Reviewed by Anders Carlsson.
3061 * Scripts/webkitpy/common/config/build.py:
3062 (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
3063 directories as Windows-only.
3065 * Scripts/webkitpy/common/config/build_unittest.py:
3066 (ShoulBuildTest): Added test cases for the above.
3068 2011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com>
3070 Reviewed by Laszlo Gombos.
3072 [Qt] Build MiniBrowser for Symbian
3073 https://bugs.webkit.org/show_bug.cgi?id=56319
3075 Have MiniBrowser reference it's own copy of useragentlist.txt instead
3076 of copying QtTestBrowser's.
3077 Remove Tools/MiniBrowser/DerivedSources.pro
3078 This reduces complexity in the Tools scripts due to Symbian limitations.
3080 * DerivedSources.pro:
3081 * MiniBrowser/DerivedSources.pro: Removed.
3082 * MiniBrowser/MiniBrowser.qrc:
3083 * MiniBrowser/qt/MiniBrowser.pro:
3084 * Scripts/webkitdirs.pm:
3086 2011-03-31 Chang Shu <cshu@webkit.org>
3088 Reviewed by Darin Adler.
3090 WebKitTestRunner needs layoutTestController.clearAllDatabases
3091 https://bugs.webkit.org/show_bug.cgi?id=42540
3093 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3094 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3095 (WTR::InjectedBundle::beginTesting):
3096 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3097 (WTR::LayoutTestController::clearAllDatabases):
3098 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3100 2011-03-31 Chang Shu <cshu@webkit.org>
3102 Reviewed by Darin Adler.
3104 WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
3105 https://bugs.webkit.org/show_bug.cgi?id=42692
3107 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3109 2011-03-31 Darin Adler <darin@apple.com>
3111 Reviewed by Sam Weinig.
3113 Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
3114 https://bugs.webkit.org/show_bug.cgi?id=57573
3116 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3117 Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
3118 Removed fake definitions of keyDown and contextClick.
3120 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3121 (WTR::operator==): Added. So we can compare two WKPoint structs.
3122 (WTR::parseModifier): Added.
3123 (WTR::parseModifierArray): Added.
3124 (WTR::EventSendingController::EventSendingController): Initialize the
3126 (WTR::EventSendingController::mouseDown): Added. Calls
3127 WKBundlePageSimulateMouseDown.
3128 (WTR::EventSendingController::mouseUp): Added. Calls
3129 WKBundlePageSimulateMouseUp.
3130 (WTR::EventSendingController::mouseMoveTo): Added. Calls
3131 WKBundlePageSimulateMouseMotion.
3132 (WTR::EventSendingController::leapForward): Added.
3133 (WTR::EventSendingController::updateClickCount): Added. Used by the
3134 mouseDown/Up functions to create a click count.
3136 * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
3137 for the changes above.
3139 2011-03-31 Sergio Villar Senin <svillar@igalia.com>
3141 Reviewed by Martin Robinson.
3143 [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
3144 https://bugs.webkit.org/show_bug.cgi?id=57362
3146 Do not generate DRT output if willSendRequestReturnsNull is set.
3148 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3149 (willSendRequestCallback):
3151 2011-03-31 Vamshikrishna.Yellenki <vamshi@motorola.com> and Alejandro G. Castro <alex@igalia.com>
3153 Reviewed by Martin Robinson.
3155 Implement MiniBrowser for Gtk port.
3156 https://bugs.webkit.org/show_bug.cgi?id=48512
3158 Initial implementation of the Gtk MiniBrowser.
3160 * MiniBrowser/gtk/GNUmakefile.am: Added.
3161 * MiniBrowser/gtk/main.c: Added.
3162 (activateUriEntryCallback):
3165 (goForwardCallback):
3172 2011-03-30 Dominic Cooney <dominicc@google.com>
3174 Reviewed by Dimitri Glazkov.
3176 Adds layoutTestController.shadowRoot accessor to Mac DRT.
3177 https://bugs.webkit.org/show_bug.cgi?id=57415
3179 * DumpRenderTree/LayoutTestController.cpp:
3180 (shadowRootCallback):
3181 (LayoutTestController::staticFunctions):
3182 * DumpRenderTree/LayoutTestController.h:
3183 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3184 (LayoutTestController::shadowRoot):
3185 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3186 (LayoutTestController::shadowRoot):
3188 2011-03-30 Matthew Delaney <mdelaney@apple.com>
3190 Reviewed by Chris Marrin.
3192 Update fast/canvas tests to avoid dumping the render tree when possible
3193 https://bugs.webkit.org/show_bug.cgi?id=57493
3195 * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
3196 accelerated drawing and accelerated drawing for canvas
3198 2011-03-30 Adam Roben <aroben@apple.com>
3200 Stop ignoring leaks in CGGradientCreateWithColorStops
3202 Fixes <rdar://problem/7888547>.
3204 Rubber-stamped by John Sullivan.
3206 * Scripts/old-run-webkit-tests:
3207 (countAndPrintLeaks): Removed some code to ignore those leaks.
3209 2011-03-30 Timur Iskhodzhanov <timurrrr@google.com>
3211 Reviewed by Alexey Proskuryakov.
3213 Add some dynamic annotations to JavaScriptCore/wtf
3214 https://bugs.webkit.org/show_bug.cgi?id=53747
3216 By using these annotations we can improve the precision of finding
3217 WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
3218 These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
3220 These files don't add new functionality, so don't need extra tests.
3222 * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
3224 2011-03-30 Steve Falkenburg <sfalken@apple.com>
3226 Reviewed by Adam Roben.
3228 Share most vsprops between Release and Production builds in releaseproduction.vsprops
3229 https://bugs.webkit.org/show_bug.cgi?id=57508
3231 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
3232 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
3233 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
3234 * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
3235 * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
3236 * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
3237 * DumpRenderTree/win/ImageDiffProduction.vsprops:
3238 * DumpRenderTree/win/ImageDiffRelease.vsprops:
3239 * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
3240 * FindSafari/FindSafariProduction.vsprops:
3241 * FindSafari/FindSafariRelease.vsprops:
3242 * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
3243 * FindSafari/FindSafariReleasePGO.vsprops:
3244 * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
3245 * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
3246 * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
3247 * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
3248 * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
3249 * WebKitAPITest/WebKitAPITestProduction.vsprops:
3250 * WebKitAPITest/WebKitAPITestRelease.vsprops:
3251 * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
3252 * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
3253 * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
3254 * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
3255 * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
3256 * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
3257 * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
3258 * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
3259 * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
3260 * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
3261 * WinLauncher/WinLauncherProduction.vsprops:
3262 * WinLauncher/WinLauncherRelease.vsprops:
3263 * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
3264 * record-memory-win/record-memory-winProduction.vsprops:
3265 * record-memory-win/record-memory-winRelease.vsprops:
3266 * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
3268 2011-03-30 Steve Falkenburg <sfalken@apple.com>
3270 Reviewed by Adam Roben.
3272 Update Windows production build logic for new production configurations
3273 https://bugs.webkit.org/show_bug.cgi?id=57494
3275 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
3276 * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
3277 * DumpRenderTree/win/ImageDiffProduction.vsprops:
3278 * FindSafari/FindSafariProduction.vsprops:
3279 * FindSafari/FindSafariReleasePGO.vsprops:
3280 * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
3281 * WebKitAPITest/WebKitAPITestProduction.vsprops:
3282 * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
3283 * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
3284 * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
3285 * WinLauncher/WinLauncherProduction.vsprops:
3286 * record-memory-win/record-memory-winProduction.vsprops:
3288 2011-03-30 Robert Hogan <robert@webkit.org>
3290 Reviewed by Antonio Gomes.
3292 [Qt] Fix LoadHTMLStringItem::invoke() after r75966
3293 Unskip http/tests/navigation/go-back-to-error-page.html
3295 Also add the location of DumpRenderTreeSupportQt.h
3296 to DRT's include paths.
3298 https://bugs.webkit.org/show_bug.cgi?id=52614
3300 * DumpRenderTree/qt/DumpRenderTree.pro:
3301 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3302 * DumpRenderTree/qt/DumpRenderTreeQt.h:
3303 * DumpRenderTree/qt/GCControllerQt.cpp:
3304 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3305 (LayoutTestController::queueLoadHTMLString):
3306 * DumpRenderTree/qt/LayoutTestControllerQt.h:
3307 * DumpRenderTree/qt/PlainTextControllerQt.cpp:
3308 * DumpRenderTree/qt/TextInputControllerQt.cpp:
3309 * DumpRenderTree/qt/WorkQueueItemQt.cpp:
3310 (LoadAlternateHTMLStringItem::invoke):
3311 * DumpRenderTree/qt/WorkQueueItemQt.h:
3312 (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
3313 * QtTestBrowser/QtTestBrowser.pro:
3314 * QtTestBrowser/launcherwindow.h:
3316 2011-03-30 Adam Barth <abarth@webkit.org>
3318 Reviewed by Adam Roben.
3320 SheriffBot rollouts take too long
3321 https://bugs.webkit.org/show_bug.cgi?id=57498
3323 We used to build before landing rollouts via the commit-queue to
3324 prevent further breakage, but now that our individual commit-queue
3325 machines are slower, building takes too long. I can't remember the
3326 last time a rollout broke compile. It seems like just landing the
3327 patch is the better trade-off.
3329 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3330 * Scripts/webkitpy/tool/commands/queues_unittest.py:
3332 2011-03-30 Adam Barth <abarth@webkit.org>
3334 Remove platform/chromium-mac-snowleopard
3335 https://bugs.webkit.org/show_bug.cgi?id=57486
3337 This directory no longer exists, so we can remove it from the fallback
3340 * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3342 2011-03-30 Steve Falkenburg <sfalken@apple.com>
3344 Reviewed by Adam Roben.
3346 Rename Windows configuration Release_LTCG to Production for clarity
3347 https://bugs.webkit.org/show_bug.cgi?id=57465
3349 * DumpRenderTree/DumpRenderTree.sln:
3350 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3351 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
3352 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
3353 * DumpRenderTree/win/DumpRenderTree.vcproj:
3354 * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
3355 * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
3356 * DumpRenderTree/win/ImageDiff.vcproj:
3357 * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
3358 * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
3359 * FindSafari/FindSafari.vcproj:
3360 * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
3361 * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
3362 * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
3363 * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
3364 * MiniBrowser/MiniBrowser.vcproj:
3365 * Scripts/webkitdirs.pm:
3366 * TestWebKitAPI/win/TestWebKitAPI.sln:
3367 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3368 * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3369 * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3370 * WebKitAPITest/WebKitAPITest.vcproj:
3371 * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
3372 * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
3373 * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3374 * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
3375 * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
3376 * WebKitTestRunner/WebKitTestRunner.sln:
3377 * WebKitTestRunner/win/InjectedBundle.vcproj:
3378 * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3379 * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
3380 * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
3381 * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3382 * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
3383 * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
3384 * WinLauncher/WinLauncher.vcproj:
3385 * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
3386 * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
3387 * record-memory-win/record-memory-win.vcproj:
3388 * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
3389 * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
3391 2011-03-30 MORITA Hajime <morrita@google.com>
3393 Reviewed by Dimitri Glazkov.
3395 [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
3396 https://bugs.webkit.org/show_bug.cgi?id=56573
3398 Added LayoutTestController.shadowRoot() to Chromium DRT.
3400 * DumpRenderTree/chromium/LayoutTestController.cpp:
3401 (LayoutTestController::LayoutTestController):
3402 (LayoutTestController::shadowRoot):
3403 * DumpRenderTree/chromium/LayoutTestController.h:
3405 2011-03-30 Yuta Kitamura <yutak@chromium.org>
3407 Reviewed by Kent Tamura.
3409 [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
3410 https://bugs.webkit.org/show_bug.cgi?id=57430
3412 * DumpRenderTree/chromium/LayoutTestController.cpp:
3413 (LayoutTestController::LayoutTestController):
3414 (LayoutTestController::setPluginsEnabled):
3415 * DumpRenderTree/chromium/LayoutTestController.h:
3417 2011-03-30 Maciej Stachowiak <mjs@apple.com>
3419 Reviewed by Adam Barth.
3421 make webkit-patch upload respect -d
3422 https://bugs.webkit.org/show_bug.cgi?id=57425
3424 * Scripts/webkitpy/common/checkout/scm.py:
3425 * Scripts/webkitpy/tool/steps/commit.py:
3427 2011-03-30 Maciej Stachowiak <mjs@apple.com>
3429 Reviewed by Adam Barth.
3431 Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
3432 https://bugs.webkit.org/show_bug.cgi?id=57429
3434 * Scripts/webkitpy/common/checkout/scm.py:
3436 2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
3438 Unreviewed, rolling out r82383.
3439 http://trac.webkit.org/changeset/82383
3440 https://bugs.webkit.org/show_bug.cgi?id=57417
3442 "nrwt isn't shutting down cleanly" (Requested by dpranke on
3445 * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3446 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3447 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3449 2011-03-29 Kent Tamura <tkent@chromium.org>
3451 Reviewed by Dimitri Glazkov.
3453 Make validation message bubble testable
3454 https://bugs.webkit.org/show_bug.cgi?id=57290
3456 * DumpRenderTree/mac/DumpRenderTree.mm:
3457 (createWebViewAndOffscreenWindow): Change a setting so that validation
3458 bubbles isn't hidden automatically.
3460 2011-03-29 Dirk Pranke <dpranke@chromium.org>
3462 Reviewed by Ojan Vafai.
3464 new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
3466 It's a bit unclear whether multiple threads or multiple
3467 processes will be a better model on windows. This change will
3468 test threads for now while we're still working out the bugs in
3471 https://bugs.webkit.org/show_bug.cgi?id=57410
3473 * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3474 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3475 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3477 2011-03-29 David Levin <levin@chromium.org>
3479 Reviewed by Shinichiro Hamaji.
3481 check-webkit-style confused by two ChangeLog entries in a row from same user
3482 https://bugs.webkit.org/show_bug.cgi?id=57250
3484 * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
3485 * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
3486 * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
3487 It basically assumes only one ChangeLog entry is being processed because that is the standard case and
3488 checking more than that would be very messey.
3489 * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
3490 * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
3492 2011-03-29 Kent Tamura <tkent@chromium.org>
3494 Reviewed by Dimitri Glazkov.
3496 [Mac] Enable interactive-validation tests on Mac DRT
3497 https://bugs.webkit.org/show_bug.cgi?id=57308
3499 * DumpRenderTree/mac/DumpRenderTree.mm:
3500 (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
3502 2011-03-29 Chang Shu <cshu@webkit.org>
3504 Reviewed by Kenneth Rohde Christiansen.
3506 WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
3507 https://bugs.webkit.org/show_bug.cgi?id=42692
3509 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3510 (WTR::InjectedBundle::beginTesting):
3511 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3512 (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
3513 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3515 2011-03-24 Martin Robinson <mrobinson@igalia.com>
3517 Reviewed by Xan Lopez.
3519 [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
3520 https://bugs.webkit.org/show_bug.cgi?id=57067
3522 Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
3523 will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
3524 update DRT and pixel results as hundreds of results will need to be updated.
3526 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3527 (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
3528 by overriding the theme RC/CSS files.
3530 2011-03-29 Steve Falkenburg <sfalken@apple.com>
3532 Reviewed by Adam Roben.
3534 Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
3535 https://bugs.webkit.org/show_bug.cgi?id=57394
3537 Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
3538 InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
3539 the IDE. To avoid this, add a separate vsprops file for each project configuration that
3540 contains the required inherited property sheets.
3542 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3543 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
3544 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
3545 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
3546 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
3547 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
3548 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
3549 * DumpRenderTree/win/DumpRenderTree.vcproj:
3550 * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
3551 * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
3552 * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
3553 * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
3554 * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
3555 * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
3556 * DumpRenderTree/win/ImageDiff.vcproj:
3557 * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
3558 * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
3559 * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
3560 * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
3561 * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
3562 * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
3563 * FindSafari/FindSafari.vcproj:
3564 * FindSafari/FindSafariDebug.vsprops: Added.
3565 * FindSafari/FindSafariDebugAll.vsprops: Added.
3566 * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
3567 * FindSafari/FindSafariRelease.vsprops: Added.
3568 * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
3569 * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
3570 * FindSafari/FindSafariReleasePGO.vsprops: Added.
3571 * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
3572 * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
3573 * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
3574 * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
3575 * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
3576 * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
3577 * MiniBrowser/MiniBrowser.vcproj:
3578 * WebKitAPITest/WebKitAPITest.vcproj:
3579 * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
3580 * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
3581 * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
3582 * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
3583 * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
3584 * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
3585 * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3586 * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
3587 * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
3588 * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
3589 * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
3590 * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
3591 * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
3592 * WebKitTestRunner/win/InjectedBundle.vcproj:
3593 * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
3594 * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
3595 * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
3596 * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
3597 * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
3598 * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
3599 * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3600 * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
3601 * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
3602 * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
3603 * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
3604 * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
3605 * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
3606 * WinLauncher/WinLauncher.vcproj:
3607 * WinLauncher/WinLauncherDebug.vsprops: Added.
3608 * WinLauncher/WinLauncherDebugAll.vsprops: Added.
3609 * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
3610 * WinLauncher/WinLauncherRelease.vsprops: Added.
3611 * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
3612 * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
3613 * record-memory-win/record-memory-win.vcproj:
3614 * record-memory-win/record-memory-winDebug.vsprops: Added.
3615 * record-memory-win/record-memory-winDebugAll.vsprops: Added.
3616 * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
3617 * record-memory-win/record-memory-winRelease.vsprops: Added.
3618 * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
3619 * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
3621 2011-03-29 Adam Barth <abarth@webkit.org>
3623 Reviewed by Darin Adler.
3625 test_runner2.py can crash due to undefined variable
3626 https://bugs.webkit.org/show_bug.cgi?id=57356
3628 Replace reference to undefined variable with a variable that's actually
3629 defined. AFAICT, there's no way to test this code.
3631 * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3633 2011-03-29 Tony Chang <tony@chromium.org>
3635 Reviewed by Eric Seidel.
3637 cleanup rebaseline-chromium-webkit-tests
3638 https://bugs.webkit.org/show_bug.cgi?id=57375
3640 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3641 - Split _extract_and_add_new_baselines into 3 functions
3642 - Reduce the amount of line wrapping (the file already has lines
3643 over 80 col, so may as well try to make the file consistent)
3644 - Remove unnecessary ()s
3646 2011-03-29 Brent Fulgham <bfulgham@webkit.org>
3648 Reviewed by Adam Roben.
3650 Make WinCairo a core builder.
3651 https://bugs.webkit.org/show_bug.cgi?id=57373
3653 * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
3654 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
3656 2011-03-29 Timothy Hatcher <timothy@apple.com>
3658 Update update-webkit-localizable-strings to understand that WebKit and
3659 WebKit2 strings go in WebCore.
3661 Also make extract-localizable-strings optionally use an exclude file. No individual
3662 warnings are produced about unlocalized strings when there is no exclude file. This
3663 is needed for WebCore, since there are too many bare strings.
3665 https://webkit.org/b/57354
3667 Reviewed by Sam Weinig.
3669 * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
3670 * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
3672 2011-03-29 Darin Adler <darin@apple.com>
3674 Reviewed by Adam Roben.
3676 WebKit2 bundle page needs to offer generated file hooks
3677 https://bugs.webkit.org/show_bug.cgi?id=57279
3679 (Land missing part of the original patch after r82289.)
3681 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: