Unreviewed, rolling out r108522.
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-22  Philippe Normand  <pnormand@igalia.com>
2
3         Unreviewed, rolling out r108522.
4         http://trac.webkit.org/changeset/108522
5         https://bugs.webkit.org/show_bug.cgi?id=76181
6
7         Broke 4 fullscreen tests on GTK.
8
9         * GtkLauncher/main.c:
10         (createBrowser):
11         (createWindow):
12
13 2012-02-20  Philippe Normand  <pnormand@igalia.com>
14
15         [GTK] FullScreen signals
16         https://bugs.webkit.org/show_bug.cgi?id=76181
17
18         Reviewed by Martin Robinson.
19
20         Use the two new entering/leaving fullscreen signals to hide/show
21         the tool bar, the status bar and ask the user's permission before
22         entering fullscreen.
23
24         * GtkLauncher/main.c:
25         (webViewFullscreenMessageWindowClose):
26         (webViewWindowStateEvent):
27         (hide_widget):
28         (show_widget):
29         (webViewEnteringFullScreen):
30         (webViewLeavingFullScreen):
31         (createBrowser):
32         (createWindow):
33
34 2012-02-22  Rob Flack  <flackr@chromium.org>
35
36         Update Linux ChromiumOS builders in flakiness dashboard.
37         https://bugs.webkit.org/show_bug.cgi?id=79238
38
39         Reviewed by Ojan Vafai.
40
41         * TestResultServer/static-dashboards/builders.js:
42
43 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
44
45         webkitpy: test_function_length_check_definition_huge_lines is slow
46         https://bugs.webkit.org/show_bug.cgi?id=79185
47
48         Reviewed by Adam Barth.
49
50         This test takes ~3 seconds to run, apparently because we're
51         running a test on a 10,000 line function :). Dropping the
52         function length to 640 still exercises the code path and
53         provides a 10x speedup.
54
55         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
56         (CppStyleTest):
57         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
58
59 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
60
61         webkitpy: speed up FileLockTest.test_lock_lifecycle
62         https://bugs.webkit.org/show_bug.cgi?id=79189
63
64         Reviewed by Adam Barth.
65
66         The unit test had a second lock trying to acquire a
67         lock already held, and a hard-coded timeout of one second.
68         I have changed the timeouts to a tenth of a second (which
69         is probably still fine) and changed the hard-spin on
70         the lock to a slow-spin every hundredth of a second.
71
72         * Scripts/webkitpy/common/system/file_lock.py:
73         (FileLock.acquire_lock):
74         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
75         (FileLockTest.setUp):
76         (FileLockTest.test_stuck_lock):
77
78 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
79
80         build-webkit should use environment variable at number of CPU
81         detection on all platform
82         https://bugs.webkit.org/show_bug.cgi?id=79227
83
84         Reviewed by Martin Robinson.
85
86         * Scripts/webkitdirs.pm:
87         (determineNumberOfCPUs):
88
89 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
90
91         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
92         https://bugs.webkit.org/show_bug.cgi?id=78960
93
94         Reviewed by Csaba Osztrogonác.
95
96         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
97         (LayoutTestController::overridePreference):
98
99 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
100
101         [chromium] Build WebKit with MEDIA_STREAM disabled.
102         https://bugs.webkit.org/show_bug.cgi?id=79214
103
104         Reviewed by Kent Tamura.
105
106         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
107         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
108         * DumpRenderTree/chromium/WebViewHost.cpp:
109         (WebViewHost::createMediaPlayer):
110         * DumpRenderTree/chromium/WebViewHost.h:
111         (WebViewHost):
112
113 2012-02-22  Zeno Albisser  <zeno@webkit.org>
114
115         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
116         https://bugs.webkit.org/show_bug.cgi?id=79124
117
118         WebKitTestRunnerPrefix.h should also be included
119         when building with clang.
120
121         Reviewed by Kenneth Rohde Christiansen.
122
123         * WebKitTestRunner/Target.pri:
124
125 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
126
127         <style scoped>: Add runtime-flag
128         https://bugs.webkit.org/show_bug.cgi?id=79074
129
130         Enable the runtime-flag for DRT. 
131
132         Reviewed by Dimitri Glazkov.
133
134         * DumpRenderTree/chromium/TestShell.cpp:
135         (TestShell::TestShell):
136
137 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
138
139         Unreviewed, rolling out r107351.
140         http://trac.webkit.org/changeset/107351
141         https://bugs.webkit.org/show_bug.cgi?id=53600
142
143         Several issues introduced in WebKitGTK+ API
144
145         * DumpRenderTree/gtk/DumpRenderTree.cpp:
146         (createWebView):
147         * GtkLauncher/main.c:
148         (createWebViewCb):
149         (createBrowser):
150         (createWindow):
151         (main):
152
153 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
154
155         JSC should be a triple-tier VM
156         https://bugs.webkit.org/show_bug.cgi?id=75812
157         <rdar://problem/10079694>
158
159         Reviewed by Gavin Barraclough.
160
161         Changed EFL's build system to include a new directory in JavaScriptCore.
162
163         * DumpRenderTree/efl/CMakeLists.txt:
164
165 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
166
167         [chromium] Fix image drag out on Chromium
168         https://bugs.webkit.org/show_bug.cgi?id=79158
169
170         Reviewed by Tony Chang.
171
172         * DumpRenderTree/chromium/EventSender.cpp:
173         (EventSender::dumpFilenameBeingDragged):
174         (EventSender::beginDragWithFiles):
175         * DumpRenderTree/chromium/WebViewHost.cpp:
176         (addDRTFakeFileToDataObject):
177
178 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
179
180         webkitpy: speed up hot filesystem_mock functions
181         https://bugs.webkit.org/show_bug.cgi?id=79159
182
183         Reviewed by Adam Barth.
184
185         Profiling run_webkit_tests_integrationtest.py revealed that
186         isdir(), normpath(), and join() are called a lot and were very
187         slow.This patch speeds them up substantially, shaving 20 seconds
188         off of the execution time.
189
190         * Scripts/webkitpy/common/system/filesystem_mock.py:
191         (MockFileSystem.isdir):
192         (MockFileSystem._slow_but_correct_join):
193         (MockFileSystem.join):
194         (MockFileSystem.listdir):
195         (MockFileSystem._slow_but_correct_normpath):
196         (MockFileSystem.normpath):
197         (MockFileSystem.write_binary_file):
198         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
199         (MockFileSystemTest.quick_check):
200         (MockFileSystemTest):
201         (MockFileSystemTest.test_join):
202         (MockFileSystemTest.test_normpath):
203         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
204         (get_test_config): Call write_binary_file() instead of updating
205           filesystem.files directly, so that we create directories as
206           needed.
207
208 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
209
210         nrwt: make the delay between starting workers configurable per-port
211         https://bugs.webkit.org/show_bug.cgi?id=79148
212
213         Reviewed by Eric Seidel.
214
215         Because of bug 79147, we have to sleep a bit in between starting
216         DRTs; however, doing so across the board slows down the Test
217         port. Making this configurable shaves 10 seconds off of
218         run_webkit_tests_integrationtest.py
219         
220         * Scripts/webkitpy/layout_tests/controllers/manager.py:
221         (Manager._run_tests):
222         * Scripts/webkitpy/layout_tests/port/base.py:
223         (Port.worker_startup_delay_secs):
224         * Scripts/webkitpy/layout_tests/port/test.py:
225         (TestPort.worker_startup_delay_secs):
226
227 2012-02-21  Jon Lee  <jonlee@apple.com>
228
229         Bring notifications support to WK1 mac
230         https://bugs.webkit.org/show_bug.cgi?id=78783
231         <rdar://problem/10610578>
232
233         Reviewed by Anders Carlsson.
234
235         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
236         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
237         (-[UIDelegate timerFired]):
238
239 2012-02-21  Kentaro Hara  <haraken@chromium.org>
240
241         Enable the IDL attribute checker in run-bindings-tests
242         https://bugs.webkit.org/show_bug.cgi?id=79091
243
244         Reviewed by Adam Barth.
245
246         We have enabled the IDL attribute checker in Chromium in r108322.
247         This patch enables the IDL attribute checker in run-bindings-tests.
248
249         No tests. I manually checked that [Custommm], [CallWith=],
250         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
251         run-bindings-tests failures.
252
253         * Scripts/webkitpy/bindings/main.py:
254         (BindingsTests.generate_supplemental_dependency):
255
256 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
257
258         Add rafaelw as a committer.
259
260         Unreviewed.
261
262         * Scripts/webkitpy/common/config/committers.py:
263
264 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
265
266         webkitpy: update names after deleting message_broker
267         https://bugs.webkit.org/show_bug.cgi?id=79000
268
269         Reviewed by Eric Seidel.
270
271         Part 3 of 3 in deleting message_broker.py; this change just
272         adjusts the names for the newly merged symbols so that they are
273         private as appropriate.
274
275         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
276         (get):
277         (_Broker):
278         (_BrokerConnection):
279         (_BrokerConnection.__init__):
280         (AbstractWorker.__init__):
281         (_ManagerConnection):
282         (_ManagerConnection.__init__):
283         (_WorkerConnection):
284         (_WorkerConnection.__init__):
285
286 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
287
288         webkitpy: merge message_broker.py into manager_worker_broker.py
289         https://bugs.webkit.org/show_bug.cgi?id=78999
290
291         Reviewed by Tony Chang.
292
293         This is pretty much a straight cut-and-paste of one file into
294         another (broken up so that docstrings and imports are in the
295         right place).
296
297         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
298         (BrokerClient):
299         (BrokerClient.is_done):
300         (BrokerClient.name):
301         (Broker):
302         (Broker.__init__):
303         (Broker.add_topic):
304         (Broker._get_queue_for_topic):
305         (Broker.post_message):
306         (Broker.run_message_loop):
307         (Broker.run_all_pending):
308         (Broker._run_loop):
309         (Broker._dispatch_message):
310         (_Message):
311         (_Message.loads):
312         (_Message.__init__):
313         (_Message.dumps):
314         (_Message.__repr__):
315         (BrokerConnection):
316         (BrokerConnection.__init__):
317         (BrokerConnection.run_message_loop):
318         (BrokerConnection.post_message):
319         (BrokerConnection.raise_exception):
320         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
321
322 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
323
324         webkitpy: prepare to delete message_broker.py
325         https://bugs.webkit.org/show_bug.cgi?id=78997
326
327         Reviewed by Eric Seidel.
328
329         This is part 1 of 3 changes to fix bug 78187. This change
330         prepares the code for merging message_broker.py into
331         manager_worker_broker.py; the tests in message_broker_unittest
332         are merged into manager_worker_broker_unittest, the symbols
333         needed by the tests are exported from manager_worker_broker.py,
334         and manager_worker_broker itself is updated to refer to the
335         symbols directly (without the module prefix).
336
337         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
338         (get):
339         (AbstractWorker):
340         (AbstractWorker.__init__):
341         (_ManagerConnection):
342         (_ManagerConnection.__init__):
343         (_WorkerConnection):
344         (_WorkerConnection.__init__):
345         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
346         (InterfaceTest.test_brokerclient_is_abstract):
347         (InterfaceTest.test_brokerclient_is_abstract.methods):
348         (MessageTest):
349         (MessageTest.test__no_body):
350         (MessageTest.test__body):
351         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
352
353 2012-02-21  Sam Weinig  <sam@webkit.org>
354
355         Attempt to fix the Snow Leopard build.
356
357         * DumpRenderTree/mac/Configurations/Base.xcconfig:
358         * MiniBrowser/Configurations/Base.xcconfig:
359         * TestWebKitAPI/Configurations/Base.xcconfig:
360         * WebKitTestRunner/Configurations/Base.xcconfig:
361
362 2012-02-21  Sam Weinig  <sam@webkit.org>
363
364         Use libc++ when building with Clang on Mac
365         https://bugs.webkit.org/show_bug.cgi?id=78981
366
367         Reviewed by Dan Bernstein.
368
369         * DumpRenderTree/mac/Configurations/Base.xcconfig:
370         * MiniBrowser/Configurations/Base.xcconfig:
371         * TestWebKitAPI/Configurations/Base.xcconfig:
372         * WebKitTestRunner/Configurations/Base.xcconfig:
373
374 2012-02-21  Adam Roben  <aroben@apple.com>
375
376         Roll out r108309, r108323, and r108326
377
378         They broke the 32-bit Lion build.
379
380         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
381
382         * DumpRenderTree/efl/CMakeLists.txt:
383
384 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
385
386         [Qt][WK2] Get rid of the dependency to QtWidgets
387         https://bugs.webkit.org/show_bug.cgi?id=76276
388
389         Reviewed by Simon Hausmann.
390
391         * MiniBrowser/qt/MiniBrowser.pro:
392         * MiniBrowser/qt/MiniBrowserApplication.cpp:
393         (MiniBrowserApplication::MiniBrowserApplication):
394         (MiniBrowserApplication::notify):
395         (MiniBrowserApplication::sendTouchEvent):
396         * MiniBrowser/qt/MiniBrowserApplication.h:
397         (MiniBrowserApplication):
398         * QtTestBrowser/locationedit.h:
399         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
400         (WTR::activateFonts):
401         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
402
403 2012-02-20  Adam Barth  <abarth@webkit.org>
404
405         mastercfg_unittest.py fails without simplejson
406         https://bugs.webkit.org/show_bug.cgi?id=79070
407
408         Reviewed by Csaba Osztrogonác.
409
410         Now that we require Python 2.6 (and higher) we can import json rather
411         than simplejson.  We still need to use the simplejson name because
412         that's what the master.cfg script expects.
413
414         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
415         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
416
417 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
418
419         JSC should be a triple-tier VM
420         https://bugs.webkit.org/show_bug.cgi?id=75812
421         <rdar://problem/10079694>
422
423         Reviewed by Gavin Barraclough.
424
425         Changed EFL's build system to include a new directory in JavaScriptCore.
426
427         * DumpRenderTree/efl/CMakeLists.txt:
428
429 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
430
431         Update pywebsocket to 0.7.2
432         https://bugs.webkit.org/show_bug.cgi?id=79066
433
434         This version includes vendor-prefixed deflate-frame extension support.
435
436         Reviewed by Kent Tamura.
437
438         * Scripts/webkitpy/thirdparty/__init__.py:
439         (AutoinstallImportHook._install_pywebsocket):
440
441 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
442
443         [UNIX] Plugin information fields are not interpreted as UTF-8
444         https://bugs.webkit.org/show_bug.cgi?id=78635
445
446         Reviewed by Gustavo Noronha Silva.
447
448         Interpret plugin metadata as UTF8 aways. This matches the behavior
449         of Chromium and the Totem plugin.
450
451         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
452         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
453
454 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
455
456         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
457         https://bugs.webkit.org/show_bug.cgi?id=78935
458
459         Reviewed by Gustavo Noronha Silva.
460
461         Move the TestNetscapePlugin headers to a more appropriate directory and update
462         the build files to match.
463
464         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
465         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
466         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
467         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
468         * GNUmakefile.am: Ditto.
469
470 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
471
472         Add a new API for the Vibration API(W3C).
473         https://bugs.webkit.org/show_bug.cgi?id=72010
474
475         Reviewed by Hajime Morita.
476
477         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
478
479 2012-02-20  János Badics  <dicska@gmail.com>
480
481         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
482         https://bugs.webkit.org/show_bug.cgi?id=71816
483
484         RunQtAPITests will notify if a timeout occurs during testing.
485         Added unittest to the master.cfg
486
487         Reviewed by Csaba Osztrogonác.
488
489         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
490         (RunQtAPITests.evaluateCommand):
491         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
492         (RunQtAPITestsTest):
493         (RunQtAPITestsTest.assertResults):
494         (RunQtAPITestsTest.test_timeout):
495         (test_success):
496         (test_failure):
497         (test_timeout_and_failure):
498
499 2012-02-20  Andy Wingo  <wingo@igalia.com>
500
501         Add wingo as a committer.
502
503         Unreviewed.
504
505         * Scripts/webkitpy/common/config/committers.py: Add myself to the
506         committers list.
507
508 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
509
510         [chromium] check that we're not running multiple modal dialogs at the same time
511         https://bugs.webkit.org/show_bug.cgi?id=78486
512
513         Reviewed by Kent Tamura.
514
515         * DumpRenderTree/chromium/TestShell.cpp:
516         (TestShell::TestShell):
517         * DumpRenderTree/chromium/TestShell.h:
518         (TestShell::setIsDisplayingModalDialog):
519         (TestShell::isDisplayingModalDialog):
520         (TestShell):
521         * DumpRenderTree/chromium/WebViewHost.cpp:
522         (WebViewHost::runModal):
523
524 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
525
526         Fix WebKit2GTK+ for 'make distcheck'.
527
528         Instead of conditionally including WebKit2 GNUmakefiles, always
529         include them and conditionally activate the final targets.
530
531         * MiniBrowser/gtk/GNUmakefile.am:
532         * WebKitTestRunner/GNUmakefile.am:
533
534 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
535
536         Enable video option for EFL port in build-webkit.
537         https://bugs.webkit.org/show_bug.cgi?id=79006
538
539         Reviewed by Daniel Bates.
540
541         * Scripts/build-webkit:
542
543 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
544
545         [EFL] Use modifier keys to execute pre-rendering.
546         https://bugs.webkit.org/show_bug.cgi?id=77933
547
548         Reviewed by Chang Shu.
549
550         Use modifier key to execute pre-rendering instead of using reserved function keys.
551
552         * EWebLauncher/main.c:
553         (on_key_down):
554
555 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
556
557         Fix one more dangling reference to worker_connection.name, delete unused code.
558
559         Unreviewed, build fix.
560
561         * Scripts/webkitpy/layout_tests/controllers/manager.py:
562         (Manager.update):
563         (_WorkerState.__init__):
564
565 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
566
567         Add a change that should've been in r108005.
568
569         Unreviewed, build fix.
570
571         In the refactoring/cleanup in r108005 I should've changed the
572         implementation of WorkerConnection to make it match BrokerClient
573         (and everything else) so that objects had a name() method
574         instead of a name property.
575
576         * Scripts/webkitpy/layout_tests/controllers/manager.py:
577         (Manager._run_tests):
578         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
579         (_WorkerConnection.__init__):
580         (_WorkerConnection.name):
581         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
582         (_TestWorker.__init__):
583         (_TestsMixin.name):
584         (_TestsMixin.test_name):
585         (_TestsMixin.test_cancel):
586         (_TestsMixin.test_unknown_message):
587
588 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
589
590         webkitpy: remove webkitpy.common.array_stream
591         https://bugs.webkit.org/show_bug.cgi?id=78952
592
593         Reviewed by Eric Seidel.
594
595         Turns out array_stream didn't really do anything that StringIO
596         didn't do (at least as of Python 2.6). This change removes it
597         and updates all of the callers. Where possible, I changed the
598         test assertions in order to capture the intent more clearly,
599         e.g., instead of calling self.assertTrue('foo' in stream.get()),
600         we have self.assertContainsLine(stream, 'foo'), and instead of
601         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
602         the latter isn't that much more readable, but StringIO doesn't
603         export an empty() method.
604
605         * Scripts/webkitpy/common/array_stream.py: Removed.
606         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
607         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
608         (passing_run):
609         (run_and_capture):
610         (StreamTestingMixin):
611         (StreamTestingMixin.assertContains):
612         (StreamTestingMixin.assertContainsLine):
613         (StreamTestingMixin.assertEmpty):
614         (StreamTestingMixin.assertNotEmpty):
615         (LintTest):
616         (LintTest.test_lint_test_files):
617         (LintTest.test_lint_test_files__errors):
618         (MainTest):
619         (MainTest.test_child_process_1):
620         (MainTest.test_child_processes_2):
621         (MainTest.test_child_processes_min):
622         (MainTest.test_help_printing):
623         (MainTest.test_hung_thread):
624         (MainTest.test_no_tests_found):
625         (MainTest.test_no_tests_found_2):
626         (MainTest.test_repeat_each_iterations_num_tests):
627         (MainTest.test_test_list):
628         (MainTest.test_unexpected_failures):
629         (MainTest.test_worker_model__inline_with_child_processes):
630         (MainTest.test_additional_platform_directory):
631         (RebaselineTest):
632         (RebaselineTest.assertBaselines):
633         (RebaselineTest.test_reset_results):
634         (RebaselineTest.test_missing_results):
635         (RebaselineTest.test_new_baseline):
636         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
637         (MeteredStream.update):
638         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
639         (TestMeteredStream.test_regular):
640         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
641         (TestUtilityFunctions.assertEmpty):
642         (TestUtilityFunctions):
643         (TestUtilityFunctions.assertNotEmpty):
644         (TestUtilityFunctions.assertWritten):
645         (TestUtilityFunctions.test_configure_logging):
646         (Testprinter.assertEmpty):
647         (Testprinter):
648         (Testprinter.assertNotEmpty):
649         (Testprinter.assertWritten):
650         (Testprinter.reset):
651         (Testprinter.get_printer):
652         (Testprinter.test_help_printer):
653         (Testprinter.do_switch_tests.do_helper):
654         (Testprinter.test_print_one_line_summary):
655         (Testprinter.test_print_test_result):
656         (Testprinter.test_print_progress):
657         (Testprinter.test_write_nothing):
658         (Testprinter.test_write_misc):
659         (Testprinter.test_write_everything):
660         (Testprinter.test_write_verbose):
661         (Testprinter.test_print_unexpected_results):
662         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
663         (MainTest.assertWritten):
664         (create_runner):
665         (test_run_test_set):
666         (test_run_test_set_kills_drt_per_run):
667         (test_run_test_set_for_parser_tests):
668         (test_run_test_set_with_json_output):
669         (test_run_test_set_with_json_source):
670         (test_run_test_set_with_multiple_repositories):
671         (test_upload_json):
672
673 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
674
675         [wx] Add the WebCore/page/scrolling directory to the build dirs.
676
677         * waf/build/settings.py:
678
679 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
680
681         [wx] Unreviewed build fix. Don't error out or hang if we have
682         downloaded dependencies but server update check fails.
683
684         * waf/build/build_utils.py:
685         (download_if_newer):
686
687 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
688
689         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
690         https://bugs.webkit.org/show_bug.cgi?id=69444
691
692         Reviewed by Tony Chang.
693
694         Currently if a test's image checksum doesn't match the checksum
695         in the baseline, but the images themselves match according to
696         ImageDiff, new-run-webkit-tests ignores the problem. This is
697         probably bad, but it's not yet clear what the right thing to do
698         is. This patch will log a warning to stderr, at least (but the
699         test will still pass).
700
701         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
702         (SingleTestRunner._compare_image):
703         (SingleTestRunner._run_reftest):
704         * Scripts/webkitpy/layout_tests/port/test.py:
705         (unit_test_list):
706         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
707
708 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
709
710         NRWT does not report failure for a skipped test
711         https://bugs.webkit.org/show_bug.cgi?id=78750
712
713         Reviewed by Eric Seidel.
714
715         If a test is listed in a Skipped file and you run it anyway
716         with --force, and the test fails, currently NRWT will print
717         "test ran as expected"; this is confusing, because you probably
718         expect the test to fail and yet this might lead you to think the
719         test passed. This patch changes the expected behavior to "PASS",
720         so tests that fail will be reported.
721
722         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
723         (result_was_expected):
724         (TestExpectationParser):
725         (TestExpectationParser.expectation_for_skipped_test):
726         (TestExpectations):
727         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
728         (test_add_skipped_tests):
729         * Scripts/webkitpy/layout_tests/port/test.py:
730         (unit_test_list): Add some tests that are expected to be in a Skipped file.
731         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
732
733 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
734
735         webkitpy: fix test code after bug 78181
736         https://bugs.webkit.org/show_bug.cgi?id=78870
737
738         Reviewed by Adam Barth.
739
740         I forgot to update the test code as per Tony's suggestion in
741         bug 78181 (r108005). This change does that, and in doing so
742         it revealed a subtle bug in _InlineWorkerConnection.run() that
743         I am fixing as part of this (_alive would not be cleared if an
744         exception was thrown).
745
746         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
747         (_InlineWorkerConnection.run):
748         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
749         (_TestWorker.__init__):
750         (_TestWorker.handle_stop):
751         (_TestWorker.handle_test):
752         (_TestWorker.run):
753         (_TestsMixin.handle_exception):
754         (_TestsMixin.test_unknown_message):
755
756 2012-02-17  Adam Roben  <aroben@apple.com>
757
758         Mac build fix after r108119
759
760         * DumpRenderTree/mac/DumpRenderTree.mm:
761         (runThread):
762         (runPthread):
763         (testThreadIdentifierMap):
764         Updated to match current WTF threading APIs.
765
766 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
767
768         revert r107147 - breaks webkit-patch on Mac SL
769         https://bugs.webkit.org/show_bug.cgi?id=78866
770
771         Reviewed by Adam Barth.
772
773         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
774         which is the version that ships on Mac SL. Reverting this
775         change until we no longer have to worry about that version.
776
777         * Scripts/webkitpy/common/system/autoinstall.py:
778         (AutoInstaller):
779         (AutoInstaller._extract_all): Added a comment about SL.
780         (AutoInstaller._unzip):
781
782 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
783
784         CSS regions enabled by default
785         https://bugs.webkit.org/show_bug.cgi?id=78525
786
787         Reviewed by David Hyatt.
788
789         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
790         CSSRegions are still enabled by default.
791         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
792
793         * DumpRenderTree/chromium/LayoutTestController.cpp:
794         (LayoutTestController::overridePreference):
795         * DumpRenderTree/chromium/WebPreferences.cpp:
796         (WebPreferences::reset):
797         (WebPreferences::applyTo):
798         * DumpRenderTree/chromium/WebPreferences.h:
799         (WebPreferences):
800         * DumpRenderTree/mac/DumpRenderTree.mm:
801         (resetDefaultsToConsistentValues):
802
803 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
804
805         Some API tests erroneously use = instead of == (causing build failures)
806         https://bugs.webkit.org/show_bug.cgi?id=78915
807
808         Reviewed by Sam Weinig.
809
810         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
811         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
812         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
813
814 2012-02-17  Peter Beverloo  <peter@chromium.org>
815
816         [Chromium] Include TestShellLinux.cpp in the build for Android
817         https://bugs.webkit.org/show_bug.cgi?id=78865
818
819         Reviewed by Eric Seidel.
820
821         Android will be re-using the TestShellLinux.cpp file. I already
822         added this r104033, but it seems to have gotten lost in the
823         recent refactorings.
824
825         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
826
827 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
828
829         Unreviewed, disable video build on EFL until it can be
830         supported by EFL build bot.
831
832         * Scripts/build-webkit:
833
834 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
835
836         [GTK] Implement zoom in/out in MiniBrowser
837         https://bugs.webkit.org/show_bug.cgi?id=75253
838
839         Reviewed by Gustavo Noronha Silva.
840
841         * MiniBrowser/gtk/BrowserWindow.c:
842         (browserWindowCanZoomIn):
843         (browserWindowCanZoomOut):
844         (browserWindowUpdateZoomActions):
845         (webViewZoomLevelChanged):
846         (zoomInCallback):
847         (zoomOutCallback):
848         (browser_window_init):
849         (browserWindowConstructed):
850
851 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
852
853         layoutTestController.display() is flaky for SVG tests
854         https://bugs.webkit.org/show_bug.cgi?id=78021
855
856         Reviewed by Adam Roben.
857
858         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
859         Size the web view before running the test, not when dumping.
860         All platforms handle this correctly now.
861
862         * DumpRenderTree/win/DumpRenderTree.cpp:
863         (dump):
864         (sizeWebViewForCurrentTest):
865         (runTest):
866
867 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
868
869         [GTK] Make install is broken when building without --enable-gtk-doc
870         https://bugs.webkit.org/show_bug.cgi?id=78828
871
872         Reviewed by Martin Robinson.
873
874         * gtk/generate-gtkdoc:
875         (rebase_installed_docs): Check documentation has been generated
876         before trying to rebase it.
877
878 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
879
880         nrwt: simplify worker interface
881         https://bugs.webkit.org/show_bug.cgi?id=78181
882
883         Reviewed by Tony Chang.
884
885         This change moves code in name(), is_done(), run(), and cancel()
886         from Worker to AbstractWorker, since the logic is pretty much
887         boilerplate code that any implementation would want to use.
888
889         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
890         (get.should):
891         (AbstractWorker.__init__):
892         (AbstractWorker):
893         (AbstractWorker.name):
894         (AbstractWorker.stop_handling_messages):
895         (AbstractWorker.run):
896         (AbstractWorker.is_done):
897         (AbstractWorker.cancel):
898         * Scripts/webkitpy/layout_tests/controllers/worker.py:
899         (Worker.__init__):
900         (Worker.run):
901         (Worker.handle_stop):
902
903 2012-02-16  Michael Saboff  <msaboff@apple.com>
904
905         ENH: Add ability to run subset of JavaScript layout tests with JSC
906         https://bugs.webkit.org/show_bug.cgi?id=78764
907
908         Reviewed by Gavin Barraclough.
909
910         New simple test drive shell script that runs a defined
911         list of javascript tests using jsc and the standalone-{pre,post}.js
912         wrappers.
913
914         * Scripts/run-fast-jsc: Added.
915
916 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
917
918         Add new Qt performance tester bot to build.webkit.org
919         https://bugs.webkit.org/show_bug.cgi?id=78795
920
921         Reviewed by Adam Roben.
922
923         * BuildSlaveSupport/build.webkit.org-config/config.json:
924
925 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
926
927         Disable inspector on WinCE.
928
929         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
930
931         * Scripts/build-webkit:
932
933 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
934
935         WinCE build fix after r107656.
936
937         Disable FTPDIR on WinCE, since it does not compile there.
938
939         * Scripts/build-webkit:
940
941 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
942
943         Build fix after r107863.
944
945         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
946
947 2012-02-15  Tony Chang  <tony@chromium.org>
948
949         [chromium] add linux dbg back to garden-o-matic
950         https://bugs.webkit.org/show_bug.cgi?id=78752
951
952         Reviewed by Adam Barth.
953
954         This reflects the current linux debug bot name (there's only one bot).
955         I'm also remove the mac clang builder since it doesn't exist (mac
956         always uses clang now).
957
958         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
959         * Scripts/webkitpy/layout_tests/port/builders.py:
960
961 2012-02-15  Sam Weinig  <sam@webkit.org>
962
963         Add style check for ctype functions that are generally frowned upon in WebKit
964         https://bugs.webkit.org/show_bug.cgi?id=78748
965
966         Reviewed by Anders Carlsson.
967
968         Not every platform has DisallowCType.h to check for uses of the ctype.h
969         functions, so add a style check for them as well.
970
971         * Scripts/webkitpy/style/checkers/cpp.py:
972         (check_ctype_functions):
973         (check_style):
974         (CppChecker):
975         Add check.
976
977         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
978         (WebKitStyleTest.test_ctype_fucntion):
979         Add checker.
980
981 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
982
983         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
984         https://bugs.webkit.org/show_bug.cgi?id=76546
985
986         Reviewed by Simon Hausmann.
987
988         Resize the web view programatically because the declarative property binding
989         does not work. Seems like our qml environment is not initialized fully but it
990         needs more investigation.
991
992         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
993         (WTR::WrapperWindow::handleStatusChanged):
994         (WTR::PlatformWebView::resizeTo):
995
996 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
997
998         webkitpy: add a worker_args concept to start_worker()
999         https://bugs.webkit.org/show_bug.cgi?id=78572
1000
1001         Reviewed by Tony Chang.
1002
1003         This change replaces the three NRWT-specific arguments passed
1004         through the broker to the worker with a generic WorkerArguments
1005         wrapper class and a separate set_inline_arguments() call that can
1006         be used to pass additional data to the worker when it is running
1007         in the same process as the manager (this is needed for testing).
1008         With the addition of set_inline_arguments() we also no longer
1009         need to pass an optional argument to the worker.run() call.
1010
1011         Note that this method is *only* implemented on inline workers,
1012         so calling this on a regular (child process) worker will result
1013         in a runtime error.
1014
1015         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1016         (Manager._run_tests):
1017         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1018         (AbstractWorker.__init__):
1019         (AbstractWorker.run):
1020         (_ManagerConnection.start_worker):
1021         (_InlineManager.start_worker):
1022         (_InlineManager.set_inline_arguments):
1023         (_InlineManager.run_message_loop):
1024         (_MultiProcessManager.start_worker): Reworked signature.
1025         (_WorkerConnection.__init__):
1026         (_InlineWorkerConnection.__init__):
1027         (_InlineWorkerConnection.set_inline_arguments): New method.
1028         (_InlineWorkerConnection):
1029         (_InlineWorkerConnection.run):
1030         (_Process.run):
1031         (_MultiProcessWorkerConnection.__init__):
1032         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1033         (_TestWorker.__init__):
1034         (_TestWorker.set_inline_arguments):
1035         (_TestWorker.handle_test):
1036         (_TestWorker.run):
1037         (_TestsMixin.test_cancel):
1038         (_TestsMixin.test_done):
1039         (_TestsMixin.test_unknown_message):
1040         (InlineBrokerTests): New class for more testing.
1041         (InlineBrokerTests.setUp):
1042         (InlineBrokerTests.test_inline_arguments): New test.
1043         (InterfaceTest.test_managerconnection_is_abstract):
1044         (InterfaceTest.test_workerconnection_is_abstract):
1045         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1046         (WorkerArguments):
1047         (WorkerArguments.__init__):
1048         (Worker.__init__):
1049         (Worker.set_inline_arguments):
1050         (Worker):
1051         (Worker.run):
1052         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
1053         (WorkerTest.test_default_platform_in_worker):
1054
1055 2012-02-15  Adam Klein  <adamk@chromium.org>
1056
1057         Unreviewed, rolling out r107704.
1058         http://trac.webkit.org/changeset/107704
1059         https://bugs.webkit.org/show_bug.cgi?id=78486
1060
1061         Caused layout test crashes in debug builds.
1062
1063         Specific crashing tests:
1064
1065         fast/events/show-modal-dialog-onblur-onfocus.html
1066         fast/harness/show-modal-dialog.html
1067         inspector/console/console-long-eval-crash.html
1068
1069         * DumpRenderTree/chromium/TestShell.cpp:
1070         (TestShell::TestShell):
1071         * DumpRenderTree/chromium/TestShell.h:
1072         (TestShell):
1073         * DumpRenderTree/chromium/WebViewHost.cpp:
1074         (WebViewHost::runModal):
1075
1076 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
1077
1078         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
1079         https://bugs.webkit.org/show_bug.cgi?id=76347
1080
1081         Reviewed by Kenneth Rohde Christiansen.
1082
1083         * MiniBrowser/qt/MiniBrowser.qrc:
1084         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
1085         * MiniBrowser/qt/qml/BrowserWindow.qml:
1086         * MiniBrowser/qt/qml/DialogLineInput.qml:
1087
1088 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
1089
1090         [Qt] Fix WebGL in QtTestBrowser
1091
1092         Reviewed by Tor Arne Vestbø.
1093
1094         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
1095         the options for enabling GL we also pass them on properly.
1096
1097 2012-02-14  Sam Weinig  <sam@webkit.org>
1098
1099         Add #include of unistd.h on the mac for getcwd. 
1100
1101         Reviewed by Anders Carlsson.
1102
1103         This is necessary when building with libc++.
1104
1105         * WebKitTestRunner/TestInvocation.cpp:
1106
1107 2012-02-14  Sam Weinig  <sam@webkit.org>
1108
1109         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
1110         https://bugs.webkit.org/show_bug.cgi?id=78663
1111
1112         Reviewed by Anders Carlsson.
1113
1114         * DumpRenderTree/DumpRenderTreePrefix.h:
1115         * DumpRenderTree/cg/ImageDiffCG.cpp:
1116
1117 2012-02-14  Adam Barth  <abarth@webkit.org>
1118
1119         Implement an adb-based driver for the ChromiumAndroidPort
1120         https://bugs.webkit.org/show_bug.cgi?id=78627
1121
1122         Reviewed by Eric Seidel.
1123
1124         This driver mostly just wires up the ChromiumDriver through adb.  In
1125         some cases, it translates protocol elements, such as URIs, so that the
1126         rest of webkitpy is insulated from the "remoteness" of the target device.
1127
1128         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1129         (ChromiumAndroidPort.start_helper):
1130         (ChromiumAndroidPort._driver_class):
1131         (ChromiumAndroidPort._update_version):
1132         (ChromiumAndroidPort._get_stderr):
1133         (ChromiumAndroidPort):
1134         (ChromiumAndroidPort._get_last_stacktrace):
1135         (ChromiumAndroidPort._teardown_performance):
1136         (ChromiumAndroidDriver):
1137         (ChromiumAndroidDriver.__init__):
1138         (ChromiumAndroidDriver._start):
1139         (ChromiumAndroidDriver.run_test):
1140         (ChromiumAndroidDriver.stop):
1141         (ChromiumAndroidDriver._test_shell_command):
1142         (ChromiumAndroidDriver._write_command_and_read_line):
1143         (ChromiumAndroidDriver._output_image):
1144         (ChromiumAndroidDriver._has_crash_hint):
1145
1146 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1147
1148         webkitpy: the real_name() method in the Port class is no longer needed
1149         https://bugs.webkit.org/show_bug.cgi?id=78651
1150
1151         Reviewed by Eric Seidel.
1152
1153         The change in bug 78565 / r107718 made it no longer necessary
1154         (we can use options.platform instead).
1155
1156         * Scripts/webkitpy/layout_tests/port/base.py:
1157         (Port.name):
1158         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1159         (MockDRTPort.__init__):
1160
1161 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1162
1163         webkitpy: clean up options, port handling in manager_worker_broker
1164         https://bugs.webkit.org/show_bug.cgi?id=78568
1165
1166         Reviewed by Tony Chang.
1167
1168         manager_worker_broker no longer needs options or port objects
1169         directly, so we make them only be passed in start_worker().
1170
1171         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1172         (Manager._run_tests):
1173         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1174         (get):
1175         (_ManagerConnection.__init__):
1176         (_ManagerConnection.start_worker):
1177         (_InlineManager.__init__):
1178         (_InlineManager.start_worker):
1179         (_InlineManager.run_message_loop):
1180         (_MultiProcessManager.__init__):
1181         (_MultiProcessManager):
1182         (_MultiProcessManager.start_worker):
1183         (_InlineWorkerConnection.__init__):
1184         (_InlineWorkerConnection.run):
1185         (_Process.__init__):
1186         (_MultiProcessWorkerConnection.__init__):
1187         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1188         (make_broker):
1189         (_TestWorker.run):
1190         (_TestsMixin.test_cancel):
1191         (_TestsMixin.test_done):
1192         (_TestsMixin.test_unknown_message):
1193         (MultiProcessBrokerTests.setUp):
1194         (InterfaceTest.test_managerconnection_is_abstract):
1195         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
1196         (Broker.__init__):
1197
1198 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1199
1200         nrwt: add a unit test for regression introduced in bug 78565
1201         https://bugs.webkit.org/show_bug.cgi?id=78646
1202
1203         Reviewed by Tony Chang.
1204
1205         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
1206         (FakeConnection):
1207         (FakeConnection.run_message_loop):
1208         (FakeConnection.post_message):
1209         (WorkerTest):
1210         (WorkerTest.test_default_platform_in_worker):
1211
1212 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1213
1214         NRWT is broken for the default port
1215         https://bugs.webkit.org/show_bug.cgi?id=78640
1216     
1217         Reviewed by Tony Chang.
1218
1219         The change in r107718 (bug 78565) broke NRWT if you didn't
1220         specify any sort of --platform flag or equivalent. I didn't
1221         catch this because it's a full integration test (which we don't
1222         have an automated test for) and I missed this command line
1223         variant when testing interactively.
1224
1225         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1226         (Worker.run):
1227
1228 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
1229
1230         Last character display for passwords in Android.
1231         https://bugs.webkit.org/show_bug.cgi?id=78532
1232
1233         Reviewed by Adam Barth.
1234
1235         * DumpRenderTree/chromium/WebPreferences.cpp:
1236         (WebPreferences::applyTo):
1237
1238 2012-02-14  Adam Barth  <abarth@webkit.org>
1239
1240         Finish implementing start_helper for ChromiumAndroidPort
1241         https://bugs.webkit.org/show_bug.cgi?id=78582
1242
1243         Reviewed by Eric Seidel.
1244
1245         This patch contains the remaining odds and ends for the start_helper function.
1246
1247         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1248         (ChromiumAndroidPort.start_helper):
1249         (ChromiumAndroidPort._synchronize_datetime):
1250         (ChromiumAndroidPort):
1251         (ChromiumAndroidPort._check_version):
1252         (ChromiumAndroidPort._run_adb_command):
1253         (ChromiumAndroidPort._copy_device_file):
1254
1255 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1256
1257         webkitpy: create ports in Workers, not in manager_worker_broker
1258         https://bugs.webkit.org/show_bug.cgi?id=78565
1259
1260         Reviewed by Tony Chang.
1261
1262         We will now create the Port object (if necessary) in the Worker
1263         directly, so that the manager_worker_broker module doesn't need
1264         all of this layout_test-specific logic. Part of the fixes for
1265         bug 78171.
1266
1267         These changes are all well-tested by the existing tests in
1268         run_webkit_tests_integrationtest.py.
1269
1270         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1271         (_Process.run):
1272         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1273         (Worker.__init__):
1274         (Worker.safe_init):
1275         (Worker.run):
1276         (Worker.cleanup):
1277         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1278         (parse_args):
1279         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
1280
1281 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
1282
1283         [chromium] check that we're not running multiple modal dialogs at the same time
1284         https://bugs.webkit.org/show_bug.cgi?id=78486
1285
1286         Reviewed by Kent Tamura.
1287
1288         * DumpRenderTree/chromium/TestShell.cpp:
1289         (TestShell::TestShell):
1290         * DumpRenderTree/chromium/TestShell.h:
1291         (TestShell::setIsDisplayingModalDialog):
1292         (TestShell::isDisplayingModalDialog):
1293         (TestShell):
1294         * DumpRenderTree/chromium/WebViewHost.cpp:
1295         (WebViewHost::runModal):
1296
1297 2012-02-14  Adam Barth  <abarth@webkit.org>
1298
1299         Enable the GPU codepath in the chromium-android port
1300         https://bugs.webkit.org/show_bug.cgi?id=78580
1301
1302         Reviewed by James Robinson.
1303
1304         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
1305         Android always uses the GPU codepath, so we set the GPU flags on the
1306         main chromium-android port instead.
1307
1308         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1309         (ChromiumAndroidPort.__init__):
1310
1311 2012-02-14  Adam Barth  <abarth@webkit.org>
1312
1313         NRWT should expose --adb-args flag for Android
1314         https://bugs.webkit.org/show_bug.cgi?id=78579
1315
1316         Reviewed by Eric Seidel.
1317
1318         This flag is already wired up to the ChromiumAndroidPort.
1319
1320         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1321         (parse_args):
1322
1323 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
1324
1325         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
1326         https://bugs.webkit.org/show_bug.cgi?id=78541
1327         <rdar://problem/10036695>
1328
1329         Reviewed by Kent Tamura.
1330
1331         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
1332         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
1333         After each test, reset to using new protocol.
1334
1335 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
1336
1337         Convert svg/animations to use SMIL methods for driving the timeline
1338         https://bugs.webkit.org/show_bug.cgi?id=78422
1339
1340         Reviewed by Dirk Schulze.
1341
1342         Remove no longer needed SVG specific animation sampling functionality from DRT.
1343         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
1344
1345         * DumpRenderTree/LayoutTestController.cpp:
1346         (LayoutTestController::staticFunctions):
1347         * DumpRenderTree/LayoutTestController.h:
1348         (LayoutTestController):
1349         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1350         * DumpRenderTree/chromium/LayoutTestController.cpp:
1351         (LayoutTestController::LayoutTestController):
1352         * DumpRenderTree/chromium/LayoutTestController.h:
1353         (LayoutTestController):
1354         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1355         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1356         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1357         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1358         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1359         (LayoutTestController):
1360         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1361         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1362
1363 2012-02-13  Rob Flack  <flackr@chromium.org>
1364
1365         Add Linux ChromiumOS test results to flakiness dashboard.
1366         https://bugs.webkit.org/show_bug.cgi?id=78495
1367
1368         Reviewed by Ojan Vafai.
1369
1370         * TestResultServer/static-dashboards/builders.js:
1371         * TestResultServer/static-dashboards/dashboard_base.js:
1372
1373 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
1374
1375         [GTK] Mutation Observers build is broken
1376         https://bugs.webkit.org/show_bug.cgi?id=78433
1377
1378         Reviewed by Martin Robinson.
1379
1380         Enabled mutation observers as a default feature for GTK port, too.
1381
1382         * Scripts/build-webkit:
1383
1384 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
1385
1386         Allow to configure ENABLE_FTPDIR in build-webkit
1387         https://bugs.webkit.org/show_bug.cgi?id=65098
1388
1389         Reviewed by Eric Seidel.
1390
1391         Allow to disable ENABLE_FTPDIR by command line.
1392         Remove ENABLE_FTPDIR from --minimal build
1393
1394         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
1395         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
1396         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
1397
1398 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
1399
1400         Add shinyak as committer.
1401
1402         Unreviewed.
1403
1404         * Scripts/webkitpy/common/config/committers.py:
1405
1406 2012-02-13  Adam Barth  <abarth@webkit.org>
1407
1408         Implement start/stop_helper for ChromiumAndroidPort
1409         https://bugs.webkit.org/show_bug.cgi?id=78558
1410
1411         Reviewed by Dirk Pranke.
1412
1413         These functions (and their dependencies) set up the Android device for
1414         testing.
1415
1416         This patch also includes a few tweaks on the previous patch recommended
1417         by dpranke.
1418
1419         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1420         (ChromiumAndroidPort.__init__):
1421         (ChromiumAndroidPort.start_helper):
1422         (ChromiumAndroidPort.stop_helper):
1423         (ChromiumAndroidPort._shut_down_http_server):
1424         (ChromiumAndroidPort):
1425         (ChromiumAndroidPort._push_executable):
1426         (ChromiumAndroidPort._push_fonts):
1427         (ChromiumAndroidPort._restore_system_font):
1428         (ChromiumAndroidPort._push_test_resources):
1429         (ChromiumAndroidPort._push_to_device):
1430         (ChromiumAndroidPort._pull_from_device):
1431         (ChromiumAndroidPort._kill_device_process):
1432         (ChromiumAndroidPort._setup_performance):
1433         (ChromiumAndroidPort._teardown_performance):
1434         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1435         (ChromiumAndroidPortTest):
1436         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1437         (PortTestCase):
1438         (PortTestCase.make_port):
1439         (PortTestCase.test_default_worker_model):
1440
1441 2012-02-13  Adam Barth  <abarth@webkit.org>
1442
1443         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
1444         https://bugs.webkit.org/show_bug.cgi?id=78550
1445
1446         Reviewed by Eric Seidel.
1447
1448         Much of this code just forwards to the "host" port, which seems like a
1449         reasonable thing to do.
1450
1451         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1452         (ChromiumAndroidPort.__init__):
1453         (ChromiumAndroidPort.stop_helper):
1454         (ChromiumAndroidPort):
1455         (ChromiumAndroidPort._build_path):
1456         (ChromiumAndroidPort._path_to_apache):
1457         (ChromiumAndroidPort._path_to_apache_config_file):
1458         (ChromiumAndroidPort._path_to_driver):
1459         (ChromiumAndroidPort._path_to_helper):
1460         (ChromiumAndroidPort._path_to_image_diff):
1461         (ChromiumAndroidPort._path_to_lighttpd):
1462         (ChromiumAndroidPort._path_to_lighttpd_modules):
1463         (ChromiumAndroidPort._path_to_lighttpd_php):
1464         (ChromiumAndroidPort._path_to_wdiff):
1465         (ChromiumAndroidPort._shut_down_http_server):
1466         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1467         (ChromiumAndroidPortTest):
1468         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1469         (PortTestCase):
1470         (PortTestCase.make_port):
1471         (PortTestCase.test_default_worker_model):
1472
1473 2012-02-13  Adam Barth  <abarth@webkit.org>
1474
1475         chromium_android.py should implement "virtual" methods from ChromiumPort
1476         https://bugs.webkit.org/show_bug.cgi?id=78545
1477
1478         Reviewed by Dirk Pranke.
1479
1480         This patch adds basic implementations that specialize a bunch of
1481         functions from ChromiumPort.
1482
1483         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1484         (ChromiumAndroidPort):
1485         (ChromiumAndroidPort.__init__):
1486         (ChromiumAndroidPort.default_child_processes):
1487         (ChromiumAndroidPort.baseline_search_path):
1488         (ChromiumAndroidPort.check_build):
1489         (ChromiumAndroidPort.check_sys_deps):
1490         (ChromiumAndroidPort.default_worker_model):
1491         (ChromiumAndroidPort.test_expectations):
1492         (ChromiumAndroidPort.start_http_server):
1493         (ChromiumAndroidPort.stop_http_server):
1494         (ChromiumAndroidPort.start_helper):
1495         (ChromiumAndroidPort.stop_helper):
1496
1497 2012-02-13  Adam Barth  <abarth@webkit.org>
1498
1499         Add a skeleton ChromiumAndroid port to webkitpy
1500         https://bugs.webkit.org/show_bug.cgi?id=78543
1501
1502         Reviewed by Eric Seidel.
1503
1504         This patch just adds an empty ChromiumAndroid port object to webkitpy
1505         and wires it up to the factory objects.  An actual implementation will
1506         follow.
1507
1508         * Scripts/webkitpy/layout_tests/port/chromium.py:
1509         (ChromiumPort):
1510         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
1511         (ChromiumAndroidPort):
1512         (ChromiumAndroidPort.__init__):
1513         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1514         (ChromiumPortTest.test_all_test_configurations):
1515         * Scripts/webkitpy/layout_tests/port/factory.py:
1516         (PortFactory):
1517
1518 2012-02-13  Adam Barth  <abarth@webkit.org>
1519
1520         NRWT's HTTP servers should support additional directories for resources
1521         https://bugs.webkit.org/show_bug.cgi?id=78528
1522
1523         Reviewed by Eric Seidel.
1524
1525         This functionality will be used by the Chromium-Android port.
1526
1527         * Scripts/webkitpy/layout_tests/port/base.py:
1528         (Port.to.start_http_server):
1529         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1530         (LayoutTestApacheHttpd.__init__):
1531         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1532         (Lighttpd.__init__):
1533         (Lighttpd._prepare_config):
1534
1535 2012-02-13  Ami Fischman  <fischman@chromium.org>
1536
1537         Add fischman as committer.
1538
1539         Unreviewed
1540
1541         * Scripts/webkitpy/common/config/committers.py:
1542
1543 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
1544
1545         [EFL] Drop support for the Curl network backend.
1546         https://bugs.webkit.org/show_bug.cgi?id=77874
1547
1548         Reviewed by Eric Seidel.
1549
1550         Nobody seems to be maintaining the Curl backend in WebCore, the
1551         EFL port developers all seem to be using the Soup backend and the
1552         port itself has many features which are only implemented for the
1553         latter.
1554
1555         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
1556         and always add the required include directories.
1557         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
1558         include directories and link to them.
1559
1560 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
1561
1562         [WebSocket] Update pywebsocket to 0.7.1
1563         https://bugs.webkit.org/show_bug.cgi?id=78484
1564
1565         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
1566
1567         Reviewed by Kent Tamura.
1568
1569         * Scripts/webkitpy/thirdparty/__init__.py:
1570         (AutoinstallImportHook._install_pywebsocket):
1571
1572 2012-02-12  Kangil Han  <kangil.han@samsung.com>
1573
1574         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
1575         https://bugs.webkit.org/show_bug.cgi?id=78091
1576
1577         Reviewed by Hajime Morita.
1578
1579         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
1580         This patch will activate around 1,900 test cases from skipped list in EFL port.
1581
1582         * DumpRenderTree/efl/EventSender.cpp:
1583         (textZoom):
1584         (pageZoom):
1585         (textZoomInCallback):
1586         (textZoomOutCallback):
1587         (zoomPageInCallback):
1588         (zoomPageOutCallback):
1589
1590 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
1591
1592         KeywordLookupGenerator.py script fails in some cases
1593         https://bugs.webkit.org/show_bug.cgi?id=77886
1594
1595         Reviewed by Benjamin Poulain.
1596
1597         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
1598         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
1599         (GlobalVariablesTest.test_path_rules_specifier):
1600
1601 2012-02-12  Joe Thomas  <joethomas@motorola.com>
1602
1603         Add toText and isTextNode helpers in Text class.
1604         https://bugs.webkit.org/show_bug.cgi?id=78140
1605
1606         Unit test case for the new style checker introduced.
1607
1608         Reviewed by Adam Barth.
1609
1610         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1611         (CppStyleTest):
1612         (CppStyleTest.test_static_cast_readability): Added a unit test case.
1613
1614 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1615
1616         Enable features supported by EFL port in build-webkit.
1617         https://bugs.webkit.org/show_bug.cgi?id=78348
1618
1619         Reviewed by Ryosuke Niwa.
1620
1621         Sync build-webkit with OptionEfl.cmake, as some features enabled in
1622         OptionEfl.cmake are not enabled in build-webkit.
1623
1624         * Scripts/build-webkit:
1625
1626 2012-02-12  Joe Thomas  <joethomas@motorola.com>
1627
1628         Add toText and isTextNode helpers in Text class.
1629         https://bugs.webkit.org/show_bug.cgi?id=78140
1630
1631         Added a style checker to use toText rather than static_cast<Text*>.
1632
1633         Reviewed by Adam Barth.
1634
1635         * Scripts/webkitpy/style/checkers/cpp.py:
1636         (check_language): Style checker for static_cast<Text*>.
1637
1638 2012-02-12  Philippe Normand  <pnormand@igalia.com>
1639
1640         Unreviewed, disable Mutation observers build on GTK until it can
1641         actually build.
1642
1643         * Scripts/build-webkit:
1644
1645 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
1646
1647         Add back WTFURL to WebKit
1648         https://bugs.webkit.org/show_bug.cgi?id=77291
1649
1650         Reviewed by Adam Barth.
1651
1652         Add a flag to build-webkit to easily build WebKit with WTFURL.
1653
1654         * Scripts/build-webkit:
1655
1656 2012-02-10  Adam Klein  <adamk@chromium.org>
1657
1658         Enable MUTATION_OBSERVERS by default on all platforms
1659         https://bugs.webkit.org/show_bug.cgi?id=78196
1660
1661         Reviewed by Ojan Vafai.
1662
1663         * Scripts/build-webkit:
1664
1665 2012-02-10  Adam Barth  <abarth@webkit.org>
1666
1667         Move garden-o-matic's All Failures out of experimental
1668         https://bugs.webkit.org/show_bug.cgi?id=78395
1669
1670         Reviewed by Dimitri Glazkov.
1671
1672         Several folks have tried this feature and found it useful.
1673
1674         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1675
1676 2012-02-10  Tim Horton  <timothy_horton@apple.com>
1677
1678         NRWT should categorize options in --help
1679         https://bugs.webkit.org/show_bug.cgi?id=76221
1680
1681         Reviewed by Eric Seidel.
1682         
1683         Use optparse's OptionGroup mechanism to logically group NRWT's options,
1684         providing a better experience when scanning all the options.
1685
1686         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1687         (parse_args):
1688
1689 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1690
1691         [Qt][WK2] Refactor on Qt5 Layout tests' structure
1692         https://bugs.webkit.org/show_bug.cgi?id=77450
1693
1694         Reviewed by Csaba Osztrogonác.
1695
1696         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
1697         to qt-5.0-wk2 and qt-5.0-wk1.
1698
1699         * Scripts/old-run-webkit-tests:
1700         (buildPlatformResultHierarchy):
1701         (readSkippedFiles):
1702         * Scripts/webkitpy/layout_tests/port/qt.py:
1703         (QtPort._wk2_port_name):
1704         (QtPort._skipped_file_search_paths):
1705         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1706         (QtPortTest.test_baseline_search_path):
1707         * Scripts/webkitpy/layout_tests/port/webkit.py:
1708         (WebKitPort._wk2_port_name):
1709
1710 2012-02-09  Philippe Normand  <pnormand@igalia.com>
1711
1712         [GTK] EWS command-line option to run the tests
1713         https://bugs.webkit.org/show_bug.cgi?id=78211
1714
1715         Reviewed by Adam Barth.
1716
1717         New --run-tests option (defaults to False) for the EWS commands.
1718
1719         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1720         (AbstractEarlyWarningSystem):
1721         (AbstractEarlyWarningSystem.__init__):
1722         (AbstractEarlyWarningSystem.review_patch):
1723         (ChromiumLinuxEWS):
1724         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1725         (EarlyWarningSytemTest._test_builder_ews):
1726
1727 2012-02-09  Eric Seidel  <eric@webkit.org>
1728
1729         Rename compare_text and compare_audio to make it clear that they're !=
1730         https://bugs.webkit.org/show_bug.cgi?id=78301
1731
1732         Reviewed by Adam Barth.
1733
1734         I also removed the maybe_create_directory function which was redundant.
1735
1736         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1737         (Manager.set_up_run):
1738         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1739         (TestResultWriter._make_output_directory):
1740         * Scripts/webkitpy/layout_tests/port/base.py:
1741         (Port.do_text_results_differ):
1742         (Port.do_audio_results_differ):
1743         (Port.diff_text):
1744         (Port.driver_name):
1745         (Port.skips_perf_test):
1746         * Scripts/webkitpy/layout_tests/port/win.py:
1747         (WinPort.do_text_results_differ):
1748         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1749         (WinPortTest.test_do_text_results_differ):
1750         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1751         (LayoutTestApacheHttpd.__init__):
1752         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1753         (HttpServerBase.__init__):
1754         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1755         (Rebaseliner._diff_baselines):
1756
1757 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
1758
1759         [GTK] Add DRT support for modal dialogs
1760         https://bugs.webkit.org/show_bug.cgi?id=53600
1761
1762         Reviewed by Martin Robinson.
1763
1764         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
1765         Most significantly, when creating a new web view in GtkLauncher, the window
1766         of the web view opener is passed around. In DumpRenderTree, the window of
1767         the main web view is always considered as the opener. This is required so
1768         the modal dialog's toplevel can be made transient for the opener's toplevel.
1769
1770         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1771         (webViewRunModalDialog):
1772         (createWebView):
1773         * GtkLauncher/main.c:
1774         (createWebViewCb):
1775         (runModalDialogCb):
1776         (createBrowser):
1777         (createWindow):
1778         (main):
1779
1780 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
1781
1782         [Gtk] security/set-form-autocomplete-attribute.html fails
1783         https://bugs.webkit.org/show_bug.cgi?id=78261
1784
1785         Reviewed by Martin Robinson.
1786
1787         Use the new helper in DumpRenderTreeSupportGtk to properly
1788         test whether an element performs autocompletion.
1789
1790         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1791         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
1792
1793 2012-02-09  James Robinson  <jamesr@chromium.org>
1794
1795         [chromium] Enable mock scrollbars for compositing layout tests
1796         https://bugs.webkit.org/show_bug.cgi?id=78299
1797
1798         Reviewed by Dirk Pranke.
1799
1800         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
1801         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
1802         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
1803
1804         * DumpRenderTree/chromium/TestShell.cpp:
1805         (TestShell::runFileTest):
1806         * DumpRenderTree/chromium/WebPreferences.cpp:
1807         (WebPreferences::reset):
1808         (WebPreferences::applyTo):
1809         * DumpRenderTree/chromium/WebPreferences.h:
1810         (WebPreferences):
1811
1812 2012-02-09  Eric Seidel  <eric@webkit.org>
1813
1814         Remove more uses of "os" from our webkitpy code
1815         https://bugs.webkit.org/show_bug.cgi?id=78292
1816
1817         Reviewed by Adam Barth.
1818
1819         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1820         (MockCheckout.__init__):
1821         (MockCheckout.is_path_to_changelog):
1822         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1823         * Scripts/webkitpy/common/system/filesystem_mock.py:
1824         (MockFileSystem._split):
1825         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1826         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1827         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1828         * Scripts/webkitpy/layout_tests/port/webkit.py:
1829         * Scripts/webkitpy/tool/bot/queueengine.py:
1830         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1831         * Scripts/webkitpy/tool/commands/download.py:
1832         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1833         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1834         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1835         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1836         * Scripts/webkitpy/tool/commands/upload.py:
1837         (CreateBug.prompt_for_bug_title_and_comment):
1838         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1839         * Scripts/webkitpy/tool/steps/attachtobug.py:
1840         (AttachToBug.run):
1841         * Scripts/webkitpy/tool/steps/checkstyle.py:
1842         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1843         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1844         * Scripts/webkitpy/tool/steps/editchangelog.py:
1845         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1846         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1847         (PrepareChangeLogTest.test_ensure_bug_url):
1848         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1849         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1850         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1851         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1852
1853 2012-02-09  Eric Seidel  <eric@webkit.org>
1854
1855         Remove the cr-mac-ews (it's long been dead)
1856         https://bugs.webkit.org/show_bug.cgi?id=78267
1857
1858         Reviewed by Adam Barth.
1859
1860         * QueueStatusServer/model/queues.py:
1861         (Queue):
1862         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1863         (ChromiumWindowsEWS):
1864         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1865         (EarlyWarningSytemTest._test_builder_ews):
1866         (EarlyWarningSytemTest._test_testing_ews):
1867
1868 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
1869
1870         some tests in webkitpy are being run three times
1871         https://bugs.webkit.org/show_bug.cgi?id=78283
1872
1873         Reviewed by Ryosuke Niwa.
1874
1875         It turns out that if you import a class derived from
1876         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
1877         the unittest framework treats it as if the class was defined in
1878         the file (as well in the original file). This led us to running
1879         the tests in ChangeLogTest three times.
1880
1881         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1882         (PrepareChangeLogTest):
1883         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1884         (_assert_message_for_revert_output):
1885
1886 2012-02-09  Adam Barth  <abarth@webkit.org>
1887
1888         Remove extraneous line in previous patch.  I forgot to remove this
1889         before landing.
1890
1891         * Scripts/webkitpy/layout_tests/port/driver.py:
1892         (DriverProxy.start):
1893
1894 2012-02-09  Adam Barth  <abarth@webkit.org>
1895
1896         run-perf-tests should have an option to pause before running tests so we can attach Instruments
1897         https://bugs.webkit.org/show_bug.cgi?id=78271
1898
1899         Reviewed by Ryosuke Niwa.
1900
1901         This lets me attach instruments to profile the performance of the test.
1902
1903         * Scripts/webkitpy/layout_tests/port/chromium.py:
1904         (ChromiumDriver.start):
1905         * Scripts/webkitpy/layout_tests/port/driver.py:
1906         (Driver.start):
1907         (DriverProxy.start):
1908         * Scripts/webkitpy/layout_tests/port/server_process.py:
1909         (ServerProcess.start):
1910         * Scripts/webkitpy/layout_tests/port/test.py:
1911         (TestDriver.start):
1912         * Scripts/webkitpy/layout_tests/port/webkit.py:
1913         (WebKitDriver.start):
1914         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1915         (get_tests_run.RecordingTestDriver.start):
1916         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1917         (PerfTestsRunner._parse_args):
1918         (PerfTestsRunner._run_tests_set):
1919         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1920         (start):
1921         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1922         (test_run_test_set_kills_drt_per_run):
1923         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
1924         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
1925
1926 2012-02-09  Adam Barth  <abarth@webkit.org>
1927
1928         run-perf-tests --chromium should run the chromium port
1929         https://bugs.webkit.org/show_bug.cgi?id=78266
1930
1931         Reviewed by Ryosuke Niwa.
1932
1933         This patch makes run-perf-tests work more like run-webkit-tests.
1934
1935         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1936         (PerfTestsRunner._parse_args):
1937
1938 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1939
1940         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
1941         https://bugs.webkit.org/show_bug.cgi?id=77466
1942
1943         Reviewed by Dirk Pranke.
1944
1945         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
1946         is set or if we should raise an error. A unit test was added.
1947
1948         * Scripts/webkitpy/layout_tests/port/qt.py:
1949         (QtPort.operating_system):
1950         (QtPort):
1951         (QtPort.check_sys_deps):
1952         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1953         (QtPortTest.test_operating_system):
1954         (QtPortTest):
1955         (QtPortTest.test_check_sys_deps):
1956
1957 2012-02-09  Eric Seidel  <eric@webkit.org>
1958
1959         Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
1960         https://bugs.webkit.org/show_bug.cgi?id=78263
1961
1962         Reviewed by Adam Barth.
1963
1964         * Scripts/webkitpy/common/config/ports.py:
1965         (DeprecatedPort):
1966         (DeprecatedPort.name):
1967         (DeprecatedPort.flag):
1968         (DeprecatedPort.script_path):
1969         (DeprecatedPort.script_shell_command):
1970         (DeprecatedPort.port):
1971         (DeprecatedPort.makeArgs):
1972         (DeprecatedPort.update_webkit_command):
1973         (DeprecatedPort.check_webkit_style_command):
1974         (DeprecatedPort.prepare_changelog_command):
1975         (DeprecatedPort.build_webkit_command):
1976         (DeprecatedPort.run_javascriptcore_tests_command):
1977         (DeprecatedPort.run_webkit_unit_tests_command):
1978         (DeprecatedPort.run_webkit_tests_command):
1979         (DeprecatedPort.run_python_unittests_command):
1980         (DeprecatedPort.run_perl_unittests_command):
1981         (DeprecatedPort.layout_tests_results_path):
1982         (MacPort):
1983         (WinPort):
1984         (GtkPort):
1985         (GtkPort.build_webkit_command):
1986         (GtkPort.run_webkit_tests_command):
1987         (QtPort):
1988         (QtPort.build_webkit_command):
1989         (EflPort):
1990         (EflPort.build_webkit_command):
1991         (ChromiumPort):
1992         (ChromiumPort.update_webkit_command):
1993         (ChromiumPort.build_webkit_command):
1994         (ChromiumPort.run_webkit_tests_command):
1995         (ChromiumPort.run_javascriptcore_tests_command):
1996         (ChromiumXVFBPort):
1997         (ChromiumXVFBPort.run_webkit_tests_command):
1998         * Scripts/webkitpy/common/config/ports_unittest.py:
1999         (DeprecatedPortTest):
2000         (DeprecatedPortTest.test_mac_port):
2001         (DeprecatedPortTest.test_gtk_port):
2002         (DeprecatedPortTest.test_qt_port):
2003         (DeprecatedPortTest.test_chromium_port):
2004         (DeprecatedPortTest.test_chromium_xvfb_port):
2005         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2006         (AbstractEarlyWarningSystem.__init__):
2007         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2008         * Scripts/webkitpy/tool/main.py:
2009         (WebKitPatch):
2010         (WebKitPatch.handle_global_options):
2011         * Scripts/webkitpy/tool/steps/abstractstep.py:
2012         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2013         (StepsTest.test_runtests_args):
2014
2015 2012-02-09  Jochen Eisinger  <jochen@chromium.org>
2016
2017         [chromium] always initialize makeArgs in buildChromiumNinja
2018         https://bugs.webkit.org/show_bug.cgi?id=78231
2019
2020         Reviewed by Tony Gentilcore.
2021
2022         * Scripts/webkitdirs.pm:
2023         (buildChromiumNinja):
2024
2025 2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2026
2027         [GTK] Show url of current hovered link in MiniBrowser
2028         https://bugs.webkit.org/show_bug.cgi?id=78098
2029
2030         Reviewed by Martin Robinson.
2031
2032         * MiniBrowser/gtk/BrowserWindow.c:
2033         (webViewMouseTargetChanged): Check whether hit test result is a
2034         link and use the url to update the status bar text.
2035         (browserWindowConstructed): Connect to
2036         WebKitWebView::mouse-target-changed signal.
2037
2038 2012-02-09  Rob Buis  <rbuis@rim.com>
2039
2040         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2041         https://bugs.webkit.org/show_bug.cgi?id=78042
2042
2043         Reviewed by Antonio Gomes.
2044
2045         Upstream final part of our DRT implementation.
2046
2047         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
2048         * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
2049         * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
2050         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
2051         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
2052
2053 2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
2054
2055         kill-old-processes should kill gcc and clang
2056         https://bugs.webkit.org/show_bug.cgi?id=78189
2057
2058         Reviewed by Eric Seidel.
2059
2060         Added a bunch of processes names of gcc and clang to the list.
2061
2062         * BuildSlaveSupport/kill-old-processes:
2063
2064 2012-02-07  MORITA Hajime  <morrita@google.com>
2065
2066         Replacement text should be available from the marker.
2067         https://bugs.webkit.org/show_bug.cgi?id=77934
2068
2069         Made the mock requestCheckingOfText() implementation to return
2070         a replacement text for each misspelled word if available.
2071
2072         Reviewed by Kent Tamura.
2073
2074         * DumpRenderTree/chromium/WebViewHost.cpp:
2075         (WebViewHost::finishLastTextCheck):
2076
2077 2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2078
2079         [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
2080         https://bugs.webkit.org/show_bug.cgi?id=78146
2081
2082         Reviewed by Ryosuke Niwa.
2083
2084         Our DumpRenderTree should support --no-timeout and --timeout options in order
2085         to be able to use run-perf-tests and have a Performance Bot.
2086         This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
2087         and the necessary code to handle such command line arguments to our DumpRenderTree.
2088
2089         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2090         (WebCore::DumpRenderTree::setTimeout):
2091         (WebCore):
2092         (WebCore::DumpRenderTree::setShouldTimeout):
2093         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2094         (DumpRenderTree):
2095         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2096         (LayoutTestController::LayoutTestController):
2097         (LayoutTestController::waitUntilDone):
2098         (LayoutTestController::notifyDone):
2099         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2100         (LayoutTestController::setTimeout):
2101         (LayoutTestController::setShouldTimeout):
2102         (LayoutTestController):
2103         * DumpRenderTree/qt/main.cpp:
2104         (isOption):
2105         (printUsage):
2106         (main):
2107
2108 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2109
2110         Rubber-stamped by Martin Robinson.
2111
2112         * gtk/common.py:
2113         (get_build_path): Move test for current directory being a valid
2114         directory up so it takes precedence over WebKitBuild/Release and
2115         WebKitBuild/Debug when they exist as well.
2116
2117 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2118
2119         [GTK] doc rebasing does not respect DESTDIR
2120         https://bugs.webkit.org/show_bug.cgi?id=78177
2121
2122         Reviewed by Martin Robinson.
2123
2124         * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
2125         calling it for rebasing.
2126         * gtk/generate-gtkdoc:
2127         (get_common_options): Handle the new --virtual-root option.
2128         * gtk/gtkdoc.py:
2129         (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
2130         it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
2131
2132 2012-02-08  Adam Barth  <abarth@webkit.org>
2133
2134         Remove Python 2.5 support from WebKit
2135         https://bugs.webkit.org/show_bug.cgi?id=71593
2136
2137         Reviewed by Eric Seidel.
2138
2139         This is the last vestige of our Python 2.5 support.
2140
2141         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2142         (AbstractQueueTest.test_log_from_script_error_for_upload):
2143
2144 2012-02-08  Adam Barth  <abarth@webkit.org>
2145
2146         version_check.py should inform users that we don't support Python 2.5 anymore
2147         https://bugs.webkit.org/show_bug.cgi?id=78179
2148
2149         Reviewed by Eric Seidel.
2150
2151         We don't support Python 2.5 anymore.
2152
2153         * Scripts/webkitpy/common/version_check.py:
2154
2155 2012-02-08  Adam Barth  <abarth@webkit.org>
2156
2157         test_configuration.py shouldn't re-implement itertools
2158         https://bugs.webkit.org/show_bug.cgi?id=78178
2159
2160         Reviewed by Eric Seidel.
2161
2162         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2163         (TestConfigurationConverter.to_specifiers_list):
2164         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2165         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2166         (TestConfigurationConverter):
2167
2168 2012-02-08  Adam Barth  <abarth@webkit.org>
2169
2170         webkitpy should reply upon the multiprocessing package existing
2171         https://bugs.webkit.org/show_bug.cgi?id=78176
2172
2173         Reviewed by Eric Seidel.
2174
2175         Now that we don't support Python 2.5, this import can't fail.
2176
2177         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2178         (get):
2179         (_Process):
2180         (_Process.__init__):
2181         (_Process.run):
2182         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2183         (FunctionTests.test_get__processes):
2184         (MultiProcessBrokerTests.setUp):
2185         * Scripts/webkitpy/layout_tests/port/base.py:
2186         (Port.__init__):
2187         (Port.default_worker_model):
2188         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2189         (ChromiumMacPort.check_build):
2190         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2191         (PortTestCase.test_default_worker_model):
2192         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2193
2194 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2195
2196         Unreviewed typo fix that makes docs build again for the gtk2-based
2197         library.
2198
2199         * gtk/generate-gtkdoc:
2200
2201 2012-02-08  Adam Barth  <abarth@webkit.org>
2202
2203         Don't re-implement ZipFile.extractall
2204         https://bugs.webkit.org/show_bug.cgi?id=78173
2205
2206         Reviewed by Eric Seidel.
2207
2208         We can use ZipFile.extractall now that we don't support Python 2.5.
2209
2210         * Scripts/webkitpy/common/system/autoinstall.py:
2211         (AutoInstaller._extract_targz):
2212         (AutoInstaller._unzip):
2213
2214 2012-02-08  Adam Barth  <abarth@webkit.org>
2215
2216         Remove the ospath compat shim from webkitpy
2217         https://bugs.webkit.org/show_bug.cgi?id=78170
2218
2219         Reviewed by Eric Seidel.
2220
2221         We no longer need this compat shim now that we don't support Python 2.5.
2222
2223         * Scripts/webkitpy/common/checkout/scm/git.py:
2224         * Scripts/webkitpy/common/checkout/scm/svn.py:
2225         * Scripts/webkitpy/common/system/filesystem.py:
2226         (FileSystem.relpath):
2227         * Scripts/webkitpy/common/system/filesystem_mock.py:
2228         (MockFileSystem.relpath):
2229         * Scripts/webkitpy/common/system/ospath.py: Removed.
2230         * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
2231
2232 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2233
2234         Build fix attempt after r107053.
2235
2236         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2237         (test_collect_tests):
2238
2239 2012-02-08  Adam Barth  <abarth@webkit.org>
2240
2241         Remove simplejson because it's no longer used by webkitpy
2242         https://bugs.webkit.org/show_bug.cgi?id=78164
2243
2244         Reviewed by Eric Seidel.
2245
2246         All the importers of this code were removed in a previous patch.
2247
2248         * Scripts/webkitpy/thirdparty/simplejson: Removed.
2249         * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
2250         * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
2251         * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
2252         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
2253         * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
2254         * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
2255         * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
2256         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
2257         * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
2258         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
2259
2260 2012-02-08  Adam Barth  <abarth@webkit.org>
2261
2262         webkitpy still imports simplejson
2263         https://bugs.webkit.org/show_bug.cgi?id=78161
2264
2265         Reviewed by Eric Seidel.
2266
2267         We no longer support Python 2.5, so we can rely upon Python's built-in
2268         JSON package.
2269
2270         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2271         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2272         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
2273         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2274         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2275         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2276         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2277         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2278         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2279         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2280         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2281
2282 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2283
2284         [GTK] Fails to build docs with non-standard build directories
2285         https://bugs.webkit.org/show_bug.cgi?id=78118
2286
2287         * gtk/common.py:
2288         (get_build_path): add comment to document changes done in r107098,
2289         as requested by the reviewer and forgotten by me.
2290
2291 2012-02-08  Adam Barth  <abarth@webkit.org>
2292
2293         Stop importing with_statement from the mysterious future
2294         https://bugs.webkit.org/show_bug.cgi?id=78156
2295
2296         Reviewed by Eric Seidel.
2297
2298         The future is now!  (Well, at least 2008, when Python 2.6 was released,
2299         is no longer the __future__.)
2300
2301         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2302         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2303         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2304         * Scripts/webkitpy/common/net/credentials_unittest.py:
2305         * Scripts/webkitpy/common/net/file_uploader.py:
2306         * Scripts/webkitpy/common/newstringio_unittest.py:
2307         * Scripts/webkitpy/common/system/autoinstall.py:
2308         * Scripts/webkitpy/common/system/crashlogs.py:
2309         * Scripts/webkitpy/common/system/fileset.py:
2310         * Scripts/webkitpy/common/system/filesystem.py:
2311         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2312         * Scripts/webkitpy/common/system/path.py:
2313         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
2314         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2315         * Scripts/webkitpy/layout_tests/port/base.py:
2316         (of):
2317         * Scripts/webkitpy/layout_tests/port/gtk.py:
2318         * Scripts/webkitpy/layout_tests/port/test.py:
2319         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2320         * Scripts/webkitpy/style/filereader_unittest.py:
2321         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2322         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2323         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2324         * Scripts/webkitpy/tool/commands/queues.py:
2325         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2326         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2327
2328 2012-02-08  Rob Buis  <rbuis@rim.com>
2329
2330         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2331         https://bugs.webkit.org/show_bug.cgi?id=78042
2332
2333         Reviewed by Antonio Gomes.
2334
2335         Upstream more parts of our DRT implementation.
2336
2337         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
2338         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
2339         * DumpRenderTree/blackberry/EventSender.cpp: Added.
2340         * DumpRenderTree/blackberry/EventSender.h: Added.
2341         * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
2342         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
2343
2344 2012-02-08  Dirk Pranke  <dpranke@chromium.org>
2345
2346         check-webkit-style failing with "Path does not exist."
2347         https://bugs.webkit.org/show_bug.cgi?id=77873
2348
2349         Reviewed by Ojan Vafai.
2350
2351         This change fixes the way the style checker determines which
2352         Port class to use for a given test_expectations.txt path; the
2353         previous version used a heuristic that didn't really work in the
2354         first place.
2355
2356         * Scripts/webkitpy/style/checkers/test_expectations.py:
2357         (TestExpectationsChecker._determine_port_from_expectations_path):
2358         (TestExpectationsChecker.__init__):
2359         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2360         (TestExpectationsTestCase._expect_port_for_expectations_path):
2361         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2362
2363 2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>
2364
2365         nrwt: make --skip-pixel-test-if-no-baseline option
2366         https://bugs.webkit.org/show_bug.cgi?id=70484
2367
2368         Reviewed by Dirk Pranke.
2369
2370         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2371         (SingleTestRunner.__init__):
2372         (SingleTestRunner._should_fetch_expected_checksum):
2373         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2374         (Worker.handle_test_list):
2375         * Scripts/webkitpy/layout_tests/models/test_input.py:
2376         (TestInput.__init__):
2377         * Scripts/webkitpy/layout_tests/port/webkit.py:
2378         (WebKitDriver.cmd_line):
2379         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2380         (_set_up_derived_options):
2381         (parse_args):
2382         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2383         (MainTest.test_skip_pixel_test_if_no_baseline_option):
2384         * WebKitTestRunner/TestController.cpp:
2385         (WTR::TestController::TestController):
2386         (WTR::TestController::initialize):
2387         (WTR::TestController::runTest):
2388         * WebKitTestRunner/TestController.h:
2389         (TestController):
2390         * WebKitTestRunner/TestInvocation.cpp:
2391         (WTR::TestInvocation::TestInvocation):
2392         (WTR::TestInvocation::setIsPixelTest):
2393         * WebKitTestRunner/TestInvocation.h:
2394         (WTR::TestInvocation::setSkipPixelTestOption):
2395         (TestInvocation):
2396
2397 2012-02-08  Rob Buis  <rbuis@rim.com>
2398
2399         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2400         https://bugs.webkit.org/show_bug.cgi?id=78042
2401
2402         Reviewed by Antonio Gomes.
2403
2404         Add implementation for our DumpRenderTree solution.
2405
2406         * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
2407         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
2408
2409 2012-02-08  Antti Koivisto  <antti@apple.com>
2410
2411         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
2412         https://bugs.webkit.org/show_bug.cgi?id=78080
2413
2414         Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
2415         
2416         Add API test.
2417
2418         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2419         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
2420         (TestWebKitAPI):
2421         (TestWebKitAPI::TEST):
2422
2423 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2424
2425         [GTK] Fails to build docs with non-standard build directories
2426         https://bugs.webkit.org/show_bug.cgi?id=78118
2427
2428         Reviewed by Martin Robinson.
2429
2430         * gtk/common.py:
2431         (get_build_path): also try the current directory as a valid build
2432         dir, which makes non-standard build directories such as build-2.0
2433         and build-3.0 work
2434
2435 2012-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2436
2437         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
2438         https://bugs.webkit.org/show_bug.cgi?id=78099
2439
2440         Reviewed by Martin Robinson.
2441
2442         * MiniBrowser/gtk/BrowserWindow.c:
2443         (webViewDecidePolicy): Check whether it's a link clicked with the
2444         middle mouse button and load the request in a new window.
2445         (browserWindowConstructed): Connect to
2446         WebKitWebView::decide-policy signal.
2447
2448 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2449
2450         Revert a part of the change in r106687 as a build fix.
2451
2452         Since Chromium port doesn't checkout the entire WebKit trunk,
2453         we can't run "svn info" on webkit_base.
2454
2455         * Scripts/webkitpy/layout_tests/port/base.py:
2456         (Port.repository_paths):
2457
2458 2012-02-07  Ryosuke Niwa  <rniwa@webkit.org>
2459
2460         run-perf-tests doesn't recognize paths that start with PerformanceTests
2461         https://bugs.webkit.org/show_bug.cgi?id=78012
2462
2463         Reviewed by Adam Barth.
2464
2465         Use resolve paths using filesystem.relpath before passing it to find_files.find.
2466
2467         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2468         (PerfTestsRunner):
2469         (PerfTestsRunner._collect_tests):
2470         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2471         (test_collect_tests):
2472         (test_collect_tests.add_file):
2473
2474 2012-02-07  Justin Novosad  <junov@chromium.org>
2475
2476         [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
2477         https://bugs.webkit.org/show_bug.cgi?id=78039
2478
2479         Reviewed by Stephen White.
2480
2481         Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
2482
2483         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2484         (main):
2485         * DumpRenderTree/chromium/TestShell.cpp:
2486         (TestShell::TestShell):
2487         (TestShell::resetWebSettings):
2488         (TestShell::runFileTest):
2489         * DumpRenderTree/chromium/TestShell.h:
2490         (TestShell::setDeferred2dCanvasEnabled):
2491         (TestShell):
2492         * DumpRenderTree/chromium/WebPreferences.cpp:
2493         (WebPreferences::reset):
2494         (WebPreferences::applyTo):
2495         * DumpRenderTree/chromium/WebPreferences.h:
2496         (WebPreferences):
2497
2498 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2499
2500         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
2501         https://bugs.webkit.org/show_bug.cgi?id=77928
2502
2503         Reviewed by Daniel Bates.
2504
2505         CMake has used *Programs* directory for executable. In addition, shared libraries are being
2506         built in source directory. It is better to set common places in order to maintain executable
2507         and libraries. *bin* is for executable and *lib* is for library.
2508
2509         * DumpRenderTree/efl/CMakeLists.txt:
2510         * EWebLauncher/CMakeLists.txt:
2511         * Scripts/run-launcher:
2512         * Scripts/webkitdirs.pm:
2513         (jscProductDir):
2514         * Scripts/webkitpy/layout_tests/port/efl.py:
2515         (EflPort._path_to_driver):
2516         (EflPort._path_to_image_diff):
2517
2518 2012-02-07  Adam Klein  <adamk@chromium.org>
2519
2520         Add JSC support for delivering mutations when the outermost script context exits
2521         https://bugs.webkit.org/show_bug.cgi?id=70289
2522
2523         Reviewed by Eric Seidel.
2524
2525         * DumpRenderTree/mac/EventSendingController.mm: Add support for
2526         eventSender.scheduleAsynchronousKeyDown.
2527         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2528         (+[EventSendingController webScriptNameForSelector:]):
2529         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
2530         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
2531         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
2532
2533 2012-02-07  Chris Rogers  <crogers@google.com>
2534
2535         Add Chris Rogers to reviewers section
2536         https://bugs.webkit.org/show_bug.cgi?id=78016
2537
2538         Reviewed by Adam Barth.
2539
2540         * Scripts/webkitpy/common/config/committers.py:
2541
2542 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
2543
2544         layoutTestController.display() is flaky for SVG tests
2545         https://bugs.webkit.org/show_bug.cgi?id=78021
2546
2547         Reviewed by Dan Bernstein.
2548
2549         Fix race condition in repaint rect tracking. When running a test using the repaint.js
2550         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
2551         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
2552         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
2553         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
2554         the repaint test already run, thus invalidating the previously tracked repaint rects.
2555
2556         * DumpRenderTree/mac/DumpRenderTree.mm:
2557         (dump):
2558         (runTest):
2559
2560 2012-02-07  Hans Wennborg  <hans@chromium.org>
2561
2562         Chromium: remove WebSpeechInputResult::set
2563         https://bugs.webkit.org/show_bug.cgi?id=77977
2564
2565         Reviewed by Darin Fisher.
2566
2567         It was renamed to assign() in r106475.
2568
2569         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2570         (makeRectResult):
2571
2572 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2573
2574         [Qt] Give emulated touch-point a radius
2575         https://bugs.webkit.org/show_bug.cgi?id=77985
2576         
2577         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
2578
2579         Reviewed by Kenneth Rohde Christiansen.
2580
2581         * MiniBrowser/qt/BrowserWindow.cpp:
2582         (BrowserWindow::updateVisualMockTouchPoints):
2583         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2584         (MiniBrowserApplication::notify):
2585         * MiniBrowser/qt/qml/MockTouchPoint.qml:
2586
2587 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
2588
2589         [GTK] Include gdk-pixbuf in the jhbuild modules
2590         https://bugs.webkit.org/show_bug.cgi?id=77980
2591
2592         Reviewed by Gustavo Noronha Silva.
2593
2594         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
2595
2596 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
2597
2598         [Qt] Prevent early test termination with newer Qt 5
2599         https://bugs.webkit.org/show_bug.cgi?id=77945
2600
2601         Reviewed by Csaba Osztrogonác.
2602
2603         QTBUG-24120 tracks a regression in Qt that would make layout tests
2604         terminate early. This patch works around it in a Qt 4 + 5 safe manner
2605         by disabling the quitOnLastWindowClosed feature, which we don't want/need
2606         for DRT anyway.
2607
2608         * DumpRenderTree/qt/main.cpp:
2609         (main): Don't quit on last window closed.
2610
2611 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
2612
2613         Fix some miscellaneous 'make dist' error for WebKitGTK+.
2614
2615         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
2616         files should not be distributed.
2617
2618 2012-02-02  Hajime Morrita  <morrita@chromium.org>
2619
2620         [PerformanceTests] Each Dromaeo test needs its landing html.
2621         https://bugs.webkit.org/show_bug.cgi?id=77504
2622
2623         Reviewed by Ryosuke Niwa.
2624
2625         Added an ignorable pattern which happens in some Dromaeo tests.
2626
2627         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2628         (PerfTestsRunner):
2629
2630 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
2631
2632         [GTK] Add missing pango include dir to fix build
2633         https://bugs.webkit.org/show_bug.cgi?id=77832
2634
2635         Reviewed by Martin Robinson.
2636
2637         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
2638
2639 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
2640
2641         [GTK] Fix remaining errors in GTK+ WebKit2 API
2642         https://bugs.webkit.org/show_bug.cgi?id=77890
2643
2644         Reviewed by Gustavo Noronha Silva.
2645
2646         Verify that WebKit2 GTK+ test files are not skipped during style checks.
2647         Skip soup_server_new when checking for NULL versus 0 usage.
2648
2649         * Scripts/webkitpy/style/checker_unittest.py:
2650         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
2651         * Scripts/webkitpy/style/checkers/cpp.py:
2652         (check_for_null):
2653
2654 2012-02-06  Eric Seidel  <eric@webkit.org>
2655
2656         webkit-patch apply-from-bug should be able to apply non-reviewed patches
2657         https://bugs.webkit.org/show_bug.cgi?id=77883
2658
2659         Reviewed by Adam Barth.
2660
2661         This is very helpful if you use bugzilla as a replacement for git-stash.
2662         Makes it simpler to re-apply the patch w/o having to look up the patch id.
2663
2664         * Scripts/webkitpy/tool/commands/download.py:
2665         (ProcessBugsMixin._fetch_list_of_patches_to_process):
2666         * Scripts/webkitpy/tool/commands/download_unittest.py:
2667         (DownloadCommandsTest.test_apply_from_bug):
2668
2669 2012-02-06  Philippe Normand  <pnormand@igalia.com>
2670
2671         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
2672         https://bugs.webkit.org/show_bug.cgi?id=77866
2673
2674         Reviewed by Martin Robinson.
2675
2676         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
2677         errors in some gstreamer source code files defining new GStreamer elements.
2678         * Scripts/webkitpy/style/checker_unittest.py:
2679         (GlobalVariablesTest.test_path_rules_specifier):
2680
2681 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2682
2683         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
2684         https://bugs.webkit.org/show_bug.cgi?id=77869
2685
2686         Reviewed by Philippe Normand.
2687
2688         * gtk/gtkdoc.py:
2689         (GTKDoc.rebase_installed_docs): Check html_dir exists.
2690
2691 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2692
2693         [Qt] Don't version QtWebKit.experimental.
2694         https://bugs.webkit.org/show_bug.cgi?id=77739
2695
2696         Reviewed by Tor Arne Vestbø.
2697
2698         * MiniBrowser/qt/qml/BrowserWindow.qml:
2699
2700 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2701
2702         [GTK] Fix several gtkdoc-fixxref warnings
2703         https://bugs.webkit.org/show_bug.cgi?id=77613
2704
2705         Reviewed by Martin Robinson.
2706
2707         * gtk/generate-gtkdoc:
2708         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
2709         of ignored files, since it's private.
2710         * gtk/gtkdoc.py:
2711         (GTKDoc._ignored_files_basenames): Helper function that returns a
2712         string with the list of ignored files basenames separated by a
2713         spaces, as expected by several gtkdoc commands.
2714         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
2715         --ignore-headers option.
2716         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
2717         --ignore-files option.
2718
2719 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2720
2721         [GTK] Fix xrefs after installing API documentation
2722         https://bugs.webkit.org/show_bug.cgi?id=77551
2723
2724         Reviewed by Martin Robinson.
2725
2726         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
2727         api docs.
2728         * gtk/common.py:
2729         (prefix_of_pkg_config_file): Get the prefix variable of the given
2730         pkg-config file.
2731         (gtk_version_of_pkg_config_file): Get the gtk version required by
2732         the given pkg-config file.
2733         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
2734         installed documentation.
2735         (get_gtkdoc_module_paths): Get paths where API doc is installed
2736         for the dependencies of the given pkg-config file.
2737         (get_common_xref_deps): Get API doc directories of dependencies
2738         common to WebKit1 and WebKit2.
2739         (get_webkit2_options): Add cross_reference_deps option.
2740         (get_webkit1_options): Ditto
2741         (rebase_installed_docs): Helper function to create a generator for
2742         the given pkg-config file and options and call rebase_installed_docs.
2743         * gtk/gtkdoc.py:
2744         (GTKDoc.__init__): Initialize cross_reference_deps.
2745         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
2746         dependencies.
2747         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
2748         links of installed documentation.
2749         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
2750         file.
2751
2752 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
2753
2754         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
2755         https://bugs.webkit.org/show_bug.cgi?id=77672
2756
2757         Reviewed by Dirk Pranke.
2758
2759         Test repetitions must be taken into account when working out
2760         the statistics shown by run-webkit-tests.
2761
2762         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2763         (Manager.prepare_lists_and_print_output):
2764         (Manager._print_result_summary):
2765         * Scripts/webkitpy/layout_tests/models/result_summary.py:
2766         (ResultSummary.__init__):
2767         (ResultSummary.add):
2768         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2769         (MainTest.test_repeat_each_iterations_num_tests):
2770
2771 2012-02-05  Dan Bernstein  <mitz@apple.com>
2772
2773         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
2774         https://bugs.webkit.org/show_bug.cgi?id=77823
2775
2776         Reviewed by Anders Carlsson.
2777
2778         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2779         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
2780
2781 2012-02-04  Dan Bernstein  <mitz@apple.com>
2782
2783         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
2784         https://bugs.webkit.org/show_bug.cgi?id=77822
2785
2786         Reviewed by Sam Weinig.
2787
2788         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2789         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
2790
2791 2012-02-04  Sam Weinig  <sam@webkit.org>
2792
2793         Add ability to send WKURLRequests in WebKit2 API user messages
2794         https://bugs.webkit.org/show_bug.cgi?id=77819
2795
2796         Reviewed by Anders Carlsson.
2797
2798         Add testing for round-tripping WKTypes from the UIProcess,
2799         to the WebProcess, and back.
2800
2801         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
2802           More can easily be added.
2803
2804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2805         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
2806         (TestWebKitAPI):
2807         (WebKit2UserMessageRoundTripTest):
2808         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
2809         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
2810         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
2811         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
2812         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
2813         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
2814         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
2815         (TestWebKitAPI::TEST_F):
2816         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
2817         (TestWebKitAPI):
2818         (UserMessageTest):
2819         (TestWebKitAPI::UserMessageTest::UserMessageTest):
2820         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
2821         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2822         (TestWebKitAPI::PlatformWebView::resizeTo):
2823         (TestWebKitAPI):
2824         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2825         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2826
2827 2012-02-04  Dan Bernstein  <mitz@apple.com>
2828
2829         <rdar://problem/10772406> WKPreferences instances cannot be copied
2830         https://bugs.webkit.org/show_bug.cgi?id=77816
2831
2832         Reviewed by Sam Weinig.
2833
2834         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2835         (TestWebKitAPI::TEST):
2836
2837 2012-02-04  Adam Barth  <abarth@webkit.org>
2838
2839         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
2840         https://bugs.webkit.org/show_bug.cgi?id=77802
2841
2842         Reviewed by Eric Seidel.
2843
2844         This patch refactors our directory grouping code into base.js where it
2845         can be shared between failures.js and notifications.js.  It then adds
2846         an Examine action to each group of failures that triggers the "results"
2847         view.
2848
2849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2853         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2854         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
2855
2856 2012-02-04  Ojan Vafai  <ojan@chromium.org>
2857
2858         check-webkit-style is throwing an exception
2859         https://bugs.webkit.org/show_bug.cgi?id=77744
2860
2861         Reviewed by David Levin.
2862
2863         If the test_list is None, then we don't need to check for unsupported
2864         feature tests to skip.
2865
2866         * Scripts/webkitpy/layout_tests/port/webkit.py:
2867         (WebKitPort._has_test_in_directories):
2868         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2869         (test_skipped_tests_for_unsupported_features_empty_test_list):
2870
2871 2012-02-03  Adam Barth  <abarth@webkit.org>
2872
2873         List of all failures in garden-o-matic should actually list all the failures
2874         https://bugs.webkit.org/show_bug.cgi?id=77796
2875
2876         Reviewed by Eric Seidel.
2877
2878         This patch wires a bit more data into the new "All Failures" tab.  I've
2879         also iterated on how we enable this experimental feature.  The tab is
2880         still just a dumb list, but we'll make it smarter.
2881
2882         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2883         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2884         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2885         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2886
2887 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2888
2889         Windows build fix after r106692.
2890
2891         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2892         (PortTest.test_reference_files):
2893
2894 2012-02-03  Beth Dakin  <bdakin@apple.com>
2895
2896         https://bugs.webkit.org/show_bug.cgi?id=77782
2897         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than 
2898         once on some pages with frames
2899         -and corresponding-
2900         <rdar://problem/10798474>
2901
2902         Reviewed by Sam Weinig.
2903
2904         One new test.
2905         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2906         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
2907         (TestWebKitAPI):
2908         (TestWebKitAPI::didForceRepaint):
2909         (TestWebKitAPI::didFinishLoadForFrame):
2910         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2911         (TestWebKitAPI::setPageLoaderClient):
2912         (TestWebKitAPI::TEST):
2913         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
2914         (TestWebKitAPI):
2915         (NewFirstVisuallyNonEmptyLayoutFramesTest):
2916         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
2917         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
2918         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
2919
2920 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
2921
2922         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
2923         https://bugs.webkit.org/show_bug.cgi?id=77781
2924
2925         Reviewed by Eric Seidel.
2926
2927         This change fixes a couple of issues discovered while debugging
2928         test-webkitpy; both calling exit() instead of sys.exit() --
2929         which is discouraged in program code instead of the interpreter
2930         -- and a particular usage of outputcapture were stdin to get whacked
2931         and preventing debugging.
2932        
2933         This change introduces a couple of common _exit() methods that
2934         will standardize how webkit-patch exit's, in case we need to do
2935         something different in the future.
2936
2937         * Scripts/webkitpy/common/system/deprecated_logging.py:
2938         (error):
2939         * Scripts/webkitpy/common/system/outputcapture.py:
2940         (OutputCapture.assert_outputs):
2941         * Scripts/webkitpy/tool/bot/queueengine.py:
2942         (QueueEngine.exit_after_handled_error):
2943         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2944         (AbstractSequencedCommand.execute):
2945         * Scripts/webkitpy/tool/commands/queues.py:
2946         (StyleQueue.handle_script_error):
2947         * Scripts/webkitpy/tool/commands/upload.py:
2948         (MarkBugFixed.execute):
2949         * Scripts/webkitpy/tool/multicommandtool.py:
2950         (Command._exit):
2951         * Scripts/webkitpy/tool/steps/abstractstep.py:
2952         (AbstractStep._exit):
2953         * Scripts/webkitpy/tool/steps/checkstyle.py:
2954         (CheckStyle.run):
2955         * Scripts/webkitpy/tool/steps/commit.py:
2956         (Commit._check_test_expectations):
2957         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2958         (ConfirmDiff.run):
2959
2960 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2961
2962         Perf bot build fix.
2963
2964         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2965         (PerfTestsRunner._generate_json):
2966
2967 2012-02-03  Adam Barth  <abarth@webkit.org>
2968
2969         Add a blank "Expected Failures" tab to garden-o-matic
2970         https://bugs.webkit.org/show_bug.cgi?id=77793
2971
2972         Reviewed by Eric Seidel.
2973
2974         This tab will help us explore and manage our expected failures.  The
2975         tab is hidden by default via a new "experimental features" flag.
2976
2977         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2978         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2980         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2982         (#unexpected):
2983         (#onebar.partytime #unexpected):
2984
2985 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2986
2987         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
2988         https://bugs.webkit.org/show_bug.cgi?id=77785
2989
2990         Fix the build bots.
2991         
2992         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
2993
2994         * Scripts/update-webkit-support-libs:
2995         (downloadExpectedVersionNumber):
2996
2997 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2998
2999         Add a Mac Lion Performance bot.
3000         https://bugs.webkit.org/show_bug.cgi?id=77765
3001
3002         Reviewed by Adam Roben.
3003
3004         This will update the master configuration in the following ways:
3005             Add a new performance slave (apple-xseve-11)
3006             Add a new Factory to download a build and run perf tests.
3007             
3008         * BuildSlaveSupport/build.webkit.org-config/config.json:
3009         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3010         (DownloadAndPerfTestFactory):
3011         (DownloadAndPerfTestFactory.__init__):
3012
3013 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
3014
3015         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
3016         https://bugs.webkit.org/show_bug.cgi?id=77752
3017
3018         Reviewed by James Robinson.
3019
3020         Delete unneeded file accidentally checked in in r106481.
3021
3022         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
3023
3024 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3025
3026         Ref Tests should support plain SVG files
3027         https://bugs.webkit.org/show_bug.cgi?id=77685
3028
3029         Reviewed by Tony Chang.
3030
3031         Don't assume reference files always use .html as the extension.
3032         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
3033
3034         Also fix various bugs in MockFileSystem and TestPort.
3035
3036         * Scripts/webkitpy/common/system/filesystem_mock.py:
3037         (MockFileSystem.isdir):
3038         * Scripts/webkitpy/layout_tests/port/base.py:
3039         (Port.reference_files):
3040         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3041         (PortTest.test_is_test_file):
3042         (PortTest.test_reference_files):
3043         * Scripts/webkitpy/layout_tests/port/test.py:
3044         (TestInstance.__init__):
3045
3046 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3047
3048         perf-o-matic should store chromium svn revision
3049         https://bugs.webkit.org/show_bug.cgi?id=77725
3050
3051         Reviewed by Dirk Pranke.
3052
3053         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
3054         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
3055         is implemented in terms of newly added svn_revision.
3056
3057         * Scripts/webkitpy/common/checkout/scm/git.py:
3058         (Git.svn_revision):
3059         * Scripts/webkitpy/common/checkout/scm/scm.py:
3060         (SCM.head_svn_revision):
3061         (SCM):
3062         (SCM.svn_revision):
3063         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3064         (MockSCM.svn_revision):
3065         * Scripts/webkitpy/common/checkout/scm/svn.py:
3066         (SVN.svn_revision):
3067         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3068         (JSONLayoutResultsGenerator.__init__):
3069         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3070         (JSONResultsGeneratorBase._insert_generic_metadata):
3071         * Scripts/webkitpy/layout_tests/port/base.py:
3072         (Port.repository_paths):
3073         * Scripts/webkitpy/layout_tests/port/chromium.py:
3074         (ChromiumPort.repository_paths):
3075         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3076         (PerfTestsRunner._generate_json):
3077         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3078         (test_run_test_set_with_json_output):
3079         (test_run_test_set_with_json_source):
3080         (test_run_test_set_with_multiple_repositories):
3081
3082 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3083
3084         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
3085         https://bugs.webkit.org/show_bug.cgi?id=77632
3086
3087         Reviewed by Kenneth Rohde Christiansen.
3088
3089         * MiniBrowser/qt/BrowserWindow.cpp:
3090         (BrowserWindow::BrowserWindow):
3091         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3092         (MiniBrowserApplication::sendTouchEvent):
3093         (MiniBrowserApplication::handleUserOptions):
3094         * MiniBrowser/qt/MiniBrowserApplication.h:
3095         (WindowOptions):
3096         (WindowOptions::WindowOptions):
3097         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3098         (WTR::PlatformWebView::PlatformWebView):
3099         * WebKitTestRunner/qt/main.cpp:
3100         (main):
3101         * qmake/mkspecs/features/default_post.prf:
3102
3103 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
3104
3105         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
3106         https://bugs.webkit.org/show_bug.cgi?id=77723
3107
3108         Reviewed by Tor Arne Vestbø.
3109
3110         * Tools.pro: Compile WTR again on all platforms with WK2.
3111
3112 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
3113
3114         Ensure that inspector disabled build works
3115         https://bugs.webkit.org/show_bug.cgi?id=77604
3116
3117         Reviewed by Tor Arne Vestbø.
3118
3119         * qmake/mkspecs/features/features.prf:
3120
3121 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
3122
3123         [chromium] add support for --makeargs to the ninja-based build
3124         https://bugs.webkit.org/show_bug.cgi?id=77688
3125
3126         Reviewed by Adam Barth.
3127
3128         * Scripts/webkitdirs.pm:
3129         (buildChromiumNinja):
3130
3131 2012-02-02  Eric Seidel  <eric@webkit.org>
3132
3133         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
3134         https://bugs.webkit.org/show_bug.cgi?id=75145
3135
3136         Reviewed by Dirk Pranke.
3137
3138         * Scripts/webkitpy/layout_tests/port/mac.py:
3139         (MacPort.default_child_processes):
3140         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3141         (test_operating_system):
3142         (test_default_child_processes):
3143
3144 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
3145
3146        nrwt shouldn't blow up when there are errors in test_expectations.txt
3147        https://bugs.webkit.org/show_bug.cgi?id=73603
3148
3149        Reviewed by Ojan Vafai.
3150
3151        This change removes the distinction between 'errors' and 'warnings'
3152        in the test expectations parser. Now, any problem is a
3153        'warning', and if we are linting the file, warnings become fatal (errors).
3154
3155         This will allow a normal run-webkit-tests run to proceed even if
3156         there are bad lines.
3157
3158         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3159         (ParseError.__init__):
3160         (ParseError.__str__):
3161         (ParseError.__repr__):
3162         (TestExpectationSerializer.to_string):
3163         (TestExpectationParser._parse_modifiers):
3164         (TestExpectationParser._parse_expectations):
3165         (TestExpectationParser._check_modifiers_against_expectations):
3166         (TestExpectationParser._tokenize):
3167         (TestExpectationLine.__init__):
3168         (TestExpectationLine.is_invalid):
3169         (TestExpectationsModel.add_expectation_line):
3170         (TestExpectationsModel._already_seen_better_match):
3171         (TestExpectations.__init__):
3172         (TestExpectations._report_warnings):
3173         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
3174         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3175         (assert_bad_expectations):
3176         (test_parse_warning):
3177         (test_overrides__duplicate):
3178         (ExpectationSyntaxTests.test_missing_expectation):
3179         (ExpectationSyntaxTests.test_missing_colon):
3180         (ExpectationSyntaxTests.test_too_many_colons):
3181         (ExpectationSyntaxTests.test_too_many_equals_signs):
3182         (ExpectationSyntaxTests.test_unrecognized_expectation):
3183         (SemanticTests.test_bug_format):
3184         (SemanticTests.test_bad_bugid):
3185         (SemanticTests.test_slow_and_timeout):
3186         (test_ambiguous):
3187         (test_more_modifiers):
3188         (test_order_in_file):
3189         (test_macro_overrides):
3190         (RebaseliningTest.assertRemove):
3191         (TestExpectationParserTests.test_tokenize_blank):
3192         (TestExpectationParserTests.test_tokenize_missing_colon):
3193         (TestExpectationParserTests.test_tokenize_extra_colon):
3194         (TestExpectationParserTests.test_tokenize_empty_comment):
3195         (TestExpectationParserTests.test_tokenize_comment):
3196         (TestExpectationParserTests.test_tokenize_missing_equal):
3197         (TestExpectationParserTests.test_tokenize_extra_equal):
3198         (TestExpectationParserTests.test_tokenize_valid):
3199         (TestExpectationParserTests.test_tokenize_valid_with_comment):
3200         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
3201         (TestExpectationSerializerTests.test_unparsed_to_string):
3202         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3203         (lint):
3204         * Scripts/webkitpy/style/checkers/test_expectations.py:
3205         (TestExpectationsChecker.check_test_expectations):
3206
3207 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3208
3209         Unreviewed, rolling out r106543.
3210         http://trac.webkit.org/changeset/106543
3211         https://bugs.webkit.org/show_bug.cgi?id=77671
3212
3213         Made tests less stable (Requested by rniwa on #webkit).
3214
3215         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3216         (PerfTestsRunner):
3217         (PerfTestsRunner.__init__):
3218         (PerfTestsRunner._run_tests_set):
3219         (PerfTestsRunner._run_single_test):
3220         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3221         (MainTest.TestDriver.run_test):
3222         (run_test):
3223
3224 2012-02-02  Beth Dakin  <bdakin@apple.com>
3225
3226         https://bugs.webkit.org/show_bug.cgi?id=77664
3227         Add API tests for didNewFirstVisuallyNonEmptyLayout
3228
3229         Reviewed by Darin Adler.
3230
3231         Two new tests.
3232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3233         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
3234         (TestWebKitAPI):
3235         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3236         (TestWebKitAPI::setPageLoaderClient):
3237         (TestWebKitAPI::TEST):
3238         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
3239         (TestWebKitAPI):
3240         (TestWebKitAPI::didForceRepaint):
3241         (TestWebKitAPI::didFinishLoadForFrame):
3242         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3243         (TestWebKitAPI::setPageLoaderClient):
3244         (TestWebKitAPI::TEST):
3245         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
3246         (TestWebKitAPI):
3247         (NewFirstVisuallyNonEmptyLayoutFailsTest):
3248         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
3249         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
3250         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
3251         (TestWebKitAPI):
3252         (NewFirstVisuallyNonEmptyLayoutTest):
3253         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
3254         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
3255
3256 2012-02-02  Michael Saboff  <msaboff@apple.com>
3257
3258         Add Michael Saboff to reviewers list.
3259
3260         Rubber-stamped by Gavin Barraclough.
3261
3262         * Scripts/webkitpy/common/config/committers.py:
3263
3264 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3265
3266         Add myself as a committer
3267
3268         Unreviewed
3269
3270         * Scripts/webkitpy/common/config/committers.py:
3271
3272 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
3273
3274         [PerformanceTests] tests have dependencies
3275         https://bugs.webkit.org/show_bug.cgi?id=77506
3276
3277         Reviewed by Hajime Morita.
3278
3279         Load an initialization page before each test after starting a DRT so that
3280         warming up DRT won't affect the performance test results.
3281
3282         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3283         (PerfTestsRunner):
3284         (PerfTestsRunner.__init__):
3285         (PerfTestsRunner._run_tests_set):
3286         (PerfTestsRunner._run_single_test):
3287         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3288         (MainTest.TestDriver.run_test):
3289         (test_initial_page_loaded):
3290         (test_initial_page_loaded.run_test):
3291
3292 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
3293
3294         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
3295
3296         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3297         (PerfTestsRunner._run_tests_set):
3298         (PerfTestsRunner._run_single_test):
3299         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3300         (create_runner):
3301         (test_run_passing_test):
3302         (test_run_silent_test):
3303         (test_run_failed_test):
3304         (test_run_tonguey_test):
3305         (test_run_timeout_test):
3306         (test_run_crash_test):
3307         (test_run_test_set_kills_drt_per_run):
3308         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
3309         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
3310         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
3311
3312 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
3313
3314         Webkit generate-coverage-data script needs update to use new test script
3315         https://bugs.webkit.org/show_bug.cgi?id=77597
3316
3317         Reviewed by Dirk Schulze.
3318
3319         * Scripts/generate-coverage-data:
3320
3321 2012-02-01  Adam Barth  <abarth@webkit.org>
3322
3323         Update the tests to show that the mac-ews processes patches from
3324         non-committers.
3325
3326         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3327         (EarlyWarningSytemTest.test_committer_only_ewses):
3328         (EarlyWarningSytemTest.test_builder_ewses):
3329
3330 2012-02-01  Adam Barth  <abarth@webkit.org>
3331
3332         Mac-ews logs are huge
3333         https://bugs.webkit.org/show_bug.cgi?id=77045
3334
3335         Reviewed by Eric Seidel.
3336
3337         In order to get the cr-linux-ews bot to run tests on EC2, we created
3338         the chromium-xvfb port, which contained a number of tweaks to the
3339         Chromium port's behavior.  This patch refactors those tweaks so they
3340         can be shared with the mac-ews, mostly by moving them into the
3341         non-interactive mode of RunTests.
3342
3343         * Scripts/webkitpy/common/config/ports.py:
3344         (WebKitPort):
3345         (WebKitPort.layout_tests_results_path):
3346         (ChromiumPort.run_javascriptcore_tests_command):
3347         (ChromiumXVFBPort):
3348         (ChromiumXVFBPort.run_webkit_tests_command):
3349         * Scripts/webkitpy/common/config/ports_mock.py:
3350         (MockPort):
3351         (MockPort.layout_tests_results_path):
3352         * Scripts/webkitpy/common/config/ports_unittest.py:
3353         (WebKitPortTest.test_chromium_xvfb_port):
3354         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3355         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
3356         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3357         (CommitQueueTest.test_commit_queue):
3358         (test_rollout):
3359         (test_manual_reject_during_processing):
3360         * Scripts/webkitpy/tool/steps/runtests.py:
3361         (RunTests.run):
3362         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3363         (RunTestsTest.test_no_unit_tests):
3364         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3365         (StepsTest.test_runtests_args):
3366
3367 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
3368
3369         Roll out r106442. It made some tests more stable but others less stable.
3370
3371         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3372         (PerfTestsRunner._run_tests_set):
3373         (PerfTestsRunner._run_single_test):
3374         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3375         (create_runner):
3376         (test_run_passing_test):
3377         (test_run_silent_test):
3378         (test_run_failed_test):
3379         (test_run_tonguey_test):
3380         (test_run_timeout_test):
3381         (test_run_crash_test):
3382         (test_run_test_set):
3383
3384 2012-02-01  Lucas Forschler  <lforschler@apple.com>
3385
3386         Enable EWS for non-contributers.
3387         https://bugs.webkit.org/show_bug.cgi?id=77576
3388         
3389         Reviewed by Adam Barth.
3390
3391         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3392         (MacEWS):
3393
3394 2012-02-01  Beth Dakin  <bdakin@apple.com>
3395
3396         https://bugs.webkit.org/show_bug.cgi?id=77383
3397         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
3398         -and corresponding-
3399         <rdar://problem/10709560>
3400
3401         Reviewed by Sam Weinig.
3402
3403         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
3404         for.
3405         * MiniBrowser/mac/BrowserWindowController.m:
3406         (-[BrowserWindowController awakeFromNib]):
3407         * WebKitTestRunner/TestController.cpp:
3408         (WTR::TestController::initialize):
3409
3410 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
3411
3412         TestWebKitAPI isn't being built on chromium bots any more
3413         https://bugs.webkit.org/show_bug.cgi?id=77563
3414
3415         Reviewed by Dimitri Glazkov.
3416
3417         I accidentally dropped it in the refactoring in r105449.
3418
3419         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
3420
3421 2012-02-01  Hans Wennborg  <hans@chromium.org>
3422
3423         Rename WebSpeechInputResult::set() to assign()
3424         https://bugs.webkit.org/show_bug.cgi?id=77540
3425
3426         Reviewed by Darin Fisher.
3427
3428         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3429         (MockWebSpeechInputController::addMockRecognitionResult):
3430         (MockWebSpeechInputController::speechTaskFired):
3431
3432 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3433
3434         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
3435         https://bugs.webkit.org/show_bug.cgi?id=77542
3436
3437         Reviewed by Martin Robinson.
3438
3439         * gtk/generate-gtkdoc: Check first whether there's
3440         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
3441         instead.
3442         (get_webkit2_options): Return just the options since the
3443         pkg_config_path doesn't depend on options
3444         (get_webkit1_options): Ditto.
3445         (generate_doc): Helper function to create a generator and generate
3446         documentation for the given pkg-config file with the given options.
3447         * gtk/gtkdoc.py:
3448         (GTKDoc.__init__): Don't use ** for args parameter, since it's
3449         used as a dict and never expanded.
3450         (PkgConfigGTKDoc.__init__): Ditto.
3451
3452 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3453
3454         [GTK] API documentation is not installed even when building with --enable-gtk-doc
3455         https://bugs.webkit.org/show_bug.cgi?id=77094
3456
3457         Reviewed by Martin Robinson.
3458
3459         * GNUmakefile.am: Add install-data-local and uninstall-local rules
3460         to install/uninstall WebKit1 and WebKit2 API documentation.
3461
3462 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3463
3464         Unreviewed, rolling out r106460.
3465         http://trac.webkit.org/changeset/106460
3466         https://bugs.webkit.org/show_bug.cgi?id=77552
3467
3468         It break unit tests if WEBKIT_TESTFONTS isn't defined.
3469         (Requested by Ossy on #webkit).
3470
3471         * Scripts/webkitpy/layout_tests/port/qt.py:
3472
3473 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
3474
3475         [Qt] Automatic clean build feature always do clean build with --no-webkit2
3476         https://bugs.webkit.org/show_bug.cgi?id=74519
3477
3478         Reviewed by Tor Arne Vestbø.
3479
3480         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
3481
3482         * qmake/mkspecs/features/features.prf:
3483
3484 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3485
3486         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
3487         https://bugs.webkit.org/show_bug.cgi?id=77466
3488
3489         Reviewed by Kenneth Rohde Christiansen.
3490
3491         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
3492         is set or if we should raise an error.
3493
3494         * Scripts/webkitpy/layout_tests/port/qt.py:
3495         (QtPort.setup_environ_for_server):
3496
3497 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
3498
3499         Reviewed by Martin Robinson.
3500
3501         [GTK] Improve FrameLoader signals. Resource loading
3502         https://bugs.webkit.org/show_bug.cgi?id=49543
3503
3504         Support for the new loader signals in DRT.
3505
3506         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3507         (urlPath):
3508         (willSendRequestCallback):
3509         (urlSuitableForTestResult):
3510         (descriptionSuitableForTestResult):
3511         (didReceiveResponse):
3512         (didFinishLoading):
3513         (didFailLoadingWithError):
3514         (createWebView):
3515
3516 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
3517
3518         run-perf-tests should restart DRT for each test
3519         https://bugs.webkit.org/show_bug.cgi?id=77506
3520
3521         Reviewed by Adam Barth.
3522
3523         Always restart DRT when running performance tests in order to minimize the dependency between tests.
3524
3525         * Scripts/webkitpy/layout_tests/port/chromium.py:
3526         (ChromiumDriver.stop):
3527         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3528         (PerfTestsRunner._run_tests_set):
3529         (PerfTestsRunner._run_single_test):
3530         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3531         (create_runner):
3532         (test_run_passing_test):
3533         (test_run_silent_test):
3534         (test_run_failed_test):
3535         (test_run_tonguey_test):
3536         (test_run_timeout_test):
3537         (test_run_crash_test):
3538         (test_run_test_set_kills_drt_per_run):
3539         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
3540         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
3541         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
3542
3543 2012-01-31  Hans Wennborg  <hans@chromium.org>
3544
3545         Speech Input: Report speech element rect relative to window rather than frame
3546         https://bugs.webkit.org/show_bug.cgi?id=76443
3547
3548         Reviewed by Darin Fisher.
3549
3550         Update LayoutTestController to allow for retrieving the speech
3551         element's position used in a request.
3552
3553         In Chromium this is handled by the MockWebSpeechInputController;
3554         adding stubs for the other implementations.
3555
3556         * DumpRenderTree/LayoutTestController.cpp:
3557         (setMockSpeechInputDumpRectCallback):
3558         (LayoutTestController::staticFunctions):
3559         * DumpRenderTree/LayoutTestController.h:
3560         (LayoutTestController):
3561         * DumpRenderTree/chromium/LayoutTestController.cpp:
3562         (LayoutTestController::LayoutTestController):
3563         (LayoutTestController::setMockSpeechInputDumpRect):
3564         * DumpRenderTree/chromium/LayoutTestController.h:
3565         (LayoutTestController):
3566         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3567         (MockWebSpeechInputController::setDumpRect):
3568         (MockWebSpeechInputController::clearResults):
3569         (MockWebSpeechInputController::startRecognition):
3570         (MockWebSpeechInputController::MockWebSpeechInputController):
3571         (makeRectResult):
3572         (MockWebSpeechInputController::speechTaskFired):
3573         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
3574         (MockWebSpeechInputController):
3575         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3576         (LayoutTestController::setMockSpeechInputDumpRect):
3577         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3578         (LayoutTestController::setMockSpeechInputDumpRect):
3579         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3580         (LayoutTestController::setMockSpeechInputDumpRect):
3581         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3582         (LayoutTestController::setMockSpeechInputDumpRect):
3583         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3584         (LayoutTestController):
3585         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3586         (LayoutTestController::setMockSpeechInputDumpRect):
3587         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3588         (LayoutTestController::setMockSpeechInputDumpRect):
3589
3590 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
3591
3592         [EFL] Add basic DRT/Efl implementation to support viewport test.
3593         https://bugs.webkit.org/show_bug.cgi?id=77320
3594
3595         Reviewed by Andreas Kling.
3596
3597         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3598         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
3599
3600 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
3601
3602         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
3603         https://bugs.webkit.org/show_bug.cgi?id=77473
3604         <rdar://problem/10751357>
3605
3606         Reviewed by Darin Adler.
3607
3608         * DumpRenderTree/mac/EventSendingController.mm:
3609         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3610         * WebKitTestRunner/mac/EventSenderProxy.mm:
3611         (WTR::EventSenderProxy::keyDown):
3612         Added a new special keyDown value to test this.
3613
3614 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
3615
3616         nrwt: fix the mock port to work with DriverProxy, reftests
3617         https://bugs.webkit.org/show_bug.cgi?id=77170
3618
3619         Reviewed by Eric Seidel.
3620
3621         The DryrunPort used for benchmarking and testing NRWT has been
3622         broken since we added the DriverProxy code. It isn't really
3623         needed any more, so I've removed it.
3624
3625         The MockDRT port was also broken by DriverProxy, and moreover,
3626         never worked w/ reftests. Since we don't exercise this module in
3627         the unit tests, the code had also bitrotted some. I have cleaned
3628         it up and made it use DriverInput and DriverOutput for
3629         consistency.
3630
3631         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3632         (DryRunPort.__init__):
3633         (DryRunPort):
3634         (DryRunPort.real_name):
3635         (DryRunPort.create_driver):
3636         (DryRunPort.driver_cmd_line):
3637         (DryRunPort._driver_class):
3638         (DryrunDriver):
3639         (DryrunDriver.run_test):
3640         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3641         (MockDRTPort.create_driver):
3642         (MockChromiumDRT.run_one_test):
3643
3644 2012-01-31  Ojan Vafai  <ojan@chromium.org>
3645
3646         run-webkit-tests calls out to webkit-build-directory twice
3647         https://bugs.webkit.org/show_bug.cgi?id=77248
3648
3649         Reviewed by Dirk Pranke.
3650
3651         * Scripts/webkit-build-directory:
3652         If called with no arguments, print out both the top-level directory and the 
3653         configuration directory
3654
3655         * Scripts/webkitpy/layout_tests/port/config.py:
3656         (Config.build_directory):
3657         When called with no arguments, get and cache both the top-level and configuration directories.
3658
3659         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3660         (main):
3661         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3662         (ConfigTest.assert_configuration):
3663         (ConfigTest.test_build_directory.mock_webkit_build_directory):
3664         (ConfigTest.test_build_directory):
3665         (ConfigTest.test_default_configuration__notfound):
3666         * Scripts/webkitpy/layout_tests/port/webkit.py:
3667         (WebKitPort._build_path):
3668         Cache the build directory in the options object so that other users
3669         of the options object don't need to call out to webkit-build-directory.
3670         Also, properly support the existing --build-directory argument.
3671
3672 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
3673
3674         Bump up the timeout for performance tests since DOM/DOMTable.html
3675         and Parser/html5-full-render.html are timing out on the bot.
3676
3677         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3678         (PerfTestsRunner._parse_args):
3679
3680 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
3681
3682         Fix the update_webgl_conformance_tests.py script in order to enable it
3683         to detect the SCM being used correctly.
3684         https://bugs.webkit.org/show_bug.cgi?id=77462
3685
3686         Reviewed by Kenneth Russell.
3687
3688         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3689         (default_out_dir):
3690
3691 2012-01-31  Eric Seidel  <eric@webkit.org>
3692
3693         webkit-patch apply-from-bug should work regardless of your CWD
3694         https://bugs.webkit.org/show_bug.cgi?id=77482
3695
3696         Reviewed by Adam Barth.
3697
3698         webkit-patch only ever works with patches made from the root
3699         directory.  We should pass the CWD to svn-apply in the case
3700         where we're running not from the webkit root.  I believe
3701         this used to work in the past and regressed.
3702
3703         * Scripts/webkitpy/common/checkout/checkout.py:
3704         (Checkout.apply_patch):
3705         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3706         (CheckoutTest.test_apply_patch):
3707