Flakiness dashboard assumes there must be ToT tests
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-17  Julie Parent  <jparent@chromium.org>
2
3         Flakiness dashboard assumes there must be ToT tests
4         https://bugs.webkit.org/show_bug.cgi?id=107155
5
6         Remove group as a default parameter, since we can't actually know
7         the name of a group initially.  Instead, introduces 
8         currentBuilderGroupName which returns the current builder group
9         if it has been explicitly set, or picks the first one available
10         as a default. Allows us to remove some extra code tracking this
11         stuff as well.
12         
13         Reviewed by Ojan Vafai.
14
15         * TestResultServer/static-dashboards/dashboard_base.js:
16         (parseCrossDashboardParameters):
17         (currentBuilderGroupName):
18         (currentBuilderGroup):
19         * TestResultServer/static-dashboards/flakiness_dashboard.js:
20         (platformAndBuildType):
21         * TestResultServer/static-dashboards/loader.js:
22         (.):
23
24 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
25
26         Remove NodeListsNodeData when it's no longer needed
27         https://bugs.webkit.org/show_bug.cgi?id=107074
28
29         Reviewed by Darin Adler.
30
31         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
32
33         * Scripts/webkitpy/performance_tests/perftest.py:
34         (PerfTest):
35
36 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
37
38         Ref test images are upside-down in WebKit2
39         https://bugs.webkit.org/show_bug.cgi?id=105457
40
41         Reviewed by Sam "Speedy" Weinig.
42         
43         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
44         from the window snapshot contained a flipped copy of the image, causing all ref
45         and pixel images to be upside-down.
46
47         * WebKitTestRunner/cg/TestInvocationCG.cpp:
48         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
49
50 2013-01-17  Timothy Loh  <timloh@google.com>
51
52         Replaced specifiers variable with is_debug in builders.py
53         https://bugs.webkit.org/show_bug.cgi?id=107057
54
55         Reviewed by Dirk Pranke.
56
57         Replaced specifiers variable with is_debug in builders.py to simplify
58         Bug 106259. The other specifiers are not used elsewhere in the code.
59         Fixed builder_name_for_port_name to return a debug builder if we don't
60         have a release builder.
61
62         * Scripts/webkitpy/layout_tests/port/builders.py:
63         (all_port_names):
64         (builder_name_for_port_name):
65         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
66         (TestRebaselineExpectations.test_rebaseline_expectations):
67
68 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
69
70         [GTK] Build with LevelDB when IndexedDB is enabled
71         https://bugs.webkit.org/show_bug.cgi?id=103220
72
73         Reviewed by Gustavo Noronha Silva.
74
75         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
76         as it does not conform to WebKit style.
77
78 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
79
80         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
81         https://bugs.webkit.org/show_bug.cgi?id=107119
82
83         Reviewed by Laszlo Gombos.
84
85         Do not use ASSERT on ecore_evas_init(), since the expression inside
86         the macro compiles out of release builds.
87
88         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
89         * TestWebKitAPI/efl/PlatformWebView.cpp:
90         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
91
92 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
93
94         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
95         https://bugs.webkit.org/show_bug.cgi?id=104545
96
97         Reviewed by Yury Semikhatsky.
98
99         Adopt signature changes.
100
101         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
102         (ProfilerAgent.getCPUProfile): Renamed.
103         (ProfilerAgent.getHeapSnapshot): Added.
104
105 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
106
107         [GTK][EFL] NWRT should check that Xvfb is installed
108         https://bugs.webkit.org/show_bug.cgi?id=71767
109
110         Reviewed by Dirk Pranke.
111
112         EFL and GTK ports now check that Xvfb is installed before running
113         layout tests. The command line used to check whether Xvfb is present
114         is a simple `which Xvfb` that should return 0 as the exit code upon
115         success.
116
117         * Scripts/webkitpy/layout_tests/port/efl.py:
118         (EflPort.show_results_html_file):
119         (EflPort):
120         (EflPort.check_sys_deps):
121         * Scripts/webkitpy/layout_tests/port/gtk.py:
122         (GtkPort.check_sys_deps):
123         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
124         (XvfbDriver):
125         (XvfbDriver.check_xvfb):
126
127 2013-01-16  Alan Cutter  <alancutter@chromium.org>
128
129         sheriffbot can't tell me who "kov" is
130         https://bugs.webkit.org/show_bug.cgi?id=106184
131
132         Reviewed by Eric Seidel.
133
134         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
135
136         * Scripts/webkitpy/common/config/committers.py:
137         (Account.matches_glob):
138         (CommitterList.contributors_by_search_string):
139         * Scripts/webkitpy/common/config/committers_unittest.py:
140         (CommittersTest.test_committer_lookup):
141         * Scripts/webkitpy/tool/bot/irc_command.py:
142         (Whois):
143
144 2013-01-16  David Kilzer  <ddkilzer@apple.com>
145
146         Use xcrun to find path to make for Mac port
147         <http://webkit.org/b/107091>
148
149         Reviewed by Dan Bernstein.
150
151         * Scripts/webkitpy/layout_tests/port/mac.py:
152         (MacPort._build_java_test_support): Call self.make_command().
153         (MacPort.make_command): Add.  Call xcrun_find().
154         (MacPort.nm_command): Use self.xcrun_find().
155         (MacPort.xcrun_find): Add.  Extract from nm_command().
156
157 2013-01-16  Sam Weinig  <sam@webkit.org>
158
159         Make debug-safari --target-web-process work again
160         https://bugs.webkit.org/show_bug.cgi?id=107088
161
162         Reviewed by Anders Carlsson.
163
164         * Scripts/webkitdirs.pm:
165         (execMacWebKitAppForDebugging):
166         The shim is now called SecItemShim.
167
168 2013-01-16  Alan Cutter  <alancutter@chromium.org>
169
170         GCE build scripts don't take working directory into account when calling findzone.sh
171         https://bugs.webkit.org/show_bug.cgi?id=106962
172
173         Reviewed by Adam Barth.
174
175         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
176         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
177         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
178
179 2013-01-16  Alan Cutter  <alancutter@chromium.org>
180
181         start-queue.sh does not pass remaining parameters correctly
182         https://bugs.webkit.org/show_bug.cgi?id=107054
183
184         Reviewed by Adam Barth.
185
186         start-queue.sh now passes all remaining params to the webkit-patch command.
187         Previously only one additional queue parameter could be sent.
188
189         * EWSTools/start-queue.sh:
190
191 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
192
193         check-webkit-style script cannot running in Chinese windows.
194         https://bugs.webkit.org/show_bug.cgi?id=87548
195
196         Reviewed by Darin Adler.
197
198         * Scripts/webkitpy/common/system/platforminfo.py:
199         (PlatformInfo._win_version_tuple_from_cmd):
200
201 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
202
203         Delete an extraneous print statement.
204         https://bugs.webkit.org/show_bug.cgi?id=106562
205
206         Delete the extraneous print statement introduced in r139841.
207
208         * Scripts/webkitpy/layout_tests/views/printing.py:
209         (Printer.print_found):
210
211 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
212
213         Please reinstate --pixel
214         https://bugs.webkit.org/show_bug.cgi?id=101995
215
216         Reviewed by Dirk Pranke.
217
218         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
219         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
220         Some developers are still used to these options that were available in the ORWT.
221
222         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
223         (parse_args):
224
225 2013-01-16  Eric Seidel  <eric@webkit.org>
226
227         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
228         https://bugs.webkit.org/show_bug.cgi?id=99512
229
230         Reviewed by Darin Adler.
231
232         * Scripts/run-sunspider:
233
234 2013-01-16  Eric Seidel  <eric@webkit.org>
235
236         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
237         https://bugs.webkit.org/show_bug.cgi?id=106036
238
239         Reviewed by Darin Adler.
240
241         * Scripts/webkitpy/webkitpy.pyproj: Removed.
242         * Scripts/webkitpy/webkitpy.sln: Removed.
243
244 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
245
246         [Chromium] Remove hardcoded chromium_*.jar in gyp files
247         https://bugs.webkit.org/show_bug.cgi?id=104049
248
249         Reviewed by Eric Seidel.
250
251         Targets with dependencies (direct/indirect) on a java target receive
252         the chromium_*.jar paths in the variable input_jars_paths. Targets
253         should use that rather than hardcoding where they think the jar will
254         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
255         than as --jars to generate_native_test.py.
256
257         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
258         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
259
260 2013-01-16  Dan Carney  <dcarney@google.com>
261
262         [chromium] move setMockDeviceOrientation to TestRunner library
263         https://bugs.webkit.org/show_bug.cgi?id=106895
264
265         Reviewed by Jochen Eisinger.
266
267         * DumpRenderTree/chromium/DRTTestRunner.cpp:
268         (DRTTestRunner::DRTTestRunner):
269         * DumpRenderTree/chromium/DRTTestRunner.h:
270         (DRTTestRunner):
271         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
272         (WebKit):
273         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
274         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
275         (WebTestRunner::TestRunner::TestRunner):
276         (WebTestRunner::TestRunner::setMockDeviceOrientation):
277         (WebTestRunner):
278         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
279         (TestRunner):
280         * DumpRenderTree/chromium/WebViewHost.cpp:
281         (WebViewHost::setDeviceOrientation):
282         * DumpRenderTree/chromium/WebViewHost.h:
283         (WebViewHost):
284
285 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
286
287         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
288         https://bugs.webkit.org/show_bug.cgi?id=106904
289
290         Reviewed by Adam Barth.
291
292         * DumpRenderTree/chromium/DRTTestRunner.cpp:
293         (DRTTestRunner::DRTTestRunner):
294         (DRTTestRunner::notifyDone):
295         (DRTTestRunner::reset):
296         * DumpRenderTree/chromium/DRTTestRunner.h:
297         (DRTTestRunner):
298         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
299         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
300         (WebTestRunner::WebTestDelegate::setFocus):
301         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
302         (WebTestRunner::WebTestDelegate::pathToLocalResource):
303         (WebTestRunner::WebTestDelegate::setLocale):
304         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
305         (WebTestRunner::TestRunner::TestRunner):
306         (WebTestRunner::TestRunner::reset):
307         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
308         (WebTestRunner):
309         (WebTestRunner::TestRunner::setWindowIsKey):
310         (WebTestRunner::TestRunner::pathToLocalResource):
311         (WebTestRunner::TestRunner::setBackingScaleFactor):
312         (WebTestRunner::TestRunner::setPOSIXLocale):
313         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
314         (WebTestRunner::TestRunner::taskList):
315         (TestRunner):
316         * DumpRenderTree/chromium/WebViewHost.cpp:
317         (WebViewHost::setDeviceScaleFactor):
318         (WebViewHost::setFocus):
319         (WebViewHost::setAcceptAllCookies):
320         (WebViewHost::pathToLocalResource):
321         (WebViewHost::setLocale):
322         * DumpRenderTree/chromium/WebViewHost.h:
323         (WebViewHost):
324
325 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
326
327         [GTK] build-webkit fails if the jhbuild wrapper is not used
328         https://bugs.webkit.org/show_bug.cgi?id=106769
329
330         Reviewed by Martin Robinson.
331
332         Return an empty array instead of "" in
333         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
334         will not be recognized as a valid command when the returned array
335         is directly passed to perl's system() call.
336
337         * Scripts/webkitdirs.pm:
338         (jhbuildWrapperPrefixIfNeeded):
339
340 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
341
342         [chromium] add title text direction attribute to TestRunner
343         https://bugs.webkit.org/show_bug.cgi?id=106907
344
345         Reviewed by Adam Barth.
346
347         * DumpRenderTree/chromium/DRTTestRunner.cpp:
348         (DRTTestRunner::DRTTestRunner):
349         (DRTTestRunner::reset):
350         * DumpRenderTree/chromium/DRTTestRunner.h:
351         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
352         (WebTestRunner::WebTestRunner::setTitleTextDirection):
353         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
354         (WebTestRunner::TestRunner::TestRunner):
355         (WebTestRunner::TestRunner::reset):
356         (WebTestRunner::TestRunner::setTitleTextDirection):
357         (WebTestRunner):
358         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
359         (TestRunner):
360         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
361         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
362         * DumpRenderTree/chromium/WebViewHost.cpp:
363         (WebViewHost::didReceiveTitle):
364
365 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
366
367         NRWT still confused about test count with --repeat-each and --iterations
368         https://bugs.webkit.org/show_bug.cgi?id=106562
369
370         Reviewed by Dirk Pranke.
371
372         Fix the printed unique test count and skipped count. This
373         seems to have broken in r127688 ("NRWT lies about the number
374         of tests that it's skipping when used with --repeat-each").
375
376         Also add a test for print_found()
377
378         * Scripts/webkitpy/layout_tests/views/printing.py:
379         (Printer.print_found):
380         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
381         (Testprinter.test_details):
382         (Testprinter):
383         (Testprinter.test_found):
384
385 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
386
387         Unreviewed follow-up to r139769.
388
389         Note that omitting the WebKit1 code from the build now
390         works for GTK as well.
391
392         * Scripts/build-webkit:
393
394 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
395
396         test-webkitpy: truncate output to the terminal width when necessary
397         https://bugs.webkit.org/show_bug.cgi?id=106973
398
399         Reviewed by Ojan Vafai.
400
401         this implements the same logic for test-webkitpy that we have
402         for run-webkit-tests (and ninja).
403
404         No tests written as this is exercised by running test-webkitpy itself.
405
406         * Scripts/webkitpy/test/printer.py:
407         (Printer.configure):
408         (Printer._test_line):
409
410 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
411
412         remove extraneous output in test-webkitpy
413         https://bugs.webkit.org/show_bug.cgi?id=106971
414
415         Reviewed by Ojan Vafai.
416
417         We weren't ignoring or capturing the echoed output from
418         these two tests, and getting noise in the logs as a result.
419
420         * Scripts/webkitpy/common/system/executive_unittest.py:
421         (ExecutiveTest.test_auto_stringify_args):
422         (ExecutiveTest.test_popen_args):
423
424 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
425
426         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
427         https://bugs.webkit.org/show_bug.cgi?id=106974
428
429         Reviewed by Ryosuke Niwa.
430
431         I forgot to stub out the call to check to ensure that the ports were
432         available, so this test could fail if something was listening on 8000 or
433         8443 on the machine.
434
435         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
436         (TestHttpServer.test_win32_start_and_stop):
437
438 2013-01-15  Levi Weintraub  <leviw@chromium.org>
439
440         Unreviewed, rolling out r139792.
441         http://trac.webkit.org/changeset/139792
442         https://bugs.webkit.org/show_bug.cgi?id=106970
443
444         Broke the windows build.
445
446         * DumpRenderTree/chromium/DRTTestRunner.cpp:
447         (DRTTestRunner::DRTTestRunner):
448         (DRTTestRunner::notifyDone):
449         (DRTTestRunner::reset):
450         (DRTTestRunner::setAlwaysAcceptCookies):
451         (DRTTestRunner::setWindowIsKey):
452         (DRTTestRunner::pathToLocalResource):
453         (DRTTestRunner::setPOSIXLocale):
454         (InvokeCallbackTask):
455         (InvokeCallbackTask::InvokeCallbackTask):
456         (InvokeCallbackTask::runIfValid):
457         (DRTTestRunner::setBackingScaleFactor):
458         * DumpRenderTree/chromium/DRTTestRunner.h:
459         (DRTTestRunner):
460         (DRTTestRunner::taskList):
461         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
462         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
463         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
464         (WebTestRunner::TestRunner::TestRunner):
465         (WebTestRunner::TestRunner::reset):
466         (WebTestRunner::TestRunner::setDatabaseQuota):
467         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
468         (TestRunner):
469         * DumpRenderTree/chromium/WebViewHost.cpp:
470         (WebViewHost::setPendingExtraData):
471         (WebViewHost::setDeviceScaleFactor):
472         * DumpRenderTree/chromium/WebViewHost.h:
473         (WebViewHost):
474
475 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
476
477         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
478
479         * Scripts/webkitpy/common/config/ports.py:
480         (MacWK2Port):
481
482 2013-01-15  Alan Cutter  <alancutter@chromium.org>
483
484         Extend sheriffbot's "help" command to be able to get help on individual commands
485         https://bugs.webkit.org/show_bug.cgi?id=106629
486
487         Reviewed by Eric Seidel.
488
489         Added a help command to sheriffbot.
490         Fixed some style issues and ordered the commands alphabetically.
491
492         * Scripts/webkitpy/tool/bot/irc_command.py:
493         (IRCCommand):
494         (IRCCommand.execute):
495         (IRCCommand.usage):
496         (IRCCommand.help):
497         (CreateBug):
498         (CreateBug.execute):
499         (Help):
500         (Help.execute):
501         (Help._post_command_help):
502         (Hi):
503         (Hi.execute):
504         (Restart):
505         (RollChromiumDEPS):
506         (RollChromiumDEPS._parse_args):
507         (RollChromiumDEPS._expand_irc_nickname):
508         (RollChromiumDEPS.execute):
509         (Rollout):
510         (Rollout._extract_revisions):
511         (Rollout.execute):
512         (Sheriffs):
513         (Sheriffs.execute):
514         (Whois):
515         (Whois.execute):
516         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
517         (IRCBotTest.test_help):
518
519 2013-01-15  Enrica Casucci  <enrica@apple.com>
520
521         Add a new set of WebKit2 APIs for text search and
522         search results management.
523         https://bugs.webkit.org/show_bug.cgi?id=106834.
524         <rdar://problem/12597159>
525
526         Added new test for the new WebKit2 API for
527         text search.
528         
529         Reviewed by Simon Fraser.
530
531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
532         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
533
534 2013-01-15  Levi Weintraub  <leviw@chromium.org>
535
536         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
537         https://bugs.webkit.org/show_bug.cgi?id=106904
538
539         Reverting 139794. It broke the build. It appears that a header file,
540         WebTextDirection.h, was left out.
541
542         * DumpRenderTree/chromium/DRTTestRunner.cpp:
543         (DRTTestRunner::DRTTestRunner):
544         (DRTTestRunner::reset):
545         * DumpRenderTree/chromium/DRTTestRunner.h:
546         (DRTTestRunner::setTitleTextDirection):
547         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
548         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
549         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
550         (WebTestRunner::TestRunner::TestRunner):
551         (WebTestRunner::TestRunner::reset):
552         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
553         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
554         (TestRunner):
555         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
556         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
557         * DumpRenderTree/chromium/WebViewHost.cpp:
558         (WebViewHost::didReceiveTitle):
559
560 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
561
562         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
563         https://bugs.webkit.org/show_bug.cgi?id=106904
564
565         Reviewed by Adam Barth.
566
567         * DumpRenderTree/chromium/DRTTestRunner.cpp:
568         (DRTTestRunner::DRTTestRunner):
569         (DRTTestRunner::notifyDone):
570         (DRTTestRunner::reset):
571         * DumpRenderTree/chromium/DRTTestRunner.h:
572         (DRTTestRunner):
573         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
574         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
575         (WebTestRunner::WebTestDelegate::setFocus):
576         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
577         (WebTestRunner::WebTestDelegate::pathToLocalResource):
578         (WebTestRunner::WebTestDelegate::setLocale):
579         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
580         (WebTestRunner::TestRunner::TestRunner):
581         (WebTestRunner::TestRunner::reset):
582         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
583         (WebTestRunner):
584         (WebTestRunner::TestRunner::setWindowIsKey):
585         (WebTestRunner::TestRunner::pathToLocalResource):
586         (WebTestRunner::TestRunner::setBackingScaleFactor):
587         (WebTestRunner::TestRunner::setPOSIXLocale):
588         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
589         (WebTestRunner::TestRunner::taskList):
590         (TestRunner):
591         * DumpRenderTree/chromium/WebViewHost.cpp:
592         (WebViewHost::setDeviceScaleFactor):
593         (WebViewHost::setFocus):
594         (WebViewHost::setAcceptAllCookies):
595         (WebViewHost::pathToLocalResource):
596         (WebViewHost::setLocale):
597         * DumpRenderTree/chromium/WebViewHost.h:
598         (WebViewHost):
599
600 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
601
602         Tests with WontFix expectation are (indirectly) skipped
603         https://bugs.webkit.org/show_bug.cgi?id=105860
604
605         Reviewed by Dirk Pranke.
606
607         Only skip the WontFix expectation if there are no other layout test
608         expectations (like Failure, ImageOnlyFailure) listed for the test.
609         This makes it possible to run an expected failure for which there
610         is no reason or interest to fix. There are some ports that would like
611         to exercise this behavior as well as specific test cases that should use
612         such expectations.
613
614         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
615         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
616         WONTFIX test if there are no expectations listed. The warning is adjusted
617         to reflect the new behavior.
618         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
619         and adjust test cases for these changes.
620         (ExpectationSyntaxTests.test_wontfix):
621         (SemanticTests.test_skip_and_wontfix):
622
623 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
624
625         [chromium] add title text direction attribute to TestRunner
626         https://bugs.webkit.org/show_bug.cgi?id=106907
627
628         Reviewed by Adam Barth.
629
630         * DumpRenderTree/chromium/DRTTestRunner.cpp:
631         (DRTTestRunner::DRTTestRunner):
632         (DRTTestRunner::reset):
633         * DumpRenderTree/chromium/DRTTestRunner.h:
634         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
635         (WebTestRunner::WebTestRunner::setTitleTextDirection):
636         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
637         (WebTestRunner::TestRunner::TestRunner):
638         (WebTestRunner::TestRunner::reset):
639         (WebTestRunner::TestRunner::setTitleTextDirection):
640         (WebTestRunner):
641         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
642         (TestRunner):
643         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
644         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
645         * DumpRenderTree/chromium/WebViewHost.cpp:
646         (WebViewHost::didReceiveTitle):
647
648 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
649
650         nrwt: change the default # of locked shards on chromium_win to 1
651         https://bugs.webkit.org/show_bug.cgi?id=106938
652
653         Reviewed by Eric Seidel.
654
655         It looks like LigHTTPd might be buggy or unstable if we are
656         running multiple http tests in parallel; see
657         http://code.google.com/p/chromium/issues/detail?id=169530 for more
658         context as well. This change will stop running http tests in parallel
659         and we can see if this fixes things.
660
661         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
662         (ChromiumWinPort.default_max_locked_shards):
663         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
664         (ChromiumWinTest.test_path_to_image_diff):
665         (ChromiumWinTest):
666         (ChromiumWinTest.test_default_max_locked_shards):
667
668 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
669
670         [chromium] move WebDatabase related methods to TestRunner library
671         https://bugs.webkit.org/show_bug.cgi?id=106905
672
673         Reviewed by Adam Barth.
674
675         * DumpRenderTree/chromium/DRTTestRunner.cpp:
676         (DRTTestRunner::DRTTestRunner):
677         (DRTTestRunner::reset):
678         * DumpRenderTree/chromium/DRTTestRunner.h:
679         (DRTTestRunner):
680         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
681         (WebTestRunner::WebTestDelegate::clearAllDatabases):
682         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
683         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
684         (WebTestRunner::TestRunner::TestRunner):
685         (WebTestRunner::TestRunner::reset):
686         (WebTestRunner::TestRunner::clearAllDatabases):
687         (WebTestRunner):
688         (WebTestRunner::TestRunner::setDatabaseQuota):
689         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
690         (TestRunner):
691         * DumpRenderTree/chromium/WebViewHost.cpp:
692         (WebViewHost::clearAllDatabases):
693         (WebViewHost::setDatabaseQuota):
694         * DumpRenderTree/chromium/WebViewHost.h:
695         (WebViewHost):
696
697 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
698
699         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
700         functionality match the name.
701         https://bugs.webkit.org/show_bug.cgi?id=106870
702
703         Reviewed by Adam Barth.
704
705         * Scripts/webkitpy/tool/commands/download.py:
706         (Clean):
707         (Update):
708         (Build):
709         (BuildAndTest):
710         (CheckStyle):
711         (BuildAttachment):
712         (BuildAndTestAttachment):
713         (AbstractPatchApplyingCommand):
714         (ApplyWatchList):
715         (AbstractPatchLandingCommand):
716         (CreateRollout):
717         * Scripts/webkitpy/tool/steps/__init__.py:
718         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
719         (CleanWorkingDirectory.options):
720         (CleanWorkingDirectory.run):
721         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
722         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
723         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
724
725 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
726
727         [Autotools] Add support for WebKit2-only builds
728         https://bugs.webkit.org/show_bug.cgi?id=106889
729
730         Reviewed by Gustavo Noronha Silva.
731
732         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
733         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
734         building the GTK port through build-webkit.
735         * Scripts/webkitdirs.pm:
736         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
737         arguments when not building WebKit1.
738         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
739         through the Autotools build system.
740
741 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
742
743         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
744         https://bugs.webkit.org/show_bug.cgi?id=106197
745
746         Reviewed by Martin Robinson.
747
748         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
749         features. Enable them on GTK, meaning they will be enabled in development builds
750         (i.e. when building with build-webkit).
751
752 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
753
754         [GTK] Enable CSS Image Resolution feature
755         https://bugs.webkit.org/show_bug.cgi?id=99038
756
757         Reviewed by Gustavo Noronha Silva.
758
759         Enable the CSS Image Resolution feature for the development
760         builds of the GTK port.
761
762         * Scripts/webkitperl/FeatureList.pm:
763
764 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
765
766         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
767         https://bugs.webkit.org/show_bug.cgi?id=106579
768
769         Reviewed by Gustavo Noronha Silva.
770
771         The --enable-unstable-features flag is not required to be passed anymore
772         to the configure script as it was removed in r138252.
773
774         * Scripts/webkitdirs.pm:
775         (buildAutotoolsProject):
776
777 2013-01-15  Tony Chang  <tony@chromium.org>
778
779         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
780
781         * Scripts/webkitpy/layout_tests/servers/http_server.py:
782         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
783         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
784         (TestHttpServer.test_win32_start_and_stop):
785
786 2013-01-15  Joshua Bell  <jsbell@chromium.org>
787
788         Unreviewed. Adding Michael Pruett as contributor.
789
790         * Scripts/webkitpy/common/config/committers.py:
791
792 2013-01-15  Victor Carbune  <victor@rosedu.org>
793
794         Unreviewed. Update my email addresses.
795
796         * Scripts/webkitpy/common/config/committers.py:
797
798 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
799
800         [GTK] Waiting on the gdb process will lead to deadlock
801         https://bugs.webkit.org/show_bug.cgi?id=106906
802
803         Reviewed by Philippe Normand.
804
805         Use communicate() rather than wait() on the Popen object that's running the gdb
806         command. This avoids the deadlock that occurs on the GTK builders.
807
808         * Scripts/webkitpy/layout_tests/port/gtk.py:
809         (GtkPort._get_gdb_output):
810
811 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
812
813         [GTK] Limit the number of frames printed out when backtracing with gdb
814         https://bugs.webkit.org/show_bug.cgi?id=106901
815
816         Reviewed by Philippe Normand.
817
818         Printing an unlimited number of frames when dumping the gdb backtracing
819         output can cause timeouts in the builders. This patch limits the number
820         of frames that are printed out to 1024.
821
822         * Scripts/webkitpy/layout_tests/port/gtk.py:
823         (GtkPort._get_gdb_output):
824
825 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
826
827         [Qt] Fix ImageDiff's image format conversion
828         https://bugs.webkit.org/show_bug.cgi?id=106880
829
830         Reviewed by Csaba Osztrogonác.
831
832         Besides actually doing the conversion this also silences the suspicious warning:
833         "ignoring return value of function declared with warn_unused_result attribute".
834
835         * ImageDiff/qt/ImageDiff.cpp:
836         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
837         copy of the image in the given format and does not alter the image itself.
838
839 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
840
841         [chromium] move remaining methods that just set a boolean flag to TestRunner library
842         https://bugs.webkit.org/show_bug.cgi?id=106823
843
844         Reviewed by Darin Fisher.
845
846         * DumpRenderTree/chromium/DRTTestRunner.cpp:
847         (DRTTestRunner::DRTTestRunner):
848         (DRTTestRunner::reset):
849         * DumpRenderTree/chromium/DRTTestRunner.h:
850         (DRTTestRunner):
851         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
852         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
853         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
854         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
855         (WebTestRunner::WebTestRunner::testRepaint):
856         (WebTestRunner::WebTestRunner::sweepHorizontally):
857         (WebTestRunner::WebTestRunner::isPrinting):
858         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
859         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
860         (WebTestRunner::TestRunner::TestRunner):
861         (WebTestRunner::TestRunner::reset):
862         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
863         (WebTestRunner):
864         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
865         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
866         (WebTestRunner::TestRunner::testRepaint):
867         (WebTestRunner::TestRunner::sweepHorizontally):
868         (WebTestRunner::TestRunner::isPrinting):
869         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
870         (WebTestRunner::TestRunner::dumpBackForwardList):
871         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
872         (WebTestRunner::TestRunner::dumpSelectionRect):
873         (WebTestRunner::TestRunner::repaintSweepHorizontally):
874         (WebTestRunner::TestRunner::setPrinting):
875         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
876         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
877         (TestRunner):
878
879 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
880
881         nrwt: stub out show_results_html for mock ports
882         https://bugs.webkit.org/show_bug.cgi?id=106848
883
884         Reviewed by Ojan Vafai.
885
886         We were accidentally using the underlying ports'
887         show_results_html_file() implementation, which would, unsurprisingly,
888         fail in many cases (e.g., running mock-efl on the mac).
889
890         No test added since we don't generally add tests for the mock
891         implementation.
892
893         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
894         (MockDRTPort.show_results_html_file):
895
896 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
897
898         Changing clean_working_directory/clean_local_commits and related
899         functions to have consistent naming.
900
901         https://bugs.webkit.org/show_bug.cgi?id=104198
902
903         Reviewed by Adam Barth.
904
905         * Scripts/webkitpy/common/checkout/scm/git.py:
906         * Scripts/webkitpy/common/checkout/scm/scm.py:
907         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
908         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
909         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
910         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
911
912 2013-01-14  Alan Cutter  <alancutter@chromium.org>
913
914         Fix EWS GCE build scripts to detect which zone is available
915         https://bugs.webkit.org/show_bug.cgi?id=106524
916
917         Reviewed by Adam Barth.
918
919         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
920         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
921         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
922         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
923
924 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
925
926         Adding an error string to AmbiguousCommitError.
927         https://bugs.webkit.org/show_bug.cgi?id=106846
928
929         Reviewed by Adam Barth.
930
931         * Scripts/webkitpy/common/checkout/scm/git.py:
932         (AmbiguousCommitError.__init__):
933
934 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
935
936         kill whole lighttpd process tree for chromium win
937         https://bugs.webkit.org/show_bug.cgi?id=106838
938
939         Reviewed by Tony Chang.
940
941         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
942         I think a test is causing a httpd server child process to wedge and
943         killing the parent httpd server process isn't sufficient to ensure
944         that the children are also killed.
945
946         * Scripts/webkitpy/layout_tests/servers/http_server.py:
947         (Lighttpd._check_and_kill):
948         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
949         (TestHttpServer.test_start_cmd):
950         (TestHttpServer):
951         (TestHttpServer.test_win32_start_and_stop):
952         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
953         (TestHttpServer.test_win32_start_and_stop.mock_returns):
954         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
955
956 2013-01-14  Nico Weber  <thakis@chromium.org>
957
958         [chromium] Enable `update-webkit --chromium --ninja` on windows
959         https://bugs.webkit.org/show_bug.cgi?id=106836
960
961         Reviewed by Eric Seidel.
962
963         After running this, build-webkit --chromium will use ninja to build.
964         Apparently there are some minor issues with that still, so it's
965         not quite ready for use yet.
966
967         * Scripts/webkitdirs.pm:
968         (determineIsChromiumNinja):
969         (buildChromium):
970
971 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
972
973         nrwt: use the same search path for baselines and TestExpectations on apple mac
974         https://bugs.webkit.org/show_bug.cgi?id=105599
975
976         Reviewed by Ryosuke Niwa.
977
978         Bug 105583 revealed some confusion due to the fact that the Apple
979         Mac port used a different list of directories to search for baselines
980         and TestExpectations files (actually, pretty much every port does).
981
982         It seems like a good idea to use the same list for both by default, but
983         making this happen will affect every port in slightly different ways, so
984         we'll try this on the Apple Mac port first.
985
986         Note that the effective changes for this are that:
987         1) The apple mac port will look in platform/wk2 for baselines where
988         it didn't before (it will look after looking in mac-wk2 but before
989         the non-wk2 dirs)
990         2) The apple mac-snowleopard port will use the expectations in
991         mac-lion as well as the expectations in mac-snowleopard, although
992         I'm not even sure if mac-snowleopard is still supported ...
993
994         * Scripts/webkitpy/layout_tests/port/mac.py:
995         (MacPort.default_baseline_search_path):
996         (MacPort.expectations_files):
997         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
998         (test_baseline_search_path):
999
1000 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
1001
1002         AX: Need to implement ColorWellRole
1003         https://bugs.webkit.org/show_bug.cgi?id=106756
1004
1005         Reviewed by Chris Fleizach.
1006
1007         Returns a string representation of the value of a color
1008         when the role is Color Well, to make it easy to write layout
1009         tests for color controls.
1010
1011         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1012
1013 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
1014
1015         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
1016         https://bugs.webkit.org/show_bug.cgi?id=106682
1017
1018         Reviewed by Chris Fleizach.
1019
1020         Modify Chromium's DRT implementation of intValue to return a
1021         different value depending on the role.
1022
1023         There are actually platform-specific differences in what should
1024         be returned in the "value" of an object, so Chromium normally keeps
1025         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
1026         but this is a fine simplification to make cross-platform tests easier.
1027
1028         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1029         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
1030
1031 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
1032
1033         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
1034         https://bugs.webkit.org/show_bug.cgi?id=106785
1035
1036         Reviewed by Adam Barth.
1037
1038         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1039         (DRTTestRunner::DRTTestRunner):
1040         (DRTTestRunner::reset):
1041         * DumpRenderTree/chromium/DRTTestRunner.h:
1042         (DRTTestRunner):
1043         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1044         (WebTestProxyBase):
1045         (WebTestRunner::WebTestProxy::setStatusText):
1046         (WebTestRunner::WebTestProxy::didStopLoading):
1047         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1048         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
1049         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
1050         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1051         (WebTestRunner::TestRunner::TestRunner):
1052         (WebTestRunner::TestRunner::reset):
1053         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
1054         (WebTestRunner):
1055         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
1056         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
1057         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
1058         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1059         (TestRunner):
1060         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1061         (WebTestRunner::WebTestProxyBase::setStatusText):
1062         (WebTestRunner):
1063         (WebTestRunner::WebTestProxyBase::didStopLoading):
1064         * DumpRenderTree/chromium/WebViewHost.cpp:
1065         (WebViewHost::didStopLoading):
1066         * DumpRenderTree/chromium/WebViewHost.h:
1067         (WebViewHost):
1068
1069 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
1070
1071         Web Inspector: devtools front-end doesn't have focus in TestShell
1072         https://bugs.webkit.org/show_bug.cgi?id=106778
1073
1074         Reviewed by Pavel Feldman.
1075
1076         Focus devTools window after loadURL method.
1077
1078         * DumpRenderTree/chromium/TestShell.cpp:
1079         (TestShell::runFileTest):
1080
1081 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1082
1083         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
1084         https://bugs.webkit.org/show_bug.cgi?id=106573
1085
1086         Reviewed by Philippe Normand.
1087
1088         Similarly to what's been described in bug 106569, we're building
1089         from release tarballs, so there's no reason to regenerate the
1090         autoconf-related stuff with autogen.sh, especially since we might
1091         run into trouble with automake 1.13 and deprecated macros.
1092
1093         * efl/jhbuild.modules:
1094
1095 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1096
1097         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
1098         https://bugs.webkit.org/show_bug.cgi?id=104909
1099
1100         Reviewed by Simon Hausmann.
1101
1102         To be able to build redistribuable binary packages, Qt's configure switches
1103         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
1104         dynamically link to optional system libraries.
1105         QtWebKit is doing its own configure checks for those libraries, thus adding a
1106         runtime dependency that might not be fulfilled if the packager's machine had
1107         those libraries while the user's machine won't.
1108
1109         Since in most cases where WebKit will want to use those system libraries, Qt will
1110         also be using them, remove these configure tests from WebKit.
1111
1112         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
1113         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
1114         * qmake/config.tests/libpng/libpng.cpp: Removed.
1115         * qmake/config.tests/libpng/libpng.pro: Removed.
1116         * qmake/mkspecs/features/features.prf:
1117
1118 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1119
1120         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
1121         https://bugs.webkit.org/show_bug.cgi?id=106574
1122
1123         Reviewed by Laszlo Gombos.
1124
1125         Rely on a more recent stable release, which includes support for
1126         Lua 5.2 in Edje and other assorted minor fixes.
1127
1128         While here, also use the "configure" script to build the libraries
1129         instead of relying on autogen.sh, which is not really needed with
1130         a release tarball and may have problems with automake 1.13.
1131
1132         * efl/jhbuild.modules:
1133
1134 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
1135
1136         Web Inspector: fix DRT to deliver simulated events to devtools front-end
1137         https://bugs.webkit.org/show_bug.cgi?id=106650
1138
1139         Reviewed by Pavel Feldman.
1140
1141         Add separated m_devToolsTestInterfaces object to testShell which is
1142         bind to devTools webview.
1143
1144         * DumpRenderTree/chromium/TestShell.cpp:
1145         (TestShell::initialize):
1146         (TestShell::createMainWindow):
1147         (TestShell::~TestShell):
1148         (TestShell::showDevTools):
1149         (TestShell::resetTestController):
1150         (TestShell::bindJSObjectsToWindow):
1151         (TestShell::createNewWindow):
1152         * DumpRenderTree/chromium/TestShell.h:
1153         (TestShell):
1154
1155 2013-01-14  Alan Cutter  <alancutter@chromium.org>
1156
1157         Sheriffbot command aliases need test cases
1158         https://bugs.webkit.org/show_bug.cgi?id=106754
1159
1160         Reviewed by Eric Seidel.
1161
1162         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1163         (SheriffBotTest.test_command_aliases):
1164
1165 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1166
1167         Allow users to misspell the "sheriffs" command in sheriffbot
1168         https://bugs.webkit.org/show_bug.cgi?id=106628
1169
1170         Reviewed by Steve Block.
1171
1172         * Scripts/webkitpy/tool/bot/irc_command.py:
1173
1174 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1175
1176         Make "gardeners" an alias for "sheriffs" in sherrifbot
1177         https://bugs.webkit.org/show_bug.cgi?id=106627
1178
1179         Reviewed by Eric Seidel.
1180
1181         * Scripts/webkitpy/tool/bot/irc_command.py:
1182
1183 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
1184
1185         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
1186         https://bugs.webkit.org/show_bug.cgi?id=105380
1187
1188         Reviewed by Eric Seidel.
1189
1190         Fix a regression introduced in r137692 where we were double-encoding
1191         the arguments to popen(); this was only an issue on windows, where
1192         we would try to encode something to mbcs, then try to encode it
1193         to unicode as if the input as ascii.
1194
1195         * Scripts/webkitpy/common/system/executive.py:
1196         (Executive.run_command):
1197
1198 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1199
1200         State who told sheriffbot to roll the Chromium deps and to what revision
1201         https://bugs.webkit.org/show_bug.cgi?id=106626
1202
1203         Reviewed by Eric Seidel.
1204
1205         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
1206
1207         * Scripts/webkitpy/tool/bot/irc_command.py:
1208         (RollChromiumDEPS._expand_irc_nickname):
1209         (RollChromiumDEPS.execute):
1210         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1211         (IRCCommandTest.test_roll_chromium_deps):
1212         * Scripts/webkitpy/tool/bot/sheriff.py:
1213         (Sheriff.post_chromium_deps_roll):
1214         * Scripts/webkitpy/tool/commands/roll.py:
1215         (RollChromiumDEPS._prepare_state):
1216         (PostChromiumDEPSRoll):
1217         (PostChromiumDEPSRoll._prepare_state):
1218         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1219         (PostRollCommandsTest.test_prepare_state):
1220         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1221         (PrepareChangeLogForDEPSRoll.run):
1222
1223 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1224
1225         Add Alan Cutter as contributor
1226         https://bugs.webkit.org/show_bug.cgi?id=106747
1227
1228         Reviewed by Eric Seidel.
1229
1230         * Scripts/webkitpy/common/config/committers.py:
1231
1232 2013-01-13  Jonathan Liu  <net147@gmail.com>
1233
1234         Fix CONFIG missing link_pkgconfig on Windows
1235         https://bugs.webkit.org/show_bug.cgi?id=106647
1236
1237         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
1238         properly on Windows because they are added to PKGCONFIG but
1239         CONFIG does not contain link_pkgconfig.
1240
1241         This is because link_pkgconfig is added in unix/default_pre.prf
1242         which is only used for UNIX platforms. To fix this, move it to
1243         the general default_pre.prf.
1244
1245         Reviewed by Simon Hausmann.
1246
1247         * qmake/mkspecs/features/default_pre.prf:
1248         * qmake/mkspecs/features/unix/default_pre.prf:
1249
1250 2013-01-12  Nico Weber  <thakis@chromium.org>
1251
1252         nrwt/chromium: Don't prefer chromium over webkit build directories
1253         https://bugs.webkit.org/show_bug.cgi?id=105597
1254
1255         Reviewed by Dirk Pranke.
1256
1257         Rely on the new timestamp logic instead. Requested by dpranke in
1258         https://bugs.webkit.org/show_bug.cgi?id=105498
1259
1260         * Scripts/webkitpy/layout_tests/port/chromium.py:
1261         (ChromiumPort._static_build_path):
1262         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1263         (ChromiumLinuxPortTest.test_build_path):
1264         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1265         (ChromiumMacPortTest.test_build_path):
1266         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1267         (ChromiumWinTest.test_build_path):
1268
1269 2013-01-12  Nico Weber  <thakis@chromium.org>
1270
1271         Use ninja by default on Linux for build-webkit --chromium, bot edition
1272         https://bugs.webkit.org/show_bug.cgi?id=104434
1273
1274         Reviewed by Eric Seidel.
1275
1276         r139557 changed update-webkit to pick ninja by default on linux, but
1277         the bots run update-webkit-chromium directly so they didn't see this.
1278         Move the default for ninja into update-webkit-chromium so that it's
1279         picked up by the bots, and let update-webkit forward non-default
1280         options to there.
1281
1282         This way, the default is in one place only and both developers (who
1283         usually use update-webkit which then shells out to
1284         updat-webkit-chromium) and bots (which use update-webkit-chromium
1285         directly) see the same behavior.
1286
1287         * Scripts/update-webkit:
1288         * Scripts/update-webkit-chromium:
1289
1290 2013-01-12  Nico Weber  <thakis@chromium.org>
1291
1292         Make ninja the default build system on Linux for build-webkit --chromium
1293         https://bugs.webkit.org/show_bug.cgi?id=104434
1294
1295         Reviewed by Eric Seidel.
1296
1297         * Scripts/update-webkit:
1298
1299 2013-01-12  Alan Cutter  <alancutter@chromium.org>
1300
1301         Migrate the remaining bots in EC2 to Google Compute Engine
1302         https://bugs.webkit.org/show_bug.cgi?id=106005
1303
1304         Reviewed by Eric Seidel.
1305
1306         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
1307
1308         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
1309         * EWSTools/boot.sh:
1310         * EWSTools/build-repo.sh:
1311         * EWSTools/start-queue.sh:
1312
1313 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
1314
1315         [chromium] move inspector related methods to TestRunner library
1316         https://bugs.webkit.org/show_bug.cgi?id=106654
1317
1318         Reviewed by Adam Barth.
1319
1320         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1321         (DRTTestRunner::DRTTestRunner):
1322         * DumpRenderTree/chromium/DRTTestRunner.h:
1323         (DRTTestRunner):
1324         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1325         (WebTestRunner::WebTestDelegate::showDevTools):
1326         (WebTestRunner::WebTestDelegate::closeDevTools):
1327         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
1328         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1329         (WebTestRunner::TestRunner::TestRunner):
1330         (WebTestRunner::TestRunner::showWebInspector):
1331         (WebTestRunner):
1332         (WebTestRunner::TestRunner::closeWebInspector):
1333         (WebTestRunner::TestRunner::evaluateInWebInspector):
1334         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1335         (TestRunner):
1336         * DumpRenderTree/chromium/WebViewHost.cpp:
1337         (WebViewHost::showDevTools):
1338         (WebViewHost::closeDevTools):
1339         (WebViewHost::evaluateInWebInspector):
1340         * DumpRenderTree/chromium/WebViewHost.h:
1341         (WebViewHost):
1342
1343 2013-01-11  Julie Parent  <jparent@chromium.org>
1344
1345         Builder should not be a valid parameter for stats dashboard
1346         https://bugs.webkit.org/show_bug.cgi?id=106698
1347
1348         Reviewed by Dirk Pranke.
1349         
1350         Since builder is a dashboard specific parameter, dashboard_base
1351         should not be handling it in handleValidHashParameterWrapper, rather,
1352         each specific dashboard should in its handleValidHashParameter function.
1353     
1354         Note that the FIXME in dashboard_base about this was actually wrong -
1355         we don't want to move it to g_crossDashboardState, because it isn't
1356         actually cross dashboard state.
1357         
1358         In fact, flakiness and treemap have the code in 
1359         handleValidHashParameter, but it is currently dead code because 
1360         dashboard_base gets to it first.
1361         
1362         Added the proper handling to timeline_explorer, since builder is
1363         valid there.
1364
1365         * TestResultServer/static-dashboards/dashboard_base.js:
1366         * TestResultServer/static-dashboards/timeline_explorer.html:
1367
1368 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1369
1370         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
1371         https://bugs.webkit.org/show_bug.cgi?id=106688
1372
1373         Reviewed by Eric Seidel.
1374
1375         Update the regular expression used to strip the garbage at the beginning.
1376
1377         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1378         (RunWebKitTests.nrwt_log_message_regexp):
1379
1380 2013-01-11  Pratik Solanki  <psolanki@apple.com>
1381
1382         TestRunner leaks when running tests
1383         https://bugs.webkit.org/show_bug.cgi?id=106683
1384
1385         Reviewed by Simon Fraser.
1386
1387         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
1388         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
1389         tests.
1390
1391         * DumpRenderTree/TestRunner.cpp:
1392         (TestRunner::makeWindowObject):
1393
1394 2013-01-11  Julie Parent  <jparent@chromium.org>
1395
1396         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
1397         https://bugs.webkit.org/show_bug.cgi?id=106247
1398
1399         Old code nulled out the loader instance when it completed loading and
1400         then later used the fact that it was null to determine if it had loaded
1401         or not.  This is not only unintuitive, but it also prevents using the
1402         loader object later on.
1403         
1404         Added new method, used it, added unit test for it.
1405         
1406         Reviewed by Dirk Pranke.
1407
1408         * TestResultServer/static-dashboards/dashboard_base.js:
1409         (resourceLoadingComplete):
1410         (handleLocationChange):
1411         * TestResultServer/static-dashboards/loader.js:
1412         (.):
1413         * TestResultServer/static-dashboards/loader_unittests.js:
1414
1415 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1416
1417         Try CRLF to LF change in r139407 again.
1418
1419         * BuildSlaveSupport/delete-stale-build-files:
1420         (main):
1421         (webkitBuildDirectory):
1422         * BuildSlaveSupport/kill-old-processes:
1423         (main):
1424
1425 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1426
1427         [GTK] Disable the unit tests timeout when running from make check
1428         https://bugs.webkit.org/show_bug.cgi?id=106670
1429
1430         Reviewed by Philippe Normand.
1431
1432         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
1433
1434 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1435
1436         Yet another unreviewed fix after r139431.
1437
1438         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
1439         the correct order.
1440
1441 2013-01-11  Dan Carney  <dcarney@google.com>
1442
1443         [chromium] move some whitespace and resize related methods to TestRunner library
1444         https://bugs.webkit.org/show_bug.cgi?id=106655
1445
1446         Reviewed by Jochen Eisinger.
1447
1448         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1449         (DRTTestRunner::DRTTestRunner):
1450         * DumpRenderTree/chromium/DRTTestRunner.h:
1451         (DRTTestRunner):
1452         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1453         (WebKit):
1454         (WebTestRunner::WebTestDelegate::setClientWindowRect):
1455         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
1456         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
1457         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1458         (WebTestRunner::TestRunner::TestRunner):
1459         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
1460         (WebTestRunner):
1461         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
1462         (WebTestRunner::TestRunner::enableAutoResizeMode):
1463         (WebTestRunner::TestRunner::disableAutoResizeMode):
1464         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1465         (TestRunner):
1466         * DumpRenderTree/chromium/WebViewHost.cpp:
1467         (WebViewHost::setClientWindowRect):
1468         * DumpRenderTree/chromium/WebViewHost.h:
1469         (WebViewHost):
1470
1471 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1472
1473         Unreviewed. Update my e-mail addresses.
1474
1475         * Scripts/webkitpy/common/config/committers.py:
1476
1477 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1478
1479         Another unreviewed fix after r139431.
1480
1481         In a way, this is also a generic bug fix, since previously isEfl()
1482         would fail when called from run-efl-tests and we thus did not use
1483         jhbuild to run our tests. This now resulted in us calling
1484         "jhbuild-wrapper run" without specifying a platform.
1485
1486         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
1487         to work.
1488
1489 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1490
1491         [Qt][WK1] Web Audio support
1492         https://bugs.webkit.org/show_bug.cgi?id=106651
1493
1494         Reviewed by Jocelyn Turcotte.
1495
1496         Implements support for dumping audio data in DumpRenderTree.
1497
1498         Adds WebAudio to toggleable features in QtTestBrowser.
1499
1500         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
1501         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
1502
1503         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1504         (WebCore::DumpRenderTree::dump):
1505         * DumpRenderTree/qt/TestRunnerQt.cpp:
1506         (TestRunner::reset):
1507         (TestRunner::overridePreference):
1508         (TestRunner::setAudioData):
1509         * DumpRenderTree/qt/TestRunnerQt.h:
1510         (TestRunner::shouldDumpAsAudio):
1511         (TestRunner::audioData):
1512         (TestRunner):
1513         * QtTestBrowser/launcherwindow.cpp:
1514         (LauncherWindow::applyPrefs):
1515         (LauncherWindow::createChrome):
1516         (LauncherWindow::toggleWebAudio):
1517         * QtTestBrowser/launcherwindow.h:
1518         (WindowOptions::WindowOptions):
1519         (WindowOptions):
1520         (LauncherWindow):
1521         * qmake/mkspecs/features/features.prf:
1522         * qmake/mkspecs/features/features.pri:
1523
1524 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1525
1526         Unreviewed jhbuild-related fix after r139431.
1527
1528         * Scripts/webkitpy/layout_tests/port/efl.py:
1529         (EflPort.__init__): Pass a string to set_option_default(), since
1530         shlex.split() will be called on it later.
1531
1532 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
1533
1534         Unreviewed typo fixes after r139431.
1535
1536         * Scripts/run-javascriptcore-tests:
1537
1538 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1539
1540         [jhbuild] Remove the "run-with-jhbuild" scripts.
1541         https://bugs.webkit.org/show_bug.cgi?id=106572
1542
1543         Reviewed by Martin Robinson.
1544
1545         Both ports which use jhbuild were mostly duplicating the
1546         `run-with-jhbuild' script in their own directories for no clear reason.
1547
1548         The script itself was just a thin wrapper around the `jhbuild-wrapper',
1549         so just start using that directly and get rid of a useless middle man.
1550
1551         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
1552         instead.
1553
1554         * Scripts/run-javascriptcore-tests:
1555         * Scripts/run-launcher:
1556         * Scripts/webkitdirs.pm:
1557         (runAutogenForAutotoolsProjectIfNecessary):
1558         (buildAutotoolsProject):
1559         (jhbuildWrapperPrefixIfNeeded):
1560         (generateBuildSystemFromCMakeProject):
1561         (buildCMakeGeneratedProject):
1562         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1563         (run):
1564         * Scripts/webkitpy/layout_tests/port/efl.py:
1565         (EflPort.__init__):
1566         (EflPort._image_diff_command):
1567         * efl/run-with-jhbuild: Removed.
1568         * gtk/run-with-jhbuild: Removed.
1569
1570 2013-01-11  Alan Cutter  <alancutter@chromium.org>
1571
1572         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
1573         https://bugs.webkit.org/show_bug.cgi?id=106636
1574
1575         Reviewed by Adam Barth.
1576
1577         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
1578
1579         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1580         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1581         * EWSTools/screen-config:
1582         * EWSTools/start-queue.sh:
1583
1584 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1585
1586         kill-old-processes and delete-stale-build-files use CRLF linebreaks
1587         https://bugs.webkit.org/show_bug.cgi?id=106622
1588
1589         Reviewed by Simon Fraser.
1590
1591         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
1592         Also escape clang\+\+ correctly in kill-old-processes.
1593
1594         * BuildSlaveSupport/delete-stale-build-files:
1595         * BuildSlaveSupport/kill-old-processes:
1596
1597 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1598
1599         Build fix after r139357. It was missing a comma.
1600
1601         * QueueStatusServer/model/queues.py:
1602         (Queue):
1603
1604 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1605
1606         Fixing AuthenticationError when running test-webkitpy as a non-committer.
1607         https://bugs.webkit.org/show_bug.cgi?id=106420
1608
1609         Reviewed by Eric Seidel.
1610
1611         * Scripts/webkitpy/common/checkout/scm/git.py:
1612         (Git.push_local_commits_to_server):
1613         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1614         * Scripts/webkitpy/common/checkout/scm/svn.py:
1615         (SVNRepository):
1616         (SVNRepository.has_authorization_for_realm):
1617
1618 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
1619
1620         [EFL][jhbuild] Use tarballs for gstreamer instead of git
1621         https://bugs.webkit.org/show_bug.cgi?id=106552
1622
1623         Reviewed by Laszlo Gombos.
1624
1625         Use tarballs for gstreamer instead of git in EFL's jhbuild
1626         to work around intermittent network issues on our build
1627         bots. Tarballs are fully cached and require no network
1628         operation if their checksum matches.
1629
1630         * efl/jhbuild.modules:
1631
1632 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1633
1634         Add Mac WK2 EWS bots
1635         https://bugs.webkit.org/show_bug.cgi?id=106590
1636
1637         Reviewed by Adam Barth.
1638
1639         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
1640         Also add a deprecated MacWK2Port class.
1641
1642         * QueueStatusServer/model/queues.py:
1643         (Queue):
1644         * Scripts/webkitpy/common/config/ports.py:
1645         (DeprecatedPort.port):
1646         (MacWK2Port):
1647         (MacWK2Port.run_webkit_tests_command):
1648         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1649         (MacEWS):
1650         (MacWK2EWS):
1651         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1652         (_test_ewses):
1653
1654 2013-01-10  Dan Carney  <dcarney@google.com>
1655
1656         [chromium] move webpermissionclient related methods to TestRunner library
1657         https://bugs.webkit.org/show_bug.cgi?id=106548
1658
1659         Reviewed by Jochen Eisinger.
1660
1661         * DumpRenderTree/DumpRenderTree.gypi:
1662         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1663         (DRTTestRunner::DRTTestRunner):
1664         (DRTTestRunner::reset):
1665         * DumpRenderTree/chromium/DRTTestRunner.h:
1666         (DRTTestRunner):
1667         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1668         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
1669         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1670         (WebKit):
1671         (WebTestRunner::WebTestRunner::webPermissions):
1672         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1673         (WebTestRunner::TestRunner::TestRunner):
1674         (WebTestRunner::TestRunner::setDelegate):
1675         (WebTestRunner):
1676         (WebTestRunner::TestRunner::reset):
1677         (WebTestRunner::TestRunner::webPermissions):
1678         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
1679         (WebTestRunner::TestRunner::setImagesAllowed):
1680         (WebTestRunner::TestRunner::setScriptsAllowed):
1681         (WebTestRunner::TestRunner::setStorageAllowed):
1682         (WebTestRunner::TestRunner::setPluginsAllowed):
1683         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
1684         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
1685         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1686         (WebTestRunner):
1687         (TestRunner):
1688         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
1689         (WebTestRunner):
1690         (WebTestRunner::WebPermissions::WebPermissions):
1691         (WebTestRunner::WebPermissions::~WebPermissions):
1692         (WebTestRunner::WebPermissions::allowImage):
1693         (WebTestRunner::WebPermissions::allowScriptFromSource):
1694         (WebTestRunner::WebPermissions::allowStorage):
1695         (WebTestRunner::WebPermissions::allowPlugins):
1696         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
1697         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
1698         (WebTestRunner::WebPermissions::setImagesAllowed):
1699         (WebTestRunner::WebPermissions::setScriptsAllowed):
1700         (WebTestRunner::WebPermissions::setStorageAllowed):
1701         (WebTestRunner::WebPermissions::setPluginsAllowed):
1702         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
1703         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
1704         (WebTestRunner::WebPermissions::setDelegate):
1705         (WebTestRunner::WebPermissions::setDumpCallbacks):
1706         (WebTestRunner::WebPermissions::reset):
1707         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
1708         (WebTestRunner):
1709         (WebPermissions):
1710         * DumpRenderTree/chromium/TestShell.cpp:
1711         (TestShell::initialize):
1712         (TestShell::resetTestController):
1713         (TestShell::createNewWindow):
1714         * DumpRenderTree/chromium/TestShell.h:
1715         (TestShell):
1716         * DumpRenderTree/chromium/WebViewHost.cpp:
1717         (WebViewHost::normalizeLayoutTestURL):
1718         * DumpRenderTree/chromium/WebViewHost.h:
1719         (WebViewHost):
1720
1721 2013-01-10  Alan Cutter  <alancutter@chromium.org>
1722
1723         Split EWS tool cold-boot.sh into modular components
1724         https://bugs.webkit.org/show_bug.cgi?id=106527
1725
1726         Reviewed by Adam Barth.
1727
1728         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
1729         Updated GCE bot build scripts to match.
1730         Unable to test scripts directly as they depend on being in the repository to work!
1731
1732         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1733         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1734         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
1735         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
1736         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
1737
1738 2013-01-10  Julie Parent  <jparent@chromium.org>
1739
1740         Dashboard Cleanup: Do not generate the page if we are about to reload.
1741         https://bugs.webkit.org/show_bug.cgi?id=106584
1742
1743         Reviewed by Dirk Pranke.
1744
1745         Move the logic to determine if we should generate the page into
1746         parseParameters() since that is where we have the knowledge to
1747         determine it, and return that value to handleLocationChange, 
1748         rather than passing the changed parameters back to handleLocationChange
1749         and having it make the decision.
1750         
1751         This is logically equivalent, save one case: when we are about to do
1752         a reload, we know that there is no reason to generate the page.  Old
1753         code was causing an extra page generation in this case.
1754         
1755         * TestResultServer/static-dashboards/dashboard_base.js:
1756         (parseParameters):
1757         (handleLocationChange):
1758
1759 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1760
1761         [jhbuild] Use the "configure" script to build glib
1762         https://bugs.webkit.org/show_bug.cgi?id=106569
1763
1764         Reviewed by Martin Robinson.
1765
1766         So far both EFL and GTK have been using autogen.sh to build glib.
1767         While that does work most of the time, it's not really needed since
1768         we are downloading and building stable releases from tarballs.
1769         Additionally, autogen.sh fails to work with automake 1.13 due to the
1770         usage of some macros that have been removed (this has already been
1771         fixed in glib master).
1772
1773         * efl/jhbuild.modules:
1774         * gtk/jhbuild.modules:
1775
1776 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1777
1778         Changing tests to be consistent and use self.scm rather then recreating the scm object.
1779         (Missed a couple)
1780         https://bugs.webkit.org/show_bug.cgi?id=106536
1781
1782         Reviewed by Eric Seidel.
1783
1784         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1785
1786 2013-01-10  Tony Chang  <tony@chromium.org>
1787
1788         Speed up supplemental dependency computation
1789         https://bugs.webkit.org/show_bug.cgi?id=106503
1790
1791         Reviewed by Adam Barth.
1792
1793         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
1794
1795         * WebKitTestRunner/CMakeLists.txt:
1796
1797 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
1798
1799         Remove the ENABLE_ANIMATION_API feature define occurences
1800         https://bugs.webkit.org/show_bug.cgi?id=106544
1801
1802         Reviewed by Simon Fraser.
1803
1804         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
1805         feature define handling still lingers in various build systems and configurations
1806         but is of no use, so it should be removed.
1807
1808         * Scripts/webkitperl/FeatureList.pm:
1809         * qmake/mkspecs/features/features.pri:
1810
1811 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1812
1813         [GTK] Add support for loading web process extensions
1814         https://bugs.webkit.org/show_bug.cgi?id=105631
1815
1816         Reviewed by Gustavo Noronha Silva.
1817
1818         * MiniBrowser/gtk/GNUmakefile.am:
1819         * MiniBrowser/gtk/main.c:
1820         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
1821         bundle lib from build dir.
1822         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
1823         located in WebProcess/InjectedBundle/API/gtk.
1824         * gtk/generate-gtkdoc:
1825         (get_webkit2_options): Scan also files in
1826         WebProcess/InjectedBundle/API/gtk to generate API docs.
1827         (get_webkit2_options.injected_bundle_src_path): Helper function to
1828         build paths in WebProcess/InjectedBundle/API/gtk.
1829
1830 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1831
1832         [EFL][WK2] Writing immediately to created windows (open) fails
1833         https://bugs.webkit.org/show_bug.cgi?id=105276
1834
1835         Reviewed by Kenneth Rohde Christiansen.
1836
1837         Do not reset 'about:blank' url for the new pages in mini browser.
1838
1839         * MiniBrowser/efl/main.c:
1840         (window_create):
1841
1842 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1843
1844         Changing tests to be consistent and use self.scm rather then recreating the scm object.
1845         https://bugs.webkit.org/show_bug.cgi?id=106536
1846
1847         Reviewed by Eric Seidel.
1848
1849         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1850
1851 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1852
1853         Converting to unittest2 so we can use assertItemsEqual, making tests
1854         not dependent on order of items.
1855         https://bugs.webkit.org/show_bug.cgi?id=106532
1856
1857         Before:
1858         Ran 1733 tests in 38.385s
1859         FAILED (failures=1, errors=22)
1860
1861         After:
1862         Ran 1733 tests in 32.298s
1863         FAILED (failures=0, errors=22)
1864
1865         Reviewed by Eric Seidel.
1866
1867         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1868         * Scripts/webkitpy/thirdparty/__init__.py:
1869         (AutoinstallImportHook._install_unittest2):
1870
1871 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
1872
1873         [EFL] Add gstreamer 1.0.5 to jhbuild
1874         https://bugs.webkit.org/show_bug.cgi?id=106178
1875
1876         Reviewed by Laszlo Gombos.
1877
1878         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
1879
1880         * efl/jhbuild.modules:
1881
1882 2013-01-09  Alan Cutter  <alancutter@chromium.org>
1883
1884         Updated parameters in GCE build scripts so they now work.
1885         https://bugs.webkit.org/show_bug.cgi?id=106523
1886
1887         Reviewed by Adam Barth.
1888
1889         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1890         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1891         * EWSTools/cold-boot.sh:
1892
1893 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
1894
1895         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
1896         https://bugs.webkit.org/show_bug.cgi?id=106520
1897
1898         Reviewed by James Robinson.
1899
1900         Part of a larger refactoring series. See tracking bug 82948.
1901
1902         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1903         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1904
1905 2013-01-09  Julie Parent  <jparent@chromium.org>
1906
1907         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
1908         https://bugs.webkit.org/show_bug.cgi?id=106514
1909
1910         This is old code, as these can no longer get out of sync.
1911         permmaLinkURLHash is generated from currentState, which is set only
1912         from the location.  The commment about how these can get out of sync
1913         refers to a function that no longer exists.
1914         
1915         Reviewed by Dirk Pranke.
1916
1917         * TestResultServer/static-dashboards/dashboard_base.js:
1918         (handleLocationChange):
1919
1920 2013-01-09  Julie Parent  <jparent@chromium.org>
1921
1922         Dashboard Cleanup: Reload the page as soon as we know we need to.
1923         https://bugs.webkit.org/show_bug.cgi?id=106515
1924
1925         No need to continue parsing all of the data once we know that
1926         we need to do a reload.
1927         
1928         Reviewed by Dirk Pranke.
1929
1930         * TestResultServer/static-dashboards/dashboard_base.js:
1931         (parseParameters):
1932
1933 2013-01-09  Eric Seidel  <eric@webkit.org>
1934
1935         run-perf-tests --chromium-android --profile should show symbols for the kernel
1936         https://bugs.webkit.org/show_bug.cgi?id=106498
1937
1938         Reviewed by Adam Barth.
1939
1940         Turns out this was easy, once I finally read the output from "perf report".
1941         It appears there may be a bug in "perf record" on android, as it complains
1942         about not being able to read from /proc/kallsyms even when
1943         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
1944         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
1945         but rather just flip it to 0 long enough to grab the /proc/kallsyms
1946         and then flip it back to whatever the device had.
1947
1948         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
1949         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
1950         to symbol names.  Its world-readable, but will return all 0s if you
1951         don't have permission to see the kernel symbols.  kptr_restrict
1952         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
1953         1 is only a specific group, and 2 is "no one, not even root".
1954         By default kptr_restrict is 2 on Android it seems.
1955         More kptr_restrict docs: http://lwn.net/Articles/420403/
1956
1957         I also took this opportunity to clean up how the perf record command
1958         was built for use/display in AndroidPerf.profile_after_exit and
1959         change to always using long-form names for the arguments (to hopefully help readability).
1960
1961         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1962         (AndroidPerf.__init__):
1963         (profile_after_exit):
1964         (ChromiumAndroidDriver.__init__):
1965         (ChromiumAndroidDriver._update_kallsyms_cache):
1966         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1967
1968 2013-01-09  Julie Parent  <jparent@chromium.org>
1969
1970         Dashboard cleanup: remove dead code.
1971         https://bugs.webkit.org/show_bug.cgi?id=106509
1972
1973         Reviewed by Dirk Pranke.
1974
1975         * TestResultServer/static-dashboards/dashboard_base.js:
1976         (parseParameters):
1977
1978 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
1979
1980         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
1981         https://bugs.webkit.org/show_bug.cgi?id=105638
1982
1983         Reviewed by Martin Robinson.
1984
1985         The test was failing for two reasons:
1986         - AccessibilityRenderObject::correspondingLabelForControlElement() was
1987           not ignoring the ARIA labelled-by property
1988         - AccessibilityController::accessibleElementById() was not implemented
1989
1990         Because getting an element by ID cannot be done in the UIProcess, the
1991         decision was made to expose the element's ID as an accessible attribute
1992         of the object.
1993
1994         In addition, fixing the bug in AccessibilityRenderObject made it possible
1995         to eliminate the Gtk platform-specific expectations for another test.
1996
1997         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1998         (childElementById): Added. Walks the tree looking for the AtkObject
1999         Attribute which exposes the HTML element's ID.
2000         (AccessibilityController::accessibleElementById): Implemented.
2001         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2002         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
2003         when there is no title, as is done with the Mac port.
2004         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2005         (WTR):
2006         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2007         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
2008         Attribute which exposes the HTML element's ID.
2009         (WTR):
2010         (WTR::AccessibilityController::accessibleElementById): Implemented.
2011         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2012         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
2013         even when there is no title, as is done with the Mac port.
2014
2015 2013-01-09  Gregg Tavares  <gman@google.com>
2016
2017         Add Gregg Tavares as a committer
2018         https://bugs.webkit.org/show_bug.cgi?id=106492
2019
2020         Unreviewed.
2021
2022         * Scripts/webkitpy/common/config/committers.py:
2023
2024 2013-01-09  Roger Fong  <roger_fong@apple.com>
2025
2026         Enable seamless iFrames for Windows DRT.
2027         https://bugs.webkit.org/show_bug.cgi?id=106468.
2028
2029         Rubberstamped by Timothy Horton.
2030
2031         * DumpRenderTree/win/DumpRenderTree.cpp:
2032         (resetDefaultsToConsistentValues):
2033
2034 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
2035
2036         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
2037         https://bugs.webkit.org/show_bug.cgi?id=93979
2038
2039         Reviewed by Benjamin Poulain.
2040
2041         Implement eventSender.scheduleAsynchronousKeyDown() in
2042         WebKitTestRunner.
2043
2044         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2045         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2046         (WTR::createKeyDownMessageBody):
2047         (WTR::EventSendingController::keyDown):
2048         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2049         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2050         (EventSendingController):
2051         * WebKitTestRunner/TestController.cpp:
2052         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2053         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2054         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2055         * WebKitTestRunner/TestController.h:
2056         (TestController):
2057
2058 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
2059
2060         [chromium] move resource load callback dumping to TestRunner library
2061         https://bugs.webkit.org/show_bug.cgi?id=106449
2062
2063         Reviewed by Adam Barth.
2064
2065         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2066         (DRTTestRunner::DRTTestRunner):
2067         (DRTTestRunner::reset):
2068         * DumpRenderTree/chromium/DRTTestRunner.h:
2069         (DRTTestRunner):
2070         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2071         (WebKit):
2072         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
2073         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2074         (WebKit):
2075         (WebTestProxyBase):
2076         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
2077         (WebTestRunner::WebTestProxy::willRequestResource):
2078         (WebTestRunner::WebTestProxy::willSendRequest):
2079         (WebTestRunner::WebTestProxy::didReceiveResponse):
2080         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
2081         (WebTestRunner::WebTestProxy::didFailResourceLoad):
2082         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2083         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
2084         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
2085         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
2086         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2087         (WebTestRunner::TestRunner::TestRunner):
2088         (WebTestRunner::TestRunner::reset):
2089         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
2090         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
2091         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
2092         (WebTestRunner):
2093         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
2094         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
2095         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
2096         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2097         (TestRunner):
2098         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2099         (WebTestRunner::WebTestProxyBase::reset):
2100         (WebTestRunner):
2101         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
2102         (WebTestRunner::WebTestProxyBase::willRequestResource):
2103         (WebTestRunner::WebTestProxyBase::willSendRequest):
2104         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
2105         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
2106         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
2107         * DumpRenderTree/chromium/WebViewHost.cpp:
2108         (WebViewHost::willSendRequest):
2109         (WebViewHost::makeURLErrorDescription):
2110         (WebViewHost::reset):
2111         * DumpRenderTree/chromium/WebViewHost.h:
2112         (WebViewHost):
2113
2114 2013-01-09  Dan Carney  <dcarney@google.com>
2115
2116         [chromium] move dumpcreateview methods to testrunner library
2117         https://bugs.webkit.org/show_bug.cgi?id=106434
2118
2119         Reviewed by Adam Barth.
2120
2121         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2122         (DRTTestRunner::DRTTestRunner):
2123         (DRTTestRunner::reset):
2124         * DumpRenderTree/chromium/DRTTestRunner.h:
2125         (DRTTestRunner):
2126         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2127         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
2128         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2129         (WebTestRunner::TestRunner::TestRunner):
2130         (WebTestRunner::TestRunner::reset):
2131         (WebTestRunner::TestRunner::shouldDumpCreateView):
2132         (WebTestRunner):
2133         (WebTestRunner::TestRunner::dumpCreateView):
2134         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2135         (TestRunner):
2136
2137 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
2138
2139         webkitpy cleanup: Merge additional_comment_text into comment_text
2140         https://bugs.webkit.org/show_bug.cgi?id=106421
2141
2142         Reviewed by Adam Barth.
2143
2144         * Scripts/webkitpy/common/config/committervalidator.py:
2145         (CommitterValidator.reject_patch_from_commit_queue):
2146         (CommitterValidator.reject_patch_from_review_queue):
2147         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2148         (Bugzilla.set_flag_on_attachment):
2149         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2150         (MockBugzilla.set_flag_on_attachment):
2151         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2152         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2153         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
2154         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2155
2156 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
2157
2158         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
2159         https://bugs.webkit.org/show_bug.cgi?id=106464
2160
2161         Reviewed by Martin Robinson.
2162
2163         Current version in jhbuild.modules (2.26.0) is giving trouble to
2164         when trying to build WebKitGTK from scratch, due to a segmentation
2165         fault error in gdk-pixbuf-query-loader during the 'make'
2166         phase. Raising the version to 2.26.5 fixes this issue.
2167
2168         * gtk/jhbuild.modules: Version raised, checksums updated.
2169
2170 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
2171
2172         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
2173         https://bugs.webkit.org/show_bug.cgi?id=90968.
2174
2175         Reviewed by Csaba Osztrogonác.
2176
2177         Added functionality in DRT and WTR to use any timeout value while running
2178         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
2179         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
2180         to indicate whether the current port supports setting timeout value
2181         per test (it's False by default; I enabled it only on Qt).
2182         Also corrected a typo in driver.py
2183
2184         * DumpRenderTree/DumpRenderTree.h:
2185         (TestCommand::TestCommand):
2186         (TestCommand):
2187         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2188         (parseInputLine):
2189         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2190         (WebCore::DumpRenderTree::processLine):
2191         * Scripts/webkitpy/layout_tests/port/base.py:
2192         (Port.supports_per_test_timeout):
2193         * Scripts/webkitpy/layout_tests/port/driver.py:
2194         (Driver.run_test):
2195         (Driver._command_from_driver_input):
2196         * Scripts/webkitpy/layout_tests/port/qt.py:
2197         (QtPort.supports_per_test_timeout):
2198         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2199         (WTR::InjectedBundle::InjectedBundle):
2200         (WTR::InjectedBundle::didReceiveMessage):
2201         (WTR::InjectedBundle::beginTesting):
2202         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2203         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2204         (WTR::TestRunner::setCustomTimeout):
2205         (WTR):
2206         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2207         (TestRunner):
2208         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
2209         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2210         * WebKitTestRunner/TestController.cpp:
2211         (WTR::TestController::TestController):
2212         (WTR::TestController::getCustomTimeout):
2213         (WTR):
2214         (WTR::TestCommand::TestCommand):
2215         (TestCommand):
2216         (WTR::parseInputLine):
2217         (WTR::TestController::runTest):
2218         (WTR::TestController::runUntil):
2219         * WebKitTestRunner/TestController.h:
2220         (TestController):
2221         * WebKitTestRunner/TestInvocation.cpp:
2222         (WTR::TestInvocation::TestInvocation):
2223         (WTR::TestInvocation::setCustomTimeout):
2224         (WTR):
2225         (WTR::TestInvocation::invoke):
2226         * WebKitTestRunner/TestInvocation.h:
2227         (TestInvocation):
2228
2229 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2230
2231         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
2232         https://bugs.webkit.org/show_bug.cgi?id=106290
2233
2234         Reviewed by Martin Robinson.
2235
2236         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
2237         the macro isn't enabled.
2238
2239         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2240
2241 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
2242
2243         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
2244         https://bugs.webkit.org/show_bug.cgi?id=103653
2245
2246         Reviewed by Anders Carlsson.
2247
2248         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
2249         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
2250         client callback.
2251
2252         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
2253         methods to the JavaScript API.
2254         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2255         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
2256         (WTR::TestRunner::setAuthenticationUsername): Ditto.
2257         (WTR::TestRunner::setAuthenticationPassword): Ditto.
2258         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2259         (TestRunner): Added new declarations for the above.
2260         * WebKitTestRunner/TestController.cpp:
2261         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
2262         callback.
2263         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
2264         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
2265         the authentication information passed from the InjectedBundle.
2266         * WebKitTestRunner/TestController.h:
2267         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
2268         to communicate with the TestController.
2269         (WTR::TestController::setAuthenticationUsername): Ditto.
2270         (WTR::TestController::setAuthenticationPassword): Ditto.
2271         (TestController):
2272         * WebKitTestRunner/TestInvocation.cpp:
2273         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
2274         information from the InjectedBundle.
2275         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
2276         text to the TestInvocation text output.
2277         * WebKitTestRunner/TestInvocation.h:
2278         (TestInvocation): Added declaration for new method.
2279
2280 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
2281
2282         Add myself as a watcher for Web Geolocation
2283
2284         Unreviewed.
2285
2286         * Scripts/webkitpy/common/config/watchlist:
2287
2288 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2289
2290         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
2291         https://bugs.webkit.org/show_bug.cgi?id=106364
2292
2293         Reviewed by Eric Seidel.
2294
2295         When the setup_test_run method is called on the subclasses of the base Port
2296         interface, the parent method should also be called via super(), despite the
2297         parent method not doing anything at the moment.
2298
2299         The according calls to super() are required in the ChromiumPort, EflPort
2300         and GtkPort implementations.
2301
2302         * Scripts/webkitpy/layout_tests/port/chromium.py:
2303         (ChromiumPort.setup_test_run):
2304         * Scripts/webkitpy/layout_tests/port/efl.py:
2305         (EflPort.setup_test_run):
2306         * Scripts/webkitpy/layout_tests/port/gtk.py:
2307         (GtkPort.setup_test_run):
2308
2309 2013-01-08  Julie Parent  <jparent@chromium.org>
2310
2311         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
2312         https://bugs.webkit.org/show_bug.cgi?id=106356
2313
2314         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
2315         dashboard_base, assigned by Loader, and used only by dashboard_base to
2316         create error messages.  Moved the variables to be privates on the Loader
2317         object, moved error message creation to _getLoadingErrorMessages on the
2318         Loader object, and now pass the errors back to dashboard base via the
2319         resourceLoadingComplete callback.
2320         
2321         Also removed the now unused clearError function, it was only being used
2322         by unit tests to clean up global state.
2323         
2324         Reviewed by Dirk Pranke.
2325
2326         * TestResultServer/static-dashboards/dashboard_base.js:
2327         (resourceLoadingComplete):
2328         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2329         * TestResultServer/static-dashboards/loader.js:
2330         (.):
2331         * TestResultServer/static-dashboards/loader_unittests.js:
2332
2333 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2334
2335         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
2336         https://bugs.webkit.org/show_bug.cgi?id=106354
2337
2338         Reviewed by Eric Seidel.
2339
2340         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
2341         instead of those two inheriting from it. Also add a mock object of the
2342         sanitizer that's used in unit tests.
2343
2344         * Scripts/webkitpy/layout_tests/port/efl.py:
2345         (EflPort):
2346         (EflPort.__init__):
2347         (EflPort.setup_test_run):
2348         (EflPort.clean_up_test_run):
2349         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
2350         importing order.
2351         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
2352         * Scripts/webkitpy/layout_tests/port/gtk.py:
2353         (GtkPort):
2354         (GtkPort.__init__):
2355         (GtkPort.setup_test_run):
2356         (GtkPort.clean_up_test_run):
2357         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
2358         importing order.
2359         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
2360         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
2361         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
2362         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
2363         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
2364         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
2365         (PulseAudioSanitizerMock.unload_pulseaudio_module):
2366         (PulseAudioSanitizerMock.restore_pulseaudio_module):
2367
2368 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
2369
2370         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
2371         https://bugs.webkit.org/show_bug.cgi?id=106324
2372
2373         Reviewed by Adam Barth.
2374
2375         Since the frame load callbacks are part of the WebFrameClient, the
2376         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
2377         methods.
2378
2379         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2380         (DRTTestRunner::DRTTestRunner):
2381         (DRTTestRunner::reset):
2382         * DumpRenderTree/chromium/DRTTestRunner.h:
2383         (DRTTestRunner):
2384         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2385         (WebTestInterfaces):
2386         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2387         (WebKit):
2388         (WebTestProxyBase):
2389         (WebTestRunner):
2390         (WebTestRunner::WebTestProxy::WebTestProxy):
2391         (WebTestProxy):
2392         (WebTestRunner::WebTestProxy::didInvalidateRect):
2393         (WebTestRunner::WebTestProxy::didScrollRect):
2394         (WebTestRunner::WebTestProxy::scheduleComposite):
2395         (WebTestRunner::WebTestProxy::scheduleAnimation):
2396         (WebTestRunner::WebTestProxy::setWindowRect):
2397         (WebTestRunner::WebTestProxy::show):
2398         (WebTestRunner::WebTestProxy::didAutoResize):
2399         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
2400         (WebTestRunner::WebTestProxy::startDragging):
2401         (WebTestRunner::WebTestProxy::shouldBeginEditing):
2402         (WebTestRunner::WebTestProxy::shouldEndEditing):
2403         (WebTestRunner::WebTestProxy::shouldInsertNode):
2404         (WebTestRunner::WebTestProxy::shouldInsertText):
2405         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
2406         (WebTestRunner::WebTestProxy::shouldDeleteRange):
2407         (WebTestRunner::WebTestProxy::shouldApplyStyle):
2408         (WebTestRunner::WebTestProxy::didBeginEditing):
2409         (WebTestRunner::WebTestProxy::didChangeSelection):
2410         (WebTestRunner::WebTestProxy::didChangeContents):
2411         (WebTestRunner::WebTestProxy::didEndEditing):
2412         (WebTestRunner::WebTestProxy::registerIntentService):
2413         (WebTestRunner::WebTestProxy::dispatchIntent):
2414         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
2415         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
2416         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
2417         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
2418         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
2419         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
2420         (WebTestRunner::WebTestProxy::didReceiveTitle):
2421         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
2422         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
2423         (WebTestRunner::WebTestProxy::didFailLoad):
2424         (WebTestRunner::WebTestProxy::didFinishLoad):
2425         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
2426         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
2427         (WebTestRunner::WebTestProxy::didRunInsecureContent):
2428         (WebTestRunner::WebTestProxy::didDetectXSS):
2429         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2430         (WebTestRunner::WebTestRunner::setTestIsRunning):
2431         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
2432         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
2433         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
2434         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
2435         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
2436         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2437         (WebTestRunner::TestRunner::TestRunner):
2438         (WebTestRunner::TestRunner::reset):
2439         (WebTestRunner::TestRunner::setTestIsRunning):
2440         (WebTestRunner):
2441         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
2442         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
2443         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
2444         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
2445         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
2446         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
2447         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
2448         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
2449         (WebTestRunner::TestRunner::dumpTitleChanges):
2450         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2451         (TestRunner):
2452         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2453         (WebTestInterfaces::Internal):
2454         (WebTestRunner::WebTestInterfaces::Internal::webView):
2455         (WebTestRunner::WebTestInterfaces::Internal::Internal):
2456         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
2457         (WebTestRunner):
2458         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
2459         (WebTestRunner::WebTestInterfaces::setWebView):
2460         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
2461         (WebTestRunner::WebTestInterfaces::webView):
2462         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2463         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
2464         (WebTestRunner):
2465         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
2466         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
2467         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
2468         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
2469         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
2470         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2471         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
2472         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
2473         (WebTestRunner::WebTestProxyBase::didFailLoad):
2474         (WebTestRunner::WebTestProxyBase::didFinishLoad):
2475         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
2476         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
2477         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
2478         (WebTestRunner::WebTestProxyBase::didDetectXSS):
2479         * DumpRenderTree/chromium/TestShell.cpp:
2480         (TestShell::runFileTest):
2481         (TestShell::testFinished):
2482         * DumpRenderTree/chromium/TestShell.h:
2483         (TestShell):
2484         * DumpRenderTree/chromium/WebViewHost.cpp:
2485         (WebViewHost::didStartProvisionalLoad):
2486         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
2487         (WebViewHost::didFailProvisionalLoad):
2488         (WebViewHost::didCommitProvisionalLoad):
2489         (WebViewHost::didReceiveTitle):
2490         (WebViewHost::didFailLoad):
2491         (WebViewHost::didFinishLoad):
2492         * DumpRenderTree/chromium/WebViewHost.h:
2493         (WebViewHost):
2494
2495 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2496
2497         [GTK] Lower the default timeout value for WebKitTestRunner
2498         https://bugs.webkit.org/show_bug.cgi?id=106353
2499
2500         Reviewed by Dirk Pranke.
2501
2502         The default timeout value for WebKitTestRunner should be lowered.
2503         The current value (80 seconds) is irrational and just leads to producing
2504         text failures for layout tests that genuinely time out. This just leads
2505         to more deviation from the GTK WK1 port in terms of test expectations.
2506
2507         The value used is the same as when running the DumpRenderTree, that's
2508         6 seconds in release builds and 12 seconds in debug builds.
2509
2510         * Scripts/webkitpy/layout_tests/port/gtk.py:
2511         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2512         (GtkPortTest.test_default_timeout_ms):
2513
2514 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2515
2516         test-webkitpy shows failure output on my linux box
2517         https://bugs.webkit.org/show_bug.cgi?id=101261
2518
2519         Reviewed by Eric Seidel.
2520
2521         Mock out the PulseAudioSanitizer methods when creating testing instances
2522         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
2523         PulseAudio output when the sanitizer was trying to unload modules which
2524         were already unloaded by another unit test that was being run in parallel.
2525
2526         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2527         (EflPortTest):
2528         (EflPortTest.make_port):
2529         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2530         (GtkPortTest):
2531         (GtkPortTest.make_port):
2532
2533 2013-01-08  Julie Parent  <jparent@chromium.org>
2534
2535         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
2536         https://bugs.webkit.org/show_bug.cgi?id=106254
2537
2538         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
2539         only to figure out if we should call addBuilderLoadErrors during
2540         handleLocationChange, which was called when the loader completed and on
2541         any hash change, but we only ever wanted to call addBuilderLoadErrors
2542         on the initial loader load.  Moved the call of addBuilderLoadErrors to
2543         resourceLoadingComplete rather than handleLocationChange, so now we
2544         only call it when we want to, and the check can go away completely.
2545
2546         Reviewed by Dirk Pranke.
2547
2548         * TestResultServer/static-dashboards/dashboard_base.js:
2549         (addBuilderLoadErrors):
2550         (resourceLoadingComplete):
2551         (handleLocationChange):
2552         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2553
2554 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
2555
2556         Add aboxhall@chromium.org to accessibility watchlist.
2557
2558         Unreviewed.
2559
2560         * Scripts/webkitpy/common/config/watchlist:
2561
2562 2013-01-08  Dan Winship  <danw@gnome.org>
2563
2564         Add Apache 2.4 support for Fedora 18
2565         https://bugs.webkit.org/show_bug.cgi?id=104478
2566
2567         Reviewed by Martin Robinson.
2568
2569         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
2570         need a separate config.
2571
2572         * Scripts/webkitpy/layout_tests/port/base.py:
2573         (Port._apache_version):
2574         (Port._apache_config_file_name_for_platform):
2575         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2576         * Scripts/run-webkit-httpd:
2577         * Scripts/webkitperl/httpd.pm:
2578         (getApacheVersion):
2579         (getDefaultConfigForTestDirectory):
2580         (getHTTPDConfigPathForTestDirectory):
2581
2582 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2583
2584         Make the override-feature-defines script compatible with Python v3
2585         https://bugs.webkit.org/show_bug.cgi?id=105742
2586
2587         Reviewed by Martin Robinson.
2588
2589         Instead of printing output through a statement, use the print function and format
2590         the output using the str.format method. This makes the script runnable with Python v3.
2591
2592         * gtk/override-feature-defines:
2593         (adjust_feature_defines_makefile):
2594
2595 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
2596
2597         [Qt] Fix libxml2 config test
2598         https://bugs.webkit.org/show_bug.cgi?id=106317
2599
2600         Reviewed by Simon Hausmann.
2601
2602         Don't assume standard include/libxml2, libxml-2.0.pc should know
2603         where it's headers are.
2604
2605         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
2606
2607 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2608
2609         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
2610         https://bugs.webkit.org/show_bug.cgi?id=106195
2611
2612         Reviewed by Philippe Normand.
2613
2614         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
2615         to make the Python code compatible with Python 3. This includes modifying
2616         print statements, exception handling, dictionary iteration and
2617         byte-sequence-to-string conversion.
2618
2619         * gtk/common.py:
2620         (get_build_path):
2621         (pkg_config_file_variable):
2622         (gtk_version_of_pkg_config_file):
2623         * gtk/generate-gtkdoc:
2624         (print_missing_api):
2625         * gtk/gtkdoc.py:
2626         (GTKDoc.__init__):
2627         (GTKDoc._run_command):
2628
2629 2013-01-02  Steve Block  <steveblock@chromium.org>
2630
2631         Add chromium.org email address for Steve Block.
2632
2633         Unreviewed.
2634
2635         * Scripts/webkitpy/common/config/committers.py:
2636
2637 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
2638
2639         Rationalize closure call heuristics and profiling
2640         https://bugs.webkit.org/show_bug.cgi?id=106270
2641
2642         Reviewed by Oliver Hunt.
2643         
2644         Add ability to use display-profiler-output via a pipe, and add the ability to dump
2645         all generated code ('display *' or 'd *').
2646
2647         * Scripts/display-profiler-output:
2648
2649 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2650
2651         Sorted more xcodeproj files.
2652
2653         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2654         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2655         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2656
2657 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2658
2659         Sorted xcodeproj files.
2660
2661         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2662         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2663
2664 2013-01-07  Dan Bernstein  <mitz@apple.com>
2665
2666         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
2667         https://bugs.webkit.org/show_bug.cgi?id=106261
2668
2669         Reviewed by Simon Fraser.
2670
2671         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
2672
2673         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2674         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
2675         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
2676         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
2677         (TestWebKitAPI):
2678         (TestWebKitAPI::TEST):
2679
2680 2013-01-07  Ojan Vafai  <ojan@chromium.org>
2681
2682         Add the Apple MountainLion bots to garden-o-matic.
2683         Eventually, we really should move away from hardcoding
2684         the list of bots.
2685
2686         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2687
2688 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
2689
2690         [chromium] move web audio related methods to testrunner library
2691         https://bugs.webkit.org/show_bug.cgi?id=106211
2692
2693         Reviewed by Adam Barth.
2694
2695         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2696         (DRTTestRunner::DRTTestRunner):
2697         (DRTTestRunner::reset):
2698         * DumpRenderTree/chromium/DRTTestRunner.h:
2699         (DRTTestRunner):
2700         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2701         (WebKit):
2702         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
2703         (WebTestRunner::WebTestRunner::audioData):
2704         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2705         (WebTestRunner::TestRunner::TestRunner):
2706         (WebTestRunner::TestRunner::reset):
2707         (WebTestRunner::TestRunner::shouldDumpAsAudio):
2708         (WebTestRunner):
2709         (WebTestRunner::TestRunner::audioData):
2710         (WebTestRunner::TestRunner::setAudioData):
2711         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2712         (TestRunner):
2713         * DumpRenderTree/chromium/TestShell.cpp:
2714         (TestShell::dump):
2715
2716 2013-01-07  Mike West  <mkwst@chromium.org>
2717
2718         Make the IFRAME_SEAMLESS flag runtime-enabled.
2719         https://bugs.webkit.org/show_bug.cgi?id=106213
2720
2721         Reviewed by Ojan Vafai.
2722
2723         * DumpRenderTree/chromium/TestShell.cpp:
2724         (TestShell::TestShell):
2725         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2726         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2727         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2728         (resetDefaultsToConsistentValues):
2729         * DumpRenderTree/mac/DumpRenderTree.mm:
2730         (resetDefaultsToConsistentValues):
2731         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2732         (WebCore::WebPage::resetSettings):
2733         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2734         (WTR::InjectedBundle::beginTesting):
2735             Ensure that seamless IFrames are enabled for layout tests in each of
2736             the ports that support seamless IFrames.
2737
2738 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
2739
2740         [chromium] move dumpAsText and friends to the TestRunner library
2741         https://bugs.webkit.org/show_bug.cgi?id=106222
2742
2743         Reviewed by Adam Barth.
2744
2745         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
2746
2747         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2748         (DRTTestRunner::DRTTestRunner):
2749         (DRTTestRunner::reset):
2750         * DumpRenderTree/chromium/DRTTestRunner.h:
2751         (DRTTestRunner):
2752         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2753         (WebTestRunner::WebTestRunner::shouldDumpAsText):
2754         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
2755         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
2756         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
2757         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
2758         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
2759         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2760         (WebTestRunner::TestRunner::TestRunner):
2761         (WebTestRunner::TestRunner::reset):
2762         (WebTestRunner::TestRunner::shouldDumpAsText):
2763         (WebTestRunner):
2764         (WebTestRunner::TestRunner::setShouldDumpAsText):
2765         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
2766         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
2767         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
2768         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
2769         (WebTestRunner::TestRunner::dumpAsText):
2770         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
2771         (WebTestRunner::TestRunner::dumpChildFramesAsText):
2772         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2773         (TestRunner):
2774
2775 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2776
2777         Build fix attempt after r138810.
2778
2779         Apparently python 2.6 is really bad at floating point computation.
2780
2781         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2782         (MainTest.test_run_memory_test):
2783
2784 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2785
2786         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
2787         https://bugs.webkit.org/show_bug.cgi?id=106172
2788
2789         Reviewed by Tony Chang.
2790
2791         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
2792         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
2793         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
2794         test on perf-o-matic and perf. test's results page.
2795
2796         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
2797
2798         * Scripts/webkitpy/performance_tests/perftest.py:
2799         (PerfTestMetric): Added.
2800         (PerfTestMetric.__init__): Added.
2801         (PerfTestMetric.metric): Added.
2802         (PerfTestMetric.has_values): Added.
2803         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
2804         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
2805         conversions to be done on the client side (perf-o-matic and results page).
2806         (PerfTestMetric.append): Added.
2807         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
2808         a result for this metric.
2809         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
2810         (PerfTestMetric.compute_statistics): Moved from PerfTest.
2811
2812         (PerfTest._create_driver): Extracted from PerfTest.run.
2813         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
2814         as needed.
2815         (PerfTest._run_with_driver):
2816         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
2817         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
2818         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
2819
2820         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
2821         from other perf tests, there isn't much point in sharing the code here.
2822
2823         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
2824         statistics for the measured values.
2825
2826         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2827         (TestPerfTestMetric): Added.
2828         (TestPerfTestMetric.test_init_set_missing_unit): Added.
2829         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
2830         (TestPerfTestMetric.test_has_values): Added.
2831         (TestPerfTestMetric.test_append): Added.
2832         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
2833         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
2834
2835         (TestPerfTest._assert_results_are_correct): Updated as needed.
2836         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
2837         in PerfTest.run now after generating the results dictionary.
2838         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
2839
2840 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
2841
2842         Support size_t multiplication and division operators on LayoutUnit
2843         https://bugs.webkit.org/show_bug.cgi?id=83848
2844
2845         Reviewed by Emil A Eklund.
2846
2847         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2848         Added some simple tests for the new operators using size_t.
2849
2850 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2851
2852         [Qt] run-webkit-tests cleanup for parallel NRWT
2853         https://bugs.webkit.org/show_bug.cgi?id=106220
2854
2855         Reviewed by Dirk Pranke.
2856
2857         * Scripts/run-webkit-tests:
2858         (useNewRunWebKitTests):
2859         * Scripts/webkitpy/layout_tests/port/qt.py:
2860         (QtPort):
2861         (QtPort.default_child_processes):
2862
2863 2013-01-07  Philippe Normand  <pnormand@igalia.com>
2864
2865         Create a GStreamerAudio watchlist and add myself to it.
2866
2867         Unreviewed.
2868
2869         * Scripts/webkitpy/common/config/watchlist:
2870
2871 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
2872
2873         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
2874         Also removed the empty mac directory.
2875
2876         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
2877         * BuildSlaveSupport/download-built-product: Added property svn:executable.
2878         * BuildSlaveSupport/mac: Removed.
2879         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
2880
2881 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
2882
2883         Add a script to delete stale zero-byte build files
2884         https://bugs.webkit.org/show_bug.cgi?id=106131
2885
2886         Reviewed by Tony Chang.
2887
2888         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
2889
2890         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2891         (DeleteStaleBuildFiles): Added.
2892         (Factory.__init__): Add DeleteStaleBuildFiles step.
2893         * BuildSlaveSupport/delete-stale-build-files: Added.
2894         (main): Delete zero-byte files except ones intentionally generated by our build process.
2895         (webkitBuildDirectory): Copied from build-product-archive.
2896
2897 2013-01-04  Michael Pruett  <michael@68k.org>
2898
2899         [GTK] Fix build error on GTK due to r138836
2900         https://bugs.webkit.org/show_bug.cgi?id=106154
2901
2902         Reviewed by Kentaro Hara.
2903
2904         * GNUmakefile.am:
2905
2906 2013-01-04  Dan Bernstein  <mitz@apple.com>
2907
2908         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
2909         https://bugs.webkit.org/show_bug.cgi?id=106121
2910
2911         Reviewed by Adele Peterson.
2912
2913         Added test for -[DOMTHMLTableCellElement _cellAbove].
2914
2915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2916         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
2917         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
2918         (TestWebKitAPI):
2919         (TestWebKitAPI::expectCellAboveCell):
2920         (TestWebKitAPI::TEST):
2921         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
2922
2923 2013-01-04  Eric Seidel  <eric@webkit.org>
2924
2925         FlakyTestReporter should be re-enabled and taught how to post patches
2926         https://bugs.webkit.org/show_bug.cgi?id=103839
2927
2928         Reviewed by Adam Barth.
2929
2930         This moves LayoutTestResultsReader off of the DeprecatedPort object.
2931         It also adds a real Port object to the EWS and CommitQueue objects
2932         using a new PatchProcessingQueue superclass.
2933         PatchProcessingQueue doesn't seem to be the cleanest insertion point
2934         but works for this purpose.
2935         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
2936         to resolve a FIXME.
2937
2938         This required some hacks/shiming between the non-specific "old"
2939         port names which the EWS system is currently using, and the new
2940         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
2941
2942         Hopefully this will fix the flaky test reporter and results uploading.
2943         Certainly it's another small step towards getting rid of the old ports.py
2944         infrastructure and making the NRWT Port class common webkitpy infrastructure.
2945
2946         Now that DeprecatedPort is no longer used for the results directory
2947         I removed all the explicit results-dir code which webkit-patch was using
2948         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
2949
2950         * Scripts/webkitpy/common/config/ports.py:
2951         (DeprecatedPort.run_perl_unittests_command):
2952         * Scripts/webkitpy/common/config/ports_mock.py:
2953         (MockPort.name):
2954         * Scripts/webkitpy/common/system/outputcapture.py:
2955         (OutputCapture.assert_outputs):
2956         * Scripts/webkitpy/layout_tests/port/apple.py:
2957         (ApplePort.determine_full_port_name):
2958         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2959         (LayoutTestResultsReader.__init__):
2960         (LayoutTestResultsReader):
2961         (LayoutTestResultsReader._read_file_contents):
2962         (LayoutTestResultsReader._create_layout_test_results):
2963         (LayoutTestResultsReader._create_unit_test_results):
2964         (LayoutTestResultsReader.results):
2965         (LayoutTestResultsReader.archive):
2966         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2967         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2968         (LayoutTestResultsReaderTest.test_create_unit_test_results):
2969         (test_missing_unit_test_results_path):
2970         (test_layout_test_results):
2971         (test_archive_last_layout_test_results):
2972         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2973         (AbstractEarlyWarningSystem):
2974         (AbstractEarlyWarningSystem.__init__):
2975         (AbstractEarlyWarningSystem.begin_work_queue):
2976         (AbstractEarlyWarningSystem.run_command):
2977         * Scripts/webkitpy/tool/commands/queues.py:
2978         (AbstractPatchQueue.work_item_log_path):
2979         (PatchProcessingQueue):
2980         (PatchProcessingQueue._new_port_name_from_old):
2981         (PatchProcessingQueue.begin_work_queue):
2982         (PatchProcessingQueue._upload_results_archive_for_patch):
2983         (CommitQueue):
2984         (CommitQueue.begin_work_queue):
2985         (CommitQueue.run_command):
2986         (AbstractReviewQueue):
2987         (AbstractReviewQueue.__init__):
2988         (AbstractReviewQueue.begin_work_queue):
2989         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2990         (AbstractPatchQueueTest.test_next_patch):
2991         (PatchProcessingQueueTest):
2992         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
2993         * Scripts/webkitpy/tool/steps/runtests.py:
2994         (RunTests.run):
2995         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2996
2997 2013-01-04  Dana Jansens  <danakj@chromium.org>
2998
2999         [chromium] Remove lost-compositor-context layout tests
3000         https://bugs.webkit.org/show_bug.cgi?id=106089
3001
3002         Reviewed by James Robinson.
3003
3004         Remove the loseCompositorContext() test function.
3005
3006         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3007         (WebTestRunner::TestRunner::TestRunner):
3008         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3009         (TestRunner):
3010
3011 2013-01-04  Adam Klein  <adamk@chromium.org>
3012
3013         Remove ENABLE_MUTATION_OBSERVERS #define
3014         https://bugs.webkit.org/show_bug.cgi?id=105459
3015
3016         Reviewed by Ryosuke Niwa.
3017
3018         * Scripts/webkitperl/FeatureList.pm:
3019         * qmake/mkspecs/features/features.pri:
3020
3021 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
3022
3023         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
3024         https://bugs.webkit.org/show_bug.cgi?id=106078
3025
3026         Reviewed by Tony Chang.
3027
3028         This patch updates values for individual iterations in dummy performance tests used in
3029         perftest_unittest.py and perftest_integrationtest.py so that they match up with
3030         statistics such as stdev and median reported in those tests. This change is required
3031         to resolve the bug 97510.
3032
3033         This patch also refactors integration tests by extracting *TestData classes that
3034         centralizes the definitions of each dummy performance test's text (DRT output),
3035         runner output, and parsed results (JSON) so that we may share more data between
3036         python tests.
3037
3038         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3039         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
3040         Use self.assertAlmostEqual when comparing the standard deviation.
3041         (MainTest.test_parse_output):
3042         (test_parse_output_with_failing_line):
3043         (test_parse_output_with_description): Use _assert_results_are_correct.
3044         (test_parse_output_with_subtests): Ditto.
3045
3046         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3047         (InspectorPassTestData): Extracted from tests below.
3048         (EventTargetWrapperTestData): Ditto.
3049         (SomeParserTestData): Ditto.
3050         (MemoryTestData): Ditto.
3051         (TestDriver.run_test): Moved test definitions out of the method.
3052         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
3053         (MainTest._load_output_json): Extracted from create_runner.
3054         (MainTest.create_runner):
3055         (MainTest.test_run_test_set_for_parser_tests):
3056         (MainTest.test_run_memory_test):
3057         (MainTest._test_run_with_json_output):
3058         (MainTest.test_run_with_json_output):
3059         (MainTest.test_run_with_description):
3060         (MainTest.test_run_generates_json_by_default):
3061         (MainTest.test_run_merges_output_by_default):
3062         (MainTest.test_run_respects_reset_results):
3063         (MainTest.test_run_generates_and_show_results_page):
3064         (MainTest.test_run_with_slave_config_json):
3065         (MainTest.test_run_with_multiple_repositories):
3066
3067 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
3068
3069         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
3070         https://bugs.webkit.org/show_bug.cgi?id=106045
3071
3072         Reviewed by Carlos Garcia Campos.
3073
3074         Update test results to confirm that compositions without preedits do not trigger
3075         a composition confirmation.
3076
3077         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
3078         (TestWebKitAPI::verifyCanceledComposition):
3079
3080 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
3081
3082         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
3083         https://bugs.webkit.org/show_bug.cgi?id=105958
3084
3085         Reviewed by Alexey Proskuryakov.
3086
3087         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
3088
3089         * WebKitTestRunner/mac/EventSenderProxy.mm:
3090         (KeyMappingEntry):
3091         (WTR):
3092         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
3093
3094 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
3095
3096         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
3097         https://bugs.webkit.org/show_bug.cgi?id=106073
3098
3099         Reviewed by Ryosuke Niwa.
3100
3101         Check that the element being compared to is not nil. 
3102         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
3103         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
3104         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
3105         sometimes before on parallel WebKitTestRunner runs.
3106
3107         * DumpRenderTree/AccessibilityUIElement.cpp:
3108         (AccessibilityUIElement::isEqual):
3109         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3110         (WTR::AccessibilityUIElement::isEqual):
3111
3112 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
3113
3114         Downloads can be flaky, so try downloading multiple times.
3115         https://bugs.webkit.org/show_bug.cgi?id=105976
3116
3117         Reviewed by Eric Seidel.
3118
3119         * Scripts/webkitpy/common/system/autoinstall.py:
3120         (AutoInstaller._download_to_stream):
3121
3122 2013-01-03  Eric Seidel  <eric@webkit.org>
3123
3124         Rename Tool.port to deprecated_port in preparation for removing more callers
3125         https://bugs.webkit.org/show_bug.cgi?id=106076
3126
3127         Reviewed by Ryosuke Niwa.
3128
3129         This resolves a long-standing FIXME to rename this method. :)
3130
3131         * Scripts/webkitpy/tool/bot/botinfo.py:
3132         (BotInfo.summary_text):
3133         * Scripts/webkitpy/tool/bot/irc_command.py:
3134         (Rollout._update_working_copy):
3135         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3136         (LayoutTestResultsReader._create_layout_test_results):
3137         (LayoutTestResultsReader._create_unit_test_results):
3138         (LayoutTestResultsReader._results_directory):
3139         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3140         (test_missing_unit_test_results_path):
3141         * Scripts/webkitpy/tool/main.py:
3142         (WebKitPatch.deprecated_port):
3143         * Scripts/webkitpy/tool/mocktool.py:
3144         (MockTool.deprecated_port):
3145         * Scripts/webkitpy/tool/steps/build.py:
3146         (Build.build):
3147         * Scripts/webkitpy/tool/steps/checkstyle.py:
3148         (CheckStyle.run):
3149         * Scripts/webkitpy/tool/steps/commit.py:
3150         (Commit._check_test_expectations):
3151         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3152         (PrepareChangeLog.run):
3153         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
3154         (PrepareChangeLogForDEPSRoll.run):
3155         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3156         (PrepareChangeLogForRevert.run):
3157         * Scripts/webkitpy/tool/steps/runtests.py:
3158         (RunTests.run):
3159         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3160         (StepsTest.test_runtests_args):
3161         * Scripts/webkitpy/tool/steps/update.py:
3162         (Update._update_command):
3163
3164 2013-01-03  Eric Seidel  <eric@webkit.org>
3165
3166         Add myself to the webkitpy watchlist.
3167
3168         Unreviewed.
3169
3170         * Scripts/webkitpy/common/config/watchlist:
3171
3172 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3173
3174         Cleanup perftest* tests and add a test for computing statistics
3175         https://bugs.webkit.org/show_bug.cgi?id=105685
3176
3177         Reviewed by Eric Seidel.
3178
3179         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
3180         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
3181
3182         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
3183
3184         * Scripts/webkitpy/performance_tests/perftest.py:
3185         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
3186         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
3187         accurate result for the mean.
3188         (PageLoadingPerfTest.run_single):
3189         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3190         (MainTest.test_compute_statistics):
3191         (MainTest.test_compute_statistics.compute_statistics): Added.
3192         (TestPageLoadingPerfTest.test_run): floatify values.
3193         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
3194         correctly recognizes them as integers.
3195
3196         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
3197         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
3198         (TestDriver): Moved out of MainTest.
3199         (MainTest): Got rid of assertWritten and all unit tests.
3200         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
3201         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
3202         (MainTest.test_run_test_set_for_parser_tests):
3203         (MainTest.test_run_memory_test):
3204         (MainTest._test_run_with_json_output):
3205         (MainTest.test_run_generates_json_by_default):
3206         (MainTest.test_run_merges_output_by_default):
3207         (MainTest.test_run_respects_reset_results):
3208         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
3209         parsing output JSON files. Just verify that the output path is correct instead.
3210         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3211         (MainTest): Removed all integration tests.
3212         (MainTest.create_runner): Simplified.
3213
3214 2013-01-03  Julie Parent  <jparent@chromium.org>
3215
3216         Dashboard cleanup: remove usage of global g_defaultBuilderName
3217         https://bugs.webkit.org/show_bug.cgi?id=106043
3218
3219         Use now public defaultBuilder() from the BuilderGroup, rather
3220         than global variable.
3221
3222         Also eliminates the setup() and initBuilders() functions since we
3223         no longer need to track the global.
3224
3225         Reviewed by Adam Barth.
3226
3227         * TestResultServer/static-dashboards/builders.js:
3228         (BuilderGroup.prototype.defaultBuilder):
3229         (BuilderGroup.prototype.master):
3230         * TestResultServer/static-dashboards/dashboard_base.js:
3231         (parseParameters):
3232         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3233         (updateDefaultBuilderState):
3234         * TestResultServer/static-dashboards/loader.js:
3235         (.):
3236         * TestResultServer/static-dashboards/loader_unittests.js:
3237
3238 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3239
3240         Disable an intermittently failing unit test for now.
3241         The failure is tracked by the bug 106051.
3242
3243         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
3244         (TestWebKitAPI::TEST):
3245
3246 2013-01-03  Dan Bernstein  <mitz@apple.com>
3247
3248         No way to obtain a DOMNode given a JS wrapper for a Node
3249         https://bugs.webkit.org/show_bug.cgi?id=106033
3250
3251         Added a test for +[DOMNode _nodeFromJSWrapper:].
3252
3253         Reviewed by Sam Weinig.
3254
3255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3256         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
3257         (TestWebKitAPI):
3258         (TestWebKitAPI::TEST):
3259
3260 2013-01-03  Emil A Eklund  <eae@chromium.org>
3261
3262         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
3263         https://bugs.webkit.org/show_bug.cgi?id=105961
3264
3265         Reviewed by Levi Weintraub.
3266         
3267         Add tests for LayoutUnit::ceil and floor.
3268
3269         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3270         (TestWebKitAPI::TEST):
3271         (TestWebKitAPI):
3272
3273 2013-01-03  Julie Parent  <jparent@chromium.org>
3274
3275         Add unit test for default builder for the dashboards.
3276         https://bugs.webkit.org/show_bug.cgi?id=105972
3277
3278         Reviewed by Dirk Pranke.
3279
3280         * TestResultServer/static-dashboards/loader_unittests.js:
3281
3282 2013-01-03  Tony Chang  <tony@chromium.org>
3283
3284         Generate internal.settings from Settings.in
3285         https://bugs.webkit.org/show_bug.cgi?id=104740
3286
3287         Reviewed by Adam Barth.
3288
3289         * GNUmakefile.am: Compile new generated files on GTK+.
3290         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
3291         with both extra_sources and add_output_to_sources=false will still
3292         compile the files in extra_sources. This makes it possible to compile
3293         InternalSettingsGenerated.cpp and not be confused by
3294         InternalSettingsGenerated.idl.
3295
3296 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
3297
3298         [style] WebIDL-reflecting uppercase enums reported as style violation
3299         https://bugs.webkit.org/show_bug.cgi?id=105832
3300
3301         Reviewed by Tony Chang.
3302
3303         Recognize the enum as WebIDL-reflecting one if there's a comment present that
3304         indicates this. In enums spanning over multiple lines, the comment is expected
3305         on the first line. In enums placed in one line, the comment is expected at the
3306         end of that line.
3307
3308         WebIDL-reflecting enum values are required to be written in uppercase and as such
3309         violate the common rule of these values being written in InterCaps. Annotating
3310         enums this way makes it possible to avoid false style violation reports.
3311
3312         The comment is of form '// Web(?:Kit)?IDL enum'.
3313
3314         * Scripts/webkitpy/style/checkers/cpp.py:
3315         (_EnumState.__init__):
3316         (_EnumState.process_clean_line):
3317         (check_enum_casing):
3318         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3319         (NoNonVirtualDestructorsTest.test_enum_casing):
3320
3321 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
3322
3323         Adding favicon.ico to the garden-o-matic.
3324         https://bugs.webkit.org/show_bug.cgi?id=105982
3325
3326         Reviewed by Adam Barth.
3327
3328         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3329         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
3330
3331 2013-01-03  Jonathan Liu  <net147@gmail.com>
3332
3333         [Qt] Fix library linking order
3334         https://bugs.webkit.org/show_bug.cgi?id=105818
3335
3336         Some Qt libraries are linked before the private static libraries
3337         that depend on them which results in QtWebKit failing to link.
3338
3339         Copy Qt module dependencies from QT to QT_PRIVATE when creating
3340         module to ensure the Qt libraries are linked after the private
3341         static libraries that depend on them.
3342
3343         Reviewed by Tor Arne Vestbø.
3344
3345         * qmake/mkspecs/features/default_post.prf:
3346
3347 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
3348
3349         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
3350         https://bugs.webkit.org/show_bug.cgi?id=102209
3351
3352         Reviewed by Gyuyoung Kim.
3353
3354         Set tooltip on the elm_window instead of ewk_view, and add delay to
3355         show the tooltip window.
3356
3357         Setting tooltip on the ewk_view makes elementary error message because
3358         ewk_view is not an elementary widget. To remove the error message,
3359         tooltip should be set on the elm_window.
3360
3361         Most browsers show the tooltip after a mouse pointer stays on an
3362         element object that has tooltip text.
3363         But elm_tooltip widget itself doesn't have delay or handle mouse
3364         events to show/hide.
3365
3366         So additional codes are added to show/hide tooltip widget along with
3367         mouse events.
3368           1) When a mouse pointer stays for a second on an element which has
3369              tooltip text, then tooltip widget is displayed.
3370           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
3371              widget.
3372
3373         * MiniBrowser/efl/main.c:
3374         (_Tooltip_Information):
3375         (_Browser_Window):
3376         (on_tooltip_show):
3377         (window_tooltip_hide):
3378         (window_tooltip_update):
3379         (on_mouse_in):
3380         (on_mouse_move):
3381         (on_mouse_out):
3382         (window_free):
3383         (on_tooltip_text_set):
3384         (on_tooltip_text_unset):
3385         (window_create):
3386
3387 2013-01-02  Tony Chang  <tony@chromium.org>
3388
3389         Unreviewed, rolling out r138661.
3390         http://trac.webkit.org/changeset/138661
3391         https://bugs.webkit.org/show_bug.cgi?id=104740
3392
3393         Compile problems on EFL
3394
3395         * GNUmakefile.am:
3396         * qmake/mkspecs/features/default_post.prf:
3397
3398 2013-01-02  Tony Chang  <tony@chromium.org>
3399
3400         Generate internal.settings from Settings.in
3401         https://bugs.webkit.org/show_bug.cgi?id=104740
3402
3403         Reviewed by Adam Barth.
3404
3405         * GNUmakefile.am: Compile new generated files on GTK+.
3406         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
3407         with both extra_sources and add_output_to_sources=false will still
3408         compile the files in extra_sources. This makes it possible to compile
3409         InternalSettingsGenerated.cpp and not be confused by
3410         InternalSettingsGenerated.idl.
3411
3412 2013-01-02  Adam Barth  <abarth@webkit.org>
3413
3414         Remove old-run-webkit-tests support from webkitpy
3415         https://bugs.webkit.org/show_bug.cgi?id=105619
3416
3417         Reviewed by Eric Seidel.
3418
3419         This patch removes support for webkitpy parsing the
3420         old-run-webkit-tests results format. There doesn't seem to be any
3421         reason to keep this code around anymore now that most bots have
3422         switched to new-run-webkit-tests.
3423
3424         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3425         (Builder.fetch_layout_test_results):
3426         * Scripts/webkitpy/common/net/layouttestresults.py:
3427         (path_for_layout_test):
3428         (LayoutTestResults.results_from_string):
3429         (LayoutTestResults):
3430         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3431         (LayoutTestResultsTest.test_results_from_string):
3432         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3433         (test_flaky_test_failure):
3434         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3435         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
3436         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3437         (PatchAnalysisTask._test_patch):
3438         * Scripts/webkitpy/tool/commands/queuestest.py:
3439         (QueuesTest.assert_queue_outputs):
3440
3441 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
3442
3443         [Qt][WK2] Add simple UI to find text from page
3444         https://bugs.webkit.org/show_bug.cgi?id=96481
3445
3446         Reviewed by Jocelyn Turcotte.
3447
3448         Find bar that slides between navigation bar and WebView.
3449
3450         * MiniBrowser/qt/BrowserWindow.cpp:
3451         (BrowserWindow::toggleFind):
3452         * MiniBrowser/qt/BrowserWindow.h:
3453         (BrowserWindow):
3454         * MiniBrowser/qt/MiniBrowser.qrc:
3455         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3456         (MiniBrowserApplication::notify):
3457         * MiniBrowser/qt/icons/find.png: Added.
3458         * MiniBrowser/qt/qml/BrowserWindow.qml:
3459
3460 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
3461
3462         Regression(r138603): Caused 2 webkitpy tests to fail
3463         https://bugs.webkit.org/show_bug.cgi?id=105913
3464
3465         Reviewed by Kentaro Hara.
3466
3467         Fix 2 webkitpy tests that started to fail after
3468         r138603.
3469
3470         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3471         (IRCCommandTest._sheriff_test_data_url): Make sure the
3472         returned test file URL is valid no matter what the
3473         current working directory is.
3474         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3475         (IRCBotTest.test_help): Add "sheriffs" command to the
3476         list of available commands.
3477
3478 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
3479
3480         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
3481         https://bugs.webkit.org/show_bug.cgi?id=105897
3482
3483         Reviewed by Alexey Proskuryakov.
3484
3485         Dump in WebKitTestRunner the message that is expected by layout tests
3486         when the missing plugin button is clicked.
3487
3488         * WebKitTestRunner/TestController.cpp:
3489         (WTR::TestController::createWebViewWithOptions):
3490         (WTR::TestController::unavailablePluginButtonClicked):
3491         (WTR):
3492         * WebKitTestRunner/TestController.h:
3493         (TestController):
3494
3495 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
3496
3497         [EFL] Enable MHTML feature
3498         https://bugs.webkit.org/show_bug.cgi?id=105815
3499
3500         Reviewed by Laszlo Gombos.
3501
3502         Enable MHTML feature for EFL port by default.
3503
3504         * Scripts/webkitperl/FeatureList.pm:
3505
3506 2013-01-01  Alan Cutter  <alancutter@chromium.org>
3507
3508         sheriff-bot should know who the gardeners/sheriffs are
3509         https://bugs.webkit.org/show_bug.cgi?id=105698
3510
3511         Reviewed by Eric Seidel.
3512
3513         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
3514
3515         * Scripts/webkitpy/tool/bot/irc_command.py:
3516         (Current):
3517         (Current._retrieve_webkit_sheriffs):
3518         (Current.execute):
3519         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3520         (IRCCommandTest.test_current):
3521         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
3522         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
3523         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
3524         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
3525         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
3526
3527 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3528
3529         [GTK] Move ImageDiff to the Tools directory root
3530         https://bugs.webkit.org/show_bug.cgi?id=105421
3531
3532         Reviewed by Kenneth Rohde Christiansen.
3533
3534         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
3535         * GNUmakefile.am:
3536         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
3537
3538 2012-12-30  Mike West  <mkwst@chromium.org>
3539
3540         Add myself to watchlists for CSP and console logs.
3541         https://bugs.webkit.org/show_bug.cgi?id=105874
3542
3543         Reviewed by Dirk Pranke.
3544
3545         Because I really, really, really need more email.
3546
3547         * Scripts/webkitpy/common/config/committers.py:
3548             Add mkwst+watchlist@chromium.org as a contributor.
3549         * Scripts/webkitpy/common/config/watchlist:
3550             Create watchlist categories for 1) the various mechanisms used to
3551             generate console messages, and 2) CSP usage and files.
3552
3553 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3554
3555         [EFL] Enable TEMPLATE_ELEMENT feature
3556         https://bugs.webkit.org/show_bug.cgi?id=105865
3557         
3558         Reviewed by Laszlo Gombos.
3559
3560         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
3561
3562 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
3563
3564         Unreviewed GTK gardening of the unit tests.
3565
3566         Skip the TestInspectorServer unit test that's timing out completely.
3567
3568         * Scripts/run-gtk-tests:
3569         (TestRunner):
3570
3571 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
3572
3573         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
3574         https://bugs.webkit.org/show_bug.cgi?id=105855
3575
3576         Reviewed by Vsevolod Vlasov.
3577
3578         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
3579         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
3580
3581         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3582         (ReportMemoryUsageVisitor):
3583         (clang::AddMemberCallVisitor::VisitCallExpr):
3584         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
3585         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
3586
3587 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
3588
3589         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
3590         https://bugs.webkit.org/show_bug.cgi?id=105852
3591
3592         Reviewed by Alexander Pavlov.
3593
3594         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3595         (clang):
3596         (AddMemberCallVisitor):
3597         (ReportMemoryUsageVisitor):
3598         (clang::ReportMemoryUsageAction::ParseArgs):
3599         (clang::AddMemberCallVisitor::VisitCallExpr):
3600         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
3601         (clang::ReportMemoryUsageVisitor::emitWarning):
3602         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
3603         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
3604         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
3605
3606 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
3607
3608         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
3609         https://bugs.webkit.org/show_bug.cgi?id=105835
3610
3611         Reviewed by Dirk Pranke.
3612
3613         The BeautifulSoup module is a third-party import and as such we don't have much control
3614         over its testing. Because of that it should be omitted from code coverage checking.
3615
3616         * Scripts/webkitpy/test/main.py:
3617         (Tester._run_tests):
3618
3619 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
3620
3621         [GTK][WK2] Add support for IME Composition
3622         https://bugs.webkit.org/show_bug.cgi?id=65093
3623
3624         Reviewed by Carlos Garcia Campos.
3625
3626         Update unit tests for GtkInputMethodFilter to note whether or not an event
3627         was a fake event synthesized for composition purposes. This is now used
3628         for WebKit2.
3629
3630         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
3631         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
3632         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
3633         (TestWebKitAPI::TEST):
3634         * gtk/generate-gtkdoc:
3635         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
3636         generation.
3637
3638 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
3639
3640         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
3641         https://bugs.webkit.org/show_bug.cgi?id=105800</