ASSERTION FAILED: registration || isTerminating() in WebCore::SWServerWorker::skipWai...
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2
3         History state should be updated during client redirects with asynchronous policy decisions
4         https://bugs.webkit.org/show_bug.cgi?id=181358
5         <rdar://problem/35547689>
6
7         Reviewed by Andy Estes.
8
9         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
10         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
11         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
12         (TEST):
13
14 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
15
16         webkitpy: Refactor simulator code (Part 4)
17         https://bugs.webkit.org/show_bug.cgi?id=180555
18         <rdar://problem/36131381>
19
20         Reviewed by Aakash Jain.
21
22         Move new_simulated_device.py to simulated_device.py.
23
24         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
25         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
26         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
27         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
28         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
29
30 2018-01-12  Alex Christensen  <achristensen@webkit.org>
31
32         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
33         https://bugs.webkit.org/show_bug.cgi?id=181595
34
35         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
36         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
37         I change the < and > to $ to make this test pass and continue to test what it used to.
38
39         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
40         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
41         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
42
43 2018-01-11  Keith Miller  <keith_miller@apple.com>
44
45         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
46         https://bugs.webkit.org/show_bug.cgi?id=181573
47
48         Reviewed by Simon Fraser.
49
50         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
51
52 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
53
54         [WebAuthN] Import a CBOR coder from Chromium
55         https://bugs.webkit.org/show_bug.cgi?id=181522
56         <rdar://problem/36055729>
57
58         Reviewed by Brent Fulgham.
59
60         This patch also imports all unit tests into our API tests to ensure all
61         workarounds and modification against the original codebase doesn't change
62         any original functionalities.
63
64         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
65         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
66         (TestWebKitAPI::TEST):
67         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
68         (TestWebKitAPI::TEST):
69         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
70         (TestWebKitAPI::eq):
71         Workarounds applied.
72         (TestWebKitAPI::TEST):
73
74 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
75
76         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
77         https://bugs.webkit.org/show_bug.cgi?id=181538
78         <rdar://problem/36440580>
79
80         Reviewed by Aakash Jain.
81
82         When disambiguating a device type, it is possible that the provided device type is sufficiently
83         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
84         will result in a failure to disambiguate the type.
85
86         * Scripts/webkitpy/xcode/new_simulated_device.py:
87         (SimulatedDeviceManager._disambiguate_device_type):
88
89 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
90
91         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
92         https://bugs.webkit.org/show_bug.cgi?id=181136
93         <rdar://problem/36116604>
94
95         Reviewed by Chris Dumez.
96
97         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
98         browsing sessions.
99
100         * Scripts/run-gtk-tests:
101         (GtkTestRunner): Unskip test now that it passes.
102         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
103         (TEST): Add new WebsiteDataStoreEphemeral test.
104
105 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
106
107         Unreviewed, rolling out r226816.
108
109         This change broke LayoutTests on the bots.
110
111         Reverted changeset:
112
113         "run-webkit-tests fails when there is a curly brace in Xcode
114         build output"
115         https://bugs.webkit.org/show_bug.cgi?id=181254
116         https://trac.webkit.org/changeset/226816
117
118 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
119
120         webkitpy: Fix flakey webserver tests
121         https://bugs.webkit.org/show_bug.cgi?id=181555
122         <rdar://problem/36448273>
123
124         Reviewed by Aakash Jain.
125
126         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
127         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
128         determine if a specific server is running.
129
130 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
131
132         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
133         https://bugs.webkit.org/show_bug.cgi?id=181561
134         <rdar://problem/36452652>
135
136         Reviewed by Aakash Jain.
137
138         BeautifulSoup.find may return None, this case should be gracefully handled.
139
140         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
141         (BugzillaQueries._parse_result_count):
142         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
143
144 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
145
146         run-webkit-tests fails when there is a curly brace in Xcode build output
147         https://bugs.webkit.org/show_bug.cgi?id=181254
148
149         Reviewed by Daniel Bates.
150
151         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
152         (MeteredStream.write):
153
154 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
155
156         webkitpy: Reimplement simulator code (Part 3)
157         https://bugs.webkit.org/show_bug.cgi?id=180555
158         <rdar://problem/36131381>
159
160         Reviewed by Aakash Jain.
161
162         Remove old simulator code.
163
164         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
165         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
166         * Scripts/webkitpy/xcode/simulator.py: Removed.
167         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
168
169 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
170
171         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
172         https://bugs.webkit.org/show_bug.cgi?id=181337
173         <rdar://problem/36324813>
174
175         Reviewed by Tim Horton.
176
177         Add 3 new API tests for attachment element dragging.
178
179         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
180         (-[TestWKWebView expectElementTag:toComeBefore:]):
181         (-[NSItemProvider expectType:withData:]):
182         (TestWebKitAPI::TEST):
183
184 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
185
186         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
187         https://bugs.webkit.org/show_bug.cgi?id=179621
188         <rdar://problem/35589585>
189
190         Unreviewed infrastructure fix.
191
192         * Scripts/webkitpy/port/mac.py:
193         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
194         list if we are the VERSION_MAX, which usually corresponds with future.
195
196 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
197
198         CodeBlocks should be in IsoSubspaces
199         https://bugs.webkit.org/show_bug.cgi?id=180884
200
201         Reviewed by Saam Barati.
202         
203         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
204         shouldn't take a long time due to benchmarks we don't optimize for.
205         
206         * Scripts/run-jsc-benchmarks:
207
208 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
209
210         Test gardening for GTK.
211         https://bugs.webkit.org/show_bug.cgi?id=181477
212
213         Unreviewed test gardening.
214
215         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
216         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
217
218 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
219
220         Add the new JSCOnly bot to the scheduler.
221         https://bugs.webkit.org/show_bug.cgi?id=181487
222
223         Unreviewed follow-up patch after r226729
224
225         On r226729 I missed to add the new JSCOnly bot the default scheduler.
226         This is needed to make the bot automatically pick each commit for testing.
227
228         * BuildSlaveSupport/build.webkit.org-config/config.json:
229
230 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
231
232         [Attachment Support] Support dragging attachment elements out as files on iOS
233         https://bugs.webkit.org/show_bug.cgi?id=181199
234         <rdar://problem/36299316>
235
236         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
237
238         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
239         attachment API tests.
240
241         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
242         (-[NSItemProvider expectType:withData:]):
243         (TestWebKitAPI::TEST):
244
245         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
246         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
247         -expectType:withData: helper to inspect the item providers created from the drag source.
248
249         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
250         (TestWebKitAPI::TEST):
251         * TestWebKitAPI/ios/DataInteractionSimulator.h:
252         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
253         (-[MockDragSession localContext]):
254         (-[MockDragSession setLocalContext:]):
255         (-[DataInteractionSimulator _resetSimulatedState]):
256         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
257         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
258         (-[DataInteractionSimulator _advanceProgress]):
259         (-[DataInteractionSimulator endDataTransfer]):
260
261         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
262         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
263         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
264         MockDragSession to hold on to a localContext.
265
266 2018-01-11  Ali Juma  <ajuma@chromium.org>
267
268         Unreviewed. Add Ali Juma as contributor
269
270         * Scripts/webkitpy/common/config/contributors.json:
271
272 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
273
274         Unreviewed. Update Selenium WebDriver imported tests.
275
276         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
277         environment variables.
278
279         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
280         (collect): Reorder the arguments to make pytest happy.
281         (run): Ditto.
282         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
283         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
284
285 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
286
287         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
288         https://bugs.webkit.org/show_bug.cgi?id=181492
289         <rdar://problem/36359679>
290
291         Reviewed by Alexey Proskuryakov. 
292
293 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
294
295         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
296         https://bugs.webkit.org/show_bug.cgi?id=181475
297
298         Reviewed by Michael Catanzaro.
299
300         * gtk/install-dependencies: Update package list for Arch Linux, extend
301         message shown at end of installation with additional tips.
302
303 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
304
305         REGRESSION(r222507): Composition highlight doesn't render when using IME
306         https://bugs.webkit.org/show_bug.cgi?id=181485
307         <rdar://problem/35896516>
308
309         Reviewed by Ryosuke Niwa.
310
311         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
312         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
313         allow rendering composition backgrounds (see InlineTextBox::paint).
314
315         * DumpRenderTree/ios/TextInputControllerIOS.m:
316         (+[TextInputController isSelectorExcludedFromWebScript:]):
317         (+[TextInputController webScriptNameForSelector:]):
318         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
319         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
320         * DumpRenderTree/mac/TextInputControllerMac.m:
321         (+[TextInputController isSelectorExcludedFromWebScript:]):
322         (+[TextInputController webScriptNameForSelector:]):
323         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
324         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
325         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
326         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
327         (WTR::TextInputController::setMarkedText):
328         * WebKitTestRunner/InjectedBundle/TextInputController.h:
329
330 2018-01-10  JF Bastien  <jfbastien@apple.com>
331
332         Poison small JSObject derivatives which only contain pointers
333         https://bugs.webkit.org/show_bug.cgi?id=181483
334         <rdar://problem/36407127>
335
336         Reviewed by Mark Lam.
337
338         Test the new move-assign and move-copy from unique_ptr, as well as
339         nullptr_t ctors.
340
341         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
342         (TestWebKitAPI::TEST):
343         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
344         (TestWebKitAPI::TEST):
345         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
346         (TestWebKitAPI::TEST):
347
348 2018-01-10  Chris Dumez  <cdumez@apple.com>
349
350         Multiple http/wpt/beacon/contentextensions/ test are flaky.
351         https://bugs.webkit.org/show_bug.cgi?id=179256
352         <rdar://problem/35401978>
353
354         Reviewed by Alex Christensen.
355
356         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
357         instance gets its own folder to avoid conflicts and flakiness.
358
359         * WebKitTestRunner/mac/TestControllerMac.mm:
360         (WTR::TestController::platformConfigureViewForTest):
361
362 2018-01-10  Tim Horton  <timothy_horton@apple.com>
363
364         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
365         https://bugs.webkit.org/show_bug.cgi?id=181269
366         <rdar://problem/35110344>
367
368         Reviewed by Simon Fraser.
369
370         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
371         (WTR::UIScriptController::beginBackSwipe):
372         (WTR::UIScriptController::completeBackSwipe):
373         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
374         (WTR::UIScriptController::beginBackSwipe):
375         (WTR::UIScriptController::completeBackSwipe):
376         (WTR::UIScriptController::overridePreference):
377         (WTR::UIScriptController::replaceTextAtRange):
378         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
379         (WTR::PlatformWebView::setNavigationGesturesEnabled):
380         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
381         (WTR::UIScriptController::beginBackSwipe):
382         (WTR::UIScriptController::completeBackSwipe):
383         Implement beginBackSwipe and completeBackSwipe on iOS (they already
384         exist on Mac) in terms of the new WKWebView testing SPI.
385
386 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
387
388         REGRESSION (r226715): ignore WARNING output in linter tests
389         https://bugs.webkit.org/show_bug.cgi?id=181486
390         <rdar://problem/36408847>
391
392         Reviewed by Aakash Jain.
393
394         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
395
396         * Scripts/webkitpy/common/system/outputcapture.py:
397         (OutputCapture.__init__): Pass logging level to be captured.
398         * Scripts/webkitpy/style/main_unittest.py:
399         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
400         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
401         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
402         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
403         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
404         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
405         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
406         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
407
408 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
409
410         Add a JSCOnly MIPS buildbot
411         https://bugs.webkit.org/show_bug.cgi?id=181487
412
413         Reviewed by Michael Catanzaro.
414
415         Add the new bot configs definitions for the master and update the unit tests.
416
417         * BuildSlaveSupport/build.webkit.org-config/config.json:
418         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
419
420 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
421
422         REGRESSION (r226715): don't re-check number of simulators in child processes
423         https://bugs.webkit.org/show_bug.cgi?id=181484
424         <rdar://problem/36407151>
425
426         Reviewed by Aakash Jain.
427
428         * Scripts/webkitpy/port/ios_simulator.py:
429         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
430         are already initialized.
431
432 2018-01-10  Commit Queue  <commit-queue@webkit.org>
433
434         Unreviewed, rolling out r226667 and r226673.
435         https://bugs.webkit.org/show_bug.cgi?id=181488
436
437         This caused a flaky crash. (Requested by mlewis13 on #webkit).
438
439         Reverted changesets:
440
441         "CodeBlocks should be in IsoSubspaces"
442         https://bugs.webkit.org/show_bug.cgi?id=180884
443         https://trac.webkit.org/changeset/226667
444
445         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
446         https://bugs.webkit.org/show_bug.cgi?id=180884
447         https://trac.webkit.org/changeset/226673
448
449 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
450
451         Follow-up fix to r226715
452         https://bugs.webkit.org/show_bug.cgi?id=180555
453         <rdar://problem/36131381>
454
455         Unreviewed infrastructure fix.
456
457         * Scripts/webkitpy/xcode/new_simulated_device.py:
458         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
459         of delete.
460
461 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
462
463         webkitpy: Refactor simulator code (Part 2)
464         https://bugs.webkit.org/show_bug.cgi?id=180555
465         <rdar://problem/36131381>
466
467         Reviewed by Aakash Jain.
468
469         The patch leverages the SimulatedDeviceManager when running layout tests.
470         This patch is primarily code removal, since much of the IOSSimulatorPort
471         was dedicated to managing simulators. The removed code is either now owned by the
472         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
473         boot multiple simulators which was made obsolete in Xcode 9.
474
475         * Scripts/webkitpy/layout_tests/controllers/manager.py:
476         (Manager._custom_device_for_test.in): Device names now have spaces in them,
477         strip those spaces.
478         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
479         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
480         * Scripts/webkitpy/port/ios.py:
481         (IOSPort.__init__): The _current_device idiom is no longer required since the
482         SimulatedDeviceManager keeps track of any previously booted devices.
483         (IOSPort.target_host): Even when only a single device is used, it will be accessed
484         through the array of managed devices.
485         (IOSPort.using_multiple_devices): Deleted.
486         * Scripts/webkitpy/port/ios_device.py:
487         (IOSDevicePort.using_multiple_devices): Deleted.
488         * Scripts/webkitpy/port/ios_simulator.py:
489         (IOSSimulatorPort): Remove constants required to manage simulators, change device
490         class strings so they can be parsed by the DeviceType class.
491         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
492         the number of simulators currently booted, the number of child processes specified
493         and the maximum number of simulators supported by this system.
494         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
495         devices owned by the SimulatedDeviceManager.
496         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
497         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
498         the maximum number of supported simulators on this system.
499         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
500         request for each child process and send this list to the SimulatedDeviceManager to
501         initialize the devices.
502         (IOSSimulatorPort.clean_up_test_run):
503         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
504         specified version of iOS.
505         (IOSSimulatorPort.reset_preferences):
506         (IOSSimulatorPort.simulator_runtime): Deleted.
507         (IOSSimulatorPort.simulator_device_type): Deleted.
508         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
509         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
510         (IOSSimulatorPort._create_simulators): Deleted.
511         (IOSSimulatorPort._quit_ios_simulator): Deleted.
512         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
513         (IOSSimulatorPort.using_multiple_devices): Deleted.
514         (IOSSimulatorPort._create_device): Deleted.
515         (IOSSimulatorPort.get_simulator_path): Deleted.
516         (IOSSimulatorPort._createSimulatorApps): Deleted.
517         (IOSSimulatorPort._createSimulatorApp): Deleted.
518         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
519         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
520         maximum number of simulators run on this system.
521         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
522         * Scripts/webkitpy/xcode/new_simulated_device.py:
523         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
524
525 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
526
527         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
528         https://bugs.webkit.org/show_bug.cgi?id=181474
529
530         Reviewed by Carlos Alberto Lopez Perez.
531
532         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
533         name as the name.
534
535         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
536         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
537         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
538
539 2018-01-09  Andy Estes  <aestes@apple.com>
540
541         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
542         https://bugs.webkit.org/show_bug.cgi?id=181459
543
544         Reviewed by Dan Bernstein.
545
546         * ImageDiff/cg/Configurations/Base.xcconfig:
547
548 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
549
550         font-display:fallback can cause a visual flash (which is supposed to be impossible)
551         https://bugs.webkit.org/show_bug.cgi?id=181374
552
553         Reviewed by Simon Fraser.
554
555         The test requires Palatino.
556
557         * DumpRenderTree/mac/DumpRenderTree.mm:
558         (allowedFontFamilySet):
559         * WebKitTestRunner/mac/TestControllerMac.mm:
560         (WTR::allowedFontFamilySet):
561
562 2018-01-09  Saam Barati  <sbarati@apple.com>
563
564         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
565         https://bugs.webkit.org/show_bug.cgi?id=181449
566
567         Reviewed by JF Bastien.
568
569         This allows me to Cmd+f in my terminal to search for things without
570         having the results become misaligned.
571
572         * Scripts/display-profiler-output:
573
574 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
575
576         [webkitpy] PlatformInfo should have default argument for casual use
577         https://bugs.webkit.org/show_bug.cgi?id=180827
578
579         Reviewed by David Kilzer.
580
581         PlatformInfo should be the only way to check platform specific thing instead
582         of sys.platform or other various checks. If there is something you want to check,
583         it should be placed in PlatformInfo.
584
585         Currently to instantiate PlatformInfo, it requires arguments, which is usually
586         sys, platform and Executive(). They are straight forward and should be handled
587         by default arguments. Then we can instantiate PlatformInfo more casual.
588
589         * Scripts/webkitpy/common/system/platforminfo.py:
590         (PlatformInfo): Use relative module path import
591         (PlatformInfo.__init__):
592         (PlatformInfo.executive): Lazy instantiation of Executive()
593         (PlatformInfo.total_bytes_memory): Accessing via above property
594         (PlatformInfo.xcode_sdk_version): Ditto
595         (PlatformInfo.xcode_simctl_list): Ditto
596         (PlatformInfo.xcode_version): Ditto
597         (PlatformInfo._win_version_str): Ditto
598         * Scripts/webkitpy/common/system/systemhost.py:
599         (SystemHost.__init__):
600         * Scripts/webkitpy/common/system/user.py:
601         (User.__init__):
602
603 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
604
605         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
606         https://bugs.webkit.org/show_bug.cgi?id=176443
607
608         Reviewed by Darin Adler.
609
610         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
611         (TEST):
612
613 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
614
615         check-webkit-style: Verify syntax for WK_API_AVAILABLE
616         https://bugs.webkit.org/show_bug.cgi?id=181394
617
618         Reviewed by Darin Adler.
619
620         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
621         as the second parameter instead of ios(WK_IOS_TBA). This generally
622         builds for iOS on EWS but not when using the public SDK. See r224057,
623         r223207 and r226211 for example. This patch adds a basic style check
624         for that macro to prevent this kind of mistake.
625
626         * Scripts/webkitpy/style/checkers/cpp.py:
627         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
628         (check_style): Run new style check.
629         (CppChecker): Add build type for the new style check.
630         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
631         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
632
633 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
634
635         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
636         https://bugs.webkit.org/show_bug.cgi?id=181420
637         <rdar://problem/36365827>
638
639         Reviewed by Alex Christensen.
640
641         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
642         of corresponding _WKAttachments.
643
644         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
645         (TestWebKitAPI::TEST):
646
647 2018-01-08  Alex Christensen  <achristensen@webkit.org>
648
649         Add WKNavigationDelegate SPI exposing WebProcess crash reason
650         https://bugs.webkit.org/show_bug.cgi?id=181410
651         <rdar://problem/36167199>
652
653         Reviewed by Wenson Hsieh.
654
655         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
656         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
657         (TEST):
658
659 2018-01-08  Alex Christensen  <achristensen@webkit.org>
660
661         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
662         https://bugs.webkit.org/show_bug.cgi?id=181408
663         <rdar://problem/35884960>
664
665         Reviewed by Tim Horton.
666
667         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
668         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
669
670 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
671
672         [Attachment Support] Expose file name and content type of WKAttachment
673         https://bugs.webkit.org/show_bug.cgi?id=181390
674         <rdar://problem/36336837>
675
676         Reviewed by Tim Horton.
677
678         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
679
680         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
681         (-[_WKAttachment synchronouslyRequestInfo:]):
682         (-[_WKAttachment synchronouslyRequestData:]):
683
684         Reimplement this in terms of -synchronouslyRequestInfo:.
685
686         (-[_WKAttachment expectRequestedDataToBe:]):
687         (TestWebKitAPI::TEST):
688
689 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
690
691         Copying, pasting, and then deleting an attachment element breaks attachment data requests
692         https://bugs.webkit.org/show_bug.cgi?id=181365
693         <rdar://problem/36340647>
694
695         Reviewed by Tim Horton.
696
697         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
698         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
699         detail.
700
701         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
702         (TestWebKitAPI::TEST):
703
704 2018-01-08  Youenn Fablet  <youenn@apple.com>
705
706         navigator.onLine does not work inside service workers
707         https://bugs.webkit.org/show_bug.cgi?id=181079
708         <rdar://problem/36178606>
709
710         Reviewed by Darin Adler.
711
712         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
713         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
714
715 2018-01-07  Saam Barati  <sbarati@apple.com>
716
717         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
718         https://bugs.webkit.org/show_bug.cgi?id=181372
719
720         Reviewed by Filip Pizlo.
721
722         Adding these sorting modes makes it easier to analyze functions
723         that recompile a lot and exit a lot.
724
725         * Scripts/display-profiler-output:
726
727 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
728
729         Unreviewed, remove my Cisco email from contributors.json
730
731         * Scripts/webkitpy/common/config/contributors.json:
732
733 2018-01-05  JF Bastien  <jfbastien@apple.com>
734
735         WebAssembly: poison JS object's secrets
736         https://bugs.webkit.org/show_bug.cgi?id=181339
737         <rdar://problem/36325001>
738
739         Reviewed by Mark Lam.
740
741         Update tests for swap(Poisoned<k, T>, T*)
742
743         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
744         (TestWebKitAPI::TEST):
745         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
746         (TestWebKitAPI::TEST):
747         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
748         (TestWebKitAPI::TEST):
749
750 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
751
752         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
753         https://bugs.webkit.org/show_bug.cgi?id=181359
754
755         Reviewed by Tim Horton.
756
757         Ensure that these tests still pass using older SDKs.
758
759         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
760         (TestWebKitAPI::TEST):
761
762 2018-01-05  Alex Christensen  <achristensen@webkit.org>
763
764         Rebase API test after r226469
765         https://bugs.webkit.org/show_bug.cgi?id=181308
766
767         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
768         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
769         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
770
771 2018-01-05  Alex Christensen  <achristensen@webkit.org>
772
773         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
774         https://bugs.webkit.org/show_bug.cgi?id=181217
775
776         Reviewed by Tim Horton.
777
778         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
779         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
780         (TEST):
781
782 2018-01-05  Alex Christensen  <achristensen@webkit.org>
783
784         Add WKBundleFrameCreateFrameHandle
785         https://bugs.webkit.org/show_bug.cgi?id=181232
786         <rdar://problem/35926696>
787
788         Reviewed by Tim Horton.
789
790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
791         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
792         (mouseDidMoveOverElement):
793         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
794         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
795         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
796         (TEST):
797
798 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
799
800         iOS: Build fix after r226432.
801         
802         Unreviewed. Stop duplicating speakAs symbols for iOS.
803
804         * DumpRenderTree/AccessibilityUIElement.cpp:
805         (AccessibilityUIElement::speakAs):
806
807 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
808
809         Unreviewed, added myself as WebKit reviewer
810
811         * Scripts/webkitpy/common/config/contributors.json:
812
813 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
814
815         WPE: Build fix after r226432.
816
817         Unreviewed. Rename ::speak() to ::speakAs().
818         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
819         (WTR::AccessibilityUIElement::speakAs):
820         (WTR::AccessibilityUIElement::speak): Deleted.
821
822 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
823
824         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
825         https://bugs.webkit.org/show_bug.cgi?id=180361
826
827         Reviewed by Zalan Bujtas.
828
829         * DumpRenderTree/AccessibilityUIElement.cpp:
830         (speakAsCallback):
831         (AccessibilityUIElement::speakAs):
832         (AccessibilityUIElement::getJSClass):
833         (speakCallback): Deleted.
834         (AccessibilityUIElement::speak): Deleted.
835         * DumpRenderTree/AccessibilityUIElement.h:
836         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
837         (AccessibilityUIElement::speakAs):
838         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
839         (AccessibilityUIElement::speakAs):
840         (AccessibilityUIElement::speak): Deleted.
841         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
842         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
843         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
844         (WTR::AccessibilityUIElement::speakAs):
845         (WTR::AccessibilityUIElement::speak): Deleted.
846         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
847         (WTR::AccessibilityUIElement::speakAs):
848         (WTR::AccessibilityUIElement::speak): Deleted.
849
850 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
851
852         REGRESSION (r226395): test-webkitperl test expectations incorrect
853         https://bugs.webkit.org/show_bug.cgi?id=181307
854         <rdar://problem/36306558>
855
856         Rubber-stamped by Aakash Jain.
857
858         r226395 added two lines towards the beginning of
859         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
860         numbers in the test expectations need to update.
861
862         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
863
864 2018-01-04  Tim Horton  <timothy_horton@apple.com>
865
866         WKWebView loses minimum layout size overrides that happen while the process is terminated
867         https://bugs.webkit.org/show_bug.cgi?id=181306
868         <rdar://problem/34398288>
869
870         Reviewed by Dan Bernstein.
871
872         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
873         (TEST):
874         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
875         while the process is terminated results in the page getting the correct
876         minimum layout size.
877
878 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
879
880         [MediaStream] Add Mock screen capture source
881         https://bugs.webkit.org/show_bug.cgi?id=181291
882         <rdar://problem/36298164>
883
884         Reviewed by Dean Jackson.
885
886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
887         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
888         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
889
890 2018-01-04  Lucas Forschler  <lforschler@apple.com>
891
892         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
893
894         Reviewed by Ling Ho.
895
896         * BuildSlaveSupport/build.webkit.org-config/steps.py:
897
898 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
899
900         [Attachment Support] Create attachment elements when dropping files on iOS
901         https://bugs.webkit.org/show_bug.cgi?id=181192
902         <rdar://problem/36280945>
903
904         Reviewed by Tim Horton.
905
906         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
907         switch is enabled. See below for more details.
908
909         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
910         (-[NSItemProvider registerData:type:]):
911         (platformCopyPNG):
912         (TestWebKitAPI::TEST):
913         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
914
915         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
916         source item provider when dragging rich text *without* attachments, so this should have been a check for just
917         kUTTypeRTF instead.
918
919         (TestWebKitAPI::TEST):
920
921         Tests a few cases of inserting attachment elements via drop:
922         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
923             Instead of inserting the contents as inline web content, this should generate attachment elements.
924         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
925             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
926             back to inserting the content as an attachment.
927         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
928             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
929             or at the end).
930
931         * TestWebKitAPI/cocoa/TestWKWebView.h:
932         * TestWebKitAPI/cocoa/TestWKWebView.mm:
933         (-[TestWKWebView objectByEvaluatingJavaScript:]):
934
935         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
936         -stringByEvaluatingJavaScript to just turn around and call this.
937
938         (-[TestWKWebView stringByEvaluatingJavaScript:]):
939
940 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
941
942         Replace hard-coded paths in shebangs with #!/usr/bin/env
943         https://bugs.webkit.org/show_bug.cgi?id=181040
944
945         Reviewed by Alex Christensen.
946
947         * BuildSlaveSupport/build-launcher-app:
948         * BuildSlaveSupport/build-launcher-dmg:
949         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
950         * BuildSlaveSupport/built-product-archive:
951         * BuildSlaveSupport/clean-build:
952         * BuildSlaveSupport/delete-stale-build-files:
953         * BuildSlaveSupport/download-built-product:
954         * BuildSlaveSupport/gtk/buildbot/log/run:
955         * BuildSlaveSupport/gtk/buildbot/run:
956         * BuildSlaveSupport/gtk/pulseaudio/run:
957         * BuildSlaveSupport/kill-old-processes:
958         * BuildSlaveSupport/test-result-archive:
959         * BuildSlaveSupport/win/kill-old-processes:
960         * Scripts/SpacingHeuristics.pm:
961         * Scripts/add-include:
962         * Scripts/build-api-tests:
963         * Scripts/build-dumprendertree:
964         * Scripts/build-imagediff:
965         * Scripts/build-jsc:
966         * Scripts/build-webkit:
967         * Scripts/build-webkittestrunner:
968         * Scripts/check-Xcode-source-file-types:
969         * Scripts/check-dom-results:
970         * Scripts/check-for-exit-time-destructors:
971         * Scripts/check-for-global-initializers:
972         * Scripts/check-for-inappropriate-objc-class-names:
973         * Scripts/check-for-weak-vtables-and-externals:
974         * Scripts/clean-header-guards:
975         * Scripts/compare-timing-files:
976         * Scripts/configure-xcode-for-ios-development:
977         * Scripts/copy-webkitlibraries-to-product-directory:
978         * Scripts/create-exports:
979         * Scripts/debug-minibrowser:
980         * Scripts/debug-safari:
981         * Scripts/debug-test-runner:
982         * Scripts/do-file-rename:
983         * Scripts/do-webcore-rename:
984         * Scripts/dump-webkit-tests-run:
985         * Scripts/ensure-valid-python:
986         * Scripts/execAppWithEnv:
987         * Scripts/extract-localizable-js-strings:
988         * Scripts/filter-build-webkit:
989         * Scripts/find-extra-includes:
990         * Scripts/fix-blink-patch:
991         * Scripts/generate-coverage-data:
992         * Scripts/git-add-reviewer:
993         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
994         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
995         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
996         * Scripts/make-new-script-test:
997         * Scripts/make-script-test-wrappers:
998         * Scripts/package-root:
999         * Scripts/parse-malloc-history:
1000         * Scripts/report-include-statistics:
1001         * Scripts/resolve-ChangeLogs:
1002         * Scripts/run-api-tests:
1003         * Scripts/run-bindings-tests:
1004         * Scripts/run-content-extension-tester:
1005         * Scripts/run-iexploder-tests:
1006         * Scripts/run-javascriptcore-tests:
1007         * Scripts/run-jsc:
1008         * Scripts/run-leaks:
1009         * Scripts/run-mangleme-tests:
1010         * Scripts/run-minibrowser:
1011         * Scripts/run-pageloadtest:
1012         * Scripts/run-regexp-tests:
1013         * Scripts/run-safari:
1014         * Scripts/run-sunspider:
1015         * Scripts/run-test-runner:
1016         * Scripts/run-webkit-app:
1017         * Scripts/run-webkit-httpd:
1018         * Scripts/run-webkit-websocketserver:
1019         * Scripts/set-webkit-configuration:
1020         * Scripts/show-pretty-diff:
1021         * Scripts/sort-Xcode-project-file:
1022         * Scripts/split-file-by-class:
1023         * Scripts/sunspider-compare-results:
1024         * Scripts/svn-apply:
1025         * Scripts/svn-unapply:
1026         * Scripts/test-webkit-scripts:
1027         * Scripts/test-webkitperl:
1028         * Scripts/update-iexploder-cssproperties:
1029         * Scripts/update-javascriptcore-test-results:
1030         * Scripts/update-webkit:
1031         * Scripts/update-webkit-auxiliary-libs:
1032         * Scripts/update-webkit-dependency:
1033         * Scripts/update-webkit-libs-jhbuild:
1034         * Scripts/update-webkit-localizable-strings:
1035         * Scripts/update-webkit-support-libs:
1036         * Scripts/update-webkitgtk-libs:
1037         * Scripts/update-webkitwpe-libs:
1038         * Scripts/webkit-build-directory:
1039         * Scripts/webkitperl/LoadAsModule.pm:
1040         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1041         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1042         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
1043         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
1044         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
1045         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1046         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1047         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1048         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1049         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1050         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
1051         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
1052         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
1053         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1054         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1055         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1056         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1057         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
1058         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
1059         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
1060         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
1061         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
1062         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
1063         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
1064         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1065         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1066         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
1067         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
1068         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1069         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1070         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1071         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1072         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1073         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1074         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1075         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1076         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1077         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1078         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1079         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1080         * ccache/ccache-clang:
1081         * ccache/ccache-clang++:
1082         * ccache/ccache-wrapper:
1083         * gtk/install-dependencies:
1084         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1085         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1086         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1087         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1088         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1089         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1090         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1091         * iExploder/iexploder-1.7.2/src/webserver.rb:
1092         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1093         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1094         * wpe/install-dependencies:
1095
1096 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1097
1098         filter-build-webkit filters out useful compiler error lines
1099         https://bugs.webkit.org/show_bug.cgi?id=179864
1100
1101         Reviewed by Tim Horton.
1102
1103         Don't filter out lines that contain information about build errors by always showing lines
1104         after a line that contains "note:" or "error:".
1105
1106         * Scripts/filter-build-webkit:
1107         (shouldShowSubsequentLine):
1108         (shouldIgnoreLine):
1109
1110 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1111
1112         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1113         https://bugs.webkit.org/show_bug.cgi?id=173915
1114
1115         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1116         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1117         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1118         empty string in this case.
1119
1120         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1121         (emitFormSubmissionEvent):
1122
1123 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1124
1125         [GTK] Add web process API to detect when form is submitted via JavaScript
1126         https://bugs.webkit.org/show_bug.cgi?id=173915
1127
1128         Reviewed by Carlos Garcia Campos.
1129
1130         Test it.
1131
1132         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1133         (FormSubmissionTest::FormSubmissionTest):
1134         (FormSubmissionTest::~FormSubmissionTest):
1135         (FormSubmissionTest::testFormSubmissionResult):
1136         (FormSubmissionTest::willSendDOMEventCallback):
1137         (FormSubmissionTest::willCompleteCallback):
1138         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1139         (testWebExtensionFormSubmissionSteps):
1140         (beforeAll):
1141         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1142         (DelayedSignal::DelayedSignal):
1143         (emitFormSubmissionEvent):
1144         (handleFormSubmissionCallback):
1145         (willSubmitFormCallback):
1146         (pageCreatedCallback):
1147
1148 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1149
1150         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1151         https://bugs.webkit.org/show_bug.cgi?id=181251
1152
1153         * Scripts/run-gtk-tests:
1154         (GtkTestRunner):
1155
1156 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1157
1158         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1159         https://bugs.webkit.org/show_bug.cgi?id=181136
1160
1161         * Scripts/run-gtk-tests:
1162         (GtkTestRunner):
1163
1164 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1165
1166         [macOS, iOS] Adopt new secure coding APIs in WebKit
1167         https://bugs.webkit.org/show_bug.cgi?id=181085
1168         <rdar://problem/34837397>
1169
1170         Reviewed by Tim Horton.
1171
1172         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1173         capable of supporting NSSecureCoding, so pass through the current coding routines.
1174
1175         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1176         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1177         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1178         routines if necessary.
1179         (TEST): Updated for NSSecureCoding.
1180         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1181         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1182
1183 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1184
1185         Remove std::chrono completely
1186         https://bugs.webkit.org/show_bug.cgi?id=181186
1187
1188         Reviewed by Alex Christensen.
1189
1190         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1191         (WTR::TestController::platformRunUntil):
1192
1193 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1194
1195         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1196         https://bugs.webkit.org/show_bug.cgi?id=181231
1197
1198         Reviewed by Alex Christensen.
1199
1200         Implement TestController APIs needed by ResourceLoadStatistics tests.
1201
1202         * WebKitTestRunner/TestController.cpp:
1203         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1204         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1205
1206 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1207
1208         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1209         https://bugs.webkit.org/show_bug.cgi?id=181219
1210
1211         Reviewed by Wenson Hsieh.
1212
1213         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1214
1215 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1216
1217         Add a WebAuthentication runtime feature flag
1218         https://bugs.webkit.org/show_bug.cgi?id=181220
1219         <rdar://problem/36055305>
1220
1221         Reviewed by Brent Fulgham.
1222
1223         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1224
1225         * DumpRenderTree/TestOptions.h:
1226         * DumpRenderTree/TestOptions.mm:
1227         (TestOptions::TestOptions):
1228         * DumpRenderTree/mac/DumpRenderTree.mm:
1229         (enableExperimentalFeatures):
1230         (setWebPreferencesForTestOptions):
1231         * WebKitTestRunner/TestController.cpp:
1232         (WTR::TestController::resetPreferencesToConsistentValues):
1233         (WTR::updateTestOptionsFromTestHeader):
1234         * WebKitTestRunner/TestOptions.h:
1235         (WTR::TestOptions::hasSameInitializationOptions const):
1236
1237 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1238
1239         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1240         https://bugs.webkit.org/show_bug.cgi?id=181143
1241         <rdar://problem/36200381>
1242
1243         Reviewed by Tim Horton.
1244
1245         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1246         attachment elements are enabled.
1247
1248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1249         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1250         (TestWebKitAPI::TEST):
1251
1252 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1253
1254         Update Credential Management API for WebAuthentication
1255         https://bugs.webkit.org/show_bug.cgi?id=181082
1256         <rdar://problem/36055239>
1257
1258         Reviewed by Brent Fulgham.
1259
1260         Enable Credential Management API for testing.
1261
1262         * DumpRenderTree/TestOptions.h:
1263         * WebKitTestRunner/TestOptions.h:
1264
1265 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1266
1267         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1268         https://bugs.webkit.org/show_bug.cgi?id=168194
1269
1270         Reviewed by Carlos Garcia Campos.
1271
1272         Fix an assertion and unskip the test. The order that form controls are associated is not
1273         guaranteed.
1274
1275         * Scripts/run-gtk-tests:
1276         (GtkTestRunner):
1277         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1278         (didAssociateFormControlsCallback):
1279
1280 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1281
1282         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1283         https://bugs.webkit.org/show_bug.cgi?id=180897
1284         <rdar://problem/35535328>
1285
1286         Reviewed by Brent Fulgham.
1287
1288         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1289
1290         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1291         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1292         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1293         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1294         (websiteDataStoreTestWebView):
1295         (TEST):
1296
1297 == Rolled over to ChangeLog-2018-01-01 ==