d3724f53490f5fc33ffb5392857bced24f85f98f
[WebKit-https.git] / Tools / ChangeLog
1 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Adding myself as a reviewer.
4
5         * Scripts/webkitpy/common/config/committers.py:
6
7 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
8
9         Unreviewed.  Adding myself to committers.py.
10
11         * Scripts/webkitpy/common/config/committers.py:
12
13 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
14
15         Reviewed by Kenneth Rohde Christiansen.
16
17         TestNetscapePlugIn should use #if defined
18         https://bugs.webkit.org/show_bug.cgi?id=51471
19
20         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
21         (NP_Initialize):
22         (NPP_New):
23
24 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
25
26         Reviewed by Yury Semikhatsky.
27
28         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
29
30         DevTools window should be closed explicitly because it has custom deinitialization code.
31
32         https://bugs.webkit.org/show_bug.cgi?id=50722
33
34         * DumpRenderTree/chromium/TestShell.cpp:
35         (TestShell::closeRemainingWindows):
36
37 2010-12-22  David Levin  <levin@chromium.org>
38
39         Reviewed by Shinichiro Hamaji.
40
41         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
42         https://bugs.webkit.org/show_bug.cgi?id=51452
43
44         * Scripts/webkitpy/style/checkers/cpp.py:
45         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
46         Using the file extension if possible but falling back to the file contents if we have a header file.
47         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
48         (_FileState.is_c_or_objective_c):
49         (check_using_std): Changed to using _FileState to determine the file type.
50         (check_max_min_macros): Ditto.
51         (check_for_null): Ditto.
52         (check_style): Changed the parameters to various calls since they now need _FileState
53         to determine the file type.
54         (check_language): Added the file_state parameter so it could be passed
55         to check_identifier_name_in_declaration.
56         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
57         this is an Objective C file.
58         (_process_lines): Added information for the _FileState constructor (and moved the
59         call to a place that had the information).
60         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
61         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
62         its functionality.
63         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
64
65 2010-12-21  Andy Estes  <aestes@apple.com>
66
67         Reviewed by Mark Rowe.
68
69         Do not build non-Intel architectures for WebKit2-related projects.
70         https://bugs.webkit.org/show_bug.cgi?id=51440
71
72         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
73         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
74         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
75
76 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
77
78         Reviewed by Darin Fisher.
79
80         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
81         https://bugs.webkit.org/show_bug.cgi?id=51406 
82         
83         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
84         to WebThemeEngineDRTWin and update references everywhere.
85
86         * DumpRenderTree/DumpRenderTree.gypi:
87         * DumpRenderTree/chromium/TestShellWin.cpp:
88         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
89         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
90         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
91         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
92
93 2010-12-21  Anders Carlsson  <andersca@apple.com>
94
95         Reviewed by John Sullivan.
96
97         Clicking missing plug-in text does not show a sheet
98         https://bugs.webkit.org/show_bug.cgi?id=51403
99
100         Update for changes to the WebPageUIClient.
101
102         * MiniBrowser/mac/BrowserWindowController.m:
103         (-[BrowserWindowController awakeFromNib]):
104         * WebKitTestRunner/TestController.cpp:
105         (WTR::createOtherPage):
106         (WTR::TestController::initialize):
107
108 2010-12-21  Eric Seidel  <eric@webkit.org>
109
110         Reviewed by Adam Barth.
111
112         commit-queue will report constant failures as flaky if other tests flake
113         https://bugs.webkit.org/show_bug.cgi?id=51272
114
115         This patch just removes functionality and adds testing.
116         Previously we attempted to report flaky tests when we had
117         two different tests fail in a row.  However, since we stop
118         running the tests at the first failure, our code was wrong in
119         trying to determine flakiness from the incomplete runs.
120
121         Originally I posted an alternate patch:
122         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
123         which fixed our flaky logic in this case, however it was decided
124         that that patch would be too difficult to maintain, so now
125         I'm just removing the broken logic.
126
127         This will dramatically cut-down on our flaky-test false positives
128         at the (small) cost of the queues being unable to report
129         any flakiness if the tree is very flaky.  (With at least one test
130         flaking on every run, we'll never report failures anymore.)  I think
131         this is a tradeoff worth making.
132
133         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
134         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
135
136 2010-12-20  Eric Seidel  <eric@webkit.org>
137
138         Reviewed by Adam Barth.
139
140         commit-queue wrongly rejects patches when it can't update itself
141         https://bugs.webkit.org/show_bug.cgi?id=46636
142
143         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
144         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
145         * Scripts/webkitpy/tool/commands/queues_unittest.py:
146
147 2010-12-20  Adam Barth  <abarth@webkit.org>
148
149         Move web sites to Websites directory
150         https://bugs.webkit.org/show_bug.cgi?id=51323
151
152         Update references to BugsSite to point to the new location.
153
154         This patch was never officially reviewed (because it was too large to
155         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
156         Rowe gave me the green light.
157
158         * Scripts/old-run-webkit-tests:
159         * Scripts/webkitpy/common/config/build.py:
160         * Scripts/webkitpy/common/config/build_unittest.py:
161         * Scripts/webkitpy/common/prettypatch.py:
162         * Scripts/webkitpy/layout_tests/port/base.py:
163         * Scripts/webkitpy/style/main.py:
164
165 2010-12-20  Adrienne Walker  <enne@google.com>
166
167         Unreviewed. Adding myself to the list of committers.
168
169         * webkitpy/common/config/committers.py:
170
171 2010-12-20  Mark Rowe  <mrowe@apple.com>
172
173         Reviewed by Dan Bernstein.
174
175         <rdar://problem/8757601> Don't install header files in to the Resources directory.
176
177         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
178         Resources directory.
179
180 2010-12-20  Eric Seidel  <eric@webkit.org>
181
182         Reviewed by Adam Barth.
183
184         commit-queue should include bot id when attaching failure diffs
185         https://bugs.webkit.org/show_bug.cgi?id=51280
186
187         This is a tiny change to include the bot id in the name of the attachment.
188         Most of this diff is just changing the unit test expectations
189         now that I hid the comment printing when the comment is None.
190
191         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
192         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
193         * Scripts/webkitpy/tool/commands/upload_unittest.py:
194         * Scripts/webkitpy/tool/mocktool.py:
195
196 2010-12-20  Jeff Miller  <jeffm@apple.com>
197
198         Reviewed by Dan Bernstein.
199
200         Tools/vcbin/midl.exe needs to be rebuilt
201         https://bugs.webkit.org/show_bug.cgi?id=51347
202
203         * vcbin/midl.exe: Rebuilt.
204
205 2010-12-20  David Levin  <levin@chromium.org>
206
207         Reviewed by Ariya Hidayat.
208
209         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
210         https://bugs.webkit.org/show_bug.cgi?id=51343
211
212         Follow up from the WebKitTools -> Tools rename.
213
214         * Scripts/webkit-tools-completion.sh:
215
216 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
217
218         Reviewed by James Robinson.
219
220         new-run-webkit-tests ignores trailing EOL differences in text tests
221         https://bugs.webkit.org/show_bug.cgi?id=36983
222
223         Changed the handling of new-line characters within new-run-webkit-tests
224         to match old-run-webkit-tests.  Differences in leading and trailing empty
225         lines in text expectation files are no longer ignored.
226
227         * Scripts/webkitpy/layout_tests/port/base.py:
228         * Scripts/webkitpy/layout_tests/port/test.py:
229         Added unit tests.  Removed old duplicate unit test entries.
230         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
231
232 2010-12-20  David Levin  <levin@chromium.org>
233
234         Reviewed by Shinichiro Hamaji.
235
236         check-webkit-style should detect function declarations (and trivial functions).
237         https://bugs.webkit.org/show_bug.cgi?id=51303
238
239         * Scripts/webkitpy/style/checkers/cpp.py:
240         (_FunctionState.begin): Add is_declaration and changed the line count
241         start to begin at -1 (which will keep the results consistent, since
242         the starting line number passed in is one less in this change).
243         (detect_functions): changed function detection to now catch trivial
244         functions and declarations.
245         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
246         of the function as this may look at return values (when processing
247         a declaration).
248         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
249         (FunctionDetectionTest.perform_function_detection): Basic mechanics
250         of testing the function detection.
251         (FunctionDetectionTest.test_basic_function_detection): Test a simple
252         function.
253         (FunctionDetectionTest.test_function_declaration_detection): Test a
254         declaration.
255         (FunctionDetectionTest.test_non_functions): A test case for a case
256         that caused the code to fail due to the { being in quotes.
257         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
258         cases to help catch false alarms for return values.
259         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
260         we don't get false alarms for member variables either.
261
262 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
263
264         Reviewed by Antonio Gomes.
265
266         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
267         https://bugs.webkit.org/show_bug.cgi?id=51319
268
269         * CMakeListsEfl.txt:
270
271 2010-12-18  Adam Barth  <abarth@webkit.org>
272
273         Reviewed by Sam Weinig.
274
275         Move WebKitExamplePlugins to Examples
276         https://bugs.webkit.org/show_bug.cgi?id=51291
277
278         * Scripts/webkitpy/common/config/build.py:
279
280 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
281
282         Unreviewed Qt buildfix after r74301.
283
284         Rename WebKitTools to Tools
285         https://bugs.webkit.org/show_bug.cgi?id=49861
286
287         * MiniBrowser/DerivedSources.pro:
288         * MiniBrowser/qt/MiniBrowser.pro:
289
290 2010-12-17  Dan Bernstein  <mitz@apple.com>
291
292         Reviewed by Simon Fraser.
293
294         Rename WebKitTools to Tools
295         https://bugs.webkit.org/show_bug.cgi?id=49861
296
297         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
298         * CodeCoverage/README:
299         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
300         (WebCore::DumpRenderTree::initializeFonts):
301         * EWSTools/start-commit-queue.sh:
302         * EWSTools/start-queue.sh:
303         * GNUmakefile.am:
304         * MIDLWrapper/MIDLWrapper.cpp:
305         (wmain):
306         * MiniBrowser/qt/MiniBrowser.pro:
307         * Scripts/build-api-tests:
308         * Scripts/build-dumprendertree:
309         * Scripts/build-webkit:
310         * Scripts/build-webkittestrunner:
311         * Scripts/generate-coverage-data:
312         * Scripts/old-run-webkit-tests:
313         * Scripts/run-api-tests:
314         * Scripts/run-iexploder-tests:
315         * Scripts/run-javascriptcore-tests:
316         * Scripts/run-mangleme-tests:
317         * Scripts/run-sunspider:
318         * Scripts/run-webkit-websocketserver:
319         * Scripts/sunspider-compare-results:
320         * Scripts/test-webkitperl:
321         * Scripts/test-webkitpy:
322         * Scripts/update-iexploder-cssproperties:
323         * Scripts/update-webkit:
324         * Scripts/update-webkit-localizable-strings:
325         * Scripts/webkitdirs.pm:
326         * Scripts/webkitpy/common/checkout/scm.py:
327         * Scripts/webkitpy/common/checkout/scm_unittest.py:
328         * Scripts/webkitpy/common/config/committervalidator.py:
329         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
330         * Scripts/webkitpy/common/config/ports.py:
331         * Scripts/webkitpy/common/config/ports_unittest.py:
332         * Scripts/webkitpy/common/system/logutils_unittest.py:
333         * Scripts/webkitpy/common/system/ospath_unittest.py:
334         * Scripts/webkitpy/layout_tests/port/chromium.py:
335         * Scripts/webkitpy/layout_tests/port/config.py:
336         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
337         * Scripts/webkitpy/layout_tests/port/http_server.py:
338         * Scripts/webkitpy/layout_tests/port/test.py:
339         * Scripts/webkitpy/style/checker.py:
340         * Scripts/webkitpy/style/checker_unittest.py:
341         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
342         * Scripts/webkitpy/tool/commands/queues_unittest.py:
343         * Scripts/webkitpy/tool/steps/steps_unittest.py:
344         * WebKitTestRunner/DerivedSources.pro:
345         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
346         (WTR::activateFonts):
347         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
348         * wx/build/build_utils.py:
349
350 2010-12-16  Antonio Gomes  <agomes@rim.com>
351
352         Reviewed by Martin Robinson.
353
354         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
355         https://bugs.webkit.org/show_bug.cgi?id=51163
356
357         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
358         GTK+'s DRT should also reset to UNIX after each test execution.
359
360         * DumpRenderTree/gtk/DumpRenderTree.cpp:
361         (resetDefaultsToConsistentValues):
362
363 2010-12-17  David Levin  <levin@chromium.org>
364
365         Reviewed by Eric Seidel.
366
367         check-webkit-style should understand WTF #include guards
368         https://bugs.webkit.org/show_bug.cgi?id=44911
369
370         * Scripts/webkitpy/style/checkers/cpp.py:
371         (get_header_guard_cpp_variable): modify to suggest the WTF style
372         of header guard when appropriate.
373         (check_for_header_guard): handle multiple return values from
374         get_header_guard_cpp_variable
375         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
376         (CppStyleTest.test_build_header_guard): Added tests for the WTF
377         header style.
378
379 2010-12-16  David Levin  <levin@chromium.org>
380
381         Reviewed by Eric Seidel.
382
383         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
384         https://bugs.webkit.org/show_bug.cgi?id=51210
385
386         The error only shows up when using python 2.6 or later.
387
388         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
389         the decprecated field error,message with something equivalent.
390
391 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
392
393         Reviewed by Eric Seidel.
394
395         Add --exit-after-n-failures/crashes to NRWT
396         https://bugs.webkit.org/show_bug.cgi?id=51160
397         
398         Abort test run (in a similar way to how control-C is handled) when
399         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
400         that number of unexpected failures/crashes/timeouts.
401
402         * Scripts/webkitpy/layout_tests/port/test.py:
403         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
404         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
405
406 2010-12-16  David Levin  <levin@chromium.org>
407
408         Reviewed by Shinichiro Hamaji.
409
410         check-webkit-style unit tests has some duplicate boilerplate code.
411         https://bugs.webkit.org/show_bug.cgi?id=49519
412
413         * Scripts/webkitpy/style/checkers/cpp.py:
414         (update_include_state): Replaced the "io" parameter with the global
415         configuration _unit_test_config. This allowed not calling into
416         functions at a low level and also not plumbing through the injection
417         information through many levels of code.
418         (check_for_include_what_you_use): Ditto.
419         (process_file_data): Added the ability to set up the unit test config
420         to allow for injection.
421         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
422         (ErrorCollector.__init__): Added support for having a filter for errors.
423         (ErrorCollector.__call__): Ditto.
424         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
425         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
426         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
427         functions in the cpp.py with generic processing and a filter that
428         indicates what errors should be kept.
429         (CppStyleTestBase.perform_multi_line_lint): Ditto.
430         (CppStyleTestBase.perform_language_rules_check): Ditto.
431         (CppStyleTestBase.perform_function_lengths_check): Ditto.
432         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
433         (CppStyleTestBase.perform_include_what_you_use): Ditto.
434         (CppStyleTest.test_multi_line_comments): Added another
435         error message which applies to the test case.
436         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
437         to not have config.h, since it is processed as a header file.
438         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
439         style and indentation in checked code.
440         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
441         Fixed line number.
442         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
443         Ditto.
444
445 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
446
447         Unreviewed, rolling out r74136.
448         http://trac.webkit.org/changeset/74136
449         https://bugs.webkit.org/show_bug.cgi?id=51135
450
451         r74136 breaks chromium canary bots because some tests are not
452         rebaselined correctly to resolve EOL differences (Requested by
453         jianli on #webkit).
454
455         * Scripts/webkitpy/layout_tests/port/base.py:
456         * Scripts/webkitpy/layout_tests/port/test.py:
457         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
458
459 2010-12-15  Adam Roben  <aroben@apple.com>
460
461         Teach check-webkit-style to check .vcproj and .vsprops files for XML
462         syntax errors
463
464         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
465         XML syntax errors in .vcproj/.vsprops files
466
467         Reviewed by Dave Levin.
468
469         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
470         that should be treated as XML and that should be allowed to contain
471         carriage returns. (These lists happen to be identical currently.)
472         (FileType): Added a new XML type.
473         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
474         Just does a simple file extension check.
475         (CheckerDispatcher._file_type): Added a case for XML files.
476         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
477         files (surprise!).
478         (StyleProcessor.process): Ask the dispatcher whether we should pass the
479         lines through the carriage checker.
480
481         * Scripts/webkitpy/style/checker_unittest.py:
482         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
483         Added. Checks a few file names to see if carriage returns are allowed
484         or not.
485         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
486         other assert_checker_* functions.
487         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
488         test_*_paths functions.
489         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
490         test_*_paths functions.
491         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
492         file from this test case, as vcproj files now have a type.
493         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
494         Added. Similar to the other should_* functions.
495         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
496         Added. Checks that carriage returns aren't checked for or stripped for
497         allowed files.
498
499         * Scripts/webkitpy/style/checkers/xml.py: Added.
500         (XMLChecker.__init__): Simple init method.
501         (XMLChecker.check): Pass each line through the expat parser, and record
502         a style error for any errors thrown by the parser.
503
504         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
505         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
506         produce a style error.
507         (XMLCheckerTest.assert_error): Checks that the given XML produces an
508         error of the given category on the given line.
509         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
510         checking that the XMLChecker constructor works properly.
511         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
512         cause a style error (see, e.g., r73887).
513         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
514         cause a style error (see, e.g., r73773).
515         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
516         properly.
517         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
518         tags cause a style error (see, e.g., r72795).
519         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
520         style error.
521
522 2010-12-15  Lucas Forschler  <lforschler@apple.com>
523
524         Reviewed by Stephanie Lewis.
525
526         https://bugs.webkit.org/show_bug.cgi?id=51117
527         Add a new leopard test bot
528         really really commit to trunk this time.
529
530         * BuildSlaveSupport/build.webkit.org-config/config.json:
531
532 2010-12-15  Sam Weinig  <sam@webkit.org>
533
534         Reviewed by Anders Carlsson.
535
536         WebKit2: Can't add files to an <input type=file>
537         https://bugs.webkit.org/show_bug.cgi?id=51087
538
539         * MiniBrowser/mac/BrowserWindowController.m:
540         (runOpenPanel):
541         (-[BrowserWindowController awakeFromNib]):
542         Add simple implementation of runOpenPanel callback.
543
544         * MiniBrowser/win/BrowserView.cpp:
545         (BrowserView::create):
546         * WebKitTestRunner/TestController.cpp:
547         (WTR::createOtherPage):
548         (WTR::TestController::initialize):
549         Stub out runOpenPanel callback. 
550
551 2010-12-14  Eric Seidel  <eric@webkit.org>
552
553         Reviewed by Adam Barth.
554
555         commit-queue should upload failure diffs when tests flake
556         https://bugs.webkit.org/show_bug.cgi?id=51051
557
558         To make this testable I needed to pipe FileSystem down onto tool.
559         We've wanted it there for a long time anyway.
560
561         This patch is kinda a big hack.  But we don't have a nice
562         way to read results.html files.  I think this will need further
563         revision before this code actually feels clean.
564
565         As part of testing this change, I had to make MockBugzilla.create_bug
566         actually return an id (like it should) which required updating
567         a few other unit test results (for the better).
568
569         The results_matching_keys change in layouttestresults/rebasline
570         was an alternate path which I decided not to use in the end, but
571         I left the change as it seemed an improvement.
572
573         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
574         * Scripts/webkitpy/common/net/layouttestresults.py:
575         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
576         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
577         * Scripts/webkitpy/tool/commands/queues.py:
578         * Scripts/webkitpy/tool/commands/rebaseline.py:
579         * Scripts/webkitpy/tool/main.py:
580         * Scripts/webkitpy/tool/mocktool.py:
581
582 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
583
584         Reviewed by James Robinson.
585
586         new-run-webkit-tests ignores trailing EOL differences in text tests
587         https://bugs.webkit.org/show_bug.cgi?id=36983
588
589         Changed the handling of new-line characters within new-run-webkit-tests
590         to match old-run-webkit-tests.  Differences in leading and trailing empty
591         lines in text expectation files are no longer ignored.
592
593         * Scripts/webkitpy/layout_tests/port/base.py:
594         * Scripts/webkitpy/layout_tests/port/test.py:
595         Added unit tests.  Removed old duplicate unit test entries.
596         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
597
598 2010-12-15  Ojan Vafai  <ojan@chromium.org>
599
600         Reviewed by Adam Barth.
601
602         make status-bubble white-space:nowrap so we can measure it's width without wrapping
603         https://bugs.webkit.org/show_bug.cgi?id=51149
604
605         * QueueStatusServer/templates/statusbubble.html:
606
607 2010-12-15  Ojan Vafai  <ojan@chromium.org>
608
609         Reviewed by Adam Barth.
610
611         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
612         https://bugs.webkit.org/show_bug.cgi?id=51125
613
614         * QueueStatusServer/templates/statusbubble.html:
615
616 2010-12-15  Darin Adler  <darin@apple.com>
617
618         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
619
620 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
621
622         Unreviewed, rolling out r74117.
623         http://trac.webkit.org/changeset/74117
624         https://bugs.webkit.org/show_bug.cgi?id=51113
625
626         This broke the GTK1 build. (Requested by mrobinson on
627         #webkit).
628
629         * Scripts/webkitdirs.pm:
630
631 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
632
633         Reviewed by Martin Robinson.
634
635         Change generate-forwarding-headers.pl for GTK port usage 
636         (https://bugs.webkit.org/show_bug.cgi?id=37369)
637
638         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
639
640 2010-12-14  Kent Tamura  <tkent@chromium.org>
641
642         Reviewed by Jian Li.
643
644         [DRT/Chromium] Remove another unnecessary error message
645         https://bugs.webkit.org/show_bug.cgi?id=51083
646
647         * DumpRenderTree/chromium/WebViewHost.cpp:
648         (WebViewHost::didInvalidateRect):
649
650 2010-12-14  Lucas Forschler  <lforschler@apple.com>
651
652         Reviewed by Stephanie Lewis.
653
654         Add a new Leopard Debug Test WK2 Bot
655
656         * BuildSlaveSupport/build.webkit.org-config/config.json:
657
658 2010-12-14  Ojan Vafai  <ojan@chromium.org>
659
660         Fix python unittests after http://trac.webkit.org/changeset/74070.
661
662         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
663
664 2010-12-14  Kent Tamura  <tkent@chromium.org>
665
666         Reviewed by Jian Li.
667
668         [DRT/Chromium] Remove a unnecessary error message
669         https://bugs.webkit.org/show_bug.cgi?id=51069
670
671         * DumpRenderTree/chromium/WebViewHost.cpp:
672         (WebViewHost::paintInvalidatedRegion):
673
674 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
675
676         Reviewed by Ojan Vafai.
677
678         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
679         https://bugs.webkit.org/show_bug.cgi?id=48926
680
681         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
682         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
683
684 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
685
686         Reviewed by Eric Seidel.
687
688         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
689         https://bugs.webkit.org/show_bug.cgi?id=50231
690
691         Guard CONFIG+=link_pkgconfig with !symbian.
692
693         * DumpRenderTree/qt/DumpRenderTree.pro:
694         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
695         * WebKitTestRunner/qt/WebKitTestRunner.pro:
696
697 2010-12-14  Philippe Normand  <pnormand@igalia.com>
698
699         Reviewed by Ojan Vafai.
700
701         [new-run-webkit-tests] expectations parsing is slow
702         https://bugs.webkit.org/show_bug.cgi?id=50635
703
704         Avoid expensive iteration of all the tests when checking if a test
705         file is to be skipped or not.
706
707         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
708         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
709         * Scripts/webkitpy/layout_tests/port/test.py:
710
711 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
712
713         Reviewed by Xan Lopez.
714
715         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
716         https://bugs.webkit.org/show_bug.cgi?id=27048
717
718         Add support in DRT for checking whether an accessibility UI
719         element is focusable and/or focused. Implemented for GTK.
720
721         * DumpRenderTree/AccessibilityUIElement.cpp:
722         (getIsFocusedCallback): New.
723         (getIsFocusableCallback): New.
724         (AccessibilityUIElement::getJSClass): Add the new available
725         callbacks for isFocused and isFocusable.
726         * DumpRenderTree/AccessibilityUIElement.h:
727         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
728         (AccessibilityUIElement::isFocused): New, implemented by checking
729         whether the related AtkState value is in the object's state set.
730         (AccessibilityUIElement::isFocusable): Ditto.
731         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
732         (AccessibilityUIElement::isFocused): New, dummy implementation.
733         (AccessibilityUIElement::isFocusable): Ditto.
734         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
735         (AccessibilityUIElement::isFocused): Ditto.
736         (AccessibilityUIElement::isFocusable): Ditto.
737
738 2010-12-14  Eric Seidel  <eric@webkit.org>
739
740         Reviewed by Ojan Vafai.
741
742         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
743         https://bugs.webkit.org/show_bug.cgi?id=50715
744
745         This patch makes webkit-patch print the following:
746
747         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
748         Install a 64-bit git for better performance, see:
749         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
750
751         I wrote this mostly because I have approximately 8 machines that I use
752         and making sure each one is using a good Git install seemed folly.
753         webkit-patch makes a lot of git calls, so using a fast git can shave
754         several seconds in every invocation.  See the webkit-dev thread for more info.
755
756         This message will print twice during 'webkit-patch upload',
757         once from webkit-patch and once from check-webkit-style.
758
759         Unfortunately there is no good way to test this due to how machine-dependent
760         the code is.  I considered writing a test for the log message, but it seemed not worth it.
761
762         * Scripts/webkitpy/common/checkout/scm.py:
763
764 2010-12-13  Eric Seidel  <eric@webkit.org>
765
766         Reviewed by Adam Barth.
767
768         FlakyTestReporter doesn't understand bots running from multiple email addresses
769         https://bugs.webkit.org/show_bug.cgi?id=50960
770
771         This explains at least one of the dupes of:
772         https://bugs.webkit.org/show_bug.cgi?id=50863
773         that we saw filed by the commit-queue this morning.
774         I think the other one was explained by my previous fix to result counting code.
775
776         Since this is really hard to test with a unit test, instead I
777         create a new (possibly useful in the future) command
778         which given a layout test path will return you
779         the one bug which our tools would assume it the flaky test bug.
780         If some other script wants to use bug-for-test we'll
781         need to extend it with some options like --create-if-missing or similar.
782
783         * Scripts/webkitpy/common/net/bugzilla/bug.py:
784         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
785         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
786         * Scripts/webkitpy/tool/commands/__init__.py:
787         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
788
789 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
790
791         Reviewed by James Robinson.
792
793         Add option to build-webkit to not build WebKit2
794         https://bugs.webkit.org/show_bug.cgi?id=50988
795         
796         Add support for a --no-webkit2 option to build-webkit. It seems to save
797         ~1 minute from clean builds and ~10 seconds from no-op builds.
798
799         * Scripts/build-webkit:
800
801 2010-12-13  Lucas Forschler  <lforschler@apple.com>
802
803         Reviewed by Dave Kilzer.
804
805         Update iexploder from 1.3.2 to 1.7.2
806         Move 1.3.2 into its own subdir
807         Add 1.7.2 into its own subdir
808         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
809
810         * Scripts/run-iexploder-tests:
811         * Scripts/update-iexploder-cssproperties:
812         * iExploder/CHANGELOG.txt: Removed.
813         * iExploder/LICENSE.txt: Removed.
814         * iExploder/README.txt: Removed.
815         * iExploder/htdocs: Removed.
816         * iExploder/iexploder-1.3.2: Added.
817         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
818         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
819         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
820         * iExploder/iexploder-1.3.2/htdocs: Added.
821         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
822         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
823         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
824         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
825         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
826         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
827         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
828         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
829         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
830         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
831         * iExploder/iexploder-1.3.2/tools: Added.
832         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
833         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
834         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
835         * iExploder/iexploder-1.7.2: Added.
836         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
837         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
838         * iExploder/iexploder-1.7.2/README.txt: Added.
839         * iExploder/iexploder-1.7.2/output: Added.
840         * iExploder/iexploder-1.7.2/src: Added.
841         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
842         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
843         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
844         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
845         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
846         * iExploder/iexploder-1.7.2/src/css-properties: Added.
847         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
848         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
849         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
850         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
851         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
852         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
853         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
854         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
855         * iExploder/iexploder-1.7.2/src/css-values: Added.
856         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
857         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
858         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
859         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
860         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
861         * iExploder/iexploder-1.7.2/src/headers: Added.
862         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
863         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
864         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
865         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
866         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
867         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
868         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
869         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
870         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
871         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
872         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
873         * iExploder/iexploder-1.7.2/src/html-tags: Added.
874         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
875         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
876         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
877         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
878         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
879         * iExploder/iexploder-1.7.2/src/html-values: Added.
880         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
881         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
882         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
883         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
884         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
885         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
886         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
887         * iExploder/iexploder-1.7.2/src/index.html: Added.
888         * iExploder/iexploder-1.7.2/src/media: Added.
889         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
890         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
891         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
892         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
893         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
894         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
895         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
896         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
897         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
898         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
899         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
900         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
901         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
902         * iExploder/iexploder-1.7.2/src/mime-types: Added.
903         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
904         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
905         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
906         * iExploder/iexploder-1.7.2/src/protocols: Added.
907         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
908         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
909         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
910         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
911         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
912         * iExploder/iexploder-1.7.2/src/version.rb: Added.
913         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
914         * iExploder/iexploder-1.7.2/testcases: Added.
915         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
916         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
917         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
918         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
919         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
920         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
921         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
922         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
923         * iExploder/iexploder-1.7.2/tools: Added.
924         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
925         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
926         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
927         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
928         * iExploder/tools: Removed.
929
930 2010-12-13  Sam Weinig  <sam@webkit.org>
931
932         Reviewed by Anders Carlsson.
933
934         Remove associated page concept from WKView constructor
935         https://bugs.webkit.org/show_bug.cgi?id=50983
936
937         Step 1: Remove associate page constructors from WKView and make
938         all views use the shared namespace for the context.
939
940         * TestWebKitAPI/PlatformWebView.h:
941         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
942         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
943         * WebKitTestRunner/PlatformWebView.h:
944         * WebKitTestRunner/TestController.cpp:
945         (WTR::createOtherPage):
946         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
947         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
948         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
949
950 2010-12-13  Sam Weinig  <sam@webkit.org>
951
952         Reviewed by Anders Carlsson.
953
954         Change the WebKit2 public API so there is no explicit WKPageNamespace object
955         https://bugs.webkit.org/show_bug.cgi?id=50898
956
957         * MiniBrowser/mac/AppDelegate.h:
958         * MiniBrowser/mac/AppDelegate.m:
959         * MiniBrowser/mac/BrowserWindowController.h:
960         * MiniBrowser/mac/BrowserWindowController.m:
961         * MiniBrowser/win/BrowserView.cpp:
962         Convert MiniBrowser to not use PageNamespaces.
963
964         * TestWebKitAPI/PlatformWebView.h:
965         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
966         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
967         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
968         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
969         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
970         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
971         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
972         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
973         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
974         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
975         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
976         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
977         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
978         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
979         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
980         Convert TestWebKitAPI to not use PageNamespaces.
981
982         * WebKitTestRunner/PlatformWebView.h:
983         * WebKitTestRunner/TestController.cpp:
984         * WebKitTestRunner/TestController.h:
985         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
986         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
987         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
988         Convert WebKitTestRunner to not use PageNamespaces.
989
990 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
991
992         Reviewed by Eric Seidel.
993
994         webkit-patch rollout should be able to do multi-revision rollouts
995         https://bugs.webkit.org/show_bug.cgi?id=33336
996
997         Make it possible to pass more than one revision to webkit-patch.
998
999         * Scripts/webkitpy/common/checkout/api.py:
1000         * Scripts/webkitpy/common/checkout/changelog.py:
1001         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1002         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1003         * Scripts/webkitpy/tool/commands/download.py:
1004         * Scripts/webkitpy/tool/commands/download_unittest.py:
1005         * Scripts/webkitpy/tool/mocktool.py:
1006         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1007         * Scripts/webkitpy/tool/steps/revertrevision.py:
1008
1009 2010-12-13  Eric Seidel  <eric@webkit.org>
1010
1011         Unreviewed.
1012
1013         Teach webkit-patch how to search bugzilla
1014         https://bugs.webkit.org/show_bug.cgi?id=50500
1015
1016         webkit-patch bug-search fails when there is only one result.
1017         Turns out we needed a bit more logic in our result count parsing code.
1018
1019         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1020         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1021
1022 2010-12-13  Antti Koivisto  <antti@apple.com>
1023
1024         Reviewed by Alexey Proskuryakov.
1025
1026         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1027         https://bugs.webkit.org/show_bug.cgi?id=50758
1028
1029         * DumpRenderTree/LayoutTestController.cpp:
1030         (setSerializeHTTPLoadsCallback):
1031         (LayoutTestController::staticFunctions):
1032         * DumpRenderTree/LayoutTestController.h:
1033         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1034         (LayoutTestController::setSerializeHTTPLoads):
1035         * DumpRenderTree/mac/DumpRenderTree.mm:
1036         (resetDefaultsToConsistentValues):
1037         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1038         (LayoutTestController::setSerializeHTTPLoads):
1039         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1040         (LayoutTestController::setSerializeHTTPLoads):
1041
1042 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1043
1044         Reviewed by Ojan Vafai.
1045
1046         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1047         https://bugs.webkit.org/show_bug.cgi?id=50936
1048
1049         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1050
1051 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
1052
1053         Reviewed by Csaba Osztrogonác.
1054
1055         Add revlink to BuildBot status
1056         https://bugs.webkit.org/show_bug.cgi?id=50914
1057
1058         This adds a hyperlink to trac changeset on the revision numbers. 
1059
1060         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1061
1062 2010-12-13  Andras Becsi  <abecsi@webkit.org>
1063
1064         Reviewed by Csaba Osztrogonác.
1065
1066         [Qt][WK2] Fix build if WebKitTools are not available
1067         https://bugs.webkit.org/show_bug.cgi?id=50242
1068
1069         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
1070         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
1071         * MiniBrowser/DerivedSources.pro: Added.
1072
1073 2010-12-13  Eric Seidel  <eric@webkit.org>
1074
1075         Reviewed by Adam Barth.
1076
1077         EWS Queues should remove orpahned pyc files before starting
1078         https://bugs.webkit.org/show_bug.cgi?id=50904
1079
1080         A previous check added a platform.py which caused
1081         EWS bots on some platforms to hit an import exception.
1082         The platform.py file was removed in a subsequent commit, but
1083         the EWS bots in question stayed stuck.  This change will
1084         fix those bots once restarted (and prevent this in the future).
1085
1086         I also went ahead and unified start-queue and start-commit-queue
1087         since they were nearly identical.  I also added bot_id support
1088         to both force all EWSes to have bot ids as well as get rid of the one
1089         remaining reason why I had my own copies of these scripts.
1090         Hopefully this will be enough to get all the other bot admins
1091         (ahem, Adam, ahem) to move to using these checked in copies as well.
1092
1093         * EWSTools/start-commit-queue.sh: Removed.
1094         * EWSTools/start-queue.sh:
1095
1096 2010-10-28  MORITA Hajime  <morrita@google.com>
1097
1098         Reviewed by Ojan Vafai.
1099
1100         spellcheck does not check pasted text
1101         https://bugs.webkit.org/show_bug.cgi?id=40092
1102
1103         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
1104         to control the setting.
1105
1106         * DumpRenderTree/LayoutTestController.cpp:
1107         (setAsynchronousSpellCheckingEnabledCallback):
1108         (LayoutTestController::staticFunctions):
1109         * DumpRenderTree/LayoutTestController.h:
1110         * DumpRenderTree/chromium/LayoutTestController.h:
1111         * DumpRenderTree/chromium/LayoutTestController.cpp:
1112         (LayoutTestController::LayoutTestController):
1113         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1114         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1115         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1116         * DumpRenderTree/mac/DumpRenderTree.mm:
1117         (resetDefaultsToConsistentValues):
1118         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1119         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1120         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1121         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1122         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1123         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1124         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1125         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1126         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1127
1128 2010-12-12  Sam Weinig  <sam@webkit.org>
1129
1130         Reviewed by Anders Carlsson.
1131
1132         Fix failing API test. It turns out that a pop-state event
1133         is sent before every fragment navigation, so we have to test
1134         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
1135
1136         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1137         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1138
1139 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
1140
1141         Reviewed by Eric Seidel.
1142
1143         [GTK] Add new-run-webkit-tests support to gtk
1144         https://bugs.webkit.org/show_bug.cgi?id=50681
1145
1146         Adding the basic support to run the new-run-webkit-tests.
1147
1148         * Scripts/webkitpy/layout_tests/port/gtk.py:
1149
1150 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
1151
1152         Reviewed by Kenneth Rohde Christiansen.
1153
1154         [Qt] Mock DeviceOrientation client for DRT
1155         https://bugs.webkit.org/show_bug.cgi?id=47490
1156
1157         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1158         (WebCore::DumpRenderTree::DumpRenderTree):
1159         (WebCore::DumpRenderTree::~DumpRenderTree):
1160         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1161         (LayoutTestController::setMockDeviceOrientation):
1162
1163 2010-12-11  Philippe Normand  <pnormand@igalia.com>
1164
1165         Reviewed by Gustavo Noronha Silva.
1166
1167         [GTK] launcher: disable the Mozilla-style fullscreen API
1168         https://bugs.webkit.org/show_bug.cgi?id=50874
1169
1170         Disabling the fullscreen API until its implementation for GTK is
1171         mature enough. The webview setting for it is already FALSE by
1172         default.
1173
1174         * GtkLauncher/main.c:
1175         (createWindow):
1176
1177 2010-12-10  Eric Seidel  <eric@webkit.org>
1178
1179         Reviewed by Adam Barth.
1180
1181         commit-queue flaky test messages show cryptic version information for mac os x
1182         https://bugs.webkit.org/show_bug.cgi?id=50864
1183
1184         Turns out platform.platform() returns kernel version information
1185         which isn't helpful, and just plain confusing on Mac
1186         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
1187
1188         So I've updated PlatformInfo.display_name() to special case
1189         mac.  I also found a bad use of sys.platform in the process
1190         and fixed that.  (sys.platform always returns 'darwin' on mac).
1191
1192         * Scripts/webkitpy/common/system/platforminfo.py:
1193         * Scripts/webkitpy/common/system/user.py:
1194         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1195         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1196         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1197
1198 2010-12-10  Eric Seidel  <eric@webkit.org>
1199
1200         Unreviewed.
1201
1202         Exception seen while reporting flaky test with commit-queue.
1203         Just a missing include.
1204
1205         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1206         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1207
1208 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
1209
1210         Reviewed by Eric Seidel.
1211
1212         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
1213         https://bugs.webkit.org/show_bug.cgi?id=50796
1214
1215         Also updating the test code to use JSONResultsGeneratorBase and
1216         to improve test coverage for incremental cases.
1217
1218         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1219         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1220
1221 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
1222
1223         Reviewed by Darin Adler.
1224
1225         prepare-ChangeLog --help doesn't mention --bug shorthand -b
1226         https://bugs.webkit.org/show_bug.cgi?id=50835
1227
1228         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
1229
1230 2010-12-10  Eric Seidel  <eric@webkit.org>
1231
1232         Reviewed by Adam Barth.
1233
1234         Bugs created by the commit-queue should all block on a master bug
1235         https://bugs.webkit.org/show_bug.cgi?id=50857
1236
1237         This makes all bugs created by the commit-queue block on:
1238         https://bugs.webkit.org/show_bug.cgi?id=50856
1239
1240         In the process of testing this, I found that the existing
1241         create_bug code was wrong.  I also found that existing
1242         unit tests for create-rollout used invalid values
1243         for options.blocks.  I fixed both issues and tested.
1244
1245         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1246         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1247         * Scripts/webkitpy/tool/commands/commandtest.py:
1248         * Scripts/webkitpy/tool/commands/download_unittest.py:
1249         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1250         * Scripts/webkitpy/tool/mocktool.py:
1251         * Scripts/webkitpy/tool/steps/options.py:
1252
1253 2010-12-10  Eric Seidel  <eric@webkit.org>
1254
1255         Reviewed by Adam Barth.
1256
1257         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
1258         https://bugs.webkit.org/show_bug.cgi?id=50853
1259
1260         I also discovered when doing this that the code was posting
1261         the comment on the wrong bug, but that's fixed here too.
1262
1263         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1264         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1265         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1266         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1267         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1268         * Scripts/webkitpy/tool/mocktool.py:
1269
1270 2010-12-10  Anders Carlsson  <andersca@apple.com>
1271
1272         Reviewed by John Sullivan.
1273
1274         Make WKContextGetStatistics gather global statistics
1275         https://bugs.webkit.org/show_bug.cgi?id=50850
1276
1277         Remove the code that gets the statistics and fills in the per context
1278         statistics information for now.
1279
1280         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1281         (-[BrowserStatisticsWindowController refreshStatistics:]):
1282
1283 2010-12-10  Eric Seidel  <eric@webkit.org>
1284
1285         Unreviewed.
1286
1287         commit-queue should report port/platform information when commenting on flaky test bugs
1288         https://bugs.webkit.org/show_bug.cgi?id=50839
1289
1290         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1291         which was only used by new run webkit tests (and clearly not unit tested).
1292
1293         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1294         * Scripts/webkitpy/tool/main.py:
1295         * Scripts/webkitpy/tool/mocktool.py:
1296
1297 2010-12-10  Eric Seidel  <eric@webkit.org>
1298
1299         Reviewed by Tony Chang.
1300
1301         commit-queue should report port/platform information when commenting on flaky test bugs
1302         https://bugs.webkit.org/show_bug.cgi?id=50839
1303
1304         This was a suggestion from Tony Chang this morning.
1305         I added a platform.py class so I could easily mock the platform call,
1306         but that may not be the final solution for this mocking.
1307         We'll try it and see.
1308
1309         * Scripts/webkitpy/common/system/platform.py: Added.
1310         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1311         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1312         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1313         * Scripts/webkitpy/tool/main.py:
1314         * Scripts/webkitpy/tool/mocktool.py:
1315
1316 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1317
1318         Reviewed by Joseph Pecoraro.
1319
1320         Bug 43455 - [Qt]: Implement Application Cache Quotas
1321         https://bugs.webkit.org/show_bug.cgi?id=43455
1322
1323         Introduce functions to allow new appcache layout test origin-quota.html
1324         to work correctly under Qt.
1325
1326         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1327         (WebCore::DumpRenderTree::DumpRenderTree):
1328         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1329         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1330
1331         Introduce functions to allow new appcache layout test origin-quota.html
1332         to be successful under qt. Changes required because LayoutTestControllerQt
1333         does not inherit from LayoutController.
1334
1335         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1336         (LayoutTestController::reset):
1337         (LayoutTestController::clearAllApplicationCaches):
1338         (LayoutTestController::setApplicationCacheOriginQuota):
1339         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1340         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1341         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1342
1343 2010-12-10  Eric Seidel  <eric@webkit.org>
1344
1345         Reviewed by Adam Barth.
1346
1347         Move buildbot.py into its own module so we can split it out into one-file-per-class
1348         https://bugs.webkit.org/show_bug.cgi?id=50806
1349
1350         We're adding more buildbot logic these days, so it makes sense
1351         to give buildbot its own module.
1352
1353         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1354         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1355         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1356         * Scripts/webkitpy/common/net/failuremap.py:
1357         * Scripts/webkitpy/common/net/regressionwindow.py:
1358         * Scripts/webkitpy/tool/commands/rebaseline.py:
1359
1360 2010-12-10  Tony Chang  <tony@chromium.org>
1361
1362         Reviewed by Eric Seidel.
1363
1364         Use FileSystem::remove when cleaning up http lock files
1365         https://bugs.webkit.org/show_bug.cgi?id=50830
1366
1367         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1368
1369 2010-12-10  Joone Hur  <joone@kldp.org>
1370
1371         Reviewed by Martin Robinson.
1372
1373         [GTK] DRT needs layoutTestController.setCacheModel
1374         https://bugs.webkit.org/show_bug.cgi?id=50705
1375         
1376         webkit_set_cache_mode() is called to set the cache model.
1377         
1378         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1379         (LayoutTestController::setCacheModel): Set the cache model. 
1380
1381 2010-12-10  Tony Chang  <tony@chromium.org>
1382
1383         Reviewed by Ojan Vafai.
1384
1385         [chromium] remove --use-drt and add --use-test-shell
1386         https://bugs.webkit.org/show_bug.cgi?id=50701
1387
1388         * Scripts/webkitpy/common/config/ports.py:
1389         * Scripts/webkitpy/common/config/ports_unittest.py:
1390         * Scripts/webkitpy/layout_tests/port/chromium.py:
1391         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1392         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1393         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1394         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1395         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1396         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1397         * Scripts/webkitpy/layout_tests/port/webkit.py:
1398         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1399         * Scripts/webkitpy/style/checkers/test_expectations.py:
1400         * Scripts/webkitpy/tool/commands/queries.py:
1401
1402 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1403
1404         Reviewed by Steve Block.
1405
1406         [Chromium] Implement mocks for client-based geolocation
1407         https://bugs.webkit.org/show_bug.cgi?id=46895
1408
1409         * DumpRenderTree/chromium/LayoutTestController.cpp:
1410         (LayoutTestController::setGeolocationPermission):
1411         (LayoutTestController::setMockGeolocationPosition):
1412         (LayoutTestController::setMockGeolocationError):
1413         * DumpRenderTree/chromium/LayoutTestController.h:
1414         * DumpRenderTree/chromium/WebViewHost.cpp:
1415         (WebViewHost::geolocationClient):
1416         (WebViewHost::geolocationClientMock):
1417         (WebViewHost::reset):
1418         * DumpRenderTree/chromium/WebViewHost.h:
1419
1420 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1421
1422         Reviewed by Martin Robinson.
1423
1424         [GTK] Add hasSpellingMarker support to the DRT
1425         https://bugs.webkit.org/show_bug.cgi?id=50739
1426
1427         Implemented the hasSpellingMarker to support spelling tests.
1428
1429         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1430         (LayoutTestController::hasSpellingMarker):
1431
1432 2010-12-10  Eric Seidel  <eric@webkit.org>
1433
1434         Reviewed by Ojan Vafai.
1435
1436         webkit-patch: not possible to use build-and-test with local commits
1437         https://bugs.webkit.org/show_bug.cgi?id=33378
1438
1439         Make --no-clean not even check if we have local commits.
1440         It's unclear to me why the code was originally written this way.
1441         I was unable to dig up a reason from svn history.
1442
1443         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1444         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1445
1446 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1447
1448         Reviewed by Martin Robinson.
1449
1450         [GTK] AX: implement isEnabled in DRT
1451         https://bugs.webkit.org/show_bug.cgi?id=50814
1452
1453         Implement AccessibilityUIElement::isEnabled() for GTK.
1454
1455         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1456         (checkElementState): New function to refactor common code.
1457         (AccessibilityUIElement::isEnabled): Implement this by checking
1458         the current state of the AtkObject.
1459         (AccessibilityUIElement::isSelected): Use the new
1460         checkElementState function.
1461
1462 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1463
1464         Reviewed by Kenneth Rohde Christiansen.
1465
1466         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1467         https://bugs.webkit.org/show_bug.cgi?id=50750
1468
1469         * MiniBrowser/qt/BrowserView.cpp:
1470         (BrowserView::BrowserView):
1471         * MiniBrowser/qt/BrowserView.h:
1472         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1473         (WTR::WebView::WebView):
1474
1475 2010-12-10  Joone Hur  <joone@kldp.org>
1476
1477         Reviewed by Xan Lopez.
1478
1479         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1480         https://bugs.webkit.org/show_bug.cgi?id=50808
1481
1482         Unskipping the following test cases:
1483         userscripts/mixed-case-stylesheet.html
1484         userscripts/simple-stylesheet.html
1485         userscripts/user-style-all-frames.html
1486
1487         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1488         (LayoutTestController::addUserStyleSheet):
1489
1490 2010-12-10  Joone Hur  <joone@kldp.org>
1491
1492         Reviewed by Eric Seidel.
1493
1494         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1495         https://bugs.webkit.org/show_bug.cgi?id=50783
1496
1497         This patch allows to unskip the following test cases:
1498         printing/page-rule-selection.html
1499         printing/page-format-data.html
1500
1501         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1502         (LayoutTestController::pageProperty): Added.
1503         (LayoutTestController::isPageBoxVisible): Ditto.
1504         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1505         (LayoutTestController::addUserStyleSheet): Ditto.
1506
1507 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1508
1509         Reviewed by Kenneth Rohde Christiansen.
1510
1511         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1512
1513         A menu allows to switch QNAM back to the same thread.
1514
1515         * QtTestBrowser/launcherwindow.cpp:
1516         (LauncherWindow::initializeView):
1517         (LauncherWindow::createChrome):
1518         (LauncherWindow::toggleThreadedQnam):
1519         * QtTestBrowser/launcherwindow.h:
1520         (WindowOptions::WindowOptions):
1521         * QtTestBrowser/webpage.cpp:
1522         (WebPage::WebPage):
1523         (WebPage::setQnamThreaded):
1524         * QtTestBrowser/webpage.h:
1525         (QnamThread::QnamThread):
1526         (QnamThread::~QnamThread):
1527         (QnamThread::networkAccessManager):
1528         (QnamThread::run):
1529
1530 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1531
1532         Reviewed by Xan Lopez.
1533
1534         [Gtk] style="font-family: courier" makes text disappear
1535         https://bugs.webkit.org/show_bug.cgi?id=47452
1536
1537         Add a test that verifies that fonts without valid charmaps are
1538         never selected.
1539
1540         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1541         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1542         that has no valid charmap.
1543         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1544         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1545         settings which may disable selection of bitmap fonts.
1546
1547 2010-12-10  Eric Seidel  <eric@webkit.org>
1548
1549         Unreviewed.
1550
1551         The commit-queue should file bugs about flaky tests it encounters
1552         https://bugs.webkit.org/show_bug.cgi?id=50803
1553
1554         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1555         Now it's tested.
1556
1557         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1558         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1559
1560 2010-12-10  Eric Seidel  <eric@webkit.org>
1561
1562         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1563
1564         The commit-queue should file bugs about flaky tests it encounters
1565         https://bugs.webkit.org/show_bug.cgi?id=50803
1566
1567         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1568
1569 2010-12-09  Eric Seidel  <eric@webkit.org>
1570
1571         Reviewed by Adam Barth.
1572
1573         The commit-queue should file bugs about flaky tests it encounters
1574         https://bugs.webkit.org/show_bug.cgi?id=50803
1575
1576         This change got a bit big.  I also added a new config.urls file
1577         because I needed to share the view_source_url code with committervalidator.py.
1578
1579         This adds a new class FlakyTestReporter which holds all the logic about
1580         reporting flaky tests to bugzilla.
1581
1582         Right now this code knows how to look up bugs for flaky tests.
1583         If it can't find a bug filed from the commit-queue, it will open a new
1584         one, ccing the relevant people and adding information about the failure.
1585
1586         It is not yet smart enough to chase down duplicate chains, or to include
1587         the actual failure diff.  But those can be added in later iterations.
1588
1589         * Scripts/webkitpy/common/checkout/api.py:
1590         * Scripts/webkitpy/common/checkout/changelog.py:
1591         * Scripts/webkitpy/common/checkout/commitinfo.py:
1592         * Scripts/webkitpy/common/config/committervalidator.py:
1593         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1594         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1595         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1596         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1597         * Scripts/webkitpy/tool/bot/irc_command.py:
1598         * Scripts/webkitpy/tool/bot/sheriff.py:
1599         * Scripts/webkitpy/tool/commands/download.py:
1600         * Scripts/webkitpy/tool/commands/queues.py:
1601         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1602         * Scripts/webkitpy/tool/comments.py:
1603         * Scripts/webkitpy/tool/mocktool.py:
1604         * Scripts/webkitpy/tool/steps/commit.py:
1605
1606 2010-12-09  Eric Seidel  <eric@webkit.org>
1607
1608         Reviewed by Adam Barth.
1609
1610         Teach webkit-patch how to search bugzilla
1611         https://bugs.webkit.org/show_bug.cgi?id=50500
1612
1613         This is a step towards teaching webkitpy how to file
1614         new bugs for flaky tests and update them when new flakes occur.
1615
1616         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1617         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1618         * Scripts/webkitpy/tool/commands/__init__.py:
1619         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1620
1621 2010-12-09  Adam Barth  <abarth@webkit.org>
1622
1623         Reviewed by Ojan Vafai.
1624
1625         commit-queue errors out due to local commits
1626         https://bugs.webkit.org/show_bug.cgi?id=50766
1627
1628         We seem to be tripping over having local commits in the working copy a
1629         lot recently.  I don't quite fully understand what the issue is, but
1630         this patch attempts to solve the problem by adding an explicit clean
1631         step before processing a patch.  Previously, we did the cleaning as
1632         part of the apply-attachment step, so this might not actually fix the
1633         problem.
1634
1635         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1636         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1637         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1638
1639 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1640
1641         Reviewed by Ojan Vafai.
1642
1643         Make new-run-webkit-tests --lint-test-files log slightly better
1644         messages and return -1 if lint fails. Remove the
1645         'suppress_errors' keyword param to the TestExpectationsFile
1646         class, and clean up logging and exception raising for error
1647         handling. Also add more unit tests and clean up the unit test code a bit.
1648
1649         https://bugs.webkit.org/show_bug.cgi?id=50205
1650
1651         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1652         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1653         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1654         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1655         * Scripts/webkitpy/layout_tests/port/chromium.py:
1656         * Scripts/webkitpy/style/checkers/test_expectations.py:
1657         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1658
1659 2010-12-09  Tony Chang  <tony@chromium.org>
1660
1661         Unreviewed, fix for windows code.  We were catching the wrong
1662         exception in Windows.
1663
1664         * Scripts/webkitpy/common/system/filesystem.py:
1665
1666 2010-12-09  Antonio Gomes  <agomes@rim.com>
1667
1668         Reviewed by Martin Robinson.
1669
1670         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1671         https://bugs.webkit.org/show_bug.cgi?id=48429
1672
1673         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1674
1675         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1676         (LayoutTestController::workerThreadCount):
1677
1678 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1679
1680         Reviewed by Martin Robinson.
1681
1682         [GTK] Support the Mozilla-style Fullscreen Javascript API
1683         https://bugs.webkit.org/show_bug.cgi?id=50572
1684
1685         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1686         make DRT update the Chrome when the WebView settings have been
1687         reset to consistent values.
1688
1689         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1690         (resetDefaultsToConsistentValues):
1691         * GtkLauncher/main.c:
1692         (create_window):
1693         * Scripts/build-webkit:
1694
1695 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1696
1697         Reviewed by Tor Arne Vestbø
1698
1699         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1700         https://bugs.webkit.org/show_bug.cgi?id=50742
1701
1702         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1703
1704         * Scripts/webkitdirs.pm:
1705
1706 2010-12-09  Joone Hur  <joone@kldp.org>
1707
1708          Reviewed by Martin Robinson.
1709
1710          [GTK] Support for viewport meta tag
1711          https://bugs.webkit.org/show_bug.cgi?id=45443
1712
1713          Add support for testing the viewport properties for WebKitGtk.
1714
1715          * DumpRenderTree/LayoutTestController.cpp:
1716          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1717          (LayoutTestController::staticFunctions):
1718          * DumpRenderTree/LayoutTestController.h:
1719          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1720          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1721          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1722          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1723          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1724          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1725          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1726          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1727          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1728          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1729
1730 2010-12-08  William Siegrist <wsiegrist@apple.com>
1731
1732         Reviewed by Eric Seidel.
1733
1734         Migrate buildbot.py from xmlrpc to json.
1735         https://bugs.webkit.org/show_bug.cgi?id=50647
1736
1737         * Scripts/webkitpy/common/net/buildbot.py:
1738
1739 2010-12-08  Tony Chang  <tony@chromium.org>
1740
1741         Reviewed by Eric Seidel.
1742
1743         make starting the websocket server more reliable on windows
1744         https://bugs.webkit.org/show_bug.cgi?id=50712
1745
1746         * Scripts/webkitpy/common/system/filesystem.py:
1747         (remove): Substitute method for os.remove to retry on error on Windows
1748         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1749         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1750
1751 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1752
1753         Reviewed by Adam Roben.
1754
1755         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1756         https://bugs.webkit.org/show_bug.cgi?id=50656
1757
1758         * MiniBrowser/mac/BrowserWindowController.m:
1759         (-[BrowserWindowController awakeFromNib]):
1760         Indicate that exceededDatabaseQuota is not implemented.
1761         * MiniBrowser/win/BrowserView.cpp:
1762         (BrowserView::create):
1763         Ditto.
1764         * WebKitTestRunner/TestController.cpp:
1765         (WTR::createOtherPage):
1766         Ditto.
1767         (WTR::TestController::initialize):
1768         Ditto.
1769
1770 2010-12-08  Antonio Gomes  <agomes@rim.com>
1771
1772         Reviewed by Martin Robinson.
1773
1774         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1775         https://bugs.webkit.org/show_bug.cgi?id=48429
1776
1777         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1778         * webkit_gc_collect_javascript_objects;
1779         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1780         * webkit_gc_count_javascript_objects;
1781         * webkit_web_frame_layout.
1782
1783         These were all only used by GTK+ DRT.
1784
1785         * DumpRenderTree/gtk/EventSender.cpp:
1786         (dispatchEvent):
1787         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1788         (GCController::collect):
1789         (GCController::collectOnAlternateThread):
1790         (GCController::getJSObjectCount):
1791
1792 2010-12-07  Tony Chang  <tony@chromium.org>
1793
1794         Reviewed by Ojan Vafai.
1795
1796         [chromium] force NRWT to use DRT
1797         https://bugs.webkit.org/show_bug.cgi?id=50359
1798
1799         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1800
1801 2010-12-06  Sam Weinig  <sam@webkit.org>
1802
1803         Reviewed by Anders Carlsson.
1804
1805         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1806         https://bugs.webkit.org/show_bug.cgi?id=50584
1807
1808         * MiniBrowser/mac/BrowserWindowController.m:
1809         (didSameDocumentNavigationForFrame):
1810         (-[BrowserWindowController awakeFromNib]):
1811         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1812         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1813         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1814         (TestWebKitAPI::TEST):
1815         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1816         (WTR::InjectedBundlePage::InjectedBundlePage):
1817         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1818         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1819         * WebKitTestRunner/TestController.cpp:
1820         (WTR::TestController::initialize):
1821
1822 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1823
1824         Reviewed by Ojan Vafai.
1825
1826         Make TestResultsServer return 404 for non-existing results files.
1827         https://bugs.webkit.org/show_bug.cgi?id=50581
1828
1829         * TestResultServer/handlers/testfilehandler.py:
1830
1831 2010-12-06  Tony Chang  <tony@chromium.org>
1832
1833         Reviewed by Ojan Vafai.
1834
1835         [chromium] fix an assert hit in DRT
1836         https://bugs.webkit.org/show_bug.cgi?id=50575
1837
1838         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1839         semantics.
1840
1841         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1842         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1843         WTF::RefCountedBase::ref()).
1844
1845         * DumpRenderTree/chromium/TestWebWorker.h:
1846         (TestWebWorker::TestWebWorker):
1847
1848 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1849
1850         Reviewed by Eric Seidel.
1851
1852         make webkit-patch command work when the git branch is not synced to the remote svn branch
1853         https://bugs.webkit.org/show_bug.cgi?id=50424
1854
1855         * Scripts/webkitpy/common/checkout/scm.py:
1856         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1857
1858 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1859
1860         Reviewed by Andreas Kling.
1861
1862         [WINCE] Add build system
1863         https://bugs.webkit.org/show_bug.cgi?id=50522
1864
1865         * CMakeListsWinCE.txt: Added.
1866
1867 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1868
1869         Reviewed by Tony Chang.
1870
1871         Allow the Chromium port to have Leopard-specific baselines
1872         https://bugs.webkit.org/show_bug.cgi?id=50506
1873
1874         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1875
1876 2010-12-03  Tony Chang  <tony@chromium.org>
1877
1878         Reviewed by Kent Tamura.
1879
1880         [chromium] fix 2 bugs with inspector tests in DRT
1881         https://bugs.webkit.org/show_bug.cgi?id=50492
1882
1883         Tasks can outlive the tasklist (even when canceled) so this was
1884         causing a crash when ~WebTask() ran.  Avoid this by unregistering
1885         when a task is canceled.
1886
1887         Also fix an assert when closing devtool windows by copying some
1888         logic from test_shell.
1889
1890         * DumpRenderTree/chromium/Task.cpp:
1891         (WebTask::~WebTask):
1892         (TaskList::revokeAll):
1893         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
1894             the tasklist (since the task can outlive the tasklist).
1895         * DumpRenderTree/chromium/TestShell.h:
1896         (TestShell::devToolsWebView):
1897         * DumpRenderTree/chromium/WebViewHost.cpp:
1898         (WebViewHost::~WebViewHost): Don't load about:blank when closing
1899             a window if the window has devtools loaded.  This avoids an
1900             ASSERT and matches test_shell.
1901
1902 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
1903
1904         Reviewed by Martin Robinson.
1905
1906         [GTK] Fix GtkLauncher.c style, use webkit style
1907         https://bugs.webkit.org/show_bug.cgi?id=50542
1908
1909         * GtkLauncher/main.c:
1910         (activateUriEntryCb):
1911         (updateTitle):
1912         (linkHoverCb):
1913         (notifyTitleCb):
1914         (notifyLoadStatusCb):
1915         (notifyProgressCb):
1916         (destroyCb):
1917         (goBackCb):
1918         (goForwardCb):
1919         (create_webViewCb):
1920         (webViewReadyCb):
1921         (closeWebViewCb):
1922         (createBrowser):
1923         (createStatusbar):
1924         (createToolbar):
1925         (createWindow):
1926         (main):
1927
1928 2010-12-04  Antonio Gomes  <agomes@rim.com>
1929
1930         Reviewed by Martin Robinson.
1931
1932         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
1933         https://bugs.webkit.org/show_bug.cgi?id=48429
1934
1935         Moved more private method declared with WEBKIT_API to
1936         DumpRenderTreeSupportGtk, since they were only being used by DRT.
1937
1938         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1939         (resetDefaultsToConsistentValues):
1940         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1941         (LayoutTestController::addOriginAccessWhitelistEntry):
1942         (LayoutTestController::execCommand):
1943         (LayoutTestController::isCommandEnabled):
1944
1945 2010-12-04  Antonio Gomes  <agomes@rim.com>
1946
1947         Reviewed by Andreas Kling.
1948
1949         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
1950
1951         Method was removed by http://trac.webkit.org/changeset/71604
1952
1953         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1954
1955 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
1956
1957         Reviewed by Xan Lopez.
1958
1959         [GTK] Fix compilation warnings reported by clang
1960         https://bugs.webkit.org/show_bug.cgi?id=50252
1961
1962         * GtkLauncher/main.c:
1963         (create_window): The create_statusbar function does not have
1964         parameters.
1965
1966 2010-12-05  Robert Hogan  <robert@webkit.org>
1967
1968         Reviewed by Andreas Kling.
1969
1970         [Qt] Zero-sized font does not yet work
1971
1972         Fix fast/text/font-size-zero.html
1973
1974         Copy other ports by setting minimumFontSize to 0 for DRT runs.
1975
1976         https://bugs.webkit.org/show_bug.cgi?id=49759
1977
1978         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1979         (WebCore::WebPage::WebPage):
1980
1981 2010-12-04  Sam Weinig  <sam@webkit.org>
1982
1983         Reviewed by Jon Honeycutt.
1984
1985         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
1986         https://bugs.webkit.org/show_bug.cgi?id=50511
1987
1988         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
1989         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
1990
1991         * MiniBrowser/mac/BrowserWindowController.m:
1992         (didChangeLocationWithinPageForFrame):
1993         (-[BrowserWindowController awakeFromNib]):
1994         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
1995         * TestWebKitAPI/PlatformUtilities.cpp:
1996         (TestWebKitAPI::Util::toWK):
1997         * TestWebKitAPI/PlatformUtilities.h:
1998         (TestWebKitAPI::Util::adoptWK):
1999         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2000         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2001         (TestWebKitAPI::nullJavaScriptCallback):
2002         (TestWebKitAPI::didFinishLoadForFrame):
2003         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2004         (TestWebKitAPI::TEST):
2005         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2006         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2007         * TestWebKitAPI/win/copy-resources.cmd:
2008         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2009         (WTR::InjectedBundlePage::InjectedBundlePage):
2010         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2011         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2012         * WebKitTestRunner/TestController.cpp:
2013         (WTR::TestController::initialize):
2014
2015 2010-11-08  Antonio Gomes  <agomes@rim.com>
2016
2017         Reviewed by Martin Robinson.
2018
2019         [Gtk] Populate DumpRenderTreeSupportGtk
2020         https://bugs.webkit.org/show_bug.cgi?id=48429
2021
2022         Made the previous calls to webkit_web_frame* functions defined as private
2023         APIs in webkitprivate.h go through DRTSupportGtk.
2024
2025         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2026         (AccessibilityController::focusedElement):
2027         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2028         (dumpFramesAsText):
2029         (resetDefaultsToConsistentValues):
2030         (dump):
2031         (webViewDocumentLoadFinished):
2032         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2033         (LayoutTestController::counterValueForElementById):
2034         (LayoutTestController::pageNumberForElementById):
2035         (LayoutTestController::numberOfPages):
2036         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2037         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2038         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2039         (LayoutTestController::numberOfActiveAnimations):
2040         (LayoutTestController::suspendAnimations):
2041         (LayoutTestController::resumeAnimations):
2042         (LayoutTestController::markerTextForListItem):
2043
2044 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2045
2046         Reviewed by Tony Chang.
2047
2048         Rebaseline server: use pretty text diff output
2049         https://bugs.webkit.org/show_bug.cgi?id=50484
2050         
2051         Serve *-pretty-diff.html for text diff output.
2052
2053         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2054         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2055         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2056         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2057
2058 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2059
2060         Unreviewed, rolling out r73302.
2061         http://trac.webkit.org/changeset/73302
2062         https://bugs.webkit.org/show_bug.cgi?id=50499
2063
2064         Causes crashes in debug LayoutTests (Requested by xan_ on
2065         #webkit).
2066
2067         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2068         (AccessibilityUIElement::AccessibilityUIElement):
2069         (AccessibilityUIElement::parentElementCallback):
2070         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2071         * DumpRenderTree/chromium/CppBoundClass.cpp:
2072         * DumpRenderTree/chromium/CppBoundClass.h:
2073
2074 2010-12-03  Sam Weinig  <sam@webkit.org>
2075
2076         Reviewed by Maciej Stachowiak.
2077
2078         Enable <a ping> for Mac/Windows/WebKit2 builds
2079         <rdar://problem/8504473>
2080         https://bugs.webkit.org/show_bug.cgi?id=50488
2081
2082         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2083         (TestWebKitAPI::TEST): Test that the default value of
2084         WKPreferencesGetHyperlinkAuditingEnabled is true.
2085
2086 2010-12-03  Chris Guillory  <chris.guillory@google.com>
2087
2088         Reviewed by Chris Fleizach.
2089
2090         Include the FrameView widget of a RenderWidget in the accessibility tree.
2091         https://bugs.webkit.org/show_bug.cgi?id=49106
2092
2093         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2094         (AccessibilityUIElement::AccessibilityUIElement):
2095         (AccessibilityUIElement::parentElementCallback):
2096         (AccessibilityUIElement::isEqualCallback):
2097         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2098         * DumpRenderTree/chromium/CppBoundClass.cpp:
2099         (CppBoundClass::getFromCppVariant):
2100         * DumpRenderTree/chromium/CppBoundClass.h:
2101
2102 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2103
2104         Reviewed by Tony Chang.
2105
2106         Rebaseline server: organize tests by state, add dry run mode
2107         https://bugs.webkit.org/show_bug.cgi?id=50473
2108         
2109         Group tests in the menu by state, so that it's easier to see after
2110         processing the queue which failed.
2111         
2112         Add support for the --dry-run flag so that it's easier to test changes
2113         such as this (stubs out filesystem and SCM operations).
2114
2115         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2116         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2117         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2118
2119 2010-12-03  Brady Eidson  <beidson@apple.com>
2120
2121         Reviewed by Anders Carlsson.
2122
2123         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
2124         WebKit2 Authentication Support
2125
2126         Keep these builds working:
2127         * MiniBrowser/mac/BrowserWindowController.m:
2128         (-[BrowserWindowController awakeFromNib]):
2129
2130         * WebKitTestRunner/TestController.cpp:
2131         (WTR::TestController::initialize):
2132
2133 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
2134
2135         Reviewed by Tony Chang.
2136
2137         Rebaseline server: move existing baselines
2138         https://bugs.webkit.org/show_bug.cgi?id=50421
2139         
2140         Implement moving of existing baselines: move all files that are about
2141         to be overwriten by update baselines.
2142         
2143         Also fix a typo in the UI JS.
2144
2145         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2146         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2147         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2148
2149 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2150
2151         Unreviewed, rolling out r73211.
2152         http://trac.webkit.org/changeset/73211
2153         https://bugs.webkit.org/show_bug.cgi?id=50450
2154
2155         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
2156         yutak on #webkit).
2157
2158         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2159
2160 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2161
2162         Unreviewed, rolling out r73222.
2163         http://trac.webkit.org/changeset/73222
2164         https://bugs.webkit.org/show_bug.cgi?id=50449
2165
2166         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2167         (Requested by yutak on #webkit).
2168
2169         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2170         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2171         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2172         * Scripts/webkitpy/layout_tests/port/base.py:
2173         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2174         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2175
2176 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2177
2178         Unreviewed, rolling out r73228.
2179         http://trac.webkit.org/changeset/73228
2180         https://bugs.webkit.org/show_bug.cgi?id=50448
2181
2182         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2183         (Requested by yutak on #webkit).
2184
2185         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2186         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2187         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2188         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2189         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2190
2191 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2192
2193         Unreviewed, rolling out r73231.
2194         http://trac.webkit.org/changeset/73231
2195         https://bugs.webkit.org/show_bug.cgi?id=50443
2196
2197         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
2198         (Requested by yutak on #webkit).
2199
2200         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2201         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2202         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2203         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2204
2205 2010-12-03  David Levin  <levin@chromium.org>
2206
2207         Reviewed by Shinichiro Hamaji.
2208
2209         check-webkit-style: false positive reported for #if macro
2210         https://bugs.webkit.org/show_bug.cgi?id=48242
2211
2212         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
2213           all preprocessor commands.
2214         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2215
2216 2010-12-02  Eric Seidel  <eric@webkit.org>
2217
2218         Reviewed by Adam Barth.
2219
2220         Update the EWSTools scripts to use modern-style git repos
2221         https://bugs.webkit.org/show_bug.cgi?id=50402
2222
2223         * EWSTools/create-webkit-git:
2224         * EWSTools/start-commit-queue.sh:
2225         * EWSTools/start-queue.sh:
2226
2227 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2228
2229         Fix Chromium Linux plugin tests by not logging
2230         unconditionally from the event handling code.
2231
2232         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2233         (handleEventX11):
2234
2235 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2236
2237         Reviewed by Tony Chang.
2238
2239         nrwt multiprocessing - move logic back into run_webkit_tests
2240
2241         This change moves a bunch of logic that I had put into
2242         message_broker back into run_webkit_tests, in a slightly
2243         different format. WorkerMessageBroker needed to become less aware of
2244         the logic the TestRunner class uses, and more generic.
2245         Eventually the MessageBroker will only do generic messaging and
2246         thread/process-pooling, and (almost) all of the
2247         run-webkit-tests-specific logic will be moved to
2248         run_webkit_tests.py and dump_render_tree_thread.py.
2249         
2250         The biggest changes are that the Broker can now start a single
2251         worker, but the responsibility for starting all of them is pushed
2252         back to the TestRunner (Manager), and the logic for checking if
2253         the threads are done or wedged is moved back to TestRunner. We
2254         also remove WorkerMessageBroker.cleanup (not needed) and
2255         cancel_workers (they have to be cancelled individually).
2256         
2257         The  message_broker is now encapsulated inside
2258         TestRunner._run_tests(); it only needs to exist while actually
2259         running the tests.
2260
2261         Also, delete a bunch of tests in message_broker_unittest that no
2262         longer make much sense.
2263
2264         This patch depends on bug 50372.
2265
2266         https://bugs.webkit.org/show_bug.cgi?id=50374
2267
2268         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2269         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2270         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2271         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2272         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2273
2274 2010-12-02  Hayato Ito  <hayato@chromium.org>
2275
2276         Reviewed by Eric Seidel.
2277
2278         Refactor test_types's compare_output() method so that it takes a
2279         TestInput object.
2280
2281         compare_output() will need additional information included in a TestInput
2282         object to support reftests. This change is a pre-requirement of that.
2283
2284         https://bugs.webkit.org/show_bug.cgi?id=50362
2285
2286         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2287         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2288         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2289         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2290         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2291
2292 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2293
2294         Reviewed by Anders Carlsson.
2295
2296         Add the ability to run script on 'new' and 'paint' in the test plugin
2297         https://bugs.webkit.org/show_bug.cgi?id=50425
2298         
2299         Add "onnew" and "onpaintevent" attributes to the test plugin,
2300         so that tests can run JS at these times.
2301
2302         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2303         (pluginAllocate):
2304         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2305         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2306         (NPP_New):
2307         (NPP_Destroy):
2308         (handleEventCarbon):
2309         (handleEventCocoa):
2310         (NPP_HandleEvent):
2311
2312 2010-12-02  Sam Weinig  <sam@webkit.org>
2313
2314         Fix Qt build.
2315
2316         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2317         (WTR::PlatformWebView::PlatformWebView):
2318
2319 2010-12-02  Sam Weinig  <sam@webkit.org>
2320
2321         Reviewed by Anders Carlsson.
2322
2323         WebKit2 Preferences should be held off the PageGroup, not the Context
2324         https://bugs.webkit.org/show_bug.cgi?id=50414
2325
2326         Update for API changes.
2327
2328         * WebKitTestRunner/PlatformWebView.h:
2329         * WebKitTestRunner/TestController.cpp:
2330         (WTR::createOtherPage):
2331         (WTR::TestController::initialize):
2332         (WTR::TestController::resetStateToConsistentValues):
2333         * WebKitTestRunner/TestController.h:
2334         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2335         (WTR::PlatformWebView::PlatformWebView):
2336         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2337         (WTR::PlatformWebView::PlatformWebView):
2338
2339 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2340
2341         Reviewed by Tony Chang.
2342
2343         new-run-webkit-tests: minor cleanup for multiprocessing work
2344
2345         This change:
2346         * moves worker naming into TestShellThread, eliminating a
2347           parameter to the constructor and putting the responsibility in
2348           the correct place.
2349         * eliminates the _WorkerState() class in message_broker, because
2350           it turns out that state really needs to be in run_webkit_tests
2351         * renames the Broker classes to be module-private.
2352         * fixes a bunch of minor commenting and whitespace issues to
2353           make subsequent patches a bit clearer.
2354         * Adds a Port hook for default_worker_model() so that we can
2355           accomodate the potential for different worker models on
2356           different ports.
2357         * merge in the fix from 50420 for the brokenness introduced in
2358           bug 50367.
2359
2360         This patch depends on bug 50367.
2361
2362         https://bugs.webkit.org/show_bug.cgi?id=50372
2363
2364         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2365         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2366         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2367         * Scripts/webkitpy/layout_tests/port/base.py:
2368         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2369         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2370
2371 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2372
2373         Reviewed by Tony Chang.
2374
2375         This change is a bunch of cleanup / refactoring of the file
2376         below. It moves a bunch of free functions to methods on the
2377         TestShellThread class, and restructures other methods to be
2378         closer to the structure we'll need for the multiprocessing
2379         rewrite.
2380
2381         It also makes the logic of --run-singly a *lot* easier to follow
2382         by nestling all of the separate-thread logic into a single
2383         routine.
2384
2385         There should be no semantic changes in this patch, just cleanup.
2386
2387         https://bugs.webkit.org/show_bug.cgi?id=50367
2388
2389         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2390
2391 2010-12-02  Tony Chang  <tony@chromium.org>
2392
2393         Unreviewed, rolling out r73164.
2394         http://trac.webkit.org/changeset/73164
2395         https://bugs.webkit.org/show_bug.cgi?id=50359
2396
2397         broke debugger tests on win
2398
2399         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2400
2401 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2402
2403         Reviewed by Tony Chang.
2404
2405         Rebaseline server: add updating of baselines
2406         https://bugs.webkit.org/show_bug.cgi?id=50305
2407         
2408         Implements updating of baselines, where we copy -actual.* files over
2409         the current -expected.* files. To do this, we need a
2410         _get_actual_result_files method to get test results files and a
2411         _rebaseline_test method to actually do the file copy and SCM operation.
2412         _rebaseline_test logs output into a buffer, this is useful for both
2413         showing result in the UI and for unit tests.
2414         
2415         To make passing around of the various test environment properties
2416         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2417         class for them.
2418         
2419         Moving of existing baselines is not implemented yet, this patch is big
2420         enough as it is.
2421
2422         * Scripts/webkitpy/common/system/filesystem.py:
2423         * Scripts/webkitpy/common/system/filesystem_mock.py:
2424         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2425         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2426         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2427         * Scripts/webkitpy/tool/mocktool.py:
2428
2429 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2430
2431         Unreviewed build fix after vcproj updates.
2432
2433         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2434         that WIN_CAIRO is defined for this build.
2435         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2436         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2437         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2438
2439 2010-12-02  Sam Weinig  <sam@webkit.org>
2440
2441         Reviewed by Anders Carlsson.
2442
2443         WebKit2 needs API to turn on popup blocking
2444         https://bugs.webkit.org/show_bug.cgi?id=50407
2445
2446         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2447         (TestWebKitAPI::TEST):
2448         * WebKitTestRunner/TestController.cpp:
2449         (WTR::TestController::resetStateToConsistentValues):
2450
2451 2010-12-01  Tony Chang  <tony@chromium.org>
2452
2453         Reviewed by Ojan Vafai.
2454
2455         [chromium] force NRWT to use DRT
2456         https://bugs.webkit.org/show_bug.cgi?id=50359
2457
2458         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2459
2460 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2461
2462         Reviewed by Xan Lopez.
2463
2464         [GTK] DumpRenderTree has two copies of JavaScriptCore
2465         https://bugs.webkit.org/show_bug.cgi?id=49877
2466
2467         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2468         LDADD list for DumpRenderTree.
2469
2470 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2471
2472         Unreviewed: Added myself to list of Committers.
2473
2474         * Scripts/webkitpy/common/config/committers.py:
2475
2476 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2477
2478         Reviewed by Adam Barth.
2479
2480         build-webkit --chromium always updates DEPS and re-generates project files
2481         https://bugs.webkit.org/show_bug.cgi?id=50340
2482         
2483         Make build-webkit --chromium invoke update-webkit-chromium only when
2484         --update-chromium is passed in, so that we don't add 20 seconds to all
2485         builds.
2486         
2487         Making all invocations update was added with r61883, with the goal of
2488         making EWS bots always update. The bots will switch to using this flag
2489         (as will all other webkit-patch build steps) so nothing should change
2490         for them.
2491
2492         * Scripts/webkitdirs.pm:
2493         * Scripts/webkitpy/common/config/ports.py:
2494         * Scripts/webkitpy/common/config/ports_unittest.py:
2495
2496 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2497
2498         Reviewed by Tony Chang.
2499
2500         new-run-webkit-tests: add a --dry-run / -n flag
2501         https://bugs.webkit.org/show_bug.cgi?id=50045
2502
2503         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2504         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2505
2506 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2507
2508         Reviewed by Adam Roben.
2509
2510         WinCairo build should not use link-time code generation (LTCG)
2511         https://bugs.webkit.org/show_bug.cgi?id=50353
2512
2513         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2514         * DumpRenderTree/win/DumpRenderTree.vcproj:
2515         * DumpRenderTree/win/ImageDiff.vcproj:
2516         * FindSafari/FindSafari.vcproj:
2517         * MiniBrowser/MiniBrowser.vcproj:
2518         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2519         * WebKitAPITest/WebKitAPITest.vcproj:
2520         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2521         * WebKitTestRunner/win/InjectedBundle.vcproj:
2522         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2523         * WinLauncher/WinLauncher.vcproj:
2524         * record-memory-win/record-memory-win.vcproj:
2525
2526 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2527
2528         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2529         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2530         adding the file to the sources list was not enough to force the rebuild.
2531
2532         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2533         Remove an empty line at the end of this file to force a rebuild.
2534
2535 2010-12-01  Sam Weinig  <sam@webkit.org>
2536
2537         Fix windows build.
2538
2539         * MiniBrowser/win/BrowserView.cpp:
2540         (BrowserView::create):
2541
2542 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2543
2544         Add missing file to the TestNetscapePlugin sources list after r73057.
2545
2546         * GNUmakefile.am: Add missing file.
2547
2548 2010-12-01  Sam Weinig  <sam@webkit.org>
2549
2550         Reviewed by Anders Carlsson.
2551
2552         Add PageGrouping to WebKit2 API
2553         https://bugs.webkit.org/show_bug.cgi?id=50332
2554
2555         - Update testing harnesses to deal with new PageGroup API.
2556
2557         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2558         (WKBundleInitialize):
2559         * TestWebKitAPI/InjectedBundleController.cpp:
2560         (TestWebKitAPI::InjectedBundleController::initialize):
2561         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2562         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2563         * TestWebKitAPI/InjectedBundleController.h:
2564         * TestWebKitAPI/InjectedBundleTest.h:
2565         (TestWebKitAPI::InjectedBundleTest::initialize):
2566         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2567         * TestWebKitAPI/PlatformUtilities.cpp:
2568         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2569         * TestWebKitAPI/PlatformUtilities.h:
2570         * TestWebKitAPI/PlatformWebView.h:
2571         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2572         (TestWebKitAPI::TEST):
2573         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2574         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2575         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2576         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2577         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2578         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2579         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2580         (WTR::InjectedBundle::didInitializePageGroup):
2581         (WTR::InjectedBundle::initialize):
2582         (WTR::InjectedBundle::beginTesting):
2583         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2584         (WTR::InjectedBundle::pageGroup):
2585         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2586         (WTR::LayoutTestController::addUserScript):
2587         (WTR::LayoutTestController::addUserStyleSheet):
2588         (WTR::LayoutTestController::setXSSAuditorEnabled):
2589         * WebKitTestRunner/TestController.cpp:
2590         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2591         (WTR::PlatformWebView::PlatformWebView):
2592
2593 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2594
2595         Reviewed by Adam Roben.
2596
2597         vcproj changes can't be applied cleanly by the Windows EWS bot
2598         https://bugs.webkit.org/show_bug.cgi?id=50328
2599
2600         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2601         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2602         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2603         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2604         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2605         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2606         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2607         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2608         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2609         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2610         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2611         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2612         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2613         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2614         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2615         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2616         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2617         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2618         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2619         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2620         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2621         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2622         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2623         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2624         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2625         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2626         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2627         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2628         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2629         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2630         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2631         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2632         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2633         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2634         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2635         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2636         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2637         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2638         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2639         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2640         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2641         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2642         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2643         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2644         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2645
2646 2010-12-01  Anders Carlsson  <andersca@apple.com>
2647
2648         Reviewed by Darin Adler.
2649
2650         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2651         https://bugs.webkit.org/show_bug.cgi?id=50336
2652
2653         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2654         Add new test.
2655
2656         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2657         (PluginTest::NPP_New):
2658         Add default implementation/
2659
2660         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2661         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2662         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2663         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2664         Get the user agent.
2665
2666         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2667         (NPP_New):
2668         Call PluginTest::NPP_New.
2669
2670         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2671         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2672         Add new files.
2673
2674         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2675         (webkit_test_plugin_new_instance):
2676         Call PluginTest::NPP_New.
2677
2678 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2679
2680         [wx] Build fixes after recent trunk changes.
2681
2682         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2683         (LayoutTestController::findString):
2684         * wx/build/settings.py:
2685
2686 2010-12-01  Dan Bernstein  <mitz@apple.com>
2687
2688         Reviewed by Darin Adler.
2689
2690         WebKitTestRunner needs layoutTestController.findString
2691         https://bugs.webkit.org/show_bug.cgi?id=50238
2692
2693         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2694         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2695         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2696         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2697
2698 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2699
2700         Try using svn:eol-style native on a vcproj file.
2701
2702         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2703
2704 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2705
2706         Reviewed by Adam Roben.
2707
2708         [WINCE] Add WinCELauncher
2709         https://bugs.webkit.org/show_bug.cgi?id=50217
2710
2711         * WinCELauncher/main.cpp: Added.
2712
2713 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2714
2715         Reviewed by Kenneth Rohde Christiansen.
2716
2717         [Qt] Implement layoutTestController.findString
2718         https://bugs.webkit.org/show_bug.cgi?id=50236
2719
2720         Add the missing function to the LayoutTestController.
2721
2722         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2723         (LayoutTestController::findString):
2724         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2725
2726 2010-11-30  Tony Chang  <tony@chromium.org>
2727
2728         Reviewed by Adam Barth.
2729
2730         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2731         https://bugs.webkit.org/show_bug.cgi?id=49036
2732
2733         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2734             for CppVariants.
2735         (LayoutTestController::cppVariantToBool):
2736         (LayoutTestController::cppVariantToInt32):
2737         (LayoutTestController::setDatabaseQuota):
2738         (LayoutTestController::evaluateInWebInspector):
2739         (LayoutTestController::setMockGeolocationError):
2740
2741 2010-11-30  Eric Seidel  <eric@webkit.org>
2742
2743         Reviewed by Tony Chang.
2744
2745         update-webkit should call git fetch before git svn rebase
2746         https://bugs.webkit.org/show_bug.cgi?id=50273
2747
2748         After discussion on webkit-dev, we've decided to move the "default"
2749         git setup to pulling updates from git.webkit.org in preference
2750         to rebuilding the local svn index using git svn fetch every time.
2751
2752         This change should have no effect on people using the "old" git setup
2753         and should dramatically increase the speed of updates for those using
2754         the "new" git setup along with update-webkit.  I'm about to move the
2755         EWS and other queues over to this setup once this lands.
2756
2757         * Scripts/update-webkit:
2758
2759 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2760
2761         Reviewed by Xan Lopez.
2762
2763         GTK: AX: implement press in DRT
2764         https://bugs.webkit.org/show_bug.cgi?id=36146
2765
2766         Implement AccessibilityUIElement::press() for GTK.
2767
2768         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2769         (AccessibilityUIElement::press): Implemented.
2770
2771 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2772
2773         Reviewed by Tony Chang.
2774
2775         config.webkit_base_dir returns a path with a trailing slash
2776         https://bugs.webkit.org/show_bug.cgi?id=50197
2777         
2778         config.webkit_base_dir() should return a path without a trailing slash,
2779         like all the other methods that return paths.
2780         
2781         Undoes MockFileSytem changes by r72640, since they're no longer
2782         necessary for GetBaselinesTest to pass.
2783
2784         * Scripts/webkitpy/common/system/filesystem_mock.py:
2785         * Scripts/webkitpy/layout_tests/port/base.py:
2786         * Scripts/webkitpy/layout_tests/port/config.py:
2787         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2788
2789 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2790
2791         Reviewed by Tony Chang.
2792
2793         Rebaseline server: baseline display tweaks
2794         https://bugs.webkit.org/show_bug.cgi?id=50207
2795         
2796         Determine which baselines were used when running the tests and highlight
2797         them in the UI. Sort platform names alphabetically.
2798         
2799         Also makes the server URL be launched in the user's browser
2800         automatically.
2801
2802         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2803         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2804         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2805         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2806         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2807
2808 2010-11-30  Dan Bernstein  <mitz@apple.com>
2809
2810         Reviewed by Anders Carlsson.
2811
2812         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2813         https://bugs.webkit.org/show_bug.cgi?id=50238
2814
2815         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2816         (WTR::LayoutTestController::findString): Added.
2817         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2818
2819 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2820
2821         Reviewed by Adam Roben.
2822
2823         All projects on Windows should use cmd files for build events
2824         https://bugs.webkit.org/show_bug.cgi?id=50213
2825
2826         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2827         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2828         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2829         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2830         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2831         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2832         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2833         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2834         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2835         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2836         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2837         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2838         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2839         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2840         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2841         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2842         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2843         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2844         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2845         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2846         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2847         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2848         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2849         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2850         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2851         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2852         * WinLauncher/WinLauncherCommon.vsprops:
2853         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2854         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2855
2856 2010-11-29  Dan Bernstein  <mitz@apple.com>
2857
2858         GTK DumpRenderTree build fix after r72887.
2859
2860         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2861         (LayoutTestController::findString):
2862
2863 2010-11-29  Dan Bernstein  <mitz@apple.com>
2864
2865         Windows DumpRenderTree build fix after r72887.
2866
2867         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2868         (LayoutTestController::findString): Added empty implementation.
2869
2870 2010-11-29  Dan Bernstein  <mitz@apple.com>
2871
2872         Reviewed by Darin Adler.
2873
2874         DumpRenderTree changes for testing the text search API.
2875         https://bugs.webkit.org/show_bug.cgi?id=50038
2876
2877         * DumpRenderTree/LayoutTestController.cpp:
2878         (findStringCallback):
2879         (LayoutTestController::staticFunctions):
2880         * DumpRenderTree/LayoutTestController.h:
2881         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2882         (LayoutTestController::findString):
2883         * MiniBrowser/mac/BrowserWindowController.m:
2884         (-[BrowserWindowController find:]):
2885
2886 2010-11-29  Johnny Ding  <jnd@chromium.org>
2887
2888         Unreviewed: Add myself to the list of Committers.
2889
2890         * Scripts/webkitpy/common/config/committers.py:
2891
2892 2010-11-29  Mark Rowe  <mrowe@apple.com>
2893
2894         Reviewed by Adele Peterson.
2895
2896         <rdar://problem/8694997> DumpRenderTree fails to build.
2897
2898         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
2899
2900 2010-11-29  Mark Rowe  <mrowe@apple.com>
2901
2902         Reviewed by Adele Peterson.
2903
2904         <rdar://problem/8694997> DumpRenderTree fails to build.
2905
2906         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
2907         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
2908         * DumpRenderTree/mac/PerlSupport/Makefile:
2909
2910 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
2911
2912         Reviewed by Martin Robinson.
2913
2914         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
2915         https://bugs.webkit.org/show_bug.cgi?id=50154
2916
2917         Added missing checks to allAttributes().
2918
2919         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2920         (AccessibilityUIElement::allAttributes): Added missing checks.
2921
2922 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2923
2924         Reviewed by Kenneth Rohde Christiansen.
2925
2926         [Qt] Allow pre-generation for package builds for WebKit2
2927         https://bugs.webkit.org/show_bug.cgi?id=50139
2928
2929         Use a build variable for the generated directory path and set the
2930         value based on CONFIG just like for WebKit1.
2931
2932         For non-package builds use a relative base path for the
2933         genrated directory just like for WebKit1.
2934
2935         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2936         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2937
2938 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2939
2940         Reviewed by Kenneth Rohde Christiansen.
2941
2942         [Qt] Move some build logic from Qt to platform independent code
2943         https://bugs.webkit.org/show_bug.cgi?id=50134
2944
2945         Create target directories inside generate-forwarding-headers.pl.
2946
2947         * Scripts/generate-forwarding-headers.pl:
2948
2949 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2950
2951         Reviewed by Martin Robinson.
2952
2953         [GTK] Windowless plugins gets broken key input
2954         https://bugs.webkit.org/show_bug.cgi?id=49927
2955
2956         Convert the XEvent::keycode to ASCII before printing it. Not
2957         doing this was causing false positive in 
2958         plugins/keyboard-events.html.
2959
2960         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2961         (keycode_to_char):
2962         (webkit_test_plugin_handle_event):
2963
2964 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
2965
2966         Reviewed by Antonio Gomes.
2967
2968         [Qt] Html autofocus not working with QGraphicsWebView
2969         https://bugs.webkit.org/show_bug.cgi?id=43169
2970
2971         Tell the scene to set the webview item as the currently
2972         focused item. This makes the input field with autofocus get
2973         focus as it should.
2974
2975         * QtTestBrowser/webview.cpp:
2976         (WebViewGraphicsBased::WebViewGraphicsBased):
2977
2978 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2979
2980         Reviewed by Tony Chang.
2981
2982         nrwt - clean up create_driver interface and print out the
2983         command line used for DumpRenderTree/TestShell.
2984
2985         This patch adds a driver_cmd_line() call to the Port class in
2986         order to retrive the command line to print it out (as part of
2987         --print config).
2988
2989         In addition, this patch cleans up the Port.create_driver()
2990         signature and the Driver constructor interface to take a worker
2991         number and no longer require the image_path argument (Chromium's
2992         drivers now synthesize the image_path from the worker number
2993         internally).
2994
2995         https://bugs.webkit.org/show_bug.cgi?id=49934
2996
2997         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2998         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2999         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3000         * Scripts/webkitpy/layout_tests/port/base.py:
3001         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3002         * Scripts/webkitpy/layout_tests/port/chromium.py:
3003         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3004         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3005         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3006         * Scripts/webkitpy/layout_tests/port/test.py:
3007         * Scripts/webkitpy/layout_tests/port/webkit.py:
3008         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3009         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3010
3011 2010-11-24  Ojan Vafai  <ojan@chromium.org>
3012
3013         Reviewed by Tony Chang.
3014
3015         [chromium] improve memory usage for test results server and store fewer runs
3016         https://bugs.webkit.org/show_bug.cgi?id=50035
3017
3018         Store fewer runs and don't pass full files around when we only need bools.
3019         Greatly improves error rates on test-results.appspot.com.
3020
3021         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3022         * TestResultServer/handlers/testfilehandler.py:
3023         * TestResultServer/model/dashboardfile.py:
3024         * TestResultServer/model/jsonresults.py:
3025
3026 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3027
3028         Reviewed by Tony Chang.
3029
3030         This patch implements the first part of the manager side of the
3031         Broker objects - it handles creating threads, waiting for them
3032         to complete, and running a single-threaded loop as well.
3033
3034         https://bugs.webkit.org/show_bug.cgi?id=49779
3035
3036         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3037         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3038         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3039         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3040
3041 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
3042
3043         Reviewed by David Levin.
3044
3045         DRT should not generate pixel output for text/plain tests
3046         https://bugs.webkit.org/show_bug.cgi?id=50002
3047         
3048         Modify Mac, Windows and GTK DRT implementations to disable pixel output
3049         when encountering a text/plain response (the Chromium one already does
3050         this, and none of the other ports special-case text/plain output in
3051         the first place).
3052
3053         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3054         (dump):
3055         * DumpRenderTree/mac/DumpRenderTree.mm:
3056         (dump):
3057         * DumpRenderTree/win/DumpRenderTree.cpp:
3058         (dump):
3059
3060 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3061
3062         Unreviewed.
3063
3064         Add my other email address to committers.py.
3065
3066         * Scripts/webkitpy/common/config/committers.py:
3067
3068 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3069
3070         Reviewed by Csaba Osztrogonác.
3071
3072         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
3073         https://bugs.webkit.org/show_bug.cgi?id=49975
3074
3075         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
3076         to enable the script to define it 0 in case of a minimal build.
3077
3078 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
3079
3080         Reviewed by Xan Lopez.
3081
3082         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
3083         https://bugs.webkit.org/show_bug.cgi?id=49143
3084
3085         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3086         (createWebView): Call the new connectEditingCallbacks function.
3087         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
3088         (dumpNodePath):
3089         (dumpRange):
3090         (insertActionString):
3091         (selectionAffinityString):
3092         (shouldBeginEditing):
3093         (shouldEndEditing):
3094         (shouldInsertNode):
3095         (shouldInsertText):
3096         (shouldDeleteRange):
3097         (shouldShowDeleteInterfaceForElement):
3098         (shouldChangeSelectedRange):
3099         (shouldApplyStyle):
3100         (editingBegan):
3101         (userChangedContents):
3102         (editingEnded):
3103         (selectionChanged):
3104         (connectEditingCallbacks):
3105         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
3106         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
3107
3108 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
3109
3110         Reviewed by Andreas Kling.
3111
3112         [Qt] Make QtTestBrowser remember the selected user agent
3113         https://bugs.webkit.org/show_bug.cgi?id=50021
3114
3115         Set user agent for a new page by using the old page's
3116
3117         * QtTestBrowser/mainwindow.cpp:
3118         (MainWindow::setPage):
3119
3120 2010-11-24 Patrick Gansterer <paroga@webkit.org>
3121
3122         Reviewed by Csaba Osztrogonác.
3123
3124         Remove Bakefile build system files
3125         https://bugs.webkit.org/show_bug.cgi?id=49983
3126
3127         r53757 only removed the content, but not the files.
3128         This patch removes that empty files.
3129
3130         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
3131         * wx/browser/browser.bkl: Removed.
3132         * wx/build-wxwebkit: Removed.
3133
3134 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
3135
3136         Reviewed by Tony Chang.
3137
3138         This patch cleans up the logic used to shard tests into groups a
3139         bit and adds the --worker-model flag to NRWT. The flag is only
3140         used at the moment to control whether to run single-threaded or
3141         not, but eventually will also allow toggling between threads and
3142         processes.
3143
3144         Also add a minor cleanup with _test_is_slow(), which just
3145         eliminates some repetition and gives slightly better encapsulation.
3146
3147         https://bugs.webkit.org/show_bug.cgi?id=49773
3148
3149         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3150         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3151
3152 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
3153
3154         Reviewed by Tony Chang.
3155
3156         Rebaseline server: list current baselines and platforms
3157         https://bugs.webkit.org/show_bug.cgi?id=49991
3158         
3159         List existing baselines (with Trac links) for tests.
3160         
3161         Add dropdowns for choosing with platform baselines to target (and what
3162         to do with existing ones).
3163
3164         Also fix MockFileSystem.join to behave more like os.path.join (unit
3165         test was ending up with two consecutive slashes in a layout test
3166         path).        
3167
3168         * Scripts/webkitpy/common/system/filesystem_mock.py:
3169         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3170         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3171         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3172         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3173         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3174         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3175         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
3176
3177 2010-11-23  Ojan Vafai  <ojan@chromium.org>
3178
3179         Reviewed by Tony Chang.
3180
3181         remove timeout argument to urlopen
3182         https://bugs.webkit.org/show_bug.cgi?id=49995
3183
3184         Apparently the version of python we have on the bots doesn't accept a timeout argument.
3185
3186         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3187
3188 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3189
3190         Unreviewed, rolling out r72628.
3191         http://trac.webkit.org/changeset/72628
3192         https://bugs.webkit.org/show_bug.cgi?id=49994
3193
3194         This patch is causing layout-test failtures on GTK Linux
3195         64-bit Debug (Requested by ctguil on #webkit).
3196
3197         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3198         (AccessibilityUIElement::AccessibilityUIElement):
3199         (AccessibilityUIElement::parentElementCallback):
3200         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3201         * DumpRenderTree/chromium/CppBoundClass.cpp:
3202         * DumpRenderTree/chromium/CppBoundClass.h:
3203
3204 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3205
3206         Reviewed by Tony Chang.
3207
3208         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
3209         https://bugs.webkit.org/show_bug.cgi?id=49944
3210
3211         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3212
3213 2010-11-23  Chris Guillory  <chris.guillory@google.com>
3214
3215         Reviewed by Dimitri Glazkov.
3216
3217         Include the FrameView widget of a RenderWidget in the accessibility tree.
3218         https://bugs.webkit.org/show_bug.cgi?id=49106
3219
3220         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3221         (AccessibilityUIElement::AccessibilityUIElement):
3222         (AccessibilityUIElement::parentElementCallback):
3223         (AccessibilityUIElement::isEqualCallback):
3224         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3225         * DumpRenderTree/chromium/CppBoundClass.cpp:
3226         (CppBoundClass::getFromCppVariant):
3227         * DumpRenderTree/chromium/CppBoundClass.h:
3228
3229 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
3230
3231         Reviewed by Kenneth Rohde Christiansen.
3232
3233         [EFL] Add tiled backing store to EWebLauncher
3234         https://bugs.webkit.org/show_bug.cgi?id=45777
3235
3236         Allow EWebLauncher to choose between single and tiled backing store
3237
3238         * EWebLauncher/main.c:
3239         (on_key_down):
3240         (browserCreate):
3241         (main):
3242
3243 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3244
3245         Reviewed by Tor Arne Vestbø.
3246
3247         [Qt] Review the setUserPermission & friends API
3248         https://bugs.webkit.org/show_bug.cgi?id=46810
3249
3250         Renamed requestPermissionFromUser to featurePermissionRequested
3251         and cancelRequestsForPermission to featurePermissionRequestCanceled.
3252
3253         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3254         (WebCore::WebPage::WebPage):
3255         * QtTestBrowser/webpage.cpp:
3256         (WebPage::WebPage):
3257         (WebPage::featurePermissionRequestCanceled):
3258         * QtTestBrowser/webpage.h:
3259
3260 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3261
3262         Reviewed by Tor Arne Vestbø.
3263
3264         [Qt] Review the setUserPermission & friends API
3265         https://bugs.webkit.org/show_bug.cgi?id=46810
3266
3267         Rename setUserPermission to setFeaturePermission
3268
3269         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3270         (WebCore::WebPage::requestPermission):
3271         (WebCore::WebPage::permissionSet):
3272         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3273         (LayoutTestController::grantDesktopNotificationPermission):
3274         * QtTestBrowser/webpage.cpp:
3275         (WebPage::requestPermission):
3276
3277 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3278
3279         Reviewed by Tor Arne Vestbø.
3280
3281         [Qt] Review the setUserPermission & friends API
3282         https://bugs.webkit.org/show_bug.cgi?id=46810
3283
3284         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
3285         and GeolocationPermissionDomain to Geolocation.
3286
3287         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3288         (WebCore::WebPage::WebPage):
3289         (WebCore::WebPage::requestPermission):
3290         (WebCore::WebPage::cancelPermission):
3291         (WebCore::WebPage::permissionSet):
3292         (WebCore::DumpRenderTree::geolocationPermissionSet):
3293         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3294         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3295         (LayoutTestController::grantDesktopNotificationPermission):
3296         * QtTestBrowser/webpage.cpp:
3297         (WebPage::WebPage):
3298         (WebPage::requestPermission):
3299         (WebPage::cancelRequestsForPermission):
3300         * QtTestBrowser/webpage.h:
3301
3302 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3303
3304         Reviewed by Tor Arne Vestbø.
3305
3306         [Qt] Review the setUserPermission & friends API
3307         https://bugs.webkit.org/show_bug.cgi?id=46810
3308
3309         Add a ByUser suffix to PermissionGranted/Denied. In the future
3310         we can add PermissionGrantedByDefault.
3311
3312
3313         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3314         (WebCore::WebPage::requestPermission):
3315         (WebCore::WebPage::permissionSet):
3316         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3317         (LayoutTestController::grantDesktopNotificationPermission):
3318         * QtTestBrowser/webpage.cpp:
3319         (WebPage::requestPermission):
3320
3321 2010-11-18  Satish Sampath  <satish@chromium.org>
3322
3323         Reviewed by Jeremy Orlow.
3324
3325         For speech input event, send an event object containing all the recognition results and metadata.
3326         https://bugs.webkit.org/show_bug.cgi?id=49736
3327
3328         Updated DRT by renaming the mock result method on all platforms to the new signature.
3329
3330         * DumpRenderTree/LayoutTestController.cpp:
3331         (addMockSpeechInputResultCallback):
3332         (LayoutTestController::staticFunctions):
3333         * DumpRenderTree/LayoutTestController.h:
3334         * DumpRenderTree/chromium/LayoutTestController.cpp:
3335         (LayoutTestController::LayoutTestController):
3336         (LayoutTestController::addMockSpeechInputResult):
3337         * DumpRenderTree/chromium/LayoutTestController.h:
3338         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3339         (LayoutTestController::addMockSpeechInputResult):
3340         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3341         (LayoutTestController::addMockSpeechInputResult):
3342         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3343         (LayoutTestController::addMockSpeechInputResult):
3344         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3345         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3346         (LayoutTestController::addMockSpeechInputResult):
3347         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3348         (LayoutTestController::addMockSpeechInputResult):
3349
3350 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3351
3352         Reviewed by Tony Chang.
3353
3354         Fix some spacing issues with log messages with
3355         new-run-webkit-tests --verbose.
3356
3357         https://bugs.webkit.org/show_bug.cgi?id=49936
3358
3359         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3360
3361 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3362
3363         Reviewed by Adam Barth.
3364
3365         update scm to work with different remote branches
3366         https://bugs.webkit.org/show_bug.cgi?id=49949
3367
3368         This works if there are multiple svn tracking branches
3369         and/or if the tracking branch is refs/remots/origin/master
3370         instead of refs/remotes/trunk which is the direction we're trying
3371         to head since that makes fetches faster.
3372
3373         * Scripts/webkitpy/common/checkout/scm.py:
3374         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3375
3376 2010-11-22  Hayato Ito  <hayato@chromium.org>
3377
3378         Reviewed by Shinichiro Hamaji.
3379
3380         Ignore reference files which will be used by reftests when collecting
3381         test cases.
3382         https://bugs.webkit.org/show_bug.cgi?id=49835
3383
3384         * Scripts/webkitpy/layout_tests/port/test_files.py:
3385         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3386
3387 2010-11-22  Adam Roben  <aroben@apple.com>
3388
3389         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3390
3391         Apple's Windows build allows placing header files and import libraries for WebKit's
3392         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3393         $WebKitLibrariesDir environment variable. This is both required for production builds and
3394         convenient for Apple-internal developer builds. Apple's production builds also require that
3395         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3396         builds, the files are copied into that directory tree by the
3397         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3398         copying is done by
3399         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3400
3401         This .vsprops copying is problematic in one very important case: when a developer updates
3402         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3403         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3404         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3405         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3406         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3407         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3408
3409         To fix this, we now use normal relative paths to access the .vsprops files in the source
3410         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3411         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3412         unset, so the normal relative paths are used to read the .vsprops files out of the source
3413         tree directly. In production builds, this environment variable is set to a fake directory
3414         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3415         is resolved.
3416         
3417         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3418
3419         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3420
3421         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3422         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3423         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3424         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3425         FeatureDefines.vsprops becomes:
3426
3427         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3428
3429         which resolves to:
3430
3431         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3432
3433         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3434         actually exist since they are matched by an equal number of ".." path components.)
3435
3436         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3437         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3438
3439         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3440         updated
3441
3442         Reviewed by Dave Hyatt.
3443
3444         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3445         * DumpRenderTree/win/DumpRenderTree.vcproj:
3446         * DumpRenderTree/win/ImageDiff.vcproj:
3447         * FindSafari/FindSafari.vcproj:
3448         * MiniBrowser/MiniBrowser.vcproj:
3449         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3450         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3451         * WebKitAPITest/WebKitAPITest.vcproj:
3452         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3453         * WebKitTestRunner/win/InjectedBundle.vcproj:
3454         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3455         * WinLauncher/WinLauncher.vcproj:
3456         * record-memory-win/record-memory-win.vcproj:
3457         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3458         files.
3459
3460 2010-11-22  Adam Roben  <aroben@apple.com>
3461
3462         Make it possible to run tests on Windows without Visual Studio or VC++
3463         Express installed
3464
3465         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3466         are not installed. But this function doesn't need to be called when we
3467         already have a build available and are just trying to run the tests.
3468
3469         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
3470         because Visual Studio/VC++ Express aren't installed
3471
3472         Reviewed by Dave Hyatt.
3473
3474         * Scripts/webkitdirs.pm:
3475         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
3476         it is not needed by this function. Also added a FIXME.
3477
3478         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
3479         relying on determineConfigurationForVisualStudio doing it.
3480
3481 2010-11-19  Hayato Ito  <hayato@chromium.org>
3482
3483         Reviewed by Shinichiro Hamaji.
3484
3485         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
3486
3487         https://bugs.webkit.org/show_bug.cgi?id=49812
3488
3489         * Scripts/webkitpy/layout_tests/driver_test.py:
3490         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3491         * Scripts/webkitpy/layout_tests/port/base.py:
3492         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3493         * Scripts/webkitpy/layout_tests/port/chromium.py:
3494         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3495         * Scripts/webkitpy/layout_tests/port/test.py:
3496         * Scripts/webkitpy/layout_tests/port/webkit.py:
3497         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3498         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3499
3500 2010-11-22  Hayato Ito  <hayato@chromium.org>
3501
3502         Reviewed by Tony Chang.
3503
3504         [NRWT] Retry a few times in reading a png image to avoid a race condition.
3505
3506         https://bugs.webkit.org/show_bug.cgi?id=49924
3507
3508         * Scripts/webkitpy/layout_tests/port/chromium.py:
3509
3510 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
3511
3512         Reviewed by Kenneth Rohde Christiansen.
3513
3514         Fix EWebLauncher zoom discretization
3515         https://bugs.webkit.org/show_bug.cgi?id=49810
3516
3517         * EWebLauncher/main.c:
3518         (nearest_zoom_level_get):
3519         (zoom_level_set):
3520         (on_load_finished):
3521         (on_key_down):
3522
3523 2010-11-21  Sam Weinig  <sam@webkit.org>
3524
3525         Rubber-stamped by Dan Bernstein.
3526
3527         Fix ~300 WebKit2 tests by enabling developer extras preference.
3528
3529         * WebKitTestRunner/TestController.cpp:
3530         (WTR::TestController::resetStateToConsistentValues):
3531
3532 2010-11-21  Sam Weinig  <sam@webkit.org>
3533
3534         Reviewed by Dan Bernstein.
3535
3536         Textareas should be resizable by default
3537         https://bugs.webkit.org/show_bug.cgi?id=49892
3538
3539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3540         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3541         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3542         Add preferences test.
3543
3544 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3545
3546         Reviewed by Tony Chang.
3547
3548         Rebaseline server: checksum-only differences and prefetching
3549         https://bugs.webkit.org/show_bug.cgi?id=49841
3550         
3551         Add support for image test results where the only difference is in the
3552         checksum.
3553         
3554         Add prefetching of the image results from the next test.
3555         
3556         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3557         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3558         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3559
3560 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3561
3562         Reviewed by Tony Chang.
3563
3564         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3565
3566         Add the 'worker number' and 'worker name' concepts to the 
3567         TestShellThread objects, and move test_types and test_args from
3568         the TestRunner to the TestShellThread.
3569
3570         https://bugs.webkit.org/show_bug.cgi?id=49768
3571
3572         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3573         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3574
3575 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3576
3577         Reviewed by Ojan Vafai.
3578
3579         Do some minor cleanup and bug fixing.
3580
3581         https://bugs.webkit.org/show_bug.cgi?id=49777
3582
3583         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3584         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3585
3586 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3587
3588         Reviewed by Ojan Vafai.
3589
3590         nrwt - config.build_directory() is busted
3591
3592         Fixes a typo that was causing us to usually return the top level
3593         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3594         bug was hidden by test stubs that were too simplistic :(.
3595
3596         https://bugs.webkit.org/show_bug.cgi?id=49815
3597
3598         * Scripts/webkitpy/common/system/executive_mock.py:
3599         * Scripts/webkitpy/layout_tests/port/config.py:
3600         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3601
3602 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3603
3604         Reviewed by Adam Roben.
3605
3606         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3607         https://bugs.webkit.org/show_bug.cgi?id=49819
3608
3609         * DumpRenderTree/DumpRenderTree.sln:
3610         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3611         * DumpRenderTree/win/DumpRenderTree.vcproj:
3612         * DumpRenderTree/win/ImageDiff.vcproj:
3613         * FindSafari/FindSafari.vcproj:
3614         * MiniBrowser/MiniBrowser.vcproj:
3615         * TestWebKitAPI/win/TestWebKitAPI.sln:
3616         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3617         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3618         * WebKitAPITest/WebKitAPITest.vcproj:
3619         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3620         * WebKitTestRunner/win/InjectedBundle.vcproj:
3621         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3622         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3623         * WinLauncher/WinLauncher.vcproj:
3624         * record-memory-win/record-memory-win.vcproj:
3625
3626 2010-11-19  Adam Roben  <aroben@apple.com>
3627
3628         Add some more Windows slaves
3629
3630         This is probably more than we will be using in the immediate future,
3631         but having some extra slave names makes experimenting with different
3632         configurations easier.
3633
3634         Reviewed by Jon Honeycutt.
3635
3636         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
3637         Windows slaves and distributed them among the three different Test
3638         builders.
3639
3640 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
3641