Source/JavaScriptCore: JavaScriptCore Part of: Prevent the WebKit frameworks from...
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-21  Dan Bernstein  <mitz@apple.com>
2
3         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
4         https://bugs.webkit.org/show_bug.cgi?id=68451
5
6         Reviewed by Darin Adler.
7
8         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
9         Objective-C classes with names not having one of a list of prefixes
10         passed on the command line.
11
12 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
13
14         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
15         https://bugs.webkit.org/show_bug.cgi?id=68206
16
17         Reviewed by Tony Chang.
18
19         * Scripts/webkitdirs.pm:
20         (determineBaseProductDir): add support for chromium-mac
21         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
22         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
23
24 2011-09-21  Adam Barth  <abarth@webkit.org>
25
26         garden-o-matic command should explain that it is starting a local server
27         https://bugs.webkit.org/show_bug.cgi?id=68486
28
29         Reviewed by Dimitri Glazkov.
30
31         In the user study, both participants didn't understand why the
32         garden-o-matic command appeared to hang.  This patch adds an
33         explaination of what's going on.  It also adds a confirmation prompt
34         before launching the browser to give the user a chance to read the
35         text.  If that's too much of a speed bump, we can iterate.
36
37         * Scripts/webkitpy/tool/commands/gardenomatic.py:
38
39 2011-09-21  Chang Shu  <cshu@webkit.org>
40
41         [Qt] Implement KeyDown function for WebKit2 EventSender.
42         https://bugs.webkit.org/show_bug.cgi?id=56485
43
44         Implement the KeyDown function on Qt platform.
45
46         Reviewed by Andreas Kling.
47
48         * WebKitTestRunner/PlatformWebView.h:
49         * WebKitTestRunner/TestController.cpp:
50         (WTR::TestController::TestController):
51         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
52         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
53         (WTR::getModifiers):
54         (WTR::EventSenderProxy::keyDown):
55         (buildModifierFlags):
56         (EventSenderProxy::keyDown):
57         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
58         (WTR::PlatformWebView::sendEvent):
59         * WebKitTestRunner/qt/WebKitTestRunner.pro:
60
61 2011-09-20  Adam Barth  <abarth@webkit.org>
62
63         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
64         https://bugs.webkit.org/show_bug.cgi?id=68496
65
66         Reviewed by Dimitri Glazkov.
67
68         This patch adds a bunch of sorting to make sure things happen in a
69         predictable order in both JavaScriptCore and V8.  We've talked before
70         about whether these two JavaScript engines should enumerate
71         dictionaries in the same order, but the consensus has been that they
72         shouldn't.  Personally, I disagree with that consensus, but such is life.
73
74         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
75         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
76         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
77         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
78
79 2011-09-20  Adam Barth  <abarth@webkit.org>
80
81         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
82         https://bugs.webkit.org/show_bug.cgi?id=68495
83
84         Reviewed by Dimitri Glazkov.
85
86         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
87
88         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
89
90 2011-09-20  Eric Seidel  <eric@webkit.org>
91
92         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
93         https://bugs.webkit.org/show_bug.cgi?id=65781
94
95         Reviewed by Ryosuke Niwa.
96
97         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
98         to resolve the passed in url relative to the absolute url for the test.
99         For http tests, since the test url is an http url, we can't resolve relative
100         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
101         for resolving.
102
103         I believe this is a better approach than the on used in the Qt and Chromium DRT's
104         (which resolves the path relative to the built location of the DRT executable)
105         and we should move this new code into a shared location in a follow-up patch.
106
107         It turns out that there was a second use for pathToLocalResource, used by one
108         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
109         To support this test I made the new pathToLocalResource smart enough to map
110         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
111
112         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
113         (LayoutTestController::pathToLocalResource):
114         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
115
116 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
117
118         Need to specify a django version, instead of using default
119         https://bugs.webkit.org/show_bug.cgi?id=68398
120
121         Reviewed by Eric Seidel.
122
123         * QueueStatusServer/__init__.py:
124         * QueueStatusServer/main.py:
125
126 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
127
128         Update committers.py with a few more contributor contacts
129         https://bugs.webkit.org/show_bug.cgi?id=68487
130
131         Reviewed by Eric Seidel.
132
133         * Scripts/webkitpy/common/config/committers.py:
134
135 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
136
137         Fix webkitpy unit tests after 95547 and 95549
138         https://bugs.webkit.org/show_bug.cgi?id=68483
139
140         Reviewed by Adam Barth.
141         
142         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
143
144         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
145         parse_entries_from_file(), use StringIO and entry.reviewer_text().
146         While testing parse_latest_entry_from_file(), expect the correct
147         touched_files() list.
148
149 2011-09-20  Adam Barth  <abarth@webkit.org>
150
151         garden-o-matic makes it hard to compare images when scroll bars appear
152         https://bugs.webkit.org/show_bug.cgi?id=68482
153
154         Reviewed by Eric Seidel.
155
156         Because we autoscale image width, the images rescale if we overflow
157         vertically and get a scrollbar.  That makes it hard to compare two sets
158         of images.  This patch reserves space for the scrollbar so we won't
159         have the layout change.
160
161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
162
163 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
164
165         Unreviewed, rolling out r95565.
166         http://trac.webkit.org/changeset/95565
167         https://bugs.webkit.org/show_bug.cgi?id=68470
168
169         Broke builds (Requested by andersca on #webkit).
170
171         * MiniBrowser/gtk/BrowserWindow.c:
172         (mouseDidMoveOverElement):
173
174 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
175
176         Get hover'ed element URL from HitTest.
177         
178         mouseDidMoveOverElement now gets the hover'ed element link using
179         WKHitTestResult API's.
180         https://bugs.webkit.org/show_bug.cgi?id=68426
181
182         Reviewed by Anders Carlsson.
183
184         * MiniBrowser/gtk/BrowserWindow.c:
185         (mouseDidMoveOverElement):
186
187 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
188
189         Changelog class should have a method to return all entries
190         https://bugs.webkit.org/show_bug.cgi?id=68399
191         
192         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
193         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
194
195         Reviewed by Ryosuke Niwa.
196
197         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
198         and adapt it to become a generator.
199         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
200
201 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
202
203         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
204         https://bugs.webkit.org/show_bug.cgi?id=51159
205
206         Permit any URL with a local scheme to set a user style sheet. Allow qrc
207         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
208         
209         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
210
211         Reviewed by Kenneth Rohde Christiansen.
212
213         * DumpRenderTree/qt/DumpRenderTree.pro:
214         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
215         * DumpRenderTree/qt/resources/user.css: Added.
216         (body):
217         * WebKitTestRunner/qt/WebKitTestRunner.pro:
218         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
219         * WebKitTestRunner/qt/resources/user.css: Added.
220         (body):
221
222 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
223
224         ChangeLogEntry class should contain a list of touched files
225         https://bugs.webkit.org/show_bug.cgi?id=68115
226
227         Reviewed by Eric Seidel.
228         
229         Add method to return the list of files touched in a ChangeLog entry.
230
231         * Scripts/webkitpy/common/checkout/changelog.py: Add
232         touched_files_regexp and touched_files() method.
233         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
234         unit tests for touched_files() method.
235
236 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
237
238         Unreviewed, rolling out r95526 and r95541.
239         http://trac.webkit.org/changeset/95526
240         http://trac.webkit.org/changeset/95541
241         https://bugs.webkit.org/show_bug.cgi?id=68443
242
243         It broke 6 tests (Requested by ossy_ on #webkit).
244
245         * DumpRenderTree/qt/main.cpp:
246         (main):
247         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
248         (WTR::activateFonts):
249
250 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
251
252         Fix patch and bug numbering in the mocktool simulation code
253         https://bugs.webkit.org/show_bug.cgi?id=68374
254
255         Reviewed by Adam Barth.
256
257         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
258         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
259         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
260         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
261         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
262         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
263         * Scripts/webkitpy/tool/commands/download_unittest.py:
264         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
265         * Scripts/webkitpy/tool/commands/queries_unittest.py:
266         * Scripts/webkitpy/tool/commands/queues_unittest.py:
267         * Scripts/webkitpy/tool/commands/queuestest.py:
268         * Scripts/webkitpy/tool/commands/upload_unittest.py:
269         * Scripts/webkitpy/tool/mocktool.py:
270         * Scripts/webkitpy/tool/steps/steps_unittest.py:
271         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
272
273 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
274
275         [Qt] Don't override default QApplication font for DRT and WTR
276
277         Revision 95526 moved the relevant code below the QApplication
278         constructor, to fix a potential crash, and that made the code
279         take effect, breaking 6 tests.
280
281         We should rely on the QWebSettings to set default fonts, and
282         this QApplication::setFont() is a relic from when we didn't
283         have that option, so we remove the code.
284
285         Reviewed by Csaba Osztrogonác.
286
287         * DumpRenderTree/qt/main.cpp:
288         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
289
290 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
291
292         WebKitTestRunner: Provide usage if run without arguments
293
294         If WTR is run without either one or more filenames, or
295         a '-' to indicate server mode, we don't need to start
296         up the test machinery. Doing so might actually crash,
297         as we'll exit the application immedeatly after anyways.
298
299         Reviewed by Simon Hausmann.
300
301         * WebKitTestRunner/TestController.cpp:
302         (WTR::TestController::initialize):
303
304 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
305
306         [Qt] Don't use QFont before initializing QApplication
307
308         Could potentially result in crash.
309
310         Reviewed by Simon Hausmann.
311
312         * DumpRenderTree/qt/main.cpp:
313         (main):
314
315 2011-09-19  Adam Barth  <abarth@webkit.org>
316
317         Always enable ENABLE(EVENTSOURCE)
318         https://bugs.webkit.org/show_bug.cgi?id=68414
319
320         Reviewed by Eric Seidel.
321
322         * Scripts/build-webkit:
323
324 2011-09-19  David Levin  <levin@chromium.org>
325
326         Sheriffbot rollout should be more intuitive.
327         https://bugs.webkit.org/show_bug.cgi?id=68415
328
329         Reviewed by Adam Barth.
330
331         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
332         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
333           and a few others cases.
334         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
335
336 2011-09-19  David Levin  <levin@chromium.org>
337
338         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
339         https://bugs.webkit.org/show_bug.cgi?id=68391
340
341         Reviewed by Darin Adler.
342
343         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
344         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
345
346 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
347
348         Style checker should not check public Qt WK2 API for parameter_name.
349         https://bugs.webkit.org/show_bug.cgi?id=68359
350
351         Reviewed by Andreas Kling.
352
353         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
354         Add an exception in the style checker to disable the check. Also added the test for it.
355
356         * Scripts/webkitpy/style/checker.py:
357         * Scripts/webkitpy/style/checker_unittest.py:
358
359 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
360
361         GTK DRT leaks memory while comparing history items
362         https://bugs.webkit.org/show_bug.cgi?id=68086
363
364         Reviewed by Martin Robinson.
365         
366         webkit_web_history_item_get_target() returns a g_strdup()'d string,
367         so memory must be freed before compareHistoryItems() returns.
368
369         * DumpRenderTree/gtk/DumpRenderTree.cpp:
370         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
371
372 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
373
374         Buildbot marks a nrwt bot red when tests are missing results
375         https://bugs.webkit.org/show_bug.cgi?id=64812
376
377         Reviewed by Ryosuke Niwa.
378
379         * Scripts/webkitpy/layout_tests/controllers/manager.py:
380         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
381
382 2011-09-19  Jessie Berlin  <jberlin@apple.com>
383
384         Sites that use history pushState or replaceState are recorded in history in Private Browsing
385         mode.
386         https://bugs.webkit.org/show_bug.cgi?id=68208
387
388         Reviewed by Brady Eidson.
389
390         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
391         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
392
393         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
394         (TestWebKitAPI::didNavigateWithNavigationData):
395         This is a context history client callback, so it should not be called when in Private
396         Browsing. Add a call to FAIL().
397         (TestWebKitAPI::didSameDocumentNavigationForFrame):
398         This is a page load client callback that happens after the didNavigateWithNavigationData
399         callback. End the test.
400         (TestWebKitAPI::TEST):
401         Enable Private Browsing and load a page that uses history.pushState.
402
403         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
404         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
405         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
406         Ditto.
407         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
408         Ditto.
409         * TestWebKitAPI/win/copy-resources.cmd:
410         Ditto.
411
412 2011-09-16  Elliot Poger  <epoger@google.com>
413
414         add non-CG Webkit-Mac builds to flakiness dashboard
415         https://bugs.webkit.org/show_bug.cgi?id=68265
416
417         Reviewed by Adam Barth.
418
419         As Chromium-on-Mac approaches the switchover from Core Graphics to
420         Skia, we need to add the Skia version to the flakiness dashboard.
421
422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
423         * TestResultServer/static-dashboards/builders.js:
424         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
425
426 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
427
428         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
429         https://bugs.webkit.org/show_bug.cgi?id=68071
430
431         Reviewed by Adam Barth.
432
433         * DumpRenderTree/chromium/WebPermissions.cpp:
434         (WebPermissions::allowImage):
435         * DumpRenderTree/chromium/WebPermissions.h:
436
437 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
438
439         update-webkit-chromium should retry the gclient call if it fails once
440         https://bugs.webkit.org/show_bug.cgi?id=68252
441
442         Reviewed by Adam Barth.
443
444         * Scripts/update-webkit-chromium:
445
446 2011-09-16  Rob Buis  <rbuis@rim.com>
447
448         Add Eli's rim address and change the nick.
449
450         * Scripts/webkitpy/common/config/committers.py:
451
452 2011-09-16  Anders Carlsson  <andersca@apple.com>
453
454         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
455         https://bugs.webkit.org/show_bug.cgi?id=68269
456
457         Reviewed by Geoffrey Garen.
458
459         Update client function signatures.
460
461         * MiniBrowser/gtk/BrowserWindow.c:
462         (browserWindowUIClientInit):
463         * MiniBrowser/mac/BrowserWindowController.m:
464         (mouseDidMoveOverElement):
465         (-[BrowserWindowController awakeFromNib]):
466         * MiniBrowser/win/BrowserView.cpp:
467         (BrowserView::create):
468         * WebKitTestRunner/TestController.cpp:
469         (WTR::TestController::createOtherPage):
470         (WTR::TestController::initialize):
471
472 2011-09-16  Anders Carlsson  <andersca@apple.com>
473
474         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
475         https://bugs.webkit.org/show_bug.cgi?id=68266
476
477         Reviewed by John Sullivan.
478
479         * MiniBrowser/mac/BrowserWindowController.m:
480         (mouseDidMoveOverElement):
481
482 2011-09-16  Vincent Scheib  <scheib@chromium.org>
483
484         Add Vincent Scheib to the committers list.
485
486         * Scripts/webkitpy/common/config/committers.py:
487
488 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
489
490         Unreviewed, rolling out r95285.
491         http://trac.webkit.org/changeset/95285
492         https://bugs.webkit.org/show_bug.cgi?id=68247
493
494         It broke a webkitpy test (Requested by ossy on #webkit).
495
496         * Scripts/webkitpy/layout_tests/controllers/manager.py:
497
498 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
499
500         Buildbot marks a nrwt bot red when tests are missing results
501         https://bugs.webkit.org/show_bug.cgi?id=64812
502
503         Reviewed by Dirk Pranke.
504
505         * Scripts/webkitpy/layout_tests/controllers/manager.py:
506
507 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
508
509         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
510         https://bugs.webkit.org/show_bug.cgi?id=68178
511
512         Reviewed by Xan Lopez.
513
514         Add a work-around to enable WebKit2 when using build-webkit.
515
516         * Scripts/webkitdirs.pm:
517         (buildAutotoolsProject): 
518
519 2011-09-15  James Robinson  <jamesr@chromium.org>
520
521         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
522
523         * Scripts/webkitpy/common/config/committers.py:
524
525 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
526
527         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
528         https://bugs.webkit.org/show_bug.cgi?id=68003
529
530         Reviewed by Adam Barth.
531
532         * Scripts/webkitpy/tool/mocktool.py:
533         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
534         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
535
536 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
537
538         Python version check is confusing in test-webkitpy
539         https://bugs.webkit.org/show_bug.cgi?id=68004
540
541         Reviewed by Adam Barth.
542
543         * Scripts/test-webkitpy:
544
545 2011-09-15  Eric Seidel  <eric@webkit.org>
546
547         Reviewed by Adam Barth.
548
549         webkit-patch should be able to find users and add them to bugzilla groups
550         https://bugs.webkit.org/show_bug.cgi?id=63351
551
552         These are both very basic commands.  But it's now possible to find
553         all users matching a regexp, as well as add all users matching a regexp
554         to a set of groups.
555
556         bugzilla.py already knew how to find users (for validate-committer-lists)
557         but now it has the ability to modify the user records.
558
559         I split some of the logic out into a new EditUsersParser class
560         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
561
562         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
563         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
564         * Scripts/webkitpy/tool/commands/__init__.py:
565         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
566         * Scripts/webkitpy/tool/commands/findusers.py: Added.
567
568 2011-09-15  Eric Seidel  <eric@webkit.org>
569
570         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
571         https://bugs.webkit.org/show_bug.cgi?id=68182
572
573         Reviewed by Adam Barth.
574
575         * Scripts/build-webkit:
576         * waf/build/settings.py:
577
578 2011-09-15  Eric Seidel  <eric@webkit.org>
579
580         Unreviewed.  Make contributor email look-up case-insensitive.
581
582         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
583         was missing from committers.py due to case sensitivity.
584
585         This also includes a test expectations update to committers_unittest.py
586         after my previous change.
587
588         * Scripts/webkitpy/common/config/committers.py:
589         * Scripts/webkitpy/common/config/committers_unittest.py:
590         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
591
592 2011-09-15  Eric Seidel  <eric@webkit.org>
593
594         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
595
596         Add a bunch of email aliases to committers.py for regular contributors
597         who are committing using other email addresses than they have listed in the file.
598
599         * Scripts/webkitpy/common/config/committers.py:
600
601 2011-09-15  Eric Seidel  <eric@webkit.org>
602
603         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
604         https://bugs.webkit.org/show_bug.cgi?id=68022
605
606         Reviewed by Ryosuke Niwa.
607
608         * Scripts/build-webkit:
609         * waf/build/settings.py:
610
611 2011-09-15  Anders Carlsson  <andersca@apple.com>
612
613         Fix Mac build by including config.h where needed.
614
615         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
616         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
617         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
618         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
619         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
620         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
621         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
622         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
623         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
624         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
625         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
626         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
627         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
628         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
629         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
630         * TestWebKitAPI/mac/main.mm:
631
632 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
633
634         Let TestWebKitAPI work for chromium
635         https://bugs.webkit.org/show_bug.cgi?id=67756
636
637         Reviewed by Sam Weinig.
638
639         * Scripts/build-api-tests:
640         * Scripts/run-api-tests:
641         (isSupportedPlatform):
642         (runTest):
643         (populateTests):
644         * Scripts/webkitdirs.pm:
645         (determineBaseProductDir):
646         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
647         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
648         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
649         * TestWebKitAPI/InjectedBundleController.cpp:
650         * TestWebKitAPI/InjectedBundleMain.cpp:
651         * TestWebKitAPI/JavaScriptTest.cpp:
652         * TestWebKitAPI/PlatformUtilities.cpp:
653         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
654         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
655         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
656         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
657         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
658         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
659         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
660         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
661         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
662         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
663         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
664         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
665         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
666         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
667         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
668         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
669         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
670         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
671         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
672         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
673         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
674         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
675         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
676         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
677         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
678         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
679         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
680         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
681         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
682         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
683         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
684         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
685         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
686         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
687         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
688         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
689         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
690         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
691         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
692         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
693         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
694         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
695         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
696         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
697         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
698         * TestWebKitAPI/TestsController.cpp:
699         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
700         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
701         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
702         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
703         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
704         * TestWebKitAPI/win/main.cpp:
705
706 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
707
708         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
709         https://bugs.webkit.org/show_bug.cgi?id=68145
710
711         This will allow for other classes in DumpRenderTree to reuse this functionality
712
713         Reviewed by David Levin.
714
715         * DumpRenderTree/chromium/TestShell.cpp:
716         (normalizeLayoutTestURLInternal):
717         (dumpHistoryItem):
718         (TestShell::normalizeLayoutTestURL):
719         * DumpRenderTree/chromium/TestShell.h:
720
721 2011-09-14  Ada Chan  <adachan@apple.com>
722
723         Add test for WKBundleFrameCopyWebArchive().
724         https://bugs.webkit.org/show_bug.cgi?id=67857
725
726         Reviewed by Anders Carlsson.
727
728         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
729         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
730         the returned data is a valid webarchive.
731         (TestWebKitAPI::setInjectedBundleClient):
732         (TestWebKitAPI::didFinishLoadForFrame):
733         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
734         injected bundle for the webarchive and check the returned webarchive.
735         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
736         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
737         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
738         the web archive.
739
740         Add files to project.
741         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
742         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
744
745 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
746
747         committers.py should support multiple IRC nicknames
748         https://bugs.webkit.org/show_bug.cgi?id=68110
749
750         Reviewed by Eric Seidel.
751
752         Add multiple IRC nickname support to committers.py
753
754         * Scripts/webkitpy/common/config/committers.py:
755         * Scripts/webkitpy/common/config/committers_unittest.py:
756         * Scripts/webkitpy/tool/bot/irc_command.py:
757         * Scripts/webkitpy/tool/bot/sheriff.py:
758
759 2011-09-14  Jon Lee  <jonlee@apple.com>
760
761         Implement globalFlag for WebKitTestRunner
762         https://bugs.webkit.org/show_bug.cgi?id=68033
763         <rdar://problem/10119204>
764
765         Reviewed by Sam Weinig.
766
767         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
768         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
769         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
770         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
771         (WTR::LayoutTestController::globalFlag): simple getter
772         (WTR::LayoutTestController::setGlobalFlag): simple setter
773
774 2011-09-13  Eric Seidel  <eric@webkit.org>
775
776         Remove ENABLE_SVG_USE as <use> is required by HTML5
777         https://bugs.webkit.org/show_bug.cgi?id=68019
778
779         Reviewed by Ryosuke Niwa.
780
781         * Scripts/build-webkit:
782         * waf/build/settings.py:
783
784 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
785
786         Remove Jan Erik Hanssen (added in my r95078) from the list for now
787         since I can't confirm acceptable his committership.
788
789         * Scripts/webkitpy/common/config/committers.py:
790
791 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
792
793         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
794         https://bugs.webkit.org/show_bug.cgi?id=68066
795
796         Reviewed by Adam Barth.
797
798         * DumpRenderTree/chromium/WebViewHost.cpp:
799         * DumpRenderTree/chromium/WebViewHost.h:
800
801 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
802
803         committers.py is missing some contributors
804         https://bugs.webkit.org/show_bug.cgi?id=68059
805
806         Reviewed by Adam Barth.
807
808         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
809
810         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
811
812         * Scripts/webkitpy/common/config/committers.py:
813
814 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
815
816         Fix webkit python test after r95061.
817
818         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
819
820 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
821
822         Add myself as a contributor. No review needed.
823
824         * Scripts/webkitpy/common/config/committers.py:
825
826 2011-09-13  Adam Barth  <abarth@webkit.org>
827
828         garden-o-matic has unfriendly error messages when the local server is not available
829         https://bugs.webkit.org/show_bug.cgi?id=68042
830
831         Reviewed by Dimitri Glazkov.
832
833         This patch moves us from using alert to showing the error inline in the
834         progress dialog.
835
836         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
838         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
840         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
841
842 2011-09-13  Adam Barth  <abarth@webkit.org>
843
844         FailureGrid in garden-o-matic should link to the builder's waterfall page
845         https://bugs.webkit.org/show_bug.cgi?id=68036
846
847         Reviewed by Dimitri Glazkov.
848
849         One of the users in the user study thought the configurations names in
850         the failure grid would link to the underlying bots.  That makes sense,
851         so this patch adds the behavior.
852
853         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
854         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
855         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
856         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
857
858 2011-09-13  Adam Barth  <abarth@webkit.org>
859
860         garden-o-matic should be able to mark failures as expected
861         https://bugs.webkit.org/show_bug.cgi?id=68027
862
863         Reviewed by Dimitri Glazkov.
864
865         All the back-end infrastructure exists for this operation.  This patch
866         just adds some UI to the front-end and wires that UI up to the back
867         end.  This exact UI will likely need some more polish, but this should
868         be a reasonable first cut.
869
870         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
871         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
872         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
873         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
874         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
875
876 2011-09-13  Adam Barth  <abarth@webkit.org>
877
878         garden-o-matic should tell you about the progress of your rebaseline
879         https://bugs.webkit.org/show_bug.cgi?id=67967
880
881         Reviewed by Dimitri Glazkov.
882
883         This patch adds ui.MessageBox, which is a light wrapper around jQuery
884         UI's dialog widget.  We then use ui.MessageBox to show status messages
885         about in-progress rebaselines.  As each baseline is downloaded, the
886         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
887
888         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
889         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
890         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
891         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
892         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
893         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
894
895 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
896
897         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
898         https://bugs.webkit.org/show_bug.cgi?id=68024
899
900         Reviewed by Gustavo Noronha Silva.
901         
902         Using g_list_count() and g_list_nth_data() together on a loop is
903         inneficient since they're both O(n). Iterate over lists in a saner
904         way.
905
906         * DumpRenderTree/gtk/DumpRenderTree.cpp:
907         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
908         iterate on it using g_list_next(). Free the list after done with it.
909         (dumpBackForwardListForWebView): Instead of appending (which is
910         expensive in GLists) history items and then iterating from the tail
911         of the itemsToPrint list, prepend items and walk forwards as usual.
912         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
913         remove the (unneeded) viewList variable.
914
915 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
916
917         Add Eric's IRC nick.
918
919         * Scripts/webkitpy/common/config/committers.py:
920
921 2011-09-13  Anders Carlsson  <andersca@apple.com>
922
923         Disable C++ exceptions when building with clang
924         https://bugs.webkit.org/show_bug.cgi?id=68031
925         <rdar://problem/9556880>
926
927         Reviewed by Mark Rowe.
928
929         * MiniBrowser/Configurations/Base.xcconfig:
930         * TestWebKitAPI/Configurations/Base.xcconfig:
931         * WebKitTestRunner/Configurations/Base.xcconfig:
932
933 2011-09-13  Ojan Vafai  <ojan@chromium.org>
934
935         [chromium] fix flakiness dashboard for chromium interactive tests
936         https://bugs.webkit.org/show_bug.cgi?id=68029
937
938         Reviewed by Tony Chang.
939
940         * TestResultServer/static-dashboards/flakiness_dashboard.html:
941         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
942
943 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
944
945         Add Alice and Aryeh to the list of contributors.
946
947         * Scripts/webkitpy/common/config/committers.py:
948
949 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
950
951         sheriffbot whois should also tell us email addresses
952         https://bugs.webkit.org/show_bug.cgi?id=67975
953
954         Reviewed by Eric Seidel and David Levin.
955
956         Taught sheriffbot how to tell us contributor's email addresses.
957
958         * Scripts/webkitpy/tool/bot/irc_command.py:
959         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
960
961 2011-09-13  Eric Seidel  <eric@webkit.org>
962
963         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
964         https://bugs.webkit.org/show_bug.cgi?id=68018
965
966         Reviewed by Ryosuke Niwa.
967
968         * Scripts/build-webkit:
969         * waf/build/settings.py:
970
971 2011-09-13  Chang Shu  <cshu@webkit.org>
972
973         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
974         https://bugs.webkit.org/show_bug.cgi?id=57515
975
976         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
977         TestController synchronously. The latter then sends simulated event to WebKit2 module,
978         which is synchronous, too.
979
980         Reviewed by Darin Adler.
981
982         * WebKitTestRunner/EventSenderProxy.h: Added.
983         (WTR::EventSenderProxy::EventSenderProxy):
984         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
985         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
986         (WTR::EventSendingController::keyDown):
987         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
988         * WebKitTestRunner/PlatformWebView.h:
989         (WTR::PlatformWebView::platformWindow):
990         * WebKitTestRunner/TestController.cpp:
991         (WTR::TestController::TestController):
992         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
993         * WebKitTestRunner/TestController.h:
994         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
995         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
996         (WTR::buildModifierFlags):
997         (WTR::EventSenderProxy::keyDown):
998
999 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
1000
1001         [EFL] DRT: Add DumpRenderTreeEfl.h
1002         https://bugs.webkit.org/show_bug.cgi?id=63993
1003
1004         Reviewed by Eric Seidel.
1005         
1006         This header contains some global variables used by EFL's
1007         DumpRenderTree implementation.
1008
1009         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
1010         appropriate.
1011         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
1012
1013 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
1014
1015         [EFL] Send the right key names for PageUp and PageDown.
1016         https://bugs.webkit.org/show_bug.cgi?id=67044
1017
1018         Reviewed by Kenneth Rohde Christiansen.
1019
1020         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
1021         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
1022         However, EventSender was sending "Page_Up" and "Page_Down", so tests
1023         such as editing/input/page-up-down-scrolls.html were timing out due to
1024         the right key down events not being sent.
1025
1026         * DumpRenderTree/efl/EventSender.cpp:
1027         (keyPadNameFromJSValue):
1028         (keyNameFromJSValue):
1029
1030 2011-09-12  Eric Seidel  <eric@webkit.org>
1031
1032         sheriffbot whois is case sensitive
1033         https://bugs.webkit.org/show_bug.cgi?id=67972
1034
1035         Reviewed by Adam Barth.
1036
1037         I also fixed a typo in the "More than 5 contributors" message
1038         from my previous commit.
1039
1040         * Scripts/webkitpy/common/config/committers.py:
1041         * Scripts/webkitpy/common/config/committers_unittest.py:
1042         * Scripts/webkitpy/tool/bot/irc_command.py:
1043         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1044
1045 2011-09-12  Eric Seidel  <eric@webkit.org>
1046
1047         sheriffbot whois should be smarter
1048         https://bugs.webkit.org/show_bug.cgi?id=67971
1049
1050         Reviewed by Adam Barth.
1051
1052         This makes sheriffbot whois basically grep the committers list
1053         making it much easier to find a contributor by name.
1054
1055         Unfortunately the current unittests depend on the real committers.py
1056         file, so as we add more eric's to the project, this unittest result will
1057         change.  I think that's OK for now.  We'll fix it when it breaks.
1058
1059         * Scripts/webkitpy/common/config/committers.py:
1060         * Scripts/webkitpy/tool/bot/irc_command.py:
1061         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1062
1063 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1064
1065         Unreviewed, rolling out r94976.
1066         http://trac.webkit.org/changeset/94976
1067         https://bugs.webkit.org/show_bug.cgi?id=67953
1068
1069         Broke a bunch of security/load& tests (Requested by rniwa on
1070         #webkit).
1071
1072         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1073         (LayoutTestController::pathToLocalResource):
1074
1075 2011-09-12  Eric Seidel  <eric@webkit.org>
1076
1077         Rubber-stamped by Adam Barth.
1078
1079         Remove the "the tree is burning!" warning previously shown
1080         when landing patches.  It was a dream.  But it's just noise now.
1081
1082         Some bots will require a restart to notice the removal of the option
1083         so I've left the --ignore-builders option in for now.
1084
1085         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1086         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1087         * Scripts/webkitpy/tool/commands/download.py:
1088         * Scripts/webkitpy/tool/commands/download_unittest.py:
1089         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1090         * Scripts/webkitpy/tool/steps/__init__.py:
1091         * Scripts/webkitpy/tool/steps/commit.py:
1092         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
1093         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1094
1095 2011-09-12  Eric Seidel  <eric@webkit.org>
1096
1097         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
1098         https://bugs.webkit.org/show_bug.cgi?id=65781
1099
1100         Reviewed by Ryosuke Niwa.
1101
1102         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
1103         to resolve the passed in url relative to the absolute url for the test.
1104
1105         I believe this is a better approach than the on used in the Qt and Chromium DRT's
1106         (which resolves the path relative to the built location of the DRT executable)
1107         and we should move this new code into a shared location in a follow-up patch.
1108
1109         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1110         (LayoutTestController::pathToLocalResource):
1111
1112 2011-09-12  Eric Seidel  <eric@webkit.org>
1113
1114         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1115         https://bugs.webkit.org/show_bug.cgi?id=67530
1116
1117         Reviewed by Adam Barth.
1118
1119         I believe I've fixed the bug in the original patch which prompted the rollout.
1120         The previous patch was using the wrong deadline for the initial read,
1121         subtracting time.time() twice from the deadline value.
1122
1123         * Scripts/webkitpy/layout_tests/port/webkit.py:
1124         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1125
1126 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
1127
1128         [Qt][WK2] WebKitTestRunner does not produce crash logs
1129         https://bugs.webkit.org/show_bug.cgi?id=67714
1130
1131         Reviewed by Chang Shu.
1132
1133         Added a simple way of generating backtrace on crash
1134         to the web process. The implementation is similar what
1135         we have in DRT. It depends on GNU libc functionality
1136         so it is only enabled where we are running in such an environment.
1137
1138         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1139         (WTR::printBacktrace):
1140         (WTR::crashHandler):
1141         (WTR::InjectedBundle::platformInitialize):
1142
1143 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
1144
1145         Added my IRC nick to the committers file.
1146
1147         * Scripts/webkitpy/common/config/committers.py:
1148
1149 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
1150
1151         The executable allocator makes it difficult to free individual
1152         chunks of executable memory
1153         https://bugs.webkit.org/show_bug.cgi?id=66363
1154
1155         Reviewed by Oliver Hunt.
1156         
1157         Introduced a best-fit, balanced-tree based allocator. The allocator
1158         required a balanced tree that does not allocate memory and that
1159         permits the removal of individual nodes directly (as opposed to by
1160         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
1161         Changed all references to executable code to use a reference counted
1162         handle.
1163
1164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1165         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
1166         (TestWebKitAPI::TEST_F):
1167         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
1168         (TestWebKitAPI::Pair::findExact):
1169         (TestWebKitAPI::Pair::remove):
1170         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
1171         (TestWebKitAPI::Pair::assertFoundAndRemove):
1172         (TestWebKitAPI::Pair::assertEqual):
1173         (TestWebKitAPI::Pair::assertSameValuesForKey):
1174         (TestWebKitAPI::Pair::testDriver):
1175         (TestWebKitAPI::TEST_F):
1176
1177 2011-09-10  Andy Estes  <aestes@apple.com>
1178
1179         Move myself from committers_unable_to_review to reviewers_list.
1180
1181         * Scripts/webkitpy/common/config/committers.py:
1182
1183 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
1184
1185         [wx] Unreviewed build fix. MSW build fixes.
1186
1187         * DumpRenderTree/config.h:
1188         * waf/build/wxpresets.py:
1189
1190 2011-09-10  Andreas Kling  <kling@webkit.org>
1191
1192         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
1193         https://bugs.webkit.org/show_bug.cgi?id=59328
1194
1195         Reviewed by Kenneth Rohde Christiansen.
1196
1197         * MiniBrowser/mac/BrowserWindowController.m:
1198         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
1199
1200 2011-09-10  Adam Barth  <abarth@webkit.org>
1201
1202         Build fix for Android.  DumpRenderTree is a client of the WebKit API
1203         and does not have access to notImplemented().
1204
1205         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1206         (openStartupDialog):
1207
1208 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
1209
1210         Add a script to create a monolithic script-test
1211         https://bugs.webkit.org/show_bug.cgi?id=67747
1212
1213         Reviewed by Darin Adler.
1214
1215         * Scripts/make-new-script-test: Added.
1216
1217 2011-09-09  Luiz Agostini  <luiz@webkit.org>
1218
1219         Adding myself to the reviewers list.
1220
1221         * Scripts/webkitpy/common/config/committers.py:
1222
1223 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
1224
1225         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
1226         https://bugs.webkit.org/show_bug.cgi?id=67855
1227
1228         Reviewed by Dirk Pranke.
1229
1230         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
1231         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
1232
1233         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
1234
1235         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1236
1237 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
1238
1239         Add myself to committers.py
1240         https://bugs.webkit.org/show_bug.cgi?id=67853
1241
1242         Reviewed by Darin Adler.
1243
1244         * Scripts/webkitpy/common/config/committers.py:
1245
1246 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1247
1248         [Qt] Remove common.pri
1249         https://bugs.webkit.org/show_bug.cgi?id=67814
1250
1251         Reviewed by Andreas Kling.
1252
1253         * Tools.pro:
1254
1255 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1256
1257         [NRWT] the nrwt check httpd with --no-http option
1258         https://bugs.webkit.org/show_bug.cgi?id=67835
1259
1260         Reviewed by Tony Chang.
1261
1262         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1263         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1264
1265 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
1266
1267         [chromium] Implement DRT support for Android.
1268         https://bugs.webkit.org/show_bug.cgi?id=67590
1269
1270         Reviewed by Tony Chang.
1271
1272         Add 2 mechanism to make DRT interaction more robust on Android:
1273         - Send 'QUIT' to DRT to make it stop.
1274         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
1275         input commands before it starts.
1276         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
1277         and <clocale> for 'LC_ALL' to compile on Android.
1278
1279         Also change to use sigaction instead of signal for TestShellGtk.cpp,
1280         as signal() man page recommends using sigaction().
1281
1282         * DumpRenderTree/DumpRenderTree.gypi:
1283         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1284         (main):
1285         * DumpRenderTree/chromium/LayoutTestController.cpp:
1286         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
1287         (AlarmHandler):
1288         (TestShell::waitTestFinished):
1289         (platformInit):
1290         (openStartupDialog):
1291         (checkLayoutTestSystemDependencies):
1292         * DumpRenderTree/chromium/TestShellGtk.cpp:
1293         (AlarmHandler):
1294         (TestShell::waitTestFinished):
1295
1296 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
1297
1298         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
1299
1300         * waf/build/settings.py:
1301
1302 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1303
1304         Unreviewed, rolling out r94851.
1305         http://trac.webkit.org/changeset/94851
1306         https://bugs.webkit.org/show_bug.cgi?id=67847
1307
1308         It broke a webkitpy test (Requested by ossy on #webkit).
1309
1310         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1311
1312 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1313
1314         [NRWT] the nrwt check httpd with --no-http option
1315         https://bugs.webkit.org/show_bug.cgi?id=67835
1316
1317         Reviewed by Csaba Osztrogonác.
1318
1319         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1320
1321 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
1322
1323         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
1324         https://bugs.webkit.org/show_bug.cgi?id=67794
1325         <rdar://problem/9892024>
1326         
1327         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
1328
1329         Reviewed by Brady Eidson.
1330
1331         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
1332         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
1333         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
1334         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
1335             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
1336             didPerformServerRedirect.
1337
1338         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
1339         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
1340             our InjectedBundleTest.
1341         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
1342             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
1343             the request.
1344         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
1345
1346         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
1347         
1348         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1349         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1350         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
1351         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
1352
1353 2011-09-08  David Levin  <levin@chromium.org>
1354
1355         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
1356         https://bugs.webkit.org/show_bug.cgi?id=67797
1357
1358         Reviewed by Eric Seidel.
1359
1360         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
1361         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
1362
1363 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
1364
1365         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
1366         https://bugs.webkit.org/show_bug.cgi?id=67723
1367
1368         Reviewed by Adam Barth.
1369
1370         * DumpRenderTree/chromium/EventSender.h:
1371         * DumpRenderTree/chromium/LayoutTestController.cpp:
1372         (LayoutTestController::LayoutTestController):
1373         (LayoutTestController::enableFixedLayoutMode):
1374         (LayoutTestController::setFixedLayoutSize):
1375         * DumpRenderTree/chromium/LayoutTestController.h:
1376
1377 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
1378
1379         Add standalone script that filters the output of build-webkit to be more human-readable
1380         https://bugs.webkit.org/show_bug.cgi?id=44081
1381
1382         Reviewed by Daniel Bates.
1383
1384         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
1385         a build script (e.g. build-webkit) and it spits out a prettier version.
1386         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
1387         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
1388
1389 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
1390
1391         Add myself to committers.py                 
1392         https://bugs.webkit.org/show_bug.cgi?id=67696
1393
1394         Reviewed by Kent Tamura.
1395
1396         * Scripts/webkitpy/common/config/committers.py:
1397
1398 2011-09-07  Adam Barth  <abarth@webkit.org>
1399
1400         rebaseline button in garden-o-matic details view should work
1401         https://bugs.webkit.org/show_bug.cgi?id=67738
1402
1403         Reviewed by Dimitri Glazkov.
1404
1405         This patch wires up the rebaseline button in garden-o-matic results
1406         details view.  The button is current per-test, so there isn't a way to
1407         rebaseline individual bots.  This is a place to start.  If we decide we
1408         want per-bot rebaselining, we'll need to think of some better UI.
1409
1410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1414
1415 2011-09-07  Eric Seidel  <eric@webkit.org>
1416
1417         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
1418         https://bugs.webkit.org/show_bug.cgi?id=67737
1419
1420         Reviewed by Adam Barth.
1421
1422         I got a little over-eager when deprecating host.port_factory in the previous commit.
1423         Turns out that Host.port_factory was already the "modern" port/factory.py
1424         it was just the Module object.  I un-deprecated the variable, and changed it from
1425         being the module to being an actual PortFactory, passing it a host object.
1426         I also taught PortFactory how to set user/executive/filesystem in the kwargs
1427         when instantiating a new Port object.
1428         This magically fixed the test_rebaseline test, since its now no longer talking
1429         to the real filesystem.
1430
1431         * Scripts/webkitpy/common/host.py:
1432         * Scripts/webkitpy/layout_tests/port/factory.py:
1433         * Scripts/webkitpy/tool/commands/queries.py:
1434         * Scripts/webkitpy/tool/mocktool.py:
1435
1436 2011-09-07  Eric Seidel  <eric@webkit.org>
1437
1438         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
1439         https://bugs.webkit.org/show_bug.cgi?id=67734
1440
1441         Reviewed by Adam Barth.
1442
1443         Right now every place that creates a Port object has to be very careful
1444         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
1445         The correct fix is for port/factory.py (which creates most port objects)
1446         to know how to pass these in automatically.  However, currently all port/factory.py
1447         functions are free functions instead of being on an object.  This patch
1448         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
1449
1450         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
1451         pass along the proper scm/user/filesystem to the Port object.
1452
1453         * Scripts/webkitpy/common/host.py:
1454         * Scripts/webkitpy/layout_tests/port/factory.py:
1455         * Scripts/webkitpy/tool/commands/queries.py:
1456         * Scripts/webkitpy/tool/mocktool.py:
1457
1458 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1459
1460         Unreviewed, rolling out r94441.
1461         http://trac.webkit.org/changeset/94441
1462         https://bugs.webkit.org/show_bug.cgi?id=67731
1463
1464         "MacEWSes are backed up due to new machines not able to reach
1465         git.webkit.org.  Disabling tests for now" (Requested by
1466         eseidel2 on #webkit).
1467
1468         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1469
1470 2011-09-07  Elliot Poger  <epoger@google.com>
1471
1472         filter test_expectations properly for chromium-mac vs chromium-cg-mac
1473         https://bugs.webkit.org/show_bug.cgi?id=67324
1474
1475         Reviewed by Dirk Pranke.
1476
1477         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1478         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1479         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1480         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1481         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1482
1483 2011-09-07  Eric Boren  <borenet@gmail.com>
1484
1485         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
1486         https://bugs.webkit.org/show_bug.cgi?id=66800
1487
1488         Reviewed by Darin Fisher.
1489
1490         * DumpRenderTree/chromium/EventSender.cpp:
1491         (EventSender::sendCurrentTouchEvent):
1492
1493 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
1494
1495         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1496         https://bugs.webkit.org/show_bug.cgi?id=67254
1497
1498         Reviewed by Csaba Osztrogonác.
1499
1500         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
1501         derived from the running location of DumpRenderTree binary.
1502
1503         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1504         (LayoutTestController::pathToLocalResource):
1505         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
1506
1507 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1508
1509         REGRESSION(r94288) build-webkit doesn't work on Symbian
1510         https://bugs.webkit.org/show_bug.cgi?id=67706
1511
1512         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
1513         (buildQMakeProject):
1514
1515 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1516
1517         REGRESSION(r94288) build-webkit doesn't work on Windows
1518         https://bugs.webkit.org/show_bug.cgi?id=67646
1519
1520         Roll back r94655 with a small fix.
1521
1522         * Scripts/webkitdirs.pm:
1523         (buildQMakeProject):
1524
1525 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1526
1527         Unreviewed, rolling out r94635.
1528         http://trac.webkit.org/changeset/94635
1529         https://bugs.webkit.org/show_bug.cgi?id=67704
1530
1531         Linux Touch build is failing to compile this change.
1532         (Requested by loislo on #webkit).
1533
1534         * DumpRenderTree/chromium/EventSender.cpp:
1535         (EventSender::sendCurrentTouchEvent):
1536
1537 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1538
1539         Unreviewed, rolling out r94655.
1540         http://trac.webkit.org/changeset/94655
1541         https://bugs.webkit.org/show_bug.cgi?id=67703
1542
1543         It broke Leopard debug bot (Requested by ossy on #webkit).
1544
1545         * Scripts/webkitdirs.pm:
1546
1547 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1548
1549         REGRESSION(r94288) build-webkit doesn't work on Windows
1550         https://bugs.webkit.org/show_bug.cgi?id=67646
1551
1552         Reviewed by Csaba Osztrogonác.
1553
1554         * Scripts/webkitdirs.pm:
1555
1556 2011-09-06  Eric Boren  <borenet@gmail.com>
1557
1558         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
1559         https://bugs.webkit.org/show_bug.cgi?id=66800
1560
1561         Reviewed by Darin Fisher.
1562
1563         * DumpRenderTree/chromium/EventSender.cpp:
1564         (EventSender::sendCurrentTouchEvent):
1565
1566 2011-09-06  Adam Barth  <abarth@webkit.org>
1567
1568         garden-o-matic details view should having working rebaseline and next/previous buttons
1569         https://bugs.webkit.org/show_bug.cgi?id=67659
1570
1571         Reviewed by Dimitri Glazkov.
1572
1573         This patch wires up basic back/forward buttons that let you traverse
1574         through the results we're examining in the details view.  This ended up
1575         being more code than I expected, but I wanted to keep all the state
1576         information in the DOM itself.
1577
1578         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1579         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1580         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1581
1582 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
1583
1584         fix MockFileSystem.glob(), refactor filesystem tests
1585         https://bugs.webkit.org/show_bug.cgi?id=67462
1586
1587         Reviewed by Eric Seidel.
1588
1589         In debugging why my proposed change for MockFileSystem.glob()
1590         in bug 66228 didn't work, I stumbled across two real bugs
1591         that cancelled each other out for the unit tests. I fixed those
1592         (glob shouldn't recurse into subdirs, and we weren't populating
1593         self.dirs from self.files properly).
1594
1595         I have also created a "mixin" class for tests that can be shared
1596         between the real filesystem and the mock filesystem - MockFileSystem
1597         is being used enough it needs its own tests.
1598
1599         * Scripts/webkitpy/common/system/filesystem_mock.py:
1600         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
1601         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1602
1603 2011-09-06  Anders Carlsson  <andersca@apple.com>
1604
1605         Move NPAPI headers in bridge to plugins
1606         https://bugs.webkit.org/show_bug.cgi?id=67661
1607
1608         Update forwarding headers.
1609
1610         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1611         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1612
1613 2011-09-06  Tony Chang  <tony@chromium.org>
1614
1615         [chromium] Check in 'build' for compiled binaries first
1616         https://bugs.webkit.org/show_bug.cgi?id=67549
1617
1618         Reviewed by Dirk Pranke.
1619
1620         I'm working on moving the windows build output to a common location
1621         rather than relative to the sln file.  Because of that, we need to
1622         check those build locations first for DumpRenderTree.exe.
1623
1624         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1625
1626 2011-09-06  Adam Barth  <abarth@webkit.org>
1627
1628         Use a hierarchial structure for the garden-o-matic results view
1629         https://bugs.webkit.org/show_bug.cgi?id=67620
1630
1631         Reviewed by Dimitri Glazkov.
1632
1633         This patch re-organizes the results view to use a hierachial structure
1634         for selection.  At the top-level are sections for each test.  Expanding
1635         the test section shows a tab selector for builders.
1636
1637         This structure prepares us for wiring up various actions to this view.
1638
1639         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1640         (.):
1641         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1642         ():
1643         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1644         (.):
1645         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1646         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1647         (.results-view>.toolbar):
1648         (.results-view>.toolbar ul.actions):
1649         (.results-view>.toolbar ul.actions li):
1650         (.results-grid table):
1651         (.results-grid table td, .results-view table th):
1652         (.results-grid table th):
1653         (.results-grid .text-result):
1654         (.results-grid .image-result):
1655
1656 2011-09-06  Adam Barth  <abarth@webkit.org>
1657
1658         garden-o-matic's base.probe generates spam in the JavaScript console
1659         https://bugs.webkit.org/show_bug.cgi?id=67622
1660
1661         Reviewed by Dimitri Glazkov.
1662
1663         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
1664         instead of HTMLScriptElement to test whether results exist.  This
1665         reduces the console.log spam and saves bandwidth because we can use a
1666         HEAD request instead of a GET request.
1667
1668         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1669
1670 2011-09-05  Adam Barth  <abarth@webkit.org>
1671
1672         Add a tab to garden-o-matic for viewing expected failures
1673         https://bugs.webkit.org/show_bug.cgi?id=67619
1674
1675         Reviewed by Dimitri Glazkov.
1676
1677         This patch adds a basic tab to garden-o-matic that shows all the tests
1678         failing on the bots, including the expected failures.  This patch
1679         mostly involves refactoring existing classes to allow new subclasses.
1680
1681         This view is useful for when gardeners mark tests as expected to fail
1682         and then rebaseline them later.
1683
1684         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1685         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1686         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1687         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
1688         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1689         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1691
1692 2011-09-05  Adam Barth  <abarth@webkit.org>
1693
1694         Fix global variable leak in garden-o-matic
1695         https://bugs.webkit.org/show_bug.cgi?id=67617
1696
1697         Reviewed by Dimitri Glazkov.
1698
1699         Caught by running the unit tests with noglobals turned on.
1700
1701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1702
1703 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
1704
1705         [Qt][WK2] Add pixel test support
1706         https://bugs.webkit.org/show_bug.cgi?id=66283
1707
1708         Reviewed by Andreas Kling.
1709
1710         Implemented pixel result generation by reusing the logic
1711         that we have in DumpRenderTree.
1712         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1713         (WTR::dumpImage):
1714         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1715
1716 2011-09-04  Robin Dunn  <robin@alldunn.com>
1717
1718         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
1719         https://bugs.webkit.org/show_bug.cgi?id=67577
1720
1721         Reviewed by Kevin Ollivier.
1722
1723         * waf/build/settings.py:
1724
1725 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
1726
1727         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
1728
1729         * waf/build/settings.py:
1730
1731 2011-09-03  Dan Bernstein  <mitz@apple.com>
1732
1733         32-bit build fix.
1734
1735         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1736         (TestWebKitAPI::Util::toSTD):
1737
1738 2011-09-03  Dan Bernstein  <mitz@apple.com>
1739
1740         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
1741         https://bugs.webkit.org/show_bug.cgi?id=67559
1742
1743         Reviewed by Darin Adler.
1744
1745         * DumpRenderTree/mac/DumpRenderTree.mm:
1746         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
1747         the call to it.
1748         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
1749         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
1750         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
1751         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
1752         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1753         (TestWebKitAPI::Util::toSTD): Added.
1754
1755 2011-09-03  Adam Barth  <abarth@webkit.org>
1756
1757         garden-o-matic results view should have a better results selector
1758         https://bugs.webkit.org/show_bug.cgi?id=67542
1759
1760         Reviewed by Dimitri Glazkov.
1761
1762         This patch adds a basic grid-based results selector to the results
1763         view.  Currently, this grid just shows how the tests fail on the
1764         various bots.  A future patch will let you select which failure to view
1765         and to mark the failures for rebaselining.
1766
1767         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1768         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1769           - Add some more basic functions for manipulating dictionaries.
1770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1771         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1772         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1773
1774 2011-09-03  Adam Barth  <abarth@webkit.org>
1775
1776         garden-o-matic results view should show Actual and Expected results for text failures
1777         https://bugs.webkit.org/show_bug.cgi?id=67536
1778
1779         Reviewed by Eric Seidel.
1780
1781         In the past, we didn't show actual and expected text results (we just
1782         showed the diff) because we didn't have the awesome six-by-two results
1783         grid.  Now that we do, we can move show these results.
1784
1785         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1786         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1787           - Fixed some typos that were preventing these unit tests from running.
1788         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1789         (.):
1790         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1791           - Report -actual.txt and -expected.txt as possible results URLs.
1792
1793 2011-09-03  Adam Barth  <abarth@webkit.org>
1794
1795         garden-o-matic shows "ghost" failures that are already fixed
1796         https://bugs.webkit.org/show_bug.cgi?id=67535
1797
1798         Reviewed by Eric Seidel.
1799
1800         About 10% of writes fail to stick on test-results.appspot.com.  This
1801         patch causes us to fetch the full_results.json blob directly from
1802         build.chromium.org rather than relying upon AppEngine.
1803
1804         Unforuntately, we still need to get historical information from
1805         AppEngine.  That will take several patches to fix becuase I need to
1806         change the bots to write the full_results.json file to the
1807         build-specific directory in addition to the zip file.
1808
1809         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1810         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1811         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1812
1813 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1814
1815         Unreviewed, rolling out r94458.
1816         http://trac.webkit.org/changeset/94458
1817         https://bugs.webkit.org/show_bug.cgi?id=67558
1818
1819         Caused appcache test to fail on various bots (Requested by
1820         rniwa on #webkit).
1821
1822         * Scripts/webkitpy/layout_tests/port/webkit.py:
1823         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1824
1825 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1826
1827         Unreviewed, rolling out r94453.
1828         http://trac.webkit.org/changeset/94453
1829         https://bugs.webkit.org/show_bug.cgi?id=67557
1830
1831         Caused appcache test to fail on various bots (Requested by
1832         rniwa on #webkit).
1833
1834         * Scripts/webkitpy/layout_tests/port/webkit.py:
1835
1836 2011-09-02  Michael Saboff  <msaboff@apple.com>
1837
1838         Add JSC:RegExp functional tests
1839         https://bugs.webkit.org/show_bug.cgi?id=67339
1840
1841         New perl script to build JavaScriptCore and run the RegExp tests.
1842
1843         Reviewed by Gavin Barraclough.
1844
1845         * Scripts/run-regexp-tests: Added.
1846
1847 2011-09-02  Michael Saboff  <msaboff@apple.com>
1848
1849         Add JSC:RegExp functional tests
1850         https://bugs.webkit.org/show_bug.cgi?id=67339
1851
1852         New perl script to build JavaScriptCore and run the RegExp tests.
1853
1854         Reviewed by Gavin Barraclough.
1855
1856         * Scripts/run-regexp-tests: Added.
1857
1858 2011-09-02  Eric Seidel  <eric@webkit.org>
1859
1860         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1861         https://bugs.webkit.org/show_bug.cgi?id=67530
1862
1863         Unreviewed.  Fixing typo from previous commit.
1864
1865         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
1866         which exercises the code I previously made a typo in.
1867
1868         * Scripts/webkitpy/layout_tests/port/webkit.py:
1869         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1870
1871 2011-09-02  Eric Seidel  <eric@webkit.org>
1872
1873         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1874         https://bugs.webkit.org/show_bug.cgi?id=67530
1875
1876         Reviewed by Adam Barth.
1877
1878         No functional change, just reshuffling code.
1879
1880         * Scripts/webkitpy/layout_tests/port/webkit.py:
1881
1882 2011-09-02  Darin Adler  <darin@apple.com>
1883
1884         Added Subversion ignore for .pyc generated files.
1885
1886         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
1887         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
1888         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
1889
1890 2011-09-02  Adam Barth  <abarth@webkit.org>
1891
1892         Enable testing on mac-ews
1893         https://bugs.webkit.org/show_bug.cgi?id=67505
1894
1895         Reviewed by Eric Seidel.
1896
1897         This patch enables testing on the Mac EWS, which should help
1898         contributors not turn the Mac bots red.
1899
1900         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1901
1902 2011-09-01  Beth Dakin  <bdakin@apple.com>
1903
1904         https://bugs.webkit.org/show_bug.cgi?id=67451
1905         Add a test for going back to a cached page after changing the device scale factor
1906
1907         Reviewed by Adam Roben.
1908
1909         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
1910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1911         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
1912         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1913         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
1914         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
1915         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
1916         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
1917         (TestWebKitAPI::TEST_F):
1918
1919         Added new function to WebKitAgnosticTest to goBack. Separated 
1920         waitForLoadToFinish() into its own function (instead of being a part of 
1921         loadAndWaitUntilFinished()) so that it can be called from goBack as 
1922         well. Also added initializeView() so we can set the cache model.
1923         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
1924         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
1925         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1926         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
1927         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1928         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1929         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
1930         (TestWebKitAPI::WebKitAgnosticTest::goBack):
1931         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
1932
1933 2011-09-02  Anders Carlsson  <andersca@apple.com>
1934
1935         Build fix.
1936
1937         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
1938         (PrivateBrowsing::ScriptableObject::pluginTest):
1939
1940 2011-09-02  Anders Carlsson  <andersca@apple.com>
1941
1942         Move private browsing test to a PluginTest subclass
1943         https://bugs.webkit.org/show_bug.cgi?id=67498
1944
1945         Reviewed by Darin Adler.
1946
1947         * DumpRenderTree/DumpRenderTree.gypi:
1948         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1949         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1950         (pluginGetProperty):
1951         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1952         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1953         (PluginTest::NPP_SetValue):
1954         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1955         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
1956         (PrivateBrowsing::PrivateBrowsing):
1957         (PrivateBrowsing::privateBrowsingEnabled):
1958         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
1959         (PrivateBrowsing::ScriptableObject::hasProperty):
1960         (PrivateBrowsing::ScriptableObject::getProperty):
1961         (PrivateBrowsing::ScriptableObject::pluginTest):
1962         (PrivateBrowsing::NPP_New):
1963         (PrivateBrowsing::NPP_GetValue):
1964         (PrivateBrowsing::NPP_SetValue):
1965         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1966         (NPP_New):
1967         (NPP_SetValue):
1968         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1969         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1970         * GNUmakefile.am:
1971
1972 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
1973
1974         [Qt] Build dependency problems
1975         https://bugs.webkit.org/show_bug.cgi?id=38054
1976
1977         Trivial fix after r94288.
1978
1979         Rubber-stamped by Andras Becsi.
1980
1981         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
1982         (buildQMakeProject):
1983
1984 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
1985
1986         Remove my old e-mail address and add my new one.
1987
1988         Rubber-stamped by Tor Arne Vestbø.
1989
1990         * Scripts/webkitpy/common/config/committers.py:
1991
1992 2011-09-02  Philippe Normand  <pnormand@igalia.com>
1993
1994         [GTK] run-gtk-tests leaves a zombie Xvfb process
1995         https://bugs.webkit.org/show_bug.cgi?id=67389
1996
1997         Reviewed by Martin Robinson.
1998
1999         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
2000         child process instead of doing shell redirection.
2001
2002 2011-09-01  Mark Rowe  <mrowe@apple.com>
2003
2004         Fix the build by adding some more missing return types.
2005
2006         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2007         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2008
2009 2011-09-01  Eric Seidel  <eric@webkit.org>
2010
2011         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
2012         https://bugs.webkit.org/show_bug.cgi?id=66228
2013
2014         Reviewed by Dirk Pranke.
2015
2016         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
2017         The LeaksViewer tool globs for all *-leaks.txt files.
2018         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
2019
2020         In order to test this I had to fix a limitation in our MockFileSystem.glob
2021         method.  However, doing so uncovered a typo and bug in the integration tests.
2022         I've disabled the offending integration tests.
2023
2024         * Scripts/webkitpy/common/system/filesystem_mock.py:
2025         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2026         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
2027
2028 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
2029
2030         Adds a LayoutTestController method to make it possible to test
2031         starting speech input via an API call.
2032         https://bugs.webkit.org/show_bug.cgi?id=60170
2033
2034         Reviewed by Dimitri Glazkov.
2035
2036         * DumpRenderTree/LayoutTestController.h:
2037         * DumpRenderTree/chromium/LayoutTestController.cpp:
2038         (LayoutTestController::LayoutTestController):
2039         (LayoutTestController::startSpeechInput):
2040         * DumpRenderTree/chromium/LayoutTestController.h:
2041         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2042         (LayoutTestController::startSpeechInput):
2043         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2044         (LayoutTestController::startSpeechInput):
2045         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2046         (LayoutTestController::startSpeechInput):
2047         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2048         (LayoutTestController::startSpeechInput):
2049         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2050         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2051         (LayoutTestController::startSpeechInput):
2052         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2053         (LayoutTestController::startSpeechInput):
2054
2055 2011-09-01  Tim Horton  <hortont424@gmail.com>
2056
2057         Fix TestWebKitAPI build on clang-2.0
2058
2059         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2060
2061 2011-09-01  Adam Barth  <abarth@webkit.org>
2062
2063         Remove unused "extension" parameter from rebaseline gardeningserver handler
2064         https://bugs.webkit.org/show_bug.cgi?id=67384
2065
2066         Reviewed by James Robinson.
2067
2068         This parameter hasn't done anything in a while.
2069
2070         * Scripts/webkitpy/tool/commands/rebaseline.py:
2071         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2072         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2073
2074 2011-09-01  Eric Seidel  <eric@webkit.org>
2075
2076         Unreviewed.
2077
2078         Fix a typo in unittests.  Unfortunately fixing it
2079         caused several assertions.  Just disabling the test
2080         instead, since it was providing no value before due to the typo.
2081
2082         * Scripts/webkitpy/layout_tests/port/test.py:
2083
2084 2011-09-01  Adam Barth  <abarth@webkit.org>
2085
2086         Add a "rebaseline" button to the garden-o-matic summary page
2087         https://bugs.webkit.org/show_bug.cgi?id=67382
2088
2089         Reviewed by Dimitri Glazkov.
2090
2091         As much as we might wish folks to not rebaseline entire test groups at
2092         once, the truth is that doing so is a common operation.  Adding a
2093         button for this operation is likely to make folks happy.
2094
2095         This patch also cleans up a bunch of plumbing surrounding failureInfo
2096         objects.
2097
2098         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2099         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2100         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2101         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2102         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2103         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2108
2109 2011-09-01  Adam Barth  <abarth@webkit.org>
2110
2111         garden-o-matic should let the gardener assign blame for a group of test failures
2112         https://bugs.webkit.org/show_bug.cgi?id=67379
2113
2114         Reviewed by Dimitri Glazkov.
2115
2116         If a group of test failures has a large revision range, the gardener
2117         might wish to blame a specific revision for the failure.  Currently,
2118         this only effect of assigning blame in this way is to hide the other
2119         suspect commits.
2120
2121         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2122         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2123         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2124
2125 2011-09-01  Adam Barth  <abarth@webkit.org>
2126
2127         Hide garden-o-matic failure table until hover
2128         https://bugs.webkit.org/show_bug.cgi?id=67376
2129
2130         Reviewed by Dimitri Glazkov.
2131
2132         This patch removes the failure table for build failures (because it
2133         does not make sense) and hides the failure table for test groups until
2134         the user hovers over the test failure block, reducing visual noise.
2135
2136         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2138         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2139
2140 2011-09-01  Adam Barth  <abarth@webkit.org>
2141
2142         Switch garden-o-matic from commitData.title to commitData.summary
2143         https://bugs.webkit.org/show_bug.cgi?id=67375
2144
2145         Reviewed by Dimitri Glazkov.
2146
2147         commitData.title is a string provided by Trac, which isn't great in all
2148         cases.  commitData.summary is my attempt to find the most important
2149         one-line summary of the commit.  This patch switches garden-o-matic
2150         over to summary.
2151
2152         Also, this patch tweaks a bunch of CSS to tighten up the summary page
2153         and reduce visual noise.
2154
2155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2157         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2158
2159 2011-09-01  Adam Barth  <abarth@webkit.org>
2160
2161         Group failing tests in garden-o-matic if there are more than three in a folder
2162         https://bugs.webkit.org/show_bug.cgi?id=67373
2163
2164         Reviewed by Dimitri Glazkov.
2165
2166         Sometimes a failure will cause many tests in a given directory to fail.
2167         When that happens, it's better to list the directory as a single item
2168         (with a count) rather than spamming all the test names.
2169
2170         (This patch also updates a bunch of unit test expected results after my last commit.)
2171
2172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2173         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2177
2178 2011-09-01  Adam Barth  <abarth@webkit.org>
2179
2180         Lower the visual noise from the failing builders display
2181         https://bugs.webkit.org/show_bug.cgi?id=67369
2182
2183         Reviewed by Dimitri Glazkov.
2184
2185         This patch ensures that the "Building" row in the failing builders
2186         display is always last and dims it by 50% to reduce visual noise.  This
2187         lets the gardener focus on the actual failures.
2188
2189         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2190         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
2192
2193 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2194
2195         [Qt] Build dependency problems
2196         https://bugs.webkit.org/show_bug.cgi?id=38054
2197
2198         Make clean build after the defines are changed.
2199
2200         Reviewed by Csaba Osztrogonác.
2201
2202         * Scripts/webkitdirs.pm:
2203         (buildQMakeProject):
2204
2205 2011-08-31  Adam Barth  <abarth@webkit.org>
2206
2207         Move DumpRenderTree to WebKitPlatformSupport
2208         https://bugs.webkit.org/show_bug.cgi?id=67331
2209
2210         Reviewed by Darin Fisher.
2211
2212         This patch update DumpRenderTree to account for the WebKitClient =>
2213         WebKitPlatformSupport rename.
2214
2215         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2216         (NotificationPresenter::show):
2217         * DumpRenderTree/chromium/Task.cpp:
2218         (postTask):
2219
2220 2011-08-31  Eric Seidel  <eric@webkit.org>
2221
2222         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
2223         https://bugs.webkit.org/show_bug.cgi?id=67314
2224
2225         Reviewed by Adam Barth.
2226
2227         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
2228         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
2229         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
2230
2231         I also moved a bunch of code into dashboard.css which belonged there.
2232
2233         * QueueStatusServer/handlers/activebots.py: Added.
2234         * QueueStatusServer/main.py:
2235         * QueueStatusServer/stylesheets/dashboard.css:
2236         (.queue_bubble):
2237         (.queue_name):
2238         (.last_heard_from):
2239         (.status_text):
2240         (.alive):
2241         (.behind):
2242         (.dead):
2243         * QueueStatusServer/templates/activebots.html: Added.
2244         * QueueStatusServer/templates/dashboard.html:
2245         * QueueStatusServer/templates/recentstatus.html:
2246
2247 2011-08-31  Oliver Hunt  <oliver@apple.com>
2248
2249         Move CheckedArithmeticOperations.cpp to the intended location
2250
2251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2252         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
2253
2254 2011-08-31  Elliot Poger  <epoger@google.com>
2255
2256         add unittest to validate the complete set of Chromium configurations
2257         https://bugs.webkit.org/show_bug.cgi?id=67211
2258
2259         Reviewed by Adam Barth.
2260
2261         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2262
2263 2011-08-31  Nico Weber  <thakis@chromium.org>
2264
2265         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
2266         https://bugs.webkit.org/show_bug.cgi?id=67297
2267
2268         Reviewed by Tony Chang.
2269
2270         Explicitly disable smooth scrolling in chromium's DRT.
2271
2272         * DumpRenderTree/chromium/WebPreferences.cpp:
2273         (WebPreferences::applyTo):
2274
2275 2011-08-31  Oliver Hunt  <oliver@apple.com>
2276
2277         Add Checked<> tests to windows build
2278
2279         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2280
2281 2011-08-30  Oliver Hunt  <oliver@apple.com>
2282
2283         Add support for checked arithmetic
2284         https://bugs.webkit.org/show_bug.cgi?id=67095
2285
2286         Reviewed by Sam Weinig.
2287
2288         Add test cases for Checked<>
2289
2290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2291         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
2292
2293 2011-08-31  Adam Barth  <abarth@webkit.org>
2294
2295         Move summary.html to garden-o-matic.html.
2296
2297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
2298         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
2299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
2300         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
2301
2302 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
2303
2304         [chromium] DRT linux should pass nativeKeyCode to plugins
2305         https://bugs.webkit.org/show_bug.cgi?id=66679
2306
2307         Reviewed by Tony Chang.
2308
2309         * DumpRenderTree/chromium/EventSender.cpp:
2310         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
2311         (simulated) nativeKeyCode for the given input keyboard code.
2312
2313 2011-08-31  Adam Barth  <abarth@webkit.org>
2314
2315         Tighen up UI for garden-o-matic tab strip
2316         https://bugs.webkit.org/show_bug.cgi?id=67266
2317
2318         Reviewed by Dimitri Glazkov.
2319
2320         This patch add CSS to move the tab strip to the edges of the page and
2321         to remove some gratuitous border-radius.
2322
2323         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2324         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2325
2326 2011-08-31  Adam Barth  <abarth@webkit.org>
2327
2328         garden-o-matic results view shouldn't be horrifically ugly
2329         https://bugs.webkit.org/show_bug.cgi?id=67264
2330
2331         Reviewed by Dimitri Glazkov.
2332
2333         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
2334
2335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2338
2339 2011-08-31  Adam Barth  <abarth@webkit.org>
2340
2341         garden-o-matic needs a tabstrip
2342         https://bugs.webkit.org/show_bug.cgi?id=67263
2343
2344         Reviewed by Dimitri Glazkov.
2345
2346         This patch adds a basic tabstrip to garden-o-matic.  The results
2347         details view now opens in the "Results" tab, and the user can flip back
2348         and forth between the Summary and the Results tab quickly.  There's
2349         also a stub for a "Commits" tab, which is disabled.
2350
2351         This patch isn't the most beautiful in the world, but it gets the ball
2352         rolling on a multi-modal UI.
2353
2354         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2355         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2356         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2357         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2358         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2359
2360 2011-08-31  Ai Makabi  <makabi@google.com>
2361
2362         Extract reference links from reftest test file.
2363         https://bugs.webkit.org/show_bug.cgi?id=66838
2364
2365         Reviewed by Shinichiro Hamaji.
2366
2367         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
2368         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
2369         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
2370
2371 2011-08-03  Philippe Normand  <pnormand@igalia.com>
2372
2373         [webkitpy] missing log import in common/net/resultsjsonparser.py
2374         https://bugs.webkit.org/show_bug.cgi?id=65606
2375
2376         Reviewed by Martin Robinson.
2377
2378         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
2379
2380 2011-08-30  Philippe Normand  <pnormand@igalia.com>
2381
2382         [stylechecker] complains about NULL usage in some gst_structure_ calls
2383         https://bugs.webkit.org/show_bug.cgi?id=67194
2384
2385         Reviewed by Martin Robinson.
2386
2387         Don't warn about NULL in some gst_structure_ calls. 0 can't be
2388         used for these, a proper sentinel is required.
2389
2390         * Scripts/webkitpy/style/checkers/cpp.py:
2391         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2392
2393 2011-08-30  Adam Barth  <abarth@webkit.org>
2394
2395         Remove old-style UI from garden-o-matic
2396         https://bugs.webkit.org/show_bug.cgi?id=67257
2397
2398         Reviewed by Dimitri Glazkov.
2399
2400         This code is nowhere near as awesome as the new hotness.  Let's remove
2401         it so it doesn't weigh us down.
2402
2403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
2404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
2405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
2408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
2409
2410 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
2411
2412         [WebSocket] update pywebsocket to 0.6b5.
2413         https://bugs.webkit.org/show_bug.cgi?id=66924
2414
2415         Reviewed by Kent Tamura.
2416
2417         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
2418         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
2419         0.6b3 or later supports a closing handshake handler and it is useful to
2420         verify client's closing handshake implementation.
2421         0.6b4 supports AbortedByUserException. It is useful to eliminate
2422         unnecessary server warning messages on intended abnormal closures.
2423         0.6b5 supports Python 2.5.1 or Mac 10.5.
2424
2425         * Scripts/webkitpy/thirdparty/__init__.py:
2426         Update download URL and directory path.
2427
2428 2011-08-30  Dan Bernstein  <mitz@apple.com>
2429
2430         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
2431         https://bugs.webkit.org/show_bug.cgi?id=67230
2432
2433         Reviewed by Darin Adler.
2434
2435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2436         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
2437         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
2438         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
2439         (TestWebKitAPI::TEST):
2440
2441 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
2442
2443         Add MediaSource API to HTMLMediaElement
2444         https://bugs.webkit.org/show_bug.cgi?id=64731
2445
2446         Reviewed by Eric Carlson.
2447
2448         * Scripts/build-webkit:
2449
2450 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2451
2452         Emit last progress notification before calling dispatchDidFinishLoad
2453         https://bugs.webkit.org/show_bug.cgi?id=28851
2454
2455         Reviewed by Adam Barth.
2456
2457         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
2458         Chromium and GTK ports. The first two were simple changes.
2459
2460         Some refactoring was needed in GTK port to assure that the dumps are emitted
2461         correctly and the processing after the page load finished is in the right place.
2462
2463         To detect the load finished, we use the callback for the "load-status" notifier
2464         signal of the top loading frame. And we use the deprecated "load-finished" signal
2465         for dumping (if enabled) the progress finished expected output.
2466
2467         * DumpRenderTree/LayoutTestController.cpp:
2468         (LayoutTestController::LayoutTestController):
2469         (dumpProgressFinishedCallbackCallback):
2470         (LayoutTestController::staticFunctions):
2471         * DumpRenderTree/LayoutTestController.h:
2472         (LayoutTestController::dumpProgressFinishedCallback):
2473         (LayoutTestController::setDumpProgressFinishedCallback):
2474         * DumpRenderTree/chromium/LayoutTestController.cpp:
2475         (LayoutTestController::LayoutTestController):
2476         (LayoutTestController::dumpProgressFinishedCallback):
2477         (LayoutTestController::reset):
2478         * DumpRenderTree/chromium/LayoutTestController.h:
2479         (LayoutTestController::shouldDumpProgressFinishedCallback):
2480         (LayoutTestController::setShouldDumpProgressFinishedCallback):
2481         * DumpRenderTree/chromium/WebViewHost.cpp:
2482         (WebViewHost::didStopLoading):
2483         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2484         (webViewLoadFinished):
2485         (topLoadingFrameLoadFinished):
2486         (webFrameLoadStatusNotified):
2487         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2488         (LayoutTestController::reset):
2489         (LayoutTestController::dumpProgressFinishedCallback):
2490         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2491
2492 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
2493
2494         JavaScriptCore does not have a good mechanism for performance
2495         regression testing
2496         https://bugs.webkit.org/show_bug.cgi?id=67177
2497
2498         Reviewed by Darin Adler.
2499         
2500         Added a new script, which allows for testing one, two, or more VMs
2501         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
2502         are interleaved at random to minimize systematics.  The results
2503         that bencher prints includes all possible relevant information about
2504         how bencher was invoked.  Bencher can be easily used to measure
2505         performance changes down to fractions of a percent.
2506         
2507         Bencher also includes experimental support for running benchmarks in
2508         a DumpRenderTree release build.  This works in SunSpider and V8, but
2509         not yet in Kraken.  Running benchmarks in DumpRenderTree more
2510         closely mimics the performance when running in browser.
2511
2512         * Scripts/bencher: Added.
2513
2514 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
2515
2516         DumpRenderTree should begin each test with an empty cookie store
2517         https://bugs.webkit.org/show_bug.cgi?id=63545
2518         <rdar://problem/5666907>
2519
2520         Reviewed by Darin Adler.
2521
2522         * DumpRenderTree/mac/DumpRenderTree.mm:
2523         (resetDefaultsToConsistentValues):
2524         (setDefaultsToConsistentValuesForTesting):
2525         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2526         (LayoutTestController::setAlwaysAcceptCookies):
2527         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2528         (WTR::InjectedBundle::beginTesting):
2529         Use new SPIs to manipulate sessions.
2530
2531 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
2532
2533         Unreviewed, rolling out r94055 and r94057.
2534         http://trac.webkit.org/changeset/94055
2535         http://trac.webkit.org/changeset/94057
2536         https://bugs.webkit.org/show_bug.cgi?id=67191
2537
2538         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
2539
2540         * Scripts/webkitpy/thirdparty/__init__.py:
2541
2542 2011-08-30  Adam Barth  <abarth@webkit.org>
2543
2544         Chromium Android should not be a core builder
2545         https://bugs.webkit.org/show_bug.cgi?id=67184
2546
2547         Reviewed by Ryosuke Niwa.
2548
2549         This bot hasn't been consistently green yet because it has never actually run!
2550
2551         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2552         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2553
2554 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
2555
2556         [WebSocket] update pywebsocket to 0.6b4.
2557         https://bugs.webkit.org/show_bug.cgi?id=66924
2558
2559         Reviewed by Kent Tamura.
2560
2561         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
2562         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
2563         0.6b3 or later supports a closing handshake handler and it is useful to
2564         verify client's closing handshake implementation.
2565         0.6b4 supports AbortedByUserException. It is useful to eliminate
2566         unnecessary server warning messages on intended abnormal closures.
2567
2568         * Scripts/webkitpy/thirdparty/__init__.py:
2569         Update download URL and directory path.
2570
2571 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
2572
2573         sheriffbot "usage" help statements are wrong
2574         https://bugs.webkit.org/show_bug.cgi?id=67170
2575
2576         Reviewed by Adam Barth.
2577
2578         * Scripts/webkitpy/tool/bot/irc_command.py:
2579         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2580         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2581
2582 2011-08-29  Adam Barth  <abarth@webkit.org>
2583
2584         Add support for chomium-mac (non-CoreGraphics) baselines
2585         https://bugs.webkit.org/show_bug.cgi?id=67163
2586
2587         Reviewed by Eric Seidel.
2588
2589         This patch teaches the non-CG chromium-mac bots to look at non-CG
2590         baselines.  However, the patch still leaves CG as the default set of
2591         baselines.
2592
2593         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2594         * Scripts/webkitpy/common/config/build.py:
2595         * Scripts/webkitpy/common/config/build_unittest.py:
2596         * Scripts/webkitpy/layout_tests/port/builders.py:
2597         * Scripts/webkitpy/layout_tests/port/chromium.py:
2598         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2599         * Scripts/webkitpy/layout_tests/port/factory.py:
2600         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2601         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2602         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2603         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2604
2605 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
2606
2607         Small fix in chromium port of new-run-webkit-tests.
2608         https://bugs.webkit.org/show_bug.cgi?id=67078
2609
2610         Reviewed by Dirk Pranke.
2611
2612         * Scripts/webkitpy/layout_tests/port/chromium.py:
2613
2614 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2615
2616         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
2617         r93999.
2618         http://trac.webkit.org/changeset/93987
2619         http://trac.webkit.org/changeset/93992
2620         http://trac.webkit.org/changeset/93995
2621         http://trac.webkit.org/changeset/93998
2622         http://trac.webkit.org/changeset/93999
2623         https://bugs.webkit.org/show_bug.cgi?id=67147
2624
2625         Many failing tests (Requested by ap on #webkit).
2626
2627         * DumpRenderTree/mac/DumpRenderTree.mm:
2628         (setDefaultsToConsistentValuesForTesting):
2629         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2630         (WTR::InjectedBundle::beginTesting):
2631
2632 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
2633
2634         DumpRenderTree should begin each test with an empty cookie store
2635         https://bugs.webkit.org/show_bug.cgi?id=63545
2636         <rdar://problem/5666907>
2637
2638         Reviewed by Darin Adler.
2639
2640         * DumpRenderTree/mac/DumpRenderTree.mm:
2641         (setDefaultsToConsistentValuesForTesting):
2642         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2643         (WTR::InjectedBundle::beginTesting):
2644         Tell WebCore to use a temporary session, starting with a clean cookie store.
2645
2646 2011-08-23  Chris Marrin  <cmarrin@apple.com>
2647
2648         [mac] requestAnimationFrame support for mac port
2649         https://bugs.webkit.org/show_bug.cgi?id=59146
2650
2651         Reviewed by Simon Fraser.
2652
2653         Add support for request-animation-callback flag
2654
2655         * Scripts/build-webkit:
2656
2657 2011-08-27  Peter Beverloo  <peter@chromium.org>
2658
2659         Add a build bot for Chromium with OS(ANDROID)
2660         https://bugs.webkit.org/show_bug.cgi?id=66687
2661
2662         Reviewed by Adam Barth.
2663
2664         * BuildSlaveSupport/build.webkit.org-config/config.json:
2665
2666 2011-08-27  Peter Beverloo  <peter@chromium.org>
2667
2668         Update the master build bot configuration script to properly
2669         deal with the --chromium-android switch.
2670         https://bugs.webkit.org/show_bug.cgi?id=66687
2671
2672         The --chromium-android switch is needed when running
2673         update-webkit-chromium and build-webkit, as it'll tell the
2674         scripts to pull in the right dependencies and cross-compile
2675         WebKit using the Android NDK.
2676
2677         Reviewed by Adam Barth.
2678
2679         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2680
2681 2011-08-27  Peter Beverloo  <peter@chromium.org>
2682
2683         Teach the update and build scripts how to handle dependencies
2684         and cross-compiling rules for the Chromium port on OS(ANDROID).
2685         https://bugs.webkit.org/show_bug.cgi?id=66687
2686
2687         Reviewed by Adam Barth.
2688
2689         * Scripts/build-webkit:
2690         * Scripts/update-webkit:
2691         * Scripts/update-webkit-chromium:
2692         * Scripts/webkitdirs.pm:
2693         (argumentsForConfiguration):
2694         (isChromium):
2695         (isChromiumAndroid):
2696         (determineIsChromiumAndroid):
2697         (buildChromium):
2698
2699 2011-08-26  Adam Barth  <abarth@webkit.org>
2700
2701         garden-o-matic should let me know that I need to run the local server
2702         https://bugs.webkit.org/show_bug.cgi?id=66985
2703
2704         Reviewed by Dimitri Glazkov.
2705
2706         The patch triggers an alert dialog whenever the user tries to use a
2707         feature that requires the local server.
2708
2709         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2711         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2712
2713 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2714
2715         garden-o-matic summary view should have pretty commit data information.
2716         https://bugs.webkit.org/show_bug.cgi?id=67069
2717
2718         Reviewed by Adam Barth.
2719
2720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
2721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
2722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
2723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
2724
2725 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2726
2727         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
2728         https://bugs.webkit.org/show_bug.cgi?id=67066
2729
2730         Reviewed by Adam Barth.
2731
2732         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
2733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2734
2735 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
2736
2737         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
2738         https://bugs.webkit.org/show_bug.cgi?id=67041
2739
2740         Reviewed by Martin Robinson.
2741
2742         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
2743         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
2744         when the GTK+ port was being built.
2745
2746         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2747
2748 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2749
2750         Clean up and line up layout in garden-o-matic summary view.
2751         https://bugs.webkit.org/show_bug.cgi?id=67057
2752
2753         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
2754         2) Rearranged DOM structure a bit to accommodate recent changes;
2755         3) Added minimal CSS to line things up.
2756
2757         Reviewed by Adam Barth.
2758
2759         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
2760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
2761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
2762         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
2763         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
2764         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2765         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
2766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
2767         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
2768         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2769
2770 2011-08-26  Alice Liu  <alice.liu@apple.com>
2771
2772         https://bugs.webkit.org/show_bug.cgi?id=66823
2773         Add the request info to the WebPageProxy::CreateNewPage message
2774
2775         Reviewed by Anders Carlsson.
2776
2777         Update function declarations with additional parameter:
2778         * MiniBrowser/gtk/BrowserWindow.c:
2779         (createNewPage):
2780         * MiniBrowser/mac/BrowserWindowController.m:
2781         (createNewPage):
2782         * MiniBrowser/win/BrowserView.cpp:
2783         (createNewPage):
2784         * WebKitTestRunner/TestController.cpp:
2785         (WTR::TestController::createOtherPage):
2786         * WebKitTestRunner/TestController.h:
2787
2788 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
2789
2790         Make show-pretty-diff work on linux
2791         https://bugs.webkit.org/show_bug.cgi?id=67017
2792
2793         Reviewed by Adam Barth.
2794
2795         * Scripts/show-pretty-diff:
2796
2797 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2798
2799         Reorganize garden-o-matic CSS files to match JS-built views.
2800         https://bugs.webkit.org/show_bug.cgi?id=66998
2801
2802         Reviewed by Adam Barth.
2803
2804         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
2805         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
2806         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
2807         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
2808         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
2809         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2810
2811 2011-08-25  Adam Barth  <abarth@webkit.org>
2812
2813         garden-o-matic should be able to roll out patches
2814         https://bugs.webkit.org/show_bug.cgi?id=66982
2815
2816         Reviewed by Dimitri Glazkov.
2817
2818         This patch just wires the rollout event through the controller to the
2819         local server, which is already set up to perform rollouts.
2820
2821         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2822         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2823         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2824         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2825
2826 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2827
2828         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
2829         https://bugs.webkit.org/show_bug.cgi?id=66951
2830
2831         Reviewed by Andreas Kling.
2832
2833         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
2834         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
2835
2836         * MiniBrowser/qt/BrowserView.cpp:
2837         (BrowserView::resizeEvent):
2838
2839 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2840
2841         garden-o-matic summary view should provide information on builders still in flight.
2842         https://bugs.webkit.org/show_bug.cgi?id=66992
2843
2844         Reviewed by Adam Barth.
2845
2846         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
2847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
2848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
2849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
2850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2851
2852 2011-08-25  Adam Barth  <abarth@webkit.org>
2853
2854         webkit-patch rebaseline-expectations don't work when run outside the root
2855         https://bugs.webkit.org/show_bug.cgi?id=66966
2856
2857         Reviewed by Eric Seidel.
2858
2859         Turns out tool.path() used to be relative, which caused problems when
2860         running webkit-patch outside the root directory.  This patch makes it
2861         absolute.  I checked all callers, and they all appear to want this
2862         behavior.
2863
2864         It was unclear to me how to test this change because we only really
2865         have a testing strategy for webkitpy, not for the main script.
2866
2867         * Scripts/webkit-patch:
2868
2869 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2870
2871         garden-o-matic summary needs a mock view that could be used for working on styling
2872         https://bugs.webkit.org/show_bug.cgi?id=66971
2873
2874         Reviewed by Adam Barth.
2875
2876         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
2877         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
2878
2879 2011-08-25  Anders Carlsson  <andersca@apple.com>
2880
2881         Return the correct value for NPNVsupportsCarbonBool
2882         https://bugs.webkit.org/show_bug.cgi?id=66964
2883
2884         Add a test.
2885
2886         Reviewed by Adam Roben.
2887
2888         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2889         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
2890         (SupportsCarbonEventModel::SupportsCarbonEventModel):
2891         (SupportsCarbonEventModel::testConvert):
2892         (SupportsCarbonEventModel::runTest):
2893         (SupportsCarbonEventModel::NPP_New):
2894
2895 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2896
2897         garden-o-matic summary view should not be broken.
2898
2899         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
2900         (table.comparison): Added more specificity.
2901
2902 2011-08-25  Adam Barth  <abarth@webkit.org>
2903
2904         This command has been broken for a while.  This patch updates the
2905         callsite to the new API.
2906
2907         * Scripts/webkitpy/tool/commands/rebaseline.py:
2908
2909 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2910
2911         garden-o-matic needs a way to report where and how tests are failing in the summary view.
2912         https://bugs.webkit.org/show_bug.cgi?id=66955
2913
2914         Introduce FailureGrid, your one-stop failure-indicating destination. 
2915
2916         Reviewed by Adam Barth.
2917
2918         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
2919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
2920         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
2921         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
2922         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2923         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
2924
2925 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
2926
2927         Add myself to the committers list
2928         https://bugs.webkit.org/show_bug.cgi?id=66941
2929
2930         Reviewed by Andreas Kling.
2931
2932         * Scripts/webkitpy/common/config/committers.py:
2933
2934 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2935
2936         Unreviewed, rolling out r93767.
2937         http://trac.webkit.org/changeset/93767
2938         https://bugs.webkit.org/show_bug.cgi?id=66931
2939
2940         Broke Qt bot. (Requested by yutak on #webkit).
2941
2942         * Scripts/webkitpy/thirdparty/__init__.py:
2943
2944 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
2945
2946         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
2947         https://bugs.webkit.org/show_bug.cgi?id=66924
2948
2949         Reviewed by Kent Tamura.
2950
2951         * Scripts/webkitpy/thirdparty/__init__.py:
2952
2953 2011-08-24  Adam Barth  <abarth@webkit.org>
2954
2955         The user can't close the details view in garden-o-matic
2956         https://bugs.webkit.org/show_bug.cgi?id=66911
2957
2958         Reviewed by Dimitri Glazkov.
2959
2960         In addition to adding a close button, this patch changes the test
2961         selector to use a <select> element and refactors the test selector to
2962         share code with the builder selector.
2963
2964         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2968
2969 2011-08-24  James Robinson  <jamesr@chromium.org>
2970
2971         [chromium] Stacktrace not in test output when a test crashes
2972         https://bugs.webkit.org/show_bug.cgi?id=66806
2973
2974         Reviewed by Dirk Pranke.
2975
2976         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
2977         trace.
2978
2979         * Scripts/webkitpy/layout_tests/port/chromium.py:
2980
2981 2011-08-24  Adam Barth  <abarth@webkit.org>
2982
2983         Remove empty directory.
2984
2985         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
2986
2987 2011-08-24  Adam Barth  <abarth@webkit.org>
2988
2989         Finish writing up details-view in garden-o-matic
2990         https://bugs.webkit.org/show_bug.cgi?id=66891
2991
2992         Reviewed by Dimitri Glazkov.
2993
2994         This patch mostly just copies a bunch of CSS from main.css to
2995         summary.css.  Presumably we'll delete main.css soon.
2996
2997         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2998         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
3000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
3001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3002
3003 2011-08-24  James Robinson  <jamesr@chromium.org>
3004
3005         Some compositing LayoutTests flakily crashing on Mac 10.6
3006         https://bugs.webkit.org/show_bug.cgi?id=66740
3007
3008         Reviewed by Adam Barth.
3009
3010         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
3011         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
3012         chromium configuration.
3013
3014         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3015         (NPP_Destroy):
3016
3017 2011-08-24  Anton D'Auria  <adauria@apple.com>
3018
3019         No review necessary.
3020
3021         Adding myself to list of committers.
3022
3023         * Scripts/webkitpy/common/config/committers.py:
3024
3025 2011-08-24  Avi Drissman  <avi@google.com>
3026
3027         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
3028         https://bugs.webkit.org/show_bug.cgi?id=66875
3029
3030         Reviewed by James Robinson.
3031
3032         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3033         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3034
3035 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3036
3037         Make notifications appear in time order again.
3038         https://bugs.webkit.org/show_bug.cgi?id=66815
3039
3040         Reviewed by Adam Barth.
3041
3042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
3043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
3044
3045 2011-08-23  James Robinson  <jamesr@chromium.org>
3046
3047         [chromium] Need a way to test lost compositor context recovery
3048         https://bugs.webkit.org/show_bug.cgi?id=66820
3049
3050         Reviewed by Kenneth Russell.
3051
3052         Exposes a LayoutTestController interface in chromium to simulate a
3053         lost compositor context.
3054
3055         * DumpRenderTree/chromium/LayoutTestController.cpp:
3056         (LayoutTestController::LayoutTestController):
3057         (LayoutTestController::loseCompositorContext):
3058         * DumpRenderTree/chromium/LayoutTestController.h:
3059
3060 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3061
3062         Change garden-o-matic frontend builder array to be a configuration map.
3063         https://bugs.webkit.org/show_bug.cgi?id=66816
3064
3065         Reviewed by Adam Barth.
3066
3067         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
3068         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
3069         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
3070         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
3071         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
3072
3073 2011-08-23  Cary Clark  <caryclark@google.com>
3074
3075         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
3076         https://bugs.webkit.org/show_bug.cgi?id=66803
3077
3078         This fixes the WebKit Canaries, in particular avoids a crash on tests
3079         like css1/basic/comments.html.
3080
3081         Reviewed by James Robinson.
3082
3083         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3084         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3085         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
3086         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
3087         and treated it as if it were a CGContextRef.
3088
3089 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
3090
3091         Fix mergeChangeLogs test on native windows
3092         https://bugs.webkit.org/show_bug.cgi?id=66797
3093
3094         Reviewed by Adam Roben.
3095
3096         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
3097         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
3098
3099         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
3100         (writeTempFile):
3101
3102 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3103
3104         garden-o-matic relative time is wrong and updates too frequently.
3105         https://bugs.webkit.org/show_bug.cgi?id=66802
3106
3107         Reviewed by Adam Barth.
3108
3109         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
3110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
3111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
3112
3113 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
3114
3115         Add missing quotes around filenames in mergeChangeLogs
3116         https://bugs.webkit.org/show_bug.cgi?id=66794
3117
3118         Reviewed by Adam Roben.
3119
3120         * Scripts/VCSUtils.pm:
3121         (mergeChangeLogs):
3122
3123 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
3124
3125         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
3126         https://bugs.webkit.org/show_bug.cgi?id=49080
3127
3128         Reviewed by Adam Roben.
3129
3130         Use the string form of pipe open instead (like we do at all other places).
3131
3132         * Scripts/VCSUtils.pm:
3133         (mergeChangeLogs):
3134
3135 2011-08-23  Adam Barth  <abarth@webkit.org>
3136
3137         garden-o-matic summary should be able to examine failures
3138         https://bugs.webkit.org/show_bug.cgi?id=66748
3139
3140         Reviewed by Dimitri Glazkov.
3141
3142         This patch refactors a bunch of code from summary.js to independent
3143         controllers in controllers.js.  This patch also contains the first
3144         iteration of binding the "examine" event to a the behavior showing the
3145         details view for the tests.  There's more work to do here to make this
3146         work properly (and elegantly), but this patch is a start.
3147
3148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3150         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3151         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
3152         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3157
3158 2011-08-23  Adam Barth  <abarth@webkit.org>
3159
3160         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
3161         https://bugs.webkit.org/show_bug.cgi?id=66737
3162
3163         Reviewed by Steve Block.
3164
3165         This directory doesn't exist anymore now that the Android port shares
3166         more code with Chromium.
3167
3168         * Scripts/webkitpy/common/config/build.py:
3169
3170 2011-08-22  Eric Seidel  <eric@webkit.org>
3171
3172         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
3173         I won't have ssh access to the bot again for a couple days, so
3174         attempting to fix by changing this script.  If this doesn't
3175         work we'll just live with the it hung for now.
3176
3177         Unreviewed.
3178
3179         * EWSTools/start-queue.sh:
3180
3181 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3182
3183         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
3184         https://bugs.webkit.org/show_bug.cgi?id=66727
3185
3186         Reviewed by Adam Barth.
3187
3188         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
3189             in which case the serializer treats all expectations as unparsed.
3190         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
3191
3192 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3193
3194         Update unit test expectations after r93530.
3195
3196         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
3197         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
3198
3199 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3200
3201         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
3202         https://bugs.webkit.org/show_bug.cgi?id=66705
3203
3204         Reviewed by Adam Barth.
3205
3206         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
3207         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
3208
3209 2011-08-22  James Robinson  <jamesr@chromium.org>
3210
3211         [chromium] Update builder names for chromium gpu bots due to CG switchover
3212         https://bugs.webkit.org/show_bug.cgi?id=66693
3213
3214         Reviewed by Dirk Pranke.
3215
3216         Update the port and builder names for the chromium mac gpu bots to
3217         account for the CG transition.
3218
3219         * Scripts/webkitpy/layout_tests/port/builders.py:
3220
3221 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
3222
3223         fix the GPU bot names on the layout test dashboard
3224         https://bugs.webkit.org/show_bug.cgi?id=66697
3225
3226         Reviewed by Dimitri Glazkov.
3227
3228         * TestResultServer/static-dashboards/builders.js:
3229
3230 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3231
3232         garden-o-matic's relative time display should be updated regularly.
3233         https://bugs.webkit.org/show_bug.cgi?id=66682
3234
3235         Reviewed by Adam Barth.
3236
3237         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
3238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
3239         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
3240
3241 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3242
3243         Pass --makeargs of build-webkit to chromium linux builder
3244         https://bugs.webkit.org/show_bug.cgi?id=66361
3245
3246         Reviewed by Tony Chang.
3247
3248         * Scripts/build-webkit:
3249         * Scripts/webkitdirs.pm:
3250         (buildChromiumMakefile):
3251         (buildChromium):
3252
3253 2011-08-22  Peter Beverloo  <peter@chromium.org>
3254
3255         Add myself to the contributor list.
3256         https://bugs.webkit.org/show_bug.cgi?id=66674
3257
3258         Reviewed by Tony Gentilcore.
3259
3260         * Scripts/webkitpy/common/config/committers.py:
3261
3262 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
3263
3264         [Qt] ImageDiff does not consider --tolerance
3265         https://bugs.webkit.org/show_bug.cgi?id=66299
3266
3267         Reviewed by Csaba Osztrogonác.
3268
3269         * DumpRenderTree/qt/ImageDiff.cpp:
3270         (main):
3271
3272 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
3273
3274         Update contributor list.
3275
3276         Reviewed by Zoltan Herczeg.
3277
3278         * Scripts/webkitpy/common/config/committers.py:
3279
3280 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3281
3282         [ORWT] Fix --reset-results --add-platform-exceptions combo
3283         https://bugs.webkit.org/show_bug.cgi?id=65464
3284
3285         Reviewed by Csaba Osztrogonác.
3286
3287         * Scripts/old-run-webkit-tests:
3288
3289 2011-08-20  Adam Barth  <abarth@webkit.org>
3290
3291         garden-o-matic summary.html should have UI for examining failures
3292         https://bugs.webkit.org/show_bug.cgi?id=66625
3293
3294         Reviewed by Dimitri Glazkov.
3295
3296         This patch introduces the notion of UI actions and converts our
3297         existing manual <button> manipulation with this new abstraction.  The
3298         patch also adds an Examine button to failure notifications.  In a
3299         future patch, I'll add a controller that wires this button up to
3300         something useful.
3301
3302         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3303         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3304         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
3305         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
3306         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3307         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3308         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3309         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3310
3311 2011-08-20  Adam Barth  <abarth@webkit.org>
3312
3313         garden-o-matic summary page should indiciate compile failures
3314         https://bugs.webkit.org/show_bug.cgi?id=66624
3315
3316         Reviewed by Dimitri Glazkov.
3317
3318         This patch creates a notification-based UI for build failures.  The new
3319         UI displays the same information that used to be displayed in the
3320         infobar.  There's lots of room for improvement in surfacing more
3321         information, but this is a start.
3322
3323         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3324         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3325         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3326
3327 2011-08-19  James Robinson  <jamesr@chromium.org>
3328
3329         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
3330         https://bugs.webkit.org/show_bug.cgi?id=66606
3331
3332         Reviewed by Dirk Pranke.
3333
3334         The chromium GPU configuration does not (currently) contain any tests
3335         incompatible with --experimental-fully-parallel, and this flag is a
3336         significan speedup because of the directory canvas/philip/tests which
3337         contains 802 tests in the same directory. Setting this option by
3338         default on this configuration is a 2x speed in release, 44s to 22s,
3339         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
3340
3341         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3342         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3343         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3344
3345 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3346
3347         Unreviewed, rolling out r93426.
3348         http://trac.webkit.org/changeset/93426
3349         https://bugs.webkit.org/show_bug.cgi?id=66607
3350
3351         Broke the Mac build by not building gtest.framework anymore
3352         (Requested by andersca on #webkit).
3353
3354         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3355
3356 2011-08-19  James Robinson  <jamesr@chromium.org>
3357
3358         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
3359         https://bugs.webkit.org/show_bug.cgi?id=66603
3360
3361         Reviewed by Dirk Pranke.
3362
3363         The various ChromiumGpu ports should use the same child worker
3364         selection logic as other ports so they can run with full
3365         parallelization on multicore systems.
3366
3367         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3368         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3369
3370 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
3371
3372         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
3373         https://bugs.webkit.org/show_bug.cgi?id=66570
3374
3375         Reviewed by Mihai Parparita.
3376
3377         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
3378         (WebThemeControlDRTWin::draw):
3379         (WebThemeControlDRTWin::drawTextField):
3380         (WebThemeControlDRTWin::drawProgressBar):
3381         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
3382
3383 2011-08-18  Dmitry Lomov  <dslomov@google.com>
3384
3385         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
3386         https://bugs.webkit.org/show_bug.cgi?id=66521
3387
3388         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
3389
3390         Reviewed by David Levin.
3391
3392         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
3393
3394 2011-08-19  Adam Roben  <aroben@apple.com>
3395
3396         Add project file changes I left out in r93417
3397
3398         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3399
3400 2011-08-19  Adam Roben  <aroben@apple.com>
3401
3402         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
3403
3404         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
3405         NSScreen
3406
3407         Reviewed by Anders Carlsson.
3408
3409         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3410
3411         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
3412         (-[SimpleObject setValue:]): Original implementation.
3413
3414         (TestWebKitAPI::setValue2):
3415         (TestWebKitAPI::setValue3):
3416         Swizzled implementations.
3417
3418         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
3419         instance method.
3420
3421         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
3422         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
3423         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
3424         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
3425
3426 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
3427
3428         Fix _path_to_apache() error reporting
3429         https://bugs.webkit.org/show_bug.cgi?id=66486
3430
3431         Reviewed by Ryosuke Niwa.
3432
3433         * Scripts/webkitpy/layout_tests/port/webkit.py:
3434
3435 2011-08-19  Adam Roben  <aroben@apple.com>
3436
3437         Windows build fix after r93404
3438
3439         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
3440
3441 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
3442
3443         Add leandrogracia to the committers list
3444         https://bugs.webkit.org/show_bug.cgi?id=66552
3445
3446         Also fix line endings in file.
3447
3448         No reviewed required.
3449
3450         * Scripts/webkitpy/common/config/committers.py:
3451
3452 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
3453
3454         Fix compilation issue in WebKitTestRunner
3455         https://bugs.webkit.org/show_bug.cgi?id=66554
3456
3457         Reviewed by Martin Robinson.
3458
3459         * WebKitTestRunner/PixelDumpSupport.cpp:
3460
3461 2011-08-19  Adam Roben  <aroben@apple.com>
3462
3463         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
3464
3465         This will make it easier to write other WebKit-agnostic tests
3466
3467         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
3468         code in other WebKit-agnostic tests
3469
3470         Reviewed by Anders Carlsson.
3471
3472         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3473
3474         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
3475         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
3476         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
3477         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
3478         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
3479         WebKitAgnosticTest handles for us.
3480         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
3481
3482         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
3483         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
3484         DynamicDeviceScaleFactor::runTest.
3485
3486         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
3487         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
3488         DynamicDeviceScaleFactor.WebKit.
3489         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
3490         DynamicDeviceScaleFactor.WebKit2.
3491
3492 2011-08-19  Adam Roben  <aroben@apple.com>
3493
3494         Clean up #includes in TestWebKitAPI
3495
3496         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
3497
3498         Reviewed by Anders Carlsson.
3499
3500         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
3501         files and WebKit/WebKit.h for ObjC files.
3502
3503         * TestWebKitAPI/InjectedBundleController.cpp:
3504         * TestWebKitAPI/JavaScriptTest.h:
3505         * TestWebKitAPI/PlatformUtilities.h:
3506         * TestWebKitAPI/PlatformWebView.h:
3507         * TestWebKitAPI/Test.h:
3508         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3509         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3510         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
3511         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
3512         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3513         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3514         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3515         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3516         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3517         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3518         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3519         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3520         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
3521         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3522         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3523         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3524         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
3525         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3526         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
3527         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3528         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3529         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3530         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3531         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
3532         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3533         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3534         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3535         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3536         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
3537         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3538         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3539         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
3540         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
3541         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
3542         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3543         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
3544         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3545         * TestWebKitAPI/TestsController.cpp:
3546         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3547         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
3548         #includes since it is no longer a special header.
3549
3550 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
3551
3552         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
3553         https://bugs.webkit.org/show_bug.cgi?id=64886
3554
3555         Temporarily disable the http locking to work around the issue.
3556         I'm not actually sure if this is going to work or improve things
3557         much.
3558
3559         Reviewed by Ryosuke Niwa.
3560
3561         * Scripts/webkitpy/layout_tests/port/mac.py:
3562
3563 2011-08-18  Tony Chang  <tony@chromium.org>
3564
3565         add embedded png checksums to WebKitTestRunner
3566         https://bugs.webkit.org/show_bug.cgi?id=66494
3567
3568         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
3569         some code from DRT and adds it to the WebKitTestRunner.
3570
3571         Reviewed by Darin Adler.
3572
3573         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
3574         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
3575         * WebKitTestRunner/GNUmakefile.am: Add new files
3576         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
3577         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
3578         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
3579         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3580         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
3581         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3582         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3583         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
3584         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3585         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
3586
3587 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
3588
3589         https://bugs.webkit.org/show_bug.cgi?id=47240
3590
3591         Fixed a cygwin path problem in the chromium port of diff_image;
3592         Also made the return values of the diff_image function more consistent.
3593
3594         Reviewed by Dirk Pranke.
3595
3596         * Scripts/webkitpy/layout_tests/port/chromium.py:
3597
3598 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
3599
3600         [GTK] Fix compilation problems with deprecations in gtk+
3601         https://bugs.webkit.org/show_bug.cgi?id=66073
3602
3603         Reviewed by Martin Robinson.
3604
3605         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3606         (main): G_CONST_RETURN was deprecated
3607         * GtkLauncher/main.c:
3608         (createWindow): Added gtk_box_new conditional compilation for
3609         gtk+-3.
3610         * MiniBrowser/gtk/BrowserWindow.c:
3611         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
3612         are just supporting gtk+-3 for WebKit2.
3613
3614 2011-08-18  Anders Carlsson  <andersca@apple.com>
3615
3616         Fix libc++ C++0x build
3617         https://bugs.webkit.org/show_bug.cgi?id=66479
3618
3619         Reviewed by Adam Roben.
3620
3621         Add missing includes.
3622
3623         * DumpRenderTree/LayoutTestController.cpp:
3624         * DumpRenderTree/mac/CheckedMalloc.cpp:
3625
3626 2011-08-18  Adam Roben  <aroben@apple.com>
3627
3628         Test that WebKit updates style when a WebView is moved between differently-scaled windows
3629
3630         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
3631         WebView is moved between windows with different backing scale factors
3632
3633         Reviewed by Anders Carlsson.
3634
3635         * TestWebKitAPI/JavaScriptTest.cpp:
3636         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
3637         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
3638         gtest's built-in error messages.
3639
3640         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
3641         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
3642         those overloads.
3643
3644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3645
3646         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
3647         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
3648         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
3649         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.