Windows test results should not fall back to mac-mountainlion after r180176
[WebKit-https.git] / Tools / ChangeLog
1 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         Windows test results should not fall back to mac-mountainlion after r180176
4         https://bugs.webkit.org/show_bug.cgi?id=141719
5
6         Reviewed by Brent Fulgham.
7
8         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
9         (_should_file_trigger_build):
10         * Scripts/webkitpy/port/win.py:
11         (WinPort.default_baseline_search_path):
12         * Scripts/webkitpy/port/win_unittest.py:
13         (WinPortTest.test_baseline_search_path):
14
15 2015-02-17  Daniel Bates  <dabates@apple.com>
16
17         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
18         https://bugs.webkit.org/show_bug.cgi?id=141718
19
20         Reviewed by Alex Christensen.
21
22         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
23
24         * Scripts/webkitpy/port/ios.py:
25         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
26         Log a error and return False if we are unable to boot the simulator device so that the caller can take
27         appropriate action, say exit(3) before running any layout tests.
28         * Scripts/webkitpy/xcode/simulator.py:
29         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
30         with the specified UDID.
31         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
32         with the specified UDID can successfully boot and shut down. We make at most two attempts to
33         boot and shut down the device, erasing the device between tries so as to restore the device
34         to a known good state.
35
36 2015-02-17  Daniel Bates  <dabates@apple.com>
37
38         run_webkit_tests.py should not know about iOS Simulator details
39         https://bugs.webkit.org/show_bug.cgi?id=141711
40
41         Reviewed by Alex Christensen.
42
43         Run_webkit_tests.py should only parse the iOS-specific command
44         line options --runtime and --device-type. Let the port-specific
45         logic in ios.py validate the parsed options and instantiate
46         internal data structures.
47
48         Currently run_webkit_tests.py parses the iOS-specific command
49         line options --runtime and --device-type, validates them, and
50         instantiates internal data structures from the parsed strings.
51         Instead the validation logic and instantiation of internal
52         data structures should be handled by the iOS port object.
53
54         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
55         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
56         and instantiate internal data structures for them.
57         * Scripts/webkitpy/port/driver.py:
58         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
59         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
60         respectively.
61         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
62         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
63         object from --runtime, if specified. Otherwise, instantiates a Runtime
64         object for the latest installed iphonesimulator SDK version.
65         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
66         object from --device-type, if specified. Otherwise, instantiates
67         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
68         machine, respectively.
69         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
70         runtime is available to use.
71         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
72         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
73         * Scripts/webkitpy/xcode/simulator.py:
74         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
75         with a runtime identifier for the specified iOS version.
76
77 2015-02-17  Dana Burkart  <dburkart@apple.com>
78
79         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
80         https://bugs.webkit.org/show_bug.cgi?id=141672
81
82         Reviewed by David Kilzer.
83
84         * asan/webkit-asan-ignore.txt:
85
86 2015-02-17  Alex Christensen  <achristensen@webkit.org>
87
88         Remove WebCore.exp.in and clean up.
89         https://bugs.webkit.org/show_bug.cgi?id=141491
90
91         Reviewed by Andreas Kling.
92
93         * Scripts/sort-export-file: Removed.
94         * Scripts/webkitpy/style/checker.py:
95         (_all_categories):
96         (FileType):
97         (CheckerDispatcher._file_type):
98         (CheckerDispatcher._create_checker):
99         Don't check if the export files are sorted.
100         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
101         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
102
103 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
104
105         Unreviewed. Fix GTK+ make distcheck.
106
107         Do not exclude bmalloc directory from the tarball.
108
109         * gtk/manifest.txt.in:
110
111 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
112
113         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
114
115         I forgot to add the return of a bool function.
116
117         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
118         (WebKitDOMNodeTest::testDOMCache):
119
120 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
121
122         [GTK] GObject DOM bindings object are cached forever
123         https://bugs.webkit.org/show_bug.cgi?id=141558
124
125         Reviewed by Sergio Villar Senin.
126
127         Add checks for all DOM objects to ensure they are not leaked. Also
128         add a dedicated test for the DOM Object Cache.
129
130         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
131         (WebKitDOMNodeFilterTest::testTreeWalker):
132         (WebKitDOMNodeFilterTest::testNodeIterator):
133         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
134         (WebKitDOMNodeTest::testHierarchyNavigation):
135         (WebKitDOMNodeTest::testInsertion):
136         (WebKitDOMNodeTest::testTagNames):
137         (WebKitDOMNodeTest::testDOMCache):
138         (registerTests):
139         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
140         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
141         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
142         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
143         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
144         (testWebKitDOMObjectCache):
145         (beforeAll):
146         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
147         (documentLoadedCallback):
148
149 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
150
151         [GTK] WebKitFrame objects are never released
152         https://bugs.webkit.org/show_bug.cgi?id=141641
153
154         Reviewed by Martin Robinson.
155
156         Add a way to check GObjects leaks for WebProcess tests and check
157         WebKitFrame objects are not leaked.
158
159         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
160         (WebKitFrameTest::testMainFrame):
161         (WebKitFrameTest::testURI):
162         (WebKitFrameTest::testJavaScriptContext):
163         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
164         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
165         (runTest):
166         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
167
168 2015-02-16  Tim Horton  <timothy_horton@apple.com>
169
170         Fix the MiniBrowser build with newer clang
171
172         * MiniBrowser/mac/SettingsController.m:
173         (-[SettingsController _toggleBooleanDefault:]):
174         * MiniBrowser/mac/WK1BrowserWindowController.m:
175         (-[WK1BrowserWindowController windowWillClose:]):
176         * MiniBrowser/mac/WK2BrowserWindowController.m:
177         (-[WK2BrowserWindowController windowWillClose:]):
178         NSApp is id and clang gets confused about which -delegate we're talking about.
179
180 2015-02-16  Antti Koivisto  <antti@apple.com>
181
182         Develop/Disable Caches does not properly disable disk cache
183         https://bugs.webkit.org/show_bug.cgi?id=141636
184
185         Reviewed by Anders Carlsson.
186
187         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
188         the network process too.
189
190         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
191
192         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
193         (WTR::InjectedBundle::beginTesting):
194         (WTR::InjectedBundle::setCacheModel):
195         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
196         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
197
198             Forward to TestController.
199
200         (WTR::TestRunner::setCacheModel):
201         * WebKitTestRunner/TestInvocation.cpp:
202         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
203
204 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
205
206         Unreviewed. Add myself as a committer.
207
208         * Scripts/webkitpy/common/config/contributors.json:
209
210 2015-02-15  David Kilzer  <ddkilzer@apple.com>
211
212         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
213         <http://webkit.org/b/141607>
214
215         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
216         externals in Source/WebCore/Configurations/WebCore.unexp when
217         building with Xcode 5.x.
218         (readXcode5SymbolsToIgnore): Add.
219
220 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
221
222         [EFL] fix Evas GL engine error.
223         https://bugs.webkit.org/show_bug.cgi?id=141621
224
225         Reviewed by Gyuyoung Kim.
226
227         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
228
229         * MiniBrowser/efl/main.c:
230         (elm_main):
231
232 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
233
234         [buildbot] Enable run-api-tests on release Mac bots
235         https://bugs.webkit.org/show_bug.cgi?id=141518
236
237         Reviewed by Darin Adler.
238
239         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
240         (RunUnitTests):
241         (BuildFactory.__init__):
242         (TestFactory.__init__):
243         (BuildAndTestFactory.__init__):
244         (RunUnitTests.start): Deleted.
245         (unitTestsSupported): Deleted.
246
247 2015-02-13  Anders Carlsson  <andersca@apple.com>
248
249         Add a move constructor and move assignment operator to Deque
250         https://bugs.webkit.org/show_bug.cgi?id=141571
251
252         Reviewed by Andreas Kling.
253
254         * TestWebKitAPI/Tests/WTF/Deque.cpp:
255         (TestWebKitAPI::TEST):
256
257 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
258
259         run-jsc-stress-tests --remote should skip profiler tests
260         https://bugs.webkit.org/show_bug.cgi?id=141470
261
262         Reviewed by Filip Pizlo.
263
264         * Scripts/run-jsc-stress-tests:
265
266 2015-02-13  Anders Carlsson  <andersca@apple.com>
267
268         Add an initializer list constructor to Deque
269         https://bugs.webkit.org/show_bug.cgi?id=141565
270
271         Reviewed by Andreas Kling.
272
273         * TestWebKitAPI/Tests/WTF/Deque.cpp:
274         (TestWebKitAPI::TEST):
275
276 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
277
278         [buildbot] Remove buildJSCTool cruft from master.cfg
279         https://bugs.webkit.org/show_bug.cgi?id=141513
280
281         Reviewed by Alexey Proskuryakov.
282
283         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
284         (RunJavaScriptCoreTests):
285         (RunJavaScriptCoreTests.start):
286         (RunWebKitTests):
287         (RunWebKitTests.start):
288         (TestFactory.__init__):
289         (TestLeaksFactory.__init__):
290         (RunJavaScriptCoreTests.__init__): Deleted.
291         (RunWebKitTests.__init__): Deleted.
292
293 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
294
295         Unreviewed, remove empty directories.
296
297         * DumpRenderTree/gtk: Removed.
298         * DumpRenderTree/gtk/fonts: Removed.
299         * DumpRenderTree/unix: Removed.
300         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
301         * GtkLauncher: Removed.
302         * TestWebKitAPI/Tests/WebKitGtk: Removed.
303         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
304         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
305         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
306
307 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
308
309         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
310         https://bugs.webkit.org/show_bug.cgi?id=141519
311
312         Reviewed by Alexey Proskuryakov.
313
314         * Scripts/build-webkittestrunner:
315
316 2015-02-12  Alex Christensen  <achristensen@webkit.org>
317
318         Removed empty directory.
319
320         * WinCELauncher: Removed.
321
322 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
323
324         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
325         https://bugs.webkit.org/show_bug.cgi?id=141202
326
327         Reviewed by Darin Adler.
328
329         * Scripts/run-jsc-stress-tests:
330
331 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
332
333         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
334         https://bugs.webkit.org/show_bug.cgi?id=141517
335
336         Reviewed by Anders Carlsson.
337
338         We do not need to locate or use the DLL's that came with Safari, so stop
339         failing when we cannot find them. Also remove some old Qt cruft from this
340         script.
341
342         * BuildSlaveSupport/built-product-archive:
343         (archiveBuiltProduct): 
344         (extractBuiltProduct):
345
346 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
347
348         [Win] [64-bit] Work around MSVC2013 Runtime Bug
349         https://bugs.webkit.org/show_bug.cgi?id=141498
350         <rdar://problem/19803642>
351
352         Reviewed by Anders Carlsson.
353
354         Disable FMA3 instruction use in the MSVC math library to
355         work around a VS2013 runtime crash. We can remove this
356         workaround when we switch to VS2015.
357
358         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
359         disable FMA3 support.
360         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
361         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
362         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
363         * Scripts/webkitperl/httpd.pm: Ditto.
364         * TestWebKitAPI/win/main.cpp: Ditto.
365         * WinLauncher/Common.cpp: Ditto.
366         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
367
368 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
369
370         run-jsc-stress-tests should accept remote host config from JSON file
371         https://bugs.webkit.org/show_bug.cgi?id=141509
372
373         Reviewed by Michael Saboff.
374
375         * Scripts/run-javascriptcore-tests:
376         (runJSCStressTests):
377         * Scripts/run-jsc-stress-tests:
378
379 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
380
381         [GTK] Add API to allow overriding the default color chooser implementation
382         https://bugs.webkit.org/show_bug.cgi?id=98935
383
384         Reviewed by Gustavo Noronha Silva.
385
386         Add a color chooser implementation for MiniBrowser using
387         GtkPopover when the GTK+ version is recent enough.
388         And a test case to check the new color chooser API.
389
390         * MiniBrowser/gtk/BrowserWindow.c:
391         (colorChooserRGBAChanged):
392         (popoverColorClosed):
393         (colorChooserRequestFinished):
394         (runColorChooserCallback):
395         (browserWindowConstructed):
396         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
397         (testWebViewColorChooserRequest):
398         (beforeAll):
399
400 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
401
402         Make run-jsc-stress-tests --remote work with make-based runner
403         https://bugs.webkit.org/show_bug.cgi?id=141079
404
405         Reviewed by Darin Adler.
406
407         * Scripts/run-javascriptcore-tests:
408         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
409         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
410         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
411         to avoid code duplication.
412
413 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
414
415         run-jsc-stress tests should detect the number of processors on the remote machine too
416         https://bugs.webkit.org/show_bug.cgi?id=141196
417
418         Reviewed by Darin Adler.
419
420         * Scripts/run-javascriptcore-tests:
421         (runJSCStressTests): Pass through the --child-processes argument.
422         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
423         to detect the number of local and remote processors with the same algorithm.
424         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
425         same as $numProcessors.
426
427 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
428
429         run-jsc-stress-tests should pass JSC_timeout to remote hosts
430         https://bugs.webkit.org/show_bug.cgi?id=141164
431
432         Reviewed by Darin Adler.
433
434         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
435
436         * Scripts/run-jsc-stress-tests:
437
438 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
439
440         [GTK] Add default color chooser implementation using GtkColorChooserDialog
441         https://bugs.webkit.org/show_bug.cgi?id=141392
442
443         Reviewed by Gustavo Noronha Silva.
444
445         Enable INPUT_TYPE_COLOR by default for GTK+ port.
446
447         * Scripts/webkitperl/FeatureList.pm:
448
449 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
450
451         run-jsc-stress-tests shell test runner should run tests in fixed order
452         https://bugs.webkit.org/show_bug.cgi?id=141383
453
454         Reviewed by Darin Adler.
455
456         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
457
458 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
459
460         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
461         https://bugs.webkit.org/show_bug.cgi?id=140485
462
463         Reviewed by Anders Carlsson.
464
465         Implement takeFocus() as a way to set focus through accessibility wrappers.
466
467         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
468         (AccessibilityUIElement::takeFocus):
469         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
470         (WTR::AccessibilityUIElement::takeFocus):
471
472 2015-02-08  Darin Adler  <darin@apple.com>
473
474         Remove the SVG instance tree
475         https://bugs.webkit.org/show_bug.cgi?id=140602
476
477         Reviewed by Dean Jackson.
478
479         * Scripts/check-for-global-initializers: Removed special case for
480         SVGElementInstance.o.
481
482 2015-02-07  David Kilzer  <ddkilzer@apple.com>
483
484         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
485         <http://webkit.org/b/141365>
486
487         Reviewed by Daniel Bates.
488
489         * Scripts/webkitpy/xcode/simulator.py:
490         (Simulator): Add unavailable_version_re precompiled regex.
491         (Simulator._parse_devices): Check for unavailable versions and
492         ignore them if found when parsing the output of
493         `xcrun simctl list`.
494         * Scripts/webkitpy/xcode/simulator_unittest.py:
495         (test_unavailable_devices): Add test with output from
496         `xcrun simctl list` with unavailable runtimes that fails before
497         the fix.
498
499 2015-02-07  Chris Dumez  <cdumez@apple.com>
500
501         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
502         https://bugs.webkit.org/show_bug.cgi?id=141321
503
504         Reviewed by Darin Adler.
505
506         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
507
508 2015-02-07  David Kilzer  <ddkilzer@apple.com>
509
510         [iOS] Make Simulator class testable
511         <http://webkit.org/b/141358>
512
513         Rubber-stamped by Darin Adler.
514
515         * Scripts/webkitpy/common/system/platforminfo.py:
516         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
517         command to here from Simulator.refresh() in xcode/simulator.py
518         so that the output of the command can be mocked.
519
520         * Scripts/webkitpy/common/system/platforminfo_mock.py:
521         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
522         to None.
523         (MockPlatformInfo.xcode_simctl_list): Add method that returns
524         self.expected_xcode_simctl_list expectation.
525
526         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
527         and license header.
528         (Simulator.__init__): Add optional 'host' parameter to make it
529         possible to pass in a mock object for testing.  Set self._host
530         to 'host' parameter or create Host() object.
531         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
532         method.
533
534         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
535         for current code.
536         (SimulatorTest):
537         (SimulatorTest.setUp):
538         (SimulatorTest._set_expected_xcrun_simctl_list):
539         (SimulatorTest.test_simulator_device_types):
540         (test_invalid_device_types_header):
541         (test_invalid_runtimes_header):
542         (test_invalid_devices_header):
543
544 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
545
546         run-jsc-stress-tests --remote should use the default ssh port
547         https://bugs.webkit.org/show_bug.cgi?id=141287
548
549         Reviewed by Darin Adler.
550
551         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
552
553 2015-02-06  Dana Burkart  <dburkart@apple.com>
554
555         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
556         https://bugs.webkit.org/show_bug.cgi?id=141349
557
558         Reviewed by Alexey Proskuryakov.
559
560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
561         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
562         (BuildbotTesterQueueView.prototype.update):
563
564 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
565
566         Report network process crashes during layout tests
567         https://bugs.webkit.org/show_bug.cgi?id=139646
568
569         Reviewed by Anders Carlsson.
570
571         * WebKitTestRunner/TestController.cpp:
572         (WTR::TestController::initialize):
573         (WTR::TestController::networkProcessName):
574         (WTR::TestController::networkProcessDidCrash):
575         * WebKitTestRunner/TestController.h:
576
577 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
578
579         run-jsc-stress-tests --remote should create remote directory before copying the bundle
580         https://bugs.webkit.org/show_bug.cgi?id=141329
581
582         Reviewed by Michael Saboff.
583
584         * Scripts/run-jsc-stress-tests:
585
586 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
587
588         [GTK] Remove WebKitWebView::close-notification signal
589         https://bugs.webkit.org/show_bug.cgi?id=141330
590
591         Reviewed by Gustavo Noronha Silva.
592
593         Update notifications unit tests according to the API changes, and
594         add a test case to check that onclose event is fired when a
595         notification is closed by the user.
596
597         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
598         (testWebViewNotification):
599
600 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
601
602         Dashboard doesn't consider building ASan a productive step
603         https://bugs.webkit.org/show_bug.cgi?id=141312
604
605         Reviewed by Simon Fraser.
606
607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
608
609 2015-02-05  Daniel Bates  <dabates@apple.com>
610
611         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
612         https://bugs.webkit.org/show_bug.cgi?id=141306
613
614         Reviewed by Alexey Proskuryakov.
615
616         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
617         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
618         existent runtime.
619
620         * Scripts/webkitpy/xcode/simulator.py:
621         (Runtime.from_identifier):
622
623 2015-02-05  Daniel Bates  <dabates@apple.com>
624
625         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
626         https://bugs.webkit.org/show_bug.cgi?id=139746
627         <rdar://problem/19283658>
628
629         Reviewed by Alexey Proskuryakov.
630
631         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
632         if the simulator device is not in state Booted.
633
634         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
635         launching/relaunching the iOS Simulator app and a simulator app can only be installed
636         on a device that is in the Booted state. LayoutTestRelay may run before the
637         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
638         We should defer executing LayoutTestRelay until the simulator device booted by
639         iOS Simulator is in the Booted state.
640
641         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
642         Simulator methods with the module name, simulator.
643         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
644         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
645         before launching iOS Simulator to boot it.
646         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
647         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
648         * Scripts/webkitpy/xcode/simulator.py:
649         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
650         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
651         interested in the state of the device are more likely interested in the current state of the device as
652         opposed to the state of the device when the Device object was created.
653         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
654         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
655         from both this function and Simulator.device_state().
656         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
657         (Simulator.DeviceState): Added; class of constants.
658         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
659         device is in the specified state.
660         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
661         (Simulator.device_directory): Added.
662         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
663
664 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
665
666         Disable retries on Mac debug testers
667         https://bugs.webkit.org/show_bug.cgi?id=141296
668
669         Reviewed by Simon Fraser.
670
671         * BuildSlaveSupport/build.webkit.org-config/config.json:
672
673 2015-02-05  Dan Bernstein  <mitz@apple.com>
674
675         Need a way to force $xcodeSDK in webkitdirs.pm
676         https://bugs.webkit.org/show_bug.cgi?id=141291
677
678         Reviewed by Anders Carlsson.
679
680         * Scripts/webkitdirs.pm:
681         (setXcodeSDK): Added.
682
683 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
684
685         [Streams API] Implement a barebone ReadableStream interface
686         https://bugs.webkit.org/show_bug.cgi?id=141045
687
688         Reviewed by Benjamin Poulain.
689
690         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
691
692 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
693
694         filter-build-webkit: reduce more unfiltered output
695         https://bugs.webkit.org/show_bug.cgi?id=141282
696
697         Reviewed by Daniel Bates.
698
699         * Scripts/filter-build-webkit:
700         Report CompileDTraceScript and Preprocess lines as successful.
701
702 2015-02-04  Dana Burkart  <dburkart@apple.com>
703
704         Botwatcher's Dashboard is cramped
705         https://bugs.webkit.org/show_bug.cgi?id=140273
706
707         Reviewed by Alexey Proskuryakov.
708
709         Add a heading key which will allow for arbitrary headings in builder queues.
710
711         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
712         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
713         (BuildbotBuilderQueueView.prototype.update):
714         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
715         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
716         (BuildbotIteration.prototype._parseData):
717         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
718         (BuildbotLeaksQueueView.prototype.update):
719         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
720         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
721         (BuildbotPerformanceQueueView.prototype.update):
722         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
723         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
724         (BuildbotQueue):
725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
726         (BuildbotQueueView.prototype._unauthorizedAccess):
727         (BuildbotQueueView.prototype._appendBuild):
728         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
729         (BuildbotTestResults):
730         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
731         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
732         (BuildbotTesterQueueView.prototype.update):
733         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
734
735 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
736
737         WKTR should not use -mainScreen to pick a color profile
738         https://bugs.webkit.org/show_bug.cgi?id=141265
739
740         Reviewed by Tim Horton.
741         
742         -[NSScreen mainScreen] depends on the active window, so use the first screen
743         (which is the one we put the window on anyway).
744         
745         Do some cleanup in DRT that makes the code look similar.
746
747         * DumpRenderTree/mac/DumpRenderTree.mm:
748         (createWebViewAndOffscreenWindow):
749         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
750         (WTR::PlatformWebView::PlatformWebView):
751
752 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
753
754         LayoutTestHelper should set the color profile of all displays
755         https://bugs.webkit.org/show_bug.cgi?id=141260
756
757         Reviewed by Tim Horton.
758         
759         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
760         which is the screen with the active window. Make things more robust by changing
761         the colorspace of all displays, not just the main screen, when running layout tests.
762
763         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
764         * DumpRenderTree/mac/LayoutTestHelper.m: 
765         (originalColorProfileURLs):
766         (colorProfileURLForDisplay):
767         (displayUUIDStrings):
768         (saveDisplayColorProfiles):
769         (setDisplayColorProfile):
770         (restoreDisplayColorProfiles):
771         (installLayoutTestColorProfile):
772         (restoreUserColorProfile):
773         (main):        
774         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
775         toll-free bridged, sadly). Use the map to restore all profiles on exit.
776         Convert to use more Obj-C types.
777
778 2015-02-04  Daniel Bates  <dabates@apple.com>
779
780         test-webkitpy fails on Mac without iphoneos SDK
781         https://bugs.webkit.org/show_bug.cgi?id=141255
782         <rdar://problem/19619691>
783
784         I inadvertently committed the wrong exception message. Fix up the exception message
785         to instruct a person to install the iOS SDK when it cannot be found.
786
787         * Scripts/webkitpy/port/ios.py:
788         (IOSPort.determine_full_port_name):
789
790 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
791
792         W3C test importer should sort the list of files when generating the w3c-import.log
793         https://bugs.webkit.org/show_bug.cgi?id=141156
794
795         Reviewed by Bem Jones-Bey.
796
797         Sort explicitly the list of imported files written in the w3c-import.log.
798         Removed logging of the import date.
799
800         * Scripts/webkitpy/w3c/test_importer.py:
801         (TestImporter.write_import_log):
802
803 2015-02-04  Daniel Bates  <dabates@apple.com>
804
805         test-webkitpy fails on Mac without iphoneos SDK
806         https://bugs.webkit.org/show_bug.cgi?id=141255
807         <rdar://problem/19619691>
808
809         Reviewed by David Kilzer and Alexey Proskuryakov.
810
811         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
812         should not require the iphoneos SDK to be installed to run the webkitpy tests.
813
814         * Scripts/webkitpy/common/system/platforminfo.py:
815         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
816         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
817         to standard output if the SDK is installed to return the empty string if the SDK is
818         not installed.
819         * Scripts/webkitpy/common/system/platforminfo_mock.py:
820         (MockPlatformInfo.xcode_sdk_version): Added.
821         * Scripts/webkitpy/port/ios.py:
822         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
823         to get the version of the iphoneos SDK, if installed.
824
825 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
826
827         run-webkit-tests doesn't always capture ASan violation reports
828         https://bugs.webkit.org/show_bug.cgi?id=141231
829
830         Reviewed by Darin Adler.
831
832         * Scripts/webkitpy/port/driver.py:
833         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
834         by the driver already (as is the case with ASan violations, which are printed to
835         stderr).
836         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
837         report.
838         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
839         a separate variable for reporting.
840
841 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
842
843         [webkitpy] Add platform specific Skipped file mechanism for performance tests
844         https://bugs.webkit.org/show_bug.cgi?id=141152
845
846         Reviewed by Csaba Osztrogonác.
847
848         Support a test-expectation-like syntax in performance tests' skipped files.
849         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
850
851         * Scripts/webkitpy/port/base.py:
852         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
853
854         * Scripts/webkitpy/port/base_unittest.py:
855         (PortTest.test_skipped_perf_tests): Test the new syntax.
856
857 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
858
859         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
860         https://bugs.webkit.org/show_bug.cgi?id=141236
861
862         Reviewed by Sam Weinig.
863
864         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
865         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
866
867 2015-02-04  Chris Dumez  <cdumez@apple.com>
868
869         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
870         https://bugs.webkit.org/show_bug.cgi?id=141192
871
872         Reviewed by Benjamin Poulain.
873
874         Add API tests for Vector::removeFirst(value) and
875         Vector::removeAll(value).
876
877         * TestWebKitAPI/Tests/WTF/Vector.cpp:
878         (TestWebKitAPI::TEST):
879
880 2015-02-03  Tim Horton  <timothy_horton@apple.com>
881
882         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
883         https://bugs.webkit.org/show_bug.cgi?id=141217
884
885         Reviewed by Sam Weinig.
886
887         * WebKitTestRunner/TestController.cpp:
888         (WTR::copyWebCryptoMasterKey):
889         (WTR::TestController::createOtherPage):
890         (WTR::TestController::createWebViewWithOptions):
891         (WTR::TestController::ensureViewSupportsOptions):
892         (WTR::TestController::didCommitNavigation):
893         (WTR::TestController::didFinishNavigation):
894         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
895         (WTR::TestController::didReceiveAuthenticationChallenge):
896         (WTR::TestController::decidePolicyForPluginLoad):
897         (WTR::TestController::decidePolicyForNavigationAction):
898         (WTR::TestController::decidePolicyForNavigationResponse):
899         (WTR::TestController::didCommitLoadForFrame): Deleted.
900         (WTR::TestController::didFinishLoadForFrame): Deleted.
901         * WebKitTestRunner/TestController.h:
902         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
903
904 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
905
906         Unreviewed. Add myself as a committer.
907
908         * Scripts/webkitpy/common/config/contributors.json:
909
910 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
911
912         [Win] Unreviewed test fix.
913
914         * DumpRenderTree/win/PolicyDelegate.cpp:
915         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
916         so was not matching expected output.
917
918 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
919
920         Unreviewed. Moving myself to the committer section at last.
921
922         * Scripts/webkitpy/common/config/contributors.json:
923
924 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
925
926         [Win] Tests fail because DRT reports '(null)' instead of an empty string
927         https://bugs.webkit.org/show_bug.cgi?id=141205
928
929         Reviewed by Anders Carlsson.
930
931         * DumpRenderTree/win/HistoryDelegate.cpp:
932         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
933         properly so that we match expected DumpRenderTree output.
934
935 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
936
937         [GTK] TestWebKitAccessibility is not skipped
938         https://bugs.webkit.org/show_bug.cgi?id=141179
939
940         Reviewed by Carlos Garcia Campos.
941
942         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
943         skipped, and it apparently works reliably on the bots.
944
945         * Scripts/run-gtk-tests:
946         (TestRunner):
947
948 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
949
950         run-perf-tests: allow to specify a wrapper command.
951         https://bugs.webkit.org/show_bug.cgi?id=141172
952
953         Reviewed by Ryosuke Niwa.
954
955         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
956         (parse_args): Update text to indicate is also valid for WTR.
957         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
958         (PerfTestsRunner._parse_args): Add wrapper command.
959
960 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
961
962         [Win] Correct version parsing warning in update-webkit
963         https://bugs.webkit.org/show_bug.cgi?id=141200
964
965         Reviewed by Anders Carlsson.
966
967         * Scripts/webkitdirs.pm:
968         (setupAppleWinEnv): Strip out any specific version build level
969         from the Cygwin version information.
970   
971
972 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
973
974         [Win] Attempt to improve the reliability of HTTP service
975         https://bugs.webkit.org/show_bug.cgi?id=141191
976
977         Reviewed by Darin Adler.
978
979         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
980         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
981         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
982         when stopping the service doesn't do so on its own (for Windows runs).
983
984 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
985
986         Web platform test server should not need to create __init__.py files
987         https://bugs.webkit.org/show_bug.cgi?id=141030
988
989         Reviewed by Ryosuke Niwa.
990
991         W3C TestImporter ensures that copied __init__.py files are not empty.
992         If needed, a comment is inserted in __init__.py files.
993         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
994
995         * Scripts/webkitpy/common/system/filesystem.py:
996         (FileSystem.getsize):
997         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
998         (TestWebPlatformTestServer.test_start_cmd):
999         (TestWebPlatformTestServer):
1000         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
1001         * Scripts/webkitpy/w3c/test_importer.py:
1002         (TestImporter.import_tests):
1003
1004 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1005
1006         Unreviewed. Moving myself to the committer section.
1007
1008         * Scripts/webkitpy/common/config/contributors.json:
1009
1010 2015-02-02  Saam Barati  <saambarati1@gmail.com>
1011
1012         Create tests for JSC's Control Flow Profiler
1013         https://bugs.webkit.org/show_bug.cgi?id=141123
1014
1015         Reviewed by Filip Pizlo.
1016
1017         * Scripts/run-javascriptcore-tests:
1018         (runJSCStressTests):
1019         * Scripts/run-jsc-stress-tests:
1020
1021 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
1022
1023         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
1024         https://bugs.webkit.org/show_bug.cgi?id=141158
1025
1026         Reviewed by Darin Adler.
1027
1028         * Scripts/run-jsc-stress-tests:
1029
1030 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1031
1032         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
1033         https://bugs.webkit.org/show_bug.cgi?id=141142
1034
1035         Reviewed by Carlos Garcia Campos.
1036
1037         * MiniBrowser/gtk/BrowserWindow.c:
1038         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
1039
1040 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1041
1042         Web platform test server is not always launching properly on Mac EWS bots
1043         https://bugs.webkit.org/show_bug.cgi?id=141141
1044
1045         Unreviewed.
1046
1047         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1048         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
1049
1050 2015-01-31  Sam Weinig  <sam@webkit.org>
1051
1052         Remove even more Mountain Lion support
1053         https://bugs.webkit.org/show_bug.cgi?id=141124
1054
1055         Reviewed by Alexey Proskuryakov.
1056
1057         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1058         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1059         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1060         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1061         * DumpRenderTree/mac/DumpRenderTree.mm:
1062         (activateTestingFonts):
1063         (prepareConsistentTestingEnvironment):
1064         * DumpRenderTree/mac/EventSendingController.mm:
1065         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1066         (-[EventSendingController contextClick]):
1067         * DumpRenderTree/mac/TextInputController.m:
1068         * LayoutTestRelay/Configurations/Base.xcconfig:
1069         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1070         * MiniBrowser/Configurations/Base.xcconfig:
1071         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1072         * MiniBrowser/mac/WK2BrowserWindowController.m:
1073         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1074         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1075         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
1076         * TestWebKitAPI/Configurations/Base.xcconfig:
1077         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1078         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1079         (-[DownloadDelegate _downloadDidFinish:]):
1080         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1081         (TestWebKitAPI::TEST):
1082         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1083         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1084         * WebKitLauncher/Configurations/Base.xcconfig:
1085         * WebKitTestRunner/Configurations/Base.xcconfig:
1086         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1087         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1088         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1089         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1090         (WTR::activateFonts):
1091         * WebKitTestRunner/TestController.cpp:
1092         (WTR::TestController::initialize):
1093         (WTR::TestController::webProcessName):
1094         * WebKitTestRunner/mac/EventSenderProxy.mm:
1095         * asan/asan.xcconfig:
1096
1097 2015-01-31  Commit Queue  <commit-queue@webkit.org>
1098
1099         Unreviewed, rolling out r179408.
1100         https://bugs.webkit.org/show_bug.cgi?id=141117
1101
1102         This didn't fully fix the issue (Requested by anttik on
1103         #webkit).
1104
1105         Reverted changeset:
1106
1107         "OSObjectPtr does not work with dispatch_data_t on Maverics"
1108         https://bugs.webkit.org/show_bug.cgi?id=141081
1109         http://trac.webkit.org/changeset/179408
1110
1111 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1112
1113         https://trac.webkit.org/changeset/179439 breaks a python test
1114         https://bugs.webkit.org/show_bug.cgi?id=141114
1115
1116         Unreviewed.
1117
1118         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1119         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
1120
1121 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1122
1123         Import W3C web platform tests infrastructure
1124         https://bugs.webkit.org/show_bug.cgi?id=140934
1125
1126         Reviewed by Ryosuke Niwa.
1127
1128         Loading necessary web platform tests modules before launching server.
1129         Ensuring that some empty __init__.py files are present and create them if necessary. 
1130
1131         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1132         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1133
1134 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1135
1136         [Win] Another unreviewed test fix.
1137
1138         Correct copy/paste error in buildbot handling.
1139
1140         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1141         (LayoutTestApacheHttpd.__init__):
1142         (LayoutTestApacheHttpd._get_apache_config_file_path):
1143
1144 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1145
1146         [Win] Unreviewed test fix.
1147
1148         Correct path handling based on failures on test bots to get things running again.
1149
1150         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1151         (LayoutTestApacheHttpd.__init__):
1152         (LayoutTestApacheHttpd._get_apache_config_file_path):
1153
1154 2015-01-30  Chris Dumez  <cdumez@apple.com>
1155
1156         Unreviewed. Fix Windows build after r179409.
1157
1158         * DumpRenderTree/win/TestRunnerWin.cpp:
1159         (TestRunner::notifyDone):
1160         (TestRunner::queueLoad):
1161
1162 2015-01-30  Chris Dumez  <cdumez@apple.com>
1163
1164         Rename shared() static member functions to singleton() for singleton classes.
1165         https://bugs.webkit.org/show_bug.cgi?id=141088
1166
1167         Reviewed by Ryosuke Niwa and Benjamin Poulain.
1168
1169         Rename shared() static member functions to singleton() for singleton
1170         classes as per the recent coding style change.
1171
1172 2015-01-30  Antti Koivisto  <antti@apple.com>
1173
1174         OSObjectPtr does not work with dispatch_data_t on Maverics
1175         https://bugs.webkit.org/show_bug.cgi?id=141081
1176
1177         Reviewed by Pratik Solanki.
1178
1179         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
1180         (TestWebKitAPI::TEST):
1181
1182 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1183
1184         [Win] Switch to Apache on Windows
1185         https://bugs.webkit.org/show_bug.cgi?id=141060
1186
1187         Reviewed by Alexey Proskuryakov.
1188
1189         Update our scripts under Windows (and Cygwin) to locate and use
1190         the XAMPP installation of Apache for running tests.
1191
1192         * Scripts/run-webkit-httpd:
1193         * Scripts/webkitperl/httpd.pm:
1194         (getHTTPDPath):
1195         (getDefaultConfigForTestDirectory):
1196         (getHTTPDConfigPathForTestDirectory):
1197         * Scripts/webkitpy/common/system/executive_unittest.py:
1198         (ExecutiveTest.serial_test_kill_process):
1199         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1200         (LayoutTestApacheHttpd.__init__):
1201         (LayoutTestApacheHttpd._get_apache_config_file_path):
1202         (LayoutTestApacheHttpd._stop_running_server):
1203         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1204         (HttpServerBase._is_server_running_on_all_ports):
1205         * Scripts/webkitpy/port/base.py:
1206         (Port._apache_config_file_name_for_platform):
1207         * Scripts/webkitpy/port/port_testcase.py:
1208         (test_apache_config_file_name_for_platform):
1209         * Scripts/webkitpy/port/win.py:
1210         (WinPort.show_results_html_file):
1211         (WinPort._uses_apache):
1212         (WinPort):
1213         (WinPort._path_to_apache):
1214
1215 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
1216
1217         Built result takes too long to be compressed on bots
1218         https://bugs.webkit.org/show_bug.cgi?id=141056
1219
1220         Reviewed by Daniel Bates.
1221
1222         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
1223
1224         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
1225
1226 2015-01-29  Sam Weinig  <sam@webkit.org>
1227
1228         Remove support for screen font substitution
1229         https://bugs.webkit.org/show_bug.cgi?id=141038
1230
1231         Reviewed by Tim Horton.
1232
1233         * DumpRenderTree/win/DumpRenderTree.cpp:
1234         (resetWebPreferencesToConsistentValues):
1235         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
1236
1237 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1238
1239         Make run-jsc-stress-tests --remote work on Linux too
1240         https://bugs.webkit.org/show_bug.cgi?id=141000
1241
1242         Reviewed by Darin Adler.
1243
1244         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
1245         use bash/dash compatible signal names, use Linux/Mac compatible find options,
1246         use bash/dash compatible functions.
1247         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
1248
1249 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1250
1251         [buildbot] Simplify jscore-test buildstep
1252         https://bugs.webkit.org/show_bug.cgi?id=140821
1253
1254         Reviewed by Alexey Proskuryakov.
1255
1256         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1257         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
1258         (RunJavaScriptCoreTests.countFailures): Added.
1259         (RunJavaScriptCoreTests.commandComplete): Deleted.
1260         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
1261         (RunJavaScriptCoreTests.getText): Deleted.
1262         (RunJavaScriptCoreTests.getText2): Deleted.
1263         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
1264         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
1265         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
1266         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
1267         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
1268
1269 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1270
1271         Unreviewed, revert r179337, we don't need this dependency.
1272
1273         * efl/install-dependencies:
1274         * gtk/install-dependencies:
1275
1276 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
1277
1278         Unreviewed. Moving myself to the committer section.
1279
1280         * Scripts/webkitpy/common/config/contributors.json:
1281
1282 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
1283
1284         URTBF after r179326, added uuid-dev package as new dependency.
1285
1286         * efl/install-dependencies:
1287         * gtk/install-dependencies:
1288
1289 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
1290
1291         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
1292         https://bugs.webkit.org/show_bug.cgi?id=140673
1293
1294         Reviewed by Sam Weinig.
1295
1296         * Scripts/dtrace/trace-webkit2-messages.d: Added.
1297         Add a DTrace script that outputs a small blob of JSON per message.
1298
1299 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
1300
1301         Removed fastMallocForbid / fastMallocAllow
1302         https://bugs.webkit.org/show_bug.cgi?id=141012
1303
1304         Reviewed by Mark Hahnenberg.
1305
1306         Fixed a test bug I noticed while testing.
1307
1308         * DumpRenderTree/JavaScriptThreading.cpp:
1309         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
1310         accessing javaScriptThreads -- otherwise, you'll ASSERT.
1311
1312 2015-01-28  Dana Burkart  <dburkart@apple.com>
1313
1314         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
1315         https://bugs.webkit.org/show_bug.cgi?id=141015
1316
1317         Reviewed by Alexey Proskuryakov.
1318
1319         * asan/asan.xcconfig:
1320
1321 2015-01-28  Sam Weinig  <sam@webkit.org>
1322
1323         Fix the build.
1324
1325         * Scripts/copy-webkitlibraries-to-product-directory:
1326
1327 2015-01-28  Lucas Forschler  <lforschler@apple.com>
1328
1329         Increase the FileUpload block size in an attempt to improve network performance.
1330         
1331         Reviewed by Alexey Proskuryakov.
1332         
1333         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1334         (UploadBuiltProduct.__init__):
1335
1336 2015-01-28  Dana Burkart  <dburkart@apple.com>
1337
1338         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1339         https://bugs.webkit.org/show_bug.cgi?id=136765
1340
1341         Reviewed by Alexey Proskuryakov.
1342
1343         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1344         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1345         * LayoutTestRelay/Configurations/Base.xcconfig:
1346         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1347         * MiniBrowser/Configurations/Base.xcconfig:
1348         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1349         * TestWebKitAPI/Configurations/Base.xcconfig:
1350         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1351         * WebKitLauncher/Configurations/Base.xcconfig:
1352         * WebKitTestRunner/Configurations/Base.xcconfig:
1353         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1354
1355 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
1356
1357         AX: [ATK] Implement support for new AtkRole types for MathML
1358         https://bugs.webkit.org/show_bug.cgi?id=140916
1359
1360         Reviewed by Chris Fleizach.
1361
1362         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
1363         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
1364
1365 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1366
1367         [GTK] Stop removing color marks from unit tests output
1368         https://bugs.webkit.org/show_bug.cgi?id=140996
1369
1370         Reviewed by Philippe Normand.
1371
1372         Since r178236 google tests use a custom simplified output without
1373         any colors, so we don't need to handle the case of non ttys to
1374         remove the color marks.
1375
1376         * Scripts/run-gtk-tests:
1377         (TestRunner.__init__):
1378         (TestRunner._run_test_command.parse_line):
1379
1380 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1381
1382         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
1383         https://bugs.webkit.org/show_bug.cgi?id=131731
1384
1385         Reviewed by Žan Doberšek.
1386
1387         A web page loaded offscreen is in prerender state not hidden.
1388
1389         * Scripts/run-gtk-tests:
1390         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
1391         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1392         (testWebViewPageVisibility):
1393
1394 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1395
1396         Partially revert r178802.
1397
1398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
1399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
1400
1401 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1402
1403         build.webkit.org/dashboard asserts on some commits
1404         https://bugs.webkit.org/show_bug.cgi?id=140926
1405
1406         Reviewed by Tim Horton.
1407
1408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1409         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
1410
1411 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1412
1413         Make flakiness dashboard OS list actually match test_expectations.py
1414         https://bugs.webkit.org/show_bug.cgi?id=140969
1415
1416         Reviewed by Ryosuke Niwa.
1417
1418         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1419
1420 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
1421
1422         [Win] WinLauncher crashes on eleventh site visited
1423         https://bugs.webkit.org/show_bug.cgi?id=140960
1424
1425         Reviewed by Anders Carlsson.
1426
1427         * WinLauncher/WinLauncher.cpp:
1428         (WinLauncher::showLastVisitedSites): Don't access off the end of
1429         the history array.
1430
1431 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1432
1433         [Mac] Disable building Java applets by default
1434         https://bugs.webkit.org/show_bug.cgi?id=140957
1435         rdar://problem/19619529
1436
1437         Reviewed by Anders Carlsson.
1438
1439         It was actually already disabled unconditionally, by accident.
1440
1441         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
1442         * Scripts/webkitpy/port/mac.py:
1443         (MacPort._check_port_build):
1444         (MacPort._build_java_test_support):
1445
1446 2015-01-27  Daniel Bates  <dabates@apple.com>
1447
1448         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
1449         https://bugs.webkit.org/show_bug.cgi?id=140949
1450
1451         Reviewed by Alexey Proskuryakov.
1452
1453         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
1454         builders so that run-webkit-tests can lint the appropriate TestExpectation
1455         files.
1456
1457         * Scripts/webkitpy/port/builders.py:
1458         * Scripts/webkitpy/port/ios.py:
1459         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
1460         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
1461         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
1462         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
1463         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
1464         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
1465         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
1466
1467
1468 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1469
1470         Update bots on the flakiness dashboard
1471         https://bugs.webkit.org/show_bug.cgi?id=140956
1472
1473         Reviewed by Ryosuke Niwa.
1474
1475         * TestResultServer/static-dashboards/builders.jsonp:
1476         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1477
1478 2015-01-27  Daniel Bates  <dabates@apple.com>
1479
1480         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
1481         https://bugs.webkit.org/show_bug.cgi?id=140942
1482
1483         Reviewed by Alexey Proskuryakov.
1484
1485         The directory LayoutTests/platform/wk2 contains test expectations and test results that
1486         are applicable to all WebKit2 ports. We should make use of this information when
1487         running layout tests using iOS WebKit2.
1488
1489         Additionally, make use of the convenience function Port._wk2_port_name() for the name
1490         of the WebKit2 port instead of directly using string concatenation.
1491
1492         * Scripts/webkitpy/port/ios.py:
1493         (IOSSimulatorPort.default_baseline_search_path):
1494
1495 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
1496
1497         [Win] Disable FTL stress tests
1498         https://bugs.webkit.org/show_bug.cgi?id=140932
1499
1500         Reviewed by Brent Fulgham.
1501
1502         * Scripts/run-javascriptcore-tests:
1503
1504 2015-01-27  Daniel Bates  <dabates@apple.com>
1505
1506         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
1507         https://bugs.webkit.org/show_bug.cgi?id=140939
1508
1509         Reviewed by Eric Carlson.
1510
1511         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
1512
1513         * Scripts/webkitdirs.pm:
1514         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
1515         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
1516         and define a function called wanted.
1517
1518 2015-01-27  Daniel Bates  <dabates@apple.com>
1519
1520         Teach run-webkit-app --simulator how to install custom built app
1521         https://bugs.webkit.org/show_bug.cgi?id=140691
1522
1523         Fix inadvertent omission of directory test flag in expression to check for the
1524         existence of the iOS simulator device-specific directory for user installed apps.
1525
1526         * Scripts/webkitdirs.pm:
1527         (hasUserInstalledAppInSimulatorDevice):
1528
1529 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
1530
1531         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
1532         https://bugs.webkit.org/show_bug.cgi?id=87426
1533         <rdar://problem/11527899>
1534
1535         Reviewed by Darin Adler.
1536
1537         Revise COMPtr to work better with our HashMap implementation. Use
1538         modern loop syntax.
1539
1540         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1541         (AccessibilityController::~AccessibilityController):
1542         (AccessibilityController::winNotificationReceived):
1543         * DumpRenderTree/win/DumpRenderTree.cpp:
1544         (dumpBackForwardListForAllWindows):
1545
1546 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1547
1548         [Win] Enable JSC stress tests by default
1549         https://bugs.webkit.org/show_bug.cgi?id=128307
1550
1551         Reviewed by Brent Fulgham.
1552
1553         * Scripts/run-javascriptcore-tests:
1554
1555 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1556
1557         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
1558         arguments for build and test scripts
1559         https://bugs.webkit.org/show_bug.cgi?id=139748
1560
1561         Reviewed by Daniel Bates.
1562
1563         There was much confusion resulting from the multitude of aliases used to build/test for
1564         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
1565         tests directory.
1566
1567         This fixes an issue where run-api-tests and some other scripts failed when run with
1568         --simulator.
1569
1570         * Scripts/build-webkit:
1571         * Scripts/package-root:
1572         (usage):
1573         * Scripts/webkitdirs.pm:
1574         (argumentsForConfiguration):
1575         (determineXcodeSDK):
1576         * Scripts/webkitpy/port/factory.py:
1577         (platform_options):
1578
1579 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1580
1581         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
1582         https://bugs.webkit.org/show_bug.cgi?id=140203
1583         rdar://problem/19198492
1584
1585         Reviewed by Sam Weinig.
1586
1587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1588         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
1589         (TEST):
1590
1591 2015-01-26  David Kilzer  <ddkilzer@apple.com>
1592
1593         Add iOS EWS to build.webkit.org/dashboard
1594         <http://webkit.org/b/140627>
1595
1596         Reviewed by Alexey Proskuryakov.
1597
1598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
1599         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
1600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1601         (BubbleQueueServer): Add ios-ews queue info.
1602         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1603         Add iOS8Device platform.
1604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1605         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
1606         iOS device logo.
1607
1608 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
1609
1610         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
1611         https://bugs.webkit.org/show_bug.cgi?id=140896
1612
1613         Reviewed by Michael Saboff.
1614         
1615         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
1616         makes our script do this.
1617         
1618         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
1619         this would be harder given llvm's autoconf setup.
1620
1621         * Scripts/copy-webkitlibraries-to-product-directory:
1622
1623 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1624
1625         Update bot assignments.
1626
1627         * BuildSlaveSupport/build.webkit.org-config/config.json:
1628
1629 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1630
1631         Integrate WP python server into WebKit test framework
1632         https://bugs.webkit.org/show_bug.cgi?id=127094
1633
1634         Reviewed by Ryosuke Niwa.
1635
1636         This patch adds W3C web server (wptserver) as a new HTTP server.
1637         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
1638         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
1639
1640         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
1641         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
1642         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
1643
1644         * Scripts/webkitpy/common/system/executive_mock.py:
1645         (MockProcess.communicate):
1646         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
1647         (LayoutTestRunner.__init__):
1648         (LayoutTestRunner.run_tests):
1649         (LayoutTestRunner.start_servers):
1650         (LayoutTestRunner.stop_servers):
1651         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
1652         (LayoutTestRunnerTests._run_tests):
1653         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
1654         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
1655         (LayoutTestRunnerTests):
1656         (LayoutTestRunnerTests.test_servers_started):
1657         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
1658         (Manager.__init__):
1659         (Manager._is_http_test):
1660         (Manager._is_web_platform_test):
1661         (Manager._run_tests):
1662         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1663         (ManagerTest.test_needs_servers.get_wpt_doc_root):
1664         (ManagerTest.test_needs_servers.get_manager):
1665         (ManagerTest.test_needs_servers):
1666         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
1667         (parse_args):
1668         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
1669         (main):
1670         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
1671         (doc_root):
1672         (base_url):
1673         (WebPlatformTestServer):
1674         (WebPlatformTestServer.__init__):
1675         (WebPlatformTestServer._set_start_cmd):
1676         (WebPlatformTestServer._copy_webkit_test_files):
1677         (WebPlatformTestServer._clean_webkit_test_files):
1678         (WebPlatformTestServer._prepare_config):
1679         (WebPlatformTestServer._spawn_process):
1680         (WebPlatformTestServer._stop_running_server):
1681         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
1682         (TestWebPlatformTestServer):
1683         (TestWebPlatformTestServer.test_start_cmd):
1684         * Scripts/webkitpy/port/base.py:
1685         (Port.__init__):
1686         (Port.to.start_web_platform_test_server):
1687         (Port.to):
1688         (Port.to.web_platform_test_server_doc_root):
1689         (Port.to.web_platform_test_server_base_url):
1690         (Port.to.stop_web_platform_test_server):
1691         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
1692         (Driver.__init__):
1693         (Driver.is_web_platform_test):
1694         (Driver.test_to_uri):
1695         (Driver.uri_to_test):
1696         (Driver._command_from_driver_input):
1697         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
1698         (DriverTest.test_test_to_uri):
1699         (DriverTest.test_uri_to_test):
1700
1701 2015-01-26  Daniel Bates  <dabates@apple.com>
1702
1703         Teach run-webkit-app --simulator how to install custom built app
1704         https://bugs.webkit.org/show_bug.cgi?id=140691
1705
1706         Reviewed by David Kilzer.
1707
1708         We should teach run-webkit-app --simulator how to install a custom built app.
1709
1710         Currently run-webkit-app --simulator can only run a system app or an app that
1711         was installed using the simctl command line tool. For convenience we should
1712         teach run-webkit-app --simulator how to install a custom built app.
1713
1714         As a side effect of this change run-safari --simulator will install and run
1715         a custom built of MobileSafari (if it exists).
1716
1717         * Scripts/webkitdirs.pm:
1718         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
1719         Perl from the structure of the device.plist file.
1720         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
1721         file system check to determine the plist path for a Mac app bundle.
1722         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
1723         it will complain that it cannot find the file: "Domain ... does not exist".
1724         (appDisplayNameFromBundle): Ditto.
1725         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
1726         until a simulator device is the specified state.
1727         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
1728         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
1729         the specified device.
1730         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
1731         As implied by its name, this function will not return until the specified simulator
1732         device UDID is in the shutdown state.
1733         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
1734         device with the specified UDID.
1735         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
1736         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
1737         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
1738         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
1739         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
1740         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
1741         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
1742         (hasUserInstalledAppInSimulatorDevice): Added.
1743         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
1744         "Booted" state.
1745         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
1746         switching between a system installed app and a custom built version of the same app (e.g.
1747         custom build of MobileSafari) will erase all contents and settings in the simulator device.
1748         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
1749         as that was the only caller of this function.
1750         (bootedIOSSimulatorDevice): Deleted.
1751         (openIOSSimulator): Deleted.
1752
1753 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1754
1755         Update bot assignments.
1756
1757         * BuildSlaveSupport/build.webkit.org-config/config.json:
1758
1759 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1760
1761         Leaks bot shouldn't run JSC tests
1762         https://bugs.webkit.org/show_bug.cgi?id=140877
1763
1764         Reviewed by Darin Adler.
1765
1766         Shaves off 48 minutes of time.
1767
1768         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1769         (TestLeaksFactory): Slim down the leaks queue.
1770
1771         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1772         * Scripts/webkitpy/port/ios.py:
1773         (IOSSimulatorPort.print_leaks_summary):
1774         * Scripts/webkitpy/port/mac.py:
1775         (MacPort.print_leaks_summary):
1776         Don't yell when leaks are detected.
1777
1778 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1779
1780         Refactor run-javascriptcore-tests
1781         https://bugs.webkit.org/show_bug.cgi?id=140824
1782
1783         Reviewed by Darin Adler.
1784
1785         Separated mozilla, stress test code paths and
1786         determining skipped mozilla tests into subroutines.
1787
1788         * Scripts/run-javascriptcore-tests:
1789         (runMozillaTests):
1790         (runJSCStressTests):
1791         (defaultJsDriverArgsForMozillaTests):
1792
1793 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1794
1795         [buildbot] Fix grammar of TestWithFailureCount
1796         https://bugs.webkit.org/show_bug.cgi?id=140884
1797
1798         Reviewed by Alexey Proskuryakov.
1799
1800         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1801         (TestWithFailureCount):
1802         (TestWithFailureCount.commandComplete):
1803         (TestWithFailureCount.getText2):
1804         (RunUnitTests):
1805         (RunPythonTests):
1806         (RunPerlTests):
1807         (RunLLINTCLoopTests):
1808         (Run32bitJSCTests):
1809         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1810         (RunLLINTCLoopTestsTest.test_failure):
1811         (Run32bitJSCTestsTest.test_failure):
1812         (RunUnitTestsTest.assertFailures):
1813
1814 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1815
1816         Unreviewed. Moving myself to the committer section.
1817
1818         * Scripts/webkitpy/common/config/contributors.json:
1819
1820 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
1821
1822         [GTK] gtkdoc does not appear in DevHelp
1823         https://bugs.webkit.org/show_bug.cgi?id=139369
1824
1825         Reviewed by Philippe Normand.
1826
1827         * gtk/generate-gtkdoc: Create the generators in the main function
1828         and use them to get the local cross renference dependencies. Also
1829         pass the generator module name to webkitdom.write_doc_files().
1830         (get_gtkdoc_module_paths): Receive a list of local cross reference
1831         dependencies.
1832         (get_generator_for_config): Set the main_sgml_file property of the
1833         GtkDoc object from the configuration file.
1834         (generate_documentation): Generate the documentation for the given
1835         generator.
1836         (generate_documentation_for_config): Deleted.
1837         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
1838         * gtk/webkitdom.py:
1839         (write_doc_files): Receive the module name used to build the
1840         -sections.txt filename.
1841
1842 2015-01-26  Commit Queue  <commit-queue@webkit.org>
1843
1844         Unreviewed, rolling out r179107.
1845         https://bugs.webkit.org/show_bug.cgi?id=140880
1846
1847         The GCC in the bots doesn't support the AsyncTask
1848         implementation (Requested by KaL on #webkit).
1849
1850         Reverted changeset:
1851
1852         "[GTK] Enable IndexedDB"
1853         https://bugs.webkit.org/show_bug.cgi?id=98932
1854         http://trac.webkit.org/changeset/179107
1855
1856 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1857
1858         [EFL] Bump libseccomp version to 2.1.1
1859         https://bugs.webkit.org/show_bug.cgi?id=140357
1860
1861         Reviewed by Gyuyoung Kim.
1862
1863         * efl/jhbuild.modules:
1864
1865 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1866
1867         [GTK] Enable IndexedDB
1868         https://bugs.webkit.org/show_bug.cgi?id=98932
1869
1870         Reviewed by Žan Doberšek.
1871
1872         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
1873
1874 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
1875
1876         Would like leaks bot results at build.webkit.org/dashboard
1877         https://bugs.webkit.org/show_bug.cgi?id=122657
1878
1879         Reviewed by Darin Adler.
1880
1881         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1882         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
1883         than necessary, could use the ones from buildbot in more places.
1884
1885         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1886         (BuildbotQueue): Reflect configuration option for leaks queues.
1887
1888         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1889         Add leaks queues to performance column. First, leaks are about performance indeed,
1890         and second, this is where we have some space to spare.
1891
1892         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1893         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
1894         least a year.
1895
1896         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1897         (table.queue-grid td): Moved height from queue-view - we can now have more than one
1898         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
1899         results - once the results are loaded, all rows are currently higher than that.
1900
1901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1902         (.leaks-popover): Added.
1903
1904         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1905         Added.
1906
1907         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1908         Load BuildbotLeaksQueueView.js.
1909
1910 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
1911
1912         [Win] Add WebKit message loop interface.
1913         https://bugs.webkit.org/show_bug.cgi?id=140857
1914
1915         Reviewed by Brent Fulgham.
1916
1917         Added message loop interface which will run the message loop,
1918         and perform required tasks (like calling CFRunLoopRunInMode)
1919         on each iteration of the loop.
1920
1921         * WinLauncher/WinMain.cpp:
1922         (wWinMain): Use new message loop interface.
1923
1924 2015-01-24  Dan Bernstein  <mitz@apple.com>
1925
1926         update-webkit’s --internal option is unused
1927         https://bugs.webkit.org/show_bug.cgi?id=140861
1928
1929         Reviewed by Anders Carlsson.
1930
1931         * Scripts/update-webkit: Removed the option.
1932
1933 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
1934
1935         DumpRenderTree needs to run with Windows native controls on Windows
1936         https://bugs.webkit.org/show_bug.cgi?id=25592
1937
1938         Reviewed by Anders Carlsson.
1939
1940         * DumpRenderTree/win/DumpRenderTree.cpp:
1941         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
1942         (prepareConsistentTestingEnvironment): Ditto.
1943
1944 2015-01-23  David Kilzer  <ddkilzer@apple.com>
1945
1946         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
1947         <http://webkit.org/b/140787>
1948
1949         Reviewed by Daniel Bates.
1950
1951         * Scripts/webkitpy/port/ios.py:
1952         (IOSPort.determine_full_port_name): Instead of checking the type
1953         of the current host, test if /usr/bin/xcrun exists before trying
1954         to use it.
1955
1956 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
1957
1958         Fix the false positive build failures on the Windows buildbots
1959         https://bugs.webkit.org/show_bug.cgi?id=140819
1960
1961         Reviewed by Brent Fulgham.
1962
1963         Increase the build timeout (without producing output) to 2 hours for Windows bots,
1964         the default 20 minutes is enough for others since they produce output during the build.
1965
1966         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1967         (BuildFactory.__init__):
1968
1969 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1970
1971         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
1972         https://bugs.webkit.org/show_bug.cgi?id=140839
1973
1974         Reviewed by Dean Jackson.
1975
1976         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1977         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
1978         from the IA2Locale structure and pass it to DRT.
1979
1980 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1981
1982         [Win] Update DRT Accessibility implementation to better match Mac.
1983         https://bugs.webkit.org/show_bug.cgi?id=140830
1984
1985         Reviewed by Dean Jackson.
1986
1987         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1988         (AccessibilityUIElement::titleUIElement):
1989         (AccessibilityUIElement::parentElement):
1990         (convertToDRTLabel):
1991         (AccessibilityUIElement::role):
1992         (AccessibilityUIElement::title):
1993         (AccessibilityUIElement::description):
1994         (AccessibilityUIElement::stringValue):
1995         (AccessibilityUIElement::helpText):
1996         (AccessibilityUIElement::isFocused):
1997
1998 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
1999
2000         REGRESSION: run-perf-tests --profiler= seems to have broken
2001         https://bugs.webkit.org/show_bug.cgi?id=113528
2002
2003         Reviewed by Daniel Bates.
2004
2005         The problem is that "perf --record" (or the equivalent call for
2006         other profilers) is never called whenever there is a wrapper
2007         option in the port. We should inject the profiler call first
2008         (should it exists) and then use the port wrapper.
2009
2010         * Scripts/webkitpy/port/driver.py:
2011         (Driver._command_wrapper):
2012         * Scripts/webkitpy/port/driver_unittest.py:
2013         (DriverTest.test_profiler_and_wrapper): New unit test.
2014
2015 2015-01-22  David Kilzer  <ddkilzer@apple.com>
2016
2017         configure-xcode-for-ios-development needs to import webkitdirs.pm
2018         <http://webkit.org/b/140704>
2019
2020         Fixes the following runtime error:
2021
2022             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
2023
2024         * Scripts/configure-xcode-for-ios-development: Add back code to
2025         import webkitdirs.pm for the exitStatus() method.  Not sure why
2026         I removed it before patch review.
2027
2028 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
2029
2030         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
2031         https://bugs.webkit.org/show_bug.cgi?id=140795
2032
2033         Reviewed by Jon Honeycutt.
2034
2035         * BuildSlaveSupport/build.webkit.org-config/config.json:
2036         r178847 accidentally remove the scheduler for this bot. Re-add it to the
2037         Yosemite scheduler.
2038
2039 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
2040
2041         [Win] Expose missing editing features through WebView interface
2042         https://bugs.webkit.org/show_bug.cgi?id=140773
2043         <rdar://problem/19565421>
2044
2045         Reviewed by Dean Jackson.
2046
2047         Connect the various WebView editing delegate methods to our
2048         test infrastructure. Also prefer _bstr_t to raw BSTR types
2049         to simplify life cycle management.
2050
2051         * DumpRenderTree/win/DumpRenderTree.cpp:
2052         (resetWebViewToConsistentStateBeforeTesting):
2053         * DumpRenderTree/win/EditingDelegate.cpp:
2054         (EditingDelegate::QueryInterface):
2055         (dumpPath):
2056         (dump):
2057         (EditingDelegate::shouldBeginEditingInDOMRange):
2058         (EditingDelegate::shouldEndEditingInDOMRange):
2059         (EditingDelegate::shouldInsertNode):
2060         (EditingDelegate::shouldInsertText):
2061         (EditingDelegate::shouldDeleteDOMRange):
2062         (EditingDelegate::shouldChangeSelectedDOMRange):
2063         (EditingDelegate::shouldApplyStyle):
2064         (EditingDelegate::shouldChangeTypingStyle):
2065         (EditingDelegate::doPlatformCommand):
2066         (EditingDelegate::webViewDidBeginEditing):
2067         (EditingDelegate::webViewDidChange):
2068         (EditingDelegate::webViewDidEndEditing):
2069         (EditingDelegate::webViewDidChangeTypingStyle):
2070         (EditingDelegate::webViewDidChangeSelection):
2071         (EditingDelegate::checkSpellingOfString):
2072         (EditingDelegate::onNotify):
2073         * DumpRenderTree/win/EditingDelegate.h:
2074
2075 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2076
2077         Add a build flag for ES6 class syntax
2078         https://bugs.webkit.org/show_bug.cgi?id=140760
2079
2080         Reviewed by Michael Saboff.
2081
2082         * Scripts/webkitperl/FeatureList.pm:
2083
2084 2015-01-22  Daniel Bates  <dabates@apple.com>
2085
2086         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
2087         runtime in simctl output
2088         https://bugs.webkit.org/show_bug.cgi?id=140751
2089
2090         Reviewed by David Kilzer.
2091
2092         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
2093         with an error because it does not know how to parse the output of the simctl tool
2094         to identify an Apple Internal runtime.
2095
2096         * Scripts/webkitpy/xcode/simulator.py:
2097         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
2098         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
2099         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
2100         the runtime is an internal runtime.
2101         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
2102         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
2103         appropriate value.
2104         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
2105         it updates the appropriate Runtime object.
2106         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
2107         looking up a Runtime object for an internal runtime.
2108
2109 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
2110
2111         LeaksViewer doesn't show recent builds if there are less than 10
2112         https://bugs.webkit.org/show_bug.cgi?id=140716
2113
2114         Reviewed by Tim Horton.
2115
2116         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2117
2118 2015-01-22  Lucas Forschler  <lforschler@apple.com>
2119
2120         Add Apple build slaves.
2121         Fixed text alignment for slave list.
2122         
2123         Unreviewed.
2124         
2125         * BuildSlaveSupport/build.webkit.org-config/config.json:
2126
2127 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2128
2129         Teach build.webkit.org about bot308 and bot309.
2130         
2131         Unreviewed.
2132         
2133         * BuildSlaveSupport/build.webkit.org-config/config.json:
2134
2135 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2136
2137         Add two Apple Mavericks slaves.
2138         
2139         Unreviewed.
2140         
2141         * BuildSlaveSupport/build.webkit.org-config/config.json:
2142
2143 2015-01-21  Daniel Bates  <dabates@apple.com>
2144
2145         Add iOS WebKit1 TestExpectation file
2146         https://bugs.webkit.org/show_bug.cgi?id=140739
2147
2148         Reviewed by David Kilzer.
2149
2150         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
2151         expectations in directory LayoutTests/platform/ios-simulator-wk1.
2152
2153         * Scripts/webkitpy/port/ios.py:
2154         (IOSSimulatorPort.default_baseline_search_path):
2155
2156 2015-01-21  David Kilzer  <ddkilzer@apple.com>
2157
2158         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
2159         <http://webkit.org/b/140704>
2160
2161         Reviewed by Daniel Bates.
2162
2163         * Scripts/configure-xcode-for-ios-development:
2164         - Update copyright.
2165         - Remove FIXME addressed by r178709.
2166         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
2167         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
2168         missing headers from iphonesimulator SDK to iphoneos SDK.
2169         (sdkDirectory): Add method that returns SDK directory.
2170         (sdkPlatformDirectory): Extract method from
2171         xcodeSDKSpecificationsPath() that returns SDK platform
2172         directory.
2173         (xcodeSDKSpecificationsPath): Update to use
2174         sdkPlatformDirectory().
2175
2176 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
2177
2178         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
2179         https://bugs.webkit.org/show_bug.cgi?id=140731
2180
2181         Reviewed by Tim Horton.
2182
2183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2184         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
2185
2186 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
2187
2188         [Win] eventSender does not support scalePageBy
2189         https://bugs.webkit.org/show_bug.cgi?id=140726
2190         <rdar://problem/19549865>
2191
2192         Reviewed by Dean Jackson.
2193
2194         * DumpRenderTree/win/EventSender.cpp:
2195         (scalePageByCallback): Provide implementation using new WebView method.
2196
2197 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2198
2199         Remove Apple Mountain Lion Build & Test slaves.
2200         
2201         Unreviewed.
2202
2203         * BuildSlaveSupport/build.webkit.org-config/config.json:
2204
2205 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
2206
2207         Remove ENABLE(INSPECTOR) ifdef guards
2208         https://bugs.webkit.org/show_bug.cgi?id=140668
2209
2210         Reviewed by Darin Adler.
2211
2212         * DumpRenderTree/mac/TestRunnerMac.mm:
2213         (TestRunner::showWebInspector):
2214         (TestRunner::closeWebInspector):
2215         (TestRunner::evaluateInWebInspector):
2216         * Scripts/webkitperl/FeatureList.pm:
2217         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2218         (WTR::TestRunner::showWebInspector):
2219         (WTR::TestRunner::closeWebInspector):
2220         (WTR::TestRunner::evaluateInWebInspector):
2221         * WebKitTestRunner/TestInvocation.cpp:
2222         (WTR::TestInvocation::invoke):
2223
2224 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
2225
2226         Update build.webkit.org/dashboard to match current Mac queues.
2227
2228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
2229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
2230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
2231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
2232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2233         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2235         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
2236         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
2237
2238 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2239
2240         Update Apple MountainLion Leaks slave to Yosemite
2241         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
2242         
2243         Unreviewed.
2244
2245         * BuildSlaveSupport/build.webkit.org-config/config.json:
2246
2247 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2248
2249         Update LeaksViewer from MountainLion to Yosemite
2250         
2251         Reviewed by Alexey Proskuryakov.
2252
2253         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2254         (LeaksViewer._displayURLPrompt):
2255
2256 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
2257
2258         Fix EWS python unit tests and address code comments as per 140476
2259         https://bugs.webkit.org/show_bug.cgi?id=140637
2260
2261         Reviewed by David Kilzer.
2262
2263         * Scripts/webkitpy/port/base.py:
2264         (Port):
2265         (Port.__init__):
2266         Adds DEFAULT_ARCHITECTURE member.
2267         (Port.architecture):
2268         Removes architecture member and instead uses
2269         self.get_option('architecture'). Also removes redundant architecture
2270         method.
2271         (Port.set_architecture):
2272         Adds a setter for the architecture variable to be able to set a flag
2273         upon modification.
2274         (Port.test_configuration):
2275         Uses self.architecture() instead of self._architecture.
2276         * Scripts/webkitpy/port/ios.py:
2277         Overrides DEFAULT_ARCHITECTURE.
2278         (IOSPort):
2279         (IOSPort.determine_full_port_name):
2280         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
2281         strip. Fixes regex to not match arbitrary characters after the
2282         relevent digits are matched.
2283         (IOSPort.__init__):
2284         Removes old _architecture defaulting strategy.
2285         (IOSPort._build_driver_flags):
2286         Uses self.architecture() instead of self._architecture.
2287         (IOSSimulatorPort):
2288         Overrides DEFAULT_ARCHITECTURE.
2289         (IOSSimulatorPort.__init__):
2290         Removes old _architecture defaulting strategy.
2291         * Scripts/webkitpy/port/mac.py:
2292         (MacPort):
2293         Overrides DEFAULT_ARCHITECTURE.
2294         (MacPort.__init__):
2295         Removes old _architecture defaulting strategy.
2296         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2297         (AbstractEarlyWarningSystem.run_command):
2298         Checks the did_override_architecture flag to determine whether to add
2299         the --architecture option.
2300         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2301         Uses ews.architecture rather than trying to discern the correct
2302         architecture using a port object.
2303         (EarlyWarningSystemTest._default_expected_logs):
2304         * Scripts/webkitpy/tool/commands/queues.py:
2305         Removes use of optparse, and removes the import statement.
2306         (AbstractQueue.__init__):
2307         (PatchProcessingQueue.begin_work_queue):
2308
2309 2015-01-20  Sam Weinig  <sam@webkit.org>
2310
2311         Attempt to fix Mountain Lion and EFL tests.
2312
2313         * WebKitTestRunner/TestController.cpp:
2314         (WTR::TestController::initialize):
2315         Disable Process-per-tab and network process on Mountain Lion and EFL.
2316
2317 2015-01-20  Darin Adler  <darin@apple.com>
2318
2319         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
2320         https://bugs.webkit.org/show_bug.cgi?id=140679
2321
2322         Reviewed by Anders Carlsson.
2323
2324         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2325         Removed a reference to SVGElementInstanceList.
2326
2327 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2328
2329         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
2330         https://bugs.webkit.org/show_bug.cgi?id=140028
2331
2332         Reviewed by Carlos Garcia Campos.
2333
2334         This won't work as expected, since this function is called before the
2335         WebViewTest constructor completes.
2336
2337         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2338
2339 2015-01-20  David Kilzer  <ddkilzer@apple.com>
2340
2341         configure-xcode-for-ios-development needs to update iPhoneOS SDK
2342         <http://webkit.org/b/140661>
2343
2344         Reviewed by Daniel Bates.
2345
2346         * Scripts/configure-xcode-for-ios-development: Add for() loop to
2347         run createXcodeSpecificationFilesForSDKIfNeeded() for both
2348         "iphoneos" and "iphonesimulator" SDKs.
2349         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
2350         the main body of the script.
2351
2352 2015-01-20  Tomas Popela  <tpopela@redhat.com>
2353
2354         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
2355         https://bugs.webkit.org/show_bug.cgi?id=139443
2356
2357         Reviewed by Carlos Garcia Campos.
2358
2359         Create the new test cases for setting the editable property on the web
2360         view and on the contenteditable enabled document. Also rework the
2361         current tests that are expecting that the web view is editable.
2362
2363         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2364         (loadTestHtml):
2365         (testWebViewEditorCutCopyPasteNonEditable):
2366         (testWebViewEditorCutCopyPasteEditable):
2367         (testWebViewEditorSelectAllNonEditable):
2368         (testWebViewEditorSelectAllEditable):
2369         (runEditorEditableCutTests):
2370         (testWebViewEditorEditableOnNonEditable):
2371         (testWebViewEditorEditableOnContentEditable):
2372         (testWebViewEditorNonEditable):
2373         (beforeAll):
2374         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2375         (WebViewTest::isEditable):
2376         (WebViewTest::setEditable):
2377
2378 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2379
2380         [GTK] Add an option to create WebKitWebView snapshots with transparent background
2381         https://bugs.webkit.org/show_bug.cgi?id=140617
2382
2383         Reviewed by Gustavo Noronha Silva.
2384
2385         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2386         (testWebViewSnapshot): Check that the same snapshot with
2387         transparent background is different than the default one filled
2388         with white.
2389
2390 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2391
2392         [GTK] Add API to change the WebKitWebView background color
2393         https://bugs.webkit.org/show_bug.cgi?id=140610
2394
2395         Reviewed by Gustavo Noronha Silva.
2396
2397         Add --bg-color command line option to MiniBrowser to be able to
2398         manually test the API passing any RGBA color to MiniBrowser.
2399         Also add a simple unit test to check that getting and setting
2400         colors from the API point of view.
2401
2402         * MiniBrowser/gtk/BrowserWindow.c:
2403         (browser_window_set_background_color):
2404         * MiniBrowser/gtk/BrowserWindow.h:
2405         * MiniBrowser/gtk/main.c:
2406         (createBrowserWindow):
2407         (parseBackgroundColor):
2408         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2409         (testWebViewBackgroundColor):
2410         (beforeAll):
2411
2412 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2413
2414         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
2415         https://bugs.webkit.org/show_bug.cgi?id=140665
2416
2417         Reviewed by Brian Burg.
2418
2419         * DumpRenderTree/win/UIDelegate.cpp:
2420         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
2421         match expected test output.
2422
2423 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
2424
2425         Remove the support for custom suffixes on ChangeLog
2426         https://bugs.webkit.org/show_bug.cgi?id=140648
2427
2428         Reviewed by David Kilzer.
2429
2430         Custom suffixes were used for the iOS branch of WebKit.
2431         Now that everything is opensource, there is no need for it.
2432
2433         * Scripts/VCSUtils.pm:
2434         (changeLogSuffix): Deleted.
2435         (changeLogFileName): Deleted.
2436         * Scripts/commit-log-editor:
2437         * Scripts/prepare-ChangeLog:
2438         (getLatestChangeLogs):
2439         (generateNewChangeLogs):
2440         (generateFileList):
2441         * Scripts/resolve-ChangeLogs:
2442         (findChangeLog):
2443
2444 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
2445
2446         Adjust naming of action menu SPI
2447         https://bugs.webkit.org/show_bug.cgi?id=140644
2448         <rdar://problem/19448129>
2449
2450         Reviewed by Brian Weinstein.
2451
2452         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2453         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2454         (TestWebKitAPI::TEST):
2455
2456 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2457
2458         [GTK] Generate the make dist manifest from a CMake template file
2459         https://bugs.webkit.org/show_bug.cgi?id=139387
2460
2461         Reviewed by Martin Robinson.
2462
2463         Remove the code that performs variable substitution on manifest.txt.
2464         Replace the custom variables used in that file with CMake variables.
2465
2466         * gtk/make-dist.py:
2467         (Manifest.add_directory):
2468         (Manifest.get_full_source_path):
2469         (Manifest.process_line):
2470         (Manifest.resolve_variables): Deleted.
2471         (Manifest.get_full_tarball_path): Deleted.
2472         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
2473
2474 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2475
2476         [Win] Correct merge error in last commit.
2477
2478         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2479         (findAccessibleObjectById): Undo accidental paste made during landing.
2480
2481 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2482
2483         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
2484         https://bugs.webkit.org/show_bug.cgi?id=139906
2485
2486         Reviewed by Dean Jackson.
2487
2488         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
2489         to use them. This patch fixes that.
2490
2491         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2492         (findAccessibleObjectById):
2493         (AccessibilityController::focusedElement):
2494         (logEventProc):
2495         (notificationListenerProc):
2496         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2497         (AccessibilityUIElement::getChildAtIndex):
2498         (AccessibilityUIElement::titleUIElement):
2499         (self):
2500         (AccessibilityUIElement::role):
2501         (AccessibilityUIElement::valueDescription):
2502         (accessibilityState):
2503         (AccessibilityUIElement::isChecked):
2504         * DumpRenderTree/win/DumpRenderTree.cpp:
2505         (dumpFrameScrollPosition):
2506         (dumpFramesAsText):
2507         * DumpRenderTree/win/PolicyDelegate.cpp:
2508         (PolicyDelegate::decidePolicyForNavigationAction):
2509         * DumpRenderTree/win/UIDelegate.cpp:
2510         (UIDelegate::exceededDatabaseQuota):
2511         * WinLauncher/Common.cpp:
2512         (setWindowText):
2513
2514 2015-01-19  Dean Jackson  <dino@apple.com>
2515
2516         Add "override" to fix the build with newer clangs.
2517
2518         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2519         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
2520
2521 2015-01-19  David Kilzer  <ddkilzer@apple.com>
2522
2523         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
2524         <http://webkit.org/b/140623>
2525
2526         Reviewed by Daniel Bates.
2527
2528         * Scripts/build-webkit: Update help for --device switch.
2529         * Scripts/webkitdirs.pm:
2530         (determineXcodeSDK): When passing --device, prefer the internal
2531         iOS SDK if it exists, else fall back to the external iOS SDK.
2532         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
2533         xcodebuild instead of trying to sanitize values.
2534
2535 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
2536
2537         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
2538         https://bugs.webkit.org/show_bug.cgi?id=140606
2539
2540         Reviewed by Csaba Osztrogonác.
2541
2542         * Scripts/webkitpy/bindings/main.py:
2543         (BindingsTests.generate_supplemental_dependency):
2544         (BindingsTests.main):
2545
2546 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2547
2548         [GTK] [WK2] TestWebKitWebView snapshot fails
2549         https://bugs.webkit.org/show_bug.cgi?id=120404
2550
2551         Reviewed by Žan Doberšek.
2552
2553         Rework the test to make sure the snapshot is always created at the
2554         desired size.
2555
2556         * Scripts/run-gtk-tests:
2557         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
2558         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2559         (testWebViewSnapshot): Use a fixed size for the document, and
2560         disable scrollbars to make sure the visible area is always the
2561         WebView size.
2562         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2563         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
2564         and height parameters to create the window with a given size.
2565         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2566
2567 2015-01-18  David Kilzer  <ddkilzer@apple.com>
2568
2569         iOS EWS queue name should be consistent
2570         <http://webkit.org/b/140585>
2571
2572         Reviewed by Daniel Bates.
2573
2574         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
2575         to 'ios'.
2576         * Scripts/webkitpy/common/config/ports.py: Ditto.
2577         (DeprecatedPort.port):
2578         (IOSPort):
2579         * Scripts/webkitpy/port/ios.py: Ditto.
2580         (IOSPort):
2581
2582         * Scripts/webkitpy/port/factory.py:
2583         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
2584         appears before ios.IOSPort.  If this is not done,
2585         `run-webkit-tests --ios-simulator` will get the wrong Port class
2586         (IOSPort instead of IOSSimulatorPort) due to the way that
2587         PortFactory.get() uses prefix matching of <Port>.port_name to
2588         find the correct class to use.
2589
2590 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
2591
2592         build.webkit.org/dashboard: OS X EWS is now on Mavericks
2593         https://bugs.webkit.org/show_bug.cgi?id=140595
2594
2595         Reviewed by Csaba Osztrogonác.
2596
2597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2598         (BubbleQueueServer):
2599
2600 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2601
2602         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
2603
2604         * Scripts/webkitpy/port/ios.py:
2605         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
2606         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
2607         the Mountain Lion and Mavericks bots.
2608
2609 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2610
2611         Attempt to fix webkitpy tests on GTK Linux ports
2612
2613         * Scripts/webkitpy/port/ios.py:
2614         (IOSPort.determine_full_port_name): Set a sensible default if
2615         not running on a Mac platform or if no iOS SDK is installed.
2616
2617 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
2618
2619         Create iOS-EWS client queue
2620         https://bugs.webkit.org/show_bug.cgi?id=140476
2621
2622         Reviewed by Alexey Proskuryakov.
2623
2624         * EWSTools/start-queue-mac.sh:
2625         Adds call to configure-xcode-for-ios-development for iOS EWS.
2626         * Scripts/webkitpy/common/config/ews.json:
2627         Adds the iOS EWS config entry.
2628         * Scripts/webkitpy/common/config/ports.py:
2629         (DeprecatedPort.port):
2630         Adds IOSPort to the port map.
2631         (IOSPort):
2632         (IOSPort.build_webkit_command):
2633         Adds --sdk=iphoneos to the webkit build command.
2634         * Scripts/webkitpy/port/base.py:
2635         (Port.architecture):
2636         Adds an accessor for the architecture member variable.
2637         * Scripts/webkitpy/port/factory.py:
2638         (PortFactory):
2639         Adds IOSPort to the port class list.
2640         * Scripts/webkitpy/port/ios.py:
2641         Adds the IOSPort to encapsulate iOS-specific things.
2642         (IOSPort):
2643         (IOSPort.determine_full_port_name):
2644         (IOSPort.__init__):
2645         (IOSPort._build_driver_flags):
2646         (IOSPort.operating_system):
2647         * Scripts/webkitpy/tool/commands/download_unittest.py:
2648         Adds the archetecture option to the mock options.
2649         (DownloadCommandsTest._default_options):
2650         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2651         Appends the archetecture option into calls to webkit-patch.
2652         (AbstractEarlyWarningSystem.review_patch):
2653         (AbstractEarlyWarningSystem.run_command):
2654         (AbstractEarlyWarningSystem.load_ews_classes):
2655         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2656         Adds logic to soothe the unittest now that --architecture is being
2657         thrown around everywhere.
2658         (EarlyWarningSystemTest._default_expected_logs):
2659         * Scripts/webkitpy/tool/commands/queues.py:
2660         Adds glue code to ferry the --architecture option around.
2661         (AbstractQueue.__init__):
2662         (PatchProcessingQueue.begin_work_queue):
2663         * Scripts/webkitpy/tool/steps/abstractstep.py:
2664         Adds the archetecture option to all AbstractSteps so that
2665         EarlyWarningSystem doesn't start shoving --architecture into
2666         unsuspecting commands.
2667         (AbstractStep.options):
2668         * Scripts/webkitpy/tool/steps/build.py:
2669         Translates the --architecture option into an ARCHS= format to pass to
2670         build-webkit.
2671         (Build.build):
2672         * Scripts/webkitpy/tool/steps/options.py:
2673         Adds a definition for the --architecture option.
2674         (Options):
2675
2676 2015-01-16  Sam Weinig  <sam@webkit.org>
2677
2678         Add a basic configuration object for WKView
2679         https://bugs.webkit.org/show_bug.cgi?id=140559
2680
2681         Reviewed by Anders Carlsson.
2682
2683         Add tests for WKPageConfigurationRef.
2684
2685         * TestWebKitAPI/PlatformWebView.h:
2686         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2687         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
2688         (TestWebKitAPI::TEST):
2689         (TestWebKitAPI::didFinishLoadForFrame):
2690         (TestWebKitAPI::setPageLoaderClient):
2691         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2692         (TestWebKitAPI::PlatformWebView::initialize):
2693         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2694
2695 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
2696
2697         WeakPtr functions crash when created with default constructor
2698         https://bugs.webkit.org/show_bug.cgi?id=140479
2699
2700         Reviewed by Andreas Kling.
2701
2702         Add WeakPtr API tests.
2703
2704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2705         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
2706         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
2707
2708 2015-01-16  Chris Dumez  <cdumez@apple.com>
2709
2710         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
2711         https://bugs.webkit.org/show_bug.cgi?id=140568
2712
2713         Reviewed by Alexey Proskuryakov.
2714
2715         Fix the script parsing CSSPropertyNames.in to stop splitting lines
2716         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
2717         e.g. "Longhands=background-position-x|background-position-y".
2718         This would confuse the script and treat this as a CSS property:
2719         "background-position-x|background-position-y".
2720
2721         We now split on white space and treat the first string on the line
2722         to be the property name (this is the syntax in this file).
2723
2724         * Scripts/webkitpy/w3c/test_converter.py:
2725         (_W3CTestConverter.__init__):
2726         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2727
2728 2015-01-16  Daniel Bates  <dabates@apple.com>
2729
2730         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
2731         https://bugs.webkit.org/show_bug.cgi?id=135589
2732
2733         Reviewed by David Kilzer.
2734
2735         Derived from a patch by David Farler.
2736
2737         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
2738         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
2739         in terms of the simctl command line utility.
2740
2741         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
2742         (eraseIOSSimulatorDevice): Added.
2743         (bootedIOSSimulatorDevice): Added.
2744         (iosSimulatorApplicationsPath): Added.
2745         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
2746         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
2747         (quitIOSSimulator): Added.
2748         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
2749         the specified name and currently selected iOS runtime.
2750         (isIOSSimulatorSystemInstalledApp): Added.
2751         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
2752         (deleteiOSSimulatorDevice): Deleted.
2753         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
2754         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
2755
2756 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
2757
2758         Resurrect the WinCairo bot.
2759         https://bugs.webkit.org/show_bug.cgi?id=139908
2760
2761         Reviewed by Csaba Osztrogonác.
2762
2763         * BuildSlaveSupport/build.webkit.org-config/config.json:
2764         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2765         (appendCustomBuildFlags):
2766         * BuildSlaveSupport/test-result-archive:
2767         (archiveTestResults):
2768         Add WinCairo buildbot.
2769
2770 2015-01-16  Chris Dumez  <cdumez@apple.com>
2771
2772         webkit-patch should auto-install the keyring python module
2773         https://bugs.webkit.org/show_bug.cgi?id=140547
2774
2775         Reviewed by David Kilzer.
2776
2777         Auto-install the keyring python module. This is the module that
2778         webkit-patch uses for cross-platform access to the keyring
2779         service.
2780
2781         Without this module, if the password if not in the keychain,
2782         webkit-patch will keep asking for your username / password and
2783         never remember them.
2784
2785         * Scripts/webkitpy/common/net/credentials.py:
2786         * Scripts/webkitpy/thirdparty/__init__.py:
2787         (AutoinstallImportHook.find_module):
2788         (AutoinstallImportHook._install_keyring):
2789
2790 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
2791
2792         Remove ENABLE(SQL_DATABASE) guards
2793         https://bugs.webkit.org/show_bug.cgi?id=140434
2794
2795         Reviewed by Darin Adler.
2796
2797         * Scripts/webkitperl/FeatureList.pm:
2798
2799 2015-01-15  Daniel Bates  <dabates@apple.com>
2800
2801         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
2802         https://bugs.webkit.org/show_bug.cgi?id=139685
2803         <rdar://problem/19281317>
2804
2805         Reviewed by Simon Fraser.
2806
2807         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
2808         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
2809
2810         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
2811         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
2812         before DRT dumps the output of a test. In particular, the WebThread may start a new page
2813         load (say, as a result of continued JavaScript execution), which will ultimately lead to
2814         dumping the test result again. Instead we want DRT to dump the test result synchronously
2815         such that we capture the state of the web page either when the page is loaded or when
2816         window.testRunner.notifyDone() is called.
2817
2818         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2819         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
2820         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
2821         flush CA transactions to the window.
2822         * DumpRenderTree/mac/DumpRenderTree.mm:
2823         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
2824         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
2825         (dump): Renamed; formerly named dumpTestResults().
2826         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
2827         enabling repaint support on iOS.
2828         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
2829         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
2830         (dumpTestResults): Deleted.
2831
2832 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
2833
2834         [Win] Miscellaneous DRT fixes
2835         https://bugs.webkit.org/show_bug.cgi?id=116562
2836
2837         Reviewed by Tim Horton.
2838
2839         While investigating the cause of several Windows crashes, I found:
2840         (1) Messy conversions to and from BSTR types
2841         (2) Weird mixes of wide-string and narrow string conversions
2842         (3) Passing nullptr to some CoreFoundation routines that do not
2843             permit null arguments.
2844         (4) Commands to link the executable to the VS2005 runtime.
2845
2846         This patch cleans up these issues to improve DRT reliability on
2847         Windows.
2848
2849         * DumpRenderTree/cg/ImageDiffCG.cpp:
2850         (main): Get rid of VS2005 runtime linking.
2851         * DumpRenderTree/win/DumpRenderTree.cpp:
2852         (urlSuitableForTestResult): Protect against being asked
2853         to process an empty URL.
2854         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
2855         than converting to/from wchar_t buffers.
2856         (runTest): Simplify string and BSTR handling.
2857         (createWebViewAndOffscreenWindow): Ditto.
2858         (main): Get rid of VS2005 runtime linking.
2859         * DumpRenderTree/win/TestRunnerWin.cpp:
2860         (jsStringRefToWString): Simplify code.
2861         (TestRunner::pathToLocalResource):
2862         (TestRunner::setUserStyleSheetLocation):
2863         * TestWebKitAPI/win/main.cpp: Get rid of
2864         VS2005 runtime linking.
2865         * win/DLLLauncher/DLLLauncherMain.cpp:
2866         (wWinMain): Ditto.
2867
2868 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
2869
2870         Stop hardcoding mac-mountainlion in commit queue
2871         https://bugs.webkit.org/show_bug.cgi?id=140492
2872
2873         Reviewed by Anders Carlsson.
2874
2875         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
2876         there should be no change in behavior, because:
2877         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
2878         using it to create a port object.
2879         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
2880         is actually correct to use "mac" for the name there. We only used to get the expected
2881         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
2882         for unknown deprecated port names.
2883
2884         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
2885
2886 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
2887
2888         Create iOS-EWS server queue
2889         https://bugs.webkit.org/show_bug.cgi?id=140473
2890
2891         Reviewed by Benjamin Poulain.
2892
2893         * QueueStatusServer/app.yaml: Updates the SVN version number.
2894         * QueueStatusServer/config/queues.py: Add ios-ews queue.
2895         * QueueStatusServer/model/queues.py:         
2896         (Queue.display_name): Makes sure the display name is pretty!
2897
2898 2015-01-14  Daniel Bates  <dabates@apple.com>
2899
2900         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
2901         https://bugs.webkit.org/show_bug.cgi?id=140301
2902         <rdar://problem/19389266>
2903
2904         Reviewed by Jon Honeycutt.
2905
2906         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
2907         with an unavailable runtime.
2908
2909         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2910         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
2911         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
2912         specified runtime cannot be used because it is unavailable.
2913         * Scripts/webkitpy/port/ios.py:
2914         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
2915         which was formerly named testing_device.
2916         * Scripts/webkitpy/xcode/simulator.py:
2917         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
2918         more robust than looking up the simulator device by name and runtime. This approach also
2919         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
2920         unavailable runtimes under the same iOS heading it would use to show it as available).
2921         (Simulator.find_device_by_udid): Added.
2922         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
2923         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
2924         (Simulator.available_runtimes): Added.
2925         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
2926         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
2927         first element of the sorted list is the runtime with the highest version number.
2928         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
2929
2930 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
2931
2932         Remove WK2 Windows cruft
2933         https://bugs.webkit.org/show_bug.cgi?id=140440
2934
2935         Reviewed by Anders Carlsson.
2936
2937         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
2938         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
2939         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
2940
2941 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
2942
2943         Fix TestWTF failed in TestWebKitAPI
2944         https://bugs.webkit.org/show_bug.cgi?id=140333
2945
2946         Reviewed by Sam Weinig.
2947
2948         Clear the std::ostringstream before starting test.
2949
2950         * TestWebKitAPI/Tests/WTF/RefLogger.h:
2951         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
2952
2953 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2954
2955         TestWebKitWebContext depends on British English spellcheck dictionary
2956         https://bugs.webkit.org/show_bug.cgi?id=140403
2957
2958         Reviewed by Martin Robinson.
2959
2960         Install all English hunspell dictionaries on Fedora and Arch.
2961
2962         * gtk/install-dependencies:
2963
2964 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2965
2966         [GTK] install-dependencies should grok dnf
2967         https://bugs.webkit.org/show_bug.cgi?id=140396
2968
2969         Reviewed by Martin Robinson.
2970
2971         Fedora: install dependencies with dnf if yum is not installed.
2972
2973         * gtk/install-dependencies:
2974
2975 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
2976
2977         [EFL][GTK] Fix build after r178309  
2978         https://bugs.webkit.org/show_bug.cgi?id=140381
2979
2980         Reviewed by Gyuyoung Kim.
2981
2982         * TestWebKitAPI/CMakeLists.txt: Added the API directory
2983
2984 2015-01-11  Sam Weinig  <sam@webkit.org>
2985
2986         Remove support for SharedWorkers
2987         https://bugs.webkit.org/show_bug.cgi?id=140344
2988
2989         Reviewed by Anders Carlsson.
2990
2991         * Scripts/webkitperl/FeatureList.pm:
2992
2993 2015-01-12  Anders Carlsson  <andersca@apple.com>
2994
2995         Make delegates conform to formal delegate protocols
2996         https://bugs.webkit.org/show_bug.cgi?id=140370
2997
2998         Reviewed by Dan Bernstein.
2999
3000         * DumpRenderTree/mac/TestRunnerMac.mm:
3001         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3002         (TestRunner::setGeolocationPermission):
3003
3004 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3005
3006         build-webkit: silence output of 'which'
3007         https://bugs.webkit.org/show_bug.cgi?id=140278
3008
3009         Reviewed by Daniel Bates.
3010
3011         Use a more elegent test for the existance of ninja and eclipse.
3012
3013         * Scripts/webkitdirs.pm:
3014         (commandExists): Don't assume the command supports --version
3015         (canUseNinja): Use commandExists()
3016         (canUseEclipse): Use commandExists()
3017
3018 2015-01-09  Sam Weinig  <sam@webkit.org>
3019
3020         Update the output format for run-api-tests
3021         https://bugs.webkit.org/show_bug.cgi?id=140332
3022
3023         Reviewed by Dan Bernstein.
3024
3025         Changes the output format for run-api-tests be a bit simpler (no longer 
3026         indented based on suite, as we were not really using suite very well) but
3027         also include details in the case of failure.
3028
3029         Changes verbose mode to no longer spew out the gtest default printer output,
3030         as the custom printer now includes the failure information.
3031
3032         * Scripts/run-api-tests:
3033         (runTestsBySuite):
3034         (runTest):
3035         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
3036         with colorized variants and strip out leaks spew (the leaks can be added back using
3037         the new --show-leaks argument).
3038
3039         * TestWebKitAPI/TestsController.cpp:
3040         (TestWebKitAPI::Printer::OnTestPartResult):
3041         (TestWebKitAPI::Printer::OnTestEnd):
3042         (TestWebKitAPI::TestsController::run):
3043         Implement a custom result printer that just prints out the information we want.
3044
3045 2015-01-09  Sam Weinig  <sam@webkit.org>
3046
3047         TestWebKitAPI should print out the lists that fail at the end
3048         https://bugs.webkit.org/show_bug.cgi?id=140329
3049
3050         Reviewed by Tim Horton.
3051
3052         * Scripts/run-api-tests:
3053         (runTestsBySuite):
3054         Print out failures and timeouts in all modes, not just verbose.
3055
3056 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
3057
3058         Make bmalloc work with ASan
3059         https://bugs.webkit.org/show_bug.cgi?id=140194
3060
3061         Reviewed by Mark Lam.
3062
3063         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
3064         ASan automatically (by forwarding to system malloc at runtime).
3065
3066 2015-01-09  Daniel Bates  <dabates@apple.com>
3067
3068         [iOS] Make DumpRenderTree build with public SDK
3069         https://bugs.webkit.org/show_bug.cgi?id=140311
3070
3071         Reviewed by Sam Weinig.
3072
3073         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
3074         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
3075         Additionally, remove unused header CoreGraphics/CGFontDB.h.
3076
3077         * DumpRenderTree/mac/DumpRenderTree.mm:
3078         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
3079
3080 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
3081
3082         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
3083         https://bugs.webkit.org/show_bug.cgi?id=140300
3084
3085         Reviewed by Simon Fraser.
3086
3087         * WebKitTestRunner/TestController.cpp:
3088         (WTR::TestController::createOtherPage):
3089         (WTR::TestController::updateWindowScaleForTest):
3090         (WTR::TestController::configureViewForTest):
3091         * WebKitTestRunner/TestController.h:
3092
3093 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3094
3095         Unreviewed. Moving myself to the committer section.
3096
3097         * Scripts/webkitpy/common/config/contributors.json:
3098
3099 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3100
3101         Add a script to check for platform layering violations
3102         https://bugs.webkit.org/show_bug.cgi?id=140248
3103
3104         Reviewed by Darin Adler.
3105
3106         It prints all the cases where files inside platform include
3107         headers that are not in platform directory.
3108
3109         * Scripts/check-for-platform-layering-violations: Added.
3110         (get_platform_headers):
3111         (check_source_file):
3112
3113 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3114
3115         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
3116         https://bugs.webkit.org/show_bug.cgi?id=139884
3117
3118         Reviewed by Tim Horton.
3119
3120         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
3121         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
3122         what the "nominal resolution" is, but this appears to work in practice.
3123
3124 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
3125
3126         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
3127         https://bugs.webkit.org/show_bug.cgi?id=140256
3128
3129         Reviewed by Anders Carlsson.
3130
3131         * DumpRenderTree/win/DumpRenderTree.cpp:
3132         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
3133         running with heap validation checks.
3134         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
3135         the "svg\\W3C-SVG-1.1" test directory.
3136         (removeFontFallbackIfPresent): Use nullptr instead of 0.
3137         * DumpRenderTree/win/TestRunnerWin.cpp:
3138         (TestRunner::clearPersistentUserStyleSheet): Ditto.
3139
3140 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3141
3142         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
3143         https://bugs.webkit.org/show_bug.cgi?id=140218
3144
3145         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
3146         Undone an accidental change - check for self.has_crashed() again. This code path
3147         is for ports that don't have a signal handler printing #CRASHED when main process
3148         crashes.
3149
3150         * Scripts/webkitpy/port/driver_unittest.py:
3151         (DriverTest.test_check_for_driver_crash.assert_crash):
3152         (DriverTest.test_check_for_driver_crash):
3153         Updated the tests, all changes are expected.
3154
3155 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3156
3157         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
3158         https://bugs.webkit.org/show_bug.cgi?id=140218
3159
3160         Reviewed by Darin Adler.
3161
3162         * Scripts/webkitpy/port/driver.py:
3163         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
3164         "process crashed" condition. These don't make sense together - it's either a crash
3165         or a timeout, and we should detect those properly at a much lower level.
3166         (Driver.run_test): Ditto.
3167         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
3168         cases.
3169
3170         * WebKitTestRunner/TestController.h:
3171         * WebKitTestRunner/TestController.cpp:
3172         (WTR::TestController::webProcessName): 
3173         (WTR::TestController::processDidCrash):
3174         Factored out hardcoded child process names, as we now use these in two places.
3175
3176         * WebKitTestRunner/TestInvocation.cpp:
3177         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
3178         process name, so that it can be sampled (fixes sampling on Mavericks and above).
3179
3180 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3181
3182         Reorder my list of email addresses, keeping the Bugzilla address at the
3183         top since Bugzilla and other webkitpy scripts rely on that ordering.
3184
3185         * Scripts/webkitpy/common/config/contributors.json:
3186
3187 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3188
3189         Moving myself to the reviewers section and updating
3190         the list of my email addresses.
3191
3192         * Scripts/webkitpy/common/config/contributors.json:
3193
3194 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3195
3196         [GTK] Build gtk-doc without gtkdoc-mktmpl
3197         https://bugs.webkit.org/show_bug.cgi?id=140225
3198
3199         Reviewed by Darin Adler.
3200
3201         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
3202         don't modify the tmpl files that it generates, it's not doing anything
3203         for us.
3204
3205         * gtk/gtkdoc.py:
3206         (GTKDoc.generate):
3207         (GTKDoc._run_gtkdoc_scangobj):
3208         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
3209
3210 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
3211
3212         [GTK][ThreadedCompositor] Add support for threaded compositor.
3213         https://bugs.webkit.org/show_bug.cgi?id=118265
3214
3215         Reviewed by Martin Robinson.
3216
3217         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
3218         autotools build systems. The feature is disabled by default.
3219         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
3220         from the feature flags.
3221
3222         * Scripts/webkitperl/FeatureList.pm:
3223
3224 2015-01-07  Daniel Bates  <dabates@apple.com>
3225
3226         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3227         https://bugs.webkit.org/show_bug.cgi?id=137371
3228
3229         Reviewed by David Kilzer.
3230
3231         Use SPI wrapper headers instead of directly referencing private SPI headers.
3232
3233         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3234         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3235         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3236         to the list of iOS header search directories so that we can include header UIKitSPI.h.
3237         * DumpRenderTree/mac/DumpRenderTree.mm:
3238         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3239         * DumpRenderTree/mac/EventSendingController.mm:
3240         * DumpRenderTree/mac/TestRunnerMac.mm:
3241
3242 2015-01-07  Commit Queue  <commit-queue@webkit.org>
3243
3244         Unreviewed, rolling out r178068.
3245         https://bugs.webkit.org/show_bug.cgi?id=140235
3246
3247         Breaks the iOS build (Requested by enrica on #webkit).
3248
3249         Reverted changeset:
3250
3251         "[iOS] Make WebKit2 build with public iOS SDK and more build
3252         fixes for DRT"
3253         https://bugs.webkit.org/show_bug.cgi?id=137371
3254         http://trac.webkit.org/changeset/178068
3255
3256 2015-01-07  Daniel Bates  <dabates@apple.com>
3257
3258         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3259         https://bugs.webkit.org/show_bug.cgi?id=137371
3260
3261         Reviewed by David Kilzer.
3262
3263         Use SPI wrapper headers instead of directly referencing private SPI headers.
3264
3265         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3266         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3267         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3268         to the list of header search directories so that we can include header UIKitSPI.h.
3269         * DumpRenderTree/mac/DumpRenderTree.mm:
3270         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3271         * DumpRenderTree/mac/EventSendingController.mm:
3272         * DumpRenderTree/mac/TestRunnerMac.mm:
3273
3274 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
3275
3276         [Win] Unreviewed test change to improve run reproducibility
3277
3278         * Scripts/webkitpy/port/win.py:
3279         (WinPort.default_child_processes): Run a single DRT instance to help
3280         identify failures caused by earlier test runs.
3281
3282 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3283
3284         Myles C. Maxfield is a reviewer now
3285         https://bugs.webkit.org/show_bug.cgi?id=140196
3286
3287         Reviewed by Dean Jackson.
3288
3289         * Scripts/webkitpy/common/config/contributors.json:
3290
3291 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3292
3293         Make webkit-patch try harder to find keychain credentials
3294         https://bugs.webkit.org/show_bug.cgi?id=140170
3295
3296         Reviewed by Ryosuke Niwa.
3297
3298         When the user manually enters a password into webkit-patch, we hand that off to the
3299         Keyring Python module. However, that module creates a generic password entry instead
3300         of an internet password entry. We should look for both kinds.
3301
3302         * Scripts/webkitpy/common/net/credentials.py:
3303         (Credentials._run_security_tool):
3304         (Credentials._credentials_from_keychain):
3305         * Scripts/webkitpy/common/net/credentials_unittest.py:
3306         (test_security_output_parse_entry_not_found):
3307         (_assert_security_call):
3308
3309 2015-01-06  Anders Carlsson  <andersca@apple.com>
3310
3311         Try to fix the Mountain Lion build.
3312
3313         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3314         (TestWebKitAPI::didGetImageForMatchResult):
3315
3316 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
3317
3318         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
3319         https://bugs.webkit.org/show_bug.cgi?id=140095
3320
3321         Reviewed by Anders Carlsson.
3322
3323         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
3324         builds, but not in debug ones.
3325
3326 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
3327
3328         [Win] Extend WinLauncher with support for Page Zoom
3329         https://bugs.webkit.org/show_bug.cgi?id=140152
3330
3331         Reviewed by Anders Carlsson.
3332
3333         * WinLauncher/Common.cpp:
3334         (WndProc):
3335         * WinLauncher/WinLauncher.cpp:
3336         (WinLauncher::resetZoom):
3337         (WinLauncher::zoomIn):
3338         (WinLauncher::zoomOut):
3339         * WinLauncher/WinLauncher.h:
3340         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
3341         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3342         * win/DLLLauncher/DLLLauncherMain.cpp:
3343         (wWinMain):
3344
3345 2015-01-06  Anders Carlsson  <andersca@apple.com>
3346
3347         Fix API tests that are broken under HiDPI
3348         https://bugs.webkit.org/show_bug.cgi?id=140146
3349
3350         Reviewed by Tim Horton.
3351
3352         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3353         (TestWebKitAPI::didGetImageForMatchResult):
3354         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
3355
3356         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3357         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
3358         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
3359         out in a window that has a backing scale factor of 1.
3360  
3361         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3362         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
3363         Ditto.
3364
3365 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
3366
3367         ADDRESS_SANITIZER macro is overloaded
3368         https://bugs.webkit.org/show_bug.cgi?id=140130
3369
3370         Reviewed by Anders Carlsson.
3371
3372         * WebKitTestRunner/TestController.cpp: Use the new macro.
3373
3374 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
3375
3376         Remove some stale class names in check-for-inappropriate-objc-class-names
3377         https://bugs.webkit.org/show_bug.cgi?id=140104
3378
3379         Reviewed by Darin Adler.
3380
3381         * Scripts/check-for-inappropriate-objc-class-names:
3382         These UIWK* classes no longer exist.
3383
3384 2015-01-05  Anders Carlsson  <andersca@apple.com>
3385
3386         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
3387         https://bugs.webkit.org/show_bug.cgi?id=140096
3388         rdar://problem/19368938
3389
3390         Reviewed by Alexey Proskuryakov.
3391
3392         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
3393         since clientInfo points to a web view, not the test controller.
3394
3395         * WebKitTestRunner/TestController.cpp:
3396         (WTR::TestController::createOtherPage):
3397
3398 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
3399
3400         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
3401         https://bugs.webkit.org/show_bug.cgi?id=140077
3402
3403         Reviewed by Csaba Osztrogonác.
3404
3405         WebKit C SPI is available on EFL,GTK.
3406         Changed the define order to pass the API test.
3407
3408         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3409         (TestWebKitAPI::TEST):
3410
3411 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
3412
3413         Simplify WebKitTestRunner timeout tracking
3414         https://bugs.webkit.org/show_bug.cgi?id=140036
3415
3416         Reviewed by Darin Adler.
3417
3418         The code for configuring timeouts was mostly dead, because run-webkit-tests never
3419         passes the --timeout option to WebKitTestRunner.
3420
3421         * WebKitTestRunner/Options.h:
3422         * WebKitTestRunner/Options.cpp:
3423         (WTR::Options::Options):
3424         (WTR::OptionsHandler::OptionsHandler):
3425         (WTR::handleOptionTimeout): Deleted.
3426         Removed support for --timeout. Timeouts are passed for each test individually,
3427         and defaults are good enough for the rare cases where WebKitTestRunner is run
3428         manually without run-webkit-tests.
3429
3430         * WebKitTestRunner/TestController.cpp:
3431         (WTR::TestController::TestController):
3432         (WTR::TestController::initialize):
3433         (WTR::TestController::resetStateToConsistentValues):
3434         (WTR::TestController::reattachPageToWebProcess):
3435         (WTR::TestController::runUntil):
3436         * WebKitTestRunner/TestController.h:
3437         Simplified runUntil by passing the actual timeout, not an enum.
3438         Increased short timeout for ASan enabled builds, as WebProcess launching takes
3439         quite a while.
3440
3441         * WebKitTestRunner/TestInvocation.cpp:
3442         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
3443
3444         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3445         (WTR::TestController::platformRunUntil):
3446         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3447         (WTR::TestController::platformRunUntil):
3448         Build fixes.
3449
3450 2015-01-02  Anders Carlsson  <andersca@apple.com>
3451
3452         Remove now unused storage tracker glue from DumpRenderTree
3453         https://bugs.webkit.org/show_bug.cgi?id=140045
3454
3455         Reviewed by Darin Adler.
3456
3457         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3458         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
3459         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
3460         * DumpRenderTree/TestRunner.cpp:
3461         (TestRunner::staticFunctions):
3462         (syncLocalStorageCallback): Deleted.
3463         (observeStorageTrackerNotificationsCallback): Deleted.
3464         (deleteAllLocalStorageCallback): Deleted.
3465         (deleteLocalStorageForOriginCallback): Deleted.
3466         (localStorageDiskUsageForOriginCallback): Deleted.
3467         (originsWithLocalStorageCallback): Deleted.
3468         * DumpRenderTree/TestRunner.h:
3469         * DumpRenderTree/mac/DumpRenderTree.mm:
3470         (allocateGlobalControllers):
3471         (releaseGlobalControllers):
3472         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3473         * DumpRenderTree/mac/TestRunnerMac.mm:
3474         (TestRunner::syncLocalStorage): Deleted.
3475         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3476         (TestRunner::observeStorageTrackerNotifications): Deleted.
3477         (TestRunner::deleteAllLocalStorage): Deleted.
3478         (TestRunner::originsWithLocalStorage): Deleted.
3479         (TestRunner::deleteLocalStorageForOrigin): Deleted.
3480         * DumpRenderTree/win/TestRunnerWin.cpp:
3481         (TestRunner::syncLocalStorage): Deleted.
3482         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3483         (TestRunner::observeStorageTrackerNotifications): Deleted.
3484         (TestRunner::deleteAllLocalStorage): Deleted.
3485         (TestRunner::originsWithLocalStorage): Deleted.
3486         (TestRunner::deleteLocalStorageForOrigin): Deleted.
3487
3488 2015-01-01  Darin Adler  <darin@apple.com>
3489
3490         We often misspell identifier as "identifer"
3491         https://bugs.webkit.org/show_bug.cgi?id=140025
3492
3493         Reviewed by Michael Saboff.
3494
3495         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3496         * Scripts/webkitdirs.pm:
3497         (appIdentifierFromBundle):
3498         (installAndLaunchIOSWebKitAppInSimulator):
3499         Fix misspellings
3500
3501 2015-01-01  Zalan Bujtas  <zalan@apple.com>
3502
3503         Saturated arithmetics: Incorrect float/double clamping.
3504         https://bugs.webkit.org/show_bug.cgi?id=139888
3505         rdar://problem/19330885
3506
3507         Reviewed by Simon Fraser.
3508
3509         Clamp float and double values correctly when applying saturated arithmetics.
3510
3511         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3512         (TestWebKitAPI::TEST):
3513
3514 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
3515
3516         [EFL] Bump version of ATK used by jhbuild to 2.15.2
3517         https://bugs.webkit.org/show_bug.cgi?id=139816
3518
3519         Reviewed by Gyuyoung Kim.
3520
3521         Bump version of ATK used by jhbuild to 2.15.2
3522
3523         * efl/jhbuild.modules:
3524
3525 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
3526
3527         [jhBuild] cairo build error (-flto)
3528         https://bugs.webkit.org/show_bug.cgi?id=139056
3529
3530         Reviewed by Philippe Normand.
3531
3532         cairo fails to link  with gcc 4.9 due to lto
3533         related issue. This problem has been partially
3534         addressed by cairo:
3535         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
3536         use the cairo --disable-lto option and remove jhbuild
3537         makeargs fixes the issue.
3538
3539         * gtk/jhbuild.modules:
3540         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
3541
3542 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
3543         [Mac] Enable kerning, ligatures, and printer fonts 
3544         https://bugs.webkit.org/show_bug.cgi?id=139970
3545
3546         Rubber stamped by Simon Fraser.
3547
3548         Flip the switch.
3549
3550         * DumpRenderTree/mac/DumpRenderTree.mm:
3551         * WebKitTestRunner/TestController.cpp:
3552         * WebKitTestRunner/mac/main.mm:
3553
3554 2014-12-26  Dan Bernstein  <mitz@apple.com>
3555
3556         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
3557         https://bugs.webkit.org/show_bug.cgi?id=139950
3558
3559         Reviewed by David Kilzer.
3560
3561         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
3562         in a manner that works with Xcode 5.1.1.
3563
3564 2014-12-24  Dan Bernstein  <mitz@apple.com>
3565
3566         Engineering builds of MiniBrowser ignore deprecated declaration warnings
3567         https://bugs.webkit.org/show_bug.cgi?id=139941
3568
3569         Reviewed by Darin Adler.
3570
3571         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
3572         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
3573         to YES.
3574         * MiniBrowser/mac/AppDelegate.m:
3575         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
3576         deprecated NSOKButton.
3577
3578 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3579
3580         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
3581         https://bugs.webkit.org/show_bug.cgi?id=134763
3582
3583         Reviewed by Ryosuke Niwa.
3584
3585         Adding an option to disable test harness link conversion.
3586
3587         * Scripts/webkitpy/w3c/test_converter.py:
3588         (convert_for_webkit):
3589         (_W3CTestConverter.__init__):
3590         (_W3CTestConverter.convert_attributes_if_needed):
3591         * Scripts/webkitpy/w3c/test_importer.py:
3592         (parse_args):
3593         (TestImporter.import_tests):
3594
3595 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3596
3597         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
3598         https://bugs.webkit.org/show_bug.cgi?id=139933
3599
3600         Reviewed by Daniel Bates.
3601
3602         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
3603         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
3604         until ReportCrash lets it go.
3605
3606         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
3607         even get the actual crash log eventually - even when it times out waiting for the log, it
3608         makes a second lookup at the very end, after all tests finish. There may be further
3609         improvements needed here, but this small fix addresses most cases that happen in practice.
3610
3611         * DumpRenderTree/mac/DumpRenderTree.mm:
3612         (writeCrashedMessageOnFatalError):
3613         (dumpRenderTree):
3614         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
3615
3616         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
3617         unhelpful comment.
3618
3619 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3620
3621         Don't force -O1 for debug ASan builds
3622         https://bugs.webkit.org/show_bug.cgi?id=139926
3623
3624         Reviewed by Darin Adler.
3625
3626         * asan/asan.xcconfig:
3627
3628 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3629
3630         Simplify building with ASan
3631         https://bugs.webkit.org/show_bug.cgi?id=139916
3632
3633         Reviewed by Mark Rowe.
3634
3635         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
3636         We could also update Configuration file format, but that's a little scary because
3637         of how many places in code read it.
3638
3639         * Scripts/webkitdirs.pm:
3640         (determineASanIsEnabled): Read it from ASan configuration file.
3641         (argumentsForConfiguration): Added a FIXME.
3642         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
3643         (XcodeOptions): Pass the options needed for ASan.
3644
3645         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
3646         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
3647         that automatically.
3648
3649 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3650
3651         TestWebKitAPI build is broken when ASan is enabled
3652         https://bugs.webkit.org/show_bug.cgi?id=139902
3653
3654         Reviewed by Darin Adler.