1 2015-02-17 Myles C. Maxfield <mmaxfield@apple.com>
3 Windows test results should not fall back to mac-mountainlion after r180176
4 https://bugs.webkit.org/show_bug.cgi?id=141719
6 Reviewed by Brent Fulgham.
8 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
9 (_should_file_trigger_build):
10 * Scripts/webkitpy/port/win.py:
11 (WinPort.default_baseline_search_path):
12 * Scripts/webkitpy/port/win_unittest.py:
13 (WinPortTest.test_baseline_search_path):
15 2015-02-17 Daniel Bates <dabates@apple.com>
17 [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
18 https://bugs.webkit.org/show_bug.cgi?id=141718
20 Reviewed by Alex Christensen.
22 We should only run layout tests if simctl can successfully boot and shutdown the testing device.
24 * Scripts/webkitpy/port/ios.py:
25 (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
26 Log a error and return False if we are unable to boot the simulator device so that the caller can take
27 appropriate action, say exit(3) before running any layout tests.
28 * Scripts/webkitpy/xcode/simulator.py:
29 (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
30 with the specified UDID.
31 (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
32 with the specified UDID can successfully boot and shut down. We make at most two attempts to
33 boot and shut down the device, erasing the device between tries so as to restore the device
34 to a known good state.
36 2015-02-17 Daniel Bates <dabates@apple.com>
38 run_webkit_tests.py should not know about iOS Simulator details
39 https://bugs.webkit.org/show_bug.cgi?id=141711
41 Reviewed by Alex Christensen.
43 Run_webkit_tests.py should only parse the iOS-specific command
44 line options --runtime and --device-type. Let the port-specific
45 logic in ios.py validate the parsed options and instantiate
46 internal data structures.
48 Currently run_webkit_tests.py parses the iOS-specific command
49 line options --runtime and --device-type, validates them, and
50 instantiates internal data structures from the parsed strings.
51 Instead the validation logic and instantiation of internal
52 data structures should be handled by the iOS port object.
54 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
55 (_set_up_derived_options): Remove logic to validate --runtime and --device-type
56 and instantiate internal data structures for them.
57 * Scripts/webkitpy/port/driver.py:
58 (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
59 and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
61 * Scripts/webkitpy/port/ios.py: Sort the list of imports.
62 (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
63 object from --runtime, if specified. Otherwise, instantiates a Runtime
64 object for the latest installed iphonesimulator SDK version.
65 (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
66 object from --device-type, if specified. Otherwise, instantiates
67 a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
68 machine, respectively.
69 (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
70 runtime is available to use.
71 (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
72 and simulator_runtime for the iOS Simulator device type and runtime, respectively.
73 * Scripts/webkitpy/xcode/simulator.py:
74 (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
75 with a runtime identifier for the specified iOS version.
77 2015-02-17 Dana Burkart <dburkart@apple.com>
79 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
80 https://bugs.webkit.org/show_bug.cgi?id=141672
82 Reviewed by David Kilzer.
84 * asan/webkit-asan-ignore.txt:
86 2015-02-17 Alex Christensen <achristensen@webkit.org>
88 Remove WebCore.exp.in and clean up.
89 https://bugs.webkit.org/show_bug.cgi?id=141491
91 Reviewed by Andreas Kling.
93 * Scripts/sort-export-file: Removed.
94 * Scripts/webkitpy/style/checker.py:
97 (CheckerDispatcher._file_type):
98 (CheckerDispatcher._create_checker):
99 Don't check if the export files are sorted.
100 * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
101 * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
103 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
105 Unreviewed. Fix GTK+ make distcheck.
107 Do not exclude bmalloc directory from the tarball.
109 * gtk/manifest.txt.in:
111 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
113 Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
115 I forgot to add the return of a bool function.
117 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
118 (WebKitDOMNodeTest::testDOMCache):
120 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
122 [GTK] GObject DOM bindings object are cached forever
123 https://bugs.webkit.org/show_bug.cgi?id=141558
125 Reviewed by Sergio Villar Senin.
127 Add checks for all DOM objects to ensure they are not leaked. Also
128 add a dedicated test for the DOM Object Cache.
130 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
131 (WebKitDOMNodeFilterTest::testTreeWalker):
132 (WebKitDOMNodeFilterTest::testNodeIterator):
133 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
134 (WebKitDOMNodeTest::testHierarchyNavigation):
135 (WebKitDOMNodeTest::testInsertion):
136 (WebKitDOMNodeTest::testTagNames):
137 (WebKitDOMNodeTest::testDOMCache):
139 * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
140 (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
141 (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
142 (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
143 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
144 (testWebKitDOMObjectCache):
146 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
147 (documentLoadedCallback):
149 2015-02-16 Carlos Garcia Campos <cgarcia@igalia.com>
151 [GTK] WebKitFrame objects are never released
152 https://bugs.webkit.org/show_bug.cgi?id=141641
154 Reviewed by Martin Robinson.
156 Add a way to check GObjects leaks for WebProcess tests and check
157 WebKitFrame objects are not leaked.
159 * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
160 (WebKitFrameTest::testMainFrame):
161 (WebKitFrameTest::testURI):
162 (WebKitFrameTest::testJavaScriptContext):
163 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
164 (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
166 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
168 2015-02-16 Tim Horton <timothy_horton@apple.com>
170 Fix the MiniBrowser build with newer clang
172 * MiniBrowser/mac/SettingsController.m:
173 (-[SettingsController _toggleBooleanDefault:]):
174 * MiniBrowser/mac/WK1BrowserWindowController.m:
175 (-[WK1BrowserWindowController windowWillClose:]):
176 * MiniBrowser/mac/WK2BrowserWindowController.m:
177 (-[WK2BrowserWindowController windowWillClose:]):
178 NSApp is id and clang gets confused about which -delegate we're talking about.
180 2015-02-16 Antti Koivisto <antti@apple.com>
182 Develop/Disable Caches does not properly disable disk cache
183 https://bugs.webkit.org/show_bug.cgi?id=141636
185 Reviewed by Anders Carlsson.
187 Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
188 the network process too.
190 This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
192 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
193 (WTR::InjectedBundle::beginTesting):
194 (WTR::InjectedBundle::setCacheModel):
195 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
196 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
198 Forward to TestController.
200 (WTR::TestRunner::setCacheModel):
201 * WebKitTestRunner/TestInvocation.cpp:
202 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
204 2015-02-16 Andrzej Badowski <a.badowski@samsung.com>
206 Unreviewed. Add myself as a committer.
208 * Scripts/webkitpy/common/config/contributors.json:
210 2015-02-15 David Kilzer <ddkilzer@apple.com>
212 REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
213 <http://webkit.org/b/141607>
215 * Scripts/check-for-weak-vtables-and-externals: Ignore weak
216 externals in Source/WebCore/Configurations/WebCore.unexp when
217 building with Xcode 5.x.
218 (readXcode5SymbolsToIgnore): Add.
220 2015-02-15 KwangHyuk Kim <hyuki.kim@samsung.com>
222 [EFL] fix Evas GL engine error.
223 https://bugs.webkit.org/show_bug.cgi?id=141621
225 Reviewed by Gyuyoung Kim.
227 As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
229 * MiniBrowser/efl/main.c:
232 2015-02-14 Csaba Osztrogonác <ossy@webkit.org>
234 [buildbot] Enable run-api-tests on release Mac bots
235 https://bugs.webkit.org/show_bug.cgi?id=141518
237 Reviewed by Darin Adler.
239 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
241 (BuildFactory.__init__):
242 (TestFactory.__init__):
243 (BuildAndTestFactory.__init__):
244 (RunUnitTests.start): Deleted.
245 (unitTestsSupported): Deleted.
247 2015-02-13 Anders Carlsson <andersca@apple.com>
249 Add a move constructor and move assignment operator to Deque
250 https://bugs.webkit.org/show_bug.cgi?id=141571
252 Reviewed by Andreas Kling.
254 * TestWebKitAPI/Tests/WTF/Deque.cpp:
255 (TestWebKitAPI::TEST):
257 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
259 run-jsc-stress-tests --remote should skip profiler tests
260 https://bugs.webkit.org/show_bug.cgi?id=141470
262 Reviewed by Filip Pizlo.
264 * Scripts/run-jsc-stress-tests:
266 2015-02-13 Anders Carlsson <andersca@apple.com>
268 Add an initializer list constructor to Deque
269 https://bugs.webkit.org/show_bug.cgi?id=141565
271 Reviewed by Andreas Kling.
273 * TestWebKitAPI/Tests/WTF/Deque.cpp:
274 (TestWebKitAPI::TEST):
276 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
278 [buildbot] Remove buildJSCTool cruft from master.cfg
279 https://bugs.webkit.org/show_bug.cgi?id=141513
281 Reviewed by Alexey Proskuryakov.
283 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
284 (RunJavaScriptCoreTests):
285 (RunJavaScriptCoreTests.start):
287 (RunWebKitTests.start):
288 (TestFactory.__init__):
289 (TestLeaksFactory.__init__):
290 (RunJavaScriptCoreTests.__init__): Deleted.
291 (RunWebKitTests.__init__): Deleted.
293 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
295 Unreviewed, remove empty directories.
297 * DumpRenderTree/gtk: Removed.
298 * DumpRenderTree/gtk/fonts: Removed.
299 * DumpRenderTree/unix: Removed.
300 * DumpRenderTree/unix/TestNetscapePlugin: Removed.
301 * GtkLauncher: Removed.
302 * TestWebKitAPI/Tests/WebKitGtk: Removed.
303 * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
304 * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
305 * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
307 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
309 Remove Windows cruft from Tools/Scripts/build-webkittestrunner
310 https://bugs.webkit.org/show_bug.cgi?id=141519
312 Reviewed by Alexey Proskuryakov.
314 * Scripts/build-webkittestrunner:
316 2015-02-12 Alex Christensen <achristensen@webkit.org>
318 Removed empty directory.
320 * WinCELauncher: Removed.
322 2015-02-12 Csaba Osztrogonác <ossy@webkit.org>
324 run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
325 https://bugs.webkit.org/show_bug.cgi?id=141202
327 Reviewed by Darin Adler.
329 * Scripts/run-jsc-stress-tests:
331 2015-02-12 Brent Fulgham <bfulgham@apple.com>
333 [Win] Test bot infrastructure should not try to find/use old Safari DLLs
334 https://bugs.webkit.org/show_bug.cgi?id=141517
336 Reviewed by Anders Carlsson.
338 We do not need to locate or use the DLL's that came with Safari, so stop
339 failing when we cannot find them. Also remove some old Qt cruft from this
342 * BuildSlaveSupport/built-product-archive:
343 (archiveBuiltProduct):
344 (extractBuiltProduct):
346 2015-02-11 Brent Fulgham <bfulgham@apple.com>
348 [Win] [64-bit] Work around MSVC2013 Runtime Bug
349 https://bugs.webkit.org/show_bug.cgi?id=141498
350 <rdar://problem/19803642>
352 Reviewed by Anders Carlsson.
354 Disable FMA3 instruction use in the MSVC math library to
355 work around a VS2013 runtime crash. We can remove this
356 workaround when we switch to VS2015.
358 * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
359 disable FMA3 support.
360 * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
361 * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
362 * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
363 * Scripts/webkitperl/httpd.pm: Ditto.
364 * TestWebKitAPI/win/main.cpp: Ditto.
365 * WinLauncher/Common.cpp: Ditto.
366 * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
368 2015-02-12 Csaba Osztrogonác <ossy@webkit.org>
370 run-jsc-stress-tests should accept remote host config from JSON file
371 https://bugs.webkit.org/show_bug.cgi?id=141509
373 Reviewed by Michael Saboff.
375 * Scripts/run-javascriptcore-tests:
377 * Scripts/run-jsc-stress-tests:
379 2015-02-12 Carlos Garcia Campos <cgarcia@igalia.com>
381 [GTK] Add API to allow overriding the default color chooser implementation
382 https://bugs.webkit.org/show_bug.cgi?id=98935
384 Reviewed by Gustavo Noronha Silva.
386 Add a color chooser implementation for MiniBrowser using
387 GtkPopover when the GTK+ version is recent enough.
388 And a test case to check the new color chooser API.
390 * MiniBrowser/gtk/BrowserWindow.c:
391 (colorChooserRGBAChanged):
392 (popoverColorClosed):
393 (colorChooserRequestFinished):
394 (runColorChooserCallback):
395 (browserWindowConstructed):
396 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
397 (testWebViewColorChooserRequest):
400 2015-02-11 Csaba Osztrogonác <ossy@webkit.org>
402 Make run-jsc-stress-tests --remote work with make-based runner
403 https://bugs.webkit.org/show_bug.cgi?id=141079
405 Reviewed by Darin Adler.
407 * Scripts/run-javascriptcore-tests:
408 (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
409 * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
410 except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
411 to avoid code duplication.
413 2015-02-11 Csaba Osztrogonác <ossy@webkit.org>
415 run-jsc-stress tests should detect the number of processors on the remote machine too
416 https://bugs.webkit.org/show_bug.cgi?id=141196
418 Reviewed by Darin Adler.
420 * Scripts/run-javascriptcore-tests:
421 (runJSCStressTests): Pass through the --child-processes argument.
422 * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
423 to detect the number of local and remote processors with the same algorithm.
424 Additionally introduced $numChildProcesses to emphasize it isn't necessarily
425 same as $numProcessors.
427 2015-02-11 Csaba Osztrogonác <ossy@webkit.org>
429 run-jsc-stress-tests should pass JSC_timeout to remote hosts
430 https://bugs.webkit.org/show_bug.cgi?id=141164
432 Reviewed by Darin Adler.
434 Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
436 * Scripts/run-jsc-stress-tests:
438 2015-02-11 Carlos Garcia Campos <cgarcia@igalia.com>
440 [GTK] Add default color chooser implementation using GtkColorChooserDialog
441 https://bugs.webkit.org/show_bug.cgi?id=141392
443 Reviewed by Gustavo Noronha Silva.
445 Enable INPUT_TYPE_COLOR by default for GTK+ port.
447 * Scripts/webkitperl/FeatureList.pm:
449 2015-02-09 Csaba Osztrogonác <ossy@webkit.org>
451 run-jsc-stress-tests shell test runner should run tests in fixed order
452 https://bugs.webkit.org/show_bug.cgi?id=141383
454 Reviewed by Darin Adler.
456 * Scripts/jsc-stress-test-helpers/shell-runner.sh:
458 2015-02-08 Chris Fleizach <cfleizach@apple.com>
460 AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
461 https://bugs.webkit.org/show_bug.cgi?id=140485
463 Reviewed by Anders Carlsson.
465 Implement takeFocus() as a way to set focus through accessibility wrappers.
467 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
468 (AccessibilityUIElement::takeFocus):
469 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
470 (WTR::AccessibilityUIElement::takeFocus):
472 2015-02-08 Darin Adler <darin@apple.com>
474 Remove the SVG instance tree
475 https://bugs.webkit.org/show_bug.cgi?id=140602
477 Reviewed by Dean Jackson.
479 * Scripts/check-for-global-initializers: Removed special case for
480 SVGElementInstance.o.
482 2015-02-07 David Kilzer <ddkilzer@apple.com>
484 [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
485 <http://webkit.org/b/141365>
487 Reviewed by Daniel Bates.
489 * Scripts/webkitpy/xcode/simulator.py:
490 (Simulator): Add unavailable_version_re precompiled regex.
491 (Simulator._parse_devices): Check for unavailable versions and
492 ignore them if found when parsing the output of
494 * Scripts/webkitpy/xcode/simulator_unittest.py:
495 (test_unavailable_devices): Add test with output from
496 `xcrun simctl list` with unavailable runtimes that fails before
499 2015-02-07 Chris Dumez <cdumez@apple.com>
501 Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
502 https://bugs.webkit.org/show_bug.cgi?id=141321
504 Reviewed by Darin Adler.
506 Use new Vector::removeFirstMatching() / removeAllMatching() methods.
508 2015-02-07 David Kilzer <ddkilzer@apple.com>
510 [iOS] Make Simulator class testable
511 <http://webkit.org/b/141358>
513 Rubber-stamped by Darin Adler.
515 * Scripts/webkitpy/common/system/platforminfo.py:
516 (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
517 command to here from Simulator.refresh() in xcode/simulator.py
518 so that the output of the command can be mocked.
520 * Scripts/webkitpy/common/system/platforminfo_mock.py:
521 (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
523 (MockPlatformInfo.xcode_simctl_list): Add method that returns
524 self.expected_xcode_simctl_list expectation.
526 * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
528 (Simulator.__init__): Add optional 'host' parameter to make it
529 possible to pass in a mock object for testing. Set self._host
530 to 'host' parameter or create Host() object.
531 (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
534 * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
537 (SimulatorTest.setUp):
538 (SimulatorTest._set_expected_xcrun_simctl_list):
539 (SimulatorTest.test_simulator_device_types):
540 (test_invalid_device_types_header):
541 (test_invalid_runtimes_header):
542 (test_invalid_devices_header):
544 2015-02-07 Csaba Osztrogonác <ossy@webkit.org>
546 run-jsc-stress-tests --remote should use the default ssh port
547 https://bugs.webkit.org/show_bug.cgi?id=141287
549 Reviewed by Darin Adler.
551 * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
553 2015-02-06 Dana Burkart <dburkart@apple.com>
555 dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
556 https://bugs.webkit.org/show_bug.cgi?id=141349
558 Reviewed by Alexey Proskuryakov.
560 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
561 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
562 (BuildbotTesterQueueView.prototype.update):
564 2015-02-06 Alexey Proskuryakov <ap@apple.com>
566 Report network process crashes during layout tests
567 https://bugs.webkit.org/show_bug.cgi?id=139646
569 Reviewed by Anders Carlsson.
571 * WebKitTestRunner/TestController.cpp:
572 (WTR::TestController::initialize):
573 (WTR::TestController::networkProcessName):
574 (WTR::TestController::networkProcessDidCrash):
575 * WebKitTestRunner/TestController.h:
577 2015-02-06 Csaba Osztrogonác <ossy@webkit.org>
579 run-jsc-stress-tests --remote should create remote directory before copying the bundle
580 https://bugs.webkit.org/show_bug.cgi?id=141329
582 Reviewed by Michael Saboff.
584 * Scripts/run-jsc-stress-tests:
586 2015-02-06 Carlos Garcia Campos <cgarcia@igalia.com>
588 [GTK] Remove WebKitWebView::close-notification signal
589 https://bugs.webkit.org/show_bug.cgi?id=141330
591 Reviewed by Gustavo Noronha Silva.
593 Update notifications unit tests according to the API changes, and
594 add a test case to check that onclose event is fired when a
595 notification is closed by the user.
597 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
598 (testWebViewNotification):
600 2015-02-05 Alexey Proskuryakov <ap@apple.com>
602 Dashboard doesn't consider building ASan a productive step
603 https://bugs.webkit.org/show_bug.cgi?id=141312
605 Reviewed by Simon Fraser.
607 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
609 2015-02-05 Daniel Bates <dabates@apple.com>
611 [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
612 https://bugs.webkit.org/show_bug.cgi?id=141306
614 Reviewed by Alexey Proskuryakov.
616 The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
617 corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
620 * Scripts/webkitpy/xcode/simulator.py:
621 (Runtime.from_identifier):
623 2015-02-05 Daniel Bates <dabates@apple.com>
625 LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
626 https://bugs.webkit.org/show_bug.cgi?id=139746
627 <rdar://problem/19283658>
629 Reviewed by Alexey Proskuryakov.
631 Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
632 if the simulator device is not in state Booted.
634 Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
635 launching/relaunching the iOS Simulator app and a simulator app can only be installed
636 on a device that is in the Booted state. LayoutTestRelay may run before the
637 device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
638 We should defer executing LayoutTestRelay until the simulator device booted by
639 iOS Simulator is in the Booted state.
641 * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
642 Simulator methods with the module name, simulator.
643 (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
644 after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
645 before launching iOS Simulator to boot it.
646 (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
647 (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
648 * Scripts/webkitpy/xcode/simulator.py:
649 (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
650 the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
651 interested in the state of the device are more likely interested in the current state of the device as
652 opposed to the state of the device when the Device object was created.
653 (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
654 (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
655 from both this function and Simulator.device_state().
656 (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
657 (Simulator.DeviceState): Added; class of constants.
658 (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
659 device is in the specified state.
660 (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
661 (Simulator.device_directory): Added.
662 (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
664 2015-02-05 Alexey Proskuryakov <ap@apple.com>
666 Disable retries on Mac debug testers
667 https://bugs.webkit.org/show_bug.cgi?id=141296
669 Reviewed by Simon Fraser.
671 * BuildSlaveSupport/build.webkit.org-config/config.json:
673 2015-02-05 Dan Bernstein <mitz@apple.com>
675 Need a way to force $xcodeSDK in webkitdirs.pm
676 https://bugs.webkit.org/show_bug.cgi?id=141291
678 Reviewed by Anders Carlsson.
680 * Scripts/webkitdirs.pm:
681 (setXcodeSDK): Added.
683 2015-02-05 Youenn Fablet <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
685 [Streams API] Implement a barebone ReadableStream interface
686 https://bugs.webkit.org/show_bug.cgi?id=141045
688 Reviewed by Benjamin Poulain.
690 * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
692 2015-02-04 Joseph Pecoraro <pecoraro@apple.com>
694 filter-build-webkit: reduce more unfiltered output
695 https://bugs.webkit.org/show_bug.cgi?id=141282
697 Reviewed by Daniel Bates.
699 * Scripts/filter-build-webkit:
700 Report CompileDTraceScript and Preprocess lines as successful.
702 2015-02-04 Dana Burkart <dburkart@apple.com>
704 Botwatcher's Dashboard is cramped
705 https://bugs.webkit.org/show_bug.cgi?id=140273
707 Reviewed by Alexey Proskuryakov.
709 Add a heading key which will allow for arbitrary headings in builder queues.
711 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
712 (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
713 (BuildbotBuilderQueueView.prototype.update):
714 (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
715 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
716 (BuildbotIteration.prototype._parseData):
717 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
718 (BuildbotLeaksQueueView.prototype.update):
719 (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
720 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
721 (BuildbotPerformanceQueueView.prototype.update):
722 (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
723 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
725 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
726 (BuildbotQueueView.prototype._unauthorizedAccess):
727 (BuildbotQueueView.prototype._appendBuild):
728 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
729 (BuildbotTestResults):
730 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
731 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
732 (BuildbotTesterQueueView.prototype.update):
733 (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
735 2015-02-04 Simon Fraser <simon.fraser@apple.com>
737 WKTR should not use -mainScreen to pick a color profile
738 https://bugs.webkit.org/show_bug.cgi?id=141265
740 Reviewed by Tim Horton.
742 -[NSScreen mainScreen] depends on the active window, so use the first screen
743 (which is the one we put the window on anyway).
745 Do some cleanup in DRT that makes the code look similar.
747 * DumpRenderTree/mac/DumpRenderTree.mm:
748 (createWebViewAndOffscreenWindow):
749 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
750 (WTR::PlatformWebView::PlatformWebView):
752 2015-02-04 Simon Fraser <simon.fraser@apple.com>
754 LayoutTestHelper should set the color profile of all displays
755 https://bugs.webkit.org/show_bug.cgi?id=141260
757 Reviewed by Tim Horton.
759 WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
760 which is the screen with the active window. Make things more robust by changing
761 the colorspace of all displays, not just the main screen, when running layout tests.
763 * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
764 * DumpRenderTree/mac/LayoutTestHelper.m:
765 (originalColorProfileURLs):
766 (colorProfileURLForDisplay):
767 (displayUUIDStrings):
768 (saveDisplayColorProfiles):
769 (setDisplayColorProfile):
770 (restoreDisplayColorProfiles):
771 (installLayoutTestColorProfile):
772 (restoreUserColorProfile):
774 Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
775 toll-free bridged, sadly). Use the map to restore all profiles on exit.
776 Convert to use more Obj-C types.
778 2015-02-04 Daniel Bates <dabates@apple.com>
780 test-webkitpy fails on Mac without iphoneos SDK
781 https://bugs.webkit.org/show_bug.cgi?id=141255
782 <rdar://problem/19619691>
784 I inadvertently committed the wrong exception message. Fix up the exception message
785 to instruct a person to install the iOS SDK when it cannot be found.
787 * Scripts/webkitpy/port/ios.py:
788 (IOSPort.determine_full_port_name):
790 2015-02-04 Youenn Fablet <youenn.fablet@crf.canon.fr>
792 W3C test importer should sort the list of files when generating the w3c-import.log
793 https://bugs.webkit.org/show_bug.cgi?id=141156
795 Reviewed by Bem Jones-Bey.
797 Sort explicitly the list of imported files written in the w3c-import.log.
798 Removed logging of the import date.
800 * Scripts/webkitpy/w3c/test_importer.py:
801 (TestImporter.write_import_log):
803 2015-02-04 Daniel Bates <dabates@apple.com>
805 test-webkitpy fails on Mac without iphoneos SDK
806 https://bugs.webkit.org/show_bug.cgi?id=141255
807 <rdar://problem/19619691>
809 Reviewed by David Kilzer and Alexey Proskuryakov.
811 Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
812 should not require the iphoneos SDK to be installed to run the webkitpy tests.
814 * Scripts/webkitpy/common/system/platforminfo.py:
815 (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
816 installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
817 to standard output if the SDK is installed to return the empty string if the SDK is
819 * Scripts/webkitpy/common/system/platforminfo_mock.py:
820 (MockPlatformInfo.xcode_sdk_version): Added.
821 * Scripts/webkitpy/port/ios.py:
822 (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
823 to get the version of the iphoneos SDK, if installed.
825 2015-02-04 Alexey Proskuryakov <ap@apple.com>
827 run-webkit-tests doesn't always capture ASan violation reports
828 https://bugs.webkit.org/show_bug.cgi?id=141231
830 Reviewed by Darin Adler.
832 * Scripts/webkitpy/port/driver.py:
833 (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
834 by the driver already (as is the case with ASan violations, which are printed to
836 (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
838 (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
839 a separate variable for reporting.
841 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
843 [webkitpy] Add platform specific Skipped file mechanism for performance tests
844 https://bugs.webkit.org/show_bug.cgi?id=141152
846 Reviewed by Csaba Osztrogonác.
848 Support a test-expectation-like syntax in performance tests' skipped files.
849 e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
851 * Scripts/webkitpy/port/base.py:
852 (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
854 * Scripts/webkitpy/port/base_unittest.py:
855 (PortTest.test_skipped_perf_tests): Test the new syntax.
857 2015-02-04 Alexey Proskuryakov <ap@apple.com>
859 When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
860 https://bugs.webkit.org/show_bug.cgi?id=141236
862 Reviewed by Sam Weinig.
864 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
865 (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
867 2015-02-04 Chris Dumez <cdumez@apple.com>
869 Add removeFirst(value) / removeAll(value) methods to WTF::Vector
870 https://bugs.webkit.org/show_bug.cgi?id=141192
872 Reviewed by Benjamin Poulain.
874 Add API tests for Vector::removeFirst(value) and
875 Vector::removeAll(value).
877 * TestWebKitAPI/Tests/WTF/Vector.cpp:
878 (TestWebKitAPI::TEST):
880 2015-02-03 Tim Horton <timothy_horton@apple.com>
882 Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
883 https://bugs.webkit.org/show_bug.cgi?id=141217
885 Reviewed by Sam Weinig.
887 * WebKitTestRunner/TestController.cpp:
888 (WTR::copyWebCryptoMasterKey):
889 (WTR::TestController::createOtherPage):
890 (WTR::TestController::createWebViewWithOptions):
891 (WTR::TestController::ensureViewSupportsOptions):
892 (WTR::TestController::didCommitNavigation):
893 (WTR::TestController::didFinishNavigation):
894 (WTR::TestController::canAuthenticateAgainstProtectionSpace):
895 (WTR::TestController::didReceiveAuthenticationChallenge):
896 (WTR::TestController::decidePolicyForPluginLoad):
897 (WTR::TestController::decidePolicyForNavigationAction):
898 (WTR::TestController::decidePolicyForNavigationResponse):
899 (WTR::TestController::didCommitLoadForFrame): Deleted.
900 (WTR::TestController::didFinishLoadForFrame): Deleted.
901 * WebKitTestRunner/TestController.h:
902 Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
904 2015-02-03 Dhi Aurrahman <diorahman@rockybars.com>
906 Unreviewed. Add myself as a committer.
908 * Scripts/webkitpy/common/config/contributors.json:
910 2015-02-03 Brent Fulgham <bfulgham@apple.com>
912 [Win] Unreviewed test fix.
914 * DumpRenderTree/win/PolicyDelegate.cpp:
915 (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
916 so was not matching expected output.
918 2015-02-03 Youenn Fablet <youenn.fablet@crf.canon.fr>
920 Unreviewed. Moving myself to the committer section at last.
922 * Scripts/webkitpy/common/config/contributors.json:
924 2015-02-03 Brent Fulgham <bfulgham@apple.com>
926 [Win] Tests fail because DRT reports '(null)' instead of an empty string
927 https://bugs.webkit.org/show_bug.cgi?id=141205
929 Reviewed by Anders Carlsson.
931 * DumpRenderTree/win/HistoryDelegate.cpp:
932 (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
933 properly so that we match expected DumpRenderTree output.
935 2015-02-03 Michael Catanzaro <mcatanzaro@igalia.com>
937 [GTK] TestWebKitAccessibility is not skipped
938 https://bugs.webkit.org/show_bug.cgi?id=141179
940 Reviewed by Carlos Garcia Campos.
942 Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
943 skipped, and it apparently works reliably on the bots.
945 * Scripts/run-gtk-tests:
948 2015-02-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
950 run-perf-tests: allow to specify a wrapper command.
951 https://bugs.webkit.org/show_bug.cgi?id=141172
953 Reviewed by Ryosuke Niwa.
955 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
956 (parse_args): Update text to indicate is also valid for WTR.
957 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
958 (PerfTestsRunner._parse_args): Add wrapper command.
960 2015-02-03 Brent Fulgham <bfulgham@apple.com>
962 [Win] Correct version parsing warning in update-webkit
963 https://bugs.webkit.org/show_bug.cgi?id=141200
965 Reviewed by Anders Carlsson.
967 * Scripts/webkitdirs.pm:
968 (setupAppleWinEnv): Strip out any specific version build level
969 from the Cygwin version information.
972 2015-02-03 Brent Fulgham <bfulgham@apple.com>
974 [Win] Attempt to improve the reliability of HTTP service
975 https://bugs.webkit.org/show_bug.cgi?id=141191
977 Reviewed by Darin Adler.
979 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
980 (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
981 (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
982 when stopping the service doesn't do so on its own (for Windows runs).
984 2015-02-03 Youenn Fablet <youenn.fablet@crf.canon.fr>
986 Web platform test server should not need to create __init__.py files
987 https://bugs.webkit.org/show_bug.cgi?id=141030
989 Reviewed by Ryosuke Niwa.
991 W3C TestImporter ensures that copied __init__.py files are not empty.
992 If needed, a comment is inserted in __init__.py files.
993 Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
995 * Scripts/webkitpy/common/system/filesystem.py:
996 (FileSystem.getsize):
997 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
998 (TestWebPlatformTestServer.test_start_cmd):
999 (TestWebPlatformTestServer):
1000 (TestWebPlatformTestServer.test_import_web_platform_test_modules):
1001 * Scripts/webkitpy/w3c/test_importer.py:
1002 (TestImporter.import_tests):
1004 2015-01-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
1006 Unreviewed. Moving myself to the committer section.
1008 * Scripts/webkitpy/common/config/contributors.json:
1010 2015-02-02 Saam Barati <saambarati1@gmail.com>
1012 Create tests for JSC's Control Flow Profiler
1013 https://bugs.webkit.org/show_bug.cgi?id=141123
1015 Reviewed by Filip Pizlo.
1017 * Scripts/run-javascriptcore-tests:
1018 (runJSCStressTests):
1019 * Scripts/run-jsc-stress-tests:
1021 2015-02-02 Csaba Osztrogonác <ossy@webkit.org>
1023 Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
1024 https://bugs.webkit.org/show_bug.cgi?id=141158
1026 Reviewed by Darin Adler.
1028 * Scripts/run-jsc-stress-tests:
1030 2015-02-02 Michael Catanzaro <mcatanzaro@igalia.com>
1032 [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
1033 https://bugs.webkit.org/show_bug.cgi?id=141142
1035 Reviewed by Carlos Garcia Campos.
1037 * MiniBrowser/gtk/BrowserWindow.c:
1038 (browser_window_init): Quit on Ctrl+W or Ctrl+Q
1040 2015-02-01 Youenn Fablet <youenn.fablet@crf.canon.fr>
1042 Web platform test server is not always launching properly on Mac EWS bots
1043 https://bugs.webkit.org/show_bug.cgi?id=141141
1047 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1048 (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
1050 2015-01-31 Sam Weinig <sam@webkit.org>
1052 Remove even more Mountain Lion support
1053 https://bugs.webkit.org/show_bug.cgi?id=141124
1055 Reviewed by Alexey Proskuryakov.
1057 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1058 (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1059 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1060 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1061 * DumpRenderTree/mac/DumpRenderTree.mm:
1062 (activateTestingFonts):
1063 (prepareConsistentTestingEnvironment):
1064 * DumpRenderTree/mac/EventSendingController.mm:
1065 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1066 (-[EventSendingController contextClick]):
1067 * DumpRenderTree/mac/TextInputController.m:
1068 * LayoutTestRelay/Configurations/Base.xcconfig:
1069 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1070 * MiniBrowser/Configurations/Base.xcconfig:
1071 * MiniBrowser/Configurations/DebugRelease.xcconfig:
1072 * MiniBrowser/mac/WK2BrowserWindowController.m:
1073 (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1074 (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1075 (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
1076 * TestWebKitAPI/Configurations/Base.xcconfig:
1077 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1078 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1079 (-[DownloadDelegate _downloadDidFinish:]):
1080 * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1081 (TestWebKitAPI::TEST):
1082 * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1083 (TestWebKitAPI::InjectedBundleController::platformInitialize):
1084 * WebKitLauncher/Configurations/Base.xcconfig:
1085 * WebKitTestRunner/Configurations/Base.xcconfig:
1086 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1087 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1088 (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1089 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1090 (WTR::activateFonts):
1091 * WebKitTestRunner/TestController.cpp:
1092 (WTR::TestController::initialize):
1093 (WTR::TestController::webProcessName):
1094 * WebKitTestRunner/mac/EventSenderProxy.mm:
1095 * asan/asan.xcconfig:
1097 2015-01-31 Commit Queue <commit-queue@webkit.org>
1099 Unreviewed, rolling out r179408.
1100 https://bugs.webkit.org/show_bug.cgi?id=141117
1102 This didn't fully fix the issue (Requested by anttik on
1107 "OSObjectPtr does not work with dispatch_data_t on Maverics"
1108 https://bugs.webkit.org/show_bug.cgi?id=141081
1109 http://trac.webkit.org/changeset/179408
1111 2015-01-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
1113 https://trac.webkit.org/changeset/179439 breaks a python test
1114 https://bugs.webkit.org/show_bug.cgi?id=141114
1118 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1119 (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.
1121 2015-01-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
1123 Import W3C web platform tests infrastructure
1124 https://bugs.webkit.org/show_bug.cgi?id=140934
1126 Reviewed by Ryosuke Niwa.
1128 Loading necessary web platform tests modules before launching server.
1129 Ensuring that some empty __init__.py files are present and create them if necessary.
1131 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1132 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1134 2015-01-30 Brent Fulgham <bfulgham@apple.com>
1136 [Win] Another unreviewed test fix.
1138 Correct copy/paste error in buildbot handling.
1140 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1141 (LayoutTestApacheHttpd.__init__):
1142 (LayoutTestApacheHttpd._get_apache_config_file_path):
1144 2015-01-30 Brent Fulgham <bfulgham@apple.com>
1146 [Win] Unreviewed test fix.
1148 Correct path handling based on failures on test bots to get things running again.
1150 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1151 (LayoutTestApacheHttpd.__init__):
1152 (LayoutTestApacheHttpd._get_apache_config_file_path):
1154 2015-01-30 Chris Dumez <cdumez@apple.com>
1156 Unreviewed. Fix Windows build after r179409.
1158 * DumpRenderTree/win/TestRunnerWin.cpp:
1159 (TestRunner::notifyDone):
1160 (TestRunner::queueLoad):
1162 2015-01-30 Chris Dumez <cdumez@apple.com>
1164 Rename shared() static member functions to singleton() for singleton classes.
1165 https://bugs.webkit.org/show_bug.cgi?id=141088
1167 Reviewed by Ryosuke Niwa and Benjamin Poulain.
1169 Rename shared() static member functions to singleton() for singleton
1170 classes as per the recent coding style change.
1172 2015-01-30 Antti Koivisto <antti@apple.com>
1174 OSObjectPtr does not work with dispatch_data_t on Maverics
1175 https://bugs.webkit.org/show_bug.cgi?id=141081
1177 Reviewed by Pratik Solanki.
1179 * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
1180 (TestWebKitAPI::TEST):
1182 2015-01-30 Brent Fulgham <bfulgham@apple.com>
1184 [Win] Switch to Apache on Windows
1185 https://bugs.webkit.org/show_bug.cgi?id=141060
1187 Reviewed by Alexey Proskuryakov.
1189 Update our scripts under Windows (and Cygwin) to locate and use
1190 the XAMPP installation of Apache for running tests.
1192 * Scripts/run-webkit-httpd:
1193 * Scripts/webkitperl/httpd.pm:
1195 (getDefaultConfigForTestDirectory):
1196 (getHTTPDConfigPathForTestDirectory):
1197 * Scripts/webkitpy/common/system/executive_unittest.py:
1198 (ExecutiveTest.serial_test_kill_process):
1199 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1200 (LayoutTestApacheHttpd.__init__):
1201 (LayoutTestApacheHttpd._get_apache_config_file_path):
1202 (LayoutTestApacheHttpd._stop_running_server):
1203 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1204 (HttpServerBase._is_server_running_on_all_ports):
1205 * Scripts/webkitpy/port/base.py:
1206 (Port._apache_config_file_name_for_platform):
1207 * Scripts/webkitpy/port/port_testcase.py:
1208 (test_apache_config_file_name_for_platform):
1209 * Scripts/webkitpy/port/win.py:
1210 (WinPort.show_results_html_file):
1211 (WinPort._uses_apache):
1213 (WinPort._path_to_apache):
1215 2015-01-29 Alexey Proskuryakov <ap@apple.com>
1217 Built result takes too long to be compressed on bots
1218 https://bugs.webkit.org/show_bug.cgi?id=141056
1220 Reviewed by Daniel Bates.
1222 Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
1224 * BuildSlaveSupport/test-result-archive: (archiveTestResults):
1226 2015-01-29 Sam Weinig <sam@webkit.org>
1228 Remove support for screen font substitution
1229 https://bugs.webkit.org/show_bug.cgi?id=141038
1231 Reviewed by Tim Horton.
1233 * DumpRenderTree/win/DumpRenderTree.cpp:
1234 (resetWebPreferencesToConsistentValues):
1235 Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
1237 2015-01-29 Csaba Osztrogonác <ossy@webkit.org>
1239 Make run-jsc-stress-tests --remote work on Linux too
1240 https://bugs.webkit.org/show_bug.cgi?id=141000
1242 Reviewed by Darin Adler.
1244 * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
1245 use bash/dash compatible signal names, use Linux/Mac compatible find options,
1246 use bash/dash compatible functions.
1247 * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
1249 2015-01-29 Csaba Osztrogonác <ossy@webkit.org>
1251 [buildbot] Simplify jscore-test buildstep
1252 https://bugs.webkit.org/show_bug.cgi?id=140821
1254 Reviewed by Alexey Proskuryakov.
1256 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1257 (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
1258 (RunJavaScriptCoreTests.countFailures): Added.
1259 (RunJavaScriptCoreTests.commandComplete): Deleted.
1260 (RunJavaScriptCoreTests.evaluateCommand): Deleted.
1261 (RunJavaScriptCoreTests.getText): Deleted.
1262 (RunJavaScriptCoreTests.getText2): Deleted.
1263 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
1264 (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
1265 (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
1266 (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
1267 (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
1269 2015-01-29 Csaba Osztrogonác <ossy@webkit.org>
1271 Unreviewed, revert r179337, we don't need this dependency.
1273 * efl/install-dependencies:
1274 * gtk/install-dependencies:
1276 2015-01-28 Shivakumar JM <shiva.jm@samsung.com>
1278 Unreviewed. Moving myself to the committer section.
1280 * Scripts/webkitpy/common/config/contributors.json:
1282 2015-01-28 Csaba Osztrogonác <ossy@webkit.org>
1284 URTBF after r179326, added uuid-dev package as new dependency.
1286 * efl/install-dependencies:
1287 * gtk/install-dependencies:
1289 2015-01-28 Timothy Horton <timothy_horton@apple.com>
1291 Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
1292 https://bugs.webkit.org/show_bug.cgi?id=140673
1294 Reviewed by Sam Weinig.
1296 * Scripts/dtrace/trace-webkit2-messages.d: Added.
1297 Add a DTrace script that outputs a small blob of JSON per message.
1299 2015-01-28 Geoffrey Garen <ggaren@apple.com>
1301 Removed fastMallocForbid / fastMallocAllow
1302 https://bugs.webkit.org/show_bug.cgi?id=141012
1304 Reviewed by Mark Hahnenberg.
1306 Fixed a test bug I noticed while testing.
1308 * DumpRenderTree/JavaScriptThreading.cpp:
1309 (stopJavaScriptThreads): Lock the javaScriptThreads lock before
1310 accessing javaScriptThreads -- otherwise, you'll ASSERT.
1312 2015-01-28 Dana Burkart <dburkart@apple.com>
1314 asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
1315 https://bugs.webkit.org/show_bug.cgi?id=141015
1317 Reviewed by Alexey Proskuryakov.
1319 * asan/asan.xcconfig:
1321 2015-01-28 Sam Weinig <sam@webkit.org>
1325 * Scripts/copy-webkitlibraries-to-product-directory:
1327 2015-01-28 Lucas Forschler <lforschler@apple.com>
1329 Increase the FileUpload block size in an attempt to improve network performance.
1331 Reviewed by Alexey Proskuryakov.
1333 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1334 (UploadBuiltProduct.__init__):
1336 2015-01-28 Dana Burkart <dburkart@apple.com>
1338 Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1339 https://bugs.webkit.org/show_bug.cgi?id=136765
1341 Reviewed by Alexey Proskuryakov.
1343 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1344 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1345 * LayoutTestRelay/Configurations/Base.xcconfig:
1346 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1347 * MiniBrowser/Configurations/Base.xcconfig:
1348 * MiniBrowser/Configurations/DebugRelease.xcconfig:
1349 * TestWebKitAPI/Configurations/Base.xcconfig:
1350 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1351 * WebKitLauncher/Configurations/Base.xcconfig:
1352 * WebKitTestRunner/Configurations/Base.xcconfig:
1353 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1355 2015-01-28 Joanmarie Diggs <jdiggs@igalia.com>
1357 AX: [ATK] Implement support for new AtkRole types for MathML
1358 https://bugs.webkit.org/show_bug.cgi?id=140916
1360 Reviewed by Chris Fleizach.
1362 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
1363 * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
1365 2015-01-28 Carlos Garcia Campos <cgarcia@igalia.com>
1367 [GTK] Stop removing color marks from unit tests output
1368 https://bugs.webkit.org/show_bug.cgi?id=140996
1370 Reviewed by Philippe Normand.
1372 Since r178236 google tests use a custom simplified output without
1373 any colors, so we don't need to handle the case of non ttys to
1374 remove the color marks.
1376 * Scripts/run-gtk-tests:
1377 (TestRunner.__init__):
1378 (TestRunner._run_test_command.parse_line):
1380 2015-01-28 Carlos Garcia Campos <cgarcia@igalia.com>
1382 [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
1383 https://bugs.webkit.org/show_bug.cgi?id=131731
1385 Reviewed by Žan Doberšek.
1387 A web page loaded offscreen is in prerender state not hidden.
1389 * Scripts/run-gtk-tests:
1390 (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
1391 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1392 (testWebViewPageVisibility):
1394 2015-01-27 Alexey Proskuryakov <ap@apple.com>
1396 Partially revert r178802.
1398 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
1399 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
1401 2015-01-27 Alexey Proskuryakov <ap@apple.com>
1403 build.webkit.org/dashboard asserts on some commits
1404 https://bugs.webkit.org/show_bug.cgi?id=140926
1406 Reviewed by Tim Horton.
1408 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1409 (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
1411 2015-01-27 Alexey Proskuryakov <ap@apple.com>
1413 Make flakiness dashboard OS list actually match test_expectations.py
1414 https://bugs.webkit.org/show_bug.cgi?id=140969
1416 Reviewed by Ryosuke Niwa.
1418 * TestResultServer/static-dashboards/flakiness_dashboard.js:
1420 2015-01-27 Brent Fulgham <bfulgham@apple.com>
1422 [Win] WinLauncher crashes on eleventh site visited
1423 https://bugs.webkit.org/show_bug.cgi?id=140960
1425 Reviewed by Anders Carlsson.
1427 * WinLauncher/WinLauncher.cpp:
1428 (WinLauncher::showLastVisitedSites): Don't access off the end of
1431 2015-01-27 Alexey Proskuryakov <ap@apple.com>
1433 [Mac] Disable building Java applets by default
1434 https://bugs.webkit.org/show_bug.cgi?id=140957
1435 rdar://problem/19619529
1437 Reviewed by Anders Carlsson.
1439 It was actually already disabled unconditionally, by accident.
1441 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
1442 * Scripts/webkitpy/port/mac.py:
1443 (MacPort._check_port_build):
1444 (MacPort._build_java_test_support):
1446 2015-01-27 Daniel Bates <dabates@apple.com>
1448 [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
1449 https://bugs.webkit.org/show_bug.cgi?id=140949
1451 Reviewed by Alexey Proskuryakov.
1453 Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
1454 builders so that run-webkit-tests can lint the appropriate TestExpectation
1457 * Scripts/webkitpy/port/builders.py:
1458 * Scripts/webkitpy/port/ios.py:
1459 (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
1460 (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
1461 information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
1462 in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
1463 will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
1464 to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
1465 test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
1468 2015-01-27 Alexey Proskuryakov <ap@apple.com>
1470 Update bots on the flakiness dashboard
1471 https://bugs.webkit.org/show_bug.cgi?id=140956
1473 Reviewed by Ryosuke Niwa.
1475 * TestResultServer/static-dashboards/builders.jsonp:
1476 * TestResultServer/static-dashboards/flakiness_dashboard.js:
1478 2015-01-27 Daniel Bates <dabates@apple.com>
1480 [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
1481 https://bugs.webkit.org/show_bug.cgi?id=140942
1483 Reviewed by Alexey Proskuryakov.
1485 The directory LayoutTests/platform/wk2 contains test expectations and test results that
1486 are applicable to all WebKit2 ports. We should make use of this information when
1487 running layout tests using iOS WebKit2.
1489 Additionally, make use of the convenience function Port._wk2_port_name() for the name
1490 of the WebKit2 port instead of directly using string concatenation.
1492 * Scripts/webkitpy/port/ios.py:
1493 (IOSSimulatorPort.default_baseline_search_path):
1495 2015-01-27 Csaba Osztrogonác <ossy@webkit.org>
1497 [Win] Disable FTL stress tests
1498 https://bugs.webkit.org/show_bug.cgi?id=140932
1500 Reviewed by Brent Fulgham.
1502 * Scripts/run-javascriptcore-tests:
1504 2015-01-27 Daniel Bates <dabates@apple.com>
1506 REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
1507 https://bugs.webkit.org/show_bug.cgi?id=140939
1509 Reviewed by Eric Carlson.
1511 Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
1513 * Scripts/webkitdirs.pm:
1514 (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
1515 of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
1516 and define a function called wanted.
1518 2015-01-27 Daniel Bates <dabates@apple.com>
1520 Teach run-webkit-app --simulator how to install custom built app
1521 https://bugs.webkit.org/show_bug.cgi?id=140691
1523 Fix inadvertent omission of directory test flag in expression to check for the
1524 existence of the iOS simulator device-specific directory for user installed apps.
1526 * Scripts/webkitdirs.pm:
1527 (hasUserInstalledAppInSimulatorDevice):
1529 2015-01-26 Brent Fulgham <bfulgham@apple.com>
1531 [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
1532 https://bugs.webkit.org/show_bug.cgi?id=87426
1533 <rdar://problem/11527899>
1535 Reviewed by Darin Adler.
1537 Revise COMPtr to work better with our HashMap implementation. Use
1540 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1541 (AccessibilityController::~AccessibilityController):
1542 (AccessibilityController::winNotificationReceived):
1543 * DumpRenderTree/win/DumpRenderTree.cpp:
1544 (dumpBackForwardListForAllWindows):
1546 2015-01-26 Csaba Osztrogonác <ossy@webkit.org>
1548 [Win] Enable JSC stress tests by default
1549 https://bugs.webkit.org/show_bug.cgi?id=128307
1551 Reviewed by Brent Fulgham.
1553 * Scripts/run-javascriptcore-tests:
1555 2015-01-26 Simon Fraser <simon.fraser@apple.com>
1557 [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
1558 arguments for build and test scripts
1559 https://bugs.webkit.org/show_bug.cgi?id=139748
1561 Reviewed by Daniel Bates.
1563 There was much confusion resulting from the multitude of aliases used to build/test for
1564 the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
1567 This fixes an issue where run-api-tests and some other scripts failed when run with
1570 * Scripts/build-webkit:
1571 * Scripts/package-root:
1573 * Scripts/webkitdirs.pm:
1574 (argumentsForConfiguration):
1575 (determineXcodeSDK):
1576 * Scripts/webkitpy/port/factory.py:
1579 2015-01-26 Simon Fraser <simon.fraser@apple.com>
1581 [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
1582 https://bugs.webkit.org/show_bug.cgi?id=140203
1583 rdar://problem/19198492
1585 Reviewed by Sam Weinig.
1587 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1588 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
1591 2015-01-26 David Kilzer <ddkilzer@apple.com>
1593 Add iOS EWS to build.webkit.org/dashboard
1594 <http://webkit.org/b/140627>
1596 Reviewed by Alexey Proskuryakov.
1598 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
1599 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
1600 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1601 (BubbleQueueServer): Add ios-ews queue info.
1602 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1603 Add iOS8Device platform.
1604 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1605 (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
1608 2015-01-26 Filip Pizlo <fpizlo@apple.com>
1610 copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
1611 https://bugs.webkit.org/show_bug.cgi?id=140896
1613 Reviewed by Michael Saboff.
1615 I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
1616 makes our script do this.
1618 Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
1619 this would be harder given llvm's autoconf setup.
1621 * Scripts/copy-webkitlibraries-to-product-directory:
1623 2015-01-26 Alexey Proskuryakov <ap@apple.com>
1625 Update bot assignments.
1627 * BuildSlaveSupport/build.webkit.org-config/config.json:
1629 2015-01-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
1631 Integrate WP python server into WebKit test framework
1632 https://bugs.webkit.org/show_bug.cgi?id=127094
1634 Reviewed by Ryosuke Niwa.
1636 This patch adds W3C web server (wptserver) as a new HTTP server.
1637 wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
1638 wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
1640 Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
1641 Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
1642 It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
1644 * Scripts/webkitpy/common/system/executive_mock.py:
1645 (MockProcess.communicate):
1646 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
1647 (LayoutTestRunner.__init__):
1648 (LayoutTestRunner.run_tests):
1649 (LayoutTestRunner.start_servers):
1650 (LayoutTestRunner.stop_servers):
1651 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
1652 (LayoutTestRunnerTests._run_tests):
1653 (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
1654 (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
1655 (LayoutTestRunnerTests):
1656 (LayoutTestRunnerTests.test_servers_started):
1657 * Scripts/webkitpy/layout_tests/controllers/manager.py: Updated to check whether a test is a wpt test and whether wpt server launch is needed.
1659 (Manager._is_http_test):
1660 (Manager._is_web_platform_test):
1661 (Manager._run_tests):
1662 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1663 (ManagerTest.test_needs_servers.get_wpt_doc_root):
1664 (ManagerTest.test_needs_servers.get_manager):
1665 (ManagerTest.test_needs_servers):
1666 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
1668 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
1670 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
1673 (WebPlatformTestServer):
1674 (WebPlatformTestServer.__init__):
1675 (WebPlatformTestServer._set_start_cmd):
1676 (WebPlatformTestServer._copy_webkit_test_files):
1677 (WebPlatformTestServer._clean_webkit_test_files):
1678 (WebPlatformTestServer._prepare_config):
1679 (WebPlatformTestServer._spawn_process):
1680 (WebPlatformTestServer._stop_running_server):
1681 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
1682 (TestWebPlatformTestServer):
1683 (TestWebPlatformTestServer.test_start_cmd):
1684 * Scripts/webkitpy/port/base.py:
1686 (Port.to.start_web_platform_test_server):
1688 (Port.to.web_platform_test_server_doc_root):
1689 (Port.to.web_platform_test_server_base_url):
1690 (Port.to.stop_web_platform_test_server):
1691 * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
1693 (Driver.is_web_platform_test):
1694 (Driver.test_to_uri):
1695 (Driver.uri_to_test):
1696 (Driver._command_from_driver_input):
1697 * Scripts/webkitpy/port/driver_unittest.py: Updated tests according new conversion rules.
1698 (DriverTest.test_test_to_uri):
1699 (DriverTest.test_uri_to_test):
1701 2015-01-26 Daniel Bates <dabates@apple.com>
1703 Teach run-webkit-app --simulator how to install custom built app
1704 https://bugs.webkit.org/show_bug.cgi?id=140691
1706 Reviewed by David Kilzer.
1708 We should teach run-webkit-app --simulator how to install a custom built app.
1710 Currently run-webkit-app --simulator can only run a system app or an app that
1711 was installed using the simctl command line tool. For convenience we should
1712 teach run-webkit-app --simulator how to install a custom built app.
1714 As a side effect of this change run-safari --simulator will install and run
1715 a custom built of MobileSafari (if it exists).
1717 * Scripts/webkitdirs.pm:
1718 (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
1719 Perl from the structure of the device.plist file.
1720 (plistPathFromBundle): Fix if-statement condition so that we actually perform a
1721 file system check to determine the plist path for a Mac app bundle.
1722 (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
1723 it will complain that it cannot find the file: "Domain ... does not exist".
1724 (appDisplayNameFromBundle): Ditto.
1725 (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
1726 until a simulator device is the specified state.
1727 (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
1728 (if it's open) before opening it again so as to ensure that the iOS Simulator boots
1729 the specified device.
1730 (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
1731 As implied by its name, this function will not return until the specified simulator
1732 device UDID is in the shutdown state.
1733 (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
1734 device with the specified UDID.
1735 (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
1736 before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
1737 return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
1738 expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
1739 symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
1740 /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
1741 which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
1742 (hasUserInstalledAppInSimulatorDevice): Added.
1743 (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
1745 (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
1746 switching between a system installed app and a custom built version of the same app (e.g.
1747 custom build of MobileSafari) will erase all contents and settings in the simulator device.
1748 (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
1749 as that was the only caller of this function.
1750 (bootedIOSSimulatorDevice): Deleted.
1751 (openIOSSimulator): Deleted.
1753 2015-01-26 Alexey Proskuryakov <ap@apple.com>
1755 Update bot assignments.
1757 * BuildSlaveSupport/build.webkit.org-config/config.json:
1759 2015-01-26 Alexey Proskuryakov <ap@apple.com>
1761 Leaks bot shouldn't run JSC tests
1762 https://bugs.webkit.org/show_bug.cgi?id=140877
1764 Reviewed by Darin Adler.
1766 Shaves off 48 minutes of time.
1768 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1769 (TestLeaksFactory): Slim down the leaks queue.
1771 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1772 * Scripts/webkitpy/port/ios.py:
1773 (IOSSimulatorPort.print_leaks_summary):
1774 * Scripts/webkitpy/port/mac.py:
1775 (MacPort.print_leaks_summary):
1776 Don't yell when leaks are detected.
1778 2015-01-26 Csaba Osztrogonác <ossy@webkit.org>
1780 Refactor run-javascriptcore-tests
1781 https://bugs.webkit.org/show_bug.cgi?id=140824
1783 Reviewed by Darin Adler.
1785 Separated mozilla, stress test code paths and
1786 determining skipped mozilla tests into subroutines.
1788 * Scripts/run-javascriptcore-tests:
1790 (runJSCStressTests):
1791 (defaultJsDriverArgsForMozillaTests):
1793 2015-01-26 Csaba Osztrogonác <ossy@webkit.org>
1795 [buildbot] Fix grammar of TestWithFailureCount
1796 https://bugs.webkit.org/show_bug.cgi?id=140884
1798 Reviewed by Alexey Proskuryakov.
1800 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1801 (TestWithFailureCount):
1802 (TestWithFailureCount.commandComplete):
1803 (TestWithFailureCount.getText2):
1807 (RunLLINTCLoopTests):
1809 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1810 (RunLLINTCLoopTestsTest.test_failure):
1811 (Run32bitJSCTestsTest.test_failure):
1812 (RunUnitTestsTest.assertFailures):
1814 2015-01-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
1816 Unreviewed. Moving myself to the committer section.
1818 * Scripts/webkitpy/common/config/contributors.json:
1820 2015-01-26 Michael Catanzaro <mcatanzaro@igalia.com> and Carlos Garcia Campos <cgarcia@igalia.com>
1822 [GTK] gtkdoc does not appear in DevHelp
1823 https://bugs.webkit.org/show_bug.cgi?id=139369
1825 Reviewed by Philippe Normand.
1827 * gtk/generate-gtkdoc: Create the generators in the main function
1828 and use them to get the local cross renference dependencies. Also
1829 pass the generator module name to webkitdom.write_doc_files().
1830 (get_gtkdoc_module_paths): Receive a list of local cross reference
1832 (get_generator_for_config): Set the main_sgml_file property of the
1833 GtkDoc object from the configuration file.
1834 (generate_documentation): Generate the documentation for the given
1836 (generate_documentation_for_config): Deleted.
1837 * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
1839 (write_doc_files): Receive the module name used to build the
1840 -sections.txt filename.
1842 2015-01-26 Commit Queue <commit-queue@webkit.org>
1844 Unreviewed, rolling out r179107.
1845 https://bugs.webkit.org/show_bug.cgi?id=140880
1847 The GCC in the bots doesn't support the AsyncTask
1848 implementation (Requested by KaL on #webkit).
1852 "[GTK] Enable IndexedDB"
1853 https://bugs.webkit.org/show_bug.cgi?id=98932
1854 http://trac.webkit.org/changeset/179107
1856 2015-01-26 Csaba Osztrogonác <ossy@webkit.org>
1858 [EFL] Bump libseccomp version to 2.1.1
1859 https://bugs.webkit.org/show_bug.cgi?id=140357
1861 Reviewed by Gyuyoung Kim.
1863 * efl/jhbuild.modules:
1865 2015-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
1867 [GTK] Enable IndexedDB
1868 https://bugs.webkit.org/show_bug.cgi?id=98932
1870 Reviewed by Žan Doberšek.
1872 * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
1874 2015-01-25 Alexey Proskuryakov <ap@apple.com>
1876 Would like leaks bot results at build.webkit.org/dashboard
1877 https://bugs.webkit.org/show_bug.cgi?id=122657
1879 Reviewed by Darin Adler.
1881 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1882 Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
1883 than necessary, could use the ones from buildbot in more places.
1885 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1886 (BuildbotQueue): Reflect configuration option for leaks queues.
1888 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1889 Add leaks queues to performance column. First, leaks are about performance indeed,
1890 and second, this is where we have some space to spare.
1892 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1893 (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
1896 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1897 (table.queue-grid td): Moved height from queue-view - we can now have more than one
1898 queue view per cell. The heigt is needed to avoid ugly overlapping while loading
1899 results - once the results are loaded, all rows are currently higher than that.
1901 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1902 (.leaks-popover): Added.
1904 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1907 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1908 Load BuildbotLeaksQueueView.js.
1910 2015-01-25 peavo@outlook.com <peavo@outlook.com>
1912 [Win] Add WebKit message loop interface.
1913 https://bugs.webkit.org/show_bug.cgi?id=140857
1915 Reviewed by Brent Fulgham.
1917 Added message loop interface which will run the message loop,
1918 and perform required tasks (like calling CFRunLoopRunInMode)
1919 on each iteration of the loop.
1921 * WinLauncher/WinMain.cpp:
1922 (wWinMain): Use new message loop interface.
1924 2015-01-24 Dan Bernstein <mitz@apple.com>
1926 update-webkit’s --internal option is unused
1927 https://bugs.webkit.org/show_bug.cgi?id=140861
1929 Reviewed by Anders Carlsson.
1931 * Scripts/update-webkit: Removed the option.
1933 2015-01-24 Brent Fulgham <bfulgham@apple.com>
1935 DumpRenderTree needs to run with Windows native controls on Windows
1936 https://bugs.webkit.org/show_bug.cgi?id=25592
1938 Reviewed by Anders Carlsson.
1940 * DumpRenderTree/win/DumpRenderTree.cpp:
1941 (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
1942 (prepareConsistentTestingEnvironment): Ditto.
1944 2015-01-23 David Kilzer <ddkilzer@apple.com>
1946 test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
1947 <http://webkit.org/b/140787>
1949 Reviewed by Daniel Bates.
1951 * Scripts/webkitpy/port/ios.py:
1952 (IOSPort.determine_full_port_name): Instead of checking the type
1953 of the current host, test if /usr/bin/xcrun exists before trying
1956 2015-01-23 Csaba Osztrogonác <ossy@webkit.org>
1958 Fix the false positive build failures on the Windows buildbots
1959 https://bugs.webkit.org/show_bug.cgi?id=140819
1961 Reviewed by Brent Fulgham.
1963 Increase the build timeout (without producing output) to 2 hours for Windows bots,
1964 the default 20 minutes is enough for others since they produce output during the build.
1966 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1967 (BuildFactory.__init__):
1969 2015-01-23 Brent Fulgham <bfulgham@apple.com>
1971 [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
1972 https://bugs.webkit.org/show_bug.cgi?id=140839
1974 Reviewed by Dean Jackson.
1976 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1977 (AccessibilityUIElement::language): Retrieve the 'language' BSTR
1978 from the IA2Locale structure and pass it to DRT.
1980 2015-01-23 Brent Fulgham <bfulgham@apple.com>
1982 [Win] Update DRT Accessibility implementation to better match Mac.
1983 https://bugs.webkit.org/show_bug.cgi?id=140830
1985 Reviewed by Dean Jackson.
1987 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1988 (AccessibilityUIElement::titleUIElement):
1989 (AccessibilityUIElement::parentElement):
1990 (convertToDRTLabel):
1991 (AccessibilityUIElement::role):
1992 (AccessibilityUIElement::title):
1993 (AccessibilityUIElement::description):
1994 (AccessibilityUIElement::stringValue):
1995 (AccessibilityUIElement::helpText):
1996 (AccessibilityUIElement::isFocused):
1998 2015-01-23 Sergio Villar Senin <svillar@igalia.com>
2000 REGRESSION: run-perf-tests --profiler= seems to have broken
2001 https://bugs.webkit.org/show_bug.cgi?id=113528
2003 Reviewed by Daniel Bates.
2005 The problem is that "perf --record" (or the equivalent call for
2006 other profilers) is never called whenever there is a wrapper
2007 option in the port. We should inject the profiler call first
2008 (should it exists) and then use the port wrapper.
2010 * Scripts/webkitpy/port/driver.py:
2011 (Driver._command_wrapper):
2012 * Scripts/webkitpy/port/driver_unittest.py:
2013 (DriverTest.test_profiler_and_wrapper): New unit test.
2015 2015-01-22 David Kilzer <ddkilzer@apple.com>
2017 configure-xcode-for-ios-development needs to import webkitdirs.pm
2018 <http://webkit.org/b/140704>
2020 Fixes the following runtime error:
2022 Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
2024 * Scripts/configure-xcode-for-ios-development: Add back code to
2025 import webkitdirs.pm for the exitStatus() method. Not sure why
2026 I removed it before patch review.
2028 2015-01-22 Timothy Horton <timothy_horton@apple.com>
2030 REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
2031 https://bugs.webkit.org/show_bug.cgi?id=140795
2033 Reviewed by Jon Honeycutt.
2035 * BuildSlaveSupport/build.webkit.org-config/config.json:
2036 r178847 accidentally remove the scheduler for this bot. Re-add it to the
2039 2015-01-22 Brent Fulgham <bfulgham@apple.com>
2041 [Win] Expose missing editing features through WebView interface
2042 https://bugs.webkit.org/show_bug.cgi?id=140773
2043 <rdar://problem/19565421>
2045 Reviewed by Dean Jackson.
2047 Connect the various WebView editing delegate methods to our
2048 test infrastructure. Also prefer _bstr_t to raw BSTR types
2049 to simplify life cycle management.
2051 * DumpRenderTree/win/DumpRenderTree.cpp:
2052 (resetWebViewToConsistentStateBeforeTesting):
2053 * DumpRenderTree/win/EditingDelegate.cpp:
2054 (EditingDelegate::QueryInterface):
2057 (EditingDelegate::shouldBeginEditingInDOMRange):
2058 (EditingDelegate::shouldEndEditingInDOMRange):
2059 (EditingDelegate::shouldInsertNode):
2060 (EditingDelegate::shouldInsertText):
2061 (EditingDelegate::shouldDeleteDOMRange):
2062 (EditingDelegate::shouldChangeSelectedDOMRange):
2063 (EditingDelegate::shouldApplyStyle):
2064 (EditingDelegate::shouldChangeTypingStyle):
2065 (EditingDelegate::doPlatformCommand):
2066 (EditingDelegate::webViewDidBeginEditing):
2067 (EditingDelegate::webViewDidChange):
2068 (EditingDelegate::webViewDidEndEditing):
2069 (EditingDelegate::webViewDidChangeTypingStyle):
2070 (EditingDelegate::webViewDidChangeSelection):
2071 (EditingDelegate::checkSpellingOfString):
2072 (EditingDelegate::onNotify):
2073 * DumpRenderTree/win/EditingDelegate.h:
2075 2015-01-22 Ryosuke Niwa <rniwa@webkit.org>
2077 Add a build flag for ES6 class syntax
2078 https://bugs.webkit.org/show_bug.cgi?id=140760
2080 Reviewed by Michael Saboff.
2082 * Scripts/webkitperl/FeatureList.pm:
2084 2015-01-22 Daniel Bates <dabates@apple.com>
2086 [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
2087 runtime in simctl output
2088 https://bugs.webkit.org/show_bug.cgi?id=140751
2090 Reviewed by David Kilzer.
2092 Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
2093 with an error because it does not know how to parse the output of the simctl tool
2094 to identify an Apple Internal runtime.
2096 * Scripts/webkitpy/xcode/simulator.py:
2097 (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
2098 (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
2099 (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
2100 the runtime is an internal runtime.
2101 (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
2102 (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
2104 (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
2105 it updates the appropriate Runtime object.
2106 (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
2107 looking up a Runtime object for an internal runtime.
2109 2015-01-22 Alexey Proskuryakov <ap@apple.com>
2111 LeaksViewer doesn't show recent builds if there are less than 10
2112 https://bugs.webkit.org/show_bug.cgi?id=140716
2114 Reviewed by Tim Horton.
2116 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2118 2015-01-22 Lucas Forschler <lforschler@apple.com>
2120 Add Apple build slaves.
2121 Fixed text alignment for slave list.
2125 * BuildSlaveSupport/build.webkit.org-config/config.json:
2127 2015-01-21 Lucas Forschler <lforschler@apple.com>
2129 Teach build.webkit.org about bot308 and bot309.
2133 * BuildSlaveSupport/build.webkit.org-config/config.json:
2135 2015-01-21 Lucas Forschler <lforschler@apple.com>
2137 Add two Apple Mavericks slaves.
2141 * BuildSlaveSupport/build.webkit.org-config/config.json:
2143 2015-01-21 Daniel Bates <dabates@apple.com>
2145 Add iOS WebKit1 TestExpectation file
2146 https://bugs.webkit.org/show_bug.cgi?id=140739
2148 Reviewed by David Kilzer.
2150 Teach run-webkit-tests to look for iOS WebKit1-specific test results and
2151 expectations in directory LayoutTests/platform/ios-simulator-wk1.
2153 * Scripts/webkitpy/port/ios.py:
2154 (IOSSimulatorPort.default_baseline_search_path):
2156 2015-01-21 David Kilzer <ddkilzer@apple.com>
2158 [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
2159 <http://webkit.org/b/140704>
2161 Reviewed by Daniel Bates.
2163 * Scripts/configure-xcode-for-ios-development:
2165 - Remove FIXME addressed by r178709.
2166 - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
2167 (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
2168 missing headers from iphonesimulator SDK to iphoneos SDK.
2169 (sdkDirectory): Add method that returns SDK directory.
2170 (sdkPlatformDirectory): Extract method from
2171 xcodeSDKSpecificationsPath() that returns SDK platform
2173 (xcodeSDKSpecificationsPath): Update to use
2174 sdkPlatformDirectory().
2176 2015-01-21 Alexey Proskuryakov <ap@apple.com>
2178 https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
2179 https://bugs.webkit.org/show_bug.cgi?id=140731
2181 Reviewed by Tim Horton.
2183 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2184 (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
2186 2015-01-21 Brent Fulgham <bfulgham@apple.com>
2188 [Win] eventSender does not support scalePageBy
2189 https://bugs.webkit.org/show_bug.cgi?id=140726
2190 <rdar://problem/19549865>
2192 Reviewed by Dean Jackson.
2194 * DumpRenderTree/win/EventSender.cpp:
2195 (scalePageByCallback): Provide implementation using new WebView method.
2197 2015-01-21 Lucas Forschler <lforschler@apple.com>
2199 Remove Apple Mountain Lion Build & Test slaves.
2203 * BuildSlaveSupport/build.webkit.org-config/config.json:
2205 2015-01-21 Csaba Osztrogonác <ossy@webkit.org>
2207 Remove ENABLE(INSPECTOR) ifdef guards
2208 https://bugs.webkit.org/show_bug.cgi?id=140668
2210 Reviewed by Darin Adler.
2212 * DumpRenderTree/mac/TestRunnerMac.mm:
2213 (TestRunner::showWebInspector):
2214 (TestRunner::closeWebInspector):
2215 (TestRunner::evaluateInWebInspector):
2216 * Scripts/webkitperl/FeatureList.pm:
2217 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2218 (WTR::TestRunner::showWebInspector):
2219 (WTR::TestRunner::closeWebInspector):
2220 (WTR::TestRunner::evaluateInWebInspector):
2221 * WebKitTestRunner/TestInvocation.cpp:
2222 (WTR::TestInvocation::invoke):
2224 2015-01-20 Alexey Proskuryakov <ap@apple.com>
2226 Update build.webkit.org/dashboard to match current Mac queues.
2228 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
2229 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
2230 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
2231 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
2232 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2233 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2234 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2235 (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
2236 (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
2238 2015-01-20 Lucas Forschler <lforschler@apple.com>
2240 Update Apple MountainLion Leaks slave to Yosemite
2241 Update Apple MountainLion Release (32-bit) Build slave to Yosemite
2245 * BuildSlaveSupport/build.webkit.org-config/config.json:
2247 2015-01-20 Lucas Forschler <lforschler@apple.com>
2249 Update LeaksViewer from MountainLion to Yosemite
2251 Reviewed by Alexey Proskuryakov.
2253 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2254 (LeaksViewer._displayURLPrompt):
2256 2015-01-20 Jake Nielsen <jacob_nielsen@apple.com>
2258 Fix EWS python unit tests and address code comments as per 140476
2259 https://bugs.webkit.org/show_bug.cgi?id=140637
2261 Reviewed by David Kilzer.
2263 * Scripts/webkitpy/port/base.py:
2266 Adds DEFAULT_ARCHITECTURE member.
2267 (Port.architecture):
2268 Removes architecture member and instead uses
2269 self.get_option('architecture'). Also removes redundant architecture
2271 (Port.set_architecture):
2272 Adds a setter for the architecture variable to be able to set a flag
2274 (Port.test_configuration):
2275 Uses self.architecture() instead of self._architecture.
2276 * Scripts/webkitpy/port/ios.py:
2277 Overrides DEFAULT_ARCHITECTURE.
2279 (IOSPort.determine_full_port_name):
2280 Uses subprocess.check_output instead of Popen. Uses rstrip instead of
2281 strip. Fixes regex to not match arbitrary characters after the
2282 relevent digits are matched.
2284 Removes old _architecture defaulting strategy.
2285 (IOSPort._build_driver_flags):
2286 Uses self.architecture() instead of self._architecture.
2288 Overrides DEFAULT_ARCHITECTURE.
2289 (IOSSimulatorPort.__init__):
2290 Removes old _architecture defaulting strategy.
2291 * Scripts/webkitpy/port/mac.py:
2293 Overrides DEFAULT_ARCHITECTURE.
2295 Removes old _architecture defaulting strategy.
2296 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2297 (AbstractEarlyWarningSystem.run_command):
2298 Checks the did_override_architecture flag to determine whether to add
2299 the --architecture option.
2300 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2301 Uses ews.architecture rather than trying to discern the correct
2302 architecture using a port object.
2303 (EarlyWarningSystemTest._default_expected_logs):
2304 * Scripts/webkitpy/tool/commands/queues.py:
2305 Removes use of optparse, and removes the import statement.
2306 (AbstractQueue.__init__):
2307 (PatchProcessingQueue.begin_work_queue):
2309 2015-01-20 Sam Weinig <sam@webkit.org>
2311 Attempt to fix Mountain Lion and EFL tests.
2313 * WebKitTestRunner/TestController.cpp:
2314 (WTR::TestController::initialize):
2315 Disable Process-per-tab and network process on Mountain Lion and EFL.
2317 2015-01-20 Darin Adler <darin@apple.com>
2319 Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
2320 https://bugs.webkit.org/show_bug.cgi?id=140679
2322 Reviewed by Anders Carlsson.
2324 * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2325 Removed a reference to SVGElementInstanceList.
2327 2015-01-20 Michael Catanzaro <mcatanzaro@igalia.com>
2329 [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
2330 https://bugs.webkit.org/show_bug.cgi?id=140028
2332 Reviewed by Carlos Garcia Campos.
2334 This won't work as expected, since this function is called before the
2335 WebViewTest constructor completes.
2337 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2339 2015-01-20 David Kilzer <ddkilzer@apple.com>
2341 configure-xcode-for-ios-development needs to update iPhoneOS SDK
2342 <http://webkit.org/b/140661>
2344 Reviewed by Daniel Bates.
2346 * Scripts/configure-xcode-for-ios-development: Add for() loop to
2347 run createXcodeSpecificationFilesForSDKIfNeeded() for both
2348 "iphoneos" and "iphonesimulator" SDKs.
2349 (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
2350 the main body of the script.
2352 2015-01-20 Tomas Popela <tpopela@redhat.com>
2354 [GTK] Add API to set the web view editable into WebKit2 GTK+ API
2355 https://bugs.webkit.org/show_bug.cgi?id=139443
2357 Reviewed by Carlos Garcia Campos.
2359 Create the new test cases for setting the editable property on the web
2360 view and on the contenteditable enabled document. Also rework the
2361 current tests that are expecting that the web view is editable.
2363 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2365 (testWebViewEditorCutCopyPasteNonEditable):
2366 (testWebViewEditorCutCopyPasteEditable):
2367 (testWebViewEditorSelectAllNonEditable):
2368 (testWebViewEditorSelectAllEditable):
2369 (runEditorEditableCutTests):
2370 (testWebViewEditorEditableOnNonEditable):
2371 (testWebViewEditorEditableOnContentEditable):
2372 (testWebViewEditorNonEditable):
2374 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2375 (WebViewTest::isEditable):
2376 (WebViewTest::setEditable):
2378 2015-01-20 Carlos Garcia Campos <cgarcia@igalia.com>
2380 [GTK] Add an option to create WebKitWebView snapshots with transparent background
2381 https://bugs.webkit.org/show_bug.cgi?id=140617
2383 Reviewed by Gustavo Noronha Silva.
2385 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2386 (testWebViewSnapshot): Check that the same snapshot with
2387 transparent background is different than the default one filled
2390 2015-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
2392 [GTK] Add API to change the WebKitWebView background color
2393 https://bugs.webkit.org/show_bug.cgi?id=140610
2395 Reviewed by Gustavo Noronha Silva.
2397 Add --bg-color command line option to MiniBrowser to be able to
2398 manually test the API passing any RGBA color to MiniBrowser.
2399 Also add a simple unit test to check that getting and setting
2400 colors from the API point of view.
2402 * MiniBrowser/gtk/BrowserWindow.c:
2403 (browser_window_set_background_color):
2404 * MiniBrowser/gtk/BrowserWindow.h:
2405 * MiniBrowser/gtk/main.c:
2406 (createBrowserWindow):
2407 (parseBackgroundColor):
2408 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2409 (testWebViewBackgroundColor):
2412 2015-01-19 Brent Fulgham <bfulgham@apple.com>
2414 [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
2415 https://bugs.webkit.org/show_bug.cgi?id=140665
2417 Reviewed by Brian Burg.
2419 * DumpRenderTree/win/UIDelegate.cpp:
2420 (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
2421 match expected test output.
2423 2015-01-19 Benjamin Poulain <bpoulain@apple.com>
2425 Remove the support for custom suffixes on ChangeLog
2426 https://bugs.webkit.org/show_bug.cgi?id=140648
2428 Reviewed by David Kilzer.
2430 Custom suffixes were used for the iOS branch of WebKit.
2431 Now that everything is opensource, there is no need for it.
2433 * Scripts/VCSUtils.pm:
2434 (changeLogSuffix): Deleted.
2435 (changeLogFileName): Deleted.
2436 * Scripts/commit-log-editor:
2437 * Scripts/prepare-ChangeLog:
2438 (getLatestChangeLogs):
2439 (generateNewChangeLogs):
2441 * Scripts/resolve-ChangeLogs:
2444 2015-01-19 Timothy Horton <timothy_horton@apple.com>
2446 Adjust naming of action menu SPI
2447 https://bugs.webkit.org/show_bug.cgi?id=140644
2448 <rdar://problem/19448129>
2450 Reviewed by Brian Weinstein.
2452 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2453 (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2454 (TestWebKitAPI::TEST):
2456 2015-01-19 Michael Catanzaro <mcatanzaro@igalia.com>
2458 [GTK] Generate the make dist manifest from a CMake template file
2459 https://bugs.webkit.org/show_bug.cgi?id=139387
2461 Reviewed by Martin Robinson.
2463 Remove the code that performs variable substitution on manifest.txt.
2464 Replace the custom variables used in that file with CMake variables.
2467 (Manifest.add_directory):
2468 (Manifest.get_full_source_path):
2469 (Manifest.process_line):
2470 (Manifest.resolve_variables): Deleted.
2471 (Manifest.get_full_tarball_path): Deleted.
2472 * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
2474 2015-01-19 Brent Fulgham <bfulgham@apple.com>
2476 [Win] Correct merge error in last commit.
2478 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2479 (findAccessibleObjectById): Undo accidental paste made during landing.
2481 2015-01-19 Brent Fulgham <bfulgham@apple.com>
2483 [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
2484 https://bugs.webkit.org/show_bug.cgi?id=139906
2486 Reviewed by Dean Jackson.
2488 WebKit on Windows was creating uninitialized VARIANT structures, then attempting
2489 to use them. This patch fixes that.
2491 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2492 (findAccessibleObjectById):
2493 (AccessibilityController::focusedElement):
2495 (notificationListenerProc):
2496 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2497 (AccessibilityUIElement::getChildAtIndex):
2498 (AccessibilityUIElement::titleUIElement):
2500 (AccessibilityUIElement::role):
2501 (AccessibilityUIElement::valueDescription):
2502 (accessibilityState):
2503 (AccessibilityUIElement::isChecked):
2504 * DumpRenderTree/win/DumpRenderTree.cpp:
2505 (dumpFrameScrollPosition):
2507 * DumpRenderTree/win/PolicyDelegate.cpp:
2508 (PolicyDelegate::decidePolicyForNavigationAction):
2509 * DumpRenderTree/win/UIDelegate.cpp:
2510 (UIDelegate::exceededDatabaseQuota):
2511 * WinLauncher/Common.cpp:
2514 2015-01-19 Dean Jackson <dino@apple.com>
2516 Add "override" to fix the build with newer clangs.
2518 * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2519 (TestWebKitAPI::CalculationDeletionTestNode::operator==):
2521 2015-01-19 David Kilzer <ddkilzer@apple.com>
2523 [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
2524 <http://webkit.org/b/140623>
2526 Reviewed by Daniel Bates.
2528 * Scripts/build-webkit: Update help for --device switch.
2529 * Scripts/webkitdirs.pm:
2530 (determineXcodeSDK): When passing --device, prefer the internal
2531 iOS SDK if it exists, else fall back to the external iOS SDK.
2532 (buildXCodeProject): Use xcodeSDK() as -sdk argument for
2533 xcodebuild instead of trying to sanitize values.
2535 2015-01-19 Alexey Proskuryakov <ap@apple.com>
2537 "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
2538 https://bugs.webkit.org/show_bug.cgi?id=140606
2540 Reviewed by Csaba Osztrogonác.
2542 * Scripts/webkitpy/bindings/main.py:
2543 (BindingsTests.generate_supplemental_dependency):
2544 (BindingsTests.main):
2546 2015-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
2548 [GTK] [WK2] TestWebKitWebView snapshot fails
2549 https://bugs.webkit.org/show_bug.cgi?id=120404
2551 Reviewed by Žan Doberšek.
2553 Rework the test to make sure the snapshot is always created at the
2556 * Scripts/run-gtk-tests:
2557 (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
2558 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2559 (testWebViewSnapshot): Use a fixed size for the document, and
2560 disable scrollbars to make sure the visible area is always the
2562 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2563 (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
2564 and height parameters to create the window with a given size.
2565 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2567 2015-01-18 David Kilzer <ddkilzer@apple.com>
2569 iOS EWS queue name should be consistent
2570 <http://webkit.org/b/140585>
2572 Reviewed by Daniel Bates.
2574 * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
2576 * Scripts/webkitpy/common/config/ports.py: Ditto.
2577 (DeprecatedPort.port):
2579 * Scripts/webkitpy/port/ios.py: Ditto.
2582 * Scripts/webkitpy/port/factory.py:
2583 (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
2584 appears before ios.IOSPort. If this is not done,
2585 `run-webkit-tests --ios-simulator` will get the wrong Port class
2586 (IOSPort instead of IOSSimulatorPort) due to the way that
2587 PortFactory.get() uses prefix matching of <Port>.port_name to
2588 find the correct class to use.
2590 2015-01-18 Alexey Proskuryakov <ap@apple.com>
2592 build.webkit.org/dashboard: OS X EWS is now on Mavericks
2593 https://bugs.webkit.org/show_bug.cgi?id=140595
2595 Reviewed by Csaba Osztrogonác.
2597 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2598 (BubbleQueueServer):
2600 2015-01-17 David Kilzer <ddkilzer@apple.com>
2602 Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
2604 * Scripts/webkitpy/port/ios.py:
2605 (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
2606 test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
2607 the Mountain Lion and Mavericks bots.
2609 2015-01-17 David Kilzer <ddkilzer@apple.com>
2611 Attempt to fix webkitpy tests on GTK Linux ports
2613 * Scripts/webkitpy/port/ios.py:
2614 (IOSPort.determine_full_port_name): Set a sensible default if
2615 not running on a Mac platform or if no iOS SDK is installed.
2617 2015-01-17 Jake Nielsen <jacob_nielsen@apple.com>
2619 Create iOS-EWS client queue
2620 https://bugs.webkit.org/show_bug.cgi?id=140476
2622 Reviewed by Alexey Proskuryakov.
2624 * EWSTools/start-queue-mac.sh:
2625 Adds call to configure-xcode-for-ios-development for iOS EWS.
2626 * Scripts/webkitpy/common/config/ews.json:
2627 Adds the iOS EWS config entry.
2628 * Scripts/webkitpy/common/config/ports.py:
2629 (DeprecatedPort.port):
2630 Adds IOSPort to the port map.
2632 (IOSPort.build_webkit_command):
2633 Adds --sdk=iphoneos to the webkit build command.
2634 * Scripts/webkitpy/port/base.py:
2635 (Port.architecture):
2636 Adds an accessor for the architecture member variable.
2637 * Scripts/webkitpy/port/factory.py:
2639 Adds IOSPort to the port class list.
2640 * Scripts/webkitpy/port/ios.py:
2641 Adds the IOSPort to encapsulate iOS-specific things.
2643 (IOSPort.determine_full_port_name):
2645 (IOSPort._build_driver_flags):
2646 (IOSPort.operating_system):
2647 * Scripts/webkitpy/tool/commands/download_unittest.py:
2648 Adds the archetecture option to the mock options.
2649 (DownloadCommandsTest._default_options):
2650 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2651 Appends the archetecture option into calls to webkit-patch.
2652 (AbstractEarlyWarningSystem.review_patch):
2653 (AbstractEarlyWarningSystem.run_command):
2654 (AbstractEarlyWarningSystem.load_ews_classes):
2655 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2656 Adds logic to soothe the unittest now that --architecture is being
2657 thrown around everywhere.
2658 (EarlyWarningSystemTest._default_expected_logs):
2659 * Scripts/webkitpy/tool/commands/queues.py:
2660 Adds glue code to ferry the --architecture option around.
2661 (AbstractQueue.__init__):
2662 (PatchProcessingQueue.begin_work_queue):
2663 * Scripts/webkitpy/tool/steps/abstractstep.py:
2664 Adds the archetecture option to all AbstractSteps so that
2665 EarlyWarningSystem doesn't start shoving --architecture into
2666 unsuspecting commands.
2667 (AbstractStep.options):
2668 * Scripts/webkitpy/tool/steps/build.py:
2669 Translates the --architecture option into an ARCHS= format to pass to
2672 * Scripts/webkitpy/tool/steps/options.py:
2673 Adds a definition for the --architecture option.
2676 2015-01-16 Sam Weinig <sam@webkit.org>
2678 Add a basic configuration object for WKView
2679 https://bugs.webkit.org/show_bug.cgi?id=140559
2681 Reviewed by Anders Carlsson.
2683 Add tests for WKPageConfigurationRef.
2685 * TestWebKitAPI/PlatformWebView.h:
2686 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2687 * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
2688 (TestWebKitAPI::TEST):
2689 (TestWebKitAPI::didFinishLoadForFrame):
2690 (TestWebKitAPI::setPageLoaderClient):
2691 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2692 (TestWebKitAPI::PlatformWebView::initialize):
2693 (TestWebKitAPI::PlatformWebView::PlatformWebView):
2695 2015-01-16 Myles C. Maxfield <mmaxfield@apple.com>
2697 WeakPtr functions crash when created with default constructor
2698 https://bugs.webkit.org/show_bug.cgi?id=140479
2700 Reviewed by Andreas Kling.
2702 Add WeakPtr API tests.
2704 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2705 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
2706 * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
2708 2015-01-16 Chris Dumez <cdumez@apple.com>
2710 Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
2711 https://bugs.webkit.org/show_bug.cgi?id=140568
2713 Reviewed by Alexey Proskuryakov.
2715 Fix the script parsing CSSPropertyNames.in to stop splitting lines
2716 on '=' sign. The '=' sign is also used in StyleBuilder parameters:
2717 e.g. "Longhands=background-position-x|background-position-y".
2718 This would confuse the script and treat this as a CSS property:
2719 "background-position-x|background-position-y".
2721 We now split on white space and treat the first string on the line
2722 to be the property name (this is the syntax in this file).
2724 * Scripts/webkitpy/w3c/test_converter.py:
2725 (_W3CTestConverter.__init__):
2726 (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2728 2015-01-16 Daniel Bates <dabates@apple.com>
2730 REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
2731 https://bugs.webkit.org/show_bug.cgi?id=135589
2733 Reviewed by David Kilzer.
2735 Derived from a patch by David Farler.
2737 Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
2738 run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
2739 in terms of the simctl command line utility.
2741 * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
2742 (eraseIOSSimulatorDevice): Added.
2743 (bootedIOSSimulatorDevice): Added.
2744 (iosSimulatorApplicationsPath): Added.
2745 (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
2746 (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
2747 (quitIOSSimulator): Added.
2748 (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
2749 the specified name and currently selected iOS runtime.
2750 (isIOSSimulatorSystemInstalledApp): Added.
2751 (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
2752 (deleteiOSSimulatorDevice): Deleted.
2753 (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
2754 (installAndLaunchIOSWebKitAppInSimulator): Deleted.
2756 2015-01-16 Alex Christensen <alex.christensen@flexsim.com>
2758 Resurrect the WinCairo bot.
2759 https://bugs.webkit.org/show_bug.cgi?id=139908
2761 Reviewed by Csaba Osztrogonác.
2763 * BuildSlaveSupport/build.webkit.org-config/config.json:
2764 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2765 (appendCustomBuildFlags):
2766 * BuildSlaveSupport/test-result-archive:
2767 (archiveTestResults):
2768 Add WinCairo buildbot.
2770 2015-01-16 Chris Dumez <cdumez@apple.com>
2772 webkit-patch should auto-install the keyring python module
2773 https://bugs.webkit.org/show_bug.cgi?id=140547
2775 Reviewed by David Kilzer.
2777 Auto-install the keyring python module. This is the module that
2778 webkit-patch uses for cross-platform access to the keyring
2781 Without this module, if the password if not in the keychain,
2782 webkit-patch will keep asking for your username / password and
2783 never remember them.
2785 * Scripts/webkitpy/common/net/credentials.py:
2786 * Scripts/webkitpy/thirdparty/__init__.py:
2787 (AutoinstallImportHook.find_module):
2788 (AutoinstallImportHook._install_keyring):
2790 2015-01-15 Csaba Osztrogonác <ossy@webkit.org>
2792 Remove ENABLE(SQL_DATABASE) guards
2793 https://bugs.webkit.org/show_bug.cgi?id=140434
2795 Reviewed by Darin Adler.
2797 * Scripts/webkitperl/FeatureList.pm:
2799 2015-01-15 Daniel Bates <dabates@apple.com>
2801 [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
2802 https://bugs.webkit.org/show_bug.cgi?id=139685
2803 <rdar://problem/19281317>
2805 Reviewed by Simon Fraser.
2807 Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
2808 the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
2810 Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
2811 as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
2812 before DRT dumps the output of a test. In particular, the WebThread may start a new page
2813 load (say, as a result of continued JavaScript execution), which will ultimately lead to
2814 dumping the test result again. Instead we want DRT to dump the test result synchronously
2815 such that we capture the state of the web page either when the page is loaded or when
2816 window.testRunner.notifyDone() is called.
2818 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2819 (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
2820 state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
2821 flush CA transactions to the window.
2822 * DumpRenderTree/mac/DumpRenderTree.mm:
2823 (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
2824 compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
2825 (dump): Renamed; formerly named dumpTestResults().
2826 (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
2827 enabling repaint support on iOS.
2828 (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
2829 (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
2830 (dumpTestResults): Deleted.
2832 2015-01-15 Brent Fulgham <bfulgham@apple.com>
2834 [Win] Miscellaneous DRT fixes
2835 https://bugs.webkit.org/show_bug.cgi?id=116562
2837 Reviewed by Tim Horton.
2839 While investigating the cause of several Windows crashes, I found:
2840 (1) Messy conversions to and from BSTR types
2841 (2) Weird mixes of wide-string and narrow string conversions
2842 (3) Passing nullptr to some CoreFoundation routines that do not
2843 permit null arguments.
2844 (4) Commands to link the executable to the VS2005 runtime.
2846 This patch cleans up these issues to improve DRT reliability on
2849 * DumpRenderTree/cg/ImageDiffCG.cpp:
2850 (main): Get rid of VS2005 runtime linking.
2851 * DumpRenderTree/win/DumpRenderTree.cpp:
2852 (urlSuitableForTestResult): Protect against being asked
2853 to process an empty URL.
2854 (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
2855 than converting to/from wchar_t buffers.
2856 (runTest): Simplify string and BSTR handling.
2857 (createWebViewAndOffscreenWindow): Ditto.
2858 (main): Get rid of VS2005 runtime linking.
2859 * DumpRenderTree/win/TestRunnerWin.cpp:
2860 (jsStringRefToWString): Simplify code.
2861 (TestRunner::pathToLocalResource):
2862 (TestRunner::setUserStyleSheetLocation):
2863 * TestWebKitAPI/win/main.cpp: Get rid of
2864 VS2005 runtime linking.
2865 * win/DLLLauncher/DLLLauncherMain.cpp:
2868 2015-01-15 Alexey Proskuryakov <ap@apple.com>
2870 Stop hardcoding mac-mountainlion in commit queue
2871 https://bugs.webkit.org/show_bug.cgi?id=140492
2873 Reviewed by Anders Carlsson.
2875 Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
2876 there should be no change in behavior, because:
2877 1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
2878 using it to create a port object.
2879 2. Although it doesn't convert the name before using DeprecatedPort.port(), it
2880 is actually correct to use "mac" for the name there. We only used to get the expected
2881 behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
2882 for unknown deprecated port names.
2884 * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
2886 2015-01-14 Jake Nielsen <jacob_nielsen@apple.com>
2888 Create iOS-EWS server queue
2889 https://bugs.webkit.org/show_bug.cgi?id=140473
2891 Reviewed by Benjamin Poulain.
2893 * QueueStatusServer/app.yaml: Updates the SVN version number.
2894 * QueueStatusServer/config/queues.py: Add ios-ews queue.
2895 * QueueStatusServer/model/queues.py:
2896 (Queue.display_name): Makes sure the display name is pretty!
2898 2015-01-14 Daniel Bates <dabates@apple.com>
2900 [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
2901 https://bugs.webkit.org/show_bug.cgi?id=140301
2902 <rdar://problem/19389266>
2904 Reviewed by Jon Honeycutt.
2906 Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
2907 with an unavailable runtime.
2909 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2910 (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
2911 which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
2912 specified runtime cannot be used because it is unavailable.
2913 * Scripts/webkitpy/port/ios.py:
2914 (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
2915 which was formerly named testing_device.
2916 * Scripts/webkitpy/xcode/simulator.py:
2917 (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
2918 more robust than looking up the simulator device by name and runtime. This approach also
2919 avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
2920 unavailable runtimes under the same iOS heading it would use to show it as available).
2921 (Simulator.find_device_by_udid): Added.
2922 (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
2923 to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
2924 (Simulator.available_runtimes): Added.
2925 (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
2926 of the reverse=True argument to sorted() to sort the list of available runtimes such that the
2927 first element of the sorted list is the runtime with the highest version number.
2928 (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
2930 2015-01-14 Csaba Osztrogonác <ossy@webkit.org>
2932 Remove WK2 Windows cruft
2933 https://bugs.webkit.org/show_bug.cgi?id=140440
2935 Reviewed by Anders Carlsson.
2937 * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
2938 * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
2939 * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
2941 2015-01-13 Hunseop Jeong <hs85.jeong@samsung.com>
2943 Fix TestWTF failed in TestWebKitAPI
2944 https://bugs.webkit.org/show_bug.cgi?id=140333
2946 Reviewed by Sam Weinig.
2948 Clear the std::ostringstream before starting test.
2950 * TestWebKitAPI/Tests/WTF/RefLogger.h:
2951 (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
2953 2015-01-13 Michael Catanzaro <mcatanzaro@igalia.com>
2955 TestWebKitWebContext depends on British English spellcheck dictionary
2956 https://bugs.webkit.org/show_bug.cgi?id=140403
2958 Reviewed by Martin Robinson.
2960 Install all English hunspell dictionaries on Fedora and Arch.
2962 * gtk/install-dependencies:
2964 2015-01-13 Michael Catanzaro <mcatanzaro@igalia.com>
2966 [GTK] install-dependencies should grok dnf
2967 https://bugs.webkit.org/show_bug.cgi?id=140396
2969 Reviewed by Martin Robinson.
2971 Fedora: install dependencies with dnf if yum is not installed.
2973 * gtk/install-dependencies:
2975 2015-01-12 Hunseop Jeong <hs85.jeong@samsung.com>
2977 [EFL][GTK] Fix build after r178309
2978 https://bugs.webkit.org/show_bug.cgi?id=140381
2980 Reviewed by Gyuyoung Kim.
2982 * TestWebKitAPI/CMakeLists.txt: Added the API directory
2984 2015-01-11 Sam Weinig <sam@webkit.org>
2986 Remove support for SharedWorkers
2987 https://bugs.webkit.org/show_bug.cgi?id=140344
2989 Reviewed by Anders Carlsson.
2991 * Scripts/webkitperl/FeatureList.pm:
2993 2015-01-12 Anders Carlsson <andersca@apple.com>
2995 Make delegates conform to formal delegate protocols
2996 https://bugs.webkit.org/show_bug.cgi?id=140370
2998 Reviewed by Dan Bernstein.
3000 * DumpRenderTree/mac/TestRunnerMac.mm:
3001 (TestRunner::numberOfPendingGeolocationPermissionRequests):
3002 (TestRunner::setGeolocationPermission):
3004 2015-01-10 Michael Catanzaro <mcatanzaro@igalia.com>
3006 build-webkit: silence output of 'which'
3007 https://bugs.webkit.org/show_bug.cgi?id=140278
3009 Reviewed by Daniel Bates.
3011 Use a more elegent test for the existance of ninja and eclipse.
3013 * Scripts/webkitdirs.pm:
3014 (commandExists): Don't assume the command supports --version
3015 (canUseNinja): Use commandExists()
3016 (canUseEclipse): Use commandExists()
3018 2015-01-09 Sam Weinig <sam@webkit.org>
3020 Update the output format for run-api-tests
3021 https://bugs.webkit.org/show_bug.cgi?id=140332
3023 Reviewed by Dan Bernstein.
3025 Changes the output format for run-api-tests be a bit simpler (no longer
3026 indented based on suite, as we were not really using suite very well) but
3027 also include details in the case of failure.
3029 Changes verbose mode to no longer spew out the gtest default printer output,
3030 as the custom printer now includes the failure information.
3032 * Scripts/run-api-tests:
3035 Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
3036 with colorized variants and strip out leaks spew (the leaks can be added back using
3037 the new --show-leaks argument).
3039 * TestWebKitAPI/TestsController.cpp:
3040 (TestWebKitAPI::Printer::OnTestPartResult):
3041 (TestWebKitAPI::Printer::OnTestEnd):
3042 (TestWebKitAPI::TestsController::run):
3043 Implement a custom result printer that just prints out the information we want.
3045 2015-01-09 Sam Weinig <sam@webkit.org>
3047 TestWebKitAPI should print out the lists that fail at the end
3048 https://bugs.webkit.org/show_bug.cgi?id=140329
3050 Reviewed by Tim Horton.
3052 * Scripts/run-api-tests:
3054 Print out failures and timeouts in all modes, not just verbose.
3056 2015-01-07 Geoffrey Garen <ggaren@apple.com>
3058 Make bmalloc work with ASan
3059 https://bugs.webkit.org/show_bug.cgi?id=140194
3061 Reviewed by Mark Lam.
3063 * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
3064 ASan automatically (by forwarding to system malloc at runtime).
3066 2015-01-09 Daniel Bates <dabates@apple.com>
3068 [iOS] Make DumpRenderTree build with public SDK
3069 https://bugs.webkit.org/show_bug.cgi?id=140311
3071 Reviewed by Sam Weinig.
3073 Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
3074 header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
3075 Additionally, remove unused header CoreGraphics/CGFontDB.h.
3077 * DumpRenderTree/mac/DumpRenderTree.mm:
3078 (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
3080 2015-01-09 Alexey Proskuryakov <ap@apple.com>
3082 platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
3083 https://bugs.webkit.org/show_bug.cgi?id=140300
3085 Reviewed by Simon Fraser.
3087 * WebKitTestRunner/TestController.cpp:
3088 (WTR::TestController::createOtherPage):
3089 (WTR::TestController::updateWindowScaleForTest):
3090 (WTR::TestController::configureViewForTest):
3091 * WebKitTestRunner/TestController.h:
3093 2015-01-09 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
3095 Unreviewed. Moving myself to the committer section.
3097 * Scripts/webkitpy/common/config/contributors.json:
3099 2015-01-09 Carlos Garcia Campos <cgarcia@igalia.com>
3101 Add a script to check for platform layering violations
3102 https://bugs.webkit.org/show_bug.cgi?id=140248
3104 Reviewed by Darin Adler.
3106 It prints all the cases where files inside platform include
3107 headers that are not in platform directory.
3109 * Scripts/check-for-platform-layering-violations: Added.
3110 (get_platform_headers):
3111 (check_source_file):
3113 2015-01-08 Alexey Proskuryakov <ap@apple.com>
3115 [Mac WK2] Test snapshots are 1600x1200 on Retina devices
3116 https://bugs.webkit.org/show_bug.cgi?id=139884
3118 Reviewed by Tim Horton.
3120 * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
3121 Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
3122 what the "nominal resolution" is, but this appears to work in practice.
3124 2015-01-08 Brent Fulgham <bfulgham@apple.com>
3126 [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
3127 https://bugs.webkit.org/show_bug.cgi?id=140256
3129 Reviewed by Anders Carlsson.
3131 * DumpRenderTree/win/DumpRenderTree.cpp:
3132 (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
3133 running with heap validation checks.
3134 (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
3135 the "svg\\W3C-SVG-1.1" test directory.
3136 (removeFontFallbackIfPresent): Use nullptr instead of 0.
3137 * DumpRenderTree/win/TestRunnerWin.cpp:
3138 (TestRunner::clearPersistentUserStyleSheet): Ditto.
3140 2015-01-08 Alexey Proskuryakov <ap@apple.com>
3142 Follow-up to: When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
3143 https://bugs.webkit.org/show_bug.cgi?id=140218
3145 * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
3146 Undone an accidental change - check for self.has_crashed() again. This code path
3147 is for ports that don't have a signal handler printing #CRASHED when main process
3150 * Scripts/webkitpy/port/driver_unittest.py:
3151 (DriverTest.test_check_for_driver_crash.assert_crash):
3152 (DriverTest.test_check_for_driver_crash):
3153 Updated the tests, all changes are expected.
3155 2015-01-08 Alexey Proskuryakov <ap@apple.com>
3157 When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
3158 https://bugs.webkit.org/show_bug.cgi?id=140218
3160 Reviewed by Darin Adler.
3162 * Scripts/webkitpy/port/driver.py:
3163 (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
3164 "process crashed" condition. These don't make sense together - it's either a crash
3165 or a timeout, and we should detect those properly at a much lower level.
3166 (Driver.run_test): Ditto.
3167 (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
3170 * WebKitTestRunner/TestController.h:
3171 * WebKitTestRunner/TestController.cpp:
3172 (WTR::TestController::webProcessName):
3173 (WTR::TestController::processDidCrash):
3174 Factored out hardcoded child process names, as we now use these in two places.
3176 * WebKitTestRunner/TestInvocation.cpp:
3177 (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
3178 process name, so that it can be sampled (fixes sampling on Mavericks and above).
3180 2015-01-08 Zan Dobersek <zdobersek@igalia.com>
3182 Reorder my list of email addresses, keeping the Bugzilla address at the
3183 top since Bugzilla and other webkitpy scripts rely on that ordering.
3185 * Scripts/webkitpy/common/config/contributors.json:
3187 2015-01-08 Zan Dobersek <zdobersek@igalia.com>
3189 Moving myself to the reviewers section and updating
3190 the list of my email addresses.
3192 * Scripts/webkitpy/common/config/contributors.json:
3194 2015-01-07 Michael Catanzaro <mcatanzaro@igalia.com>
3196 [GTK] Build gtk-doc without gtkdoc-mktmpl
3197 https://bugs.webkit.org/show_bug.cgi?id=140225
3199 Reviewed by Darin Adler.
3201 Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
3202 don't modify the tmpl files that it generates, it's not doing anything
3207 (GTKDoc._run_gtkdoc_scangobj):
3208 (GTKDoc._run_gtkdoc_mktmpl): Deleted.
3210 2015-01-07 Gwang Yoon Hwang <yoon@igalia.com>
3212 [GTK][ThreadedCompositor] Add support for threaded compositor.
3213 https://bugs.webkit.org/show_bug.cgi?id=118265
3215 Reviewed by Martin Robinson.
3217 Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
3218 autotools build systems. The feature is disabled by default.
3219 And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
3220 from the feature flags.
3222 * Scripts/webkitperl/FeatureList.pm:
3224 2015-01-07 Daniel Bates <dabates@apple.com>
3226 [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3227 https://bugs.webkit.org/show_bug.cgi?id=137371
3229 Reviewed by David Kilzer.
3231 Use SPI wrapper headers instead of directly referencing private SPI headers.
3233 * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3234 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3235 * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3236 to the list of iOS header search directories so that we can include header UIKitSPI.h.
3237 * DumpRenderTree/mac/DumpRenderTree.mm:
3238 * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3239 * DumpRenderTree/mac/EventSendingController.mm:
3240 * DumpRenderTree/mac/TestRunnerMac.mm:
3242 2015-01-07 Commit Queue <commit-queue@webkit.org>
3244 Unreviewed, rolling out r178068.
3245 https://bugs.webkit.org/show_bug.cgi?id=140235
3247 Breaks the iOS build (Requested by enrica on #webkit).
3251 "[iOS] Make WebKit2 build with public iOS SDK and more build
3253 https://bugs.webkit.org/show_bug.cgi?id=137371
3254 http://trac.webkit.org/changeset/178068
3256 2015-01-07 Daniel Bates <dabates@apple.com>
3258 [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3259 https://bugs.webkit.org/show_bug.cgi?id=137371
3261 Reviewed by David Kilzer.
3263 Use SPI wrapper headers instead of directly referencing private SPI headers.
3265 * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3266 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3267 * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3268 to the list of header search directories so that we can include header UIKitSPI.h.
3269 * DumpRenderTree/mac/DumpRenderTree.mm:
3270 * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3271 * DumpRenderTree/mac/EventSendingController.mm:
3272 * DumpRenderTree/mac/TestRunnerMac.mm:
3274 2015-01-07 Brent Fulgham <bfulgham@apple.com>
3276 [Win] Unreviewed test change to improve run reproducibility
3278 * Scripts/webkitpy/port/win.py:
3279 (WinPort.default_child_processes): Run a single DRT instance to help
3280 identify failures caused by earlier test runs.
3282 2015-01-07 Myles C. Maxfield <mmaxfield@apple.com>
3284 Myles C. Maxfield is a reviewer now
3285 https://bugs.webkit.org/show_bug.cgi?id=140196
3287 Reviewed by Dean Jackson.
3289 * Scripts/webkitpy/common/config/contributors.json:
3291 2015-01-07 Myles C. Maxfield <mmaxfield@apple.com>
3293 Make webkit-patch try harder to find keychain credentials
3294 https://bugs.webkit.org/show_bug.cgi?id=140170
3296 Reviewed by Ryosuke Niwa.
3298 When the user manually enters a password into webkit-patch, we hand that off to the
3299 Keyring Python module. However, that module creates a generic password entry instead
3300 of an internet password entry. We should look for both kinds.
3302 * Scripts/webkitpy/common/net/credentials.py:
3303 (Credentials._run_security_tool):
3304 (Credentials._credentials_from_keychain):
3305 * Scripts/webkitpy/common/net/credentials_unittest.py:
3306 (test_security_output_parse_entry_not_found):
3307 (_assert_security_call):
3309 2015-01-06 Anders Carlsson <andersca@apple.com>
3311 Try to fix the Mountain Lion build.
3313 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3314 (TestWebKitAPI::didGetImageForMatchResult):
3316 2015-01-06 Alexey Proskuryakov <ap@apple.com>
3318 Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
3319 https://bugs.webkit.org/show_bug.cgi?id=140095
3321 Reviewed by Anders Carlsson.
3323 * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
3324 builds, but not in debug ones.
3326 2015-01-06 Brent Fulgham <bfulgham@apple.com>
3328 [Win] Extend WinLauncher with support for Page Zoom
3329 https://bugs.webkit.org/show_bug.cgi?id=140152
3331 Reviewed by Anders Carlsson.
3333 * WinLauncher/Common.cpp:
3335 * WinLauncher/WinLauncher.cpp:
3336 (WinLauncher::resetZoom):
3337 (WinLauncher::zoomIn):
3338 (WinLauncher::zoomOut):
3339 * WinLauncher/WinLauncher.h:
3340 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
3341 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3342 * win/DLLLauncher/DLLLauncherMain.cpp:
3345 2015-01-06 Anders Carlsson <andersca@apple.com>
3347 Fix API tests that are broken under HiDPI
3348 https://bugs.webkit.org/show_bug.cgi?id=140146
3350 Reviewed by Tim Horton.
3352 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3353 (TestWebKitAPI::didGetImageForMatchResult):
3354 NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
3356 * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3357 (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
3358 Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
3359 out in a window that has a backing scale factor of 1.
3361 * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3362 (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
3365 2015-01-06 Alexey Proskuryakov <ap@apple.com>
3367 ADDRESS_SANITIZER macro is overloaded
3368 https://bugs.webkit.org/show_bug.cgi?id=140130
3370 Reviewed by Anders Carlsson.
3372 * WebKitTestRunner/TestController.cpp: Use the new macro.
3374 2015-01-05 Joseph Pecoraro <pecoraro@apple.com>
3376 Remove some stale class names in check-for-inappropriate-objc-class-names
3377 https://bugs.webkit.org/show_bug.cgi?id=140104
3379 Reviewed by Darin Adler.
3381 * Scripts/check-for-inappropriate-objc-class-names:
3382 These UIWK* classes no longer exist.
3384 2015-01-05 Anders Carlsson <andersca@apple.com>
3386 heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
3387 https://bugs.webkit.org/show_bug.cgi?id=140096
3388 rdar://problem/19368938
3390 Reviewed by Alexey Proskuryakov.
3392 When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
3393 since clientInfo points to a web view, not the test controller.
3395 * WebKitTestRunner/TestController.cpp:
3396 (WTR::TestController::createOtherPage):
3398 2015-01-05 Hunseop Jeong <hs85.jeong@samsung.com>
3400 [EFL][GTK] WKPreferencesDefaults test failed after r177506
3401 https://bugs.webkit.org/show_bug.cgi?id=140077
3403 Reviewed by Csaba Osztrogonác.
3405 WebKit C SPI is available on EFL,GTK.
3406 Changed the define order to pass the API test.
3408 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3409 (TestWebKitAPI::TEST):
3411 2015-01-01 Alexey Proskuryakov <ap@apple.com>
3413 Simplify WebKitTestRunner timeout tracking
3414 https://bugs.webkit.org/show_bug.cgi?id=140036
3416 Reviewed by Darin Adler.
3418 The code for configuring timeouts was mostly dead, because run-webkit-tests never
3419 passes the --timeout option to WebKitTestRunner.
3421 * WebKitTestRunner/Options.h:
3422 * WebKitTestRunner/Options.cpp:
3423 (WTR::Options::Options):
3424 (WTR::OptionsHandler::OptionsHandler):
3425 (WTR::handleOptionTimeout): Deleted.
3426 Removed support for --timeout. Timeouts are passed for each test individually,
3427 and defaults are good enough for the rare cases where WebKitTestRunner is run
3428 manually without run-webkit-tests.
3430 * WebKitTestRunner/TestController.cpp:
3431 (WTR::TestController::TestController):
3432 (WTR::TestController::initialize):
3433 (WTR::TestController::resetStateToConsistentValues):
3434 (WTR::TestController::reattachPageToWebProcess):
3435 (WTR::TestController::runUntil):
3436 * WebKitTestRunner/TestController.h:
3437 Simplified runUntil by passing the actual timeout, not an enum.
3438 Increased short timeout for ASan enabled builds, as WebProcess launching takes
3441 * WebKitTestRunner/TestInvocation.cpp:
3442 (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
3444 * WebKitTestRunner/efl/TestControllerEfl.cpp:
3445 (WTR::TestController::platformRunUntil):
3446 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3447 (WTR::TestController::platformRunUntil):
3450 2015-01-02 Anders Carlsson <andersca@apple.com>
3452 Remove now unused storage tracker glue from DumpRenderTree
3453 https://bugs.webkit.org/show_bug.cgi?id=140045
3455 Reviewed by Darin Adler.
3457 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3458 * DumpRenderTree/StorageTrackerDelegate.h: Removed.
3459 * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
3460 * DumpRenderTree/TestRunner.cpp:
3461 (TestRunner::staticFunctions):
3462 (syncLocalStorageCallback): Deleted.
3463 (observeStorageTrackerNotificationsCallback): Deleted.
3464 (deleteAllLocalStorageCallback): Deleted.
3465 (deleteLocalStorageForOriginCallback): Deleted.
3466 (localStorageDiskUsageForOriginCallback): Deleted.
3467 (originsWithLocalStorageCallback): Deleted.
3468 * DumpRenderTree/TestRunner.h:
3469 * DumpRenderTree/mac/DumpRenderTree.mm:
3470 (allocateGlobalControllers):
3471 (releaseGlobalControllers):
3472 * DumpRenderTree/mac/DumpRenderTreeMac.h:
3473 * DumpRenderTree/mac/TestRunnerMac.mm:
3474 (TestRunner::syncLocalStorage): Deleted.
3475 (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3476 (TestRunner::observeStorageTrackerNotifications): Deleted.
3477 (TestRunner::deleteAllLocalStorage): Deleted.
3478 (TestRunner::originsWithLocalStorage): Deleted.
3479 (TestRunner::deleteLocalStorageForOrigin): Deleted.
3480 * DumpRenderTree/win/TestRunnerWin.cpp:
3481 (TestRunner::syncLocalStorage): Deleted.
3482 (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3483 (TestRunner::observeStorageTrackerNotifications): Deleted.
3484 (TestRunner::deleteAllLocalStorage): Deleted.
3485 (TestRunner::originsWithLocalStorage): Deleted.
3486 (TestRunner::deleteLocalStorageForOrigin): Deleted.
3488 2015-01-01 Darin Adler <darin@apple.com>
3490 We often misspell identifier as "identifer"
3491 https://bugs.webkit.org/show_bug.cgi?id=140025
3493 Reviewed by Michael Saboff.
3495 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3496 * Scripts/webkitdirs.pm:
3497 (appIdentifierFromBundle):
3498 (installAndLaunchIOSWebKitAppInSimulator):
3501 2015-01-01 Zalan Bujtas <zalan@apple.com>
3503 Saturated arithmetics: Incorrect float/double clamping.
3504 https://bugs.webkit.org/show_bug.cgi?id=139888
3505 rdar://problem/19330885
3507 Reviewed by Simon Fraser.
3509 Clamp float and double values correctly when applying saturated arithmetics.
3511 * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3512 (TestWebKitAPI::TEST):
3514 2014-12-30 Krzysztof Czech <k.czech@samsung.com>
3516 [EFL] Bump version of ATK used by jhbuild to 2.15.2
3517 https://bugs.webkit.org/show_bug.cgi?id=139816
3519 Reviewed by Gyuyoung Kim.
3521 Bump version of ATK used by jhbuild to 2.15.2
3523 * efl/jhbuild.modules:
3525 2014-12-29 Fabien Vallée <fvallee@connected-labs.com>
3527 [jhBuild] cairo build error (-flto)
3528 https://bugs.webkit.org/show_bug.cgi?id=139056
3530 Reviewed by Philippe Normand.
3532 cairo fails to link with gcc 4.9 due to lto
3533 related issue. This problem has been partially
3535 http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
3536 use the cairo --disable-lto option and remove jhbuild
3537 makeargs fixes the issue.
3539 * gtk/jhbuild.modules:
3540 * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
3542 2014-12-27 Myles C. Maxfield <mmaxfield@apple.com>
3543 [Mac] Enable kerning, ligatures, and printer fonts
3544 https://bugs.webkit.org/show_bug.cgi?id=139970
3546 Rubber stamped by Simon Fraser.
3550 * DumpRenderTree/mac/DumpRenderTree.mm:
3551 * WebKitTestRunner/TestController.cpp:
3552 * WebKitTestRunner/mac/main.mm:
3554 2014-12-26 Dan Bernstein <mitz@apple.com>
3556 <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
3557 https://bugs.webkit.org/show_bug.cgi?id=139950
3559 Reviewed by David Kilzer.
3561 * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
3562 in a manner that works with Xcode 5.1.1.
3564 2014-12-24 Dan Bernstein <mitz@apple.com>
3566 Engineering builds of MiniBrowser ignore deprecated declaration warnings
3567 https://bugs.webkit.org/show_bug.cgi?id=139941
3569 Reviewed by Darin Adler.
3571 * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
3572 * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
3574 * MiniBrowser/mac/AppDelegate.m:
3575 (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
3576 deprecated NSOKButton.
3578 2014-12-24 Youenn Fablet <youenn.fablet@crf.canon.fr>
3580 W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
3581 https://bugs.webkit.org/show_bug.cgi?id=134763
3583 Reviewed by Ryosuke Niwa.
3585 Adding an option to disable test harness link conversion.
3587 * Scripts/webkitpy/w3c/test_converter.py:
3588 (convert_for_webkit):
3589 (_W3CTestConverter.__init__):
3590 (_W3CTestConverter.convert_attributes_if_needed):
3591 * Scripts/webkitpy/w3c/test_importer.py:
3593 (TestImporter.import_tests):
3595 2014-12-23 Alexey Proskuryakov <ap@apple.com>
3597 DumpRenderTree crashes are mis-reported as timeouts on Yosemite
3598 https://bugs.webkit.org/show_bug.cgi?id=139933
3600 Reviewed by Daniel Bates.
3602 Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
3603 and there is no way for run-webkit-tests to tell a crashed process from a frozen one
3604 until ReportCrash lets it go.
3606 Reuse existing machinery that tells run-webkit-tests about crashes. The script may
3607 even get the actual crash log eventually - even when it times out waiting for the log, it
3608 makes a second lookup at the very end, after all tests finish. There may be further
3609 improvements needed here, but this small fix addresses most cases that happen in practice.
3611 * DumpRenderTree/mac/DumpRenderTree.mm:
3612 (writeCrashedMessageOnFatalError):
3614 Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
3616 * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
3619 2014-12-23 Alexey Proskuryakov <ap@apple.com>
3621 Don't force -O1 for debug ASan builds
3622 https://bugs.webkit.org/show_bug.cgi?id=139926
3624 Reviewed by Darin Adler.
3626 * asan/asan.xcconfig:
3628 2014-12-23 Alexey Proskuryakov <ap@apple.com>
3630 Simplify building with ASan
3631 https://bugs.webkit.org/show_bug.cgi?id=139916
3633 Reviewed by Mark Rowe.
3635 * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
3636 We could also update Configuration file format, but that's a little scary because
3637 of how many places in code read it.
3639 * Scripts/webkitdirs.pm:
3640 (determineASanIsEnabled): Read it from ASan configuration file.
3641 (argumentsForConfiguration): Added a FIXME.
3642 (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
3643 (XcodeOptions): Pass the options needed for ASan.
3645 * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
3646 no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
3649 2014-12-23 Alexey Proskuryakov <ap@apple.com>
3651 TestWebKitAPI build is broken when ASan is enabled
3652 https://bugs.webkit.org/show_bug.cgi?id=139902
3654 Reviewed by Darin Adler.