Fixed Layout Mode should be adjustable from layoutTestController for testing on Chrom...
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
2
3         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
4         https://bugs.webkit.org/show_bug.cgi?id=67723
5
6         Reviewed by Adam Barth.
7
8         * DumpRenderTree/chromium/EventSender.h:
9         * DumpRenderTree/chromium/LayoutTestController.cpp:
10         (LayoutTestController::LayoutTestController):
11         (LayoutTestController::enableFixedLayoutMode):
12         (LayoutTestController::setFixedLayoutSize):
13         * DumpRenderTree/chromium/LayoutTestController.h:
14
15 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
16
17         Add standalone script that filters the output of build-webkit to be more human-readable
18         https://bugs.webkit.org/show_bug.cgi?id=44081
19
20         Reviewed by Daniel Bates.
21
22         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
23         a build script (e.g. build-webkit) and it spits out a prettier version.
24         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
25         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
26
27 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
28
29         Add myself to committers.py                 
30         https://bugs.webkit.org/show_bug.cgi?id=67696
31
32         Reviewed by Kent Tamura.
33
34         * Scripts/webkitpy/common/config/committers.py:
35
36 2011-09-07  Adam Barth  <abarth@webkit.org>
37
38         rebaseline button in garden-o-matic details view should work
39         https://bugs.webkit.org/show_bug.cgi?id=67738
40
41         Reviewed by Dimitri Glazkov.
42
43         This patch wires up the rebaseline button in garden-o-matic results
44         details view.  The button is current per-test, so there isn't a way to
45         rebaseline individual bots.  This is a place to start.  If we decide we
46         want per-bot rebaselining, we'll need to think of some better UI.
47
48         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
49         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
50         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
51         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
52
53 2011-09-07  Eric Seidel  <eric@webkit.org>
54
55         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
56         https://bugs.webkit.org/show_bug.cgi?id=67737
57
58         Reviewed by Adam Barth.
59
60         I got a little over-eager when deprecating host.port_factory in the previous commit.
61         Turns out that Host.port_factory was already the "modern" port/factory.py
62         it was just the Module object.  I un-deprecated the variable, and changed it from
63         being the module to being an actual PortFactory, passing it a host object.
64         I also taught PortFactory how to set user/executive/filesystem in the kwargs
65         when instantiating a new Port object.
66         This magically fixed the test_rebaseline test, since its now no longer talking
67         to the real filesystem.
68
69         * Scripts/webkitpy/common/host.py:
70         * Scripts/webkitpy/layout_tests/port/factory.py:
71         * Scripts/webkitpy/tool/commands/queries.py:
72         * Scripts/webkitpy/tool/mocktool.py:
73
74 2011-09-07  Eric Seidel  <eric@webkit.org>
75
76         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
77         https://bugs.webkit.org/show_bug.cgi?id=67734
78
79         Reviewed by Adam Barth.
80
81         Right now every place that creates a Port object has to be very careful
82         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
83         The correct fix is for port/factory.py (which creates most port objects)
84         to know how to pass these in automatically.  However, currently all port/factory.py
85         functions are free functions instead of being on an object.  This patch
86         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
87
88         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
89         pass along the proper scm/user/filesystem to the Port object.
90
91         * Scripts/webkitpy/common/host.py:
92         * Scripts/webkitpy/layout_tests/port/factory.py:
93         * Scripts/webkitpy/tool/commands/queries.py:
94         * Scripts/webkitpy/tool/mocktool.py:
95
96 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
97
98         Unreviewed, rolling out r94441.
99         http://trac.webkit.org/changeset/94441
100         https://bugs.webkit.org/show_bug.cgi?id=67731
101
102         "MacEWSes are backed up due to new machines not able to reach
103         git.webkit.org.  Disabling tests for now" (Requested by
104         eseidel2 on #webkit).
105
106         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
107
108 2011-09-07  Elliot Poger  <epoger@google.com>
109
110         filter test_expectations properly for chromium-mac vs chromium-cg-mac
111         https://bugs.webkit.org/show_bug.cgi?id=67324
112
113         Reviewed by Dirk Pranke.
114
115         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
116         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
117         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
118         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
119         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
120
121 2011-09-07  Eric Boren  <borenet@gmail.com>
122
123         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
124         https://bugs.webkit.org/show_bug.cgi?id=66800
125
126         Reviewed by Darin Fisher.
127
128         * DumpRenderTree/chromium/EventSender.cpp:
129         (EventSender::sendCurrentTouchEvent):
130
131 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
132
133         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
134         https://bugs.webkit.org/show_bug.cgi?id=67254
135
136         Reviewed by Csaba Osztrogonác.
137
138         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
139         derived from the running location of DumpRenderTree binary.
140
141         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
142         (LayoutTestController::pathToLocalResource):
143         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
144
145 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
146
147         REGRESSION(r94288) build-webkit doesn't work on Symbian
148         https://bugs.webkit.org/show_bug.cgi?id=67706
149
150         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
151         (buildQMakeProject):
152
153 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
154
155         REGRESSION(r94288) build-webkit doesn't work on Windows
156         https://bugs.webkit.org/show_bug.cgi?id=67646
157
158         Roll back r94655 with a small fix.
159
160         * Scripts/webkitdirs.pm:
161         (buildQMakeProject):
162
163 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
164
165         Unreviewed, rolling out r94635.
166         http://trac.webkit.org/changeset/94635
167         https://bugs.webkit.org/show_bug.cgi?id=67704
168
169         Linux Touch build is failing to compile this change.
170         (Requested by loislo on #webkit).
171
172         * DumpRenderTree/chromium/EventSender.cpp:
173         (EventSender::sendCurrentTouchEvent):
174
175 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
176
177         Unreviewed, rolling out r94655.
178         http://trac.webkit.org/changeset/94655
179         https://bugs.webkit.org/show_bug.cgi?id=67703
180
181         It broke Leopard debug bot (Requested by ossy on #webkit).
182
183         * Scripts/webkitdirs.pm:
184
185 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
186
187         REGRESSION(r94288) build-webkit doesn't work on Windows
188         https://bugs.webkit.org/show_bug.cgi?id=67646
189
190         Reviewed by Csaba Osztrogonác.
191
192         * Scripts/webkitdirs.pm:
193
194 2011-09-06  Eric Boren  <borenet@gmail.com>
195
196         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
197         https://bugs.webkit.org/show_bug.cgi?id=66800
198
199         Reviewed by Darin Fisher.
200
201         * DumpRenderTree/chromium/EventSender.cpp:
202         (EventSender::sendCurrentTouchEvent):
203
204 2011-09-06  Adam Barth  <abarth@webkit.org>
205
206         garden-o-matic details view should having working rebaseline and next/previous buttons
207         https://bugs.webkit.org/show_bug.cgi?id=67659
208
209         Reviewed by Dimitri Glazkov.
210
211         This patch wires up basic back/forward buttons that let you traverse
212         through the results we're examining in the details view.  This ended up
213         being more code than I expected, but I wanted to keep all the state
214         information in the DOM itself.
215
216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
219
220 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
221
222         fix MockFileSystem.glob(), refactor filesystem tests
223         https://bugs.webkit.org/show_bug.cgi?id=67462
224
225         Reviewed by Eric Seidel.
226
227         In debugging why my proposed change for MockFileSystem.glob()
228         in bug 66228 didn't work, I stumbled across two real bugs
229         that cancelled each other out for the unit tests. I fixed those
230         (glob shouldn't recurse into subdirs, and we weren't populating
231         self.dirs from self.files properly).
232
233         I have also created a "mixin" class for tests that can be shared
234         between the real filesystem and the mock filesystem - MockFileSystem
235         is being used enough it needs its own tests.
236
237         * Scripts/webkitpy/common/system/filesystem_mock.py:
238         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
239         * Scripts/webkitpy/common/system/filesystem_unittest.py:
240
241 2011-09-06  Anders Carlsson  <andersca@apple.com>
242
243         Move NPAPI headers in bridge to plugins
244         https://bugs.webkit.org/show_bug.cgi?id=67661
245
246         Update forwarding headers.
247
248         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
249         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
250
251 2011-09-06  Tony Chang  <tony@chromium.org>
252
253         [chromium] Check in 'build' for compiled binaries first
254         https://bugs.webkit.org/show_bug.cgi?id=67549
255
256         Reviewed by Dirk Pranke.
257
258         I'm working on moving the windows build output to a common location
259         rather than relative to the sln file.  Because of that, we need to
260         check those build locations first for DumpRenderTree.exe.
261
262         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
263
264 2011-09-06  Adam Barth  <abarth@webkit.org>
265
266         Use a hierarchial structure for the garden-o-matic results view
267         https://bugs.webkit.org/show_bug.cgi?id=67620
268
269         Reviewed by Dimitri Glazkov.
270
271         This patch re-organizes the results view to use a hierachial structure
272         for selection.  At the top-level are sections for each test.  Expanding
273         the test section shows a tab selector for builders.
274
275         This structure prepares us for wiring up various actions to this view.
276
277         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
278         (.):
279         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
280         ():
281         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
282         (.):
283         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
284         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
285         (.results-view>.toolbar):
286         (.results-view>.toolbar ul.actions):
287         (.results-view>.toolbar ul.actions li):
288         (.results-grid table):
289         (.results-grid table td, .results-view table th):
290         (.results-grid table th):
291         (.results-grid .text-result):
292         (.results-grid .image-result):
293
294 2011-09-06  Adam Barth  <abarth@webkit.org>
295
296         garden-o-matic's base.probe generates spam in the JavaScript console
297         https://bugs.webkit.org/show_bug.cgi?id=67622
298
299         Reviewed by Dimitri Glazkov.
300
301         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
302         instead of HTMLScriptElement to test whether results exist.  This
303         reduces the console.log spam and saves bandwidth because we can use a
304         HEAD request instead of a GET request.
305
306         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
307
308 2011-09-05  Adam Barth  <abarth@webkit.org>
309
310         Add a tab to garden-o-matic for viewing expected failures
311         https://bugs.webkit.org/show_bug.cgi?id=67619
312
313         Reviewed by Dimitri Glazkov.
314
315         This patch adds a basic tab to garden-o-matic that shows all the tests
316         failing on the bots, including the expected failures.  This patch
317         mostly involves refactoring existing classes to allow new subclasses.
318
319         This view is useful for when gardeners mark tests as expected to fail
320         and then rebaseline them later.
321
322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
323         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
324         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
325         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
326         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
327         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
328         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
329
330 2011-09-05  Adam Barth  <abarth@webkit.org>
331
332         Fix global variable leak in garden-o-matic
333         https://bugs.webkit.org/show_bug.cgi?id=67617
334
335         Reviewed by Dimitri Glazkov.
336
337         Caught by running the unit tests with noglobals turned on.
338
339         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
340
341 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
342
343         [Qt][WK2] Add pixel test support
344         https://bugs.webkit.org/show_bug.cgi?id=66283
345
346         Reviewed by Andreas Kling.
347
348         Implemented pixel result generation by reusing the logic
349         that we have in DumpRenderTree.
350         * WebKitTestRunner/qt/TestInvocationQt.cpp:
351         (WTR::dumpImage):
352         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
353
354 2011-09-04  Robin Dunn  <robin@alldunn.com>
355
356         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
357         https://bugs.webkit.org/show_bug.cgi?id=67577
358
359         Reviewed by Kevin Ollivier.
360
361         * waf/build/settings.py:
362
363 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
364
365         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
366
367         * waf/build/settings.py:
368
369 2011-09-03  Dan Bernstein  <mitz@apple.com>
370
371         32-bit build fix.
372
373         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
374         (TestWebKitAPI::Util::toSTD):
375
376 2011-09-03  Dan Bernstein  <mitz@apple.com>
377
378         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
379         https://bugs.webkit.org/show_bug.cgi?id=67559
380
381         Reviewed by Darin Adler.
382
383         * DumpRenderTree/mac/DumpRenderTree.mm:
384         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
385         the call to it.
386         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
388         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
389         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
390         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
391         (TestWebKitAPI::Util::toSTD): Added.
392
393 2011-09-03  Adam Barth  <abarth@webkit.org>
394
395         garden-o-matic results view should have a better results selector
396         https://bugs.webkit.org/show_bug.cgi?id=67542
397
398         Reviewed by Dimitri Glazkov.
399
400         This patch adds a basic grid-based results selector to the results
401         view.  Currently, this grid just shows how the tests fail on the
402         various bots.  A future patch will let you select which failure to view
403         and to mark the failures for rebaselining.
404
405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
407           - Add some more basic functions for manipulating dictionaries.
408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
411
412 2011-09-03  Adam Barth  <abarth@webkit.org>
413
414         garden-o-matic results view should show Actual and Expected results for text failures
415         https://bugs.webkit.org/show_bug.cgi?id=67536
416
417         Reviewed by Eric Seidel.
418
419         In the past, we didn't show actual and expected text results (we just
420         showed the diff) because we didn't have the awesome six-by-two results
421         grid.  Now that we do, we can move show these results.
422
423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
425           - Fixed some typos that were preventing these unit tests from running.
426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
427         (.):
428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
429           - Report -actual.txt and -expected.txt as possible results URLs.
430
431 2011-09-03  Adam Barth  <abarth@webkit.org>
432
433         garden-o-matic shows "ghost" failures that are already fixed
434         https://bugs.webkit.org/show_bug.cgi?id=67535
435
436         Reviewed by Eric Seidel.
437
438         About 10% of writes fail to stick on test-results.appspot.com.  This
439         patch causes us to fetch the full_results.json blob directly from
440         build.chromium.org rather than relying upon AppEngine.
441
442         Unforuntately, we still need to get historical information from
443         AppEngine.  That will take several patches to fix becuase I need to
444         change the bots to write the full_results.json file to the
445         build-specific directory in addition to the zip file.
446
447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
449         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
450
451 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
452
453         Unreviewed, rolling out r94458.
454         http://trac.webkit.org/changeset/94458
455         https://bugs.webkit.org/show_bug.cgi?id=67558
456
457         Caused appcache test to fail on various bots (Requested by
458         rniwa on #webkit).
459
460         * Scripts/webkitpy/layout_tests/port/webkit.py:
461         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
462
463 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
464
465         Unreviewed, rolling out r94453.
466         http://trac.webkit.org/changeset/94453
467         https://bugs.webkit.org/show_bug.cgi?id=67557
468
469         Caused appcache test to fail on various bots (Requested by
470         rniwa on #webkit).
471
472         * Scripts/webkitpy/layout_tests/port/webkit.py:
473
474 2011-09-02  Michael Saboff  <msaboff@apple.com>
475
476         Add JSC:RegExp functional tests
477         https://bugs.webkit.org/show_bug.cgi?id=67339
478
479         New perl script to build JavaScriptCore and run the RegExp tests.
480
481         Reviewed by Gavin Barraclough.
482
483         * Scripts/run-regexp-tests: Added.
484
485 2011-09-02  Michael Saboff  <msaboff@apple.com>
486
487         Add JSC:RegExp functional tests
488         https://bugs.webkit.org/show_bug.cgi?id=67339
489
490         New perl script to build JavaScriptCore and run the RegExp tests.
491
492         Reviewed by Gavin Barraclough.
493
494         * Scripts/run-regexp-tests: Added.
495
496 2011-09-02  Eric Seidel  <eric@webkit.org>
497
498         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
499         https://bugs.webkit.org/show_bug.cgi?id=67530
500
501         Unreviewed.  Fixing typo from previous commit.
502
503         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
504         which exercises the code I previously made a typo in.
505
506         * Scripts/webkitpy/layout_tests/port/webkit.py:
507         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
508
509 2011-09-02  Eric Seidel  <eric@webkit.org>
510
511         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
512         https://bugs.webkit.org/show_bug.cgi?id=67530
513
514         Reviewed by Adam Barth.
515
516         No functional change, just reshuffling code.
517
518         * Scripts/webkitpy/layout_tests/port/webkit.py:
519
520 2011-09-02  Darin Adler  <darin@apple.com>
521
522         Added Subversion ignore for .pyc generated files.
523
524         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
525         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
526         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
527
528 2011-09-02  Adam Barth  <abarth@webkit.org>
529
530         Enable testing on mac-ews
531         https://bugs.webkit.org/show_bug.cgi?id=67505
532
533         Reviewed by Eric Seidel.
534
535         This patch enables testing on the Mac EWS, which should help
536         contributors not turn the Mac bots red.
537
538         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
539
540 2011-09-01  Beth Dakin  <bdakin@apple.com>
541
542         https://bugs.webkit.org/show_bug.cgi?id=67451
543         Add a test for going back to a cached page after changing the device scale factor
544
545         Reviewed by Adam Roben.
546
547         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
548         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
549         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
550         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
551         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
552         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
553         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
554         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
555         (TestWebKitAPI::TEST_F):
556
557         Added new function to WebKitAgnosticTest to goBack. Separated 
558         waitForLoadToFinish() into its own function (instead of being a part of 
559         loadAndWaitUntilFinished()) so that it can be called from goBack as 
560         well. Also added initializeView() so we can set the cache model.
561         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
562         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
563         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
564         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
565         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
566         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
567         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
568         (TestWebKitAPI::WebKitAgnosticTest::goBack):
569         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
570
571 2011-09-02  Anders Carlsson  <andersca@apple.com>
572
573         Build fix.
574
575         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
576         (PrivateBrowsing::ScriptableObject::pluginTest):
577
578 2011-09-02  Anders Carlsson  <andersca@apple.com>
579
580         Move private browsing test to a PluginTest subclass
581         https://bugs.webkit.org/show_bug.cgi?id=67498
582
583         Reviewed by Darin Adler.
584
585         * DumpRenderTree/DumpRenderTree.gypi:
586         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
587         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
588         (pluginGetProperty):
589         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
590         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
591         (PluginTest::NPP_SetValue):
592         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
593         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
594         (PrivateBrowsing::PrivateBrowsing):
595         (PrivateBrowsing::privateBrowsingEnabled):
596         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
597         (PrivateBrowsing::ScriptableObject::hasProperty):
598         (PrivateBrowsing::ScriptableObject::getProperty):
599         (PrivateBrowsing::ScriptableObject::pluginTest):
600         (PrivateBrowsing::NPP_New):
601         (PrivateBrowsing::NPP_GetValue):
602         (PrivateBrowsing::NPP_SetValue):
603         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
604         (NPP_New):
605         (NPP_SetValue):
606         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
607         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
608         * GNUmakefile.am:
609
610 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
611
612         [Qt] Build dependency problems
613         https://bugs.webkit.org/show_bug.cgi?id=38054
614
615         Trivial fix after r94288.
616
617         Rubber-stamped by Andras Becsi.
618
619         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
620         (buildQMakeProject):
621
622 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
623
624         Remove my old e-mail address and add my new one.
625
626         Rubber-stamped by Tor Arne Vestbø.
627
628         * Scripts/webkitpy/common/config/committers.py:
629
630 2011-09-02  Philippe Normand  <pnormand@igalia.com>
631
632         [GTK] run-gtk-tests leaves a zombie Xvfb process
633         https://bugs.webkit.org/show_bug.cgi?id=67389
634
635         Reviewed by Martin Robinson.
636
637         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
638         child process instead of doing shell redirection.
639
640 2011-09-01  Mark Rowe  <mrowe@apple.com>
641
642         Fix the build by adding some more missing return types.
643
644         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
645         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
646
647 2011-09-01  Eric Seidel  <eric@webkit.org>
648
649         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
650         https://bugs.webkit.org/show_bug.cgi?id=66228
651
652         Reviewed by Dirk Pranke.
653
654         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
655         The LeaksViewer tool globs for all *-leaks.txt files.
656         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
657
658         In order to test this I had to fix a limitation in our MockFileSystem.glob
659         method.  However, doing so uncovered a typo and bug in the integration tests.
660         I've disabled the offending integration tests.
661
662         * Scripts/webkitpy/common/system/filesystem_mock.py:
663         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
664         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
665
666 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
667
668         Adds a LayoutTestController method to make it possible to test
669         starting speech input via an API call.
670         https://bugs.webkit.org/show_bug.cgi?id=60170
671
672         Reviewed by Dimitri Glazkov.
673
674         * DumpRenderTree/LayoutTestController.h:
675         * DumpRenderTree/chromium/LayoutTestController.cpp:
676         (LayoutTestController::LayoutTestController):
677         (LayoutTestController::startSpeechInput):
678         * DumpRenderTree/chromium/LayoutTestController.h:
679         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
680         (LayoutTestController::startSpeechInput):
681         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
682         (LayoutTestController::startSpeechInput):
683         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
684         (LayoutTestController::startSpeechInput):
685         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
686         (LayoutTestController::startSpeechInput):
687         * DumpRenderTree/qt/LayoutTestControllerQt.h:
688         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
689         (LayoutTestController::startSpeechInput):
690         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
691         (LayoutTestController::startSpeechInput):
692
693 2011-09-01  Tim Horton  <hortont424@gmail.com>
694
695         Fix TestWebKitAPI build on clang-2.0
696
697         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
698
699 2011-09-01  Adam Barth  <abarth@webkit.org>
700
701         Remove unused "extension" parameter from rebaseline gardeningserver handler
702         https://bugs.webkit.org/show_bug.cgi?id=67384
703
704         Reviewed by James Robinson.
705
706         This parameter hasn't done anything in a while.
707
708         * Scripts/webkitpy/tool/commands/rebaseline.py:
709         * Scripts/webkitpy/tool/servers/gardeningserver.py:
710         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
711
712 2011-09-01  Eric Seidel  <eric@webkit.org>
713
714         Unreviewed.
715
716         Fix a typo in unittests.  Unfortunately fixing it
717         caused several assertions.  Just disabling the test
718         instead, since it was providing no value before due to the typo.
719
720         * Scripts/webkitpy/layout_tests/port/test.py:
721
722 2011-09-01  Adam Barth  <abarth@webkit.org>
723
724         Add a "rebaseline" button to the garden-o-matic summary page
725         https://bugs.webkit.org/show_bug.cgi?id=67382
726
727         Reviewed by Dimitri Glazkov.
728
729         As much as we might wish folks to not rebaseline entire test groups at
730         once, the truth is that doing so is a common operation.  Adding a
731         button for this operation is likely to make folks happy.
732
733         This patch also cleans up a bunch of plumbing surrounding failureInfo
734         objects.
735
736         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
737         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
738         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
739         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
740         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
742         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
743         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
744         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
745         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
746
747 2011-09-01  Adam Barth  <abarth@webkit.org>
748
749         garden-o-matic should let the gardener assign blame for a group of test failures
750         https://bugs.webkit.org/show_bug.cgi?id=67379
751
752         Reviewed by Dimitri Glazkov.
753
754         If a group of test failures has a large revision range, the gardener
755         might wish to blame a specific revision for the failure.  Currently,
756         this only effect of assigning blame in this way is to hide the other
757         suspect commits.
758
759         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
762
763 2011-09-01  Adam Barth  <abarth@webkit.org>
764
765         Hide garden-o-matic failure table until hover
766         https://bugs.webkit.org/show_bug.cgi?id=67376
767
768         Reviewed by Dimitri Glazkov.
769
770         This patch removes the failure table for build failures (because it
771         does not make sense) and hides the failure table for test groups until
772         the user hovers over the test failure block, reducing visual noise.
773
774         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
775         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
777
778 2011-09-01  Adam Barth  <abarth@webkit.org>
779
780         Switch garden-o-matic from commitData.title to commitData.summary
781         https://bugs.webkit.org/show_bug.cgi?id=67375
782
783         Reviewed by Dimitri Glazkov.
784
785         commitData.title is a string provided by Trac, which isn't great in all
786         cases.  commitData.summary is my attempt to find the most important
787         one-line summary of the commit.  This patch switches garden-o-matic
788         over to summary.
789
790         Also, this patch tweaks a bunch of CSS to tighten up the summary page
791         and reduce visual noise.
792
793         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
794         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
795         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
796
797 2011-09-01  Adam Barth  <abarth@webkit.org>
798
799         Group failing tests in garden-o-matic if there are more than three in a folder
800         https://bugs.webkit.org/show_bug.cgi?id=67373
801
802         Reviewed by Dimitri Glazkov.
803
804         Sometimes a failure will cause many tests in a given directory to fail.
805         When that happens, it's better to list the directory as a single item
806         (with a count) rather than spamming all the test names.
807
808         (This patch also updates a bunch of unit test expected results after my last commit.)
809
810         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
811         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
814         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
815
816 2011-09-01  Adam Barth  <abarth@webkit.org>
817
818         Lower the visual noise from the failing builders display
819         https://bugs.webkit.org/show_bug.cgi?id=67369
820
821         Reviewed by Dimitri Glazkov.
822
823         This patch ensures that the "Building" row in the failing builders
824         display is always last and dims it by 50% to reduce visual noise.  This
825         lets the gardener focus on the actual failures.
826
827         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
828         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
829         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
830
831 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
832
833         [Qt] Build dependency problems
834         https://bugs.webkit.org/show_bug.cgi?id=38054
835
836         Make clean build after the defines are changed.
837
838         Reviewed by Csaba Osztrogonác.
839
840         * Scripts/webkitdirs.pm:
841         (buildQMakeProject):
842
843 2011-08-31  Adam Barth  <abarth@webkit.org>
844
845         Move DumpRenderTree to WebKitPlatformSupport
846         https://bugs.webkit.org/show_bug.cgi?id=67331
847
848         Reviewed by Darin Fisher.
849
850         This patch update DumpRenderTree to account for the WebKitClient =>
851         WebKitPlatformSupport rename.
852
853         * DumpRenderTree/chromium/NotificationPresenter.cpp:
854         (NotificationPresenter::show):
855         * DumpRenderTree/chromium/Task.cpp:
856         (postTask):
857
858 2011-08-31  Eric Seidel  <eric@webkit.org>
859
860         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
861         https://bugs.webkit.org/show_bug.cgi?id=67314
862
863         Reviewed by Adam Barth.
864
865         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
866         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
867         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
868
869         I also moved a bunch of code into dashboard.css which belonged there.
870
871         * QueueStatusServer/handlers/activebots.py: Added.
872         * QueueStatusServer/main.py:
873         * QueueStatusServer/stylesheets/dashboard.css:
874         (.queue_bubble):
875         (.queue_name):
876         (.last_heard_from):
877         (.status_text):
878         (.alive):
879         (.behind):
880         (.dead):
881         * QueueStatusServer/templates/activebots.html: Added.
882         * QueueStatusServer/templates/dashboard.html:
883         * QueueStatusServer/templates/recentstatus.html:
884
885 2011-08-31  Oliver Hunt  <oliver@apple.com>
886
887         Move CheckedArithmeticOperations.cpp to the intended location
888
889         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
890         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
891
892 2011-08-31  Elliot Poger  <epoger@google.com>
893
894         add unittest to validate the complete set of Chromium configurations
895         https://bugs.webkit.org/show_bug.cgi?id=67211
896
897         Reviewed by Adam Barth.
898
899         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
900
901 2011-08-31  Nico Weber  <thakis@chromium.org>
902
903         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
904         https://bugs.webkit.org/show_bug.cgi?id=67297
905
906         Reviewed by Tony Chang.
907
908         Explicitly disable smooth scrolling in chromium's DRT.
909
910         * DumpRenderTree/chromium/WebPreferences.cpp:
911         (WebPreferences::applyTo):
912
913 2011-08-31  Oliver Hunt  <oliver@apple.com>
914
915         Add Checked<> tests to windows build
916
917         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
918
919 2011-08-30  Oliver Hunt  <oliver@apple.com>
920
921         Add support for checked arithmetic
922         https://bugs.webkit.org/show_bug.cgi?id=67095
923
924         Reviewed by Sam Weinig.
925
926         Add test cases for Checked<>
927
928         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
929         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
930
931 2011-08-31  Adam Barth  <abarth@webkit.org>
932
933         Move summary.html to garden-o-matic.html.
934
935         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
936         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
937         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
938         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
939
940 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
941
942         [chromium] DRT linux should pass nativeKeyCode to plugins
943         https://bugs.webkit.org/show_bug.cgi?id=66679
944
945         Reviewed by Tony Chang.
946
947         * DumpRenderTree/chromium/EventSender.cpp:
948         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
949         (simulated) nativeKeyCode for the given input keyboard code.
950
951 2011-08-31  Adam Barth  <abarth@webkit.org>
952
953         Tighen up UI for garden-o-matic tab strip
954         https://bugs.webkit.org/show_bug.cgi?id=67266
955
956         Reviewed by Dimitri Glazkov.
957
958         This patch add CSS to move the tab strip to the edges of the page and
959         to remove some gratuitous border-radius.
960
961         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
962         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
963
964 2011-08-31  Adam Barth  <abarth@webkit.org>
965
966         garden-o-matic results view shouldn't be horrifically ugly
967         https://bugs.webkit.org/show_bug.cgi?id=67264
968
969         Reviewed by Dimitri Glazkov.
970
971         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
972
973         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
974         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
975         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
976
977 2011-08-31  Adam Barth  <abarth@webkit.org>
978
979         garden-o-matic needs a tabstrip
980         https://bugs.webkit.org/show_bug.cgi?id=67263
981
982         Reviewed by Dimitri Glazkov.
983
984         This patch adds a basic tabstrip to garden-o-matic.  The results
985         details view now opens in the "Results" tab, and the user can flip back
986         and forth between the Summary and the Results tab quickly.  There's
987         also a stub for a "Commits" tab, which is disabled.
988
989         This patch isn't the most beautiful in the world, but it gets the ball
990         rolling on a multi-modal UI.
991
992         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
993         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
994         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
995         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
996         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
997
998 2011-08-31  Ai Makabi  <makabi@google.com>
999
1000         Extract reference links from reftest test file.
1001         https://bugs.webkit.org/show_bug.cgi?id=66838
1002
1003         Reviewed by Shinichiro Hamaji.
1004
1005         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
1006         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
1007         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
1008
1009 2011-08-03  Philippe Normand  <pnormand@igalia.com>
1010
1011         [webkitpy] missing log import in common/net/resultsjsonparser.py
1012         https://bugs.webkit.org/show_bug.cgi?id=65606
1013
1014         Reviewed by Martin Robinson.
1015
1016         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
1017
1018 2011-08-30  Philippe Normand  <pnormand@igalia.com>
1019
1020         [stylechecker] complains about NULL usage in some gst_structure_ calls
1021         https://bugs.webkit.org/show_bug.cgi?id=67194
1022
1023         Reviewed by Martin Robinson.
1024
1025         Don't warn about NULL in some gst_structure_ calls. 0 can't be
1026         used for these, a proper sentinel is required.
1027
1028         * Scripts/webkitpy/style/checkers/cpp.py:
1029         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1030
1031 2011-08-30  Adam Barth  <abarth@webkit.org>
1032
1033         Remove old-style UI from garden-o-matic
1034         https://bugs.webkit.org/show_bug.cgi?id=67257
1035
1036         Reviewed by Dimitri Glazkov.
1037
1038         This code is nowhere near as awesome as the new hotness.  Let's remove
1039         it so it doesn't weigh us down.
1040
1041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
1042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
1043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
1046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
1047
1048 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
1049
1050         [WebSocket] update pywebsocket to 0.6b5.
1051         https://bugs.webkit.org/show_bug.cgi?id=66924
1052
1053         Reviewed by Kent Tamura.
1054
1055         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
1056         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
1057         0.6b3 or later supports a closing handshake handler and it is useful to
1058         verify client's closing handshake implementation.
1059         0.6b4 supports AbortedByUserException. It is useful to eliminate
1060         unnecessary server warning messages on intended abnormal closures.
1061         0.6b5 supports Python 2.5.1 or Mac 10.5.
1062
1063         * Scripts/webkitpy/thirdparty/__init__.py:
1064         Update download URL and directory path.
1065
1066 2011-08-30  Dan Bernstein  <mitz@apple.com>
1067
1068         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
1069         https://bugs.webkit.org/show_bug.cgi?id=67230
1070
1071         Reviewed by Darin Adler.
1072
1073         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1074         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
1075         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
1076         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
1077         (TestWebKitAPI::TEST):
1078
1079 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
1080
1081         Add MediaSource API to HTMLMediaElement
1082         https://bugs.webkit.org/show_bug.cgi?id=64731
1083
1084         Reviewed by Eric Carlson.
1085
1086         * Scripts/build-webkit:
1087
1088 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1089
1090         Emit last progress notification before calling dispatchDidFinishLoad
1091         https://bugs.webkit.org/show_bug.cgi?id=28851
1092
1093         Reviewed by Adam Barth.
1094
1095         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
1096         Chromium and GTK ports. The first two were simple changes.
1097
1098         Some refactoring was needed in GTK port to assure that the dumps are emitted
1099         correctly and the processing after the page load finished is in the right place.
1100
1101         To detect the load finished, we use the callback for the "load-status" notifier
1102         signal of the top loading frame. And we use the deprecated "load-finished" signal
1103         for dumping (if enabled) the progress finished expected output.
1104
1105         * DumpRenderTree/LayoutTestController.cpp:
1106         (LayoutTestController::LayoutTestController):
1107         (dumpProgressFinishedCallbackCallback):
1108         (LayoutTestController::staticFunctions):
1109         * DumpRenderTree/LayoutTestController.h:
1110         (LayoutTestController::dumpProgressFinishedCallback):
1111         (LayoutTestController::setDumpProgressFinishedCallback):
1112         * DumpRenderTree/chromium/LayoutTestController.cpp:
1113         (LayoutTestController::LayoutTestController):
1114         (LayoutTestController::dumpProgressFinishedCallback):
1115         (LayoutTestController::reset):
1116         * DumpRenderTree/chromium/LayoutTestController.h:
1117         (LayoutTestController::shouldDumpProgressFinishedCallback):
1118         (LayoutTestController::setShouldDumpProgressFinishedCallback):
1119         * DumpRenderTree/chromium/WebViewHost.cpp:
1120         (WebViewHost::didStopLoading):
1121         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1122         (webViewLoadFinished):
1123         (topLoadingFrameLoadFinished):
1124         (webFrameLoadStatusNotified):
1125         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1126         (LayoutTestController::reset):
1127         (LayoutTestController::dumpProgressFinishedCallback):
1128         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1129
1130 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
1131
1132         JavaScriptCore does not have a good mechanism for performance
1133         regression testing
1134         https://bugs.webkit.org/show_bug.cgi?id=67177
1135
1136         Reviewed by Darin Adler.
1137         
1138         Added a new script, which allows for testing one, two, or more VMs
1139         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
1140         are interleaved at random to minimize systematics.  The results
1141         that bencher prints includes all possible relevant information about
1142         how bencher was invoked.  Bencher can be easily used to measure
1143         performance changes down to fractions of a percent.
1144         
1145         Bencher also includes experimental support for running benchmarks in
1146         a DumpRenderTree release build.  This works in SunSpider and V8, but
1147         not yet in Kraken.  Running benchmarks in DumpRenderTree more
1148         closely mimics the performance when running in browser.
1149
1150         * Scripts/bencher: Added.
1151
1152 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
1153
1154         DumpRenderTree should begin each test with an empty cookie store
1155         https://bugs.webkit.org/show_bug.cgi?id=63545
1156         <rdar://problem/5666907>
1157
1158         Reviewed by Darin Adler.
1159
1160         * DumpRenderTree/mac/DumpRenderTree.mm:
1161         (resetDefaultsToConsistentValues):
1162         (setDefaultsToConsistentValuesForTesting):
1163         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1164         (LayoutTestController::setAlwaysAcceptCookies):
1165         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1166         (WTR::InjectedBundle::beginTesting):
1167         Use new SPIs to manipulate sessions.
1168
1169 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
1170
1171         Unreviewed, rolling out r94055 and r94057.
1172         http://trac.webkit.org/changeset/94055
1173         http://trac.webkit.org/changeset/94057
1174         https://bugs.webkit.org/show_bug.cgi?id=67191
1175
1176         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
1177
1178         * Scripts/webkitpy/thirdparty/__init__.py:
1179
1180 2011-08-30  Adam Barth  <abarth@webkit.org>
1181
1182         Chromium Android should not be a core builder
1183         https://bugs.webkit.org/show_bug.cgi?id=67184
1184
1185         Reviewed by Ryosuke Niwa.
1186
1187         This bot hasn't been consistently green yet because it has never actually run!
1188
1189         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1190         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1191
1192 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
1193
1194         [WebSocket] update pywebsocket to 0.6b4.
1195         https://bugs.webkit.org/show_bug.cgi?id=66924
1196
1197         Reviewed by Kent Tamura.
1198
1199         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
1200         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
1201         0.6b3 or later supports a closing handshake handler and it is useful to
1202         verify client's closing handshake implementation.
1203         0.6b4 supports AbortedByUserException. It is useful to eliminate
1204         unnecessary server warning messages on intended abnormal closures.
1205
1206         * Scripts/webkitpy/thirdparty/__init__.py:
1207         Update download URL and directory path.
1208
1209 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
1210
1211         sheriffbot "usage" help statements are wrong
1212         https://bugs.webkit.org/show_bug.cgi?id=67170
1213
1214         Reviewed by Adam Barth.
1215
1216         * Scripts/webkitpy/tool/bot/irc_command.py:
1217         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1218         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1219
1220 2011-08-29  Adam Barth  <abarth@webkit.org>
1221
1222         Add support for chomium-mac (non-CoreGraphics) baselines
1223         https://bugs.webkit.org/show_bug.cgi?id=67163
1224
1225         Reviewed by Eric Seidel.
1226
1227         This patch teaches the non-CG chromium-mac bots to look at non-CG
1228         baselines.  However, the patch still leaves CG as the default set of
1229         baselines.
1230
1231         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1232         * Scripts/webkitpy/common/config/build.py:
1233         * Scripts/webkitpy/common/config/build_unittest.py:
1234         * Scripts/webkitpy/layout_tests/port/builders.py:
1235         * Scripts/webkitpy/layout_tests/port/chromium.py:
1236         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1237         * Scripts/webkitpy/layout_tests/port/factory.py:
1238         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1239         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1240         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1241         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1242
1243 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
1244
1245         Small fix in chromium port of new-run-webkit-tests.
1246         https://bugs.webkit.org/show_bug.cgi?id=67078
1247
1248         Reviewed by Dirk Pranke.
1249
1250         * Scripts/webkitpy/layout_tests/port/chromium.py:
1251
1252 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1253
1254         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
1255         r93999.
1256         http://trac.webkit.org/changeset/93987
1257         http://trac.webkit.org/changeset/93992
1258         http://trac.webkit.org/changeset/93995
1259         http://trac.webkit.org/changeset/93998
1260         http://trac.webkit.org/changeset/93999
1261         https://bugs.webkit.org/show_bug.cgi?id=67147
1262
1263         Many failing tests (Requested by ap on #webkit).
1264
1265         * DumpRenderTree/mac/DumpRenderTree.mm:
1266         (setDefaultsToConsistentValuesForTesting):
1267         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1268         (WTR::InjectedBundle::beginTesting):
1269
1270 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
1271
1272         DumpRenderTree should begin each test with an empty cookie store
1273         https://bugs.webkit.org/show_bug.cgi?id=63545
1274         <rdar://problem/5666907>
1275
1276         Reviewed by Darin Adler.
1277
1278         * DumpRenderTree/mac/DumpRenderTree.mm:
1279         (setDefaultsToConsistentValuesForTesting):
1280         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1281         (WTR::InjectedBundle::beginTesting):
1282         Tell WebCore to use a temporary session, starting with a clean cookie store.
1283
1284 2011-08-23  Chris Marrin  <cmarrin@apple.com>
1285
1286         [mac] requestAnimationFrame support for mac port
1287         https://bugs.webkit.org/show_bug.cgi?id=59146
1288
1289         Reviewed by Simon Fraser.
1290
1291         Add support for request-animation-callback flag
1292
1293         * Scripts/build-webkit:
1294
1295 2011-08-27  Peter Beverloo  <peter@chromium.org>
1296
1297         Add a build bot for Chromium with OS(ANDROID)
1298         https://bugs.webkit.org/show_bug.cgi?id=66687
1299
1300         Reviewed by Adam Barth.
1301
1302         * BuildSlaveSupport/build.webkit.org-config/config.json:
1303
1304 2011-08-27  Peter Beverloo  <peter@chromium.org>
1305
1306         Update the master build bot configuration script to properly
1307         deal with the --chromium-android switch.
1308         https://bugs.webkit.org/show_bug.cgi?id=66687
1309
1310         The --chromium-android switch is needed when running
1311         update-webkit-chromium and build-webkit, as it'll tell the
1312         scripts to pull in the right dependencies and cross-compile
1313         WebKit using the Android NDK.
1314
1315         Reviewed by Adam Barth.
1316
1317         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1318
1319 2011-08-27  Peter Beverloo  <peter@chromium.org>
1320
1321         Teach the update and build scripts how to handle dependencies
1322         and cross-compiling rules for the Chromium port on OS(ANDROID).
1323         https://bugs.webkit.org/show_bug.cgi?id=66687
1324
1325         Reviewed by Adam Barth.
1326
1327         * Scripts/build-webkit:
1328         * Scripts/update-webkit:
1329         * Scripts/update-webkit-chromium:
1330         * Scripts/webkitdirs.pm:
1331         (argumentsForConfiguration):
1332         (isChromium):
1333         (isChromiumAndroid):
1334         (determineIsChromiumAndroid):
1335         (buildChromium):
1336
1337 2011-08-26  Adam Barth  <abarth@webkit.org>
1338
1339         garden-o-matic should let me know that I need to run the local server
1340         https://bugs.webkit.org/show_bug.cgi?id=66985
1341
1342         Reviewed by Dimitri Glazkov.
1343
1344         The patch triggers an alert dialog whenever the user tries to use a
1345         feature that requires the local server.
1346
1347         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1348         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1349         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1350
1351 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1352
1353         garden-o-matic summary view should have pretty commit data information.
1354         https://bugs.webkit.org/show_bug.cgi?id=67069
1355
1356         Reviewed by Adam Barth.
1357
1358         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
1359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
1360         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
1361         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
1362
1363 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1364
1365         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
1366         https://bugs.webkit.org/show_bug.cgi?id=67066
1367
1368         Reviewed by Adam Barth.
1369
1370         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
1371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1372
1373 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
1374
1375         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
1376         https://bugs.webkit.org/show_bug.cgi?id=67041
1377
1378         Reviewed by Martin Robinson.
1379
1380         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
1381         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
1382         when the GTK+ port was being built.
1383
1384         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1385
1386 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1387
1388         Clean up and line up layout in garden-o-matic summary view.
1389         https://bugs.webkit.org/show_bug.cgi?id=67057
1390
1391         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
1392         2) Rearranged DOM structure a bit to accommodate recent changes;
1393         3) Added minimal CSS to line things up.
1394
1395         Reviewed by Adam Barth.
1396
1397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
1398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
1399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
1400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
1401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
1402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
1403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
1404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
1405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
1406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1407
1408 2011-08-26  Alice Liu  <alice.liu@apple.com>
1409
1410         https://bugs.webkit.org/show_bug.cgi?id=66823
1411         Add the request info to the WebPageProxy::CreateNewPage message
1412
1413         Reviewed by Anders Carlsson.
1414
1415         Update function declarations with additional parameter:
1416         * MiniBrowser/gtk/BrowserWindow.c:
1417         (createNewPage):
1418         * MiniBrowser/mac/BrowserWindowController.m:
1419         (createNewPage):
1420         * MiniBrowser/win/BrowserView.cpp:
1421         (createNewPage):
1422         * WebKitTestRunner/TestController.cpp:
1423         (WTR::TestController::createOtherPage):
1424         * WebKitTestRunner/TestController.h:
1425
1426 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
1427
1428         Make show-pretty-diff work on linux
1429         https://bugs.webkit.org/show_bug.cgi?id=67017
1430
1431         Reviewed by Adam Barth.
1432
1433         * Scripts/show-pretty-diff:
1434
1435 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1436
1437         Reorganize garden-o-matic CSS files to match JS-built views.
1438         https://bugs.webkit.org/show_bug.cgi?id=66998
1439
1440         Reviewed by Adam Barth.
1441
1442         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
1443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
1444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
1445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
1446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
1447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1448
1449 2011-08-25  Adam Barth  <abarth@webkit.org>
1450
1451         garden-o-matic should be able to roll out patches
1452         https://bugs.webkit.org/show_bug.cgi?id=66982
1453
1454         Reviewed by Dimitri Glazkov.
1455
1456         This patch just wires the rollout event through the controller to the
1457         local server, which is already set up to perform rollouts.
1458
1459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1463
1464 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1465
1466         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
1467         https://bugs.webkit.org/show_bug.cgi?id=66951
1468
1469         Reviewed by Andreas Kling.
1470
1471         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
1472         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
1473
1474         * MiniBrowser/qt/BrowserView.cpp:
1475         (BrowserView::resizeEvent):
1476
1477 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1478
1479         garden-o-matic summary view should provide information on builders still in flight.
1480         https://bugs.webkit.org/show_bug.cgi?id=66992
1481
1482         Reviewed by Adam Barth.
1483
1484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
1485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
1486         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
1487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
1488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
1489
1490 2011-08-25  Adam Barth  <abarth@webkit.org>
1491
1492         webkit-patch rebaseline-expectations don't work when run outside the root
1493         https://bugs.webkit.org/show_bug.cgi?id=66966
1494
1495         Reviewed by Eric Seidel.
1496
1497         Turns out tool.path() used to be relative, which caused problems when
1498         running webkit-patch outside the root directory.  This patch makes it
1499         absolute.  I checked all callers, and they all appear to want this
1500         behavior.
1501
1502         It was unclear to me how to test this change because we only really
1503         have a testing strategy for webkitpy, not for the main script.
1504
1505         * Scripts/webkit-patch:
1506
1507 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1508
1509         garden-o-matic summary needs a mock view that could be used for working on styling
1510         https://bugs.webkit.org/show_bug.cgi?id=66971
1511
1512         Reviewed by Adam Barth.
1513
1514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
1515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
1516
1517 2011-08-25  Anders Carlsson  <andersca@apple.com>
1518
1519         Return the correct value for NPNVsupportsCarbonBool
1520         https://bugs.webkit.org/show_bug.cgi?id=66964
1521
1522         Add a test.
1523
1524         Reviewed by Adam Roben.
1525
1526         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1527         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
1528         (SupportsCarbonEventModel::SupportsCarbonEventModel):
1529         (SupportsCarbonEventModel::testConvert):
1530         (SupportsCarbonEventModel::runTest):
1531         (SupportsCarbonEventModel::NPP_New):
1532
1533 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1534
1535         garden-o-matic summary view should not be broken.
1536
1537         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
1538         (table.comparison): Added more specificity.
1539
1540 2011-08-25  Adam Barth  <abarth@webkit.org>
1541
1542         This command has been broken for a while.  This patch updates the
1543         callsite to the new API.
1544
1545         * Scripts/webkitpy/tool/commands/rebaseline.py:
1546
1547 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1548
1549         garden-o-matic needs a way to report where and how tests are failing in the summary view.
1550         https://bugs.webkit.org/show_bug.cgi?id=66955
1551
1552         Introduce FailureGrid, your one-stop failure-indicating destination. 
1553
1554         Reviewed by Adam Barth.
1555
1556         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
1557         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
1558         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
1559         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
1560         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
1561         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
1562
1563 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
1564
1565         Add myself to the committers list
1566         https://bugs.webkit.org/show_bug.cgi?id=66941
1567
1568         Reviewed by Andreas Kling.
1569
1570         * Scripts/webkitpy/common/config/committers.py:
1571
1572 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1573
1574         Unreviewed, rolling out r93767.
1575         http://trac.webkit.org/changeset/93767
1576         https://bugs.webkit.org/show_bug.cgi?id=66931
1577
1578         Broke Qt bot. (Requested by yutak on #webkit).
1579
1580         * Scripts/webkitpy/thirdparty/__init__.py:
1581
1582 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
1583
1584         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
1585         https://bugs.webkit.org/show_bug.cgi?id=66924
1586
1587         Reviewed by Kent Tamura.
1588
1589         * Scripts/webkitpy/thirdparty/__init__.py:
1590
1591 2011-08-24  Adam Barth  <abarth@webkit.org>
1592
1593         The user can't close the details view in garden-o-matic
1594         https://bugs.webkit.org/show_bug.cgi?id=66911
1595
1596         Reviewed by Dimitri Glazkov.
1597
1598         In addition to adding a close button, this patch changes the test
1599         selector to use a <select> element and refactors the test selector to
1600         share code with the builder selector.
1601
1602         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1603         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1604         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1605         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1606
1607 2011-08-24  James Robinson  <jamesr@chromium.org>
1608
1609         [chromium] Stacktrace not in test output when a test crashes
1610         https://bugs.webkit.org/show_bug.cgi?id=66806
1611
1612         Reviewed by Dirk Pranke.
1613
1614         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
1615         trace.
1616
1617         * Scripts/webkitpy/layout_tests/port/chromium.py:
1618
1619 2011-08-24  Adam Barth  <abarth@webkit.org>
1620
1621         Remove empty directory.
1622
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
1624
1625 2011-08-24  Adam Barth  <abarth@webkit.org>
1626
1627         Finish writing up details-view in garden-o-matic
1628         https://bugs.webkit.org/show_bug.cgi?id=66891
1629
1630         Reviewed by Dimitri Glazkov.
1631
1632         This patch mostly just copies a bunch of CSS from main.css to
1633         summary.css.  Presumably we'll delete main.css soon.
1634
1635         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1636         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1637         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1638         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
1639         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1640
1641 2011-08-24  James Robinson  <jamesr@chromium.org>
1642
1643         Some compositing LayoutTests flakily crashing on Mac 10.6
1644         https://bugs.webkit.org/show_bug.cgi?id=66740
1645
1646         Reviewed by Adam Barth.
1647
1648         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
1649         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
1650         chromium configuration.
1651
1652         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1653         (NPP_Destroy):
1654
1655 2011-08-24  Anton D'Auria  <adauria@apple.com>
1656
1657         No review necessary.
1658
1659         Adding myself to list of committers.
1660
1661         * Scripts/webkitpy/common/config/committers.py:
1662
1663 2011-08-24  Avi Drissman  <avi@google.com>
1664
1665         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
1666         https://bugs.webkit.org/show_bug.cgi?id=66875
1667
1668         Reviewed by James Robinson.
1669
1670         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1671         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1672
1673 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1674
1675         Make notifications appear in time order again.
1676         https://bugs.webkit.org/show_bug.cgi?id=66815
1677
1678         Reviewed by Adam Barth.
1679
1680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
1681         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
1682
1683 2011-08-23  James Robinson  <jamesr@chromium.org>
1684
1685         [chromium] Need a way to test lost compositor context recovery
1686         https://bugs.webkit.org/show_bug.cgi?id=66820
1687
1688         Reviewed by Kenneth Russell.
1689
1690         Exposes a LayoutTestController interface in chromium to simulate a
1691         lost compositor context.
1692
1693         * DumpRenderTree/chromium/LayoutTestController.cpp:
1694         (LayoutTestController::LayoutTestController):
1695         (LayoutTestController::loseCompositorContext):
1696         * DumpRenderTree/chromium/LayoutTestController.h:
1697
1698 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1699
1700         Change garden-o-matic frontend builder array to be a configuration map.
1701         https://bugs.webkit.org/show_bug.cgi?id=66816
1702
1703         Reviewed by Adam Barth.
1704
1705         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
1706         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
1707         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
1708         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
1709         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
1710
1711 2011-08-23  Cary Clark  <caryclark@google.com>
1712
1713         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
1714         https://bugs.webkit.org/show_bug.cgi?id=66803
1715
1716         This fixes the WebKit Canaries, in particular avoids a crash on tests
1717         like css1/basic/comments.html.
1718
1719         Reviewed by James Robinson.
1720
1721         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1722         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1723         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
1724         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
1725         and treated it as if it were a CGContextRef.
1726
1727 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1728
1729         Fix mergeChangeLogs test on native windows
1730         https://bugs.webkit.org/show_bug.cgi?id=66797
1731
1732         Reviewed by Adam Roben.
1733
1734         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
1735         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
1736
1737         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1738         (writeTempFile):
1739
1740 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1741
1742         garden-o-matic relative time is wrong and updates too frequently.
1743         https://bugs.webkit.org/show_bug.cgi?id=66802
1744
1745         Reviewed by Adam Barth.
1746
1747         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
1748         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
1749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
1750
1751 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1752
1753         Add missing quotes around filenames in mergeChangeLogs
1754         https://bugs.webkit.org/show_bug.cgi?id=66794
1755
1756         Reviewed by Adam Roben.
1757
1758         * Scripts/VCSUtils.pm:
1759         (mergeChangeLogs):
1760
1761 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1762
1763         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
1764         https://bugs.webkit.org/show_bug.cgi?id=49080
1765
1766         Reviewed by Adam Roben.
1767
1768         Use the string form of pipe open instead (like we do at all other places).
1769
1770         * Scripts/VCSUtils.pm:
1771         (mergeChangeLogs):
1772
1773 2011-08-23  Adam Barth  <abarth@webkit.org>
1774
1775         garden-o-matic summary should be able to examine failures
1776         https://bugs.webkit.org/show_bug.cgi?id=66748
1777
1778         Reviewed by Dimitri Glazkov.
1779
1780         This patch refactors a bunch of code from summary.js to independent
1781         controllers in controllers.js.  This patch also contains the first
1782         iteration of binding the "examine" event to a the behavior showing the
1783         details view for the tests.  There's more work to do here to make this
1784         work properly (and elegantly), but this patch is a start.
1785
1786         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1787         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1788         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1789         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
1790         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1791         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1792         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1793         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1794         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1795
1796 2011-08-23  Adam Barth  <abarth@webkit.org>
1797
1798         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
1799         https://bugs.webkit.org/show_bug.cgi?id=66737
1800
1801         Reviewed by Steve Block.
1802
1803         This directory doesn't exist anymore now that the Android port shares
1804         more code with Chromium.
1805
1806         * Scripts/webkitpy/common/config/build.py:
1807
1808 2011-08-22  Eric Seidel  <eric@webkit.org>
1809
1810         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
1811         I won't have ssh access to the bot again for a couple days, so
1812         attempting to fix by changing this script.  If this doesn't
1813         work we'll just live with the it hung for now.
1814
1815         Unreviewed.
1816
1817         * EWSTools/start-queue.sh:
1818
1819 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1820
1821         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
1822         https://bugs.webkit.org/show_bug.cgi?id=66727
1823
1824         Reviewed by Adam Barth.
1825
1826         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
1827             in which case the serializer treats all expectations as unparsed.
1828         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
1829
1830 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1831
1832         Update unit test expectations after r93530.
1833
1834         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
1835         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
1836
1837 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1838
1839         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
1840         https://bugs.webkit.org/show_bug.cgi?id=66705
1841
1842         Reviewed by Adam Barth.
1843
1844         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
1845         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
1846
1847 2011-08-22  James Robinson  <jamesr@chromium.org>
1848
1849         [chromium] Update builder names for chromium gpu bots due to CG switchover
1850         https://bugs.webkit.org/show_bug.cgi?id=66693
1851
1852         Reviewed by Dirk Pranke.
1853
1854         Update the port and builder names for the chromium mac gpu bots to
1855         account for the CG transition.
1856
1857         * Scripts/webkitpy/layout_tests/port/builders.py:
1858
1859 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
1860
1861         fix the GPU bot names on the layout test dashboard
1862         https://bugs.webkit.org/show_bug.cgi?id=66697
1863
1864         Reviewed by Dimitri Glazkov.
1865
1866         * TestResultServer/static-dashboards/builders.js:
1867
1868 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1869
1870         garden-o-matic's relative time display should be updated regularly.
1871         https://bugs.webkit.org/show_bug.cgi?id=66682
1872
1873         Reviewed by Adam Barth.
1874
1875         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
1876         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
1877         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
1878
1879 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1880
1881         Pass --makeargs of build-webkit to chromium linux builder
1882         https://bugs.webkit.org/show_bug.cgi?id=66361
1883
1884         Reviewed by Tony Chang.
1885
1886         * Scripts/build-webkit:
1887         * Scripts/webkitdirs.pm:
1888         (buildChromiumMakefile):
1889         (buildChromium):
1890
1891 2011-08-22  Peter Beverloo  <peter@chromium.org>
1892
1893         Add myself to the contributor list.
1894         https://bugs.webkit.org/show_bug.cgi?id=66674
1895
1896         Reviewed by Tony Gentilcore.
1897
1898         * Scripts/webkitpy/common/config/committers.py:
1899
1900 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
1901
1902         [Qt] ImageDiff does not consider --tolerance
1903         https://bugs.webkit.org/show_bug.cgi?id=66299
1904
1905         Reviewed by Csaba Osztrogonác.
1906
1907         * DumpRenderTree/qt/ImageDiff.cpp:
1908         (main):
1909
1910 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
1911
1912         Update contributor list.
1913
1914         Reviewed by Zoltan Herczeg.
1915
1916         * Scripts/webkitpy/common/config/committers.py:
1917
1918 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1919
1920         [ORWT] Fix --reset-results --add-platform-exceptions combo
1921         https://bugs.webkit.org/show_bug.cgi?id=65464
1922
1923         Reviewed by Csaba Osztrogonác.
1924
1925         * Scripts/old-run-webkit-tests:
1926
1927 2011-08-20  Adam Barth  <abarth@webkit.org>
1928
1929         garden-o-matic summary.html should have UI for examining failures
1930         https://bugs.webkit.org/show_bug.cgi?id=66625
1931
1932         Reviewed by Dimitri Glazkov.
1933
1934         This patch introduces the notion of UI actions and converts our
1935         existing manual <button> manipulation with this new abstraction.  The
1936         patch also adds an Examine button to failure notifications.  In a
1937         future patch, I'll add a controller that wires this button up to
1938         something useful.
1939
1940         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1941         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1942         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
1943         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
1944         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1945         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1946         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1948
1949 2011-08-20  Adam Barth  <abarth@webkit.org>
1950
1951         garden-o-matic summary page should indiciate compile failures
1952         https://bugs.webkit.org/show_bug.cgi?id=66624
1953
1954         Reviewed by Dimitri Glazkov.
1955
1956         This patch creates a notification-based UI for build failures.  The new
1957         UI displays the same information that used to be displayed in the
1958         infobar.  There's lots of room for improvement in surfacing more
1959         information, but this is a start.
1960
1961         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1962         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1963         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1964
1965 2011-08-19  James Robinson  <jamesr@chromium.org>
1966
1967         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
1968         https://bugs.webkit.org/show_bug.cgi?id=66606
1969
1970         Reviewed by Dirk Pranke.
1971
1972         The chromium GPU configuration does not (currently) contain any tests
1973         incompatible with --experimental-fully-parallel, and this flag is a
1974         significan speedup because of the directory canvas/philip/tests which
1975         contains 802 tests in the same directory. Setting this option by
1976         default on this configuration is a 2x speed in release, 44s to 22s,
1977         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
1978
1979         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1980         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1981         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1982
1983 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1984
1985         Unreviewed, rolling out r93426.
1986         http://trac.webkit.org/changeset/93426
1987         https://bugs.webkit.org/show_bug.cgi?id=66607
1988
1989         Broke the Mac build by not building gtest.framework anymore
1990         (Requested by andersca on #webkit).
1991
1992         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1993
1994 2011-08-19  James Robinson  <jamesr@chromium.org>
1995
1996         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
1997         https://bugs.webkit.org/show_bug.cgi?id=66603
1998
1999         Reviewed by Dirk Pranke.
2000
2001         The various ChromiumGpu ports should use the same child worker
2002         selection logic as other ports so they can run with full
2003         parallelization on multicore systems.
2004
2005         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2006         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2007
2008 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
2009
2010         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
2011         https://bugs.webkit.org/show_bug.cgi?id=66570
2012
2013         Reviewed by Mihai Parparita.
2014
2015         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
2016         (WebThemeControlDRTWin::draw):
2017         (WebThemeControlDRTWin::drawTextField):
2018         (WebThemeControlDRTWin::drawProgressBar):
2019         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2020
2021 2011-08-18  Dmitry Lomov  <dslomov@google.com>
2022
2023         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
2024         https://bugs.webkit.org/show_bug.cgi?id=66521
2025
2026         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
2027
2028         Reviewed by David Levin.
2029
2030         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
2031
2032 2011-08-19  Adam Roben  <aroben@apple.com>
2033
2034         Add project file changes I left out in r93417
2035
2036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2037
2038 2011-08-19  Adam Roben  <aroben@apple.com>
2039
2040         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
2041
2042         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
2043         NSScreen
2044
2045         Reviewed by Anders Carlsson.
2046
2047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2048
2049         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
2050         (-[SimpleObject setValue:]): Original implementation.
2051
2052         (TestWebKitAPI::setValue2):
2053         (TestWebKitAPI::setValue3):
2054         Swizzled implementations.
2055
2056         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
2057         instance method.
2058
2059         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
2060         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
2061         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
2062         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
2063
2064 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
2065
2066         Fix _path_to_apache() error reporting
2067         https://bugs.webkit.org/show_bug.cgi?id=66486
2068
2069         Reviewed by Ryosuke Niwa.
2070
2071         * Scripts/webkitpy/layout_tests/port/webkit.py:
2072
2073 2011-08-19  Adam Roben  <aroben@apple.com>
2074
2075         Windows build fix after r93404
2076
2077         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
2078
2079 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
2080
2081         Add leandrogracia to the committers list
2082         https://bugs.webkit.org/show_bug.cgi?id=66552
2083
2084         Also fix line endings in file.
2085
2086         No reviewed required.
2087
2088         * Scripts/webkitpy/common/config/committers.py:
2089
2090 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
2091
2092         Fix compilation issue in WebKitTestRunner
2093         https://bugs.webkit.org/show_bug.cgi?id=66554
2094
2095         Reviewed by Martin Robinson.
2096
2097         * WebKitTestRunner/PixelDumpSupport.cpp:
2098
2099 2011-08-19  Adam Roben  <aroben@apple.com>
2100
2101         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
2102
2103         This will make it easier to write other WebKit-agnostic tests
2104
2105         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
2106         code in other WebKit-agnostic tests
2107
2108         Reviewed by Anders Carlsson.
2109
2110         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2111
2112         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
2113         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
2114         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
2115         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
2116         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
2117         WebKitAgnosticTest handles for us.
2118         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
2119
2120         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
2121         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
2122         DynamicDeviceScaleFactor::runTest.
2123
2124         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
2125         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
2126         DynamicDeviceScaleFactor.WebKit.
2127         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
2128         DynamicDeviceScaleFactor.WebKit2.
2129
2130 2011-08-19  Adam Roben  <aroben@apple.com>
2131
2132         Clean up #includes in TestWebKitAPI
2133
2134         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
2135
2136         Reviewed by Anders Carlsson.
2137
2138         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
2139         files and WebKit/WebKit.h for ObjC files.
2140
2141         * TestWebKitAPI/InjectedBundleController.cpp:
2142         * TestWebKitAPI/JavaScriptTest.h:
2143         * TestWebKitAPI/PlatformUtilities.h:
2144         * TestWebKitAPI/PlatformWebView.h:
2145         * TestWebKitAPI/Test.h:
2146         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2147         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2148         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
2149         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2150         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2151         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2152         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2153         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2154         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2155         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2156         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2157         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2158         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2159         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2160         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2161         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2162         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2163         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2164         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2165         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2166         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2167         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2168         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2169         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2170         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2171         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2172         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2173         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2174         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2175         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2176         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2177         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2178         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2179         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2180         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2181         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2182         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2183         * TestWebKitAPI/TestsController.cpp:
2184         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2185         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
2186         #includes since it is no longer a special header.
2187
2188 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
2189
2190         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
2191         https://bugs.webkit.org/show_bug.cgi?id=64886
2192
2193         Temporarily disable the http locking to work around the issue.
2194         I'm not actually sure if this is going to work or improve things
2195         much.
2196
2197         Reviewed by Ryosuke Niwa.
2198
2199         * Scripts/webkitpy/layout_tests/port/mac.py:
2200
2201 2011-08-18  Tony Chang  <tony@chromium.org>
2202
2203         add embedded png checksums to WebKitTestRunner
2204         https://bugs.webkit.org/show_bug.cgi?id=66494
2205
2206         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
2207         some code from DRT and adds it to the WebKitTestRunner.
2208
2209         Reviewed by Darin Adler.
2210
2211         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
2212         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
2213         * WebKitTestRunner/GNUmakefile.am: Add new files
2214         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
2215         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
2216         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
2217         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2218         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
2219         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2220         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2221         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
2222         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2223         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
2224
2225 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
2226
2227         https://bugs.webkit.org/show_bug.cgi?id=47240
2228
2229         Fixed a cygwin path problem in the chromium port of diff_image;
2230         Also made the return values of the diff_image function more consistent.
2231
2232         Reviewed by Dirk Pranke.
2233
2234         * Scripts/webkitpy/layout_tests/port/chromium.py:
2235
2236 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
2237
2238         [GTK] Fix compilation problems with deprecations in gtk+
2239         https://bugs.webkit.org/show_bug.cgi?id=66073
2240
2241         Reviewed by Martin Robinson.
2242
2243         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2244         (main): G_CONST_RETURN was deprecated
2245         * GtkLauncher/main.c:
2246         (createWindow): Added gtk_box_new conditional compilation for
2247         gtk+-3.
2248         * MiniBrowser/gtk/BrowserWindow.c:
2249         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
2250         are just supporting gtk+-3 for WebKit2.
2251
2252 2011-08-18  Anders Carlsson  <andersca@apple.com>
2253
2254         Fix libc++ C++0x build
2255         https://bugs.webkit.org/show_bug.cgi?id=66479
2256
2257         Reviewed by Adam Roben.
2258
2259         Add missing includes.
2260
2261         * DumpRenderTree/LayoutTestController.cpp:
2262         * DumpRenderTree/mac/CheckedMalloc.cpp:
2263
2264 2011-08-18  Adam Roben  <aroben@apple.com>
2265
2266         Test that WebKit updates style when a WebView is moved between differently-scaled windows
2267
2268         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
2269         WebView is moved between windows with different backing scale factors
2270
2271         Reviewed by Anders Carlsson.
2272
2273         * TestWebKitAPI/JavaScriptTest.cpp:
2274         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
2275         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
2276         gtest's built-in error messages.
2277
2278         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
2279         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
2280         those overloads.
2281
2282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2283
2284         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
2285         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
2286         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
2287         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
2288         (TestWebKitAPI::setPageLoaderClient): Set up the client.
2289         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
2290         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
2291         SyntheticBackingScaleFactorWindow and returns it.
2292         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
2293         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
2294         window, is moved to a differently-scaled window, and is taken out of the window.
2295         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
2296         WebKit1 and WebKit2.
2297         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
2298
2299         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
2300
2301         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
2302         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
2303
2304         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
2305         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
2306         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
2307         initializer.
2308         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
2309
2310         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
2311         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
2312         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
2313
2314 2011-08-18  Dmitry Lomov  <dslomov@google.com>
2315
2316         https://bugs.webkit.org/show_bug.cgi?id=66425
2317         check-webkit-style should detect incorrectly formatted file change descriptions.
2318         Description, if present, should be separated from colon with a space.
2319
2320         Reviewed by David Levin.
2321
2322         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
2323         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
2324
2325 2011-08-18  Adam Barth  <abarth@webkit.org>
2326
2327         webkit-patch pretty-diff should be shown in main help
2328         https://bugs.webkit.org/show_bug.cgi?id=66404
2329
2330         Reviewed by Dimitri Glazkov.
2331
2332         As requested by dglazkov.
2333
2334         * Scripts/webkitpy/tool/commands/prettydiff.py:
2335
2336 2011-08-17  Dmitry Lomov  <dslomov@google.com>
2337
2338         https://bugs.webkit.org/show_bug.cgi?id=66400
2339         Fix TestWebKitAPI build on Mac OS.
2340
2341         Reviewed by David Levin.
2342
2343         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
2344
2345 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2346
2347         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
2348         https://bugs.webkit.org/show_bug.cgi?id=66427
2349
2350         Reviewed by Adam Barth.
2351
2352         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
2353         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
2354         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
2355         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
2356         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
2357         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
2358         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
2359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
2360         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
2361         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
2362         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
2363         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
2364         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
2365         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
2366         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
2367         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
2368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
2370         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
2371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
2372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
2373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
2374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
2375         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
2376         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
2377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
2378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
2379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
2380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
2381         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
2382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
2383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
2384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
2385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
2386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
2387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
2388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
2389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
2390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
2391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
2395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
2396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
2398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
2399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
2400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
2401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
2402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
2403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
2404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
2405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
2406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
2408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
2409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
2410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
2411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
2413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
2414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
2415         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
2416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
2417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
2418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
2419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
2420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
2421         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
2422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
2423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
2424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
2425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
2426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
2427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
2428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
2429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
2430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
2432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
2433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
2434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
2435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
2436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
2437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
2438         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
2439         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
2440         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
2441         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
2442         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
2443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
2444         ():
2445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
2446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
2447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
2448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
2449         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
2450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
2451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
2452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
2453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
2454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
2455         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
2456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
2457         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
2458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
2459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
2461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
2462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
2463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
2464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
2465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
2466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
2467
2468 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
2469
2470         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
2471         https://bugs.webkit.org/show_bug.cgi?id=65877
2472
2473         Reviewed by Eric Seidel.
2474
2475         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2476
2477 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2478
2479         Remove base.keys and replace it with Object.keys.
2480         https://bugs.webkit.org/show_bug.cgi?id=66422
2481
2482         Reviewed by Adam Barth.
2483
2484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
2485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
2486         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
2487
2488 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2489
2490         garden-o-matic Summary view should have items in descending chronological order.
2491         https://bugs.webkit.org/show_bug.cgi?id=66403
2492
2493         Reviewed by Adam Barth.
2494
2495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
2496         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
2497         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
2498
2499 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2500
2501         Fix a few errors in garden-o-matic frontend unit tests.
2502         https://bugs.webkit.org/show_bug.cgi?id=66421
2503
2504         Reviewed by Adam Barth.
2505
2506         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
2507         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
2508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
2509
2510 2011-08-17  Adam Barth  <abarth@webkit.org>
2511
2512         Update Tools to account for (CG) being added to Chromium builder names
2513         https://bugs.webkit.org/show_bug.cgi?id=66410
2514
2515         Reviewed by Adam Barth.
2516
2517         Some of these names will change back once we turn on Skia bots.
2518
2519         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
2520         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2521         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2522         * Scripts/webkitpy/layout_tests/port/builders.py:
2523         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2524         * TestResultServer/static-dashboards/builders.js:
2525         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2526
2527 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2528
2529         Wire up relative time to garden-o-matic summary view.
2530         https://bugs.webkit.org/show_bug.cgi?id=66343
2531
2532         Reviewed by Adam Barth.
2533
2534         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
2535         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
2536         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
2537         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
2538         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
2539
2540 2011-08-17  Adam Roben  <aroben@apple.com>
2541
2542         Make run-api-tests run tests in alphabetical order
2543
2544         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
2545
2546         Reviewed by David Kilzer.
2547
2548         * Scripts/run-api-tests:
2549         (runAllTests):
2550         (runAllTestsInSuite):
2551         Sort the lists of tests and suites before iterating over them.
2552
2553 2011-08-17  Adam Barth  <abarth@webkit.org>
2554
2555         garden-o-matic should be able to rebaseline expected failures
2556         https://bugs.webkit.org/show_bug.cgi?id=66204
2557
2558         Reviewed by Dimitri Glazkov.
2559
2560         This patch introduces a new view for displaying expect, actual, and
2561         differences between results.  The new view also has a fledgling
2562         controller that handles some basic operations.  The new view is
2563         exercised by rebaseline.html, which lets you rebaselines expected
2564         failures, but the new view is not fully integrated into
2565         garden-o-matic.html
2566
2567         More patches will be required to make this stuff fully working, but
2568         this patch was already somewhat spiraling out of control.  Hopefully
2569         this patch will serve as a good starting point for further development.
2570
2571         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
2572         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
2573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
2574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2575         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2576         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2577         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
2578         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2579         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2580         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
2582         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
2583
2584 2011-08-16  Chang Shu  <cshu@webkit.org>
2585
2586         Support reset in WebCore::Internals
2587         https://bugs.webkit.org/show_bug.cgi?id=66307
2588
2589         Reviewed by Dimitri Glazkov.
2590
2591         Added call to resetInternalsObject in DRT.
2592
2593         * DumpRenderTree/chromium/TestShell.cpp:
2594         (TestShell::resetTestController):
2595         * DumpRenderTree/mac/DumpRenderTree.mm:
2596         (resetWebViewToConsistentStateBeforeTesting):
2597         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2598         (WebCore::WebPage::resetSettings):
2599
2600 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
2601
2602         Add a new build slave for the Qt port on Mac OS SnowLeopard.
2603         https://bugs.webkit.org/show_bug.cgi?id=66392
2604
2605         Modify the config file to include the new build slave.
2606
2607         Reviewed by Adam Roben.
2608
2609         * BuildSlaveSupport/build.webkit.org-config/config.json:
2610
2611 2011-08-17  Sam White  <samuel.white@rochester.edu>
2612
2613         AccessibilityObject levels are inconsistent
2614         https://bugs.webkit.org/show_bug.cgi?id=66180
2615         
2616         Added the ability to get numeric attribute values using numberAttributeValue. This
2617         function complements the existing stringAttributeValue and boolAttributeValue functions.
2618         The addition of numberAttributeValue was necessary because the stringAttributeValue
2619         function does a type check and will only return strings. This limitation made it
2620         impossible to get values for attributes that returned an NSNumber.
2621
2622         Reviewed by Chris Fleizach.
2623
2624         * DumpRenderTree/AccessibilityUIElement.cpp:
2625         (numberAttributeValueCallback):
2626         (AccessibilityUIElement::getJSClass):
2627         * DumpRenderTree/AccessibilityUIElement.h:
2628         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2629         (AccessibilityUIElement::numberAttributeValue):
2630         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2631         (AccessibilityUIElement::numberAttributeValue):
2632         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2633         (AccessibilityUIElement::numberAttributeValue):
2634
2635 2011-08-17  Adam Roben  <aroben@apple.com>
2636
2637         Tell Trac logs always to display all specified revisions in a single page
2638
2639         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
2640         revisions than that.
2641
2642         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
2643         relevant revisions
2644
2645         Reviewed by Daniel Bates.
2646
2647         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2648         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
2649         a single page.
2650
2651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
2652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
2653         Updated tests for the above.
2654
2655 2011-08-17  Adam Roben  <aroben@apple.com>
2656
2657         Fix TestFailures's link to file a bug about TestFailures itself
2658
2659         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
2660         bug about itself is broken
2661
2662         Reviewed by Dan Bates.
2663
2664         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2665         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
2666         the host from the path.
2667
2668 2011-08-17  Adam Roben  <aroben@apple.com>
2669
2670         Teach TestFailures to ignore unbelievably short test runs
2671
2672         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
2673         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
2674
2675         Reviewed by Dan Bates.
2676
2677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2678         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
2679         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
2680         that caused it not to run any tests at all (as happened for a while due to
2681         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
2682
2683         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2684         Test for the above.
2685
2686         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2687         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
2688
2689 2011-08-16  Adam Barth  <abarth@webkit.org>
2690
2691         Add a CG qualifier similar to the GPU qualifier
2692         https://bugs.webkit.org/show_bug.cgi?id=66359
2693
2694         Reviewed by Eric Seidel.
2695
2696         Once we have a Skia configuration on Chromium Mac, we'll use this CG
2697         qualifier to note that expectations apply only to the CG configuration.
2698
2699         * Scripts/webkitpy/layout_tests/port/chromium.py:
2700         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2701
2702 2011-08-16  Eric Seidel  <eric@webkit.org>
2703
2704         REGRESSION(92717): WinPort needs to parse version information from port_name
2705         https://bugs.webkit.org/show_bug.cgi?id=66325
2706
2707         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
2708
2709         * Scripts/webkitpy/layout_tests/port/mac.py:
2710         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2711
2712 2011-08-16  Adam Barth  <abarth@webkit.org>
2713
2714         Change webkit-patch analyze-baselines to print in a more unix-friendly way
2715         https://bugs.webkit.org/show_bug.cgi?id=66349
2716
2717         Reviewed by James Robinson.
2718
2719         As requested by jamesr.
2720
2721         * Scripts/webkitpy/tool/commands/rebaseline.py:
2722
2723 2011-08-16  Eric Seidel  <eric@webkit.org>
2724
2725         REGRESSION(92717): WinPort needs to parse version information from port_name
2726         https://bugs.webkit.org/show_bug.cgi?id=66325
2727
2728         Reviewed by Adam Barth.
2729
2730         WinPort didn't have any port_name parsing logic.
2731         Seemed it was best to just share the logic from MacPort.
2732         Sharing the logic from MacPort seemed easiest with a shared superclass.
2733         Once I created ApplePort (the superclass) there was a bunch of logic to share.
2734         I found LeakDetector was just in the way when switching back and forth
2735         between win.py and mac.py so I moved it into its own file.
2736
2737         The only logic change here is that WinPort should now be
2738         able to parse port_name values like MacPort (and other ports)
2739         can.  The fact that ports do this in their constructors is
2740         wrong and a source of many bugs.  But at least now WinPort
2741         matches the status-quo.
2742
2743         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
2744         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
2745         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
2746         * Scripts/webkitpy/layout_tests/port/mac.py:
2747         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2748         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2749         * Scripts/webkitpy/layout_tests/port/win.py:
2750         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2751
2752 2011-08-16  Adam Barth  <abarth@webkit.org>
2753
2754         Add webkit-patch analyze-baselines, as requested by jamesr.
2755
2756         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2757         * Scripts/webkitpy/tool/commands/rebaseline.py:
2758
2759 2011-08-16  Adam Barth  <abarth@webkit.org>
2760
2761         Fold bulk-optimize-baselines into optimize-baselines
2762         https://bugs.webkit.org/show_bug.cgi?id=66345
2763
2764         Reviewed by James Robinson.
2765
2766         bulk-optimize-baselines is now a superset of optimize-baselines, so
2767         they can be combined.
2768
2769         * Scripts/webkitpy/tool/commands/rebaseline.py:
2770
2771 2011-08-16  Adam Barth  <abarth@webkit.org>
2772
2773         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
2774         https://bugs.webkit.org/show_bug.cgi?id=66334
2775
2776         Reviewed by Tony Chang.
2777
2778         This patch moves us closer to switching the Chromium port from
2779         CoreGraphics to Skia.  This patch teaches our tools that the current
2780         Chromium Mac configuration is actually chromium-cg-mac, which makes
2781         room for a future chromium-mac configuration that uses Skia.
2782
2783         Shortly after this patch lands, I'll do a server-side move of the
2784         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
2785         and chromium-cg-mac-leopard.
2786
2787         * BuildSlaveSupport/build.webkit.org-config/config.json:
2788         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2789         * Scripts/webkitpy/common/config/build.py:
2790         * Scripts/webkitpy/common/config/build_unittest.py:
2791         * Scripts/webkitpy/layout_tests/port/base.py:
2792         * Scripts/webkitpy/layout_tests/port/builders.py:
2793         * Scripts/webkitpy/layout_tests/port/chromium.py:
2794         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2795         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2796         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2797         * Scripts/webkitpy/layout_tests/port/factory.py:
2798         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2799         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2800         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2801         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2802         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2803         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2804         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2805
2806 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2807
2808         garden-o-matic frontend needs a friendly relative time description method.
2809         https://bugs.webkit.org/show_bug.cgi?id=66324
2810
2811         Reviewed by Adam Barth.
2812
2813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
2814         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
2815         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
2816
2817 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2818
2819         Summary view should not add multiple entries for the same test failure.
2820         https://bugs.webkit.org/show_bug.cgi?id=66318
2821
2822         Reviewed by Adam Barth.
2823
2824         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
2825         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
2826             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
2827         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2828
2829 2011-08-16  Adam Roben  <aroben@apple.com>
2830
2831         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
2832
2833         The basic strategy here is that once a test has failed or passed many times in a row we
2834         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
2835         in many fewer false positives than our current behavior.
2836
2837         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
2838         flaky, including tests that failed for a while but then were fixed
2839
2840         Reviewed by Dan Bates.
2841
2842         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
2843         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
2844         number of non-too-many-failure builds we've seen.
2845         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
2846         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
2847         tests, keep track of how many times they have passed or failed in a row. If they pass or
2848         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
2849         considered flaky it doesn't matter how many times it passes or fails.)
2850
2851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
2852         Added tests for the above.
2853
2854 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2855
2856         garden-o-matic needs a summary view with actions for each problem.
2857         https://bugs.webkit.org/show_bug.cgi?id=66144
2858
2859         Reviewed by Adam Barth.
2860
2861         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
2862         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
2863         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
2864         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
2865         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
2866         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
2867
2868 2011-08-16  Dean Jackson  <dino@apple.com>
2869
2870         Adding Ted "hober" O'Connor as a non-committing contributor.
2871
2872         * Scripts/webkitpy/common/config/committers.py:
2873
2874 2011-08-16  Adam Roben  <aroben@apple.com>
2875
2876         Teach TestFailures how to interpret unfinished test runs
2877
2878         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
2879         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
2880
2881         Reviewed by David Kilzer.
2882
2883         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2884         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
2885         rather than "isStarted" so that we don't count builds for which the test run never finished.
2886         Bumped the cache version to evict old, buggy cached data.
2887
2888         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2889         Added a test for the above, and made a somewhat synthetic test more realistic by including
2890         more of the actual JSON data from build.webkit.org.
2891
2892         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2893         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
2894         cached data.
2895
2896 2011-08-16  Adam Roben  <aroben@apple.com>
2897
2898         Make Apple's Windows port fall back to Lion results instead of SnowLeopard
2899
2900         Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
2901         should match Lion's behavior.
2902
2903         Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
2904         but doesn't use Lion results
2905
2906         Reviewed by David Kilzer.
2907
2908         * Scripts/old-run-webkit-tests:
2909         (expectedDirectoryForTest):
2910         * Scripts/webkitpy/layout_tests/port/win.py:
2911         (WinPort.baseline_search_path):
2912         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2913         (WinPortTest.test_baseline_search_path):
2914         Replaced mac-snowleopard with mac-lion.
2915
2916         * Scripts/webkitpy/common/config/build.py:
2917         (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
2918         directory, which all Apple Mac platforms and Apple Win platforms could potentially use
2919         results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
2920         will no longer look there for results.
2921
2922         * Scripts/webkitpy/common/config/build_unittest.py:
2923         (ShouldBuildTest.test_should_build): Tests for the above changes.
2924
2925 2011-08-16  Dean Jackson  <dino@apple.com>
2926
2927         Move me from contributor to reviewer.
2928
2929         * Scripts/webkitpy/common/config/committers.py:
2930
2931 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
2932
2933         garden-o-matic frontend needs model.commitDataForRevisionRange function.
2934         https://bugs.webkit.org/show_bug.cgi?id=66252
2935
2936         Reviewed by Adam Barth.
2937
2938         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
2939         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
2940
2941 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
2942
2943         garden-o-matic frontend needs a generic way to track updates.
2944         https://bugs.webkit.org/show_bug.cgi?id=66245
2945
2946         Reviewed by Adam Barth.
2947
2948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
2949         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
2950
2951 2011-08-15  Adam Roben  <aroben@apple.com>
2952
2953         Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
2954
2955         Failures now give output of the form: foo should be bar but is baz
2956
2957         Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
2958         test is in TestWebKitAPI's output
2959
2960         Reviewed by David Levin.
2961
2962         * TestWebKitAPI/JavaScriptTest.cpp:
2963         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
2964         members.
2965         (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
2966         object, rather than doing any testing of it here.
2967         (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
2968         to use a pretty error message when the test fails.
2969
2970         * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
2971         gtest-style macros that wrap it.
2972
2973         * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
2974
2975         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2976         (TestWebKitAPI::TEST): Changed to use the new macros.
2977
2978         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2979         (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
2980         longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
2981         the test passes, though. Returning early seems to have been an unnecessary optimization.
2982
2983         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2984         (TestWebKitAPI::TEST): Changed to use the new macros.
2985
2986 2011-08-15  Eric Seidel  <eric@webkit.org>
2987
2988         Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
2989
2990         Unreviewed.
2991
2992         * Scripts/run-webkit-tests:
2993         (usingLeaks):
2994         (useNewRunWebKitTests):
2995
2996 2011-08-14  Adam Barth  <abarth@webkit.org>
2997
2998         Switch results detail view over to new-style object-oriented UI widgets
2999         https://bugs.webkit.org/show_bug.cgi?id=66200
3000
3001         Reviewed by Dimitri Glazkov.
3002
3003         This patch replaces my goofy template-based UI for the results
3004         comparison screen with new object-oriented UI widgets.
3005
3006         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3007         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3009         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
3012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3013
3014 2011-08-13  Dimitri Glazkov  <dglazkov@chromium.org>
3015
3016         garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
3017         https://bugs.webkit.org/show_bug.cgi?id=66166
3018
3019         Also changed base.RequestTracker to:
3020         a) fire callback immediately if requestsInFlight is 0;
3021         b) not barf if callback is not supplied.
3022
3023         Reviewed by Adam Barth.
3024
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
3026         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
3027         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
3028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
3029
3030 2011-08-12  Mark Rowe  <mrowe@apple.com>
3031
3032         Be more forward-looking in the choice of compiler.
3033
3034         Rubber-stamped by Jon Honeycutt.
3035
3036         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
3037         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
3038         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
3039         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
3040
3041 2011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3042
3043         DRT: Add support for gesture events.
3044         https://bugs.webkit.org/show_bug.cgi?id=66105
3045
3046         Reviewed by Darin Fisher.
3047
3048         * DumpRenderTree/chromium/EventSender.cpp:
3049         (EventSender::EventSender):
3050         (EventSender::gestureScrollBegin):
3051         (EventSender::gestureScrollEnd):
3052         (EventSender::gestureTap):
3053         (EventSender::gestureEvent):
3054         * DumpRenderTree/chromium/EventSender.h:
3055
3056 2011-08-12  Andy Estes  <aestes@apple.com>
3057
3058         allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
3059         https://bugs.webkit.org/show_bug.cgi?id=66158
3060
3061         Reviewed by Dan Bernstein.
3062
3063         * DumpRenderTree/LayoutTestController.cpp:
3064         (allowRoundingHacksCallback): The third argument is the 'this'
3065         JSObjectRef, not the second.
3066
3067 2011-08-12  Andy Estes  <aestes@apple.com>
3068
3069         Cancel in onbeforeunload dialog sometime causes a button to stop working.
3070         https://bugs.webkit.org/show_bug.cgi?id=26211
3071
3072         Reviewed by Alexey Proskuryakov.
3073
3074         Implement a new LayoutTestController method that a test can call to set
3075         the return value of DumpRenderTree's beforeunload UI delegate.
3076
3077         * DumpRenderTree/LayoutTestController.cpp:
3078         (LayoutTestController::LayoutTestController): Initialize
3079         m_shouldStayOnPageAfterHandlingBeforeUnload.
3080         (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
3081         LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
3082         (LayoutTestController::staticFunctions): Register
3083         'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
3084         * DumpRenderTree/LayoutTestController.h: 
3085         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
3086         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
3087         * DumpRenderTree/chromium/LayoutTestController.cpp:
3088         (LayoutTestController::LayoutTestController): Initialize
3089         m_shouldStayOnPageAfterHandlingBeforeUnload and bind
3090         'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
3091         (LayoutTestController::reset): Reset
3092         m_shouldStayOnPageAfterHandlingBeforeUnload to false.
3093         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
3094         Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
3095         from JavaScript.
3096         * DumpRenderTree/chromium/LayoutTestController.h:
3097         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
3098         * DumpRenderTree/chromium/WebViewHost.cpp:
3099         (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
3100         return the inverse of
3101         LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
3102         * DumpRenderTree/mac/UIDelegate.mm:
3103         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
3104         * DumpRenderTree/win/UIDelegate.cpp:
3105         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3106         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3107         Define setShouldStayOnPageAfterHandlingBeforeUnload().
3108         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3109         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
3110         to the Test Controller telling it what value it should return in its
3111         onbeforeunload UI delegate.
3112         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3113         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3114         (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
3115         Call InjectedBundle::postNewBeforeUnloadReturnValue().
3116         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3117         * WebKitTestRunner/TestController.cpp:
3118         (WTR::TestController::TestController): Initialize
3119         m_beforeUnloadReturnValue to true.
3120         (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
3121         the value of TestController::beforeUnloadReturnValue().
3122         (WTR::TestController::resetStateToConsistentValues): Reset
3123         m_beforeUnloadReturnValue to true.
3124         * WebKitTestRunner/TestController.h:
3125         (WTR::TestController::beforeUnloadReturnValue):
3126         (WTR::TestController::setBeforeUnloadReturnValue):
3127         * WebKitTestRunner/TestInvocation.cpp:
3128         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
3129         message posted from the injected bundle by retrieving the message body
3130         as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
3131
3132 2011-08-12  Sam Weinig  <sam@webkit.org>
3133
3134         Move compiler specific macros to their own header
3135         https://bugs.webkit.org/show_bug.cgi?id=66119
3136
3137         Reviewed by Anders Carlsson.
3138
3139         * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
3140
3141 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3142
3143         Add a way to extend DOM objects in garden-o-matic.
3144         https://bugs.webkit.org/show_bug.cgi?id=66096
3145
3146         Reviewed by Adam Barth.
3147
3148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
3149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
3150
3151 2011-08-11  MORITA Hajime  <morrita@google.com>
3152
3153         [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
3154         https://bugs.webkit.org/show_bug.cgi?id=45438
3155
3156         Reviewed by Kent Tamura.
3157
3158         MockSpellCheck was assuming the input of spellCheckWord() is a word.
3159         But it can be a series of word. This change made spellCheckWord()
3160         understand simple word boundary which appears in tests.
3161         
3162         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3163         (MockSpellCheck::spellCheckWord):
3164
3165 2011-08-11  Mark Rowe  <mrowe@apple.com>
3166
3167         Rework some Makefile logic to remove a double-negative.
3168
3169         Reviewed by Jon Honeycutt.
3170
3171         * DumpRenderTree/mac/PerlSupport/Makefile:
3172
3173 2011-08-11  Anders Carlsson  <andersca@apple.com>
3174
3175         Add a FIXME.
3176
3177         * TestWebKitAPI/TestsController.cpp:
3178         (TestWebKitAPI::TestsController::TestsController):
3179
3180 2011-08-11  Anders Carlsson  <andersca@apple.com>
3181
3182         Initialize threading before running any tests
3183         https://bugs.webkit.org/show_bug.cgi?id=66112
3184
3185         Reviewed by Adam Barth.
3186
3187         * TestWebKitAPI/TestsController.cpp:
3188         (TestWebKitAPI::TestsController::TestsController):
3189
3190 2011-08-11  Adam Barth  <abarth@webkit.org>
3191
3192         Add unexpected-passes.html to TestFailures for marking tests as passing
3193         https://bugs.webkit.org/show_bug.cgi?id=66102
3194
3195         Reviewed by Dimitri Glazkov.
3196
3197         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3199             - Move some code into the library so it can be shared.
3200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3203             - Add round-trip unit tests.
3204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
3205         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
3206             - I'm not entirely sure this feature should remain a separate HTML
3207               file, but it seemed better than cluttering up the main HTML file
3208               with too much extra stuff.
3209         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3210         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3211             - The gardening server couldn't handle adding PASS expectations.  Now it can.
3212
3213 2011-08-11  Eric Seidel  <eric@webkit.org>
3214
3215         NRWT has wrong fallback order for Mac now that Lion exists
3216         https://bugs.webkit.org/show_bug.cgi?id=66093
3217
3218         Reviewed by Adam Barth.
3219
3220         ORWT used a different system for fallback orders than NRWT did.
3221         I moved win.py to match ORWT fallback orders in bug 64486.
3222         This bug moves mac.py to match ORWT fallback order
3223         and adds 'lion' as a supported OS version.
3224
3225         Because ChromiumMac shares OS version detection code with AppleMac
3226         this also added support for 'lion' to chromium mac.  Hopefully that's a good thing.
3227
3228         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3229         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3230         * Scripts/webkitpy/layout_tests/port/mac.py:
3231         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3232         * Scripts/webkitpy/layout_tests/port/win.py:
3233
3234 2011-08-11  Adam Barth  <abarth@webkit.org>
3235
3236         Update test results now that we use absolute URLs.
3237
3238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
3239
3240 2011-08-11  Adam Barth  <abarth@webkit.org>
3241
3242         garden-o-matic should be able to determine when tests unexpectedly pass
3243         https://bugs.webkit.org/show_bug.cgi?id=66092
3244
3245         Reviewed by Dimitri Glazkov.
3246
3247         This patch just contains the library methods for extracting this
3248         information.  I'll add some UI in a subsequent patch.
3249
3250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
3251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
3252
3253 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3254
3255         New expectation entries should be placed next to existing ones.
3256         https://bugs.webkit.org/show_bug.cgi?id=66066
3257
3258         Reviewed by Adam Barth.
3259
3260         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
3261             which is computed as the last found reference to the same test.
3262         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
3263
3264 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3265
3266         Unreviewed, rolling out r92847.
3267         http://trac.webkit.org/changeset/92847
3268         https://bugs.webkit.org/show_bug.cgi?id=65986
3269
3270         Broke check-webkit-style
3271
3272         * Scripts/webkitpy/style/checker.py:
3273         * Scripts/webkitpy/style/checker_unittest.py:
3274
3275 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3276
3277         Unreviewed, rolling out r92847.
3278         http://trac.webkit.org/changeset/92847
3279         https://bugs.webkit.org/show_bug.cgi?id=65986
3280
3281         Broke check-webkit-style
3282
3283         * Scripts/webkitpy/style/checker.py:
3284         * Scripts/webkitpy/style/checker_unittest.py:
3285
3286 2011-08-11  Pierre Rossi  <pierre.rossi@gmail.com>
3287
3288         [Qt] autotests shouldn't require config.h in the style check
3289         https://bugs.webkit.org/show_bug.cgi?id=65986
3290
3291         Remove the include rules from the style-check for Qt tests.
3292         Since for the most part it's just a matter of using the
3293         API provided by QtWebKit, enforcing the WebCore set of rules
3294         only seems to make sense in the case of MIMESniffing.
3295
3296         Reviewed by Benjamin Poulain.
3297
3298         * Scripts/webkitpy/style/checker.py:
3299         * Scripts/webkitpy/style/checker_unittest.py:
3300
3301 2011-08-11  Zsolt Fehér  <h490267@stud.u-szeged.hu>
3302
3303         [WK2] Implement waitForPolicyDelegate
3304         https://bugs.webkit.org/show_bug.cgi?id=42330
3305
3306         Reviewed by Csaba Osztrogonác.
3307
3308         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3309         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3310         (WTR::navigationTypeToString):
3311         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3312         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3313         (WTR::LayoutTestController::LayoutTestController):
3314         (WTR::LayoutTestController::setCustomPolicyDelegate):
3315         (WTR::LayoutTestController::waitForPolicyDelegate):
3316         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3317         (WTR::LayoutTestController::isPolicyDelegateEnabled):
3318         (WTR::LayoutTestController::isPolicyDelegatePermissive):
3319
3320 2011-08-11  Adam Barth  <abarth@webkit.org>
3321
3322         rebaseline-expectations should use the release bots, not the debug
3323         bots.  The debug bots don't all run all the tests.  Also, delay
3324         updating test_expectations a long as possible to avoid clearing out
3325         lines that we'll need for other ports.
3326
3327         * Scripts/webkitpy/layout_tests/port/builders.py:
3328         * Scripts/webkitpy/tool/commands/rebaseline.py:
3329         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3330
3331 2011-08-10  Ryosuke Niwa  <rniwa@webkit.org>
3332
3333         r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
3334         Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
3335
3336         * BuildSlaveSupport/build.webkit.org-config/config.json:
3337
3338 2011-08-10  Eric Seidel  <eric@webkit.org>
3339
3340         new-run-webkit-test's WinPort has no fallback logic
3341         https://bugs.webkit.org/show_bug.cgi?id=64486
3342
3343         Unreviewed.
3344
3345         Turns out that we've long had a subtle bug whereby if you didn't
3346         already have DumpRenderTree built, we might end up running unsupported tests
3347         because the DumpRenderTree --print-supported-features check would silently fail.
3348
3349         When I moved the call from using popen to using Executive.run_command, this silent
3350         failure became noisy.  (Breaking some bots.)
3351
3352         This re-orders our steps so that we always build DRT before collecting expectations,
3353         as well as adds a warning message when DumpRenderTree can't be found.
3354
3355         * Scripts/webkitpy/layout_tests/port/webkit.py:
3356         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3357
3358 2011-08-10  Eric Seidel  <eric@webkit.org>
3359
3360         new-run-webkit-test's WinPort has no fallback logic
3361         https://bugs.webkit.org/show_bug.cgi?id=64486
3362
3363         Unreviewed.  Fix test-webkitpy under Python 2.5.
3364
3365         * Scripts/webkitpy/layout_tests/port/win.py:
3366
3367 2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
3368
3369         [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
3370         https://bugs.webkit.org/show_bug.cgi?id=65875
3371
3372         Reviewed by Kenneth Rohde Christiansen.
3373
3374         For some reason, QWidget send fake mouse event on some platform, under certains conditions.
3375
3376         This causes mouse events to be sent twice in some cases. We work around the problem
3377         by defining the first touch point to be a primary touch point (case which hit some
3378         weird condition in QWidget, skipping the generation of fake mouse events).
3379
3380         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3381         (MiniBrowserApplication::notify):
3382
3383 2011-08-10  David Hyatt  <hyatt@apple.com>
3384
3385         https://bugs.webkit.org/show_bug.cgi?id=66004
3386
3387         Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
3388         the code on by default.
3389
3390         Reviewed by Adam Roben.
3391
3392         * BuildSlaveSupport/build.webkit.org-config/config.json:
3393         * Scripts/build-webkit:
3394
3395 2011-08-10  Oliver Hunt  <oliver@apple.com>
3396
3397         JSEvaluteScript does not return the correct object when given JSONP data
3398         https://bugs.webkit.org/show_bug.cgi?id=66003
3399
3400         Reviewed by Gavin Barraclough.
3401
3402         Add a test case.
3403
3404         * DumpRenderTree/mac/DumpRenderTree.mm:
3405         (testStringByEvaluatingJavaScriptFromString):
3406
3407 2011-08-10  Eric Seidel  <eric@webkit.org>
3408
3409         WIN: NRWT runs compositing tests on configurations that don't support compositing
3410         https://bugs.webkit.org/show_bug.cgi?id=64472
3411
3412         Reviewed by Adam Barth.
3413
3414         I think the code was just wrong.  It was never splitting the string
3415         into list pieces before.
3416         I've now tested the supported_features code and theoretically it
3417         should now work with Windows DRT.
3418
3419         I also made the list-lookup functions always return lists, to make
3420         it possible to clean up the list-transform code in the future
3421         (I opted not to do that cleanup in this patch, but at least now
3422         both types of feature lookup functions match return types.)
3423
3424         * Scripts/webkitpy/layout_tests/port/webkit.py:
3425         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3426
3427 2011-08-10  Eric Seidel  <eric@webkit.org>
3428
3429         Clean up ChromiumDriver a little
3430         https://bugs.webkit.org/show_bug.cgi?id=65995
3431
3432         Unreviewed.
3433
3434         Fix NRWT for chromium.  Silly python.
3435
3436         * Scripts/webkitpy/layout_tests/port/chromium.py:
3437
3438 2011-08-10  Eric Seidel  <eric@webkit.org>
3439
3440         Clean up ChromiumDriver a little
3441         https://bugs.webkit.org/show_bug.cgi?id=65995
3442
3443         Reviewed by Adam Barth.
3444
3445         - We no longer support threading, so remove threading specific code.
3446         - Add FIXMEs about using ServerProcess instead.
3447         - Condense option-mapping if-cascade into a for loop.
3448         - Unindent long if blocks by using early return.
3449         - Unwrap lines which are needlessly wrapped.
3450
3451         There should be no functional changes here, just code cleanup/dead-code removal.
3452
3453         * Scripts/webkitpy/layout_tests/port/chromium.py:
3454
3455 2011-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
3456
3457         Unmuddle construction options for TestConfiguration.
3458         https://bugs.webkit.org/show_bug.cgi?id=65988
3459
3460         The TestConfiguration instance is now constructed only using actual values.
3461         Port-based construction is split into a "from_port" class method.
3462
3463         Reviewed by Eric Seidel.
3464
3465         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
3466         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
3467         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
3468         * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
3469         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
3470
3471 2011-08-10  Eric Seidel  <eric@webkit.org>
3472
3473         Leaks bot shows python logging prefixes as part of summary display
3474         https://bugs.webkit.org/show_bug.cgi?id=65931
3475
3476         Reviewed by Adam Barth.
3477
3478         The big part of this change is adding a unittesting system for
3479         master.cfg, so mere-mortals can make changes to build.webkit.org
3480         with greatly-reduced risk of breaking the world.
3481
3482         Turns out that in typing up my trival logging fix I made 2 typos,
3483         so hopefully the hour spent getting master.cfg to load was worth it. :)
3484
3485         I also tried to make mastercfg_unittest run as part of test-webkitpy
3486         but right now test-webkitpy requires that unittest files be located in
3487         a module-name-compatible directory.  'build.webkit.org-config' is not
3488         a valid module name.
3489
3490         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3491          - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
3492            by using a new _strip_python_logging_prefix function.
3493          - Also fixed this function to file to work with a more modern
3494            simplejson version (which returns unicode objects instead of str objects)
3495            and filed a related bug with buildbot.net due to their handling of unicode builder names.
3496         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
3497          - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
3498          - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
3499         * Scripts/webkitpy/thirdparty/__init__.py:
3500          - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
3501
3502 2011-08-09  Dimitri Glazkov  <dglazkov@chromium.org>
3503
3504         garden-o-matic should extrapolate failures given a set of known results
3505         https://bugs.webkit.org/show_bug.cgi?id=65882
3506
3507         Reviewed by Adam Barth.
3508
3509         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
3510         * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
3511             adjusted all call sites.
3512         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
3513             makes wider net for specific failures.
3514         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
3515
3516 2011-08-10  Adam Barth  <abarth@webkit.org>
3517
3518         The URL we were computing for retrieving baselines was missing a slash
3519         character because our mocks had an extra slash character.  I've
3520         corrected both the code and the mock.
3521
3522         * Scripts/webkitpy/tool/commands/rebaseline.py:
3523         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3524         * Scripts/webkitpy/tool/mocktool.py:
3525
3526 2011-08-09  Adam Barth  <abarth@webkit.org>
3527
3528         Move the quote mark to the right place.
3529
3530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
3531
3532 2011-08-09  Adam Barth  <abarth@webkit.org>
3533
3534         garden-o-matic should use huerstics to narrow regression range
3535         https://bugs.webkit.org/show_bug.cgi?id=65948
3536
3537         Reviewed by Dimitri Glazkov.
3538
3539         When analyzing a regression range, if one of the commit messages
3540         mentions the test in question, we now hueristically assume that
3541         revision caused the failure.  (I'm shamelessly stealing this idea from
3542         TestFailures.)
3543
3544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3545
3546 2011-07-13  Eric Seidel  <eric@webkit.org>
3547
3548         new-run-webkit-test's WinPort has no fallback logic
3549         https://bugs.webkit.org/show_bug.cgi?id=64486
3550
3551         Reviewed by Adam Roben.
3552
3553         I've tried to write a patch for bug 64439 twice now, and both times
3554         I've ended up re-writing half the port system.  So I'm breaking
3555         things up into smaller pieces, this being the first.
3556
3557         WinPort still does not have any port_name parsing, so when instantiated
3558         with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
3559         I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
3560
3561         Otherwise this should "just work" for windows.  I've not been able to test the
3562         version detection on my mac, but the unit tests show the code behaving as designed.
3563
3564         * Scripts/webkitpy/layout_tests/port/win.py:
3565         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
<