d1f7f01c0d6aa8cfffab97fc8172f5cb5cdc4639
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-29  Brent Fulgham  <bfulgham@apple.com>
2
3         ResourceLoadStatistics logic does not understand custom WebsiteData stores
4         https://bugs.webkit.org/show_bug.cgi?id=176037
5         <rdar://problem/33338238>
6
7         Reviewed by Alex Christensen.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
10         (TEST): Update for ResourceLoadStatistics directories.
11
12 2017-08-29  Brady Eidson  <beidson@apple.com>
13
14         Rename "potentionally trustworthy" to "potentially trustworthy"
15         https://bugs.webkit.org/show_bug.cgi?id=176081
16
17         Reviewed by Daniel Bates.
18
19         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
20         (TestWebKitAPI::TEST_F):
21
22 2017-08-29  Stephan Szabo  <stephan.szabo@sony.com>
23
24         [Win][JSCOnly] Fix call for updating wincairo-libs in build-jsc
25         https://bugs.webkit.org/show_bug.cgi?id=176080
26
27         Reviewed by Brent Fulgham.
28
29         * Scripts/build-jsc:
30
31 2017-08-29  Adrian Perez de Castro  <aperez@igalia.com>
32
33         [WPE] Avoid using autogen for JHBuild modules, trying to fix the EWS
34
35         Unreviewed build fix.
36
37         This also makes the JHBuild process faster, because there are less
38         modules which will trigger slow, ancient Perl and M4 based tooling.
39
40         * wpe/jhbuild.modules:
41
42 2017-08-29  Don Olmstead  <don.olmstead@sony.com>
43
44         [CMake] Use find_package for libxml2 and libxstl
45         https://bugs.webkit.org/show_bug.cgi?id=176042
46
47         Reviewed by Konstantin Tokarev.
48
49         * TestWebKitAPI/PlatformWin.cmake:
50
51 2017-08-29  Per Arne Vollan  <pvollan@apple.com>
52
53         [Win] A WTF test is timing out in run-api-tests.
54         https://bugs.webkit.org/show_bug.cgi?id=176056
55
56         Reviewed by Brent Fulgham.
57
58         The test SynchronizedFixedQueue.ProduceOnly relies on that putting a thread to sleep for
59         1ms will wake it up before another thread which is put to sleep for 10ms. I believe this
60         is not neccessarily true on Windows where the thread scheduling does not have millisecond
61         accuracy. Fix the test timeout by adjusting the sleep time slightly.
62  
63         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
64         (TestWebKitAPI::ToUpperConverter::startProducing):
65
66 2017-08-29  Eric Carlson  <eric.carlson@apple.com>
67
68         Unreviewed, update my watchlist filters.
69
70         * Scripts/webkitpy/common/config/watchlist:
71
72 2017-08-29  Carlos Garcia Campos  <cgarcia@igalia.com>
73
74         Unreviewed. REGRESSION(r221219): Fix unit tests using resources from WebKit directory.
75
76         The WebKit2 directory was renamed as WebKit in r221219, but neither run-gtk-tests script nor
77         Test::getResourcesDir() were updated to use the new name.
78
79         * Scripts/run-gtk-tests:
80         (TestRunner._setup_testing_environment):
81         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
82         (Test::getResourcesDir):
83
84 2017-08-28  Eric Carlson  <eric.carlson@apple.com>
85
86         Logger should use makeString instead of String::format
87         https://bugs.webkit.org/show_bug.cgi?id=176035
88
89         Reviewed by Jer Noble.
90
91         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
92         (TestWebKitAPI::TEST_F): Update test.
93
94 2017-08-28  Michael Catanzaro  <mcatanzaro@igalia.com>
95
96         [GStreamer] The glvideoflip GStreamer element isn't available. Video mirroring and rotation functionalities are thus disabled.
97         https://bugs.webkit.org/show_bug.cgi?id=175576
98
99         Reviewed by Carlos Alberto Lopez Perez.
100
101         Build graphene to enable the glvideoflip element.
102
103         * gstreamer/jhbuild.modules:
104         * gtk/jhbuild.modules:
105         * jhbuild/jhbuild-wrapper:
106         * wpe/jhbuild.modules:
107
108 2017-08-28  Ms2ger  <Ms2ger@gmail.com>
109
110         Ensure that the alert function is called in TestWebExtensions.
111         https://bugs.webkit.org/show_bug.cgi?id=175880
112
113         Reviewed by Carlos Garcia Campos.
114
115         The test relied on a bug in the HTMLDocument JavaScript bindings: when calling
116         document.open() with three arguments, it would call any function set as the
117         "open" property on the window object, rather than just the real Window::open()
118         method. This bug was fixed by the removal of custom bindings for HTMLDocument
119         in r218437. As a result, the test no longer called alert(), which caused it to
120         fail.
121
122         Instead, call the window.open() function directly.
123
124         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
125         (testWebExtensionIsolatedWorld):
126
127 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
128
129         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
130         https://bugs.webkit.org/show_bug.cgi?id=170955
131         <rdar://problem/31697653>
132
133         Reviewed by Ryosuke Niwa.
134
135         Replace UIScriptController.insertText with UIScriptController.replaceTextAtRange, and implement
136         replaceTextAtRange in WebKit1. See corresponding layout tests (input-event-insert-replacement.html and
137         before-input-prevent-insert-replacement.html) for more detail.
138
139         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
140         * DumpRenderTree/mac/AppKitTestSPI.h: Added.
141
142         Introduce an SPI header for private AppKit headers needed to support DumpRenderTree.
143
144         * DumpRenderTree/mac/UIScriptControllerMac.mm:
145         (WTR::UIScriptController::replaceTextAtRange):
146         (WTR::UIScriptController::insertText): Deleted.
147         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
148         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
149         (WTR::UIScriptController::replaceTextAtRange):
150         (WTR::UIScriptController::insertText): Deleted.
151         * TestRunnerShared/UIScriptContext/UIScriptController.h:
152         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
153         (WTR::UIScriptController::replaceTextAtRange):
154         (WTR::UIScriptController::insertText): Deleted.
155
156         Replace UIScriptController.insertText with UIScriptController.replaceTextAtRange, which better describes the
157         behavior of this function.
158
159 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
160
161         [iOS WK2] Web process crashes after changing selection to the end of the document when speaking a selection
162         https://bugs.webkit.org/show_bug.cgi?id=176011
163         <rdar://problem/32614095>
164
165         Reviewed by Ryosuke Niwa.
166
167         Introduces AccessibilityTests, and adds three new tests that traverse selection-rect-finding codepaths when
168         speaking selected content. See WebKit and WebCore ChangeLogs for more detail.
169
170         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
171         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm: Added.
172         (-[WKWebView rectsAtSelectionOffset:withText:]):
173         (checkCGRectValueAtIndex):
174         (TestWebKitAPI::TEST):
175
176 2017-08-25  Eric Carlson  <eric.carlson@apple.com>
177
178         Add Logger::logAlways
179         https://bugs.webkit.org/show_bug.cgi?id=175996
180
181         Reviewed by Jer Noble.
182
183         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
184         (TestWebKitAPI::TEST_F):
185
186 2017-08-25  Alex Christensen  <achristensen@webkit.org>
187
188         Disable saveDataToFile API test.
189         https://bugs.webkit.org/show_bug.cgi?id=176000
190
191         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
192         The test was only working on High Sierra.  It needs investigation on older operating systems.
193
194 2017-08-25  Alex Christensen  <achristensen@webkit.org>
195
196         Rename TestWebKitAPI/Tests/WebKit2* to WebKit* following Source directory rename.
197
198         Rubber-stamped by Brady Eidson.
199
200         * TestWebKitAPI/PlatformGTK.cmake:
201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
202         * TestWebKitAPI/Tests/WebKit2Cocoa: Removed.
203         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: Removed.
204         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsPlugin.mm: Removed.
205         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsProtocol.h: Removed.
206         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Removed.
207         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Removed.
208         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Removed.
209         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Removed.
210         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Removed.
211         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Removed.
212         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Removed.
213         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Removed.
214         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Removed.
215         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Removed.
216         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Removed.
217         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Removed.
218         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Removed.
219         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Removed.
220         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Removed.
221         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Removed.
222         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Removed.
223         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: Removed.
224         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Removed.
225         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Removed.
226         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Removed.
227         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Removed.
228         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Removed.
229         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Removed.
230         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Removed.
231         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Removed.
232         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Removed.
233         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Removed.
234         * TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm: Removed.
235         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Removed.
236         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestBlobURL.html: Removed.
237         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Removed.
238         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Removed.
239         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Removed.
240         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Removed.
241         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Removed.
242         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Removed.
243         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm: Removed.
244         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Removed.
245         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.html: Removed.
246         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm: Removed.
247         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Removed.
248         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Removed.
249         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Removed.
250         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Removed.
251         * TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Removed.
252         * TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Removed.
253         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Removed.
254         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Removed.
255         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Removed.
256         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Removed.
257         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Removed.
258         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Removed.
259         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Removed.
260         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Removed.
261         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Removed.
262         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Removed.
263         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Removed.
264         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Removed.
265         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Removed.
266         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Removed.
267         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Removed.
268         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Removed.
269         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Removed.
270         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Removed.
271         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Removed.
272         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Removed.
273         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Removed.
274         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Removed.
275         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Removed.
276         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Removed.
277         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Removed.
278         * TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Removed.
279         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Removed.
280         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Removed.
281         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Removed.
282         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Removed.
283         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Removed.
284         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Removed.
285         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Removed.
286         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Removed.
287         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Removed.
288         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Removed.
289         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Removed.
290         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkEnabled.html: Removed.
291         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkTest.mm: Removed.
292         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Removed.
293         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Removed.
294         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: Removed.
295         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: Removed.
296         * TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Removed.
297         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Removed.
298         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Removed.
299         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Removed.
300         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Removed.
301         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Removed.
302         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm: Removed.
303         * TestWebKitAPI/Tests/WebKit2Cocoa/PrepareForMoveToWindow.mm: Removed.
304         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Removed.
305         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Removed.
306         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Removed.
307         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Removed.
308         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Removed.
309         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm: Removed.
310         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm: Removed.
311         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h: Removed.
312         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Removed.
313         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Removed.
314         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Removed.
315         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Removed.
316         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Removed.
317         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: Removed.
318         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Removed.
319         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Removed.
320         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Removed.
321         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Removed.
322         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm: Removed.
323         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorldPlugIn.mm: Removed.
324         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorldProtocol.h: Removed.
325         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Removed.
326         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Removed.
327         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Removed.
328         * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Removed.
329         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Removed.
330         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm: Removed.
331         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm: Removed.
332         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Removed.
333         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Removed.
334         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFView.mm: Removed.
335         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Removed.
336         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm: Removed.
337         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Removed.
338         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Removed.
339         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Removed.
340         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: Removed.
341         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Removed.
342         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Removed.
343         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Removed.
344         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Removed.
345         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Removed.
346         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm: Removed.
347         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Removed.
348         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Removed.
349         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Removed.
350         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Removed.
351         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html: Removed.
352         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm: Removed.
353         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Removed.
354         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Removed.
355         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Removed.
356         * TestWebKitAPI/Tests/WebKit2Cocoa/attachment-element.html: Removed.
357         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
358         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Removed.
359         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Removed.
360         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
361         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Removed.
362         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: Removed.
363         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: Removed.
364         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Removed.
365         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Removed.
366         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Removed.
367         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Removed.
368         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Removed.
369         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Removed.
370         * TestWebKitAPI/Tests/WebKit2Cocoa/double-click-does-not-select-trailing-space.html: Removed.
371         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Removed.
372         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Removed.
373         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Removed.
374         * TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Removed.
375         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Removed.
376         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous-video-with-sound.html: Removed.
377         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Removed.
378         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Removed.
379         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Removed.
380         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Removed.
381         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Removed.
382         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
383         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
384         * TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Removed.
385         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Removed.
386         * TestWebKitAPI/Tests/WebKit2Cocoa/input-field-in-scrollable-document.html: Removed.
387         * TestWebKitAPI/Tests/WebKit2Cocoa/large-input-field-focus-onload.html: Removed.
388         * TestWebKitAPI/Tests/WebKit2Cocoa/large-red-square.png: Removed.
389         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Removed.
390         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-mutes-onplaying.html: Removed.
391         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: Removed.
392         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Removed.
393         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Removed.
394         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Removed.
395         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: Removed.
396         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Removed.
397         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Removed.
398         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Removed.
399         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Removed.
400         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Removed.
401         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Removed.
402         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Removed.
403         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Removed.
404         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Removed.
405         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Removed.
406         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
407         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Removed.
408         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Removed.
409         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Removed.
410         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Removed.
411         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Removed.
412         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Removed.
413         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Removed.
414         * TestWebKitAPI/Tests/WebKit2Cocoa/password-protected.pages: Removed.
415         * TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Removed.
416         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Removed.
417         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Removed.
418         * TestWebKitAPI/Tests/WebKit2Cocoa/rendered-image-excluding-overflow.html: Removed.
419         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Removed.
420         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Removed.
421         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Removed.
422         * TestWebKitAPI/Tests/WebKit2Cocoa/text-and-password-inputs.html: Removed.
423         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Removed.
424         * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Removed.
425         * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: Removed.
426         * TestWebKitAPI/Tests/WebKit2Gtk: Removed.
427         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Removed.
428         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Removed.
429         * TestWebKitAPI/Tests/WebKit2Gtk/DOMClientRectTest.cpp: Removed.
430         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Removed.
431         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Removed.
432         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Removed.
433         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Removed.
434         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Removed.
435         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Removed.
436         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Removed.
437         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Removed.
438         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMClientRect.cpp: Removed.
439         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Removed.
440         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Removed.
441         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Removed.
442         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Removed.
443         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Removed.
444         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Removed.
445         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Removed.
446         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Removed.
447         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Removed.
448         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Removed.
449         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Removed.
450         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Removed.
451         * TestWebKitAPI/Tests/WebKit2ObjC: Removed.
452         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Removed.
453         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Removed.
454         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Removed.
455         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Removed.
456         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Removed.
457         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: Removed.
458         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Removed.
459         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Removed.
460         * TestWebKitAPI/Tests/WebKitCocoa: Copied from TestWebKitAPI/Tests/WebKit2Cocoa.
461         * TestWebKitAPI/Tests/WebKitGtk: Copied from TestWebKitAPI/Tests/WebKit2Gtk.
462         * TestWebKitAPI/Tests/WebKitObjC: Copied from TestWebKitAPI/Tests/WebKit2ObjC.
463         * TestWebKitAPI/glib/PlatformGTK.cmake:
464
465 2017-08-25  Alex Christensen  <achristensen@webkit.org>
466
467         Rename TestWebKitAPI/Tests/WebKit2 to WebKit following Source directory rename.
468
469         Rubber-stamped by Brady Eidson.
470
471         * TestWebKitAPI/CMakeLists.txt:
472         * TestWebKitAPI/PlatformGTK.cmake:
473         * TestWebKitAPI/PlatformWin.cmake:
474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
475         * TestWebKitAPI/Tests/WebKit: Copied from TestWebKitAPI/Tests/WebKit2.
476         * TestWebKitAPI/Tests/WebKit2: Removed.
477         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Removed.
478         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Removed.
479         * TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Removed.
480         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Removed.
481         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Removed.
482         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Removed.
483         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Removed.
484         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Removed.
485         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Removed.
486         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Removed.
487         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: Removed.
488         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: Removed.
489         * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Removed.
490         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Removed.
491         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Removed.
492         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Removed.
493         * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp: Removed.
494         * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: Removed.
495         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Removed.
496         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Removed.
497         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Removed.
498         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Removed.
499         * TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Removed.
500         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp: Removed.
501         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Removed.
502         * TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Removed.
503         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Removed.
504         * TestWebKitAPI/Tests/WebKit2/Find.cpp: Removed.
505         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Removed.
506         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp: Removed.
507         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Removed.
508         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Removed.
509         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Removed.
510         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Removed.
511         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: Removed.
512         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: Removed.
513         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: Removed.
514         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Removed.
515         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Removed.
516         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Removed.
517         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Removed.
518         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp: Removed.
519         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp: Removed.
520         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: Removed.
521         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: Removed.
522         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Removed.
523         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp: Removed.
524         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Removed.
525         * TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Removed.
526         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Removed.
527         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Removed.
528         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Removed.
529         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Removed.
530         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Removed.
531         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Removed.
532         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp: Removed.
533         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Removed.
534         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Removed.
535         * TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Removed.
536         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Removed.
537         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Removed.
538         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Removed.
539         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Removed.
540         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Removed.
541         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Removed.
542         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Removed.
543         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Removed.
544         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Removed.
545         * TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Removed.
546         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: Removed.
547         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Removed.
548         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Removed.
549         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Removed.
550         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: Removed.
551         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: Removed.
552         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Removed.
553         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Removed.
554         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Removed.
555         * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Removed.
556         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Removed.
557         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Removed.
558         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Removed.
559         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Removed.
560         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Removed.
561         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Removed.
562         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Removed.
563         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Removed.
564         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Removed.
565         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Removed.
566         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Removed.
567         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Removed.
568         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Removed.
569         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Removed.
570         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Removed.
571         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Removed.
572         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Removed.
573         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Removed.
574         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Removed.
575         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Removed.
576         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Removed.
577         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Removed.
578         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Removed.
579         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Removed.
580         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Removed.
581         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Removed.
582         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Removed.
583         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Removed.
584         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Removed.
585         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Removed.
586         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Removed.
587         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp: Removed.
588         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Removed.
589         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Removed.
590         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Removed.
591         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Removed.
592         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Removed.
593         * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: Removed.
594         * TestWebKitAPI/Tests/WebKit2/WKURL.cpp: Removed.
595         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Removed.
596         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Removed.
597         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
598         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Removed.
599         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Removed.
600         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: Removed.
601         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: Removed.
602         * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Removed.
603         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Removed.
604         * TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html: Removed.
605         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Removed.
606         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Removed.
607         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Removed.
608         * TestWebKitAPI/Tests/WebKit2/autoplay-inherits-gesture-from-document.html: Removed.
609         * TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Removed.
610         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Removed.
611         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Removed.
612         * TestWebKitAPI/Tests/WebKit2/autoplay-zero-volume-check.html: Removed.
613         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Removed.
614         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Removed.
615         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Removed.
616         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: Removed.
617         * TestWebKitAPI/Tests/WebKit2/cocoa: Removed.
618         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Removed.
619         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Removed.
620         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Removed.
621         * TestWebKitAPI/Tests/WebKit2/encrypted.pdf: Removed.
622         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Removed.
623         * TestWebKitAPI/Tests/WebKit2/execCopy.html: Removed.
624         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Removed.
625         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Removed.
626         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Removed.
627         * TestWebKitAPI/Tests/WebKit2/find.html: Removed.
628         * TestWebKitAPI/Tests/WebKit2/findRanges.html: Removed.
629         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Removed.
630         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Removed.
631         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Removed.
632         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Removed.
633         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Removed.
634         * TestWebKitAPI/Tests/WebKit2/gtk: Removed.
635         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Removed.
636         * TestWebKitAPI/Tests/WebKit2/icon.png: Removed.
637         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Removed.
638         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Removed.
639         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Removed.
640         * TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Removed.
641         * TestWebKitAPI/Tests/WebKit2/link-with-download-attribute-with-slashes.html: Removed.
642         * TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Removed.
643         * TestWebKitAPI/Tests/WebKit2/link-with-title.html: Removed.
644         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Removed.
645         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Removed.
646         * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Removed.
647         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Removed.
648         * TestWebKitAPI/Tests/WebKit2/mac: Removed.
649         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Removed.
650         * TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Removed.
651         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Removed.
652         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Removed.
653         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Removed.
654         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Removed.
655         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Removed.
656         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Removed.
657         * TestWebKitAPI/Tests/WebKit2/mac/RestoreStateAfterTermination.mm: Removed.
658         * TestWebKitAPI/Tests/WebKit2/many-iframes.html: Removed.
659         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Removed.
660         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Removed.
661         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Removed.
662         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Removed.
663         * TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Removed.
664         * TestWebKitAPI/Tests/WebKit2/no-autoplay-with-controls.html: Removed.
665         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Removed.
666         * TestWebKitAPI/Tests/WebKit2/push-state.html: Removed.
667         * TestWebKitAPI/Tests/WebKit2/set-long-title.html: Removed.
668         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Removed.
669         * TestWebKitAPI/Tests/WebKit2/simple-accelerated-compositing.html: Removed.
670         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Removed.
671         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Removed.
672         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Removed.
673         * TestWebKitAPI/Tests/WebKit2/simple.html: Removed.
674         * TestWebKitAPI/Tests/WebKit2/simple2.html: Removed.
675         * TestWebKitAPI/Tests/WebKit2/simple3.html: Removed.
676         * TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Removed.
677         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Removed.
678         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Removed.
679         * TestWebKitAPI/Tests/WebKit2/test.mp4: Removed.
680         * TestWebKitAPI/Tests/WebKit2/test.pdf: Removed.
681         * TestWebKitAPI/Tests/WebKit2/webfont.html: Removed.
682
683 2017-08-25  Alex Christensen  <achristensen@webkit.org>
684
685         Rename TestWebKitAPI/Tests/WebKit to WebKitLegacy following Source directory rename.
686
687         Rubber-stamped by Brady Eidson.
688
689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
690         * TestWebKitAPI/Tests/WebKit: Removed.
691         * TestWebKitAPI/Tests/WebKit/ios: Removed.
692         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm: Removed.
693         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Removed.
694         * TestWebKitAPI/Tests/WebKit/ios/audio-only.html: Removed.
695         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: Removed.
696         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.mp4: Removed.
697         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Removed.
698         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Removed.
699         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: Removed.
700         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.mp4: Removed.
701         * TestWebKitAPI/Tests/WebKit/win: Removed.
702         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Removed.
703         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed.
704         * TestWebKitAPI/Tests/WebKitLegacy: Copied from TestWebKitAPI/Tests/WebKit.
705
706 2017-08-25  Alex Christensen  <achristensen@webkit.org>
707
708         Add WKUIDelegatePrivate equivalent of WKPageUIClient's saveDataToFileInDownloadsFolder
709         https://bugs.webkit.org/show_bug.cgi?id=176000
710         <rdar://problem/29270035>
711
712         Reviewed by Andy Estes.
713
714         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
715         (-[FocusDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
716         (TEST):
717         (-[SaveDataToFileDelegate _webView:saveDataToFile:suggestedFilename:mimeType:originatingURL:]):
718         (-[SaveDataToFileDelegate webView:didFinishNavigation:]):
719
720 2017-08-25  Youenn Fablet  <youenn@apple.com>
721
722         WPT server should not need to copy test harness files
723         https://bugs.webkit.org/show_bug.cgi?id=175938
724
725         Reviewed by Alexey Proskuryakov.
726
727         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
728         (WebPlatformTestServer.__init__): Stopping explicit resource files copy when launching the WPT server.
729         Use aliases instead.
730
731 2017-08-25  Eric Carlson  <eric.carlson@apple.com>
732
733         Add String::format variant that takes va_args
734         https://bugs.webkit.org/show_bug.cgi?id=175988
735
736         Reviewed by Jer Noble.
737
738         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
739         (TestWebKitAPI::testWithFormatAndArguments):
740         (TestWebKitAPI::TEST):
741
742 2017-08-25  Jonathan Bedard  <jbedard@apple.com>
743
744         Follow-up Internal build fix for r221187
745         https://bugs.webkit.org/show_bug.cgi?id=175960
746         <rdar://problem/34069264>
747
748         Unreviewed build fix.
749
750         * TestWebKitAPI/ios/DataInteractionSimulator.h: Move UIItemProvider declaration
751         into #if block.
752
753 2017-08-25  Don Olmstead  <don.olmstead@sony.com>
754
755         [WinCairo] Use GitHub releases for WinCairoRequirements
756         https://bugs.webkit.org/show_bug.cgi?id=175972
757
758         Reviewed by Brent Fulgham.
759
760         * Scripts/build-webkit:
761         (cMakeArgsFromFeatures): Deleted.
762         (writeCongrats): Deleted.
763         * Scripts/download-latest-github-release.py:
764         (Status):
765         (parse_args):
766         (main):
767         * Scripts/update-webkit-wincairo-libs.py: Renamed from Tools/Scripts/update-webkit-wincairo-libs.
768
769 2017-08-25  Jonathan Bedard  <jbedard@apple.com>
770
771         Fix build breakage with Public iOS 11 SDK
772         https://bugs.webkit.org/show_bug.cgi?id=175960
773         <rdar://problem/34069264>
774
775         Reviewed by Wenson Hsieh.
776
777         * TestWebKitAPI/ios/DataInteractionSimulator.h: Add UIItemProvider declaration.
778
779 2017-08-24  Chris Dumez  <cdumez@apple.com>
780
781         [Directory Upload] Add basic support for input.webkitdirectory
782         https://bugs.webkit.org/show_bug.cgi?id=175950
783         <rdar://problem/33951915>
784
785         Reviewed by Geoffrey Garen.
786
787         * DumpRenderTree/mac/DumpRenderTree.mm:
788         (resetWebPreferencesToConsistentValues):
789         * WebKitTestRunner/TestController.cpp:
790         (WTR::TestController::resetPreferencesToConsistentValues):
791         Enable Directory Upload feature for testing, given that it is currently disabled by default.
792
793         (WTR::runOpenPanel):
794         Print additional text when directories are allowed to extend testing coverage.
795
796 2017-08-24  Alex Christensen  <achristensen@webkit.org>
797
798         Add WKUIDelegatePrivate equivalent of WKPageUIClient's handleAutoplayEvent
799         https://bugs.webkit.org/show_bug.cgi?id=175965
800         <rdar://problem/29270035>
801
802         Reviewed by Tim Horton.
803
804         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
805         (TEST):
806         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
807         (-[AutoplayPoliciesDelegate _webView:handleAutoplayEvent:withFlags:]):
808         (TEST):
809         (handleAutoplayEvent): Deleted.
810
811 2017-08-24  Alex Christensen  <achristensen@webkit.org>
812
813         didNotHandleWheelEvent test times out
814         https://bugs.webkit.org/show_bug.cgi?id=175967
815
816         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
817         Skip the test until WebCore's wheel event handling is reliable enough to test.
818
819 2017-08-24  Jonathan Bedard  <jbedard@apple.com>
820
821         Update configure-xcode-for-ios-development for iOS 11
822         https://bugs.webkit.org/show_bug.cgi?id=173937
823         <rdar://problem/33038924>
824
825         Reviewed by Daniel Bates.
826
827         Xcode 9 has removed the following headers from the iOS 11 Simulator SDK:
828                 /usr/include/crt_externs.h
829                 /usr/include/mach/mach_types.defs
830                 /usr/include/mach/machine/machine_types.defs
831                 /usr/include/mach/std_types.defs
832                 /usr/include/objc/objc-class.h
833                 /usr/include/objc/objc-runtime.h
834                 /usr/include/objc/Protocol.h
835                 /usr/include/readline/history.h
836                 /usr/include/readline/readline.h
837         To solve this problem, configure-xcode-for-ios-development copies these headers
838         from the active macOS SDK into the iOS Simulator SDK.
839
840         * Scripts/configure-xcode-for-ios-development:
841         (copyMissingHeadersFromSDKToSDKIfNeeded): Copy all missing header from one SDK
842         into another if those headers do not exist in the destination SDK.
843         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Deleted.
844
845 2017-08-24  Alex Christensen  <achristensen@webkit.org>
846
847         Add WKUIDelegatePrivate callback corresponding to PageUIClient's didNotHandleWheelEvent
848         https://bugs.webkit.org/show_bug.cgi?id=175957
849         <rdar://problem/29270035>
850
851         Reviewed by Geoffrey Garen.
852
853         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
854         (synthesizeWheelEvents):
855         (-[WheelDelegate _webView:didNotHandleWheelEvent:]):
856         (-[WheelDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
857         (TEST):
858
859 2017-08-24  Tim Horton  <timothy_horton@apple.com>
860
861         Layout size override changes during in-flight animated resize are dropped on the floor forever
862         https://bugs.webkit.org/show_bug.cgi?id=175916
863         <rdar://problem/33887295>
864
865         Reviewed by Beth Dakin.
866
867         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
868         (TEST):
869         Add a test ensuring that override layout size changes
870         during an animated resize actually take effect.
871
872 2017-08-23  Matt Lewis  <jlewis3@apple.com>
873
874         Disabled VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling.
875         https://bugs.webkit.org/show_bug.cgi?id=175909
876
877         Unreviewed test gardening.
878
879         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
880         (TestWebKitAPI::TEST):
881
882 2017-08-24  Don Olmstead  <don.olmstead@sony.com>
883
884         [CMake] Use find_package for SQLite
885         https://bugs.webkit.org/show_bug.cgi?id=175803
886
887         Reviewed by Konstantin Tokarev.
888
889         * TestWebKitAPI/PlatformWin.cmake:
890
891 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
892
893         Leaking CARenderServerBuffer in PlatformWebView::windowSnapshotImage()
894         https://bugs.webkit.org/show_bug.cgi?id=175905
895
896         Reviewed by Tim Horton.
897
898         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
899         (WTR::PlatformWebView::windowSnapshotImage): Pass CARenderServerBuffer to CGDataProviderCreateWithData
900         so that the buffer can be destroyed.
901
902 2017-08-23  Alex Christensen  <achristensen@webkit.org>
903
904         Add WKUIDelegatePrivate callbacks corresponding to WKPageUIClient's takeFocus, focus, and unfocus
905         https://bugs.webkit.org/show_bug.cgi?id=175896
906
907         Reviewed by Tim Horton.
908
909         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
910         (-[UITestDelegate _showWebView:]):
911         (TEST):
912         (tabEvent):
913         (synthesizeTab):
914         (-[FocusDelegate _webView:takeFocus:]):
915         (-[FocusDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
916         (-[UITestDelegate _webViewShow:]): Deleted.
917
918 2017-08-23  Eric Carlson  <eric.carlson@apple.com>
919
920         Platform code should be able to safely log in release builds
921         https://bugs.webkit.org/show_bug.cgi?id=175854
922         <rdar://problem/34022930>
923
924         Reviewed by Jer Noble.
925
926         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
927         (TestWebKitAPI::TEST_F):
928
929 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
930
931         Access expectations path through apple_additions
932         https://bugs.webkit.org/show_bug.cgi?id=174800
933         <rdar://problem/33498899>
934
935         Unreviewed follow-up fix for r221087.
936
937         * Scripts/webkitpy/port/ios.py:
938         (IOSPort._apple_additions_path): Use iOS mapping instead of Mac mapping.
939
940 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
941
942         Access expectations path through apple_additions
943         https://bugs.webkit.org/show_bug.cgi?id=174800
944         <rdar://problem/33498899>
945
946         Reviewed by David Kilzer.
947
948         Follow-up fix. Mapping of operating system names was done incorrectly.
949
950         * Scripts/webkitpy/port/ios.py:
951         (IOSPort._apple_additions_path): Correctly find the operating system to be replaced.
952         * Scripts/webkitpy/port/ios_device_unittest.py:
953         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Add test for operating
954         system name replacement.
955         * Scripts/webkitpy/port/ios_simulator_unittest.py:
956         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Add test for operating
957         system name replacement.
958         * Scripts/webkitpy/port/mac.py: Correctly find the operating system to be replaced.
959         (MacPort._apple_additions_path):
960         * Scripts/webkitpy/port/mac_unittest.py:
961         (MacTest.test_layout_test_searchpath_with_apple_additions): Add test for operating system
962         name replacement.
963         * Scripts/webkitpy/port/port_testcase.py:
964         (bind_mock_apple_additions.MockAppleAdditions.ios_os_name): Change the passed name so that
965         operating system name replacement can be tested.
966         (bind_mock_apple_additions.MockAppleAdditions.mac_os_name): Ditto.
967
968 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
969
970         Access expectations path through apple_additions
971         https://bugs.webkit.org/show_bug.cgi?id=174800
972         <rdar://problem/33498899>
973
974         Reviewed by Alexey Proskuryakov.
975
976         When external test expectations are imported through additional-platform-directory, they will
977         over-write any WebKit expectations. Access some expectations from apple_additions to correct
978         these precedence issues.
979
980         * Scripts/webkitpy/port/ios.py:
981         (IOSPort._apple_additions_path): Convert test expectation directory to a path
982         coming from apple_additions.
983         (IOSPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
984         path for layout test expectations.
985         * Scripts/webkitpy/port/ios_device_unittest.py:
986         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
987         * Scripts/webkitpy/port/ios_simulator_unittest.py:
988         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
989         * Scripts/webkitpy/port/mac.py:
990         (MacPort._apple_additions_path): Convert test expectation directory to a path
991         coming from apple_additions.
992         (MacPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
993         path for layout test expectations.
994         * Scripts/webkitpy/port/mac_unittest.py:
995         (MacTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
996         * Scripts/webkitpy/port/port_testcase.py:
997         (bind_mock_apple_additions): Added to create mock apple_additions for a block.
998         (bind_mock_apple_additions.MockAppleAdditions): Contains apple_addition stubs for testing.
999         * Scripts/webkitpy/port/win.py:
1000         (WinPort.default_baseline_search_path): Include apple_additions test expectation for Windows.
1001
1002 2017-08-22  Zan Dobersek  <zdobersek@igalia.com>
1003
1004         Unreviewed. The WPE port should build TestWebKitAPI with the same
1005         compiler flags as the GTK+ port, disabling a few flags that are
1006         sprouting a lot of warning output.
1007
1008         * TestWebKitAPI/PlatformWPE.cmake:
1009
1010 2017-08-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1011
1012         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
1013         https://bugs.webkit.org/show_bug.cgi?id=175116
1014         <rdar://problem/28279301>
1015
1016         Reviewed by Darin Adler and Ryosuke Niwa.
1017
1018         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
1019         EditorStateTests run on both iOS and Mac.
1020
1021         * TestWebKitAPI/EditingTestHarness.h: Added.
1022         * TestWebKitAPI/EditingTestHarness.mm: Added.
1023
1024         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
1025         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
1026         the state of the latest observed EditorState.
1027
1028         (-[EditingTestHarness initWithWebView:]):
1029         (-[EditingTestHarness dealloc]):
1030         (-[EditingTestHarness webView]):
1031         (-[EditingTestHarness latestEditorState]):
1032         (-[EditingTestHarness editorStateHistory]):
1033         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
1034         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
1035         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
1036         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
1037         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
1038         (-[EditingTestHarness toggleBold]):
1039         (-[EditingTestHarness toggleItalic]):
1040         (-[EditingTestHarness toggleUnderline]):
1041         (-[EditingTestHarness setForegroundColor:]):
1042         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
1043         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
1044         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
1045         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
1046         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
1047         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
1048         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
1049
1050         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
1051         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
1052         keys and values.
1053
1054         (-[EditingTestHarness latestEditorStateContains:]):
1055         (-[EditingTestHarness _webView:editorStateDidChange:]):
1056         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1057         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
1058         (TestWebKitAPI::setUpEditorStateTestHarness):
1059         (TestWebKitAPI::TEST):
1060         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
1061
1062 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1063
1064         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
1065         https://bugs.webkit.org/show_bug.cgi?id=175370
1066         <rdar://problem/33799806>
1067
1068         Reviewed by Ryosuke Niwa.
1069
1070         Tweaks API tests that involve editing to wait for a presentation update before checking against UI process-side
1071         information sent via EditorState updates. This allows any EditorState update scheduled by the test to propagate
1072         to the UI process.
1073
1074         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1075         (-[CandidateTestWebView typeString:inputMessage:]):
1076         (+[CandidateTestWebView setUpWithFrame:testPage:]):
1077         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
1078         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
1079         (TestWebKitAPI::AcceptsFirstMouse::runTest):
1080         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
1081         * TestWebKitAPI/cocoa/TestWKWebView.h:
1082         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1083         (-[TestWKWebView waitForNextPresentationUpdate]):
1084
1085         Add a new helper method to spin until the next presentation update.
1086
1087         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
1088         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1089         (TestWebKitAPI::WebKitAgnosticTest::waitForNextPresentationUpdate):
1090
1091 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1092
1093         Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
1094         https://bugs.webkit.org/show_bug.cgi?id=175797
1095         <rdar://problem/29270035>
1096
1097         Reviewed by Geoffrey Garen.
1098
1099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1100         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.
1101         (-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1102         (-[UITestDelegate _showPage:]):
1103         (-[UITestDelegate webView:startURLSchemeTask:]):
1104         (-[UITestDelegate webView:stopURLSchemeTask:]):
1105         (TEST):
1106
1107 2017-08-22  Devin Rousso  <webkit@devinrousso.com>
1108
1109         Unreviewed, change my IRC nick.
1110
1111         * Scripts/webkitpy/common/config/contributors.json:
1112
1113 2017-08-22  Matt Lewis  <jlewis3@apple.com>
1114
1115         Unreviewed, rolling out r221026.
1116
1117         This caused a consistent API failure on iOS Simulator.
1118
1119         Reverted changeset:
1120
1121         "Add UIDelegatePrivate SPI corresponding to
1122         WKPageUIClient.showPage"
1123         https://bugs.webkit.org/show_bug.cgi?id=175797
1124         http://trac.webkit.org/changeset/221026
1125
1126 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1127
1128         Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
1129         https://bugs.webkit.org/show_bug.cgi?id=175797
1130         <rdar://problem/29270035>
1131
1132         Reviewed by Geoffrey Garen.
1133
1134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1135         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.
1136         (-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1137         (-[UITestDelegate _showPage:]):
1138         (-[UITestDelegate webView:startURLSchemeTask:]):
1139         (-[UITestDelegate webView:stopURLSchemeTask:]):
1140         (TEST):
1141
1142 2017-08-22  Jonathan Bedard  <jbedard@apple.com>
1143
1144         Fix leak-checking for iOS Simulators
1145         https://bugs.webkit.org/show_bug.cgi?id=175735
1146
1147         Reviewed by David Kilzer.
1148
1149         Follow-up fix to r220942. _proc may be undefined.
1150
1151         * Scripts/webkitpy/port/server_process.py:
1152         (ServerProcess._wait_for_stop): Handle case where _proc is undefined.
1153
1154 2017-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1155
1156         [GTK][WPE] install-dependencies should install the required gstreamer packages needed for production builds.
1157         https://bugs.webkit.org/show_bug.cgi?id=175822
1158
1159         Reviewed by Xabier Rodriguez-Calvar.
1160
1161         * gtk/install-dependencies: Add the bad plugins to the list.
1162         * wpe/install-dependencies: Add all the gst related packages (copied from GTK listing).
1163
1164 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
1165
1166         DataInteractionTests.ExternalSourceAttributedStringToContentEditable hits a debug assertion
1167         https://bugs.webkit.org/show_bug.cgi?id=175787
1168         <rdar://problem/33996612>
1169
1170         Reviewed by Wenson Hsieh.
1171
1172         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1173         (TestWebKitAPI::TEST):
1174
1175 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
1176
1177         Typo in "webkit-patch land"
1178         https://bugs.webkit.org/show_bug.cgi?id=175788
1179
1180         Reviewed by Tim Horton.
1181
1182         * Scripts/webkitpy/tool/steps/commit.py:
1183         (Commit._commit_warning):
1184
1185 2017-08-20  Sam Weinig  <sam@webkit.org>
1186
1187         StringView could use a function to strip leading/trailing characters without allocation
1188         https://bugs.webkit.org/show_bug.cgi?id=175757
1189
1190         Reviewed by Darin Adler.
1191
1192         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1193         Add tests for StringView::stripLeadingAndTrailingMatchedCharacters().
1194
1195 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1196
1197         [PAL] Move spi/mac directory into PAL
1198         https://bugs.webkit.org/show_bug.cgi?id=175649
1199
1200         Reviewed by Myles C. Maxfield.
1201
1202         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1203
1204 2017-08-21  Per Arne Vollan  <pvollan@apple.com>
1205
1206         [Win] DRT should only allow any https certificate for localhost.
1207         https://bugs.webkit.org/show_bug.cgi?id=175147
1208
1209         Reviewed by Brent Fulgham.
1210
1211         Add check to make sure only localhost requests allow any https certificate.
1212
1213         * DumpRenderTree/win/DumpRenderTree.cpp:
1214         (runTest):
1215
1216 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
1217
1218         Add WTFLogChannel level to allow runtime log filtering
1219         https://bugs.webkit.org/show_bug.cgi?id=175731
1220         <rdar://problem/33967234>
1221
1222         Unreviewed build fix.
1223
1224         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1225         (TestWebKitAPI::LoggingTest::output): Disable testing output by default because it 
1226         fails on some of the bots.
1227
1228 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
1229
1230         Add WTFLogChannel level to allow runtime log filtering
1231         https://bugs.webkit.org/show_bug.cgi?id=175731
1232         <rdar://problem/33967234>
1233
1234         Reviewed by Jer Noble.
1235
1236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1237         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
1238         (TestWebKitAPI::LoggingTest::output):
1239         (TestWebKitAPI::TEST_F):
1240
1241 2017-08-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1242
1243         [iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
1244         https://bugs.webkit.org/show_bug.cgi?id=175509
1245         <rdar://problem/33728169>
1246
1247         Reviewed by Ryosuke Niwa.
1248
1249         Removes ExternalSourceAttributedStringToContentEditable and adds
1250         ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
1251         text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
1252         original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
1253         debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
1254         that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
1255         other style attribute, such as color, carries over from the NSAttributedString to the DOM.
1256
1257         Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.
1258
1259         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1260         (TestWebKitAPI::TEST):
1261
1262 2017-08-18  Ryan Haddad  <ryanhaddad@apple.com>
1263
1264         Unreviewed, rolling out r220938.
1265
1266         The API tests added with this change are failing.
1267
1268         Reverted changeset:
1269
1270         "Add WTFLogChannel level to allow runtime log filtering"
1271         https://bugs.webkit.org/show_bug.cgi?id=175731
1272         http://trac.webkit.org/changeset/220938
1273
1274 2017-08-18  Devin Rousso  <webkit@devinrousso.com>
1275
1276         Unreviewed, change my email.
1277
1278         * Scripts/webkitpy/common/config/contributors.json:
1279
1280 2017-08-18  Jonathan Bedard  <jbedard@apple.com>
1281
1282         Fix leak-checking for iOS Simulators
1283         https://bugs.webkit.org/show_bug.cgi?id=175735
1284
1285         Reviewed by Darin Adler.
1286
1287         If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
1288         Simulator (or device) because the process will have already been killed by the time we
1289         check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.
1290
1291         * Scripts/webkitpy/port/server_process.py:
1292         (ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
1293         (ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
1294         and SimulatorProcess.
1295         * Scripts/webkitpy/port/simulator_process.py:
1296         (SimulatorProcess.stop): Before closing the process, check for leaks.
1297
1298 2017-08-18  Eric Carlson  <eric.carlson@apple.com>
1299
1300         Add WTFLogChannel level to allow runtime log filtering
1301         https://bugs.webkit.org/show_bug.cgi?id=175731
1302         <rdar://problem/33967234>
1303
1304         Reviewed by Jer Noble.
1305
1306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1307         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
1308         (TestWebKitAPI::LoggingTest::output):
1309         (TestWebKitAPI::TEST_F):
1310
1311 2017-08-18  Alexey Proskuryakov  <ap@apple.com>
1312
1313         Add Dean Johnson to contributors.json for Bugzilla autocomplete.
1314
1315         * Scripts/webkitpy/common/config/contributors.json:
1316
1317 2017-08-18  Ross Kirsling  <ross.kirsling@sony.com>
1318
1319         [Tools] Add script to download a GitHub release
1320         https://bugs.webkit.org/show_bug.cgi?id=175279
1321
1322         Reviewed by Brent Fulgham.
1323
1324         * Scripts/download-latest-github-release.py: Added.
1325
1326 2017-08-18  Commit Queue  <commit-queue@webkit.org>
1327
1328         Unreviewed, rolling out r220854.
1329         https://bugs.webkit.org/show_bug.cgi?id=175716
1330
1331         I'm not sure we really need this (Requested by KaL on
1332         #webkit).
1333
1334         Reverted changeset:
1335
1336         "[GTK][WPE] Add NTLM authentication enabled API"
1337         https://bugs.webkit.org/show_bug.cgi?id=122952
1338         http://trac.webkit.org/changeset/220854
1339
1340 2017-08-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1341
1342         [GTK] Make TestContextMenu work on Fedora
1343         https://bugs.webkit.org/show_bug.cgi?id=175708
1344
1345         Reviewed by Carlos Garcia Campos.
1346
1347         TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
1348         and my student last summer who was trying to work on a context menu API. It's trying to load
1349         an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
1350         entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
1351         don't care to investigate. Let's switch it to WebM so I can move on.
1352
1353         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1354         (prepareContextMenuTestView):
1355         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
1356         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
1357
1358 2017-08-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1359
1360         check-webkit-style shouldn't check spacing in #elif preprocessor lines
1361         https://bugs.webkit.org/show_bug.cgi?id=175652
1362
1363         Reviewed by Alex Christensen.
1364
1365         * Scripts/webkitpy/style/checkers/cpp.py:
1366         (check_spacing):
1367         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1368         (CppStyleTest.test_spacing_for_binary_ops):
1369
1370 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1371
1372         Fix the build on other platforms after r220865
1373         https://bugs.webkit.org/show_bug.cgi?id=175683
1374
1375         Reviewed by Tim Horton.
1376
1377         Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
1378         availability is determined by SDK version rather than deployment version.
1379
1380         * TestWebKitAPI/ios/UIKitSPI.h:
1381
1382 2017-08-17  Andreas Kling  <akling@apple.com>
1383
1384         Disable CSS regions at compile time
1385         https://bugs.webkit.org/show_bug.cgi?id=175630
1386
1387         Reviewed by Antti Koivisto.
1388
1389         * Scripts/webkitperl/FeatureList.pm:
1390         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1391
1392 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1393
1394         Unreviewed, try to fix the internal iOS 10 build after r220865.
1395
1396         * TestWebKitAPI/ios/UIKitSPI.h:
1397
1398         On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
1399         extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
1400         this compiler guard.
1401
1402 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1403
1404         [iOS] Respect type fidelities when copying image elements to the pasteboard
1405         https://bugs.webkit.org/show_bug.cgi?id=175638
1406         <rdar://problem/26556043>
1407
1408         Reviewed by Ryosuke Niwa.
1409
1410         Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
1411         contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
1412         used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.
1413
1414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1415         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1416         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
1417         (TestWebKitAPI::TEST):
1418         (TestWebKitAPI::presentActionSheetAndChooseAction):
1419         (-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
1420         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1421         (checkEstimatedSize):
1422         (checkSuggestedNameAndEstimatedSize):
1423
1424         Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.
1425
1426         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1427         (TestWebKitAPI::TEST):
1428         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1429         * TestWebKitAPI/ios/UIKitSPI.h: Added.
1430
1431 2017-08-17  Jonathan Bedard  <jbedard@apple.com>
1432
1433         Recursively create resource load statistics folder for testing
1434         https://bugs.webkit.org/show_bug.cgi?id=175676
1435
1436         Reviewed by Brady Eidson.
1437
1438         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1439         (WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.
1440
1441 2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1442
1443         [GTK][WPE] Add NTLM authentication enabled API
1444         https://bugs.webkit.org/show_bug.cgi?id=122952
1445
1446         Reviewed by Michael Catanzaro.
1447
1448         Add a test case to check we can enable/disable NTLM.
1449
1450         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1451         (testWebViewAuthenticationNTLM):
1452         (beforeAll):
1453
1454 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1455
1456         [PAL] Move spi/ios and spi/win directories into PAL
1457         https://bugs.webkit.org/show_bug.cgi?id=175171
1458
1459         Reviewed by Antti Koivisto.
1460
1461         * DumpRenderTree/mac/EventSendingController.mm:
1462
1463 2017-08-16  Andy Estes  <aestes@apple.com>
1464
1465         [Payment Request] Add an ENABLE flag and an experimental feature preference
1466         https://bugs.webkit.org/show_bug.cgi?id=175622
1467
1468         Reviewed by Tim Horton.
1469
1470         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1471         * WebKitTestRunner/TestController.cpp:
1472         (WTR::TestController::resetPreferencesToConsistentValues):
1473
1474 2017-08-15  Aakash Jain  <aakash_jain@apple.com>
1475
1476         undefined URL in PopoverTracker for failed step
1477         https://bugs.webkit.org/show_bug.cgi?id=175593
1478         <rdar://problem/33898769>
1479
1480         Reviewed by Daniel Bates.
1481
1482         This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
1483         does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.
1484
1485         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1486         (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
1487         (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
1488         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1489         (BuildbotTestResults): Accept URL in constructor.
1490
1491 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1492
1493         Remove Proximity Events and related code
1494         https://bugs.webkit.org/show_bug.cgi?id=175545
1495
1496         Reviewed by Daniel Bates.
1497
1498         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
1499         and other related code.
1500
1501         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1502
1503 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1504
1505         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
1506         https://bugs.webkit.org/show_bug.cgi?id=175504
1507
1508         Reviewed by Sam Weinig.
1509
1510         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1511
1512 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1513
1514         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
1515         https://bugs.webkit.org/show_bug.cgi?id=175557
1516
1517         Reviewed by Jon Lee.
1518         
1519         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
1520
1521         * DumpRenderTree/TestRunner.cpp:
1522         (TestRunner::staticFunctions):
1523         (setViewModeMediaFeatureCallback): Deleted.
1524         * DumpRenderTree/TestRunner.h:
1525         * DumpRenderTree/mac/TestRunnerMac.mm:
1526         (TestRunner::setViewModeMediaFeature): Deleted.
1527         * DumpRenderTree/win/TestRunnerWin.cpp:
1528         (TestRunner::setViewModeMediaFeature): Deleted.
1529         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1530
1531 2017-08-14  Andy Estes  <aestes@apple.com>
1532
1533         REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
1534         https://bugs.webkit.org/show_bug.cgi?id=175548
1535         <rdar://problem/33866206>
1536
1537         Reviewed by Brady Eidson.
1538
1539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1540         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.
1541         (TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().
1542
1543 2017-08-14  Youenn Fablet  <youenn@apple.com>
1544
1545         WPT server should be able to do logging even if its output folder is not created at launch time
1546         https://bugs.webkit.org/show_bug.cgi?id=175543
1547
1548         Reviewed by Alexey Proskuryakov.
1549
1550         Removing no longer used stdout/stderr member variables.
1551         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
1552
1553         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1554         (WebPlatformTestServer.__init__):
1555         (WebPlatformTestServer._prepare_config):
1556         (WebPlatformTestServer._spawn_process):
1557         (WebPlatformTestServer._stop_running_server):
1558
1559 2017-08-14  Daniel Bates  <dabates@apple.com>
1560
1561         webkit-patch: Passing --no-review should submit patch to EWS by default
1562         https://bugs.webkit.org/show_bug.cgi?id=148899
1563
1564         Reviewed by David Kilzer.
1565
1566         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
1567         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
1568         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
1569
1570         Frequently I want to post a draft of a patch without review to have the EWS bots process
1571         it to catch build and test breakage before I clean it up and post it for formal review.
1572         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
1573         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
1574         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
1575
1576         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1577         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
1578         parse the attachment id from the response page after adding an attachment to the bug.
1579         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
1580         HTTP response after uploading the patch.
1581         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1582         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
1583         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1584         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
1585         * Scripts/webkitpy/tool/commands/upload.py:
1586         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
1587         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
1588         this command.
1589         (PostCommits.execute): Submit the patch to EWS, if applicable.
1590         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1591         (test_upload): Set options.ews to False as the upload command expects this option
1592         to be specified.
1593         (test_upload_with_no_review_and_ews): Added.
1594         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
1595         * Scripts/webkitpy/tool/steps/options.py:
1596         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
1597         * Scripts/webkitpy/tool/steps/postdiff.py:
1598         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
1599         this command.
1600         (PostDiff.run): Submit the patch to EWS, if applicable.
1601         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
1602         (SubmitToEWS):
1603         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
1604         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
1605
1606 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
1607
1608         Disable two flaky VideoControlsManager API tests.
1609
1610         Unreviewed test gardening.
1611
1612         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1613         (TestWebKitAPI::TEST):
1614
1615 2017-08-14  Tim Horton  <timothy_horton@apple.com>
1616
1617         Only create directory and sandbox extension handle for storage directories if they are set
1618         https://bugs.webkit.org/show_bug.cgi?id=175522
1619
1620         Reviewed by Brady Eidson.
1621
1622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1623         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
1624         (TEST):
1625         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
1626         doesn't log anything to stderr.
1627
1628 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
1629
1630         sub-categorize Sandbox violation logs
1631         https://bugs.webkit.org/show_bug.cgi?id=175536
1632         <rdar://problem/33834416>
1633
1634         Reviewed by David Kilzer.
1635
1636         * Scripts/webkitpy/common/system/crashlogs.py:
1637         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
1638         a Sandbox violation.
1639         (CrashLogs._find_all_logs_darwin): Update comment.
1640         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1641         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
1642         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
1643         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
1644         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
1645         * Scripts/webkitpy/port/darwin.py:
1646         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
1647
1648 2017-08-14  Daniel Bates  <dabates@apple.com>
1649
1650         Add Automator service to copy permalink to Clipboard
1651         https://bugs.webkit.org/show_bug.cgi?id=170978
1652
1653         Reviewed by Joseph Pecoraro.
1654
1655         It is helpful to reference using a hyperlink a particular line of code when having
1656         a discussion on IRC or in a bug. You can get such a link by navigating to the file
1657         in the Trac Browse Source viewer and selecting the line your are interested in.
1658         I found myself doing this often enough that I wrote an Automator service to do it
1659         for me.
1660
1661         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
1662
1663         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
1664         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
1665         * CopyPermalink/README: Added.
1666
1667 2017-08-14  Chris Dumez  <cdumez@apple.com>
1668
1669         Address flakiness related to download tests
1670         https://bugs.webkit.org/show_bug.cgi?id=175338
1671         <rdar://problem/33865119>
1672
1673         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
1674         between tests.
1675
1676         * WebKitTestRunner/TestController.cpp:
1677         (WTR::TestController::resetStateToConsistentValues):
1678
1679 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
1680
1681         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
1682         https://bugs.webkit.org/show_bug.cgi?id=175474
1683         <rdar://problem/33844628>
1684
1685         Reviewed by Wenson Hsieh.
1686
1687         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
1688
1689         * DumpRenderTree/mac/DumpRenderTree.mm:
1690         (resetWebPreferencesToConsistentValues):
1691         * WebKitTestRunner/TestController.cpp:
1692         (WTR::TestController::resetPreferencesToConsistentValues):
1693
1694 2017-08-12  Chris Dumez  <cdumez@apple.com>
1695
1696         Address flakiness related to download tests
1697         https://bugs.webkit.org/show_bug.cgi?id=175338
1698
1699         Reviewed by Ryosuke Niwa.
1700
1701         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
1702           is actually queried when a download completes. Previously, this would be
1703           identical to a call to testRunner.waitUntilDone() because any download
1704           completion would call testRunner.notifyDone().
1705         - Disable logging of download callbacks by default and add a
1706           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
1707           enable such logging.
1708
1709         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1710         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1711         (WTR::InjectedBundle::didReceiveMessageToPage):
1712         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1713         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1714         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1715         * WebKitTestRunner/TestController.cpp:
1716         (WTR::TestController::downloadDidStart):
1717         (WTR::TestController::decideDestinationWithSuggestedFilename):
1718         (WTR::TestController::downloadDidFinish):
1719         (WTR::TestController::downloadDidFail):
1720         (WTR::TestController::downloadDidCancel):
1721         * WebKitTestRunner/TestController.h:
1722         (WTR::TestController::setShouldLogDownloadCallbacks):
1723         * WebKitTestRunner/TestInvocation.cpp:
1724         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1725
1726 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
1727
1728         Create mock ITP data in testing to prevent grandfathering
1729         https://bugs.webkit.org/show_bug.cgi?id=174720
1730
1731         Unreviewed follow-up fix for r220604.
1732
1733         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1734         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
1735
1736 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
1737
1738         Create mock ITP data in testing to prevent grandfathering
1739         https://bugs.webkit.org/show_bug.cgi?id=174720
1740         <rdar://problem/33457779>
1741
1742         Reviewed by Brent Fulgham.
1743
1744         We don't need to be triggering grandfathering when each test runner starts. On Mac,
1745         this may launch plugins which can cause layout tests to fail later if the test
1746         runner does not shut-down before the plugins unload.
1747
1748         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
1749         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1750         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
1751         prevent grandfathering from being triggered.
1752         * WebKitTestRunner/ios/TestControllerIOS.mm:
1753         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
1754         * WebKitTestRunner/mac/TestControllerMac.mm:
1755         (WTR::TestController::platformInitialize): Ditto.
1756
1757 2017-08-11  Sam Weinig  <sam@webkit.org>
1758
1759         WTF::Function does not allow for reference / non-default constructible return types
1760         https://bugs.webkit.org/show_bug.cgi?id=175244
1761         <rdar://problem/33801582>
1762
1763         Reviewed by Chris Dumez.
1764
1765         * TestWebKitAPI/Tests/WTF/Function.cpp:
1766         (TestWebKitAPI::TEST):
1767
1768 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1769
1770         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
1771         https://bugs.webkit.org/show_bug.cgi?id=175378
1772
1773         Reviewed by Sergio Villar Senin.
1774
1775         Add two test cases to check proxy authentication.
1776
1777         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1778         (Tunnel::Tunnel):
1779         (Tunnel::~Tunnel):
1780         (Tunnel::connect):
1781         (Tunnel::connected):
1782         (serverCallback):
1783         (ProxyAuthenticationTest::ProxyAuthenticationTest):
1784         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
1785         (ProxyAuthenticationTest::proxyServerPortAsString):
1786         (testWebViewAuthenticationProxy):
1787         (testWebViewAuthenticationProxyHTTPS):
1788         (beforeAll):
1789
1790 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1791
1792         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
1793         https://bugs.webkit.org/show_bug.cgi?id=175428
1794
1795         Both ports share the GStreamer code as multimedia backend and till
1796         not so long they were using different versions. Now they do use
1797         the same versions and it does not make any sense anymore (and
1798         neither had sense before) to have differences in the modulesets.
1799
1800         In this patch I created a GStreamer moduleset and referenced it
1801         from both GTK+'s and WPE's. GStreamer patches were also moved there.
1802
1803         Reviewed by Žan Doberšek.
1804
1805         * gstreamer/jhbuild.modules: Added.
1806         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
1807         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
1808         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
1809         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
1810         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
1811         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
1812         * gtk/jhbuild.modules:
1813         * wpe/jhbuild.modules:
1814         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
1815         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
1816         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1817         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1818         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
1819
1820 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
1821
1822         Unreviewed, adding Ross Kirsling to contributors.json
1823
1824         * Scripts/webkitpy/common/config/contributors.json:
1825
1826 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
1827
1828         Unreviewed, attempt to fix build failure with VC2017
1829
1830         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1831         (TEST):
1832
1833 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
1834
1835         Unreviewed, suppress warnings on GCC
1836
1837         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1838         (TestWebKitAPI::CheckedArithmeticTester::run):
1839
1840 2017-08-10  Dan Bernstein  <mitz@apple.com>
1841
1842         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
1843         https://bugs.webkit.org/show_bug.cgi?id=173223
1844
1845         Reviewed by Tim Horton.
1846
1847         The rebuilds were happening due to a difference in the compiler options that the IDE and
1848         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
1849         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
1850         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
1851         Advanced when a Custom Absolute path is selected.
1852
1853         * Scripts/webkitdirs.pm:
1854         (determineBaseProductDir):
1855
1856 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
1857
1858         Run more WTF tests
1859         https://bugs.webkit.org/show_bug.cgi?id=174970
1860
1861         Reviewed by Michael Catanzaro.
1862
1863         Some of WTF tests are not executed in non Apple ports while they are generic ones.
1864         This patch adds these tests to non-Apple port TestWebKitAPI.
1865         Currently, we do not add Signals.cpp since it depends on signal functionality.
1866
1867         * TestWebKitAPI/CMakeLists.txt:
1868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1869         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1870         (isHigherPriority):
1871         (TEST):
1872         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
1873         (TEST):
1874         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1875         (TEST):
1876
1877 2017-08-10  obinna obike  <oobike@apple.com>
1878
1879         Remove obsolete link from webkit-queues status page
1880         https://bugs.webkit.org/show_bug.cgi?id=175337
1881
1882         Reviewed by Aakash Jain.
1883
1884         * QueueStatusServer/templates/recentstatus.html:
1885         Removed the link to the ews-watcher server.
1886
1887 2017-08-10  Brian Burg  <bburg@apple.com>
1888
1889         WKPreferences should conform to NSCopying
1890         https://bugs.webkit.org/show_bug.cgi?id=175303
1891         <rdar://problem/33764939>
1892
1893         Reviewed by Dan Bernstein.
1894
1895         Add unit test to make sure a WKPreference and its copy are
1896         not aliased to each other or affect each other's properties.
1897
1898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1899         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
1900         (TEST):
1901
1902 2017-08-10  Tim Horton  <timothy_horton@apple.com>
1903
1904         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
1905         https://bugs.webkit.org/show_bug.cgi?id=175436
1906         <rdar://problem/33667497>
1907
1908         Reviewed by Simon Fraser.
1909
1910         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1911         (TestWebKitAPI::TEST_F):
1912
1913 2017-08-10  Lucas Forschler  <lforschler@apple.com>
1914
1915         Fix duplicated code in r220534.
1916
1917         Unreviewed cleanup.
1918
1919         * Scripts/bisect-builds:
1920
1921 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
1922
1923         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
1924         https://bugs.webkit.org/show_bug.cgi?id=175344
1925         <rdar://problem/28507240>
1926
1927         Reviewed by Alexey Proskuryakov.
1928
1929         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
1930         Finally enable the existing tests for iOS.
1931
1932         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
1933         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1934         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1935         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
1936
1937 2017-08-10  Lucas Forschler  <lforschler@apple.com>
1938
1939         Write a tool to bisect WebKit builds
1940         https://bugs.webkit.org/show_bug.cgi?id=174596
1941
1942         Reviewed by Dean Johnson and Kocsen Chung.
1943
1944         * Scripts/bisect-builds: Added.
1945         (bisect_builds): main bisection algorithm
1946         (download_archive):download an archive from S3 using existing tools
1947         (extract_archive):extract an archive using existing tools
1948         (find_le):Find rightmost value less than or equal to x
1949         (find_ge):Find leftmost item greater than or equal to x
1950         (get_api_url):generate url for the rest api/database
1951         (get_indices_from_revisions):convert revisions to list indexes for bisection
1952         (get_sorted_revisions):retrieve sorted revision list
1953         (get_s3_location_for_revision):calculate the S3 archive storage location
1954         (parse_args):parse command line arguments
1955         (pick_next_build):compute the next build to bisect
1956         (prompt_did_reproduce):prompt user for direction for bisection
1957         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
1958         (test_archive):Platform specific logic to test downloaded archive
1959         (minified_platforms):return a list of minified platforms in the database
1960         (unminified_platforms):return a list of full platforms in the database
1961         (is_supported_platform):check if platform is supported
1962         (validate_options):validate command line options
1963         (main):
1964
1965 2017-08-10  Lucas Forschler  <lforschler@apple.com>
1966
1967         Remove bisect-builds script.
1968         https://bugs.webkit.org/show_bug.cgi?id=175433
1969         
1970         Reviewed by Aakash Jain.
1971
1972         * Scripts/bisect-builds: Removed.
1973
1974 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1975
1976         Remove ENABLE_GAMEPAD_DEPRECATED
1977         https://bugs.webkit.org/show_bug.cgi?id=175361
1978
1979         Reviewed by Carlos Garcia Campos.
1980
1981         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1982
1983 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1984
1985         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
1986         https://bugs.webkit.org/show_bug.cgi?id=175426
1987
1988         Reviewed by Carlos Garcia Campos.
1989
1990         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
1991
1992 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
1993
1994         Add Ms2ger as contributor.
1995         https://bugs.webkit.org/show_bug.cgi?id=175325
1996
1997         Reviewed by Carlos Alberto Lopez Perez.
1998
1999         * Scripts/webkitpy/common/config/contributors.json:
2000
2001 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
2002
2003         Fix run-benchmark after r220483.
2004         https://bugs.webkit.org/show_bug.cgi?id=175415
2005         <rdar://problem/33803003>
2006
2007         Reviewed by Ryosuke Niwa.
2008
2009         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
2010
2011         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2012         (WebServerBenchmarkRunner._run_one_test):
2013
2014 2017-08-09  Chris Dumez  <cdumez@apple.com>
2015
2016         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
2017         https://bugs.webkit.org/show_bug.cgi?id=175401
2018
2019         Reviewed by Brady Eidson.
2020
2021         * DumpRenderTree/mac/DumpRenderTree.mm:
2022         (enableExperimentalFeatures):
2023
2024 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2025
2026         [PAL] Move spi/cocoa and spi/cg directories into PAL
2027         https://bugs.webkit.org/show_bug.cgi?id=175175
2028
2029         Reviewed by Myles C. Maxfield.
2030
2031         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2032         * DumpRenderTree/mac/DumpRenderTree.mm:
2033         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
2034         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2035
2036         * Scripts/webkitpy/style/checker.py:
2037         * Scripts/webkitpy/style/checker_unittest.py:
2038         (GlobalVariablesTest.test_path_rules_specifier):
2039
2040         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
2041
2042         * Scripts/webkitpy/style/checkers/cpp.py:
2043         (check_braces):
2044         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2045         (WebKitStyleTest.test_braces.CF_OPTIONS):
2046         (WebKitStyleTest.test_braces):
2047
2048         Prevent CF_OPTIONS() from being handled as funtion definition.
2049
2050 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
2051
2052         [WTF] Move TextStream into WTF
2053         https://bugs.webkit.org/show_bug.cgi?id=175211
2054
2055         Reviewed by Myles C. Maxfield.
2056
2057         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2058
2059 2017-08-09  Andy Estes  <aestes@apple.com>
2060
2061         Part 3 of: Rename DatabaseProcess to StorageProcess
2062         https://bugs.webkit.org/show_bug.cgi?id=175034
2063
2064         Reviewed by Brady Eidson.
2065
2066         * WebKitTestRunner/TestController.cpp:
2067         (WTR::TestController::databaseProcessName): Updated to return
2068         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
2069
2070 2017-08-09  Commit Queue  <commit-queue@webkit.org>
2071
2072         Unreviewed, rolling out r220466, r220477, and r220487.
2073         https://bugs.webkit.org/show_bug.cgi?id=175411
2074
2075         This change broke existing API tests and follow up fixes did
2076         not resolve all the issues. (Requested by ryanhaddad on
2077         #webkit).
2078
2079         Reverted changesets:
2080
2081         https://bugs.webkit.org/show_bug.cgi?id=175244
2082         http://trac.webkit.org/changeset/220466
2083
2084         "WTF::Function does not allow for reference / non-default
2085         constructible return types"
2086         https://bugs.webkit.org/show_bug.cgi?id=175244
2087         http://trac.webkit.org/changeset/220477
2088
2089         https://bugs.webkit.org/show_bug.cgi?id=175244
2090         http://trac.webkit.org/changeset/220487
2091
2092 2017-08-09  Sam Weinig  <sam@webkit.org>
2093
2094         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
2095
2096         Remove one addition of null Function test.
2097
2098 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
2099
2100         Allow nested timeouts in webkitpy
2101         https://bugs.webkit.org/show_bug.cgi?id=175390
2102         <rdar://problem/33803003>
2103
2104         Reviewed by David Kilzer.
2105
2106         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
2107         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
2108         the executive to detect and recover from any issues connecting with devices.
2109
2110         * Scripts/webkitpy/benchmark_runner/utils.py:
2111         (TimeoutError): Deleted.
2112         (timeout): Deleted.
2113         * Scripts/webkitpy/common/timeout_context.py: Added.
2114         (Timeout): A timeout context designed to be nested.
2115         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
2116         (Timeout.TimeoutData.__init__):
2117         (Timeout.default_handler): Timeout handler used if none is specified.
2118         (Timeout.current): Access data about the most urgent timeout.
2119         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
2120         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
2121         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
2122         urgent timeout data.
2123         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
2124         most urgent timeout data, if such data exists.
2125         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
2126         (TimeoutContextTests):
2127         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
2128         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
2129         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
2130         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
2131         over a less urgent outer timeout.
2132         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
2133         over a less urgent inner timeout.
2134         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
2135         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
2136         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
2137         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
2138         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
2139         * Scripts/webkitpy/port/simulator_process.py:
2140         (SimulatorProcess._start): Use Timeout class.
2141         * Scripts/webkitpy/xcode/simulated_device.py:
2142         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
2143         (SimulatedDevice.launch_app): Ditto.
2144         (SimulatedDevice.launch_app._install_timeout): Deleted.
2145         * Scripts/webkitpy/xcode/simulator.py:
2146         (Simulator.wait_until_device_is_booted):Use Timeout class.
2147         (Simulator.wait_until_device_is_in_state): Ditto.
2148
2149 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2150
2151         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
2152         https://bugs.webkit.org/show_bug.cgi?id=175392
2153         <rdar://problem/33783207>
2154
2155         Reviewed by Tim Horton and Megan Gardner.
2156
2157         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
2158
2159         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2160
2161 2017-08-09  Sam Weinig  <sam@webkit.org>
2162
2163         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
2164
2165         * TestWebKitAPI/Tests/WTF/Function.cpp:
2166         Remove tests of null Functions, as they are no longer supported.
2167
2168 2017-08-09  Daniel Bates  <dabates@apple.com>
2169
2170         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2171         https://bugs.webkit.org/show_bug.cgi?id=175247
2172         <rdar://problem/33679804>
2173
2174         Reviewed by Brady Eidson.
2175
2176         Add tests for redirects.
2177
2178         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
2179         (TEST):
2180         * TestWebKitAPI/cocoa/TestProtocol.mm:
2181         (createRedirectURL):
2182         (-[TestProtocol startLoading]):
2183
2184 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2185
2186         Unreviewed, rolling out r220393.
2187
2188         This patch regresses the performance of WebPage::editorState.
2189
2190         Reverted changeset:
2191
2192         "[iOS WK2] WKWebView schedules nonstop layout after pressing
2193         cmb+b,i,u inside a contenteditable div"
2194         https://bugs.webkit.org/show_bug.cgi?id=175116
2195         http://trac.webkit.org/changeset/220393
2196
2197 2017-08-08  obinna obike  <oobike@apple.com>
2198
2199         Created Individual EWS Pages
2200         https://bugs.webkit.org/show_bug.cgi?id=174477
2201
2202         Reviewed by Aakash Jain.
2203
2204         Created individual pages for each EWS. Changed the link within each status bubble
2205         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
2206
2207         * QueueStatusServer/handlers/patch.py:
2208         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
2209         * QueueStatusServer/handlers/statusbubble.py:
2210         (StatusBubble._build_bubble): Updated url for specific EWS.
2211         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
2212         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
2213         all ews queues.
2214         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
2215         takes you directly to the individual ews page.
2216
2217 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
2218
2219         Separate jsc stress test script writer from run-jsc-stress-tests
2220         https://bugs.webkit.org/show_bug.cgi?id=175216
2221
2222         Reviewed by Mark Lam.
2223
2224         * Scripts/run-jsc-stress-tests:
2225         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
2226
2227 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
2228
2229         Unreviewed, fix Ubuntu LTS build
2230         https://bugs.webkit.org/show_bug.cgi?id=174490
2231
2232         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2233
2234 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2235
2236         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
2237         https://bugs.webkit.org/show_bug.cgi?id=175302
2238         <rdar://problem/33762116>
2239
2240         Reviewed by Tim Horton.
2241
2242         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
2243         See WebKit ChangeLog for more details.
2244
2245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2246         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
2247         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
2248         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
2249         (-[SlowTextInputContext handleEvent:completionHandler:]):
2250         (-[SlowInputWebView inputContext]):
2251         (-[SlowInputWebView _web_superInputContext]):
2252         (TEST):
2253
2254 2017-08-08  John Wilander  <wilander@apple.com>
2255
2256         Resource Load Statistics: Clear web processes' state on history removal
2257         https://bugs.webkit.org/show_bug.cgi?id=175271
2258         <rdar://problem/33756560>
2259
2260         Reviewed by Chris Dumez.
2261
2262         Test infrastructure for asynchronous tests of website data
2263         removal for _WKWebsiteDataTypeResourceLoadStatistics.
2264
2265         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2266         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2267         (WTR::InjectedBundle::didReceiveMessageToPage):
2268         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2269         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2270         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
2271         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2272         * WebKitTestRunner/TestController.cpp:
2273         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
2274         * WebKitTestRunner/TestController.h:
2275         * WebKitTestRunner/TestInvocation.cpp:
2276         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2277         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
2278         * WebKitTestRunner/TestInvocation.h:
2279         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2280         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
2281
2282 2017-08-08  Alicia Boya García  <aboya@igalia.com>
2283
2284         Add Alicia Boya García as contributor
2285         https://bugs.webkit.org/show_bug.cgi?id=175326
2286
2287         Reviewed by Michael Catanzaro.
2288
2289         * Scripts/webkitpy/common/config/contributors.json:
2290
2291 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
2292
2293         [CMake] Properly test if compiler supports compiler flags
2294         https://bugs.webkit.org/show_bug.cgi?id=174490
2295
2296         Reviewed by Konstantin Tokarev.
2297
2298         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2299         * MiniBrowser/gtk/CMakeLists.txt:
2300         * TestRunnerShared/Bindings/JSWrapper.cpp:
2301         (WTR::JSWrapper::initialize):
2302         * TestWebKitAPI/CMakeLists.txt:
2303         * TestWebKitAPI/PlatformGTK.cmake:
2304         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2305         (TestWebKitAPI::CheckedArithmeticTester::run):
2306         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2307         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2308         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2309         (formControlsAssociatedCallback):
2310         * TestWebKitAPI/glib/CMakeLists.txt:
2311         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2312         (Test::getResourcesDir):
2313         * WebKitTestRunner/CMakeLists.txt:
2314         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2315         (WTR::menuItemClickCallback):
2316         (WTR::staticConvertMenuItemToType):
2317         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2318         (WTR::TestRunner::setUseDashboardCompatibilityMode):
2319         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2320         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
2321         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2322         (WTR::AccessibilityUIElement::helpText const):
2323         (WTR::AccessibilityUIElement::attributedStringForRange):
2324         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2325         (WTR::EventSenderProxy::updateTouchPoint):
2326         (WTR::EventSenderProxy::releaseTouchPoint):
2327
2328 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2329
2330         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
2331         https://bugs.webkit.org/show_bug.cgi?id=175116
2332         <rdar://problem/28279301>
2333
2334         Reviewed by Darin Adler and Ryosuke Niwa.
2335
2336         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
2337         EditorStateTests run on both iOS and Mac.
2338
2339         * TestWebKitAPI/EditingTestHarness.h: Added.
2340         * TestWebKitAPI/EditingTestHarness.mm: Added.
2341
2342         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
2343         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
2344         the state of the latest observed EditorState.
2345
2346         (-[EditingTestHarness initWithWebView:]):
2347         (-[EditingTestHarness dealloc]):
2348         (-[EditingTestHarness webView]):
2349         (-[EditingTestHarness latestEditorState]):
2350         (-[EditingTestHarness editorStateHistory]):
2351         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
2352         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
2353         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
2354         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
2355         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
2356         (-[EditingTestHarness toggleBold]):
2357         (-[EditingTestHarness toggleItalic]):
2358         (-[EditingTestHarness toggleUnderline]):
2359         (-[EditingTestHarness setForegroundColor:]):
2360         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
2361         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
2362         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
2363         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
2364         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
2365         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
2366         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
2367
2368         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
2369         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
2370         keys and values.
2371
2372         (-[EditingTestHarness latestEditorStateContains:]):
2373         (-[EditingTestHarness _webView:editorStateDidChange:]):
2374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2375         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
2376         (TestWebKitAPI::setUpEditorStateTestHarness):
2377         (TestWebKitAPI::TEST):
2378         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
2379
2380 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
2381
2382         Prevent domain from being set to a TLD
2383         https://bugs.webkit.org/show_bug.cgi?id=175226
2384         <rdar://problem/11079948>
2385
2386         Reviewed by Chris Dumez.
2387
2388         Extend the public suffix tests to include cases used by the
2389         Public Domain 'Public Suffix List'.
2390
2391         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
2392         (TestWebKitAPI::TEST):
2393
2394 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
2395
2396         [XCode] webkit-patch should run sort-Xcode-project-file
2397         https://bugs.webkit.org/show_bug.cgi?id=174036
2398         <rdar://problem/33732709>
2399
2400         Reviewed by Simon Fraser.
2401
2402         * Scripts/webkitpy/common/config/ports.py:
2403         * Scripts/webkitpy/tool/commands/download.py:
2404         * Scripts/webkitpy/tool/commands/download_unittest.py:
2405         * Scripts/webkitpy/tool/commands/upload.py:
2406         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2407         * Scripts/webkitpy/tool/steps/__init__.py:
2408         * Scripts/webkitpy/tool/steps/options.py:
2409         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
2410
2411 2017-08-07  Devin Rousso  <drousso@apple.com>
2412
2413         Web Inspector: Preview Canvas path when viewing a recording
2414         https://bugs.webkit.org/show_bug.cgi?id=174967
2415
2416         Reviewed by Brian Burg.
2417
2418         * DumpRenderTree/TestOptions.h:
2419         * DumpRenderTree/TestOptions.mm:
2420         (TestOptions::TestOptions):
2421         * DumpRenderTree/mac/DumpRenderTree.mm:
2422         (setWebPreferencesForTestOptions):
2423         * WebKitTestRunner/TestController.cpp:
2424         (WTR::TestController::resetPreferencesToConsistentValues):
2425         (WTR::updateTestOptionsFromTestHeader):
2426         * WebKitTestRunner/TestOptions.h:
2427         (WTR::TestOptions::hasSameInitializationOptions const):
2428         Add plumbing for new InspectorAdditions runtime flag.
2429
2430 2017-08-07  obinna obike  <oobike@apple.com>
2431
2432         Sorted EWS Queues on Patch page
2433         https://bugs.webkit.org/show_bug.cgi?id=173667
2434
2435         Reviewed by Aakash Jain.
2436
2437         * QueueStatusServer/handlers/patch.py:
2438         (Patch.get): Sorted queue_status.
2439         * QueueStatusServer/templates/patch.html:
2440         Changed queue_status.items to queue_status because it's a list.
2441
2442 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2443
2444         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
2445         https://bugs.webkit.org/show_bug.cgi?id=175286
2446
2447         Reviewed by Myles C. Maxfield.
2448
2449         * Scripts/webkitpy/style/checkers/cpp.py:
2450         (check_braces):
2451         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2452         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
2453         (WebKitStyleTest.test_braces):
2454         (WebKitStyleTest.test_braces.NS_OPTIONS):
2455
2456 2017-08-07  Brian Burg  <bburg@apple.com>
2457
2458         Remove CANVAS_PATH compilation guard
2459         https://bugs.webkit.org/show_bug.cgi?id=175207
2460
2461         Reviewed by Sam Weinig.
2462
2463         * Scripts/webkitperl/FeatureList.pm:
2464         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2465
2466 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
2467
2468         [Win] Use Visual Studio 2017 if installed.
2469         https://bugs.webkit.org/show_bug.cgi?id=175188
2470
2471         Reviewed by Sam Weinig.
2472
2473         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
2474
2475         * Scripts/webkitdirs.pm:
2476         (visualStudioInstallDir):
2477         (msBuildInstallDir):
2478
2479 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2480
2481         [GTK][WPE] Add API to provide browser information required by automation
2482         https://bugs.webkit.org/show_bug.cgi?id=175130
2483
2484         Reviewed by Michael Catanzaro.
2485
2486         * MiniBrowser/gtk/main.c:
2487         (automationStartedCallback): Set browser information when a new automation session is started.
2488         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2489         (testAutomationSessionApplicationInfo):
2490         (beforeAll):
2491
2492 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
2493
2494         Unreviewed, rolling out r220295.
2495
2496         This change introduced 4 errors in webkitpy tests.
2497
2498         Reverted changeset:
2499
2500         "[XCode] webkit-patch should run sort-Xcode-project-file"
2501         https://bugs.webkit.org/show_bug.cgi?id=174036
2502         http://trac.webkit.org/changeset/220295
2503
2504 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
2505
2506         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
2507
2508         Unreviewed test gardening.
2509
2510         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2511         (TestWebKitAPI::TEST):
2512
2513 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
2514
2515         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
2516         https://bugs.webkit.org/show_bug.cgi?id=175083
2517
2518         Reviewed by Oliver Hunt.
2519         
2520         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
2521         to wait for VM destructions to finish before running the next test. This makes it easier to 
2522         understand leaks results from workers tests, and leads to fewer reported leaks.
2523
2524         * DumpRenderTree/mac/DumpRenderTree.mm:
2525         (runTest):
2526
2527 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2528
2529         check-webkit-style: fix path-specific rules for WebKit2 rename
2530         https://bugs.webkit.org/show_bug.cgi?id=175182
2531
2532         Reviewed by David Kilzer.
2533
2534         * Scripts/webkitpy/style/checker.py:
2535
2536 2017-08-04  Youenn Fablet  <youenn@apple.com>
2537
2538         [Cache API] Add Cache and CacheStorage IDL definitions
2539         https://bugs.webkit.org/show_bug.cgi?id=175201
2540
2541         Reviewed by Brady Eidson.
2542
2543         * DumpRenderTree/mac/DumpRenderTree.mm:
2544         (enableExperimentalFeatures):
2545         (resetWebPreferencesToConsistentValues):
2546         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2547         (WTR::InjectedBundle::beginTesting):
2548         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2549         (WTR::TestRunner::setCacheAPIEnabled):
2550         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2551
2552 2017-08-04  John Wilander  <wilander@apple.com>
2553
2554         Resource Load Statistics: Report user interaction immediately, but only when needed
2555         https://bugs.webkit.org/show_bug.cgi?id=175090
2556         <rdar://problem/33685546>
2557
2558         Reviewed by Chris Dumez.
2559
2560         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2561         (WTR::InjectedBundle::beginTesting):
2562             Now calls WebCore::ResourceLoadObserver::clearState().
2563
2564 2017-08-04  Tim Horton  <timothy_horton@apple.com>
2565
2566         Add an API test for r220286
2567         https://bugs.webkit.org/show_bug.cgi?id=175206
2568
2569         Reviewed by Simon Fraser.
2570
2571         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2572         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
2573         (createAnimatedResizeWebView):
2574         (TEST):
2575         Add a test to ensure that we don't call
2576         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
2577         animated resize.
2578
2579 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
2580
2581         [XCode] webkit-patch should run sort-Xcode-project-file
2582         https://bugs.webkit.org/show_bug.cgi?id=174036
2583
2584         Reviewed by Simon Fraser.
2585
2586         * Scripts/webkitpy/common/config/ports.py:
2587         * Scripts/webkitpy/tool/commands/download.py:
2588         * Scripts/webkitpy/tool/commands/upload.py:
2589         * Scripts/webkitpy/tool/steps/__init__.py:
2590         * Scripts/webkitpy/tool/steps/options.py:
2591         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
2592
2593 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2594
2595         REGRESSION(r219857): run-benchmark --allplans broken
2596         https://bugs.webkit.org/show_bug.cgi?id=175186
2597
2598         Reviewed by Saam Barati.
2599
2600         r219857 forgot to update also the calls to BenchmarkRunner() that
2601         is done when the script is run with --allplans.
2602
2603         To fix this (and avoid future issues like this), let's factorize
2604         the calls to the benchhmark runner in a run_benchmark_plan()
2605         function.
2606
2607         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2608         (run_benchmark_plan):
2609         (start):
2610
2611 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
2612
2613         Dashboard bubbles sometimes show failure count instead of crash count
2614         https://bugs.webkit.org/show_bug.cgi?id=175157
2615         <rdar://problem/33709009>
2616
2617         Reviewed by Alexey Proskuryakov.
2618
2619         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2620         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
2621
2622 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
2623
2624         Add tests for NeverDestroyed
2625         https://bugs.webkit.org/show_bug.cgi?id=175146
2626
2627         Reviewed by Darin Adler.
2628
2629         * CMakeLists.txt:
2630         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2631         New files and sort.
2632
2633         * TestWebKitAPI/Tests/WTF/Logger.h:
2634         * TestWebKitAPI/Tests/WTF/Logger.cpp:
2635         (TestWebKitAPI::log):
2636         (TestWebKitAPI::takeLogStr):
2637         * TestWebKitAPI/Tests/WTF/RefLogger.h:
2638         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
2639         (TestWebKitAPI::log): Deleted.
2640         (TestWebKitAPI::takeLogStr): Deleted.
2641         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
2642
2643         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
2644         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
2645         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
2646         (TestWebKitAPI::LifecycleLogger::operator=):
2647         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
2648         (TestWebKitAPI::LifecycleLogger::setName):
2649         (TestWebKitAPI::TEST):
2650         Add a class that logs construction / assignment / modifications.
2651
2652         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
2653         (TestWebKitAPI::TEST):
2654         (TestWebKitAPI::list):
2655         Test construction behavior is as expected both directly and using makeNeverDestroyed.
2656
2657 2017-08-04  Lucas Forschler  <lforschler@apple.com>
2658
2659         minification logic is not implemented for ios builds
2660         <rdar://problem/33726561>
2661
2662         Reviewed by Dean Johnson
2663
2664         * BuildSlaveSupport/built-product-archive:
2665         (minifyDirectory): refactor minifySource -> minifyDirectory
2666         (archiveBuiltProduct): add ios minification logic
2667         (minifySource): Deleted.
2668
2669 2017-08-04  Matt Lewis  <jlewis3@apple.com>
2670
2671         Unreviewed, rolling out r220271.
2672
2673         Rolling out due to Layout Test failing on iOS Simulator.
2674
2675         Reverted changeset:
2676
2677         "Remove STREAMS_API compilation guard"
2678         https://bugs.webkit.org/show_bug.cgi?id=175165
2679         http://trac.webkit.org/changeset/220271
2680
2681 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
2682
2683         Unreviewed, rolling out r220268.
2684
2685         This change caused assertion failures on macOS and iOS Debug
2686         WK2.
2687
2688         Reverted changeset:
2689
2690         "Resource Load Statistics: Report user interaction
2691         immediately, but only when needed"
2692         https://bugs.webkit.org/show_bug.cgi?id=175090
2693         http://trac.webkit.org/changeset/220268
2694
2695 2017-08-04  Youenn Fablet  <youenn@apple.com>
2696
2697         Remove STREAMS_API compilation guard
2698         https://bugs.webkit.org/show_bug.cgi?id=175165
2699
2700         Reviewed by Darin Adler.
2701
2702         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2703
2704 2017-08-04  John Wilander  <wilander@apple.com>
2705
2706         Resource Load Statistics: Report user interaction immediately, but only when needed
2707         https://bugs.webkit.org/show_bug.cgi?id=175090
2708         <rdar://problem/33685546>
2709
2710         Reviewed by Chris Dumez.
2711
2712         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2713         (WTR::InjectedBundle::beginTesting):
2714             Now calls WebCore::ResourceLoadObserver::clearState().
2715
2716 2017-08-03  Brian Burg  <bburg@apple.com>
2717
2718         Remove ENABLE(WEB_SOCKET) guards
2719         https://bugs.webkit.org/show_bug.cgi?id=167044
2720
2721         Reviewed by Joseph Pecoraro.
2722
2723         * Scripts/webkitperl/FeatureList.pm:
2724         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2725
2726 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2727
2728         REGRESSION(r219850): run-benchmark script broken on Linux
2729         https://bugs.webkit.org/show_bug.cgi?id=175126
2730
2731         Reviewed by Stephanie Lewis.
2732
2733         The run-benchmark script dynamically generates the list of supported
2734         browsers and platforms (currently Linux and OSX) by loading all
2735         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
2736         and getting the browser_name and platform variables from the
2737         classes defined there.
2738
2739         This means that this classes should not raise an exception when
2740         loaded on other platforms or otherwise they will broke the whole
2741         script. Its fine if they raise an exception when executing any of
2742         the methods they implement, but not when just loading/importing
2743         the class.
2744
2745         Move the argument variable definitions that call on the platform
2746         specific OSXBrowserDriver._screen_size() function from beeing
2747         variables that are evaluated when loading the file, to be functions
2748         that are only evaluated when the actual functionality needs to be
2749         executed.
2750
2751         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2752         (OSXChromeDriver.launch_url):
2753         (OSXChromeCanaryDriver.launch_url):
2754         (create_args):
2755         (create_chrome_options):
2756         (create_window_size_arg):
2757         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2758         (OSXFirefoxDriver.launch_url):
2759         (OSXFirefoxNightlyDriver.launch_url):
2760         (OSXFirefoxNightlyDriver.launch_driver):
2761         (create_args):
2762
2763 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
2764
2765         [PAL] Move spi/cf directory into PAL
2766         https://bugs.webkit.org/show_bug.cgi?id=175057
2767
2768         Reviewed by Antti Koivisto.
2769
2770         * Scripts/webkitpy/style/checker.py:
2771         * Scripts/webkitpy/style/checker_unittest.py:
2772         (GlobalVariablesTest.test_path_rules_specifier):
2773
2774         Ignore "readability/naming/underscores" style errors for sources
2775         under the WebCore/PAL/pal/spi directory.
2776
2777         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
2778
2779 2017-08-03  Youenn Fablet  <youenn@apple.com>
2780
2781         Remove FETCH_API compilation guard
2782         https://bugs.webkit.org/show_bug.cgi?id=175154
2783
2784         Reviewed by Chris Dumez.
2785
2786         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2787
2788 2017-08-03  Lucas Forschler  <lforschler@apple.com>
2789
2790         Enable archive minification on iOS builds
2791         https://bugs.webkit.org/show_bug.cgi?id=174718
2792         
2793         Reviewed by Aakash Jain.
2794
2795         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2796         (BuildFactory.__init__):
2797
2798 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2799
2800         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
2801         https://bugs.webkit.org/show_bug.cgi?id=175140
2802
2803         Reviewed by Alexey Proskuryakov.
2804
2805         We are having lately issues with JSC tests causing problems on
2806         the GTK+ and WPE bots due to the high amount of memory some tests
2807         need to run.
2808
2809         The best thing we can do now is to workaround this by disabling
2810         all the tests marked as memoryLimited on the GTK and WPE bots.
2811         We may revise this on the future.
2812
2813         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2814         (RunJavaScriptCoreTests.start):
2815
2816 2017-08-03  Brady Eidson  <beidson@apple.com>
2817
2818         Add SW IDLs and stub out basic functionality.
2819         https://bugs.webkit.org/show_bug.cgi?id=175115
2820
2821         Reviewed by Chris Dumez.
2822
2823         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2824
2825         * Scripts/webkitpy/bindings/main.py:
2826
2827 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
2828
2829         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
2830         https://bugs.webkit.org/show_bug.cgi?id=159510
2831
2832         Reviewed by Daniel Bates.
2833
2834         Allow any https certificate when running tests.
2835
2836         * DumpRenderTree/win/DumpRenderTree.cpp:
2837         (runTest):
2838
2839 2017-08-02  Youenn Fablet  <youenn@apple.com>
2840
2841         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
2842         https://bugs.webkit.org/show_bug.cgi?id=175089
2843
2844         Reviewed by Chris Dumez.
2845
2846         * DumpRenderTree/TestOptions.mm:
2847         (TestOptions::TestOptions): Using absolutePath if available.
2848         * DumpRenderTree/mac/DumpRenderTree.mm:
2849         (computeTestURL): Removing http/tests/ specific URL computation.
2850         * Scripts/webkitpy/port/driver.py:
2851         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
2852
2853 2017-08-02  Lucas Forschler  <lforschler@apple.com>
2854
2855         download-built-product should allow for a proxy option
2856         https://bugs.webkit.org/show_bug.cgi?id=174875
2857
2858         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
2859
2860         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2861         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
2862         
2863
2864 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
2865
2866         check-webkit-style: deleting lines in a file runs the linter on the whole file
2867         https://bugs.webkit.org/show_bug.cgi?id=175078
2868
2869         Reviewed by David Kilzer.
2870
2871         Deleting lines in a file should not cause linter errors to be blamed on the patch.
2872         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
2873
2874         * Scripts/webkitpy/style/checkers/test_expectations.py:
2875         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
2876         * Scripts/webkitpy/style/main_unittest.py:
2877         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
2878         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
2879         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
2880
2881 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
2882
2883         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
2884         https://bugs.webkit.org/show_bug.cgi?id=175075
2885
2886         Reviewed by David Kilzer.
2887
2888         We have no way of handling text files with illegal unicode characters. Allow the callers of
2889         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
2890         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
2891
2892         * Scripts/webkitpy/common/system/filesystem.py:
2893         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
2894         (FileSystem.write_text_file): Ditto.
2895         * Scripts/webkitpy/common/system/filesystem_mock.py:
2896         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
2897         (MockFileSystem.write_text_file): Ditto.
2898         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2899         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
2900         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
2901
2902 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
2903
2904         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
2905         https://bugs.webkit.org/show_bug.cgi?id=175072
2906
2907         Reviewed by Alexey Proskuryakov.
2908
2909         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2910         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
2911
2912 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2913
2914         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
2915         https://bugs.webkit.org/show_bug.cgi?id=175019
2916
2917         Reviewed by Darin Adler.
2918
2919         * TestWebKitAPI/CMakeLists.txt:
2920
2921 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
2922
2923         Enabling uploading archives to S3
2924         https://bugs.webkit.org/show_bug.cgi?id=174198
2925
2926         Unreviewed unit test fix after r219235.
2927
2928         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2929
2930 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
2931
2932         Fix JSCOnly ARM buildbots after r220047
2933         https://bugs.webkit.org/show_bug.cgi?id=174993
2934
2935         Unreviewed fix after r220087.
2936
2937         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2938         (BuildAndRemoteJSCTestsFactory.__init__):
2939
2940 2017-08-01  Chris Dumez  <cdumez@apple.com>
2941
2942         Add initial support for navigator.sendBeacon
2943         https://bugs.webkit.org/show_bug.cgi?id=175007
2944         <rdar://problem/33547728>
2945
2946         Reviewed by Sam Weinig.
2947
2948         Enable the Beacon API at runtime in the context of layout tests since the
2949         feature is currently disabled by default.
2950
2951         * DumpRenderTree/mac/DumpRenderTree.mm:
2952         (enableExperimentalFeatures):
2953         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2954         (WTR::InjectedBundle::beginTesting):
2955         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2956         (WTR::TestRunner::setModernMediaControlsEnabled):
2957         (WTR::TestRunner::setBeaconAPIEnabled):
2958         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2959
2960 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
2961
2962         Update Bot Watcher's Dashboard for Buildbot 0.9
2963         https://bugs.webkit.org/show_bug.cgi?id=174777
2964
2965         Reviewed by Daniel Bates.
2966
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2968         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
2969         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
2970         in a dictionary.
2971         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
2972         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
2973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2974         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
2975         (parseRevisionProperty): Ditto.
2976         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
2977         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
2978         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
2979         have changed in Buildbot 0.9.
2980         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
2981         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
2982         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
2983         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
2984         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
2985         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
2986         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
2987         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
2988         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
2989         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
2990         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2991         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
2992         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
2993         (BuildbotQueue.prototype.get overviewURL): Ditto.
2994         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
2995         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
2996         Buildbot 0.8 or 0.9.
2997         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
2998         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
2999         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
3000         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
3001         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
3002         Therefore we are fetching information for fixed number of build. 
3003         Also iterating the loop incrementally since the build data is already reverse sorted.
3004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3005         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
3006         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
3007         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3008         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
3009
3010 2017-08-01  Devin Rousso  <drousso@apple.com>
3011
3012         Web Inspector: simplify WebInspector with WI
3013         https://bugs.webkit.org/show_bug.cgi?id=175058
3014
3015         Reviewed by Joseph Pecoraro.
3016
3017         * Scripts/check-inspector-strings:
3018         (extract_ui_strings):
3019         * Scripts/extract-localizable-js-strings:
3020
3021 2017-08-01  Youenn Fablet  <youenn@apple.com>
3022
3023         Layout tests with 'https' suffix should be run over HTTPS
3024         https://bugs.webkit.org/show_bug.cgi?id=174992
3025
3026         Reviewed by Chris Dumez.
3027
3028         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
3029         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
3030         Covered by corresponding unit tests.
3031
3032         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
3033         (run_server):
3034         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3035         (base_http_url):
3036         (base_https_url):
3037         (base_url): Deleted.
3038         * Scripts/webkitpy/port/base.py:
3039         (Port.to.web_platform_test_server_base_http_url):
3040         (Port.to):
3041         (Port.to.web_platform_test_server_base_https_url):
3042         (Port.to.web_platform_test_server_base_url): Deleted.
3043         * Scripts/webkitpy/port/driver.py:
3044         (Driver.__init__):
3045         (Driver.wpt_test_path_to_uri):
3046         (Driver):
3047         (Driver.http_test_path_to_uri):
3048         (Driver.test_to_uri):
3049         (Driver.uri_to_test):
3050         * Scripts/webkitpy/port/driver_unittest.py:
3051         (DriverTest.test_test_to_uri):
3052         (DriverTest.test_uri_to_test):
3053
3054 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
3055
3056         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
3057         https://bugs.webkit.org/show_bug.cgi?id=173998
3058
3059         Reviewed by Darin Adler.
3060
3061         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
3062         detect mistakes in backward compatibility in the future when we change it.
3063
3064         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
3065         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
3066         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
3067         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
3068         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
3069         internal key data slot.
3070
3071         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3072         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
3073         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
3074         (getNextMessage):
3075         (TEST):
3076         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
3077         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
3078         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
3079         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
3080         These are the pre-baked databases.
3081         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
3082         This is the actual test that do all the reads and comparisons.
3083         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
3084         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
3085         IndexedDB new stuffs. Then it can be used to bake the database again.
3086
3087 2017-08-01  Brady Eidson  <beidson@apple.com>
3088
3089         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
3090         https://bugs.webkit.org/show_bug.cgi?id=175030
3091
3092         Reviewed by Andy Estes.
3093
3094         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3095         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
3096
3097 2017-08-01  Brady Eidson  <beidson@apple.com>
3098
3099         Part 2 of: Rename DatabaseProcess to StorageProcess.
3100         https://bugs.webkit.org/show_bug.cgi?id=174880
3101
3102         Reviewed by Andy Estes.
3103
3104         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
3105         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
3106         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
3107         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3108         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
3109         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
3110         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
3111         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3112
3113 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
3114
3115         Fix JSCOnly ARM buildbots after r220047
3116         https://bugs.webkit.org/show_bug.cgi?id=174993
3117
3118         Reviewed by Saam Barati.
3119
3120         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3121         (BuildAndRemoteJSCTestsFactory.__init__):
3122
3123 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
3124
3125         [WTF] Introduce Private Symbols
3126         https://bugs.webkit.org/show_bug.cgi?id=174935
3127
3128         Reviewed by Darin Adler.
3129
3130         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3131         (TestWebKitAPI::TEST):
3132
3133 2017-07-30  Darin Adler  <darin@apple.com>
3134
3135         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
3136         https://bugs.webkit.org/show_bug.cgi?id=130653
3137
3138         Reviewed by Antti Koivisto.
3139
3140         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3141         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
3142         when calling frameDidChangeLocation.
3143         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
3144         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
3145         thus causing mysterious failures of a couple of tests. There are two remaining issues:
3146         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
3147         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
3148         same logic flaw that causes "top loading frame" to get set to one of the subframes in
3149         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
3150         loading, subframe starts loading. It would be good to clean that up some day, but for now
3151         this patch makes the two work identically rather than changing both.
3152         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
3153
3154 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3155
3156         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
3157         https://bugs.webkit.org/show_bug.cgi?id=174963
3158
3159         Reviewed by Darin Adler.
3160
3161         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
3162         RetainPtr<>. This patch changes them to all use auto.
3163
3164         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3165         (TestWebKitAPI::TEST):
3166
3167 2017-07-30  Brady Eidson  <beidson@apple.com>
3168
3169         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
3170         https://bugs.webkit.org/show_bug.cgi?id=174958
3171
3172         Reviewed by Darin Adler.
3173
3174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3175         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
3176         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
3177         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
3178         (runUntilTasksInFlight):
3179         (TEST):
3180
3181 2017-07-28  Commit Queue  <commit-queue@webkit.org>
3182
3183         Unreviewed, rolling out r219990.
3184         https://bugs.webkit.org/show_bug.cgi?id=174961
3185
3186         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
3187         estes on #webkit).
3188
3189         Reverted changeset:
3190
3191         "Part 2 of: Rename DatabaseProcess to StorageProcess."
3192         https://bugs.webkit.org/show_bug.cgi?id=174880
3193         http://trac.webkit.org/changeset/219990
3194
3195 2017-07-28  Brady Eidson  <beidson@apple.com>
3196
3197         API tests that use URLSchemeHandler are failing.
3198         https://bugs.webkit.org/show_bug.cgi?id=174950
3199
3200         Reviewed by Alex Christensen.
3201
3202         Fix the NoMIMEType test to be correct.
3203
3204         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3205         (-[SchemeHandler initWithData:mimeType:]):
3206         (-[SchemeHandler webView:startURLSchemeTask:]):
3207         (TEST):
3208
3209 2017-07-28  Daniel Bates  <dabates@apple.com>
3210
3211         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
3212         https://bugs.webkit.org/show_bug.cgi?id=174876
3213
3214         Reviewed by Alex Christensen.
3215
3216         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
3217         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
3218         they provide a more direct way to test the platform abstraction.
3219
3220         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
3221
3222         * Scripts/prepare-ChangeLog:
3223         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
3224         of the current working directory.
3225
3226 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
3227
3228         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
3229         https://bugs.webkit.org/show_bug.cgi?id=174930
3230
3231         Unreviewed test fix.
3232
3233         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
3234
3235         * Scripts/prepare-ChangeLog:
3236         (get_function_line_ranges_for_cpp):
3237
3238 2017-07-28  JF Bastien  <jfbastien@apple.com>
3239
3240         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
3241         https://bugs.webkit.org/show_bug.cgi?id=174930
3242
3243         Reviewed by Daniel Bates.
3244
3245         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
3246         here also teach it about const and volatile overloads. I didn't do
3247         reference and rvalue reference overloads because we don't really
3248         use them, and the current parser throws away those characters and
3249         it doesn't seem worth making it more complex.
3250
3251         * Scripts/prepare-ChangeLog:
3252         (get_function_line_ranges_for_cpp):
3253         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
3254         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
3255         (Foo::Arrow::arrow):
3256         (Foo::Arrow::otherArrow):
3257         (Foo::Arrow::otherArrow const):
3258         (Foo::Arrow::otherArrow volatile):
3259         (Foo::Arrow::otherArrow const volatile):
3260
3261 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
3262
3263         [GTK] Building with ENABLE_VIDEO=OFF fails
3264         https://bugs.webkit.org/show_bug.cgi?id=174940
3265
3266         Reviewed by Alex Christensen.
3267
3268         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
3269         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
3270
3271         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3272         (methodCallCallback): Add missing USE(GSTREAMER) guard.
3273
3274 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
3275
3276         [WPE] Implement EventSenderProxy in WTR
3277         https://bugs.webkit.org/show_bug.cgi?id=173419
3278
3279         Reviewed by Žan Doberšek.
3280
3281         Add the implementation of EventSenderProxy to the WTR. This
3282         allows us to extend the coverage of the test suite in WKWPE.
3283
3284         * WebKitTestRunner/EventSenderProxy.h:
3285         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
3286         libxkbcommon needed to deal with key events.
3287         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3288         (WTR::EventSenderProxy::EventSenderProxy):
3289         (WTR::senderButtonToWPEButton):
3290         (WTR::EventSenderProxy::mouseDown):
3291         (WTR::EventSenderProxy::mouseUp):
3292         (WTR::EventSenderProxy::mouseMoveTo):
3293         (WTR::EventSenderProxy::mouseScrollBy):
3294         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3295         (WTR::EventSenderProxy::leapForward):
3296         (WTR::wkEventModifiersToWPE):
3297         (WTR::getXKBKeySymForKeyRef):
3298         (WTR::EventSenderProxy::keyDown):
3299         (WTR::EventSenderProxy::addTouchPoint):
3300         (WTR::EventSenderProxy::updateTouchPoint):
3301         (WTR::EventSenderProxy::setTouchModifier):
3302         (WTR::EventSenderProxy::setTouchPointRadius):
3303         (WTR::EventSenderProxy::getUpdatedTouchEvents):
3304         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
3305         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3306         (WTR::EventSenderProxy::touchStart):
3307         (WTR::EventSenderProxy::touchMove):
3308         (WTR::EventSenderProxy::touchEnd):
3309         (WTR::EventSenderProxy::touchCancel):
3310         (WTR::EventSenderProxy::clearTouchPoints):
3311         (WTR::EventSenderProxy::releaseTouchPoint):
3312         (WTR::EventSenderProxy::cancelTouchPoint):
3313
3314 2017-07-27  Brady Eidson  <beidson@apple.com>
3315
3316         Part 2 of: Rename DatabaseProcess to StorageProcess.
3317         https://bugs.webkit.org/show_bug.cgi?id=174880
3318
3319         Reviewed by Andy Estes.
3320
3321         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
3322         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
3323         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
3324         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3325         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
3326         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
3327         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
3328         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3329
3330 2017-07-26  Mark Lam  <mark.lam@apple.com>
3331
3332         Add ability to only run specific tests in run-javascriptcore-tests.
3333         https://bugs.webkit.org/show_bug.cgi?id=174884
3334
3335         Reviewed by Saam Barati.
3336
3337         For example, if we only want to run testapi, we can do so as follows:
3338             $ run-javascriptcore-tests --testapi
3339
3340         Previously, specifying --testapi effectively does nothing because we run all tests
3341         by default.  Only --no-testapi had the effect of disabling the test set.  This
3342         old behavior for --testapi is not very useful or meaningful.  We're now changing
3343         it to mean that we will only run that test.
3344
3345         With this change, we can also run more than one set of tests.  For example, if we
3346         only want to run testmasm and testair, we can do so as follows:
3347             $ run-javascriptcore-tests --testmasm --testair
3348
3349         By default, if no specific test option is specified, run-javascriptcore-tests will
3350         run all tests.
3351
3352         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
3353         the mozilla tests (--mozilla-tests) even though both are run via the lower level
3354         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
3355         the other set will not run.  For example, the following only runs the mozilla tests:
3356             $ run-javascriptcore-tests --mozilla-tests
3357
3358         Note also that --jit-stress-tests is not for choosing a different set of tests.
3359         Instead, it is used for determining whether we run JIT'ed test configurations
3360         on the jsc stress tests and mozilla tests.  As a result, specifying
3361         --jit-stress-tests will not omit other tests.  For example, the following still
3362         runs all tests:
3363             $ run-javascriptcore-tests --jit-stress-tests
3364
3365         * Scripts/run-javascriptcore-tests:
3366         (defaultStringForTestState):
3367         (enableTestOrNot):
3368         (runJSCStressTests):
3369
3370 2017-07-26  Mark Lam  <mark.lam@apple.com>
3371
3372         Make run-javascriptcore-test run testair, testb3, and testmasm.
3373         https://bugs.webkit.org/show_bug.cgi?id=174837
3374         <rdar://problem/33522927>
3375
3376         Reviewed by Saam Barati and Filip Pizlo.
3377
3378         1. Refactors code for running testapi so that we can use it to run other tests.
3379         2. Added running of testmasm, testair, testb3.
3380
3381         Note: the existing testapi invocation code does not support remote invocation of
3382         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
3383         and testb3 also do not support remote invocation.  If we wish to add remote
3384         invocation support, we should do that in a separate patch.
3385
3386         * Scripts/run-javascriptcore-tests:
3387         (testPath):
3388         (runTest):
3389         (testapiPath): Deleted.
3390
3391 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
3392
3393         Remove duplicate code from Buildbot.js in dashboard
3394         https://bugs.webkit.org/show_bug.cgi?id=174870
3395
3396         Reviewed by Daniel Bates.
3397
3398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3399         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
3400         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
3401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
3402         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
3403
3404 2017-07-26  Brady Eidson  <beidson@apple.com>
3405
3406         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
3407         https://bugs.webkit.org/show_bug.cgi?id=174851
3408
3409         Reviewed by Chris Dumez.
3410
3411         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
3412         (TEST):
3413
3414 2017-07-26  Brian Burg  <bburg@apple.com>
3415
3416         Remove WEB_TIMING feature flag
3417         https://bugs.webkit.org/show_bug.cgi?id=174795
3418
3419         Reviewed by Alex Christensen.
3420
3421         * Scripts/webkitperl/FeatureList.pm:
3422         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3423
3424 2017-07-26  Chris Dumez  <cdumez@apple.com>
3425
3426         Pressing the Escape key should not be a valid user gesture to enter fullscreen
3427         https://bugs.webkit.org/show_bug.cgi?id=174864
3428         <rdar://problem/33009088>
3429
3430         Reviewed by Geoffrey Garen.
3431
3432         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
3433         WKTR.
3434
3435         * DumpRenderTree/mac/EventSendingController.mm:
3436         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3437
3438 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
3439
3440         Unreviewed, added Romain Bellessort to contributors.json.
3441
3442         * Scripts/webkitpy/common/config/contributors.json:
3443
3444 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
3445
3446         [WPE] WebGL2 support
3447         https://bugs.webkit.org/show_bug.cgi?id=174249
3448
3449         Reviewed by Alex Christensen.
3450
3451         * Scripts/webkitperl/FeatureList.pm:
3452         Enable WebGL2 for WPE when building through build-webkit.
3453
3454 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3455
3456         Unreviewed. Fix GTK distcheck.
3457
3458         * gtk/make-dist.py:
3459         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
3460
3461 2017-07-25  Brady Eidson  <beidson@apple.com>
3462
3463         ResourceLoadStatistics grandfathering happens much too often.
3464         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
3465
3466         Reviewed by Chris Dumez.
3467
3468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3469         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
3470         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
3471         (TEST):
3472
3473 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
3474
3475         Fix autoinstaller failing on autoinstall_everything
3476         https://bugs.webkit.org/show_bug.cgi?id=174830
3477
3478         Reviewed by Joseph Pecoraro.
3479
3480         * Scripts/webkitpy/thirdparty/__init__.py:
3481         (AutoinstallImportHook.find_module):
3482         (AutoinstallImportHook.install_chromedriver):
3483         (AutoinstallImportHook.install_geckodriver):
3484         (AutoinstallImportHook._install_chromedriver): Deleted.
3485         (AutoinstallImportHook._install_geckodriver): Deleted.
3486
3487 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
3488
3489         Replace --runtime with something for both ios-simulator and ios-device
3490         https://bugs.webkit.org/show_bug.cgi?id=173775
3491         <rdar://problem/32952164>
3492
3493         Reviewed by Aakash Jain.
3494
3495         Add --version flag for both iOS simulator and iOS device.
3496
3497         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3498         (parse_args): Add --version flag and move --no-install.
3499         * Scripts/webkitpy/port/factory.py:
3500         (platform_options): Move --no-intall to run_webkit_tests.py.
3501         * Scripts/webkitpy/port/ios.py:
3502         (IOSPort):
3503         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
3504         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
3505         * Scripts/webkitpy/port/ios_device.py:
3506         (IOSDevicePort.ios_version): Consult --version flag before checking connected
3507         devices for iOS version.
3508         * Scripts/webkitpy/port/ios_device_unittest.py:
3509         (IOSDeviceTest.make_port): Set --version option so that we can generate test
3510         expectation paths without devices connected.
3511         (IOSDeviceTest.test_additional_platform_directory): Deleted.
3512         (IOSDeviceTest.test_baseline_searchpath): Deleted.
3513         (IOSDeviceTest.test_expectations_ordering): Deleted.
3514         * Scripts/webkitpy/port/ios_simulator.py:
3515         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
3516         flag to specify a runtime.
3517         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
3518         flag and then use the default runtime.
3519
3520 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3521
3522         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
3523         https://bugs.webkit.org/show_bug.cgi?id=174815
3524
3525         Reviewed by Carlos Alberto Lopez Perez.
3526
3527         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
3528         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
3529         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
3530         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
3531         think), probably because of a newer CMake version.
3532
3533         * CMakeLists.txt:
3534         * TestWebKitAPI/CMakeLists.txt:
3535         * TestWebKitAPI/PlatformGTK.cmake:
3536
3537 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
3538
3539         Fix BenchmarkRunner to only import selenium when needed
3540         https://bugs.webkit.org/show_bug.cgi?id=174808
3541
3542         Reviewed by Stephanie Lewis.
3543
3544         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
3545         (LinuxChromeDriver.launch_driver):
3546         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
3547         (LinuxFirefoxDriver.launch_driver):
3548         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3549         (OSXChromeDriver.launch_driver):
3550         (OSXChromeCanaryDriver.launch_driver):
3551         (create_chrome_options):
3552         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3553         (OSXFirefoxDriver.launch_driver):
3554         (OSXFirefoxNightlyDriver.launch_driver):
3555         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3556         (OSXSafariDriver.launch_driver):
3557         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
3558         (WebDriverBenchmarkRunner._run_one_test):
3559
3560 2017-07-23  Darin Adler  <darin@apple.com>
3561
3562         More NeverDestroyed and related cleanup
3563         https://bugs.webkit.org/show_bug.cgi?id=174745
3564
3565         Reviewed by Alex Christensen.
3566
3567         * DumpRenderTree/JavaScriptThreading.cpp:
3568         (javaScriptThreadsMutex): Use NeverDestroyed instead of
3569         DEPRECATED_DEFINE_STATIC_LOCAL.
3570         (javaScriptThreads): Ditto.
3571
3572 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
3573
3574         Subclass Benchmark Runner script for WebDriver support
3575         https://bugs.webkit.org/show_bug.cgi?id=174390
3576
3577         Reviewed by Dewei Zhu, Stephanie Lewis.
3578
3579         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
3580
3581         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
3582         (BenchmarkBuilder.__init__):
3583         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3584         (BenchmarkRunner.__init__):
3585         (BenchmarkRunner._find_plan_file):
3586         (BenchmarkRunner._run_one_test.and):
3587         (BenchmarkRunner.execute):
3588         (BenchmarkRunner._get_result): Deleted.
3589         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3590         (parse_args):
3591         (start):
3592         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
3593         (WebDriverBenchmarkRunner):
3594         (WebDriverBenchmarkRunner._get_result):
3595         (WebDriverBenchmarkRunner._run_one_test):
3596         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
3597         (WebServerBenchmarkRunner):
3598         (WebServerBenchmarkRunner.__init__):
3599         (WebServerBenchmarkRunner._get_result):
3600         (WebServerBenchmarkRunner._run_one_test):
3601
3602 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
3603
3604         Add BenchmarkRunner patches with WebDriver support for each testing plan
3605         https://bugs.webkit.org/show_bug.cgi?id=174443
3606
3607         Reviewed by Dewei Zhu, Stephanie Lewis.
3608
3609         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
3610         (BenchmarkBuilder.__enter__):
3611         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
3612         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
3613         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
3614         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
3615         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
3616         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
3617         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
3618         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
3619         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
3620         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
3621         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
3622         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
3623         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
3624         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
3625         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
3626         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
3627         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
3628         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
3629         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
3630         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
3631         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
3632         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
3633         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
3634         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
3635         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
3636         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
3637         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
3638         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
3639         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
3640         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
3641         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
3642         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
3643         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
3644
3645 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
3646
3647         Add functions to autoinstaller needed for Benchmark Runner script
3648         https://bugs.webkit.org/show_bug.cgi?id=174331
3649
3650         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
3651
3652         Adds autoinstaller functions to install selenium and webdriver binaries
3653         which will be used by the browser driver part of Benchmark Runner.
3654
3655         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3656         (BrowserDriver.restore_env):
3657         (BrowserDriver):
3658         (BrowserDriver.get_webdriver_binary_path):
3659         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
3660         (LinuxChromeDriver.launch_driver):
3661         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
3662         (LinuxFirefoxDriver.launch_driver):
3663         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3664         (OSXChromeDriver.launch_driver):
3665         (OSXChromeCanaryDriver.launch_driver):
3666         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3667         (OSXFirefoxDriver.launch_driver):
3668         (OSXFirefoxNightlyDriver.launch_driver):
3669         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3670         * Scripts/webkitpy/benchmark_runner/utils.py:
3671         (get_driver_binary_path):
3672         * Scripts/webkitpy/common/system/autoinstall.py:
3673         (AutoInstaller._unzip):
3674         * Scripts/webkitpy/thirdparty/__init__.py:
3675         (AutoinstallImportHook.find_module):
3676         (AutoinstallImportHook._install_selenium):
3677         (AutoinstallImportHook):
3678         (AutoinstallImportHook._install_chromedriver):
3679         (AutoinstallImportHook._install_geckodriver):
3680         (AutoinstallImportHook.get_latest_pypi_url):
3681         (AutoinstallImportHook.install_binary):
3682         (autoinstall_everything):
3683         (get_driver_filename):
3684         (get_os_info):
3685
3686 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
3687
3688         Add WebDriver support in browser driver part of BenchmarkRunner
3689         https://bugs.webkit.org/show_bug.cgi?id=174445
3690
3691         Reviewed by Stephanie Lewis.
3692
3693         Adds a launch_driver function to each BrowserDriver subclass. This
3694         function sets up the arguments for the webdriver and launches the
3695         webdriver specific to that browser.
3696
3697         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3698         (BrowserDriver.launch_webdriver):
3699         (BrowserDriver):
3700         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
3701         (LinuxBrowserDriver.launch_webdriver):
3702         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
3703         (LinuxChromeDriver.launch_url):
3704         (LinuxChromeDriver):
3705         (LinuxChromeDriver.launch_driver):
3706         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
3707         (EpiphanyBrowserDriver.launch_url):
3708         (EpiphanyBrowserDriver):
3709         (EpiphanyBrowserDriver.launch_driver):
3710         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
3711         (LinuxFirefoxDriver):
3712         (LinuxFirefoxDriver.launch_url):
3713         (LinuxFirefoxDriver.launch_driver):
3714         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
3715         (GTKMiniBrowserDriver.launch_url):
3716         (GTKMiniBrowserDriver):
3717         (GTKMiniBrowserDriver.launch_driver):
3718         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3719         (OSXBrowserDriver._launch_webdriver):
3720         (OSXBrowserDriver):
3721         (OSXBrowserDriver._screen_size):
3722         (OSXBrowserDriver._insert_url):
3723         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3724         (OSXChromeDriver):
3725         (OSXChromeDriver.launch_url):
3726         (OSXChromeDriver.launch_driver):
3727         (OSXChromeCanaryDriver):
3728         (OSXChromeCanaryDriver.launch_url):
3729         (OSXChromeCanaryDriver.launch_driver):
3730         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3731         (OSXFirefoxDriver):
3732         (OSXFirefoxDriver.launch_url):
3733         (OSXFirefoxDriver.launch_driver):
3734         (OSXFirefoxNightlyDriver):
3735         (OSXFirefoxNightlyDriver.launch_url):
3736         (OSXFirefoxNightlyDriver.launch_driver):
3737         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3738         (OSXSafariDriver.launch_driver):
3739
3740 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3741
3742         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
3743         https://bugs.webkit.org/show_bug.cgi?id=174793
3744
3745         Reviewed by Tim Horton.
3746
3747         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
3748         down. Without r219765, this test will dereference null and crash.
3749
3750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3751         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
3752         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
3753         (TEST):
3754
3755 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3756
3757         [Win] Implement Authentication dialog in MiniBrowser
3758         https://bugs.webkit.org/show_bug.cgi?id=174662
3759
3760         Reviewed by Alex Christensen.
3761
3762         * MiniBrowser/win/Common.cpp:
3763         (CustomUserAgent):
3764         (DisplayAuthDialog):
3765         (AuthDialogProc):
3766         * MiniBrowser/win/MiniBrowserLib.rc:
3767         * MiniBrowser/win/MiniBrowserLibResource.h:
3768         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3769         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3770
3771 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
3772
3773         Handle case where line_numbers is None instead of an array of line numbers
3774         https://bugs.webkit.org/show_bug.cgi?id=174775
3775
3776         Reviewed by Aakash Jain.
3777
3778         Added files set line_numbers to None in process_file.
3779
3780         * Scripts/webkitpy/style/filereader.py:
3781         (TextFileReader.process_file): Handle case where line_number is set to None.
3782         * Scripts/webkitpy/style/main_unittest.py:
3783         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
3784
3785 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
3786
3787         [WPE] Add libepoxy to the Jhbuild moduleset
3788         https://bugs.webkit.org/show_bug.cgi?id=174711
3789
3790         Reviewed by Carlos Alberto Lopez Perez.
3791
3792         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
3793
3794 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
3795
3796         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
3797         https://bugs.webkit.org/show_bug.cgi?id=174780
3798
3799         Reviewed by Carlos Garcia Campos.
3800
3801         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
3802         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
3803         in case the eglplatform.h header doesn't provide that macro. This replicates
3804         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
3805
3806 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3807
3808         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
3809         https://bugs.webkit.org/show_bug.cgi?id=174758
3810
3811         Reviewed by Dan Bernstein.
3812
3813         Migrate position-information-related unit tests from the PositionInformationTests suite to
3814         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
3815
3816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3817         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3818         (TestWebKitAPI::checkElementTypeAndBoundingRect):
3819         (TestWebKitAPI::TEST):
3820         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
3821         * TestWebKitAPI/cocoa/TestWKWebView.h:
3822         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3823         (-[TestWKWebView activatedElementAtPosition:]):
3824
3825 2017-07-22  Chris Dumez  <cdumez@apple.com>
3826
3827         REGRESSION(r204565): WKObject is broken
3828         https://bugs.webkit.org/show_bug.cgi?id=174736
3829         <rdar://problem/33246169>
3830
3831         Reviewed by Dan Bernstein.
3832
3833         Add API test that used to crash.
3834
3835         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
3836         (TestWebKitAPI::TEST):
3837
3838 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
3839
3840         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
3841         https://bugs.webkit.org/show_bug.cgi?id=174705
3842
3843         Reviewed by Mark Lam.
3844
3845         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
3846         (TestWebKitAPI::testThreadGroup):
3847         (TestWebKitAPI::TEST):
3848
3849 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
3850
3851         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
3852         https://bugs.webkit.org/show_bug.cgi?id=174724
3853
3854         Reviewed by Aakash Jain.
3855
3856         * Scripts/webkitpy/port/ios_simulator.py:
3857         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
3858         simulator. Errors here should be treated the same as no simulators found.
3859
3860 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
3861
3862         [CMake] Add an option to stop build after generating project files
3863         https://bugs.webkit.org/show_bug.cgi?id=174664
3864
3865         Reviewed by Konstantin Tokarev.
3866
3867         Add "--generate-project-only" to stop build after generating project files.
3868
3869         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
3870         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
3871         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
3872         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
3873         (isGenerateProjectOnly): ditto
3874
3875 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
3876
3877         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3878         https://bugs.webkit.org/show_bug.cgi?id=174501
3879
3880         Reviewed by Darin Adler.
3881
3882         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3883         (TestWebKitAPI::TEST):
3884
3885 2017-07-20  David Quesada  <david_quesada@apple.com>
3886
3887         Add SPI to notify WKNavigationDelegate about client redirects
3888         https://bugs.webkit.org/show_bug.cgi?id=174680
3889         rdar://problem/33184886
3890
3891         Reviewed by Brady Eidson.
3892
3893         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3894         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
3895         (TEST):
3896         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
3897
3898 2017-07-20  Brady Eidson  <beidson@apple.com>
3899
3900         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
3901         https://bugs.webkit.org/show_bug.cgi?id=174685
3902
3903         Reviewed by Andy Estes.
3904
3905         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3906         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
3907
3908 2017-07-20  Brady Eidson  <beidson@apple.com>
3909
3910         Deprecate WebIconDatabase in WebKitLegacy/mac.
3911         https://bugs.webkit.org/show_bug.cgi?id=174607
3912
3913         Reviewed by Alex Christensen.
3914
3915         * DumpRenderTree/mac/TestRunnerMac.mm:
3916
3917 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
3918
3919         lint-test-expectations should be run during style checking
3920         https://bugs.webkit.org/show_bug.cgi?id=173559
3921         <rdar://problem/32854941>
3922
3923         Reviewed by Aakash Jain.
3924
3925         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3926         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
3927         prevents identifying errors on specific lines in a file.
3928         * Scripts/webkitpy/style/main_unittest.py:
3929         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
3930         case where a linter error is in the file modified, but the line modified is not related to
3931         the linter error.
3932
3933 2017-07-20  Brady Eidson  <beidson@apple.com>
3934
3935         Remove WebIconDatabase from WebKitLegacy/win.
3936         https://bugs.webkit.org/show_bug.cgi?id=174608
3937
3938         Reviewed by Alex Christensen.
3939
3940         * DumpRenderTree/win/DumpRenderTree.cpp:
3941         (main):
3942         * DumpRenderTree/win/TestRunnerWin.cpp:
3943         (TestRunner::setIconDatabaseEnabled):
3944
3945 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
3946
3947         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
3948         https://bugs.webkit.org/show_bug.cgi?id=174671
3949
3950         Reviewed by Carlos Garcia Campos.
3951
3952         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
3953         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
3954         priority for this source in order to have it dispatched on the same
3955         priority as the other WebKit-controlled GSource objects.
3956
3957 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
3958
3959         lint-test-expectations should be run during style checking
3960         https://bugs.webkit.org/show_bug.cgi?id=173559
3961         <rdar://problem/32854941>
3962
3963         Reviewed by Daniel Bates.
3964
3965         Follow up fix addressing style and a few minor bugs.
3966
3967         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3968         (TestExpectationParser.__init__): Use lambda x: x instead of str
3969         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
3970         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
3971         reduce the calls of _shorten_filename, fix minor bug in appending the current
3972         expectation's line number instead of the previous ones, clarify treatment of None
3973         in file-to-line-number mapping.
3974         (TestExpectations._report_warnings): Collapse call.
3975         * Scripts/webkitpy/style/checkers/test_expectations.py:
3976         (TestExpectationsChecker.lint_test_expectations):
3977         * Scripts/webkitpy/style/filereader.py: Re-write comment.
3978         (TextFileReader.process_file): Add comment explaining treatment of None in
3979         file-to-line-number mapping.
3980         (TextFileReader.delete_file): Collapse call.
3981
3982 2017-07-19  Chris Dumez  <cdumez@apple.com>
3983
3984         Unreviewed attempt to fix API test failure after r219663.
3985
3986         The test was hard-coding an exception string and the string has changed slightly
3987         in r219663.
3988
3989         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3990         (TEST):
3991
3992 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
3993
3994         Don't write file URLs to iOS Pasteboard
3995         https://bugs.webkit.org/show_bug.cgi?id=174647
3996         <rdar://problem/33199730>
3997
3998         Reviewed by Wenson Hsieh.
3999
4000         Updating tests to reflect the lack of file URLs for images.
4001
4002         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4003         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
4004         (checkEstimatedSize):
4005         (TestWebKitAPI::TEST):
4006
4007 2017-07-19  Brady Eidson  <beidson@apple.com>
4008
4009         iBooks sometimes crashes when closing a book.
4010         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
4011
4012         Reviewed by Oliver Hunt.
4013
4014         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
4015         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
4016         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
4017         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
4018         (TestWebKitAPI::TEST):
4019
4020         Add a "spin the runloop X number of times" utility:
4021         * TestWebKitAPI/Utilities.h:
4022         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
4023         (TestWebKitAPI::Util::spinRunLoop):
4024
4025 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
4026
4027         lint-test-expectations should be run during style checking
4028         https://bugs.webkit.org/show_bug.cgi?id=173559
4029         <rdar://problem/32854941>
4030
4031         Reviewed by David Kilzer.
4032
4033         Running the test expectation linter requires reading both files and lines not in the
4034         patch because, for example, deletion of a test can cause a lint failure even though
4035         no test expectations where modified. This means that the linter will occasionally warn
4036         about lines which were not changed in a given patch but whose error is related to a
4037         change made in that patch.
4038
4039         * Scripts/webkitpy/common/system/filesystem_mock.py:
4040         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
4041         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4042         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
4043         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
4044         content, description of the error and the name of the associated test.
4045         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
4046         (TestExpectationParser.__init__): Pass shorten_filename function to
4047         TestExpectationsParser to add a deleted file to the related_files dictionary.
4048         (TestExpectationParser._check_test_exists): If the test does not exist, add the
4049         missing path to the related_files dictionary.
4050         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
4051         files and line numbers related to this test expectation line. This will allow
4052         tracking linter errors in the style checker occurring across multiple files.
4053         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
4054         lines to related_files dictionary.
4055         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
4056         (TestExpectations._report_warnings): Construct warning object instead of string
4057         when adding to warnings list.
4058         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
4059         clean-up log.
4060         * Scripts/webkitpy/style/checker.py:
4061         (ProcessorBase.do_association_check): Add required function for processor classes.
4062         (StyleProcessor):
4063         (StyleProcessor.do_association_check): Run the TestExpectations linter when
4064         checking for errors between associated files.
4065         * Scripts/webkitpy/style/checkers/test_expectations.py:
4066         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
4067         (TestExpectationsChecker):
4068         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
4069         of modified files, the current working directory and the host, determine if the linter
4070         warning is associated with the changes.
4071         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
4072         style checker.
4073         * Scripts/webkitpy/style/filereader.py:
4074         (TextFileReader):
4075         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
4076         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
4077         (TextFileReader.process_file): Track both the number of files changed and which lines
4078         in those files were changed.
4079         (TextFileReader.do_association_check): Run the processor's association check on all
4080         modified or deleted files processed by TextFileReader.
4081         (TextFileReader.delete_file): Track deleted files in _files dictionary.
4082         (TextFileReader.count_delete_only_file): Deleted.
4083         * Scripts/webkitpy/style/filereader_unittest.py:
4084         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
4085         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
4086         * Scripts/webkitpy/style/main.py:
4087         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
4088         explicitly run the association check on the file reader.
4089         * Scripts/webkitpy/style/main_unittest.py:
4090         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
4091         embedded in the style checker.
4092         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
4093         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
4094         construct the TextFileReader object with a StyleProcessor used to run style checks on
4095         specific files.
4096         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
4097         testing the test expectation linter inside the style checker. This host must contain a
4098         mock file system with the basic structure of test expectations.
4099         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
4100         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
4101         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
4102         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
4103         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
4104         * Scripts/webkitpy/style/patchreader.py:
4105         (PatchReader.check): Specify which file was deleted, run the association check.
4106         * Scripts/webkitpy/style/patchreader_unittest.py:
4107         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
4108         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
4109         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
4110
4111 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
4112
4113         [WTF] Implement WTF::ThreadGroup
4114         https://bugs.webkit.org/show_bug.cgi?id=174081
4115
4116         Reviewed by Mark Lam.
4117
4118         Add WTF::ThreadGroup tests.
4119
4120         * TestWebKitAPI/CMakeLists.txt:
4121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4122         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
4123         (TestWebKitAPI::testThreadGroup):
4124         (TestWebKitAPI::TEST):
4125
4126 2017-07-18  Andy Estes  <aestes@apple.com>
4127
4128         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
4129         https://bugs.webkit.org/show_bug.cgi?id=174631
4130
4131         Reviewed by Tim Horton.
4132
4133         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4134         * MiniBrowser/Configurations/Base.xcconfig:
4135         * MobileMiniBrowser/Configurations/Base.xcconfig:
4136         * TestWebKitAPI/Configurations/Base.xcconfig:
4137         * WebKitTestRunner/Configurations/Base.xcconfig:
4138
4139 2017-07-18  Andy Estes  <aestes@apple.com>
4140
4141         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
4142         https://bugs.webkit.org/show_bug.cgi?id=174631
4143
4144         Reviewed by Sam Weinig.
4145
4146         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4147         * MiniBrowser/Configurations/Base.xcconfig:
4148         * MobileMiniBrowser/Configurations/Base.xcconfig:
4149         * TestWebKitAPI/Configurations/Base.xcconfig:
4150         * WebKitTestRunner/Configurations/Base.xcconfig:
4151
4152 2017-07-18  Daniel Bates  <dabates@apple.com>
4153
4154         lldb: Add type summary for StringView
4155         https://bugs.webkit.org/show_bug.cgi?id=174637
4156
4157         Reviewed by Sam Weinig.
4158
4159         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
4160         StringView object will print output that has the form:
4161
4162             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
4163               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
4164               m_length = 2
4165               m_is8Bit = true
4166               m_underlyingString = 0x0000614000000a90
4167             }
4168
4169         * lldb/lldb_webkit.py: