[GTK] Add support to load/save session in MiniBrowser
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Add support to load/save session in MiniBrowser
4         https://bugs.webkit.org/show_bug.cgi?id=153201
5
6         Reviewed by Michael Catanzaro.
7
8         It makes it easier to test the new WebView session API.
9
10         * MiniBrowser/gtk/BrowserWindow.c:
11         (browserWindowFinalize): Free the session file path.
12         (browserWindowSaveSession): Save the current WebView session if
13         there's a session file path.
14         (browserWindowDeleteEvent): Call browserWindowSaveSession().
15         (browser_window_load_session): Try to load the session from the
16         given file path, otherwise fall back to homepage and keep the
17         session file to save the session on window close.
18         * MiniBrowser/gtk/BrowserWindow.h:
19         * MiniBrowser/gtk/main.c:
20         (createBrowserWindow): Pass the given session file path when
21         shouldLoadSession is TRUE.
22         (main): Only allow to restore/save session when MiniBrowser is
23         launched without URL arguments.
24
25 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
26
27         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
28
29         Geolocation is no longer allowed for unique origins after r195075.
30
31         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
32         (testWebViewGeolocationPermissionRequests):
33
34 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
35
36         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
37         https://bugs.webkit.org/show_bug.cgi?id=153216
38
39         Reviewed by Michael Catanzaro.
40
41         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
42         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
43
44 2016-01-18  Nan Wang  <n_wang@apple.com>
45
46         AX: [Mac] Implement next/previous text marker functions using TextIterator
47         https://bugs.webkit.org/show_bug.cgi?id=152728
48
49         Reviewed by Chris Fleizach.
50
51         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
52         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
53
54 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
55
56         [cmake] Add testair to the build system
57         https://bugs.webkit.org/show_bug.cgi?id=153126
58
59         Reviewed by Michael Catanzaro.
60
61         * Scripts/build-jsc:
62
63 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
64
65         Remove TextRun::allowsRoundingHacks()
66         https://bugs.webkit.org/show_bug.cgi?id=153185
67
68         Reviewed by Simon Fraser.
69
70         * DumpRenderTree/mac/DumpRenderTree.mm:
71         (resetWebViewToConsistentStateBeforeTesting): Deleted.
72
73 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
74
75         [webkitdirs] Avoid list form of open because it broke WinCairo
76         https://bugs.webkit.org/show_bug.cgi?id=153106
77
78         Reviewed by Alex Christensen.
79
80         * Scripts/webkitdirs.pm:
81         (determineArchitecture):
82
83 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
84
85         Add kdebug_trace signposts for a few WebCore operations
86         https://bugs.webkit.org/show_bug.cgi?id=153136
87         rdar://problem/24208487
88
89         Reviewed by Sam Weinig.
90         
91         Plist used by kdebug_trace() viewing tools.
92
93         * Tracing/SystemTracePoints.plist: Added.
94
95 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
96
97         [webkitdirs] Replaced grep invocation with perl code
98         https://bugs.webkit.org/show_bug.cgi?id=153106
99
100         Reviewed by Alex Christensen.
101
102         * Scripts/webkitdirs.pm:
103         (determineArchitecture):
104
105 2016-01-14  Brian Burg  <bburg@apple.com>
106
107         prepare-changelog does not read paths containing spaces properly
108         https://bugs.webkit.org/show_bug.cgi?id=137982
109
110         Reviewed by Joseph Pecoraro.
111
112         Escape whitespace in filenames before passing the file path to other functions.
113
114         * Scripts/prepare-ChangeLog:
115         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
116
117 2016-01-14  Jason Marcell  <jmarcell@apple.com>
118
119         Standardize the usage of "branch" vs. "branchName".
120         https://bugs.webkit.org/show_bug.cgi?id=152982
121
122         Reviewed by Daniel Bates.
123
124         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
125         "branchName" implies that the variable or property in question is simply a string.
126
127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
128         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
129         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
130         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
131         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
132         (Trac.prototype.commitsOnBranch): Change branch to branchName.
133         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
135         (MockTrac): Ditto.
136
137 2016-01-14  Jason Marcell  <jmarcell@apple.com>
138
139         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
140         https://bugs.webkit.org/show_bug.cgi?id=152910
141
142         Reviewed by Daniel Bates.
143
144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
145         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
146         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
147         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
148         the need to talk to a real Buildbot server.
149         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
150         without the need to talk to a real Buildbot server.
151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
152         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
153         server.
154         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
155         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
156         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
157         trying to talk to Trac.
158         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
159         QUnit unit tests.
160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
161
162 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
163
164         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
165         https://bugs.webkit.org/show_bug.cgi?id=132599
166
167         Reviewed by Michael Catanzaro.
168
169         Check if cmake Ninja generators are installed.
170
171         * Scripts/webkitdirs.pm:
172         (canUseNinjaGenerator):
173         (canUseEclipseNinjaGenerator):
174         (generateBuildSystemFromCMakeProject):
175         (canUseEclipse): Deleted.
176
177 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
178
179         [Cocoa] Testing with font family name "System Font" is unused
180         https://bugs.webkit.org/show_bug.cgi?id=153073
181         <rdar://problem/24091683>
182
183         Reviewed by Brent Fulgham.
184
185         * DumpRenderTree/mac/DumpRenderTree.mm:
186         (allowedFontFamilySet): Deleted.
187         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
188         (WTR::allowedFontFamilySet): Deleted.
189         * WebKitTestRunner/mac/TestControllerMac.mm:
190         (WTR::allowedFontFamilySet): Deleted.
191
192 2016-01-13  Daniel Bates  <dabates@apple.com>
193
194         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
195         https://bugs.webkit.org/show_bug.cgi?id=152871
196
197         Reviewed by Brent Fulgham.
198
199         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
200         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
201
202         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
203
204 2016-01-08  Andy Estes  <aestes@apple.com>
205
206         [Content Filtering] Lazily load platform frameworks
207         https://bugs.webkit.org/show_bug.cgi?id=152881
208         rdar://problem/23270886
209
210         Reviewed by Brady Eidson.
211
212         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
213         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
214         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
215         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
216         is loaded after an HTTPS request.
217
218         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
219         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
220         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
221         also re-enabled on iOS after mistakenly being disabled by r188892.
222
223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
224         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
225         (TestWebKitAPI::TEST):
226         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
227         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
228         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
229         (TEST):
230         (downloadTest):
231         (-[LazilyLoadPlatformFrameworksController init]):
232         (-[LazilyLoadPlatformFrameworksController webView]):
233         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
234         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
235         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
236         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
237         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
238         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
239         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
240         (TestWebKitAPI::TEST):
241         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
242         (TestWebKitAPI::TEST): Deleted.
243         * TestWebKitAPI/cocoa/TestProtocol.h:
244         * TestWebKitAPI/cocoa/TestProtocol.mm:
245         (+[TestProtocol registerWithScheme:]):
246         (+[TestProtocol unregister]):
247
248 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
249
250         Fix the Sunpider converage in slow device.
251         https://bugs.webkit.org/show_bug.cgi?id=152938
252         <rdar://problem/22511411>
253
254         Reviewed by Ryosuke Niwa.
255
256         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
257
258         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
259
260 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
261
262         Add a build flag for custom element
263         https://bugs.webkit.org/show_bug.cgi?id=153005
264
265         Reviewed by Alex Christensen.
266
267         Added --custom-elements option to enable custom elements support.
268
269         * Scripts/webkitperl/FeatureList.pm:
270
271 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
272
273         [JSC] Add a help message when run-jsc-stress-tests fails
274         https://bugs.webkit.org/show_bug.cgi?id=153014
275
276         Reviewed by Csaba Osztrogonác.
277
278         * Scripts/run-jsc-stress-tests:
279
280 2016-01-11  Saam barati  <sbarati@apple.com>
281
282         run-jsc-stress-tests should try to figure out a JSC path
283         https://bugs.webkit.org/show_bug.cgi?id=152971
284
285         Reviewed by Yusuke Suzuki.
286
287         This patch now allows run-jsc-stress-tests to be run
288         without a "--jsc <jsc-path>" argument. It tries
289         to take its best guess at a <jsc-path> automagically.
290         
291         This makes it much easier to just run run-jsc-stress-tests
292         with a directory or a yaml file as an argument.
293         You now just do this:
294         `run-jsc-stress-tests <path-to-yaml>`
295         or
296         `run-jsc-stress-tests <path-to-directory-of-js-files>`
297         
298         I wrote this patch because I'd often find myself hacking the 
299         run-javascriptcore-tests file just to run a particular subset of tests.
300         Because I always forget the arguments to run-jsc-stress-tests (which means
301         I always forgot to provide a --jsc argument), I always found it easier to 
302         just hack on that file instead of calling run-jsc-stress-tests directly.
303         No longer is this true!
304
305         * Scripts/run-jsc-stress-tests:
306
307 2016-01-09  Andy Estes  <aestes@apple.com>
308
309         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
310         https://bugs.webkit.org/show_bug.cgi?id=152950
311         rdar://problem/24066652
312
313         Reviewed by Tim Horton.
314
315         Added an API test.
316
317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
318         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
319         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
320         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
321         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
322         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
323         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
324         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
325         (TEST):
326
327 2016-01-11  Commit Queue  <commit-queue@webkit.org>
328
329         Unreviewed, rolling out r194866.
330         https://bugs.webkit.org/show_bug.cgi?id=152986
331
332         This change broke the mac build (Requested by ryanhaddad on
333         #webkit).
334
335         Reverted changeset:
336
337         "[Cocoa] Add SPI to opt out a URL scheme from the memory
338         cache"
339         https://bugs.webkit.org/show_bug.cgi?id=152950
340         http://trac.webkit.org/changeset/194866
341
342 2016-01-11  Andy Estes  <aestes@apple.com>
343
344         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
345         https://bugs.webkit.org/show_bug.cgi?id=152950
346         rdar://problem/24066652
347
348         Reviewed by Tim Horton.
349
350         Added an API test.
351
352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
353         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
354         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
355         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
356         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
357         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
358         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
359         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
360         (TEST):
361
362 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
363
364         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
365         https://bugs.webkit.org/show_bug.cgi?id=152959
366
367         Reviewed by Brent Fulgham.
368
369         * Scripts/webkitdirs.pm:
370         (determineArchitecture):
371
372 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
373
374         [GTK] W3C CSS2.1 anonymous table tests are failing
375         https://bugs.webkit.org/show_bug.cgi?id=152455
376
377         Reviewed by Mario Sanchez Prada.
378
379         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
380         tests. Add upstream patches to fix detection of XHTML files.
381
382         * gtk/jhbuild.modules:
383         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
384         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
385
386 2016-01-10  Saam barati  <sbarati@apple.com>
387
388         Implement a sampling profiler
389         https://bugs.webkit.org/show_bug.cgi?id=151713
390
391         Reviewed by Filip Pizlo.
392
393         * Scripts/run-jsc-stress-tests:
394
395 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
396
397         [webkitdirs] Try arch and uname commands on non-windows OS
398         https://bugs.webkit.org/show_bug.cgi?id=152958
399
400         Reviewed by Michael Catanzaro.
401
402         Right now, determineArchitecture()  uses `arch` and `uname -m`
403         commands to determine architecture in case of condition (isGtk() ||
404         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
405         instead, because this code is applicable to any non-windows OS WebKit
406         supports (even Haiku which once was supported is moderately
407         POSIX-compliant and has uname command).
408
409         * Scripts/webkitdirs.pm:
410         (determineArchitecture):
411
412 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
413
414         run-webkit-tests mis-counts totals when there are other crashes
415         https://bugs.webkit.org/show_bug.cgi?id=152894
416         <rdar://problem/24098697>
417
418         Reviewed by Alexey Proskuryakov.
419
420         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
421         (TestRunResults.add): Do not update result counters for other crashes.
422
423 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
424
425         webkit-patch build-and-test should have an option to iterate over new tests
426         https://bugs.webkit.org/show_bug.cgi?id=143093
427
428         Reviewed by Michael Catanzaro.
429
430         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
431         It allows running run-webkit-tests on modified or new paths in LayoutTests.
432         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
433         It implements the translation of -expected.* paths to their related tests.
434         It also implements the removal of skipped tests.
435
436         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
437         (LayoutTestFinder.find_touched_tests):
438         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
439         (MockPort):
440         (MockPort.__init__):
441         (MockPort.tests):
442         (LayoutTestFinderTests):
443         (LayoutTestFinderTests.touched_files):
444         (LayoutTestFinderTests.test_touched_test):
445         (LayoutTestFinderTests.test_expected_touched_test):
446         (LayoutTestFinderTests.test_platform_expected_touched_test):
447         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
448         (LayoutTestFinderTests.test_touched_but_skipped_test):
449         * Scripts/webkitpy/port/base.py:
450         (Port.potential_test_names_from_expected_file):
451         * Scripts/webkitpy/tool/commands/download_unittest.py:
452         (DownloadCommandsTest._default_options):
453         * Scripts/webkitpy/tool/steps/options.py:
454         (Options):
455         * Scripts/webkitpy/tool/steps/runtests.py:
456         (RunTests.options):
457         (RunTests.run):
458         (RunTests):
459         (RunTests._new_or_modified_tests):
460         (RunTests._run_webkit_tests):
461         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
462         (RunTestsTest.test_webkit_run_unit_tests):
463         * Scripts/webkitpy/tool/steps/steps_unittest.py:
464         (StepsTest._step_options):
465
466 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
467
468         prepare-ChangeLog should include radar number
469         https://bugs.webkit.org/show_bug.cgi?id=152839
470         <rdar://problem/24093563>
471
472         Reviewed by Daniel Bates.
473
474         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
475         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
476         in the ChangeLog description after the bug URL.
477
478         * Scripts/prepare-ChangeLog:
479         (main): Update signatures.
480         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
481         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
482         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
483         (generateNewChangeLogs): Include radar URL if we found one.
484
485         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
486         Tests for the radar URL extraction.
487
488 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
489
490         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
491         https://bugs.webkit.org/show_bug.cgi?id=152390
492         <rdar://problem/23948321>
493
494         Reviewed by Simon Fraser.
495
496         Fix two use-after-frees.
497
498         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
499         but we may have already progressed to another test by the time the callback fires,
500         having destroyed the TestInvocation.
501         2. UIScriptController is a RefCounted object, but it has a raw pointer to
502         UIScriptContext which has the same lifetime as a TestInvocation.
503         As a result, completion blocks of UIScriptController actions would use a destroyed
504         TestInvocation.
505
506         * WebKitTestRunner/TestInvocation.cpp:
507         (WTR::TestInvocation::~TestInvocation):
508         (WTR::TestInvocation::url):
509         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
510         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
511         (WTR::TestInvocation::runUISideScript):
512         * WebKitTestRunner/TestInvocation.h:
513         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
514         (UIScriptContext::UIScriptContext):
515         (UIScriptContext::~UIScriptContext):
516         (UIScriptContext::runUIScript):
517         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
518         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
519         (WTR::UIScriptController::UIScriptController):
520         (WTR::UIScriptController::contextDestroyed):
521         (WTR::UIScriptController::makeWindowObject):
522         (WTR::UIScriptController::setWillBeginZoomingCallback):
523         (WTR::UIScriptController::willBeginZoomingCallback):
524         (WTR::UIScriptController::setDidEndZoomingCallback):
525         (WTR::UIScriptController::didEndZoomingCallback):
526         (WTR::UIScriptController::setDidEndScrollingCallback):
527         (WTR::UIScriptController::didEndScrollingCallback):
528         (WTR::UIScriptController::setDidShowKeyboardCallback):
529         (WTR::UIScriptController::didShowKeyboardCallback):
530         (WTR::UIScriptController::setDidHideKeyboardCallback):
531         (WTR::UIScriptController::didHideKeyboardCallback):
532         (WTR::UIScriptController::uiScriptComplete):
533         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
534         (WTR::UIScriptController::create):
535         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
536         (WTR::UIScriptController::doAsyncTask):
537         (WTR::UIScriptController::zoomToScale):
538         (WTR::UIScriptController::singleTapAtPoint):
539         (WTR::UIScriptController::doubleTapAtPoint):
540         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
541         (WTR::UIScriptController::contentVisibleRect):
542         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
543         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
544         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
545         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
546         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
547         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
548         (WTR::UIScriptController::doAsyncTask):
549
550 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
551
552         [buildbot] clean-build script should remove untracked files and revert local changes too
553         https://bugs.webkit.org/show_bug.cgi?id=142400
554
555         Reviewed by Ryosuke Niwa.
556
557         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
558         A helper routine SCM.discard_untracked_files is added for that purpose.
559
560         * BuildSlaveSupport/clean-build:
561         (main): Making call to Scripts/clean-webkit
562         * Scripts/clean-webkit: Added.
563         (main): Revert changes and delete untracked files.
564         * Scripts/webkitpy/common/checkout/scm/scm.py:
565         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
566         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
567         (SCMTest._shared_test_discard_untracked_files):
568         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
569
570 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
571
572         Add a setting and preferences to enable display-list drawing. Does nothing yet.
573         https://bugs.webkit.org/show_bug.cgi?id=152807
574
575         Reviewed by Zalan Bujtas.
576         
577         Add an item to the Settings menu to toggle display-list drawing.
578
579         * MiniBrowser/mac/SettingsController.h:
580         * MiniBrowser/mac/SettingsController.m:
581         (-[SettingsController _populateMenu]):
582         (-[SettingsController validateMenuItem:]):
583         (-[SettingsController toggleDisplayListDrawingEnabled:]):
584         (-[SettingsController displayListDrawingEnabled]):
585         * MiniBrowser/mac/WK2BrowserWindowController.m:
586         (-[WK2BrowserWindowController didChangeSettings]):
587
588 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
589
590         Python SCM should be able to retrieve untracked files - Add GIT support
591         https://bugs.webkit.org/show_bug.cgi?id=143135
592
593         Reviewed by Michael Catanzaro.
594
595         * Scripts/webkitpy/common/checkout/scm/git.py:
596         (Git.untracked_files): Adding support for git.
597         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
598         (GitTest.setUp):
599         (GitTest.test_untracked_files): Adding test.
600
601 2016-01-05  Mark Lam  <mark.lam@apple.com>
602
603         Rename badly named JSC_timeout env var to JSCTEST_timeout.
604         https://bugs.webkit.org/show_bug.cgi?id=152748
605
606         Reviewed by Geoffrey Garen.
607
608         Now that we validate JSC options, the badly named JSC_timeout env var causes the
609         bots to have a bad time.
610
611         * Scripts/run-javascriptcore-tests:
612         * Scripts/run-jsc-stress-tests:
613
614 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
615
616         [GTK] Allow to save and restore session
617         https://bugs.webkit.org/show_bug.cgi?id=115600
618
619         Reviewed by Michael Catanzaro.
620
621         Add test case to check the new session API.
622
623         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
624         (testWebKitWebViewSessionState):
625         (testWebKitWebViewSessionStateWithFormData):
626         (beforeAll):
627
628 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
629
630         [EFL] Bump EFL version to 1.16.1
631         https://bugs.webkit.org/show_bug.cgi?id=152688
632
633         Reviewed by Gyuyoung Kim.
634
635         * efl/jhbuild.modules:
636
637 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
638
639         error running layout tests on iOS simulator on latest build
640         https://bugs.webkit.org/show_bug.cgi?id=152719
641         <rdar://problem/24009549>
642
643         Reviewed by Alexey Proskuryakov.
644
645         * Scripts/webkitpy/xcode/simulator.py:
646         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
647           before running simctl spawn command.
648
649 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
650
651         Unreviewed, move Frédéric Wang to committers list
652
653         He seems to be on the contributors list by accident. He has been landing his own commits for
654         about two years now.
655
656         * Scripts/webkitpy/common/config/contributors.json:
657
658 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
659
660         Unreviewed, move Sebastian Dröge to committers list harder
661
662         He accidentally added himself to the reviewers list because the file is confusing. Then I
663         accidentially moved him to the contributors list because the file is confusing, even though
664         I knew the contributors list existed in this file and was attempting to add him to the
665         committers list. Really move him to the committers list now.
666
667         * Scripts/webkitpy/common/config/contributors.json:
668
669 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
670
671         Python SCM should be able to retrieve untracked files - Add SVN support
672         https://bugs.webkit.org/show_bug.cgi?id=152546
673
674         Reviewed by Michael Catanzaro.
675
676         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
677         (test_untracked_files): Activating test for SVN.
678         * Scripts/webkitpy/common/checkout/scm/svn.py:
679         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
680
681 2015-12-31  Andy Estes  <aestes@apple.com>
682
683         Replace WTF::move with WTFMove
684         https://bugs.webkit.org/show_bug.cgi?id=152601
685
686         Reviewed by Brady Eidson.
687
688         * DumpRenderTree/TestRunner.h:
689         (TestRunner::setAllowedHosts):
690         * DumpRenderTree/win/DRTDataObject.cpp:
691         (DRTDataObject::SetData):
692         * TestWebKitAPI/Tests/WTF/Deque.cpp:
693         (TestWebKitAPI::TEST):
694         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
695         (TestWebKitAPI::TEST):
696         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
697         (TestWebKitAPI::TEST):
698         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
699         (TestWebKitAPI::TEST):
700         * TestWebKitAPI/Tests/WTF/Ref.cpp:
701         (TestWebKitAPI::passWithRef):
702         (TestWebKitAPI::TEST):
703         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
704         (TestWebKitAPI::TEST):
705         * TestWebKitAPI/Tests/WTF/Vector.cpp:
706         (TestWebKitAPI::TEST):
707         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
708         (TestWebKitAPI::TEST):
709         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
710         (TestWebKitAPI::TEST):
711         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
712         (TestWebKitAPI::createTestValue):
713         (TestWebKitAPI::TEST):
714         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
715         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
716         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
717         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
718         (TestWebKitAPI::createNFAs):
719         (TestWebKitAPI::TEST_F):
720         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
721         (TestWebKitAPI::combine):
722         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
723         (TestWebKitAPI::createNFAs):
724         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
725         (TEST):
726         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
727         (WebProcessTest::add):
728
729 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
730
731         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
732         https://bugs.webkit.org/show_bug.cgi?id=152634
733
734         Reviewed by Carlos Garcia Campos.
735
736         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
737         (testLoadFromGResource): Added test.
738         (beforeAll):
739         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
740         (registerGResource): Added.
741         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
742         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
743         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
744
745 2015-12-31  David Kilzer  <ddkilzer@apple.com>
746
747         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
748         <https://bugs.webkit.org/show_bug.cgi?id=152601>
749
750         Ignore unknown pragmas on older clangs.  Fixes the following
751         build failure:
752
753             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
754             #pragma clang diagnostic ignored "-Wself-move"
755                                              ^
756             1 error generated.
757
758         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
759         (TestWebKitAPI::TEST):
760         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
761         (TestWebKitAPI::TEST):
762
763 2015-12-31  Andy Estes  <aestes@apple.com>
764
765         Update the style checker to advise using WTFMove() instead of WTF::move()
766         https://bugs.webkit.org/show_bug.cgi?id=152601
767
768         Reviewed by Daniel Bates.
769
770         * Scripts/webkitpy/style/checkers/cpp.py:
771         (check_wtf_move):
772         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
773         (WebKitStyleTest.test_wtf_move):
774
775 2015-12-31  Andy Estes  <aestes@apple.com>
776
777         Fix warnings uncovered by migrating to WTF_MOVE
778         https://bugs.webkit.org/show_bug.cgi?id=152601
779
780         Reviewed by Daniel Bates.
781
782         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
783         self-move, even if doing so would trigger a warning.
784
785         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
786         (TestWebKitAPI::TEST):
787         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
788         (TestWebKitAPI::TEST):
789
790 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
791
792         [GTK] The install-dependencies script has a syntax error
793         https://bugs.webkit.org/show_bug.cgi?id=152613
794
795         Reviewed by Michael Catanzaro.
796
797         * gtk/install-dependencies: Add the missing 'then.'
798
799 2015-12-30  Philippe Normand  <pnormand@igalia.com>
800
801         [Mac][GTK] Jhbuild support for OSX
802         https://bugs.webkit.org/show_bug.cgi?id=150799
803
804         Reviewed by Michael Catanzaro.
805
806         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
807         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
808         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
809         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
810
811 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
812
813         Unreviewed, move Sebastian Dröge to committers list
814
815         He accidentally added himself to the reviewers list because the file is confusing.
816
817         * Scripts/webkitpy/common/config/contributors.json:
818
819 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
820
821         Remove the unused #define _USE_MATH_DEFINES
822         https://bugs.webkit.org/show_bug.cgi?id=152034
823
824         Reviewed by Tim Horton.
825         
826         Update this test to use piDouble from MathExtras.h, and
827         std::numeric_limits<>.
828
829         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
830
831 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
832
833         Python SCM should be able to retrieve untracked files - Generic changes
834         https://bugs.webkit.org/show_bug.cgi?id=152536
835
836         Reviewed by Brent Fulgham.
837
838         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
839         No support is yet added to GIT and SVN specific implementations.
840
841         * Scripts/webkitpy/common/checkout/scm/scm.py:
842         (SCM.untracked_files):
843         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
844         (SCMTest._shared_test_untracked_files):
845
846 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
847
848         SVN checkout used by RunBenchmark should be non-interactive
849         https://bugs.webkit.org/show_bug.cgi?id=152542
850
851         Reviewed by Ryosuke Niwa.
852
853         RunBenchmark should not require user interaction while running.
854
855         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
856         (BenchmarkBuilder._checkout_with_subversion):
857
858 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
859
860         Web Inspector: add support for running protocol-test.js tests on Windows
861         https://bugs.webkit.org/show_bug.cgi?id=148037
862         <rdar://problem/22292237>
863
864         Reviewed by Simon Fraser.
865
866         * DumpRenderTree/win/TestRunnerWin.cpp:
867         (TestRunner::inspectorTestStubURL): Provide implementation.
868
869 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
870
871         [MediaStream] MediaDeviceInfo.label must be empty in some situations
872         https://bugs.webkit.org/show_bug.cgi?id=152000
873
874         Reviewed by Brent Fulgham.
875
876         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
877         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
878         (WTR::InjectedBundle::setUserMediaPermission):
879         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
880         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
881
882         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
883         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
884         * WebKitTestRunner/InjectedBundle/TestRunner.h:
885
886         * WebKitTestRunner/TestController.cpp:
887         (WTR::TestController::setUserMediaPermissionForOrigin):
888         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
889         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
890           persistent permission for origin, that can be done from script now.
891         * WebKitTestRunner/TestController.h:
892
893         * WebKitTestRunner/TestInvocation.cpp:
894         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
895           SetUserMediaPermissionForOrigin.
896
897 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
898
899         [Win] Unreviewed build fix: Recognize Windows 10 variants.
900
901         * Scripts/webkitpy/common/system/platforminfo.py:
902         (PlatformInfo._determine_win_version):
903
904 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
905
906         Content blockers should be able to promote http to https
907         https://bugs.webkit.org/show_bug.cgi?id=148966
908
909         Reviewed by Benjamin Poulain.
910
911         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
912         (WebCore::ContentExtensions::operator<<):
913         (TestWebKitAPI::TEST_F):
914
915 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
916
917         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
918         https://bugs.webkit.org/show_bug.cgi?id=152516
919
920         Reviewed by Gyuyoung Kim.
921
922         * MiniBrowser/efl/main.c:
923
924 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
925
926         Unreviewed: Add John Wilander as a contributor.
927
928         * Scripts/webkitpy/common/config/contributors.json:
929
930 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
931
932         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
933         https://bugs.webkit.org/show_bug.cgi?id=152482
934
935         Reviewed by Brent Fulgham.
936
937         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
938         for the same property. On WK2, the element returned will not be valid, but is still present and
939         that can lead to looping.
940
941         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
942         (AccessibilityUIElement::horizontalScrollbar):
943         (AccessibilityUIElement::verticalScrollbar):
944         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
945         (WTR::AccessibilityUIElement::horizontalScrollbar):
946         (WTR::AccessibilityUIElement::verticalScrollbar):
947
948 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
949
950         Unreviewed.
951
952         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
953
954 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
955
956         [EFL] test_ewk2_context failed after r192808
957         https://bugs.webkit.org/show_bug.cgi?id=151846
958
959         Reviewed by Gyuyoung Kim.
960
961         Used the added ewk_context_web_process_count_limit_set api
962         instead of the deprecated ewk_context_process_model_set.
963
964         * MiniBrowser/efl/main.c:
965         (elm_main):
966
967 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
968
969         Unreviewed, move myself to reviewer list.
970
971         * Scripts/webkitpy/common/config/contributors.json:
972
973 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
974
975         Unreviewed, add myself to the committers list.
976
977         * Scripts/webkitpy/common/config/contributors.json:
978
979 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
980
981         [GTK] jquery.min.js violates DFSG
982         https://bugs.webkit.org/show_bug.cgi?id=152428
983
984         Reviewed by Joseph Pecoraro.
985
986         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
987         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
988
989         * gtk/manifest.txt.in:
990
991 2015-12-19  Dan Bernstein  <mitz@apple.com>
992
993         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
994         https://bugs.webkit.org/show_bug.cgi?id=152462
995
996         Reviewed by Alexey Proskuryakov.
997
998         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
999           OS X 10.9:
1000
1001         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1002         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1003         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1004         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1005         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1006
1007         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1008           never getting compiled:
1009
1010         * DumpRenderTree/mac/TextInputController.m:
1011         * MiniBrowser/mac/BrowserWindowController.m:
1012         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1013         * WebKitTestRunner/mac/EventSenderProxy.mm:
1014
1015 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
1016
1017         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1018
1019         This is to make it easy to CC it on Bugzilla.
1020
1021         * Scripts/webkitpy/common/config/contributors.json:
1022
1023 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
1024
1025         Pasteboard get messed up after running kill-old-processes
1026         https://bugs.webkit.org/show_bug.cgi?id=152426
1027
1028         Reviewed by Alexey Proskuryakov.
1029
1030         * BuildSlaveSupport/kill-old-processes:
1031         (main): Do not kill pasteboard anymore.
1032
1033 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1034
1035         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1036         https://bugs.webkit.org/show_bug.cgi?id=152157
1037         <rdar://problem/23851817>
1038
1039         Reviewed by Alexey Proskuryakov.
1040
1041         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1042         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1043         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1044         (Manager._get_test_inputs): Common method to calculate test_inputs.
1045         (Manager._update_worker_count): Calculate and update required number of workers.
1046
1047 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1048
1049         run-webkit-tests fails to delete Simulator device during cleanup
1050         https://bugs.webkit.org/show_bug.cgi?id=152363
1051
1052         Reviewed by Alexey Proskuryakov.
1053
1054         * Scripts/webkitpy/xcode/simulator.py:
1055         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1056
1057 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1058
1059         [mac-wk2] fast/events force click tests crashing
1060         https://bugs.webkit.org/show_bug.cgi?id=152339
1061
1062         Reviewed by Beth Dakin.
1063
1064         * WebKitTestRunner/mac/EventSenderProxy.mm:
1065         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1066         Set the NSEvent's _type member in addition to overriding -type,
1067         because there are assertions in touch event handling code that depend on it.
1068
1069 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1070
1071         Enforce temporarily bots to sync WebKit and WPT testharness.js
1072         https://bugs.webkit.org/show_bug.cgi?id=152334
1073
1074         Reviewed by Darin Adler.
1075
1076         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1077         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1078
1079 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1080
1081         [Fetch API] Add fetch API compile time flag
1082         https://bugs.webkit.org/show_bug.cgi?id=152254
1083
1084         Reviewed by Darin Adler.
1085
1086         * Scripts/webkitperl/FeatureList.pm:
1087
1088 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1089
1090         Unreviewed.
1091
1092         Added files that have impact in building Streams API to the watchlist.
1093
1094         * Scripts/webkitpy/common/config/watchlist:
1095
1096 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1097
1098         Unreviewed.
1099
1100         Added imported tests to Streams API watchlist.
1101
1102         * Scripts/webkitpy/common/config/watchlist:
1103
1104 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1105
1106         Remove default copy of wpt testharness.js when launching wpt server
1107         https://bugs.webkit.org/show_bug.cgi?id=152298
1108
1109         Reviewed by Darin Adler.
1110
1111         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1112         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1113
1114 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1115
1116         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1117         <http://webkit.org/b/152314>
1118
1119         Reviewed by Daniel Bates.
1120
1121         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1122         code path to exit immediately when calling main().
1123         Unfortunately, DumpRenderTreeMain.mm was used for both
1124         DumpRenderTree command-line binary and DumpRenderTree.app, which
1125         meant that the app would exit immediately with no error code
1126         when run!
1127
1128         The workaround is to introduce a separate source file called
1129         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1130         already does.
1131
1132         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1133         DumpRenderTreeAppMain.mm to the project.  Make it the only
1134         compiled source for the DumpRenderTree.app target.
1135         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1136         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1137         case someone tries mistakenly to use the app.
1138         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1139         Link to JavaScriptCore.framework on iOS for the assert.
1140         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1141         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1142         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1143         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1144         (main): Add assert for iOS so that a crash occurs if someone
1145         tries to run the wrong command.
1146
1147 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1148
1149         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1150         https://bugs.webkit.org/show_bug.cgi?id=152266
1151         <rdar://problem/22092676>
1152
1153         Reviewed by Simon Fraser.
1154
1155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1156         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1157         Add a test that crashed before this change, and doesn't crash after.
1158
1159 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1160
1161         AX: iOS: Text field variations do not have the correct traits
1162         https://bugs.webkit.org/show_bug.cgi?id=152237
1163
1164         Reviewed by Mario Sanchez Prada.
1165
1166         Add iOS calls for determing if an object is a search field or a text area.
1167
1168         * DumpRenderTree/AccessibilityUIElement.cpp:
1169         (getIsSearchFieldCallback):
1170         (getIsTextAreaCallback):
1171         (stringForSelectionCallback):
1172         (AccessibilityUIElement::getJSClass):
1173         * DumpRenderTree/AccessibilityUIElement.h:
1174         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1175         (AccessibilityUIElement::identifier):
1176         (AccessibilityUIElement::isTextArea):
1177         (AccessibilityUIElement::isSearchField):
1178         (AccessibilityUIElement::traits):
1179         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1180         (WTR::AccessibilityUIElement::scrollPageRight):
1181         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1182         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1183         (WTR::AccessibilityUIElement::isSearchField):
1184         (WTR::AccessibilityUIElement::isTextArea):
1185         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1186         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1187         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1188         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1189         (WTR::AccessibilityUIElement::isTextArea):
1190         (WTR::AccessibilityUIElement::isSearchField):
1191         (WTR::AccessibilityUIElement::rowCount):
1192
1193 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1194
1195         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1196         https://bugs.webkit.org/show_bug.cgi?id=152252
1197
1198         Reviewed by Sergio Villar Senin.
1199
1200         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1201         for building the JHBuild on Debian systems.
1202
1203 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1204
1205         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1206         https://bugs.webkit.org/show_bug.cgi?id=152156
1207
1208         Reviewed by Dan Bernstein.
1209
1210         Our frameworks should appropriately prefix all ObjC classes,
1211         not just external symbols.
1212
1213         * Scripts/check-for-inappropriate-objc-class-names:
1214         Remove the -g switch to check all ObjC class names.
1215
1216 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1217
1218         [MediaStream] Expose media capture devices persistent permissions to WebCore
1219         https://bugs.webkit.org/show_bug.cgi?id=152087
1220
1221         Add support for the new user media permission checker page UI client method.
1222
1223         Reviewed by Chris Dumez.
1224
1225         * WebKitTestRunner/TestController.cpp:
1226         (WTR::decidePolicyForUserMediaPermissionRequest):
1227         (WTR::checkUserMediaPermissionForOrigin):
1228         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1229         (WTR::TestController::createWebViewWithOptions): Ditto.
1230         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1231         (WTR::originUserVisibleName): New, create a string for the origin.
1232         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1233           according to the state of the origin permission map.
1234         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1235           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1236         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1237           origin permission map.
1238         * WebKitTestRunner/TestController.h:
1239
1240 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1241
1242         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1243         https://bugs.webkit.org/show_bug.cgi?id=152022
1244         rdar://problem/23763584
1245
1246         Reviewed by Darin Adler.
1247
1248         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1249         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1250         (WTR::InjectedBundlePage::willSendRequestForFrame):
1251         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1252         (WTR::TestRunner::setWillSendRequestReturnsNull):
1253         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1254         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1255         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1256         (WTR::TestRunner::willSendRequestHTTPBody):
1257         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1258
1259 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1260
1261         Remove additional simulator checks before running layout-tests
1262         https://bugs.webkit.org/show_bug.cgi?id=152146
1263
1264         Reviewed by Darin Adler.
1265
1266         * Scripts/webkitpy/port/ios.py:
1267         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1268         * Scripts/webkitpy/xcode/simulator.py:
1269         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1270         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1271
1272 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1273
1274         Run atleast one simulator even if max process limit is low
1275         https://bugs.webkit.org/show_bug.cgi?id=152081
1276         <rdar://problem/23819694>
1277
1278         Reviewed by Alexey Proskuryakov.
1279
1280 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1281
1282         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1283         https://bugs.webkit.org/show_bug.cgi?id=144262
1284
1285         Reviewed by Carlos Garcia Campos.
1286
1287         Added new unit test to check the additional scenarios we now
1288         handle for custom URI schemes.
1289
1290         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1291         (generateHTMLContent): New helper function to generate big enough content.
1292         (testWebContextURIScheme): New unit test.
1293
1294 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1295
1296         [EFL] Fix unhandled web process message when launching MiniBrowser
1297         https://bugs.webkit.org/show_bug.cgi?id=152048
1298
1299         Reviewed by Gyuyoung Kim.
1300
1301         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1302         (TestWebKitAPI::TEST):
1303
1304 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1305
1306         [GTK] Add API to handle beforeunload events
1307         https://bugs.webkit.org/show_bug.cgi?id=139090
1308
1309         Reviewed by Gustavo Noronha Silva.
1310
1311         * MiniBrowser/gtk/BrowserWindow.c:
1312         (browserWindowConstructed):
1313         (browserWindowDeleteEvent):
1314         (browser_window_class_init):
1315         Handle delete-event to prevent the window from being closed when
1316         the page has beforeunload handlers. Use
1317         webkit_web_view_try_close() when the window is requested to be
1318         closed.
1319         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1320         (testWebViewJavaScriptDialogs):
1321         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1322         script dialog type.
1323
1324 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1325
1326         Refactored initialization code in LoadTrackingTest.
1327
1328         Rubber-stamped by Carlos Garcia Campos.
1329
1330         Small refactoring to make sure that the state of a LoadTrackingTest
1331         gets properly reset before loading new web content.
1332
1333         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1334         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1335         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1336         functions and reset the remaining local variables.
1337         (LoadTrackingTest::loadURI): Call reset();
1338         (LoadTrackingTest::loadHtml): Ditto.
1339         (LoadTrackingTest::loadPlainText): Ditto.
1340         (LoadTrackingTest::loadBytes): Ditto.
1341         (LoadTrackingTest::loadRequest): Ditto.
1342         (LoadTrackingTest::reload): Ditto.
1343         (LoadTrackingTest::goBack): Ditto.
1344         (LoadTrackingTest::goForward): Ditto.
1345
1346 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1347
1348         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1349         https://bugs.webkit.org/show_bug.cgi?id=151942
1350
1351         Reviewed by Darin Adler.
1352
1353         * MiniBrowser/efl/main.c:
1354         (window_create): Enable offline web application cache feature on MiniBrowser.
1355         (elm_main):
1356
1357 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1358
1359         https://bugs.webkit.org/show_bug.cgi?id=151243
1360         <rdar://problem/22955197>
1361
1362         Reviewed by Alexey Proskuryakov.
1363
1364         * LayoutTestRelay/LayoutTestRelay/main.m:
1365         (getTestingSimDevice): Use separate testing device for each worker.
1366         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1367         (Manager.run): Perform cleanup even if setup fails.
1368         * Scripts/webkitpy/port/ios.py:
1369         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1370         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1371         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1372         (IOSSimulatorPort._quit_ios_simulator): Same
1373         (IOSSimulatorPort.clean_up_test_run): Same
1374         (IOSSimulatorPort.check_sys_deps): Same
1375         (IOSSimulatorPort.testing_device): Same
1376         (IOSSimulatorPort.reset_preferences): Same
1377         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1378         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1379         * Scripts/webkitpy/xcode/simulator.py:
1380         (Device.delete): Delete the simulator device.
1381         (Simulator.delete_device): Same
1382         (Simulator.wait_until_device_is_booted): Wait for device booting.
1383
1384 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1385
1386         [EFL] Add API to provide preferences before creating ewk_view
1387         https://bugs.webkit.org/show_bug.cgi?id=151587
1388
1389         Reviewed by Gyuyoung Kim.
1390
1391         * MiniBrowser/efl/main.c:
1392         (on_key_down):
1393         (quit):
1394         (window_create):
1395         Moved settings related code to configuration() not to update settings
1396         whenever ewk_view is created.
1397         (configuration):
1398         (elm_main):
1399
1400 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1401
1402         Unreviewed. Fix GTK+ API tests after r193639.
1403
1404         The new jhbuild version needs some more variables ot be present in
1405         the builtin dict, even if they are set to None.
1406
1407         * jhbuild/jhbuildutils.py:
1408         (enter_jhbuild_environment_if_available):
1409
1410 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1411
1412         [GTK] Notify WebCore when notification is clicked
1413         https://bugs.webkit.org/show_bug.cgi?id=151951
1414
1415         Reviewed by Carlos Garcia Campos.
1416
1417         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1418         (testWebViewNotification): test the new API.
1419
1420 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1421
1422         'jhbuild build' should fail immediately when building any module fails
1423         https://bugs.webkit.org/show_bug.cgi?id=145697
1424
1425         Reviewed by Carlos Garcia Campos.
1426
1427         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1428         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1429         Everything is placed under lib instead of lib64 now.
1430         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1431         --exit-on-error when running 'jhbuild build'.
1432         * jhbuild/jhbuildrc_common.py:
1433         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1434         jhbuild should be able to handle these for us without breaking things....
1435
1436 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1437
1438         Add support to import w3c tests from a repository with a different root that the main repo dir
1439         https://bugs.webkit.org/show_bug.cgi?id=151751
1440
1441         Reviewed by Ryosuke Niwa and Youenn Fablet.
1442
1443         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1444         in a different directory than the repository root.
1445
1446         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1447         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1448         requires having the copy_path lists including tuples of origin and destination directories.
1449
1450         * Scripts/webkitpy/w3c/test_downloader.py:
1451         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1452         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1453         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1454         (TestImporterTest.test_tests_directory): Test.
1455
1456 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1457
1458         Mock TestRepositories in W3C importer tests
1459         https://bugs.webkit.org/show_bug.cgi?id=151938
1460
1461         Reviewed by Youenn Fablet.
1462
1463         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1464         is because the test repository method reading the file was using the filesystem directly instead of taking the
1465         host one. This patch changes that.
1466
1467         * Scripts/webkitpy/w3c/test_downloader.py:
1468         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1469         default one.
1470         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1471         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1472         (TestImporterTest.test_harnesslinks_conversion):
1473         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1474
1475 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1476
1477         TestNetscapePlugIn: Address review comment on 193607
1478         <http://webkit.org/b/151881>
1479
1480         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1481         (testSetStatus): Initializing std::unique_ptr<char[]> with
1482         nullptr is redundant.
1483
1484 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1485
1486         [GTK] Add webkit_uri_request_get_http_method
1487         https://bugs.webkit.org/show_bug.cgi?id=151601
1488
1489         Reviewed by Martin Robinson.
1490
1491         Add test case to check HTTP method of WebKitURIRequest.
1492
1493         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1494         (testURIRequestHTTPMethod):
1495         (serverCallback):
1496         (beforeAll):
1497         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1498         (sendRequestCallback):
1499
1500 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1501
1502         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1503         https://bugs.webkit.org/show_bug.cgi?id=79918
1504
1505         Reviewed by Gustavo Noronha Silva.
1506
1507         Add unit tests to check the different console messages.
1508
1509         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1510         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1511         (ConsoleMessageTest::ConsoleMessage::operator==):
1512         (ConsoleMessageTest::consoleMessageReceivedCallback):
1513         (ConsoleMessageTest::ConsoleMessageTest):
1514         (ConsoleMessageTest::~ConsoleMessageTest):
1515         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1516         (testWebKitConsoleMessageConsoleAPI):
1517         (testWebKitConsoleMessageJavaScriptException):
1518         (testWebKitConsoleMessageNetworkError):
1519         (testWebKitConsoleMessageSecurityError):
1520         (beforeAll):
1521         (afterAll):
1522         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1523         (consoleMessageSentCallback):
1524         (pageCreatedCallback):
1525
1526 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1527
1528         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1529         https://bugs.webkit.org/show_bug.cgi?id=151934
1530
1531         Reviewed by Csaba Osztrogonác.
1532
1533         * MiniBrowser/efl/main.c:
1534         (on_window_deletion): Revert the changes of r192767.
1535
1536 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1537
1538         [GTK] update-webkitgtk-libs cannot build mesa
1539         https://bugs.webkit.org/show_bug.cgi?id=151535
1540
1541         Reviewed by Martin Robinson.
1542
1543         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1544         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1545         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1546         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1547         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1548         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1549
1550         * gtk/jhbuild.modules:
1551
1552 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1553
1554         [GTK][Mac] libWebExtensionTest link error
1555         https://bugs.webkit.org/show_bug.cgi?id=150802
1556
1557         Reviewed by Carlos Garcia Campos.
1558
1559         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1560
1561 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1562
1563         TestNetscapePlugIn: Fix leaks found by static analyzer
1564         <http://webkit.org/b/151881>
1565
1566         Reviewed by Darin Adler.
1567
1568         Fixes the following leaks found by the static analyzer:
1569             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1570                     return false;
1571                            ^~~~~
1572             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1573                     return false;
1574                            ^~~~~
1575             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1576                     return false;
1577                            ^~~~~
1578
1579         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1580         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1581         early return if allocation fails.
1582         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1583         Make sure to call fclose() on filehandle, even for an early
1584         return.
1585         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1586
1587 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1588
1589         prepare-ChangeLog: Fix some warning messages when using svn
1590         <http://webkit.org/b/151914>
1591
1592         Reviewed by Daniel Bates.
1593
1594         * Scripts/prepare-ChangeLog:
1595         (generateFunctionLists): Simplify logic so that we never call
1596         normalizePath() with an undefined value.
1597         (attributeCommand): Quote $subPath for the shell so that we
1598         don't try to run "svn propget" on invalid paths.
1599
1600 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1601
1602         TestNetscapePlugIn: Fix remaining static analyzer warnings
1603         <http://webkit.org/b/151888>
1604
1605         Reviewed by Alexey Proskuryakov.
1606
1607         Fixes the following static analyzer warnings:
1608             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1609                     CRASH();
1610                     ^~~~~~~
1611             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1612                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1613                 ^~~~~~~~~~~~~~~~
1614             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1615                 return obj->pluginTest->NPP_SetWindow(window);
1616                        ^~~~~~~~~~~~~~~
1617             2 warnings generated.
1618
1619         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1620         (CRASH): Use __builtin_trap() for gcc/clang.
1621         (NPP_SetWindow): Add early return if obj is nullptr.
1622
1623 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1624
1625         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1626         https://bugs.webkit.org/show_bug.cgi?id=151797
1627
1628         Reviewed by Martin Robinson.
1629
1630         Since we switched to use the network process to run the unit tests
1631         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1632         sometimes passes. We are now also getting the notification for the
1633         css image. Since we wait for 3 resources, sometimes the css image
1634         is loaded before and then checkResourceData is called for it, but
1635         not handled. When the css image is the last one loaded the test
1636         passes. So, we just need to wait for the 4 resources.
1637
1638         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1639         (testWebResourceGetData):
1640
1641 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1642
1643         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1644         <http://webkit.org/b/151845>
1645
1646         Reviewed by Simon Fraser.
1647
1648         Fixes the following static analyzer warning:
1649             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1650                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1651                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1652
1653         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1654         (createBitmapContext): Free 'buffer' after using it in logging
1655         to fix the use-after-free.  Assign a value of nullptr to buffer
1656         so we don't return with it set to a freed address.
1657
1658 2015-12-03  Jer Noble  <jer.noble@apple.com>
1659
1660         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1661         https://bugs.webkit.org/show_bug.cgi?id=151830
1662
1663         Reviewed by Anders Carlsson.
1664
1665         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1666
1667         * DumpRenderTree/mac/DumpRenderTree.mm:
1668         (resetWebPreferencesToConsistentValues):
1669         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1670         (WTR::initializeWebViewConfiguration):
1671
1672 2015-12-03  Anders Carlsson  <andersca@apple.com>
1673
1674         Remove Objective-C GC support
1675         https://bugs.webkit.org/show_bug.cgi?id=151819
1676         rdar://problem/23746991
1677
1678         Reviewed by Dan Bernstein.
1679
1680         * asan/asan.xcconfig:
1681
1682 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1683
1684         Allow nil for unspecified benchmark pathes
1685         https://bugs.webkit.org/show_bug.cgi?id=151784
1686
1687         Reviewed by Filip Pizlo.
1688
1689         `Pathname.new(nil)` will raise an error.
1690         Only generate Pathname if the benchmark path is specified.
1691
1692         * Scripts/run-jsc-benchmarks:
1693
1694 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1695
1696         [Win] Run non-http tests without Cygwin
1697         https://bugs.webkit.org/show_bug.cgi?id=151721
1698
1699         Reviewed by Andy Estes.
1700
1701         Support native 32-bit and 64-bit Python (and Perl) builds
1702         for running tests:
1703
1704         1. Use "startswith('win')", rather than "== 'win32'" to support
1705         various Windows build types.
1706         2. Supply full path for some native Windows utilities, since the
1707         path environment does not always have the specified, and they are
1708         guaranteed to exist in those specific locations.
1709         3. Make sure native Windows Python test runs pass proper environment
1710         variables to run programs.
1711         4. Append 'exe' suffix when running Windows executables.
1712         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1713         command doesn't exist.
1714         
1715         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1716         the current Perl executable, rather than requiring a new path search.
1717         * Scripts/webkitpy/common/find_files_unittest.py:
1718         (TestWinNormalize.test_win): Use startswith('win').
1719         * Scripts/webkitpy/common/prettypatch_unittest.py:
1720         (test_pretty_diff_encodings): Ditto.
1721         * Scripts/webkitpy/common/system/executive.py:
1722         (Executive._should_close_fds): Ditto.
1723         (Executive.shell_command_for_script): Use startswith('win').
1724         (Executive.kill_process): Use full path to killall executable.
1725         (Executive.check_running_pid): Use startswith('win').
1726         (Executive.running_pids): Ditto.
1727         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1728         running under native Windows Python.
1729         (Executive._child_process_encoding): Use startswith('win').
1730         (Executive._should_encode_child_process_arguments): Ditto.
1731         (Executive.popen): Recognize proper script engine on Windows, since it
1732         does not support the shebang syntax.
1733         (Executive.run_in_parallel): Use startswith('win').
1734         * Scripts/webkitpy/common/system/executive_unittest.py:
1735         (never_ending_command): Ditto.
1736         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1737         (ExecutiveTest.serial_test_kill_process): Ditto.
1738         (ExecutiveTest.serial_test_kill_all): Ditto.
1739         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1740         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1741         (main): Ditto.
1742         * Scripts/webkitpy/common/system/file_lock.py:
1743         (FileLock._create_lock): Ditto.
1744         (FileLock._remove_lock): Ditto.
1745         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1746         (RealFileSystemTest.test_chdir): Ditto.
1747         (RealFileSystemTest.test_chdir__notexists): Ditto.
1748         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1749         * Scripts/webkitpy/common/system/path_unittest.py:
1750         (AbspathTest.test_abspath_to_uri_win): Ditto.
1751         * Scripts/webkitpy/common/system/platforminfo.py:
1752         (PlatformInfo._determine_os_name): Ditto.
1753         * Scripts/webkitpy/common/system/user.py: Ditto.
1754         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1755         (ManagerTest.integration_test_needs_servers): Ditto.
1756         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1757         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1758         driver letters.
1759         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1760         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1761         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1762         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1763         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1764         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1765         (TestHttpServer.test_start_cmd): Ditto.
1766         * Scripts/webkitpy/port/base.py:
1767         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1768         and 'SYSTEMROOT' in environment passed to test runners.
1769         (Port._apache_config_file_name_for_platform): Use startswith('win').
1770         (Port._build_path): Ditto.
1771         (Port._path_to_driver): Include 'exe' suffix when running under native
1772         Windows.
1773         * Scripts/webkitpy/port/driver.py:
1774         (Driver._setup_environ_for_driver): Explicitly make some environment
1775         variables strings.
1776         * Scripts/webkitpy/port/server_process.py:
1777         (ServerProcess.__init__): Use startswith('win').
1778         * Scripts/webkitpy/port/win.py:
1779         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1780         registry key formats.
1781         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1782         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1783         and regtool on Cygwin.
1784         (WinPort.write_registry_value): Ditto.
1785         (WinPort.setup_crash_log_saving): Ditto.
1786         (WinPort.restore_crash_log_saving): Ditto.
1787         (WinPort.prevent_error_dialogs): Ditto.
1788         (WinPort.allow_error_dialogs): Ditto.
1789         (WinPort.find_system_pid): Revise to use Windows management
1790         infrastructure on native Windows, continue using 'ps' on Cygwin.
1791         (WinPort.read_registry_string): Deleted.
1792         (WinPort.write_registry_string): Deleted.
1793         * Scripts/webkitpy/test/main.py:
1794         (main): Use startswith('win').
1795         (Tester._parse_args): Ditto.
1796
1797 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1798
1799         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1800         https://bugs.webkit.org/show_bug.cgi?id=150792
1801
1802         Reviewed by Saam Barati.
1803
1804         * Scripts/webkitperl/FeatureList.pm:
1805
1806 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1807
1808         Unreviewed, rolling out r192914.
1809         https://bugs.webkit.org/show_bug.cgi?id=151734
1810
1811         JSC tests for this change are failing on 32 and 64-bit bots
1812         (Requested by ryanhaddad on #webkit).
1813
1814         Reverted changeset:
1815
1816         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1817         enable this feature"
1818         https://bugs.webkit.org/show_bug.cgi?id=150792
1819         http://trac.webkit.org/changeset/192914
1820
1821 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1822
1823         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1824         <http://webkit.org/b/151726>
1825
1826         Reviewed by Simon Fraser.
1827
1828         * WebKitTestRunner/mac/EventSenderProxy.mm:
1829         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1830         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1831
1832 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1833
1834         Give String and AtomicString an existingHash() function
1835         https://bugs.webkit.org/show_bug.cgi?id=151717
1836
1837         Reviewed by Andreas Kling.
1838
1839         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1840         (TestWebKitAPI::TEST):
1841         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1842         (TestWebKitAPI::TEST):
1843
1844 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1845
1846         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1847         https://bugs.webkit.org/show_bug.cgi?id=150792
1848
1849         Reviewed by Saam Barati.
1850
1851         * Scripts/webkitperl/FeatureList.pm:
1852
1853 2015-12-01  Sam Weinig  <sam@webkit.org>
1854
1855         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1856         <rdar://problem/23320863>
1857         https://bugs.webkit.org/show_bug.cgi?id=151708
1858
1859         Reviewed by Anders Carlsson.
1860
1861         * WebKitTestRunner/TestController.cpp:
1862         (WTR::TestController::createOtherPage):
1863         (WTR::TestController::createWebViewWithOptions):
1864         Update for new WKPageUIClient.
1865
1866 2015-12-01  Anders Carlsson  <andersca@apple.com>
1867
1868         Remove WebKit2.framework
1869         https://bugs.webkit.org/show_bug.cgi?id=151715
1870
1871         Reviewed by Dan Bernstein.
1872
1873         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1874         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1875         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1876         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1877         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1878         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1879         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1880
1881 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1882
1883         Unreviewed common typo fix "occurance" => "occurrence".
1884
1885         * Scripts/webkitpy/tool/commands/queries.py:
1886         (FindFlakyTests._print_statistics):
1887
1888 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1889
1890         Make ProcessModel always MultipleSecondaryProcesses
1891         https://bugs.webkit.org/show_bug.cgi?id=151662
1892
1893         Reviewed by Antti Koivisto.
1894
1895         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1896         (TestWebKitAPI::TEST):
1897         * WebKitTestRunner/TestController.cpp:
1898         (WTR::TestController::generatePageConfiguration):
1899
1900 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1901
1902         Make usesNetworkProcess always true
1903         https://bugs.webkit.org/show_bug.cgi?id=151580
1904
1905         Reviewed by Darin Adler.
1906
1907         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1908         (TestWebKitAPI::TEST):
1909         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1910         (TestWebKitAPI::TEST):
1911         * WebKitTestRunner/TestController.cpp:
1912         (WTR::TestController::generatePageConfiguration):
1913
1914 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1915
1916         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1917
1918         Add a way to skip unit tests only for Debug or Release builds and
1919         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1920
1921         * Scripts/run-gtk-tests:
1922         (SkippedTest):
1923         (SkippedTest.__init__):
1924         (SkippedTest.__str__):
1925         (SkippedTest.skip_entire_suite):
1926         (SkippedTest.skip_for_build_type):
1927         (TestRunner):
1928         (TestRunner.__init__):
1929
1930 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1931
1932         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1933
1934         It's an assert hit because we are reloading a view loaded with
1935         HTML data which is not supported. Use loadURI instead.
1936
1937         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1938         (testWebViewCustomCharset):
1939
1940 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1941
1942         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1943         https://bugs.webkit.org/show_bug.cgi?id=151633
1944
1945         Reviewed by Csaba Osztrogonác.
1946
1947         * TestWebKitAPI/PlatformGTK.cmake:
1948         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1949
1950 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1951
1952         [GTK] Remove the remaining uses of GMainLoopSource
1953         https://bugs.webkit.org/show_bug.cgi?id=151632
1954
1955         Reviewed by Žan Doberšek.
1956
1957         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1958         (testWebViewSyncRequestOnMaxConns):
1959         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1960         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1961         (WTR::TestRunner::TestRunner):
1962         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1963         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1964         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1965         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1966         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1967         (WTR::timeoutSource):
1968         (WTR::TestController::notifyDone):
1969         (WTR::TestController::platformRunUntil):
1970
1971 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1972
1973         [cmake] Add testb3 to the build system
1974         https://bugs.webkit.org/show_bug.cgi?id=151619
1975
1976         Reviewed by Gyuyoung Kim.
1977
1978         * Scripts/build-jsc:
1979
1980 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1981
1982         [jhbuild] Fix pixman build with clang
1983         https://bugs.webkit.org/show_bug.cgi?id=151441
1984
1985         Reviewed by Carlos Garcia Campos.
1986
1987         * efl/jhbuild.modules:
1988         * gtk/jhbuild.modules:
1989
1990 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1991
1992         Extract prependToEnvironmentVariableList
1993         <http://webkit.org/b/151536>
1994
1995         Reviewed by Daniel Bates.
1996
1997         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1998                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1999
2000         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2001         and prependToEnvironmentVariableList.
2002         (appendToEnvironmentVariableList): Simplify variable name.
2003         Switch to use $Config{path_sep}.
2004         (prependToEnvironmentVariableList): Add new method.
2005         (setupMacWebKitEnvironment): Switch to use
2006         prependToEnvironmentVariableList().
2007         (setupIOSWebKitEnvironment): Ditto.
2008
2009         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2010         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2011
2012 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2013
2014         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2015         https://bugs.webkit.org/show_bug.cgi?id=151567
2016
2017         Reviewed by Darin Adler.
2018
2019         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2020         (on_window_deletion):
2021
2022 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2023
2024         [GTK] Use the network process unconditionally
2025         https://bugs.webkit.org/show_bug.cgi?id=151541
2026
2027         Reviewed by Alex Christensen.
2028
2029         Fix TestInspectorServer test. Do not assume we already have the
2030         title we want when the page has been loaded, since the title is
2031         changed afterwards. So, check if the title has already been set,
2032         and if not wait for it.
2033
2034         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2035         (openRemoteDebuggingSession):
2036
2037 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2038
2039         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2040         https://bugs.webkit.org/show_bug.cgi?id=151532
2041
2042         Reviewed by Benjamin Poulain.
2043
2044         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2045         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2046         (TestWebKitAPI::TEST):
2047         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2048         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2049         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2050         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
2051         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2052         so it was calling a function on a test object that had gone out of scope.
2053         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2054         but that will become the default soon and that call will be removed.
2055
2056 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2057
2058         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2059         <http://webkit.org/b/151542>
2060
2061         Reviewed by Daniel Bates.
2062
2063         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2064         (base_url): Use the Port object (already passed in) to give us
2065         the path to the LayoutTests directory, which already checks for a
2066         --layout-tests-directory command-line switch.
2067         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2068         argument since we can get this from the Port object already
2069         passed in via Port.results_directory().  Also switch to use
2070         Port.layout_tests_dir() to get the LayoutTests directory.
2071
2072         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2073         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2074         Add test case for custom LayoutTests directory.
2075         (TestWebPlatformTestServer.test_previously_spawned_instance):
2076         Update Port object to set mock results directory as if it was
2077         set on the command-line.  Remove unneeded argument from
2078         WebPlatformTestServer constructor.
2079         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2080
2081         * Scripts/webkitpy/port/base.py:
2082         (Port.to.start_web_platform_test_server): Remove unneeded
2083         argument from WebPlatformTestServer constuctor.
2084
2085 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2086
2087         [GTK] Some unit tests fail when using the network process
2088         https://bugs.webkit.org/show_bug.cgi?id=151490
2089
2090         Reviewed by Martin Robinson.
2091
2092         Run the soup server in a separate thread in TestResources test to
2093         avoid deadlocks.
2094
2095         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2096         /webkit2/WebKitWebResource/get-data when using the network process.
2097
2098         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2099         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2100         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2101         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2102         present, create a WorkQueue to run the server.
2103         (WebKitTestServer::run): Run the server in the work queue if it
2104         has been created.
2105         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2106         type into server options as flags.
2107
2108 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2109
2110         [GTK] ImageDiff should normalize the diff image
2111         https://bugs.webkit.org/show_bug.cgi?id=151261
2112
2113         Reviewed by Sergio Villar Senin.
2114
2115         * ImageDiff/gtk/ImageDiff.cpp:
2116         (readPixbufFromStdin): Fix memory leak.
2117         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2118         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2119
2120 == Rolled over to ChangeLog-2015-11-21 ==