Build fixes for the flakiness dashboard.
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-19  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Build fixes for the flakiness dashboard.
4
5         * TestResultServer/static-dashboards/flakiness_dashboard.js:
6
7 2013-04-17  Gustavo Noronha Silva  <gns@gnome.org>
8
9         [GTK] Make the 32 bits bot only build and run API tests
10         https://bugs.webkit.org/show_bug.cgi?id=113532
11
12         Reviewed by Martin Robinson.
13
14         * BuildSlaveSupport/build.webkit.org-config/config.json: make the 32 bits bot use the new BuildAndAPITest type
15         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
16         (BuildAndAPITestFactory): new factory that builds and runs API tests, only used by the GTK+ 32 bits bot at the
17         moment;
18         (BuildAndAPITestFactory.__init__): add API tests step for platforms that have it.
19
20 2013-04-19  Andras Becsi  <andras.becsi@digia.com>
21
22         [Qt] Only use thin archives on Linux
23
24         Rubber-stamped by Jocelyn Turcotte.
25
26         Since "thin archive" is a feature of GNU's ar
27         we limit the usage to Linux to avoid problems
28         with other configurations (eg. macx-g++).
29
30         * qmake/mkspecs/features/default_pre.prf:
31
32 2013-04-19  Krzysztof Czech  <k.czech@samsung.com>
33
34         [GTK][WK2] accessibility/language-attribute.html is failing
35         https://bugs.webkit.org/show_bug.cgi?id=106342
36
37         Reviewed by Gyuyoung Kim.
38
39         Adds support for getting language information.
40
41         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
42         (WTR::AccessibilityUIElement::language):
43
44 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
45
46         [Dashboard] Remove the isToTWebKit member variable from the BuilderGroup interface
47         https://bugs.webkit.org/show_bug.cgi?id=114805
48
49         Reviewed by Benjamin Poulain.
50
51         Remove the isToTWebKit member variable from the BuilderGroup and all its usages as it now defaults to true for every
52         builder group. The isTipOfTreeWebKitBuilder method now returns true by default but should be removed in a follow-up patch.
53         The BuilderGroup constructor does not accept the isToTWebKit parameter anymore so all the callsites are adjusted accordingly.
54
55         * TestResultServer/static-dashboards/builders.js:
56         (BuilderGroup):
57         (loadBuildersList):
58         * TestResultServer/static-dashboards/dashboard_base.js:
59         (isTipOfTreeWebKitBuilder):
60         (expectationsMap):
61         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
62         (test):
63
64 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
65
66         [Dashboard] htmlForIndividualTests unit test should include its dummy builder under the webkit.org builder master
67         https://bugs.webkit.org/show_bug.cgi?id=114804
68
69         Reviewed by Benjamin Poulain.
70
71         The htmlForIndividualTests unit test should include its dummy builder under the sole supported webkit.org builder master
72         just so the unit tests properly functions.
73
74         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
75
76 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
77
78         [Dashboard] Remove Chromium-specific helper functions that were used in the builder-loading code
79         https://bugs.webkit.org/show_bug.cgi?id=114803
80
81         Reviewed by Benjamin Poulain.
82
83         Remove three Chromium-specific helper functions that were used to determine Chromium DEPS, Content Shell and WebKit ToT
84         test runners. These are not required anymore and thus removed along with a couple of unit tests that were testing these
85         methods' correct behavior.
86
87         * TestResultServer/static-dashboards/builders.js:
88         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
89
90 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
91
92         [Dashboard] Remove the Chromium-specific builder masters
93         https://bugs.webkit.org/show_bug.cgi?id=114802
94
95         Reviewed by Benjamin Poulain.
96
97         Remove all the Chromium-specific builder masters, the webkit.org builder master is the only one currently supported.
98
99         * TestResultServer/static-dashboards/builders.js:
100
101 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
102
103         [Dashboard] Remove all the Chromium-specific builder groups
104         https://bugs.webkit.org/show_bug.cgi?id=114801
105
106         Reviewed by Benjamin Poulain.
107
108         Remove all the Chromium-specific builder groups, all of these are not supported anymore.
109
110         * TestResultServer/static-dashboards/builders.js:
111
112 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
113
114         [Dashboard] Only accept the 'group' parameter if present in the layout tests builders group
115         https://bugs.webkit.org/show_bug.cgi?id=114799
116
117         Reviewed by Benjamin Poulain.
118
119         The layout tests builder group is the only one supported, all the other Chromium-specific builder groups are
120         bound to be removed.
121
122         * TestResultServer/static-dashboards/history.js:
123         (.):
124
125 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
126
127         [Dashboard] Remove Chromium-specific builder loading code from loadBuildersList
128         https://bugs.webkit.org/show_bug.cgi?id=114797
129
130         Reviewed by Benjamin Poulain.
131
132         Remove anything Chromium-specific from the builder-loading code, specifically removing support for loading builder data
133         for anything other that the layout-tests type and removing support for loading builder data from builders connected
134         to the Chromium-specific builder groups which are no longer supported.
135
136         * TestResultServer/static-dashboards/builders.js:
137
138 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
139
140         [Dashboard] The currentBuilderGroupCategory method should return the layout tests builder groups by default
141         https://bugs.webkit.org/show_bug.cgi?id=114796
142
143         Reviewed by Benjamin Poulain.
144
145         With the Chromium builders no longer uploading results and the layout-tests test type the only one supported by the
146         WebKit's dashboard, the currentBuilderGroupCategory can now return LAYOUT_TESTS_BUILDER_GROUPS as the default builder
147         group category.
148
149         * TestResultServer/static-dashboards/dashboard_base.js:
150         (currentBuilderGroupCategory):
151
152 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
153
154         [Dashboard] Narrow down the test types list to only layout-tests
155         https://bugs.webkit.org/show_bug.cgi?id=114795
156
157         Reviewed by Ryosuke Niwa.
158
159         Remove all the redundant test types that the webkit.org builders do not upload results for. All of the removed
160         test types were specific to the Chromium builders.
161
162         * TestResultServer/static-dashboards/dashboard_base.js:
163
164 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
165
166         [Dashboard] The revision rows for aggregate results should no longer include Chromium revisions
167         https://bugs.webkit.org/show_bug.cgi?id=114760
168
169         Reviewed by Benjamin Poulain.
170
171         With the Chromium builders no longer present there's no need to display the Chromium revision range under the
172         aggregate results. Only the first half of the htmlForRevisionRows method (the one returning the table row listing the
173         WebKit revisions) is now relevant - the method is therefor removed and its callsites updated to directly call the
174         htmlForTableRow method that returns the table row containing all the relevant WebKit revisions.
175
176         * TestResultServer/static-dashboards/aggregate_results.js:
177         (htmlForSummaryTable):
178         (htmlForTestType):
179
180 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
181
182         [Dashboard] Remove Chromium-specific cases from the construction of the chart HTML for aggregate results
183         https://bugs.webkit.org/show_bug.cgi?id=114759
184
185         Reviewed by Benjamin Poulain.
186
187         Aggregate results are not viewable for Chromium builders anymore, meaning the WebKit revisions are shown by default.
188         This means the code in the chartHTML method can be simplified, defaulting the revision key to WEBKIT_REVISIONS_KEY
189         and the revision label to 'WebKit Revision'.
190
191         * TestResultServer/static-dashboards/aggregate_results.js:
192         (chartHTML):
193
194 2013-04-18  Xuefei Ren  <xren@blackberry.com>
195
196         remove build warning(unused parameter)
197         https://bugs.webkit.org/show_bug.cgi?id=114670
198
199         Reviewed by Rob Buis.
200
201         remove builde warning (unused parameter) in
202         Tools/DumpRenderTree/blackberry
203
204         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
205         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
206         (AccessibilityUIElement::scrollToGlobalPoint):
207         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
208         (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
209         (BlackBerry::WebKit::DumpRenderTree::didReceiveResponseForFrame):
210         * DumpRenderTree/blackberry/EventSender.cpp:
211         (getDragModeCallback):
212         (setDragModeCallback):
213         (mouseWheelToCallback):
214         (contextClickCallback):
215         (mouseDownCallback):
216         (mouseUpCallback):
217         (mouseMoveToCallback):
218         (beginDragWithFilesCallback):
219         (leapForwardCallback):
220         (keyDownCallback):
221         (textZoomInCallback):
222         (textZoomOutCallback):
223         (zoomPageInCallback):
224         (zoomPageOutCallback):
225         (addTouchPointCallback):
226         (updateTouchPointCallback):
227         (setTouchModifierCallback):
228         (touchStartCallback):
229         (touchCancelCallback):
230         (touchMoveCallback):
231         (touchEndCallback):
232         (clearTouchPointsCallback):
233         (cancelTouchPointCallback):
234         (releaseTouchPointCallback):
235         (scalePageByCallback):
236         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
237         (TestRunner::authenticateSession):
238         (TestRunner::setSpatialNavigationEnabled):
239         (TestRunner::apiTestNewWindowDataLoadBaseURL):
240         (TestRunner::setPluginsEnabled):
241         (TestRunner::setApplicationCacheOriginQuota):
242         (TestRunner::addMockSpeechInputResult):
243         (TestRunner::setViewModeMediaFeature):
244         (TestRunner::deleteLocalStorageForOrigin):
245         (TestRunner::applicationCacheDiskUsageForOrigin):
246         (TestRunner::grantWebNotificationPermission):
247         (TestRunner::denyWebNotificationPermission):
248         (TestRunner::simulateWebNotificationClick):
249         (TestRunner::simulateLegacyWebNotificationClick):
250
251 2013-04-18  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
252
253         [WK2][EFL] Text Checker's settings refactor
254         https://bugs.webkit.org/show_bug.cgi?id=111713
255
256         Reviewed by Andreas Kling.
257
258         * MiniBrowser/efl/main.c:
259         (window_create):
260         Use a new text checker API to enable spell checking.
261
262 2013-04-18  Seokju Kwon  <seokju.kwon@gmail.com>
263
264         [EFL] Add a newline to the end of log message
265         https://bugs.webkit.org/show_bug.cgi?id=114659
266
267         Reviewed by Gyuyoung Kim.
268
269         Move a newline to info() definition.
270
271         * EWebLauncher/main.c:
272         (on_load_finished):
273         (on_tooltip_text_set):
274         (on_tooltip_text_unset):
275         (on_inputmethod_changed):
276         (on_focus_out):
277         (on_focus_in):
278         (on_key_down):
279         (windowCreate):
280         * MiniBrowser/efl/main.c:
281         (on_key_down):
282         (on_download_request):
283         (on_download_finished):
284         (on_download_failed):
285         (on_refresh_button_clicked):
286         (on_popup_menu_discarded):
287         (on_popup_menu_item_clicked):
288         (popup_menu_populate):
289         (on_popup_menu_show):
290         (on_window_create):
291         (context_popup_item_selected_cb):
292         (on_context_menu_show):
293         (on_context_menu_hide):
294         (window_create):
295
296 2013-04-17  Zan Dobersek  <zandobersek@gmail.com>
297
298         [Dashboard] Remove code for showing 'WebKit roll' annotations in timelines for Chromium builders
299         https://bugs.webkit.org/show_bug.cgi?id=114755
300
301         Reviewed by Ryosuke Niwa.
302
303         The Chromium builders are no longer available to inspect so there's no need for the code that used to show
304         the 'WebKit roll' annotations in the Chromium builders' timeline.
305
306         * TestResultServer/static-dashboards/timeline_explorer.js:
307
308 2013-04-17  Zan Dobersek  <zandobersek@gmail.com>
309
310         [Dashboard] Clean up the timeline updating code, removing Chromium-specific cases
311         https://bugs.webkit.org/show_bug.cgi?id=114756
312
313         Reviewed by Ryosuke Niwa.
314
315         Clean up the updating of the timeline in the timeline explorer, defaulting to the webkit.org build master when
316         constructing the results URL and removing the possible row addition containing the Chromium commit range that
317         only applied to Chromium builders in the first place. Also removes the now-redundant shouldShowWebKitRevisionsOnly
318         method.
319
320         * TestResultServer/static-dashboards/timeline_explorer.js:
321
322 2013-04-17  Alberto Garcia  <agarcia@igalia.com>
323
324         media-stream and xslt are no longer configurable options in the GTK+ port
325         https://bugs.webkit.org/show_bug.cgi?id=114736
326
327         Reviewed by Martin Robinson.
328
329         media-stream support was removed in r145199 and XSLT is a hard
330         requirement since r145859. Attempting to pass those options to the
331         configure script, only results in a warning.
332
333         * Scripts/webkitdirs.pm:
334         (buildAutotoolsProject):
335
336 2013-04-17  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
337
338         [EFL][WK2] Implement context menu in MiniBrowser
339         https://bugs.webkit.org/show_bug.cgi?id=102932
340
341         Reviewed by Gyuyoung Kim.
342
343         Added context menu support for EFL port using Elementary context popup.
344
345         * MiniBrowser/efl/main.c:
346         (_Browser_Window):
347         (context_popup_item_selected_cb):
348         (context_popup_populate):
349         (on_context_menu_show):
350         (on_context_menu_hide):
351         (window_create):
352
353 2013-04-17  Csaba Osztrogonác  <ossy@webkit.org>
354
355         REGRESSION(r148588): It broke the Qt WK2 EWS
356         https://bugs.webkit.org/show_bug.cgi?id=114737
357
358         Reviewed by Jocelyn Turcotte.
359
360         * Scripts/webkitpy/common/config/ews.json: "Qt WK2 EWS" should use qt-wk2 port.
361         * Scripts/webkitpy/common/config/ports.py:
362         (DeprecatedPort.port):
363         (QtPort.build_webkit_command): qt port shouldn't build WebKit2.
364         (QtPort.run_webkit_tests_command): qt port runs WK1 tests.
365         (QtWK2Port): Added.
366         (QtWK2Port.build_webkit_command): qt-wk2 port builds WK1 and WK2 too.
367         (QtWK2Port.run_webkit_tests_command): qt-wk2 port runs WK2 tests.
368         * Scripts/webkitpy/common/config/ports_unittest.py:
369         (DeprecatedPortTest.test_qt_port):
370         (DeprecatedPortTest):
371         (DeprecatedPortTest.test_qt_wk2_port):
372
373 2013-04-17  Zan Dobersek  <zdobersek@igalia.com>
374
375         Unreviewed.
376
377         * Scripts/webkitpy/common/config/ports_unittest.py:
378         (DeprecatedPortTest.test_efl_port): Adjusting the expected outcome of the EFL build-webkit command after r148589.
379
380 2013-04-17  Allan Sandfeld Jensen  <allan.jensen@digia.com>
381
382         [Qt] Enable sub-pixel layout.
383         https://bugs.webkit.org/show_bug.cgi?id=113199
384
385         Reviewed by Jocelyn Turcotte.
386
387         * qmake/mkspecs/features/features.pri:
388
389 2013-04-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
390
391         Add Efl WebKit2 EWS bot
392         https://bugs.webkit.org/show_bug.cgi?id=114564
393
394         Reviewed by Ryosuke Niwa.
395
396         Added EflWK2EWS, and add myself a watcher for EflWK2EWS.
397         Also add a deprecated EflWK2Port class.
398
399         Besides clean up eflews watchers.
400
401         * QueueStatusServer/config/queues.py:
402         * Scripts/webkitpy/common/config/ews.json:
403         * Scripts/webkitpy/common/config/ports.py:
404         (DeprecatedPort.port):
405         (EflPort.build_webkit_command):
406         (EflWK2Port):
407         (EflWK2Port.build_webkit_command):
408
409 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
410
411         Isolate Early Warning System definitions into a JSON
412         https://bugs.webkit.org/show_bug.cgi?id=114558
413
414         Reviewed by Benjamin Poulain.
415
416         Added ews.json to common/config, and made tool/commands/__init__.py call
417         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
418
419         Reland the patch since the EWS failure was a false positive.
420
421         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
422         * Scripts/webkitpy/tool/commands/__init__.py:
423         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
424         (AbstractEarlyWarningSystem):
425         (AbstractEarlyWarningSystem.__init__):
426         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
427         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
428         (EarlyWarningSystemTest._default_expected_logs):
429         (_test_ews):
430         (test_ewses):
431
432 2013-04-16  Sam Weinig  <sam@webkit.org>
433
434         Fix fallout after r148545.
435
436         * WebKitTestRunner/TestController.cpp:
437         (WTR::TestController::resetStateToConsistentValues):
438         Remove calls to non-existent API functions.
439
440 2013-04-13  Roger Fong  <roger_fong@apple.com>
441
442         Unreviewed. Disable WinEWS tests, simply not enough bots.
443
444         All bots are running consistently now but the queue still keeps growing.
445         Until we get more bots or make the tests faster, it doesn't seem wise to keep running tests.
446
447         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
448         (WinEWS):
449
450 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
451
452         The list of contributors in committers.py should be a separate JSON
453         https://bugs.webkit.org/show_bug.cgi?id=114673
454
455         Reviewed by Anders Carlsson.
456
457         Added webkitpy/common/config/contributors.json, made CommitterList load it.
458
459         * EWSTools/start-queue-mac.sh:
460         * EWSTools/start-queue.sh:
461         * Scripts/webkitpy/common/checkout/commitinfo.py:
462         (CommitInfo.committer):
463         * Scripts/webkitpy/common/config/contributors.json: Added.
464         * Scripts/webkitpy/common/config/committers.py:
465         (Reviewer.__init__):
466         (CommitterList.__init__):
467         (CommitterList.load_json): Added.
468         (CommitterList.load_json.emails):
469         (CommitterList.load_json.nicks):
470         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
471         (MockCommitInfo.author):
472
473 2013-04-16  Manuel Rego Casasnovas  <rego@igalia.com>
474
475         [EFL] Bump libsoup dependency to 2.42.0
476         https://bugs.webkit.org/show_bug.cgi?id=113927
477
478         Reviewed by Gyuyoung Kim.
479
480         Update libsoup required version to v2.42.0 and GLib to v2.36.0 as
481         required by libsoup for EFL port.
482
483         * efl/jhbuild.modules:
484         * efl/patches/libsoup-2.40-auth-fix.patch: Removed as it's already
485         included in v2.42.0.
486
487 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
488
489         Remove Account class from committers.py
490         https://bugs.webkit.org/show_bug.cgi?id=114671
491
492         Reviewed by Csaba Osztrogonác.
493
494         Account class was added to support watch list email addresses that are not associated with
495         a particular contributor but nobody uses these email address since Chromium port forked.
496
497         Remove it.
498
499         Also removed account_by_login from CommitterList since it was never called except its unittests.
500
501         * Scripts/webkitpy/common/checkout/changelog.py:
502         * Scripts/webkitpy/common/config/committers.py:
503         (Contributor):
504         (Contributor.matches_glob):
505         (Reviewer.__init__):
506         (CommitterList.__init__):
507         (CommitterList._email_to_account_map):
508         (CommitterList._login_to_account_map):
509         (CommitterList.contributors_by_fuzzy_match):
510         (CommitterList.contributor_by_email):
511         (CommitterList.contributor_by_name):
512         (CommitterList.committer_by_email):
513         (CommitterList.reviewer_by_email):
514         * Scripts/webkitpy/common/config/committers_unittest.py:
515         (CommittersTest.test_committer_lookup):
516         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
517         (Bugzilla._commit_queue_flag):
518         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
519         (test_commit_queue_flag):
520         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
521         (WatchListParser._validate):
522
523 2013-04-16  Mike West  <mkwst@chromium.org>
524
525         Unreviewed update to the watchlist.
526
527         Removing 'mkwst+watchlist@chromium.org' from committers.py and the
528         watchist file; moving to 'mkwst@chromium.org' instead.
529
530         * Scripts/webkitpy/common/config/committers.py:
531         * Scripts/webkitpy/common/config/watchlist:
532
533 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
534
535         Move webkitpy.layout_tests.port to webkitpy.port
536         https://bugs.webkit.org/show_bug.cgi?id=114668
537
538         Reviewed by Maciej Stachowiak.
539
540         Moved. Port objects knows a lot more than just layout_tests. They doesn't belong down in layout_tests.
541
542         * Scripts/webkitpy/common/host.py:
543         * Scripts/webkitpy/common/host_mock.py:
544         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
545         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
546         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
547         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
548         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
549         * Scripts/webkitpy/layout_tests/port: Removed.
550         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
551         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
552         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
553         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
554         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
555         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
556         * Scripts/webkitpy/performance_tests/perftest.py:
557         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
558         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
559         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
560         * Scripts/webkitpy/port: Copied from Tools/Scripts/webkitpy/layout_tests/port.
561         * Scripts/webkitpy/port/apple.py:
562         * Scripts/webkitpy/port/base.py:
563         * Scripts/webkitpy/port/base_unittest.py:
564         * Scripts/webkitpy/port/config_unittest.py:
565         (ConfigTest.test_default_configuration__standalone):
566         * Scripts/webkitpy/port/driver_unittest.py:
567         * Scripts/webkitpy/port/efl.py:
568         * Scripts/webkitpy/port/efl_unittest.py:
569         * Scripts/webkitpy/port/factory.py:
570         * Scripts/webkitpy/port/factory_unittest.py:
571         * Scripts/webkitpy/port/gtk.py:
572         * Scripts/webkitpy/port/gtk_unittest.py:
573         * Scripts/webkitpy/port/image_diff.py:
574         * Scripts/webkitpy/port/image_diff_unittest.py:
575         * Scripts/webkitpy/port/leakdetector_unittest.py:
576         * Scripts/webkitpy/port/mac.py:
577         * Scripts/webkitpy/port/mac_unittest.py:
578         * Scripts/webkitpy/port/mock_drt.py:
579         * Scripts/webkitpy/port/mock_drt_unittest.py:
580         * Scripts/webkitpy/port/port_testcase.py:
581         * Scripts/webkitpy/port/qt.py:
582         * Scripts/webkitpy/port/qt_unittest.py:
583         * Scripts/webkitpy/port/server_process_unittest.py:
584         * Scripts/webkitpy/port/test.py:
585         * Scripts/webkitpy/port/win.py:
586         * Scripts/webkitpy/port/win_unittest.py:
587         * Scripts/webkitpy/port/xvfbdriver.py:
588         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
589         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
590         * Scripts/webkitpy/tool/commands/gardenomatic.py:
591         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
592         * Scripts/webkitpy/tool/commands/queries.py:
593         * Scripts/webkitpy/tool/commands/queries_unittest.py:
594         * Scripts/webkitpy/tool/commands/rebaseline.py:
595         * Scripts/webkitpy/tool/servers/gardeningserver.py:
596         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
597         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
598         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
599
600 2013-04-16  Commit Queue  <rniwa@webkit.org>
601
602         Unreviewed, rolling out r148498.
603         http://trac.webkit.org/changeset/148498
604         https://bugs.webkit.org/show_bug.cgi?id=114669
605
606         Appears to have broken EWS (Requested by rniwa on #webkit).
607
608         * Scripts/webkitpy/common/config/ews.json: Removed.
609         * Scripts/webkitpy/tool/commands/__init__.py:
610         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
611         (AbstractEarlyWarningSystem):
612         (AbstractEarlyWarningSystem.__init__):
613         (AbstractEarlyWarningSystem.handle_script_error.does):
614         (GtkEWS):
615         (GtkWK2EWS):
616         (EflEWS):
617         (QtEWS):
618         (QtWK2EWS):
619         (WinEWS):
620         (MacEWS):
621         (MacWK2EWS):
622         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
623         (EarlyWarningSystemTest._default_expected_logs):
624         (_test_ews):
625         (test_ewses):
626
627 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
628
629         Isolate Early Warning System definitions into a JSON
630         https://bugs.webkit.org/show_bug.cgi?id=114558
631
632         Reviewed by Benjamin Poulain.
633
634         Added ews.json to common/config, and made tool/commands/__init__.py call
635         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
636
637         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
638         * Scripts/webkitpy/tool/commands/__init__.py:
639         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
640         (AbstractEarlyWarningSystem):
641         (AbstractEarlyWarningSystem.__init__):
642         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
643         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
644         (EarlyWarningSystemTest._default_expected_logs):
645         (_test_ews):
646         (test_ewses):
647
648 2013-04-15  Ryosuke Niwa  <rniwa@webkit.org>
649
650         WKR gets stuck when there are many merges
651         https://bugs.webkit.org/show_bug.cgi?id=114632
652
653         Reviewed by Andreas Kling.
654
655         Move the last revision forward when it exists in a branch.
656         Otherwise, we'll be stuck looping over revisions made to merge patches.
657
658         * Scripts/webkitpy/tool/commands/newcommitbot.py:
659         (NewCommitBot.next_work_item):
660
661 2013-04-15  Gustavo Noronha Silva  <gns@gnome.org>
662
663         [GTK] Missing a few packages for building on stock Fedora
664         https://bugs.webkit.org/show_bug.cgi?id=113916
665
666         Reviewed by Philippe Normand.
667
668         * gtk/install-dependencies: add packages that are missing.
669
670 2013-04-15  Zan Dobersek  <zdobersek@igalia.com>
671
672         REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
673         https://bugs.webkit.org/show_bug.cgi?id=114602
674
675         Reviewed by Ryosuke Niwa.
676
677         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
678         (CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
679         interface so its value doesn't leak into the following tests.
680
681 2013-04-15  Zan Dobersek  <zandobersek@gmail.com>
682
683         Deprecate land-cowboy in favor of land-cowhand
684         https://bugs.webkit.org/show_bug.cgi?id=104470
685
686         Reviewed by Darin Adler.
687
688         Move the LandCowboy command implementation under the LandCowhand command and deprecate the former.
689
690         * Scripts/webkitpy/tool/commands/download.py:
691         (LandCowhand):
692         (LandCowboy):
693         (LandCowboy._prepare_state):
694         * Scripts/webkitpy/tool/commands/download_unittest.py:
695         (test_land_cowhand): Adjust the unit tests by testing both LandCowhand and LandCowboy,
696         also checking the deprecation message in the output of the latter.
697
698 2013-04-15  Jonathan Liu  <net147@gmail.com>
699
700         Improve Windows cmd.exe detection
701         https://bugs.webkit.org/show_bug.cgi?id=114620
702
703         Reviewed by Jocelyn Turcotte.
704
705         The current detection code handles Windows cmd.exe and Cygwin shell
706         but not does not handle MSYS shell correctly. Simplify and improve the
707         detection by checking MINGW_IN_SHELL instead as used in other places
708         (e.g. qt_functions.prf).
709
710         * qmake/mkspecs/features/default_pre.prf:
711
712 2013-04-15  Manuel Rego Casasnovas  <rego@igalia.com>
713
714         [webkitpy] Use $NUMBER_OF_PROCESSORS in Executive.cpu_count()
715         https://bugs.webkit.org/show_bug.cgi?id=114506
716
717         Reviewed by Philippe Normand.
718
719         * Scripts/webkitpy/common/system/executive.py:
720         (Executive.cpu_count): Modify function in order to use the environment
721         variable $NUMBER_OF_PROCESSORS if it is defined and it is an integer
722         greater than 0.
723
724 2013-04-15  Xan Lopez  <xlopez@igalia.com>
725
726         [BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
727         https://bugs.webkit.org/show_bug.cgi?id=114615
728
729         Reviewed by Carlos Garcia Campos.
730
731         Enable the style scoped feature if we have support for it.
732
733         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
734         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
735
736 2013-04-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
737
738         [Qt] QtMultimedia not used when GStreamer is not found
739         https://bugs.webkit.org/show_bug.cgi?id=111842
740
741         Reviewed by Philippe Normand.
742
743         Fallback to using QtMultimedia when native libraries are not found.
744
745         * qmake/mkspecs/features/features.prf:
746
747 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
748
749         Build fix attempt for webkitbot. Unicodify everything.
750
751         * Scripts/webkitpy/tool/bot/irc_command.py:
752         (Whois.execute):
753
754 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
755
756         webkitbot should provide full name, email address, and IRC nicknames on whois
757         https://bugs.webkit.org/show_bug.cgi?id=114494
758
759         Reviewed by Benjamin Poulain.
760
761         A response like the one below is useless. Improve it:
762         webkitbot: rniwa: zdobersek is zdobersek (zandobersek@gmail.com). Why do you ask?
763
764         We now report full name, email address, committer/reviewer status, and IRC nickname.
765
766         Also teach webkitbot how to respond to ping.
767
768         * Scripts/webkitpy/tool/bot/irc_command.py:
769         (PingPong): Moved 
770         (PingPong.execute):
771         (Whois._full_record_and_nick): Renamed and rewritten.
772         (Whois.execute):
773
774         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
775         (IRCCommandTest.test_whois): Updated test cases as needed.
776
777         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
778         (IRCBotTest.test_help): Added ping.
779
780         * Scripts/webkitpy/tool/commands/newcommitbot.py:
781         (NewCommitBot): Teached WKR how to respond to hi.
782
783 2013-04-13  Anders Carlsson  <andersca@apple.com>
784
785         Add form delegate method that's invoked right before sending a submit event to a form element
786         https://bugs.webkit.org/show_bug.cgi?id=114575
787
788         Reviewed by Dan Bernstein.
789
790         Add a test.
791
792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
793         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm: Added.
794         (-[FormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
795         (TestWebKitAPI):
796         (TestWebKitAPI::TEST):
797         
798         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
799         (TestWebKitAPI::Util::toSTD):
800         Don't crash when a null NSString is passed to toSTD.
801
802 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
803
804         Python test fix attempt after r148360.
805
806         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
807         (test_command_help):
808
809 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
810
811         Merge AbstractDeclarativeCommand into Command as a comment suggests
812         https://bugs.webkit.org/show_bug.cgi?id=114559
813
814         Reviewed by Antti Koivisto.
815
816         Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
817         We need to merge a lot more classes to make webkitpy hackable.
818
819         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
820         (AbstractLocalServerCommand):
821         (AbstractLocalServerCommand.__init__):
822         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
823         (AbstractSequencedCommand):
824         (AbstractSequencedCommand.__init__):
825         * Scripts/webkitpy/tool/commands/adduserstogroups.py:
826         (AddUsersToGroups):
827         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
828         (AnalyzeChangeLog):
829         (AnalyzeChangeLog.__init__):
830         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
831         * Scripts/webkitpy/tool/commands/bugfortest.py:
832         (BugForTest):
833         * Scripts/webkitpy/tool/commands/bugsearch.py:
834         (BugSearch):
835         * Scripts/webkitpy/tool/commands/chromechannels.py:
836         (ChromeChannels):
837         (__init__):
838         * Scripts/webkitpy/tool/commands/download.py:
839         (AbstractPatchProcessingCommand):
840         * Scripts/webkitpy/tool/commands/findusers.py:
841         (FindUsers):
842         * Scripts/webkitpy/tool/commands/openbugs.py:
843         (OpenBugs):
844         * Scripts/webkitpy/tool/commands/queries.py:
845         (BugsToCommit):
846         (PatchesInCommitQueue):
847         (PatchesToCommitQueue):
848         (PatchesToCommitQueue.__init__):
849         (PatchesToReview):
850         (PatchesToReview.__init__):
851         (PatchesToReview.execute):
852         (WhatBroke):
853         (ResultsFor):
854         (FailureReason):
855         (FindFlakyTests):
856         (TreeStatus):
857         (CrashLog):
858         (PrintExpectations):
859         (PrintExpectations.__init__):
860         (PrintBaselines):
861         (PrintBaselines.__init__):
862         * Scripts/webkitpy/tool/commands/queues.py:
863         (AbstractQueue.__init__):
864         * Scripts/webkitpy/tool/commands/rebaseline.py:
865         (AbstractRebaseliningCommand):
866         * Scripts/webkitpy/tool/commands/suggestnominations.py:
867         (SuggestNominations):
868         (SuggestNominations.__init__):
869         * Scripts/webkitpy/tool/commands/upload.py:
870         (CommitMessageForCurrentDiff):
871         (CommitMessageForCurrentDiff.__init__):
872         (CleanPendingCommit):
873         (CleanReviewQueue):
874         (AssignToCommitter):
875         (PostCommits):
876         (PostCommits.__init__):
877         (MarkBugFixed):
878         (MarkBugFixed.__init__):
879         (CreateBug):
880         (CreateBug.__init__):
881         * Scripts/webkitpy/tool/multicommandtool.py:
882         (Command):
883         (Command.__init__):
884         (Command.main):
885         (HelpCommand):
886         (HelpCommand.__init__):
887         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
888         (TrivialCommand):
889         (TrivialCommand.__init__):
890         (LikesToRetry):
891         (LikesToRetry.__init__):
892         (CommandTest.test_name_with_arguments):
893         (CommandTest.test_required_arguments):
894         (test_command_help):
895
896 2013-04-13  Ed Bartosh  <bartosh@gmail.com>
897
898         [EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
899         https://bugs.webkit.org/show_bug.cgi?id=114048
900
901         Reviewed by Gyuyoung Kim.
902
903         Wrapped view media related code in #if ENABLE(VIEW_MODE_CSS_MEDIA)
904
905         * DumpRenderTree/efl/TestRunnerEfl.cpp:
906         (TestRunner::setViewModeMediaFeature):
907
908 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
909
910         Merge watchlistloader into host since it's an unnecessary indirection
911         https://bugs.webkit.org/show_bug.cgi?id=114555
912
913         Reviewed by Antti Koivisto.
914
915         We don't need a class to load a file.
916
917         * Scripts/webkitpy/common/host.py:
918         (Host.watch_list):
919         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Removed.
920         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Removed.
921
922 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
923
924         Rename JSONResultsGeneratorBase to JSONResultsGenerator
925         https://bugs.webkit.org/show_bug.cgi?id=114553
926
927         Reviewed by Philippe Normand.
928
929         Renamed now that we've got rid of the old JSONResultsGenerator in r148352.
930
931         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
932         (JSONLayoutResultsGenerator):
933         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
934         (JSONResultsGenerator):
935         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
936         (JSONGeneratorTest._test_json_generation):
937         (JSONGeneratorTest._verify_json_results):
938
939 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
940
941         Remove more Chromium specific code from webkitpy
942         https://bugs.webkit.org/show_bug.cgi?id=114552
943
944         Reviewed by Philippe Normand.
945
946         * Scripts/webkitpy/common/host.py:
947         (Host.checkout):
948         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
949         (JSONResultsGeneratorBase):
950         (JSONResultsGeneratorBase.__init__):
951         (JSONResultsGeneratorBase._is_results_all_of_type):
952         * Scripts/webkitpy/layout_tests/port/base.py:
953         (Port):
954         (Port.expected_filename):
955         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
956         (PerfTestsRunner._parse_args):
957         * Scripts/webkitpy/tool/commands/queues.py:
958         (PatchProcessingQueue._new_port_name_from_old):
959         (CommitQueue.did_pass_testing_ews):
960         * Scripts/webkitpy/tool/commands/rebaseline.py:
961         (RebaselineTest._results_url):
962         (Rebaseline._builder_with_name):
963         * Scripts/webkitpy/tool/mocktool.py:
964         (MockTool.irc):
965
966 2013-04-13  Zan Dobersek  <zdobersek@igalia.com>
967
968         Fix flakiness dashboard unit test failures
969         https://bugs.webkit.org/show_bug.cgi?id=114518
970
971         Reviewed by Ryosuke Niwa.
972
973         Fix the current failures in unit tests for the flakiness dashboard by adjusting failing
974         test cases to simulate loading the builders list from the webkit.org build master, replacing
975         the Chromium builders and platforms that are used in tests with builders and platforms for the
976         Apple Mac Lion WebKit2 port, and removing two test cases that were testing Chromium-specific
977         functionality of the dashboard.
978
979         This is sort of an interlude to the flakiness dashboard cleanup, with the removal of Chromium-specific
980         code and hopefully general simplification of the dashboard codebase coming in near future.
981
982         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
983         (resetGlobals):
984         (test):
985         * TestResultServer/static-dashboards/loader_unittests.js:
986
987 2013-04-12  David Kilzer  <ddkilzer@apple.com>
988
989         BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS
990
991         Reviewed by Chris Fleizach.
992
993         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Declare
994         -_accessibilityPath from the WebAccessibilityObjectWrapper
995         class.
996         (_CGPathEnumerationIteration): Remove unused CGPoint* variable.
997
998 2013-04-12  Jeffrey Pfau  <jpfau@apple.com>
999
1000         Unreviewed, remove an old email address for myself.
1001
1002         * Scripts/webkitpy/common/config/committers.py:
1003
1004 2013-04-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1005
1006         [WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
1007         https://bugs.webkit.org/show_bug.cgi?id=110743
1008
1009         Reviewed by Benjamin Poulain.
1010
1011         Adding a new test file to check if loading a page just after WebProcess
1012         has crashed (or was terminated) works. The test executes the
1013         following steps (Load, Crash, Load), thus stressing WebProcess
1014         reattach and process termination code path.
1015
1016         * TestWebKitAPI/GNUmakefile.am:
1017         * TestWebKitAPI/PlatformEfl.cmake:
1018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1019         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1020         (TestWebKitAPI::setPageLoaderClient):
1021         (TestWebKitAPI::TEST):
1022         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Added.
1023         (TestWebKitAPI):
1024         (WebKit2CrashLoader):
1025         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1026         (TestWebKitAPI::WebKit2CrashLoader::loadUrl):
1027         (TestWebKitAPI::WebKit2CrashLoader::crashWebProcess):
1028         (TestWebKitAPI::didFinishLoad):
1029         (TestWebKitAPI::TEST):
1030         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1031
1032 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1033
1034         [Mac] REGRESSION: Auto substitution strips new lines
1035         https://bugs.webkit.org/show_bug.cgi?id=114537
1036
1037         Reviewed by Enrica Casucci.
1038
1039         Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.
1040
1041         * DumpRenderTree/mac/DumpRenderTree.mm:
1042         (resetDefaultsToConsistentValues):
1043
1044 2013-04-09  Roger Fong  <roger_fong@apple.com>
1045
1046         Re-enable WinEWS tests.
1047
1048         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1049         (WinEWS):
1050
1051 2013-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1052
1053         [GTK] Split GtkAuthenticationDialog in two widgets
1054         https://bugs.webkit.org/show_bug.cgi?id=103644
1055
1056         Reviewed by Xan Lopez.
1057
1058         * gtk/generate-gtkdoc:
1059         (get_webkit2_options): Do not generate api docs for
1060         WebKitAuthenticationDialog which is private in WebKit2.
1061         (get_webkit1_options): Do not generate api docs for
1062         webkitauthenticationdialog which is private in WebKit1.
1063
1064 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1065
1066         WebKit Queues should capitalize K in Wk2
1067         https://bugs.webkit.org/show_bug.cgi?id=114524
1068
1069         Reviewed by Philippe Normand.
1070
1071         * QueueStatusServer/model/queues.py:
1072         (Queue.display_name):
1073
1074 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1075
1076         [Mac] Enable spellchecking tests added in r141471
1077         https://bugs.webkit.org/show_bug.cgi?id=108525
1078
1079         Reviewed by Darin Adler.
1080
1081         * DumpRenderTree/mac/DumpRenderTree.mm:
1082         (createWebViewAndOffscreenWindow):
1083         (resetDefaultsToConsistentValues):
1084         * WebKitTestRunner/TestController.cpp:
1085         (WTR::TestController::resetStateToConsistentValues):
1086
1087 2013-04-12  Manuel Rego Casasnovas  <rego@igalia.com>
1088
1089         [GTK] Enable WebKit2 building on GTK EWSs
1090         https://bugs.webkit.org/show_bug.cgi?id=114500
1091
1092         Reviewed by Philippe Normand.
1093
1094         Add configuration in order to be able to setup GTK EWSs building
1095         WebKit2. A new queue gtk-wk2-ews is added.
1096
1097         * QueueStatusServer/config/queues.py:
1098         * Scripts/webkitpy/common/config/ports.py:
1099         (DeprecatedPort.port):
1100         (GtkWK2Port):
1101         (GtkWK2Port.build_webkit_command):
1102         (GtkWK2Port.run_webkit_tests_command):
1103         * Scripts/webkitpy/common/config/ports_unittest.py:
1104         (DeprecatedPortTest.test_gtk_port):
1105         (DeprecatedPortTest):
1106         (DeprecatedPortTest.test_gtk_wk2_port):
1107         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1108         (GtkWK2EWS):
1109
1110 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1111
1112         Remove Chromium scripts
1113         https://bugs.webkit.org/show_bug.cgi?id=114492
1114
1115         Reviewed by Benjamin Poulain.
1116
1117         * Scripts/run-chromium-webkit-unit-tests: Removed.
1118         * Scripts/update-webkit-chromium: Removed.
1119
1120 2013-04-12  Commit Queue  <rniwa@webkit.org>
1121
1122         Unreviewed, rolling out r148262.
1123         http://trac.webkit.org/changeset/148262
1124         https://bugs.webkit.org/show_bug.cgi?id=114493
1125
1126         Cairo dep should now build, rolling r148247 back in (Requested
1127         by zdobersek on #webkit).
1128
1129         * Scripts/webkitdirs.pm:
1130         (buildAutotoolsProject):
1131         * gtk/jhbuild.modules:
1132
1133 2013-04-11  Commit Queue  <rniwa@webkit.org>
1134
1135         Unreviewed, rolling out r148247.
1136         http://trac.webkit.org/changeset/148247
1137         https://bugs.webkit.org/show_bug.cgi?id=114490
1138
1139         Cairo dep fails to build on builders due to missing EGL
1140         headers (Requested by zdobersek on #webkit).
1141
1142         * Scripts/webkitdirs.pm:
1143         (buildAutotoolsProject):
1144         * gtk/jhbuild.modules:
1145
1146 2013-04-11  Martin Robinson  <mrobinson@igalia.com>
1147
1148         [GTK] Add accelerated 2D canvas support using cairo-gl
1149         https://bugs.webkit.org/show_bug.cgi?id=104672
1150
1151         Reviewed by Alejandro G. Castro.
1152
1153         Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
1154         dependencies, don't override value of the setting determined by configure.
1155         This will make it easier for people using build-webkit, but not the
1156         WebKit JHBuild.
1157
1158         * Scripts/webkitdirs.pm:
1159         (buildAutotoolsProject): Add a blacklist for settings to never override.
1160         * gtk/jhbuild.modules: Build CairoGL.
1161
1162 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1163
1164         build.webkit.org should link to webkit-queues instead of webkit-commit-queue
1165         https://bugs.webkit.org/show_bug.cgi?id=114477
1166
1167         Reviewed by Benjamin Poulain.
1168
1169         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1170
1171 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1172
1173         Leaks builder should not be triggered upon new commits
1174         https://bugs.webkit.org/show_bug.cgi?id=114475
1175
1176         Reviewed by Jessie Berlin.
1177
1178         Don't trigger them on new checkins. Wait for Mountain Lion (Build), which already triggers
1179         the leak builder when builds are done.
1180
1181         * BuildSlaveSupport/build.webkit.org-config/config.json:
1182
1183 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
1184
1185         [GTK] Windows build failure after r136056
1186         https://bugs.webkit.org/show_bug.cgi?id=114121
1187
1188         Reviewed by Martin Robinson.
1189
1190         * TestWebKitAPI/config.h: Make sure defines are correct for other
1191         Windows ports than apple-win.
1192
1193 2013-04-11  Ojan Vafai  <ojan@chromium.org>
1194
1195         Remove myself from watchlists.
1196         * Scripts/webkitpy/common/config/watchlist:
1197
1198 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1199
1200         Build fix. Don't hard-code queues.webkit.org at least during the transition.
1201
1202         * QueueStatusServer/templates/statusbubble.html:
1203
1204 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1205
1206         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
1207         https://bugs.webkit.org/show_bug.cgi?id=114397
1208
1209         Reviewed by Benjamin Poulain.
1210
1211         Reland the patch since Alan appears to have finished the migration.
1212
1213         * Scripts/webkitpy/common/net/statusserver.py:
1214         (StatusServer):
1215
1216 2013-04-11  Brian Holt  <brian.holt@samsung.com>
1217
1218         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
1219         https://bugs.webkit.org/show_bug.cgi?id=76796
1220
1221         Reviewed by Chris Fleizach.
1222
1223         Make the Gtk window for the DRT a toplevel so that it gets the
1224         focus from the window manager when the test starts.
1225
1226         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1227         (main):
1228
1229 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1230
1231         Use CSS4 image-rendering to determing image scaling quality
1232         https://bugs.webkit.org/show_bug.cgi?id=113405
1233
1234         Reviewed by Simon Fraser.
1235
1236         Introduce new flag to enable experimental support for CSS4 Images.
1237
1238         * Scripts/webkitperl/FeatureList.pm:
1239
1240 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1241
1242         Remove code for Chromium from wkbuild.py
1243         https://bugs.webkit.org/show_bug.cgi?id=114423
1244
1245         Reviewed by Benjamin Poulain.
1246
1247         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1248         (_should_file_trigger_build):
1249         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1250         (ShouldBuildTest):
1251
1252 2013-04-11  Philippe Normand  <pnormand@igalia.com>
1253
1254         Unreviewed, update my IRC nickname.
1255
1256         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
1257
1258 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1259
1260         Remove the rest of Chromium code from webkitpy
1261         https://bugs.webkit.org/show_bug.cgi?id=114420
1262
1263         Reviewed by Benjamin Poulain.
1264
1265         * Scripts/webkitpy/common/config/urls.py:
1266         (view_revision_url):
1267         * Scripts/webkitpy/common/host.py:
1268         (Host._engage_awesome_locale_hacks):
1269         (Host.initialize_scm):
1270         (Host):
1271         * Scripts/webkitpy/common/host_mock.py:
1272         (MockHost.__init__):
1273         (MockHost.checkout):
1274         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
1275         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1276         (JSONResultsGeneratorBase._insert_generic_metadata):
1277         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1278         (TestExpectationParser._tokenize_line):
1279         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1280         (ExpectationSyntaxTests.test_bare_name_and_bugs):
1281         (ExpectationSyntaxTests.test_warnings):
1282         * Scripts/webkitpy/layout_tests/port/base.py:
1283         (Port.skips_perf_test):
1284         (Port.path_to_test_expectations_file):
1285         (Port._port_flag_for_scripts):
1286         * Scripts/webkitpy/style/checkers/cpp.py:
1287         (check_function_definition):
1288         (check_include_line):
1289         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1290         (OrderOfIncludesTest.test_check_wtf_includes):
1291         (WebKitStyleTest.test_webkit_export_check):
1292         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1293         (TestExpectationsTestCase.test_valid_expectations):
1294         * Scripts/webkitpy/tool/bot/irc_command.py:
1295         (Rollout.execute):
1296         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1297         (IRCCommandTest.test_whois):
1298         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1299         (IRCBotTest.test_help):
1300         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1301         (SheriffBotTest.test_command_aliases):
1302
1303 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1304
1305         roll-chromium-deps doesn't roll DEPS
1306         https://bugs.webkit.org/show_bug.cgi?id=114421
1307
1308         Reviewed by Antti Koivisto.
1309
1310         Roll DEPS. Rolling DEPS. Rolled DEPS.
1311
1312         * Scripts/webkitpy/tool/bot/irc_command.py:
1313         (RollChromiumDEPS.execute):
1314
1315 2013-04-11  Glenn Adams  <glenn@skynav.com>
1316
1317         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
1318         https://bugs.webkit.org/show_bug.cgi?id=114418
1319
1320         Reviewed by Ryosuke Niwa.
1321
1322         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1323         (MockSCM.add): Remove optional remove_exit_code argument.
1324         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
1325         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1326         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
1327         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
1328
1329 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1330
1331         Fix roll-chromium-deps and hi.
1332
1333         * Scripts/webkitpy/tool/bot/irc_command.py:
1334         (Hi.execute):
1335         (RollChromiumDEPS.execute):
1336
1337 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1338
1339         Remove webkitpy code to roll Chromium DEPS
1340         https://bugs.webkit.org/show_bug.cgi?id=114415
1341
1342         Reviewed by Benjamin Poulain.
1343
1344         Removed the code to roll Chromium DEPS in WebKit.
1345
1346         * Scripts/webkitpy/common/checkout/checkout.py:
1347         (Checkout.bug_id_for_this_commit):
1348         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1349         (MockCheckout.commit_message_for_this_commit):
1350         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1351         (CheckoutTest.test_suggested_reviewers):
1352         * Scripts/webkitpy/common/checkout/deps.py: Removed.
1353         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
1354         * Scripts/webkitpy/tool/bot/irc_command.py:
1355         (RollChromiumDEPS): Teach webkitbot a sense of humor.
1356         (RollChromiumDEPS.execute):
1357         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1358         (IRCCommandTest.test_create_bug):
1359         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1360         (IRCBotTest.test_revert):
1361         * Scripts/webkitpy/tool/bot/sheriff.py:
1362         (Sheriff.post_rollout_patch):
1363         * Scripts/webkitpy/tool/commands/__init__.py:
1364         * Scripts/webkitpy/tool/commands/roll.py: Removed.
1365         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
1366         * Scripts/webkitpy/tool/steps/__init__.py:
1367         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
1368         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
1369         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
1370
1371 2013-04-11  Glenn Adams  <glenn@skynav.com>
1372
1373         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
1374         https://bugs.webkit.org/show_bug.cgi?id=114386
1375
1376         Reviewed by Benjamin Poulain.
1377
1378         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
1379         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
1380         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
1381         by default and to return exit code 1 if a file/dir had already been added.
1382
1383         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1384         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
1385         * Scripts/webkitpy/common/checkout/scm/svn.py:
1386         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
1387
1388 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1389
1390         Unreviewed.
1391
1392         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
1393
1394 2013-04-10  Glenn Adams  <glenn@skynav.com>
1395
1396         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
1397         https://bugs.webkit.org/show_bug.cgi?id=114410
1398
1399         Reviewed by Ryosuke Niwa.
1400
1401         * Scripts/webkitpy/common/checkout/scm/git.py:
1402         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
1403         * Scripts/webkitpy/common/checkout/scm/scm.py:
1404         (SCM.add): Remove optional return_exit_code argument.
1405         (SCM.add_list): Remove optional return_exit_code argument.
1406         * Scripts/webkitpy/common/checkout/scm/svn.py:
1407         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
1408
1409 2013-04-10  Eric Seidel  <eric@webkit.org>
1410
1411         Remove myself from the watchlists, I'm getting too much bug mail. :)
1412
1413         * Scripts/webkitpy/common/config/watchlist:
1414
1415 2013-04-10  Commit Queue  <rniwa@webkit.org>
1416
1417         Unreviewed, rolling out r148158.
1418         http://trac.webkit.org/changeset/148158
1419         https://bugs.webkit.org/show_bug.cgi?id=114405
1420
1421         We need to migrate status data (Requested by rniwa on
1422         #webkit).
1423
1424         * Scripts/webkitpy/common/net/statusserver.py:
1425         (StatusServer):
1426
1427 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
1428
1429         Mass remove all the empty directories
1430
1431         Rubberstamped by Ryosuke Niwa.
1432
1433         * BuildSlaveSupport/gtk/crashmon/log: Removed.
1434         * BuildSlaveSupport/gtk/xvfb/log: Removed.
1435         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
1436         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
1437         * MiniBrowser/gtk/WebBundle: Removed.
1438         * MiniBrowser/win: Removed.
1439         * QtTestPlatformPlugin/mac: Removed.
1440         * Scripts/webkitpy/tool/bot/testdata: Removed.
1441         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
1442         * efl/ImageDiff: Removed.
1443         * iExploder/htdocs: Removed.
1444         * iExploder/iexploder-1.7.2/output: Removed.
1445         * iExploder/tools: Removed.
1446         * qmake/config.tests/libexecdir: Removed.
1447         * qmake/config.tests/libjpeg: Removed.
1448         * qmake/config.tests/libpng: Removed.
1449
1450 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1451
1452         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
1453         https://bugs.webkit.org/show_bug.cgi?id=114397
1454
1455         Reviewed by Benjamin Poulain.
1456
1457         * Scripts/webkitpy/common/net/statusserver.py:
1458         (StatusServer):
1459
1460 2013-04-10  Adam Barth  <abarth@webkit.org>
1461
1462         Remove abarth from watchlists
1463         https://bugs.webkit.org/show_bug.cgi?id=114390
1464
1465         Reviewed by Ryosuke Niwa.
1466
1467         I'm trying to cut down on the amount of bugmail I get so that I'll have
1468         more of a chance to notice a piece of bugmail directed at me.
1469
1470         * Scripts/webkitpy/common/config/watchlist:
1471
1472 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1473
1474         webkit-test-results.appspot.com loads the dashboard for Chromium by default
1475         https://bugs.webkit.org/show_bug.cgi?id=114381
1476
1477         Reviewed by Benjamin Poulain.
1478
1479         Changed the defaults.
1480
1481         * TestResultServer/static-dashboards/builders.js:
1482         * TestResultServer/static-dashboards/dashboard_base.js:
1483         (currentBuilderGroupCategory):
1484
1485 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1486
1487         Remove Chromium EWS bots from the queue status server
1488         https://bugs.webkit.org/show_bug.cgi?id=113988
1489
1490         Reviewed by Benjamin Poulain.
1491
1492         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
1493
1494         * QueueStatusServer/app.yaml:
1495         * QueueStatusServer/config/queues.py:
1496         * QueueStatusServer/model/queues.py:
1497         (Queue.short_name):
1498         (Queue.display_name):
1499         * QueueStatusServer/model/queues_unittest.py:
1500         (QueueTest.test_short_name):
1501         (QueueTest.test_display_name):
1502         (QueueTest.test_name_with_underscores):
1503         * QueueStatusServer/templates/activebots.html:
1504
1505 2013-04-10  Ojan Vafai  <ojan@chromium.org>
1506
1507         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
1508         https://bugs.webkit.org/show_bug.cgi?id=114370
1509
1510         Reviewed by Ryosuke Niwa.
1511
1512         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
1513         Unfortunately, there's no way to test this until this is committed and there is
1514         a master restart.
1515
1516         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1517         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1519         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1520         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1521         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1522         * TestResultServer/generate_builders_json.py:
1523         * TestResultServer/static-dashboards/dashboard_base.js:
1524         * TestResultServer/static-dashboards/loader.js:
1525
1526 2013-04-10  Glenn Adams  <glenn@skynav.com>
1527
1528         [Qt] Fix regression to test-webkitpy.
1529         https://bugs.webkit.org/show_bug.cgi?id=114368
1530
1531         Reviewed by Ryosuke Niwa.
1532
1533         * Scripts/webkitpy/layout_tests/port/factory.py:
1534         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
1535         (PortFactory.get): Remove obsolete chromium port related code.
1536         * Scripts/webkitpy/layout_tests/port/mac.py:
1537         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
1538
1539 2013-04-10  Anders Carlsson  <andersca@apple.com>
1540
1541         Remove unneeded headers from FrameLoader.h
1542         https://bugs.webkit.org/show_bug.cgi?id=114223
1543
1544         Reviewed by Geoffrey Garen.
1545
1546         Add back headers implicitly included by other headers.
1547
1548         * WebKitTestRunner/WorkQueueManager.cpp:
1549
1550 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1551
1552         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
1553         https://bugs.webkit.org/show_bug.cgi?id=114365
1554
1555         Reviewed by Martin Robinson.
1556
1557         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
1558         The patch addresses crashes in the tally_event_reply method. It is already committed into the
1559         at-spi2-atk source tree and will be available with the next stable release, after which the
1560         patch should be removed and the dependency version bumped.
1561
1562         * gtk/jhbuild.modules:
1563         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
1564
1565 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
1566
1567         [WinCairo] Unreviewed build fix. Correct DropBox download link.
1568
1569         * Scripts/update-webkit-wincairo-libs: Revise download URL to
1570         match change in DropBox server behavior.
1571
1572 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
1573
1574         Removed an annoying message from svn-create-patch
1575         https://bugs.webkit.org/show_bug.cgi?id=114332
1576
1577         Reviewed by Alexey Proskuryakov.
1578
1579         I see this message basically every time I write a patch, so it must not
1580         be true.
1581
1582         * Scripts/svn-create-patch:
1583         (generateDiff):
1584
1585 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
1586
1587         [GTK] Add support for Page Visibility
1588         https://bugs.webkit.org/show_bug.cgi?id=97324
1589
1590         Reviewed by Sam Weinig.
1591
1592         Implemented test runner API for page visibility layout tests.
1593
1594         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1595         (TestRunner::resetPageVisibility):
1596         (TestRunner::setPageVisibility):
1597         * Scripts/webkitperl/FeatureList.pm:
1598
1599 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1600
1601         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
1602         https://bugs.webkit.org/show_bug.cgi?id=114342
1603
1604         Reviewed by Gyuyoung Kim.
1605
1606         Commit 148033 only added an implementation for the Mac port, which made
1607         other ports fail most tests since loading the injected bundle failed
1608         with a missing symbol.
1609
1610         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1611         (WTR::AccessibilityUIElement::pathDescription):
1612
1613 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
1614
1615         [EFL] Add spell checking option to MiniBrowser
1616         https://bugs.webkit.org/show_bug.cgi?id=114282
1617
1618         Reviewed by Ryosuke Niwa.
1619
1620         Spell checking is enabled by adding a flag (t/text-checking)
1621         with launching MiniBrowser.
1622
1623         * MiniBrowser/efl/main.c:
1624         (window_create):
1625         (elm_main):
1626
1627 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1628
1629         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
1630         https://bugs.webkit.org/show_bug.cgi?id=113281
1631
1632         Reviewed by Darin Adler.
1633
1634         * Scripts/run-gtk-tests:
1635         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
1636
1637 2013-04-09  Glenn Adams  <glenn@skynav.com>
1638
1639         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
1640
1641         Unreviewed.
1642
1643         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1644         (RunTest.test_build_check):
1645
1646 2013-04-09  Glenn Adams  <glenn@skynav.com>
1647
1648         [webkitpy] Remove chromium ports.
1649         https://bugs.webkit.org/show_bug.cgi?id=114326
1650
1651         Reviewed by Dirk Pranke.
1652
1653         As a side effect, also:
1654
1655         - remove chromium builders from webkitpy.layout_tests.port.builders
1656         - remove chromium builders from rebaseline
1657         - rewrite chromium dependent tests in rebaseline_unittest
1658         - remove chromium platform from garden-o-matic
1659         - select apple platform as default platform in garden-o-matic
1660         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
1661
1662         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1663         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1664         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1665         (BaselineOptimizerTest.test_move_baselines):
1666         (BaselineOptimizerTest.test_efl):
1667         (BaselineOptimizerTest.test_no_add_mac_future):
1668         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1669         (BaselineOptimizerTest.test_common_directory_includes_root):
1670         (BaselineOptimizerTest.test_complex_shadowing):
1671         (BaselineOptimizerTest.test_virtual_ports_filtered):
1672         * Scripts/webkitpy/layout_tests/port/builders.py:
1673         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
1674         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
1675         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
1676         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
1677         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
1678         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
1679         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
1680         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
1681         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
1682         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
1683         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
1684         * Scripts/webkitpy/layout_tests/port/factory.py:
1685         (platform_options):
1686         (PortFactory):
1687         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1688         (FactoryTest.test_qt):
1689         (FactoryTest.test_get_from_builder_name):
1690         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1691         (RunTest.test_build_check):
1692         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1693         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1694         * Scripts/webkitpy/tool/commands/rebaseline.py:
1695         (Rebaseline._builders_to_pull_from):
1696         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1697         (_BaseTestCase):
1698         (_BaseTestCase.setUp):
1699         (TestRebaselineTest.setUp):
1700         (TestRebaselineTest.test_baseline_directory):
1701         (test_rebaseline_updates_expectations_file):
1702         (test_rebaseline_does_not_include_overrides):
1703         (test_rebaseline_test):
1704         (test_rebaseline_test_and_print_scm_changes):
1705         (test_rebaseline_and_copy_test):
1706         (test_rebaseline_and_copy_test_no_existing_result):
1707         (test_rebaseline_and_copy_test_with_lion_result):
1708         (test_rebaseline_and_copy_no_overwrite_test):
1709         (TestRebaselineExpectations.test_rebaseline_expectations):
1710
1711 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1712
1713         newcommitbot (WKR) requires a subversion checkout
1714         https://bugs.webkit.org/show_bug.cgi?id=114309
1715
1716         Reviewed by Benjamin Poulain.
1717
1718         Directly talk to the subversion server instead of relying on a local checkout.
1719         This allows us to run WKR off of a git clone.
1720
1721         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1722         (NewCommitBot.next_work_item):
1723         (NewCommitBot.process_work_item):
1724
1725 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1726
1727         webkitbot refers to sheriffbot in help
1728         https://bugs.webkit.org/show_bug.cgi?id=114307
1729
1730         Reviewed by Benjamin Poulain.
1731
1732         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
1733
1734         * Scripts/webkitpy/tool/bot/irc_command.py:
1735         (Help):
1736         (Help.execute):
1737         (RollChromiumDEPS.execute):
1738         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1739         (IRCBotTest.test_help):
1740         * Scripts/webkitpy/tool/bot/sheriff.py:
1741         (Sheriff.name):
1742
1743 2013-04-06  Roger Fong  <roger_fong@apple.com>
1744
1745         Kill old processes between runs on WinEWS bots.
1746         Temporarily disable tests to let bots catch up again.
1747
1748         * EWSTools/start-queue-win.sh:
1749         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1750         (WinEWS):
1751
1752 2013-04-09  Glenn Adams  <glenn@skynav.com>
1753
1754         [webkitpy] Remove chromium deprecated port support.
1755         https://bugs.webkit.org/show_bug.cgi?id=114228
1756
1757         Reviewed by Ryosuke Niwa.
1758
1759         * Scripts/webkitpy/common/config/ports.py:
1760         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
1761         (ChromiumPort): Removed.
1762         (ChromiumAndroidPort): Removed.
1763         (ChromiumXVFBPort): Removed.
1764         * Scripts/webkitpy/common/config/ports_unittest.py:
1765         (DeprecatedPortTest.test_chromium_port): Removed.
1766         (DeprecatedPortTest.test_chromium_android_port): Removed.
1767         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
1768         * Scripts/webkitpy/tool/steps/update_unittest.py:
1769         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
1770         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
1771
1772 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
1773
1774         AX: The bounding paths should be made available through accessibility
1775         https://bugs.webkit.org/show_bug.cgi?id=113817
1776
1777         Reviewed by David Kilzer.
1778
1779         Add a pathDescription property for testing so that it's possible
1780         to verify that a path is being returned correctly.
1781
1782         * DumpRenderTree/AccessibilityUIElement.cpp:
1783         (getPathDescriptionCallback):
1784         (AccessibilityUIElement::pathDescription):
1785         (AccessibilityUIElement::getJSClass):
1786         * DumpRenderTree/AccessibilityUIElement.h:
1787         (AccessibilityUIElement):
1788         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1789         (_CGPathEnumerationIteration):
1790         (AccessibilityUIElement::pathDescription):
1791         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1792         (AccessibilityUIElement::pathDescription):
1793         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1794         (WTR::AccessibilityUIElement::pathDescription):
1795         (WTR):
1796         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1797         (AccessibilityUIElement):
1798         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1799         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1800         (WTR::AccessibilityUIElement::pathDescription):
1801         (WTR):
1802
1803 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1804
1805         [EFL] Declare TEST_THEME_DIR in a single place.
1806         https://bugs.webkit.org/show_bug.cgi?id=114285
1807
1808         Reviewed by Anders Carlsson.
1809
1810         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
1811
1812         * DumpRenderTree/efl/CMakeLists.txt:
1813         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1814         (DumpRenderTreeChrome::createView):
1815         (DumpRenderTreeChrome::createInspectorView):
1816         (DumpRenderTreeChrome::initialize):
1817         (DumpRenderTreeChrome::onDownloadRequest):
1818         * EWebLauncher/CMakeLists.txt:
1819         * EWebLauncher/main.c:
1820         (findThemePath):
1821         * EWebLauncher/url_bar.c:
1822         (url_bar_add):
1823         * MiniBrowser/efl/CMakeLists.txt:
1824         * MiniBrowser/efl/main.c:
1825         (window_create):
1826         * TestWebKitAPI/PlatformEfl.cmake:
1827         * TestWebKitAPI/efl/PlatformWebView.cpp:
1828         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1829         * WebKitTestRunner/PlatformEfl.cmake:
1830         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1831         (WTR::PlatformWebView::PlatformWebView):
1832
1833 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
1834
1835         [GTK][AC] upversion of clutter and its dependecy
1836         https://bugs.webkit.org/show_bug.cgi?id=114016
1837
1838         Reviewed by Gustavo Noronha Silva.
1839
1840         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
1841
1842         * gtk/jhbuild-optional.modules:
1843
1844 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1845
1846         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
1847         https://bugs.webkit.org/show_bug.cgi?id=89875
1848
1849         Reviewed by Maciej Stachowiak.
1850
1851         Add unit tests to verify if the handling of the open, openat, creat syscall
1852         is being done right. We check if the Read/Write/ReadAndWrite permissions
1853         are respected, if the canonical path is being resolved and if
1854         the permissions are falling back to the topmost parent directory with a
1855         policy set when the directory being opened has no policy.
1856
1857         We also test if any attempt of blocking SIGSYS is silently ignored.
1858         SIGSYS cannot be blocked because in it's handler is where we hook
1859         syscalls to the broker process.
1860
1861         Also added libseccomp to EFL's jhbuild to make the life of developers
1862         willing to help easier.
1863
1864         * Scripts/webkitperl/FeatureList.pm:
1865         * TestWebKitAPI/PlatformEfl.cmake:
1866         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
1867         (TestWebKitAPI):
1868         (SeccompEnvironment):
1869         (TestWebKitAPI::SeccompEnvironment::SetUp):
1870         (TestWebKitAPI::SeccompEnvironment::TearDown):
1871         (TestWebKitAPI::dummyHandler):
1872         (TestWebKitAPI::TEST):
1873         (TestWebKitAPI::stressTest):
1874         * efl/jhbuild.modules:
1875         * qmake/mkspecs/features/features.pri:
1876
1877 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1878
1879         REGRESSION: Autocorrection doesn't work in DumpRenderTree
1880         https://bugs.webkit.org/show_bug.cgi?id=113846
1881
1882         Reviewed by Alexey Proskuryakov.
1883
1884         The problem was that we were replacing NSSpellCheck's dictionary with our own
1885         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
1886
1887         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
1888         and "would" respectively in DumpRenderTree.
1889
1890         * DumpRenderTree/mac/DumpRenderTree.mm:
1891         (resetDefaultsToConsistentValues):
1892
1893 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
1894
1895         Remove the gyp files for Tools
1896         https://bugs.webkit.org/show_bug.cgi?id=114248
1897
1898         Reviewed by Ryosuke Niwa.
1899
1900         * DumpRenderTree/DumpRenderTree.gyp: Removed.
1901         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
1902         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
1903         * DumpRenderTree/DumpRenderTree.gypi: Removed.
1904         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
1905         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
1906         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
1907         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
1908
1909 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1910
1911         WKR (new-commit-bot) is too slow
1912         https://bugs.webkit.org/show_bug.cgi?id=110087
1913
1914         Reviewed by Geoffrey Garen.
1915
1916         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
1917         Just run "svn log -r <revision>" instead to cut down the delay.
1918
1919         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
1920
1921         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1922         (NewCommitBot):
1923         (NewCommitBot.next_work_item):
1924         (NewCommitBot._is_empty_log):
1925         (NewCommitBot._update_checkout):
1926
1927 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1928
1929         Build fix. Can't remove appendCustomBuildFlags.
1930
1931         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1932         (appendCustomBuildFlags):
1933
1934 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1935
1936         Remove Chromium builders from build.webkit.org
1937         https://bugs.webkit.org/show_bug.cgi?id=113990
1938
1939         Reviewed by Benjamin Poulain.
1940
1941         Removed.
1942
1943         * BuildSlaveSupport/build.webkit.org-config/config.json:
1944         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1945         (InstallGtkDependencies):
1946         (RunUnitTests.start):
1947         (RunWebKit2Tests.start):
1948         (Factory.__init__):
1949         (unitTestsSupported):
1950         (TestFactory.__init__):
1951         (BuildAndTestFactory.__init__):
1952         (BuildAndPerfTestFactory.__init__):
1953         (BuildAndPerfTestWebKit2Factory.__init__):
1954         (DownloadAndPerfTestFactory.__init__):
1955         (loadBuilderConfig):
1956         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1957
1958 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
1959
1960         Remove HTML Notification
1961         https://bugs.webkit.org/show_bug.cgi?id=114231
1962
1963         Reviewed by Ryosuke Niwa.
1964
1965         * qmake/mkspecs/features/features.pri:
1966
1967 2013-04-08  Glenn Adams  <glenn@skynav.com>
1968
1969         Remove chromium EWS support, and fix broken test.
1970         https://bugs.webkit.org/show_bug.cgi?id=114221
1971
1972         Reviewed by Ryosuke Niwa.
1973
1974         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1975         (AbstractChromiumEWS): Removed.
1976         (ChromiumLinuxEWS): Removed.
1977         (ChromiumLinuxDebugEWS): Removed.
1978         (ChromiumWindowsEWS): Removed.
1979         (ChromiumAndroidEWS): Removed.
1980         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1981         (EarlyWarningSystemTest): Fix misspelled class name.
1982         (test_ewses): Fix entry point name to ensure test is run.
1983
1984 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
1985
1986         [WIN] Remove WebKit2 source code
1987         https://bugs.webkit.org/show_bug.cgi?id=114096
1988
1989         Reviewed by Anders Carlsson.
1990
1991         Remove the windows specific parts of the MiniBrowser.
1992
1993         * MiniBrowser/MiniBrowser.vcproj: Removed.
1994         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
1995         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
1996         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
1997         * MiniBrowser/win/BrowserView.cpp: Removed.
1998         * MiniBrowser/win/BrowserView.h: Removed.
1999         * MiniBrowser/win/BrowserWindow.cpp: Removed.
2000         * MiniBrowser/win/BrowserWindow.h: Removed.
2001         * MiniBrowser/win/MiniBrowser.cpp: Removed.
2002         * MiniBrowser/win/MiniBrowser.h: Removed.
2003         * MiniBrowser/win/MiniBrowser.rc: Removed.
2004         * MiniBrowser/win/main.cpp: Removed.
2005         * MiniBrowser/win/resource.h: Removed.
2006         * MiniBrowser/win/stdafx.cpp: Removed.
2007         * MiniBrowser/win/stdafx.h: Removed.
2008
2009 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
2010
2011         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
2012
2013         * Scripts/webkitpy/common/config/irc.py:
2014
2015 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
2016
2017         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
2018         https://bugs.webkit.org/show_bug.cgi?id=113139
2019
2020         Reviewed by Anders Carlsson.
2021
2022         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2023         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2024         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2025         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
2026         (ToStringAndValueOfObject):
2027         (ToStringAndValueOfObject::ToStringAndValueOfObject):
2028         (ScriptableObject):
2029         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
2030         (ToStringAndValueOfObject::ScriptableObject::invoke):
2031         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
2032         (ToStringAndValueOfObject::NPP_GetValue):
2033         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2034         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2035         * GNUmakefile.am:
2036
2037 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
2038
2039         [GTK] Bump gnome-themes-standard to 3.6.0
2040         https://bugs.webkit.org/show_bug.cgi?id=114155
2041
2042         Reviewed by Martin Robinson.
2043
2044         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
2045         dependency of gnome-themes-standard accordingly.
2046
2047 2013-04-08  David Levin  <levin@chromium.org>
2048
2049         Remove my watchlist entries.
2050         https://bugs.webkit.org/show_bug.cgi?id=114180
2051
2052         Reviewed by Adam Barth.
2053
2054         * Scripts/webkitpy/common/config/committers.py:
2055         * Scripts/webkitpy/common/config/watchlist:
2056
2057 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2058
2059         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
2060         https://bugs.webkit.org/show_bug.cgi?id=114161
2061
2062         Reviewed by Gyuyoung Kim.
2063
2064         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
2065         as it is crashing due to Bug 111074.
2066
2067         * TestWebKitAPI/PlatformEfl.cmake:
2068
2069 2013-04-07  David Kilzer  <ddkilzer@apple.com>
2070
2071         Remove the rest of SVG_DOM_OBJC_BINDINGS
2072         <http://webkit.org/b/114112>
2073
2074         Reviewed by Geoffrey Garen.
2075
2076         * Scripts/webkitperl/FeatureList.pm:
2077         - Remove --svg-dom-objc-bindings switch.
2078         * qmake/mkspecs/features/features.pri:
2079         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
2080
2081 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
2082
2083         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
2084         https://bugs.webkit.org/show_bug.cgi?id=114089
2085
2086         Reviewed by Chris Fleizach.
2087
2088         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
2089         * DumpRenderTree/AccessibilityController.cpp:
2090         * DumpRenderTree/AccessibilityUIElement.cpp:
2091         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2092         (DumpRenderTreeChrome::DumpRenderTreeChrome):
2093         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2094         (DumpRenderTreeChrome):
2095
2096 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
2097
2098         Build fix after r147857, remove remaining USE(JSC) guards.
2099
2100         Unreviewed.
2101
2102         * DumpRenderTree/config.h:
2103         * TestWebKitAPI/config.h:
2104         * WebKitTestRunner/config.h:
2105
2106 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2107
2108         Rename sheriffbot to webkitbot
2109         https://bugs.webkit.org/show_bug.cgi?id=114109
2110
2111         Reviewed by Benjamin Poulain.
2112
2113         Renamed since sheriffbot will be used in Blink.
2114
2115         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2116         (SheriffBot):
2117         (SheriffBot.begin_work_queue):
2118
2119 2013-04-06  Oliver Hunt  <oliver@apple.com>
2120
2121         Unify the many and varied stack trace mechanisms, and make the result sane.
2122         https://bugs.webkit.org/show_bug.cgi?id=114072
2123
2124         Reviewed by Filip Pizlo.
2125
2126         The commandline jsc executable no longer requires arguments, so
2127         I've made run-jsc work without them.
2128
2129         * Scripts/run-jsc:
2130
2131 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
2132
2133         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
2134         https://bugs.webkit.org/show_bug.cgi?id=114086
2135
2136         Reviewed by Tim Horton.
2137
2138         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
2139
2140 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
2141
2142         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
2143         https://bugs.webkit.org/show_bug.cgi?id=114083
2144
2145         Reviewed by Ryosuke Niwa.
2146
2147         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
2148         in TestWebKitAPI and WebKitTestRunner.
2149
2150         * TestWebKitAPI/config.h:
2151         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2152         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2153         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2154         (WTR::InjectedBundle::platformInitialize):
2155
2156 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
2157
2158         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
2159         https://bugs.webkit.org/show_bug.cgi?id=114094
2160
2161         Reviewed by Anders Carlsson.
2162
2163         * Scripts/run-jsc:
2164
2165 2013-04-05  Ojan Vafai  <ojan@chromium.org>
2166
2167         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
2168         https://bugs.webkit.org/show_bug.cgi?id=114080
2169
2170         Reviewed by Ryosuke Niwa.
2171
2172         This way, the WebKit and Blink dashboard code can change as appropriate without
2173         needing to consider the other project's needs. This still doesn't update the
2174         buildbots to upload to the new location, or the dashboard code to pull the
2175         results.json files from the new location, but it at least allows for changing the
2176         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
2177
2178         * TestResultServer/app.yaml:
2179
2180 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2181
2182         Re-enable testing on the commit queue
2183         https://bugs.webkit.org/show_bug.cgi?id=114078
2184
2185         Reviewed by Darin Adler.
2186
2187         Re-enabled the feature and the associated tests.
2188
2189         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2190         (CommitQueueTask.run):
2191         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2192         (CommitQueueTaskTest._run_through_task):
2193         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2194         (CommitQueueTest._mock_test_result):
2195
2196 2013-04-05  Oliver Hunt  <oliver@apple.com>
2197
2198         Unify the many and varied stack trace mechanisms, and make the result sane.
2199         https://bugs.webkit.org/show_bug.cgi?id=114072
2200
2201         Reviewed by Filip Pizlo.
2202
2203         The commandline jsc executable no longer requires arguments, so
2204         I've made run-jsc work without them.
2205
2206         * Scripts/run-jsc:
2207
2208 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
2209
2210         AX: Make SVG Group containers accessible elements
2211         https://bugs.webkit.org/show_bug.cgi?id=113939
2212
2213         Reviewed by Simon Fraser.
2214
2215         Implement axController.elementAtPoint for iOS.
2216         Implement a correct version of clickPoint for iOS.
2217
2218         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2219         (AccessibilityController::elementAtPoint):
2220         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2221         (AccessibilityUIElement::clickPointX):
2222         (AccessibilityUIElement::clickPointY):
2223
2224 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2225
2226         Unreviewed, rolling out r147773 and r147774.
2227         http://trac.webkit.org/changeset/147773
2228         http://trac.webkit.org/changeset/147774
2229         https://bugs.webkit.org/show_bug.cgi?id=114056
2230
2231         Causing some exceptions on AppEngine I don't understand
2232         (Requested by rniwa on #webkit).
2233
2234         * QueueStatusServer/config/queues.py:
2235         * QueueStatusServer/model/queues.py:
2236         (Queue.short_name):
2237         (Queue.display_name):
2238         * QueueStatusServer/model/queues_unittest.py:
2239         (QueueTest.test_short_name):
2240         (QueueTest.test_display_name):
2241         (QueueTest.test_name_with_underscores):
2242
2243 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
2244
2245         Fixed run-bindings-tests by removing V8
2246         https://bugs.webkit.org/show_bug.cgi?id=114053
2247
2248         Reviewed by Benjamin Poulain.
2249
2250         * Scripts/run-bindings-tests:
2251         (main):
2252
2253 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2254
2255         Build fix.
2256
2257         * QueueStatusServer/model/queues.py:
2258         (Queue.short_name):
2259         (Queue.display_name):
2260
2261 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2262
2263         Remove Chromium EWS bots from the queue status server
2264         https://bugs.webkit.org/show_bug.cgi?id=113988
2265
2266         Reviewed by Benjamin Poulain.
2267
2268         Removed Chromium EWS bots.
2269
2270         * QueueStatusServer/config/queues.py:
2271         * QueueStatusServer/model/queues.py:
2272         (Queue.short_name):
2273         (Queue.display_name):
2274         * QueueStatusServer/model/queues_unittest.py:
2275         (QueueTest.test_short_name):
2276         (QueueTest.test_display_name):
2277         (QueueTest.test_name_with_underscores):
2278
2279 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2280
2281         [EFL] Enable indexed database
2282         https://bugs.webkit.org/show_bug.cgi?id=107248
2283
2284         Reviewed by Alexis Menard.
2285
2286         * Scripts/webkitperl/FeatureList.pm:
2287
2288 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
2289
2290         Remove vestiges of Chromium bits from watchlists.
2291         https://bugs.webkit.org/show_bug.cgi?id=114047
2292
2293         Reviewed by Ryosuke Niwa.
2294
2295         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
2296
2297 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
2298
2299         Add James Craig to the contributors list.
2300
2301         * Scripts/webkitpy/common/config/committers.py:
2302
2303 2013-04-04  Kent Tamura  <tkent@chromium.org>
2304
2305         Remove ChromiumPublicApi pattern, and cc/message rules for it.
2306
2307         * Scripts/webkitpy/common/config/watchlist:
2308
2309 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
2310
2311         Temporarily disable the Python unittests broken by the commit queue not running layout tests
2312         https://bugs.webkit.org/show_bug.cgi?id=113997
2313
2314         Reviewed by Ryosuke Niwa.
2315
2316         Disable the tests until Ryosuke gets the time and hardware to have
2317         a testing commit-queue.
2318
2319         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2320         (CommitQueueTaskTest):
2321         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2322         (CommitQueueTest):
2323
2324 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2325
2326         Remove Chromium builders from build.webkit.org
2327         https://bugs.webkit.org/show_bug.cgi?id=113990
2328
2329         Reviewed by Benjamin Poulain.
2330
2331         Land the part to disable triggering of Chromium builders first so that we may start
2332         deleting more Chromium code that breaks the update step.
2333
2334         * BuildSlaveSupport/build.webkit.org-config/config.json:
2335
2336 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
2337
2338         Remove Chromium's DumpRenderTree
2339         https://bugs.webkit.org/show_bug.cgi?id=113989
2340
2341         Reviewed by Kent Tamura.
2342
2343         On second thought, let's not go to Camelot. It is a silly place.
2344
2345         * DumpRenderTree/mac/DumpRenderTree.mm:
2346         (resetDefaultsToConsistentValues):
2347
2348 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
2349
2350         Nixed the defunct chromium folder from DumpRenderTree
2351         https://bugs.webkit.org/show_bug.cgi?id=113993
2352
2353         Reviewed by Ryosuke Niwa.
2354
2355         * DumpRenderTree/chromium: Removed.
2356         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
2357         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
2358         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
2359         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
2360         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
2361         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
2362         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
2363         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
2364         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
2365         * DumpRenderTree/chromium/MockPlatform.h: Removed.
2366         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
2367         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
2368         * DumpRenderTree/chromium/Task.cpp: Removed.
2369         * DumpRenderTree/chromium/Task.h: Removed.
2370         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
2371         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
2372         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
2373         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
2374         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
2375         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
2376         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
2377         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
2378         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2379         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
2380         * DumpRenderTree/chromium/TestRunner: Removed.
2381         * DumpRenderTree/chromium/TestRunner/public: Removed.
2382         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
2383         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
2384         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
2385         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
2386         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
2387         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
2388         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
2389         * DumpRenderTree/chromium/TestRunner/src: Removed.
2390         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
2391         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
2392         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
2393         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
2394         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
2395         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
2396         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
2397         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
2398         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
2399         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
2400         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
2401         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
2402         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
2403         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
2404         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
2405         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
2406         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
2407         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
2408         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
2409         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
2410         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
2411         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
2412         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
2413         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
2414         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
2415         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
2416         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
2417         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
2418         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
2419         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
2420         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
2421         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
2422         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
2423         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
2424         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
2425         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
2426         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
2427         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
2428         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
2429         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
2430         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
2431         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
2432         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
2433         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
2434         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
2435         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
2436         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
2437         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
2438         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
2439         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
2440         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
2441         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
2442         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
2443         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
2444         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
2445         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
2446         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2447         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
2448         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
2449         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2450         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
2451         * DumpRenderTree/chromium/TestShell.cpp: Removed.
2452         * DumpRenderTree/chromium/TestShell.h: Removed.
2453         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
2454         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
2455         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
2456         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
2457         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
2458         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
2459         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
2460         * DumpRenderTree/chromium/WebViewHost.h: Removed.
2461         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
2462         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
2463         * DumpRenderTree/chromium/config.h: Removed.
2464         * DumpRenderTree/chromium/fonts.conf: Removed.
2465
2466 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2467
2468         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
2469
2470         Rubber stamped by Benjamin Poulain.
2471
2472         * RebaselineQueueServer: Removed.
2473         * RebaselineQueueServer/app.yaml: Removed.
2474         * RebaselineQueueServer/handlers: Removed.
2475         * RebaselineQueueServer/handlers/__init__.py: Removed.
2476         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
2477         * RebaselineQueueServer/handlers/pages.py: Removed.
2478         * RebaselineQueueServer/index.yaml: Removed.
2479         * RebaselineQueueServer/main.py: Removed.
2480         * RebaselineQueueServer/model: Removed.
2481         * RebaselineQueueServer/model/__init__.py: Removed.
2482         * RebaselineQueueServer/model/queueentry.py: Removed.
2483         * RebaselineQueueServer/static: Removed.
2484         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
2485         * RebaselineQueueServer/static/styles.css: Removed.
2486         * RebaselineQueueServer/templates: Removed.
2487         * RebaselineQueueServer/templates/builder-picker.html: Removed.
2488         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
2489         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
2490         * RebaselineQueueServer/templates/home.html: Removed.
2491
2492 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2493
2494         Fix setup-commit-queue and temporarily disable testing on commit-queue
2495         https://bugs.webkit.org/show_bug.cgi?id=113979
2496
2497         Reviewed by Benjamin Poulain.
2498
2499         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
2500         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
2501
2502         * EWSTools/setup-commit-queue.sh:
2503         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2504         (CommitQueueTask.run):
2505
2506 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2507
2508         temporarily make flakiness dashboard work again webkit.org bots
2509         https://bugs.webkit.org/show_bug.cgi?id=113972
2510
2511         Reviewed by Ojan Vafai.
2512
2513         This patch disables the chromium.org layout test bots TestExpectations
2514         parsing temporarily until we can work out the right way to split into
2515         two instances for webkit.org and chromium.org and figure out which
2516         code to delete where :).
2517
2518         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2519
2520 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2521
2522         Fix webkitpy tests after r147678.
2523
2524         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2525         (CommitQueueTest.test_commit_queue):
2526         (test_manual_reject_during_processing):
2527
2528 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2529
2530         The commit queue should use Mac MountainLion port
2531         https://bugs.webkit.org/show_bug.cgi?id=113971
2532
2533         Reviewed by Lucas Forschler.
2534
2535         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
2536         * Scripts/webkitpy/tool/commands/queues.py:
2537         (CommitQueue):
2538
2539 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2540
2541         turn off running tests on chromium linux EWS bots
2542         https://bugs.webkit.org/show_bug.cgi?id=113959
2543
2544         Reviewed by Geoffrey Garen.
2545
2546         Now that the Chromium port is no longer being maintained
2547         there's little point in running the tests. Soon we should
2548         just shut this bot off altogether.
2549
2550         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2551         (ChromiumLinuxEWS):
2552
2553 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
2554
2555         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
2556
2557         * Scripts/webkitpy/common/config/watchlist:
2558
2559 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
2560
2561         Indentation fix to get webkit-patch working again after r147625
2562
2563         Unreviewed.
2564
2565         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2566         (MacEWS):
2567         (MacWK2EWS):
2568
2569 2013-04-04  Lucas Forschler  <lforschler@apple.com>
2570
2571         Turn tests back on for Mac WK1/WK2 EWS.
2572         
2573         Unreviewed.
2574         
2575         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2576         (MacEWS):
2577         (MacWK2EWS):
2578
2579 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
2580
2581         [GTK][WK2] MiniBrowser custom URI scheme support
2582         https://bugs.webkit.org/show_bug.cgi?id=112419
2583
2584         Reviewed by Carlos Garcia Campos.
2585
2586         Add support for about URIs in MiniBrowser. An example about page is show
2587         with URI "about:minibrowser", the rest of the cases it will show a
2588         proper message explaining that the about page didn't exist.
2589
2590         Internally it uses "minibrowser-about" prefix instead of "about", but
2591         from the user point of view it works with "about" prefix.
2592
2593         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
2594         (getInternalURI): Method to convert URIs from "about" prefix to
2595         "minibrowser-about".
2596         (getExternalURI): Opposite method.
2597         (webViewURIChanged): Use "about" prefix to show the URI to users.
2598         (webViewEnterFullScreen): Ditto.
2599         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
2600         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
2601         (aboutURISchemeRequestCallback): Callback to manage about calls.
2602         (main): Register the URI scheme to manage about URIs.
2603
2604 2013-04-03  Roger Fong  <roger_fong@apple.com>
2605
2606         Re-enable WinEWS tests.
2607
2608         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2609         (WinEWS):
2610
2611 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
2612
2613         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
2614         https://bugs.webkit.org/show_bug.cgi?id=113883
2615
2616         Reviewed by Martin Robinson.
2617
2618         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
2619         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
2620         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
2621
2622 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2623
2624         [GTK] Include Pango in jhbuild-optional.modules
2625         https://bugs.webkit.org/show_bug.cgi?id=113878
2626
2627         Reviewed by Martin Robinson.
2628
2629         Since r147547 Pango 1.32.0 is required. Including the module in the
2630         JHBuild optional moduleset.
2631
2632         * gtk/jhbuild-optional.modules: Add Pango module.
2633
2634 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2635
2636         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
2637         https://bugs.webkit.org/show_bug.cgi?id=113864
2638
2639         Moving setDefersLoading from TestRunnerQt to TestRunner
2640         requires access to the non-Qt TestRunner.
2641         As long as we instantiate both TestRunner and TestRunnerQt,
2642         we need a separate getter for the non-Qt TestRunner instance.
2643
2644         Reviewed by Simon Hausmann.
2645
2646         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2647         (WebPage::resetSettings):
2648         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2649         (DumpRenderTree::jscTestRunner):
2650         * DumpRenderTree/qt/TestRunnerQt.cpp:
2651         (TestRunner::setDefersLoading):
2652             Moving setDefersLoading from TestRunnerQt
2653             to TestRunner.
2654         * DumpRenderTree/qt/TestRunnerQt.h:
2655         (TestRunnerQt):
2656
2657 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2658
2659         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2660         https://bugs.webkit.org/show_bug.cgi?id=104779
2661
2662         Reviewed by Carlos Garcia Campos.
2663
2664         * Scripts/run-gtk-tests:
2665         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2666         passing in current trunk.
2667
2668 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
2669
2670         Fix HAVE(QTTESTSUPPORT) logic
2671
2672         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
2673         resulting in HAVE(QTTESTSUPPORT) never being true.
2674         Move that logic down in sanitizeFeatures.
2675
2676         Rubber-stamped by Tor Arne Vestbø.
2677
2678         * qmake/mkspecs/features/features.prf:
2679
2680 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2681
2682         [GTK] Bump required versions of some dependencies
2683         https://bugs.webkit.org/show_bug.cgi?id=113282
2684
2685         Reviewed by Martin Robinson.
2686
2687         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2688
2689 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2690
2691         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
2692         https://bugs.webkit.org/show_bug.cgi?id=113809
2693
2694         Reviewed by Philippe Normand.
2695
2696         Newer Linux kernels have removed some deprecated macros from v4l2
2697         headers, causing gst-plugins-good's build to break. We don't need it
2698         right now, so just disable it.
2699
2700         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
2701
2702 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2703
2704         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
2705         https://bugs.webkit.org/show_bug.cgi?id=113535
2706
2707         Reviewed by Simon Hausmann.
2708
2709         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
2710
2711         * qmake/mkspecs/features/features.prf:
2712
2713 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2714
2715         [Qt] Move logic of simple forwarding functions to TestRunner.
2716         https://bugs.webkit.org/show_bug.cgi?id=113863
2717
2718         Reviewed by Simon Hausmann.
2719
2720         * DumpRenderTree/qt/TestRunnerQt.cpp:
2721         (TestRunner::setTextDirection):
2722         (TestRunner::goBack):
2723         (TestRunner::evaluateScriptInIsolatedWorld):
2724         (TestRunner::addUserStyleSheet):
2725         * DumpRenderTree/qt/TestRunnerQt.h:
2726         (TestRunnerQt):
2727
2728 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2729
2730         [Qt] Disable media support using QuickTime if deployment target != SDK
2731
2732         We link to a single libWebKitSystemInterface static lib, so unless the
2733         deployment target matches the SDK let's not pretend like we'll be able
2734         to run on anything lower than the SDK version.
2735
2736         Reviewed by Simon Hausmann.
2737
2738         * qmake/mkspecs/features/features.prf:
2739
2740 2013-04-02  James Craig  <james@cookiecrook.com>
2741
2742         AXRoleDescripton for DL is "list"; should be "description list"
2743         https://bugs.webkit.org/show_bug.cgi?id=111665
2744
2745         Reviewed by Chris Fleizach.
2746
2747         Defining the role and description strings.
2748
2749         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2750
2751 2013-04-02  Roger Fong  <roger_fong@apple.com>
2752
2753         Unreviewed. Disable running tests on Win EWS queue.
2754
2755         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2756         (WinEWS):
2757
2758 2013-04-02  Lucas Forschler  <lforschler@apple.com>
2759
2760         Disable running tests on the MAC WK2 EWS queue.
2761         
2762         Unreviewed.
2763         
2764         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2765         (MacWK2EWS):
2766
2767 2013-04-02  Julie Parent  <jparent@chromium.org>
2768
2769         Dashboard refactor: Move dashboard specific history related features to History.
2770         https://bugs.webkit.org/show_bug.cgi?id=113717
2771
2772         Reviewed by Ojan Vafai.
2773         
2774         Each dashboard now creates its own History object, with a custom
2775         configuration. This changes from just overriding global functions
2776         to passing in callbacks for generatePage, handleValidHashParameter,
2777         and handleQueryParameterChange. Same with passing in defaultStateValues
2778         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
2779         variables.
2780         
2781         All functions related to these features are now (mostly) private
2782         function on History. 
2783         
2784         Loader no longer needs a loadingComplete callback, since it can just
2785         initialize the history object itself.
2786
2787         * TestResultServer/static-dashboards/aggregate_results.js:
2788         (handleValidHashParameter):
2789         * TestResultServer/static-dashboards/dashboard_base.js:
2790         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2791         (generatePage):
2792         (.switch.return):
2793         (handleQueryParameterChange):
2794         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2795         (resetGlobals):
2796         * TestResultServer/static-dashboards/history.js:
2797         (.):
2798         * TestResultServer/static-dashboards/loader.js:
2799         (.):
2800         * TestResultServer/static-dashboards/loader_unittests.js:
2801         * TestResultServer/static-dashboards/timeline_explorer.js:
2802         (generatePage):
2803         (initCurrentBuilderTestResults):
2804         * TestResultServer/static-dashboards/treemap.js:
2805         (generatePage):
2806         (.switch.return):
2807         (handleQueryParameterChange):
2808
2809 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2810
2811         Unreviewed, rolling out r147401.
2812         http://trac.webkit.org/changeset/147401
2813         https://bugs.webkit.org/show_bug.cgi?id=113767
2814
2815         The patch makes it extremely hard to set up the dependencies
2816         properly on the GTK builders (Requested by zdobersek on
2817         #webkit).
2818
2819         * gtk/jhbuild.modules:
2820
2821 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2822
2823         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
2824         https://bugs.webkit.org/show_bug.cgi?id=113382
2825
2826         Reviewed by Gyuyoung Kim.
2827
2828         Do not show the empty tooltip box if the text is null.
2829
2830         * MiniBrowser/efl/main.c:
2831         (popup_menu_populate):
2832
2833 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2834
2835         [GTK] Bump required versions of some dependencies
2836         https://bugs.webkit.org/show_bug.cgi?id=113282
2837
2838         Reviewed by Martin Robinson.
2839
2840         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2841
2842 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2843
2844         Unreviewed, rolling out r147319.
2845         http://trac.webkit.org/changeset/147319
2846         https://bugs.webkit.org/show_bug.cgi?id=113707
2847
2848         The unit test is still failing on the buildbot (Requested by
2849         zdobersek on #webkit).
2850
2851         * Scripts/run-gtk-tests:
2852         (TestRunner):
2853
2854 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2855
2856         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2857         https://bugs.webkit.org/show_bug.cgi?id=104779
2858
2859         Reviewed by Carlos Garcia Campos.
2860
2861         * Scripts/run-gtk-tests:
2862         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2863         passing in current trunk.
2864
2865 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
2866
2867         Unreviewed, rolling out r147289.
2868         http://trac.webkit.org/changeset/147289
2869         https://bugs.webkit.org/show_bug.cgi?id=113678
2870
2871         broke Win7 (dbg) build (Requested by shinyak|gardener on
2872         #webkit).
2873
2874         * DumpRenderTree/DumpRenderTree.gypi:
2875         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
2876         (WebTestRunner):
2877         (WebUserMediaClientMock):
2878         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
2879         (WebTestRunner::WebUserMediaClientMock::taskList):
2880         * Scripts/webkitpy/style/checkers/cpp.py:
2881         (check_function_definition):
2882
2883 2013-03-31  Adam Barth  <abarth@webkit.org>
2884
2885         configure-svn-config.sh fails
2886         https://codereview.chromium.org/13392007/
2887
2888         Reviewed by Eric Seidel.
2889
2890         This script was trying to use "svn checkout" to dowload a file from
2891         svn.webkit.org, but "svn checkout" only works with directories.
2892         Instead, we should use "svn export".
2893
2894         * EWSTools/configure-svn-config.sh:
2895
2896 2013-03-31  Wei Jia  <wjia@chromium.org>
2897
2898         Allow WebUserMediaClientMock to be used by client
2899         https://bugs.webkit.org/show_bug.cgi?id=113633
2900
2901         Reviewed by Adam Barth.
2902
2903         Export WebUserMediaClientMock.
2904         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
2905
2906         * DumpRenderTree/DumpRenderTree.gypi:
2907         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
2908         (WebUserMediaClientMock):
2909         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2910         * Scripts/webkitpy/style/checkers/cpp.py:
2911         (check_function_definition):
2912
2913 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
2914
2915         Expose FeatureObserver data to WebKit clients
2916         https://bugs.webkit.org/show_bug.cgi?id=113613
2917
2918         Reviewed by Sam Weinig.
2919
2920         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2921         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
2922
2923 2013-03-29  Greg Hughes  <ghughes@apple.com>
2924
2925         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
2926         https://bugs.webkit.org/show_bug.cgi?id=112276
2927
2928         Reviewed by Chris Fleizach.
2929
2930         Added support to test accessibility search predicates with multiple keys.  
2931
2932         * DumpRenderTree/AccessibilityUIElement.cpp:
2933         (uiElementForSearchPredicateCallback):
2934         * DumpRenderTree/AccessibilityUIElement.h:
2935         (AccessibilityUIElement):
2936         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2937         (AccessibilityUIElement::uiElementForSearchPredicate):
2938         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2939         (AccessibilityUIElement::uiElementForSearchPredicate):
2940         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2941         (AccessibilityUIElement::uiElementForSearchPredicate):
2942         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2943         (AccessibilityUIElement::uiElementForSearchPredicate):
2944         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2945         (AccessibilityUIElement::uiElementForSearchPredicate):
2946         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2947         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2948         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2949         (AccessibilityUIElement):
2950         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2951         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2952         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2953         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2954         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2955
2956 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
2957
2958         Fix a typo in r147147 to fix Mac EWS.
2959
2960         * Scripts/webkitpy/tool/commands/queues.py:
2961         (PatchProcessingQueue._new_port_name_from_old):
2962
2963 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
2964
2965         [EFL] Build break with latest EFL libraries after r146265
2966         https://bugs.webkit.org/show_bug.cgi?id=113558
2967
2968         Unreviewed build fix.
2969
2970         * TestWebKitAPI/PlatformWebView.h:
2971         * WebKitTestRunner/PlatformWebView.h:
2972
2973 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2974
2975         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
2976
2977         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
2978         in libgcrypt build.
2979
2980 2013-03-28  Lucas Forschler  <lforschler@apple.com>
2981
2982         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
2983
2984         Unreviewed.
2985
2986         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2987         (MacEWS):
2988
2989 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
2990
2991         Use the right OS name on Mac EWS instead of mac-future.
2992
2993         Rubber-stamped by Dirk Pranke.
2994
2995         * Scripts/webkitpy/tool/commands/queues.py:
2996         (PatchProcessingQueue._new_port_name_from_old):
2997         (PatchProcessingQueue.begin_work_queue):
2998         (PatchProcessingQueue._upload_results_archive_for_patch):
2999
3000 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
3001
3002         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
3003         https://bugs.webkit.org/show_bug.cgi?id=112546
3004
3005         Reviewed by Martin Robinson.
3006
3007         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
3008         moved back to Source/WebCore/platform. Fix an indentation issue as well.
3009
3010 2013-03-28  Ming Xie  <mxie@blackberry.com>
3011
3012         [BlackBerry] Committer Email Updates
3013         https://bugs.webkit.org/show_bug.cgi?id=113435
3014
3015         Reviewed by Rob Buis.
3016
3017         Add the @blackberry.com email address for all our BlackBerry
3018         WebKit committers. This is the first step for our email address
3019         migration.
3020
3021         * Scripts/webkitpy/common/config/committers.py:
3022
3023 2013-03-28  Philippe Normand  <pnormand@igalia.com>
3024
3025         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
3026         https://bugs.webkit.org/show_bug.cgi?id=113508
3027
3028         Reviewed by Martin Robinson.
3029
3030         Prevent the GStreamer plugin scanner to load system-wide
3031         plugins. Only the ones built in JHBuild should be loaded and used
3032         at runtime.
3033
3034         * efl/jhbuildrc:
3035         * gtk/jhbuildrc:
3036
3037 2013-03-27  Philippe Normand  <pnormand@igalia.com>
3038
3039         [GTK] run-launcher --gtk -2 fails on a WK2-only build
3040         https://bugs.webkit.org/show_bug.cgi?id=113386
3041
3042         Reviewed by Carlos Garcia Campos.
3043
3044         * Scripts/webkitdirs.pm:
3045         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
3046         version to 3.0. Reflect this change so the builtDylibPathForName
3047         function doesn't fail to report the library as found.
3048
3049 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
3050
3051         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
3052         https://bugs.webkit.org/show_bug.cgi?id=113484
3053
3054         Unreviewed build fix.
3055
3056         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
3057
3058         * TestWebKitAPI/CMakeLists.txt:
3059         * WebKitTestRunner/CMakeLists.txt:
3060
3061 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
3062
3063         Revision for the internal jhbuild is too old
3064         https://bugs.webkit.org/show_bug.cgi?id=113324
3065
3066         Reviewed by Martin Robinson.
3067
3068         Update the minimum required version to a point where jhbuild won't
3069         fail installing packages when trying to remove a symlink to a directory.
3070
3071         * jhbuild/jhbuild-wrapper: Updated revision.
3072
3073 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
3074
3075         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
3076         https://bugs.webkit.org/show_bug.cgi?id=113203
3077
3078         Reviewed by Philippe Normand.
3079
3080         We build our libsoup without GNOME support. gst-plugins-good does separate
3081         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
3082         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
3083         build failures as the headers of those diverge. We do not use souphttpsrc, so
3084         disable it when building gst-plugins-good.
3085
3086         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
3087
3088 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
3089
3090         Build fix after r146852. Please another reference to the Lion leaks builder.
3091
3092         * BuildSlaveSupport/build.webkit.org-config/config.json:
3093
3094 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
3095
3096         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
3097         https://bugs.webkit.org/show_bug.cgi?id=113421
3098
3099         Reviewed by Dirk Pranke.
3100
3101         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
3102         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
3103         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
3104         in the GTK-specific TestExpectations files.
3105
3106         To avoid this only enable the warnings only when not using WKTR.
3107
3108         * Scripts/webkitpy/layout_tests/port/gtk.py:
3109         (GtkPort.warn_if_bug_missing_in_test_expectations):
3110
3111 2013-03-27  Antti Koivisto  <antti@apple.com>
3112
3113         Fix Zalan's email.
3114
3115         * Scripts/webkitpy/common/config/committers.py:
3116
3117 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3118
3119         master.cfg cleanup
3120         https://bugs.webkit.org/show_bug.cgi?id=113195
3121
3122         Reviewed by Ryosuke Niwa.
3123
3124         * BuildSlaveSupport/build.webkit.org-config/config.json:
3125         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3126
3127 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3128
3129         master.cfg fine-tuning for Qt Mountain Lion Release bot
3130         https://bugs.webkit.org/show_bug.cgi?id=113191
3131
3132         Reviewed by Ryosuke Niwa.
3133
3134         * BuildSlaveSupport/build.webkit.org-config/config.json:
3135           - Rename the slave due to its location change.
3136           - Update the platform of the slave.
3137         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3138         (RunQtAPITests): Enable running WK2 API tests on Qt.
3139         (RunQtAPITests.start):
3140         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
3141         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
3142
3143 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3144
3145         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
3146         https://bugs.webkit.org/show_bug.cgi?id=113403
3147
3148         Reviewed by Kenneth Rohde Christiansen.
3149
3150         As of Evas 1.7.5, when Wayland is detected on the system, support for
3151         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
3152         The code, however, seems to depend on a few other flags which must be
3153         explicitly enabled.
3154
3155         If those additional GL-related options are passed, we end up
3156         having issues on the WebKit side, so disable Wayland support for
3157         now.
3158
3159         * efl/jhbuild.modules:
3160
3161 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3162
3163         Unreviewed, rolling out r146864.
3164         http://trac.webkit.org/changeset/146864
3165         https://bugs.webkit.org/show_bug.cgi?id=113391
3166
3167         causes crashes on Wk2 EFL release bot (Requested by drott on
3168         #webkit).
3169
3170         * Scripts/webkitperl/FeatureList.pm:
3171
3172 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3173
3174         [jhbuild] Correctly specify an alternate number of make jobs.
3175         https://bugs.webkit.org/show_bug.cgi?id=113396
3176
3177         Reviewed by Philippe Normand.
3178
3179         So far, we were using the `MAKEFLAGS' environment variable to pass the
3180         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
3181         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
3182
3183         We now behave more closely to the rest of the WebKit tools by first
3184         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
3185         not set, just letting jhbuild itself figure out how many jobs to use.
3186
3187         * efl/jhbuildrc:
3188         * gtk/jhbuildrc:
3189
3190 2013-03-27  Zeno Albisser  <zeno@webkit.org>
3191
3192         [Qt] Remove Qt specific WorkQueueItem definitions.
3193         https://bugs.webkit.org/show_bug.cgi?id=112891
3194
3195         This patch is preparation work for removing
3196         WorkQueue related code from TestRunnerQt and
3197         replacing it with generic TestRunner code.
3198
3199         Reviewed by Benjamin Poulain.
3200
3201         * DumpRenderTree/qt/TestRunnerQt.cpp:
3202         (TestRunnerQt::queueBackNavigation):
3203         (TestRunnerQt::queueForwardNavigation):
3204         (TestRunnerQt::queueLoadHTMLString):
3205         (TestRunnerQt::queueReload):
3206         (TestRunnerQt::queueLoadingScript):
3207         (TestRunnerQt::queueNonLoadingScript):
3208         (TestRunner::queueLoad):
3209         * DumpRenderTree/qt/TestRunnerQt.h:
3210         (TestRunnerQt):
3211         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
3212         (LoadItem::invoke):
3213         (LoadHTMLStringItem::invoke):
3214         (LoadAlternateHTMLStringItem::invoke):
3215         (ReloadItem::invoke):
3216         (ScriptItem::invoke):
3217         (BackForwardItem::invoke):
3218         * DumpRenderTree/qt/WorkQueueItemQt.h:
3219         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
3220         (LoadAlternateHTMLStringItem):
3221
3222 2013-03-26  Julie Parent  <jparent@chromium.org>
3223
3224         Flakiness dashboard: simplify logic around which tests to show.
3225         https://bugs.webkit.org/show_bug.cgi?id=113250
3226
3227         Reviewed by Ojan Vafai.
3228         
3229         The different filters for showing results are only used for layout
3230         tests, otherwise, we show everything.
3231         
3232         Change the defaults to false (what layout tests used), and only
3233         look at the values when viewing layout tests.
3234
3235         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3236         (htmlForTestsWithExpectationsButNoFailures):
3237         (shouldHideTest):
3238
3239 2013-03-26  Isaac Levy  <ilevy@google.com>
3240
3241         Update bots on test-results.appspot
3242         https://bugs.webkit.org/show_bug.cgi?id=113333
3243
3244         Reviewed by Ojan Vafai.
3245
3246         * TestResultServer/static-dashboards/builders.jsonp:
3247
3248 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
3249
3250         Unreviewed GTK gardening.
3251
3252         * Scripts/run-gtk-tests:
3253         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
3254
3255 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
3256
3257         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
3258         https://bugs.webkit.org/show_bug.cgi?id=113287
3259
3260         Reviewed by Jocelyn Turcotte.
3261
3262         * Scripts/run-qtwebkit-tests:
3263         (Options.__init__):
3264
3265 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
3266
3267         [EFL] Enable IndexedDB by default
3268         https://bugs.webkit.org/show_bug.cgi?id=107248
3269
3270         Reviewed by Laszlo Gombos.
3271
3272         * Scripts/webkitperl/FeatureList.pm:
3273         Enable IndexedDB by default on EFL.
3274
3275 2013-03-26  Alan Cutter  <alancutter@chromium.org>
3276
3277         Sheriffbot should explain rollout failures in a human readable form.
3278         https://bugs.webkit.org/show_bug.cgi?id=107092
3279
3280         Reviewed by Ryosuke Niwa.
3281
3282         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
3283
3284         * Scripts/webkitpy/tool/bot/irc_command.py:
3285         (Rollout._check_diff_failure):
3286         (Rollout.execute):
3287         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3288         (IRCCommandTest.test_rollout):
3289
3290 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
3291
3292         Unreviewed GTK gardening.
3293
3294         * Scripts/run-gtk-tests:
3295         (TestRunner): Skipping a failing unit test after r146518.
3296
3297 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
3298
3299         Remove Lion leaks builder
3300         https://bugs.webkit.org/show_bug.cgi?id=113252
3301
3302         Reviewed by Andreas Kling.
3303
3304         Removed.
3305
3306         * BuildSlaveSupport/build.webkit.org-config/config.json:
3307
3308 2013-03-25  Kent Tamura  <tkent@chromium.org>
3309
3310         Rename ENABLE_INPUT_TYPE_DATETIME
3311         https://bugs.webkit.org/show_bug.cgi?id=113254
3312
3313         Reviewed by Kentaro Hara.
3314
3315         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
3316         Actually I'd like to remove the code, but we shouldn't remove it yet
3317         because we shipped products with it on some platforms.
3318
3319         * Scripts/webkitperl/FeatureList.pm:
3320         * qmake/mkspecs/features/features.pri:
3321
3322 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
3323
3324         Remove one more line that was intended to be removed in r146657.
3325
3326         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3327         (summarize_results):
3328
3329 2013-03-25  Roger Fong  <roger_fong@apple.com>
3330
3331         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
3332         Re-enable WinEWS tests.
3333
3334         * Scripts/webkitpy/common/config/ports.py:
3335         (WinPort.run_bindings_tests_command):
3336         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3337         (WinEWS):
3338
3339 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3340
3341         Unreviewed, rolling out r146793.
3342         http://trac.webkit.org/changeset/146793
3343         https://bugs.webkit.org/show_bug.cgi?id=113248
3344
3345         Fix did not work (Requested by rfong on #webkit).
3346
3347         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3348         (WinEWS):
3349
3350 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
3351
3352         REGRESSION(r146657): Test failures reported incorrectly
3353         https://bugs.webkit.org/show_bug.cgi?id=113223
3354
3355         Reviewed by Dirk Pranke.
3356
3357         The bug was caused by BuildBotPrinter not taking the new behavior into account.
3358
3359         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
3360         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
3361
3362         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3363         (Manager.run):
3364
3365         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3366         (RunDetails.__init__):
3367         (summarize_results): Remove the line I intended to remove in r146657.
3368
3369         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3370         (logging_run): Return details instead of the exit code.
3371         (run_and_capture): Ditto.
3372
3373         (RunTest.test_full_results_html):
3374         (RunTest.test_hung_thread):
3375         (RunTest.test_no_tests_found):
3376         (RunTest.test_no_tests_found_2):
3377         (RunTest.test_repeat_each_iterations_num_tests):
3378         (RunTest.test_run_singly_actually_runs_tests):
3379         (RunTest.test_test_list):
3380         (RunTest.test_missing_and_unexpected_results):
3381         (RunTest.test_pixel_test_directories):
3382         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
3383         (RunTest.test_crash_with_stderr):
3384         (RunTest.test_no_image_failure_with_image_diff):
3385         (RunTest.test_crash_log):
3386         (RunTest.test_exit_after_n_failures_upload):
3387         (RunTest.test_results_directory_absolute):
3388         (RunTest.test_results_directory_relative):
3389         (RunTest.test_retrying_and_flaky_tests):
3390         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
3391         (RunTest.test_retrying_uses_retries_directory):
3392         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
3393         (RunTest.test_output_diffs):
3394         (EndToEndTest.test_reftest_with_two_notrefs):
3395         (RebaselineTest.test_reset_results):
3396         (RebaselineTest.test_missing_results):
3397         (RebaselineTest.test_new_baseline):
3398
3399         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3400         (BuildBotPrinter.print_results):
3401         (BuildBotPrinter.print_unexpected_results):
3402         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
3403         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
3404
3405 2013-03-25  Julie Parent  <jparent@chromium.org>
3406
3407         Dashboard refactor: Move cross dashboard history related code into history.js.
3408         https://bugs.webkit.org/show_bug.cgi?id=113104
3409
3410         Reviewed by Ojan Vafai.
3411
3412         All functions relating to cross dashboard behavior move from being
3413         globals to methods on the history.History object. Names stay the same,
3414         except many are made private, ones that should have been constants now
3415         are, and the long standing TODO to change "currentState" to 
3416         dashboardSpecificState is done.
3417         
3418         We now create a global history object in dashboard_base, as an 
3419         intermediate measure.  Once the dashboard specific code is
3420         added to history, each DB will need to create its own, and this
3421         global will be eliminated.
3422         
3423         * TestResultServer/static-dashboards/aggregate_results.js:
3424         (handleValidHashParameter):
3425         (htmlForBuilder):
3426         (rawValuesHTML):
3427         * TestResultServer/static-dashboards/dashboard_base.js:
3428         (parseDashboardSpecificParameters):
3429         (defaultValue):
3430         (currentBuilderGroupCategory):
3431         (currentBuilderGroupName):
3432         (handleLocationChange):
3433         (expectationsMap):
3434         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3435         (generatePage):
3436         (.switch.return):
3437         (platformAndBuildType):
3438         (individualTests):
3439         (substringList):
3440         (processMissingAndExtraExpectations):
3441         (pathToFailureLog):
3442         (showPopupForBuild):
3443         (htmlForTestsWithExpectationsButNoFailures):
3444         (shouldHideTest):
3445         (isCrossBuilderView):
3446         (tableHeaders):
3447         (htmlForSingleTestRow):
3448         (htmlForTableColumnHeader):
3449         (generatePageForExpectationsUpdate):
3450         (handleUpdate):
3451         (nextUpdate):
3452         (setUpdateIndex):
3453         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
3454         (.appendExpectationsItem):
3455         (loadExpectations):
3456         (.dummyNode.onload):
3457         (loadExpectationsLayoutTests):
3458         (appendExpectations):
3459         (htmlForNavBar):
3460         (checkBoxToToggleState):
3461         (linkHTMLToToggleState):
3462         (generatePageForBuilder):
3463         (isInvalidKeyForCrossBuilderView):
3464         (handleQueryParameterChange):
3465         (showLegend):
3466         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3467         (resetGlobals):
3468         (test):
3469         * TestResultServer/static-dashboards/history.js:
3470         (.):
3471         * TestResultServer/static-dashboards/history_unittests.js:
3472         * TestResultServer/static-dashboards/loader.js:
3473         (.):
3474         * TestResultServer/static-dashboards/loader_unittests.js:
3475         * TestResultServer/static-dashboards/timeline_explorer.js:
3476         (generatePage):
3477         (initCurrentBuilderTestResults):
3478         (selectBuild):
3479         (showResultsDelta):
3480         * TestResultServer/static-dashboards/treemap.js:
3481         (generatePage):
3482         (.switch.return):
3483         (handleFocus):
3484         * TestResultServer/static-dashboards/ui.js:
3485
3486 2013-03-25  Roger Fong  <roger_fong@apple.com>
3487
3488         Unreviewed. Enable WinEWS tests again.
3489
3490         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3491         (WinEWS):
3492
3493 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
3494
3495         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
3496         https://bugs.webkit.org/show_bug.cgi?id=112166
3497
3498         HarfBuzz 0.9.14 merged my patch for icu detection without
3499         pkg-config files, as needed by for example Ubuntu 12.04.
3500         This obsoletes our local workaround. Removed it for GTK and EFL.
3501
3502         Reviewed by Martin Robinson.
3503
3504         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3505         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
3506         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3507         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
3508
3509 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
3510
3511         Unreviewed.  Move self from contributor to committer list.
3512
3513         * Scripts/webkitpy/common/config/committers.py:
3514
3515 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3516
3517         EWS should use a human readable port name when uploading layout test archives
3518         https://bugs.webkit.org/show_bug.cgi?id=113099
3519
3520         Reviewed by Dirk Pranke.
3521
3522         Use new port's object's name() method to report human readable port names.
3523         This will also help us resolving the bug to apply layout test results posted by EWS.
3524
3525         * Scripts/webkitpy/tool/bot/botinfo.py:
3526         (BotInfo.__init__): Take port's name.
3527         (BotInfo.summary_text):
3528
3529         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3530         (BotInfoTest.test_summary_text):
3531
3532         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3533         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
3534
3535         * Scripts/webkitpy/tool/commands/queues.py:
3536         (PatchProcessingQueue.__init__): Initialize self._port.
3537         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
3538         and use that for the attachment filename and the comment posted.
3539
3540         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3541         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
3542         "mac-snowleopard" as expected for TestPort.
3543
3544 2013-03-22  Roger Fong  <roger_fong@apple.com>
3545
3546         Unreviewed. Turn off EWS test on Win again.
3547         The battle continues.
3548
3549         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3550         (WinEWS):
3551
3552 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3553
3554         NRWT: Enable pixel tests when retrying tests
3555         https://bugs.webkit.org/show_bug.cgi?id=112898
3556
3557         Reviewed by Dirk Pranke.
3558
3559         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3560         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
3561         if we've forced pixel tests in the retry.
3562         (Manager._run_tests):
3563         (Manager._clean_up_run): Fixed the capitalizations.
3564         (Manager._force_pixel_tests_if_needed): Added.
3565
3566         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3567         (_interpret_test_failures): Now that this function maybe called multiple times, only set
3568         'image_diff_percent' if it doesn't already exist.
3569
3570         (summarize_results): When the first attempt resulted in a text failure and the second attempt
3571         resulted in image and text failures and we've forced to run pixel tests in the retry run,
3572         treat this as a regular regression instead of a flakiness.
3573
3574         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
3575         run had image diffs.
3576
3577         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3578         (summarized_results):
3579
3580         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3581         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
3582         Also removed some dead code.
3583
3584         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
3585         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
3586         is set and pixel_tests_enabled is set to false.
3587         (EndToEndTest.test_reftest_with_two_notrefs):
3588
3589 2013-03-22  Tim Horton  <timothy_horton@apple.com>
3590
3591         Make it possible to run layout tests on Retina MBP
3592         https://bugs.webkit.org/show_bug.cgi?id=93673
3593
3594         Reviewed by Ryosuke Niwa.
3595
3596         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
3597         windows on 2x machines still run at 1x.
3598
3599         * DumpRenderTree/mac/DumpRenderTree.mm:
3600         (createWebViewAndOffscreenWindow):
3601         Reset the window resolution to 1x on creation.
3602         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
3603         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3604         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
3605         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3606         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
3607         (WTR::PlatformWebView::PlatformWebView):
3608         Add NSWindow details, reset the window resolution to 1x on creation.
3609
3610 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3611
3612         Leak bots shouldn't build
3613         https://bugs.webkit.org/show_bug.cgi?id=112774
3614
3615         Reviewed by Simon Fraser.
3616
3617         Since leak bots use regular debug builds, there is no need to build on these bots.
3618         Simply downloading builds will dramatically improve the cycle time of these bots.
3619
3620         * BuildSlaveSupport/build.webkit.org-config/config.json:
3621         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3622         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
3623         TestFactory instead of BuildAndTestFactory.
3624
3625 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
3626
3627         [Qt] Fix the TestWebKitAPI build
3628         https://bugs.webkit.org/show_bug.cgi?id=113044
3629
3630         Reviewed by Tor Arne Vestbø.
3631
3632         The generate-forwarding-headers script would only be run
3633         after the targets in InjectedBundle.pri since the second
3634         addStrictSubdirOrderBetween call in
3635         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
3636         the derived_sources -> injected_bundle order in SUBDIRS.
3637
3638         Fix it by only moving the dependent target at the end of
3639         SUBDIRS, don't touch its dependency.
3640
3641         * qmake/mkspecs/features/functions.prf:
3642
3643 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3644
3645         [EFL][WK2] View is not focused when fullscreen mode toggled
3646         https://bugs.webkit.org/show_bug.cgi?id=113009
3647
3648         Reviewed by Laszlo Gombos.
3649
3650         Set focus on view when fullscreen mode enabled/disabled
3651         by FullScreen API.
3652
3653         * MiniBrowser/efl/main.c:
3654         (on_fullscreen_accept):
3655         (on_fullscreen_deny):
3656
3657 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3658
3659         nrwt is no longer saving retry results in the retries/ subdirectory
3660         https://bugs.webkit.org/show_bug.cgi?id=112995
3661
3662         Reviewed by Ojan Vafai.
3663
3664         I think this has been broken a long time, unfortunately. This
3665         patch should fix that.
3666
3667         In order to do so, I had to pass the directory to use from
3668         the Worker object through the SingleTestWriter to the
3669         TestResultWriter. While I was plumbing that through, I rationalized
3670         the order of the parameter arguments a bit ...
3671
3672         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3673         (Worker._run_single_test):
3674         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3675         (run_single_test):
3676         (SingleTestRunner.__init__):
3677         (SingleTestRunner._run_compare_test):
3678         (SingleTestRunner._run_rebaseline):
3679         (SingleTestRunner._run_reftest):
3680         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3681         (write_test_result):
3682         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3683         (TestResultWriterTest.test_reftest_diff_image):
3684         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3685         (RunTest.test_retrying_uses_retries_directory):
3686