Source/JavaScriptCore: Add Vector::reverse()
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-09  Dan Bernstein  <mitz@apple.com>
2
3         Reviewed by Anders Carlsson.
4
5         Added a test for Vector::reverse()
6         https://bugs.webkit.org/show_bug.cgi?id=62393
7
8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
10         (TestWebKitAPI::TEST):
11         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
12
13 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
14
15         Reviewed by Andreas Kling.
16
17         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
18         https://bugs.webkit.org/show_bug.cgi?id=62385
19
20         Remove duplicate TestNetscapePlugIn implementation. Having two copies
21         of this code makes keeping it in sync much more difficult. The files are
22         almost identical and this change ports the X11 changes to main.cpp.
23
24         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
25         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
26         (handleEventX11): Use the handler to properly convert the keycode. Do not print
27         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
28         it should not be in the results.
29         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
30         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
31         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
32         * GNUmakefile.am: Update source list.
33
34 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
35
36         Reviewed by Tony Chang.
37
38         Test plugin should support event logging on the windows port.
39         https://bugs.webkit.org/show_bug.cgi?id=61721
40
41         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
42         calls to mean the plugin handled the event.
43
44         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
45         (handleEventWin): Return 0 for each event on windows.
46
47 2011-06-09  Chang Shu  <cshu@webkit.org>
48
49         Reviewed by Andreas Kling.
50
51         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
52         https://bugs.webkit.org/show_bug.cgi?id=62381
53
54         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
55         QWKPagePrivate::isViewFocused() will check it later.
56
57         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
58         (WTR::PlatformWebView::PlatformWebView):
59
60 2011-06-09  Robert Hogan  <robert@webkit.org>
61
62         Reviewed by Andreas Kling.
63
64         Teach Qt about window.internals
65         https://bugs.webkit.org/show_bug.cgi?id=61074
66
67         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
68         (WebCore::DumpRenderTree::initJSObjects):
69
70 2011-06-09  Eric Seidel  <eric@webkit.org>
71
72         Reviewed by Adam Barth.
73
74         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
75         https://bugs.webkit.org/show_bug.cgi?id=62362
76
77         The mac bots are failing inspector tests.  We don't know why yet.
78         So for now, turning run-webkit-tests off for the mac-ews.
79
80         Also noticed that due to the wrong variable name the cr-linux
81         bots weren't running tests!
82
83         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
84
85 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
86
87         Reviewed by Csaba Osztrogonac.
88
89         [Qt][WK2] Canvas tests make css2.1 ones failing
90         https://bugs.webkit.org/show_bug.cgi?id=53427
91
92         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
93         Since the Qt port should eventually go to QRawFont, this issue will be resolved
94         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
95         needed for the workaround.
96
97         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
98         (WTR::LayoutTestController::platformInitialize):
99
100 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
101
102         Reviewed by Chris Fleizach.
103
104         [GTK] Provide a way in DRT to check the platform name
105         https://bugs.webkit.org/show_bug.cgi?id=56855
106
107         Patch for adding 'platformName' static property to DRT's
108         LayoutController and provide platform specific implementations.
109
110         In principle, this feature will be only of interest for writing
111         accessibility tests, so that's why it's only implemented in the
112         Mac, Gtk and Win platforms.
113
114         * DumpRenderTree/LayoutTestController.h: New method platformName().
115         * DumpRenderTree/LayoutTestController.cpp:
116         (getPlatformNameCallback): New callback for 'platformName'.
117         (LayoutTestController::staticValues): New static property.
118
119         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
120         (LayoutTestController::platformName): Implemented.
121
122         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
123         (LayoutTestController::platformName): Implemented.
124
125         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
126         (LayoutTestController::platformName): Implemented.
127
128 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
129
130         Reviewed by James Robinson.
131
132         Add mikelawther to committers.py
133         https://bugs.webkit.org/show_bug.cgi?id=62354
134
135         * Scripts/webkitpy/common/config/committers.py:
136
137 2011-06-08  Kent Tamura  <tkent@chromium.org>
138
139         [Chromium] Fix a typo.
140
141         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
142         (WebThemeControlDRTWin::draw):
143
144 2011-06-08  Kent Tamura  <tkent@chromium.org>
145
146         Reviewed by Hajime Morita.
147
148         [Chromium] Support vertical sliders in Windows DRT
149         https://bugs.webkit.org/show_bug.cgi?id=62352
150
151         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
152         (WebThemeControlDRTWin::draw):
153           Paint VerticalSliderThumbType and VerticalSliderTrackType.
154         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
155           Add VerticalSliderTrackType and VerticalSliderThumbType.
156         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
157         (WebThemeEngineDRTWin::paintTrackbar):
158           Convert Windows identifiers to the internal identifiers for vertical sliders.
159
160 2011-06-08  Ojan Vafai  <ojan@chromium.org>
161
162         Reviewed by Tony Chang.
163
164         add a short-flag for --experimental-fully-parallel
165         https://bugs.webkit.org/show_bug.cgi?id=62321
166
167         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
168
169 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
170
171         Reviewed by Tony Chang.
172
173         new-run-webkit-tests: don't turn the tree red when there are new passes
174         https://bugs.webkit.org/show_bug.cgi?id=62311
175
176         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
177         to match commandComplete.
178
179         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
180
181 2011-06-08  Tom Hudson  <tomhudson@google.com>
182
183         Reviewed by Mihai Parparita.
184
185         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
186         https://bugs.webkit.org/show_bug.cgi?id=60964
187
188         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
189         Add 'Sort tests by metric' link.
190         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
191         (disableSorting): Activate 'Sort tests by metric' link.
192         (enableSorting): Deactivate 'Sort tests by metric' link.
193         (selectDirectory): Call enableSorting()/disableSorting() depending
194         on currently selected failure type, and sort tests if requested.
195         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
196         New .disabled-control class for deactivated links.
197
198 2011-06-08  Tom Sepez  <tsepez@chromium.org>
199
200         Reviewed by Adam Barth.
201
202         Add web permissions callbacks for mixed content blocking.
203         https://bugs.webkit.org/show_bug.cgi?id=61946
204
205         * DumpRenderTree/chromium/LayoutTestController.cpp:
206         (LayoutTestController::setAllowDisplayOfInsecureContent):
207         (LayoutTestController::setAllowRunningOfInsecureContent):
208         (LayoutTestController::overridePreference):
209         * DumpRenderTree/chromium/WebPermissions.cpp:
210         (WebPermissions::allowDisplayingInsecureContent):
211         (WebPermissions::allowRunningInsecureContent):
212         (WebPermissions::setDisplayingInsecureContentAllowed):
213         (WebPermissions::setRunningInsecureContentAllowed):
214         (WebPermissions::reset):
215         * DumpRenderTree/chromium/WebPermissions.h:
216
217 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
218
219         Reviewed by Tony Chang.
220
221         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
222         https://bugs.webkit.org/show_bug.cgi?id=62259
223
224         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
225
226 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
227
228         Reviewed by Tony Chang.
229
230         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
231         https://bugs.webkit.org/show_bug.cgi?id=62303
232
233         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
234
235         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
236
237 2011-06-08  Greg Simon  <gregsimon@chromium.org>
238
239         Reviewed by Dimitri Glazkov.
240
241         Control Indexeddb backends from LayoutTestController
242         https://bugs.webkit.org/show_bug.cgi?id=61000
243
244         * DumpRenderTree/chromium/LayoutTestController.cpp:
245         (LayoutTestController::LayoutTestController):
246         (LayoutTestController::setOverrideIndexedDBBackingStore):
247         (LayoutTestController::clearAllDatabases):
248         * DumpRenderTree/chromium/LayoutTestController.h:
249
250 2011-06-08  Andreas Kling  <kling@webkit.org>
251
252         Add Pierre Rossi to contributors list for EZ-CC.
253
254         * Scripts/webkitpy/common/config/committers.py:
255
256 2011-06-08  Ilya Sherman  <isherman@chromium.org>
257
258         Reviewed by Andreas Kling.
259
260         Add Ilya Sherman to list of committers
261         https://bugs.webkit.org/show_bug.cgi?id=62270
262
263         * Scripts/webkitpy/common/config/committers.py:
264
265 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
266
267         Reviewed by Tony Chang.
268
269         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
270         https://bugs.webkit.org/show_bug.cgi?id=62178
271
272         Added commandComplete and evaluateCommand for NewRunWebKitTests class
273         to parse new-run-webkit-tests' results.
274
275         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
276
277 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
278
279         Reviewed by Eric Seidel.
280
281         webkitpy: add a popen() call to executive
282         https://bugs.webkit.org/show_bug.cgi?id=62179
283
284         This change adds a popen() wrapper call to the Executive object.
285         This will allow other webkitpy scripts that currently call
286         subprocess directly to use Executive, instead.
287
288         No additional tests are necessary (the existing tests cover the code).
289
290         * Scripts/webkitpy/common/system/executive.py:
291
292 2011-06-07  Sam Weinig  <sam@webkit.org>
293
294         Reviewed by Anders Carlsson.
295
296         Remove repeated IPC traffic from SetRenderTreeSize message
297         https://bugs.webkit.org/show_bug.cgi?id=62244
298
299         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
300         (WTR::InjectedBundlePage::InjectedBundlePage):
301         Add stub for didLayoutForFrame.
302
303 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
304
305         Reviewed by Tony Chang.
306
307         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
308         https://bugs.webkit.org/show_bug.cgi?id=62241
309
310         * Scripts/webkitpy/layout_tests/port/chromium.py:
311
312 2011-06-07  Adam Barth  <abarth@webkit.org>
313
314         Rubber-stamped by Eric Seidel.
315
316         Enable tests on the mac-ews
317
318         When we bring the mac-ews back up, we're going to try running tests!
319
320         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
321
322 2011-06-07  Dmitry Lomov  <dslomov@google.com>
323
324         Reviewed by David Levin.
325
326         https://bugs.webkit.org/show_bug.cgi?id=62215
327         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
328
329         * Scripts/webkitpy/style/checkers/cpp.py:
330         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
331
332 2011-06-07  Nico Weber  <thakis@chromium.org>
333
334         Reviewed by Dimitri Glazkov.
335
336         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
337         https://bugs.webkit.org/show_bug.cgi?id=62210
338
339         The change to TestEventPrinter fixes a latent bug, because
340         objects are deleted through the TestEventPrinter type, but none
341         of the subclasses have destructors or non-POD members.
342
343         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
344         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
345         discussed at http://codereview.chromium.org/7094005/, we prefer making
346         leaf class destructors virtual over making the leaf classes final.
347
348         * DumpRenderTree/chromium/NotificationPresenter.cpp:
349         (NotificationPresenter::~NotificationPresenter):
350         * DumpRenderTree/chromium/NotificationPresenter.h:
351         * DumpRenderTree/chromium/TestEventPrinter.cpp:
352         (TestEventPrinter::~TestEventPrinter):
353         * DumpRenderTree/chromium/TestEventPrinter.h:
354         * DumpRenderTree/chromium/WebViewHost.h:
355
356 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
357
358         Reviewed by Dirk Pranke.
359
360         [chromium] Chromium bots on build.webkit.org don't upload results.html
361         https://bugs.webkit.org/show_bug.cgi?id=61961
362
363         Don't fix the path on chromium port erroneously.
364
365         * BuildSlaveSupport/test-result-archive:
366
367 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
368
369         Fix the GTK+ build by ensuring that the autogenerated sources
370         necessary for libWebCoreInternals are recorded in a predeclared
371         variable before assigning to BUILT_SOURCES.
372
373         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
374
375 2011-06-06  Yong Li  <yoli@rim.com>
376
377         Reviewed by Eric Seidel.
378
379         https://bugs.webkit.org/show_bug.cgi?id=62097
380         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
381
382         * Scripts/webkitpy/style/checkers/cpp.py:
383         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
384
385 2011-06-06  Xan Lopez  <xlopez@igalia.com>
386
387         Reviewed by Martin Robinson.
388
389         [GTK] Enable feature/symbol detection in NWRT/GTK
390         https://bugs.webkit.org/show_bug.cgi?id=62136
391
392         Disable feature detection through DRT, since we don't support it,
393         and set the libwebcore patch correctly so that symbol detection
394         through 'nm' works.
395
396         * Scripts/webkitpy/layout_tests/port/gtk.py:
397
398 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
399
400         Reviewed by Tony Gentilcore.
401
402         Add a "prerender" state for page visibility.
403         https://bugs.webkit.org/show_bug.cgi?id=62062
404
405         * DumpRenderTree/chromium/LayoutTestController.cpp:
406         (LayoutTestController::setPageVisibility):
407
408 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
409
410         [Qt] Implement download feature for QtTestBrowser
411         https://bugs.webkit.org/show_bug.cgi?id=61865
412
413         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
414
415         * QtTestBrowser/launcherwindow.cpp:
416         (LauncherWindow::LauncherWindow):
417         * QtTestBrowser/launcherwindow.h:
418
419 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
420
421         Reviewed by Csaba Osztrogonác.
422
423         [Qt] Implement download feature for QtTestBrowser
424         https://bugs.webkit.org/show_bug.cgi?id=61865
425
426         * QtTestBrowser/launcherwindow.cpp:
427         (LauncherWindow::LauncherWindow):
428         (LauncherWindow::downloadRequest):
429         (LauncherWindow::fileDownloadFinished):
430         * QtTestBrowser/launcherwindow.h:
431
432 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
433
434         Reviewed by Dimitri Glazkov.
435
436         Make DumpRenderTree initialize window.internals.
437         https://bugs.webkit.org/show_bug.cgi?id=61076
438
439         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
440         * DumpRenderTree/win/FrameLoadDelegate.cpp:
441         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
442
443 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
444
445         Reviewed by Kent Tamura.
446
447         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
448         https://bugs.webkit.org/show_bug.cgi?id=61628
449
450         * Scripts/build-webkit:
451
452 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
453
454         Reviewed by Kent Tamura.
455
456         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
457         https://bugs.webkit.org/show_bug.cgi?id=61631
458
459         * Scripts/build-webkit:
460
461 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
462
463         Unreviewed. Fix the GTK+ build.
464
465         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
466
467 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
468
469         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
470         works properly).
471
472         * Scripts/webkitpy/common/config/committers.py:
473
474 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
475
476         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
477         WebKit scripts expect, so other scripts work properly with wx.
478
479         * waf/build/build_utils.py:
480         * waf/build/settings.py:
481
482 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
483
484         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
485         to build on Mac.
486
487         * waf/build/settings.py:
488         * wx/install-unix-extras:
489
490 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
491
492         [wx] Unreviewed build fixes for recent trunk changes.
493
494         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
495         (LayoutTestController::setTextDirection):
496         * waf/build/settings.py:
497
498 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
499
500         Fix the GTK+ build.
501
502         * GNUmakefile.am: Add some missing newline escape.
503
504 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
505
506         Try to fix the GTK+ bulid.
507
508         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
509         source list.
510
511 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
512
513         Reviewed by Adam Barth.
514
515         nrwt: should skip chromium test expectation overrides on upstream bots
516         https://bugs.webkit.org/show_bug.cgi?id=61888
517
518         * Scripts/webkitpy/layout_tests/port/chromium.py:
519         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
520
521 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
522
523         Reviewed by Ojan Vafai.
524
525         new-run-webkit-tests: minor logging, code cleanup
526         https://bugs.webkit.org/show_bug.cgi?id=62055
527
528         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
529         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
530
531 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
532
533         Try to fix the build failure on the GTK+ 32-bit Release bot.
534
535         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
536
537 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
538
539         Reviewed by Ryosuke Niwa.
540
541         [GTK] Support smart replace for the pasteboard
542         https://bugs.webkit.org/show_bug.cgi?id=61734
543
544         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
545         This is required to produce consistent test results.
546
547         * DumpRenderTree/gtk/DumpRenderTree.cpp:
548         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
549         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
550         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
551         methods which calls into DumpRenderTreeSupportGtk.
552
553 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
554
555         Reviewed by Dimitri Glazkov.
556
557         Teach Gtk build about window.internals
558         https://bugs.webkit.org/show_bug.cgi?id=61071
559
560         * DumpRenderTree/gtk/DumpRenderTree.cpp:
561         (webViewWindowObjectCleared): Inject the new internals object when the
562         window object clears.
563         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
564         Also do a little bit of cleanup.
565
566 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
567
568         Reviewed by Tony Chang.
569
570         Worker may not be stopped after LT.
571         https://bugs.webkit.org/show_bug.cgi?id=61847
572
573         Re-submit a variant of the first fix for this bug. It's possible
574         that actually calling cleanup() in the worker threads was taking
575         too long and we triggered the assertions in the manager thread.
576
577         I've bumped up the timeout in the manager and added better
578         diagnostics. I also cleaned up the cleanup() code a bit because
579         there was some unnecessary if-checks.
580
581         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
582         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
583
584 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
585
586         Reviewed by Tony Chang.
587
588         nrwt: fix duplicate logging regression
589         https://bugs.webkit.org/show_bug.cgi?id=61981
590
591         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
592
593 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
594
595         Reviewed by Adam Barth.
596
597         Modified addTouchPoint to correctly re-use touchPoint id values starting
598         from the lowest not-un-use touchPoint id as is done by the embedder
599         APIs. (Fixes BUGCR36415)
600
601         https://bugs.webkit.org/show_bug.cgi?id=62016
602
603         * DumpRenderTree/chromium/EventSender.cpp:
604         (EventSender::addTouchPoint):
605
606 2011-06-03  Cary Clark  <caryclark@google.com>
607
608         Reviewed by Eric Seidel.
609
610         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
611         https://bugs.webkit.org/show_bug.cgi?id=61534
612
613         Skia on Mac uses Skia to render WebKit, and CG
614         to render UI elements. The CG elements need a
615         transcribed graphics context that preserves the
616         canvas matrix, and the canvas clip.
617
618         The SkiaBitLocker utility class sets up a CGContext
619         from the SkCanvas, locks the bitmap's bits, and
620         releases the lock when the class goes out of scope.
621
622         The SkiaBitLocker implementation is described by
623         this patch:
624         http://codereview.chromium.org/7031006/
625
626         When WebKit uses Skia for rendering, the WebCanvas
627         is an SkCanvas. Create an equivalent CGContext to
628         draw the scrollbar thumb.
629
630         As the Chrome Mac port does not yet use Skia, this
631         patch has no effect and requires no tests.
632
633         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
634         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
635
636 2011-06-03  Andras Becsi  <abecsi@webkit.org>
637
638         Unreviewed build fix.
639
640         Fix typo.
641
642         * Scripts/old-run-webkit-tests:
643
644 2011-06-03  Andras Becsi  <abecsi@webkit.org>
645
646         Reviewed by Csaba Osztrogonác.
647
648         Print error message when there is no httpd present on the system
649         https://bugs.webkit.org/show_bug.cgi?id=61939
650
651         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
652         * Scripts/webkitperl/httpd.pm:
653
654 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
655
656         Reviewed by Yury Semikhatsky.
657
658         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
659         https://bugs.webkit.org/show_bug.cgi?id=61533
660
661         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
662
663         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
664         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
665         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
666         * DumpRenderTree/chromium/LayoutTestController.cpp:
667         (LayoutTestController::LayoutTestController):
668         (LayoutTestController::setJavaScriptProfilingEnabled):
669         * DumpRenderTree/chromium/LayoutTestController.h:
670         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
671         (LayoutTestController::setJavaScriptProfilingEnabled):
672         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
673         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
674         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
675
676 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
677
678         Reviewed by Tony Chang.
679
680         NRWT needs a way to log to a file without including backspaces without needing --verbose
681         https://bugs.webkit.org/show_bug.cgi?id=60328
682
683         This change modifies NRWT so that if it can tell if it is
684         writing to a terminal, it will overwrite any messages printed
685         in the 'one-line-progress' and 'updates' print options, and if
686         not (or if --verbose was specified) the messages will be printed
687         without backspaces.
688
689         If the overwriting updates are disabled, one-line-progress will
690         only print every 10 seconds instead of on every update. This
691         ensures that we still get updates once in a while while the
692         tests are running, even if we're not in --verbose mode. Note
693         that one-line-progress will now still be printed in --verbose,
694         since it's useful as long as you're not flooded with the
695         updates.
696
697         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
698         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
699         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
700
701 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
702
703         Reviewed by Gustavo Noronha Silva.
704
705         [GTK] autogen.sh is run twice for each buld on the bots
706         https://bugs.webkit.org/show_bug.cgi?id=61951
707
708         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
709         for the WebKit project. This prevents build-jsc runs from forcing subsequent
710         build-webkit runs to re-rerun autogen.sh.
711
712 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
713
714         Unreviewed, rolling out r87946.
715         http://trac.webkit.org/changeset/87946
716         https://bugs.webkit.org/show_bug.cgi?id=61965
717
718         Cause NRWT to break (Requested by abarth|gardener on #webkit).
719
720         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
721
722 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
723
724         Reviewed by Darin Adler.
725
726         Add build logistics and plumbing for window.internals object.
727         https://bugs.webkit.org/show_bug.cgi?id=60313
728
729         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
730         * DumpRenderTree/chromium/TestShell.cpp:
731         (TestShell::bindJSObjectsToWindow): Added injection code.
732         * DumpRenderTree/mac/FrameLoadDelegate.mm:
733         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
734
735 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
736
737         Reviewed by Dirk Pranke.
738
739         Call cleanup() explicitly at the end of worker.run().
740         https://bugs.webkit.org/show_bug.cgi?id=61847
741
742         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
743
744 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
745
746         Unreviewed, rolling out r87926.
747         http://trac.webkit.org/changeset/87926
748         https://bugs.webkit.org/show_bug.cgi?id=60313
749
750         Fails to find WebCoreTestSupport.dylib on bots.
751
752         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
753         * DumpRenderTree/chromium/TestShell.cpp:
754         (TestShell::bindJSObjectsToWindow):
755         * DumpRenderTree/mac/FrameLoadDelegate.mm:
756         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
757
758 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
759
760         Reviewed by Darin Adler.
761
762         Add build logistics and plumbing for window.internals object.
763         https://bugs.webkit.org/show_bug.cgi?id=60313
764
765         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
766         * DumpRenderTree/chromium/TestShell.cpp:
767         (TestShell::bindJSObjectsToWindow): Added injection code.
768         * DumpRenderTree/mac/FrameLoadDelegate.mm:
769         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
770
771 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
772
773         Reviewed by Eric Seidel.
774
775         Adjust efl coding style to more efl directories
776         https://bugs.webkit.org/show_bug.cgi?id=61903
777
778         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
779
780 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
781
782         Reviewed by Tony Chang.
783
784         old-run-webkit-tests: add support for audio files
785         https://bugs.webkit.org/show_bug.cgi?id=57992
786
787         * Scripts/old-run-webkit-tests:
788
789 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
790
791         Reviewed by Adam Barth.
792
793         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
794         https://bugs.webkit.org/show_bug.cgi?id=34314
795
796         * DumpRenderTree/DumpRenderTree.gypi:
797         * DumpRenderTree/chromium/LayoutTestController.cpp:
798         (LayoutTestController::LayoutTestController):
799         (LayoutTestController::setImagesAllowed):
800         (LayoutTestController::setStorageAllowed):
801         * DumpRenderTree/chromium/LayoutTestController.h:
802         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
803         (WebPermissions::WebPermissions):
804         (WebPermissions::~WebPermissions):
805         (WebPermissions::allowImages):
806         (WebPermissions::allowStorage):
807         (WebPermissions::setImagesAllowed):
808         (WebPermissions::setStorageAllowed):
809         (WebPermissions::reset):
810         * DumpRenderTree/chromium/WebPermissions.h:
811
812 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
813
814         Reviewed by Tony Chang.
815
816         Test plugin should support event logging on the windows port.
817         https://bugs.webkit.org/show_bug.cgi?id=61721
818
819         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
820         (handleEventWin): Well, handle them.
821
822 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
823
824         Reviewed by Tony Chang.
825
826         [chromium] Use correct file name for dragging out images.
827         https://bugs.webkit.org/show_bug.cgi?id=24887
828
829         * DumpRenderTree/chromium/EventSender.cpp:
830         (EventSender::EventSender):
831         (EventSender::dumpFilenameBeingDragged):
832         * DumpRenderTree/chromium/EventSender.h:
833
834 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
835
836         Reviewed by Tony Chang.
837
838         nrwt: make webaudio work w/o content-length header
839         https://bugs.webkit.org/show_bug.cgi?id=61819
840
841         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
842         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
843         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
844         * Scripts/webkitpy/layout_tests/port/webkit.py:
845
846 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
847
848         Reviewed by Andreas Kling.
849
850         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
851         https://bugs.webkit.org/show_bug.cgi?id=61802
852
853         Add command line parameter and menu item to MiniBrowser application 
854         enabling use of QGLWidget for browser viewport.
855
856         * MiniBrowser/qt/BrowserWindow.cpp:
857         (BrowserWindow::BrowserWindow):
858         (BrowserWindow::toggleGLViewport):
859         * MiniBrowser/qt/BrowserWindow.h:
860         * MiniBrowser/qt/MiniBrowserApplication.cpp:
861         (MiniBrowserApplication::handleUserOptions):
862         * MiniBrowser/qt/MiniBrowserApplication.h:
863         (WindowOptions::WindowOptions):
864
865 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
866
867         Reviewed by Xan Lopez.
868
869         Print out autogen arguments when they differ from the last set, to help
870         with debugging build issues.
871
872         * Scripts/webkitdirs.pm: Print out previous and current build arguments
873         when they differ.
874
875 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
876
877         Reviewed by Martin Robinson.
878
879         [GTK] run-launcher should run MiniBrowser in WebKit2
880         https://bugs.webkit.org/show_bug.cgi?id=61858
881
882         * Scripts/run-launcher: Check whether -2 command line option has
883         been passed and run MiniBrowser instead of GtkLauncher.
884
885 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
886
887         Reviewed by Dirk Pranke.
888
889         Fix exception in verbose printing mode.
890         https://bugs.webkit.org/show_bug.cgi?id=61723
891
892         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
893
894 2011-05-31  Yong Li  <yoli@rim.com>
895
896         Reviewed by Eric Seidel.
897
898         https://bugs.webkit.org/show_bug.cgi?id=54807
899         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
900         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
901         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
902         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
903         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
904         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
905         rule we should have in order to make our code independent from compilers and compiler flags.
906
907         * Scripts/webkitpy/style/checkers/cpp.py:
908
909 2011-05-31  Hironori Bono  <hbono@chromium.org>
910
911         Reviewed by Eric Seidel.
912
913         Add a JavaScript function layoutTestController.setTextDirection().
914         https://bugs.webkit.org/show_bug.cgi?id=50952
915
916         This change adds a new JavaScript function setTextDirection() to the
917         LayoutTestController class of Safari and Chrome to write layout tests
918         that changes the text direction of an editable element.
919
920         * DumpRenderTree/LayoutTestController.cpp:
921         (setTextDirectionCallback):
922         (LayoutTestController::staticFunctions):
923         * DumpRenderTree/LayoutTestController.h:
924         * DumpRenderTree/chromium/LayoutTestController.cpp:
925         (LayoutTestController::LayoutTestController):
926         (LayoutTestController::setTextDirection):
927         * DumpRenderTree/chromium/LayoutTestController.h:
928         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
929         (LayoutTestController::setTextDirection):
930         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
931         (LayoutTestController::setTextDirection):
932         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
933         (LayoutTestController::setTextDirection):
934
935 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
936
937         Reviewed by Simon Hausmann.
938
939         [Qt] User-agent list of Qt test browsers is very outdated
940         https://bugs.webkit.org/show_bug.cgi?id=61531
941
942         The user can edit the user-agent manually, so there's no need to have
943         a super complete and up to date list, but it's nice to have it
944         minimally updated.
945
946         * MiniBrowser/qt/useragentlist.txt:
947         * QtTestBrowser/useragentlist.txt:
948
949 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
950
951         Reviewed by Adam Roben.
952
953         [GTK] [WebKit2] Implement a basic WebKitTestRunner
954         https://bugs.webkit.org/show_bug.cgi?id=57068
955
956         Add an implementation of WebKitTestRunner for GTK+.
957
958         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
959         * Scripts/old-run-webkit-tests: Ditto.
960         * Scripts/run-launcher: Ditto.
961         * Scripts/webkitdirs.pm: Ditto.
962         * WebKitTestRunner/GNUmakefile.am: Added.
963         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
964         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
965         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
966         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
967         * WebKitTestRunner/PlatformWebView.h:
968         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
969         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
970         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
971         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
972         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
973         (main): Added.
974
975 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
976
977         Reviewed by Tony Chang.
978
979         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
980         https://bugs.webkit.org/show_bug.cgi?id=60241
981
982         * Scripts/new-run-webkit-tests:
983
984 2011-05-31  Eric Seidel  <eric@webkit.org>
985
986         Reviewed by David Kilzer.
987
988         webkitpy should create zips with zip -9
989         https://bugs.webkit.org/show_bug.cgi?id=61789
990
991         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
992
993         * Scripts/webkitpy/common/system/workspace.py:
994         * Scripts/webkitpy/common/system/workspace_unittest.py:
995
996 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
997
998         Reviewed by Csaba Osztrogonác.
999
1000         [Qt] Implement find feature for QtTestBrowser
1001         https://bugs.webkit.org/show_bug.cgi?id=61425
1002
1003         Buildfix for --minimal and CONFIG+=qt_minimal build.
1004
1005         * QtTestBrowser/launcherwindow.cpp:
1006         (LauncherWindow::LauncherWindow):
1007         (LauncherWindow::createChrome):
1008         * QtTestBrowser/launcherwindow.h:
1009
1010 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1011
1012         Reviewed by Csaba Osztrogonác.
1013
1014         [Qt] Implement find feature for QtTestBrowser
1015         https://bugs.webkit.org/show_bug.cgi?id=61425
1016
1017         * QtTestBrowser/launcherwindow.cpp:
1018         (LauncherWindow::LauncherWindow):
1019         (LauncherWindow::createChrome):
1020         (LauncherWindow::showFindBar):
1021         (LauncherWindow::find):
1022         * QtTestBrowser/launcherwindow.h:
1023
1024 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1025
1026         Reviewed by Martin Robinson.
1027
1028         [GTK] Implement JavaScript dialogs in MiniBrowser
1029         https://bugs.webkit.org/show_bug.cgi?id=61725
1030
1031         * MiniBrowser/gtk/BrowserWindow.c:
1032         (WKStringGetCString): Helper function to get a UTF-8 c string from
1033         a WKStringRef.
1034         (WKURLGetCString): Helper function to get a UTF-8 c string from a
1035         WKURLRef.
1036         (browserWindowUpdateURL): Update to use WKURLGetCString.
1037         (didReceiveTitleForFrame): Update to use WKStringGetCString.
1038         (createMessageDialog): Create a GtkMessageDialog.
1039         (runJavaScriptAlert):
1040         (runJavaScriptConfirm):
1041         (runJavaScriptPrompt):
1042         (browserWindowUIClientInit):
1043
1044 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
1045
1046         Reviewed by Kent Tamura.
1047
1048         WebSocket closing handshake
1049         https://bugs.webkit.org/show_bug.cgi?id=35721
1050
1051         * Scripts/webkitpy/thirdparty/__init__.py:
1052         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1053         to get the right behavior of closing handshake.
1054
1055 2011-05-29  Daniel Bates  <dbates@rim.com>
1056
1057         Reviewed by David Kilzer.
1058
1059         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
1060         https://bugs.webkit.org/show_bug.cgi?id=61162
1061
1062         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
1063         that omits a line count. In particular, the chunk range regular expression does
1064         not match a chunk range line that omits a line count. GNU diff(1) will omit the
1065         line count in the chunk range if the line count is exactly 1. For example, appending
1066         a new line to the end of an existing file F that contains exactly one line of text will
1067         be represented in a diff with a chunk range line that omits the line count for F.
1068
1069         * Scripts/VCSUtils.pm:
1070           (parseChunkRange): Added.
1071         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
1072         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1073           - Added unit test "Git: Append new line to the end of an existing file".
1074
1075 2011-05-28  Adam Barth  <abarth@webkit.org>
1076
1077         Reviewed by Eric Seidel.
1078
1079         EWS builds patches that fail to build twice, which seems useless and slows down the bots
1080         https://bugs.webkit.org/show_bug.cgi?id=55585
1081
1082         This patch switches all the early warning system bots over to the new
1083         PatchAnalysisTask-based infrastructure.  This patch makes these bots
1084         more efficient (in the case where patches fail to build) and paves the
1085         way for running tests on these bots!
1086
1087         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1088         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1089         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1090         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1091         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1092         * Scripts/webkitpy/tool/commands/queues.py:
1093
1094 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
1095
1096         Reviewed by Kent Tamura.
1097
1098         Add bashi as a committer.
1099
1100         https://bugs.webkit.org/show_bug.cgi?id=61685
1101
1102         * Scripts/webkitpy/common/config/committers.py:
1103
1104 2011-05-27  Adam Barth  <abarth@webkit.org>
1105
1106         Reviewed by Eric Seidel.
1107
1108         When checking whether the tree is red, the EWS posts a link to the wrong log
1109         https://bugs.webkit.org/show_bug.cgi?id=61072
1110
1111         We need to cache the original script error because that contains the
1112         failure log we want to upload.  If we don't cache that script error,
1113         self._script_error will get overwritten when we sanity check the clean
1114         tree (and it also has test failures).
1115
1116         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1117             - This testing approach is slightly goofy.  We'd like to use
1118               assertRaisesRegexp, but that's not available until Python 2.7.
1119         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1120
1121 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
1122
1123         Reviewed by Adam Barth.
1124
1125         Add layoutTestController.setStorageAllowed() to control whether access
1126         to the localStorage API is enabled via the WebPermissionClient
1127         https://bugs.webkit.org/show_bug.cgi?id=61581
1128
1129         * DumpRenderTree/chromium/LayoutTestController.cpp:
1130         (LayoutTestController::LayoutTestController):
1131         (LayoutTestController::setStorageAllowed):
1132         * DumpRenderTree/chromium/LayoutTestController.h:
1133         * DumpRenderTree/chromium/TestShell.cpp:
1134         (TestShell::TestShell):
1135         (TestShell::createNewWindow):
1136         * DumpRenderTree/chromium/TestShell.h:
1137         * DumpRenderTree/chromium/WebPermissions.h: Added.
1138         (WebPermissions::WebPermissions):
1139         (WebPermissions::allowStorage):
1140         (WebPermissions::setStorageAllowed):
1141         (WebPermissions::reset):
1142
1143 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1144
1145         Reviewed by Eric Seidel.
1146
1147         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
1148         https://bugs.webkit.org/show_bug.cgi?id=60326
1149
1150         This patch removes a lot of the complexity from the
1151         metered_stream implementation that was unnecessary since there
1152         was only one caller and the logic could be coordinated better.
1153
1154         There should be no functional changes in this patch, just code
1155         getting deleted and cleaned up.
1156
1157         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1158         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
1159         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1160         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1161
1162 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1163
1164         Reviewed by Eric Seidel.
1165
1166         NRWT: minor cleanup in printing module
1167         https://bugs.webkit.org/show_bug.cgi?id=60329
1168
1169         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1170
1171 2011-05-27  Steve Lacey  <sjl@chromium.org>
1172
1173         Reviewed by David Levin.
1174
1175         Add sjl@chromium.org as a committer.
1176
1177         https://bugs.webkit.org/show_bug.cgi?id=61672
1178
1179         * Scripts/webkitpy/common/config/committers.py:
1180
1181 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1182
1183         Reviewed by Adam Barth.
1184
1185         NRWT: remove --print detailed-progress
1186         https://bugs.webkit.org/show_bug.cgi?id=60324
1187
1188         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1189         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1190         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1191         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1192
1193 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1194
1195         Reviewed by Ojan Vafai.
1196
1197         NRWT: debug messages from the workers are being logged twice
1198         https://bugs.webkit.org/show_bug.cgi?id=60428
1199
1200         It looks like when the workers are run in separate processes
1201         we end up getting two copies of every log message they print.
1202         This has to do with the multiprocessing module on UNIX cloning
1203         the log configuration in a way I wasn't expecting, and so two
1204         log handlers end up getting registered.
1205
1206         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1207         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1208         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1209         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1210
1211 2011-05-27  Adam Roben  <aroben@apple.com>
1212
1213         Always decode tester names from location.hash
1214
1215         When navigating directly to a tester-specific URL (e.g.,
1216         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
1217         with a URL-encoded tester name in the page, and then the encoded name could make its way
1218         into Bugzilla bugs. Bad!
1219
1220         Reviewed by David Kilzer.
1221
1222         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1223         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
1224         decodeURIComponent before trying to use it.
1225
1226 2011-05-27  Adam Roben  <aroben@apple.com>
1227
1228         Remove testing code that snuck into r87528
1229
1230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1231         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
1232
1233 2011-05-27  Adam Roben  <aroben@apple.com>
1234
1235         Add links to TestFailures to easily file bugs about failing tests
1236
1237         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
1238         links to file bugs for failing tests
1239
1240         Reviewed by David Kilzer.
1241
1242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1243         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
1244         for a particular build.
1245         (Builder.prototype._getFailingTests): Use resultsPageURL.
1246
1247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1248         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
1249         failures.
1250         (ViewController.prototype._domForBuildName): Use resultsPageURL.
1251         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
1252         new bug link. The bug has a title, description, and URL already filled in for you!
1253
1254 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1255
1256         Unreviewed, rolling out r87464.
1257         http://trac.webkit.org/changeset/87464
1258         https://bugs.webkit.org/show_bug.cgi?id=61643
1259
1260         client-close/server-close tests are flaky on Chromium Mac and
1261         Windows (Requested by aklein on #webkit).
1262
1263         * Scripts/webkitpy/thirdparty/__init__.py:
1264
1265 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
1266
1267         Added Douglas Davidson to contributors list for easier CC'ing.
1268
1269         * Scripts/webkitpy/common/config/committers.py:
1270
1271 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1272
1273         Reviewed by Adam Barth.
1274
1275         Fix worldID and destinationDomain argument names
1276         https://bugs.webkit.org/show_bug.cgi?id=61571
1277
1278         As part of working on r87423, I noticed a couple of inconsistencies in
1279         argument names:
1280         - We would use worldId in .h files but worldID in .cpp files.
1281           Standardize on the latter
1282         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
1283           destinationDomains argument, even though the actual parameter was for
1284           a single domain (renamed to be singular).
1285
1286         * DumpRenderTree/LayoutTestController.h:
1287         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1288         (LayoutTestController::evaluateScriptInIsolatedWorld):
1289
1290 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
1291
1292         Reviewed by Kent Tamura.
1293
1294         WebSocket closing handshake
1295         https://bugs.webkit.org/show_bug.cgi?id=35721
1296
1297         * Scripts/webkitpy/thirdparty/__init__.py:
1298         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1299         to get the right behavior of closing handshake.
1300
1301 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
1302
1303         Reviewed by Andreas Kling.
1304
1305         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
1306         https://bugs.webkit.org/show_bug.cgi?id=42676
1307
1308         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
1309
1310         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1311         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1312         (WTR::InjectedBundle::beginTesting):
1313         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1314         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
1315         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1316
1317 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1318
1319         Reviewed by Andreas Kling.
1320
1321         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
1322         https://bugs.webkit.org/show_bug.cgi?id=61527
1323
1324         The setMaximumHeight() call is unecessary and breaks the dialog at
1325         least on my setup.
1326
1327         * QtTestBrowser/launcherwindow.cpp:
1328         (LauncherWindow::showUserAgentDialog):
1329
1330 2011-05-02  Robert Hogan  <robert@webkit.org>
1331
1332         Reviewed by Adam Roben.
1333
1334         [Qt] Allow popup windows from plugins when initiated by a user gesture
1335
1336         https://bugs.webkit.org/show_bug.cgi?id=41292
1337
1338         Support parameters introduced in plugin-initiate-popup-window.html
1339
1340         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1341         (webkit_test_plugin_new_instance):
1342         (webkit_test_plugin_handle_event):
1343
1344 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1345
1346         Reviewed by Adam Barth.
1347
1348         Support cross-origin XMLHttpRequest in isolated worlds
1349         https://bugs.webkit.org/show_bug.cgi?id=59843
1350
1351         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
1352
1353         * DumpRenderTree/chromium/LayoutTestController.cpp:
1354         (LayoutTestController::LayoutTestController):
1355         (LayoutTestController::setIsolatedWorldSecurityOrigin):
1356         * DumpRenderTree/chromium/LayoutTestController.h:
1357
1358 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
1359
1360         Reviewed by Adam Roben.
1361
1362         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
1363         https://bugs.webkit.org/show_bug.cgi?id=61474
1364         <rdar://problem/9468337>
1365
1366         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1367         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
1368
1369 2011-05-26  Andreas Kling  <kling@webkit.org>
1370
1371         Unreviewed, correct address to webkit-committers mailing list.
1372
1373         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1374
1375 2011-05-25  Adam Roben  <aroben@apple.com>
1376
1377         Don't assume that builds finish in the order they were started
1378
1379         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
1380         build when one slave is taking a long time to finish a build
1381
1382         Reviewed by Antti Koivisto.
1383
1384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1385         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
1386         newer than the oldest in-progress build are also themselves in progress. Just check whether
1387         each build is actually in progress (as signified by its presence in the currentBuilds set).
1388
1389 2011-05-25  Adam Roben  <aroben@apple.com>
1390
1391         Correctly detect cases where only a single test failed/crashed/timed out
1392
1393         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
1394         failing test
1395
1396         Reviewed by Darin Adler.
1397
1398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1399         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
1400         will be singular when only a single test fails/crashes/times out.
1401
1402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1403         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
1404         failed/crashed/timed out.
1405
1406 2011-05-26  Tom Hudson  <tomhudson@google.com>
1407
1408         Reviewed by Tony Chang.
1409
1410         Add flags to Chromium ImageDiff to write image comparison metrics on
1411         stdout.
1412         https://bugs.webkit.org/show_bug.cgi?id=60569
1413
1414         * DumpRenderTree/chromium/ImageDiff.cpp:
1415         (Image::createFromStdin): Fix spelling.
1416         (maxOf3): New function to do 3-way maximum.
1417         (getRedComponent): Extract red component from ABGR packed encoding.
1418         (getGreenComponent): Extract green component from ABGR packed encoding.
1419         (getBlueComponent): Extract blue component from ABGR packed encoding.
1420         (weightedPercentageDifferent): Determine % of pixels different in two
1421         images multiplied by intensity difference of each pixel.
1422         (printHelp): Document new arguments.
1423         (compareImages): Parameterize.
1424         (untestedCompareImages): Parameterize.
1425         (diffImages): Parameterize; write results on stdout if requested.
1426         (main): Parse new arguments.
1427
1428 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1429
1430         Reviewed by Simon Hausmann.
1431
1432         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
1433         https://bugs.webkit.org/show_bug.cgi?id=42697
1434
1435         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
1436
1437         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1438         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1439         (WTR::InjectedBundle::beginTesting):
1440         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1441         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
1442         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1443
1444 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
1445
1446         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
1447         https://bugs.webkit.org/show_bug.cgi?id=61428
1448         <rdar://problem/9457006>
1449
1450         Reviewed by Adam Roben.
1451
1452         The crash occurs when Flash posts a message to a window that it
1453         creates, and in processing the message, it calls NPN_Evaluate to
1454         evaluate JavaScript that removes the plug-in from the page. Flash then
1455         crashes when we return to Flash code.
1456
1457         This test emulates that behavior.
1458
1459         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
1460         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
1461         Initialize member vars.
1462         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
1463         Remove our custom property from the message window, and destroy it.
1464         (CallJSThatDestroysPlugin::NPP_Destroy):
1465         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
1466         layout test controller that we're done.
1467         (wndProc):
1468         Get the PluginTest object, and call its runTest() function.
1469         (CallJSThatDestroysPlugin::NPP_New):
1470         Setup the test: register a class for the message-only window, create
1471         it, and post a message to it to run the test.
1472         (CallJSThatDestroysPlugin::runTest):
1473         Execute JS that removes the plug-in from the page, and if we're not
1474         destroyed, log a success message.
1475
1476         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1477         Add new test to project.
1478
1479 2011-05-25  Tony Chang  <tony@chromium.org>
1480
1481         Reviewed by Adam Barth.
1482
1483         webkitpy's NetworkTransaction shouldn't use mechanize
1484         https://bugs.webkit.org/show_bug.cgi?id=61450
1485
1486         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
1487         use urllib2 directly.  Re-add NetworkTransaction to
1488         test_results_uploader.py (reverting r87124).
1489
1490         * Scripts/webkitpy/common/net/networktransaction.py:
1491         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1492
1493 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1494
1495         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
1496         until the port begins using those export macros.
1497
1498         * DumpRenderTree/chromium/config.h:
1499
1500 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1501
1502         Unreviewed, rolling out r87257.
1503         http://trac.webkit.org/changeset/87257
1504         https://bugs.webkit.org/show_bug.cgi?id=61457
1505
1506         This broke layout tests, see bug 61431. (Requested by
1507         hwennborg on #webkit).
1508
1509         * DumpRenderTree/chromium/LayoutTestController.cpp:
1510         (LayoutTestController::LayoutTestController):
1511         (LayoutTestController::clearAllDatabases):
1512         * DumpRenderTree/chromium/LayoutTestController.h:
1513
1514 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1515
1516         Reviewed by Andreas Kling.
1517
1518         [Qt] fast/css/disabled-author-styles.html failed
1519         https://bugs.webkit.org/show_bug.cgi?id=61438
1520
1521         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
1522
1523         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1524         (WebCore::WebPage::resetSettings):
1525         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1526         (LayoutTestController::setAuthorAndUserStylesEnabled):
1527         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1528
1529 2011-05-25  Adam Roben  <aroben@apple.com>
1530
1531         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
1532
1533         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
1534         started exiting early due to too many crashes, timeouts, or failures
1535
1536         Reviewed by David Kilzer.
1537
1538         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1539         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
1540         run-webkit-tests exits early due to too many failures, pass that information in another
1541         argument to the callback.
1542         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
1543         the new structure of the object passed to the callback.
1544         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
1545         getNumberOfFailingTests and to pass that along to our own callbacks.
1546         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
1547         from _getFailingTests and to store that value in the history object.
1548
1549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1550         (.info): Added.
1551
1552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1553         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
1554         object and to add a note when run-webkit-tests exited early due to too many failures.
1555         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
1556         latestBuildInfos since each entry now contains more than just the tester and failure count.
1557         Now displays a message for testers where the latest build exited early due to too many
1558         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
1559         store that value in latestBuildInfos.
1560
1561 2011-05-24  Keishi Hattori  <keishi@webkit.org>
1562
1563         Reviewed by Kent Tamura.
1564
1565         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
1566         https://bugs.webkit.org/show_bug.cgi?id=61273
1567
1568         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
1569
1570 2011-05-24  Greg Simon  <gregsimon@chromium.org>
1571
1572         Reviewed by Dimitri Glazkov.
1573
1574         Control Indexeddb backends from LayoutTestController
1575         https://bugs.webkit.org/show_bug.cgi?id=61000
1576
1577         * DumpRenderTree/chromium/LayoutTestController.cpp:
1578         (LayoutTestController::LayoutTestController):
1579         (LayoutTestController::setOverrideIndexedDBBackingStore):
1580         (LayoutTestController::clearAllDatabases):
1581         * DumpRenderTree/chromium/LayoutTestController.h:
1582
1583 2011-05-24  Robert Hogan  <robert@webkit.org>
1584
1585         Reviewed by Ryosuke Niwa.
1586
1587         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
1588         https://bugs.webkit.org/show_bug.cgi?id=61393
1589
1590         * DumpRenderTree/qt/EventSenderQt.h:
1591         * DumpRenderTree/qt/EventSenderQt.cpp:
1592         (getModifiers): static function for interpreting modifiers
1593         (EventSender::mouseDown): Respect keyboard modifiers
1594         (EventSender::keyDown): use new static function
1595         (EventSender::sendOrQueueEvent): whitespace fix
1596
1597 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
1598
1599         Reviewed by Adam Barth.
1600
1601         Adding MHTML reading support.
1602         https://bugs.webkit.org/show_bug.cgi?id=7168
1603
1604         * Scripts/build-webkit:
1605         * Scripts/old-run-webkit-tests:
1606         * Scripts/webkitperl/features.pm:
1607         * Scripts/webkitpy/layout_tests/port/test_files.py:
1608         * Scripts/webkitpy/layout_tests/port/webkit.py:
1609
1610 2011-05-24  Stephen White  <senorblanco@chromium.org>
1611
1612         Reviewed by Kenneth Russell.
1613
1614         Remove most style checks on Source/ThirdParty/glu, since it doesn't
1615         follow WebKit style.
1616         https://bugs.webkit.org/show_bug.cgi?id=61365
1617
1618         * Scripts/webkitpy/style/checker.py:
1619
1620 2011-05-24  Adam Roben  <aroben@apple.com>
1621
1622         Don't allow forcing builds through the build.webkit.org web interface
1623
1624         Someone has been forcing bogus builds.
1625
1626         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1627
1628 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
1629
1630         Reviewed by Adam Roben.
1631
1632         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1633         https://bugs.webkit.org/show_bug.cgi?id=42669
1634
1635         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
1636         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
1637         Because that case changed the setting.
1638
1639         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1640         (WTR::InjectedBundle::beginTesting):
1641
1642 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
1643
1644         Reviewed by Kenneth Rohde Christiansen.
1645
1646         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
1647         https://bugs.webkit.org/show_bug.cgi?id=61052
1648
1649         * Scripts/old-run-webkit-tests:
1650
1651 2011-05-24  Adam Roben  <aroben@apple.com>
1652
1653         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
1654
1655         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
1656         that don't have any failing tests, which isn't useful
1657
1658         Reviewed by David Kilzer.
1659
1660         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
1661         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
1662         instead of name strings.
1663         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
1664         builder names into an array of builders.
1665
1666         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1667         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
1668         the most recently completed build, or -1 if there is no such build.
1669         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
1670         in the given build, or -1 if the number could not be determined. Some of this code came from
1671         _getFailingTests.
1672         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
1673         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
1674         getNumberOfFailingTests functions.
1675
1676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1677         (ViewController.prototype._displayTesters): Get the current number of test failures for each
1678         tester and show it in the list. Omit testers that have no failures at all. We keep the
1679         testers and failure counts in an array and sort it before displaying the current data, as
1680         the order in which data will be fetched is unpredictable.
1681
1682 2011-05-23  Tony Chang  <tony@chromium.org>
1683
1684         Reviewed by Ojan Vafai.
1685
1686         [nrwt] don't use NetworkTranslation when uploading results
1687         https://bugs.webkit.org/show_bug.cgi?id=61315
1688
1689         This avoids autoinstalling mechanize.  It didn't matter anyway
1690         because test_results_uploader.py wasn't using mechanize to make the
1691         request so NetworkTransaction::run wasn't doing anything extra
1692         (it only matters if it catches mechanize.HTTPError).
1693
1694         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1695
1696 2011-05-23  Tony Chang  <tony@chromium.org>
1697
1698         Reviewed by Dirk Pranke.
1699
1700         [chromium] fix the rebaseline tool to work with Linux GPU failures
1701         https://bugs.webkit.org/show_bug.cgi?id=61312
1702
1703         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1704
1705 2011-05-23  Darin Adler  <darin@apple.com>
1706
1707         Ignore generated .pyc files in a directory full of python code.
1708
1709         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
1710
1711 2011-05-23  Adam Barth  <abarth@webkit.org>
1712
1713         Reviewed by Eric Seidel.
1714
1715         sheriffbot should give more details about the failures in IRC
1716         https://bugs.webkit.org/show_bug.cgi?id=61233
1717
1718         With this patch, sheriffbot will annonce the set of failing tests,
1719         which might help folks triage the problem.
1720
1721         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1722         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1723
1724 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1725
1726         Unreviewed, rolling out r87078.
1727         http://trac.webkit.org/changeset/87078
1728         https://bugs.webkit.org/show_bug.cgi?id=61294
1729
1730         Patch contains errors and seems likely to break a bunch of
1731         bots (Requested by abarth on #webkit).
1732
1733         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1734         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1735         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1736
1737 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
1738
1739         Reviewed by Ojan Vafai.
1740
1741         Convert json_results_generator.py to output version 4 JSON.
1742         https://bugs.webkit.org/show_bug.cgi?id=60869
1743
1744         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1745         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1746         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1747
1748 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
1749
1750         Reviewed by Adam Barth.
1751
1752         Move generation of shell_command from port to executive
1753         https://bugs.webkit.org/show_bug.cgi?id=61251
1754
1755         After move it's possible to use the code in other places too.
1756
1757         * Scripts/webkitpy/common/config/ports.py:
1758         * Scripts/webkitpy/common/system/executive.py:
1759
1760 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
1761
1762         Reviewed by Darin Adler.
1763
1764         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1765         https://bugs.webkit.org/show_bug.cgi?id=42669
1766
1767         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
1768
1769         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1770         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1771         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
1772         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1773
1774 2011-05-22  Robert Hogan  <robert@webkit.org>
1775
1776         Reviewed by Kenneth Rohde Christiansen.
1777
1778         Fix policyDelegate in Qt DRT
1779         https://bugs.webkit.org/show_bug.cgi?id=61247
1780
1781         Use the 'policy delegate' implemented in FrameLoaderClient
1782         for layout tests. The partial implementation in DumpRenderTreeQt
1783         is redundant, so remove it.
1784
1785         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1786         (WebCore::WebPage::acceptNavigationRequest):
1787         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1788         (LayoutTestController::waitForPolicyDelegate):
1789
1790 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
1791
1792         Reviewed by Darin Adler.
1793
1794         Use double quotes for filename arguments
1795         https://bugs.webkit.org/show_bug.cgi?id=61250
1796
1797         Windows does not support single quotes on the command line,
1798         so replace them with double quotes.
1799
1800         * Scripts/prepare-ChangeLog:
1801
1802 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
1803
1804         Reviewed by Sam Weinig.
1805
1806         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
1807         https://bugs.webkit.org/show_bug.cgi?id=42550
1808         
1809         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
1810
1811         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1812         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1813         Copy the code for pausing animations, FIXME comments and all.
1814         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1815         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1816
1817 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
1818
1819         Reviewed by Stephen White.
1820
1821         Adding myself to the committers list.
1822
1823         * Scripts/webkitpy/common/config/committers.py:
1824
1825 2011-05-19  Adam Roben  <aroben@apple.com>
1826
1827         Test that the WebKit2 UI process doesn't crash when starting a download
1828
1829         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
1830         (preceded by assertion) in fastMalloc when downloading a file
1831
1832         Reviewed by Darin Adler.
1833
1834         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
1835
1836         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
1837         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
1838         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
1839         started, cancel the download, and return a bogus string.
1840
1841         (TestWebKitAPI::setContextDownloadClient):
1842         (TestWebKitAPI::setPagePolicyClient):
1843         Simple helper functions.
1844
1845         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
1846         our policy client, and run until we know that the download was started. If we haven't
1847         crashed, we win!
1848
1849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1850         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1851         * TestWebKitAPI/win/copy-resources.cmd:
1852         Added new files.
1853
1854 2011-05-20  Kent Tamura  <tkent@chromium.org>
1855
1856         Reviewed by Ryosuke Niwa.
1857
1858         Fix style errors in DumpRenderTree/chromium/.
1859         https://bugs.webkit.org/show_bug.cgi?id=61172
1860
1861         * DumpRenderTree/chromium/CppBoundClass.cpp:
1862         (CppBoundClass::getAsCppVariant):
1863         (CppBoundClass::bindToJavascript):
1864         * DumpRenderTree/chromium/CppBoundClass.h:
1865         (CppBoundClass::GetterCallback::~GetterCallback):
1866         (CppBoundClass::CppBoundClass):
1867         (CppBoundClass::Callback::~Callback):
1868         (CppBoundClass::MemberCallback::MemberCallback):
1869         (CppBoundClass::MemberCallback::~MemberCallback):
1870         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
1871         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
1872         * DumpRenderTree/chromium/CppVariant.h:
1873         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1874         (DRTDevToolsAgent::~DRTDevToolsAgent):
1875         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1876         (DRTDevToolsClient::sendFrontendLoaded):
1877         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1878         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1879         (main):
1880         * DumpRenderTree/chromium/EventSender.cpp:
1881         (SavedEvent::SavedEvent):
1882         (EventSender::EventSender):
1883         (EventSender::keyDown):
1884         * DumpRenderTree/chromium/EventSender.h:
1885         * DumpRenderTree/chromium/ImageDiff.cpp:
1886         (Image::Image):
1887         * DumpRenderTree/chromium/LayoutTestController.cpp:
1888         (LayoutTestController::LayoutTestController):
1889         (LayoutTestController::WorkQueue::reset):
1890         (WorkItemBackForward::WorkItemBackForward):
1891         (WorkItemLoadingScript::WorkItemLoadingScript):
1892         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
1893         (WorkItemLoad::WorkItemLoad):
1894         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1895         (LayoutTestController::pathToLocalResource):
1896         * DumpRenderTree/chromium/LayoutTestController.h:
1897         (LayoutTestController::WorkItem::~WorkItem):
1898         (LayoutTestController::WorkQueue::WorkQueue):
1899         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1900         (MockSpellCheck::MockSpellCheck):
1901         (MockSpellCheck::~MockSpellCheck):
1902         * DumpRenderTree/chromium/MockSpellCheck.h:
1903         * DumpRenderTree/chromium/NotificationPresenter.h:
1904         (NotificationPresenter::NotificationPresenter):
1905         * DumpRenderTree/chromium/Task.cpp:
1906         (WebTask::WebTask):
1907         * DumpRenderTree/chromium/Task.h:
1908         (TaskList::TaskList):
1909         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1910         (DRTPrinter::DRTPrinter):
1911         (TestShellPrinter::TestShellPrinter):
1912         * DumpRenderTree/chromium/TestNavigationController.cpp:
1913         (TestNavigationEntry::TestNavigationEntry):
1914         (TestNavigationEntry::~TestNavigationEntry):
1915         (TestNavigationController::TestNavigationController):
1916         (TestNavigationController::reload):
1917         (TestNavigationController::loadEntry):
1918         (TestNavigationController::didNavigateToEntry):
1919         * DumpRenderTree/chromium/TestNavigationController.h:
1920         (TestShellExtraData::TestShellExtraData):
1921         * DumpRenderTree/chromium/TestShell.cpp:
1922         (dumpHistoryItem):
1923         * DumpRenderTree/chromium/TestShell.h:
1924         (TestParams::TestParams):
1925         * DumpRenderTree/chromium/TestShellWin.cpp:
1926         (TestShell::waitTestFinished):
1927         * DumpRenderTree/chromium/TestWebWorker.h:
1928         (TestWebWorker::startWorkerContext):
1929         (TestWebWorker::terminateWorkerContext):
1930         (TestWebWorker::postMessageToWorkerContext):
1931         (TestWebWorker::clientDestroyed):
1932         (TestWebWorker::postMessageToWorkerObject):
1933         (TestWebWorker::postExceptionToWorkerObject):
1934         (TestWebWorker::postConsoleMessageToWorkerObject):
1935         (TestWebWorker::confirmMessageFromWorkerObject):
1936         (TestWebWorker::reportPendingActivity):
1937         (TestWebWorker::workerContextClosed):
1938         (TestWebWorker::~TestWebWorker):
1939         * DumpRenderTree/chromium/TextInputController.cpp:
1940         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1941         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1942         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1943         (WebThemeEngineDRTWin::paintButton):
1944         (WebThemeEngineDRTWin::paintMenuList):
1945         (WebThemeEngineDRTWin::paintTrackbar):
1946         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
1947         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1948         * DumpRenderTree/chromium/WebViewHost.cpp:
1949         (WebViewHost::navigate):
1950         (WebViewHost::updateSessionHistory):
1951         (WebViewHost::paintInvalidatedRegion):
1952         * DumpRenderTree/chromium/WebViewHost.h:
1953
1954 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1955
1956         Reviewed by Adam Roben.
1957
1958         Detect hangs in run-api-tests
1959         https://bugs.webkit.org/show_bug.cgi?id=48043
1960
1961         * Scripts/run-api-tests: Added test timeouts
1962
1963 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1964
1965         Reviewed by Adam Roben.
1966
1967         run-api-tests should run one test per process
1968         https://bugs.webkit.org/show_bug.cgi?id=61088
1969
1970         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
1971         return code, and parsing GTest output format.
1972
1973 2011-05-15  Robert Hogan  <robert@webkit.org>
1974
1975         Reviewed by Antonio Gomes.
1976
1977         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
1978         https://bugs.webkit.org/show_bug.cgi?id=60834
1979         Fix unix test plugin for plugins/get-url-with-javascript-url.html
1980
1981         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1982         (webkit_test_plugin_new_stream):
1983         (webkit_test_plugin_write_ready):
1984         (webkit_test_plugin_write):
1985
1986 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1987
1988         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
1989         http://trac.webkit.org/changeset/86869
1990         http://trac.webkit.org/changeset/86873
1991         http://trac.webkit.org/changeset/86875
1992         http://trac.webkit.org/changeset/86877
1993         https://bugs.webkit.org/show_bug.cgi?id=61139
1994
1995         broke builds and debug DRT (Requested by rniwa on #webkit).
1996
1997         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1998         * DumpRenderTree/chromium/TestShell.cpp:
1999         (TestShell::bindJSObjectsToWindow):
2000         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2001         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2002
2003 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
2004
2005         Reviewed by Darin Adler.
2006
2007         Add build logistics and plumbing for window.internals object.
2008         https://bugs.webkit.org/show_bug.cgi?id=60313
2009
2010         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2011         * DumpRenderTree/chromium/TestShell.cpp:
2012         (TestShell::bindJSObjectsToWindow): Added injection code.
2013         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2014         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2015
2016 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2017
2018         Reviewed by Csaba Osztrogonác.
2019
2020         [Qt] Implement eventSender.scalePageBy
2021         https://bugs.webkit.org/show_bug.cgi?id=60015
2022
2023         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2024         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2025         * DumpRenderTree/qt/EventSenderQt.cpp:
2026         (EventSender::scalePageBy):
2027         * DumpRenderTree/qt/EventSenderQt.h:
2028
2029 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
2030
2031         Reviewed by Kent Tamura.
2032
2033         [Chromium] IME candidate window appears wrong position in an iframe
2034         https://bugs.webkit.org/show_bug.cgi?id=61023
2035
2036         Call the focused frame's firstRectForCharacterRange() instead of the
2037         main frame so that DRT behaves as the same as Chromium.
2038
2039         * DumpRenderTree/chromium/TextInputController.cpp:
2040         (TextInputController::firstRectForCharacterRange):
2041
2042 2011-05-18  Adam Roben  <aroben@apple.com>
2043
2044         Add a new page to build.webkit.org to help find when tests started failing
2045
2046         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
2047         right now, but already shows some useful information. It's somewhat similar to webkit-patch
2048         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
2049         little more convenient than either of them, though, because it's all done in the browser
2050         (and thus it's easy to go directly to the relevant test results).
2051
2052         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
2053         (Buildbot): This class represents a Buildbot server.
2054         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
2055         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
2056         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
2057         callback.
2058         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
2059         be implemented by a derived class that understands this server's build naming scheme.
2060         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2061         particular build.
2062
2063         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
2064         (Builder): This class represents one builder on the buildbot.
2065         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
2066         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
2067         information about a particular test failure.
2068         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
2069         information about when tests started failing.
2070         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2071         particular build.
2072         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
2073         callback.
2074         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
2075         extracts all the failing tests listed in it, passing them to the callback.
2076         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
2077         build, merges them into the build history, and calls the callback telling it whether the
2078         next build should be fetched to provide more information.
2079
2080         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2081         Added. Just some simple styles.
2082
2083         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
2084         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
2085         (getResource): Wrapper around XMLHttpRequest.
2086         (Array.prototype.findFirst): Finds the first element matching the given predicate and
2087         returns it.
2088         (Array.prototype.last): Returns the last element of the array.
2089
2090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
2091         (ViewController): This class contains the main logic for displaying the page.
2092         (ViewController.loaded): Just calls through to parseHash.
2093         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
2094         shows the list of all testers so one can be chosen. This function is called when the page
2095         loads and whenever we get a hashchange event.
2096         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
2097         as it is fetched. The display ends up grouping tests by when they started failing.
2098         (ViewController._displayTesters): Gets the list of testers and displays it.
2099
2100         (ViewController._domForBuildName):
2101         (ViewController._domForFailedTest):
2102         Helper functions to create descriptions and links for a particular build or failed test.
2103
2104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
2105         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
2106         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
2107
2108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
2109         loads all the files and sets up a ViewController, which does the rest.
2110
2111         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
2112         page.
2113
2114 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2115
2116         Reviewed by Csaba Osztrogonác.
2117
2118         [Qt] Implement layoutTestController.setValueForUser()
2119         https://bugs.webkit.org/show_bug.cgi?id=60956
2120
2121         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2122         (LayoutTestController::setValueForUser):
2123         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2124
2125 2011-05-16  Robert Hogan  <robert@webkit.org>
2126
2127         Reviewed by Kenneth Rohde Christiansen.
2128
2129         plugins/invalidate_rect.html fails on linux ports
2130
2131         - Make the unix test netscape plugin recognize the onPaintEvent
2132           and windowedPlugin parameters.
2133
2134         https://bugs.webkit.org/show_bug.cgi?id=54051
2135
2136         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2137         (handleEventX11):
2138         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2139         (LayoutTestController::displayInvalidatedRegion):
2140         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2141         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2142         (webkit_test_plugin_new_instance):
2143         (webkit_test_plugin_handle_event):
2144
2145 2011-05-17  Tony Chang  <tony@chromium.org>
2146
2147         Reviewed by Ojan Vafai.
2148
2149         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
2150         https://bugs.webkit.org/show_bug.cgi?id=60895
2151
2152         Update the tools to handle the move.  Lucid 32 results now go in
2153         chromium-linux-x86 and the default platform on Linux is now x86_64.
2154
2155         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
2156         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2157         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
2158         * Scripts/webkitpy/layout_tests/port/base.py: ditto
2159         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
2160         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2161         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
2162         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
2163         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
2164
2165 2011-05-17  Adam Roben  <aroben@apple.com>
2166
2167         Make run-api-tests work on Windows when there are spaces in the path
2168
2169         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
2170         spaces in the path to TestWebKitAPI.exe
2171
2172         Reviewed by David Levin.
2173
2174         * Scripts/run-api-tests:
2175         (runTestTool): Use the "direct object" form of system() to avoid having the path to
2176         TestWebKitAPI.exe be split by the shell.
2177
2178 2011-05-16  Ian Henderson  <ianh@apple.com>
2179
2180         Reviewed by Joseph Pecoraro.
2181
2182         Page::goToItem doesn't work while loading is deferred
2183         https://bugs.webkit.org/show_bug.cgi?id=60412
2184
2185         Add setDefersLoading and goBack methods to LayoutTestController.  We
2186         need to use goBack() instead of history.back() because the latter goes
2187         through NavigationScheduler, hence doesn't exhibit the bug.
2188
2189         * DumpRenderTree/LayoutTestController.cpp:
2190         (goBackCallback):
2191         (setDefersLoadingCallback):
2192         (LayoutTestController::staticFunctions):
2193         * DumpRenderTree/LayoutTestController.h:
2194         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2195         (LayoutTestController::goBack):
2196         (LayoutTestController::setDefersLoading):
2197         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2198         (LayoutTestController::goBack):
2199         (LayoutTestController::setDefersLoading):
2200         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2201         (LayoutTestController::goBack):
2202         (LayoutTestController::setDefersLoading):
2203         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2204         (LayoutTestController::goBack):
2205         (LayoutTestController::setDefersLoading):
2206
2207 2011-05-16  Sam Weinig  <sam@webkit.org>
2208
2209         Reviewed by Anders Carlsson.
2210
2211         TestWebKitAPI should build with clang if it can
2212         https://bugs.webkit.org/show_bug.cgi?id=60918
2213
2214         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2215         Update CompilerVersion.xcconfig to match others.
2216
2217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2218         Add CompilerVersion.xcconfig to the project.
2219
2220         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2221         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2222         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2223         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2224         Add some casts to quiet warnings from clang.
2225
2226 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
2227
2228         Reviewed by David Levin.
2229
2230         add dpranke as a reviewer
2231         https://bugs.webkit.org/show_bug.cgi?id=60919
2232
2233         * Scripts/webkitpy/common/config/committers.py:
2234
2235 2011-05-16  Robert Hogan  <robert@webkit.org>
2236
2237         Reviewed by Anders Carlsson.
2238
2239         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
2240
2241         https://bugs.webkit.org/show_bug.cgi?id=60838
2242
2243         The unix test plugin needs to call the test's NPP_URLNotify
2244         rather than the browsers.
2245
2246         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2247         (webkit_test_plugin_url_notify):
2248
2249 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
2250
2251         Rubber-stamped by Adam Roben.
2252
2253         Adding myself as a reviewer.
2254         * Scripts/webkitpy/common/config/committers.py:
2255
2256 2011-05-16  Sam Weinig  <sam@webkit.org>
2257
2258         Fix typo pointed out by Dave Levin.
2259
2260         * TestWebKitAPI/PlatformUtilities.h:
2261         (TestWebKitAPI::Util::assertWKStringEqual):
2262         Strig -> String.
2263
2264 2011-05-16  Sam Weinig  <sam@webkit.org>
2265
2266         Reviewed by David Levin.
2267
2268         Convert api tester over to using gtest expectations directly
2269         https://bugs.webkit.org/show_bug.cgi?id=60862
2270
2271         * TestWebKitAPI/PlatformUtilities.cpp:
2272         (TestWebKitAPI::Util::toSTD):
2273         * TestWebKitAPI/PlatformUtilities.h:
2274         (TestWebKitAPI::Util::assertWKStrigEqual):
2275         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
2276         the implementation of the macro simpler.
2277
2278         * TestWebKitAPI/Test.h:
2279         Remove TEST_ASSERT forwarder.
2280
2281         [Test changes elided]
2282
2283 2011-05-16  David Kilzer  <ddkilzer@apple.com>
2284
2285         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
2286         <rdar://problem/9446430>
2287
2288         Reviewed by Mark Rowe.
2289
2290         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
2291         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2292         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2293
2294 2011-05-16  Jon Lee  <jonlee@apple.com>
2295
2296         Reviewed by Simon Fraser.
2297
2298         Can't horizontally scroll iframes and overflow because wheel events are always accepted
2299         https://bugs.webkit.org/show_bug.cgi?id=60779
2300
2301         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2302         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
2303
2304 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2305
2306         Reviewed by Csaba Osztrogonác.
2307
2308         [Qt] Tools.pro misses include(common.pri)
2309         https://bugs.webkit.org/show_bug.cgi?id=60883
2310
2311         It includes features.pri, which depends on common.pri (the build is
2312         not broken today with the default options, but this is the right
2313         thing to do).
2314
2315         * Tools.pro:
2316
2317 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
2318
2319         Unreviewed: adding myself to committers.py.
2320
2321         * Scripts/webkitpy/common/config/committers.py:
2322
2323 2011-05-15  Daniel Bates  <dbates@webkit.org>
2324
2325         Reviewed by Chris Jerdonek.
2326
2327         svn-apply can't handle Git diff that only changes executable bit
2328         https://bugs.webkit.org/show_bug.cgi?id=60848
2329
2330         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
2331         that only has an executable bit change.
2332
2333         * Scripts/VCSUtils.pm:
2334           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
2335         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
2336         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
2337         * Scripts/svn-apply:
2338         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
2339         * Scripts/svn-unapply:
2340         (patch): Ditto.
2341         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2342           - Updated expected results for test cases to account for numTextChunks.
2343           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
2344           - Added test case "Git: file that only has an executable bit change".
2345         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2346           - Updated expected results for test cases to account for numTextChunks.
2347
2348 2011-05-15  Sam Weinig  <sam@webkit.org>
2349
2350         Fix windows build.
2351
2352         * TestWebKitAPI/win/main.cpp:
2353         (main):
2354
2355 2011-05-15  Sam Weinig  <sam@webkit.org>
2356
2357         Reviewed by David Levin.
2358
2359         Make API tester more gtest friendly
2360         https://bugs.webkit.org/show_bug.cgi?id=60859
2361
2362         * Scripts/run-api-tests:
2363         Numerous changes:
2364         - Remove logic to run tests one at a time.
2365         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
2366           the test runner and allow gtest to print it for us.
2367         - Forward stdout from the test tool to stdout, even in non-verbose runs.
2368         - Run test tool from the current working directory instead of the root webkit
2369           directory.
2370
2371         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2372         Move plist to be with other bundle sources.
2373
2374         * TestWebKitAPI/TestsController.cpp:
2375         (TestWebKitAPI::TestsController::TestsController):
2376         (TestWebKitAPI::TestsController::run):
2377         * TestWebKitAPI/TestsController.h:
2378         * TestWebKitAPI/mac/main.mm:
2379         Simplify TestController down to a single run function. We should consider removing the class
2380         entirely at some point.
2381
2382 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2383
2384         Unreviewed, rolling out r86504.
2385         http://trac.webkit.org/changeset/86504
2386         https://bugs.webkit.org/show_bug.cgi?id=60853
2387
2388         "Broke Qt EventSender in editing/selection tests" (Requested
2389         by mwenge on #webkit).
2390
2391         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2392         (WebCore::WebPage::WebPage):
2393         (WebCore::DumpRenderTree::DumpRenderTree):
2394         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2395         (WebCore::DumpRenderTree::initJSObjects):
2396         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2397         (WebCore::DumpRenderTree::eventSender):
2398         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2399         (webkit_test_plugin_new_instance):
2400         (webkit_test_plugin_set_window):
2401         (webkit_test_plugin_handle_event):
2402
2403 2011-05-12  Robert Hogan  <robert@webkit.org>
2404
2405         Reviewed by Benjamin Poulain.
2406
2407         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2408
2409         The support for this test added to the unix test plugin here
2410         may allow other platforms to pass it (nearly everyone
2411         skips it). On Qt it required a bit of trickiness with
2412         the page's EventSender object to get it working fully though,
2413         so only unskipping Qt here.
2414
2415         https://bugs.webkit.org/show_bug.cgi?id=60722
2416
2417         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2418         (WebCore::WebPage::WebPage):
2419         (WebCore::WebPage::eventSender):
2420         (WebCore::DumpRenderTree::DumpRenderTree):
2421         (WebCore::DumpRenderTree::initJSObjects):
2422         (WebCore::DumpRenderTree::createWindow):
2423         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2424         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2425         (webkit_test_plugin_new_instance):
2426         (webkit_test_plugin_set_window):
2427         (webkit_test_plugin_handle_event):
2428
2429 2011-05-14  Arno Renevier  <arno@renevier.net>
2430
2431         Reviewed by Martin Robinson.
2432
2433         make run-gtk-tests executable
2434         https://bugs.webkit.org/show_bug.cgi?id=59278
2435
2436         * Scripts/run-gtk-tests:
2437
2438 2011-05-14  Anders Carlsson  <andersca@apple.com>
2439
2440         Reviewed by Kevin Decker.
2441
2442         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2443         https://bugs.webkit.org/show_bug.cgi?id=60823
2444         <rdar://problem/9430386>
2445
2446         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2447
2448         * DumpRenderTree/DumpRenderTree.gypi:
2449         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2450         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2451         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2452         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2453         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2454         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2455         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2456         * GNUmakefile.am:
2457
2458 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2459
2460         Unreviewed, rolling out r86476.
2461         http://trac.webkit.org/changeset/86476
2462         https://bugs.webkit.org/show_bug.cgi?id=60832
2463
2464         It made plugins/get-url-notify-with-url-that-fails-to-
2465         load.html crash on GTK (Requested by Ossy on #webkit).
2466
2467         * DumpRenderTree/DumpRenderTree.gypi:
2468         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2469         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
2470         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2471         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2472         * GNUmakefile.am:
2473
2474 2011-05-13  Anders Carlsson  <andersca@apple.com>
2475
2476         Reviewed by Sam Weinig.
2477
2478         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2479         https://bugs.webkit.org/show_bug.cgi?id=60823
2480         <rdar://problem/9430386>
2481
2482         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2483
2484         * DumpRenderTree/DumpRenderTree.gypi:
2485         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2486         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2487         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2488         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2489         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2490         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2491         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2492         * GNUmakefile.am:
2493
2494 2011-05-13  Anders Carlsson  <andersca@apple.com>
2495
2496         Build fix.
2497
2498         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
2499
2500 2011-05-13  Anders Carlsson  <andersca@apple.com>
2501
2502         Reviewed by Sam Weinig.
2503
2504         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
2505         https://bugs.webkit.org/show_bug.cgi?id=60810
2506
2507         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
2508
2509         * DumpRenderTree/DumpRenderTree.gypi:
2510         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2511         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2512         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2513         * GNUmakefile.am:
2514         Add files.
2515
2516         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2517         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2518         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
2519
2520         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
2521         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
2522         (GetURLWithJavaScriptURL::NPP_New):
2523         (GetURLWithJavaScriptURL::NPP_NewStream):
2524         (GetURLWithJavaScriptURL::NPP_DestroyStream):
2525         (GetURLWithJavaScriptURL::NPP_WriteReady):
2526         (GetURLWithJavaScriptURL::NPP_Write):
2527         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2528         (NPP_NewStream):
2529         (NPP_WriteReady):
2530         (NPP_Write):
2531         (NPP_URLNotify):
2532         call the PluginTest NPP wrappers.
2533
2534 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2535
2536         Unreviewed, rolling out r86447.
2537         http://trac.webkit.org/changeset/86447
2538         https://bugs.webkit.org/show_bug.cgi?id=60809
2539
2540         "Broke some uses of EventSender object on Qt" (Requested by
2541         mwenge on #webkit).
2542
2543         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2544         (WebCore::WebPage::WebPage):
2545         (WebCore::DumpRenderTree::DumpRenderTree):
2546         (WebCore::DumpRenderTree::initJSObjects):
2547         (WebCore::DumpRenderTree::createWindow):
2548         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2549         (WebCore::DumpRenderTree::eventSender):
2550         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2551         (webkit_test_plugin_new_instance):
2552         (webkit_test_plugin_set_window):
2553         (webkit_test_plugin_handle_event):
2554
2555 2011-05-13  Robert Hogan  <robert@webkit.org>
2556
2557         Reviewed by Benjamin Poulain.
2558
2559         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2560
2561         The support for this test added to the unix test plugin here
2562         may allow other platforms to pass it (nearly everyone
2563         skips it). On Qt it required a bit of trickiness with
2564         the page's EventSender object to get it working fully though,
2565         so only unskipping Qt here.
2566
2567         https://bugs.webkit.org/show_bug.cgi?id=60722
2568
2569         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2570         (WebCore::WebPage::WebPage):
2571         (WebCore::WebPage::eventSender):
2572         (WebCore::DumpRenderTree::DumpRenderTree):
2573         (WebCore::DumpRenderTree::initJSObjects):
2574         (WebCore::DumpRenderTree::createWindow):
2575         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2576         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2577         (webkit_test_plugin_new_instance):
2578         (webkit_test_plugin_set_window):
2579         (webkit_test_plugin_handle_event):
2580
2581 2011-05-13  Adam Roben  <aroben@apple.com>
2582
2583         Exclude the Leopard NRWT bot from the core builder set
2584
2585         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
2586
2587         Reviewed by Darin Adler.
2588
2589         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2590         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
2591         in the core builder set.
2592
2593         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2594         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
2595         regexps.
2596
2597 2011-05-13  Adam Roben  <aroben@apple.com>
2598
2599         Group all the NRWT bots together
2600
2601         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
2602         bots are experimental, it seems best not to clutter up the non-experimental bots with
2603         experimental ones.
2604
2605         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
2606         on build.webkit.org
2607
2608         Reviewed by Dan Bernstein.
2609
2610         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
2611         Chromium testers, which also use new-run-webkit-tests.
2612
2613 2011-05-13  Adam Roben  <aroben@apple.com>
2614
2615         Add a plugin test that dumps the plugin window's rect
2616
2617         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
2618         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
2619
2620         Reviewed by Dan Bernstein.
2621
2622         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
2623         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
2624         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
2625         harness window and log it.
2626
2627         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
2628
2629 2011-05-13  Adam Roben  <aroben@apple.com>
2630
2631         Move code required for most tests of plugin window geometry into a base class
2632
2633         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
2634         having all the trickiness in a shared base class, writing new window geometry tests will be
2635         much easier.
2636
2637         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
2638
2639         Reviewed by Anders Carlsson.
2640
2641         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2642         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
2643         WindowGeometryTest base class. Most of the code from this class was moved to the new base
2644         class.
2645         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
2646         This is called by the base class when it is safe to check the window's geometry. Note that
2647         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
2648         just vestigial code from an earlier version of this test.
2649
2650         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
2651         WindowGeometryTest class.
2652
2653         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
2654         WindowRegionIsSetToClipRect.
2655         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
2656         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
2657         Subclasses can implement that function to perform their own tests.
2658
2659         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
2660
2661 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
2662
2663         Reviewed by Csaba Osztrogonác.
2664
2665         Missing 2nd #EOF if WebProcess is killed.
2666         https://bugs.webkit.org/show_bug.cgi?id=60761
2667
2668         If the WebProcess is killed, only one #EOF is yielded
2669         by WebKitTestRunner. However, run-webkit-test wait for
2670         a second #EOF, which signals the finishing of pixel dump.
2671         Since this never happens, run-webkit-test waits forever.
2672
2673         * WebKitTestRunner/TestInvocation.cpp:
2674         (WTR::TestInvocation::dump):
2675         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2676         * WebKitTestRunner/TestInvocation.h:
2677
2678 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2679
2680         Reviewed by Csaba Osztrogonác.
2681
2682         [NRWT] chromium-linux tests shouldn't run on other platforms
2683         https://bugs.webkit.org/show_bug.cgi?id=60162
2684
2685         Remove _tests_for_other_platforms defs because r82753
2686         implemented it properly in the baseclass in webkit.py.
2687
2688         * Scripts/webkitpy/layout_tests/port/gtk.py:
2689         * Scripts/webkitpy/layout_tests/port/qt.py:
2690         * Scripts/webkitpy/layout_tests/port/win.py:
2691
2692 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
2693
2694         Reviewed by Antonio Gomes.
2695
2696         [EFL] Remove unused option of EWeblauncher
2697         https://bugs.webkit.org/show_bug.cgi?id=60747
2698
2699         Remove sudo-workaround option.
2700         This option is not used and make other option wrong.
2701
2702         * EWebLauncher/main.c:
2703
2704 2011-05-12  Lucas Forschler  <lforschler@apple.com>
2705
2706         Reviewed by Stephanie Lewis.
2707
2708         Fix config.json to address missing WK2 builder/tester config.
2709         Fix naming of machines (xserve not macpro)
2710
2711         * BuildSlaveSupport/build.webkit.org-config/config.json:
2712
2713 2011-05-12  Lucas Forschler  <lforschler@apple.com>
2714
2715         Reviewed by Stephanie Lewis.
2716
2717         Add SnowLeopard Debug builder and Test bot.
2718         apple-xserve-8 = SL Debug Tester.
2719         apple-xserve-9 = SL Debug Builder.
2720         
2721         * BuildSlaveSupport/build.webkit.org-config/config.json:
2722
2723 2011-05-12  Adam Barth  <abarth@webkit.org>
2724
2725         This patch disables sheriffbot's bug postings.  He's just been way too
2726         spammy recently due to test flakiness.
2727
2728         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2729         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2730
2731 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2732
2733         Reviewed by Anders Carlsson.
2734
2735         After relaunching an unresponsive web process, web page stops responding to mouse movement
2736         https://bugs.webkit.org/show_bug.cgi?id=60669
2737         <rdar://problem/9409934>
2738         
2739         This test follows the steps needed to reproduce this bug:
2740         1) Hang the web process
2741         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
2742         3) Kill and restart the WebProcess
2743         4) Move the mouse
2744         
2745         We are testing that we receive mouse move events after the WebProcess has restarted.
2746
2747         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
2748         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
2749         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
2750         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
2751         (TestWebKitAPI::setPageLoaderClient):
2752         (TestWebKitAPI::TEST):
2753         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
2754         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
2755         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
2756         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
2757
2758         * TestWebKitAPI/PlatformWebView.h:
2759         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2760         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
2761         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2762         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
2763
2764         Add new files.
2765         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2766         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2767         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2768         * TestWebKitAPI/win/copy-resources.cmd:
2769
2770 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
2771
2772         Reviewed by Antonio Gomes.
2773
2774         [EFL] Added initialization/shutdown for ecore_file library
2775         https://bugs.webkit.org/show_bug.cgi?id=60457
2776
2777         Added initialization and shuthown for ecore_file library and replaced
2778         realpath function to ecore_file_realpath.
2779
2780         * EWebLauncher/main.c:
2781         (quit):
2782         (findThemePath):
2783         (main):
2784
2785 2011-05-12  Young Han Lee  <joybro@company100.net>
2786
2787         Reviewed by Kenneth Rohde Christiansen.
2788
2789         [Qt] Implement layoutTestController.layerTreeAsText()
2790         https://bugs.webkit.org/show_bug.cgi?id=60367
2791
2792         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2793         (LayoutTestController::layerTreeAsText):
2794         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2795
2796 2011-05-11  Eric Seidel  <eric@webkit.org>
2797
2798         Reviewed by David Levin.
2799
2800         Teach validate-committer-lists how to validate committers bugzilla_email()
2801         https://bugs.webkit.org/show_bug.cgi?id=60651
2802
2803         It turns out we currently have 9 committers with invalid values for their
2804         bugzilla_email field (meaning we don't know what email is their bugzilla account).
2805         "Alexander Kellett" <lypanov@mac.com>
2806         "Andre Boule" <aboule@apple.com>
2807         "Cameron McCormack" <cam@webkit.org>
2808         "Chris Petersen" <cpetersen@apple.com>
2809         "Eli Fidler" <eli@staikos.net>
2810         "Matt Lilek" <webkit@mattlilek.com>
2811         "Pierre d'Herbemont" <pdherbemont@free.fr>
2812         "Scott Violet" <sky@chromium.org>
2813         "Adam Treat" <treat@kde.org>
2814
2815         Most of those haven't committed in a very long time, so it's not suprising
2816         that we haven't noticed that their bugzilla emails are bogus.
2817
2818         * Scripts/validate-committer-lists:
2819         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2820         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2821
2822 2011-05-11  Dmitry Lomov  <dslomov@google.com>
2823
2824         Reviewed by David Levin.
2825
2826         https://bugs.webkit.org/show_bug.cgi?id=59561
2827         Switch TestWebKitAPI to GTest
2828
2829         Fixes Makefiles and WinCairo build as well
2830
2831         * Makefile:
2832         * Scripts/build-api-tests:
2833         * Scripts/run-api-tests:
2834         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2835         * TestWebKitAPI/Test.h:
2836         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2837         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2838         (TestWebKitAPI::TEST):
2839         * TestWebKitAPI/TestsController.cpp:
2840         (TestWebKitAPI::TestsController::TestsController):
2841         (TestWebKitAPI::TestsController::dumpTestNames):
2842         (TestWebKitAPI::TestsController::runTestNamed):
2843         (TestWebKitAPI::TestsController::runAllTests):
2844         * TestWebKitAPI/TestsController.h:
2845         * TestWebKitAPI/mac/main.mm:
2846         (main):
2847
2848 2011-05-11  Eric Seidel  <eric@webkit.org>
2849
2850         Reviewed by Alexey Proskuryakov.
2851
2852         Add Luke Macpherson to committers.py as a Contributor
2853         https://bugs.webkit.org/show_bug.cgi?id=60639
2854
2855         * Scripts/webkitpy/common/config/committers.py:
2856
2857 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
2858
2859         Reviewed by Kenneth Rohde Christiansen.
2860
2861         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
2862         https://bugs.webkit.org/show_bug.cgi?id=60439
2863
2864         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
2865
2866         * Scripts/build-webkit:
2867
2868 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2869
2870         Reviewed by Adam Roben.
2871
2872         REGRESSION (r86161): WKPreferences API test failing on Windows
2873         https://bugs.webkit.org/show_bug.cgi?id=60658
2874
2875         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2876         (TestWebKitAPI::TEST):
2877
2878 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
2879
2880         Reviewed by Ojan Vafai.
2881
2882         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
2883         https://bugs.webkit.org/show_bug.cgi?id=60521
2884
2885         First steps towards making the results JSON all hierarchical.
2886
2887         * TestResultServer/model/jsonresults.py:
2888         * TestResultServer/model/jsonresults_unittest.py:
2889
2890 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
2891
2892         [wx] Build fix, adding new LayoutTestController method stubs.
2893
2894         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2895         (LayoutTestController::localStorageDiskUsageForOrigin):
2896         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2897
2898 2011-05-11  Jessie Berlin  <jberlin@apple.com>
2899
2900         Reviewed by Darin Adler.
2901
2902         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
2903         about the usage for both the origin overall and the database in question.
2904         https://bugs.webkit.org/show_bug.cgi?id=60573
2905
2906         * WebKitTestRunner/TestController.cpp:
2907         (WTR::exceededDatabaseQuota):
2908
2909 2011-05-10  Stephen White  <senorblanco@chromium.org>
2910
2911         Reviewed by David Levin.
2912
2913         Adding myself as a reviewer.
2914         https://bugs.webkit.org/show_bug.cgi?id=60587
2915
2916         * Scripts/webkitpy/common/config/committers.py:
2917
2918 2011-05-11  Eric Seidel  <eric@webkit.org>
2919
2920         Reviewed by Csaba Osztrogonác.
2921
2922         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
2923         https://bugs.webkit.org/show_bug.cgi?id=60614
2924
2925         AppEngine has a result limit of 1000.  We hit that when trying
2926         to find out how many patches the style-queue (and other queues)
2927         have passed in the last 30 days.  So lets display 1000+ instead
2928         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
2929
2930         I also made the status pages show "never" instead of just "ago" when we
2931         haven't seen a pass or boot message in the last 1000 messages.
2932
2933         * QueueStatusServer/handlers/queuestatus.py:
2934         * QueueStatusServer/templates/queuestatus.html:
2935
2936 2011-05-11  Adam Barth  <abarth@webkit.org>
2937
2938         Reviewed by Eric Seidel.
2939
2940         sheriffbot shouldn't spam bugs when it can't figure out who to blame
2941         https://bugs.webkit.org/show_bug.cgi?id=60613
2942
2943         This patch limits the number of bugs sheriffbot will spam to three.
2944         Ideally, we'd come up with some smarter huerstics, but hopefully this
2945         will cut down on the bugmail spam for slow bots.
2946
2947         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2948
2949 2011-05-10  Eric Seidel  <eric@webkit.org>
2950
2951         Reviewed by Adam Barth.
2952
2953         EWS bots should be robust against test-webkitpy hangs
2954         https://bugs.webkit.org/show_bug.cgi?id=60579
2955
2956         Added a killAfterTimeout subroutine, which takes a child_pid
2957         and timeout, and will setup a watchdog process to kill that child
2958         after the timeout.  killAfterTimeout will waitpid on the child.
2959
2960         * EWSTools/start-queue.sh:
2961
2962 2011-05-10  MORITA Hajime  <morrita@google.com>
2963
2964         Unreviewed, moved myself to the reviewers list.
2965
2966         * Scripts/webkitpy/common/config/committers.py:
2967
2968 2011-05-10  Anton D'Auria  <adauria@apple.com>
2969
2970         Reviewed by David Levin.
2971
2972         StorageTracker should report actual local storage usage on disk
2973         https://bugs.webkit.org/show_bug.cgi?id=60558
2974
2975         * DumpRenderTree/LayoutTestController.cpp:
2976         (localStorageDiskUsageForOriginCallback):
2977         (LayoutTestController::staticFunctions):
2978         * DumpRenderTree/LayoutTestController.h:
2979         * DumpRenderTree/chromium/LayoutTestController.cpp:
2980         (LayoutTestController::LayoutTestController):
2981         (LayoutTestController::localStorageDiskUsageForOrigin):
2982         * DumpRenderTree/chromium/LayoutTestController.h:
2983         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2984         (LayoutTestController::localStorageDiskUsageForOrigin):
2985         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2986         (LayoutTestController::localStorageDiskUsageForOrigin):
2987         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2988         (LayoutTestController::localStorageDiskUsageForOrigin):
2989         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2990         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2991         (LayoutTestController::localStorageDiskUsageForOrigin):
2992
2993 2011-05-10  Anton D'Auria  <adauria@apple.com>
2994
2995         Reviewed by Alexey Proskuryakov.
2996
2997         Add ApplicationCache API to get disk usage per origin
2998         https://bugs.webkit.org/show_bug.cgi?id=57127
2999
3000         Added test that loads two frames with ~15Kb image, checks usage,
3001         deletes app cache, verifies usage is 0.
3002
3003         * DumpRenderTree/LayoutTestController.cpp:
3004         (applicationCacheDiskUsageForOriginCallback):
3005         (LayoutTestController::staticFunctions):
3006         * DumpRenderTree/LayoutTestController.h:
3007         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
3008         (LayoutTestController::LayoutTestController):
3009         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3010         * DumpRenderTree/chromium/LayoutTestController.h:
3011         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
3012         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3013         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3014         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3015         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
3016         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3017         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3018         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
3019         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3020
3021 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3022
3023         Unreviewed, adding Rafael Antognolli as a committer.
3024
3025         * Scripts/webkitpy/common/config/committers.py:
3026
3027 2011-05-10  Chris Evans  <cevans@chromium.org>
3028
3029         Reviewed by Adam Barth.
3030
3031         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
3032         https://bugs.webkit.org/show_bug.cgi?id=58378
3033
3034         * DumpRenderTree/chromium/LayoutTestController.cpp:
3035         (LayoutTestController::LayoutTestController):
3036         (LayoutTestController::setAllowDisplayOfInsecureContent):
3037         (LayoutTestController::setAllowRunningOfInsecureContent):
3038         * DumpRenderTree/chromium/LayoutTestController.h:
3039         * DumpRenderTree/chromium/WebPreferences.cpp:
3040         (WebPreferences::reset):
3041         (WebPreferences::applyTo):
3042         * DumpRenderTree/chromium/WebPreferences.h:
3043         Add plumbing for new settings to Chromium DRT.
3044
3045 2011-05-10  Enrica Casucci  <enrica@apple.com>
3046
3047         Reviewed by Beth Dakin.
3048
3049         Added my name to the reviewers list and removed my name from
3050         to committer-only list.
3051
3052         * Scripts/webkitpy/common/config/committers.py:
3053
3054 2011-05-10  David Levin  <levin@chromium.org>
3055
3056         Reviewed by Shinichiro Hamaji.
3057
3058         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
3059         https://bugs.webkit.org/show_bug.cgi?id=60466
3060
3061         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
3062         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
3063           that property was removed.
3064         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
3065           filtering for errors.
3066         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
3067           verify that the line filtering is turned off.
3068         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
3069           and remove the unused file_path parameter.
3070         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
3071           line filtering is turned off (and fix test_no_error).
3072         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
3073           of errors based on the lines changed in the patch.
3074         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
3075           the filtering.
3076
3077 2011-05-10  Adam Roben  <aroben@apple.com>
3078
3079         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
3080
3081         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
3082         platform/win/plugins/window-geometry-initialized-before-set-window.html and
3083         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
3084         (WebKit2 Tests)
3085
3086         Reviewed by Anders Carlsson.
3087
3088         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3089         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
3090         WindowedPluginTest::testHarnessWindow function.
3091
3092         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
3093         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
3094         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
3095         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
3096         created for.
3097
3098         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
3099         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
3100         WindowedPluginTest, and initialized new members.
3101         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
3102         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
3103         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
3104         then clean up and tell the test harness we're done.
3105         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
3106         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
3107         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
3108         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
3109         window becomes visible.
3110         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
3111         if it was hidden at the start of the test.
3112         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
3113         This should cause our window to become visible and our window region to get set. When we get
3114         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
3115         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
3116         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
3117         "startTest".
3118         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
3119
3120         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
3121         (WindowedPluginTest::testHarnessWindow):
3122         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
3123         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
3124
3125 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
3126
3127         Reviewed by Kenneth Rohde Christiansen.
3128
3129         [Qt] Add new qt-4.8 platform for layout testing
3130         https://bugs.webkit.org/show_bug.cgi?id=60544
3131
3132         * Scripts/old-run-webkit-tests:
3133         * Scripts/webkitdirs.pm:
3134
3135 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3136
3137         Unreviewed, rolling out r86108.
3138         http://trac.webkit.org/changeset/86108
3139         https://bugs.webkit.org/show_bug.cgi?id=60533
3140
3141         Broke makefile based builds and Cairo (Requested by weinig on
3142         #webkit).
3143
3144         * Scripts/build-api-tests:
3145         * Scripts/run-api-tests:
3146         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3147         * TestWebKitAPI/Test.h:
3148         (TestWebKitAPI::Test::~Test):
3149         (TestWebKitAPI::Test::name):
3150         (TestWebKitAPI::Test::Register::Register):
3151         (TestWebKitAPI::Test::Register::create):
3152         (TestWebKitAPI::Test::Test):
3153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3154         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3155         (TestWebKitAPI::TEST):
3156         * TestWebKitAPI/TestsController.cpp:
3157         (TestWebKitAPI::TestsController::TestsController):
3158         (TestWebKitAPI::TestsController::dumpTestNames):
3159         (TestWebKitAPI::TestsController::runTestNamed):
3160         (TestWebKitAPI::TestsController::testFailed):
3161         (TestWebKitAPI::TestsController::registerCreateTestFunction):
3162         * TestWebKitAPI/TestsController.h:
3163         * TestWebKitAPI/mac/main.mm:
3164         (main):
3165
3166 2011-05-09  Hayato Ito  <hayato@chromium.org>
3167
3168         Reviewed by Ojan Vafai.
3169
3170         Skip reftests if pixel tests are disabled.
3171
3172         https://bugs.webkit.org/show_bug.cgi?id=59078
3173
3174         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3175         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3176         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3177         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3178
3179 2011-05-09  Chang Shu  <cshu@webkit.org>
3180
3181         Reviewed by Kenneth Rohde Christiansen.
3182
3183         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
3184         https://bugs.webkit.org/show_bug.cgi?id=60499
3185
3186         The implementation is similar to gtk.
3187
3188         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3189         (TextInputController::unmarkText):
3190         * DumpRenderTree/qt/TextInputControllerQt.h:
3191
3192 2011-05-09  James Robinson  <jamesr@chromium.org>
3193
3194         Reviewed by Eric Seidel.
3195
3196         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
3197         https://bugs.webkit.org/show_bug.cgi?id=60520
3198
3199         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3200
3201 2011-05-09  Dmitry Lomov  <dslomov@google.com>
3202
3203         Reviewed by Sam Weinig.
3204
3205         Switch TestWebKitAPI to GTest
3206         https://bugs.webkit.org/show_bug.cgi?id=59561
3207
3208         * Scripts/build-api-tests:
3209         * Scripts/run-api-tests:
3210         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3211         * TestWebKitAPI/Test.h:
3212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3213         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3214         (TestWebKitAPI::TEST):
3215         * TestWebKitAPI/TestsController.cpp:
3216         (TestWebKitAPI::TestsController::TestsController):
3217         (TestWebKitAPI::TestsController::dumpTestNames):
3218         (TestWebKitAPI::TestsController::runTestNamed):
3219         (TestWebKitAPI::TestsController::runAllTests):
3220         * TestWebKitAPI/TestsController.h:
3221         * TestWebKitAPI/mac/main.mm:
3222         (main):
3223
3224 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
3225
3226         Reviewed by Andreas Kling.
3227
3228         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
3229         https://bugs.webkit.org/show_bug.cgi?id=60487
3230
3231         When adding a new touch point, the start position of this point needs to be set.
3232
3233         * DumpRenderTree/qt/EventSenderQt.cpp:
3234         (EventSender::addTouchPoint):
3235
3236 2011-05-09  Robert Hogan  <robert@webkit.org>
3237
3238         Reviewed by Adam Roben.
3239
3240         https://bugs.webkit.org/show_bug.cgi?id=57137
3241
3242         Unskip plugins/embed-prefers-plugins-for-images.html
3243
3244         Add image/png mime-type to test netscape plugin on Unix.
3245
3246         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3247         (NP_GetMIMEDescription):
3248
3249 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
3250
3251         Reviewed by Ojan Vafai.
3252
3253         Pull jsonresults_unittest test cases out into separate test methods.
3254         https://bugs.webkit.org/show_bug.cgi?id=60418
3255
3256         * TestResultServer/model/jsonresults_unittest.py:
3257
3258 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3259
3260         Reviewed by Andreas Kling.
3261
3262         [Qt] fix fast/dom/Geolocation/window-close-crash.html
3263         https://bugs.webkit.org/show_bug.cgi?id=60458
3264
3265         Update all pages with Mock position/error/permission.
3266
3267         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3268         (LayoutTestController::setGeolocationPermission):
3269         (LayoutTestController::setMockGeolocationError):
3270         (LayoutTestController::setMockGeolocationPosition):
3271
3272 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
3273
3274         Reviewed by Tony Gentilcore.
3275
3276         Implement Page Visibility API.
3277         https://bugs.webkit.org/show_bug.cgi?id=54181
3278
3279         * DumpRenderTree/LayoutTestController.cpp:
3280         (setPageVisibilityCallback):
3281         (resetPageVisibilityCallback):
3282         (LayoutTestController::staticFunctions):
3283         * DumpRenderTree/LayoutTestController.h:
3284         (LayoutTestController::setPageVisibility):
3285         (LayoutTestController::resetPageVisibility):
3286         * DumpRenderTree/chromium/LayoutTestController.cpp:
3287         (LayoutTestController::LayoutTestController):
3288         (LayoutTestController::resetPageVisibility):
3289         (LayoutTestController::setPageVisibility):
3290         * DumpRenderTree/chromium/LayoutTestController.h:
3291
3292 2011-05-07  Adam Barth  <abarth@webkit.org>
3293
3294         Reviewed by Eric Seidel.
3295
3296         Testing EWS spins on patches with a large number of failures
3297         https://bugs.webkit.org/show_bug.cgi?id=60441
3298
3299         In cases where the tree has a small number of persistent failures but a
3300         patch has a large number of failures, we weren't believing any results.
3301         That lead to us retrying the patch forever while we waited for
3302         trustworthy results that would never come.
3303
3304         This patch loosens the semantics of unexpected_failures to return a
3305         subset (rather than the exact set) of unexpected failures.  In the case
3306         where the tree has a bounded number of failures and the patch has an
3307         unbounded number of failures, we can accurately compute such a subset
3308         and reject the patch.
3309
3310         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3311         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3312         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3313         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3314         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3315
3316 2011-05-07  Joe Mason  <jmason@rim.com>
3317
3318         Reviewed by Daniel Bates.
3319
3320         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
3321         https://bugs.webkit.org/show_bug.cgi?id=52211
3322
3323         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
3324         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
3325
3326         * DumpRenderTree/chromium/WebViewHost.cpp:
3327         (WebViewHost::willPerformClientRedirect):
3328         (WebViewHost::didStartProvisionalLoad):
3329         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3330         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3331
3332 2011-05-07  Daniel Bates  <dbates@webkit.org>
3333
3334         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
3335         <http://trac.webkit.org/changeset/86007> (bug #60438).
3336
3337         * Scripts/old-run-webkit-tests:
3338           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
3339             file local variable. 
3340
3341 2011-05-07  Pratik Solanki  <psolanki@apple.com>
3342
3343         Reviewed by Darin Adler.
3344
3345         Remove references to Tiger in scripts
3346         https://bugs.webkit.org/show_bug.cgi?id=60438
3347
3348         Remove isTiger() and all of the code that depends on it.
3349
3350         * Scripts/build-webkit:
3351         * Scripts/ensure-valid-python:
3352         * Scripts/gdb-safari:
3353         * Scripts/webkitdirs.pm:
3354
3355 2011-05-06  David Grogan  <dgrogan@chromium.org>
3356
3357         Reviewed by Eric Seidel.
3358
3359         update link to message about mac 64bit git binaries
3360         https://bugs.webkit.org/show_bug.cgi?id=60411
3361
3362         The original message implied (correctly, at-the-time) that
3363         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
3364         binaries. The new message notes that they do. This might prevent someone
3365         else from spending a few minutes confused.
3366
3367         * Scripts/webkitpy/common/checkout/scm/git.py:
3368
3369 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
3370
3371         Reviewed by Ojan Vafai.
3372
3373         new-run-webkit-tests: crashes in race with crashing DRT
3374         https://bugs.webkit.org/show_bug.cgi?id=60238
3375
3376         This fixes a race where if we wrote the URL to DRT and
3377         DRT crashed immediately, we could get a broken pipe
3378         error back during the write() and not handle it correctly,
3379         causing NRWT to also crash.
3380
3381         * Scripts/webkitpy/layout_tests/port/server_process.py:
3382         * Scripts/webkitpy/layout_tests/port/webkit.py:
3383
3384 2011-05-06  Adam Barth  <abarth@webkit.org>
3385
3386         Reviewed by Eric Seidel.
3387
3388         Add a --skip-integrationtests mode to test-webkitpy
3389         https://bugs.webkit.org/show_bug.cgi?id=60354
3390
3391         These two test suites account for 2/3 of test-webkitpy's running time
3392         because they're not actually unit tests.  They're integration tests.
3393         This patch adds the ability to skip integration tests by passing a
3394         command line argument to test-webkitpy.  The buildbots will continue to
3395         run these integration tests to make sure they don't regress.  This
3396         option is for use by developers when working on parts of the code that
3397         are well-covered by unit tests.
3398
3399         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
3400         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
3401         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
3402         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
3403         * Scripts/webkitpy/test/main.py:
3404
3405 2011-05-06  Adam Barth  <abarth@webkit.org>
3406
3407         Reviewed by Eric Seidel.
3408
3409         The results.zip generated by the Chromium EWS are too big
3410         https://bugs.webkit.org/show_bug.cgi?id=60352
3411
3412         Currently results.zip created by the Chromium EWS bot contain roughly
3413         1000 tests that we expect to fail.  These test results are not helpful
3414         to contributors.
3415
3416         There are several approaches to solving this problem:
3417
3418         1) We could be more selective about which files to include in the zip.
3419         2) We could ask new-run-webkit-tests not to generate results for
3420            expected failures.
3421         3) We could ask new-run-webkit-tests not to run tests that we expect to
3422            fail.
3423
3424         This patch takes approach (3).  Currently, we're ignoring the outcome
3425         of failing tests anyway, so there's not much point in actually running
3426         them.  As a side benefit, this will speed up the test run by about 6%.
3427         In the future, we might revisit this decision and choose another
3428         approach.
3429
3430         * Scripts/webkitpy/common/config/ports.py:
3431         * Scripts/webkitpy/common/config/ports_unittest.py:
3432
3433 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
3434
3435         Reviewed by Csaba Osztrogonác.
3436
3437         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
3438
3439         * Scripts/old-run-webkit-tests:
3440
3441 2011-05-06  Adam Barth  <abarth@webkit.org>
3442
3443         Reviewed by Ojan Vafai.
3444
3445         Add an option to NRWT to skip failing tests
3446         https://bugs.webkit.org/show_bug.cgi?id=60295
3447
3448         This option is similar to the way old-run-webkit-tests works.  We're
3449         planning to use this option on the testing EWS bots because they don't
3450         use information from failing tests yet.
3451
3452         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3453         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3454         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3455
3456 2011-05-04  Philippe Normand  <pnormand@igalia.com>
3457
3458         Reviewed by Dimitri Glazkov.
3459
3460         Implement LayoutTestController::pseudoShadowId()
3461         https://bugs.webkit.org/show_bug.cgi?id=60034
3462
3463         shadowPseudoId support in the various LayoutTestController
3464         implementations.
3465
3466         * DumpRenderTree/LayoutTestController.cpp:
3467         (shadowPseudoIdCallback):
3468         (LayoutTestController::staticFunctions):
3469         * DumpRenderTree/LayoutTestController.h:
3470         * DumpRenderTree/chromium/LayoutTestController.cpp:
3471         (LayoutTestController::LayoutTestController):
3472         (LayoutTestController::shadowPseudoId):
3473         * DumpRenderTree/chromium/LayoutTestController.h:
3474         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3475         (LayoutTestController::shadowPseudoId):
3476         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3477         (LayoutTestController::shadowPseudoId):
3478         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3479         (LayoutTestController::shadowPseudoId):
3480         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3481         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3482         (LayoutTestController::shadowPseudoId):
3483         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3484         (LayoutTestController::shadowPseudoId):
3485         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3486         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3487         (WTR::LayoutTestController::shadowPseudoId):
3488         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3489
3490 2011-05-06  Adam Barth  <abarth@webkit.org>
3491
3492         EWS can't reject patches
3493         https://bugs.webkit.org/show_bug.cgi?id=60345
3494
3495         We're supposed to use patch.id() for the attachment ID, silly.
3496
3497         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3498         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3499
3500 2011-05-05  Steve Lacey  <sjl@chromium.org>
3501
3502         Reviewed by Ojan Vafai.
3503
3504         Fix generation of results html file by passing relative path to scm
3505         methods.
3506         Generate diff images for results html file.
3507
3508         https://bugs.webkit.org/show_bug.cgi?id=60086
3509
3510         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3511         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3512
3513 2011-05-05  Andy Estes  <aestes@apple.com>
3514
3515         Reviewed by Daniel Bates.
3516
3517         update-webkit should handle Internal using a different VCS than OpenSource.
3518         https://bugs.webkit.org/show_bug.cgi?id=60310
3519
3520         isGit() and isSVN() cache their results, so Internal will always be
3521         updated using the VCS commands used for OpenSource. If Internal uses a
3522         different VCS, this will fail. Fix this by calling isGitDirectory() and
3523         isSVNDirectory() instead, which do not cache their results.
3524
3525         * Scripts/update-webkit:
3526
3527 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3528
3529         Reviewed by Ojan Vafai.
3530
3531         nrwt: revamp integration tests incl. tests for servers
3532         https://bugs.webkit.org/show_bug.cgi?id=59985
3533
3534         This change adds the ability to run "integration tests" that
3535         depend on (and affect) the local environment on your machine.
3536         These tests can be run manually by invoking python on the
3537         test file in question and passing the '-i' flag, but are
3538         not run automatically as part of test-webkitpy.
3539
3540         Integration tests are identified by being methods named as
3541         "integration_test_*" instead of "test_*", and we use a
3542         custom TestLoader instead of the default one provided by
3543         unittest.
3544
3545         This change also adds a protected "_default_to_apache" method
3546         to the port object so we can do the right thing when starting
3547         and stopping web servers with less mechanism.
3548
3549         * Scripts/webkitpy/layout_tests/port/base.py:
3550         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3551         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3552         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3553         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3554         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3555
3556 2011-05-05  Adam Roben  <aroben@apple.com>
3557
3558         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
3559
3560         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
3561         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
3562         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
3563         safeguard against this, we fill the alpha channel with constant full opacity after the
3564         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
3565         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
3566         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
3567         results need an alpha channel, too.)
3568
3569         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
3570         generated due to alpha channel weirdness
3571
3572         Reviewed by Sam Weinig.
3573
3574         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3575         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
3576         constant full opacity.
3577         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
3578         in a CGContext or cairo_surface.
3579
3580 2011-05-05  Adam Roben  <aroben@apple.com>
3581
3582         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
3583
3584         Passing true tells the test harness to dump pixels even though we're not dumping a render
3585         tree.
3586
3587         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
3588         WebKitTestRunner doesn't result in pixel results being generated
3589
3590         Reviewed by Sam Weinig.
3591
3592         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
3593         argument to dumpAsText.
3594
3595         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3596         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
3597
3598         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3599         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
3600
3601         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
3602
3603         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
3604         developers.
3605
3606 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3607
3608         Reviewed by Ojan Vafai.
3609
3610         new-run-webkit-tests: merge os, version fields in test config
3611         https://bugs.webkit.org/show_bug.cgi?id=60004
3612
3613         This change removes the 'o/s' field from the TestConfiguration
3614         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
3615         the expectations file to macros that expand to the version names
3616         for each platform.
3617
3618         This means that you can once again put any subset of the
3619         operating system versions on a single line, e.g.:
3620           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
3621
3622         This change will break any existing test_expectations.txt
3623         file that uses the "OS-VERSION" macros, which are no longer
3624         needed. It turns out they were never needed, as just VERSION
3625         by itself was sufficient. The test_expectations.txt file should
3626         be updated accordingly prior to landing this change.
3627
3628         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3629         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3630         * Scripts/webkitpy/layout_tests/port/base.py:
3631
3632 2011-05-05  Tony Chang  <tony@chromium.org>
3633
3634         Reviewed by Adam Barth.
3635
3636         [chromium] switch from Lucida to free fonts for Hindi and Thai
3637         https://bugs.webkit.org/show_bug.cgi?id=60287
3638
3639         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
3640         packages on Lucid. There are actually multiple Thai fonts in the
3641         package, so I just picked one.
3642
3643         * DumpRenderTree/chromium/TestShellGtk.cpp:
3644         (setupFontconfig):
3645
3646 2011-05-05  Tony Chang  <tony@chromium.org>
3647
3648         Reviewed by Ojan Vafai.
3649
3650         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
3651         https://bugs.webkit.org/show_bug.cgi?id=60290
3652
3653         It used to be t