Add String::format variant that takes va_args
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-25  Eric Carlson  <eric.carlson@apple.com>
2
3         Add String::format variant that takes va_args
4         https://bugs.webkit.org/show_bug.cgi?id=175988
5
6         Reviewed by Jer Noble.
7
8         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
9         (TestWebKitAPI::testWithFormatAndArguments):
10         (TestWebKitAPI::TEST):
11
12 2017-08-25  Jonathan Bedard  <jbedard@apple.com>
13
14         Follow-up Internal build fix for r221187
15         https://bugs.webkit.org/show_bug.cgi?id=175960
16         <rdar://problem/34069264>
17
18         Unreviewed build fix.
19
20         * TestWebKitAPI/ios/DataInteractionSimulator.h: Move UIItemProvider declaration
21         into #if block.
22
23 2017-08-25  Don Olmstead  <don.olmstead@sony.com>
24
25         [WinCairo] Use GitHub releases for WinCairoRequirements
26         https://bugs.webkit.org/show_bug.cgi?id=175972
27
28         Reviewed by Brent Fulgham.
29
30         * Scripts/build-webkit:
31         (cMakeArgsFromFeatures): Deleted.
32         (writeCongrats): Deleted.
33         * Scripts/download-latest-github-release.py:
34         (Status):
35         (parse_args):
36         (main):
37         * Scripts/update-webkit-wincairo-libs.py: Renamed from Tools/Scripts/update-webkit-wincairo-libs.
38
39 2017-08-25  Jonathan Bedard  <jbedard@apple.com>
40
41         Fix build breakage with Public iOS 11 SDK
42         https://bugs.webkit.org/show_bug.cgi?id=175960
43         <rdar://problem/34069264>
44
45         Reviewed by Wenson Hsieh.
46
47         * TestWebKitAPI/ios/DataInteractionSimulator.h: Add UIItemProvider declaration.
48
49 2017-08-24  Chris Dumez  <cdumez@apple.com>
50
51         [Directory Upload] Add basic support for input.webkitdirectory
52         https://bugs.webkit.org/show_bug.cgi?id=175950
53         <rdar://problem/33951915>
54
55         Reviewed by Geoffrey Garen.
56
57         * DumpRenderTree/mac/DumpRenderTree.mm:
58         (resetWebPreferencesToConsistentValues):
59         * WebKitTestRunner/TestController.cpp:
60         (WTR::TestController::resetPreferencesToConsistentValues):
61         Enable Directory Upload feature for testing, given that it is currently disabled by default.
62
63         (WTR::runOpenPanel):
64         Print additional text when directories are allowed to extend testing coverage.
65
66 2017-08-24  Alex Christensen  <achristensen@webkit.org>
67
68         Add WKUIDelegatePrivate equivalent of WKPageUIClient's handleAutoplayEvent
69         https://bugs.webkit.org/show_bug.cgi?id=175965
70         <rdar://problem/29270035>
71
72         Reviewed by Tim Horton.
73
74         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
75         (TEST):
76         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
77         (-[AutoplayPoliciesDelegate _webView:handleAutoplayEvent:withFlags:]):
78         (TEST):
79         (handleAutoplayEvent): Deleted.
80
81 2017-08-24  Alex Christensen  <achristensen@webkit.org>
82
83         didNotHandleWheelEvent test times out
84         https://bugs.webkit.org/show_bug.cgi?id=175967
85
86         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
87         Skip the test until WebCore's wheel event handling is reliable enough to test.
88
89 2017-08-24  Jonathan Bedard  <jbedard@apple.com>
90
91         Update configure-xcode-for-ios-development for iOS 11
92         https://bugs.webkit.org/show_bug.cgi?id=173937
93         <rdar://problem/33038924>
94
95         Reviewed by Daniel Bates.
96
97         Xcode 9 has removed the following headers from the iOS 11 Simulator SDK:
98                 /usr/include/crt_externs.h
99                 /usr/include/mach/mach_types.defs
100                 /usr/include/mach/machine/machine_types.defs
101                 /usr/include/mach/std_types.defs
102                 /usr/include/objc/objc-class.h
103                 /usr/include/objc/objc-runtime.h
104                 /usr/include/objc/Protocol.h
105                 /usr/include/readline/history.h
106                 /usr/include/readline/readline.h
107         To solve this problem, configure-xcode-for-ios-development copies these headers
108         from the active macOS SDK into the iOS Simulator SDK.
109
110         * Scripts/configure-xcode-for-ios-development:
111         (copyMissingHeadersFromSDKToSDKIfNeeded): Copy all missing header from one SDK
112         into another if those headers do not exist in the destination SDK.
113         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Deleted.
114
115 2017-08-24  Alex Christensen  <achristensen@webkit.org>
116
117         Add WKUIDelegatePrivate callback corresponding to PageUIClient's didNotHandleWheelEvent
118         https://bugs.webkit.org/show_bug.cgi?id=175957
119         <rdar://problem/29270035>
120
121         Reviewed by Geoffrey Garen.
122
123         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
124         (synthesizeWheelEvents):
125         (-[WheelDelegate _webView:didNotHandleWheelEvent:]):
126         (-[WheelDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
127         (TEST):
128
129 2017-08-24  Tim Horton  <timothy_horton@apple.com>
130
131         Layout size override changes during in-flight animated resize are dropped on the floor forever
132         https://bugs.webkit.org/show_bug.cgi?id=175916
133         <rdar://problem/33887295>
134
135         Reviewed by Beth Dakin.
136
137         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
138         (TEST):
139         Add a test ensuring that override layout size changes
140         during an animated resize actually take effect.
141
142 2017-08-23  Matt Lewis  <jlewis3@apple.com>
143
144         Disabled VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling.
145         https://bugs.webkit.org/show_bug.cgi?id=175909
146
147         Unreviewed test gardening.
148
149         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
150         (TestWebKitAPI::TEST):
151
152 2017-08-24  Don Olmstead  <don.olmstead@sony.com>
153
154         [CMake] Use find_package for SQLite
155         https://bugs.webkit.org/show_bug.cgi?id=175803
156
157         Reviewed by Konstantin Tokarev.
158
159         * TestWebKitAPI/PlatformWin.cmake:
160
161 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
162
163         Leaking CARenderServerBuffer in PlatformWebView::windowSnapshotImage()
164         https://bugs.webkit.org/show_bug.cgi?id=175905
165
166         Reviewed by Tim Horton.
167
168         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
169         (WTR::PlatformWebView::windowSnapshotImage): Pass CARenderServerBuffer to CGDataProviderCreateWithData
170         so that the buffer can be destroyed.
171
172 2017-08-23  Alex Christensen  <achristensen@webkit.org>
173
174         Add WKUIDelegatePrivate callbacks corresponding to WKPageUIClient's takeFocus, focus, and unfocus
175         https://bugs.webkit.org/show_bug.cgi?id=175896
176
177         Reviewed by Tim Horton.
178
179         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
180         (-[UITestDelegate _showWebView:]):
181         (TEST):
182         (tabEvent):
183         (synthesizeTab):
184         (-[FocusDelegate _webView:takeFocus:]):
185         (-[FocusDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
186         (-[UITestDelegate _webViewShow:]): Deleted.
187
188 2017-08-23  Eric Carlson  <eric.carlson@apple.com>
189
190         Platform code should be able to safely log in release builds
191         https://bugs.webkit.org/show_bug.cgi?id=175854
192         <rdar://problem/34022930>
193
194         Reviewed by Jer Noble.
195
196         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
197         (TestWebKitAPI::TEST_F):
198
199 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
200
201         Access expectations path through apple_additions
202         https://bugs.webkit.org/show_bug.cgi?id=174800
203         <rdar://problem/33498899>
204
205         Unreviewed follow-up fix for r221087.
206
207         * Scripts/webkitpy/port/ios.py:
208         (IOSPort._apple_additions_path): Use iOS mapping instead of Mac mapping.
209
210 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
211
212         Access expectations path through apple_additions
213         https://bugs.webkit.org/show_bug.cgi?id=174800
214         <rdar://problem/33498899>
215
216         Reviewed by David Kilzer.
217
218         Follow-up fix. Mapping of operating system names was done incorrectly.
219
220         * Scripts/webkitpy/port/ios.py:
221         (IOSPort._apple_additions_path): Correctly find the operating system to be replaced.
222         * Scripts/webkitpy/port/ios_device_unittest.py:
223         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Add test for operating
224         system name replacement.
225         * Scripts/webkitpy/port/ios_simulator_unittest.py:
226         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Add test for operating
227         system name replacement.
228         * Scripts/webkitpy/port/mac.py: Correctly find the operating system to be replaced.
229         (MacPort._apple_additions_path):
230         * Scripts/webkitpy/port/mac_unittest.py:
231         (MacTest.test_layout_test_searchpath_with_apple_additions): Add test for operating system
232         name replacement.
233         * Scripts/webkitpy/port/port_testcase.py:
234         (bind_mock_apple_additions.MockAppleAdditions.ios_os_name): Change the passed name so that
235         operating system name replacement can be tested.
236         (bind_mock_apple_additions.MockAppleAdditions.mac_os_name): Ditto.
237
238 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
239
240         Access expectations path through apple_additions
241         https://bugs.webkit.org/show_bug.cgi?id=174800
242         <rdar://problem/33498899>
243
244         Reviewed by Alexey Proskuryakov.
245
246         When external test expectations are imported through additional-platform-directory, they will
247         over-write any WebKit expectations. Access some expectations from apple_additions to correct
248         these precedence issues.
249
250         * Scripts/webkitpy/port/ios.py:
251         (IOSPort._apple_additions_path): Convert test expectation directory to a path
252         coming from apple_additions.
253         (IOSPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
254         path for layout test expectations.
255         * Scripts/webkitpy/port/ios_device_unittest.py:
256         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
257         * Scripts/webkitpy/port/ios_simulator_unittest.py:
258         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
259         * Scripts/webkitpy/port/mac.py:
260         (MacPort._apple_additions_path): Convert test expectation directory to a path
261         coming from apple_additions.
262         (MacPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
263         path for layout test expectations.
264         * Scripts/webkitpy/port/mac_unittest.py:
265         (MacTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
266         * Scripts/webkitpy/port/port_testcase.py:
267         (bind_mock_apple_additions): Added to create mock apple_additions for a block.
268         (bind_mock_apple_additions.MockAppleAdditions): Contains apple_addition stubs for testing.
269         * Scripts/webkitpy/port/win.py:
270         (WinPort.default_baseline_search_path): Include apple_additions test expectation for Windows.
271
272 2017-08-22  Zan Dobersek  <zdobersek@igalia.com>
273
274         Unreviewed. The WPE port should build TestWebKitAPI with the same
275         compiler flags as the GTK+ port, disabling a few flags that are
276         sprouting a lot of warning output.
277
278         * TestWebKitAPI/PlatformWPE.cmake:
279
280 2017-08-20  Wenson Hsieh  <wenson_hsieh@apple.com>
281
282         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
283         https://bugs.webkit.org/show_bug.cgi?id=175116
284         <rdar://problem/28279301>
285
286         Reviewed by Darin Adler and Ryosuke Niwa.
287
288         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
289         EditorStateTests run on both iOS and Mac.
290
291         * TestWebKitAPI/EditingTestHarness.h: Added.
292         * TestWebKitAPI/EditingTestHarness.mm: Added.
293
294         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
295         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
296         the state of the latest observed EditorState.
297
298         (-[EditingTestHarness initWithWebView:]):
299         (-[EditingTestHarness dealloc]):
300         (-[EditingTestHarness webView]):
301         (-[EditingTestHarness latestEditorState]):
302         (-[EditingTestHarness editorStateHistory]):
303         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
304         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
305         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
306         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
307         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
308         (-[EditingTestHarness toggleBold]):
309         (-[EditingTestHarness toggleItalic]):
310         (-[EditingTestHarness toggleUnderline]):
311         (-[EditingTestHarness setForegroundColor:]):
312         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
313         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
314         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
315         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
316         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
317         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
318         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
319
320         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
321         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
322         keys and values.
323
324         (-[EditingTestHarness latestEditorStateContains:]):
325         (-[EditingTestHarness _webView:editorStateDidChange:]):
326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
327         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
328         (TestWebKitAPI::setUpEditorStateTestHarness):
329         (TestWebKitAPI::TEST):
330         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
331
332 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
333
334         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
335         https://bugs.webkit.org/show_bug.cgi?id=175370
336         <rdar://problem/33799806>
337
338         Reviewed by Ryosuke Niwa.
339
340         Tweaks API tests that involve editing to wait for a presentation update before checking against UI process-side
341         information sent via EditorState updates. This allows any EditorState update scheduled by the test to propagate
342         to the UI process.
343
344         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
345         (-[CandidateTestWebView typeString:inputMessage:]):
346         (+[CandidateTestWebView setUpWithFrame:testPage:]):
347         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
348         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
349         (TestWebKitAPI::AcceptsFirstMouse::runTest):
350         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
351         * TestWebKitAPI/cocoa/TestWKWebView.h:
352         * TestWebKitAPI/cocoa/TestWKWebView.mm:
353         (-[TestWKWebView waitForNextPresentationUpdate]):
354
355         Add a new helper method to spin until the next presentation update.
356
357         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
358         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
359         (TestWebKitAPI::WebKitAgnosticTest::waitForNextPresentationUpdate):
360
361 2017-08-22  Alex Christensen  <achristensen@webkit.org>
362
363         Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
364         https://bugs.webkit.org/show_bug.cgi?id=175797
365         <rdar://problem/29270035>
366
367         Reviewed by Geoffrey Garen.
368
369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
370         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.
371         (-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
372         (-[UITestDelegate _showPage:]):
373         (-[UITestDelegate webView:startURLSchemeTask:]):
374         (-[UITestDelegate webView:stopURLSchemeTask:]):
375         (TEST):
376
377 2017-08-22  Devin Rousso  <webkit@devinrousso.com>
378
379         Unreviewed, change my IRC nick.
380
381         * Scripts/webkitpy/common/config/contributors.json:
382
383 2017-08-22  Matt Lewis  <jlewis3@apple.com>
384
385         Unreviewed, rolling out r221026.
386
387         This caused a consistent API failure on iOS Simulator.
388
389         Reverted changeset:
390
391         "Add UIDelegatePrivate SPI corresponding to
392         WKPageUIClient.showPage"
393         https://bugs.webkit.org/show_bug.cgi?id=175797
394         http://trac.webkit.org/changeset/221026
395
396 2017-08-22  Alex Christensen  <achristensen@webkit.org>
397
398         Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
399         https://bugs.webkit.org/show_bug.cgi?id=175797
400         <rdar://problem/29270035>
401
402         Reviewed by Geoffrey Garen.
403
404         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
405         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.
406         (-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
407         (-[UITestDelegate _showPage:]):
408         (-[UITestDelegate webView:startURLSchemeTask:]):
409         (-[UITestDelegate webView:stopURLSchemeTask:]):
410         (TEST):
411
412 2017-08-22  Jonathan Bedard  <jbedard@apple.com>
413
414         Fix leak-checking for iOS Simulators
415         https://bugs.webkit.org/show_bug.cgi?id=175735
416
417         Reviewed by David Kilzer.
418
419         Follow-up fix to r220942. _proc may be undefined.
420
421         * Scripts/webkitpy/port/server_process.py:
422         (ServerProcess._wait_for_stop): Handle case where _proc is undefined.
423
424 2017-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
425
426         [GTK][WPE] install-dependencies should install the required gstreamer packages needed for production builds.
427         https://bugs.webkit.org/show_bug.cgi?id=175822
428
429         Reviewed by Xabier Rodriguez-Calvar.
430
431         * gtk/install-dependencies: Add the bad plugins to the list.
432         * wpe/install-dependencies: Add all the gst related packages (copied from GTK listing).
433
434 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
435
436         DataInteractionTests.ExternalSourceAttributedStringToContentEditable hits a debug assertion
437         https://bugs.webkit.org/show_bug.cgi?id=175787
438         <rdar://problem/33996612>
439
440         Reviewed by Wenson Hsieh.
441
442         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
443         (TestWebKitAPI::TEST):
444
445 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
446
447         Typo in "webkit-patch land"
448         https://bugs.webkit.org/show_bug.cgi?id=175788
449
450         Reviewed by Tim Horton.
451
452         * Scripts/webkitpy/tool/steps/commit.py:
453         (Commit._commit_warning):
454
455 2017-08-20  Sam Weinig  <sam@webkit.org>
456
457         StringView could use a function to strip leading/trailing characters without allocation
458         https://bugs.webkit.org/show_bug.cgi?id=175757
459
460         Reviewed by Darin Adler.
461
462         * TestWebKitAPI/Tests/WTF/StringView.cpp:
463         Add tests for StringView::stripLeadingAndTrailingMatchedCharacters().
464
465 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
466
467         [PAL] Move spi/mac directory into PAL
468         https://bugs.webkit.org/show_bug.cgi?id=175649
469
470         Reviewed by Myles C. Maxfield.
471
472         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
473
474 2017-08-21  Per Arne Vollan  <pvollan@apple.com>
475
476         [Win] DRT should only allow any https certificate for localhost.
477         https://bugs.webkit.org/show_bug.cgi?id=175147
478
479         Reviewed by Brent Fulgham.
480
481         Add check to make sure only localhost requests allow any https certificate.
482
483         * DumpRenderTree/win/DumpRenderTree.cpp:
484         (runTest):
485
486 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
487
488         Add WTFLogChannel level to allow runtime log filtering
489         https://bugs.webkit.org/show_bug.cgi?id=175731
490         <rdar://problem/33967234>
491
492         Unreviewed build fix.
493
494         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
495         (TestWebKitAPI::LoggingTest::output): Disable testing output by default because it 
496         fails on some of the bots.
497
498 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
499
500         Add WTFLogChannel level to allow runtime log filtering
501         https://bugs.webkit.org/show_bug.cgi?id=175731
502         <rdar://problem/33967234>
503
504         Reviewed by Jer Noble.
505
506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
507         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
508         (TestWebKitAPI::LoggingTest::output):
509         (TestWebKitAPI::TEST_F):
510
511 2017-08-19  Wenson Hsieh  <wenson_hsieh@apple.com>
512
513         [iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
514         https://bugs.webkit.org/show_bug.cgi?id=175509
515         <rdar://problem/33728169>
516
517         Reviewed by Ryosuke Niwa.
518
519         Removes ExternalSourceAttributedStringToContentEditable and adds
520         ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
521         text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
522         original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
523         debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
524         that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
525         other style attribute, such as color, carries over from the NSAttributedString to the DOM.
526
527         Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.
528
529         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
530         (TestWebKitAPI::TEST):
531
532 2017-08-18  Ryan Haddad  <ryanhaddad@apple.com>
533
534         Unreviewed, rolling out r220938.
535
536         The API tests added with this change are failing.
537
538         Reverted changeset:
539
540         "Add WTFLogChannel level to allow runtime log filtering"
541         https://bugs.webkit.org/show_bug.cgi?id=175731
542         http://trac.webkit.org/changeset/220938
543
544 2017-08-18  Devin Rousso  <webkit@devinrousso.com>
545
546         Unreviewed, change my email.
547
548         * Scripts/webkitpy/common/config/contributors.json:
549
550 2017-08-18  Jonathan Bedard  <jbedard@apple.com>
551
552         Fix leak-checking for iOS Simulators
553         https://bugs.webkit.org/show_bug.cgi?id=175735
554
555         Reviewed by Darin Adler.
556
557         If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
558         Simulator (or device) because the process will have already been killed by the time we
559         check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.
560
561         * Scripts/webkitpy/port/server_process.py:
562         (ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
563         (ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
564         and SimulatorProcess.
565         * Scripts/webkitpy/port/simulator_process.py:
566         (SimulatorProcess.stop): Before closing the process, check for leaks.
567
568 2017-08-18  Eric Carlson  <eric.carlson@apple.com>
569
570         Add WTFLogChannel level to allow runtime log filtering
571         https://bugs.webkit.org/show_bug.cgi?id=175731
572         <rdar://problem/33967234>
573
574         Reviewed by Jer Noble.
575
576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
577         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
578         (TestWebKitAPI::LoggingTest::output):
579         (TestWebKitAPI::TEST_F):
580
581 2017-08-18  Alexey Proskuryakov  <ap@apple.com>
582
583         Add Dean Johnson to contributors.json for Bugzilla autocomplete.
584
585         * Scripts/webkitpy/common/config/contributors.json:
586
587 2017-08-18  Ross Kirsling  <ross.kirsling@sony.com>
588
589         [Tools] Add script to download a GitHub release
590         https://bugs.webkit.org/show_bug.cgi?id=175279
591
592         Reviewed by Brent Fulgham.
593
594         * Scripts/download-latest-github-release.py: Added.
595
596 2017-08-18  Commit Queue  <commit-queue@webkit.org>
597
598         Unreviewed, rolling out r220854.
599         https://bugs.webkit.org/show_bug.cgi?id=175716
600
601         I'm not sure we really need this (Requested by KaL on
602         #webkit).
603
604         Reverted changeset:
605
606         "[GTK][WPE] Add NTLM authentication enabled API"
607         https://bugs.webkit.org/show_bug.cgi?id=122952
608         http://trac.webkit.org/changeset/220854
609
610 2017-08-17  Michael Catanzaro  <mcatanzaro@igalia.com>
611
612         [GTK] Make TestContextMenu work on Fedora
613         https://bugs.webkit.org/show_bug.cgi?id=175708
614
615         Reviewed by Carlos Garcia Campos.
616
617         TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
618         and my student last summer who was trying to work on a context menu API. It's trying to load
619         an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
620         entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
621         don't care to investigate. Let's switch it to WebM so I can move on.
622
623         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
624         (prepareContextMenuTestView):
625         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
626         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
627
628 2017-08-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
629
630         check-webkit-style shouldn't check spacing in #elif preprocessor lines
631         https://bugs.webkit.org/show_bug.cgi?id=175652
632
633         Reviewed by Alex Christensen.
634
635         * Scripts/webkitpy/style/checkers/cpp.py:
636         (check_spacing):
637         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
638         (CppStyleTest.test_spacing_for_binary_ops):
639
640 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
641
642         Fix the build on other platforms after r220865
643         https://bugs.webkit.org/show_bug.cgi?id=175683
644
645         Reviewed by Tim Horton.
646
647         Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
648         availability is determined by SDK version rather than deployment version.
649
650         * TestWebKitAPI/ios/UIKitSPI.h:
651
652 2017-08-17  Andreas Kling  <akling@apple.com>
653
654         Disable CSS regions at compile time
655         https://bugs.webkit.org/show_bug.cgi?id=175630
656
657         Reviewed by Antti Koivisto.
658
659         * Scripts/webkitperl/FeatureList.pm:
660         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
661
662 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
663
664         Unreviewed, try to fix the internal iOS 10 build after r220865.
665
666         * TestWebKitAPI/ios/UIKitSPI.h:
667
668         On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
669         extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
670         this compiler guard.
671
672 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
673
674         [iOS] Respect type fidelities when copying image elements to the pasteboard
675         https://bugs.webkit.org/show_bug.cgi?id=175638
676         <rdar://problem/26556043>
677
678         Reviewed by Ryosuke Niwa.
679
680         Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
681         contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
682         used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.
683
684         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
685         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
686         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
687         (TestWebKitAPI::TEST):
688         (TestWebKitAPI::presentActionSheetAndChooseAction):
689         (-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
690         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
691         (checkEstimatedSize):
692         (checkSuggestedNameAndEstimatedSize):
693
694         Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.
695
696         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
697         (TestWebKitAPI::TEST):
698         * TestWebKitAPI/ios/DataInteractionSimulator.h:
699         * TestWebKitAPI/ios/UIKitSPI.h: Added.
700
701 2017-08-17  Jonathan Bedard  <jbedard@apple.com>
702
703         Recursively create resource load statistics folder for testing
704         https://bugs.webkit.org/show_bug.cgi?id=175676
705
706         Reviewed by Brady Eidson.
707
708         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
709         (WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.
710
711 2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
712
713         [GTK][WPE] Add NTLM authentication enabled API
714         https://bugs.webkit.org/show_bug.cgi?id=122952
715
716         Reviewed by Michael Catanzaro.
717
718         Add a test case to check we can enable/disable NTLM.
719
720         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
721         (testWebViewAuthenticationNTLM):
722         (beforeAll):
723
724 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
725
726         [PAL] Move spi/ios and spi/win directories into PAL
727         https://bugs.webkit.org/show_bug.cgi?id=175171
728
729         Reviewed by Antti Koivisto.
730
731         * DumpRenderTree/mac/EventSendingController.mm:
732
733 2017-08-16  Andy Estes  <aestes@apple.com>
734
735         [Payment Request] Add an ENABLE flag and an experimental feature preference
736         https://bugs.webkit.org/show_bug.cgi?id=175622
737
738         Reviewed by Tim Horton.
739
740         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
741         * WebKitTestRunner/TestController.cpp:
742         (WTR::TestController::resetPreferencesToConsistentValues):
743
744 2017-08-15  Aakash Jain  <aakash_jain@apple.com>
745
746         undefined URL in PopoverTracker for failed step
747         https://bugs.webkit.org/show_bug.cgi?id=175593
748         <rdar://problem/33898769>
749
750         Reviewed by Daniel Bates.
751
752         This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
753         does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.
754
755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
756         (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
757         (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
758         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
759         (BuildbotTestResults): Accept URL in constructor.
760
761 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
762
763         Remove Proximity Events and related code
764         https://bugs.webkit.org/show_bug.cgi?id=175545
765
766         Reviewed by Daniel Bates.
767
768         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
769         and other related code.
770
771         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
772
773 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
774
775         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
776         https://bugs.webkit.org/show_bug.cgi?id=175504
777
778         Reviewed by Sam Weinig.
779
780         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
781
782 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
783
784         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
785         https://bugs.webkit.org/show_bug.cgi?id=175557
786
787         Reviewed by Jon Lee.
788         
789         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
790
791         * DumpRenderTree/TestRunner.cpp:
792         (TestRunner::staticFunctions):
793         (setViewModeMediaFeatureCallback): Deleted.
794         * DumpRenderTree/TestRunner.h:
795         * DumpRenderTree/mac/TestRunnerMac.mm:
796         (TestRunner::setViewModeMediaFeature): Deleted.
797         * DumpRenderTree/win/TestRunnerWin.cpp:
798         (TestRunner::setViewModeMediaFeature): Deleted.
799         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
800
801 2017-08-14  Andy Estes  <aestes@apple.com>
802
803         REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
804         https://bugs.webkit.org/show_bug.cgi?id=175548
805         <rdar://problem/33866206>
806
807         Reviewed by Brady Eidson.
808
809         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
810         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.
811         (TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().
812
813 2017-08-14  Youenn Fablet  <youenn@apple.com>
814
815         WPT server should be able to do logging even if its output folder is not created at launch time
816         https://bugs.webkit.org/show_bug.cgi?id=175543
817
818         Reviewed by Alexey Proskuryakov.
819
820         Removing no longer used stdout/stderr member variables.
821         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
822
823         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
824         (WebPlatformTestServer.__init__):
825         (WebPlatformTestServer._prepare_config):
826         (WebPlatformTestServer._spawn_process):
827         (WebPlatformTestServer._stop_running_server):
828
829 2017-08-14  Daniel Bates  <dabates@apple.com>
830
831         webkit-patch: Passing --no-review should submit patch to EWS by default
832         https://bugs.webkit.org/show_bug.cgi?id=148899
833
834         Reviewed by David Kilzer.
835
836         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
837         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
838         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
839
840         Frequently I want to post a draft of a patch without review to have the EWS bots process
841         it to catch build and test breakage before I clean it up and post it for formal review.
842         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
843         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
844         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
845
846         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
847         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
848         parse the attachment id from the response page after adding an attachment to the bug.
849         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
850         HTTP response after uploading the patch.
851         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
852         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
853         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
854         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
855         * Scripts/webkitpy/tool/commands/upload.py:
856         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
857         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
858         this command.
859         (PostCommits.execute): Submit the patch to EWS, if applicable.
860         * Scripts/webkitpy/tool/commands/upload_unittest.py:
861         (test_upload): Set options.ews to False as the upload command expects this option
862         to be specified.
863         (test_upload_with_no_review_and_ews): Added.
864         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
865         * Scripts/webkitpy/tool/steps/options.py:
866         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
867         * Scripts/webkitpy/tool/steps/postdiff.py:
868         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
869         this command.
870         (PostDiff.run): Submit the patch to EWS, if applicable.
871         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
872         (SubmitToEWS):
873         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
874         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
875
876 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
877
878         Disable two flaky VideoControlsManager API tests.
879
880         Unreviewed test gardening.
881
882         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
883         (TestWebKitAPI::TEST):
884
885 2017-08-14  Tim Horton  <timothy_horton@apple.com>
886
887         Only create directory and sandbox extension handle for storage directories if they are set
888         https://bugs.webkit.org/show_bug.cgi?id=175522
889
890         Reviewed by Brady Eidson.
891
892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
893         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
894         (TEST):
895         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
896         doesn't log anything to stderr.
897
898 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
899
900         sub-categorize Sandbox violation logs
901         https://bugs.webkit.org/show_bug.cgi?id=175536
902         <rdar://problem/33834416>
903
904         Reviewed by David Kilzer.
905
906         * Scripts/webkitpy/common/system/crashlogs.py:
907         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
908         a Sandbox violation.
909         (CrashLogs._find_all_logs_darwin): Update comment.
910         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
911         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
912         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
913         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
914         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
915         * Scripts/webkitpy/port/darwin.py:
916         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
917
918 2017-08-14  Daniel Bates  <dabates@apple.com>
919
920         Add Automator service to copy permalink to Clipboard
921         https://bugs.webkit.org/show_bug.cgi?id=170978
922
923         Reviewed by Joseph Pecoraro.
924
925         It is helpful to reference using a hyperlink a particular line of code when having
926         a discussion on IRC or in a bug. You can get such a link by navigating to the file
927         in the Trac Browse Source viewer and selecting the line your are interested in.
928         I found myself doing this often enough that I wrote an Automator service to do it
929         for me.
930
931         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
932
933         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
934         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
935         * CopyPermalink/README: Added.
936
937 2017-08-14  Chris Dumez  <cdumez@apple.com>
938
939         Address flakiness related to download tests
940         https://bugs.webkit.org/show_bug.cgi?id=175338
941         <rdar://problem/33865119>
942
943         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
944         between tests.
945
946         * WebKitTestRunner/TestController.cpp:
947         (WTR::TestController::resetStateToConsistentValues):
948
949 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
950
951         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
952         https://bugs.webkit.org/show_bug.cgi?id=175474
953         <rdar://problem/33844628>
954
955         Reviewed by Wenson Hsieh.
956
957         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
958
959         * DumpRenderTree/mac/DumpRenderTree.mm:
960         (resetWebPreferencesToConsistentValues):
961         * WebKitTestRunner/TestController.cpp:
962         (WTR::TestController::resetPreferencesToConsistentValues):
963
964 2017-08-12  Chris Dumez  <cdumez@apple.com>
965
966         Address flakiness related to download tests
967         https://bugs.webkit.org/show_bug.cgi?id=175338
968
969         Reviewed by Ryosuke Niwa.
970
971         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
972           is actually queried when a download completes. Previously, this would be
973           identical to a call to testRunner.waitUntilDone() because any download
974           completion would call testRunner.notifyDone().
975         - Disable logging of download callbacks by default and add a
976           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
977           enable such logging.
978
979         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
980         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
981         (WTR::InjectedBundle::didReceiveMessageToPage):
982         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
983         (WTR::TestRunner::setShouldLogDownloadCallbacks):
984         * WebKitTestRunner/InjectedBundle/TestRunner.h:
985         * WebKitTestRunner/TestController.cpp:
986         (WTR::TestController::downloadDidStart):
987         (WTR::TestController::decideDestinationWithSuggestedFilename):
988         (WTR::TestController::downloadDidFinish):
989         (WTR::TestController::downloadDidFail):
990         (WTR::TestController::downloadDidCancel):
991         * WebKitTestRunner/TestController.h:
992         (WTR::TestController::setShouldLogDownloadCallbacks):
993         * WebKitTestRunner/TestInvocation.cpp:
994         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
995
996 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
997
998         Create mock ITP data in testing to prevent grandfathering
999         https://bugs.webkit.org/show_bug.cgi?id=174720
1000
1001         Unreviewed follow-up fix for r220604.
1002
1003         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1004         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
1005
1006 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
1007
1008         Create mock ITP data in testing to prevent grandfathering
1009         https://bugs.webkit.org/show_bug.cgi?id=174720
1010         <rdar://problem/33457779>
1011
1012         Reviewed by Brent Fulgham.
1013
1014         We don't need to be triggering grandfathering when each test runner starts. On Mac,
1015         this may launch plugins which can cause layout tests to fail later if the test
1016         runner does not shut-down before the plugins unload.
1017
1018         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
1019         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1020         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
1021         prevent grandfathering from being triggered.
1022         * WebKitTestRunner/ios/TestControllerIOS.mm:
1023         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
1024         * WebKitTestRunner/mac/TestControllerMac.mm:
1025         (WTR::TestController::platformInitialize): Ditto.
1026
1027 2017-08-11  Sam Weinig  <sam@webkit.org>
1028
1029         WTF::Function does not allow for reference / non-default constructible return types
1030         https://bugs.webkit.org/show_bug.cgi?id=175244
1031         <rdar://problem/33801582>
1032
1033         Reviewed by Chris Dumez.
1034
1035         * TestWebKitAPI/Tests/WTF/Function.cpp:
1036         (TestWebKitAPI::TEST):
1037
1038 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1039
1040         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
1041         https://bugs.webkit.org/show_bug.cgi?id=175378
1042
1043         Reviewed by Sergio Villar Senin.
1044
1045         Add two test cases to check proxy authentication.
1046
1047         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1048         (Tunnel::Tunnel):
1049         (Tunnel::~Tunnel):
1050         (Tunnel::connect):
1051         (Tunnel::connected):
1052         (serverCallback):
1053         (ProxyAuthenticationTest::ProxyAuthenticationTest):
1054         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
1055         (ProxyAuthenticationTest::proxyServerPortAsString):
1056         (testWebViewAuthenticationProxy):
1057         (testWebViewAuthenticationProxyHTTPS):
1058         (beforeAll):
1059
1060 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1061
1062         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
1063         https://bugs.webkit.org/show_bug.cgi?id=175428
1064
1065         Both ports share the GStreamer code as multimedia backend and till
1066         not so long they were using different versions. Now they do use
1067         the same versions and it does not make any sense anymore (and
1068         neither had sense before) to have differences in the modulesets.
1069
1070         In this patch I created a GStreamer moduleset and referenced it
1071         from both GTK+'s and WPE's. GStreamer patches were also moved there.
1072
1073         Reviewed by Žan Doberšek.
1074
1075         * gstreamer/jhbuild.modules: Added.
1076         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
1077         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
1078         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
1079         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
1080         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
1081         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
1082         * gtk/jhbuild.modules:
1083         * wpe/jhbuild.modules:
1084         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
1085         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
1086         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1087         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1088         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
1089
1090 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
1091
1092         Unreviewed, adding Ross Kirsling to contributors.json
1093
1094         * Scripts/webkitpy/common/config/contributors.json:
1095
1096 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
1097
1098         Unreviewed, attempt to fix build failure with VC2017
1099
1100         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1101         (TEST):
1102
1103 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
1104
1105         Unreviewed, suppress warnings on GCC
1106
1107         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1108         (TestWebKitAPI::CheckedArithmeticTester::run):
1109
1110 2017-08-10  Dan Bernstein  <mitz@apple.com>
1111
1112         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
1113         https://bugs.webkit.org/show_bug.cgi?id=173223
1114
1115         Reviewed by Tim Horton.
1116
1117         The rebuilds were happening due to a difference in the compiler options that the IDE and
1118         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
1119         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
1120         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
1121         Advanced when a Custom Absolute path is selected.
1122
1123         * Scripts/webkitdirs.pm:
1124         (determineBaseProductDir):
1125
1126 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
1127
1128         Run more WTF tests
1129         https://bugs.webkit.org/show_bug.cgi?id=174970
1130
1131         Reviewed by Michael Catanzaro.
1132
1133         Some of WTF tests are not executed in non Apple ports while they are generic ones.
1134         This patch adds these tests to non-Apple port TestWebKitAPI.
1135         Currently, we do not add Signals.cpp since it depends on signal functionality.
1136
1137         * TestWebKitAPI/CMakeLists.txt:
1138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1139         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1140         (isHigherPriority):
1141         (TEST):
1142         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
1143         (TEST):
1144         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1145         (TEST):
1146
1147 2017-08-10  obinna obike  <oobike@apple.com>
1148
1149         Remove obsolete link from webkit-queues status page
1150         https://bugs.webkit.org/show_bug.cgi?id=175337
1151
1152         Reviewed by Aakash Jain.
1153
1154         * QueueStatusServer/templates/recentstatus.html:
1155         Removed the link to the ews-watcher server.
1156
1157 2017-08-10  Brian Burg  <bburg@apple.com>
1158
1159         WKPreferences should conform to NSCopying
1160         https://bugs.webkit.org/show_bug.cgi?id=175303
1161         <rdar://problem/33764939>
1162
1163         Reviewed by Dan Bernstein.
1164
1165         Add unit test to make sure a WKPreference and its copy are
1166         not aliased to each other or affect each other's properties.
1167
1168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1169         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
1170         (TEST):
1171
1172 2017-08-10  Tim Horton  <timothy_horton@apple.com>
1173
1174         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
1175         https://bugs.webkit.org/show_bug.cgi?id=175436
1176         <rdar://problem/33667497>
1177
1178         Reviewed by Simon Fraser.
1179
1180         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1181         (TestWebKitAPI::TEST_F):
1182
1183 2017-08-10  Lucas Forschler  <lforschler@apple.com>
1184
1185         Fix duplicated code in r220534.
1186
1187         Unreviewed cleanup.
1188
1189         * Scripts/bisect-builds:
1190
1191 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
1192
1193         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
1194         https://bugs.webkit.org/show_bug.cgi?id=175344
1195         <rdar://problem/28507240>
1196
1197         Reviewed by Alexey Proskuryakov.
1198
1199         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
1200         Finally enable the existing tests for iOS.
1201
1202         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
1203         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1204         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1205         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
1206
1207 2017-08-10  Lucas Forschler  <lforschler@apple.com>
1208
1209         Write a tool to bisect WebKit builds
1210         https://bugs.webkit.org/show_bug.cgi?id=174596
1211
1212         Reviewed by Dean Johnson and Kocsen Chung.
1213
1214         * Scripts/bisect-builds: Added.
1215         (bisect_builds): main bisection algorithm
1216         (download_archive):download an archive from S3 using existing tools
1217         (extract_archive):extract an archive using existing tools
1218         (find_le):Find rightmost value less than or equal to x
1219         (find_ge):Find leftmost item greater than or equal to x
1220         (get_api_url):generate url for the rest api/database
1221         (get_indices_from_revisions):convert revisions to list indexes for bisection
1222         (get_sorted_revisions):retrieve sorted revision list
1223         (get_s3_location_for_revision):calculate the S3 archive storage location
1224         (parse_args):parse command line arguments
1225         (pick_next_build):compute the next build to bisect
1226         (prompt_did_reproduce):prompt user for direction for bisection
1227         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
1228         (test_archive):Platform specific logic to test downloaded archive
1229         (minified_platforms):return a list of minified platforms in the database
1230         (unminified_platforms):return a list of full platforms in the database
1231         (is_supported_platform):check if platform is supported
1232         (validate_options):validate command line options
1233         (main):
1234
1235 2017-08-10  Lucas Forschler  <lforschler@apple.com>
1236
1237         Remove bisect-builds script.
1238         https://bugs.webkit.org/show_bug.cgi?id=175433
1239         
1240         Reviewed by Aakash Jain.
1241
1242         * Scripts/bisect-builds: Removed.
1243
1244 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1245
1246         Remove ENABLE_GAMEPAD_DEPRECATED
1247         https://bugs.webkit.org/show_bug.cgi?id=175361
1248
1249         Reviewed by Carlos Garcia Campos.
1250
1251         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1252
1253 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1254
1255         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
1256         https://bugs.webkit.org/show_bug.cgi?id=175426
1257
1258         Reviewed by Carlos Garcia Campos.
1259
1260         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
1261
1262 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
1263
1264         Add Ms2ger as contributor.
1265         https://bugs.webkit.org/show_bug.cgi?id=175325
1266
1267         Reviewed by Carlos Alberto Lopez Perez.
1268
1269         * Scripts/webkitpy/common/config/contributors.json:
1270
1271 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
1272
1273         Fix run-benchmark after r220483.
1274         https://bugs.webkit.org/show_bug.cgi?id=175415
1275         <rdar://problem/33803003>
1276
1277         Reviewed by Ryosuke Niwa.
1278
1279         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
1280
1281         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
1282         (WebServerBenchmarkRunner._run_one_test):
1283
1284 2017-08-09  Chris Dumez  <cdumez@apple.com>
1285
1286         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
1287         https://bugs.webkit.org/show_bug.cgi?id=175401
1288
1289         Reviewed by Brady Eidson.
1290
1291         * DumpRenderTree/mac/DumpRenderTree.mm:
1292         (enableExperimentalFeatures):
1293
1294 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1295
1296         [PAL] Move spi/cocoa and spi/cg directories into PAL
1297         https://bugs.webkit.org/show_bug.cgi?id=175175
1298
1299         Reviewed by Myles C. Maxfield.
1300
1301         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1302         * DumpRenderTree/mac/DumpRenderTree.mm:
1303         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
1304         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1305
1306         * Scripts/webkitpy/style/checker.py:
1307         * Scripts/webkitpy/style/checker_unittest.py:
1308         (GlobalVariablesTest.test_path_rules_specifier):
1309
1310         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
1311
1312         * Scripts/webkitpy/style/checkers/cpp.py:
1313         (check_braces):
1314         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1315         (WebKitStyleTest.test_braces.CF_OPTIONS):
1316         (WebKitStyleTest.test_braces):
1317
1318         Prevent CF_OPTIONS() from being handled as funtion definition.
1319
1320 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
1321
1322         [WTF] Move TextStream into WTF
1323         https://bugs.webkit.org/show_bug.cgi?id=175211
1324
1325         Reviewed by Myles C. Maxfield.
1326
1327         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1328
1329 2017-08-09  Andy Estes  <aestes@apple.com>
1330
1331         Part 3 of: Rename DatabaseProcess to StorageProcess
1332         https://bugs.webkit.org/show_bug.cgi?id=175034
1333
1334         Reviewed by Brady Eidson.
1335
1336         * WebKitTestRunner/TestController.cpp:
1337         (WTR::TestController::databaseProcessName): Updated to return
1338         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
1339
1340 2017-08-09  Commit Queue  <commit-queue@webkit.org>
1341
1342         Unreviewed, rolling out r220466, r220477, and r220487.
1343         https://bugs.webkit.org/show_bug.cgi?id=175411
1344
1345         This change broke existing API tests and follow up fixes did
1346         not resolve all the issues. (Requested by ryanhaddad on
1347         #webkit).
1348
1349         Reverted changesets:
1350
1351         https://bugs.webkit.org/show_bug.cgi?id=175244
1352         http://trac.webkit.org/changeset/220466
1353
1354         "WTF::Function does not allow for reference / non-default
1355         constructible return types"
1356         https://bugs.webkit.org/show_bug.cgi?id=175244
1357         http://trac.webkit.org/changeset/220477
1358
1359         https://bugs.webkit.org/show_bug.cgi?id=175244
1360         http://trac.webkit.org/changeset/220487
1361
1362 2017-08-09  Sam Weinig  <sam@webkit.org>
1363
1364         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
1365
1366         Remove one addition of null Function test.
1367
1368 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
1369
1370         Allow nested timeouts in webkitpy
1371         https://bugs.webkit.org/show_bug.cgi?id=175390
1372         <rdar://problem/33803003>
1373
1374         Reviewed by David Kilzer.
1375
1376         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
1377         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
1378         the executive to detect and recover from any issues connecting with devices.
1379
1380         * Scripts/webkitpy/benchmark_runner/utils.py:
1381         (TimeoutError): Deleted.
1382         (timeout): Deleted.
1383         * Scripts/webkitpy/common/timeout_context.py: Added.
1384         (Timeout): A timeout context designed to be nested.
1385         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
1386         (Timeout.TimeoutData.__init__):
1387         (Timeout.default_handler): Timeout handler used if none is specified.
1388         (Timeout.current): Access data about the most urgent timeout.
1389         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
1390         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
1391         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
1392         urgent timeout data.
1393         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
1394         most urgent timeout data, if such data exists.
1395         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
1396         (TimeoutContextTests):
1397         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
1398         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
1399         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
1400         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
1401         over a less urgent outer timeout.
1402         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
1403         over a less urgent inner timeout.
1404         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
1405         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
1406         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
1407         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
1408         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
1409         * Scripts/webkitpy/port/simulator_process.py:
1410         (SimulatorProcess._start): Use Timeout class.
1411         * Scripts/webkitpy/xcode/simulated_device.py:
1412         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
1413         (SimulatedDevice.launch_app): Ditto.
1414         (SimulatedDevice.launch_app._install_timeout): Deleted.
1415         * Scripts/webkitpy/xcode/simulator.py:
1416         (Simulator.wait_until_device_is_booted):Use Timeout class.
1417         (Simulator.wait_until_device_is_in_state): Ditto.
1418
1419 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1420
1421         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
1422         https://bugs.webkit.org/show_bug.cgi?id=175392
1423         <rdar://problem/33783207>
1424
1425         Reviewed by Tim Horton and Megan Gardner.
1426
1427         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
1428
1429         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1430
1431 2017-08-09  Sam Weinig  <sam@webkit.org>
1432
1433         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
1434
1435         * TestWebKitAPI/Tests/WTF/Function.cpp:
1436         Remove tests of null Functions, as they are no longer supported.
1437
1438 2017-08-09  Daniel Bates  <dabates@apple.com>
1439
1440         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
1441         https://bugs.webkit.org/show_bug.cgi?id=175247
1442         <rdar://problem/33679804>
1443
1444         Reviewed by Brady Eidson.
1445
1446         Add tests for redirects.
1447
1448         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1449         (TEST):
1450         * TestWebKitAPI/cocoa/TestProtocol.mm:
1451         (createRedirectURL):
1452         (-[TestProtocol startLoading]):
1453
1454 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1455
1456         Unreviewed, rolling out r220393.
1457
1458         This patch regresses the performance of WebPage::editorState.
1459
1460         Reverted changeset:
1461
1462         "[iOS WK2] WKWebView schedules nonstop layout after pressing
1463         cmb+b,i,u inside a contenteditable div"
1464         https://bugs.webkit.org/show_bug.cgi?id=175116
1465         http://trac.webkit.org/changeset/220393
1466
1467 2017-08-08  obinna obike  <oobike@apple.com>
1468
1469         Created Individual EWS Pages
1470         https://bugs.webkit.org/show_bug.cgi?id=174477
1471
1472         Reviewed by Aakash Jain.
1473
1474         Created individual pages for each EWS. Changed the link within each status bubble
1475         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
1476
1477         * QueueStatusServer/handlers/patch.py:
1478         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
1479         * QueueStatusServer/handlers/statusbubble.py:
1480         (StatusBubble._build_bubble): Updated url for specific EWS.
1481         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
1482         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
1483         all ews queues.
1484         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
1485         takes you directly to the individual ews page.
1486
1487 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
1488
1489         Separate jsc stress test script writer from run-jsc-stress-tests
1490         https://bugs.webkit.org/show_bug.cgi?id=175216
1491
1492         Reviewed by Mark Lam.
1493
1494         * Scripts/run-jsc-stress-tests:
1495         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
1496
1497 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1498
1499         Unreviewed, fix Ubuntu LTS build
1500         https://bugs.webkit.org/show_bug.cgi?id=174490
1501
1502         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1503
1504 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1505
1506         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
1507         https://bugs.webkit.org/show_bug.cgi?id=175302
1508         <rdar://problem/33762116>
1509
1510         Reviewed by Tim Horton.
1511
1512         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
1513         See WebKit ChangeLog for more details.
1514
1515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1516         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
1517         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
1518         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
1519         (-[SlowTextInputContext handleEvent:completionHandler:]):
1520         (-[SlowInputWebView inputContext]):
1521         (-[SlowInputWebView _web_superInputContext]):
1522         (TEST):
1523
1524 2017-08-08  John Wilander  <wilander@apple.com>
1525
1526         Resource Load Statistics: Clear web processes' state on history removal
1527         https://bugs.webkit.org/show_bug.cgi?id=175271
1528         <rdar://problem/33756560>
1529
1530         Reviewed by Chris Dumez.
1531
1532         Test infrastructure for asynchronous tests of website data
1533         removal for _WKWebsiteDataTypeResourceLoadStatistics.
1534
1535         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1536         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1537         (WTR::InjectedBundle::didReceiveMessageToPage):
1538         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1539         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1540         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
1541         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1542         * WebKitTestRunner/TestController.cpp:
1543         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1544         * WebKitTestRunner/TestController.h:
1545         * WebKitTestRunner/TestInvocation.cpp:
1546         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1547         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
1548         * WebKitTestRunner/TestInvocation.h:
1549         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1550         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1551
1552 2017-08-08  Alicia Boya García  <aboya@igalia.com>
1553
1554         Add Alicia Boya García as contributor
1555         https://bugs.webkit.org/show_bug.cgi?id=175326
1556
1557         Reviewed by Michael Catanzaro.
1558
1559         * Scripts/webkitpy/common/config/contributors.json:
1560
1561 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1562
1563         [CMake] Properly test if compiler supports compiler flags
1564         https://bugs.webkit.org/show_bug.cgi?id=174490
1565
1566         Reviewed by Konstantin Tokarev.
1567
1568         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1569         * MiniBrowser/gtk/CMakeLists.txt:
1570         * TestRunnerShared/Bindings/JSWrapper.cpp:
1571         (WTR::JSWrapper::initialize):
1572         * TestWebKitAPI/CMakeLists.txt:
1573         * TestWebKitAPI/PlatformGTK.cmake:
1574         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1575         (TestWebKitAPI::CheckedArithmeticTester::run):
1576         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1577         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1578         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1579         (formControlsAssociatedCallback):
1580         * TestWebKitAPI/glib/CMakeLists.txt:
1581         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1582         (Test::getResourcesDir):
1583         * WebKitTestRunner/CMakeLists.txt:
1584         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1585         (WTR::menuItemClickCallback):
1586         (WTR::staticConvertMenuItemToType):
1587         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1588         (WTR::TestRunner::setUseDashboardCompatibilityMode):
1589         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1590         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1591         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1592         (WTR::AccessibilityUIElement::helpText const):
1593         (WTR::AccessibilityUIElement::attributedStringForRange):
1594         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1595         (WTR::EventSenderProxy::updateTouchPoint):
1596         (WTR::EventSenderProxy::releaseTouchPoint):
1597
1598 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1599
1600         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
1601         https://bugs.webkit.org/show_bug.cgi?id=175116
1602         <rdar://problem/28279301>
1603
1604         Reviewed by Darin Adler and Ryosuke Niwa.
1605
1606         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
1607         EditorStateTests run on both iOS and Mac.
1608
1609         * TestWebKitAPI/EditingTestHarness.h: Added.
1610         * TestWebKitAPI/EditingTestHarness.mm: Added.
1611
1612         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
1613         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
1614         the state of the latest observed EditorState.
1615
1616         (-[EditingTestHarness initWithWebView:]):
1617         (-[EditingTestHarness dealloc]):
1618         (-[EditingTestHarness webView]):
1619         (-[EditingTestHarness latestEditorState]):
1620         (-[EditingTestHarness editorStateHistory]):
1621         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
1622         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
1623         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
1624         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
1625         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
1626         (-[EditingTestHarness toggleBold]):
1627         (-[EditingTestHarness toggleItalic]):
1628         (-[EditingTestHarness toggleUnderline]):
1629         (-[EditingTestHarness setForegroundColor:]):
1630         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
1631         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
1632         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
1633         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
1634         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
1635         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
1636         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
1637
1638         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
1639         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
1640         keys and values.
1641
1642         (-[EditingTestHarness latestEditorStateContains:]):
1643         (-[EditingTestHarness _webView:editorStateDidChange:]):
1644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1645         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
1646         (TestWebKitAPI::setUpEditorStateTestHarness):
1647         (TestWebKitAPI::TEST):
1648         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
1649
1650 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
1651
1652         Prevent domain from being set to a TLD
1653         https://bugs.webkit.org/show_bug.cgi?id=175226
1654         <rdar://problem/11079948>
1655
1656         Reviewed by Chris Dumez.
1657
1658         Extend the public suffix tests to include cases used by the
1659         Public Domain 'Public Suffix List'.
1660
1661         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
1662         (TestWebKitAPI::TEST):
1663
1664 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
1665
1666         [XCode] webkit-patch should run sort-Xcode-project-file
1667         https://bugs.webkit.org/show_bug.cgi?id=174036
1668         <rdar://problem/33732709>
1669
1670         Reviewed by Simon Fraser.
1671
1672         * Scripts/webkitpy/common/config/ports.py:
1673         * Scripts/webkitpy/tool/commands/download.py:
1674         * Scripts/webkitpy/tool/commands/download_unittest.py:
1675         * Scripts/webkitpy/tool/commands/upload.py:
1676         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1677         * Scripts/webkitpy/tool/steps/__init__.py:
1678         * Scripts/webkitpy/tool/steps/options.py:
1679         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1680
1681 2017-08-07  Devin Rousso  <drousso@apple.com>
1682
1683         Web Inspector: Preview Canvas path when viewing a recording
1684         https://bugs.webkit.org/show_bug.cgi?id=174967
1685
1686         Reviewed by Brian Burg.
1687
1688         * DumpRenderTree/TestOptions.h:
1689         * DumpRenderTree/TestOptions.mm:
1690         (TestOptions::TestOptions):
1691         * DumpRenderTree/mac/DumpRenderTree.mm:
1692         (setWebPreferencesForTestOptions):
1693         * WebKitTestRunner/TestController.cpp:
1694         (WTR::TestController::resetPreferencesToConsistentValues):
1695         (WTR::updateTestOptionsFromTestHeader):
1696         * WebKitTestRunner/TestOptions.h:
1697         (WTR::TestOptions::hasSameInitializationOptions const):
1698         Add plumbing for new InspectorAdditions runtime flag.
1699
1700 2017-08-07  obinna obike  <oobike@apple.com>
1701
1702         Sorted EWS Queues on Patch page
1703         https://bugs.webkit.org/show_bug.cgi?id=173667
1704
1705         Reviewed by Aakash Jain.
1706
1707         * QueueStatusServer/handlers/patch.py:
1708         (Patch.get): Sorted queue_status.
1709         * QueueStatusServer/templates/patch.html:
1710         Changed queue_status.items to queue_status because it's a list.
1711
1712 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1713
1714         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
1715         https://bugs.webkit.org/show_bug.cgi?id=175286
1716
1717         Reviewed by Myles C. Maxfield.
1718
1719         * Scripts/webkitpy/style/checkers/cpp.py:
1720         (check_braces):
1721         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1722         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
1723         (WebKitStyleTest.test_braces):
1724         (WebKitStyleTest.test_braces.NS_OPTIONS):
1725
1726 2017-08-07  Brian Burg  <bburg@apple.com>
1727
1728         Remove CANVAS_PATH compilation guard
1729         https://bugs.webkit.org/show_bug.cgi?id=175207
1730
1731         Reviewed by Sam Weinig.
1732
1733         * Scripts/webkitperl/FeatureList.pm:
1734         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1735
1736 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
1737
1738         [Win] Use Visual Studio 2017 if installed.
1739         https://bugs.webkit.org/show_bug.cgi?id=175188
1740
1741         Reviewed by Sam Weinig.
1742
1743         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
1744
1745         * Scripts/webkitdirs.pm:
1746         (visualStudioInstallDir):
1747         (msBuildInstallDir):
1748
1749 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1750
1751         [GTK][WPE] Add API to provide browser information required by automation
1752         https://bugs.webkit.org/show_bug.cgi?id=175130
1753
1754         Reviewed by Michael Catanzaro.
1755
1756         * MiniBrowser/gtk/main.c:
1757         (automationStartedCallback): Set browser information when a new automation session is started.
1758         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1759         (testAutomationSessionApplicationInfo):
1760         (beforeAll):
1761
1762 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
1763
1764         Unreviewed, rolling out r220295.
1765
1766         This change introduced 4 errors in webkitpy tests.
1767
1768         Reverted changeset:
1769
1770         "[XCode] webkit-patch should run sort-Xcode-project-file"
1771         https://bugs.webkit.org/show_bug.cgi?id=174036
1772         http://trac.webkit.org/changeset/220295
1773
1774 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1775
1776         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
1777
1778         Unreviewed test gardening.
1779
1780         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1781         (TestWebKitAPI::TEST):
1782
1783 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
1784
1785         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
1786         https://bugs.webkit.org/show_bug.cgi?id=175083
1787
1788         Reviewed by Oliver Hunt.
1789         
1790         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
1791         to wait for VM destructions to finish before running the next test. This makes it easier to 
1792         understand leaks results from workers tests, and leads to fewer reported leaks.
1793
1794         * DumpRenderTree/mac/DumpRenderTree.mm:
1795         (runTest):
1796
1797 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1798
1799         check-webkit-style: fix path-specific rules for WebKit2 rename
1800         https://bugs.webkit.org/show_bug.cgi?id=175182
1801
1802         Reviewed by David Kilzer.
1803
1804         * Scripts/webkitpy/style/checker.py:
1805
1806 2017-08-04  Youenn Fablet  <youenn@apple.com>
1807
1808         [Cache API] Add Cache and CacheStorage IDL definitions
1809         https://bugs.webkit.org/show_bug.cgi?id=175201
1810
1811         Reviewed by Brady Eidson.
1812
1813         * DumpRenderTree/mac/DumpRenderTree.mm:
1814         (enableExperimentalFeatures):
1815         (resetWebPreferencesToConsistentValues):
1816         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1817         (WTR::InjectedBundle::beginTesting):
1818         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1819         (WTR::TestRunner::setCacheAPIEnabled):
1820         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1821
1822 2017-08-04  John Wilander  <wilander@apple.com>
1823
1824         Resource Load Statistics: Report user interaction immediately, but only when needed
1825         https://bugs.webkit.org/show_bug.cgi?id=175090
1826         <rdar://problem/33685546>
1827
1828         Reviewed by Chris Dumez.
1829
1830         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1831         (WTR::InjectedBundle::beginTesting):
1832             Now calls WebCore::ResourceLoadObserver::clearState().
1833
1834 2017-08-04  Tim Horton  <timothy_horton@apple.com>
1835
1836         Add an API test for r220286
1837         https://bugs.webkit.org/show_bug.cgi?id=175206
1838
1839         Reviewed by Simon Fraser.
1840
1841         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1842         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
1843         (createAnimatedResizeWebView):
1844         (TEST):
1845         Add a test to ensure that we don't call
1846         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
1847         animated resize.
1848
1849 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
1850
1851         [XCode] webkit-patch should run sort-Xcode-project-file
1852         https://bugs.webkit.org/show_bug.cgi?id=174036
1853
1854         Reviewed by Simon Fraser.
1855
1856         * Scripts/webkitpy/common/config/ports.py:
1857         * Scripts/webkitpy/tool/commands/download.py:
1858         * Scripts/webkitpy/tool/commands/upload.py:
1859         * Scripts/webkitpy/tool/steps/__init__.py:
1860         * Scripts/webkitpy/tool/steps/options.py:
1861         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1862
1863 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1864
1865         REGRESSION(r219857): run-benchmark --allplans broken
1866         https://bugs.webkit.org/show_bug.cgi?id=175186
1867
1868         Reviewed by Saam Barati.
1869
1870         r219857 forgot to update also the calls to BenchmarkRunner() that
1871         is done when the script is run with --allplans.
1872
1873         To fix this (and avoid future issues like this), let's factorize
1874         the calls to the benchhmark runner in a run_benchmark_plan()
1875         function.
1876
1877         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1878         (run_benchmark_plan):
1879         (start):
1880
1881 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
1882
1883         Dashboard bubbles sometimes show failure count instead of crash count
1884         https://bugs.webkit.org/show_bug.cgi?id=175157
1885         <rdar://problem/33709009>
1886
1887         Reviewed by Alexey Proskuryakov.
1888
1889         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1890         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
1891
1892 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
1893
1894         Add tests for NeverDestroyed
1895         https://bugs.webkit.org/show_bug.cgi?id=175146
1896
1897         Reviewed by Darin Adler.
1898
1899         * CMakeLists.txt:
1900         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1901         New files and sort.
1902
1903         * TestWebKitAPI/Tests/WTF/Logger.h:
1904         * TestWebKitAPI/Tests/WTF/Logger.cpp:
1905         (TestWebKitAPI::log):
1906         (TestWebKitAPI::takeLogStr):
1907         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1908         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
1909         (TestWebKitAPI::log): Deleted.
1910         (TestWebKitAPI::takeLogStr): Deleted.
1911         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
1912
1913         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
1914         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
1915         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
1916         (TestWebKitAPI::LifecycleLogger::operator=):
1917         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1918         (TestWebKitAPI::LifecycleLogger::setName):
1919         (TestWebKitAPI::TEST):
1920         Add a class that logs construction / assignment / modifications.
1921
1922         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1923         (TestWebKitAPI::TEST):
1924         (TestWebKitAPI::list):
1925         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1926
1927 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1928
1929         minification logic is not implemented for ios builds
1930         <rdar://problem/33726561>
1931
1932         Reviewed by Dean Johnson
1933
1934         * BuildSlaveSupport/built-product-archive:
1935         (minifyDirectory): refactor minifySource -> minifyDirectory
1936         (archiveBuiltProduct): add ios minification logic
1937         (minifySource): Deleted.
1938
1939 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1940
1941         Unreviewed, rolling out r220271.
1942
1943         Rolling out due to Layout Test failing on iOS Simulator.
1944
1945         Reverted changeset:
1946
1947         "Remove STREAMS_API compilation guard"
1948         https://bugs.webkit.org/show_bug.cgi?id=175165
1949         http://trac.webkit.org/changeset/220271
1950
1951 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1952
1953         Unreviewed, rolling out r220268.
1954
1955         This change caused assertion failures on macOS and iOS Debug
1956         WK2.
1957
1958         Reverted changeset:
1959
1960         "Resource Load Statistics: Report user interaction
1961         immediately, but only when needed"
1962         https://bugs.webkit.org/show_bug.cgi?id=175090
1963         http://trac.webkit.org/changeset/220268
1964
1965 2017-08-04  Youenn Fablet  <youenn@apple.com>
1966
1967         Remove STREAMS_API compilation guard
1968         https://bugs.webkit.org/show_bug.cgi?id=175165
1969
1970         Reviewed by Darin Adler.
1971
1972         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1973
1974 2017-08-04  John Wilander  <wilander@apple.com>
1975
1976         Resource Load Statistics: Report user interaction immediately, but only when needed
1977         https://bugs.webkit.org/show_bug.cgi?id=175090
1978         <rdar://problem/33685546>
1979
1980         Reviewed by Chris Dumez.
1981
1982         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1983         (WTR::InjectedBundle::beginTesting):
1984             Now calls WebCore::ResourceLoadObserver::clearState().
1985
1986 2017-08-03  Brian Burg  <bburg@apple.com>
1987
1988         Remove ENABLE(WEB_SOCKET) guards
1989         https://bugs.webkit.org/show_bug.cgi?id=167044
1990
1991         Reviewed by Joseph Pecoraro.
1992
1993         * Scripts/webkitperl/FeatureList.pm:
1994         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1995
1996 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1997
1998         REGRESSION(r219850): run-benchmark script broken on Linux
1999         https://bugs.webkit.org/show_bug.cgi?id=175126
2000
2001         Reviewed by Stephanie Lewis.
2002
2003         The run-benchmark script dynamically generates the list of supported
2004         browsers and platforms (currently Linux and OSX) by loading all
2005         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
2006         and getting the browser_name and platform variables from the
2007         classes defined there.
2008
2009         This means that this classes should not raise an exception when
2010         loaded on other platforms or otherwise they will broke the whole
2011         script. Its fine if they raise an exception when executing any of
2012         the methods they implement, but not when just loading/importing
2013         the class.
2014
2015         Move the argument variable definitions that call on the platform
2016         specific OSXBrowserDriver._screen_size() function from beeing
2017         variables that are evaluated when loading the file, to be functions
2018         that are only evaluated when the actual functionality needs to be
2019         executed.
2020
2021         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2022         (OSXChromeDriver.launch_url):
2023         (OSXChromeCanaryDriver.launch_url):
2024         (create_args):
2025         (create_chrome_options):
2026         (create_window_size_arg):
2027         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2028         (OSXFirefoxDriver.launch_url):
2029         (OSXFirefoxNightlyDriver.launch_url):
2030         (OSXFirefoxNightlyDriver.launch_driver):
2031         (create_args):
2032
2033 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
2034
2035         [PAL] Move spi/cf directory into PAL
2036         https://bugs.webkit.org/show_bug.cgi?id=175057
2037
2038         Reviewed by Antti Koivisto.
2039
2040         * Scripts/webkitpy/style/checker.py:
2041         * Scripts/webkitpy/style/checker_unittest.py:
2042         (GlobalVariablesTest.test_path_rules_specifier):
2043
2044         Ignore "readability/naming/underscores" style errors for sources
2045         under the WebCore/PAL/pal/spi directory.
2046
2047         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
2048
2049 2017-08-03  Youenn Fablet  <youenn@apple.com>
2050
2051         Remove FETCH_API compilation guard
2052         https://bugs.webkit.org/show_bug.cgi?id=175154
2053
2054         Reviewed by Chris Dumez.
2055
2056         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2057
2058 2017-08-03  Lucas Forschler  <lforschler@apple.com>
2059
2060         Enable archive minification on iOS builds
2061         https://bugs.webkit.org/show_bug.cgi?id=174718
2062         
2063         Reviewed by Aakash Jain.
2064
2065         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2066         (BuildFactory.__init__):
2067
2068 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2069
2070         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
2071         https://bugs.webkit.org/show_bug.cgi?id=175140
2072
2073         Reviewed by Alexey Proskuryakov.
2074
2075         We are having lately issues with JSC tests causing problems on
2076         the GTK+ and WPE bots due to the high amount of memory some tests
2077         need to run.
2078
2079         The best thing we can do now is to workaround this by disabling
2080         all the tests marked as memoryLimited on the GTK and WPE bots.
2081         We may revise this on the future.
2082
2083         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2084         (RunJavaScriptCoreTests.start):
2085
2086 2017-08-03  Brady Eidson  <beidson@apple.com>
2087
2088         Add SW IDLs and stub out basic functionality.
2089         https://bugs.webkit.org/show_bug.cgi?id=175115
2090
2091         Reviewed by Chris Dumez.
2092
2093         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2094
2095         * Scripts/webkitpy/bindings/main.py:
2096
2097 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
2098
2099         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
2100         https://bugs.webkit.org/show_bug.cgi?id=159510
2101
2102         Reviewed by Daniel Bates.
2103
2104         Allow any https certificate when running tests.
2105
2106         * DumpRenderTree/win/DumpRenderTree.cpp:
2107         (runTest):
2108
2109 2017-08-02  Youenn Fablet  <youenn@apple.com>
2110
2111         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
2112         https://bugs.webkit.org/show_bug.cgi?id=175089
2113
2114         Reviewed by Chris Dumez.
2115
2116         * DumpRenderTree/TestOptions.mm:
2117         (TestOptions::TestOptions): Using absolutePath if available.
2118         * DumpRenderTree/mac/DumpRenderTree.mm:
2119         (computeTestURL): Removing http/tests/ specific URL computation.
2120         * Scripts/webkitpy/port/driver.py:
2121         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
2122
2123 2017-08-02  Lucas Forschler  <lforschler@apple.com>
2124
2125         download-built-product should allow for a proxy option
2126         https://bugs.webkit.org/show_bug.cgi?id=174875
2127
2128         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
2129
2130         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2131         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
2132         
2133
2134 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
2135
2136         check-webkit-style: deleting lines in a file runs the linter on the whole file
2137         https://bugs.webkit.org/show_bug.cgi?id=175078
2138
2139         Reviewed by David Kilzer.
2140
2141         Deleting lines in a file should not cause linter errors to be blamed on the patch.
2142         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
2143
2144         * Scripts/webkitpy/style/checkers/test_expectations.py:
2145         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
2146         * Scripts/webkitpy/style/main_unittest.py:
2147         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
2148         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
2149         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
2150
2151 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
2152
2153         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
2154         https://bugs.webkit.org/show_bug.cgi?id=175075
2155
2156         Reviewed by David Kilzer.
2157
2158         We have no way of handling text files with illegal unicode characters. Allow the callers of
2159         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
2160         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
2161
2162         * Scripts/webkitpy/common/system/filesystem.py:
2163         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
2164         (FileSystem.write_text_file): Ditto.
2165         * Scripts/webkitpy/common/system/filesystem_mock.py:
2166         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
2167         (MockFileSystem.write_text_file): Ditto.
2168         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2169         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
2170         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
2171
2172 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
2173
2174         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
2175         https://bugs.webkit.org/show_bug.cgi?id=175072
2176
2177         Reviewed by Alexey Proskuryakov.
2178
2179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2180         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
2181
2182 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2183
2184         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
2185         https://bugs.webkit.org/show_bug.cgi?id=175019
2186
2187         Reviewed by Darin Adler.
2188
2189         * TestWebKitAPI/CMakeLists.txt:
2190
2191 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
2192
2193         Enabling uploading archives to S3
2194         https://bugs.webkit.org/show_bug.cgi?id=174198
2195
2196         Unreviewed unit test fix after r219235.
2197
2198         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2199
2200 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
2201
2202         Fix JSCOnly ARM buildbots after r220047
2203         https://bugs.webkit.org/show_bug.cgi?id=174993
2204
2205         Unreviewed fix after r220087.
2206
2207         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2208         (BuildAndRemoteJSCTestsFactory.__init__):
2209
2210 2017-08-01  Chris Dumez  <cdumez@apple.com>
2211
2212         Add initial support for navigator.sendBeacon
2213         https://bugs.webkit.org/show_bug.cgi?id=175007
2214         <rdar://problem/33547728>
2215
2216         Reviewed by Sam Weinig.
2217
2218         Enable the Beacon API at runtime in the context of layout tests since the
2219         feature is currently disabled by default.
2220
2221         * DumpRenderTree/mac/DumpRenderTree.mm:
2222         (enableExperimentalFeatures):
2223         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2224         (WTR::InjectedBundle::beginTesting):
2225         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2226         (WTR::TestRunner::setModernMediaControlsEnabled):
2227         (WTR::TestRunner::setBeaconAPIEnabled):
2228         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2229
2230 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
2231
2232         Update Bot Watcher's Dashboard for Buildbot 0.9
2233         https://bugs.webkit.org/show_bug.cgi?id=174777
2234
2235         Reviewed by Daniel Bates.
2236
2237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2238         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
2239         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
2240         in a dictionary.
2241         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
2242         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
2243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2244         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
2245         (parseRevisionProperty): Ditto.
2246         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
2247         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
2248         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
2249         have changed in Buildbot 0.9.
2250         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
2251         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
2252         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
2253         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
2254         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
2255         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
2256         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
2257         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
2258         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
2259         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
2260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2261         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
2262         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
2263         (BuildbotQueue.prototype.get overviewURL): Ditto.
2264         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
2265         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
2266         Buildbot 0.8 or 0.9.
2267         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
2268         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
2269         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
2270         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
2271         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
2272         Therefore we are fetching information for fixed number of build. 
2273         Also iterating the loop incrementally since the build data is already reverse sorted.
2274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2275         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
2276         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
2277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2278         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
2279
2280 2017-08-01  Devin Rousso  <drousso@apple.com>
2281
2282         Web Inspector: simplify WebInspector with WI
2283         https://bugs.webkit.org/show_bug.cgi?id=175058
2284
2285         Reviewed by Joseph Pecoraro.
2286
2287         * Scripts/check-inspector-strings:
2288         (extract_ui_strings):
2289         * Scripts/extract-localizable-js-strings:
2290
2291 2017-08-01  Youenn Fablet  <youenn@apple.com>
2292
2293         Layout tests with 'https' suffix should be run over HTTPS
2294         https://bugs.webkit.org/show_bug.cgi?id=174992
2295
2296         Reviewed by Chris Dumez.
2297
2298         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
2299         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
2300         Covered by corresponding unit tests.
2301
2302         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
2303         (run_server):
2304         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2305         (base_http_url):
2306         (base_https_url):
2307         (base_url): Deleted.
2308         * Scripts/webkitpy/port/base.py:
2309         (Port.to.web_platform_test_server_base_http_url):
2310         (Port.to):
2311         (Port.to.web_platform_test_server_base_https_url):
2312         (Port.to.web_platform_test_server_base_url): Deleted.
2313         * Scripts/webkitpy/port/driver.py:
2314         (Driver.__init__):
2315         (Driver.wpt_test_path_to_uri):
2316         (Driver):
2317         (Driver.http_test_path_to_uri):
2318         (Driver.test_to_uri):
2319         (Driver.uri_to_test):
2320         * Scripts/webkitpy/port/driver_unittest.py:
2321         (DriverTest.test_test_to_uri):
2322         (DriverTest.test_uri_to_test):
2323
2324 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
2325
2326         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
2327         https://bugs.webkit.org/show_bug.cgi?id=173998
2328
2329         Reviewed by Darin Adler.
2330
2331         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
2332         detect mistakes in backward compatibility in the future when we change it.
2333
2334         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
2335         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
2336         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
2337         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
2338         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
2339         internal key data slot.
2340
2341         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2342         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
2343         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
2344         (getNextMessage):
2345         (TEST):
2346         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
2347         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
2348         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
2349         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
2350         These are the pre-baked databases.
2351         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
2352         This is the actual test that do all the reads and comparisons.
2353         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
2354         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
2355         IndexedDB new stuffs. Then it can be used to bake the database again.
2356
2357 2017-08-01  Brady Eidson  <beidson@apple.com>
2358
2359         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
2360         https://bugs.webkit.org/show_bug.cgi?id=175030
2361
2362         Reviewed by Andy Estes.
2363
2364         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2365         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
2366
2367 2017-08-01  Brady Eidson  <beidson@apple.com>
2368
2369         Part 2 of: Rename DatabaseProcess to StorageProcess.
2370         https://bugs.webkit.org/show_bug.cgi?id=174880
2371
2372         Reviewed by Andy Estes.
2373
2374         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2375         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2376         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2377         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2378         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2379         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2380         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2381         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2382
2383 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
2384
2385         Fix JSCOnly ARM buildbots after r220047
2386         https://bugs.webkit.org/show_bug.cgi?id=174993
2387
2388         Reviewed by Saam Barati.
2389
2390         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2391         (BuildAndRemoteJSCTestsFactory.__init__):
2392
2393 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2394
2395         [WTF] Introduce Private Symbols
2396         https://bugs.webkit.org/show_bug.cgi?id=174935
2397
2398         Reviewed by Darin Adler.
2399
2400         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2401         (TestWebKitAPI::TEST):
2402
2403 2017-07-30  Darin Adler  <darin@apple.com>
2404
2405         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
2406         https://bugs.webkit.org/show_bug.cgi?id=130653
2407
2408         Reviewed by Antti Koivisto.
2409
2410         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2411         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
2412         when calling frameDidChangeLocation.
2413         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
2414         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
2415         thus causing mysterious failures of a couple of tests. There are two remaining issues:
2416         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
2417         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
2418         same logic flaw that causes "top loading frame" to get set to one of the subframes in
2419         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
2420         loading, subframe starts loading. It would be good to clean that up some day, but for now
2421         this patch makes the two work identically rather than changing both.
2422         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
2423
2424 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2425
2426         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
2427         https://bugs.webkit.org/show_bug.cgi?id=174963
2428
2429         Reviewed by Darin Adler.
2430
2431         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
2432         RetainPtr<>. This patch changes them to all use auto.
2433
2434         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2435         (TestWebKitAPI::TEST):
2436
2437 2017-07-30  Brady Eidson  <beidson@apple.com>
2438
2439         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
2440         https://bugs.webkit.org/show_bug.cgi?id=174958
2441
2442         Reviewed by Darin Adler.
2443
2444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2445         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
2446         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
2447         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
2448         (runUntilTasksInFlight):
2449         (TEST):
2450
2451 2017-07-28  Commit Queue  <commit-queue@webkit.org>
2452
2453         Unreviewed, rolling out r219990.
2454         https://bugs.webkit.org/show_bug.cgi?id=174961
2455
2456         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
2457         estes on #webkit).
2458
2459         Reverted changeset:
2460
2461         "Part 2 of: Rename DatabaseProcess to StorageProcess."
2462         https://bugs.webkit.org/show_bug.cgi?id=174880
2463         http://trac.webkit.org/changeset/219990
2464
2465 2017-07-28  Brady Eidson  <beidson@apple.com>
2466
2467         API tests that use URLSchemeHandler are failing.
2468         https://bugs.webkit.org/show_bug.cgi?id=174950
2469
2470         Reviewed by Alex Christensen.
2471
2472         Fix the NoMIMEType test to be correct.
2473
2474         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2475         (-[SchemeHandler initWithData:mimeType:]):
2476         (-[SchemeHandler webView:startURLSchemeTask:]):
2477         (TEST):
2478
2479 2017-07-28  Daniel Bates  <dabates@apple.com>
2480
2481         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
2482         https://bugs.webkit.org/show_bug.cgi?id=174876
2483
2484         Reviewed by Alex Christensen.
2485
2486         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
2487         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
2488         they provide a more direct way to test the platform abstraction.
2489
2490         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
2491
2492         * Scripts/prepare-ChangeLog:
2493         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
2494         of the current working directory.
2495
2496 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
2497
2498         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2499         https://bugs.webkit.org/show_bug.cgi?id=174930
2500
2501         Unreviewed test fix.
2502
2503         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
2504
2505         * Scripts/prepare-ChangeLog:
2506         (get_function_line_ranges_for_cpp):
2507
2508 2017-07-28  JF Bastien  <jfbastien@apple.com>
2509
2510         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2511         https://bugs.webkit.org/show_bug.cgi?id=174930
2512
2513         Reviewed by Daniel Bates.
2514
2515         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
2516         here also teach it about const and volatile overloads. I didn't do
2517         reference and rvalue reference overloads because we don't really
2518         use them, and the current parser throws away those characters and
2519         it doesn't seem worth making it more complex.
2520
2521         * Scripts/prepare-ChangeLog:
2522         (get_function_line_ranges_for_cpp):
2523         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2524         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
2525         (Foo::Arrow::arrow):
2526         (Foo::Arrow::otherArrow):
2527         (Foo::Arrow::otherArrow const):
2528         (Foo::Arrow::otherArrow volatile):
2529         (Foo::Arrow::otherArrow const volatile):
2530
2531 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
2532
2533         [GTK] Building with ENABLE_VIDEO=OFF fails
2534         https://bugs.webkit.org/show_bug.cgi?id=174940
2535
2536         Reviewed by Alex Christensen.
2537
2538         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
2539         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
2540
2541         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2542         (methodCallCallback): Add missing USE(GSTREAMER) guard.
2543
2544 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
2545
2546         [WPE] Implement EventSenderProxy in WTR
2547         https://bugs.webkit.org/show_bug.cgi?id=173419
2548
2549         Reviewed by Žan Doberšek.
2550
2551         Add the implementation of EventSenderProxy to the WTR. This
2552         allows us to extend the coverage of the test suite in WKWPE.
2553
2554         * WebKitTestRunner/EventSenderProxy.h:
2555         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
2556         libxkbcommon needed to deal with key events.
2557         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2558         (WTR::EventSenderProxy::EventSenderProxy):
2559         (WTR::senderButtonToWPEButton):
2560         (WTR::EventSenderProxy::mouseDown):
2561         (WTR::EventSenderProxy::mouseUp):
2562         (WTR::EventSenderProxy::mouseMoveTo):
2563         (WTR::EventSenderProxy::mouseScrollBy):
2564         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2565         (WTR::EventSenderProxy::leapForward):
2566         (WTR::wkEventModifiersToWPE):
2567         (WTR::getXKBKeySymForKeyRef):
2568         (WTR::EventSenderProxy::keyDown):
2569         (WTR::EventSenderProxy::addTouchPoint):
2570         (WTR::EventSenderProxy::updateTouchPoint):
2571         (WTR::EventSenderProxy::setTouchModifier):
2572         (WTR::EventSenderProxy::setTouchPointRadius):
2573         (WTR::EventSenderProxy::getUpdatedTouchEvents):
2574         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
2575         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2576         (WTR::EventSenderProxy::touchStart):
2577         (WTR::EventSenderProxy::touchMove):
2578         (WTR::EventSenderProxy::touchEnd):
2579         (WTR::EventSenderProxy::touchCancel):
2580         (WTR::EventSenderProxy::clearTouchPoints):
2581         (WTR::EventSenderProxy::releaseTouchPoint):
2582         (WTR::EventSenderProxy::cancelTouchPoint):
2583
2584 2017-07-27  Brady Eidson  <beidson@apple.com>
2585
2586         Part 2 of: Rename DatabaseProcess to StorageProcess.
2587         https://bugs.webkit.org/show_bug.cgi?id=174880
2588
2589         Reviewed by Andy Estes.
2590
2591         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2592         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2593         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2594         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2595         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2596         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2597         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2598         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2599
2600 2017-07-26  Mark Lam  <mark.lam@apple.com>
2601
2602         Add ability to only run specific tests in run-javascriptcore-tests.
2603         https://bugs.webkit.org/show_bug.cgi?id=174884
2604
2605         Reviewed by Saam Barati.
2606
2607         For example, if we only want to run testapi, we can do so as follows:
2608             $ run-javascriptcore-tests --testapi
2609
2610         Previously, specifying --testapi effectively does nothing because we run all tests
2611         by default.  Only --no-testapi had the effect of disabling the test set.  This
2612         old behavior for --testapi is not very useful or meaningful.  We're now changing
2613         it to mean that we will only run that test.
2614
2615         With this change, we can also run more than one set of tests.  For example, if we
2616         only want to run testmasm and testair, we can do so as follows:
2617             $ run-javascriptcore-tests --testmasm --testair
2618
2619         By default, if no specific test option is specified, run-javascriptcore-tests will
2620         run all tests.
2621
2622         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
2623         the mozilla tests (--mozilla-tests) even though both are run via the lower level
2624         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
2625         the other set will not run.  For example, the following only runs the mozilla tests:
2626             $ run-javascriptcore-tests --mozilla-tests
2627
2628         Note also that --jit-stress-tests is not for choosing a different set of tests.
2629         Instead, it is used for determining whether we run JIT'ed test configurations
2630         on the jsc stress tests and mozilla tests.  As a result, specifying
2631         --jit-stress-tests will not omit other tests.  For example, the following still
2632         runs all tests:
2633             $ run-javascriptcore-tests --jit-stress-tests
2634
2635         * Scripts/run-javascriptcore-tests:
2636         (defaultStringForTestState):
2637         (enableTestOrNot):
2638         (runJSCStressTests):
2639
2640 2017-07-26  Mark Lam  <mark.lam@apple.com>
2641
2642         Make run-javascriptcore-test run testair, testb3, and testmasm.
2643         https://bugs.webkit.org/show_bug.cgi?id=174837
2644         <rdar://problem/33522927>
2645
2646         Reviewed by Saam Barati and Filip Pizlo.
2647
2648         1. Refactors code for running testapi so that we can use it to run other tests.
2649         2. Added running of testmasm, testair, testb3.
2650
2651         Note: the existing testapi invocation code does not support remote invocation of
2652         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
2653         and testb3 also do not support remote invocation.  If we wish to add remote
2654         invocation support, we should do that in a separate patch.
2655
2656         * Scripts/run-javascriptcore-tests:
2657         (testPath):
2658         (runTest):
2659         (testapiPath): Deleted.
2660
2661 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
2662
2663         Remove duplicate code from Buildbot.js in dashboard
2664         https://bugs.webkit.org/show_bug.cgi?id=174870
2665
2666         Reviewed by Daniel Bates.
2667
2668         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2669         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
2670         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
2671         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
2672         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
2673
2674 2017-07-26  Brady Eidson  <beidson@apple.com>
2675
2676         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
2677         https://bugs.webkit.org/show_bug.cgi?id=174851
2678
2679         Reviewed by Chris Dumez.
2680
2681         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2682         (TEST):
2683
2684 2017-07-26  Brian Burg  <bburg@apple.com>
2685
2686         Remove WEB_TIMING feature flag
2687         https://bugs.webkit.org/show_bug.cgi?id=174795
2688
2689         Reviewed by Alex Christensen.
2690
2691         * Scripts/webkitperl/FeatureList.pm:
2692         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2693
2694 2017-07-26  Chris Dumez  <cdumez@apple.com>
2695
2696         Pressing the Escape key should not be a valid user gesture to enter fullscreen
2697         https://bugs.webkit.org/show_bug.cgi?id=174864
2698         <rdar://problem/33009088>
2699
2700         Reviewed by Geoffrey Garen.
2701
2702         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
2703         WKTR.
2704
2705         * DumpRenderTree/mac/EventSendingController.mm:
2706         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2707
2708 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2709
2710         Unreviewed, added Romain Bellessort to contributors.json.
2711
2712         * Scripts/webkitpy/common/config/contributors.json:
2713
2714 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
2715
2716         [WPE] WebGL2 support
2717         https://bugs.webkit.org/show_bug.cgi?id=174249
2718
2719         Reviewed by Alex Christensen.
2720
2721         * Scripts/webkitperl/FeatureList.pm:
2722         Enable WebGL2 for WPE when building through build-webkit.
2723
2724 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2725
2726         Unreviewed. Fix GTK distcheck.
2727
2728         * gtk/make-dist.py:
2729         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
2730
2731 2017-07-25  Brady Eidson  <beidson@apple.com>
2732
2733         ResourceLoadStatistics grandfathering happens much too often.
2734         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
2735
2736         Reviewed by Chris Dumez.
2737
2738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2739         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
2740         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
2741         (TEST):
2742
2743 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
2744
2745         Fix autoinstaller failing on autoinstall_everything
2746         https://bugs.webkit.org/show_bug.cgi?id=174830
2747
2748         Reviewed by Joseph Pecoraro.
2749
2750         * Scripts/webkitpy/thirdparty/__init__.py:
2751         (AutoinstallImportHook.find_module):
2752         (AutoinstallImportHook.install_chromedriver):
2753         (AutoinstallImportHook.install_geckodriver):
2754         (AutoinstallImportHook._install_chromedriver): Deleted.
2755         (AutoinstallImportHook._install_geckodriver): Deleted.
2756
2757 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
2758
2759         Replace --runtime with something for both ios-simulator and ios-device
2760         https://bugs.webkit.org/show_bug.cgi?id=173775
2761         <rdar://problem/32952164>
2762
2763         Reviewed by Aakash Jain.
2764
2765         Add --version flag for both iOS simulator and iOS device.
2766
2767         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2768         (parse_args): Add --version flag and move --no-install.
2769         * Scripts/webkitpy/port/factory.py:
2770         (platform_options): Move --no-intall to run_webkit_tests.py.
2771         * Scripts/webkitpy/port/ios.py:
2772         (IOSPort):
2773         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
2774         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
2775         * Scripts/webkitpy/port/ios_device.py:
2776         (IOSDevicePort.ios_version): Consult --version flag before checking connected
2777         devices for iOS version.
2778         * Scripts/webkitpy/port/ios_device_unittest.py:
2779         (IOSDeviceTest.make_port): Set --version option so that we can generate test
2780         expectation paths without devices connected.
2781         (IOSDeviceTest.test_additional_platform_directory): Deleted.
2782         (IOSDeviceTest.test_baseline_searchpath): Deleted.
2783         (IOSDeviceTest.test_expectations_ordering): Deleted.
2784         * Scripts/webkitpy/port/ios_simulator.py:
2785         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
2786         flag to specify a runtime.
2787         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
2788         flag and then use the default runtime.
2789
2790 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2791
2792         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
2793         https://bugs.webkit.org/show_bug.cgi?id=174815
2794
2795         Reviewed by Carlos Alberto Lopez Perez.
2796
2797         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
2798         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
2799         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
2800         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
2801         think), probably because of a newer CMake version.
2802
2803         * CMakeLists.txt:
2804         * TestWebKitAPI/CMakeLists.txt:
2805         * TestWebKitAPI/PlatformGTK.cmake:
2806
2807 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2808
2809         Fix BenchmarkRunner to only import selenium when needed
2810         https://bugs.webkit.org/show_bug.cgi?id=174808
2811
2812         Reviewed by Stephanie Lewis.
2813
2814         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2815         (LinuxChromeDriver.launch_driver):
2816         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2817         (LinuxFirefoxDriver.launch_driver):
2818         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2819         (OSXChromeDriver.launch_driver):
2820         (OSXChromeCanaryDriver.launch_driver):
2821         (create_chrome_options):
2822         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2823         (OSXFirefoxDriver.launch_driver):
2824         (OSXFirefoxNightlyDriver.launch_driver):
2825         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2826         (OSXSafariDriver.launch_driver):
2827         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2828         (WebDriverBenchmarkRunner._run_one_test):
2829
2830 2017-07-23  Darin Adler  <darin@apple.com>
2831
2832         More NeverDestroyed and related cleanup
2833         https://bugs.webkit.org/show_bug.cgi?id=174745
2834
2835         Reviewed by Alex Christensen.
2836
2837         * DumpRenderTree/JavaScriptThreading.cpp:
2838         (javaScriptThreadsMutex): Use NeverDestroyed instead of
2839         DEPRECATED_DEFINE_STATIC_LOCAL.
2840         (javaScriptThreads): Ditto.
2841
2842 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2843
2844         Subclass Benchmark Runner script for WebDriver support
2845         https://bugs.webkit.org/show_bug.cgi?id=174390
2846
2847         Reviewed by Dewei Zhu, Stephanie Lewis.
2848
2849         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
2850
2851         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2852         (BenchmarkBuilder.__init__):
2853         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2854         (BenchmarkRunner.__init__):
2855         (BenchmarkRunner._find_plan_file):
2856         (BenchmarkRunner._run_one_test.and):
2857         (BenchmarkRunner.execute):
2858         (BenchmarkRunner._get_result): Deleted.
2859         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2860         (parse_args):
2861         (start):
2862         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
2863         (WebDriverBenchmarkRunner):
2864         (WebDriverBenchmarkRunner._get_result):
2865         (WebDriverBenchmarkRunner._run_one_test):
2866         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
2867         (WebServerBenchmarkRunner):
2868         (WebServerBenchmarkRunner.__init__):
2869         (WebServerBenchmarkRunner._get_result):
2870         (WebServerBenchmarkRunner._run_one_test):
2871
2872 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2873
2874         Add BenchmarkRunner patches with WebDriver support for each testing plan
2875         https://bugs.webkit.org/show_bug.cgi?id=174443
2876
2877         Reviewed by Dewei Zhu, Stephanie Lewis.
2878
2879         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2880         (BenchmarkBuilder.__enter__):
2881         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
2882         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
2883         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
2884         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
2885         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
2886         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
2887         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
2888         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
2889         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
2890         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
2891         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2892         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
2893         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
2894         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
2895         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
2896         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
2897         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
2898         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2899         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
2900         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
2901         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
2902         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2903         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2904         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
2905         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
2906         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
2907         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2908         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
2909         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
2910         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2911         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
2912         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2913         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2914
2915 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2916
2917         Add functions to autoinstaller needed for Benchmark Runner script
2918         https://bugs.webkit.org/show_bug.cgi?id=174331
2919
2920         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2921
2922         Adds autoinstaller functions to install selenium and webdriver binaries
2923         which will be used by the browser driver part of Benchmark Runner.
2924
2925         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2926         (BrowserDriver.restore_env):
2927         (BrowserDriver):
2928         (BrowserDriver.get_webdriver_binary_path):
2929         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2930         (LinuxChromeDriver.launch_driver):
2931         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2932         (LinuxFirefoxDriver.launch_driver):
2933         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2934         (OSXChromeDriver.launch_driver):
2935         (OSXChromeCanaryDriver.launch_driver):
2936         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2937         (OSXFirefoxDriver.launch_driver):
2938         (OSXFirefoxNightlyDriver.launch_driver):
2939         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2940         * Scripts/webkitpy/benchmark_runner/utils.py:
2941         (get_driver_binary_path):
2942         * Scripts/webkitpy/common/system/autoinstall.py:
2943         (AutoInstaller._unzip):
2944         * Scripts/webkitpy/thirdparty/__init__.py:
2945         (AutoinstallImportHook.find_module):
2946         (AutoinstallImportHook._install_selenium):
2947         (AutoinstallImportHook):
2948         (AutoinstallImportHook._install_chromedriver):
2949         (AutoinstallImportHook._install_geckodriver):
2950         (AutoinstallImportHook.get_latest_pypi_url):
2951         (AutoinstallImportHook.install_binary):
2952         (autoinstall_everything):
2953         (get_driver_filename):
2954         (get_os_info):
2955
2956 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2957
2958         Add WebDriver support in browser driver part of BenchmarkRunner
2959         https://bugs.webkit.org/show_bug.cgi?id=174445
2960
2961         Reviewed by Stephanie Lewis.
2962
2963         Adds a launch_driver function to each BrowserDriver subclass. This
2964         function sets up the arguments for the webdriver and launches the
2965         webdriver specific to that browser.
2966
2967         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2968         (BrowserDriver.launch_webdriver):
2969         (BrowserDriver):
2970         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2971         (LinuxBrowserDriver.launch_webdriver):
2972         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2973         (LinuxChromeDriver.launch_url):
2974         (LinuxChromeDriver):
2975         (LinuxChromeDriver.launch_driver):
2976         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2977         (EpiphanyBrowserDriver.launch_url):
2978         (EpiphanyBrowserDriver):
2979         (EpiphanyBrowserDriver.launch_driver):
2980         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2981         (LinuxFirefoxDriver):
2982         (LinuxFirefoxDriver.launch_url):
2983         (LinuxFirefoxDriver.launch_driver):
2984         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2985         (GTKMiniBrowserDriver.launch_url):
2986         (GTKMiniBrowserDriver):
2987         (GTKMiniBrowserDriver.launch_driver):
2988         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2989         (OSXBrowserDriver._launch_webdriver):
2990         (OSXBrowserDriver):
2991         (OSXBrowserDriver._screen_size):
2992         (OSXBrowserDriver._insert_url):
2993         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2994         (OSXChromeDriver):
2995         (OSXChromeDriver.launch_url):
2996         (OSXChromeDriver.launch_driver):
2997         (OSXChromeCanaryDriver):
2998         (OSXChromeCanaryDriver.launch_url):
2999         (OSXChromeCanaryDriver.launch_driver):
3000         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3001         (OSXFirefoxDriver):
3002         (OSXFirefoxDriver.launch_url):
3003         (OSXFirefoxDriver.launch_driver):
3004         (OSXFirefoxNightlyDriver):
3005         (OSXFirefoxNightlyDriver.launch_url):
3006         (OSXFirefoxNightlyDriver.launch_driver):
3007         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3008         (OSXSafariDriver.launch_driver):
3009
3010 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3011
3012         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
3013         https://bugs.webkit.org/show_bug.cgi?id=174793
3014
3015         Reviewed by Tim Horton.
3016
3017         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
3018         down. Without r219765, this test will dereference null and crash.
3019
3020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3021         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
3022         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
3023         (TEST):
3024
3025 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3026
3027         [Win] Implement Authentication dialog in MiniBrowser
3028         https://bugs.webkit.org/show_bug.cgi?id=174662
3029
3030         Reviewed by Alex Christensen.
3031
3032         * MiniBrowser/win/Common.cpp:
3033         (CustomUserAgent):
3034         (DisplayAuthDialog):
3035         (AuthDialogProc):
3036         * MiniBrowser/win/MiniBrowserLib.rc:
3037         * MiniBrowser/win/MiniBrowserLibResource.h:
3038         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3039         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3040
3041 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
3042
3043         Handle case where line_numbers is None instead of an array of line numbers
3044         https://bugs.webkit.org/show_bug.cgi?id=174775
3045
3046         Reviewed by Aakash Jain.
3047
3048         Added files set line_numbers to None in process_file.
3049
3050         * Scripts/webkitpy/style/filereader.py:
3051         (TextFileReader.process_file): Handle case where line_number is set to None.
3052         * Scripts/webkitpy/style/main_unittest.py:
3053         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
3054
3055 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
3056
3057         [WPE] Add libepoxy to the Jhbuild moduleset
3058         https://bugs.webkit.org/show_bug.cgi?id=174711
3059
3060         Reviewed by Carlos Alberto Lopez Perez.
3061
3062         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
3063
3064 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
3065
3066         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
3067         https://bugs.webkit.org/show_bug.cgi?id=174780
3068
3069         Reviewed by Carlos Garcia Campos.
3070
3071         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
3072         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
3073         in case the eglplatform.h header doesn't provide that macro. This replicates
3074         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
3075
3076 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3077
3078         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
3079         https://bugs.webkit.org/show_bug.cgi?id=174758
3080
3081         Reviewed by Dan Bernstein.
3082
3083         Migrate position-information-related unit tests from the PositionInformationTests suite to
3084         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
3085
3086         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3087         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3088         (TestWebKitAPI::checkElementTypeAndBoundingRect):
3089         (TestWebKitAPI::TEST):
3090         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
3091         * TestWebKitAPI/cocoa/TestWKWebView.h:
3092         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3093         (-[TestWKWebView activatedElementAtPosition:]):
3094
3095 2017-07-22  Chris Dumez  <cdumez@apple.com>
3096
3097         REGRESSION(r204565): WKObject is broken
3098         https://bugs.webkit.org/show_bug.cgi?id=174736
3099         <rdar://problem/33246169>
3100
3101         Reviewed by Dan Bernstein.
3102
3103         Add API test that used to crash.
3104
3105         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
3106         (TestWebKitAPI::TEST):
3107
3108 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
3109
3110         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
3111         https://bugs.webkit.org/show_bug.cgi?id=174705
3112
3113         Reviewed by Mark Lam.
3114
3115         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
3116         (TestWebKitAPI::testThreadGroup):
3117         (TestWebKitAPI::TEST):
3118
3119 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
3120
3121         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
3122         https://bugs.webkit.org/show_bug.cgi?id=174724
3123
3124         Reviewed by Aakash Jain.
3125
3126         * Scripts/webkitpy/port/ios_simulator.py:
3127         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
3128         simulator. Errors here should be treated the same as no simulators found.
3129
3130 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
3131
3132         [CMake] Add an option to stop build after generating project files
3133         https://bugs.webkit.org/show_bug.cgi?id=174664
3134
3135         Reviewed by Konstantin Tokarev.
3136
3137         Add "--generate-project-only" to stop build after generating project files.
3138
3139         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
3140         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
3141         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
3142         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
3143         (isGenerateProjectOnly): ditto
3144
3145 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
3146
3147         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3148         https://bugs.webkit.org/show_bug.cgi?id=174501
3149
3150         Reviewed by Darin Adler.
3151
3152         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3153         (TestWebKitAPI::TEST):
3154
3155 2017-07-20  David Quesada  <david_quesada@apple.com>
3156
3157         Add SPI to notify WKNavigationDelegate about client redirects
3158         https://bugs.webkit.org/show_bug.cgi?id=174680
3159         rdar://problem/33184886
3160
3161         Reviewed by Brady Eidson.
3162
3163         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3164         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
3165         (TEST):
3166         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
3167
3168 2017-07-20  Brady Eidson  <beidson@apple.com>
3169
3170         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
3171         https://bugs.webkit.org/show_bug.cgi?id=174685
3172
3173         Reviewed by Andy Estes.
3174
3175         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3176         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
3177
3178 2017-07-20  Brady Eidson  <beidson@apple.com>
3179
3180         Deprecate WebIconDatabase in WebKitLegacy/mac.
3181         https://bugs.webkit.org/show_bug.cgi?id=174607
3182
3183         Reviewed by Alex Christensen.
3184
3185         * DumpRenderTree/mac/TestRunnerMac.mm:
3186
3187 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
3188
3189         lint-test-expectations should be run during style checking
3190         https://bugs.webkit.org/show_bug.cgi?id=173559
3191         <rdar://problem/32854941>
3192
3193         Reviewed by Aakash Jain.
3194
3195         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3196         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
3197         prevents identifying errors on specific lines in a file.
3198         * Scripts/webkitpy/style/main_unittest.py:
3199         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
3200         case where a linter error is in the file modified, but the line modified is not related to
3201         the linter error.
3202
3203 2017-07-20  Brady Eidson  <beidson@apple.com>
3204
3205         Remove WebIconDatabase from WebKitLegacy/win.
3206         https://bugs.webkit.org/show_bug.cgi?id=174608
3207
3208         Reviewed by Alex Christensen.
3209
3210         * DumpRenderTree/win/DumpRenderTree.cpp:
3211         (main):
3212         * DumpRenderTree/win/TestRunnerWin.cpp:
3213         (TestRunner::setIconDatabaseEnabled):
3214
3215 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
3216
3217         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
3218         https://bugs.webkit.org/show_bug.cgi?id=174671
3219
3220         Reviewed by Carlos Garcia Campos.
3221
3222         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
3223         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
3224         priority for this source in order to have it dispatched on the same
3225         priority as the other WebKit-controlled GSource objects.
3226
3227 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
3228
3229         lint-test-expectations should be run during style checking
3230         https://bugs.webkit.org/show_bug.cgi?id=173559
3231         <rdar://problem/32854941>
3232
3233         Reviewed by Daniel Bates.
3234
3235         Follow up fix addressing style and a few minor bugs.
3236
3237         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3238         (TestExpectationParser.__init__): Use lambda x: x instead of str
3239         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
3240         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
3241         reduce the calls of _shorten_filename, fix minor bug in appending the current
3242         expectation's line number instead of the previous ones, clarify treatment of None
3243         in file-to-line-number mapping.
3244         (TestExpectations._report_warnings): Collapse call.
3245         * Scripts/webkitpy/style/checkers/test_expectations.py:
3246         (TestExpectationsChecker.lint_test_expectations):
3247         * Scripts/webkitpy/style/filereader.py: Re-write comment.
3248         (TextFileReader.process_file): Add comment explaining treatment of None in
3249         file-to-line-number mapping.
3250         (TextFileReader.delete_file): Collapse call.
3251
3252 2017-07-19  Chris Dumez  <cdumez@apple.com>
3253
3254         Unreviewed attempt to fix API test failure after r219663.
3255
3256         The test was hard-coding an exception string and the string has changed slightly
3257         in r219663.
3258
3259         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3260         (TEST):
3261
3262 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
3263
3264         Don't write file URLs to iOS Pasteboard
3265         https://bugs.webkit.org/show_bug.cgi?id=174647
3266         <rdar://problem/33199730>
3267
3268         Reviewed by Wenson Hsieh.
3269
3270         Updating tests to reflect the lack of file URLs for images.
3271
3272         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3273         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
3274         (checkEstimatedSize):
3275         (TestWebKitAPI::TEST):
3276
3277 2017-07-19  Brady Eidson  <beidson@apple.com>
3278
3279         iBooks sometimes crashes when closing a book.
3280         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
3281
3282         Reviewed by Oliver Hunt.
3283
3284         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3285         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
3286         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
3287         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
3288         (TestWebKitAPI::TEST):
3289
3290         Add a "spin the runloop X number of times" utility:
3291         * TestWebKitAPI/Utilities.h:
3292         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3293         (TestWebKitAPI::Util::spinRunLoop):
3294
3295 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
3296
3297         lint-test-expectations should be run during style checking
3298         https://bugs.webkit.org/show_bug.cgi?id=173559
3299         <rdar://problem/32854941>
3300
3301         Reviewed by David Kilzer.
3302
3303         Running the test expectation linter requires reading both files and lines not in the
3304         patch because, for example, deletion of a test can cause a lint failure even though
3305         no test expectations where modified. This means that the linter will occasionally warn
3306         about lines which were not changed in a given patch but whose error is related to a
3307         change made in that patch.
3308
3309         * Scripts/webkitpy/common/system/filesystem_mock.py:
3310         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
3311         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3312         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
3313         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
3314         content, description of the error and the name of the associated test.
3315         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
3316         (TestExpectationParser.__init__): Pass shorten_filename function to
3317         TestExpectationsParser to add a deleted file to the related_files dictionary.
3318         (TestExpectationParser._check_test_exists): If the test does not exist, add the
3319         missing path to the related_files dictionary.
3320         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
3321         files and line numbers related to this test expectation line. This will allow
3322         tracking linter errors in the style checker occurring across multiple files.
3323         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
3324         lines to related_files dictionary.
3325         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
3326         (TestExpectations._report_warnings): Construct warning object instead of string
3327         when adding to warnings list.
3328         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
3329         clean-up log.
3330         * Scripts/webkitpy/style/checker.py:
3331         (ProcessorBase.do_association_check): Add required function for processor classes.
3332         (StyleProcessor):
3333         (StyleProcessor.do_association_check): Run the TestExpectations linter when
3334         checking for errors between associated files.
3335         * Scripts/webkitpy/style/checkers/test_expectations.py:
3336         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
3337         (TestExpectationsChecker):
3338         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
3339         of modified files, the current working directory and the host, determine if the linter
3340         warning is associated with the changes.
3341         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
3342         style checker.
3343         * Scripts/webkitpy/style/filereader.py:
3344         (TextFileReader):
3345         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
3346         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
3347         (TextFileReader.process_file): Track both the number of files changed and which lines
3348         in those files were changed.
3349         (TextFileReader.do_association_check): Run the processor's association check on all
3350         modified or deleted files processed by TextFileReader.
3351         (TextFileReader.delete_file): Track deleted files in _files dictionary.
3352         (TextFileReader.count_delete_only_file): Deleted.
3353         * Scripts/webkitpy/style/filereader_unittest.py:
3354         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
3355         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
3356         * Scripts/webkitpy/style/main.py:
3357         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
3358         explicitly run the association check on the file reader.
3359         * Scripts/webkitpy/style/main_unittest.py:
3360         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
3361         embedded in the style checker.
3362         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
3363         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
3364         construct the TextFileReader object with a StyleProcessor used to run style checks on
3365         specific files.
3366         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
3367         testing the test expectation linter inside the style checker. This host must contain a
3368         mock file system with the basic structure of test expectations.
3369         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
3370         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
3371         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
3372         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
3373         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
3374         * Scripts/webkitpy/style/patchreader.py:
3375         (PatchReader.check): Specify which file was deleted, run the association check.
3376         * Scripts/webkitpy/style/patchreader_unittest.py:
3377         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
3378         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
3379         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
3380
3381 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3382
3383         [WTF] Implement WTF::ThreadGroup
3384         https://bugs.webkit.org/show_bug.cgi?id=174081
3385
3386         Reviewed by Mark Lam.
3387
3388         Add WTF::ThreadGroup tests.
3389
3390         * TestWebKitAPI/CMakeLists.txt:
3391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3392         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
3393         (TestWebKitAPI::testThreadGroup):
3394         (TestWebKitAPI::TEST):
3395
3396 2017-07-18  Andy Estes  <aestes@apple.com>
3397
3398         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3399         https://bugs.webkit.org/show_bug.cgi?id=174631
3400
3401         Reviewed by Tim Horton.
3402
3403         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3404         * MiniBrowser/Configurations/Base.xcconfig:
3405         * MobileMiniBrowser/Configurations/Base.xcconfig:
3406         * TestWebKitAPI/Configurations/Base.xcconfig:
3407         * WebKitTestRunner/Configurations/Base.xcconfig:
3408
3409 2017-07-18  Andy Estes  <aestes@apple.com>
3410
3411         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3412         https://bugs.webkit.org/show_bug.cgi?id=174631
3413
3414         Reviewed by Sam Weinig.
3415
3416         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3417         * MiniBrowser/Configurations/Base.xcconfig:
3418         * MobileMiniBrowser/Configurations/Base.xcconfig:
3419         * TestWebKitAPI/Configurations/Base.xcconfig:
3420         * WebKitTestRunner/Configurations/Base.xcconfig:
3421
3422 2017-07-18  Daniel Bates  <dabates@apple.com>
3423
3424         lldb: Add type summary for StringView
3425         https://bugs.webkit.org/show_bug.cgi?id=174637
3426
3427         Reviewed by Sam Weinig.
3428
3429         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
3430         StringView object will print output that has the form:
3431
3432             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
3433               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
3434               m_length = 2
3435               m_is8Bit = true
3436               m_underlyingString = 0x0000614000000a90
3437             }
3438
3439         * lldb/lldb_webkit.py:
3440         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
3441         (WTFStringView_SummaryProvider):
3442         (WTFStringViewProvider):
3443         (WTFStringViewProvider.__init__):
3444         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
3445         (WTFStringViewProvider.get_length): Access field StringView.m_length.
3446         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
3447         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
3448
3449 2017-07-18  Andy Estes  <aestes@apple.com>
3450
3451         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3452         https://bugs.webkit.org/show_bug.cgi?id=174631
3453
3454         Reviewed by Dan Bernstein.
3455
3456         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3457         * MiniBrowser/Configurations/Base.xcconfig:
3458         * MobileMiniBrowser/Configurations/Base.xcconfig:
3459         * TestWebKitAPI/Configurations/Base.xcconfig:
3460         * WebKitTestRunner/Configurations/Base.xcconfig:
3461
3462 2017-07-18  Devin Rousso  <drousso@apple.com>
3463
3464         Web Inspector: Add memoryCost to Inspector Protocol objects
3465         https://bugs.webkit.org/show_bug.cgi?id=174478
3466
3467         Reviewed by Joseph Pecoraro.
3468
3469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3470         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
3471         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
3472         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
3473         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
3474         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
3475         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
3476         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
3477         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
3478         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
3479         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
3480         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
3481         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
3482         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
3483         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
3484         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
3485         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
3486
3487 2017-07-18  Andy Estes  <aestes@apple.com>
3488
3489         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3490         https://bugs.webkit.org/show_bug.cgi?id=174631
3491
3492         Reviewed by Darin Adler.
3493
3494         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3495         * MiniBrowser/Configurations/Base.xcconfig:
3496         * MobileMiniBrowser/Configurations/Base.xcconfig:
3497         * TestWebKitAPI/Configurations/Base.xcconfig:
3498         * WebKitTestRunner/Configurations/Base.xcconfig:
3499
3500 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3501
3502         Unreviewed, fix the iOS build.
3503
3504         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
3505
3506         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3507         (TestWebKitAPI::TEST):
3508
3509 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3510
3511         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
3512         https://bugs.webkit.org/show_bug.cgi?id=174585
3513         <rdar://problem/33302541>
3514
3515         Reviewed by Tim Horton.
3516
3517         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
3518         being dragged when initiating a drag.
3519
3520         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3521         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
3522         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3523         (TestWebKitAPI::TEST):
3524         * TestWebKitAPI/cocoa/TestWKWebView.h:
3525
3526         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
3527
3528         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3529         (-[TestWKWebView synchronouslyLoadHTMLString:]):
3530
3531 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3532
3533         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
3534         https://bugs.webkit.org/show_bug.cgi?id=174547
3535
3536         Reviewed by Alex Christensen.
3537
3538         * DumpRenderTree/PlatformWin.cmake:
3539         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3540
3541 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3542
3543         Update style checker to deal with "final"
3544         https://bugs.webkit.org/show_bug.cgi?id=174528
3545
3546         Reviewed by Alex Christensen.
3547         
3548         check-webkit-style shouldn't complain about an open brace to start a
3549         line after a function definition with "final" or "const final".
3550
3551         * Scripts/webkitpy/style/checkers/cpp.py:
3552         (check_braces):
3553         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3554         (CppStyleTest.test_brace_at_begin_of_line):
3555
3556 2017-07-17  Alex Christensen  <achristensen@webkit.org>
3557
3558         Modernize content extension code
3559         https://bugs.webkit.org/show_bug.cgi?id=174588
3560
3561         Reviewed by Sam Weinig.
3562
3563         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3564         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3565         (TestWebKitAPI::testRequest):
3566         (TestWebKitAPI::makeBackend):
3567         (TestWebKitAPI::TEST_F):
3568
3569 2017-07-17  Brady Eidson  <beidson@apple.com>
3570
3571         WKHTTPCookieStore observing only works on the default cookie store.
3572         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
3573
3574         Reviewed by Sam Weinig.
3575
3576         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3577         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
3578           called for the default store, a non-persistent store, and a custom store.
3579         (TEST):
3580
3581 2017-07-16  Sam Weinig  <sam@webkit.org>
3582
3583         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
3584         https://bugs.webkit.org/show_bug.cgi?id=174575
3585
3586         Reviewed by Brady Eidson.
3587
3588         * Scripts/svn-create-patch:
3589         (findModificationType):
3590         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
3591         default value of "unknown".
3592
3593         (generateFileList):
3594         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
3595         for untracked, which matches our old behavior.
3596
3597 2017-07-17  Charlie Turner  <cturner@igalia.com>
3598
3599         Add some missing build dependencies on Fedora
3600         https://bugs.webkit.org/show_bug.cgi?id=174578
3601
3602         Unreviewed dependency update.
3603
3604         * gt