[Win] build-jsc and run-javascriptcore-tests do not work
[WebKit-https.git] / Tools / ChangeLog
1 2015-10-30  Brent Fulgham  <bfulgham@apple.com>
2
3         [Win] build-jsc and run-javascriptcore-tests do not work
4         https://bugs.webkit.org/show_bug.cgi?id=150700
5
6         Reviewed by Mark Lam.
7         
8         Correct our build system so that it expects Windows to be using CMake,
9         and to build the correct sub-projects for our JSC helper scripts.
10
11         * Scripts/build-jsc: Make sure to build the testapi harness when
12           building for Windows.
13         * Scripts/build-webkit:
14           (1) Use the existing 'cmakeBasedPortName()'
15           (2) Use File::Spec rather than hard-coding path delimeters.
16           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
17         method rather than hard-coding the name based on conditional.
18         * Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
19           LLVM libraries on Apple Windows build.
20         * Scripts/run-javascriptcore-tests:
21         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
22         * Scripts/run-jsc: Ditto.
23         * Scripts/webkitdirs.pm:
24         (cmakeBasedPortName): Update to return the right value for the Apple
25         Windows port and the WinCairo port.
26         (isCMakeBuild): Expect CMake build for all Windows ports.
27
28 2015-10-30  Carlos Garcia Campos  <cgarcia@igalia.com>
29
30         [JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
31         https://bugs.webkit.org/show_bug.cgi?id=150665
32
33         Reviewed by Csaba Osztrogonác.
34
35         We check it only to wipe the directory or not, but we are still
36         tryihng to update every module even when the configuration hasn't
37         changed. This is problematic because it makes the whole build fail
38         when any repository fails to checkout an already checked out
39         revision, because the server is down for example. This is even
40         more problematic for the bots that skip perfectly valid revisions.
41         It's still possible to force an update passing --force command
42         line argument.
43
44         * Scripts/update-webkit-libs-jhbuild:
45         (deleteJhbuildMd5): Delete the md5sum files if exist.
46         (runJhbuild): Return early if the md5sum files haven't
47         changed. Only write them after a successful build and delete them
48         if the build fails to ensure we don't skip next run.
49
50 2015-10-30  Philippe Normand  <pnormand@igalia.com>
51
52         [GTK] Fix MacCLang build errors in Tools
53         https://bugs.webkit.org/show_bug.cgi?id=150031
54
55         Reviewed by Carlos Garcia Campos.
56
57         * TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
58         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
59         * WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
60         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
61
62 2015-10-29  Hunseop Jeong  <hs85.jeong@samsung.com>
63
64         [EFL] MiniBrowser didn't work after r191749.
65         https://bugs.webkit.org/show_bug.cgi?id=150706
66
67         Reviewed by Alex Christensen.
68
69         Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.
70
71         * Scripts/run-minibrowser:
72
73 2015-10-29  Commit Queue  <commit-queue@webkit.org>
74
75         Unreviewed, rolling out r191766.
76         https://bugs.webkit.org/show_bug.cgi?id=150707
77
78         Problem with Cygwin build (Requested by bfulgham_ on #webkit).
79
80         Reverted changeset:
81
82         "[Win] build-jsc and run-javascriptcore-tests do not work"
83         https://bugs.webkit.org/show_bug.cgi?id=150700
84         http://trac.webkit.org/changeset/191766
85
86 2015-10-29  Brent Fulgham  <bfulgham@apple.com>
87
88         [Win] build-jsc and run-javascriptcore-tests do not work
89         https://bugs.webkit.org/show_bug.cgi?id=150700
90
91         Reviewed by Mark Lam.
92         
93         Correct our build system so that it expects Windows to be using CMake,
94         and to build the correct sub-projects for our JSC helper scripts.
95
96         * Scripts/build-jsc: Make sure to build the testapi harness when
97           building for Windows.
98         * Scripts/build-webkit:
99           (1) Use the existing 'cmakeBasedPortName()'
100           (2) Use File::Spec rather than hard-coding path delimeters.
101           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
102         method rather than hard-coding the name based on conditional.
103         * Scripts/run-javascriptcore-tests:
104         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
105         * Scripts/run-jsc: Ditto.
106         * Scripts/webkitdirs.pm:
107         (cmakeBasedPortName): Update to return the right value for the Apple
108         Windows port and the WinCairo port.
109         (isCMakeBuild): Expect CMake build for all Windows ports.
110
111 2015-10-29  Alex Christensen  <achristensen@webkit.org>
112
113         Fix build-jsc on Mac after r191749.
114
115         * Scripts/build-jsc:
116         Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.
117
118 2015-10-29  Alex Christensen  <achristensen@webkit.org>
119
120         Fix Mac CMake build
121         https://bugs.webkit.org/show_bug.cgi?id=150686
122
123         Reviewed by Filip Pizlo.
124
125         * Scripts/build-webkit:
126         * Scripts/webkitdirs.pm:
127         (isCachedArgumentfileOutOfDate):
128         (wrapperPrefixIfNeeded):
129         (generateBuildSystemFromCMakeProject):
130         (buildCMakeGeneratedProject):
131         (cmakeBasedPortName):
132         (determineIsCMakeBuild):
133         (isCMakeBuild):
134         (promptUser):
135         (jhbuildWrapperPrefixIfNeeded): Deleted.
136
137 2015-10-29  Lucas Forschler  <lforschler@apple.com>
138
139         Teach JSC bots to build 32bit instead of x86_64
140         
141         Reviewed by Mark Lam.
142
143         * BuildSlaveSupport/build.webkit.org-config/config.json:
144
145 2015-10-29  Per Arne Vollan  <peavo@outlook.com>
146
147         [WinCairo] Fall back to AppleWin results in layout tests.
148         https://bugs.webkit.org/show_bug.cgi?id=150672
149
150         Reviewed by Alex Christensen.
151
152         * Scripts/webkitpy/port/win.py:
153         (WinCairoPort):
154         (WinCairoPort.default_baseline_search_path):
155
156 2015-10-28  Keith Rollin  <krollin@apple.com>
157
158         Do not sanitize user input for input[type=url]
159         https://bugs.webkit.org/show_bug.cgi?id=150346
160         <rdar://problem/23243240>
161
162         Reviewed by Brent Fulgham.
163
164         The Windows version of DumpRenderTree's eventSender.keyDown handler
165         simulates user-entry by decomposing the given character into a virtual
166         key code and a set of modifier keys. The code that determines if the
167         shift key should be simulated only worked if the character was an
168         upper case character. Extend this support to also include symbols that
169         (on the U.S. keyboard) require holding down the shift key.
170
171         This change allows fast/forms/input-user-input-sanitization.html
172         to succeed, which requires us to simulate the entering of '@' and ':'.
173
174         * DumpRenderTree/win/EventSender.cpp:
175         (keyDownCallback):
176
177 2015-10-28  Alex Christensen  <achristensen@webkit.org>
178
179         Compile and link with CMake on Mac
180         https://bugs.webkit.org/show_bug.cgi?id=150632
181
182         Reviewed by Tim Horton.
183
184         * TestWebKitAPI/PlatformMac.cmake:
185
186 2015-10-28  Xabier Rodriguez Calvar  <calvaris@igalia.com>
187
188         Unreviewed.
189
190         * Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
191
192 2015-10-28  Per Arne Vollan  <peavo@outlook.com>
193
194         Add WinCairo to list of ports in run-webkit-tests.
195         https://bugs.webkit.org/show_bug.cgi?id=150625
196
197         Reviewed by Brent Fulgham.
198
199         * Scripts/webkitpy/common/config/ports.py:
200         (DeprecatedPort.port):
201         (WinPort.run_webkit_tests_command):
202         (WinCairoPort):
203         (GtkWK2Port):
204         * Scripts/webkitpy/port/factory.py:
205         (PortFactory):
206         * Scripts/webkitpy/port/win.py:
207         (WinPort.find_system_pid):
208         (WinCairoPort):
209
210 2015-10-27  Alexey Proskuryakov  <ap@apple.com>
211
212         WebKitTestRunner leaks in generateWhitelist()
213         https://bugs.webkit.org/show_bug.cgi?id=150563
214
215         Reviewed by Andreas Kling.
216
217         * WebKitTestRunner/mac/TestControllerMac.mm:
218         (WTR::generateWhitelist):
219
220 2015-10-27  Anders Carlsson  <andersca@apple.com>
221
222         Add an API test for _WKRemoteObjectRegistry
223         https://bugs.webkit.org/show_bug.cgi?id=150597
224
225         Reviewed by Andreas Kling.
226
227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
228         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
229         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
230         (TEST):
231         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
232         (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
233         (-[RemoteObjectRegistryPlugIn sayHello:]):
234
235 2015-10-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
236
237         Add myself to the reviewers list
238         https://bugs.webkit.org/show_bug.cgi?id=150581
239
240         Unreviewed.
241
242         * Scripts/webkitpy/common/config/contributors.json:
243
244 2015-10-26  Ryan Haddad  <ryanhaddad@apple.com>
245
246         Adding myself to contributors.json
247
248         * Scripts/webkitpy/common/config/contributors.json:
249
250 2015-10-26  Tim Horton  <timothy_horton@apple.com>
251
252         Don't expose the whitelist/blacklist in _WKUserStyleSheet
253         https://bugs.webkit.org/show_bug.cgi?id=150566
254
255         Reviewed by Anders Carlsson.
256
257         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
258         (TEST):
259
260 2015-10-26  Philippe Normand  <pnormand@igalia.com>
261
262         Unreviewed, rolling out r191576.
263
264         broke
265
266         Reverted changeset:
267
268         "[GStreamer] Bump internal jhbuild versions to 1.6.0"
269         https://bugs.webkit.org/show_bug.cgi?id=149594
270         http://trac.webkit.org/changeset/191576
271
272 2015-10-26  ChangSeok Oh  <changseok.oh@collabora.com>
273
274         [GStreamer] Bump internal jhbuild versions to 1.6.0
275         https://bugs.webkit.org/show_bug.cgi?id=149594
276
277         Reviewed by Philippe Normand.
278
279         Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
280         useful so they are removed accordingly.
281
282         * gtk/jhbuild.modules:
283         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
284         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
285         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
286
287 2015-10-25  Alexey Proskuryakov  <ap@apple.com>
288
289         API tests fail on El Capitan after r191543
290         https://bugs.webkit.org/show_bug.cgi?id=150547
291
292         Reviewed by Dan Bernstein.
293
294         * Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
295
296 2015-10-24  Tim Horton  <timothy_horton@apple.com>
297
298         Add a way to add user style sheets to WKUserContentController
299         https://bugs.webkit.org/show_bug.cgi?id=150531
300         <rdar://problem/23191691>
301
302         Reviewed by Darin Adler.
303
304         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
305         (TEST):
306
307 2015-10-24  Tim Horton  <timothy_horton@apple.com>
308
309         Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
310         https://bugs.webkit.org/show_bug.cgi?id=150525
311
312         Reviewed by Darin Adler.
313
314         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
315         (TEST):
316         Test the various new keys.
317
318 2015-10-24  Frederic Wang  <fred.wang@free.fr>
319
320         check-webkit-style complains about missing operator whitespace inside character literal
321         https://bugs.webkit.org/show_bug.cgi?id=150396
322
323         Reviewed by Darin Adler.
324
325         * Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
326         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
327         (WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
328
329 2015-10-23  Michael Saboff  <msaboff@apple.com>
330
331         REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
332         https://bugs.webkit.org/show_bug.cgi?id=150513
333
334         Reviewed by Saam Barati.
335
336         Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
337
338         * DumpRenderTree/TestRunner.cpp:
339         (simulateWebNotificationClickCallback):
340         (failNextCodeBlock):
341         (numberOfDFGCompiles):
342         (TestRunner::staticFunctions):
343         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
344         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
345         (WTR::TestRunner::setBlockAllPlugins):
346         (WTR::TestRunner::failNextCodeBlock):
347         (WTR::TestRunner::numberOfDFGCompiles):
348         * WebKitTestRunner/InjectedBundle/TestRunner.h:
349
350 2015-10-23  Anders Carlsson  <andersca@apple.com>
351
352         Simplify the WebKitLegacy menu conversion code
353         https://bugs.webkit.org/show_bug.cgi?id=150509
354
355         Reviewed by Andreas Kling.
356
357         Implement the context menu delegate method so we'll test that code path.
358
359         * MiniBrowser/mac/WK1BrowserWindowController.m:
360         (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
361
362 2015-10-23  Per Arne Vollan  <peavo@outlook.com>
363
364         [WinCairo] Improve test results for fast layouttests.
365         https://bugs.webkit.org/show_bug.cgi?id=150464
366
367         Reviewed by Alex Christensen.
368
369         Set custom device scale factor to 1.0.
370
371         * DumpRenderTree/win/DumpRenderTree.cpp:
372         (createWebViewAndOffscreenWindow):
373
374 2015-10-23  Mark Salisbury  <mark.salisbury@hp.com>
375
376         [GTK] update-webkitgtk-libs should use mesa tarball
377
378         https://bugs.webkit.org/show_bug.cgi?id=150470
379
380         update-webkitgtk-libs downloads all build dependencies; in fixing
381         bug 148941 mesa was switched from ftp to git access.  Now an http
382         tarball is available, which is preferred over accessing via git.
383
384         Reviewed by Philippe Normand
385
386         * gtk/jhbuild.modules:
387         Mesa access changed to http tarball.
388
389 2015-10-22  Sam Weinig  <sam@webkit.org>
390
391         Navigations on the same host (but with different schemes and ports) should not trigger universal links
392         <rdar://problem/22811325>
393         https://bugs.webkit.org/show_bug.cgi?id=150481
394
395         Reviewed by Dan Bernstein.
396
397         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
398         Update test to test that navigations on the same host but with different schemes does not
399         trigger universal links, but that changes in the host do.
400
401 2015-10-22  Ryosuke Niwa  <rniwa@webkit.org>
402
403         REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
404         https://bugs.webkit.org/show_bug.cgi?id=150428
405
406         Reviewed by Antti Koivisto.
407
408         Added a regression test using WebKit API test.
409
410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
411         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
412         (TestWebKitAPI::didFinishLoadForFrame):
413         (TestWebKitAPI::TEST):
414
415 2015-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
416
417         Unreviewed. Fix GTK+ build after r191423.
418
419         Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
420
421         * gtk/webkitdom.py:
422         (WebKitDOMDocGenerator):
423
424 2015-10-22  Aakash Jain  <aakash_jain@apple.com>
425
426         [Win][EFL][GTK] webkitpy test failed after r191374.
427         https://bugs.webkit.org/show_bug.cgi?id=150433
428
429         Reviewed by Alexey Proskuryakov.
430
431         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
432         (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
433         (CrashLogsTest.test_find_log_darwin): Same.
434
435 2015-10-21  Brian Burg  <bburg@apple.com>
436
437         Unreviewed, update watchlist for JS builtins.
438
439         Add a category for JS builtins code generator, similar to other generators.
440
441         Add a nag message to rebaseline builtins generator tests when touching
442         code generator files in Source/JavaScriptCore/Scripts/builtins/.
443
444         * Scripts/webkitpy/common/config/watchlist:
445
446 2015-10-21  Brian Burg  <bburg@apple.com>
447
448         Restructure generate-js-bindings script to be modular and testable
449         https://bugs.webkit.org/show_bug.cgi?id=149929
450
451         Reviewed by Alex Christensen.
452
453         Add a stub shell script and basic webkitpy support for running builtins
454         generator tests.
455
456         * Scripts/run-builtins-generator-tests: Added.
457         (main):
458         * Scripts/webkitpy/codegen/__init__.py: Added.
459         * Scripts/webkitpy/codegen/main.py: Added.
460
461             The only interesting difference here from the inspector protocol
462             generator equivalent is that this implementation decodes the target
463             framework and output mode (combined or separate) from the test's file name.
464
465         (BuiltinsGeneratorTests):
466         (BuiltinsGeneratorTests.__init__):
467         (BuiltinsGeneratorTests.generate_from_js_builtins):
468         (BuiltinsGeneratorTests.write_error_file):
469         (BuiltinsGeneratorTests.detect_changes):
470         (BuiltinsGeneratorTests.run_tests):
471         (BuiltinsGeneratorTests.main):
472
473 2015-10-21  Aakash Jain  <aakash_jain@apple.com>
474
475         run-webkit-tests does not copy all crash logs for layout test failures on Mac
476         https://bugs.webkit.org/show_bug.cgi?id=150407
477         <rdar://problem/22239750>
478
479         Reviewed by Alexey Proskuryakov.
480
481         * Scripts/webkitpy/port/mac.py:
482         (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
483         (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
484         the log directory.
485         (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
486         from log directory and merge them with the list of already crashed tests.
487
488 2015-10-21  Filip Pizlo  <fpizlo@apple.com>
489
490         Failures in PutStackSinkingPhase should be less severe
491         https://bugs.webkit.org/show_bug.cgi?id=150400
492
493         Reviewed by Geoffrey Garen.
494
495         Add a test mode for no PutStackSinkingPhase.
496
497         * Scripts/run-jsc-stress-tests:
498
499 2015-10-21  Nan Wang  <n_wang@apple.com>
500
501         AX: Expose table size and cell indexes on iOS
502         https://bugs.webkit.org/show_bug.cgi?id=150366
503
504         Reviewed by Chris Fleizach.
505
506         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
507         (AccessibilityUIElement::rowCount):
508         (AccessibilityUIElement::columnCount):
509         (AccessibilityUIElement::indexInTable):
510         (AccessibilityUIElement::numberAttributeValue):
511         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
512         (WTR::AccessibilityUIElement::numberAttributeValue):
513         (WTR::AccessibilityUIElement::rowCount):
514         (WTR::AccessibilityUIElement::columnCount):
515         (WTR::AccessibilityUIElement::indexInTable):
516
517 2015-10-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
518
519         W3C test importer should not import reference files as regular tests
520         https://bugs.webkit.org/show_bug.cgi?id=150331
521
522         Reviewed by Darin Adler.
523
524         Updated test_parser to return information that a file can be a referencefile or a manual test.
525         Updated test importer to skip those files.
526         Updated/Added test parser unit tests accordingly.
527
528         Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
529         Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
530         to mark these files as Skip, since they are not direct tests. 
531
532         * Scripts/webkitpy/w3c/test_importer.py:
533         (TestImporter.__init__):
534         (TestImporter.find_importable_tests):
535         (TestImporter.import_tests):
536         * Scripts/webkitpy/w3c/test_parser.py:
537         (TestParser.analyze_test):
538         * Scripts/webkitpy/w3c/test_parser_unittest.py:
539         (test_analyze_non_html_file):
540         (test_reference_test):
541
542 2015-10-20  Aakash Jain  <aakash_jain@apple.com>
543
544         run-webkit-tests does not copy all crash logs for layout test failures on iOS
545         https://bugs.webkit.org/show_bug.cgi?id=150056
546         <rdar://problem/9280656>
547
548         Reviewed by Alexey Proskuryakov.
549
550         * Scripts/webkitpy/common/system/crashlogs.py:
551         (CrashLogs.find_all_logs): Generic method to find all crash logs.
552         (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
553         It iterates through log directory and returns all the logs based on timestamp.
554         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
555         (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
556         (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
557         (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
558         * Scripts/webkitpy/layout_tests/controllers/manager.py:
559         (Manager.run): Modified start_time to start counting before simulator launch
560         so that we can capture crashes during simualator launch.
561         (Manager._look_for_new_crash_logs): Browse through list of crashes and append
562         any test which is not already marked as CRASH to the run_results.
563         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
564         (TestExpectationsModel.get_expectations_string): return PASS in case there
565         are no expectations defined for this test.
566         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
567         (summarize_results): Add other_crashes in a separte category in full_results.json.
568         * Scripts/webkitpy/port/ios.py:
569         (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
570         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
571         from the log directory.
572         (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
573         logs from log directory and merge them with the list of already crashed tests.
574
575 2015-10-20  Dana Burkart  <dburkart@apple.com>
576
577         Fix the build
578
579         Unreviewed.
580
581         My previous patch was missing a necessary space character.
582
583         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
584
585 2015-10-20  Dana Burkart  <dburkart@apple.com>
586
587         svn-apply fails to apply binary diffs in some cases
588         https://bugs.webkit.org/show_bug.cgi?id=64647
589
590         Reviewed by Daniel Bates.
591
592         * Scripts/VCSUtils.pm:
593         (decodeGitBinaryPatchDeltaSize): Modified.
594         We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
595         * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
596
597 2015-10-20  Alexey Proskuryakov  <ap@apple.com>
598
599         Mac Debug EWS never finishes when there are failures
600         https://bugs.webkit.org/show_bug.cgi?id=150334
601
602         Reviewed by Daniel Bates.
603
604         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
605         * Scripts/webkitpy/tool/commands/queues.py:
606
607 2015-10-20  Philippe Normand  <pnormand@igalia.com>
608
609         [GTK] Enable OpenWebRTC test video/audio sources in tests
610
611         This is needed because we can't expect the buildbots to have
612         webcam/mic devices plugged in.
613
614         Rubber-stamped by Carlos Garcia Campos.
615
616         * Scripts/run-gtk-tests:
617         (TestRunner._setup_testing_environment):
618         * Scripts/webkitpy/port/gtk.py:
619         (GtkPort.setup_environ_for_server):
620
621 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
622
623         Rename the PICTURE_SIZES flag to CURRENTSRC
624         https://bugs.webkit.org/show_bug.cgi?id=150275
625
626         Reviewed by Dean Jackson.
627
628         * Scripts/webkitperl/FeatureList.pm:
629
630 2015-10-19  Hunseop Jeong  <hs85.jeong@samsung.com>
631
632         Unreviewed, add myself to the committers list.
633
634         * Scripts/webkitpy/common/config/contributors.json:
635
636 2015-10-19  Alexey Proskuryakov  <ap@apple.com>
637
638         Add new EWS queues to bot watcher's dashboard
639         https://bugs.webkit.org/show_bug.cgi?id=150297
640
641         Reviewed by Darin Adler.
642
643         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
644         (BubbleQueueServer):
645
646 2015-10-19  ChangSeok Oh  <changseok.oh@collabora.com>
647
648         REGRESSION(r190262): User media unit test failures after r190262
649         https://bugs.webkit.org/show_bug.cgi?id=149580
650
651         Reviewed by Carlos Garcia Campos.
652
653         The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
654         So we do not need to skip them anymore.
655
656         * Scripts/run-gtk-tests:
657         (TestRunner): Deleted.
658
659 2015-10-19  Csaba Osztrogonác  <ossy@webkit.org>
660
661         Add historical addresses to contributors.json
662         https://bugs.webkit.org/show_bug.cgi?id=150227
663
664         Reviewed by Darin Adler.
665
666         * Scripts/webkitpy/common/config/contributors.json:
667
668 2015-10-18  Sungmann Cho  <sungmann.cho@navercorp.com>
669
670         [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
671         https://bugs.webkit.org/show_bug.cgi?id=150307
672
673         Reviewed by Brent Fulgham.
674
675         The DLL build rules have been changed to generate "{Name}Lib.DLL",
676         but these changes have not yet been applied to the Visual Studio builds.
677
678         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
679
680 2015-10-16  Andreas Kling  <akling@apple.com>
681
682         [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
683         <https://webkit.org/b/150153>
684
685         Unreviewed.
686
687         Just use simple arrays of LChar and UChar for this test instead of creating String
688         objects and then getting the characters8()/characters16() from them, since that
689         doesn't guarantee null-termination (the bug.)
690
691         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
692         (TestWebKitAPI::TEST):
693         (TestWebKitAPI::build): Deleted.
694
695 2015-10-16  Tim Horton  <timothy_horton@apple.com>
696
697         WebKit2.AutoLayoutIntegration API test is failing on some of the bots
698         https://bugs.webkit.org/show_bug.cgi?id=150255
699
700         Reviewed by Simon Fraser.
701
702         * Scripts/run-api-tests:
703         (runTest):
704         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
705         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
706         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
707         (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
708         (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
709         Don't set the layout size until after the load finishes and we're waiting
710         for the reply, so that there is no race between the new size coming in
711         and us waiting for it.
712
713 2015-10-16  Anders Carlsson  <andersca@apple.com>
714
715         WebEditingDelegate should be a formal protocol
716         https://bugs.webkit.org/show_bug.cgi?id=150254
717         <rdar://problem/23149847>
718
719         Reviewed by Dan Bernstein.
720
721         * DumpRenderTree/mac/EditingDelegate.h:
722         Conform to the WebEditingDelegate protocol.
723
724 2015-10-16  Tim Horton  <timothy_horton@apple.com>
725
726         Hook up autolayout intrinsic sizing for WKWebView
727         https://bugs.webkit.org/show_bug.cgi?id=150219
728         <rdar://problem/20016905>
729
730         Reviewed by Simon Fraser.
731
732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
733         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
734         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
735         (-[AutoLayoutWKWebView load:expectingContentSize:]):
736         (-[AutoLayoutWKWebView expectContentSizeChange:]):
737         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
738         (TEST):
739         Add a variety of tests, including one which catches the bug that
740         the WebCore part of this patch fixes.
741
742 2015-10-15  Csaba Osztrogonác  <ossy@webkit.org>
743
744         Update the help message of --system-malloc
745         https://bugs.webkit.org/show_bug.cgi?id=150169
746
747         Reviewed by Geoffrey Garen.
748
749         * Scripts/webkitperl/FeatureList.pm:
750
751 2015-10-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
752
753         Update ImportExpectations according currently imported wpt tests
754         https://bugs.webkit.org/show_bug.cgi?id=150158
755
756         Reviewed by Chris Dumez.
757
758         * Scripts/webkitpy/w3c/test_downloader.py:
759         (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
760
761 2015-10-15  Eunmi Lee  <eunmi15.lee@samsung.com>
762
763         Unreviewed, Update my email address.
764
765         * Scripts/webkitpy/common/config/contributors.json:
766
767 2015-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
768
769         [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
770         https://bugs.webkit.org/show_bug.cgi?id=84960
771
772         Reviewed by Žan Doberšek.
773
774         * Scripts/run-gtk-tests:
775         (TestRunner): Unskip tests using SessionState.
776         * TestWebKitAPI/PlatformGTK.cmake: Add
777         WKPageCopySessionStateWithFiltering test.
778
779 2015-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
780
781         [GTK] Missing return value on TestWebExtensions.cpp:193
782         https://bugs.webkit.org/show_bug.cgi?id=149755
783
784         Unreviewed. Add missing return value.
785
786         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
787         (permissionRequestCallback):
788
789 2015-10-14  Andy Estes  <aestes@apple.com>
790
791         [iOS] build-dumprendertree does not build ImageDiff
792         https://bugs.webkit.org/show_bug.cgi?id=150152
793
794         Reviewed by Tim Horton.
795
796         run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
797         On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
798         as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
799         WebKit.xcworkspace), tests that rely on image diffing won't work properly.
800
801         There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
802         fine on that platform, and results in ImageDiff being built.
803
804         * Scripts/build-dumprendertree:
805
806 2015-10-14  Brent Fulgham  <bfulgham@apple.com>
807
808         [Win] Enforce launcher/library naming scheme
809         https://bugs.webkit.org/show_bug.cgi?id=150124
810
811         Reviewed by Alex Christensen.
812
813         * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
814         * MiniBrowser/win/CMakeLists.txt: Ditto.
815         * TestWebKitAPI/PlatformWin.cmake: Ditto.
816         * win/DLLLauncher/DLLLauncherMain.cpp:
817         (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
818         original {name}.dll.
819
820 2015-10-14  Andreas Kling  <akling@apple.com>
821
822         REGRESSION(r190882): Concatenating a character array and an empty string is broken.
823         <https://webkit.org/b/150135>
824
825         Reviewed by Geoffrey Garen.
826
827         Add a new WTF API test that covers this issue.
828
829         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
830         (TestWebKitAPI::build):
831         (TestWebKitAPI::TEST):
832
833 2015-10-14  Alex Christensen  <achristensen@webkit.org>
834
835         Add SPI for reloading without content blockers
836         https://bugs.webkit.org/show_bug.cgi?id=150058
837         rdar://problem/22742222
838
839         Reviewed by Sam Weinig.
840
841         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
842         (WTR::TestController::cocoaResetStateToConsistentValues):
843         * WebKitTestRunner/mac/TestControllerMac.mm:
844         (WTR::TestController::platformConfigureViewForTest):
845
846 2015-10-14  Mark Lam  <mark.lam@apple.com>
847
848         Rename some JSC option names to be more uniform.
849         https://bugs.webkit.org/show_bug.cgi?id=150127
850
851         Reviewed by Geoffrey Garen.
852
853         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
854         * Scripts/run-jsc-stress-tests:
855
856 2015-10-14  Anders Carlsson  <andersca@apple.com>
857
858         Change the bundle app cache APIs to take a page
859         https://bugs.webkit.org/show_bug.cgi?id=150123
860
861         Reviewed by Sam Weinig.
862
863         Update APIs.
864
865         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
866         (WTR::InjectedBundle::beginTesting):
867         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
868         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
869         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
870         (WTR::TestRunner::clearAllApplicationCaches):
871         (WTR::TestRunner::clearApplicationCacheForOrigin):
872         (WTR::TestRunner::setAppCacheMaximumSize):
873         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
874         (WTR::TestRunner::originsWithApplicationCache):
875
876 2015-10-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
877
878         Update web-platform-tests tools to the latest revision
879         https://bugs.webkit.org/show_bug.cgi?id=149645
880
881         Reviewed by Darin Adler.
882
883         Disabling git submodules information conversion to json install file for web-platform-tests.
884         Disabling related python unit tests.
885         The tools submodules contain submodules and the conversion tool does not support that yet.
886
887         Updating wpt launcher script to aling it with web-platform-test main script.
888
889         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
890         (main):
891         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
892         (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
893         * Scripts/webkitpy/w3c/test_importer_unittest.py:
894         (TestImporterTest.test_submodules_generation):
895
896 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
897
898         More debug queue build fixing.
899
900         Preserve the build style in one more place. Changed mock build_style from "both"
901         to "release", as we don't support testing both debug and release.
902
903         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
904         (MockCommitQueue.archive_last_test_results):
905         (MockCommitQueue):
906         (MockCommitQueue.build_style):
907         (MockCommitQueue.did_pass_testing_ews):
908         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
909         (PatchAnalysisTask._test):
910         (PatchAnalysisTask._build_and_test_without_patch):
911         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
912         (EarlyWarningSystemTest._default_expected_logs):
913         * Scripts/webkitpy/tool/commands/queues_unittest.py:
914
915 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
916
917         More debug queue build fixing.
918
919         Add build_style argument to derived classes as well.
920
921         * Scripts/webkitpy/common/config/ports.py:
922         (MacPort):
923         (MacPort.run_webkit_tests_command):
924         (WinPort.run_bindings_tests_command):
925         (WinPort):
926         (WinPort.run_webkit_tests_command):
927         (GtkWK2Port.build_webkit_command):
928         (GtkWK2Port):
929         (GtkWK2Port.run_webkit_tests_command):
930
931 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
932
933         [iOS] Build fix
934
935         Unreviewed.
936
937         Mach-O section names are limited to 16 characters.
938
939         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
940         * DumpRenderTree/mac/DumpRenderTree.mm:
941         (activateFontsIOS):
942
943 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
944
945         Build fix for mac-debug EWS queue.
946
947         Unreviewed.
948
949         Pass --debug to run-webkit-tests.
950
951         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
952         will need to be substantially modified to work in EWS, so the dummy implementation
953         was not helpful.
954
955         * Scripts/webkitpy/common/config/ports.py:
956         (DeprecatedPort.run_javascriptcore_tests_command):
957         (DeprecatedPort):
958         (DeprecatedPort.run_webkit_tests_command):
959         (DeprecatedPort.run_python_unittests_command):
960         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
961         * Scripts/webkitpy/common/config/ports_mock.py:
962         (MockPort.run_javascriptcore_tests_command):
963         (MockPort):
964         (MockPort.run_webkit_tests_command):
965         (MockPort.run_bindings_tests_command):
966         (MockPort.run_webkit_unit_tests_command): Deleted.
967         * Scripts/webkitpy/tool/commands/download_unittest.py:
968         * Scripts/webkitpy/tool/steps/runtests.py:
969         (RunTests.run):
970         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
971         (RunTestsTest.test_webkit_run_unit_tests):
972         * Scripts/webkitpy/tool/steps/steps_unittest.py:
973         (StepsTest.test_runtests_args):
974
975 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
976
977         [Win] Generate Crash Traces
978         https://bugs.webkit.org/show_bug.cgi?id=150103
979
980         Reviewed by Daniel Bates.
981
982         We were using an exception filter to try to emit "#CRASHED" to stderr
983         when a test program crashed. However, the modern Python implementation
984         seems capable of recognizing crashes on its own. Furthermore, registering
985         the exception handler was preventing the JIT debugger (NTSD) from
986         automatically attaching to the crashing program, so we were not getting
987         crash traces.
988         
989         * DumpRenderTree/win/DumpRenderTree.cpp:
990         (main): Don't register an exception filter.
991         (exceptionFilter): Deleted.
992         * Scripts/webkitpy/common/system/crashlogs.py:
993         (CrashLogs): Add another regular expression to handle a second crash trace
994         syntax I encountered during testing.
995         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
996         try the new one. The PID found by the new expression is in hexadecimal, so
997         convert it to an integer before returning it.
998         * Scripts/webkitpy/port/driver.py:
999         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
1000         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
1001         check for "#CRASHED" after stripping off the EOL characters.
1002         * Scripts/webkitpy/port/win.py:
1003         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
1004         invocation. This is apparently used to signal an event when the debugger is finished.
1005
1006 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1007
1008         Mac Debug and 32-bit queues should be separate
1009         https://bugs.webkit.org/show_bug.cgi?id=150092
1010
1011         Reviewed by Lucas Forschler.
1012
1013         * QueueStatusServer/config/queues.py:
1014         * QueueStatusServer/model/queues.py:
1015         (Queue._capitalize_after_dash):
1016         (Queue._caplitalize_after_dash): Deleted.
1017         * Scripts/webkitpy/common/config/ews.json:
1018
1019 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
1020
1021         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
1022         https://bugs.webkit.org/show_bug.cgi?id=150085
1023
1024         Reviewed by Carlos Garcia Campos.
1025
1026         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1027
1028 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
1029
1030         Unreviewed, add myself to the committers list.
1031
1032         * Scripts/webkitpy/common/config/contributors.json:
1033
1034 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1035
1036         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
1037         https://bugs.webkit.org/show_bug.cgi?id=149983
1038
1039         Reviewed by Dan Bates.
1040
1041         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1042         (BubbleQueueServer):
1043         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1044
1045 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1046
1047         Fix webkitpy tests after r190922.
1048
1049         * Scripts/webkitpy/common/config/ews.json:
1050         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1051         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1052
1053 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1054
1055         Add a Mac debug EWS queue
1056         https://bugs.webkit.org/show_bug.cgi?id=150069
1057
1058         Reviewed by Geoffrey Garen.
1059
1060         * QueueStatusServer/config/queues.py:
1061         * Scripts/webkitpy/common/config/ews.json:
1062         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1063         (AbstractEarlyWarningSystem):
1064         (AbstractEarlyWarningSystem.archive_last_test_results):
1065         (AbstractEarlyWarningSystem.build_style):
1066         (AbstractEarlyWarningSystem.refetch_patch):
1067         (AbstractEarlyWarningSystem.load_ews_classes):
1068
1069 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1070
1071         [GTK] Update jhbuild's version of harfbuzz
1072         https://bugs.webkit.org/show_bug.cgi?id=149749
1073
1074         Reviewed by Martin Robinson.
1075
1076         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
1077
1078         * gtk/jhbuild.modules: Updated details for harfbuzz.
1079
1080 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1081
1082         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
1083         https://bugs.webkit.org/show_bug.cgi?id=150026
1084
1085         Reviewed by Philippe Normand.
1086
1087         Backport upstream patch from gst-plugins-bad so that the right version
1088         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
1089         gets compiled properly, avoiding crashes on runtime while running tests.
1090
1091         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
1092         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
1093
1094 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
1095
1096         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
1097         https://bugs.webkit.org/show_bug.cgi?id=149777
1098
1099         Reviewed by Simon Fraser.
1100
1101         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
1102         to the list of tests to preinstall at startup time.
1103
1104         Also, update the generation of the 'name' table in the FontWithFeatures font.
1105
1106         * DumpRenderTree/mac/DumpRenderTree.mm:
1107         (allowedFontFamilySet):
1108         (activateTestingFonts):
1109         (activateFontsIOS):
1110         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1111         (Generator::generate):
1112         (Generator::appendCFFTable):
1113         (Generator::appendNameSubtable):
1114         (Generator::appendNAMETable):
1115         * FontWithFeatures/FontWithFeatures/main.cpp:
1116         (main):
1117         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1118         (WTR::allowedFontFamilySet):
1119         (WTR::activateFonts):
1120         * WebKitTestRunner/mac/TestControllerMac.mm:
1121         (WTR::allowedFontFamilySet):
1122
1123 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
1124
1125         Unreviewed. Add Jinyoung Hur as a committer. 
1126
1127         * Scripts/webkitpy/common/config/contributors.json:
1128
1129 2015-10-10  Dan Bernstein  <mitz@apple.com>
1130
1131         [iOS] Remove unnecessary iOS version checks
1132         https://bugs.webkit.org/show_bug.cgi?id=150002
1133
1134         Reviewed by Alexey Proskuryakov.
1135
1136         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1137         (-[HIDEventGenerator _createIOHIDEventType:]):
1138         (-[HIDEventGenerator _sendHIDEvent:]):
1139         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1140         * WebKitTestRunner/ios/UIKitSPI.h:
1141
1142 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
1143
1144         Unreviewed, rolling out r190689
1145         https://bugs.webkit.org/show_bug.cgi?id=149992
1146
1147         Fixed in other repository.
1148
1149         Reverted changesets:
1150
1151         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
1152         https://bugs.webkit.org/show_bug.cgi?id=149897
1153
1154 2015-10-09  Brian Burg  <bburg@apple.com>
1155
1156         Teach webkitperl how to figure out IOS versions from the SDK
1157         https://bugs.webkit.org/show_bug.cgi?id=149963
1158
1159         Reviewed by Daniel Bates.
1160
1161         It should be easier to check the major and minor version of IOS SDKs.
1162
1163         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
1164         * Scripts/webkitdirs.pm:
1165         (splitVersionString): Added.
1166         (determineOSXVersion): Use splitVersionString.
1167         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
1168         (iosVersion): Added.
1169
1170 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
1171
1172         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
1173         https://bugs.webkit.org/show_bug.cgi?id=149960
1174
1175         Reviewed by Tim Horton.
1176         
1177         Use adoptWK(), and null out some members (file is not using ARC).
1178
1179         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1180         (UIScriptContext::uiScriptComplete):
1181         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1182         (-[TestRunnerWKWebView dealloc]):
1183
1184 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1185
1186         Remove ENABLE_SUID_SANDBOX_LINUX cruft
1187         https://bugs.webkit.org/show_bug.cgi?id=149954
1188
1189         Reviewed by Darin Adler.
1190
1191         * Scripts/webkitperl/FeatureList.pm:
1192
1193 2015-10-09  Daniel Bates  <dabates@apple.com>
1194
1195         Make iOS builders generate debug information in a separate dSYM file
1196         https://bugs.webkit.org/show_bug.cgi?id=149696
1197
1198         Reviewed by Darin Adler.
1199
1200         Similar to the Mac builders, the iOS builders should write debug information
1201         into a separate dSYM file instead of including such information in the binary
1202         itself (default Xcode behavior)
1203
1204         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1205         (CompileWebKit.start):
1206
1207 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1208
1209         Fix webkitpy tests after r190779
1210         https://bugs.webkit.org/show_bug.cgi?id=149949
1211
1212         Reviewed by Ryosuke Niwa.
1213
1214         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1215         (BenchmarkResults.format):
1216         (BenchmarkResults._format_values):
1217
1218 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
1219
1220         Extend run-benchmark script to support human-readable results conversion.
1221         https://bugs.webkit.org/show_bug.cgi?id=149944
1222
1223         Reviewed by Ryosuke Niwa.
1224
1225         Add '--read-results-json' and '--no-adjust-unit' options.
1226         '--read-results-json' option converts result file to human readable format.
1227         '--no-adjust-unit' option skips scientific notation convertion.
1228         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
1229
1230         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1231         (BenchmarkResults.format):
1232         (BenchmarkResults._format_tests):
1233         (BenchmarkResults._format_values):
1234         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1235         (BenchmarkRunner.__init__):
1236         (BenchmarkRunner._run_benchmark):
1237         (BenchmarkRunner._dump):
1238         (BenchmarkRunner.show_results):
1239         (BenchmarkRunner._show_results): Deleted.
1240         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1241         (parse_args):
1242         (start):
1243
1244 2015-10-08  Daniel Bates  <dabates@apple.com>
1245
1246         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
1247         https://bugs.webkit.org/show_bug.cgi?id=149945
1248
1249         Reviewed by Dan Bernstein.
1250
1251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
1252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
1253         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1255         (WebKitBuildbot):
1256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1257         (table.queue-grid tr.platform.ios-9 img.logo):
1258
1259 2015-10-08  Daniel Bates  <dabates@apple.com>
1260
1261         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
1262         https://bugs.webkit.org/show_bug.cgi?id=149943
1263
1264         Reviewed by Dan Bernstein.
1265
1266         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
1267         teach build-webkit to install them when building for iOS device using the public iOS SDK. 
1268
1269         * Scripts/build-webkit:
1270
1271 2015-10-08  Daniel Bates  <dabates@apple.com>
1272
1273         Add LLVM binaries for iOS 9 device
1274         https://bugs.webkit.org/show_bug.cgi?id=149913
1275
1276         Reviewed by Filip Pizlo.
1277
1278         Implement support for building LLVM for ARM64-based iOS devices.
1279
1280         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
1281         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
1282         an existing build earlier in the file such that remove previously built
1283         libraries before building/copying new ones (if applicable).
1284         (fileContains): Moved function outside of if-block.
1285         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
1286         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
1287         added logic to build LLVM for ARM64-based iOS devices.
1288         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
1289         LLVM into the WebKitBuild directory.
1290
1291 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
1292
1293         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
1294         https://bugs.webkit.org/show_bug.cgi?id=149848
1295
1296         Reviewed by Darin Adler.
1297
1298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1299
1300 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
1301
1302         [Win] Support 64-bit Build and Testing
1303         https://bugs.webkit.org/show_bug.cgi?id=149904
1304
1305         Reviewed by Daniel Bates.
1306
1307         Extend our existing scripts to support 64-bit build and test operations on
1308         Windows.
1309
1310         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
1311         Windows always builds the whole stack.
1312         * Scripts/webkit-build-directory: Add an option to return the location of
1313         the executable files produced by a specific configuration. This change is
1314         actually useful for Gtk and EFL, too.
1315         * Scripts/webkitdirs.pm:
1316         (executableProductDir): Added. This function appends the proper binary
1317         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
1318         (jscProductDir): Use the new 'executableProductDir' method.
1319         (setPathForRunningWebKitApp): Ditto.
1320         (runSafari): Ditto.
1321         (runMiniBrowser): Ditto.
1322         * Scripts/webkitpy/port/factory.py:
1323         (configuration_options): Add a 64-bit option, used on Windows to specify
1324         which binary target should be used for testing.
1325         * Scripts/webkitpy/port/win.py:
1326         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
1327         processes when needed.
1328         (WinPort._build_path): Add the correct binary target path to _build_path.
1329         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
1330         64-bit paths for 64-bit tests.
1331         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
1332         NTSD debugger does not understand this argument.
1333
1334 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
1335
1336         Test font-variant-* and font-feature-settings with TrueType fonts
1337         https://bugs.webkit.org/show_bug.cgi?id=149776
1338
1339         Reviewed by Simon Fraser.
1340
1341         This test extends our existing FontWithFeatures project to be able to generate a
1342         TrueType font. This font is conceptually similar as the existing OpenType font,
1343         except the feature -> character mapping is different.
1344
1345         The font itself only supports the following characters:
1346         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1347         However, the shape of these letters are either an X or a check mark.
1348         The letter "A" always is a check mark.
1349         The letter "B" always is an X.
1350         Each font feature has an letter associated with it. When the font feature is enabled,
1351         that letter is shown as a check mark. For example, when
1352         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
1353         mark.
1354
1355         Here are the mappings of font features to letters:
1356         kLigaturesType / kCommonLigaturesOnSelector: C
1357         kLigaturesType / kContextualLigaturesOnSelector: D
1358         kLigaturesType / kRareLigaturesOnSelector: G
1359         kLigaturesType / kHistoricalLigaturesOnSelector: I
1360         kContextualAlternatesType / kContextualAlternatesOnSelector: L
1361         kVerticalPositionType / kInferiorsSelector: O
1362         kVerticalPositionType / kSuperiorsSelector: P
1363         kLowerCaseType / kLowerCaseSmallCapsSelector: S
1364         kUpperCaseType / kUpperCaseSmallCapsSelector: V
1365         kLowerCaseType / kLowerCasePetiteCapsSelector: T
1366         kUpperCaseType / kUpperCasePetiteCapsSelector: W
1367         kLetterCaseType / 14: Y
1368         kStyleOptionsType / kTitlingCapsSelector: a
1369         kNumberCaseType / kUpperCaseNumbersSelector: c
1370         kNumberCaseType / kLowerCaseNumbersSelector: d
1371         kNumberSpacingType / kProportionalNumbersSelector: f
1372         kNumberSpacingType / kMonospacedNumbersSelector: g
1373         kFractionsType / kDiagonalFractionsSelector: i
1374         kFractionsType / kVerticalFractionsSelector: j
1375         kVerticalPositionType / kOrdinalsSelector: Q
1376         kTypographicExtrasType / kSlashedZeroOnSelector: k
1377         kLigaturesType / kHistoricalLigaturesOnSelector: K
1378         kCharacterShapeType / kJIS1978CharactersSelector: m
1379         kCharacterShapeType / kJIS1983CharactersSelector: n
1380         kCharacterShapeType / kJIS1990CharactersSelector: o
1381         kCharacterShapeType / kJIS2004CharactersSelector: p
1382         kCharacterShapeType / kSimplifiedCharactersSelector: q
1383         kCharacterShapeType / kTraditionalCharactersSelector: r
1384         kTextSpacingType / kMonospacedTextSelector: t
1385         kTextSpacingType / kProportionalTextSelector: u
1386         kRubyKanaType / kRubyKanaOnSelector: v
1387
1388         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1389         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1390         (CFFBuilder::moveTo):
1391         (CFFBuilder::lineTo):
1392         (GLYFBuilder::GLYFBuilder):
1393         (GLYFBuilder::takeResult):
1394         (GLYFBuilder::moveTo):
1395         (GLYFBuilder::lineTo):
1396         (GLYFBuilder::closePath):
1397         (GLYFBuilder::writePoint):
1398         (GLYFBuilder::append16):
1399         (generateBoxCharString):
1400         (generateCheckCharString):
1401         (generateXCharString):
1402         (itemForGlyph):
1403         (Generator::generate):
1404         (Generator::insertSelector):
1405         (Generator::insertFeature):
1406         (Generator::generateFeatureDescription):
1407         (Generator::appendCFFTable):
1408         (Generator::appendGLYFTable):
1409         (Generator::appendLOCATable):
1410         (Generator::appendFEATTable):
1411         (Generator::appendMetamorphosisChain):
1412         (Generator::appendMORXTable):
1413         (Generator::appendHEADTable):
1414         (Generator::appendHMTXTable):
1415         (Generator::appendNameSubtable):
1416         (Generator::append2ByteASCIIString):
1417         (Generator::appendNAMETable):
1418         (generateFont):
1419         (CFFBuilder::curveToCubic): Deleted.
1420         (charStringForGlyph): Deleted.
1421         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1422         * FontWithFeatures/FontWithFeatures/main.cpp:
1423         (constructFontWithTrueTypeFeature):
1424         (constructFontWithOpenTypeFeature):
1425         (drawText):
1426         (main):
1427         (drawTextWithFeature): Deleted.
1428
1429 2015-10-07  Commit Queue  <commit-queue@webkit.org>
1430
1431         Unreviewed, rolling out r190572, r190593, r190594, and
1432         r190639.
1433         https://bugs.webkit.org/show_bug.cgi?id=149897
1434
1435         Breaks Mavericks build (Requested by litherum on #webkit).
1436
1437         Reverted changesets:
1438
1439         "Allow WKRetainPtrs to be used as keys in hashing data
1440         structures"
1441         https://bugs.webkit.org/show_bug.cgi?id=149762
1442         http://trac.webkit.org/changeset/190572
1443
1444         "REGRESSION(189668?): http/tests/notifications/events.html
1445         flakily asserts or times out"
1446         https://bugs.webkit.org/show_bug.cgi?id=149218
1447         http://trac.webkit.org/changeset/190593
1448
1449         "Prospective Mavericks build fix."
1450         http://trac.webkit.org/changeset/190594
1451
1452         "Post-review cleanup after r190572."
1453         http://trac.webkit.org/changeset/190639
1454
1455 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1456
1457         [GTK] Add autocleanups
1458         https://bugs.webkit.org/show_bug.cgi?id=149588
1459
1460         Reviewed by Darin Adler.
1461
1462         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
1463         (AutocleanupsTest::create):
1464         (AutocleanupsTest::testWebProcessAutocleanups):
1465         (registerTests):
1466         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1467         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
1468         (testUIProcessAutocleanups):
1469         (testWebProcessAutocleanups):
1470         (beforeAll):
1471         (afterAll):
1472
1473 2015-10-06  Brian Burg  <bburg@apple.com>
1474
1475         Unreviewed, try to fix the iOS 8 build after r190368.
1476
1477         On older versions, IOHIDEventCreateForceEvent is not available.
1478
1479         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1480         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
1481
1482 2015-10-06  Keith Miller  <keith_miller@apple.com>
1483
1484         Add gmalloc option to run-javascriptcore-tests.
1485         https://bugs.webkit.org/show_bug.cgi?id=149858
1486
1487         Reviewed by Geoffrey Garen.
1488
1489         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
1490         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
1491
1492         * Scripts/run-javascriptcore-tests:
1493
1494 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
1495
1496         Post-review cleanup after r190572.
1497
1498         Unreviewed.
1499
1500         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
1501
1502 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
1503
1504         [Win] Unreviewed build correction.
1505
1506         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
1507         are soft-linked at runtime.
1508
1509 2015-10-06  Keith Miller  <keith_miller@apple.com>
1510
1511         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
1512         https://bugs.webkit.org/show_bug.cgi?id=149815
1513
1514         Reviewed by Filip Pizlo.
1515
1516         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
1517         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
1518         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
1519         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
1520         so should just use one test runner.
1521
1522         * Scripts/run-javascriptcore-tests:
1523         (runJSCStressTests):
1524         (runMozillaTests): Deleted.
1525         (defaultJsDriverArgsForMozillaTests): Deleted.
1526         * Scripts/run-jsc-stress-tests:
1527
1528 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
1529
1530         [GTK] Make update-webkitgtk-libs work behind firewall
1531
1532         update-webkitgtk-libs can work behind a firewall with changes to
1533         a few packages.  Where outbound git and active FTP connections
1534         fail, using http protocol succeeds.  Most packages are
1535         already accessed using http.
1536
1537         https://bugs.webkit.org/show_bug.cgi?id=148941
1538
1539         Reviewed by Martin Robinson.
1540
1541         Tools
1542         * gtk/jhbuild.modules:
1543             Replace git URLs with http.  Remove no longer used ftp repositories.
1544             Update argument for libxml2's autogen.sh script (--without-python
1545             is ignored; --with-python=no is correct).
1546         * jhbuild/jhbuild-wrapper:
1547             Instead of connecting to git://git.gnome.org/jhbuild, connect to
1548             http://git.gnome.org/browse/jhbuild.
1549
1550 2015-10-06  Daniel Bates  <dbates@webkit.org>
1551
1552         Enable XSLT when building WebKit for iOS using the public iOS SDK
1553         https://bugs.webkit.org/show_bug.cgi?id=149827
1554
1555         Reviewed by Alexey Proskuryakov.
1556
1557         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1558         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1559         run this script before building WebKit for iOS or the build will fail because one or more XSLT
1560         headers cannot be found.
1561
1562         * Scripts/configure-xcode-for-ios-development:
1563         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1564
1565 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1566
1567         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1568         https://bugs.webkit.org/show_bug.cgi?id=149218
1569
1570         Reviewed by Alexey Proskuryakov.
1571
1572         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1573         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1574         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1575         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1576         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1577         WebNotificationProvider must be updated to appropriately handle multiple
1578         WKNotificationManagerRefs in flight at the same time.
1579
1580         * WebKitTestRunner/WebNotificationProvider.cpp:
1581         (WTR::WebNotificationProvider::~WebNotificationProvider):
1582         (WTR::WebNotificationProvider::showWebNotification):
1583         (WTR::WebNotificationProvider::closeWebNotification):
1584         (WTR::WebNotificationProvider::addNotificationManager):
1585         (WTR::WebNotificationProvider::removeNotificationManager):
1586         (WTR::WebNotificationProvider::simulateWebNotificationClick):
1587         (WTR::WebNotificationProvider::reset):
1588         * WebKitTestRunner/WebNotificationProvider.h:
1589
1590 2015-10-05  Daniel Bates  <dabates@apple.com>
1591
1592         Disable Bitcode when building for iOS device
1593         https://bugs.webkit.org/show_bug.cgi?id=149818
1594
1595         Reviewed by Alexey Proskuryakov.
1596
1597         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1598         when building for iOS device.
1599
1600         * Scripts/webkitdirs.pm:
1601         (XcodeOptions):
1602
1603 2015-10-05  Daniel Bates  <dabates@apple.com>
1604
1605         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1606         https://bugs.webkit.org/show_bug.cgi?id=140828
1607         <rdar://problem/19520599>
1608
1609         Reviewed by Alexey Proskuryakov.
1610
1611         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1612         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1613         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1614         to build-webkit.
1615
1616         * Scripts/webkitdirs.pm:
1617         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1618         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1619         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1620         (hasIOSDevelopmentCertificate): Added.
1621
1622 2015-10-05  Daniel Bates  <dabates@apple.com>
1623
1624         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1625         https://bugs.webkit.org/show_bug.cgi?id=149766
1626
1627         Reviewed by Alexey Proskuryakov.
1628
1629         Create network storage testing session on iOS.
1630
1631         Currently we do not create a network storage testing session on iOS. A network storage testing session always
1632         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1633         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1634         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1635         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1636         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1637         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1638         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1639         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1640
1641         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1642         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1643         returns a non-null pointer to a cookie store.
1644
1645         * DumpRenderTree/mac/DumpRenderTree.mm:
1646         (prepareConsistentTestingEnvironment):
1647
1648 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1649
1650         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1651         available.
1652
1653         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1654         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1655
1656 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1657
1658         Allow WKRetainPtrs to be used as keys in hashing data structures
1659         https://bugs.webkit.org/show_bug.cgi?id=149762
1660
1661         Reviewed by Anders Carlsson.
1662
1663         * TestWebKitAPI/PlatformGTK.cmake:
1664         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1665         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1666         (TestWebKitAPI::TEST):
1667
1668 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1669
1670         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1671         available, and tidy up the #ifdefs in the UIKitSPI header.
1672
1673         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1674         (-[HIDEventGenerator _sendHIDEvent:]):
1675         * WebKitTestRunner/ios/UIKitSPI.h:
1676
1677 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
1678
1679         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1680         https://bugs.webkit.org/show_bug.cgi?id=149792
1681
1682         Reviewed by Martin Robinson.
1683
1684         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1685         for WebKitTestRunner multiple times.
1686
1687 2015-10-04  Daniel Bates  <dabates@apple.com>
1688
1689         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1690         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1691
1692         For now, support calling build-layouttestrelay without --ios-simulator so long
1693         as we are building on a Mac.
1694
1695         * Scripts/build-layouttestrelay:
1696
1697 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1698
1699         Support Trac 1.0.x XML timeline link format
1700         https://bugs.webkit.org/show_bug.cgi?id=149786
1701
1702         Reviewed by Lucas Forschler.
1703
1704         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1705         (Trac.prototype._convertCommitInfoElementToObject):
1706
1707 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1708
1709         Fix some errors on bot watcher's dashboard
1710         https://bugs.webkit.org/show_bug.cgi?id=149789
1711
1712         Reviewed by Lucas Forschler.
1713
1714         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1715         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
1716         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
1717
1718 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1719
1720         Bot watcher's dashboard builders should turn yellow when svn fails
1721         https://bugs.webkit.org/show_bug.cgi?id=149791
1722
1723         Reviewed by Lucas Forschler.
1724
1725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1726         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
1727         (BuildbotBuilderQueueView.prototype.update):
1728
1729 2015-10-02  Daniel Bates  <dabates@apple.com>
1730
1731         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
1732         https://bugs.webkit.org/show_bug.cgi?id=149769
1733
1734         Reviewed by Alexey Proskuryakov.
1735
1736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
1737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
1738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1740         (WebKitBuildbot):
1741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1742         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
1743
1744 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1745
1746         REGRESSION(r190370): Speedometer spits out an extra console message
1747         https://bugs.webkit.org/show_bug.cgi?id=149720
1748
1749         Unreviewed. Temporarily ignore the console error message.
1750
1751         * Scripts/webkitpy/performance_tests/perftest.py:
1752         (PerfTest._filter_output):
1753
1754 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1755
1756         Provide "--no-ninja" option to avoid using Ninja
1757         https://bugs.webkit.org/show_bug.cgi?id=149757
1758
1759         Reviewed by Alex Christensen.
1760
1761         Add a new command line argument understood by webkitdirs.pm so
1762         that we can conditionally avoid using Ninja. This is an
1763         'opt-out' argument, so no existing Ninja users should be affected.
1764         
1765         * Scripts/webkitdirs.pm:
1766         (canUseNinja): Check for option and block ninja if present.
1767
1768 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
1769
1770         Flakiness dashboard should support OS X El Capitan
1771         https://bugs.webkit.org/show_bug.cgi?id=149648
1772
1773         Reviewed by Alexey Proskuryakov.
1774
1775         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
1776
1777 2015-10-02  Daniel Bates  <dabates@apple.com>
1778
1779         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
1780         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1781
1782         For now, pass --ios-simulator.
1783
1784         * Scripts/webkitpy/port/ios.py:
1785         (IOSSimulatorPort._build_relay):
1786
1787 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
1788
1789         Remove a "nullable" that breaks the iOS 8 build.
1790
1791         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1792         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
1793
1794 2015-10-02  Daniel Bates  <dabates@apple.com>
1795
1796         LayoutTestRelay is not built and archived when building for iOS Simulator
1797         https://bugs.webkit.org/show_bug.cgi?id=149753
1798
1799         Reviewed by Alexey Proskuryakov and Andy Estes.
1800
1801         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
1802         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
1803         product archive when building for iOS Simulator, respectively.
1804
1805         * BuildSlaveSupport/built-product-archive:
1806         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
1807         differentiate between iOS device and iOS Simulator platforms.
1808         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
1809         from determineWebKitBuildDirectories() into this function so that it can be used by both
1810         determineWebKitBuildDirectories() and archiveBuiltProduct().
1811         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
1812         webkitBuildDirectoryForConfigurationAndPlatform().
1813         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
1814         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
1815         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
1816         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
1817         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
1818         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
1819         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
1820         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
1821         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
1822         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
1823         * Scripts/build-layouttestrelay:
1824             - Remove unnecessary include of Perl module POSIX.
1825             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
1826         * Scripts/build-webkit:
1827             - Invoke script build-layouttestrelay when building for iOS Simulator.
1828
1829 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1830
1831         [Win] Unreviewed test fix.
1832
1833         You cannot run 'run-webkit-tests' from the command line because it does not know
1834         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
1835         because they explicitly set use the 'root' argument to provide the full path to
1836         the test binaries.
1837
1838         * Scripts/webkitpy/port/win.py:
1839         (WinPort._build_path): Added.
1840
1841 2015-10-02  Alex Christensen  <achristensen@webkit.org>
1842
1843         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
1844         https://bugs.webkit.org/show_bug.cgi?id=149430
1845         rdar://problem/22742222
1846
1847         Reviewed by Geoffrey Garen.
1848
1849         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1850         (WTR::TestController::cocoaResetStateToConsistentValues):
1851         * WebKitTestRunner/mac/TestControllerMac.mm:
1852         (WTR::TestController::platformConfigureViewForTest):
1853         Test what happens when you disable content blockers from the SPI.
1854
1855 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1856
1857         [Win] Unreviewed build fix for run-api-tests
1858
1859         * Scripts/run-api-tests:
1860         (testToolPaths): Windows run needs to specify the binary path.
1861
1862 2015-10-01  Daniel Bates  <dabates@apple.com>
1863
1864         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
1865         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1866
1867         Following r190424 we can now rely on webkit-build-directory to return the path to
1868         the correct configuration-specific build directory on Windows.
1869
1870         * BuildSlaveSupport/built-product-archive:
1871         (archiveBuiltProduct):
1872
1873 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1874
1875         [Win] Unreviewed build fix.
1876
1877         * Scripts/webkitdirs.pm:
1878         (setupAppleWinEnv): Use 64-bit build tools if available
1879
1880 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1881
1882         [Win] Fix TestWebKitAPI build under CMake.
1883
1884         Reviewed by Alex Christensen.
1885
1886         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
1887         for Psapi.lib.
1888
1889 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1890
1891         [Win] Fix behavior of webkit-build-directory script
1892         https://bugs.webkit.org/show_bug.cgi?id=149718
1893
1894         Reviewed by Alex Christensen.
1895
1896         * Scripts/webkitdirs.pm:
1897         (determineConfigurationProductDir): Do not include the binary
1898         sub-directory in the configuration product directory output.
1899         (jscProductDir): Append correct binary path for Windows build.
1900         (setPathForRunningWebKitApp): Include properly binary subdirectories.
1901         (runSafari): Update for revised productDir behavior.
1902         (runMiniBrowser): Ditto.
1903
1904 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1905
1906         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
1907         use iOS SDK, like with all the others.
1908
1909         * Scripts/build-webkit:
1910
1911 2015-10-01  Daniel Bates  <dabates@apple.com>
1912
1913         Attempt to fix the iOS 9 Simulator testers
1914
1915         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
1916         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
1917         LayoutTestRelay when building for iOS Simulator.
1918
1919         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1920         * Scripts/build-webkit:
1921
1922 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1923
1924         [GTK] Websites with invalid auth header keep loading forever
1925         https://bugs.webkit.org/show_bug.cgi?id=149710
1926
1927         Reviewed by Martin Robinson.
1928
1929         Add test case to check that we can authenticate sites with an
1930         empty realm.
1931
1932         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1933         (testWebViewAuthenticationEmptyRealm):
1934         (serverCallback):
1935         (beforeAll):
1936
1937 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1938
1939         [Mac] Make run-api-tests work with System Integrity Protection
1940         https://bugs.webkit.org/show_bug.cgi?id=149711
1941         rdar://problem/22928202
1942
1943         Reviewed by Dan Bernstein.
1944
1945         * Scripts/run-api-tests:
1946         (runTest):
1947         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
1948
1949 2015-10-01  Daniel Bates  <dabates@apple.com>
1950
1951         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
1952         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1953
1954         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
1955         For now, use the path to the top-level WebKit build directory instead of using the configuration-
1956         specific build directory.
1957
1958         * BuildSlaveSupport/built-product-archive:
1959         (archiveBuiltProduct):
1960
1961 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1962
1963         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
1964         https://bugs.webkit.org/show_bug.cgi?id=145837
1965
1966         Reviewed by Philippe Normand.
1967
1968         * efl/jhbuild.modules:
1969         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
1970         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
1971
1972 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1973
1974         Unreviewed. Fix the iOS build after r190407.
1975
1976         * WebKitTestRunner/ios/IOKitSPI.h:
1977
1978 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1979
1980         Implement keyboard event sending for iOS in WebKitTestRunner
1981         https://bugs.webkit.org/show_bug.cgi?id=149676
1982
1983         Reviewed by Simon Fraser.
1984
1985         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
1986         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
1987         allows us to run code when the keyboard is shown or hidden.
1988
1989         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
1990         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1991         (WTR::UIScriptController::setDidShowKeyboardCallback):
1992         (WTR::UIScriptController::didShowKeyboardCallback):
1993         (WTR::UIScriptController::setDidHideKeyboardCallback):
1994         (WTR::UIScriptController::didHideKeyboardCallback):
1995         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1996         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1997         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1998         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1999         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2000         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2001         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
2002                 the notifications that the keyboard has been raised or lowered.
2003         (-[TestRunnerWKWebView _keyboardDidShow:]):
2004         (-[TestRunnerWKWebView _keyboardDidHide:]):
2005         * WebKitTestRunner/ios/HIDEventGenerator.h:
2006         * WebKitTestRunner/ios/HIDEventGenerator.m:
2007         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
2008         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
2009         (hidUsageCodeForCharacter): Ditto.
2010         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
2011                 a keyDown event in WebKit.
2012         * WebKitTestRunner/ios/IOKitSPI.h:
2013         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2014
2015 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2016
2017         Unreviewed, rolling out r190399.
2018
2019         Tests are still failing even after r190362
2020
2021         Reverted changeset:
2022
2023         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
2024         http://trac.webkit.org/changeset/190399
2025
2026 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2027
2028         [jhbuild] switch to new upstream usrsctp library
2029         https://bugs.webkit.org/show_bug.cgi?id=149494
2030
2031         Reviewed by Philippe Normand.
2032
2033         * efl/jhbuild.modules:
2034         * gtk/jhbuild.modules:
2035
2036 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2037
2038         Unreviewed. Unskip GTK+ user media unit tests after r190362.
2039
2040         They should pass now.
2041
2042         * Scripts/run-gtk-tests:
2043         (TestRunner):
2044
2045 2015-09-30  Daniel Bates  <dabates@apple.com>
2046
2047         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2048         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2049
2050         * BuildSlaveSupport/built-product-archive:
2051         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
2052         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
2053
2054 2015-09-30  Daniel Bates  <dabates@apple.com>
2055
2056         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2057         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2058
2059         Actually, we need to pass --configuration to script webkit-build-directory to have
2060         it return the path to the configuration-specific build directory.
2061
2062         * BuildSlaveSupport/built-product-archive:
2063         (determineWebKitBuildDirectories):
2064
2065 2015-09-30  Daniel Bates  <dabates@apple.com>
2066
2067         built-product-archive archives incorrect build directory for iOS port
2068         https://bugs.webkit.org/show_bug.cgi?id=149695
2069
2070         Reviewed by Darin Adler.
2071
2072         Fixes an issue where the script built-product-archive archives a non-existent
2073         build directory for the iOS port. Without loss of generality, the script assumes
2074         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
2075         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
2076
2077         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
2078         to determine the top-level build directory and computes the configuration-specific
2079         build directory to be the concatenation of the the top-level build directory and
2080         the configuration (e.g. Release). This is incorrect. Instead we should call
2081         webkit-build-directory omitting the flag --top-level to compute the path to the
2082         configuration-specific build directory.
2083
2084         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
2085         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
2086         its purpose and added global variable _configurationBuildDirectory to store the path
2087         to the configuration-specific build directory. Ensure that we have a non-empty string
2088         for both the top-level and configuration-specific build directories.
2089         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
2090         Compute the configuration-specific build directory and store it in the global variable
2091         _configurationBuildDirectory.
2092         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
2093         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
2094         as needed.
2095         (determineWebKitBuildDirectory): Deleted.
2096
2097 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
2098
2099         [EFL] css3/device-adapt/* tests failed after r190335.
2100         https://bugs.webkit.org/show_bug.cgi?id=149655
2101
2102         Reviewed by Simon Fraser.
2103
2104         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2105         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
2106
2107         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2108         (WTR::shouldUseFixedLayout):
2109
2110 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
2111
2112         Extend JetStream timeout for slow devices.
2113
2114         Reviewed by Chris Dumez.
2115
2116         Extend JetStream timeout to 20 minutes.
2117
2118         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2119
2120 2015-09-30  Daniel Bates  <dabates@apple.com>
2121
2122         Rename iOS builders/testers to include version
2123         https://bugs.webkit.org/show_bug.cgi?id=149685
2124
2125         Reviewed by Simon Fraser.
2126
2127         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
2128         make it clear to a reader the version of iOS these builders/testers are using.
2129
2130         * BuildSlaveSupport/build.webkit.org-config/config.json:
2131         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2132
2133 2015-09-30  Daniel Bates  <dabates@apple.com>
2134
2135         Add iOS criterion for triggering a build
2136         https://bugs.webkit.org/show_bug.cgi?id=149679
2137
2138         Rubber-stamped by Alexey Proskuryakov.
2139
2140         First pass at defining criterion for triggering an iOS build.
2141
2142         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2143         (_should_file_trigger_build):
2144         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2145         (ShouldBuildTest):
2146         (ShouldBuildTest.test_should_build):
2147
2148 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2149
2150         [iOS] Allow tests to generate user gestures for UI testing
2151         https://bugs.webkit.org/show_bug.cgi?id=149653
2152
2153         Reviewed by Tim Horton.
2154
2155         Expose functionality in UIScriptController to allow for testing single- and double-tap,
2156         and to listen for completion of scrolling and zooming in the WKWebView.
2157         
2158         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
2159         which hides the complexity of creating these events. Event dispatch is asynchronous.
2160         We detect when the last event has been handled by dispatching a vendor-specific event,
2161         which is detected via -_handleHIDEvent: in our UIApplication subclass.
2162         
2163         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
2164         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
2165         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
2166         single and double taps.
2167         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2168         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
2169         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
2170         (UIScriptContext::unregisterCallback):
2171         (UIScriptContext::callbackWithID):
2172         (UIScriptContext::fireCallback):
2173         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
2174         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2175         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
2176         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
2177         (WTR::UIScriptController::setDidEndZoomingCallback):
2178         (WTR::UIScriptController::didEndZoomingCallback):
2179         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
2180         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
2181         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2182         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2183         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2184         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2185         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
2186         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2187         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
2188         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
2189         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
2190         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
2191         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2192         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
2193         (simpleDragCurve):
2194         (calculateNextLocation):
2195         (delayBetweenMove):
2196         (+[HIDEventGenerator sharedHIDEventGenerator]):
2197         (+[HIDEventGenerator nextEventCallbackID]):
2198         (-[HIDEventGenerator init]):
2199         (-[HIDEventGenerator _createIOHIDEventType:]):
2200         (-[HIDEventGenerator _sendHIDEvent:]):
2201         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2202         (-[HIDEventGenerator _updateTouchPoints:count:]):
2203         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
2204         (-[HIDEventGenerator touchDown:touchCount:]):
2205         (-[HIDEventGenerator touchDown:]):
2206         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
2207         (-[HIDEventGenerator liftUp:touchCount:]):
2208         (-[HIDEventGenerator liftUp:]):
2209         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
2210         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2211         (-[HIDEventGenerator tap:completionBlock:]):
2212         (-[HIDEventGenerator doubleTap:completionBlock:]):
2213         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
2214         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2215         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
2216         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
2217         (-[HIDEventGenerator markerEventReceived:]):
2218         * WebKitTestRunner/ios/IOKitSPI.h: Added.
2219         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2220         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2221         (WTR::globalToContentCoordinates):
2222         (WTR::UIScriptController::singleTapAtPoint):
2223         (WTR::UIScriptController::doubleTapAtPoint):
2224         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2225         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2226         * WebKitTestRunner/ios/mainIOS.mm:
2227         (-[WebKitTestRunnerApp _handleHIDEvent:]):
2228
2229 2015-09-30  Dana Burkart  <dburkart@apple.com>
2230
2231         git-add-reviewer should trim trailing spaces/newlines
2232         https://bugs.webkit.org/show_bug.cgi?id=149513
2233
2234         Reviewed by Darin Adler.
2235
2236         * Scripts/git-add-reviewer:
2237         (nonInteractive):
2238
2239 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
2240
2241         REGRESSION(r190262): User media unit test failures after r190262
2242         https://bugs.webkit.org/show_bug.cgi?id=149580
2243
2244         Reviewed by Darin Adler.
2245
2246         * WebKitTestRunner/TestController.cpp:
2247         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
2248           order to WKUserMediaPermissionRequestAllow.
2249
2250 2015-09-30  Daniel Bates  <dabates@apple.com>
2251
2252         Add iOS builders and testers
2253         https://bugs.webkit.org/show_bug.cgi?id=149549
2254
2255         Reviewed by Alexey Proskuryakov.
2256
2257         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
2258         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
2259
2260         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
2261         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
2262
2263 2015-09-30  Timothy Hatcher  <timothy@apple.com>
2264
2265         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
2266         https://bugs.webkit.org/show_bug.cgi?id=149674
2267
2268         Reviewed by Lucas Forschler.
2269
2270         * WebKitLauncher/WebKitLauncher.entitlements: Added.
2271         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2272
2273 2015-09-30  Jason Marcell  <jmarcell@apple.com>
2274
2275         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
2276         have an associated trac instance.
2277         https://bugs.webkit.org/show_bug.cgi?id=149673
2278
2279         Reviewed by Alexey Proskuryakov.
2280
2281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2282         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
2283         have an associated trac instance.
2284
2285 2015-09-30  Daniel Bates  <dabates@apple.com>
2286
2287         Prioritize testing latest build request on iOS test bots
2288         https://bugs.webkit.org/show_bug.cgi?id=149669
2289
2290         Reviewed by Darin Adler.
2291
2292         We should prioritize testing of the latest build request on the iOS test bots
2293         as we do for Mac and Windows test bots.
2294
2295         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2296         (loadBuilderConfig):
2297
2298 2015-09-30  Daniel Bates  <dabates@apple.com>
2299
2300         Add buildbot category for iOS builders and testers
2301         https://bugs.webkit.org/show_bug.cgi?id=149667
2302
2303         Reviewed by Darin Adler.
2304
2305         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
2306         for iOS to the build.webkit.org home page.
2307
2308         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2309         (loadBuilderConfig):
2310         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2311
2312 2015-09-30  Daniel Bates  <dabates@apple.com>
2313
2314         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2315         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2316
2317         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
2318         in <http://trac.webkit.org/changeset/190351>.
2319
2320         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2321         (CompileWebKit.start):
2322
2323 2015-09-30  Daniel Bates  <dabates@apple.com>
2324
2325         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2326         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2327
2328         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
2329         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
2330
2331         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2332         (CompileWebKit.start):
2333
2334 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2335
2336         bot210 was configured for a queue instead of bot126.
2337         
2338         Unreviewed config.json fix.
2339         
2340         * BuildSlaveSupport/build.webkit.org-config/config.json:
2341
2342 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2343
2344         Bring El Capitan buildbot infrastructure online.
2345         https://bugs.webkit.org/show_bug.cgi?id=149605
2346         
2347         Reviewed by Darin Adler.
2348
2349         * BuildSlaveSupport/build.webkit.org-config/config.json:
2350
2351 2015-09-30  Tomas Popela  <tpopela@redhat.com>
2352
2353         [GTK] Deprecation warnings in DOMNodeTest
2354         https://bugs.webkit.org/show_bug.cgi?id=149663
2355
2356         After the webkit_dom_document_get_elements_by_tag_name deprecation we
2357         need to update the tests to use webkit_dom_document_query_selector_all
2358         to avoid compilation warnings.
2359
2360         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
2361         (the suggested replacement for the deprecated function).
2362
2363         Reviewed by Carlos Garcia Campos.
2364
2365         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2366         (WebKitDOMNodeTest::testTagNamesNodeList):
2367         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2368         (registerTests):
2369         (WebKitDOMNodeTest::testTagNames): Deleted.
2370         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2371         (prepareDOMForTagNamesTests):
2372         (testWebKitDOMNodeTagNamesNodeList):
2373         (testWebKitDOMNodeTagNamesHTMLCollection):
2374         (beforeAll):
2375         (testWebKitDOMNodeTagNames): Deleted.
2376
2377 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2378
2379         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
2380         https://bugs.webkit.org/show_bug.cgi?id=149650
2381
2382         Reviewed by Tim Horton.
2383         
2384         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
2385         looks at the file path, and not the custom options that come from file comments.
2386         
2387         Fix by computing TestOptions before making the TestInvocation, and setting them
2388         as const TestInvocation data. This meant changing various call sites to take
2389         the std::string pathOrURL, rather than the TestInvocation itself.
2390         
2391         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
2392
2393         * WebKitTestRunner/CMakeLists.txt:
2394         * WebKitTestRunner/TestController.cpp:
2395         (WTR::TestController::ensureViewSupportsOptionsForTest):
2396         (WTR::testPath):
2397         (WTR::createTestURL):
2398         (WTR::updateTestOptionsFromTestHeader):
2399         (WTR::TestController::testOptionsForTest):
2400         (WTR::TestController::updateWebViewSizeForTest):
2401         (WTR::TestController::updateWindowScaleForTest):
2402         (WTR::TestController::runTest):
2403         * WebKitTestRunner/TestController.h:
2404         * WebKitTestRunner/TestInvocation.cpp:
2405         (WTR::TestInvocation::TestInvocation):
2406         (WTR::TestInvocation::invoke):
2407         (WTR::createWKURL): Deleted.
2408         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
2409         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
2410         * WebKitTestRunner/TestInvocation.h:
2411         (WTR::TestInvocation::options):
2412         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2413         (WTR::pathContains):
2414         (WTR::shouldMakeViewportFlexible):
2415         (WTR::shouldUseFixedLayout):
2416         (WTR::isSVGTestPath):
2417         (WTR::isHiDPITestPath):
2418         (WTR::TestOptions::TestOptions):
2419         * WebKitTestRunner/TestOptions.h:
2420         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2421         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2422         (WTR::pathContains):
2423         (WTR::shouldUseFixedLayout):
2424         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2425         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2426         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2427         * WebKitTestRunner/ios/TestControllerIOS.mm:
2428         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2429         * WebKitTestRunner/mac/TestControllerMac.mm:
2430         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2431
2432 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
2433
2434         Flakiness dashboard should support OS X El Capitan
2435         https://bugs.webkit.org/show_bug.cgi?id=149648
2436
2437         Reviewed by Alexey Proskuryakov.
2438
2439         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
2440         difference between new appscale and old Google App Engine implementation.
2441         * TestResultServer/app.yaml: Same.
2442         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
2443
2444 2015-09-29  Daniel Bates  <dabates@apple.com>
2445
2446         configure-xcode-for-ios-development does not work with Xcode 7
2447         https://bugs.webkit.org/show_bug.cgi?id=149640
2448
2449         Reviewed by Alexey Proskuryakov.
2450
2451         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
2452         because it cannot find the Xcode specification files for iOS simulator and device. These
2453         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
2454         relevant definitions to the Xcode 7 specification files directly as opposed to creating
2455         new specification files with the added definitions (as we did in older versions of Xcode)
2456         in order for Xcode 7 to honor these definitions.
2457
2458         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
2459         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
2460         (updateXcode7SpecificationFile): Added.
2461         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
2462         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
2463         appropriate success message.
2464         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
2465         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
2466         (createXcodeSpecificationFromSpecificationAndId): Deleted.
2467
2468 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2469
2470         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
2471         https://bugs.webkit.org/show_bug.cgi?id=149639
2472
2473         Reviewed by Alex Christensen.
2474
2475         * Scripts/VCSUtils.pm:
2476         (exitStatus): Use 'isWindows()' method.
2477         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
2478         an error. This method could probably just go away.
2479         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
2480         always changing to Unix style. 
2481         (unixPath): Added. Needed so Windows can always show a Unix path in the
2482         ChangeLog file.
2483         (changeLogName): Work around the fact that 'getpwuid' is not available on
2484         a pure Windows build of Perl.
2485         * Scripts/prepare-ChangeLog:
2486         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
2487         path on Windows.
2488         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
2489         support using arrays for 'open' arguments.
2490         (resolveChangeLogsPath): Ditto.
2491         (resolveConflictedChangeLogs): Use new helper functions.
2492         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
2493         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
2494         quotes. Unix systems are happy either way.
2495         (statusCommand): Ditto.
2496         * Scripts/webkitdirs.pm:
2497         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
2498
2499 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2500
2501         [Win] Unreviewed 64-bit build fix after switch to CMake.
2502
2503         * Scripts/webkitdirs.pm:
2504         (determineIsWin64FromArchitecture): Added.
2505
2506 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2507
2508         printing does not use minimum page zoom factor
2509         https://bugs.webkit.org/show_bug.cgi?id=108507
2510
2511         Reviewed by Darin Adler.
2512
2513         WebKitTestRunner always takes the snapshots from the UI process
2514         (expect for IOS), so in the case of printing, the layout in the
2515         web view is not the expected one. When printing, we need to take
2516         the snapshot in the web process and ensure it's rendered with a
2517         PrintContext.
2518
2519         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2520         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2521         kWKSnapshotOptionsPrinting option to
2522         WKBundlePageCreateSnapshotWithOptions() when printing.
2523
2524 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2525
2526         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
2527         https://bugs.webkit.org/show_bug.cgi?id=149595
2528
2529         Reviewed by Tim Horton.
2530
2531         All ports except IOS implement
2532         PlatformWebView::windowSnapshotImage() to generate the snapshot
2533         for the pixel tests in the UI process. But we are still generating
2534         a snapshot for pixel tests in the Web process too, that is passed
2535         to the UI process but ignored.
2536         Whether a pixel result is needed or not, is only known by the web
2537         process depending on whether the test called dumpAsText with
2538         dumpPixels == true or not. Since the pixels are now dump in the UI
2539         process, we need to pass that information to the UI process when
2540         the test is done. For that we set a PixelResultIsPending bool
2541         parameter to the Done message, and we only add the PixelResult
2542         when UI process doesn't need to generate the pixels dump.
2543
2544         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2545         (WTR::InjectedBundle::didReceiveMessageToPage): Set
2546         m_pixelResultIsPending to false on reset.
2547         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2548         Done message, and set the PixelResult if m_pixelResultIsPending is false.
2549         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2550         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2551         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2552         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2553         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2554         port.
2555         * WebKitTestRunner/TestInvocation.cpp:
2556         (WTR::TestInvocation::dumpResults): Use either the pixel result
2557         from the web process or generate a pixel result from the web view
2558         if need it.
2559         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2560         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2561         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2562         is created by the caller now, but the CG implementation needs to
2563         know if it's a Web or UI process snapshot.
2564         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2565         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2566         cairo surface for the given image.
2567         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2568         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2569         CGContext for the given image.
2570
2571 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
2572
2573         Fix JS errors on dashboard metrics page
2574         https://bugs.webkit.org/show_bug.cgi?id=149608
2575
2576         Reviewed by Alexey Proskuryakov.
2577
2578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2579         (initPlatformsByFamily): 
2580         (updateHiddenPlatforms):
2581         (parsePlatformFamily): Deleted.
2582         (updateToggleButtons): Deleted.
2583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2584         (updateHiddenPlatforms): Added to remove errors.
2585         (initPlatformsByFamily): Added to remove errors.
2586         (unhiddenQueues): Updated to use Settings.
2587         (documentReady): Added logic to add toggle buttons to the settings menu.
2588         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2589         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2590         MetricsMain.js to Settings.
2591         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2592         MetricsMain.js to Settings.
2593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2594         (QueueView.prototype._updateHiddenState): Updated to use Settings.
2595
2596 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
2597
2598         Appscale query fails because of missing index
2599         https://bugs.webkit.org/show_bug.cgi?id=149609
2600
2601         Reviewed by Darin Adler.
2602
2603         * QueueStatusServer/index.yaml: Added the required index.
2604
2605 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2606
2607         [Win] Fix the 64-bit build after switch to cmake.
2608
2609         Reviewed by Alex Christensen.
2610
2611         * Scripts/webkitdirs.pm:
2612         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2613         run a 64-bit build.
2614
2615 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2616
2617         [Win] Allow Windows to run test-webkitpy without Cygwin
2618         https://bugs.webkit.org/show_bug.cgi?id=149602
2619
2620         Reviewed by Alex Christensen.
2621
2622         These changes mostly shift from hard-coded paths using UNIX-style
2623         separators to Python's "os.path.join" syntax that uses the correct
2624         path separator for each platform.
2625         
2626         * Scripts/webkitpy/common/system/path.py:
2627         (cygpath): Don't pass paths through Cygpath on native Windows.
2628         * Scripts/webkitpy/port/win.py:
2629         (WinPort._path_to_apache): Use os.path.join.
2630         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2631         in 64-bit environments).
2632         * Scripts/webkitpy/style/checker.py: Use os.path.join.
2633         * Scripts/webkitpy/style/checker_unittest.py:
2634         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2635         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2636         (GlobalVariablesTest): Ditto.
2637         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2638         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2639         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2640         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2641         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2642         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2643         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2644         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2645         (StyleProcessor_CodeCoverageTest): Ditto.
2646         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2647         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2648         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2649         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2650         manual string concatenation of paths.
2651
2652 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2653
2654         Add bugzilla addresses of committers to contributors.json
2655         https://bugs.webkit.org/show_bug.cgi?id=149520
2656
2657         Reviewed by Darin Adler.
2658
2659         * Scripts/webkitpy/common/config/contributors.json:
2660
2661 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2662
2663         validate-committer-lists -b shouldn't need edituser privileges
2664         https://bugs.webkit.org/show_bug.cgi?id=149519
2665
2666         Reviewed by Darin Adler.
2667
2668         * Scripts/validate-committer-lists:
2669         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2670         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2671         (BugzillaQueries.is_invalid_bugzilla_email):
2672         (BugzillaQueries): Deleted.
2673         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2674
2675 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2676
2677         Unreviewed. Gardening: skip media stream tests failing after r190262.
2678
2679         * Scripts/run-gtk-tests:
2680         (TestRunner):
2681
2682 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2683
2684         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2685         https://bugs.webkit.org/show_bug.cgi?id=149571
2686
2687         Reviewed by Dan Bernstein.
2688
2689         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
2690
2691         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2692         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2693         * LayoutTestRelay/Configurations/Base.xcconfig:
2694         * MiniBrowser/Configurations/Base.xcconfig:
2695         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2696         * TestWebKitAPI/Configurations/Base.xcconfig:
2697         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2698         * WebEditingTester/Configurations/Base.xcconfig:
2699         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2700         * WebKitTestRunner/Configurations/Base.xcconfig:
2701         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2702         * WebKitTestRunner/iOS.xcconfig: Removed.
2703
2704 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
2705
2706         Clean up user media request internal API
2707         https://bugs.webkit.org/show_bug.cgi?id=149527
2708
2709         Reviewed by Tim Horton.
2710
2711         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2712         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
2713
2714         * WebKitTestRunner/TestController.cpp:
2715         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2716
2717 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
2718
2719         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
2720         https://bugs.webkit.org/show_bug.cgi?id=149577
2721
2722         Reviewed by Tim Horton.
2723         
2724         When calling testRunner.runUIScript() from a page load event, the script could run
2725         in the UI process before the current remote layer tree transaction had been handled
2726         there. This meant that runUIScript() could query state which was about to change.
2727         
2728         Fix by delaying the execution of the UI script until a layer tree transaction has
2729         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
2730
2731         * WebKitTestRunner/TestInvocation.cpp:
2732         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2733         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2734         * WebKitTestRunner/TestInvocation.h:
2735
2736 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2737
2738         [Mac] Media tests start to time out after a few days of bot uptime
2739         https://bugs.webkit.org/show_bug.cgi?id=149468
2740
2741         Reviewed by Darin Adler.
2742
2743         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
2744         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
2745         all temporary and cache files go to a custom location.
2746
2747         * Scripts/webkitpy/port/base.py:
2748         * Scripts/webkitpy/port/driver.py:
2749         * Scripts/webkitpy/port/mac.py:
2750         * Scripts/webkitpy/port/win.py:
2751         (WinPort._driver_tempdir_for_environment): Deleted unused function.
2752
2753 2015-09-25  Dan Bernstein  <mitz@apple.com>
2754
2755         Removed MiniBrowser.entitlements.
2756
2757         Rubber-stamped by Anders Carlsson.
2758
2759         The entitlements weren’t used anyway.
2760
2761         * MiniBrowser/MiniBrowser.entitlements: Removed.
2762         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2763
2764 2015-09-24  Daniel Bates  <dabates@apple.com>
2765
2766         Add WebKitSystemInterface for iOS 9.0
2767         https://bugs.webkit.org/show_bug.cgi?id=149550
2768
2769         Rubber-stamped by Alexey Proskuryakov.
2770
2771         * Scripts/copy-webkitlibraries-to-product-directory:
2772
2773 2015-09-24  Daniel Bates  <dabates@apple.com>
2774
2775         Support building for arbitrary architectures
2776         https://bugs.webkit.org/show_bug.cgi?id=149539
2777
2778         Reviewed by Alexey Proskuryakov.
2779
2780         Teach buildbot to pass the architectures associated with the builder to build-webkit
2781         when building on OS X and iOS. As a side effect of this change we now support building
2782         universal binaries when multiples architectures are specified.
2783
2784         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2785         (CompileWebKit.start):
2786
2787 2015-09-24  Daniel Bates  <dabates@apple.com>
2788
2789         Fix the build after <http://trac.webkit.org/changeset/190212>
2790         (http://trac.webkit.org/changeset/190212)
2791
2792         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
2793
2794         * BuildSlaveSupport/built-product-archive:
2795         (main):
2796
2797 2015-09-24  Daniel Bates  <dabates@apple.com>
2798
2799         Support running unit tests on iOS Simulator test bot
2800         https://bugs.webkit.org/show_bug.cgi?id=149536
2801
2802         Reviewed by Alexey Proskuryakov.
2803
2804         Implements support for running unit tests on a iOS test bot. At the time of writing,
2805         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
2806
2807         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2808         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
2809         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
2810
2811 2015-09-24  Daniel Bates  <dabates@apple.com>
2812
2813         Add support infrastructure for OpenSource iOS builders and testers
2814         https://bugs.webkit.org/show_bug.cgi?id=149534
2815
2816         Reviewed by Darin Adler.
2817
2818         Towards setting up OpenSource iOS build bots, teach buildbot and its support
2819         scripts about iOS.
2820
2821         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2822         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
2823         --ios-simulator or --device for a builder/tester whose full platform name begins with
2824         "ios-simulator" or "ios", respectively.
2825         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
2826         * BuildSlaveSupport/built-product-archive:
2827         (main): Pass the full platform name to determineWebKitBuildDirectory().
2828         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
2829         command line flag when building for iOS.
2830         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
2831         parameter fullPlatform. This parameter was originally added in r125066 to support the
2832         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
2833         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
2834         * BuildSlaveSupport/clean-build:
2835         (main): Call script webkit-build-directory with the appropriate command line flag when
2836         building for iOS.
2837         * BuildSlaveSupport/delete-stale-build-files:
2838         (main): Use the same logic for iOS as we do for Mac.
2839         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
2840         flag when building for iOS.
2841         * BuildSlaveSupport/test-result-archive:
2842         (archiveTestResults): Use the same logic for iOS as we do for Mac.
2843
2844 2015-09-24  Daniel Bates  <dabates@apple.com>
2845
2846         Remove Chromium-specific changes to script built-product-archive
2847         https://bugs.webkit.org/show_bug.cgi?id=149530
2848
2849         Rubber-stamped by Csaba Osztrogonác.
2850
2851         Reverts changes made in r113074 and r113067 to support Chromium testers. The
2852         Chromium code has long since been removed from the OpenSource WebKit Project.
2853
2854         * BuildSlaveSupport/built-product-archive:
2855         (createZipManually):
2856         (createZip):
2857         (archiveBuiltProduct):
2858
2859 2015-09-24  Dan Bernstein  <mitz@apple.com>
2860
2861         Build fix.
2862
2863         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2864
2865 2015-09-24  Mark Lam  <mark.lam@apple.com>
2866
2867         Unreviewed. Make Lucas Forschler a WebKit reviewer.
2868
2869         * Scripts/webkitpy/common/config/contributors.json:
2870
2871 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2872
2873         Unreviewed. Fix GObject DOM API breaks after r190120.
2874
2875         Bring back code removed in r169931 to handle documentation of
2876         deleted classes.
2877
2878         * gtk/webkitdom.py:
2879         (WebKitDOMDocGenerator):
2880         (WebKitDOMDocGenerator.write_deleted_classes):
2881         (WebKitDOMDocGenerator.generate):
2882         (write_deleted_classes):
2883         (WebKitDOMDocGeneratorSections._deleted_class):
2884         (WebKitDOMDocGeneratorSections._deleted_class.in):
2885         (WebKitDOMDocGeneratorSections.write_deleted_classes):
2886         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
2887
2888 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
2889
2890         [Cocoa] [Font Features] Implement font-variant-*
2891         https://bugs.webkit.org/show_bug.cgi?id=148413
2892
2893         Reviewed by Darin Adler.
2894
2895         Update test font to use "lnum" feature.
2896
2897         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2898         (Generator::appendGSUBTable):
2899
2900 2015-09-22  Andy Estes  <aestes@apple.com>
2901
2902         ContentFiltering.AllowDownloadAfterAddData is very flaky
2903         https://bugs.webkit.org/show_bug.cgi?id=148885
2904         <rdar://problem/22729563>
2905
2906         Reviewed by Alexey Proskuryakov.
2907
2908         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
2909         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
2910         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
2911
2912         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2913         (downloadTest):
2914
2915 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
2916
2917         Mavericks: Media tests start to time out after a few days of bot uptime
2918         https://bugs.webkit.org/show_bug.cgi?id=149468
2919
2920         Reviewed by Chris Dumez.
2921
2922         * Scripts/webkitpy/port/base.py:
2923         * Scripts/webkitpy/port/driver.py:
2924         * Scripts/webkitpy/port/mac.py:
2925
2926 2015-09-22  Nan Wang  <n_wang@apple.com>
2927
2928         Unreviewed, add myself to the committers list.
2929
2930         * Scripts/webkitpy/common/config/contributors.json:
2931
2932 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2933
2934         Remove 'nullable' to fix older iOS builds.
2935
2936         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2937         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2938
2939 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2940
2941         [Win] Show tiled drawing debug overlay on Windows
2942         https://bugs.webkit.org/show_bug.cgi?id=149426
2943
2944         Reviewed by Dean Jackson.
2945
2946         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
2947         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
2948         * MiniBrowser/win/Common.cpp:
2949         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
2950         flag if needed.
2951         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
2952
2953 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2954
2955         [Win] Use command-line argument to launch in regular or High DPI mode.
2956         https://bugs.webkit.org/show_bug.cgi?id=149417
2957
2958         Reviewed by Dean Jackson.
2959
2960         * MiniBrowser/win/Common.cpp:
2961         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
2962         very start of execution, before the MiniBrowser.dll is loaded.
2963         * win/DLLLauncher/DLLLauncherMain.cpp:
2964         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
2965         present. On WinCairo, always use High DPI.
2966
2967 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2968
2969         32-bit Mac build fix attempt after r190065.
2970
2971         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2972
2973 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
2974
2975         [OS X] Update for Xcode 7.0 on Yosemite
2976         https://bugs.webkit.org/show_bug.cgi?id=149389
2977
2978         Reviewed by Dan Bernstein.
2979
2980         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2981         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2982         Removed unneeded declarations - conforming to a protocol is sufficient.
2983
2984         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2985         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2986         Changed the definitions to be compiled whenever the SDK requires it (so we will have
2987         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
2988
2989 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2990
2991         Add the ability for tests to run script in the UI process in WebKitTestRunner
2992         https://bugs.webkit.org/show_bug.cgi?id=149356
2993
2994         Reviewed by Tim Horton.
2995
2996         This change adds testRunner.runUIScript(script, callback), which allows a test
2997         to execute script in a JSContext which runs in the UI process. That context
2998         has bindings exposed through the UIScriptController interface; currently one test
2999         function, and some iOS-specific functions are included. UIScriptController can be
3000         async with a callback, and runUIScript() itself is asynchronous. When the UI 
3001         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
3002         is a string passed back to the web process, and given to the runUIScript()
3003         callback function.
3004         
3005         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
3006
3007         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
3008         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
3009         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3010         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
3011         complete, call back into TestRunner.
3012         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3013         (WTR::nextUIScriptCallbackID):
3014         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
3015         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
3016         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3017         * WebKitTestRunner/PlatformWebView.h:
3018         * WebKitTestRunner/TestController.cpp:
3019         (WTR::updateTestOptionsFromTestHeader):
3020         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
3021         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
3022         * WebKitTestRunner/TestInvocation.cpp:
3023         (WTR::TestInvocation::shouldUseFixedLayout):
3024         (WTR::TestInvocation::shouldUseThreadedScrolling):
3025         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3026         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3027         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
3028         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
3029         * WebKitTestRunner/TestInvocation.h:
3030         * WebKitTestRunner/TestOptions.h:
3031         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3032         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3033         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3034         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
3035         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3036         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
3037         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3038         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
3039         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3040         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
3041         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
3042         (WTR::UIScriptController::doAsyncTask):
3043         (WTR::UIScriptController::zoomToScale):
3044         (WTR::UIScriptController::zoomScale):
3045         (WTR::UIScriptController::minimumZoomScale):
3046         (WTR::UIScriptController::maximumZoomScale):
3047         (WTR::UIScriptController::contentVisibleRect):
3048         * WebKitTestRunner/mac/EventSenderProxy.mm:
3049         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3050         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
3051         * WebKitTestRunner/mac/TestControllerMac.mm:
3052         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3053         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
3054         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3055         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
3056         (UIScriptContext::UIScriptContext):
3057         (UIScriptContext::~UIScriptContext):
3058         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
3059         asynchronous, call the callback.
3060         (UIScriptContext::nextTaskCallbackID):
3061         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
3062         that has a callback). Has to store the callbackID of the script, so code called from the completion
3063         callback knows which UI script invoked it.
3064         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
3065         (UIScriptContext::uiScriptComplete):
3066         (UIScriptContext::objectFromRect): Make a JS object from a rect.
3067         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3068         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
3069         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
3070         (WTR::UIScriptController::UIScriptController):
3071         (WTR::UIScriptController::makeWindowObject):
3072         (WTR::UIScriptController::wrapperClass):
3073         (WTR::UIScriptController::doAsyncTask):
3074         (WTR::UIScriptController::zoomToScale):
3075         (WTR::UIScriptController::zoomScale):
3076         (WTR::UIScriptController::minimumZoomScale):
3077         (WTR::UIScriptController::maximumZoomScale):
3078         (WTR::UIScriptController::contentVisibleRect):
3079         (WTR::UIScriptController::uiScriptComplete):
3080         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3081         (WTR::UIScriptController::create):
3082         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
3083
3084 2015-09-21  Tim Horton  <timothy_horton@apple.com>
3085
3086         Turn on threaded scrolling by default in the tests
3087         https://bugs.webkit.org/show_bug.cgi?id=149377
3088
3089         Reviewed by Simon Fraser.
3090
3091         * WebKitTestRunner/mac/TestControllerMac.mm:
3092         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3093         (WTR::shouldUseThreadedScrolling): Deleted.
3094         Turn on threaded scrolling by default.
3095
3096 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3097
3098         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
3099         https://bugs.webkit.org/show_bug.cgi?id=149252
3100
3101         Reviewed by Darin Adler.
3102
3103         In case of glib tests the test runner notifies about tests
3104         crashing, but for google tests we don't get any feedback, which
3105         means that in case of a test crashing we get a list of **PASS**
3106         messages and at the summary we are notified that the test suite
3107         has failed, but it's impossible to know which test cases have failed.
3108
3109         * Scripts/run-gtk-tests:
3110         (TestRunner._run_google_test): Add a **CRASH** message if test
3111         case crashed.
3112
3113 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3114
3115         WebKitTestRunner can leak user content script results between tests
3116         https://bugs.webkit.org/show_bug.cgi?id=149391
3117
3118         Reviewed by Sam Weinig.
3119
3120         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
3121         about:blank, and thus about:blank doesn't have unintended side effects.
3122
3123         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3124         (WTR::InjectedBundle::beginTesting):
3125         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3126         (WTR::InjectedBundlePage::resetAfterTest):
3127
3128 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3129
3130         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
3131         https://bugs.webkit.org/show_bug.cgi?id=149384
3132
3133         Reviewed by Chris Fleizach.
3134
3135         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3136         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
3137         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
3138         regardless of whether someone else holds a reference (we also call -stopListening in
3139         -dealloc).
3140
3141         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3142         (AccessibilityController::platformResetToConsistentState):
3143         (AccessibilityController::addNotificationListener):
3144         Ditto.
3145
3146 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3147
3148         Remove XHR_TIMEOUT compilation guard
3149         https://bugs.webkit.org/show_bug.cgi?id=149260
3150
3151         Reviewed by Benjamin Poulain.
3152
3153         * Scripts/webkitperl/FeatureList.pm:
3154
3155 2015-09-19  Dan Bernstein  <mitz@apple.com>
3156
3157         Attempted build fix.
3158
3159         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3160
3161 2015-09-18  Commit Queue  <commit-queue@webkit.org>
3162
3163         Unreviewed, rolling out r189908.
3164         https://bugs.webkit.org/show_bug.cgi?id=149368
3165
3166         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
3167
3168         Reverted changeset:
3169
3170         "printing does not use minimum page zoom factor"
3171         https://bugs.webkit.org/show_bug.cgi?id=108507
3172         http://trac.webkit.org/changeset/189908
3173
3174 2015-09-18  Andy Estes  <aestes@apple.com>
3175
3176         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
3177         https://bugs.webkit.org/show_bug.cgi?id=149360
3178
3179         Reviewed by Tim Horton.
3180
3181         Added an API test.
3182
3183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3184         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
3185         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3186         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3187         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
3188         (TEST):
3189         * TestWebKitAPI/ios/pages.pages: Added.
3190
3191 2015-09-18  Nan Wang  <n_wang@apple.com>
3192
3193         AX: Implement ARIA 1.1 @aria-current on iOS
3194         https://bugs.webkit.org/show_bug.cgi?id=149297
3195
3196         Reviewed by Chris Fleizach.
3197
3198         Added support to test aria-current on iOS.
3199
3200         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3201         (AccessibilityUIElement::stringAttributeValue):
3202         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3203         (WTR::AccessibilityUIElement::stringAttributeValue):
3204
3205 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
3206
3207         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
3208         https://bugs.webkit.org/show_bug.cgi?id=149352
3209
3210         Reviewed by Simon Fraser.
3211
3212         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
3213         m_context can be null. This may indicate a bug in webkitpy too, but
3214         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
3215         wrong with opening and immediately closing it.
3216
3217 2015-09-18  Daniel Bates  <dabates@apple.com>
3218
3219         isGitSVNDirectory() returns true when Git is not installed
3220         https://bugs.webkit.org/show_bug.cgi?id=149351
3221
3222         Reviewed by Alexey Proskuryakov.
3223
3224         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
3225         Git is not installed on the machine.
3226
3227         * Scripts/VCSUtils.pm:
3228         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
3229         status code 0 (success).
3230
3231 2015-09-18  Alex Christensen  <achristensen@webkit.org>
3232
3233         Prevent build-webkit from building four times on Windows 
3234         https://bugs.webkit.org/show_bug.cgi?id=149336
3235
3236         Reviewed by Brent Fulgham.
3237
3238         * Scripts/build-webkit:
3239         Move the Windows code out of the for loop iterating over each subdirectory to be build.
3240         They're built all at once.
3241         * Scripts/webkitdirs.pm:
3242         (buildVisualStudioProject):
3243         (cmakeGeneratedBuildfile):
3244         Don't generate the Visual Studio solution if it already exists.
3245         It will run CMake again if necessary.
3246
3247 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3248
3249         [iOS WK2] WTR fails to set the key window in the UIKit sense
3250         https://bugs.webkit.org/show_bug.cgi?id=149325
3251
3252         Reviewed by Tim Horton.
3253
3254         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
3255         This causes UIKit to bypass code that actually sets the key window, resulting in
3256         [UIAppliation sharedApplication].keyWindow always being nil.
3257
3258         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
3259         -[WebKitTestRunnerWindow isKeyWindow] call super.
3260
3261         * WebKitTestRunner/PlatformWebView.h:
3262         (WTR::PlatformWebView::setWindowIsKey): Deleted.
3263         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3264         (WTR::PlatformWebView::setWindowIsKey):
3265         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3266         (WTR::PlatformWebView::setWindowIsKey):
3267         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3268         (-[WebKitTestRunnerWindow isKeyWindow]):
3269         (WTR::PlatformWebView::PlatformWebView):
3270         (WTR::PlatformWebView::~PlatformWebView):
3271         (WTR::PlatformWebView::setWindowIsKey):
3272         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3273         (WTR::PlatformWebView::setWindowIsKey):
3274
3275 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3276
3277         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
3278         https://bugs.webkit.org/show_bug.cgi?id=149321
3279
3280         Reviewed by Tim Horton.
3281         
3282         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
3283         enabled the "testing" viewport configuration, which disables page scaling.
3284         
3285         If we're running viewport tests, we want the normal web page configuration.
3286         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
3287         based on whether the test is in a "viewport" directory.
3288
3289         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3290         (WTR::InjectedBundle::beginTesting):
3291         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3292         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
3293         * WebKitTestRunner/TestInvocation.cpp:
3294         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3295         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3296         (WTR::TestInvocation::shouldMakeViewportFlexible):
3297         (WTR::TestInvocation::invoke):
3298         * WebKitTestRunner/TestInvocation.h:
3299         * WebKitTestRunner/ios/TestControllerIOS.mm:
3300         (WTR::TestController::platformConfigureViewForTest):
3301         (WTR::shouldMakeViewportFlexible): Deleted.
3302
3303 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3304
3305         Give iOS WebKitTestRunner a launch storyboard
3306         https://bugs.webkit.org/show_bug.cgi?id=149314
3307
3308         Reviewed by Dan Bates.
3309         
3310         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
3311         that it's been built for specific device configurations, and puts the window
3312         at the top of the screen. This simplifies coordinate conversions in a future patch.
3313
3314         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3315         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
3316         * WebKitTestRunner/ios/Launch.storyboard: Added.
3317
3318 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
3319
3320         Update licence in r189890
3321         https://bugs.webkit.org/show_bug.cgi?id=149306
3322
3323         Reviewed by Dean Jackson.
3324
3325         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3326         * FontWithFeatures/FontWithFeatures/FontCreator.h:
3327         * FontWithFeatures/FontWithFeatures/main.cpp:
3328
3329 2015-09-17  Mark Lam  <mark.lam@apple.com>
3330
3331         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
3332         https://bugs.webkit.org/show_bug.cgi?id=149285
3333
3334         Reviewed by Saam Barati.
3335
3336         Just need to add an option to pass --no-jit to run-jsc-stress-test.
3337
3338         * Scripts/run-javascriptcore-tests:
3339         (runJSCStressTests):
3340
3341 2015-09-17  Alex Christensen  <achristensen@webkit.org>
3342
3343         Switch AppleWin build to use CMake
3344         https://bugs.webkit.org/show_bug.cgi?id=149163
3345
3346         Reviewed by Brent Fulgham.
3347
3348         * Scripts/build-webkit:
3349         * Scripts/run-api-tests:
3350         (runTest):
3351         (listAllTests):
3352         (prepareEnvironmentForRunningTestTool):
3353         (testToolPaths):
3354         (testToolPath): Deleted.
3355         Run the API tests as separate executables on Windows.
3356         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3357         * Scripts/webkitdirs.pm:
3358         (checkRequiredSystemConfig):
3359         (jhbuildWrapperPrefixIfNeeded):
3360         (generateBuildSystemFromCMakeProject):
3361         Fix configuration quirks.
3362
3363 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
3364
3365         Added toggle options for hiding and showing certain platform families on the dashboard.
3366         https://bugs.webkit.org/show_bug.cgi?id=148403
3367
3368         Reviewed by David Kilzer.
3369
3370         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
3371         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
3372         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
3373         in lieu of an "all" button in the toggle menu.
3374
3375         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3376         (parsePlatformFamily): Helper function to parse out a platform family.
3377         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
3378         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
3379         (updateToggleButtons): Updates the status of the toggle buttons.
3380         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
3381         (documentReady): Added creation of toggle buttons.
3382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3383         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
3384         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
3385         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
3386         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
3387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3388         (QueueView): Updated to use hiddenPlatformFamilies.
3389         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
3390         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3391         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
3392         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
3393         (Settings.prototype.toggleHiddenPlatform): Deleted.
3394         (Settings.prototype.clearHiddenPlatforms): Deleted.
3395         (Settings.prototype.toggleShowPlatformFamily): Deleted.
3396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3397         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
3398         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
3399         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
3400         (table.queue-grid tr.headers th):
3401         (div.settingsWrapper.hide):
3402         (div.settingsWrapper):
3403         (div.familyToggleWrapper):
3404         (div.platformFamilyToggleButton):
3405         (div.platformFamilyShowToggleButton:not(:last-child)):
3406         (div.familyShown):
3407         (div.accessibilityButton):
3408         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
3409         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
3410         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
3411         platformFamilyToggleButton and settingsWrapper class.
3412         (.accessibilityButton): Deleted.
3413
3414 2015-09-17  Tim Horton  <timothy_horton@apple.com>
3415
3416         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
3417         https://bugs.webkit.org/show_bug.cgi?id=148904
3418
3419         Reviewed by Myles Maxfield.
3420
3421         * WebKitTestRunner/TestController.cpp:
3422         (WTR::parseBooleanTestHeaderValue):
3423         (WTR::updateViewOptionsFromTestHeader):
3424         Check for the key "useThreadedScrolling".
3425         Add some code to check for "true" and "false" for boolean options.
3426
3427         (WTR::TestController::viewOptionsForTest):
3428         Apply the test's overrides last, even after the platform's.
3429
3430 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3431
3432         printing does not use minimum page zoom factor
3433         https://bugs.webkit.org/show_bug.cgi?id=108507
3434
3435         Reviewed by Darin Adler.
3436
3437         WebKitTestRunner always takes the snapshots from the UI process
3438         (expect for IOS), so in the case of printing, the layout in the
3439         web view is not the expected one. When printing, we need to take
3440         the snapshot in the web process and ensure it's rendered with a
3441         PrintContext.
3442
3443         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3444         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
3445         kWKSnapshotOptionsPrinting option to
3446         WKBundlePageCreateSnapshotWithOptions() when printing. When not
3447         printing, don't even create the snapshot, since it will be ignored
3448         by the UI process that always creates its own from the WebView (expect for IOS platform)
3449         * WebKitTestRunner/TestInvocation.cpp:
3450         (WTR::TestInvocation::dumpResults): Use always the snapshot image
3451         received from the web process if any when comparing pixel
3452         results. Now we only receive a snapshot from the web process in
3453         case of printing, or when platform is IOS. Otherwhise, generate
3454         the snapshot from the WebView as usual.
3455         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
3456         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
3457         is created by the caller now, but the CG implementation needs to
3458         know if it's a Web or UI process snapshot.
3459         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3460         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3461         cairo surface for the given image.
3462         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3463         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3464         CGContext for the given image.
3465
3466 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
3467
3468         Create a font which can be used for testing font features
3469         https://bugs.webkit.org/show_bug.cgi?id=149237
3470
3471         Reviewed by Simon Fraser.
3472
3473         This patch adds a new project in the Tools/ directory which generates a font which can
3474         be used for testing font features. This is a standalone project consisting of two files:
3475         1. A file which actually generates the byte vector representing the font. This file has
3476         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
3477         specific, and only relies on the C++ STL.
3478         2. A file with a main() which calls generateFont() and writes out the font, as well as
3479         uses the font to render some demonstration text into a .png file. This file is platform
3480         specific.
3481
3482         The font itself only supports the following characters:
3483         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
3484         However, the shape of these letters are either an X or a check mark.
3485
3486         The letter "A" always is a check mark.
3487         The letter "B" always is an X.
3488         Without any font features turned on, the rest of the letters are shown as X.
3489
3490         Each font feature has an letter associated with it. When the font feature is enabled,
3491         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
3492         as a check mark.
3493
3494         Here are the mappings of font features to letters:
3495         liga: C
3496         clig: D
3497         dlig: E
3498         hlig: F
3499         calt: G
3500         subs: H
3501         sups: I
3502         smcp: J
3503         c2sc: K
3504         pcap: L
3505         c2pc: M
3506         unic: N
3507         titl: O
3508         onum: P
3509         pnum: Q
3510         tnum: R
3511         frac: S
3512         afrc: T
3513         ordn: U
3514         zero: V
3515         hist: W
3516         jp78: X
3517         jp83: Y
3518         jp90: Z
3519         jp04: a
3520         smpl: b
3521         trad: c
3522         fwid: d
3523         pwid: e
3524         ruby: f
3525
3526         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
3527         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
3528         (integralLog2):
3529         (roundDownToPowerOfTwo):
3530         (isFourByteAligned):
3531         (clampTo):
3532         (append32):
3533         (writeCFFEncodedNumber):
3534         (CFFBuilder::CFFBuilder):
3535         (CFFBuilder::takeResult):
3536         (CFFBuilder::moveTo):
3537         (CFFBuilder::lineTo):
3538         (CFFBuilder::curveToCubic):
3539         (CFFBuilder::closePath):
3540         (CFFBuilder::writePoint):
3541         (generateBoxCharString):
3542         (generateCheckCharString):
3543         (generateXCharString):
3544         (charStringForGlyph):
3545         (Generator::generate):
3546         (Generator::Placeholder::Placeholder):
3547         (Generator::Placeholder::populate):
3548         (Generator::Placeholder::~Placeholder):
3549         (Generator::placeholder):
3550         (Generator::append16):
3551         (Generator::append32):
3552         (Generator::append32BitCode):
3553         (Generator::overwrite16):
3554         (Generator::overwrite32):
3555         (Generator::appendCFFTable):
3556         (Generator::appendSubstitutionSubtable):
3557         (Generator::appendScriptSubtable):
3558         (Generator::appendGSUBTable):
3559         (Generator::appendOS2Table):
3560         (Generator::appendFormat12CMAPTable):
3561         (Generator::appendFormat4CMAPTable):
3562         (Generator::appendCMAPTable):
3563         (Generator::appendHEADTable):
3564         (Generator::appendHHEATable):
3565         (Generator::appendHMTXTable):
3566         (Generator::appendMAXPTable):
3567         (Generator::appendNAMETable):
3568         (Generator::appendPOSTTable):
3569         (Generator::calculateChecksum):
3570         (Generator::appendTable):
3571         (generateFont):
3572         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
3573         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
3574         (drawTextWithFeature):
3575         (main):
3576
3577 2015-09-16  Commit Queue  <commit-queue@webkit.org>
3578
3579         Unreviewed, rolling out r189875 and r189878.
3580         https://bugs.webkit.org/show_bug.cgi?id=149235
3581
3582         cygwin cmake build not ready yet (Requested by alexchristensen
3583         on #webkit).
3584
3585         Reverted changesets:
3586
3587         "Switch AppleWin build to use CMake"
3588         https://bugs.webkit.org/show_bug.cgi?id=149163
3589         http://trac.webkit.org/changeset/189875
3590
3591         "Cygwin build fix after r189875"
3592         http://trac.webkit.org/changeset/189878
3593
3594 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3595
3596         Cygwin build fix after r189875
3597
3598         * Scripts/build-webkit:
3599         * Scripts/webkitdirs.pm:
3600         (jhbuildWrapperPrefixIfNeeded):
3601         (generateBuildSystemFromCMakeProject):
3602         Make things work with cygwin and cmake.