Move ASan arguments from LLVM (-mllvm) to the frontend
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-02  David Farler  <dfarler@apple.com>
2
3         Move ASan arguments from LLVM (-mllvm) to the frontend
4         https://bugs.webkit.org/show_bug.cgi?id=137365
5
6         Reviewed by David Kilzer.
7
8         * asan/asan.xcconfig:
9         Remove the -mllvm prefix to the asan-blacklist argument, moving it
10         to the clang frontend.
11
12         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
13
14 2014-10-02  Commit Queue  <commit-queue@webkit.org>
15
16         Unreviewed, rolling out r174120.
17         https://bugs.webkit.org/show_bug.cgi?id=137350
18
19         While number of failures is reasonable with 2 processes, test
20         results seem to be inconsistent between runs (Requested by
21         rfong on #webkit).
22
23         Reverted changeset:
24
25         "[Windows] Back to 2 child processes for NRWT on Windows."
26         http://trac.webkit.org/changeset/174120
27
28 2014-10-02  Jeff Miller  <jeffm@apple.com>
29
30         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
31         https://bugs.webkit.org/show_bug.cgi?id=137347
32
33         Reviewed by Dan Bernstein.
34
35         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
36         Use WebKitSystemInterfaceYosemite on OS X 10.10.
37
38         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
39         Ditto.
40
41 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
42
43         [GTK] [JHBuild] Switch sourceware.org mirror to http.
44
45         Unreviewed.
46
47         The ftp access is recently failing to work as expected, and the
48         bots fail to download the file.
49         The same mirror is available via http and seems to work better.
50
51         * gtk/jhbuild.modules:
52
53 2014-10-01  Commit Queue  <commit-queue@webkit.org>
54
55         Unreviewed, rolling out r174185.
56         https://bugs.webkit.org/show_bug.cgi?id=137334
57
58         Patch that adds logging causes webkitpy failures (Requested by
59         rfong on #webkit).
60
61         Reverted changeset:
62
63         "commitqueuetasks_unittest references a non-existent member
64         variable"
65         https://bugs.webkit.org/show_bug.cgi?id=137303
66         http://trac.webkit.org/changeset/174185
67
68 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
69
70         EWS and Commit Queue should know better than to spew 500 failed
71         results in the case of extremely red patches.
72         https://bugs.webkit.org/show_bug.cgi?id=137324
73
74         Reviewed by Alexey Proskuryakov.
75
76         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
77         Adds a check for did_exceed_test_failure_limit.
78         (AbstractEarlyWarningSystem._failing_tests_message):
79         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
80         Alters the task mock to respond properly to
81         results_from_patch_test_run(patch)
82         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
83         * Scripts/webkitpy/tool/commands/queues.py:
84         Adds a check for did_exceed_test_failure_limit.
85         (CommitQueue._failing_tests_message):
86
87 2014-10-01  Daniel Bates  <dabates@apple.com>
88
89         Unreviewed, rolling out r174192.
90
91         Revert the unit test fix in r174192 since we reverted r174187
92         in r174194 due to correctness issues. See
93         <http://webkit.org/b/137329> for more details.
94
95         Reverted changeset:
96
97         "Test fix after r174187"
98         http://trac.webkit.org/changeset/174192
99
100 2014-10-01  Mark Rowe  <mrowe@apple.com>
101
102         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
103
104         Reviewed by Dan Bernstein.
105
106         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
107         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
108         for the LLVM components when on Yosemite.
109
110 2014-10-01  Commit Queue  <commit-queue@webkit.org>
111
112         Unreviewed, rolling out r174187.
113         https://bugs.webkit.org/show_bug.cgi?id=137329
114
115         webkitpy failures, and thorton says the patch is wrong
116         (Requested by dethbakin on #webkit).
117
118         Reverted changeset:
119
120         "[Windows] Increase layout test timeout for Windows following
121         r174162."
122         http://trac.webkit.org/changeset/174187
123
124 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
125
126         Test fix after r174187
127
128         * Scripts/webkitpy/port/win_unittest.py:
129         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
130
131 2014-10-01  Roger Fong  <roger_fong@apple.com>
132
133         [Windows] Increase layout test timeout for Windows following r174162.
134
135         * Scripts/webkitpy/port/win.py:
136         (WinPort.default_timeout_ms):
137
138 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
139
140         commitqueuetasks_unittest references a non-existent member variable
141         when mock-reporting flaky tests.
142         https://bugs.webkit.org/show_bug.cgi?id=137303
143
144         Reviewed by Daniel Bates.
145
146         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
147         (MockCommitQueue.report_flaky_tests):
148         Makes the appropriate name change.
149         (test_simple_flaky_test_failure):
150         Adds a unit test to make sure that the code is excercised.
151
152 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
153
154         EWS is inconclusively spinning forever on a patch that breaks 500+
155         tests
156         https://bugs.webkit.org/show_bug.cgi?id=137223
157
158         Reviewed by Tim Horton.
159
160         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
161         Checks to see whether the tests have exceeded the failure limit, and
162         only spins off another test if they have not exceeded the limit.
163         (PatchAnalysisTask._test_patch):
164
165 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
166
167         Unreviewed, add Katie Madonna as a contributor.
168
169         * Scripts/webkitpy/common/config/contributors.json:
170
171 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
172
173         commitqueuetasks_unittest does not construct FailingTestCommitQueue
174         objects properly in its test cases.
175         https://bugs.webkit.org/show_bug.cgi?id=137281
176
177         Reviewed by Daniel Bates.
178
179         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
180         (FailingTestCommitQueue.test_results):
181         Adds an assert to make FailingTestCommitQueue harder to mis-use.
182         (test_double_flaky_test_failure):
183         Nests the intended test failure strings into one-length lists.
184         (test_red_test_failure):
185         Nests the intended test failure strings into one-length lists.
186
187 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
188
189         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
190         https://bugs.webkit.org/show_bug.cgi?id=136987
191
192         Reviewed by Daniel Bates.
193
194         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
195         Specify the default encoding for all WebKit developers to get consistent results.
196
197 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
198
199         EWS is too eager to say that a patch does not apply to trunk of repository
200         https://bugs.webkit.org/show_bug.cgi?id=137290
201
202         Reviewed by Ryosuke Niwa.
203
204         * QueueStatusServer/app.yaml: Updated app version.
205
206         * QueueStatusServer/handlers/statusbubble.py:
207         (StatusBubble._build_bubble):
208         (StatusBubble._build_bubbles_for_attachment):
209         Rewrote to make more sense.
210
211 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
212
213         Remove thirdparty/unittest2 from webkitpy
214         https://bugs.webkit.org/show_bug.cgi?id=137251
215
216         Reviewed by Brent Fulgham.
217
218         Additionally ordered imports in related webkitpy files and
219         removed unnecessary shebangs from unittest files.
220
221         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
222         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
223         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
224         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
225         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
226         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
227         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
228         * Scripts/webkitpy/common/config/committers_unittest.py:
229         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
230         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
231         * Scripts/webkitpy/common/config/ports_unittest.py:
232         * Scripts/webkitpy/common/config/urls_unittest.py:
233         * Scripts/webkitpy/common/editdistance_unittest.py:
234         * Scripts/webkitpy/common/find_files_unittest.py:
235         * Scripts/webkitpy/common/lru_cache_unittest.py:
236         * Scripts/webkitpy/common/memoized_unittest.py:
237         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
238         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
239         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
240         * Scripts/webkitpy/common/net/credentials_unittest.py:
241         * Scripts/webkitpy/common/net/failuremap_unittest.py:
242         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
243         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
244         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
245         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
246         * Scripts/webkitpy/common/net/statusserver_unittest.py:
247         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
248         * Scripts/webkitpy/common/newstringio_unittest.py:
249         * Scripts/webkitpy/common/prettypatch_unittest.py:
250         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
251         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
252         * Scripts/webkitpy/common/system/environment_unittest.py:
253         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
254         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
255         * Scripts/webkitpy/common/system/executive_unittest.py:
256         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
257         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
258         * Scripts/webkitpy/common/system/filesystem_unittest.py:
259         * Scripts/webkitpy/common/system/logtesting.py:
260         * Scripts/webkitpy/common/system/logutils_unittest.py:
261         * Scripts/webkitpy/common/system/outputcapture.py:
262         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
263         * Scripts/webkitpy/common/system/outputtee_unittest.py:
264         * Scripts/webkitpy/common/system/path_unittest.py:
265         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
266         * Scripts/webkitpy/common/system/profiler_unittest.py:
267         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
268         * Scripts/webkitpy/common/system/user_unittest.py:
269         * Scripts/webkitpy/common/system/workspace_unittest.py:
270         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
271         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
272         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
273         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
274         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
275         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
276         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
277         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
278         * Scripts/webkitpy/common/webkitunittest.py:
279         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
280         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
281         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
282         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
283         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
284         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
285         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
286         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
287         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
288         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
289         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
290         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
291         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
292         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
293         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
294         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
295         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
296         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
297         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
298         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
299         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
300         * Scripts/webkitpy/port/base_unittest.py:
301         * Scripts/webkitpy/port/builders_unittest.py:
302         * Scripts/webkitpy/port/config_unittest.py:
303         * Scripts/webkitpy/port/driver_unittest.py:
304         * Scripts/webkitpy/port/efl_unittest.py:
305         * Scripts/webkitpy/port/factory_unittest.py:
306         * Scripts/webkitpy/port/gtk_unittest.py:
307         * Scripts/webkitpy/port/http_lock_unittest.py:
308         * Scripts/webkitpy/port/image_diff_unittest.py:
309         * Scripts/webkitpy/port/leakdetector_unittest.py:
310         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
311         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
312         * Scripts/webkitpy/port/mock_drt_unittest.py:
313         * Scripts/webkitpy/port/port_testcase.py:
314         * Scripts/webkitpy/port/server_process_unittest.py:
315         * Scripts/webkitpy/port/westondriver_unittest.py:
316         * Scripts/webkitpy/port/win_unittest.py:
317         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
318         * Scripts/webkitpy/style/checker_unittest.py:
319         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
320         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
321         * Scripts/webkitpy/style/checkers/common_unittest.py:
322         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
323         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
324         * Scripts/webkitpy/style/checkers/js_unittest.py:
325         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
326         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
327         * Scripts/webkitpy/style/checkers/png_unittest.py:
328         * Scripts/webkitpy/style/checkers/python_unittest.py:
329         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
330         * Scripts/webkitpy/style/checkers/text_unittest.py:
331         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
332         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
333         * Scripts/webkitpy/style/checkers/xml_unittest.py:
334         * Scripts/webkitpy/style/error_handlers_unittest.py:
335         * Scripts/webkitpy/style/filereader_unittest.py:
336         * Scripts/webkitpy/style/filter_unittest.py:
337         * Scripts/webkitpy/style/main_unittest.py:
338         * Scripts/webkitpy/style/optparser_unittest.py:
339         * Scripts/webkitpy/style/patchreader_unittest.py:
340         * Scripts/webkitpy/test/finder_unittest.py:
341         * Scripts/webkitpy/test/main.py: Ordered imports.
342         * Scripts/webkitpy/test/main_unittest.py:
343         * Scripts/webkitpy/test/printer.py: Ordered imports.
344         (Printer.configure):
345         * Scripts/webkitpy/test/runner_unittest.py:
346         * Scripts/webkitpy/test/skip_unittest.py:
347         * Scripts/webkitpy/thirdparty/__init__.py:
348         (AutoinstallImportHook._install_irc):
349         (AutoinstallImportHook._install_unittest2): Deleted.
350         * Scripts/webkitpy/thirdparty/__init___unittest.py:
351         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
352         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
353         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
354         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
355         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
356         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
357         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
358         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
359         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
360         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
361         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
362         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
363         * Scripts/webkitpy/tool/commands/download_unittest.py:
364         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
365         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
366         * Scripts/webkitpy/tool/commands/queries_unittest.py:
367         * Scripts/webkitpy/tool/commands/queuestest.py:
368         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
369         * Scripts/webkitpy/tool/grammar_unittest.py:
370         * Scripts/webkitpy/tool/mocktool_unittest.py:
371         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
372         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
373         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
374         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
375         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
376         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
377         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
378         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
379         * Scripts/webkitpy/tool/steps/commit_unittest.py:
380         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
381         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
382         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
383         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
384         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
385         * Scripts/webkitpy/tool/steps/steps_unittest.py:
386         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
387         * Scripts/webkitpy/tool/steps/update_unittest.py:
388         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
389         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
390         * Scripts/webkitpy/w3c/test_converter_unittest.py:
391         * Scripts/webkitpy/w3c/test_importer_unittest.py:
392         * Scripts/webkitpy/w3c/test_parser_unittest.py:
393
394 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
395
396         LayoutTestResults and ExpectedFailures should know about the
397         interrupted flag from the json results file
398         https://bugs.webkit.org/show_bug.cgi?id=137229
399
400         Reviewed by Daniel Bates.
401
402         Changes LayoutTestResults to use the interrupted flag instead of
403         counting failures.
404
405         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
406         (BuilderTest._install_fetch_build._mock_fetch_build):
407         (BuilderTest.test_latest_layout_test_results):
408         * Scripts/webkitpy/common/net/layouttestresults.py:
409         Removes notion of failure_limit_count, and adds
410         did_exceed_test_failure_limit.
411
412         (LayoutTestResults.results_from_string):
413         (LayoutTestResults.__init__):
414         (LayoutTestResults.did_exceed_test_failure_limit):
415         (LayoutTestResults): Deleted.
416         (LayoutTestResults.set_failure_limit_count): Deleted.
417         (LayoutTestResults.failure_limit_count): Deleted.
418         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
419         Removes unit test for failure_limit_count logic.
420
421         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
422         * Scripts/webkitpy/common/net/resultsjsonparser.py:
423         Instead of providing a class method that returns a list of
424         TestResults objects, resultsjsonparser now provides a class
425         ParsedJSONResults that serves as an interface between the results.json
426         file and the rest of webkitpy.
427
428         (ParsedJSONResults):
429         (ParsedJSONResults.__init__):
430         (ParsedJSONResults.did_exceed_test_failure_limit):
431         (ParsedJSONResults.test_results):
432         (ResultsJSONParser): Deleted.
433         (ResultsJSONParser.parse_results_json): Deleted.
434         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
435         Updates the unit test so that it can test the new ResultsJSONParser
436         class.
437
438         (ParsedJSONResultsTest):
439         (test_basic):
440         (ResultsJSONParserTest): Deleted.
441         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
442         Updates the unit test to instantiate ResultsJSONParser objects rather
443         than simple lists of TestResult objects.
444
445         (MockCommitQueue.test_results):
446         (FailingTestCommitQueue.test_results):
447         (test_flaky_test_failure):
448         (test_failed_archive):
449         * Scripts/webkitpy/tool/bot/expectedfailures.py:
450         Updates ExpectedFailures to use the did_exceed_test_failure_limit
451         method rather than counting the number of failed tests.
452
453         (ExpectedFailures._should_trust):
454         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
455         Updates MockResults to more closely resemble the updated
456         LayoutTestResults class.
457
458         (MockResults.__init__):
459         (MockResults.did_exceed_test_failure_limit):
460         (ExpectedFailuresTest.test_can_trust_results):
461         (ExpectedFailuresTest.test_unexpected_failures_observed):
462         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
463         (MockResults.failure_limit_count): Deleted.
464         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
465         Removes a FIXME regarding the use of the
466         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
467
468         (LayoutTestResultsReader.results):
469         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
470         Updates test to not check the now-nonexistant failure_count_limit
471         method.
472
473         (test_missing_unit_test_results_path):
474         (test_layout_test_results):
475         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
476         Accounts for name change: ResultsJSONParserTest ->
477         ParsedJSONParserTest.
478
479         (RebaselineTestTest.test_gather_baselines):
480
481 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
482
483         [EFL] Rename TEST_THEME_DIR macro
484         https://bugs.webkit.org/show_bug.cgi?id=137244
485
486         Reviewed by Csaba Osztrogonác.
487
488         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
489         DEFAULT_THEME_DIR is better than it.
490
491         * MiniBrowser/efl/main.c:
492         (window_create):
493         * TestWebKitAPI/efl/PlatformWebView.cpp:
494         (TestWebKitAPI::PlatformWebView::PlatformWebView):
495         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
496         (WTR::PlatformWebView::PlatformWebView):
497
498 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
499
500         Windows EWS went purple when it failed to build
501         https://bugs.webkit.org/show_bug.cgi?id=137267
502
503         Reviewed by Ryosuke Niwa.
504
505         * QueueStatusServer/app.yaml: Update the version.
506
507         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
508         Make it work for style and win-ews queues.
509
510 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
511
512         It should be fun and easy to run every possible JavaScript benchmark from the command line
513         https://bugs.webkit.org/show_bug.cgi?id=137245
514
515         Reviewed by Oliver Hunt.
516         
517         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
518         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
519         having their own private scripts for doing benchmark runs, and didn't share them in the open
520         source community, because of fears about the shady licensing of the benchmarks suites that
521         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
522         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
523         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
524         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
525         but some of them are. The non-public tests are exclusively those that were not made by any
526         WebKit contributor, but which JSC/WebKit devs found useful for testing.
527
528         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
529         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
530         checked into WebKit svn at all) can be run by passing the path to them via a configuration
531         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
532         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
533         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
534         probably never be checked in because there is no license text anywhere in that benchmark.
535         A valid ~/.run-jsc-benchmarks file will just be something like:
536         
537             {
538                 "OctanePath": "/path/to/Octane2",
539                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
540             }
541         
542         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
543         run-jsc-benchmarks will just gracefully avoid running that test suite.
544         
545         Finally, a word about policy: it is understood that different organizations that do
546         development on JSC may find themselves having internal benchmarks that they cannot share
547         because of weird licensing. It happens - usually because the organization doing JSC
548         development found some test in the wild that is owned by someone else and therefore cannot
549         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
550         that add support for some new kind of benchmark suite even if the suite is not made public
551         as part of the same patch - so long as the patch isn't too invasive. An example of
552         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
553         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
554         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
555         completely open-sourced and committed to the WebKit repo - but the reality is that this
556         can't always be done safely.
557
558         * Scripts/bencher: Removed.
559         * Scripts/run-jsc-benchmarks: Added.
560
561 2014-09-30  Roger Fong  <roger_fong@apple.com>
562
563         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
564
565         * Scripts/webkitpy/port/drdiver.py:
566         (Driver.stop):
567         * Scripts/webkitpy/port/server_process.py:
568         (ServerProcess.stop):
569
570 2014-09-30  Roger Fong  <roger_fong@apple.com>
571
572         [Windows] Back to 2 child processes for NRWT on Windows.
573
574         * Scripts/webkitpy/port/win.py:
575         (WinPort.default_child_processes):
576         Changing the number of processes to 1 did not have an effect on the layout test results. 
577         It does introduce an issue with one of the workers hanging indefinitely and causing the 
578         layout tests to timeout as a whole occasionally, but we should just fix that.
579
580 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
581
582         Remove an accidentally committed line..
583
584         * QueueStatusServer/handlers/statusbubble.py:
585         (StatusBubble._build_bubble):
586
587 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
588
589         build.webkit.org/dashboard: Switch EWS view to using actual retry count
590         https://bugs.webkit.org/show_bug.cgi?id=137240
591
592         Reviewed by Ryosuke Niwa.
593
594         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
595         (EWSQueue.prototype.loadDetailedStatus):
596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
597         (EWSQueueView.prototype._popoverContentForEWSQueue):
598         Use the new retry_count data member from JSON.
599
600         * QueueStatusServer/app.yaml: Updating the version.
601
602         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
603         Instead of message_count, produce retry_count.
604
605 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
606
607         EWS doesn't need to show all the bubbles when a patch fails to apply
608         https://bugs.webkit.org/show_bug.cgi?id=137256
609
610         Reviewed by Ryosuke Niwa.
611
612         * QueueStatusServer/app.yaml: Updated app version.
613
614         * QueueStatusServer/handlers/statusbubble.py:
615         (StatusBubble._build_bubble):
616         (StatusBubble._build_bubbles_for_attachment):
617         (StatusBubble.get):
618         * QueueStatusServer/templates/statusbubble.html:
619         When some queues fail to apply, and no queues had meaningful output (meaning that
620         they will almost certainly fail to apply later), we can show a single bubble
621         telling the user just that.
622
623 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
624
625         [EFL] Bump EFL version to 1.11.2
626         https://bugs.webkit.org/show_bug.cgi?id=137118
627
628         Reviewed by Gyuyoung Kim.
629
630         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
631         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
632
633         * efl/jhbuild.modules:
634         * efl/patches/ecore.patch: Removed.
635
636 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
637
638         REGRESSION(r173929): [GTK] TestInspector fails after r173929
639         https://bugs.webkit.org/show_bug.cgi?id=137247
640
641         Reviewed by Philippe Normand.
642
643         Wait until can-attach property changes before trying to attach the
644         inspector after resizing the view.
645
646         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
647         (testInspectorDefault):
648
649 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
650
651         Require Python 2.7 version
652         https://bugs.webkit.org/show_bug.cgi?id=137112
653
654         Reviewed by Csaba Osztrogonác.
655
656         * Scripts/ensure-valid-python:
657         (checkPythonVersion):
658         * Scripts/webkitpy/common/version_check.py:
659
660 2014-09-30  Martin Hock  <mhock@apple.com>
661
662         Skip a JSC test after r174036.
663         https://bugs.webkit.org/show_bug.cgi?id=137236
664
665         Reviewed by Csaba Osztrogonác.
666
667         * Scripts/run-javascriptcore-tests:
668
669 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
670
671         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
672         https://bugs.webkit.org/show_bug.cgi?id=137212
673
674         This moves TestNetscapePlugin to a new folder (lib/plugins).
675         We should not use the same directory for TestNetscapePlugin and
676         the other libraries, because we end up scanning all the .so in the
677         lib dir for every test.
678
679         Reviewed by Carlos Garcia Campos.
680
681         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
682         * Scripts/webkitpy/port/efl.py:
683         (EflPort.setup_environ_for_server): Update plugin path.
684         * Scripts/webkitpy/port/gtk.py:
685         (GtkPort.setup_environ_for_server): Update plugin path.
686         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
687
688 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
689
690         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
691
692         Rubber-stamped by Tim Horton.
693
694         * QueueStatusServer/app.yaml:
695         * QueueStatusServer/handlers/statusbubble.py:
696         (StatusBubble._build_bubble):
697
698 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
699
700         Typo fix, suggested by Tim Horton.
701
702         * QueueStatusServer/handlers/statusbubble.py:
703         (StatusBubble._build_message_for_provisional_failure):
704
705 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
706
707         Improve Bugzilla status bubbles
708         https://bugs.webkit.org/show_bug.cgi?id=137232
709
710         Reviewed by Ryosuke Niwa.
711
712         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
713
714         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
715         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
716         that are stuck, as it was only confusing that they disappeared after 99.
717
718         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
719         by old bubbles. We need a lot more information to determine color, so the implementation
720         can not be here.
721
722         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
723         always have a link for consistency. Added code to convert timestamps in tooltips
724         to local time zone.
725
726 2014-09-29  Commit Queue  <commit-queue@webkit.org>
727
728         Unreviewed, rolling out r174045.
729         https://bugs.webkit.org/show_bug.cgi?id=137231
730
731         Introduced a crash during page loading tests on Mac (Requested
732         by rniwa on #webkit).
733
734         Reverted changeset:
735
736         "Replace OSObjectPtr with RetainPtr/adoptOS"
737         https://bugs.webkit.org/show_bug.cgi?id=137158
738         http://trac.webkit.org/changeset/174045
739
740 2014-09-29  Tim Horton  <timothy_horton@apple.com>
741
742         Add Jake as a contributor.
743
744         * Scripts/webkitpy/common/config/contributors.json:
745
746 2014-09-29  Roger Fong  <roger_fong@apple.com>
747
748         [Windows] Skip a javascriptcore test following r174036.
749
750         * Scripts/run-javascriptcore-tests:
751
752 2014-09-29  Roger Fong  <roger_fong@apple.com>
753
754         [Windows] Reduce number of processes used by NRWT on Windows to 1.
755
756         * Scripts/webkitpy/port/win.py:
757         (WinPort.default_child_processes):
758         Reduce number of processes to 1 so we can get a good baseline for what failures
759         we should be expecting to see from the Windows bots.
760
761 2014-09-29  Darin Adler  <darin@apple.com>
762
763         Tweak and tighten SVG font converter
764         https://bugs.webkit.org/show_bug.cgi?id=136956
765
766         Reviewed by Myles Maxfield.
767
768         I was investigating behavior of String::toInt, String::toDouble, and
769         String::toFloat for various failure cases, and decided to start some
770         unit tests for those functions here.
771
772         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
773         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
774         StringToDouble testing.
775
776 2014-09-29  Philippe Normand  <pnormand@igalia.com>
777
778         [GTK][CMake] TestWebCore target build sometimes fail
779         https://bugs.webkit.org/show_bug.cgi?id=137207
780
781         Reviewed by Csaba Osztrogon.
782
783         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
784         headers are generated before the TestWebCore target is built.
785
786 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
787
788         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
789         https://bugs.webkit.org/show_bug.cgi?id=137209
790
791         Reviewed by Philippe Normand.
792
793         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
794         from the WebCore test sources.
795
796 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
797
798         Allow webkit-patch upload to respect the --directory argument with git checkouts
799         https://bugs.webkit.org/show_bug.cgi?id=137166
800
801         Reviewed by Darin Adler.
802
803         We simply hadn't plumbed it through.
804
805         * Scripts/webkitpy/common/checkout/scm/detection.py:
806         (SCMDetector.detect_scm_system):
807         * Scripts/webkitpy/common/checkout/scm/git.py:
808         (Git.__init__):
809         (Git.changed_files):
810
811 2014-09-26  Sam Weinig  <sam@webkit.org>
812
813         Replace OSObjectPtr with RetainPtr/adoptOS
814         https://bugs.webkit.org/show_bug.cgi?id=137158
815
816         Reviewed by Dan Bernstein.
817
818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
819         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
820         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
821         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
822
823 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
824
825         Disable function.arguments
826         https://bugs.webkit.org/show_bug.cgi?id=137167
827
828         Rubber stamped by Geoffrey Garen
829         
830         Enable the feature by default during tests.
831
832         * Scripts/run-jsc-stress-tests:
833
834 2014-09-26  Beth Dakin  <bdakin@apple.com>
835
836         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
837         https://bugs.webkit.org/show_bug.cgi?id=137089
838
839         Reviewed by Tim Horton.
840
841         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
842         tests run at 1x, but that code does not seem to execute at the right time for 
843         these tests, so if we just ensure we start out at 1x, that appears to fix these 
844         tests and does not break the HiDPI tests either.
845         * WebKitTestRunner/TestController.cpp:
846         (WTR::TestController::createWebViewWithOptions):
847
848 2014-09-26  Roger Fong  <roger_fong@apple.com>
849
850         [Windows] Decrease default number of child processes used by Windows.
851
852         * Scripts/webkitpy/port/win.py:
853         (WinPort.default_child_processes):
854         Having too many seems to cause many tests to crash or timeout. 
855         We may even need to make it have only 1 child process if we’re still seeing problems after this.
856
857 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
858
859         Mac EWS bots do not keep logs as promised
860         https://bugs.webkit.org/show_bug.cgi?id=137151
861
862         Reviewed by Ryosuke Niwa.
863
864         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
865
866 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
867
868         Get rid of webkit-queues dashboard
869         https://bugs.webkit.org/show_bug.cgi?id=137141
870
871         Reviewed by Ryosuke Niwa.
872
873         * QueueStatusServer/app.yaml: Updated version.
874
875         * QueueStatusServer/templates/dashboard.html: Removed.
876         * QueueStatusServer/handlers/dashboard.py: Removed.
877         * QueueStatusServer/main.py:
878         Kill it!
879
880         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
881         (.status-cell): Deleted.
882         (.status-cell:hover): Deleted.
883         (.status-cell.pass): Deleted.
884         (.status-cell.fail): Deleted.
885         (.status-cell.pending): Deleted.
886         (.status-cell.error): Deleted.
887         * QueueStatusServer/stylesheets/dashboard.css: Removed.
888         * QueueStatusServer/templates/activebots.html:
889         * QueueStatusServer/templates/patch.html:
890         * QueueStatusServer/templates/queuestatus.html:
891         * QueueStatusServer/templates/recentstatus.html:
892         Renamed dashboard.css to common.css, and removed dashboard-only rules.
893
894 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
895
896         Get rid of Retry status in webkit-queues
897         https://bugs.webkit.org/show_bug.cgi?id=137135
898
899         Reviewed by Ryosuke Niwa.
900
901         * QueueStatusServer/config/messages.py: Removed Retry.
902
903         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
904         no longer needs to check the latest status. It just always both unlocks the patch
905         and removes it from WorkItems.
906
907         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
908         I don't understand why we even needed to check for retries here, but now that there
909         are no retries, that code can go to /dev/null.
910
911         * QueueStatusServer/loggers/recordpatchevent.py:
912         (RecordPatchEvent.started):
913         (RecordPatchEvent.retrying): Deleted.
914         Fixed retry counting, it should work for all queues now.
915
916         * QueueStatusServer/model/queuestatus.py:
917         (QueueStatus.is_retry_request): Deleted. These are no more.
918
919         * Scripts/webkitpy/common/net/statusserver_mock.py:
920         (MockStatusServer.release_lock):
921         * Scripts/webkitpy/tool/commands/queues_unittest.py:
922         Did whatever it took to keep passing the tests. The particular test doesn't seem
923         quite right, but whatever.
924
925         * Scripts/webkitpy/tool/commands/queues.py:
926         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
927         and let others pick up. Also, added explicit returns for clarity.
928         (AbstractPatchQueue._did_retry): Deleted.
929
930 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
931
932         [EFL] Fix the gst-libav build on ARM Thumb2
933         https://bugs.webkit.org/show_bug.cgi?id=137022
934
935         Reviewed by Zoltan Herczeg.
936
937         * efl/jhbuild.modules:
938         * efl/patches/gst-libav.patch: Added.
939
940 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
941
942         [EFL] Bump up dependencies not to conflict with the GTK port.
943         https://bugs.webkit.org/show_bug.cgi?id=137143
944
945         Reviewed by Gyuyoung Kim.
946
947         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
948         installing and removing different versions of libgnutls-dev, thus
949         hindering the development for both ports on the same machine. GTK is
950         using the newer version of the package, now bumping up EFL to use the 
951         same.
952
953         * efl/install-dependencies:
954
955 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
956
957         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
958         https://bugs.webkit.org/show_bug.cgi?id=136854
959
960         Reviewed by Gyuyoung Kim.
961
962         'Escape' key should exit fullscreen first and then should be used to stop page load.
963
964         * MiniBrowser/efl/main.c:
965         (on_key_down):
966
967 2014-09-25  Dean Jackson  <dino@apple.com>
968
969         Add Said to the contributors list so his name completes in bugzilla.
970
971         * Scripts/webkitpy/common/config/contributors.json:
972
973 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
974
975         EWS only repeats its cycle every two hours
976         https://bugs.webkit.org/show_bug.cgi?id=137129
977
978         Reviewed by Ryosuke Niwa.
979
980         * QueueStatusServer/app.yaml: Updated version.
981
982         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
983
984         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
985         the patch from work items.
986
987         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
988
989         * QueueStatusServer/main.py: Added release-lock.
990
991         * QueueStatusServer/model/activeworkitems.py:
992         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
993
994         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
995         we don't want it to be immediately picked up again, it's better to give other patches
996         a chance.
997
998         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
999         these interactive versions, but OK.
1000
1001         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
1002         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
1003         or svn is down).
1004
1005         * Scripts/webkitpy/tool/commands/queues.py:
1006         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
1007         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
1008         meaning that these handlers could never do the right thing. We'd either get a duplicate
1009         _did_fail, or try to unlock an already unlocked patch.
1010         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
1011         making it eligible for retry immediately.
1012
1013         * Scripts/webkitpy/common/net/statusserver.py:
1014         (StatusServer._post_release_lock):
1015         (StatusServer.release_lock):
1016         Added a call to release-lock.
1017
1018 2014-09-25  Roger Fong  <roger_fong@apple.com>
1019
1020         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
1021
1022         * Scripts/webkitpy/common/system/path.py:
1023         (_CygPath.convert):
1024
1025 2014-09-25  Roger Fong  <roger_fong@apple.com>
1026
1027         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
1028
1029         * Scripts/webkitpy/common/system/path.py:
1030         (_CygPath.convert):
1031
1032 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1033
1034         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
1035         https://bugs.webkit.org/show_bug.cgi?id=136377
1036
1037         Reviewed by Philippe Normand.
1038
1039         * Scripts/webkitdirs.pm:
1040         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
1041
1042 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
1043
1044         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
1045         https://bugs.webkit.org/show_bug.cgi?id=137117
1046
1047         Tools/efl/install-dependencies relies on apt-get to install packages.
1048         Unfortunately, if a package does not exist (e.g., for a given
1049         architecture) then apt-get install is not able to ignore the missing
1050         package and install the rest but fails to run entirely (and there
1051         seems to be no intent to change this behaviour).
1052
1053         On ARM64, the luajit package is missing and currently it needs manual
1054         editing of install-dependencies to get the script install as much as it
1055         can.
1056
1057         This patch separates the installation of the universally available
1058         packages from those which might not be available for all architectures.
1059
1060         Reviewed by Gyuyoung Kim.
1061
1062         * efl/install-dependencies:
1063
1064 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
1065
1066         Remove WinCE port from trunk
1067         https://bugs.webkit.org/show_bug.cgi?id=136951
1068
1069         Reviewed by Alex Christensen.
1070
1071         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1072         (_should_file_trigger_build):
1073         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1074         (ShouldBuildTest):
1075         * CMakeLists.txt:
1076         * DumpRenderTree/win/DRTDataObject.cpp:
1077         (DRTDataObject::CopyMedium):
1078         * Scripts/build-webkit:
1079         * Scripts/webkit-build-directory:
1080         * Scripts/webkitdirs.pm:
1081         (argumentsForConfiguration):
1082         (builtDylibPathForName):
1083         (isAppleWinWebKit):
1084         (launcherPath):
1085         (launcherName):
1086         (shouldRemoveCMakeCache):
1087         (cmakeBasedPortArguments):
1088         (cmakeBasedPortName):
1089         (isCMakeBuild):
1090         (isWinCE): Deleted.
1091         (determineIsWinCE): Deleted.
1092         * Scripts/webkitperl/FeatureList.pm:
1093         * Scripts/webkitpy/port/port_testcase.py:
1094         (test_apache_config_file_name_for_platform):
1095         * TestWebKitAPI/config.h:
1096         * WinCELauncher/CMakeLists.txt: Removed.
1097         * WinCELauncher/main.cpp: Removed.
1098         * gtk/manifest.txt:
1099
1100 2014-09-23  David Farler  <dfarler@apple.com>
1101
1102         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
1103         https://bugs.webkit.org/show_bug.cgi?id=136895
1104
1105         Reviewed by David Kilzer.
1106
1107         Create Device, DeviceType, and Runtime data classes.
1108         Create Simulator class represent simctl output.
1109
1110         Wherever possible, use structured data classes anywhere a raw
1111         identifier or UDID string was used for a cleaner implementation
1112         and to encapsulate the inherent fragility of scraping simctl output.
1113
1114         Create a suitably named testing device if one doesn't exist.
1115
1116         Finally, accurately handle having multiple simulator runtimes (SDKs)
1117         installed in the active Xcode.app bundle.
1118
1119         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1120         (_set_up_derived_options):
1121         * Scripts/webkitpy/port/driver.py:
1122         (IOSSimulatorDriver.cmd_line):
1123         Construct DeviceType and Runtime objects from identifiers passed at the
1124         command line, still providing sensible defaults for 32- and 64-bit testing.
1125         * Scripts/webkitpy/port/ios.py:
1126         (IOSSimulatorPort.__init__):
1127         (IOSSimulatorPort.setup_test_run):
1128         (IOSSimulatorPort):
1129         (IOSSimulatorPort.testing_device):
1130         Cache the testing device once it is created or found.
1131         (IOSSimulatorPort.reset_preferences):
1132         Get the device path from the Device object instead of consructing it
1133         in the port class.
1134         (IOSSimulatorPort.simulator_udid): Deleted.
1135         Get the UDID from the testing_device :: Device object itself.
1136         * Scripts/webkitpy/xcode/simulator.py:
1137         Created Device, DeviceType, Runtime, and Simulator classes.
1138         (get_runtimes): Deleted.
1139         (get_devices): Deleted.
1140         (get_device_types): Deleted.
1141         (get_latest_runtime): Deleted.
1142
1143 2014-09-24  Roger Fong  <roger_fong@apple.com>
1144
1145         [Windows] Tentative fix for Windows test bots.
1146
1147         * Scripts/webkitpy/common/system/path.py:
1148         (_CygPath.convert):
1149
1150 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
1151
1152         Change more build.webkit.org links to https
1153         https://bugs.webkit.org/show_bug.cgi?id=137049
1154
1155         Reviewed by Csaba Osztrogonác.
1156
1157         Fix appspot, svn.webkit.org and Trac links.
1158
1159         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1160         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
1161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1162         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1163         (ViewController.prototype._domForBuildName):
1164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1167         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1168         (.):
1169         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1170         (EWS):
1171         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1172         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
1173         (TestHistory):
1174         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1175
1176 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
1177
1178         Update the list of u-szeged contributors.
1179
1180         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
1181
1182         * Scripts/webkitpy/common/config/contributors.json:
1183
1184 2014-09-23  Roger Fong  <roger_fong@apple.com>
1185
1186         [Windows] More debugging for the Windows bots.
1187
1188         * Scripts/webkitpy/common/system/path.py:
1189         (_CygPath):
1190
1191 2014-09-23  Roger Fong  <roger_fong@apple.com>
1192
1193         Unreviewed. Fix for r173899, those tabs should be spaces.
1194
1195         * Scripts/webkitpy/port/driver.py:
1196         (Driver._command_from_driver_input):
1197         (Driver): Deleted.
1198
1199 2014-09-23  Roger Fong  <roger_fong@apple.com>
1200
1201         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
1202
1203         * Scripts/webkitpy/port/driver.py:
1204         (Driver):
1205
1206 2014-09-23  Jer Noble  <jer.noble@apple.com>
1207
1208         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
1209         https://bugs.webkit.org/show_bug.cgi?id=137031
1210
1211         Reviewed by Joseph Pecoraro.
1212
1213         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
1214         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
1215         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
1216         ChangeLog locations before passing them to createCommitMessage().
1217
1218         * Scripts/commit-log-editor:
1219
1220 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1221
1222         W3C test importer should detect manual and reference tests according their filenames
1223         https://bugs.webkit.org/show_bug.cgi?id=133852
1224
1225         Reviewed by Bem Jones-Bey.
1226
1227         * Scripts/webkitpy/w3c/test_parser.py:
1228         (TestParser.analyze_test): Adding checks based on WPT filename rules.
1229         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
1230         (TestParser):
1231         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
1232         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
1233         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1234         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
1235
1236 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
1237
1238         Unreviewed, add Rebecca Hauck as a contributor.
1239
1240         * Scripts/webkitpy/common/config/contributors.json:
1241
1242 2014-09-23  David Kilzer  <ddkilzer@apple.com>
1243
1244         Switch build.webkit.org URLs to https
1245
1246         Reviewed by Lucas Forschler and Alexey Proskuryakov.
1247
1248         * TestResultServer/app.yaml: Update version to this commit
1249         revision.
1250
1251         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1252         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1253         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
1255         (WebKitBuildbot):
1256         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1257         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1259         (.):
1260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1261         (WebKitBuildbot):
1262         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1263         * Scripts/webkitpy/common/config/urls.py:
1264         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1265         (test_builder_with_name):
1266         * Scripts/webkitpy/tool/commands/queries.py:
1267         (TreeStatus):
1268         * TestResultServer/generate_builders_json.py:
1269         (main):
1270         * TestResultServer/generate_builders_json_unittest.py:
1271         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
1272         (GenerateBuildersJsonTest):
1273         (GenerateBuildersJsonTest.test_generate_json_data):
1274         * TestResultServer/static-dashboards/builders.jsonp:
1275         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1276         (loadExpectationsLayoutTests):
1277         * TestResultServer/static-dashboards/timeline_explorer.js:
1278
1279 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1280
1281         W3C test importer should copy .htaccess files
1282         https://bugs.webkit.org/show_bug.cgi?id=136850
1283
1284         Reviewed by Bem Jones-Bey.
1285
1286         * Scripts/webkitpy/w3c/test_importer.py:
1287         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
1288         (TestImporter):
1289         (TestImporter.find_importable_tests): Making use of new helper function.
1290
1291 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
1292
1293         Trying to revive bot watcher's dashboard after HSTS.
1294
1295         Unreviewed.
1296
1297         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1298         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
1299
1300 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1301
1302         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
1303         https://bugs.webkit.org/show_bug.cgi?id=137026
1304
1305         Reviewed by Csaba Osztrogonác.
1306
1307         * BuildSlaveSupport/wait-for-SVN-server.py:
1308         (getLatestSVNRevision):
1309         (waitForSVNRevision):
1310
1311 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1312
1313         Remove unlinkZeroFiles from build-webkit
1314         https://bugs.webkit.org/show_bug.cgi?id=137018
1315
1316         Reviewed by Csaba Osztrogonác.
1317
1318         * Scripts/build-webkit:
1319         (unlinkZeroFiles): Deleted.
1320
1321 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
1322
1323         [GTK] Minibrowser : Add keyboard support for stop page load
1324         https://bugs.webkit.org/show_bug.cgi?id=136857
1325
1326         Reviewed by Philippe Normand.
1327
1328         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
1329
1330         * MiniBrowser/gtk/BrowserWindow.c:
1331         (stopPageLoad): Callback to stop page load.
1332         (browser_window_init):
1333
1334 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
1335
1336         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
1337         https://bugs.webkit.org/show_bug.cgi?id=136813
1338
1339         Reviewed by Gyuyoung Kim.
1340
1341         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
1342
1343         * MiniBrowser/efl/main.c:
1344         (on_key_down):
1345
1346 2014-09-22  Daniel Bates  <dabates@apple.com>
1347
1348         [Cocoa] Add UI delegate callback when window.close() is called
1349         https://bugs.webkit.org/show_bug.cgi?id=137008
1350         <rdar://problem/17801001>
1351
1352         Reviewed by Anders Carlsson.
1353
1354         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
1355         for window opened via JavaScript (i.e. window.open()).
1356
1357         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1358         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
1359         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
1360
1361 2014-09-22  Youenn Fablet  <youennf@gmail.com>
1362
1363         W3C importer should import html files within resources folders
1364         https://bugs.webkit.org/show_bug.cgi?id=127548
1365
1366         Reviewed by Ryosuke Niwa.
1367         
1368         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
1369
1370         * Scripts/webkitpy/w3c/test_importer.py:
1371         (TestImporter.find_importable_tests):
1372
1373 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1374
1375         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
1376         https://bugs.webkit.org/show_bug.cgi?id=136998
1377
1378         Reviewed by Philippe Normand.
1379
1380         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1381         (testWebViewCanShowMIMEType): Remove the check of PDF as
1382         unsupported MIME type.
1383
1384 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1385
1386         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
1387
1388         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
1389         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
1390
1391         * Scripts/webkitpy/common/config/watchlist: Use
1392         Source/WebCore/platform/gtk/po/ as directory to watch for
1393         WebKitGTKTranslations rule and add berto and myself to the list of
1394         watchers.
1395
1396 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
1397
1398         Fix syntaxError in watchlist since r173594
1399         https://bugs.webkit.org/show_bug.cgi?id=136996
1400
1401         Reviewed by Philippe Normand.
1402
1403         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
1404
1405 2014-09-20  Sam Weinig  <sam@webkit.org>
1406
1407         Make possible HashSet<std::unique_ptr<>>
1408         https://bugs.webkit.org/show_bug.cgi?id=136166
1409
1410         Reviewed by Darin Adler.
1411
1412         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
1413         * TestWebKitAPI/Counters.cpp: Added.
1414         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
1415         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
1416         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
1417         translation unit.
1418     
1419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1420         Add new files.
1421
1422         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1423         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
1424
1425         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1426         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
1427
1428 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1429
1430         run-webkit-tests should count tests submitted as absolute paths once
1431         https://bugs.webkit.org/show_bug.cgi?id=136848
1432
1433         Reviewed by Darin Adler.
1434
1435         * Scripts/webkitpy/port/base.py:
1436         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
1437
1438 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
1439
1440         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
1441         https://bugs.webkit.org/show_bug.cgi?id=136974
1442
1443         Reviewed by Chris Fleizach.
1444
1445         * DumpRenderTree/AccessibilityUIElement.cpp:
1446         (selectTextWithCriteriaCallback):
1447         Be sure to release the string if it was allocated.
1448
1449 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
1450
1451         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
1452         https://bugs.webkit.org/show_bug.cgi?id=136966
1453
1454         Reviewed by Daniel Bates.
1455
1456         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1457         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
1458
1459 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1460
1461         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
1462         https://bugs.webkit.org/show_bug.cgi?id=136917
1463
1464         Reviewed by Darin Adler.
1465
1466         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
1467
1468         * TestWebKitAPI/PlatformEfl.cmake:
1469         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
1470         (TestWebKitAPI::didFinishLoadForFrame):
1471         (TestWebKitAPI::TEST):
1472         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
1473
1474 2014-09-19  Daniel Bates  <dabates@apple.com>
1475
1476         Always assume internal SDK when building configuration Production
1477         https://bugs.webkit.org/show_bug.cgi?id=136925
1478         <rdar://problem/18362399>
1479
1480         Reviewed by Dan Bernstein.
1481
1482         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1483         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1484         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1485         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1486
1487 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1488
1489         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
1490         https://bugs.webkit.org/show_bug.cgi?id=136847
1491
1492         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
1493
1494         Reviewed by Alexey Proskuryakov.
1495
1496         * WebKitTestRunner/TestController.cpp:
1497         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
1498
1499 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1500
1501         [GTK] Missing inspector files in the tarball
1502         https://bugs.webkit.org/show_bug.cgi?id=136952
1503
1504         Reviewed by Gustavo Noronha Silva.
1505
1506         * gtk/manifest.txt: Add
1507         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
1508         to the tarball.
1509
1510 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1511
1512         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
1513         https://bugs.webkit.org/show_bug.cgi?id=136632
1514
1515         Reviewed by Gustavo Noronha Silva.
1516
1517         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
1518         the gtk icons.
1519         * gtk/manifest.txt: Only include the free icons in the tarball.
1520
1521 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1522
1523         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
1524         https://bugs.webkit.org/show_bug.cgi?id=136943
1525
1526         Reviewed by Philippe Normand.
1527
1528         Update the script to receive the list of files from the command
1529         line instead of scanning the given directories.
1530
1531         * gtk/generate-inspector-gresource-manifest.py:
1532         (get_filenames): Convert filenames to use relative paths.
1533         (find_all_files_in_directory): Deleted.
1534         (find_all_files_in_directory.select_file): Deleted.
1535
1536 2014-09-18  Tanay C  <tanay.c@samsung.com>
1537
1538         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
1539         https://bugs.webkit.org/show_bug.cgi?id=136739
1540
1541         Reviewed by Gyuyoung Kim.
1542
1543         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
1544         (on_mouse_wheel): Modified.
1545
1546 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1547
1548         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
1549         https://bugs.webkit.org/show_bug.cgi?id=136923
1550
1551         Reviewed by Gustavo Noronha Silva.
1552
1553         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1554         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
1555         the source.
1556
1557 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
1558
1559         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
1560         https://bugs.webkit.org/show_bug.cgi?id=136856
1561
1562         Reviewed by Darin Adler.
1563
1564         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1565         (RunLLINTCLoopTests.countFailures):
1566         (Run32bitJSCTests.countFailures):
1567         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1568         (RunLLINTCLoopTestsTest.test_failures):
1569         (RunLLINTCLoopTestsTest.test_failure):
1570         (RunLLINTCLoopTestsTest.test_no_failure):
1571         (Run32bitJSCTestsTest.test_failures):
1572         (Run32bitJSCTestsTest.test_failure):
1573         (Run32bitJSCTestsTest.test_no_failure):
1574
1575 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
1576
1577         GMainLoopSource is exposed to race conditions
1578         https://bugs.webkit.org/show_bug.cgi?id=135800
1579
1580         Reviewed by Carlos Garcia Campos.
1581
1582         Add unit tests for GMainLoopSource.
1583
1584         The tests check correct behavior of GMainLoopSource in various conditions --
1585         from the most simple rescheduling to rescheduling during dispatch, cancelling
1586         or destroying the GMainLoopSource during dispatch, proper destroy callback
1587         dispatching etc.
1588
1589         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
1590         State of the GMainLoopSource object (either ready, sheduled or active) is
1591         thoroughly tested throughout the lifetime of that object.
1592
1593         Still missing are tests for socket callbacks, which are a bit trickier because
1594         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
1595         are also not tested thoroughly, simply because it is at the moment impossible
1596         to test that the objects are actually destroyed when the corresponding source
1597         is finally deleted.
1598
1599         * TestWebKitAPI/PlatformGTK.cmake:
1600         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
1601         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1602         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1603         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1604         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1605         (TestWebKitAPI::GMainLoopSourceTest::finish):
1606         (TestWebKitAPI::GMainLoopSourceTest::source):
1607         (TestWebKitAPI::TEST):
1608
1609 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
1610
1611         Unreviewed, Update my email in contributors.json
1612
1613         * Scripts/webkitpy/common/config/contributors.json:
1614
1615 2014-09-17  Daniel Bates  <dabates@apple.com>
1616
1617         Unreviewed, rolling out r173695.
1618
1619         Broke building third-party Legacy WebKit apps; will
1620         investigate offline
1621
1622         Reverted changeset:
1623
1624         "[iOS] Make WebCore build with public iOS SDK"
1625         https://bugs.webkit.org/show_bug.cgi?id=136487
1626         http://trac.webkit.org/changeset/173695
1627
1628 2014-09-17  Daniel Bates  <dabates@apple.com>
1629
1630         [iOS] Make WebCore build with public iOS SDK
1631         https://bugs.webkit.org/show_bug.cgi?id=136487
1632
1633         Reviewed by David Kilzer.
1634
1635         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
1636
1637         * DumpRenderTree/mac/CheckedMalloc.cpp:
1638
1639 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1640
1641         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
1642         https://bugs.webkit.org/show_bug.cgi?id=136889
1643
1644         Reviewed by Gustavo Noronha Silva.
1645
1646         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1647         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
1648         event was added to the events vector.
1649         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1650         (loadFailedCallback): Do not assume the web view URI is the
1651         failing URI when the load fails before the committed state.
1652         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
1653         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
1654         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
1655         (LoadTrackingTest::loadFailedWithTLSErrors): Add
1656         LoadFailedWithTLSErrors event to the events vector.
1657         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1658
1659 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
1660
1661         [EFL][GTK] Remove WebKit1 related codes
1662         https://bugs.webkit.org/show_bug.cgi?id=136853
1663
1664         Reviewed by Csaba Osztrogonác.
1665
1666         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
1667         from scripts.
1668
1669         * BuildSlaveSupport/build.webkit.org-config/config.json:
1670         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1671         (Compile32bitJSC):
1672         (BuildAndTestWebKit2Factory):
1673         (CompileWebKit1Only): Deleted.
1674         (CompileWebKit2Only): Deleted.
1675         (BuildAndTestWebKit1OnlyFactory): Deleted.
1676         (BuildAndTestWebKit2OnlyFactory): Deleted.
1677         * Scripts/build-webkit:
1678         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1679         * Scripts/webkitpy/common/config/ports.py:
1680         (GtkWK2Port.build_webkit_command):
1681         (EflWK2Port.build_webkit_command):
1682         * Scripts/webkitpy/common/config/ports_unittest.py:
1683         (DeprecatedPortTest.test_gtk_wk2_port):
1684         * Scripts/webkitpy/port/efl.py:
1685         (EflPort.build_webkit_command):
1686         * Scripts/webkitpy/port/gtk.py:
1687         (GtkPort._built_libraries_path):
1688         (GtkPort._search_paths):
1689         (GtkPort.test_expectations_file_position):
1690         (GtkPort.build_webkit_command):
1691         (GtkPort.run_webkit_tests_command):
1692         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
1693
1694 2014-09-16  Daniel Bates  <dabates@apple.com>
1695
1696         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
1697         https://bugs.webkit.org/show_bug.cgi?id=136862
1698
1699         Reviewed by David Kilzer.
1700
1701         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1702         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1703         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
1704         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
1705
1706 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
1707
1708         Mac queue slaves should reboot every so often
1709         https://bugs.webkit.org/show_bug.cgi?id=136791
1710
1711         Reviewed by Alexey Proskuryakov.
1712
1713         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
1714
1715         * EWSTools/start-queue-mac.sh:
1716
1717 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1718
1719         Unreviewed gardening, skip one more tests on Windows.
1720
1721         * Scripts/run-javascriptcore-tests:
1722
1723 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1724
1725         JSC test gardening
1726         https://bugs.webkit.org/show_bug.cgi?id=136823
1727
1728         Reviewed by Geoffrey Garen.
1729
1730         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
1731
1732 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1733
1734         Remove shouldAbortEarly cruft from master.cfg
1735         https://bugs.webkit.org/show_bug.cgi?id=136779
1736
1737         Reviewed by Csaba Osztrogonác.
1738
1739         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1740         (ConfigureBuild.start):
1741         (RunWebKitTests.start):
1742         (RunWebKit2Tests.start): Deleted.
1743
1744 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1745
1746         Remove ORWT related crufts from webkitdirs.pm
1747         https://bugs.webkit.org/show_bug.cgi?id=136821
1748
1749         Reviewed by Alexey Proskuryakov.
1750
1751         * Scripts/webkitdirs.pm:
1752         (isPerianInstalled): Deleted.
1753         (determineIPhoneSimulatorVersion): Deleted.
1754         (iPhoneSimulatorVersion): Deleted.
1755         (isSnowLeopard): Deleted.
1756         (isLion): Deleted.
1757         (quitIOSSimulator): Deleted.
1758
1759 2014-09-15  Roger Fong  <roger_fong@apple.com>
1760
1761         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
1762         https://bugs.webkit.org/show_bug.cgi?id=25160
1763
1764         * Scripts/run-javascriptcore-tests:
1765
1766 2014-09-15  Lucas Forschler  <lforschler@apple.com>
1767
1768         Add another Apple build slave to the Mountain Lion Debug WK1 queue
1769         
1770         Rubber stamped by Matt Hanson.
1771         
1772         * BuildSlaveSupport/build.webkit.org-config/config.json:
1773
1774 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1775
1776         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
1777         https://bugs.webkit.org/show_bug.cgi?id=136822
1778
1779         Reviewed by Gyuyoung Kim.
1780
1781         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
1782         initialized as we already does it in PlatformWebView::PlatformWebView
1783         calling ewk_init(). The reason for that was to ensure testing for example,
1784         WTF where creating the view is not mandatory.
1785
1786         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
1787         in order to properly initalize and release EWebKit.
1788
1789         * TestWebKitAPI/PlatformEfl.cmake:
1790         * TestWebKitAPI/efl/PlatformWebView.cpp:
1791         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1792         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1793         * TestWebKitAPI/efl/main.cpp:
1794         (main):
1795
1796 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
1797
1798         [WinCairo] Make it easier to enable/disable GStreamer.
1799         https://bugs.webkit.org/show_bug.cgi?id=135766
1800
1801         Reviewed by Brent Fulgham.
1802
1803         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
1804
1805         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
1806
1807 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
1808
1809         Web Inspector: remind about rebaselining generator test results
1810         https://bugs.webkit.org/show_bug.cgi?id=136759
1811
1812         Reviewed by Joseph Pecoraro.
1813
1814         For now, we can implement this as a watchlist message. Add watchlist
1815         groups and messages for the inspector and web replay generators.
1816
1817         * Scripts/webkitpy/common/config/watchlist:
1818
1819 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
1820
1821         build.webkit.org/dashboard: Overlapping text when status is long
1822         https://bugs.webkit.org/show_bug.cgi?id=136794
1823
1824         Reviewed by Timothy Hatcher.
1825
1826         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1827         (.status-line): Replaces height with min-height.
1828
1829 2014-09-12  Timothy Hatcher  <timothy@apple.com>
1830
1831         Make Brian Burg a WebKit reviewer.
1832
1833         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
1834
1835 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
1836
1837         Multiple EWS or commit bots can pick up processing of the same patch
1838         https://bugs.webkit.org/show_bug.cgi?id=136793
1839
1840         Reviewed by Ryosuke Niwa.
1841
1842         Change timeout from one hour to two hours. This will let bots finish, and in the
1843         unlikely event of a bot being frozen, will only delay patch processing restart by
1844         one hour.
1845
1846         * QueueStatusServer/app.yaml:
1847         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
1848
1849 2014-09-11  Andy Estes  <aestes@apple.com>
1850
1851         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
1852         https://bugs.webkit.org/show_bug.cgi?id=136768
1853
1854         Reviewed by Tim Horton.
1855
1856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1857         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
1858         (TestWebKitAPI::TEST):
1859
1860 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1861
1862         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
1863         https://bugs.webkit.org/show_bug.cgi?id=136669
1864
1865         Reviewed by Antti Koivisto.
1866
1867         * Scripts/run-gtk-tests:
1868         (TestRunner): Unskip SSL test.
1869
1870 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
1871
1872         Strip extraneous AVFoundation and CoreMedia logging
1873         https://bugs.webkit.org/show_bug.cgi?id=136747
1874
1875         Reviewed by Jer Noble.
1876
1877         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1878         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
1879
1880         * Scripts/webkitpy/port/base.py:
1881         (Port.stderr_patterns_to_strip): Base class, empty list
1882
1883         * Scripts/webkitpy/port/driver.py:
1884         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
1885
1886         * Scripts/webkitpy/port/ios.py:
1887         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
1888
1889         * Scripts/webkitpy/port/mac.py:
1890         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
1891
1892
1893 2014-09-11  Michael Saboff  <msaboff@apple.com>
1894
1895         lldb_webkit.py:btjs doesn't work with release builds
1896         https://bugs.webkit.org/show_bug.cgi?id=136760
1897
1898         Reviewed by Jer Noble.
1899
1900         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
1901         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
1902         we can't get a valid result from trying either call.  In that case, we fallback to
1903         just showing the PC.  Also added check for both entry points.  If neither is found,
1904         we issue a warning and output the stack trace without JavaScript annotations.
1905
1906         * lldb/lldb_webkit.py:
1907         (btjs):
1908
1909 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
1910
1911         webkitpy test failures from import-w3c-tests
1912         https://bugs.webkit.org/show_bug.cgi?id=136752
1913
1914         Reviewed by Bem Jones-Bey.
1915
1916         This patch fixes a bug in import-w3c-tests where we were appending
1917         the wrong set of files to the copy_list. This also updates the tests
1918         to clear the failures introduced in the patch for bug 135929.
1919
1920         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1921         (W3CTestConverterTest.test_read_prefixed_property_list):
1922         * Scripts/webkitpy/w3c/test_parser.py:
1923         (TestParser.analyze_test):
1924         (TestParser.support_files):
1925         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1926
1927 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
1928
1929         Blink merge: Speculative fix for windows run-webkit-tests hangs
1930         https://bugs.webkit.org/show_bug.cgi?id=136727
1931
1932         Reviewed by Csaba Osztrogonác.
1933
1934         Merged from Blink (patch by Dirk Pranke):
1935         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
1936
1937         * Scripts/webkitpy/common/system/executive.py:
1938         (Executive.kill_process):
1939
1940 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1941
1942         Added myself as a committer.
1943
1944         Unreviewed.
1945
1946         * Scripts/webkitpy/common/config/contributors.json:
1947
1948 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
1949
1950         [JavaScriptCore] Fix FTL on platform EFL.
1951         https://bugs.webkit.org/show_bug.cgi?id=133571
1952
1953         Reviewed by Filip Pizlo.
1954
1955         * efl/install-dependencies: Revert r169181.
1956         * efl/jhbuild.modules: Clone and build a custom branch.
1957         This branch contains some fix for FTL of platform EFL.
1958         The branch is a fork of llvm r206311.
1959
1960 2014-09-10  Tanay C  <tanay.c@samsung.com>
1961
1962         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
1963         https://bugs.webkit.org/show_bug.cgi?id=136698
1964
1965         Reviewed by Gyuyoung Kim.
1966
1967         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
1968         (on_mouse_wheel): Added.
1969         (window_free):
1970         (window_create):
1971
1972 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
1973
1974         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
1975         https://bugs.webkit.org/show_bug.cgi?id=136284
1976
1977         Reviewed by Gyuyoung Kim.
1978
1979         * MiniBrowser/efl/main.c:
1980         (window_create):
1981
1982 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
1983
1984         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
1985         https://bugs.webkit.org/show_bug.cgi?id=135929
1986
1987         Reviewed by Bem Jones-Bey.
1988
1989         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
1990         were made when this script was originally written with respect to relative paths
1991         in ref files. This patch updates import-w3c-tests to update paths in ref files if
1992         they move relative to the test file.
1993
1994
1995         * Scripts/webkitpy/w3c/test_converter.py:
1996         (convert_for_webkit):
1997         (_W3CTestConverter.__init__):
1998         (_W3CTestConverter.convert_reference_relpaths):
1999         (_W3CTestConverter.convert_style_data):
2000         (_W3CTestConverter.convert_attributes_if_needed):
2001         * Scripts/webkitpy/w3c/test_importer.py:
2002         (TestImporter.find_importable_tests):
2003         (TestImporter.import_tests):
2004         * Scripts/webkitpy/w3c/test_parser.py:
2005         (TestParser.load_file):
2006         (TestParser.analyze_test):
2007         (TestParser.support_files):
2008
2009 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2010
2011         [GTK] allow overwriting destination of download
2012         https://bugs.webkit.org/show_bug.cgi?id=136372
2013
2014         Reviewed by Carlos Garcia Campos.
2015
2016         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2017         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
2018         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
2019         (createFileAtDestination): Added
2020         (testDownloadOverwriteDestinationAllowed): Added
2021         (testDownloadOverwriteDestinationDisallowed): Added
2022         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
2023         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
2024         (beforeAll): New tests
2025
2026 2014-08-05  David Farler  <dfarler@apple.com>
2027
2028         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
2029         https://bugs.webkit.org/show_bug.cgi?id=135551
2030
2031         Reviewed by Daniel Bates.
2032
2033         Prevent printing invalid Unicode strings going to stderr.
2034         Also, make filesystem.py more tolerant about receiving
2035         Unicode (encoded as UTF-8) when writing to files, in the
2036         rare case that an NSError description will make it to
2037         stderr, such as -[LTRelayController createUniqueApp].
2038
2039         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2040         (-[LTRelayController launchSimulator]): Removed.
2041         (-[LTRelayController createUniqueApp]):
2042         Don't explicitly try to uninstall the app. It is automatically handled
2043         when installing an app with the same bundle identifier.
2044         (-[LTRelayController start]):
2045         (-[LTRelayController bootDevice]): Removed.
2046         The device already boots as a part of starting the simulator. Attempting
2047         to boot a second time may cause spurious stderr output.
2048         * Scripts/webkitpy/port/driver.py:
2049         (IOSSimulatorDriver._setup_environ_for_driver):
2050         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
2051         Open the iOS Simulator once instead of the LayoutTestRelay trying
2052         to do it.
2053         * Scripts/webkitpy/port/ios.py:
2054         (IOSSimulatorPort._get_crash_log):
2055         Make sure stderr is at least an empty string.
2056         (IOSSimulatorPort):
2057         (IOSSimulatorPort.developer_dir):
2058         New property for setting up DEVELOPER_DIR in the driver environment.
2059
2060 2014-09-09  Dan Bernstein  <mitz@apple.com>
2061
2062         Clean up the MiniBrowser Xcode project
2063         https://bugs.webkit.org/show_bug.cgi?id=136684
2064
2065         Reviewed by Tim Horton.
2066
2067         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
2068         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
2069         WebKit2.framework. Upgraded project file version.
2070
2071 2014-09-09  Daniel Bates  <dbates@webkit.org>
2072
2073         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
2074         https://bugs.webkit.org/show_bug.cgi?id=136379
2075
2076         Reviewed by David Kilzer.
2077
2078         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
2079         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
2080         and sets a property on F (say, the executable bit).
2081
2082         * Scripts/svn-apply:
2083         (patch): Only add file if the diff has text chunks.
2084         * Scripts/svn-unapply:
2085         (patch): Only delete added file if the diff has text chunks.
2086
2087 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2088
2089         [GTK] Unreviewed GTK gardening.
2090
2091         * Scripts/run-gtk-tests:
2092         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
2093
2094 2014-09-09  Christophe Dumez  <cdumez@apple.com>
2095
2096         Update my email in contributors.json
2097         https://bugs.webkit.org/show_bug.cgi?id=136671
2098
2099         Reviewed by Andreas Kling.
2100
2101         * Scripts/webkitpy/common/config/contributors.json:
2102
2103 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2104
2105         [EFL] Enable fixed layout by default
2106         https://bugs.webkit.org/show_bug.cgi?id=136607
2107
2108         Reviewed by Csaba Osztrogonác.
2109
2110         Fixed layout is being used by Tizen platform by default. However, the feature
2111         has still many defects now. So, we need to enable it by default, then should fix
2112         those bugs. 
2113
2114         * MiniBrowser/efl/main.c:
2115
2116 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2117
2118         Remove FILTERS flag
2119         https://bugs.webkit.org/show_bug.cgi?id=136571
2120
2121         Reviewed by Darin Adler.
2122
2123         * Scripts/webkitperl/FeatureList.pm:
2124
2125 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
2126
2127         Dashboard metrics should ignore commits that didn't trigger builds
2128         https://bugs.webkit.org/show_bug.cgi?id=136618
2129
2130         Reviewed by Darin Adler.
2131
2132         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
2133         other platforms etc. It does not make sense to count wait time for these, as it
2134         can be arbitrarily long.
2135
2136         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
2137
2138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2139         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
2140
2141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2142         We used to walk the timeline to see which revisions are fully tested, but that's not
2143         correct. A revision that's only tested by a subset of queues finishes independently
2144         of another that's tested by another subset. Now, we just search for the answer for
2145         each revision individually.
2146
2147         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
2148         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
2149         the analyzer now reports. Removed best time, which is more confusing than meaningful.
2150
2151 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2152
2153         Remove EWebLauncher from webkitdirs.pm
2154         https://bugs.webkit.org/show_bug.cgi?id=136622
2155
2156         Reviewed by Gyuyoung Kim.
2157
2158         * Scripts/webkitdirs.pm:
2159         (launcherName):
2160
2161 2014-09-06  Sam Weinig  <sam@webkit.org>
2162
2163         XPCPtr should be converted into an all purpose smart pointer for os_objects
2164         https://bugs.webkit.org/show_bug.cgi?id=136602
2165
2166         Reviewed by Darin Adler.
2167
2168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2169         * TestWebKitAPI/Tests/WTF/darwin: Added.
2170         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
2171         Add basic unit tests for OSObjectPtr.
2172
2173 2014-09-06  Saam Barati  <saambarati1@gmail.com>
2174
2175         Unreviewed. Add myself as a committer.
2176
2177         * Scripts/webkitpy/common/config/contributors.json:
2178
2179 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2180
2181         Unreviewed, EFL build fix when SHARED_CORE is on.
2182
2183         * TestWebKitAPI/PlatformEfl.cmake:
2184
2185 2014-09-05  Lucas Forschler  <lforschler@apple.com>
2186
2187         <https://webkit.org/b/136586> Add bots to Apple build/test queues
2188         
2189         Reviewed by Daniel Bates.
2190
2191         * BuildSlaveSupport/build.webkit.org-config/config.json:
2192
2193 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
2194
2195         Buildbot metrics page gives wrong results after a new bot gets added
2196         https://bugs.webkit.org/show_bug.cgi?id=136516
2197
2198         Reviewed by Tim Horton.
2199
2200         Part 2: Fix elapsed times.
2201
2202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2203         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
2204         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
2205
2206 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2207
2208         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
2209         https://bugs.webkit.org/show_bug.cgi?id=136562
2210
2211         Reviewed by Martin Robinson.
2212
2213         * Scripts/run-gtk-tests:
2214         (TestRunner): Remove failure expectations for tests that now pass.
2215
2216 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2217
2218         Dashboard metrics page wastes a lot of time sorting iterations
2219         https://bugs.webkit.org/show_bug.cgi?id=136559
2220
2221         Reviewed by Tim Horton.
2222
2223         Also fixes comments here and there, and adds a missing "var".
2224
2225         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2226         (BuildbotIteration.prototype._parseData):
2227         (BuildbotIteration.prototype._updateWithData):
2228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2229         (BuildbotQueue.prototype.loadAll):
2230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2231         (Analyzer.prototype._countTimes):
2232
2233 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2234
2235         [GTK] Unreviewed GTK gardening.
2236
2237         * Scripts/run-gtk-tests:
2238         (TestRunner): Skip tests failing since r173272.
2239
2240 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
2241
2242         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
2243         https://bugs.webkit.org/show_bug.cgi?id=136561
2244
2245         Reviewed by Tim Horton.
2246         
2247         Log for calloc() and CGBitmapContextCreate() failures.
2248
2249         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2250         (createBitmapContext):
2251         (createBitmapContextFromWebView):
2252
2253 2014-09-04  Andy Estes  <aestes@apple.com>
2254
2255         Fix the Mac Production build after r173283.
2256
2257         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
2258
2259 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2260
2261         [Win] webkitpy test suite frequently fails to complete
2262         https://bugs.webkit.org/show_bug.cgi?id=136546
2263
2264         Reviewed by Daniel Bates.
2265
2266         Properly convert the ASCII crash log produced by ntsd into
2267         a unicode string as early as possible so that we handle it
2268         properly when generating our logs and other test support output.
2269
2270         We were mixing ASCII/unicode strings under Windows, which was
2271         causing test system failures when we processed some crash logs.
2272
2273         Also do a better job of handling garbage pid entries in the
2274         Cygwin lock files.
2275
2276         * Scripts/webkitpy/common/system/crashlogs.py:
2277         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
2278         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
2279         handle the strings as unicode from that point on.
2280         * Scripts/webkitpy/port/http_lock.py:
2281         (HttpLock._current_lock_pid): Add logging and handle case of
2282         the current_pid failing to cleanly convert to 'int'.
2283         * Scripts/webkitpy/port/win.py:
2284         (WinPort): Add 64-bit architecture as a known target for the
2285         Windows build.
2286
2287 2014-09-04  Andy Estes  <aestes@apple.com>
2288
2289         Address additional review feedback after landing r173283.
2290
2291         Reviewed by Daniel Bates.
2292
2293         * DumpRenderTree/config.h: Removed redundant includes.
2294         * TestWebKitAPI/config.h: Ditto.
2295         * WebKitTestRunner/config.h: Ditto.
2296
2297 2014-09-03  Andy Estes  <aestes@apple.com>
2298
2299         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
2300         https://bugs.webkit.org/show_bug.cgi?id=136521
2301
2302         Reviewed by Anders Carlsson.
2303
2304         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
2305         * TestWebKitAPI/config.h: Ditto.
2306         * WebKitTestRunner/config.h: Ditto.
2307
2308 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2309
2310         REGRESSION: Dashboard metrics page aggregation counts performance bots
2311         https://bugs.webkit.org/show_bug.cgi?id=136539
2312
2313         Reviewed by Tim Horton.
2314
2315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2316
2317 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2318
2319         [Win] Perl test fix.
2320
2321         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
2322         VersionStamp.exe tool, not just the driver script.
2323
2324 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2325
2326         Remove CSS_FILTERS flag
2327         https://bugs.webkit.org/show_bug.cgi?id=136529
2328
2329         Reviewed by Dirk Schulze.
2330
2331         * Scripts/webkitperl/FeatureList.pm:
2332
2333 2014-09-04  Commit Queue  <commit-queue@webkit.org>
2334
2335         Unreviewed, rolling out r173201.
2336         https://bugs.webkit.org/show_bug.cgi?id=136538
2337
2338         Improves the situation but also introduces additional crashes.
2339         (Requested by zdobersek on #webkit).
2340
2341         Reverted changeset:
2342
2343         "GMainLoopSource is exposed to race conditions"
2344         https://bugs.webkit.org/show_bug.cgi?id=135800
2345         http://trac.webkit.org/changeset/173201
2346
2347 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2348
2349         Buildbot metrics page gives wrong results after a new bot gets added
2350         https://bugs.webkit.org/show_bug.cgi?id=136516
2351
2352         Part 1: Fix red/green counters. Dashboard is considered green at a given time
2353         if all the bots that ever had results before this time are green.
2354
2355         This doesn't (and cannot) address situations where the bot gets removed and then
2356         re-added. It also gives wrong results after a bot gets removed, because it doesn't
2357         know that it was ever displayed on the dashboard.
2358
2359         Reviewed by Darin Adler.
2360
2361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2362         (Analyzer.prototype._dashboardIsAllGreen):
2363         (Analyzer.prototype._updateStretchOfRedCounters):
2364         (Analyzer.prototype._countPercentageOfGreen):
2365         (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
2366
2367 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2368
2369         [Win] Unreviewed test fix.
2370
2371         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
2372         test if user doesn't have the VersionStamp.exe program.
2373
2374 2014-09-03  Dana Burkart  <dburkart@apple.com>
2375
2376         Unreviewed. Add myself as a committer.
2377
2378         * Scripts/webkitpy/common/config/contributors.json:
2379
2380 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2381
2382         build.webkit.org/dashboard performance popover is unstyled
2383         https://bugs.webkit.org/show_bug.cgi?id=136499
2384
2385         Reviewed by Tim Horton.
2386
2387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2388         (.performance-popover):
2389         (.performance-popover .dashboard-link):
2390
2391 2014-09-03  Saam Barati  <saambarati1@gmail.com>
2392
2393         Create tests for type profiling
2394         https://bugs.webkit.org/show_bug.cgi?id=136161
2395
2396         Reviewed by Geoffrey Garen.
2397
2398         Have run-javascriptcore-tests run the newly created
2399         tests for the type profiler.
2400
2401         * Scripts/run-javascriptcore-tests:
2402         * Scripts/run-jsc-stress-tests:
2403
2404 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2405
2406         [Win] Revise test environment for Windows build.
2407         https://bugs.webkit.org/show_bug.cgi?id=136486
2408
2409         Reviewed by David Kilzer.
2410
2411         The various calls to get the Safari path really only have
2412         meaning on the Mac. Other ports get access to the build
2413         and test environment separately, so remove the various
2414         checks in the Safari-specific code to simplify things.
2415
2416         Remove some 64-bit hacks used on Windows now that the
2417         various tools know how to find the 64-bit runtime environment.
2418
2419         * Scripts/run-javascriptcore-tests: 
2420         * Scripts/webkitdirs.pm:
2421         (safariPathFromSafariBundle): Revise to expect Mac.
2422         (installedSafariPath): Ditto.
2423         (safariPath): Ditto.
2424         (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
2425         (setPathForRunningWebKitApp): Get rid of unused SafariPath
2426         argument for Windows runs.
2427
2428 2014-09-03  Dana Burkart  <dburkart@apple.com>
2429
2430         Dashboard should show performance bots.
2431         https://bugs.webkit.org/show_bug.cgi?id=136386
2432
2433         Reviewed by Alexey Proskuryakov.
2434
2435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2436         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
2437         (BuildbotIteration.prototype._parseData):
2438         Support possible performance failures.
2439
2440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2441         New QueueView to manage the way we present performance data.
2442
2443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2444         (BuildbotQueue):
2445         Support new 'performance' and 'performanceTestName' keys.
2446
2447
2448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2449         Add performance column to the main page.
2450
2451         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2452         (WebKitBuildbot):
2453         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2454         (body):
2455         Make sure everything fits on 13 inch screens.
2456
2457         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2458
2459 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
2460
2461         GMainLoopSource is exposed to race conditions
2462         https://bugs.webkit.org/show_bug.cgi?id=135800
2463
2464         Reviewed by Carlos Garcia Campos.
2465
2466         Add a unit test for GMainLoopSource that tests different
2467         types of rescheduling tasks on already-active sources.
2468
2469         * TestWebKitAPI/PlatformGTK.cmake:
2470         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
2471         (GMainLoopSourceTest::GMainLoopSourceTest):
2472         (GMainLoopSourceTest::~GMainLoopSourceTest):
2473         (GMainLoopSourceTest::runLoop):
2474         (GMainLoopSourceTest::finish):
2475         (GMainLoopSourceTest::source):
2476         (testGMainLoopSourceBasicRescheduling):
2477         (testGMainLoopSourceReentrantRescheduling):
2478         (testGMainLoopSourceDifferentThreadRescheduling):
2479         (beforeAll):
2480         (afterAll):
2481         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
2482         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
2483         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
2484         (TestWebKitAPI::GMainLoopSourceTest::finish):
2485         (TestWebKitAPI::GMainLoopSourceTest::source):
2486         (TestWebKitAPI::TEST):
2487
2488 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
2489
2490         Make sure WK1 prefs are initialized in MiniBrowser
2491         https://bugs.webkit.org/show_bug.cgi?id=136465
2492
2493         Reviewed by Tim Horton.
2494         
2495         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
2496         for WK2 windows, to make sure that WebPreferences are updated (to get
2497         layer borders to work consistently).
2498
2499         * MiniBrowser/mac/WK1BrowserWindowController.m:
2500         (-[WK1BrowserWindowController awakeFromNib]):
2501
2502 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
2503
2504         check-webkit-style should complain about C++ comments in Platform.h
2505         https://bugs.webkit.org/show_bug.cgi?id=133802
2506
2507         Reviewed by Csaba Osztrogonác.
2508
2509         * Scripts/webkitpy/style/checkers/cpp.py:
2510         (check_platformh_comments):
2511         (_process_lines):
2512         (CppChecker):
2513         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2514         (CppStyleTest.test_platformh_comment):
2515
2516 2014-09-02  Brendan Long  <self@brendanlong.com>
2517
2518         [Gtk] Make install-dependencies work on Arch Linux
2519         https://bugs.webkit.org/show_bug.cgi?id=136374
2520
2521         Reviewed by Philippe Normand.
2522
2523         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
2524
2525 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
2526
2527         Provide column numbers to DTrace willExecute/didExecute probes
2528         https://bugs.webkit.org/show_bug.cgi?id=136434
2529
2530         Reviewed by Antti Koivisto.
2531
2532         Create a directory for DTrace scripts. Add an example script that
2533         shows how to use static probes provided by JavaScriptCore's profiler.
2534
2535         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
2536
2537 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2538
2539         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
2540         https://bugs.webkit.org/show_bug.cgi?id=136431
2541
2542         Reviewed by Martin Robinson.
2543
2544         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
2545         Add missing dependencies for librsvg (glib and cairo).
2546
2547 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2548
2549         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
2550         https://bugs.webkit.org/show_bug.cgi?id=136425
2551
2552         Reviewed by Martin Robinson.
2553
2554         * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
2555
2556 2014-09-01  Ryuan Choi  <ryuan.choi@samsung.com>
2557
2558         Update my list of email addresses in contributors.json
2559         https://bugs.webkit.org/show_bug.cgi?id=136424
2560
2561         Reviewed by Gyuyoung Kim.
2562
2563         * Scripts/webkitpy/common/config/contributors.json:
2564
2565 2014-08-30  Filip Pizlo  <fpizlo@apple.com>
2566
2567         [RJST] eager-no-cjit should really mean eager
2568         https://bugs.webkit.org/show_bug.cgi?id=136407
2569
2570         Reviewed by Mark Hahnenberg.
2571         
2572         At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
2573         and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
2574         after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
2575         all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
2576         threshold setting that NO_CJIT_OPTIONS was currently setting
2577         (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
2578         NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
2579         
2580         Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
2581
2582         * Scripts/run-jsc-stress-tests:
2583
2584 2014-08-29  Daniel Bates  <dabates@apple.com>
2585
2586         [iOS] Configure Xcode to build a command line tool for the iOS Simulator
2587         https://bugs.webkit.org/show_bug.cgi?id=136388
2588
2589         Reviewed by David Kilzer.
2590
2591         Add a script, called configure-xcode-for-ios-development, to configure Xcode to
2592         support building a command line tool for the iOS Simulator. You must run this
2593         script as root.
2594
2595         The script uses the xcspec files in the OS X SDK to create xcspec files in the
2596         iOS Simulator SDK with the product- and package- type definitions to build a
2597         command line tool, if applicable.
2598
2599         * Scripts/configure-xcode-for-ios-development: Added.
2600
2601 2014-08-29  Tim Horton  <timothy_horton@apple.com>
2602
2603         Remove Windows WebKit2 code from TestWebKitAPI
2604         https://bugs.webkit.org/show_bug.cgi?id=136385
2605
2606         Reviewed by Alexey Proskuryakov.
2607
2608         * TestWebKitAPI/PlatformUtilities.h:
2609         * TestWebKitAPI/PlatformWebView.h:
2610         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
2611         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2612         (TestWebKitAPI::TEST): Deleted.
2613         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2614         (TestWebKitAPI::TEST):
2615         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2616         (TestWebKitAPI::TEST):
2617         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
2618         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
2619         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
2620         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
2621         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
2622         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
2623         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
2624
2625 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2626
2627         [JSC] Some JSC tests are dependent on the machine time zone.
2628         https://bugs.webkit.org/show_bug.cgi?id=136363
2629
2630         Reviewed by Filip Pizlo.
2631
2632         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
2633         Unskip the tests that were skipped on r99580.
2634
2635 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2636
2637         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
2638         https://bugs.webkit.org/show_bug.cgi?id=135560
2639
2640         Reviewed by Gyuyoung Kim.
2641
2642         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
2643
2644 2014-08-28  Daniel Bates  <dabates@apple.com>
2645
2646         [Win] update-webkit should update auxiliary libs by default
2647
2648         Reviewed by Dan Bernstein.
2649
2650         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
2651         from updating the Windows auxiliary libs by default. We should make update-webkit update the
2652         Windows auxiliary libs by default. This will make its behavior match its usage text.
2653
2654         * Scripts/update-webkit:
2655
2656 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
2657
2658         build-webkit --inspector-frontend tries to copy files from old inspector path
2659         https://bugs.webkit.org/show_bug.cgi?id=136346
2660
2661         Reviewed by Timothy Hatcher.
2662
2663         Remove the old code path for copying inspector resources. It doesn't work.
2664         Complain if this option is passed to CMake-based builds.
2665
2666         * Scripts/build-webkit:
2667         * Scripts/webkitdirs.pm:
2668         (copyInspectorFrontendFiles): Deleted.
2669
2670 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
2671
2672         Dashboard metrics page could show longest stretch of red
2673         https://bugs.webkit.org/show_bug.cgi?id=136334
2674
2675         Reviewed by Sam Weinig.
2676
2677         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2678         (Analyzer.prototype._updateStretchOfRedCounters):
2679         (Analyzer.prototype._countPercentageOfGreen):
2680         When counting percentage of green, also keep track of how long the page was red.
2681
2682         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
2683         (MetricsView.prototype._update.addDivider):
2684         (MetricsView.prototype._update.appendQueueResults):
2685         Show it in aggregate queues (can't think of a reason to have it in individual ones).
2686
2687         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
2688         Changed to use an explicit divider element between green time and performance groups,
2689         as there are too many combinations to easily express in CSS.
2690
2691 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2692
2693         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
2694         https://bugs.webkit.org/show_bug.cgi?id=136248
2695
2696         Reviewed by Gustavo Noronha Silva.
2697
2698         Add new test case for webkit_uri_response_get_http_headers().
2699
2700         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2701         (testURIResponseHTTPHeaders):
2702         (serverCallback):
2703         (beforeAll):
2704
2705 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2706
2707         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
2708         https://bugs.webkit.org/show_bug.cgi?id=131668
2709
2710         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2711         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
2712
2713 2014-08-27  Zalan Bujtas  <zalan@apple.com>
2714
2715         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
2716         https://bugs.webkit.org/show_bug.cgi?id=136264
2717
2718         Reviewed by Simon Fraser.
2719         
2720         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
2721         functions. ->snappedIntSize()/snapSizeToDevicePixel().
2722         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
2723
2724         Covered by existing tests.
2725
2726         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2727         (TestWebKitAPI::TEST): Deleted.
2728
2729 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2730
2731         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
2732         https://bugs.webkit.org/show_bug.cgi?id=131668
2733
2734         Reviewed by Daniel Bates.
2735
2736         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
2737         to not just hardcode.
2738
2739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2740         (EWS.prototype.queueStatusURL): Added.
2741
2742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2743         (EWSQueue.prototype.get statusPageURL): Use the above function.
2744         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
2745
2746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2747         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
2748         are no patches in the queue. The popover has other useful information, such as charts
2749         link and bot status.
2750
2751 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2752
2753         https://bugs.webkit.org/show_bug.cgi?id=136317
2754         Dashboard metrics page sometimes shows 0 for best time
2755
2756         Reviewed by Tim Horton.
2757
2758         This also affects regular dashboard display in a good way - iterations that failed
2759         due to infrastructure misbehavior will more reliably show up as yellow and not red.
2760
2761         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2762         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
2763         updated if we rename steps.
2764         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
2765         do it once.
2766         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
2767         that failed e.g. at downloading built archive step are not productive.
2768
2769 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
2770
2771         [Win] Unreviewed gardening.
2772
2773         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
2774         of logs assembled into the final build output.
2775
2776 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2777
2778         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
2779         https://bugs.webkit.org/show_bug.cgi?id=136196
2780
2781         Reviewed by Timothy Hatcher.
2782
2783         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
2784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
2785         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
2786         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
2787         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
2788         A date range picker control with dependencies.
2789         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
2790         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
2791         (it didn't happen again upon re-opening the picker).
2792         - Made made style tweaks to match Dashboard UI.
2793
2794         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2795         Don't create objects that are not needed by the given app, and thus are not loaded at all.
2796
2797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
2798         Math to count all the things. Only supports open source tree and trunk at the moment,
2799         but written with internal tree and branches in mind.
2800
2801         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
2802         Like dashboard Main.js, draws the UI and creates all necessary objects.
2803
2804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
2805         A view for table cells.
2806
2807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2808         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
2809         Metrics page has individual platforms initially scrolled away form the view, so 
2810         it needs to scroll down to reveal what's being configured.
2811
2812         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2813         Added Array.prototype.average and Array.prototype.median.
2814
2815         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2816         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
2817         in settings mode.
2818
2819         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
2820         Additional style rules.
2821
2822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
2823         The metrics page.
2824
2825 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2826
2827         Remove networkinfo watch category in watchlist
2828         https://bugs.webkit.org/show_bug.cgi?id=136279
2829
2830         Reviewed by Alexey Proskuryakov.
2831
2832         Network info was removed. So, it is not needed anymore.
2833
2834         * Scripts/webkitpy/common/config/watchlist:
2835
2836 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
2837
2838         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
2839         https://bugs.webkit.org/show_bug.cgi?id=136281
2840
2841         Reviewed by Tim Horton.
2842
2843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2844         Track and expose whether the itertion is being loaded. Made update() a no-op if
2845         the iteration is already being loaded.
2846
2847         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2848         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
2849         loading everything at once, ask the queue to load a little more. We can always repeat
2850         if we still don't have enough data.
2851
2852         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2853         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
2854         10 more iterations intelligently.
2855
2856 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
2857
2858         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
2859         https://bugs.webkit.org/show_bug.cgi?id=136283
2860
2861         Reviewed by Tim Horton.
2862
2863         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2864         Don't.
2865
2866 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
2867
2868         build.webkit.org/dashboard raises an exception after a hidden platform is removed
2869         https://bugs.webkit.org/show_bug.cgi?id=136282
2870
2871         Reviewed by Tim Horton.
2872
2873         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2874         (updateHiddenPlatforms): Check that the platform is still valid.
2875
2876 2014-08-26  Matt Lilek  <mrl@apple.com>
2877
2878         Add WebKit SPI to control the navigator.standalone property
2879         https://bugs.webkit.org/show_bug.cgi?id=136189
2880
2881         Reviewed by Andy Estes.
2882
2883         Add API test for WKPreferences
2884
2885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2886         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2887         (TEST):
2888
2889 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2890
2891         Remove ENABLE_DRT environment variable to enable SHARED_CORE
2892         https://bugs.webkit.org/show_bug.cgi?id=136205
2893
2894         Reviewed by Andrei Bucur.
2895
2896         EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
2897         use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
2898
2899         * Scripts/webkitdirs.pm:
2900         (generateBuildSystemFromCMakeProject):
2901
2902 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
2903
2904         [Win] Version stamp should include package-level version
2905         https://bugs.webkit.org/show_bug.cgi?id=136266
2906         <rdar://problem/18134138>
2907
2908         Reviewed by David Kilzer.
2909
2910         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
2911         tests for the full 3+ digit version.
2912         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
2913         Confirm that the final output DLL uses the 3+ digit version.
2914
2915 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
2916
2917         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
2918         https://bugs.webkit.org/show_bug.cgi?id=136258
2919         <rdar://problem/18134138>
2920
2921         Reviewed by Tim Horton.
2922
2923         Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
2924         values from passing through the 32-bit OLE_HANDLE data type.
2925
2926         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2927         (AccessibilityController::rootElement):
2928         * DumpRenderTree/win/DumpRenderTree.cpp:
2929         (resetWebViewToConsistentStateBeforeTesting):
2930         (runTest):
2931         (createWebViewAndOffscreenWindow):
2932         * DumpRenderTree/win/FrameLoadDelegate.h:
2933         (FrameLoadDelegate::didReceiveIcon):
2934         * DumpRenderTree/win/TestRunnerWin.cpp:
2935         (TestRunner::setWindowIsKey):
2936         * DumpRenderTree/win/UIDelegate.cpp:
2937         (UIDelegate::trackCustomPopupMenu):
2938         (UIDelegate::drawHeaderInRect):
2939         (UIDelegate::drawFooterInRect):
2940         (UIDelegate::webViewClose):
2941         (UIDelegate::webViewFocus):
2942         (UIDelegate::webViewSetCursor):
2943         (UIDelegate::drawBackground):
2944         * DumpRenderTree/win/UIDelegate.h:
2945         (UIDelegate::webViewFirstResponder):
2946         (UIDelegate::makeFirstResponder):
2947         (UIDelegate::contextMenuItemsForElement):
2948         (UIDelegate::addCustomMenuDrawingData):
2949         (UIDelegate::cleanUpCustomMenuDrawingData):
2950         (UIDelegate::webViewLostFocus):
2951         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2952         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
2953         * WinLauncher/PrintWebUIDelegate.cpp:
2954         (PrintWebUIDelegate::drawHeaderInRect):
2955         (PrintWebUIDelegate::drawFooterInRect):
2956         * WinLauncher/PrintWebUIDelegate.h:
2957         (PrintWebUIDelegate::webViewFirstResponder):
2958         (PrintWebUIDelegate::makeFirstResponder):
2959         (PrintWebUIDelegate::contextMenuItemsForElement):
2960         (PrintWebUIDelegate::trackCustomPopupMenu):
2961         (PrintWebUIDelegate::addCustomMenuDrawingData):
2962         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
2963         * WinLauncher/WinLauncher.cpp:
2964         (WinLauncher::prepareViews):
2965         * WinLauncher/WinLauncherWebHost.h:
2966         (WinLauncherWebHost::didReceiveIcon):
2967
2968 2014-08-26  Daniel Bates  <dabates@apple.com>
2969
2970         Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
2971
2972         Rubber-stamped by Tim Horton.
2973
2974         The Windows and iOS ports are the only ports that make use of WebCore headers
2975         in DumpRenderTree.
2976
2977         * DumpRenderTree/config.h:
2978
2979 2014-08-26  Dan Bernstein  <mitz@apple.com>
2980
2981         runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
2982         https://bugs.webkit.org/show_bug.cgi?id=136254
2983
2984         Reviewed by Tim Horton.
2985
2986         * Scripts/webkitdirs.pm:
2987         (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
2988         not the invoking script.
2989
2990 2014-08-26  Krzysztof Czech  <k.czech@samsung.com>
2991
2992         [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
2993         https://bugs.webkit.org/show_bug.cgi?id=136127
2994
2995         Reviewed by Gyuyoung Kim.
2996
2997         Add espeak dependency.
2998
2999         * efl/install-dependencies:
3000
3001 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3002
3003         Remove a little more accidentally landed code from r172891.
3004
3005         iteration.branch also wasn't meant to be landed.
3006
3007         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3008         (BuildbotIteration.prototype._parseData):
3009
3010 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3011
3012         REGRESSION (r172891): Internal dashboard is broken.
3013
3014         Removing some accidentally landed code - I needed "changes" for another patch, but
3015         not here, and then I decided to not use it anyway.
3016
3017         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3018         (BuildbotIteration.prototype._parseData):
3019
3020 2014-08-25  Daniel Bates  <dabates@apple.com>
3021
3022         Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
3023         (https://bugs.webkit.org/show_bug.cgi?id=136108)
3024
3025         Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
3026         so that we can compile DumpRenderTree for iOS.
3027
3028         * DumpRenderTree/config.h:
3029
3030 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3031
3032         Make build.webkit.org/dashboard work with changeset_show_files=location
3033         https://bugs.webkit.org/show_bug.cgi?id=136237
3034
3035         Reviewed by Tim Horton.
3036
3037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3038         (Trac.prototype._convertCommitInfoElementToObject): Remove location information
3039         from description before getting title, and also actually parse the location into
3040         result object when available.
3041
3042         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3043         (String.prototype.startsWith): Added.
3044
3045 2014-08-25  Tanay C  <tanay.c@samsung.com>
3046
3047         [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
3048         https://bugs.webkit.org/show_bug.cgi?id=135795
3049
3050         Reviewed by Gyuyoung Kim.
3051
3052         * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
3053         (history_list_hide): Hiding and dereferencing the history list and items
3054         (on_key_down):
3055         (on_mouse_down):
3056         (on_back_button_clicked): Early return for longpress 
3057         (on_forward_button_clicked): Early return for longpress 
3058         (list_item_label_get): Populate item labels
3059         (on_list_item_select): Navigates on selection from history list
3060         (navigation_button_longpress_process): Populates the history list and displays it
3061         (on_forward_button_longpress):
3062         (on_back_button_longpress):
3063         (window_create): Add the widget for history list
3064
3065 2014-08-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3066
3067         [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
3068         https://bugs.webkit.org/show_bug.cgi?id=136152
3069
3070         Reviewed by Philippe Normand.
3071
3072         * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
3073         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
3074         Cherry pick upstream patches daa194 and 4e3d101.
3075
3076 2014-08-24  Zan Dobersek  <zdobersek@igalia.com>
3077
3078         GenericHashTraits::peek() is producing copies of passed-in temporary values
3079         https://bugs.webkit.org/show_bug.cgi?id=131461
3080
3081         Reviewed by Darin Adler.
3082
3083         Add a test case that checks the number of copies and moves of the mapped objects
3084         when calling HashMap::get(). Exactly one copy of the mapped value should be
3085         performed when there exists a value that is mapped to the specified key, and
3086         exactly one move and no copies of the empty value should be performed when there
3087         isn't any mapped value for the specified key.
3088
3089         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
3090         (CopyMoveCounter::TestingScope::TestingScope):
3091         (CopyMoveCounter::CopyMoveCounter):
3092         (CopyMoveCounter::operator=):
3093         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3094         (TestWebKitAPI::TEST):
3095
3096 2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
3097
3098         [EFL] Introduce DEVELOPER_MODE
3099         https://bugs.webkit.org/show_bug.cgi?id=135884
3100
3101         Reviewed by Gyuyoung Kim.
3102
3103         * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
3104         (generateBuildSystemFromCMakeProject):
3105
3106 2014-08-24  Alexey Proskuryakov  <ap@apple.com>
3107
3108         build.webkit.org/dashboard unnecessarily loads results of hidden queues
3109         https://bugs.webkit.org/show_bug.cgi?id=136195
3110
3111         Reviewed by Tim Horton.
3112
3113         This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
3114
3115         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3116         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3117         Don't start an update just because a queue object was created. Periodic updates
3118         are triggered by views, so it only makes sense to do the same for the initial update.
3119
3120         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3121         Now that Trac object doesn't auto-load, start loading here.
3122
3123         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3124         (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
3125         a data member added by subclasses later. With this.platform being undefined, it
3126         always looked like this queue was not hidden.
3127         (QueueView.prototype._updateHiddenState): Start an immediate update, too.
3128
3129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3130         (Trac): Don't load anything here, the client may choose to load a custom date range.
3131         (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
3132
3133 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
3134
3135         build.webkit.org/dashboard: Further improve Trac loading
3136         https://bugs.webkit.org/show_bug.cgi?id=136174
3137
3138         Reviewed by Timothy Hatcher.
3139
3140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3141         (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
3142         error, the oldest commit within the range wasn't returned. The correct argument for
3143         "no limit" is 0.
3144         (Trac.prototype.load): Added a function to load a specific time range.
3145         (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
3146         positioned with regards to ones that were already known.
3147
3148 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
3149
3150         build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
3151         https://bugs.webkit.org/show_bug.cgi?id=136182
3152
3153         Reviewed by Timothy Hatcher.
3154
3155         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3156         Make it possible to create a complete BuildbotIteration object with JSON, not only by
3157         loading data from the network.
3158
3159         An iteration has three states:
3160         1. Just created, it only knows the revision, and whether it's already finished.
3161         BuildbotIteration constructor used to create these.
3162         2. A complete JSON report loaded from buildbot. The new constructor form creates these.
3163         3. Data about tests is fetched.
3164
3165         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3166         Make it possible to pull all data from a buildbot queue. This needs to be better
3167         optimized eventually, as it's somewhat slow.
3168
3169 2014-08-22  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3170
3171         Remove LevelDB.
3172         https://bugs.webkit.org/show_bug.cgi?id=136170
3173
3174         Reviewed by Gyuyoung Kim.
3175
3176         * Scripts/webkitpy/common/config/watchlist:
3177         * Scripts/webkitpy/style/checker.py:
3178
3179 2014-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3180
3181         [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
3182         https://bugs.webkit.org/show_bug.cgi?id=136153
3183
3184         Reviewed by Martin Robinson.
3185
3186         * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
3187
3188 2014-08-21  Alex Christensen  <achristensen@webkit.org>
3189
3190         [Win] Another unreviewed build fix.
3191
3192         * DumpRenderTree/config.h:
3193         Defined WEBCORE_EXPORT on Windows.
3194
3195 2014-08-21  Rohit Kumar  <kumar.rohit@samsung.com>
3196
3197         [EFL][WK2] Minibrowser : Add stop button to abort page load
3198         https://bugs.webkit.org/show_bug.cgi?id=136122
3199
3200         Reviewed by Gyuyoung Kim.
3201
3202         * MiniBrowser/efl/main.c:
3203         (on_key_down):
3204         (on_stop_button_clicked): Callback for stop button press.
3205         (window_create):
3206
3207 2014-08-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3208
3209         [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
3210         https://bugs.webkit.org/show_bug.cgi?id=134070
3211
3212         Reviewed by Martin Robinson.
3213
3214         * Scripts/webkitpy/port/base.py:
3215         (Port.__init__): Set default _jhbuild_wrapper variable.
3216         (Port._should_use_jhbuild): Implement generic check.
3217         * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
3218         to make it consistent with the other ports.
3219         * Scripts/webkitpy/port/gtk.py:
3220         (GtkPort.__init__): Use the new _should_use_jhbuild() method.
3221         (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
3222         querying the jhbuild with printenv. Also check that the path contains
3223         the libraries we expect. Preload this path only for XvfbDriver.
3224         * Scripts/webkitpy/port/xvfbdriver.py:
3225         (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
3226         (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
3227         configured at setup_environ_for_server()
3228         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3229         (XvfbDriverTest.make_driver): Get the port default environment.
3230         (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
3231         should include the environment that is passed when running Xvfb.
3232         (XvfbDriverTest.test_start_pixel_tests): Ditto.
3233         (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
3234         (XvfbDriverTest.test_start_next_worker): Ditto.
3235         * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
3236         prevent future problems when the version is raised. Add also a
3237         comment with a warning.
3238         * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
3239         that has the llvm optimized Gallium libGL libraries.
3240
3241 2014-08-21  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3242
3243         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
3244         https://bugs.webkit.org/show_bug.cgi?id=136125
3245
3246         Reviewed by Csaba Osztrogonác.
3247
3248         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3249         (RunLLINTCLoopTests.countFailures):
3250         (Run32bitJSCTests.countFailures):
3251         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3252         (RunLLINTCLoopTestsTest):
3253         (RunLLINTCLoopTestsTest.assertResults):
3254         (RunLLINTCLoopTestsTest.test_failures):
3255         (RunLLINTCLoopTestsTest.test_failure):
3256         (RunLLINTCLoopTestsTest.test_no_failure):
3257         (Run32bitJSCTestsTest):
3258         (Run32bitJSCTestsTest.assertResults):
3259         (Run32bitJSCTestsTest.test_failures):
3260         (Run32bitJSCTestsTest.test_failure):
3261         (Run32bitJSCTestsTest.test_no_failure):
3262
3263 2014-08-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3264
3265         Unreviewed, EFL build fix since r172814.
3266
3267         * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
3268
3269 2014-08-20  Alex Christensen  <achristensen@webkit.org>
3270
3271         Introducing WEBCORE_EXPORT macro.
3272         https://bugs.webkit.org/show_bug.cgi?id=136108
3273
3274         Reviewed by Antti Koivisto.
3275
3276         * TestWebKitAPI/config.h:
3277         Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.
3278
3279 2014-08-20  Rebecca Hauck  <rhauck@adobe.com>
3280
3281         import-w3c-tests doesn't import .svg support files
3282         https://bugs.webkit.org/show_bug.cgi?id=135928
3283
3284         Reviewed by Bem Jones-Bey.
3285
3286         This patch fixes the W3C import script to not treat all
3287         files with an xml mimetype as convertible tests, which
3288         was causing SVG support files to not be imported.
3289
3290         * Scripts/webkitpy/w3c/test_importer.py:
3291         (TestImporter.find_importable_tests):
3292
3293 2014-08-19  Dan Bernstein  <mitz@apple.com>
3294
3295         update-webkit should not check for the presence of Apple’s Internal directory
3296         Last part of https://bugs.webkit.org/show_bug.cgi?id=135815
3297
3298         Reviewed by Tim Horton.
3299
3300         * Scripts/update-webkit:
3301
3302 2014-08-19  Zalan Bujtas  <zalan@apple.com>
3303
3304         Remove ENABLE(SUBPIXEL_LAYOUT).
3305         https://bugs.webkit.org/show_bug.cgi?id=136077
3306
3307         Reviewed by Simon Fraser.
3308
3309         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
3310
3311         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3312
3313 2014-08-19  Akos Kiss  <akiss@inf.u-szeged.hu>
3314
3315         Let the caller define JSC_timeout for run-javascriptcore-tests
3316         https://bugs.webkit.org/show_bug.cgi?id=136068
3317
3318         Reviewed by Csaba Osztrogonác.
3319
3320         Keep the 60 second timeout for jsc tests as the default setting but
3321         don't override the value of JSC_timeout if already set.
3322
3323         * Scripts/run-javascriptcore-tests:
3324
3325 2014-08-19  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3326
3327         Remove obsolete run-javascriptcore-tests result parsing from master.cfg
3328         https://bugs.webkit.org/show_bug.cgi?id=136039
3329
3330         Reviewed by Csaba Osztrogonác.
3331
3332         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3333         (RunJavaScriptCoreTests.commandComplete):
3334         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3335         (RunJavaScriptCoreTestsTest.test_no_failure_new_output):
3336         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
3337         (RunJavaScriptCoreTestsTest):
3338         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
3339         (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
3340         (test_layout_failure_new_output): Deleted.
3341         (test_layout_crash_new_output): Deleted.
3342         (test_mozilla_and_layout_failure_new_output): Deleted.
3343         (test_jsc_stress_failure_new_output): Deleted.
3344         (test_js_crashes_and_jsc_stress_failures_new_output): Deleted.
3345
3346 2014-08-19  Alexey Proskuryakov  <ap@apple.com>
3347
3348         build.webkit.org/dashboard should not request 50 revisions from trac each time
3349         https://bugs.webkit.org/show_bug.cgi?id=127130
3350
3351         build.webkit.org/dashboard sometimes fetches a Trac revision in an intermediate state, and never updates later
3352         https://bugs.webkit.org/show_bug.cgi?id=127131
3353
3354         Reviewed by Timothy Hatcher.
3355
3356         Turns out that requesting 50 builds is much slower than requesting by date - even
3357         if the request ends up returning more than 50 results. There is no way to only
3358         request updates, but this change brings request time from 6-8 seconds down to
3359         less than a second.
3360
3361         This patch generalizes date handling for later use in metrics code. As part of the
3362         rewrite, I made newly fetched data update author e-mail in previously fetched
3363         revisions, as it changes after commit queue first lands.
3364
3365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3366         Updated for event rename. I changed the trac event to not contain the list of new
3367         commits, as we now sometimes update old commits, and that couldn't be expressed
3368         in event data. We never used the list anywhere in the first place.
3369
3370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3371         (Trac.prototype._xmlTimelineURL): Made this function take arbitrary dates. When called
3372         without arguments, return commits for today and yesterday.
3373         (Trac.prototype._loaded):
3374         (Trac.prototype.update): Moved the function for processing loaded results out of
3375         here for clarity, and also because I'm going to have a separate loading code path
3376         for metrics.
3377
3378 2014-08-18  Dan Bernstein  <mitz@apple.com>
3379
3380         Added an update-webkit option to override the ../Internal check.
3381         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
3382
3383         Reviewed by Tim Horton.
3384
3385         * Scripts/update-webkit:
3386         Added an explicit --internal option to control updating ../Internal, defaulting to whether
3387         ../Internal exists.
3388         (runSvnUpdate): Moved to webkitdirs.pm.
3389         (runGitUpdate): Ditto.
3390         * Scripts/webkitdirs.pm:
3391         (runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
3392         (runGitUpdate): Moved from update-webkit.
3393
3394 2014-08-18  Pratik Solanki  <psolanki@apple.com>
3395
3396         Make update-webkit more lenient for pure git svn repositories
3397         https://bugs.webkit.org/show_bug.cgi?id=135805
3398
3399         Reviewed by Oliver Hunt.
3400
3401         Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
3402         call to git fetch will fail and update-webkit will abort. The purpose of r72966 was to
3403         provide an optimization when you have a git repository setup. We should not fail if the
3404         git setup does not have svn-remote.svn.fetch set.
3405
3406         * Scripts/update-webkit:
3407         (runGitUpdate):
3408
3409 2014-08-18  Simon Fraser  <simon.fraser@apple.com>
3410
3411         Enable Web Inspector in MiniBrowser WK2 windows
3412         https://bugs.webkit.org/show_bug.cgi?id=136045
3413
3414         Reviewed by Tim Horton.
3415         
3416         Set the pref to enable developer extras for all WK2 windows.
3417
3418         * MiniBrowser/mac/WK2BrowserWindowController.m:
3419         (-[WK2BrowserWindowController awakeFromNib]):
3420
3421 2014-08-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3422
3423         master.cfg should handle special return codes of run-perf-tests
3424         https://bugs.webkit.org/show_bug.cgi?id=135974
3425
3426         Reviewed by Ryosuke Niwa.
3427
3428         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3429         (RunAndUploadPerfTests.getText2):
3430         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3431         (RunAndUploadPerfTestsTest):
3432         (RunAndUploadPerfTestsTest.assertResults):
3433         (RunAndUploadPerfTestsTest.test_tests_failed):
3434         (RunAndUploadPerfTestsTest.test_build_bad_build):
3435         (RunAndUploadPerfTestsTest.test_build_bad_source_json):
3436         (RunAndUploadPerfTestsTest.test_build_bad_marge):
3437         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading):
3438         (RunAndUploadPerfTestsTest.test_build_bad_preparation):
3439
3440 2014-08-17  Brent Fulgham  <bfulgham@apple.com>
3441
3442         [Win] Unreviewed change to force rebuild
3443         (plus drive-by add an accessor I wanted for
3444         some future tooling).
3445
3446         * WinLauncher/WinLauncher.h:
3447         (WinLauncher::webView): Added.
3448
3449 2014-08-16  Mark Hahnenberg  <mhahnenb@gmail.com>
3450
3451         Update contributors.json for my new email
3452         https://bugs.webkit.org/show_bug.cgi?id=136021
3453
3454         Reviewed by Filip Pizlo.
3455
3456         * Scripts/webkitpy/common/config/contributors.json:
3457
3458 2014-08-15  Alexey Proskuryakov  <ap@apple.com>
3459
3460         REGRESSION (r172660): WebKit2.TerminateTwice asserts
3461         https://bugs.webkit.org/show_bug.cgi?id=136012
3462
3463         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Skipped the test in debug mode.
3464
3465 2014-08-15  Ryuan Choi  <ryuan.choi@samsung.com>
3466
3467         Unreviewed build fix attempt on the CMake based pots since r172665
3468
3469         * TestWebKitAPI/CMakeLists.txt: Added JavaScriptCore/interpreter to the include list.
3470
3471 2014-08-15  Brian J. Burg  <burg@cs.washington.edu>
3472
3473         Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
3474         https://bugs.webkit.org/show_bug.cgi?id=131596
3475
3476         Reviewed by Joseph Pecoraro.
3477
3478         * Scripts/run-inspector-generator-tests: Added.
3479         (main):
3480         * Scripts/webkitpy/inspector/__init__.py: Added.
3481         * Scripts/webkitpy/inspector/main.py: Added.
3482         (InspectorGeneratorTests):
3483         (InspectorGeneratorTests.__init__):
3484         (InspectorGeneratorTests.generate_from_json):
3485         (InspectorGeneratorTests.write_error_file):
3486         (InspectorGeneratorTests.detect_changes):
3487         (InspectorGeneratorTests.run_tests):
3488         (InspectorGeneratorTests.main):
3489
3490 2014-08-15  Rebecca Hauck  <rhauck@adobe.com>
3491
3492         run-webkit-tests should skip 'support' directories
3493         https://bugs.webkit.org/show_bug.cgi?id=135910
3494
3495         Reviewed by Bem Jones-Bey.
3496         
3497         This patch adds the 'support' directory to the list
3498         of dirs to skip when looking for runnable tests.
3499         the W3C uses this name for support files, so tests
3500         imported from the W3C will not work without this change
3501         or without many edits.
3502
3503         * Scripts/webkitpy/port/base.py:
3504         (Port._real_tests):
3505
3506 2014-08-14  Brent Fulgham  <bfulgham@apple.com>
3507
3508         [Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion
3509         https://bugs.webkit.org/show_bug.cgi?id=135948
3510         <rdar://problem/18022221>
3511
3512         Reviewed by David Kilzer.
3513
3514         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add tests
3515         for RC_ProjectBuildVersion.
3516
3517 2014-08-05  David Farler  <dfarler@apple.com>
3518
3519         [iOS] run-webkit-tests runs webkit-build-directory on every test
3520         https://bugs.webkit.org/show_bug.cgi?id=135409
3521
3522         Reviewed by Daniel Bates.
3523
3524         * Scripts/webkitpy/port/ios.py:
3525         (IOSSimulatorPort.__init__): Cache Mac build directory.
3526         (IOSSimulatorPort.relay_path): Use cached build directory.
3527         (IOSSimulatorPort._path_to_image_diff): Use cached build directory.
3528
3529 2014-08-14  Zan Dobersek  <zdobersek@igalia.com>
3530
3531         Initialize a separate variable (TestWTF_SOURCES) with the list of files
3532         that are built into the TestWTF executable and move it above the platform-specific
3533         config file inclusion. This makes it possible to add platform-specific files to that
3534         list (e.g. GUniquePtr.cpp for the GTK port).
3535
3536         Rubber-stamped by Carlos Garcia Campos.
3537
3538         * TestWebKitAPI/CMakeLists.txt:
3539         * TestWebKitAPI/PlatformGTK.cmake:
3540
3541 2014-08-13  Akos Kiss  <akiss@inf.u-szeged.hu>
3542
3543         [EFL] Bump up and patch dependencies to allow building for aarch64
3544         https://bugs.webkit.org/show_bug.cgi?id=135885
3545
3546         Reviewed by Gyuyoung Kim.
3547
3548         The currently used versions of pixman, libffi, glib, glib-networking,
3549         and fontconfig fail to configure for aarch64, so they are bumped up to
3550         the latest stable version.
3551
3552         Gstreamer-plugins-base configures for aarch64 but incorrectly recogizes
3553         ARM NEON assembly support, so it is patched with a change that has been
3554         accepted by upstream.
3555
3556         * efl/jhbuild.modules:
3557         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Added.
3558
3559 2014-08-13  Mark Rowe  <mrowe@apple.com>
3560
3561         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
3562
3563         Reviewed by Darin Adler.
3564
3565         * DumpRenderTree/mac/TextInputController.m: Don't use extern "C" in a non-C++ file.
3566
3567 2014-08-13  Alex Christensen  <achristensen@webkit.org>
3568
3569         Progress towards CMake on Mac.
3570         https://bugs.webkit.org/show_bug.cgi?id=135819
3571
3572         Reviewed by Laszlo Gombos.
3573
3574         * WebKitTestRunner/CMakeLists.txt:
3575         Added new cpp parameter for the extension of the generated files.
3576
3577 2014-08-13  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3578
3579         Make check-webkit-style run sort-export-file
3580         https://bugs.webkit.org/show_bug.cgi?id=135877
3581
3582         Reviewed by Csaba Osztrogonác.
3583
3584         * Scripts/webkitpy/style/checker.py:
3585         (_all_categories):
3586         (FileType):
3587         (CheckerDispatcher._file_type):
3588         (CheckerDispatcher._create_checker):
3589         * Scripts/webkitpy/style/checkers/exportfile.py: Added.
3590         (ExportFileChecker):
3591         (ExportFileChecker.__init__):
3592         (ExportFileChecker.check):
3593         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Added.
3594         (handle_style_error):
3595         (MockErrorHandler):
3596         (MockErrorHandler.__init__):
3597         (MockErrorHandler.turn_off_line_filtering):
3598         (MockErrorHandler.__call__):
3599         (ExportFileTest):
3600         (ExportFileTest.setUp):
3601         (ExportFileTest.tearDown):
3602         (ExportFileTest.test_sorted):
3603         (ExportFileTest.test_non_sorted):
3604         (ExportFileTest.test_parse_error):
3605
3606 2014-08-13  Jinwoo Song  <jinwoo7.song@samsung.com>
3607
3608         [EFL] Sets the persistent storage for cookies in MiniBrowser
3609         https://bugs.webkit.org/show_bug.cgi?id=135875
3610
3611         Reviewed by Gyuyoung Kim.
3612
3613         In case of EWK_COOKIE_ACCEPT_POLICY_ALWAYS, sets the persistent storage
3614         for non-session cookies can be stored persistently.
3615
3616         * MiniBrowser/efl/main.c:
3617         (elm_main):
3618
3619 2014-08-12  Daniel Bates  <dabates@apple.com>
3620
3621         [iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
3622         https://bugs.webkit.org/show_bug.cgi?id=135845
3623
3624         Reviewed by Andy Estes.
3625
3626         Towards building the iOS WebKit port using the public SDK, remove the logic
3627         added to build-webkit to build projects WebKitSystemInterface and
3628         WebKitAdditions when building the iOS WebKit port.
3629
3630         * Scripts/build-webkit:
3631
3632 2014-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
3633
3634         [GTK] Adds dependency for GnuTLS 3.0+ explicitly in gtk/install-dependencies
3635         https://bugs.webkit.org/show_bug.cgi?id=135850
3636
3637         Reviewed by Philippe Normand.
3638
3639         After r172433, GTK port requires GnuTLS 3.0+. In this time, libgnutls-dev is 2.x in
3640         Ubuntu(trusty) and Debian(sid). So added libgnutls28-dev explicitly.
3641
3642         * gtk/install-dependencies:
3643