Fix the build.
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-21  Mark Rowe  <mrowe@apple.com>
2
3         Fix the build.
4
5         Ensure that our test tools don't try and use RTTI unnecessarily.
6
7         * DumpRenderTree/mac/Configurations/Base.xcconfig:
8         * TestWebKitAPI/Configurations/Base.xcconfig:
9         * WebKitTestRunner/Configurations/Base.xcconfig:
10
11 2012-03-21  Adam Barth  <abarth@webkit.org>
12
13         WebKit should have some scripts to smooth interactions with GitHub
14         https://bugs.webkit.org/show_bug.cgi?id=81842
15
16         Reviewed by Eric Seidel.
17
18         These scripts support the workflow in
19         https://trac.webkit.org/wiki/UsingGitHub by automating the
20         configuration and syncing operations needed for a GitHub fork of WebKit
21         to track the main WebKit repository.
22
23         * Scripts/configure-github-as-upstream: Added.
24         * Scripts/sync-master-with-upstream: Added.
25
26 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
27
28         WTR - log the pid of a crashing WebProcess
29         https://bugs.webkit.org/show_bug.cgi?id=81575
30
31         Reviewed by Alexey Proskuryakov.
32
33         This allows run-webkit-tests to find the right crash log for a
34         given crashed WebProcess in WebKit2.
35
36         * WebKitTestRunner/TestController.cpp:
37         (WTR::exceededDatabaseQuota):
38         (WTR::TestController::createOtherPage):
39         (WTR::TestController::initialize):
40         (WTR::TestController::resetStateToConsistentValues):
41         (WTR::TestController::runTest):
42         (WTR::TestController::processDidCrash):
43
44 2012-03-21  Enrica Casucci  <enrica@apple.com>
45
46         WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
47         https://bugs.webkit.org/show_bug.cgi?id=81835
48         <rdar://problem/11082749>
49
50         Reviewed by Brady Eidson.
51
52         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
53         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
54         (TestWebKitAPI::contextMenuCopyLink):
55
56 2012-03-21  Alexandru Chiculita  <achicu@adobe.com>
57
58         [CSS Shaders] Make CSS Shaders compile on Chromium
59         https://bugs.webkit.org/show_bug.cgi?id=81435
60
61         Reviewed by Stephen White.
62         
63         I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
64
65         * DumpRenderTree/chromium/LayoutTestController.cpp:
66         (LayoutTestController::overridePreference):
67         * DumpRenderTree/chromium/WebPreferences.cpp:
68         (WebPreferences::reset):
69         (WebPreferences::applyTo):
70         * DumpRenderTree/chromium/WebPreferences.h:
71         (WebPreferences):
72
73 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
74
75         fix regression on gtk port introduced by r111609
76         https://bugs.webkit.org/show_bug.cgi?id=81839
77
78         Reviewed by Philippe Normand.
79
80         r111609 should've initialized a couple of missing fields in
81         WebKitDriver, and also should've checked for method overrides
82         in the other ports :(.
83
84         * Scripts/webkitpy/layout_tests/port/gtk.py:
85         (GtkDriver._start):
86         * Scripts/webkitpy/layout_tests/port/webkit.py:
87         (WebKitDriver.__init__):
88         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
89         (MainTest.test_crash_log):
90         (MainTest.test_web_process_crash_log):
91
92 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
93
94         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
95         https://bugs.webkit.org/show_bug.cgi?id=81603
96
97         Reviewed by Adam Barth.
98
99         Add a new _get_crash_log() overridable method on the Port
100         object to customize how we fetch crash logs per port.
101         Mac will now slow-spin with a timeout waiting for the crash log, rather
102         than waiting for the ReportCrash process to exit (it appears
103         that the mac will manage multiple crashes with a single
104         ReportCrash process, the process waits around longer than
105         necessary, presumably to avoid thrashing if processes are
106         repeatedly crashing).
107
108         Also, add the DriverOutput should contain the crash log and other info,
109         which is created in a port-specific manner but can then be
110         treated generically. Previously single_test_runner would get
111         told that something crashed and attempt to do something to get
112         the crash log, but it didn't have the information it needed to
113         od the right thing; better to make the driver hand back the
114         right info.
115
116         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
117         (SingleTestRunner._handle_error):
118         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
119         (write_test_result):
120         (TestResultWriter.write_crash_log):
121         * Scripts/webkitpy/layout_tests/port/base.py:
122         (Port.diff_text):
123         (Port._get_crash_log):
124         * Scripts/webkitpy/layout_tests/port/chromium.py:
125         (ChromiumDriver.run_test):
126         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
127         (ChromiumDriverTest.test_crash_log):
128         * Scripts/webkitpy/layout_tests/port/driver.py:
129         (DriverOutput.__init__):
130         * Scripts/webkitpy/layout_tests/port/mac.py:
131         (MacPort.is_lion):
132         (MacPort._get_crash_log):
133         * Scripts/webkitpy/layout_tests/port/test.py:
134         (TestDriver.run_test):
135         * Scripts/webkitpy/layout_tests/port/webkit.py:
136         (WebKitDriver.__init__):
137         (WebKitDriver._start):
138         (WebKitDriver.has_crashed):
139         (WebKitDriver._check_for_driver_crash):
140         (WebKitDriver.run_test):
141
142 2012-03-21  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
143
144         [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
145         https://bugs.webkit.org/show_bug.cgi?id=81507
146
147         Now that we're only loading from one directory, no need to
148         iterate over a list of directories anymore.
149
150         Reviewed by Martin Robinson.
151
152         * DumpRenderTree/efl/CMakeLists.txt:
153         * DumpRenderTree/efl/FontManagement.cpp:
154         (addFontDirectory):
155         (addFontsToEnvironment):
156
157 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
158
159         webkitpy: get ServerProcess out of the reportcrash business
160         https://bugs.webkit.org/show_bug.cgi?id=81600
161
162         Unreviewed, build fix.
163
164         Re-land r111307 and r111293 with another fix for a crash in NRWT;
165         we need to check if the driver has crashed before attempting to
166         read from it.
167
168
169         * Scripts/webkitpy/layout_tests/port/server_process.py:
170         (ServerProcess._reset):
171         (ServerProcess._handle_possible_interrupt):
172         (ServerProcess.write):
173         (ServerProcess.read_stdout):
174         (ServerProcess.has_crashed):
175         (ServerProcess._read):
176         (ServerProcess.stop):
177         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
178         (TrivialMockPort.check_for_leaks):
179         (TestServerProcess.test_broken_pipe):
180         * Scripts/webkitpy/layout_tests/port/webkit.py:
181         (WebKitPort._read_image_diff):
182         (WebKitDriver.has_crashed):
183         (WebKitDriver._check_for_driver_crash):
184         (WebKitDriver.run_test):
185         (WebKitDriver._read_block):
186         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
187         (MockServerProcess.__init__):
188         (MockServerProcess):
189         (MockServerProcess.has_crashed):
190
191 2012-03-21  Zeno Albisser  <zeno@webkit.org>
192
193         [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
194         https://bugs.webkit.org/show_bug.cgi?id=81750
195
196         Building WebCore on mac currently creates an archive that is bigger than
197         4GB. But ranlib fails to create a symbol table for such a big archive,
198         even on 64bit machines.
199         Therefore we start using SVGAllInOne.cpp when building debug
200         on mac. This reduces the size of the archive by about 300MB.
201
202         Reviewed by Tor Arne Vestbø.
203
204         * qmake/mkspecs/features/mac/default_pre.prf:
205
206 2012-03-21  Szilard Ledan  <szledan@inf.u-szeged.hu>
207
208         Updated the address list of committers.py.
209
210         Reviewed by Csaba Osztrogonác.
211
212         * Scripts/webkitpy/common/config/committers.py:
213
214 2012-03-21  W. James MacLean  <wjmaclean@chromium.org>
215
216         Updating my nick in committers file.
217
218         Unreviewed.
219
220         * Scripts/webkitpy/common/config/committers.py:
221
222 2012-03-21  Peter Beverloo  <peter@chromium.org>
223
224         [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
225         https://bugs.webkit.org/show_bug.cgi?id=80861
226
227         Reviewed by Tony Chang.
228
229         Remove most Android-specific logic from webkitdirs.pm in favor of
230         handling this during project generation time.
231
232         * Scripts/webkitdirs.pm:
233         (buildChromiumMakefile):
234
235 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
236
237         [GTK] Allow running javascript from location bar in MiniBrowser
238         https://bugs.webkit.org/show_bug.cgi?id=81331
239
240         Reviewed by Martin Robinson.
241
242         * MiniBrowser/gtk/BrowserWindow.c:
243         (activateUriEntryCallback): Use browser_window_load_uri().
244         (browser_window_load_uri): Check whether uri starts with
245         javascript: and run the given script, or just call
246         webkit_web_view_load_uri() to load the given uri.
247         * MiniBrowser/gtk/BrowserWindow.h:
248         * MiniBrowser/gtk/main.c:
249         (createBrowserWindow): Use browser_window_load_uri().
250
251 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
252
253         [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
254         https://bugs.webkit.org/show_bug.cgi?id=75543
255
256         Reviewed by Martin Robinson.
257
258         * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
259         MiniBrowser CPP flags.
260
261 2012-03-20  Eric Seidel  <eric@webkit.org>
262
263         Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
264         https://bugs.webkit.org/show_bug.cgi?id=80911
265
266         Reviewed by Adam Barth.
267
268         Update include paths for Source/WTF.
269
270         * DumpRenderTree/efl/CMakeLists.txt:
271         * DumpRenderTree/qt/DumpRenderTree.pro:
272         * QtTestBrowser/QtTestBrowser.pro:
273         * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
274
275 2012-03-20  Adam Barth  <abarth@webkit.org>
276
277         svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
278         https://bugs.webkit.org/show_bug.cgi?id=81567
279
280         Reviewed by Eric Seidel.
281
282         This temporary measure should help us avoid disrupting the folks
283         working on WebAudio when we move the webaudio directory to Modules.
284
285         * Scripts/VCSUtils.pm:
286         (adjustPathForRecentRenamings):
287         (parseGitDiffHeader):
288         (parseSvnDiffHeader):
289
290 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
291
292         Unreviewed, rolling out r111453.
293         http://trac.webkit.org/changeset/111453
294         https://bugs.webkit.org/show_bug.cgi?id=81600
295
296         still broken
297
298         * Scripts/webkitpy/layout_tests/port/server_process.py:
299         (ServerProcess._reset):
300         (ServerProcess.handle_interrupt):
301         (ServerProcess.write):
302         (ServerProcess._check_for_crash):
303         (ServerProcess._handle_timeout):
304         (ServerProcess._check_for_abort):
305         (ServerProcess._read):
306         (ServerProcess.stop):
307         (ServerProcess):
308         (ServerProcess.set_crashed):
309         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
310         (TrivialMockPort.is_crash_reporter):
311         (TestServerProcess.test_broken_pipe):
312         * Scripts/webkitpy/layout_tests/port/webkit.py:
313         (WebKitPort._read_image_diff):
314         (WebKitDriver.has_crashed):
315         (WebKitDriver._check_for_driver_crash):
316         (WebKitDriver):
317         (WebKitDriver._detected_crash):
318         (WebKitDriver._subprocess_crashed):
319         (WebKitDriver._crashed_process_name):
320         (WebKitDriver.run_test):
321         (WebKitDriver._read_block):
322         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
323         (MockServerProcess.__init__):
324
325 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
326
327         webkitpy: get ServerProcess out of the reportcrash business
328         https://bugs.webkit.org/show_bug.cgi?id=81600
329
330         Unreviewed, build fix.
331
332         Re-land r111307 and r111293 with fix for crash in NRWT; I
333         was failing to set the crashing process name.
334
335         * Scripts/webkitpy/layout_tests/port/server_process.py:
336         (ServerProcess._reset):
337         (ServerProcess._handle_possible_interrupt):
338         (ServerProcess.write):
339         (ServerProcess.read_stdout):
340         (ServerProcess.has_crashed):
341         (ServerProcess._read):
342         (ServerProcess.stop):
343         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
344         (TrivialMockPort.check_for_leaks):
345         (TestServerProcess.test_broken_pipe):
346         * Scripts/webkitpy/layout_tests/port/webkit.py:
347         (WebKitPort._read_image_diff):
348         (WebKitDriver.has_crashed):
349         (WebKitDriver._check_for_driver_crash):
350         (WebKitDriver.run_test):
351         (WebKitDriver._read_block):
352         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
353         (MockServerProcess.__init__):
354         (MockServerProcess):
355         (MockServerProcess.has_crashed):
356
357 2012-03-20  Tim Horton  <timothy_horton@apple.com>
358
359         [mac] Restore color space switching code to run-webkit-tests
360         https://bugs.webkit.org/show_bug.cgi?id=80571
361         <rdar://problem/11008529>
362
363         Reviewed by Simon Fraser.
364
365         http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
366         
367         Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
368         didn't exist until Lion.
369
370         * DumpRenderTree/mac/LayoutTestHelper.m:
371         (installLayoutTestColorProfile):
372         (restoreUserColorProfile):
373
374 2012-03-20  Adele Peterson  <adele@apple.com>
375
376         Update the last test to use EXPECT_WK_STREQ.
377
378         Reviewed by Dan Bernstein.
379
380         * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
381
382 2012-03-20  Adele Peterson  <adele@apple.com>
383
384         "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
385         https://bugs.webkit.org/show_bug.cgi?id=81630
386         <rdar://problem/10650660>
387
388         Reviewed by Alexey Proskuryakov.
389
390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
391         * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
392         * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
393         (-[AttributedStringTest webView:didFinishLoadForFrame:]):
394         (TestWebKitAPI):
395         (TestWebKitAPI::didFinishLoadForFrame):
396         (TestWebKitAPI::TEST):
397         * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
398
399 2012-03-20  Eric Seidel  <eric@webkit.org>
400
401         Add link on queues.webkit.org to kov's fancy queue-depth graph
402         https://bugs.webkit.org/show_bug.cgi?id=81690
403
404         Reviewed by Adam Barth.
405
406         * QueueStatusServer/templates/recentstatus.html:
407
408 2012-03-20  Tim Horton  <timothy_horton@apple.com>
409
410         [mac] Restore color space switching code to run-webkit-tests
411         https://bugs.webkit.org/show_bug.cgi?id=80571
412         <rdar://problem/11008529>
413
414         Reviewed by Simon Fraser.
415
416         Make use of the layout test helper hooks to restore the Mac system-wide
417         color profile switching code. This makes WkTR and DRT results match, and
418         causes the main display's color profile to not affect results on Lion.
419
420         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
421         * DumpRenderTree/mac/LayoutTestHelper.m: Added.
422         (installLayoutTestColorProfile):
423         (restoreUserColorProfile):
424         (simpleSignalHandler):
425         (main):
426         * Scripts/webkitpy/layout_tests/port/mac.py:
427         (MacPort.release_http_lock):
428         (MacPort):
429         (MacPort._path_to_helper):
430         (MacPort.start_helper):
431         (MacPort.stop_helper):
432         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
433         (WTR::PlatformWebView::PlatformWebView):
434         (WTR::PlatformWebView::windowSnapshotImage):
435
436 2012-02-24  Darin Fisher  <darin@chromium.org>
437
438         Add more Chromium WebKit API reviewers
439         https://bugs.webkit.org/show_bug.cgi?id=81576
440
441         Reviewed by Adam Barth and David Levin.
442
443         Simplify watchlist to lump all WebKit API into one.
444
445         * Scripts/webkitpy/common/config/watchlist:
446
447 2012-03-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
448
449         Convert hasSpellingMarker to use Internals interface.
450         https://bugs.webkit.org/show_bug.cgi?id=81300
451
452         Reviewed by Ryosuke Niwa.
453
454         Remove hasSpellingMarker functions, because it is able to work in the
455         cross-port way through the Internals interface.
456
457         * DumpRenderTree/LayoutTestController.cpp:
458         (LayoutTestController::staticFunctions):
459         * DumpRenderTree/LayoutTestController.h:
460         (LayoutTestController):
461         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
462         * DumpRenderTree/chromium/LayoutTestController.cpp:
463         (LayoutTestController::LayoutTestController):
464         * DumpRenderTree/chromium/LayoutTestController.h:
465         (LayoutTestController):
466         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
467         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
468         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
469         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
470         * DumpRenderTree/qt/LayoutTestControllerQt.h:
471         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
472         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
473
474 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
475
476         Add new Qt-WK2 performance tester bot to build.webkit.org
477         https://bugs.webkit.org/show_bug.cgi?id=80842
478
479         Reviewed by Ryosuke Niwa.
480
481         * BuildSlaveSupport/build.webkit.org-config/config.json:
482         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
483         (RunAndUploadPerfTestsWebKit2):
484         (RunAndUploadPerfTestsWebKit2.start):
485         (BuildAndPerfTestWebKit2Factory):
486         (BuildAndPerfTestWebKit2Factory.__init__):
487         (DownloadAndPerfTestWebKit2Factory):
488         (DownloadAndPerfTestWebKit2Factory.__init__):
489
490 2012-03-20  Peter Beverloo  <peter@chromium.org>
491
492         [Chromium] Update to Android NDK r7b
493         https://bugs.webkit.org/show_bug.cgi?id=81005
494
495         Reviewed by Adam Barth.
496
497         Update to version r7b of the Android NDK, release notes of which are
498         available on the following page:
499         http://developer.android.com/sdk/ndk/index.html
500
501         * Scripts/update-webkit-chromium:
502
503 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
504
505         x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
506         https://bugs.webkit.org/show_bug.cgi?id=81502
507
508         Unreviewed.
509
510         * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
511
512 2012-03-19  Jessie Berlin  <jberlin@apple.com>
513
514         Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
515         because they broke running the layout tests on mac.
516
517         * Scripts/webkitpy/layout_tests/port/webkit.py:
518         (WebKitDriver._check_for_driver_crash):
519
520 2012-03-16  Martin Robinson  <mrobinson@igalia.com>
521
522         [GTK] Allow running run-gtk-tests during 'make distcheck'
523         https://bugs.webkit.org/show_bug.cgi?id=81415
524
525         Reviewed by Philippe Normand.
526
527         Modify the build and run-gtk-tests so that it can run during 'make distcheck'
528
529         * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
530         main command run during 'make check.'
531         * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
532         a requirement to run it. If jhbuild isn't around it will simply not start the
533         SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
534         main loop and simply use the main loop in a synchronous method to start SPI
535         daemons. Did a bunch of general cleanup around these tasks.
536
537 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
538
539         jhbuild: Use the multiprocessing module to get the number of CPUs.
540         https://bugs.webkit.org/show_bug.cgi?id=81585
541
542         Reviewed by Martin Robinson.
543
544         Now that support for Python 2.5 has been dropped, we can safely
545         use multiprocessing.cpu_count() to obtain the current number of
546         CPUs in the system instead of running a webkitperl script for
547         that.
548
549         * efl/common.py:
550         (top_level_path):
551         * efl/jhbuildrc:
552         * gtk/common.py:
553         (build_path):
554         * gtk/jhbuildrc:
555
556 2012-03-19  Ojan Vafai  <ojan@chromium.org>
557
558         We should only add a live event listener once, not once per TestSelector.
559         Adding one per TestSelector would cause accordion('option', 'active') to
560         incorrectly be "false" if you examine multiple sets of tests.
561
562         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
563
564 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
565
566         Fix typo introduced in r111293.
567
568         Unreviewed, build fix.
569
570         * Scripts/webkitpy/layout_tests/port/webkit.py:
571         (WebKitDriver._check_for_driver_crash):
572
573 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
574
575         webkitpy: get ServerProcess out of the reportcrash business
576         https://bugs.webkit.org/show_bug.cgi?id=81600
577
578         Reviewed by Adam Barth.
579
580         ServerProcess was half-aware that ReportCrash might run
581         sometimes, and that the process ServerProcess was talking to
582         might have its own crashing subprocesses; neither of these
583         things really worked right and it made the logic convoluted, so
584         this change makes handling crashes completely separate from the
585         server_process code, so that it can focus on just I/O to the
586         subprocess.
587
588         There should be no functional changes resulting from this patch.
589
590         * Scripts/webkitpy/layout_tests/port/server_process.py:
591         (ServerProcess._reset):
592         (ServerProcess._handle_possible_interrupt):
593         (ServerProcess.write):
594         (ServerProcess.read_stdout):
595         (ServerProcess.has_crashed):
596         (ServerProcess._read):
597         (ServerProcess.stop):
598         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
599         (TrivialMockPort.check_for_leaks):
600         (TestServerProcess.test_broken_pipe):
601         * Scripts/webkitpy/layout_tests/port/webkit.py:
602         (WebKitPort._read_image_diff):
603         (WebKitDriver.has_crashed):
604         (WebKitDriver._check_for_driver_crash):
605         (WebKitDriver.run_test):
606         (WebKitDriver._read_block):
607         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
608         (MockServerProcess.__init__):
609         (MockServerProcess):
610         (MockServerProcess.has_crashed):
611
612 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
613
614         webkitpy: crashlog parsing is broken
615         https://bugs.webkit.org/show_bug.cgi?id=81586
616
617         Reviewed by Adam Barth.
618
619         Seeking on a file opened through codecs() appears to not work
620         correctly (at least on SL).
621         
622         The code was more complicated than it needed to be, so I have
623         revamped it to just read a full crashlog at once and then look
624         for matches. 
625         
626         I have also added the ability to optionally propagate
627         errors back (which can be helpful to debug races when ReportCrash is
628         still running and you need to see that you couldn't open some
629         files, rather than just ignoring them).
630
631         * Scripts/webkitpy/common/system/crashlogs.py:
632         (CrashLogs.find_newest_log):
633         (CrashLogs._find_newest_log_darwin):
634         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
635         (CrashLogsTest.test_find_log_darwin):
636
637 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
638
639         webkitpy: clean up some port._filesystem references to not reference private members
640         https://bugs.webkit.org/show_bug.cgi?id=81595
641
642         Reviewed by Eric Seidel.
643
644         There should be no functional changes in this patch, just some
645         refactoring. Also, fixes a minor nit in write_image_diff_files(()
646
647         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
648         (SingleTestRunner.__init__):
649         (SingleTestRunner._run_compare_test):
650         (SingleTestRunner._run_rebaseline):
651         (SingleTestRunner._save_baseline_data):
652         (SingleTestRunner._handle_error):
653         (SingleTestRunner._run_reftest):
654         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
655         (write_test_result):
656         (TestResultWriter.__init__):
657         (TestResultWriter._make_output_directory):
658         (TestResultWriter.output_filename):
659         (TestResultWriter._output_testname):
660         (TestResultWriter.write_output_files):
661         (TestResultWriter.write_stderr):
662         (TestResultWriter.write_crash_report):
663         (TestResultWriter.create_text_diff_and_write_result):
664         (TestResultWriter.write_image_diff_files):
665         (copy_file):
666         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
667         (TestResultWriterTest.test_reftest_diff_image):
668
669 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
670
671         webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
672         https://bugs.webkit.org/show_bug.cgi?id=81598
673
674         Reviewed by Eric Seidel.
675
676         "DumpRenderTree" shouldn't be hard-coded here, since some other
677         process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
678         
679         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
680         (TestExpectations):
681
682 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
683
684         webkitpy: allow instance data in TestFailure objects
685         https://bugs.webkit.org/show_bug.cgi?id=81580
686
687         Reviewed by Tony Chang.
688
689         Current TestFailures are basically enums, but it would be nice,
690         especially for crashes, if they contained the name and pid of
691         the process that crashed.
692
693         * Scripts/webkitpy/layout_tests/models/test_failures.py:
694         (TestFailure.message):
695         (FailureTimeout.message):
696         (FailureCrash):
697         (FailureCrash.__init__):
698         (FailureCrash.message):
699         (FailureMissingResult.message):
700         (FailureTextMismatch.message):
701         (FailureMissingImageHash.message):
702         (FailureMissingImage.message):
703         (FailureImageHashMismatch.message):
704         (FailureImageHashIncorrect.message):
705         (FailureReftestMismatch.message):
706         (FailureReftestMismatchDidNotOccur.message):
707         (FailureReftestNoImagesGenerated.message):
708         (FailureMissingAudio.message):
709         (FailureAudioMismatch.message):
710         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
711         (TestFailuresTest.test_equals):
712         (TestFailuresTest):
713         (TestFailuresTest.test_crashes):
714
715 2012-03-19  Brady Eidson  <beidson@apple.com>
716
717         <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
718         Crash in 3rd party WebKit apps under XHR/Cache code
719
720         Reviewed by Antti Koivisto.
721
722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
723         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
724         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
725         (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
726         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
727         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
728         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
729         (TestWebKitAPI):
730         (TestWebKitAPI::TEST):
731
732 2012-03-19  Brady Eidson  <beidson@apple.com>
733
734         <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
735         REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
736
737         Reviewed by Enrica Casucci.
738
739         Bring up a context menu on a link, copy the link, then verify the pasteboard contents
740         are in the correct format.
741
742         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
743         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
744         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
745         (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
746         (TestWebKitAPI::contextMenuCopyLink):
747         (TestWebKitAPI::TEST):
748
749 2012-03-19  Ojan Vafai  <ojan@chromium.org>
750
751         Make the selected item in the accordion a link to the flakiness dashboard
752         https://bugs.webkit.org/show_bug.cgi?id=81571
753
754         Reviewed by Dimitri Glazkov.
755
756         Also, make it so that you can select the text of the link, instead of the current behavior
757         of acting as if you had clicked on the accordion header.
758
759         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
761
762 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
763
764         NRWT runs some tests that are skipped with -i command line option
765         https://bugs.webkit.org/show_bug.cgi?id=81535
766
767         Reviewed by Ojan Vafai.
768
769         This change modifies the interaction of Skipped files and
770         test_expectations files so that entries in Skipped files (and
771         the -i command line) override *everything* in the expectations
772         file.
773
774         Specifically, a directory in a Skipped file will cause all of
775         the tests in the dir to be skipped even if individual tests in
776         the dir are listed in the test_expectations.txt.
777
778         Skipped files also override anything in an overrides files.
779
780         This seems to make more intuitive sense, since if you list
781         something in the Skips file (and even more specify it on the
782         command line) you probably want it to be universally applied.
783
784         Theoretically we could add more precedence levels and have full
785         paths in an expectations file override dirs in a Skipped file
786         (but not the command line), but I don't know yet that that level
787         of complexity is justified.
788         
789         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
790         (TestExpectations.__init__):
791         (TestExpectations._add_skipped_tests):
792         (TestExpectations._add_test):
793         (TestExpectations._add_expectations):
794         (TestExpectations._add_expectation_line):
795         (TestExpectations._already_seen_better_match):
796         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
797         (test_more_specific_override_resets_skip):
798         (SkippedTests):
799         (SkippedTests.get_exp):
800         (SkippedTests.assert_exp):
801         (SkippedTests.test_skipped_tests_work):
802         (SkippedTests.test_duplicate_skipped_test_fails_lint):
803         (SkippedTests.test_skipped_file_overrides_expectations):
804         (SkippedTests.test_skipped_dir_overrides_expectations):
805         (SkippedTests.test_skipped_file_overrides_overrides):
806         (SkippedTests.test_skipped_dir_overrides_overrides):
807
808 2012-03-19  Eric Seidel  <eric@webkit.org>
809
810         Fix WTF header include discipline in Chromium WebKit
811         https://bugs.webkit.org/show_bug.cgi?id=81281
812
813         Reviewed by James Robinson.
814
815         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
816         * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
817
818 2012-03-19  Andy Chen  <andchen@rim.com>
819
820         [BlackBerry] Add new layout test for text match marker
821         https://bugs.webkit.org/show_bug.cgi?id=81531
822
823         Make the LayoutTestControllerBlackBerry::findString to test the
824         BlackBerry port implementation.
825
826         Reviewed by Rob Buis.
827
828         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
829         (LayoutTestController::findString):
830
831 2012-03-19  Ojan Vafai  <ojan@chromium.org>
832
833         Don't show WONTFIX tests in garden-o-matic
834         https://bugs.webkit.org/show_bug.cgi?id=81554
835
836         Reviewed by Dimitri Glazkov.
837
838         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
840
841 2012-03-19  Chris Fleizach  <cfleizach@apple.com>
842
843         platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
844         https://bugs.webkit.org/show_bug.cgi?id=81530
845
846         Reviewed by Jessie Berlin.
847
848         Add rowAtIndex to WebKitTestRunner.
849
850         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
851         (WTR::AccessibilityUIElement::rowAtIndex):
852         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
853         (AccessibilityUIElement):
854         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
855         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
856         (WTR):
857         (WTR::AccessibilityUIElement::rowAtIndex):
858
859 2012-03-19  Ojan Vafai  <ojan@chromium.org>
860
861         Change garden-o-matic All Failures tab to Expected Failures
862         https://bugs.webkit.org/show_bug.cgi?id=81540
863
864         Reviewed by Dimitri Glazkov.
865
866         Also, fix some broken unittests that had just gotten stale.
867
868         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
869         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
870         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
871         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
872         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
873         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
874         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
875         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
876         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
877         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
878
879 2012-03-19  Hao Zheng  <zhenghao@chromium.org>
880
881         [chromium] DRT crashes at shutdown.
882         https://bugs.webkit.org/show_bug.cgi?id=81504
883
884         Reviewed by James Robinson.
885
886         WebCompositor must be destroyed after WebView is properly destroyed,
887         or some compositor objects like CCLayerTreeHost may not be destroyed.
888         However, it is really hard to make the destruction order correct
889         explicitly in ~TestShell. So move it out to DumpRenderTree.
890
891         * DumpRenderTree/chromium/DumpRenderTree.cpp:
892         (main):
893         * DumpRenderTree/chromium/TestShell.cpp:
894         (TestShell::~TestShell):
895
896 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
897
898         add dpranke to webkitpy watchlist
899         https://bugs.webkit.org/show_bug.cgi?id=81433
900
901         Reviewed by Benjamin Poulain.
902
903         * Scripts/webkitpy/common/config/watchlist:
904
905 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
906
907         test-webkitpy is failing on SL/Python 2.6.1
908         https://bugs.webkit.org/show_bug.cgi?id=81533
909
910         Reviewed by Ojan Vafai.
911
912         It appears that itertools.combinations() is buggy in 2.6.1; this
913         backports the implementation from 2.7.
914
915         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
916         (TestConfigurationConverter.collapse_macros):
917         (TestConfigurationConverter):
918         (TestConfigurationConverter.combinations):
919
920 2012-03-19  David Michael Barr  <davidbarr@google.com>
921
922         Optimize the cleanup sequence in the start-queue.sh script
923         https://github.com/abarth/webkit/pull/1
924
925         Reviewed by Adam Barth.
926
927         Updating the working copy is an expensive operation
928         for a repository the size of WebKit.
929         Attempt to reset only to the target revision.
930
931         * EWSTools/start-queue.sh:
932
933 2012-03-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
934
935         Adjust architecture type of the EFL build bot.
936         https://bugs.webkit.org/show_bug.cgi?id=81452
937
938         Reviewed by Tony Chang.
939
940         * BuildSlaveSupport/build.webkit.org-config/config.json: The
941         buildslave is a 64-bit machine, therefore describe it as being
942         x86_64, not i386.
943
944 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
945
946         [Qt] printLoadedUrls prints "Object" instead of the actual URL.
947         https://bugs.webkit.org/show_bug.cgi?id=81514
948
949         Reviewed by Simon Hausmann.
950
951         * MiniBrowser/qt/qml/BrowserWindow.qml:
952
953 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
954
955         [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
956         https://bugs.webkit.org/show_bug.cgi?id=81491
957
958         Reviewed by Philippe Normand.
959
960         For the find_path(), find_library() etc CMake calls to find the
961         dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
962         set, otherwise CMake cannot know the dependencies exist and will only
963         look in the standard directories.
964
965         * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
966         the jhbuild Root directory.
967
968 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
969
970         [EFL] Add XDG env vars to jhbuildrc
971         https://bugs.webkit.org/show_bug.cgi?id=81510
972
973         Needed to ensure correct glib behaviour in jhbuild environment.
974
975         Reviewed by Philippe Normand.
976
977         * efl/jhbuildrc:
978
979 2012-03-19  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
980
981         Select best target for tap gesture.
982         https://bugs.webkit.org/show_bug.cgi?id=78801
983
984         Reviewed by Kenneth Rohde Christiansen.
985
986         Add TOUCH_ADJUSTMENT to enabled features.
987
988         * qmake/mkspecs/features/features.prf:
989
990 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
991
992         [chromium] synthesize wheel events for fling on main thread
993         https://bugs.webkit.org/show_bug.cgi?id=81458
994
995         Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
996
997         Reviewed by James Robinson.
998
999         * DumpRenderTree/chromium/EventSender.cpp:
1000         (EventSender::EventSender):
1001         (EventSender::gestureFlingCancel):
1002         (EventSender::gestureFlingStart):
1003         * DumpRenderTree/chromium/EventSender.h:
1004         (EventSender):
1005
1006 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1007
1008         [Qt] Add command line option to set the user agent in the MiniBrowser
1009         https://bugs.webkit.org/show_bug.cgi?id=81508
1010
1011         Reviewed by Simon Hausmann.
1012
1013         * MiniBrowser/qt/BrowserWindow.cpp:
1014         (BrowserWindow::BrowserWindow):
1015         (BrowserWindow::webViewExperimental):
1016         * MiniBrowser/qt/BrowserWindow.h:
1017         (BrowserWindow):
1018         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1019         (printHelp):
1020         (MiniBrowserApplication::handleUserOptions):
1021         * MiniBrowser/qt/MiniBrowserApplication.h:
1022         (WindowOptions::WindowOptions):
1023         (WindowOptions::setUserAgent):
1024         (WindowOptions::userAgent):
1025         (WindowOptions):
1026
1027 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1028
1029         [Qt] Remove dead user agent code from the MiniBrowser.
1030
1031         Reviewed by Simon Hausmann.
1032
1033         * MiniBrowser/qt/BrowserWindow.cpp:
1034         * MiniBrowser/qt/BrowserWindow.h:
1035         (BrowserWindow):
1036         * MiniBrowser/qt/MiniBrowser.qrc:
1037         * MiniBrowser/qt/useragentlist.txt: Removed.
1038
1039 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1040
1041         jhbuild: Call jhbuild's autogen.sh via bash.
1042         https://bugs.webkit.org/show_bug.cgi?id=81485
1043
1044         Reviewed by Philippe Normand.
1045
1046         jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
1047         this is usually true only on Linux systems, and even then bash for
1048         some reason might not be available in that location. It is safer to
1049         call bash directly and pass autogen.sh to it instead.
1050
1051         * jhbuild/jhbuild-wrapper:
1052         (install_jhbuild):
1053
1054 2012-03-19  Philippe Normand  <pnormand@igalia.com>
1055
1056         [GTK] Prefix run-launcher with run-with-jhbuild
1057         https://bugs.webkit.org/show_bug.cgi?id=81503
1058
1059         Reviewed by Hajime Morita.
1060
1061         * Scripts/run-launcher:
1062
1063 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1064
1065         [EFL] Prefix run-launcher with run-with-jhbuild
1066         https://bugs.webkit.org/show_bug.cgi?id=80026
1067
1068         Reviewed by Hajime Morita.
1069
1070         * Scripts/run-launcher:
1071
1072 2012-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1073
1074         [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
1075         https://bugs.webkit.org/show_bug.cgi?id=81498
1076
1077         * qmake/mkspecs/features/unix/default_post.prf:
1078
1079 2012-03-17  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1080
1081         Unreviewed; switch to using my FreeBSD.org email address, the
1082         other one is going to disappear soon.
1083
1084         * Scripts/webkitpy/common/config/committers.py:
1085         * Scripts/webkitpy/common/config/watchlist:
1086
1087 2012-03-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1088
1089         Unreviewed; fix webkitpy unit test failures after r111116.
1090
1091         It turns out that cmd_line in the patch in bug 80025 had the right
1092         signature when it was submitted, but r109242 added a few more
1093         required parameters, and since the method (and EflDriver) did not
1094         exist at the time we ended up committing a broken method.
1095
1096         * Scripts/webkitpy/layout_tests/port/efl.py:
1097         (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
1098         arguments.
1099
1100 2012-03-17  Charles Wei  <charles.wei@torchmobile.com.cn>
1101
1102         [BlackBerry] Enable Web Timing for performance profiling and improvement.
1103         https://bugs.webkit.org/show_bug.cgi?id=81085
1104
1105         Reviewed by Rob Buis.
1106
1107         * Scripts/build-webkit:
1108
1109 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1110
1111         Add a dependencies installation step for EFL to buildbot master.cfg
1112         https://bugs.webkit.org/show_bug.cgi?id=81337
1113
1114         Reviewed by Gustavo Noronha Silva.
1115
1116         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1117         (InstallEflDependencies):
1118         (Factory.__init__):
1119
1120 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1121
1122         [EFL] Prefixing run-webkit-tests with run-with-jhbuild
1123         https://bugs.webkit.org/show_bug.cgi?id=80025
1124
1125         Reviewed by Gustavo Noronha Silva.
1126
1127         * Scripts/webkitpy/layout_tests/port/efl.py:
1128         (EflDriver):
1129         (EflDriver.cmd_line):
1130         (EflPort._driver_class):
1131
1132 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1133
1134         [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
1135         https://bugs.webkit.org/show_bug.cgi?id=79904
1136
1137         build-webkit --efl will use jhbuild for fetching and building dependencies.
1138
1139         Reviewed by Gustavo Noronha Silva.
1140
1141         * Scripts/update-webkitefl-libs: Added.
1142         * Scripts/webkitdirs.pm:
1143         (jhbuildWrapperPrefixIfNeeded):
1144         (generateBuildSystemFromCMakeProject):
1145         (buildCMakeGeneratedProject):
1146         * efl/common.py: Added.
1147         (script_path):
1148         (top_level_path):
1149         (number_of_cpus):
1150         * efl/jhbuild.modules: Added.
1151         * efl/jhbuildrc: Added.
1152         * efl/run-with-jhbuild: Added.
1153
1154 2012-03-16  Stephanie Lewis  <slewis@apple.com>
1155
1156         https://bugs.webkit.org/show_bug.cgi?id=81065
1157         <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
1158         Fix crash preventing WebKitTestRunner from working in Release.  
1159         WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
1160         FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
1161         the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.
1162
1163         I removed ostringstream in favor of StringBuilder.  
1164
1165         Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
1166
1167         Reviewed by Geoff Garen.
1168
1169         Add DEBUG_DEFINES to set NDEBUG on release builds.
1170         * WebKitTestRunner/Configurations/Base.xcconfig:
1171         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1172
1173         Remove ostringstream member in favor of StringBuilder.
1174         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1175         (WTR::InjectedBundle::initialize):
1176         (WTR::InjectedBundle::beginTesting):
1177         (WTR::InjectedBundle::done):
1178         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1179         (WTF):
1180         (WTR::InjectedBundle::stringBuilder):
1181         (InjectedBundle):
1182
1183         Append output to StringBuilder.
1184         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1185         (WTR::hasPrefix):
1186         (WTR::dumpPath):
1187         (WTR::rangeToStr):
1188         (WTR::styleDecToStr):
1189         (WTR::frameToStr):
1190         (WTR::dumpFrameScrollPosition):
1191         (WTR::dumpFrameText):
1192         (WTR::dumpDescendantFramesText):
1193         (WTR::InjectedBundlePage::dump):
1194         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1195         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1196         (WTR::InjectedBundlePage::willSendRequestForFrame):
1197         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1198         (WTR::lastFileURLPathComponent):
1199         (WTR::InjectedBundlePage::willAddMessageToConsole):
1200         (WTR::InjectedBundlePage::willSetStatusbarText):
1201         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1202         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1203         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1204         (WTR::InjectedBundlePage::shouldBeginEditing):
1205         (WTR::InjectedBundlePage::shouldEndEditing):
1206         (WTR::InjectedBundlePage::shouldInsertNode):
1207         (WTR::InjectedBundlePage::shouldInsertText):
1208         (WTR::InjectedBundlePage::shouldDeleteRange):
1209         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1210         (WTR::InjectedBundlePage::shouldApplyStyle):
1211         (WTR::InjectedBundlePage::didBeginEditing):
1212         (WTR::InjectedBundlePage::didEndEditing):
1213         (WTR::InjectedBundlePage::didChange):
1214         (WTR::InjectedBundlePage::didChangeSelection):
1215         (WTR::InjectedBundlePage::supportsFullScreen):
1216         (WTR::InjectedBundlePage::enterFullScreenForElement):
1217         (WTR::InjectedBundlePage::exitFullScreenForElement):
1218         (WTR::InjectedBundlePage::beganEnterFullScreen):
1219         (WTR::InjectedBundlePage::beganExitFullScreen):
1220         (WTR::dumpBackForwardListItem):
1221         (WTR::InjectedBundlePage::dumpBackForwardList):
1222         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1223         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
1224         (WTR::LayoutTestController::dumpConfigurationForViewport):
1225         
1226         Convert between WTF::String and WKStringRef.
1227         * WebKitTestRunner/StringFunctions.h:
1228         (WTR::toWTFString):
1229         (WTR):
1230         * WebKitTestRunner/TestInvocation.cpp:
1231         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1232
1233 2012-03-16  Eric Seidel  <eric@webkit.org>
1234
1235         Add a land-from-url command
1236         https://bugs.webkit.org/show_bug.cgi?id=81411
1237
1238         Reviewed by Adam Barth.
1239
1240         Very basic so far.  The goal is to make it landing smarter
1241         so that users don't have to bother to parse out the ids out of the urls.
1242
1243         * Scripts/webkitpy/common/config/urls.py:
1244         (parse_bug_id):
1245         (parse_attachment_id):
1246         * Scripts/webkitpy/common/config/urls_unittest.py:
1247         (URLsTest.test_parse_bug_id):
1248         (URLsTest):
1249         (URLsTest.test_parse_attachment_id):
1250         * Scripts/webkitpy/tool/commands/download.py:
1251         (ProcessURLsMixin):
1252         (ProcessURLsMixin._fetch_list_of_patches_to_process):
1253         (LandFromURL):
1254         * Scripts/webkitpy/tool/commands/download_unittest.py:
1255         (test_land_from_bug):
1256         (test_land_from_url):
1257
1258 2012-03-16  Dave Tharp  <dtharp@codeaurora.org>
1259
1260         build-webkit launcher instructions use wrong relative path for Qt
1261         https://bugs.webkit.org/show_bug.cgi?id=81357
1262
1263         Reviewed by Eric Seidel.
1264
1265         Ensure we are at the proper directory before generating run-launcher
1266         instructions.
1267
1268         * Scripts/build-webkit:
1269
1270 2012-03-16  Brady Eidson  <beidson@apple.com>
1271
1272         <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
1273         REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
1274
1275         Reviewed by Geoff Garen.
1276
1277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1278         * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
1279
1280 2012-03-16  Ojan Vafai  <ojan@chromium.org>
1281
1282         Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
1283         https://bugs.webkit.org/show_bug.cgi?id=81407
1284
1285         Reviewed by Adam Barth.
1286
1287         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1288         (summarize_results):
1289         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1290         (ResultSummaryTest.summarized_results):
1291         (ResultSummaryTest.test_no_svn_revision):
1292         (ResultSummaryTest.test_svn_revision):
1293         (ResultSummaryTest):
1294         (ResultSummaryTest.test_summarized_results_wontfix):
1295
1296 2012-03-16  Ojan Vafai  <ojan@chromium.org>
1297
1298         Have webkit-patch rebaseline-test update test_expectations.txt
1299         https://bugs.webkit.org/show_bug.cgi?id=81054
1300
1301         Recommit http://trac.webkit.org/changeset/110783 now that
1302         http://trac.webkit.org/changeset/111034 has landed.
1303
1304         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1305         (TestExpectations.remove_configuration_from_test):
1306         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1307         (RemoveConfigurationsTest):
1308         (RemoveConfigurationsTest.test_remove):
1309         (test_remove_line):
1310         * Scripts/webkitpy/tool/commands/rebaseline.py:
1311         (RebaselineTest._update_expectations_file):
1312         (RebaselineTest._rebaseline_test_and_update_expectations):
1313         (RebaselineTest):
1314         (RebaselineTest.execute):
1315         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1316         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1317         (test_rebaseline_updates_expectations_file):
1318
1319 2012-03-15  Ojan Vafai  <ojan@chromium.org>
1320
1321         Specifier collapsing when writing test expectations lines gets a number of cases wrong
1322         https://bugs.webkit.org/show_bug.cgi?id=81309
1323
1324         Reviewed by Dimitri Glazkov.
1325
1326         I've run this over all the lines in the current Chromium test_expectations.txt file,
1327         so I'm relatively confident we now cover all the cases.
1328
1329         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1330         (TestConfigurationConverter.__init__):
1331         (TestConfigurationConverter.collapse_macros):
1332         (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
1333         (TestConfigurationConverter):
1334         (TestConfigurationConverter.intersect_combination):
1335         (TestConfigurationConverter.symmetric_difference):
1336         (TestConfigurationConverter.to_specifiers_list):
1337         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1338         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1339         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1340         (make_mock_all_test_configurations_set):
1341         (TestConfigurationConverterTest.test_symmetric_difference):
1342         (TestConfigurationConverterTest.test_to_config_set):
1343         (TestConfigurationConverterTest.test_macro_expansion):
1344         (TestConfigurationConverterTest.test_to_specifier_lists):
1345         (TestConfigurationConverterTest.test_converter_macro_collapsing):
1346         * Scripts/webkitpy/layout_tests/port/chromium.py:
1347         (ChromiumPort):
1348         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1349         (ChromiumAndroidPort.__init__):
1350         The android port uses "arm" as it's architecture, which is technically correct,
1351         but considerably complicates making collapsing work. We probably should kill
1352         the concept of architecture entirely. The benefits are not worth the code
1353         complexity.
1354
1355         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1356         (ChromiumPortTest.test_all_test_configurations):
1357         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1358         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1359         (test_rebaseline_updates_expectations_file):
1360
1361 2012-03-16  Dinu Jacob  <dinu.jacob@nokia.com>
1362
1363         [Qt][Wk2] Assertion Failure and crash on file upload
1364         https://bugs.webkit.org/show_bug.cgi?id=80854
1365
1366         Reviewed by Simon Hausmann.
1367
1368         Added filePicker to WebView using experimental API.
1369
1370         * MiniBrowser/qt/MiniBrowser.qrc:
1371         * MiniBrowser/qt/icons/folder.png: Added.
1372         * MiniBrowser/qt/icons/titlebar.png: Added.
1373         * MiniBrowser/qt/icons/up.png: Added.
1374         * MiniBrowser/qt/qml/BrowserWindow.qml:
1375         * MiniBrowser/qt/qml/FilePicker.qml: Added.
1376
1377 2012-03-16  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1378
1379         Updating email for committer.py script.
1380
1381         * Scripts/webkitpy/common/config/committers.py:
1382
1383 2012-03-16  Robert Kroeger  <rjkroege@chromium.org>
1384
1385         [chromium] DRT: Add support for sending gesture scrolls without a begin
1386         https://bugs.webkit.org/show_bug.cgi?id=81292
1387
1388         Reviewed by Kent Tamura.
1389
1390         * DumpRenderTree/chromium/EventSender.cpp:
1391         (EventSender::EventSender):
1392         (EventSender::gestureScrollFirstPoint):
1393         * DumpRenderTree/chromium/EventSender.h:
1394         (EventSender):
1395
1396 2012-03-02  Carlos Garcia Campos  <cgarcia@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
1397
1398         [GTK] WebKitIconDatabase doesn't keep icons cached
1399         https://bugs.webkit.org/show_bug.cgi?id=56200
1400
1401         Reviewed by Martin Robinson.
1402
1403         Add support for favicons in GtkLauncher.
1404
1405         * GtkLauncher/main.c:
1406         (activateUriEntryCb):
1407         (iconLoadedCb):
1408         (createBrowser):
1409
1410 2012-03-16  Adam Barth  <abarth@webkit.org>
1411
1412         Remove sheriff-bot's last-green-revision command
1413         https://bugs.webkit.org/show_bug.cgi?id=81314
1414
1415         Reviewed by Eric Seidel.
1416
1417         This command is a cruel joke.  WebKit doesn't really ever have a
1418         last-green-revision.
1419
1420         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1421         (BuildBot._find_green_revision):
1422         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1423         (MockBuildBot.builder_statuses):
1424         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1425         (test_find_green_revision):
1426         * Scripts/webkitpy/tool/bot/irc_command.py:
1427         (IRCCommand.execute):
1428         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1429         (SheriffIRCBotTest.test_help):
1430         * Scripts/webkitpy/tool/commands/queries.py:
1431         (PatchesToReview.execute):
1432
1433 2012-03-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1434
1435         [Qt] Make gccdepends test aware of broken icecream deps generation
1436
1437         Icecream seems to build the files without passing -o to gcc with
1438         the original destination path, which means the target name in the
1439         dependency file is wrong.
1440
1441         Also, echo something to the final file instead of just touching it,
1442         so it's not deleted on every build.
1443
1444         Reviewed by Simon Hausmann.
1445
1446         * qmake/config.tests/gccdepends/gccdepends.pro:
1447
1448 2012-03-16  Kihong Kwon  <kihong.kwon@samsung.com>
1449
1450         Support for Battery Status API
1451         https://bugs.webkit.org/show_bug.cgi?id=62698
1452
1453         Add include directory and file.
1454         http://www.w3.org/TR/battery-status/
1455
1456         Reviewed by Adam Barth.
1457
1458         * Scripts/build-webkit:
1459
1460 2012-03-16  Kishore Bolisetty  <kbolisetty@innominds.com>
1461
1462         check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
1463         https://bugs.webkit.org/show_bug.cgi?id=81007
1464
1465         Reviewed by Adam Barth.
1466
1467         A dedidcated build slave is available for efl on build.webkit.org. 
1468         This change add's an entry for the elf port in list of available port builders.
1469         This is required because test_expectations.py when triggered, looks for a valid port object for the specified port. 
1470
1471         * Scripts/webkitpy/layout_tests/port/builders.py:
1472
1473 2012-03-16  Adam Barth  <abarth@webkit.org>
1474
1475         [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
1476         https://bugs.webkit.org/show_bug.cgi?id=81302
1477
1478         Reviewed by Eric Seidel.
1479
1480         This is a trivial patch, but the variable name turned up in a grep of
1481         webkitpy and looks like copy pasta.
1482
1483         * Scripts/webkitpy/common/net/statusserver.py:
1484         (StatusServer.next_work_item):
1485
1486 2012-03-16  Andrew Lo  <anlo@rim.com>
1487
1488         [BlackBerry] Enable PAGE_VISIBILITY_API
1489         https://bugs.webkit.org/show_bug.cgi?id=81257
1490
1491         Enable Page Visibility API for BlackBerry.
1492
1493         Reviewed by Rob Buis.
1494
1495         * Scripts/build-webkit:
1496
1497 2012-03-16  Zan Dobersek  <zandobersek@gmail.com>
1498
1499         [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
1500         https://bugs.webkit.org/show_bug.cgi?id=81232
1501
1502         Reviewed by Philippe Normand.
1503
1504         Use the newly-added helper method in DumpRenderTreeSupportGtk.
1505
1506         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1507         (LayoutTestController::computedStyleIncludingVisitedInfo):
1508
1509 2012-03-15  Eric Seidel  <eric@webkit.org>
1510
1511         Move parse_bug_id into config/urls in preparation for re-use elsewhere.
1512         https://bugs.webkit.org/show_bug.cgi?id=81313
1513
1514         Reviewed by Adam Barth.
1515
1516         * Scripts/webkitpy/common/checkout/changelog.py:
1517         (parse_bug_id_from_changelog):
1518         * Scripts/webkitpy/common/config/urls.py:
1519         (parse_bug_id):
1520         * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
1521         (URLsTest):
1522         (URLsTest.test_parse_bug_id):
1523         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1524         (test_parse_bug_id):
1525         * Scripts/webkitpy/tool/bot/irc_command.py:
1526         (_post_error_and_check_for_bug_url):
1527         * Scripts/webkitpy/tool/bot/sheriff.py:
1528         (Sheriff.post_rollout_patch):
1529         (Sheriff.post_chromium_deps_roll):
1530
1531 2012-03-15  Adam Barth  <abarth@webkit.org>
1532
1533         The commit-queue should fast-track patches that have already passed the testing EWS bots
1534         https://bugs.webkit.org/show_bug.cgi?id=81305
1535
1536         Reviewed by Eric Seidel.
1537
1538         If a patch has already passed the testing EWS bots (currently only the
1539         chromium-ews bot), we should be able to land the patch without running
1540         the tests again.  This patch is somewhat risky in that the tests might
1541         have been broken between when the EWS bots ran and when the
1542         commit-queue is processing the patch.  If that turns out to be a
1543         problem in practice, we'll tighten up this fast-track in some way,
1544         likely by making sure that the pass status is recent.
1545
1546         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1547         (CommitQueueTaskDelegate.did_pass_testing_ews):
1548         (CommitQueueTask._did_pass_tests_recently):
1549         (CommitQueueTask.run):
1550         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1551         (MockCommitQueue.did_pass_testing_ews):
1552         (test_fast_success_case):
1553         * Scripts/webkitpy/tool/commands/queues.py:
1554         (CommitQueue.did_pass_testing_ews):
1555         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1556         (test_did_pass_testing_ews):
1557
1558 2012-03-15  Kentaro Hara  <haraken@chromium.org>
1559
1560         [PerformanceTests] run-perf-tests should output correct units
1561         https://bugs.webkit.org/show_bug.cgi?id=78303
1562
1563         Reviewed by Ryosuke Niwa.
1564
1565         Previously run-perf-tests just supported "ms" for units.
1566         Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
1567         This patch fixes run-perf-tests so that they can support custom units.
1568         The default unit is "ms".
1569
1570         The test result looks like this:
1571
1572         $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
1573         RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
1574         median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
1575
1576         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1577         (PerfTestsRunner._process_parser_test_result):
1578
1579 2012-03-15  Brent Fulgham  <bfulgham@webkit.org>
1580
1581         [WinCairo] Unreviewed build change after wtf path changes.
1582
1583         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
1584         directories to look at the private header directory to find 'wtf'.
1585
1586 2012-03-15  Kent Tamura  <tkent@chromium.org>
1587
1588         REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
1589         https://bugs.webkit.org/show_bug.cgi?id=81293
1590
1591         Reviewed by Adam Barth.
1592
1593         r110595 introduced new format of the author field of ChangeLog entry:
1594         "Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>"
1595         Updte chanelog.py to support it.
1596
1597         * Scripts/webkitpy/common/checkout/changelog.py:
1598         (ChangeLogEntry._split_contributor_names):
1599         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1600         (test_parse_authors):
1601
1602 2012-03-15  Lynn Neir  <lynn.neir@skype.net>
1603
1604         Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
1605
1606         Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
1607
1608         Reviewed by Jessie Berlin.
1609
1610         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1611         (LayoutTestController::setValueForUser):
1612         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1613         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1614         (WTR::LayoutTestController::setValueForUser):
1615         (WTR):
1616         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1617         (LayoutTestController):
1618
1619 2012-03-15  Adam Barth  <abarth@webkit.org>
1620
1621         Update the start-queue.sh script to match what we're using on the bots
1622         https://bugs.webkit.org/show_bug.cgi?id=81277
1623
1624         Reviewed by Eric Seidel.
1625
1626         Over time we've added more magic git commands to clean up the local repo after
1627         it has been borked in various ways. The idea behind this sequence is to clear
1628         out any changes in the working copy and then to rebuild the master branch from
1629         origin/master.
1630
1631         This patch also removes the watchdog timer that we've stopped using on the
1632         bots.
1633
1634         This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
1635         Note: Eric and I are experimenting with GitHub to see if it might be
1636         useful for WebKit.  If you have thoughts on this topic, please feel
1637         free to grab Eric or me on #webkit to chat.  I assume that he and I are
1638         the only ones who care about this file so using this alternative
1639         process for this patch shouldn't cause any trouble.
1640
1641         * EWSTools/start-queue.sh:
1642
1643 2012-03-15  Adam Barth  <abarth@webkit.org>
1644
1645         The commit-queue can hang when the test_expectations.txt style check fails during commit
1646         https://bugs.webkit.org/show_bug.cgi?id=81251
1647
1648         Reviewed by Eric Seidel.
1649
1650         We forgot to check the --non-interactive flag, so we end up prompting
1651         the "user" who doesn't exist on the bot.  We might consider teaching
1652         the User class about non-interactive if we have this sort of bug again.
1653
1654         * Scripts/webkitpy/tool/steps/commit.py:
1655         (Commit.options):
1656         (Commit._check_test_expectations):
1657         (Commit.run):
1658         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1659         (CommitTest.test_check_test_expectations):
1660
1661 2012-03-15  Jessie Berlin  <jberlin@apple.com>
1662
1663         fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
1664         Mac WK2 because WebAudio is not enabled
1665         https://bugs.webkit.org/show_bug.cgi?id=81259
1666
1667         Reviewed by Dan Bernstein.
1668
1669         Enable WebAudio so that it appears in the window object in the tests.
1670         The webaudio tests are all still skipped in the Mac Skipped list.
1671
1672         * WebKitTestRunner/TestController.cpp:
1673         (WTR::TestController::resetStateToConsistentValues):
1674
1675 2012-03-15  David Levin  <levin@chromium.org>
1676
1677         Various autoresize fixes.
1678         https://bugs.webkit.org/show_bug.cgi?id=81199
1679
1680         Reviewed by Darin Fisher.
1681
1682         * DumpRenderTree/chromium/LayoutTestController.cpp:
1683         (LayoutTestController::reset): Stop using the deprecated api that was removed.
1684
1685 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1686
1687         [GTK] Actually use --release and --debug command line options in run-gtk-test
1688         https://bugs.webkit.org/show_bug.cgi?id=81234
1689
1690         Reviewed by Philippe Normand.
1691
1692         Actually handle --release and --debug command line options to
1693         create the build directory, falling back to current hack to detect
1694         whether it's a Release or Debug build when both options are missed.
1695
1696         * Scripts/run-gtk-tests:
1697         (TestRunner.__init__): Receive options too.
1698         (TestRunner._get_top_level_directory): Helper function to get the
1699         top level directory.
1700         (TestRunner._get_build_directory): Helper function to get the
1701         build directory depending on --release/--debug command line
1702         options or gessing it if both options are missing.
1703         (TestRunner._ensure_accessibility_daemon_is_running): Use
1704         self-options now.
1705         (TestRunner.run): Ditto.
1706         (TestRunner.run.run_tests): Pass options to the constructor
1707         instead of run().
1708
1709 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1710
1711         [GTK] Run unit tests with --verbose in the bots
1712         https://bugs.webkit.org/show_bug.cgi?id=81230
1713
1714         Reviewed by Martin Robinson.
1715
1716         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1717         (RunGtkAPITests): Add --verbose to run-gtk-test command.
1718
1719 2012-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1720
1721         Move wx port to using export macros
1722         https://bugs.webkit.org/show_bug.cgi?id=77279
1723
1724         Reviewed by Hajime Morita.
1725
1726         * waf/build/settings.py:
1727         (common_configure):
1728
1729 2012-03-15  Philippe Normand  <pnormand@igalia.com>
1730
1731         Unreviewed, GTK build fix attempt after r110845.
1732
1733         * Scripts/run-gtk-tests: Added --release and --debug options.
1734
1735 2012-03-15  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1736
1737         Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
1738         https://bugs.webkit.org/show_bug.cgi?id=79673
1739
1740         Preparatory work for bringing jhbuild enabled build to EFL port.
1741
1742         Reviewed by Philippe Normand.
1743
1744         * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
1745         * Scripts/update-webkitgtk-libs:
1746         * gtk/run-with-jhbuild:
1747         * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
1748         (top_level_path):
1749         (jhbuild_installed):
1750         (jhbuild_cloned):
1751         (jhbuild_at_expected_revision):
1752         (update_jhbuild):
1753         (clone_jhbuild):
1754         (install_jhbuild):
1755         (update_webkit_libs_jhbuild):
1756         (determine_platform):
1757         (ensure_jhbuild):
1758
1759 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1760
1761         [GTK] Add command line options to run-gtk-tests script
1762         https://bugs.webkit.org/show_bug.cgi?id=81218
1763
1764         Reviewed by Philippe Normand.
1765
1766         Following command line options have been added:
1767
1768         -v, --verbose: to run gtester with --verbose. That would be used
1769         by the bots to make it easier to know which test case it failing.
1770
1771         --display: to use a different display for Xvfb
1772
1773         It's also possible to pass one or more tests as arguments.
1774
1775         * Scripts/run-gtk-tests:
1776         (TestRunner.__init__): Receive command line arguments.
1777         (TestRunner._get_tests): Get all the tests or the ones passed by
1778         command line arguments.
1779         (TestRunner._ensure_accessibility_daemon_is_running): Use display
1780         command line argument.
1781         (TestRunner.run): Pas command line options.
1782         (TestRunner.run.run_tests): Pass command line arguments.
1783
1784 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1785
1786         [GTK] WebKit2APITests/TestPrinting timeout in the bots
1787         https://bugs.webkit.org/show_bug.cgi?id=81211
1788
1789         Reviewed by Philippe Normand.
1790
1791         Add gtk+ patch to fix timeout in the bots. A similar patch has
1792         already landed in updatream gtk+, see
1793         http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
1794
1795         * gtk/jhbuild.modules:
1796         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
1797
1798 2012-03-14  Gustavo Noronha Silva  <gns@gnome.org>
1799
1800         sheriffbot should also be addressable with a comma in addition to colon
1801         https://bugs.webkit.org/show_bug.cgi?id=81101
1802
1803         Reviewed by Adam Barth.
1804
1805         * Scripts/webkitpy/common/net/irc/ircbot.py:
1806         (IRCBot.on_pubmsg):
1807
1808 2012-03-15  Alexander Færøy  <alexander.faeroy@nokia.com>
1809
1810         [Qt] MiniBrowser scroll indicators should not scroll out of view
1811         https://bugs.webkit.org/show_bug.cgi?id=81131
1812
1813         Reviewed by Kenneth Rohde Christiansen.
1814
1815         * MiniBrowser/qt/qml/ScrollIndicator.qml:
1816
1817 2012-03-14  Chris Fleizach  <cfleizach@apple.com>
1818
1819         AX: ARIA tables need to support selected rows attribute/select rows changed notification
1820         https://bugs.webkit.org/show_bug.cgi?id=79821
1821
1822         Reviewed by Beth Dakin.
1823
1824         * DumpRenderTree/AccessibilityUIElement.cpp:
1825         (rowAtIndexCallback):
1826         (AccessibilityUIElement::getJSClass):
1827         * DumpRenderTree/AccessibilityUIElement.h:
1828         (AccessibilityUIElement):
1829         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1830         (AccessibilityUIElement::rowAtIndex):
1831         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1832         (AccessibilityUIElement::rowAtIndex):
1833         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1834         (AccessibilityUIElement::rowAtIndex):
1835         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1836         (AccessibilityUIElement::rowAtIndex):
1837
1838 2012-03-14  Tim Horton  <timothy_horton@apple.com>
1839
1840         NRWT should respect --additional-platform-directory's Skipped list
1841         https://bugs.webkit.org/show_bug.cgi?id=81172
1842
1843         Reviewed by Timothy Hatcher.
1844
1845         Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
1846         from said path are already used, but the Skipped file is ignored.
1847
1848         * Scripts/webkitpy/layout_tests/port/webkit.py:
1849         (WebKitPort._skipped_file_search_paths):
1850         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1851         (test_skipped_file_search_paths):
1852
1853 2012-03-14  Ojan Vafai  <ojan@chromium.org>
1854
1855         Unreviewed, rolling out r110783.
1856         http://trac.webkit.org/changeset/110783
1857         https://bugs.webkit.org/show_bug.cgi?id=81054
1858
1859         Caused existing test expectation lines to expand to one for
1860         each test configuration.
1861
1862         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1863         (TestExpectations.has_warnings):
1864         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1865         (test_macro_overrides):
1866         * Scripts/webkitpy/tool/commands/rebaseline.py:
1867         (RebaselineTest._save_baseline):
1868         (RebaselineTest._rebaseline_test):
1869         (RebaselineTest.execute):
1870         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1871         (TestRebaseline.test_tests_to_update):
1872
1873 2012-03-13  Jon Lee  <jonlee@apple.com>
1874
1875         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
1876         https://bugs.webkit.org/show_bug.cgi?id=80922
1877         <rdar://problem/11035082>
1878
1879         Reviewed by Jian Li.
1880
1881         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
1882         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
1883         new API. Therefore, APIs that are common between the two will have:
1884         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
1885
1886         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
1887         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
1888
1889         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
1890         * DumpRenderTree/chromium/LayoutTestController.cpp:
1891         (LayoutTestController::grantDesktopNotificationPermission):
1892         (LayoutTestController::simulateDesktopNotificationClick):
1893         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1894         * DumpRenderTree/chromium/TestShell.cpp:
1895         (TestShell::TestShell):
1896         (TestShell::resetTestController):
1897         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1898         (DRTDesktopNotificationPresenter::checkNotificationPermission):
1899
1900 2012-03-13  Ojan Vafai  <ojan@chromium.org>
1901
1902         Have webkit-patch rebaseline-test update test_expectations.txt
1903         https://bugs.webkit.org/show_bug.cgi?id=81054
1904
1905         Reviewed by Dirk Pranke.
1906
1907         This will allow us to use the All Failures tab in garden-o-matic
1908         to rebaseline tests without making test_expectations.txt stale.
1909
1910         It's conservative and only removes lines if the test is
1911         not flaky and fails in a way the rebaseline would fix (e.g.
1912         CRASH/TIMEOUT will not be touched).
1913
1914         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1915         (TestExpectations.remove_configuration_from_test):
1916         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1917         (RemoveConfigurationsTest):
1918         (RemoveConfigurationsTest.test_remove):
1919         (test_remove_line):
1920         * Scripts/webkitpy/tool/commands/rebaseline.py:
1921         (RebaselineTest._is_supported_port):
1922         (RebaselineTest):
1923         (RebaselineTest._update_expectations_file):
1924         (RebaselineTest._rebaseline_test_and_update_expectations):
1925         (RebaselineTest.execute):
1926         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1927         (TestRebaseline.test_rebaseline_updates_expectations_file):
1928
1929 2012-03-14  Jessie Berlin  <jberlin@apple.com>
1930
1931         Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
1932         https://bugs.webkit.org/show_bug.cgi?id=81167
1933
1934         Reviewed by Sam Weinig.
1935
1936         Do not use 0 as a key in a HashMap.
1937
1938         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1939         cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
1940
1941 2012-03-14  Ojan Vafai  <ojan@chromium.org>
1942
1943         Add the chromium lion bot to garden-o-matic and remove
1944         the platform_move_to in builders.py since the Chromium Lion
1945         port is now a normal port.
1946
1947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1948         * Scripts/webkitpy/layout_tests/port/builders.py:
1949
1950 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
1951
1952         Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
1953
1954         Unreviewed, build fix.
1955
1956         * Scripts/webkitpy/layout_tests/port/base.py:
1957         (Port.skipped_tests):
1958
1959 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
1960
1961         Please add a way to manually skip some tests in NRWT
1962         https://bugs.webkit.org/show_bug.cgi?id=81019
1963
1964         Reviewed by Ojan Vafai.
1965
1966         This patch implements the -i / --ignore-tests flag from ORWT
1967         and refactors the test_expectations.py code slightly to handle
1968         it.
1969
1970         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1971         (Manager.parse_expectations):
1972         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1973         (TestExpectations.__init__):
1974         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1975         (test_add_skipped_tests):
1976         (test_add_skipped_tests_duplicate):
1977         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1978         (parse_args):
1979         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1980         (MainTest.test_ignore_tests):
1981         (MainTest.test_ignore_tests.assert_ignored):
1982
1983 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
1984
1985         nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
1986         https://bugs.webkit.org/show_bug.cgi?id=81028
1987
1988         Reviewed by Ojan Vafai.
1989
1990         The mac port had incorrect lookups for 'mac-lion' and
1991         'mac-future' in some places. This patch fixes that and adds a
1992         bunch of tests.
1993
1994         * Scripts/webkitpy/layout_tests/port/mac.py:
1995         (MacPort.baseline_path):
1996         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1997         (MacTest.assert_skipped_file_search_paths):
1998         (MacTest.test_skipped_file_search_paths):
1999         (_assert_search_path):
2000         (test_baseline_search_path):
2001         * Scripts/webkitpy/layout_tests/port/webkit.py:
2002         (WebKitPort._skipped_file_search_paths):
2003
2004 2012-03-13  Jer Noble  <jer.noble@apple.com>
2005
2006         Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
2007         https://bugs.webkit.org/show_bug.cgi?id=81056
2008
2009         Reviewed by Jessie Berlin.
2010
2011         Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
2012
2013         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2014         (WTR::InjectedBundlePage::InjectedBundlePage):
2015         (WTR::InjectedBundlePage::beganEnterFullScreen):
2016         (WTR::InjectedBundlePage::beganExitFullScreen):
2017
2018 2012-03-14  Alexander Færøy  <alexander.faeroy@nokia.com>
2019
2020         The width and height of the scroll indicators in the MiniBrowser does
2021         not consider the offset margins.
2022         https://bugs.webkit.org/show_bug.cgi?id=81112
2023
2024         Reviewed by Kenneth Rohde Christiansen.
2025
2026         This patch fixes the issue by withdrawing two times the anchor
2027         margins.
2028
2029         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2030
2031 2012-03-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2032
2033         [EFL] Implement LayoutTestController::clearBackForwardList
2034         https://bugs.webkit.org/show_bug.cgi?id=80142
2035
2036         Adding missing implementation clearBackForwardList to EFL's
2037         LayoutTestController. This implementation allows us to unskip 
2038         tests connected with history.
2039
2040         Reviewed by Antonio Gomes.
2041
2042         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2043         (LayoutTestController::clearBackForwardList): Implemented.
2044
2045 2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2046
2047         [EFL][DRT] Expose window.internals object
2048         https://bugs.webkit.org/show_bug.cgi?id=79900
2049
2050         Exposes window.internals for EFL's DRT. Makes possible to
2051         remove some tests from the skip list.
2052
2053         Reviewed by Antonio Gomes.
2054
2055         * DumpRenderTree/efl/CMakeLists.txt:
2056         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2057         (DumpRenderTreeChrome::onWindowObjectCleared):
2058
2059 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
2060
2061         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
2062         https://bugs.webkit.org/show_bug.cgi?id=78853
2063
2064         Reviewed by Adam Barth.
2065
2066         * Scripts/build-webkit:
2067         * qmake/mkspecs/features/features.prf:
2068
2069 2012-03-12  Antonio Gomes  <agomes@rim.com>
2070
2071         Convert nodesFromRect tests to use Internals interface
2072         https://bugs.webkit.org/show_bug.cgi?id=80886
2073
2074         Reviewed by Ryosuke Niwa.
2075
2076         This clean up allows to remove port specific bits of each
2077         DRT implementation that supports testing Document::nodesFromRect,
2078         in favor of making use of the 'Internals' interface to test it.
2079
2080         This makes its code conveniently more expansible and cleaner.
2081
2082         Also removed stubs from Win and EFL DRTs.
2083
2084         * DumpRenderTree/LayoutTestController.cpp:
2085         (LayoutTestController::staticFunctions):
2086         * DumpRenderTree/LayoutTestController.h:
2087         (LayoutTestController):
2088         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2089         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2090         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2091         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2092         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2093         (LayoutTestController):
2094         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2095
2096 2012-03-13  Ojan Vafai  <ojan@chromium.org>
2097
2098         Rebaselining for a new port doesn't work right with multiple fallback ports
2099         https://bugs.webkit.org/show_bug.cgi?id=80932
2100
2101         Reviewed by Adam Barth.
2102
2103         Since chromium-leopard also falls back to mac-leopard, we need to
2104         copy the existing result for both chromium-leopard and chromium-snowleopard
2105         before doing lion rebaselines.
2106
2107         * Scripts/webkitpy/layout_tests/port/builders.py:
2108         (fallback_port_names_for_new_port):
2109         * Scripts/webkitpy/tool/commands/rebaseline.py:
2110         (RebaselineTest):
2111         (RebaselineTest._copy_existing_baseline):
2112         (RebaselineTest._rebaseline_test):
2113         (RebaselineTest.execute):
2114         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2115         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2116         (GardeningHTTPRequestHandler.rebaseline):
2117         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2118         (GardeningServerTest.test_rebaseline_new_port):
2119
2120 2012-03-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2121
2122         [Qt] Tweak minibrowser UI
2123
2124         Add some margins to the scroll indicators, and set a dark background
2125         color so you see the page dimensions.
2126
2127         Reviewed by Antonio Gomes.
2128
2129         * MiniBrowser/qt/qml/BrowserWindow.qml:
2130         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2131
2132 2012-03-13  ChangSeok Oh  <shivamidow@gmail.com>
2133
2134         [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
2135         https://bugs.webkit.org/show_bug.cgi?id=79601
2136
2137         Reviewed by Gustavo Noronha Silva.
2138
2139         Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
2140         createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
2141         and is taken over to sendKeyDown.
2142         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
2143         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
2144
2145         * DumpRenderTree/efl/EventSender.cpp:
2146         (KeyEventInfo::KeyEventInfo):
2147         (KeyEventInfo):
2148         (createKeyEventInfo):
2149         (sendKeyDown):
2150         (keyDownCallback):
2151         (sendAsynchronousKeyDown):
2152         (scheduleAsynchronousKeyDownCallback):
2153
2154 2012-03-12  Ojan Vafai  <ojan@chromium.org>
2155
2156         webkit-patch optimize-baselines sometimes creates a mac-future result
2157         https://bugs.webkit.org/show_bug.cgi?id=80717
2158
2159         Reviewed by Adam Barth.
2160
2161         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2162         (_baseline_search_hypergraph):
2163         (BaselineOptimizer._find_optimal_result_placement):
2164         (BaselineOptimizer._filter_virtual_ports):
2165         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2166         (BaselineOptimizerTest.test_no_add_mac_future):
2167
2168 2012-03-12  Jessie Berlin  <jberlin@apple.com>
2169
2170         More Windows build fixing.
2171
2172         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2173
2174 2012-03-12  Jessie Berlin  <jberlin@apple.com>
2175
2176         More Windows build fixing.
2177
2178         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2179         * DumpRenderTree/win/EditingDelegate.cpp:
2180         * DumpRenderTree/win/EventSender.cpp:
2181         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2182         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2183         * DumpRenderTree/win/UIDelegate.cpp:
2184
2185 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2186
2187         remove the 'gpu' group from the flakiness dashboard
2188         https://bugs.webkit.org/show_bug.cgi?id=80353
2189
2190         Reviewed by Adam Barth.
2191
2192         Since those bots are obsolete, we don't need this any more.
2193
2194         * TestResultServer/static-dashboards/builders.js:
2195         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2196         (testPlatformAndBuildType):
2197         (testHtmlForTestTypeSwitcherGroup):
2198
2199 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2200
2201         remove graphics_type from webkitpy.layout_tests.models.test_configuration
2202         https://bugs.webkit.org/show_bug.cgi?id=80643
2203
2204         Reviewed by Ojan Vafai.
2205
2206         Now that the chromium-gpu ports are gone, there's no need for
2207         the graphics_type CPU/GPU distinction. Most of this change is
2208         just updating tests accordingly.
2209
2210         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2211         (TestExpectationEditorTests):
2212         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2213         (TestConfiguration.__init__):
2214         (TestConfiguration.category_order):
2215         (TestConfiguration.__str__):
2216         (TestConfiguration.__repr__):
2217         (TestConfiguration.__hash__):
2218         (TestConfigurationConverter.to_specifiers_list):
2219         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2220         (make_mock_all_test_configurations_set):
2221         (TestConfigurationTest.test_items):
2222         (TestConfigurationTest.test_keys):
2223         (TestConfigurationTest.test_str):
2224         (TestConfigurationTest.test_repr):
2225         (TestConfigurationTest.test_hash):
2226         (TestConfigurationTest.test_hash.query_unknown_key):
2227         (TestConfigurationTest.test_eq):
2228         (TestConfigurationTest.test_values):
2229         (SpecifierSorterTest.test_specifier_priority):
2230         (SpecifierSorterTest.test_sort_specifiers):
2231         (TestConfigurationConverterTest.test_to_config_set):
2232         (TestConfigurationConverterTest.test_macro_expansion):
2233         (TestConfigurationConverterTest.test_to_specifier_lists):
2234         (TestConfigurationConverterTest.test_converter_macro_collapsing):
2235         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2236         (test_error_on_different_build_type):
2237         (TestExpectationSerializerTests.test_parsed_to_string):
2238         (TestExpectationSerializerTests.test_reconstitute_only_these):
2239         * Scripts/webkitpy/layout_tests/port/apple.py:
2240         (ApplePort._generate_all_test_configurations):
2241         * Scripts/webkitpy/layout_tests/port/base.py:
2242         (Port.__init__):
2243         (Port.name):
2244         (Port.version):
2245         (Port.test_configuration):
2246         * Scripts/webkitpy/layout_tests/port/builders.py:
2247         * Scripts/webkitpy/layout_tests/port/chromium.py:
2248         (ChromiumPort):
2249         (ChromiumPort._generate_all_test_configurations):
2250         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2251         (ChromiumLinuxPort.__init__):
2252         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2253         (ChromiumLinuxPortTest.test_check_illegal_port_names):
2254         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2255         (ChromiumMacPortTest.test_baseline_path):
2256         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2257         (ChromiumPortTest.test_all_test_configurations):
2258         * Scripts/webkitpy/layout_tests/port/efl.py:
2259         (EflPort._generate_all_test_configurations):
2260         * Scripts/webkitpy/layout_tests/port/gtk.py:
2261         (GtkPort._generate_all_test_configurations):
2262         * Scripts/webkitpy/layout_tests/port/qt.py:
2263         (QtPort._generate_all_test_configurations):
2264         * Scripts/webkitpy/layout_tests/port/test.py:
2265         (TestPort.all_test_configurations):
2266         (TestPort._all_build_types):
2267         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2268         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2269         (BuildCoverageExtrapolatorTest.test_extrapolate):
2270         (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
2271         (GardeningExpectationsUpdaterTest.test_add_new_expectation):
2272         (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
2273         (GardeningExpectationsUpdaterTest.test_pass_expectation):
2274         (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
2275         (GardeningExpectationsUpdaterTest.test_spurious_updates):
2276
2277 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2278
2279         _runtime_feature_list isn't supported on Apple Mac DRT
2280         https://bugs.webkit.org/show_bug.cgi?id=80906
2281
2282         Reviewed by Eric Seidel.
2283
2284         It looks like this feature is actually only supported on the Win
2285         DRT port, so this patch reworks the code to make that clearer
2286         and reduce unnecessary overrides.
2287
2288         * Scripts/webkitpy/layout_tests/port/efl.py:
2289         (EflPort._path_to_webcore_library):
2290         * Scripts/webkitpy/layout_tests/port/gtk.py:
2291         (GtkPort._path_to_webcore_library):
2292         * Scripts/webkitpy/layout_tests/port/qt.py:
2293         (QtPort._skipped_file_search_paths):
2294         * Scripts/webkitpy/layout_tests/port/webkit.py:
2295         (WebKitPort._runtime_feature_list):
2296         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2297         (TestWebKitPort.__init__):
2298         (TestWebKitPort.all_test_configurations):
2299         (test_skipped_directories_for_features):
2300         * Scripts/webkitpy/layout_tests/port/win.py:
2301         (WinPort):
2302         (WinPort._runtime_feature_list):
2303         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2304         (WinPortTest.test_operating_system):
2305         (WinPortTest):
2306         (WinPortTest.test_runtime_feature_list):
2307
2308 2012-03-12  Peter Beverloo  <peter@chromium.org>
2309
2310         [Chromium] Temporary build-fix for the Android bot
2311         https://bugs.webkit.org/show_bug.cgi?id=80862
2312
2313         Reviewed by Adam Barth.
2314
2315         Manually set the environmental variables required to compile source
2316         files through the Android NDK instead of relying on the envsetup.sh
2317         script. A proper fix will be landed to Chromium ASAP, and following
2318         a Chromium roll into WebKit this code will be removed.
2319
2320         * Scripts/webkitdirs.pm:
2321         (buildChromiumMakefile):
2322
2323 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2324
2325         [Qt] Use right construct to detect config_test_gccdepends
2326
2327         Reviewed by Andreas Kling.
2328
2329         * qmake/mkspecs/features/default_pre.prf:
2330
2331 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2332
2333         [Qt] Expose location of WebKit's bin and imports dir through module file
2334
2335         Reviewed by Andreas Kling.
2336
2337         * qmake/qt_webkit.pri:
2338
2339 2012-03-12  Andras Becsi  <andras.becsi@nokia.com>
2340
2341         [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
2342         https://bugs.webkit.org/show_bug.cgi?id=80832
2343
2344         Reviewed by Tor Arne Vestbø.
2345
2346         Add a basic scroll indicator component to MiniBrowser so that it
2347         behaves similar to the ScrollDecorator QML component.
2348
2349         * MiniBrowser/qt/MiniBrowser.qrc:
2350         * MiniBrowser/qt/qml/BrowserWindow.qml:
2351         * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
2352
2353 2012-03-12  C Anthony Risinger  <anthony@xtfx.me>
2354
2355         [GTK] r110296 included an extra $ in @$(AM_V_GEN)
2356         https://bugs.webkit.org/show_bug.cgi?id=80809
2357
2358         Reviewed by Philippe Normand.
2359
2360         * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
2361
2362 2012-03-12  Ming Xie  <mxie@rim.com>
2363
2364         [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
2365         https://bugs.webkit.org/show_bug.cgi?id=80812
2366
2367         Reviewed by Rob Buis.
2368
2369         * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
2370         * Scripts/webkitdirs.pm:
2371         (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
2372
2373
2374 2012-03-12  Simon Hausmann  <simon.hausmann@nokia.com>
2375
2376         [Qt] Fix build with newer Qt 5.
2377
2378         Reviewed by Tor Arne Vestbø.
2379
2380         Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
2381         renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
2382         we should disable -Werror.
2383
2384         Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
2385         implicit load was removed recently.
2386
2387         * qmake/mkspecs/features/default_pre.prf:
2388         * qmake/mkspecs/features/unix/default_post.prf:
2389
2390 2012-03-11  Maciej Stachowiak  <mjs@apple.com>
2391
2392         Add --instruments option to sunspider to profile with Instruments
2393         https://bugs.webkit.org/show_bug.cgi?id=80783
2394
2395         Reviewed by Filip Pizlo.
2396
2397         * Scripts/run-sunspider:
2398
2399 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2400
2401         [Qt] [WK2] Support threaded renderer in WK2
2402         https://bugs.webkit.org/show_bug.cgi?id=76661
2403
2404         Remove disabling of threaded rendering.
2405
2406         Reviewed by Noam Rosenthal.
2407
2408         * MiniBrowser/qt/main.cpp:
2409         (main):
2410
2411 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
2412
2413         [WK2] run-perf-tests should be able to run with WTR
2414         https://bugs.webkit.org/show_bug.cgi?id=80042
2415
2416         Reviewed by Martin Robinson.
2417
2418         Add an option to PerfTestRunner to use WebKitTestRunner instead of
2419         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
2420         to avoid timing out when running performance tests.
2421
2422         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2423         (PerfTestsRunner._parse_args):
2424         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2425         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
2426         to true.
2427         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
2428         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
2429         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2430         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
2431         publicly accessible.
2432         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2433         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
2434         is required.
2435         * WebKitTestRunner/TestController.cpp:
2436         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
2437         to true.
2438         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
2439         if '--no-timeout' option is present.
2440         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
2441         value, or -1.0 if timeout should not occur.
2442         * WebKitTestRunner/TestController.h:
2443         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
2444         publicly accessible.
2445         * WebKitTestRunner/TestInvocation.cpp:
2446         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
2447         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
2448         Waiting for final message should not time out if not necessary.
2449         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2450         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
2451         * WebKitTestRunner/qt/TestControllerQt.cpp:
2452         (WTR::TestController::platformRunUntil): Ditto.
2453         * WebKitTestRunner/mac/TestControllerMac.mm:
2454         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
2455         is missing.
2456         * WebKitTestRunner/win/TestControllerWin.cpp:
2457         (WTR::TestController::platformRunUntil): Ditto.
2458
2459 2012-03-09  Jon Lee  <jonlee@apple.com>
2460
2461         Rename NotificationPresenter to NotificationClient
2462         https://bugs.webkit.org/show_bug.cgi?id=80488
2463         <rdar://problem/10965558>
2464
2465         Reviewed by Kentaro Hara.
2466
2467         Refactor to use renamed WebCore::NotificationClient.
2468         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2469         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2470
2471 2012-03-07  James Robinson  <jamesr@chromium.org>
2472
2473         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
2474         https://bugs.webkit.org/show_bug.cgi?id=80523
2475
2476         Reviewed by Darin Fisher.
2477
2478         * DumpRenderTree/chromium/WebViewHost.cpp:
2479         (WebViewHost::createGraphicsContext3D):
2480         * DumpRenderTree/chromium/WebViewHost.h:
2481         (WebViewHost):
2482
2483 2012-03-09  Eric Seidel  <eric@webkit.org>
2484
2485         build-webkit should build Source/WTF on Mac
2486         https://bugs.webkit.org/show_bug.cgi?id=80728
2487
2488         Reviewed by Adam Barth.
2489
2490         We'll add other ports to this list in future commits.
2491
2492         * Scripts/build-webkit:
2493
2494 2012-03-09  Jon Lee  <jonlee@apple.com>
2495
2496         Add support for ENABLE(LEGACY_NOTIFICATIONS)
2497         https://bugs.webkit.org/show_bug.cgi?id=80497
2498
2499         Reviewed by Adam Barth.
2500
2501         Prep for b80472: Update API for Web Notifications
2502         * Scripts/build-webkit:
2503         * qmake/mkspecs/features/features.prf:
2504
2505 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
2506
2507         Bash scripts should support LF endings only
2508         https://bugs.webkit.org/show_bug.cgi?id=79509
2509
2510         Reviewed by David Kilzer.
2511
2512         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
2513         * EWSTools/start-queue.sh: Added property svn:eol-style.
2514         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
2515         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
2516         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
2517         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
2518
2519 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
2520
2521         [BUILD] use detected python to run generate-gtkdoc
2522         https://bugs.webkit.org/show_bug.cgi?id=80695
2523
2524         Reviewed by Gustavo Noronha Silva.
2525
2526         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
2527
2528 2012-03-09  Nat Duca  <nduca@chromium.org>
2529
2530         Make check-webkit-style complain about "no new tests" lines in changelogs
2531         https://bugs.webkit.org/show_bug.cgi?id=80582
2532
2533         Reviewed by David Levin.
2534
2535         * Scripts/webkitpy/style/checkers/changelog.py:
2536         (ChangeLogChecker.check_entry):
2537         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2538         (ChangeLogCheckerTest.test_no_new_tests):
2539
2540 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2541
2542         Unreviewed, rolling out r110250.
2543         http://trac.webkit.org/changeset/110250
2544         https://bugs.webkit.org/show_bug.cgi?id=80682
2545
2546         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
2547         qt-linux at all. (Requested by Ossy on #webkit).
2548
2549         * Scripts/old-run-webkit-tests:
2550         * Scripts/webkitpy/layout_tests/port/qt.py:
2551         (QtPort):
2552         (QtPort.determine_full_port_name):
2553         (QtPort.baseline_search_path):
2554         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2555         (QtPortTest):
2556         (QtPortTest._assert_search_path):
2557         (QtPortTest.test_baseline_search_path):
2558
2559 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2560
2561         [Qt] Use Qt's module system for install rules and depending on QtWebKit
2562
2563         Instead of rolling our own install rules we now use the same approach as
2564         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
2565
2566         This ensures that we follow the same semantics as the rest of Qt on
2567         what sort of config options are enabled by default (create_cmake eg.).
2568         It also allows us to use QT += webkit instead of the workaround we had
2569         with CONFIG += qtwebkit.
2570
2571         We do however force Qt to always treat our build as a non-developer build,
2572         so the libraries will end up in the WebKit lib directory instead of the
2573         qtbase directory (as with a normal developer-build). This allows us to
2574         keep the webkit-build self-contained. If Qt is a developer build we still
2575         copy the module file manually to Qt, so that you don't have to install
2576         WebKit to make it available.
2577
2578         For non-developer builds of Qt, it is still possible to use the built
2579         WebKit libraries without having to install them, by having the variable
2580         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
2581         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
2582
2583         https://bugs.webkit.org/show_bug.cgi?id=80590
2584
2585         Reviewed by Simon Hausmann.
2586
2587         * DumpRenderTree/qt/DumpRenderTree.pro:
2588         * MiniBrowser/qt/BrowserWindow.cpp:
2589         * MiniBrowser/qt/MiniBrowser.pro:
2590         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2591         * MiniBrowser/qt/UrlLoader.cpp:
2592         * QtTestBrowser/QtTestBrowser.pro:
2593         * Tools.pro:
2594         * WebKitTestRunner/InjectedBundle/Target.pri:
2595         * WebKitTestRunner/Target.pri:
2596         * qmake/mkspecs/features/default_post.prf:
2597         * qmake/mkspecs/features/default_pre.prf:
2598         * qmake/mkspecs/features/functions.prf:
2599         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
2600         * qmake/mkspecs/features/qtwebkit.prf:
2601         * qmake/mkspecs/features/rpath.prf:
2602         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
2603         * qmake/qt_webkit.pri: Added.
2604
2605 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
2606
2607         Unreviewed. Update my email.
2608
2609         * Scripts/webkitpy/common/config/committers.py:
2610
2611 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2612
2613         Recent changes to chromium.py etc. broke chromium_android.py
2614         https://bugs.webkit.org/show_bug.cgi?id=80623
2615
2616         Reviewed by Dirk Pranke.
2617
2618         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2619         (ChromiumAndroidDriver.__init__):
2620         (ChromiumAndroidDriver._start):
2621
2622 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2623
2624         [Chromium] Exception running reftest with --no-pixel-tests
2625         https://bugs.webkit.org/show_bug.cgi?id=80642
2626
2627         Reviewed by Dirk Pranke.
2628
2629         * Scripts/webkitpy/layout_tests/port/chromium.py:
2630         (ChromiumDriver.__init__):
2631         (ChromiumDriver._wrapper_options):
2632
2633 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
2634
2635         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
2636         https://bugs.webkit.org/show_bug.cgi?id=72489
2637
2638         Reviewed by Dirk Pranke.
2639
2640         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
2641         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
2642         --platform will override the platform name and then we'll use it.
2643
2644         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
2645         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
2646         override it in the end.
2647
2648         * Scripts/old-run-webkit-tests:
2649         * Scripts/webkitpy/layout_tests/port/qt.py:
2650         (QtPort):
2651         (QtPort.determine_full_port_name):
2652         (QtPort.baseline_search_path):
2653         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2654         (QtPortTest):
2655         (QtPortTest._assert_search_path):
2656         (QtPortTest.test_baseline_search_path):
2657
2658 2012-03-08  Beth Dakin  <bdakin@apple.com>
2659
2660         https://bugs.webkit.org/show_bug.cgi?id=80463
2661         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
2662         -and corresponding-
2663         <rdar://problem/10970221>
2664
2665         Reviewed by Dan Bernstein.
2666
2667         New test!
2668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2669         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
2670         (TestWebKitAPI):
2671         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2672         (TestWebKitAPI::setPageLoaderClient):
2673         (TestWebKitAPI::TEST):
2674         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
2675         (TestWebKitAPI):
2676         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
2677         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
2678         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
2679         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
2680
2681 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2682
2683         [Qt] Prospective Windows build fix
2684
2685         Don't assume that windows-builds will always run inside a cmd.exe shell.
2686
2687         * qmake/mkspecs/features/default_pre.prf:
2688
2689 2012-03-08  Dan Bernstein  <mitz@apple.com>
2690
2691         <rdar://problem/10981173> Dashboard regions should not be in device space
2692
2693         Reviewed by John Sullivan.
2694
2695         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2696         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
2697         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
2698         (TestWebKitAPI):
2699         (TestWebKitAPI::TEST):
2700
2701 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
2702
2703         webkit-patch works oddly on local Git branches
2704         https://bugs.webkit.org/show_bug.cgi?id=76958
2705
2706         Reviewed by Ojan Vafai.
2707
2708         This change makes the '-g' flag to webkit-patch behave a
2709         little more consistently with git. The 'HEAD..' syntax
2710         is changed to 'HEAD....' (four dots), so as to not
2711         collide with the underlying git syntax. We also generalize
2712         the syntax to support any refname, so 'foo....' means
2713         diff against foo and include working copy changes.
2714
2715         This change also adds the 'UPSTREAM' shortcut to identify
2716         whatever the current upstream/tracking branch is; this is
2717         useful if you have multiple local branches stacked up.
2718
2719         * Scripts/webkitpy/common/checkout/scm/git.py:
2720         (Git._branch_from_ref):
2721         (Git):
2722         (Git._current_branch):
2723         (Git._upstream_branch):
2724         (Git.merge_base):
2725         (Git._commit_on_branch):
2726         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2727         (GitSVNTest._second_local_commit):
2728         (GitSVNTest._two_local_commits):
2729         (GitSVNTest.test_commit_with_message_git_commit_range):
2730         (GitSVNTest.test_upstream_branch):
2731         (GitSVNTest.test_create_patch_working_copy_only):
2732         (GitSVNTest.test_changed_files_local_plus_working_copy):
2733         (GitSVNTest.test_changed_files_working_copy_only):
2734         (GitSVNTest.test_changed_files_upstream):
2735         * Scripts/webkitpy/tool/steps/options.py:
2736         (Options):
2737
2738 2012-03-08  John Sullivan  <sullivan@apple.com>
2739
2740         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
2741
2742         Reviewed by Eric Carlson.
2743
2744         * Scripts/extract-localizable-strings:
2745         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
2746         with NSLocalized. Also improved an error message to include the troublesome token.
2747
2748 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2749
2750         Unreviewed, rolling out r110115.
2751         http://trac.webkit.org/changeset/110115
2752         https://bugs.webkit.org/show_bug.cgi?id=80581
2753
2754         broke test-webkitpy (Requested by philn-tp on #webkit).
2755
2756         * Scripts/old-run-webkit-tests:
2757         * Scripts/webkitpy/layout_tests/port/qt.py:
2758         (QtPort):
2759         (QtPort.determine_full_port_name):
2760         (QtPort.baseline_search_path):
2761
2762 2012-03-08  Kentaro Hara  <haraken@chromium.org>
2763
2764         Unreviewed. Added myself to watchlist.
2765
2766         * Scripts/webkitpy/common/config/watchlist:
2767
2768 2012-03-07  Jessie Berlin  <jberlin@apple.com>
2769
2770         Clean Windows build fails after r110033
2771         https://bugs.webkit.org/show_bug.cgi?id=80553
2772
2773         Rubber-stamped by Jon Honeycutt and Eric Seidel.
2774
2775         Add the new JavaScriptCore include directory to some more vsprops files.
2776
2777         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2778         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2779         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2780
2781 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
2782
2783         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
2784         https://bugs.webkit.org/show_bug.cgi?id=72489
2785
2786         Reviewed by Dirk Pranke.
2787
2788         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
2789         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
2790         --platform will override the platform name and then we'll use it.
2791
2792         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
2793         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
2794         override it in the end.
2795
2796         * Scripts/old-run-webkit-tests:
2797         * Scripts/webkitpy/layout_tests/port/qt.py:
2798         (QtPort):
2799         (QtPort.determine_full_port_name):
2800         (QtPort.baseline_search_path):
2801
2802 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
2803
2804         [Qt][WK2] MiniBrowser on desktop does not react to click events
2805         https://bugs.webkit.org/show_bug.cgi?id=80314
2806
2807         Reviewed by Kenneth Rohde Christiansen.
2808
2809         Do not enable touch mocking on desktop mode.
2810
2811         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2812         (MiniBrowserApplication::handleUserOptions):
2813
2814 2012-03-07  Ojan Vafai  <ojan@chromium.org>
2815
2816         Automatically move to the next test after rebaseline in the results view
2817         https://bugs.webkit.org/show_bug.cgi?id=80527
2818
2819         Reviewed by Dimitri Glazkov.
2820
2821         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2822         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2823
2824 2012-03-07  Ojan Vafai  <ojan@chromium.org>
2825
2826         garden-o-matic rebaseline is broken for ports that don't have a fallback port
2827         https://bugs.webkit.org/show_bug.cgi?id=80526
2828
2829         Reviewed by Adam Barth.
2830
2831         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
2832         since there is no "None" port.
2833
2834         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2835         (GardeningHTTPRequestHandler.rebaseline):
2836         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2837         (GardeningServerTest.test_rebaseline):
2838
2839 2012-03-07  James Robinson  <jamesr@chromium.org>
2840
2841         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
2842         https://bugs.webkit.org/show_bug.cgi?id=80521
2843
2844         Reviewed by Kenneth Russell.
2845
2846         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
2847         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
2848         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
2849
2850         Covered by platform/chromium/compositing/plugins/*
2851
2852         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2853         (TestWebPlugin::TestWebPlugin):
2854         (TestWebPlugin::initialize):
2855         (TestWebPlugin::updateGeometry):
2856         (TestWebPlugin::initScene):
2857         (TestWebPlugin::destroyScene):
2858         * DumpRenderTree/chromium/TestWebPlugin.h:
2859         (TestWebPlugin):
2860         * DumpRenderTree/chromium/WebViewHost.cpp:
2861         (WebViewHost::createPlugin):
2862
2863 2012-03-07  Philippe Normand  <pnormand@igalia.com>
2864
2865         [GTK] remove webkitpy dependency in run-gtk-tests
2866         https://bugs.webkit.org/show_bug.cgi?id=80500
2867
2868         Reviewed by Martin Robinson.
2869
2870         Replace Executive calls with bare subprocess calls.
2871
2872         * Scripts/run-gtk-tests:
2873         (TestRunner):
2874         (TestRunner._lookup_atspi2_binary):
2875         (TestRunner.run):
2876         (TestRunner.run.run_for_real):
2877
2878 2012-03-07  Philippe Normand  <pnormand@igalia.com>
2879
2880         Unreviewed, GTK build fix after r110059.
2881
2882         * Scripts/run-gtk-tests:
2883         (TestRunner._check_if_tests_have_timed_out):
2884         (TestRunner.run.run_tests):
2885         (TestRunner):
2886
2887 2012-03-07  Philippe Normand  <pnormand@igalia.com>
2888
2889         [GTK] race condition in run-gtk-tests
2890         https://bugs.webkit.org/show_bug.cgi?id=80495
2891
2892         Reviewed by Martin Robinson.
2893
2894         Refactored the script to wait the a11y dbus service becomes
2895         available before starting the tests.
2896
2897         * Scripts/run-gtk-tests:
2898         (TestRunner._lookup_atspi2_binary):
2899         (TestRunner):
2900         (TestRunner._wait_dbus_service_and_run):
2901         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
2902         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
2903         (TestRunner.run):
2904         (TestRunner.run.bailout):
2905         (TestRunner.run.run_for_real):
2906
2907 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
2908
2909         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
2910         https://bugs.webkit.org/show_bug.cgi?id=80425
2911
2912         Reviewed by Simon Hausmann.
2913
2914         Set startScreenPos in mock touch point
2915
2916         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2917         (MiniBrowserApplication::notify):
2918         * MiniBrowser/qt/MiniBrowserApplication.h:
2919         (MiniBrowserApplication):
2920
2921 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
2922
2923         [Qt] Windows build fix.
2924
2925         Reviewed by Tor Arne Vestbø.
2926
2927         Pass the -j parameter only to "make", not "nmake".
2928
2929         * Scripts/webkitdirs.pm:
2930         (buildQMakeProjects):
2931
2932 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
2933
2934         [Qt] Fix compilation without QtQuick1
2935         https://bugs.webkit.org/show_bug.cgi?id=80503
2936
2937         Reviewed by Tor Arne Vestbø.
2938
2939         Introduce HAVE_QQUICK1 as feature and added haveQtModule
2940         as convenience function.
2941
2942         * qmake/mkspecs/features/features.prf:
2943         * qmake/mkspecs/features/functions.prf:
2944
2945 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
2946
2947         [Qt] Add qmake config tests for JPEG and PNG library
2948         https://bugs.webkit.org/show_bug.cgi?id=80398
2949
2950         Add JPEG and PNG library tests to config.tests and
2951         add error() abort to WebCore.pri if tests don't work.
2952
2953         Reviewed by Tor Arne Vestbø.
2954
2955         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
2956         (main):
2957         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
2958         * qmake/config.tests/libpng/libpng.cpp: Added.
2959         (main):
2960         * qmake/config.tests/libpng/libpng.pro: Added.
2961         * qmake/sync.profile:
2962
2963 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
2964
2965         [EFL] Build warning: Fix warn_unused_result warnings.
2966         https://bugs.webkit.org/show_bug.cgi?id=79194
2967
2968         Reviewed by Filip Pizlo.
2969
2970         Fixed build warning which is getting generated when not using return
2971         value of a fuction, especially declared with warn_unused_result
2972         attribute.
2973
2974         * DumpRenderTree/efl/ImageDiff.cpp:
2975         (printImage):
2976
2977 2012-03-07  Kangil Han  <kangil.han@samsung.com>
2978
2979         [DRT] Remove PlainTextController implementations.
2980         https://bugs.webkit.org/show_bug.cgi?id=79959
2981
2982         Reviewed by Hajime Morita.
2983
2984         PlainTextController usages in existing tests have been
2985         replaced by internals API by bug 78570.
2986         So this patch will remove PlainTextController implementations
2987         to avoid further usage in new tests.
2988
2989         * DumpRenderTree/DumpRenderTree.gypi:
2990         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2991         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
2992         * DumpRenderTree/chromium/PlainTextController.h: Removed.
2993         * DumpRenderTree/chromium/TestShell.cpp:
2994         (TestShell::TestShell):
2995         (TestShell::bindJSObjectsToWindow):
2996         * DumpRenderTree/chromium/TestShell.h:
2997         (TestShell):
2998         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2999         (webViewWindowObjectCleared):
3000         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
3001         * DumpRenderTree/gtk/PlainTextController.h: Removed.
3002         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3003         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3004         * DumpRenderTree/mac/PlainTextController.h: Removed.
3005         * DumpRenderTree/mac/PlainTextController.mm: Removed.
3006         * DumpRenderTree/qt/DumpRenderTree.pro:
3007         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3008         (WebCore::DumpRenderTree::DumpRenderTree):
3009         (WebCore::DumpRenderTree::initJSObjects):
3010         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3011         (DumpRenderTree):
3012         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
3013         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
3014         * GNUmakefile.am:
3015
3016 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3017
3018         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
3019         https://bugs.webkit.org/show_bug.cgi?id=80137
3020
3021         Reviewed by Eric Seidel.
3022
3023         Adds implementation LayoutTestController's setPopupBlockingEnabled.
3024         To pass popup-blocking-click-in-iframe.html EventSender should not
3025         repeat click events in idler's function. EventSender allows to
3026         asynchronously send click event through ecore_idler_add.
3027         This event will be called repeatedly as long as it return true.
3028         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
3029
3030         * DumpRenderTree/efl/EventSender.cpp:
3031         (sendMouseEvent): Changed return value from bool to void because it always returns true.
3032         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
3033         (mouseDownCallback): Remove unnecessary checking of return value.
3034         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3035         (LayoutTestController::setPopupBlockingEnabled):
3036
3037 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3038
3039         rebaseline_chromium_webkit_tests is obsolete and should be removed
3040         https://bugs.webkit.org/show_bug.cgi?id=80347
3041
3042         Reviewed by Tony Chang.
3043
3044         * Scripts/rebaseline-chromium-webkit-tests: Removed.
3045         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
3046         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
3047
3048 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3049
3050         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
3051         https://bugs.webkit.org/show_bug.cgi?id=80468
3052
3053         Unreviewed, build fix.
3054
3055         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
3056
3057         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3058         (Lighttpd._prepare_config):
3059
3060 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3061
3062         remove chromium_gpu ports
3063         https://bugs.webkit.org/show_bug.cgi?id=80345
3064
3065         Reviewed by Ojan Vafai.
3066
3067         This change leaves in the 'graphics_type' distinction in the
3068         test_expectations; removing that will require more updates and a
3069         pass over test_expectations.txt, so I'm separating that out.
3070
3071         * Scripts/webkitpy/layout_tests/port/builders.py:
3072         * Scripts/webkitpy/layout_tests/port/chromium.py:
3073         (ChromiumPort):
3074         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
3075         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
3076         * Scripts/webkitpy/layout_tests/port/factory.py:
3077         (PortFactory):
3078         (PortFactory.get):
3079         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3080         (FactoryTest.test_qt):
3081         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3082         (TestRebaseline.test_rebaseline_expectations):
3083
3084 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
3085
3086         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
3087         https://bugs.webkit.org/show_bug.cgi?id=80282
3088
3089         Reviewed by Antonio Gomes.
3090
3091         Remove transitive library dependencies; they are especially
3092         dangerous when one ends up linking against WTF, JSC and then WTF
3093         again, since some symbols will not be defined.
3094
3095         Passing --no-copy-dt-needed-entries and --as-needed to the linker
3096         (which some recent Linux distros do by default) makes the issue
3097         even more evident.
3098
3099         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
3100         as the other libraries have the needed symbols. Explicitly link
3101         against fontconfig.
3102
3103 2012-03-06  Dean Jackson  <dino@apple.com>
3104
3105         filter-build-webkit needs more filters
3106         https://bugs.webkit.org/show_bug.cgi?id=80440
3107
3108         Reviewed by Joseph Pecoraro.
3109
3110         Added as many missing filters as I could find for Apple
3111         builds. Plus a few minor style updates.
3112
3113         * Scripts/filter-build-webkit:
3114         (printLine):
3115
3116 2012-03-06  Ojan Vafai  <ojan@chromium.org>
3117
3118         Copying old baselines throws an error if the new directory doesn't exist
3119         https://bugs.webkit.org/show_bug.cgi?id=80443
3120
3121         Reviewed by Adam Barth.
3122
3123         Existing tests cover the new code with the fix to filesystem_mock.
3124
3125         * Scripts/webkitpy/common/system/filesystem_mock.py:
3126         (MockFileSystem.copyfile):
3127         Fix the mock to better match python's copyfile semantics.
3128
3129         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3130         (Rebaseliner._create_html_baseline_files):
3131         * Scripts/webkitpy/tool/commands/rebaseline.py:
3132         (RebaselineTest._copy_existing_baseline):
3133
3134 2012-03-05  Ojan Vafai  <ojan@chromium.org>
3135
3136         Add a mechanism to rebaseline new ports
3137         https://bugs.webkit.org/show_bug.cgi?id=80355
3138
3139         Reviewed by Adam Barth.
3140
3141         For a test that's only failing on a new port, we want
3142         to first copy the existing result into the location for the
3143         port it's replacing in order to not break that port.
3144
3145         For example, bringing up the chromium-lion port, if we just
3146         stick the results in the chromium-mac directory, the snow leopard
3147         will start failing. Instead, we first copy the existing result
3148         to the chromium-mac-snowleopard directory.
3149
3150         * Scripts/webkitpy/layout_tests/port/builders.py:
3151         (builder_path_for_port_name):
3152         (fallback_port_name_for_new_port):
3153         * Scripts/webkitpy/tool/commands/rebaseline.py:
3154         (RebaselineTest):
3155         (RebaselineTest._copy_existing_baseline):
3156         (RebaselineTest._rebaseline_test):
3157         (RebaselineTest.execute):
3158         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3159         (TestRebaseline.test_rebaseline_test):
3160         (TestRebaseline):
3161         (TestRebaseline.test_rebaseline_and_copy_test):
3162         (test_rebaseline_and_copy_test_no_existing_result):
3163         (test_rebaseline_and_copy_test_with_lion_result):
3164         (test_rebaseline_and_copy_no_overwrite_test):
3165         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3166         (GardeningHTTPRequestHandler.rebaseline):
3167         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3168         (GardeningServerTest.test_rebaseline):
3169         (GardeningServerTest):
3170         (GardeningServerTest.test_rebaseline_new_port):
3171
3172 2012-03-06  Beth Dakin  <bdakin@apple.com>
3173
3174         https://bugs.webkit.org/show_bug.cgi?id=80351
3175         InlineTextBox is using the wrong origin when calling 
3176         addRelevantRepaintedObject
3177         -and corresponding-
3178         <rdar://problem/10970221>
3179
3180         Reviewed by Sam Weinig.
3181
3182         This test has actually been broken since revision 109273. This change makes 
3183         the test pass again, and it makes it specifically exercise the fix for this 
3184         bug.
3185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3186         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
3187         (TestWebKitAPI::TEST):
3188
3189         Adjust comments in the other tests to reflect the API changes from 109273.
3190         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
3191         (TestWebKitAPI::TEST):
3192         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
3193         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
3194         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
3195         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
3196         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
3197         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
3198         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
3199
3200 2012-03-06  Hans Wennborg  <hans@chromium.org>
3201
3202         Speech JavaScript API: add SpeechRecognitionError
3203         https://bugs.webkit.org/show_bug.cgi?id=80410
3204
3205         Chromium: enable the runtime flag for scripted speech so we can run
3206         the layout tests for it.
3207
3208         Reviewed by Adam Barth.
3209
3210         * DumpRenderTree/chromium/TestShell.cpp:
3211         (TestShell::TestShell):
3212
3213 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
3214
3215         Enable universal newlines in chromium android layout test runner
3216         https://bugs.webkit.org/show_bug.cgi?id=80418
3217
3218         Reviewed by Adam Barth.
3219
3220         The Chromium Android layout test runner uses the 'adb' program to
3221         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
3222         output lines from the test runner, while the test expectation files are
3223         written with LF ('\n') delimiters. This causes the results to have
3224         spurious whitespace differences, making them more difficult to
3225         interpret.
3226
3227         The fix is to enable universal newlines for the DumpRenderTree pipe,
3228         causing the output to only contain LF newlines like on other platforms.
3229
3230         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3231         (ChromiumAndroidDriver._start):
3232
3233 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3234
3235         [Qt] Revert r109900, it was completly busted
3236
3237         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
3238
3239         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
3240         of manual define checks.
3241
3242         Reviewed by Ossy.
3243
3244         * DumpRenderTree/qt/DumpRenderTree.pro:
3245         * QtTestBrowser/QtTestBrowser.pro:
3246         * WebKitTestRunner/InjectedBundle/Target.pri:
3247         * qmake/mkspecs/features/features.prf:
3248
3249 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3250
3251         [Qt] Use config test to determine if the compiler supports -MD
3252
3253         We used to assume that unix systems building against Qt5 would have
3254         a compiler that supported -MD. Although this was usually the case,
3255         we failed to take into account broken tools for distributed builds
3256         (e.g. teambuilder or icecream) which would end up producing .d files
3257         in the root of the build dir instead of along-side the object file.
3258
3259         Now that we use a config-test to determine the support, we'll capture
3260         those cases, unless distributed builds are enabled after the initial
3261         build-webkit run.
3262
3263         Reviewed by Csaba Osztrogonác.
3264
3265         * Tools.pro:
3266         * qmake/config.tests/gccdepends/empty.cpp: Added.
3267         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
3268         * qmake/mkspecs/features/default_pre.prf:
3269         * qmake/mkspecs/features/features.prf:
3270         * qmake/mkspecs/features/unix/default_pre.prf:
3271         * qmake/sync.profile:
3272
3273 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3274
3275         REGRESSION(r109294): It broke the unittest of master.cfg
3276         https://bugs.webkit.org/show_bug.cgi?id=80253
3277
3278         Reviewed by Tor Arne Vestbø.
3279
3280         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
3281         (BuildBotConfigLoader._create_mock_passwords_dict):
3282         (BuildBotConfigLoader._mock_open):
3283         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
3284         (BuildBotConfigLoader.load_config):
3285
3286 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3287
3288         Qt API test buildstep throws exception after buildmaster update
3289         https://bugs.webkit.org/show_bug.cgi?id=80249
3290
3291         This patch based on Peter Gal's work.
3292
3293         Reviewed by Csaba Osztrogonác.
3294
3295         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3296         (RunQtAPITests):
3297         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
3298
3299 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3300
3301         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
3302
3303         Reviewed by Simon Hausmann.
3304         Reviewed by Ossy.
3305
3306         * DumpRenderTree/qt/DumpRenderTree.pro:
3307         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
3308         (WebKit::initializeTestFonts):
3309         * QtTestBrowser/QtTestBrowser.pro:
3310         * WebKitTestRunner/InjectedBundle/Target.pri:
3311         * qmake/mkspecs/features/features.prf:
3312
3313 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3314
3315         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
3316
3317         Reviewed by Ossy.
3318
3319         * qmake/mkspecs/features/default_post.prf:
3320
3321 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3322
3323         [Qt] Make sure clean builds are followed by make qmake && make if needed
3324
3325         On non-GNUmake systems we have to run make qmake so that the generated
3326         sources are generated before we run qmake on the target pro files. This
3327         is achieved by using the 'incremental' target.
3328
3329         Reviewed by Ossy.
3330
3331         * Scripts/webkitdirs.pm:
3332         (buildQMakeProjects):
3333
3334 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
3335
3336         DumpRenderTree should support preciseTime()
3337         https://bugs.webkit.org/show_bug.cgi?id=80397
3338
3339         Reviewed by Gavin Barraclough.
3340
3341         * DumpRenderTree/LayoutTestController.cpp:
3342         (preciseTimeCallback):
3343         (LayoutTestController::staticFunctions):
3344
3345 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3346
3347         Unreviewed, rolling out r109887.
3348         http://trac.webkit.org/changeset/109887
3349         https://bugs.webkit.org/show_bug.cgi?id=80402
3350
3351         It broke the build (Requested by Ossy on #webkit).
3352
3353         * DumpRenderTree/qt/DumpRenderTree.pro:
3354         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
3355         (WebKit::initializeTestFonts):
3356         * QtTestBrowser/QtTestBrowser.pro:
3357         * WebKitTestRunner/InjectedBundle/Target.pri:
3358         * qmake/mkspecs/features/features.prf:
3359
3360 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3361
3362         Unreviewed, rolling out r109837.
3363         http://trac.webkit.org/changeset/109837
3364         https://bugs.webkit.org/show_bug.cgi?id=80399
3365
3366         breaks Mac Productions builds, too late to try and fix it
3367         tonight (Requested by eseidel on #webkit).
3368
3369         * Scripts/build-webkit:
3370
3371 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3372
3373         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
3374
3375         Reviewed by Simon Hausmann.
3376
3377         * DumpRenderTree/qt/DumpRenderTree.pro:
3378         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
3379         (WebKit::initializeTestFonts):
3380         * QtTestBrowser/QtTestBrowser.pro:
3381         * WebKitTestRunner/InjectedBundle/Target.pri:
3382         * qmake/mkspecs/features/features.prf:
3383
3384 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3385
3386         [Qt] Create EWS to build WebKit2
3387         https://bugs.webkit.org/show_bug.cgi?id=80277
3388
3389         Reviewed by Csaba Osztrogonác.
3390
3391         * QueueStatusServer/model/queues.py:
3392         (Queue):
3393         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3394         (QtWK2EWS):
3395         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3396         (EarlyWarningSytemTest.test_builder_ewses):
3397
3398 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3399
3400         Unreviewed, rolling out r109733.
3401         http://trac.webkit.org/changeset/109733
3402         https://bugs.webkit.org/show_bug.cgi?id=80378
3403
3404         It broke Qt5 build system (Requested by Ossy on #webkit).
3405
3406         * Tools.pro:
3407         * qmake/config.tests/gccdepends/empty.cpp: Removed.
3408         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
3409         * qmake/mkspecs/features/default_pre.prf:
3410         * qmake/mkspecs/features/features.prf:
3411         * qmake/mkspecs/features/unix/default_pre.prf:
3412         * qmake/sync.profile:
3413
3414 2012-03-05  Eric Seidel  <eric@webkit.org>
3415
3416         Update JavaScriptCore files to use fully-qualified WTF include path
3417         https://bugs.webkit.org/show_bug.cgi?id=79960
3418
3419         Reviewed by Adam Barth.
3420
3421         Build WTF/WTF.xcodeproj by default on Mac.
3422
3423         * Scripts/build-webkit:
3424
3425 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
3426
3427         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
3428         https://bugs.webkit.org/show_bug.cgi?id=69590
3429
3430         Reviewed by Ryosuke Niwa.
3431
3432         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
3433         to skip the 'optimize-expectations' step.
3434
3435         * Scripts/webkitpy/tool/commands/rebaseline.py:
3436         (RebaselineExpectations.__init__):
3437         (RebaselineExpectations.execute):
3438         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3439
3440 2012-03-05  Kent Tamura  <tkent@chromium.org>
3441
3442         [Chromium] Add new popup type: PagePopup
3443         https://bugs.webkit.org/show_bug.cgi?id=80106
3444
3445         Reviewed by Darin Fisher.
3446
3447         * DumpRenderTree/chromium/WebViewHost.cpp:
3448         (WebViewHost::createPopupMenu):
3449
3450 2012-03-05  Jessie Berlin  <jberlin@apple.com>
3451
3452         Add myself as a reviewer.
3453
3454         * Scripts/webkitpy/common/config/committers.py:
3455         Also, add my IRC nick so it is easier to find and yell at me.
3456
3457 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
3458
3459         Correctly compute the positions of GestureScroll* events on
3460         Chromium.
3461         https://bugs.webkit.org/show_bug.cgi?id=80075
3462
3463         Reviewed by Adam Barth.
3464
3465         * DumpRenderTree/chromium/EventSender.cpp:
3466         (EventSender::reset):
3467         (EventSender::gestureEvent):
3468         * DumpRenderTree/chromium/EventSender.h:
3469         (EventSender):
3470
3471 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
3472
3473         flakiness dashboard doesn't display baselines for virtual tests correctly
3474         https://bugs.webkit.org/show_bug.cgi?id=80341
3475
3476         Reviewed by Ojan Vafai.
3477
3478         If the test is part of a virtual test suite, we need to look for
3479         baselines in the underlying fallback path for the actual test
3480         being run, as well as baselines for the virtual version.
3481
3482         This patch adds code to handle both branches and also pulls the
3483         mapping of the test suites up into a constant.
3484
3485         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3486         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3487         (testLookupVirtualTestSuite):
3488         (testBaseTest):
3489
3490 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3491
3492         Unreviewed, rolling out r109760.
3493         http://trac.webkit.org/changeset/109760
3494         https://bugs.webkit.org/show_bug.cgi?id=80320
3495
3496         Caused many GTK+ tests to crash (Requested by mrobinson on
3497         #webkit).
3498
3499         * gtk/jhbuild.modules:
3500
3501 2012-03-05  Charlie Reis  <creis@chromium.org>
3502
3503         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
3504         https://bugs.webkit.org/show_bug.cgi?id=80057
3505
3506         Reviewed by Darin Fisher.
3507
3508         * DumpRenderTree/chromium/WebViewHost.cpp:
3509         (WebViewHost::createView):
3510         * DumpRenderTree/chromium/WebViewHost.h:
3511         (WebViewHost):
3512
3513 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
3514
3515         [soup] Crash while loading http://www.jusco.cn
3516         https://bugs.webkit.org/show_bug.cgi?id=68238
3517
3518         Reviewed by Philippe Normand.
3519
3520         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
3521         in the jhbuild file.
3522
3523 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3524
3525         Unreviewed, rolling out r109748.
3526         http://trac.webkit.org/changeset/109748
3527         https://bugs.webkit.org/show_bug.cgi?id=80296
3528
3529         Made some tests crash, will fix and recommit (Requested by
3530         noamr on #webkit).
3531
3532         * MiniBrowser/qt/main.cpp:
3533         (main):
3534
3535 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
3536
3537         [GTK] plugins/netscape-plugin-page-cache-works.html fails
3538         https://bugs.webkit.org/show_bug.cgi?id=74409
3539
3540         Reviewed by Martin Robinson.
3541
3542         Add support for overriding the page-cache-for-plugins preference
3543         through DumpRenderTreeSupport.
3544
3545         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3546         (booleanFromValue): A helper function to convert a string to boolean.
3547         (LayoutTestController::overridePreference):
3548
3549 2012-03-05  Rob Buis  <rbuis@rim.com>
3550
3551         [BlackBerry] Update Tools/DumpRenderTree
3552         https://bugs.webkit.org/show_bug.cgi?id=80287
3553
3554         Reviewed by Antonio Gomes.
3555
3556         Update so we are sure we can build our implementation of DRT.
3557
3558         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
3559         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
3560         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
3561         (AccessibilityController::addNotificationListener): add missing hook.
3562         (AccessibilityController::removeNotificationListener): add missing hook.
3563         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3564         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
3565         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3566         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
3567         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
3568
3569 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
3570
3571         [Qt] [WK2] Support threaded renderer in WK2
3572         https://bugs.webkit.org/show_bug.cgi?id=76661
3573
3574         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
3575
3576         Reviewed by Kenneth Rohde Christiansen.
3577
3578         * MiniBrowser/qt/main.cpp:
3579         (main):
3580
3581 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
3582
3583         Unreviewed. Add myself to committer list.
3584
3585         * Scripts/webkitpy/common/config/committers.py:
3586
3587 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3588
3589         [Qt] Use config test to determine if the compiler supports -MD
3590
3591         We used to assume that unix systems building against Qt5 would have
3592         a compiler that supported -MD. Although this was usually the case,
3593         we failed to take into account broken tools for distributed builds
3594         (e.g. teambuilder or icecream) which would end up producing .d files
3595         in the root of the build dir instead of along-side the object file.
3596
3597         Now that we use a config-test to determine the support, we'll capture
3598         those cases, unless distributed builds are enabled after the initial
3599         build-webkit run.
3600
3601         Reviewed by Csaba Osztrogonác.
3602
3603         * Tools.pro:
3604         * qmake/config.tests/gccdepends/empty.cpp: Added.
3605         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
3606         * qmake/mkspecs/features/default_pre.prf:
3607         * qmake/mkspecs/features/features.prf:
3608         * qmake/mkspecs/features/unix/default_pre.prf:
3609         * qmake/sync.profile:
3610
3611 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
3612
3613         Qt API test buildstep throws exception after buildmaster update
3614         https://bugs.webkit.org/show_bug.cgi?id=80249
3615
3616         Reviewed by Zoltan Herczeg.
3617
3618         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
3619         (BuildAndTestFactory.__init__):
3620
3621 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
3622
3623         [GTK] Unit tests are noisy when run under jhbuild
3624         https://bugs.webkit.org/show_bug.cgi?id=80241
3625
3626         Reviewed by Philippe Normand.
3627
3628         Force the 'memory' backend in GSettings so that each unit
3629         test doesn't produce a warning when it's forced to fall back
3630         to the 'memory' backend.
3631
3632         * Scripts/run-gtk-tests:
3633         (TestRunner.run): Force the 'memory' backend.
3634
3635 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
3636
3637         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
3638         https://bugs.webkit.org/show_bug.cgi?id=80235
3639
3640         Reviewed by Philippe Normand.
3641
3642         * Scripts/run-gtk-tests:
3643         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
3644         inspector resources path determination is shared by all tests.
3645
3646 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
3647
3648         [GTK] REGRESSION: r108278 broke some tests that expect focus
3649         https://bugs.webkit.org/show_bug.cgi?id=79084
3650
3651         Reviewed by Philippe Normand.
3652
3653         Grab focus when dumping test results and also when sending
3654         events. During the course of testing, the WebView may lose
3655         focus and this seems to snap it back when tests demand it.
3656
3657         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3658         (dump): Grab focus.
3659         * DumpRenderTree/gtk/EventSender.cpp:
3660         (dispatchEvent): Ditto.
3661
3662 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
3663
3664         Unreviewed, Add myself to committer list.
3665         https://bugs.webkit.org/show_bug.cgi?id=80232
3666
3667         * Scripts/webkitpy/common/config/committers.py:
3668
3669 2012-03-04  Anders Carlsson  <andersca@apple.com>
3670
3671         Newer versions of clang fail to compile WebKit.
3672
3673         Fix build.
3674
3675         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3676         (descriptionOfValue):
3677         (AccessibilityUIElement::rowIndexRange):
3678         (AccessibilityUIElement::columnIndexRange):
3679         (AccessibilityUIElement::selectedTextRange):
3680         * DumpRenderTree/mac/EditingDelegate.mm:
3681         (-[DOMRange dump]):
3682         * DumpRenderTree/mac/PolicyDelegate.mm:
3683         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
3684         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3685         (-[NSError _drt_descriptionSuitableForTestResult]):
3686         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3687         (WTR::descriptionOfValue):
3688         (WTR::AccessibilityUIElement::rowIndexRange):
3689         (WTR::AccessibilityUIElement::columnIndexRange):
3690         (WTR::AccessibilityUIElement::selectedTextRange):