cd11b7bfd149266307f8d2b4f7288fefc830b77f
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-18  Patrick Gansterer  <paroga@webkit.org>
2
3         Reviewed by Adam Roben.
4
5         [WIN] Use WCHAR instead of TCHAR
6         https://bugs.webkit.org/show_bug.cgi?id=58755
7
8         We always use the UNICODE versions of windows functions, so
9         the usage of TCHAR makes no sense and mixing them is bad style.
10
11         * WinLauncher/PrintWebUIDelegate.cpp:
12           Also fix various style issues (including indentation and removal of ugly C-casts).
13         * WinLauncher/WinLauncher.cpp:
14
15 2011-04-18  Dominic Cooney  <dominicc@chromium.org>
16
17         Reviewed by Andreas Kling.
18
19         Add layoutTestController.shadowRoot to Qt DRT.
20         https://bugs.webkit.org/show_bug.cgi?id=58759
21
22         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
23         (LayoutTestController::shadowRoot): Added.
24         * DumpRenderTree/qt/LayoutTestControllerQt.h:
25
26 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
27
28         Unreviewed, rolling out r84111.
29         http://trac.webkit.org/changeset/84111
30         https://bugs.webkit.org/show_bug.cgi?id=58771
31
32         Chromium linux layout tests are broken. (Requested by loislo2
33         on #webkit).
34
35         * Scripts/webkitpy/layout_tests/port/chromium.py:
36         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
37         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
38
39 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
40
41         Unreviewed, rolling out r84112.
42         http://trac.webkit.org/changeset/84112
43         https://bugs.webkit.org/show_bug.cgi?id=58770
44
45         Chromium linux layout tests are broken. (Requested by loislo2
46         on #webkit).
47
48         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
49         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
50
51 2011-04-17  Daniel Bates  <dbates@webkit.org>
52
53         Reviewed by Eric Seidel and Adam Barth.
54
55         webkit-patch land hangs if svn prompts for credentials
56         https://bugs.webkit.org/show_bug.cgi?id=31500
57
58         Prompt for username and password when using git-svn and there aren't cached SVN credentials.
59
60         * Scripts/webkitpy/common/checkout/scm.py:
61           - Added mixin class SVNRepository and made both class SVN and Git inherit from it.
62           - Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value
63             for argument realm; modified call sites as needed.
64           - Modified AuthenticationError constructor to take optional prompt_for_password argument.
65           - Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument.
66           - Modified Git._commit_on_branch() to take optional username and password argument.
67           - Modified Git.push_local_commits_to_server() to take optional username and password
68             argument and to call has_authorization_for_realm().
69         * Scripts/webkitpy/common/checkout/scm_unittest.py:
70           - Modified SVNTest.test_commit_without_authorization() to take dummy realm argument.
71           - Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to
72             SVN.has_authorization_for_realm().
73         * Scripts/webkitpy/common/net/credentials.py:
74           - Modified Credentials.read_credentials() to call User.prompt_password() instead
75             of using getpass.getpass() directly.
76         * Scripts/webkitpy/common/system/user.py:
77           - Added User.prompt_password().
78         * Scripts/webkitpy/tool/steps/commit.py:
79           - Modified Commit.run() to prompt for a password if needed.
80
81 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
82
83         Reviewed by Ojan Vafai.
84
85         new-run-webkit-tests: save stderr into the layout-test-results dir
86         https://bugs.webkit.org/show_bug.cgi?id=58690
87
88         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
89         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
90
91 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
92
93         Reviewed by Ojan Vafai.
94
95         new-run-webkit-tests: read stderr from chromium DRT separately
96         https://bugs.webkit.org/show_bug.cgi?id=58708
97
98         * Scripts/webkitpy/layout_tests/port/chromium.py:
99         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
100         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
101
102 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
103
104         Reviewed by Adam Barth.
105
106         Rename PLATFORM(CA) to USE(CA)
107         https://bugs.webkit.org/show_bug.cgi?id=58742
108
109         * DumpRenderTree/mac/DumpRenderTree.mm:
110         (resetDefaultsToConsistentValues):
111
112 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
113
114         Reviewed by Adam Barth.
115
116         Rename PLATFORM(CG) to USE(CG)
117         https://bugs.webkit.org/show_bug.cgi?id=58729
118
119         * DumpRenderTree/PixelDumpSupport.cpp:
120         * DumpRenderTree/chromium/WebViewHost.cpp:
121         (WebViewHost::paintRect):
122         * DumpRenderTree/config.h:
123         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
124         (createBitmapContextFromWebView):
125         * TestWebKitAPI/PlatformWebView.h:
126         * WebKitTestRunner/config.h:
127         * WebKitTestRunner/win/TestInvocationWin.cpp:
128
129 2011-04-16  Patrick Gansterer  <paroga@webkit.org>
130
131         Reviewed by Eric Seidel.
132
133         Rename PLATFORM(CAIRO) to USE(CAIRO)
134         https://bugs.webkit.org/show_bug.cgi?id=55192
135
136         * DumpRenderTree/PixelDumpSupport.cpp:
137         * DumpRenderTree/config.h:
138         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
139         (createBitmapContextFromWebView):
140         * WebKitTestRunner/config.h:
141
142 2011-04-16  Ojan Vafai  <ojan@chromium.org>
143
144         Reviewed by Eric Seidel.
145
146         show diffs+test inline in the results page
147         https://bugs.webkit.org/show_bug.cgi?id=58723
148         
149         Put each row in it's own tbody and sort based on tbodies. That way
150         we can append the results to the tbody inline as another table row.
151
152         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
153
154 2011-04-16  Ojan Vafai  <ojan@chromium.org>
155
156         Reviewed by Eric Seidel.
157
158         handle new tests in the new results html file
159         https://bugs.webkit.org/show_bug.cgi?id=58715
160
161         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
162
163 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
164
165         Reviewed by Ojan Vafai.
166
167         old-run-webkit-tests: save the list of tests actually run to a file
168         https://bugs.webkit.org/show_bug.cgi?id=58692
169
170         * Scripts/old-run-webkit-tests:
171
172 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
173
174         Reviewed by Ojan Vafai.
175
176         fix MockFileSystem.abspath() on windows
177         https://bugs.webkit.org/show_bug.cgi?id=58713
178
179         The existing code was borked on Windows if a path was passed
180         in using a drive letter (e.g., "d:\foo.txt"), and would go
181         into an infinite recursive loop. While win paths shouldn't
182         normally be passed into the mock filesystem, this just
183         bulletproofs things a bit (note that "/foo.txt" is considered
184         an absolute path on windows python as well.
185
186         * Scripts/webkitpy/common/system/filesystem_mock.py:
187
188 2011-04-15  Ojan Vafai  <ojan@chromium.org>
189
190         Reviewed by Eric Seidel.
191
192         show stderr files and httpd log files
193         https://bugs.webkit.org/show_bug.cgi?id=58714
194
195         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
196         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
197
198 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
199
200         Reviewed by James Robinson.
201
202         Add a flag to guard Page Visibility API changes.
203         https://bugs.webkit.org/show_bug.cgi?id=58464
204
205         * Scripts/build-webkit:
206
207 2011-04-15  Chang Shu  <cshu@webkit.org>
208
209         Reviewed by Alexey Proskuryakov.
210
211         When a message with url embedded is added to console, the "file:" scheme
212         and path should be stripped.
213         https://bugs.webkit.org/show_bug.cgi?id=58665
214
215         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
216         (WTR::lastFileURLPathComponent):
217         (WTR::InjectedBundlePage::willAddMessageToConsole):
218
219 2011-04-15  Jeff Miller  <jeffm@apple.com>
220
221         Reviewed by Sam Weinig.
222
223         Add takeFocus callback to WKPageUIClient
224         https://bugs.webkit.org/show_bug.cgi?id=58686
225
226         Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.
227
228         * MiniBrowser/mac/BrowserWindowController.m:
229         (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
230         * MiniBrowser/win/BrowserView.cpp:
231         (BrowserView::create): Added empty takeFocus entry.
232         * WebKitTestRunner/TestController.cpp:
233         (WTR::TestController::createOtherPage): Added empty takeFocus entry.
234         (WTR::TestController::initialize): Added empty takeFocus entry.
235
236 2011-04-15  Ojan Vafai  <ojan@chromium.org>
237
238         Reviewed by Eric Seidel.
239
240         only show pretty-diff/wdiff if they were generated
241         https://bugs.webkit.org/show_bug.cgi?id=58682
242
243         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
244         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
245         * Scripts/webkitpy/layout_tests/port/base.py:
246
247 2011-04-15  Andreas Kling  <kling@webkit.org>
248
249         Reviewed by Antonio Gomes.
250
251         [Qt] DRT: Default custom policy delegate decision should be Ignore.
252
253         If layoutTestController.setCustomPolicyDelegate() is called with only
254         one argument, the second ("permissive") should default to false.
255
256         * DumpRenderTree/qt/LayoutTestControllerQt.h:
257
258 2011-04-15  Ojan Vafai  <ojan@chromium.org>
259
260         Reviewed by Eric Seidel.
261
262         fix path to layout test in new results file
263         https://bugs.webkit.org/show_bug.cgi?id=58618
264
265         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
266         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
267
268 2011-04-15  Ojan Vafai  <ojan@chromium.org>
269
270         Reviewed by Eric Seidel.
271
272         fix sorting in new results file
273         https://bugs.webkit.org/show_bug.cgi?id=58616
274
275         -Fix the custom sort to return -1, 0, 1 instead of true/false.
276         -Secondary sort by test name when sort values are equal.
277         -Sort by test name by default.
278
279         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
280
281 2011-04-15  Dmitry Lomov  <dslomov@google.com>
282
283         Reviewed by David Levin.
284
285         check-webkit-style shouldn't complain about not including a primary header file 
286         if none exists
287         https://bugs.webkit.org/show_bug.cgi?id=39514
288
289         * Scripts/webkitpy/style/checkers/cpp.py:
290         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
291
292 2011-04-15  Eric Seidel  <eric@webkit.org>
293
294         Reviewed by Mihai Parparita.
295
296         queues.webkit.org should display when a bot last rebooted
297         https://bugs.webkit.org/show_bug.cgi?id=58562
298
299         There is more repeated code here than I would like.  I fear
300         my django-fu isn't quite up to snuff.
301
302         * QueueStatusServer/handlers/queuestatus.py:
303         * QueueStatusServer/templates/queuestatus.html:
304
305 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
306
307         Reviewed by Adam Barth.
308
309         Remove dependency on chromium skia::PlatformCanvas
310         https://bugs.webkit.org/show_bug.cgi?id=57563
311         
312         Fixed compile error on Mac when using Core Graphics.
313
314         * DumpRenderTree/chromium/WebViewHost.cpp:
315         (WebViewHost::paintRect):
316
317 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
318
319         Reviewed by James Robinson.
320
321         Remove dependency on chromium skia::PlatformCanvas
322         https://bugs.webkit.org/show_bug.cgi?id=57563
323
324         * DumpRenderTree/chromium/TestShell.cpp:
325         (makeCanvasOpaque):
326         (TestShell::dumpImage):
327         * DumpRenderTree/chromium/TestShell.h:
328         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
329         (WebThemeControlDRTWin::WebThemeControlDRTWin):
330         (WebThemeControlDRTWin::draw):
331         (WebThemeControlDRTWin::drawTextField):
332         (WebThemeControlDRTWin::drawProgressBar):
333         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
334         * DumpRenderTree/chromium/WebViewHost.cpp:
335         (WebViewHost::canvas):
336         * DumpRenderTree/chromium/WebViewHost.h:
337
338 2011-04-14  Keith Kyzivat  <keith.kyzivat@nokia.com>
339
340         Reviewed by Laszlo Gombos.
341
342         [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
343         https://bugs.webkit.org/show_bug.cgi?id=58007
344
345         Adds flag to start the test browsers maximized.
346         Symbian started maximized on QtTestBrowser - made MiniBrowser follow
347         suit.
348         Also fixes some ToggleFullScreen issues so that prior window state is
349         restored.
350
351         * MiniBrowser/qt/BrowserWindow.cpp:
352         (BrowserWindow::BrowserWindow):
353         (BrowserWindow::toggleFullScreenMode):
354         * MiniBrowser/qt/MiniBrowserApplication.cpp:
355         (MiniBrowserApplication::handleUserOptions):
356         * MiniBrowser/qt/MiniBrowserApplication.h:
357         (WindowOptions::WindowOptions):
358         * QtTestBrowser/launcherwindow.cpp:
359         (LauncherWindow::init):
360         (LauncherWindow::toggleFullScreenMode):
361         * QtTestBrowser/launcherwindow.h:
362         (WindowOptions::WindowOptions):
363         * QtTestBrowser/main.cpp:
364         (LauncherApplication::handleUserOptions):
365
366 2011-04-14  Ojan Vafai  <ojan@chromium.org>
367
368         Reviewed by Eric Seidel.
369
370         add checkbox to only show unexpected results to new results file
371         https://bugs.webkit.org/show_bug.cgi?id=58606
372
373         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
374
375 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
376
377         Reviewed by Martin Robinson.
378
379         [WinCairo] Implement ImageDiff Logic.
380         http://bugs.webkit.org/show_bug.cgi?id=58486
381
382         * DumpRenderTree/win/ImageDiffCairo.cpp: Added.
383         (strtof):
384         (readFromData):
385         (createImageFromStdin):
386         (releaseMallocBuffer):
387         (createDifferenceImage):
388         (imageHasAlpha):
389         (writeToData):
390         (main):
391         * DumpRenderTree/win/ImageDiff.vcproj: Updated for new
392           ImageDiffCairo.cpp (excluding from Apple builds).
393         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use
394           new ImageDiffWinCairoCommon.vsprops file.
395         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use
396           new ImageDiffWinCairoCommon.vsprops file.
397         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added.
398         * Scripts/old-run-webkit-tests: Make sure proper executable
399           is built and executed for WinCairo port.
400
401 2011-04-14  Ojan Vafai  <ojan@chromium.org>
402
403         Reviewed by Eric Seidel.
404
405         only show expected failure type for ports that use an expectations file
406         https://bugs.webkit.org/show_bug.cgi?id=58588
407
408         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
409         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
410
411 2011-04-14  Eric Seidel  <eric@webkit.org>
412
413         Reviewed by Adam Barth.
414
415         commit-queue fails to catch IOError when results.html is missing
416         https://bugs.webkit.org/show_bug.cgi?id=58589
417
418         * Scripts/webkitpy/tool/commands/queues.py:
419         * Scripts/webkitpy/tool/commands/queues_unittest.py:
420
421 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
422
423         [wx] Unreviewed build fix for Mac installation script.
424
425         * wx/packaging/build-mac-installer.py:
426
427 2011-04-14  Ojan Vafai  <ojan@chromium.org>
428
429         Reviewed by Tony Chang.
430
431         sort columns in the new json_results.html file
432         https://bugs.webkit.org/show_bug.cgi?id=58581
433
434         Also fix padding on TDs and the path to layout tests.
435
436         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
437
438 2011-04-14  Eric Seidel  <eric@webkit.org>
439
440         Reviewed by Dimitri Glazkov.
441
442         queues.webkit.org should display when a bot last passed a patch
443         https://bugs.webkit.org/show_bug.cgi?id=58546
444
445         I am suspicious that some of our commit-queue instances are never
446         actually passing anything.
447
448         This will let us know if those bots are never passing patches.
449
450         * QueueStatusServer/handlers/queuestatus.py:
451         * QueueStatusServer/index.yaml:
452         * QueueStatusServer/templates/queuestatus.html:
453
454 2011-04-14  Dirk Pranke  <dpranke@chromium.org>
455
456         Reviewed by Adam Roben.
457
458         REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
459         https://bugs.webkit.org/show_bug.cgi?id=58545
460
461         Remove platform-specific overrides; the default behavior should
462         be working everywhere now, I think.
463
464         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
465         * Scripts/webkitpy/layout_tests/port/mac.py:
466
467 2011-04-14  Eric Seidel  <eric@webkit.org>
468
469         Reviewed by Adam Barth.
470
471         commit-queues are hitting an exception trying to land when the tree is red
472         https://bugs.webkit.org/show_bug.cgi?id=58558
473
474         Just an un-tested (and thus broken) code path from yesterday's changes.
475
476         * Scripts/webkitpy/common/net/layouttestresults.py:
477         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
478         * Scripts/webkitpy/tool/commands/queues.py:
479         * Scripts/webkitpy/tool/commands/queues_unittest.py:
480
481 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
482
483         [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
484
485         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
486         (LayoutTestController::shadowRoot):
487         * wx/build/wxpresets.py:
488
489 2011-04-14  Victoria Kirst  <vrk@google.com>
490
491         Reviewed by James Robinson.
492
493         [chromium] Failing GPU video tests
494         https://bugs.webkit.org/show_bug.cgi?id=57926
495
496         Added/updated GPU directory names for rebaseline tool.
497
498         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
499
500 2011-04-13  Daniel Bates  <dbates@rim.com>
501
502         Reviewed by Adam Barth.
503
504         Perl unit test removeEOL.pl should print test case name on failure
505         https://bugs.webkit.org/show_bug.cgi?id=58513
506
507         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as
508           second argument of Test::Simple::ok().
509
510 2011-04-13  Kent Tamura  <tkent@chromium.org>
511
512         Reviewed by Eric Seidel.
513
514         gdb-safari should pass arguments to safari.
515         https://bugs.webkit.org/show_bug.cgi?id=58439
516
517         We can do:
518           gdb-safari --debug LayoutTests/.../foo.html
519
520         * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
521
522 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
523
524         Unreviewed, build fix.
525         https://bugs.webkit.org/show_bug.cgi?id=52763
526
527         r83799 broke test-webkitpy because it assumed we always have
528         access to a real filesystem (we don't during the unit tests).
529         Stubbing out the copy for now but we might need a better
530         solution at some point.
531
532         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
533
534 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
535
536         Reviewed by Tony Chang.
537
538         new-run-webkit-tests --run-singly option is busted
539         https://bugs.webkit.org/show_bug.cgi?id=55909
540
541         Python's broken lexical scoping strikes again :(.
542
543         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
544         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
545
546 2011-04-13  Ojan Vafai  <ojan@chromium.org>
547
548         Reviewed by Eric Seidel.
549
550         generated unexpected_results.html from unexpected_results.json
551         https://bugs.webkit.org/show_bug.cgi?id=52763
552
553         Eventually, we'll merge this with results.html and have a single richer results page.
554         For now, I just want to get something checked in that we can iterate on.
555
556         * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
557         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
558
559 2011-04-13  Eric Seidel  <eric@webkit.org>
560
561         Reviewed by Adam Barth.
562
563         Up the failure limit to allow the commit-queue to actually land when the tree is red
564         https://bugs.webkit.org/show_bug.cgi?id=58499
565
566         This change increases the --exit-after-N-failures limit used by the commit-queue
567         from 1 to 10.  This will cause the code added in bug 58494 to actually get
568         exercised and the queues should start being able to land when the trees are red.
569
570         When testing I found that test_runtests_leopard_commit_queue_hack_command was the
571         only unit test to actually detect this change!  Since we don't actually
572         run on leopard anymore, I removed the hack code and repurposed the test.
573
574         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
575         * Scripts/webkitpy/tool/steps/runtests.py:
576         * Scripts/webkitpy/tool/steps/steps_unittest.py:
577
578 2011-04-13  Eric Seidel  <eric@webkit.org>
579
580         Reviewed by Adam Barth.
581
582         commit-queue should be able to land when tree is red
583         https://bugs.webkit.org/show_bug.cgi?id=58494
584
585         There is some yak hair on my hands, I will admit.
586
587         This change is mostly about adding an ExpectedFailures
588         class to track when the bots are red and we should be
589         ignoring failures when landing from the commit-queue.
590
591         However, to make intelligent decisions about patches we
592         need to know whether the run hit the --exit-after-N-failures limit
593         or not.  Right now that information is not saved off in results.html
594         so we have to pull the information from RunTests.
595
596         I've plumbed the --exit-after-N-failures information into
597         LayoutTestResults for now to make the ExpectedFailures code cleaner.
598
599         As a result of adding all these additional calls to delegate.layout_test_results()
600         I broke some of our flaky test detection tests and had to re-write them
601         to not depend on the number of layout_test_results code.
602
603         At the same time I updated the commit-queue to use the newer filesystem
604         API (to allow us to use MockFileSystem) which required further changes
605         to the layout tests.  Changes were required in either case, since
606         we're now calling layout_test_results() in more cases, which previously
607         would try and hit the disk (until I moved it to use tool.filesystem).
608
609         I should note that *all* of this code is disabled for now, since our
610         --exit-after-N-failures limit is currently 1!  (Thus were always in the
611         case where we can't actually tell if the layout test results are legit.)
612         I will up that limit in a second patch (which may require a couple more unit test tweaks).
613
614         * Scripts/webkitpy/common/net/layouttestresults.py:
615         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
616         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
617         * Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
618         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
619         * Scripts/webkitpy/tool/commands/queues.py:
620         * Scripts/webkitpy/tool/commands/queues_unittest.py:
621         * Scripts/webkitpy/tool/commands/queuestest.py:
622         * Scripts/webkitpy/tool/steps/runtests.py:
623
624 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
625
626         Unreviewed build correction.
627
628         * TestWebKitAPI/PlatformWebView.h: Limit include of
629           <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
630
631 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
632
633         Reviewed by Eric Seidel.
634
635         [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
636         https://bugs.webkit.org/show_bug.cgi?id=58489
637         
638         r83743 added --additional-platform-directory to old-run-webkit-tests,
639         rename the equivalent flag in new-run-webkit-tests to be consistent.
640
641         * Scripts/webkitpy/layout_tests/port/base.py:
642         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
643         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
644         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
645
646 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
647
648         Reviewed by Eric Seidel.
649
650         Rebaseline queue server
651         https://bugs.webkit.org/show_bug.cgi?id=57891
652
653         Adds a simple rebaseline queue server (meant to run at
654         http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
655         builders and their failing tests, and allows those tests to be added to
656         a per-builer rebaseline queue.
657
658         A subsequent change will add a mode to NRWT (and/or a wrapper script)
659         for pulling the tests to be rebaselined from the server and running them
660         with --reset-results (the initial use-case is for the GPU hardware bots,
661         which do not have checked-in baselines, therefore there is no need for a
662         check-in step yet).
663
664         * RebaselineQueueServer/app.yaml: Added.
665         * RebaselineQueueServer/handlers/__init__.py: Added.
666         * RebaselineQueueServer/handlers/builderqueue.py: Added.
667         * RebaselineQueueServer/handlers/pages.py: Added.
668         * RebaselineQueueServer/index.yaml: Added.
669         * RebaselineQueueServer/main.py: Added.
670         * RebaselineQueueServer/model/__init__.py: Added.
671         * RebaselineQueueServer/model/queueentry.py: Added.
672         * RebaselineQueueServer/static/builder-frame-empty.html: Added.
673         * RebaselineQueueServer/static/styles.css: Added.
674         * RebaselineQueueServer/templates/builder-picker.html: Added.
675         * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
676         * RebaselineQueueServer/templates/builder-queue-list.html: Added.
677         * RebaselineQueueServer/templates/home.html: Added.
678
679 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
680
681         Reviewed by Mihai Parparita.
682
683         nrwt: enable multiple processes by default on Chromium Win.
684         https://bugs.webkit.org/show_bug.cgi?id=55163
685
686         Re-land r79268; it should be more stable now and will hopefully
687         work.
688
689         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
690         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
691
692 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
693
694         Reviewed by Ojan Vafai.
695
696         new-run-webkit-tests: configure logging in child processes properly
697         https://bugs.webkit.org/show_bug.cgi?id=58296
698
699         Logging propagated properly from manager to worker processes on
700         Unix but not on Windows; this fixes that.
701
702         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
703         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
704
705 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
706
707         Reviewed by Ojan Vafai.
708
709         new-run-webkit-tests: suppress extraneous pretty patch warnings
710         https://bugs.webkit.org/show_bug.cgi?id=58295
711
712         NRWT wasn't being careful about when it logged messages from
713         PrettyPatch not being available; it should only log during
714         check_build(), and be silent otherwise. This was causing us to
715         get multiple errors at runtime, which was confusing.
716
717         * Scripts/webkitpy/layout_tests/port/base.py:
718         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
719         * Scripts/webkitpy/layout_tests/port/chromium.py:
720
721 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
722
723         Reviewed by Jian Li.
724
725         add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
726         https://bugs.webkit.org/show_bug.cgi?id=58461
727
728         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
729
730 2011-04-13  Tony Chang  <tony@chromium.org>
731
732         Unreviewed, fix NRWT.  Stack:
733
734             return super(ChromiumPort, self).results_directory(self)
735         TypeError: results_directory() takes exactly 1 argument (2 given)
736
737         * Scripts/webkitpy/layout_tests/port/chromium.py:
738
739 2011-04-13  Adam Roben  <aroben@apple.com>
740
741         Teach ORWT about extra platform-specific directories to be searched before the default ones
742
743         Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
744         platform-specific results
745
746         Reviewed by Anders Carlsson.
747
748         * Scripts/old-run-webkit-tests:
749         (top-level): Added @additionalPlatformDirectories and hooked up
750         --additional-platform-directories to populate it.
751         (buildPlatformResultHierarchy): Prepend the additional platform directories to the default
752         list (after filtering out any of the additional directories that don't exist).
753
754 2011-04-13  Lucas Forschler  <lforschler@apple.com>
755
756         Reviewed by Adam Roben.
757
758         Add the /T command to taskkill.exe.
759         This will kill spawned child processes.
760         
761         * BuildSlaveSupport/win/kill-old-processes:
762
763 2011-04-13  Lucas Forschler  <lforschler@apple.com>
764
765         Reviewed by Adam Roben.
766
767         Sort kill list alphabeticaly.
768         Fixed capitalization on VcBuildHelper.  
769
770         * BuildSlaveSupport/win/kill-old-processes:
771
772 2011-04-13  Lucas Forschler  <lforschler@apple.com>
773
774         Reviewed by Adam Roben.
775
776         https://bugs.webkit.org/show_bug.cgi?id=58384
777         Update kill-old-processes to include a few new ones.
778         
779         * BuildSlaveSupport/win/kill-old-processes:
780
781 2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>
782
783         Reviewed by Martin Robinson.
784
785         [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
786         https://bugs.webkit.org/show_bug.cgi?id=58297
787
788         Do not disable flash specifically when built with GTK+ 3 -
789         PluginPackage should do the right thing while loading plugins.
790
791         * GtkLauncher/main.c:
792         (main):
793
794 2011-04-12  Kent Tamura  <tkent@chromium.org>
795
796         Reviewed by Dimitri Glazkov.
797
798         [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
799         https://bugs.webkit.org/show_bug.cgi?id=57426
800
801         * DumpRenderTree/chromium/WebPreferences.cpp:
802         (WebPreferences::applyTo): Disable the validation message timer.
803
804 2011-04-12  James Kozianski  <koz@chromium.org>
805
806         Unreviewed.
807
808         Adding myself to committers.py.
809
810         * Scripts/webkitpy/common/config/committers.py:
811
812 2011-04-12  Brent Fulgham  <bfulgham@webkit.org>
813
814         Unreviewed build correction for WinCairo bot after r83639.
815         https://bugs.webkit.org/show_bug.cgi?id=51790
816
817         Correct typo for the new "update-webkit-wincairo-libs" script.
818
819         * Scripts/build-webkit: Incorrectly calling the
820           update-webkit-cairo-libs which does not exist.
821
822 2011-04-12  Alice Liu  <alice.liu@apple.com>
823
824         Reviewed by Jon Honeycutt.
825
826         A change that should have been part of http://trac.webkit.org/changeset/83628
827
828         * DumpRenderTree/win/DumpRenderTree.cpp:
829         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
830
831 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
832
833         Reviewed by Tony Chang.
834
835         new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
836         https://bugs.webkit.org/show_bug.cgi?id=58272
837
838         NRWT was interpreting the --results-directory cmd line arg as
839         relative to the build directory, not the current working
840         directory (ORWT uses the latter, which is much more intuitive).
841         
842         This patch fixes the base case, but includes an override for
843         Chromium that is needed until the bots can be updated.
844
845         * Scripts/webkitpy/layout_tests/port/base.py:
846         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
847         * Scripts/webkitpy/layout_tests/port/chromium.py:
848         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
849         * Scripts/webkitpy/layout_tests/port/test.py:
850         * Scripts/webkitpy/layout_tests/port/webkit.py:
851         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
852         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
853
854 2011-04-12  Philippe Normand  <pnormand@igalia.com>
855
856         Unreviewed, roll out r83621 as it broke the GTK build.
857
858         [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
859         https://bugs.webkit.org/show_bug.cgi?id=58333
860
861         * Scripts/build-jsc:
862         * Scripts/build-webkit:
863
864 2011-04-12  Carl Lobo  <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
865
866         Reviewed by Adam Roben.
867
868         Patch to download the WinCairo dependancies as part of build-webkit.
869         https://bugs.webkit.org/show_bug.cgi?id=51790
870
871         This patch downloads the dependancies from 
872             http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip 
873         checking the modification timestamp etc. 
874
875         * Tools/Scripts/build-webkit
876         * Tools/Scripts/update-webkit: Modified to understand the --wincairo
877           flag, and to update WinCairo dependencies when used.
878         * Tools/Scripts/update-webkit-cairo-libs: added
879         * Tools/Scripts/update-webkit-dependency: added
880         * Tools/Scripts/update-webkit-auxiliary-libs
881
882 2011-04-12  Jeff Miller  <jeffm@apple.com>
883
884         Reviewed by Adam Roben.
885
886         WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
887         https://bugs.webkit.org/show_bug.cgi?id=56020
888
889         Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
890         since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
891         which would generate two characters for every keypress (for example).  I didn't bother doing this for
892         WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
893         
894         Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
895
896         * MiniBrowser/win/main.cpp:
897         (shouldTranslateMessage): Added.
898         (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
899         * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
900         * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
901         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
902         (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
903         (TestWebKitAPI::runAndWatchForWMChar): Added.
904         (TestWebKitAPI::TEST): Added.
905         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
906         (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
907         (TestWebKitAPI::Util::shouldTranslateMessage): Added.
908         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
909         (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
910         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
911
912 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
913
914         Reviewed by Tony Chang.
915
916         new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
917         https://bugs.webkit.org/show_bug.cgi?id=58290
918
919         This is some preliminary refactoring for bug 58272.
920
921         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
922         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
923         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
924         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
925         * Scripts/webkitpy/layout_tests/port/test.py:
926         * Scripts/webkitpy/layout_tests/port/chromium.py:
927         * Scripts/webkitpy/layout_tests/port/base.py:
928         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
929
930 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
931
932         Reviewed by Eric Seidel.
933
934         webkitpy: fix mock_filesystem abspath to handle relative paths
935         and add filesystem.chdir() and filesystem.getcwd() to be able
936         to test this and mock it out.
937
938         https://bugs.webkit.org/show_bug.cgi?id=58288
939
940         * Scripts/webkitpy/common/system/filesystem.py:
941         * Scripts/webkitpy/common/system/filesystem_mock.py:
942         * Scripts/webkitpy/common/system/filesystem_unittest.py:
943
944 2011-04-12  Alice Liu  <alice.liu@apple.com>
945
946         Reviewed by Sam Weinig.
947
948         https://bugs.webkit.org/show_bug.cgi?id=58292
949         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
950
951         * DumpRenderTree/mac/DumpRenderTree.mm:
952         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
953
954 2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
955
956         Reviewed by Eric Seidel.
957
958         [Qt] Enable JIT build for SH4 platforms.
959         https://bugs.webkit.org/show_bug.cgi?id=58317
960
961
962         * DumpRenderTree/qt/DumpRenderTree.pro:
963         * QtTestBrowser/QtTestBrowser.pro:
964         * Scripts/webkitdirs.pm:
965
966 2011-04-12  Tony Chang  <tony@chromium.org>
967
968         Reviewed by Andreas Kling.
969
970         [Qt] embed checksums in PNGs written by Qt-DRT
971         https://bugs.webkit.org/show_bug.cgi?id=58173
972
973         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
974         (WebCore::DumpRenderTree::dump):
975
976 2011-04-12  Eric Seidel  <eric@webkit.org>
977
978         Reviewed by Adam Barth.
979
980         commit-queue should upload failure diffs when tests fail
981         https://bugs.webkit.org/show_bug.cgi?id=58348
982
983         This change was mostly just plumbing.  We were already saving
984         this information for flaky test reporting.  I just made it possible
985         for normal failures to report archives as well.
986
987         I did a little abstraction work to try and share some code between
988         flakytestreporter.py and this new code.  There is still more we could do.
989
990         In making this change I also went through and updated the various
991         places we have urls hard-coded in our python and pointed them at
992         common.config.urls.
993
994         * Scripts/webkitpy/common/checkout/scm.py:
995         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
996         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
997         * Scripts/webkitpy/common/net/statusserver.py:
998         * Scripts/webkitpy/layout_tests/port/base.py:
999         * Scripts/webkitpy/tool/bot/botinfo.py: Added.
1000         * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
1001         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1002         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1003         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1004         * Scripts/webkitpy/tool/commands/queues.py:
1005
1006 2011-04-12  Daniel Bates  <dbates@rim.com>
1007
1008         Rubber-stamped by Eric Seidel.
1009
1010         svn-apply and/or patch(1) has trouble applying patches that makes changes to files
1011         with Windows line endings
1012         https://bugs.webkit.org/show_bug.cgi?id=53625
1013
1014         Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
1015         applied to an SCM checkout on a Windows file system and vice-versa.
1016
1017         This issue manifests itself due to custom SCM settings as well as differences in
1018         gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
1019         into svn-apply/unapply to compensate for differences in line endings by converting
1020         the line endings in a patch to match the line endings in the target file (if it exists).
1021
1022         * Scripts/VCSUtils.pm:
1023           - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
1024             content read from the specified file handle. Obviously, this heuristic will not work
1025             for files with mixed line endings, but I don't envision such files to be the norm. If
1026             this turns out to be an issue then we can improve the heuristic.
1027           - Added firstEOLInFile().
1028           - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
1029             In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
1030             endings in the diff instead of the line endings in the target file.
1031           - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
1032             re-used in parseDiff().
1033         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
1034           to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
1035           mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
1036         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
1037         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
1038
1039 2011-04-12  Sam Weinig  <sam@webkit.org>
1040
1041         Reviewed by Adam Roben.
1042
1043         REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
1044         https://bugs.webkit.org/show_bug.cgi?id=58336
1045
1046         * WebKitTestRunner/TestController.cpp:
1047         (WTR::TestController::resetStateToConsistentValues):
1048         Remove cache clearing as that is causing tests to crash on Windows 7.
1049
1050 2011-04-11  Sam Weinig  <sam@webkit.org>
1051
1052         Reviewed by Anders Carlsson.
1053
1054         REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
1055         <rdar://problem/8981346>
1056         https://bugs.webkit.org/show_bug.cgi?id=54159
1057
1058         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1059         (WTR::InjectedBundlePage::InjectedBundlePage):
1060         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1061         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
1062         (WTR::InjectedBundlePage::decidePolicyForResponse):
1063         (WTR::InjectedBundlePage::unableToImplementPolicy):
1064         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1065         Add short-circuited policy client which matches WebKit1.
1066
1067         * WebKitTestRunner/TestController.cpp:
1068         (WTR::TestController::resetStateToConsistentValues):
1069         Clear the cache between tests to ensure consistent results.
1070
1071 2011-04-11  George Guo  <George.Guo@nokia.com>
1072
1073         Reviewed by Eric Seidel.
1074
1075         prepare-ChangeLog support email input but -h did not show the option
1076         https://bugs.webkit.org/show_bug.cgi?id=58164
1077
1078         Add email option to -h to improve the usability
1079
1080         * Scripts/prepare-ChangeLog:
1081
1082 2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
1083
1084         Reviewed by Eric Carlson.
1085
1086         Rename MediaControls to MediaControlRootElement.
1087         https://bugs.webkit.org/show_bug.cgi?id=58250
1088
1089         * Scripts/do-webcore-rename: Documented the renaming.
1090
1091 2011-04-11  Sam Weinig  <sam@webkit.org>
1092
1093         Fix Windows build.
1094
1095         * MiniBrowser/win/BrowserView.cpp:
1096         (BrowserView::create):
1097
1098 2011-04-11  Sam Weinig  <sam@webkit.org>
1099
1100         Reviewed by Anders Carlsson.
1101
1102         Move focus management out of WebKit via  the UIClient
1103         <rdar://problem/8784068>
1104         https://bugs.webkit.org/show_bug.cgi?id=58278
1105
1106         * MiniBrowser/mac/BrowserWindowController.m:
1107         (-[BrowserWindowController awakeFromNib]):
1108         * WebKitTestRunner/TestController.cpp:
1109         (WTR::TestController::createOtherPage):
1110         (WTR::TestController::initialize):
1111         Add stubs for new UIClient functions.
1112
1113 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
1114
1115         Reviewed by Eric Seidel.
1116
1117         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
1118         https://bugs.webkit.org/show_bug.cgi?id=53605
1119
1120         Add an implementation of the PlainTextController for the GTK+ DRT.
1121
1122         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1123         (addControllerToWindow): Added this helper method.
1124         (webViewWindowObjectCleared): Use the new helper to add EventSender
1125         and the PlainTextController to the window object.
1126         * GNUmakefile.am: Added PlainTextController source files.
1127         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
1128         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
1129         until that functionality exists somewhere in the WebKitGTK+ stack.
1130         * DumpRenderTree/gtk/PlainTextController.h: Added.
1131
1132 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
1133
1134         Unreviewed.
1135
1136         Adding my IRC nick.
1137
1138         * Scripts/webkitpy/common/config/committers.py:
1139
1140 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
1141
1142         Reviewed by Adam Roben.
1143
1144         new-run-webkit-tests: fix crash when running under windows cmd.exe
1145         https://bugs.webkit.org/show_bug.cgi?id=58197
1146
1147         We would intermittently crash when running NRWT directly under
1148         cmd.exe on windows because we were sharing the stdin file
1149         descriptor between the python process and the http server.
1150         cmd.exe really didn't like that, and there was no reason to
1151         share the descriptor, so we now use a PIPE instead.
1152
1153         * Scripts/webkitpy/layout_tests/port/http_server.py:
1154
1155 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
1156
1157         Reviewed by Ojan Vafai.
1158
1159         new-run-webkit-tests: add unit tests for Port.diff_image()
1160         https://bugs.webkit.org/show_bug.cgi?id=58196
1161
1162         Add the unit tests for the fix in bug 58195.
1163
1164         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1165         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1166         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1167
1168 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
1169
1170         Reviewed by Tony Chang.
1171
1172         new-run-webkit-tests: implement support for audio, take two
1173         https://bugs.webkit.org/show_bug.cgi?id=58195
1174
1175         Attempt to re-land the fix for bug 58101 (which was initially
1176         landed in r83330, but rolled out). This is the same patch but
1177         fixes crashes in Port.diff_image() caused by the change for
1178         empty image files being None instead of ''.
1179
1180         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1181         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1182         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1183         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1184         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1185         * Scripts/webkitpy/layout_tests/port/base.py:
1186         * Scripts/webkitpy/layout_tests/port/chromium.py:
1187         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1188         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1189         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1190         * Scripts/webkitpy/layout_tests/port/test.py:
1191         * Scripts/webkitpy/layout_tests/port/webkit.py:
1192
1193 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
1194
1195         Reviewed by Xan Lopez.
1196
1197         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
1198         https://bugs.webkit.org/show_bug.cgi?id=57854
1199
1200         Implement missing features in GTK's DRT.
1201
1202         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1203         (indexRangeInTable): New helper function to get the range string
1204         for the current cell inside the parent table, either from the
1205         point of view of rows or columns.
1206         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
1207         the new helper function indexRangeInTable().
1208         (AccessibilityUIElement::columnIndexRange): Ditto.
1209
1210 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
1211
1212         Reviewed by Chris Fleizach.
1213
1214         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
1215         https://bugs.webkit.org/show_bug.cgi?id=57826
1216
1217         Implement missing feature in GTK's DRT.
1218
1219         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1220         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
1221         relying on the analogous function from the AtkTable interface.
1222
1223 2011-04-05  Timothy Hatcher  <timothy@apple.com>
1224
1225         Fix the extract-localizable-strings script errors that started after
1226         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
1227
1228         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
1229
1230 2011-04-11  Tony Chang  <tony@chromium.org>
1231
1232         Reviewed by Eric Seidel.
1233
1234         fix crc computation on 64 bit machines
1235         https://bugs.webkit.org/show_bug.cgi?id=58243
1236
1237         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
1238
1239         * DumpRenderTree/CyclicRedundancyCheck.cpp:
1240         (makeCrcTable):
1241         (computeCrc):
1242         * DumpRenderTree/CyclicRedundancyCheck.h:
1243         * DumpRenderTree/PixelDumpSupport.cpp:
1244         (appendIntToVector):
1245         (convertChecksumToPNGComment):
1246
1247 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
1248
1249         Reviewed by Eric Seidel.
1250
1251         Require no undefined symbols during compilation.
1252
1253         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
1254         https://bugs.webkit.org/show_bug.cgi?id=54896
1255
1256         Add -Wl,--no-undefined to catch missing symbols early.
1257
1258         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1259         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1260
1261 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
1262
1263         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
1264
1265         * wx/build/settings.py:
1266
1267 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
1268
1269         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
1270
1271         * wx/build/settings.py:
1272
1273 2011-04-10  David Levin  <levin@chromium.org>
1274
1275         Reviewed by Dimitri Glazkov.
1276
1277         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
1278         https://bugs.webkit.org/show_bug.cgi?id=58201
1279
1280         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
1281         and filed bug 58202.
1282
1283 2011-04-09  David Levin  <levin@chromium.org>
1284
1285         Unreviewed, rolling out r83394.
1286         http://trac.webkit.org/changeset/83394
1287         https://bugs.webkit.org/show_bug.cgi?id=53625
1288
1289         Patch was incorrect as noted in the bug.
1290
1291         * Scripts/svn-apply:
1292
1293 2011-04-09  David Levin  <levin@chromium.org>
1294
1295         Reviewed by Adam Barth.
1296
1297         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
1298         https://bugs.webkit.org/show_bug.cgi?id=53625
1299
1300         * Scripts/svn-apply: Ensure that the portions of patches
1301         which are for vcproj/vsprops files has DOS line endings.
1302
1303 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
1304
1305         Reviewed by Tony Chang.
1306
1307         It looks like NRWT has not been stopping DRT/TestShell
1308         instances properly on windows, probably for a long time.
1309         This would go a long way to explaining why we often have
1310         processes lying around :)
1311
1312         https://bugs.webkit.org/show_bug.cgi?id=57807
1313
1314         * Scripts/webkitpy/layout_tests/port/chromium.py:
1315         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1316
1317 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
1318
1319         Reviewed by Laszlo Gombos.
1320
1321         [Qt] Don't link against fontconfig or X11 if embedded
1322         https://bugs.webkit.org/show_bug.cgi?id=58104
1323
1324         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
1325         * QtTestBrowser/QtTestBrowser.pro: ditto
1326         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
1327         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
1328
1329 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
1330
1331         http/tests/loading/preload-append-scan.php is failing on Windows
1332         https://bugs.webkit.org/show_bug.cgi?id=58178
1333
1334         Reviewed by Brian Weinstein.
1335
1336         * DumpRenderTree/win/DumpRenderTree.cpp:
1337         (lastPathComponent):
1338         Use CFURL API to find the last path component, rather than
1339         PathFindFileName(), because the latter will include the query string.
1340
1341 2011-04-08  Jian Li  <jianli@chromium.org>
1342
1343         Unreviewed, rolling out r83327, r83330 since these patches are very
1344         likely to break chromium webkit mac10.6 builders.
1345
1346         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1347         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1348         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1349         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1350         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1351         * Scripts/webkitpy/layout_tests/port/base.py:
1352         * Scripts/webkitpy/layout_tests/port/chromium.py:
1353         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1354         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1355         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1356         * Scripts/webkitpy/layout_tests/port/test.py:
1357         * Scripts/webkitpy/layout_tests/port/webkit.py:
1358
1359 2011-04-08  Vincent Scheib  <scheib@chromium.org>
1360
1361         Reviewed by Eric Seidel.
1362
1363         add chromium-gpu-linux-x86_64 to the recognized list of ports
1364         https://bugs.webkit.org/show_bug.cgi?id=58099
1365
1366         Add chromium-gpu-linux-x86_64 to fix assert.
1367
1368         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1369
1370 2011-04-08  Alpha Lam  <hclam@chromium.org>
1371
1372         Unreviewed, rolling out r83335.
1373         http://trac.webkit.org/changeset/83335
1374         https://bugs.webkit.org/show_bug.cgi?id=53556
1375
1376         GTK and QT bots are broken
1377
1378         * Scripts/build-webkit:
1379
1380 2011-04-07  Anna Cavender  <annacc@chromium.org>
1381
1382         Reviewed by Eric Carlson.
1383
1384         Setup ENABLE(TRACK) feature define
1385         https://bugs.webkit.org/show_bug.cgi?id=53556
1386
1387         * Scripts/build-webkit:
1388
1389 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
1390
1391         Reviewed by Adam Roben.
1392
1393         new-run-webkit-tests: configure a NRWT test bot for Mac SL
1394         https://bugs.webkit.org/show_bug.cgi?id=58114
1395
1396         This change removes the old new-run-webkit-tests entry and
1397         updates it for a new test-only bot.
1398
1399         * BuildSlaveSupport/build.webkit.org-config/config.json:
1400
1401 2011-04-08  Dominic Cooney  <dominicc@google.com>
1402
1403         Reviewed by Adam Roben.
1404
1405         Make layoutTestController.shadowRoot return null, not undefined,
1406         when its argument is invalid.
1407         https://bugs.webkit.org/show_bug.cgi?id=58121
1408
1409         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1410         (LayoutTestController::shadowRoot):
1411         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1412         (WTR::LayoutTestController::shadowRoot):
1413
1414 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
1415
1416         Reviewed by Adam Roben.
1417
1418         Locate NSTD.EXE in 64-bit Windows
1419         https://bugs.webkit.org/show_bug.cgi?id=57847
1420
1421         * Scripts/old-run-webkit-tests:
1422
1423 2011-04-08  Adam Roben  <aroben@apple.com>
1424
1425         Qt build fix
1426
1427         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
1428
1429 2011-04-07  Adam Roben  <aroben@apple.com>
1430
1431         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
1432
1433         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
1434         plugin
1435
1436         Reviewed by Anders Carlsson.
1437
1438         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1439         (pluginLogWithArguments): Moved code to format and log the message here...
1440         (pluginLog): ...from here.
1441
1442         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
1443
1444         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1445         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
1446
1447         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
1448
1449         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
1450         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
1451         to begin.
1452         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
1453         constructor.
1454         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
1455         can be used to invoke our setWillBeDestroyed function.
1456         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
1457         anything unexpected happens).
1458         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
1459         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
1460         NPP_SetWindow was *not* called during destruction.
1461         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
1462         method, setWillBeDestroyed.
1463         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
1464         object.
1465
1466         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1467         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1468         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1469         * GNUmakefile.am:
1470         Added new test.
1471
1472         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
1473         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
1474
1475 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
1476
1477         Reviewed by Martin Robinson.
1478
1479         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
1480         https://bugs.webkit.org/show_bug.cgi?id=58039
1481
1482         Implement missing functions in GTK's DRT.
1483
1484         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1485         (AccessibilityUIElement::increment): Implemented.
1486         (AccessibilityUIElement::decrement): Implemented.
1487
1488 2011-04-08  Dominic Cooney  <dominicc@google.com>
1489
1490         Reviewed by Kent Tamura.
1491
1492         Make WK2 layoutTestController.shadowRoot return undefined, not
1493         null, when its argument is not an element.
1494         https://bugs.webkit.org/show_bug.cgi?id=58121
1495
1496         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1497         (WTR::LayoutTestController::shadowRoot):
1498
1499 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
1500
1501         Reviewed by Mihai Parparita.
1502
1503         Change reference port for Mac GPU baselines from
1504         Leopard to SnowLeopard, XP to Win7, and Linux-x86
1505         to Linux x86-64.
1506
1507         https://bugs.webkit.org/show_bug.cgi?id=58099
1508
1509         * Scripts/webkitpy/layout_tests/port/chromium.py:
1510
1511 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
1512
1513         Revert ENABLE_TRACK patch due to compile failures.
1514
1515         * Scripts/build-webkit:
1516
1517 2011-04-07  Tony Chang  <tony@chromium.org>
1518
1519         Reviewed by Eric Seidel.
1520
1521         update DRT to embed checksums in png files
1522         https://bugs.webkit.org/show_bug.cgi?id=57871
1523
1524         We insert the bytes for the comment in printPNG rather than at encode
1525         time because each platform does its own PNG encoding (either using CG
1526         or cairo).  Putting this in pringPNG avoids having to duplicate this
1527         code, although it's not as clean as doing it at encoding time.
1528
1529         We insert the comment right after the IHDR chunk of the PNG.
1530
1531         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1532         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
1533         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
1534         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
1535         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
1536         * DumpRenderTree/PixelDumpSupport.cpp:
1537         (dumpWebViewAsPixelsAndCompareWithExpected):
1538         (convertChecksumToPNGComment): Generate the bytes to insert.
1539         (printPNG): Insert the png comment before the first IDAT section.
1540         * DumpRenderTree/PixelDumpSupport.h:
1541         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
1542         (printPNG):
1543         (dumpBitmap):
1544         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1545         (printPNG):
1546         (dumpBitmap):
1547         * DumpRenderTree/win/DumpRenderTree.vcproj:
1548         * GNUmakefile.am:
1549
1550 2011-04-07  Jeff Miller  <jeffm@apple.com>
1551
1552         Reviewed by Adam Roben.
1553
1554         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
1555         https://bugs.webkit.org/show_bug.cgi?id=58058
1556
1557         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1558         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
1559
1560 2011-04-07  Chang Shu  <cshu@webkit.org>
1561
1562         Reviewed by Darin Adler.
1563
1564         WebKitTestRunner needs layoutTestController.isPageBoxVisible
1565         https://bugs.webkit.org/show_bug.cgi?id=42695
1566
1567         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1568         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1569         (WTR::LayoutTestController::isPageBoxVisible):
1570         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1571
1572 2011-04-07  Adam Roben  <aroben@apple.com>
1573
1574         Build fix
1575
1576         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
1577
1578 2011-04-07  Adam Roben  <aroben@apple.com>
1579
1580         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
1581
1582         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
1583         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
1584         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
1585         be overridden by subclasses to provide extra URLs before we call up to the base class (after
1586         which adding more URLs is no longer possible).
1587
1588         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
1589         bot results page
1590
1591         Reviewed by John Sullivan.
1592
1593         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1594         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
1595         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
1596         method is never called for MasterShellCommands.
1597         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
1598         with this method (which is).
1599
1600 2011-04-07  Adam Roben  <aroben@apple.com>
1601
1602         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
1603
1604         This matches how most of our other build steps work, so is good just for improving
1605         consistency between build steps. It should also make it possible for
1606         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
1607         trying to do this in finished() after we had called up to the base class, but that was
1608         apparently too late to add more URLs.)
1609
1610         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
1611         results page
1612
1613         Reviewed by John Sullivan.
1614
1615         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1616         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
1617         call setText to get the right text to show up for this step. This matches how most of our
1618         other build steps work.
1619         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
1620         This is how most of our other build steps work.
1621         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
1622         function, to match the base class.
1623
1624 2011-04-07  Adam Barth  <abarth@webkit.org>
1625
1626         Reviewed by Maciej Stachowiak.
1627
1628         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
1629         https://bugs.webkit.org/show_bug.cgi?id=58022
1630
1631         Previously, we were ignoring the args variable!  This patch fixes the
1632         regression introduced in http://trac.webkit.org/changeset/82771.
1633
1634         * Scripts/webkitpy/tool/commands/download_unittest.py:
1635         * Scripts/webkitpy/tool/mocktool.py:
1636         * Scripts/webkitpy/tool/steps/checkstyle.py:
1637
1638 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
1639
1640         Reviewed by Adam Barth.
1641
1642         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
1643         https://bugs.webkit.org/show_bug.cgi?id=58017
1644
1645         * Scripts/webkitpy/common/checkout/scm.py:
1646         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1647
1648 2011-04-06  Chang Shu  <cshu@webkit.org>
1649
1650         Reviewed by Darin Adler.
1651
1652         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
1653         https://bugs.webkit.org/show_bug.cgi?id=57984
1654
1655         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1656         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1657         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
1658         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1659
1660 2011-04-06  Chris Rogers  <crogers@google.com>
1661
1662         Reviewed by Tony Chang.
1663
1664         Add web audio support to DumpRenderTree (mac port)
1665         https://bugs.webkit.org/show_bug.cgi?id=57969
1666
1667         * DumpRenderTree/LayoutTestController.cpp:
1668         (LayoutTestController::LayoutTestController):
1669         (setEncodedAudioDataCallback):
1670         (LayoutTestController::staticFunctions):
1671         * DumpRenderTree/LayoutTestController.h:
1672         (LayoutTestController::dumpAsAudio):
1673         (LayoutTestController::setDumpAsAudio):
1674         (LayoutTestController::encodedAudioData):
1675         (LayoutTestController::setEncodedAudioData):
1676         * DumpRenderTree/mac/DumpRenderTree.mm:
1677         (dumpAudio):
1678         (dump):
1679
1680 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
1681
1682         Reviewed by Kenneth Rohde Christiansen.
1683
1684         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
1685         https://bugs.webkit.org/show_bug.cgi?id=56086
1686
1687         Add the missing method.
1688
1689         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1690         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
1691         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1692         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1693         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1694
1695 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
1696
1697         Reviewed by David Levin.
1698
1699         Add QUOTA build flag for unified quota API
1700         https://bugs.webkit.org/show_bug.cgi?id=57918
1701
1702         * Scripts/build-webkit: Added QUOTA build flag
1703
1704 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
1705
1706         Reviewed by Tony Chang.
1707
1708         Adjust the apple webkit port's default timeout to match
1709         old-run-webkit-tests at 35 seconds.
1710
1711         https://bugs.webkit.org/show_bug.cgi?id=37738
1712
1713         * Scripts/webkitpy/layout_tests/port/mac.py:
1714
1715 2011-04-06  Scott Cameron  <sccameron@rim.com>
1716
1717         Reviewed by Eric Seidel.
1718
1719         Remove global variable $httpdPath and replace with the return value of
1720         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
1721         https://bugs.webkit.org/show_bug.cgi?id=53499
1722
1723         * Scripts/run-iexploder-tests:
1724         * Scripts/webkitperl/httpd.pm:
1725
1726 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
1727
1728         Reviewed by Darin Adler.
1729
1730         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
1731         
1732         https://bugs.webkit.org/show_bug.cgi?id=27551
1733         
1734         * DumpRenderTree/config.h:
1735         * WebKitAPITest/config.h:
1736         * WebKitTestRunner/config.h:
1737
1738 2011-04-06  Tony Chang  <tony@chromium.org>
1739
1740         Reviewed by Darin Adler.
1741
1742         teach run-webkit-tests to read checksums from png files
1743         https://bugs.webkit.org/show_bug.cgi?id=57993
1744
1745         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
1746           no .checksum and look for the checksum in there.
1747
1748 2011-04-06  David Dorwin  <ddorwin@chromium.org>
1749
1750         Reviewed by David Levin.
1751
1752         Enable fullscreen layout tests for Chromium
1753         https://bugs.webkit.org/show_bug.cgi?id=55726
1754
1755         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
1756
1757         * DumpRenderTree/chromium/WebPreferences.cpp:
1758         (WebPreferences::applyTo):
1759
1760 2011-04-06  Adam Roben  <aroben@apple.com>
1761
1762         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
1763
1764         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
1765
1766         Reviewed by David Kilzer.
1767
1768         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1769         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
1770         build's results directory here...
1771         (ExtractTestResults.finished): ...from here.
1772         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
1773         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
1774         leaks" link to point to Leaks Viewer for this build.
1775         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
1776         but it seemed good to add for consistency with BuildAndTestFactory.
1777         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
1778         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
1779         that we'll get a "view leaks" link.
1780
1781 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
1782
1783         Reviewed by Eric Seidel.
1784
1785         [Gtk] plugins/set-status.html fails
1786         https://bugs.webkit.org/show_bug.cgi?id=57844
1787
1788         Allow an empty status text to be dumped.
1789
1790         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1791         (webViewStatusBarTextChanged):
1792
1793 2011-04-06  Chang Shu  <cshu@webkit.org>
1794
1795         Reviewed by Darin Adler.
1796
1797         WebKitTestRunner needs layoutTestController.pageNumberForElementById
1798         https://bugs.webkit.org/show_bug.cgi?id=42329
1799
1800         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1801         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1802         (WTR::LayoutTestController::pageNumberForElementById):
1803         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1804
1805 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
1806
1807         Reviewed by Martin Robinson.
1808
1809         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
1810         https://bugs.webkit.org/show_bug.cgi?id=57932
1811
1812         Some Layout tests have invalid URIs that do not generate valid
1813         SoupURI instances. Do not try to free those NULL SoupURIs.
1814
1815         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1816         (willSendRequestCallback):
1817
1818 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
1819
1820         Reviewed by Andreas Kling.
1821
1822         ORWT shouldn't generate diff files for tests without expected files
1823         https://bugs.webkit.org/show_bug.cgi?id=57846
1824
1825         * Scripts/old-run-webkit-tests:
1826
1827 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
1828
1829         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
1830         to deps.
1831
1832         * wx/install-unix-extras:
1833
1834 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1835
1836         Unreviewed, rolling out r82978, r82999, and r83001.
1837         http://trac.webkit.org/changeset/82978
1838         http://trac.webkit.org/changeset/82999
1839         http://trac.webkit.org/changeset/83001
1840         https://bugs.webkit.org/show_bug.cgi?id=57913
1841
1842         Does not work in Python 2.5 (Requested by abarth on #webkit).
1843
1844         * Scripts/webkitpy/common/system/executive.py:
1845         * Scripts/webkitpy/common/system/executive_unittest.py:
1846
1847 2011-04-05  Chang Shu  <cshu@webkit.org>
1848
1849         Reviewed by Darin Adler.
1850
1851         WebKitTestRunner needs layoutTestController.numberOfPages
1852         https://bugs.webkit.org/show_bug.cgi?id=42694
1853
1854         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1855         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1856         (WTR::LayoutTestController::numberOfPages):
1857         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1858
1859 2011-04-05  Tony Chang  <tony@chromium.org>
1860
1861         Reviewed by Mihai Parparita.
1862
1863         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
1864         https://bugs.webkit.org/show_bug.cgi?id=57889
1865
1866         * Scripts/webkitpy/layout_tests/port/chromium.py:
1867         * Scripts/webkitpy/layout_tests/port/test.py:
1868         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1869
1870 2011-04-05  Adam Barth  <abarth@webkit.org>
1871
1872         Silly with statement, from the future!
1873
1874         * Scripts/webkitpy/common/system/executive.py:
1875
1876 2011-04-05  Adam Barth  <abarth@webkit.org>
1877
1878         Reviewed by Tony Chang.
1879
1880         Don't use Exception.message because it's deprecated
1881         https://bugs.webkit.org/show_bug.cgi?id=57892
1882
1883         Suppress the warning for now.  When we move to Python 3, we might need
1884         to something more dramatic.
1885
1886         * Scripts/webkitpy/common/system/executive.py:
1887
1888 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1889
1890         Reviewed by Ojan Vafai.
1891
1892         Add builders.js to dashboard file list
1893         https://bugs.webkit.org/show_bug.cgi?id=57899
1894
1895         Add file added by http://crrev.com/80538 to dashboard file list.
1896
1897         * TestResultServer/handlers/dashboardhandler.py:
1898
1899 2011-04-05  MORITA Hajime  <morrita@google.com>
1900
1901         Reviewed by Adam Barth.
1902
1903         webkit-patch should print git's stderr when git svn dcommit fail
1904         http://webkit.org/b/57861
1905
1906         * Scripts/webkitpy/common/checkout/scm.py:
1907
1908 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1909
1910         Reviewed by Tony Chang.
1911
1912         Add --baseline-search-path to NRWT
1913         https://bugs.webkit.org/show_bug.cgi?id=56233
1914         
1915         Add NRWT option to specify additional directories to look for baselines
1916         (will be used by hardware GPU bots which will have local per-bot
1917         expectations for some tests)
1918
1919         * Scripts/webkitpy/common/system/filesystem_mock.py:
1920         * Scripts/webkitpy/layout_tests/port/base.py:
1921         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1922         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1923
1924 2011-04-05  Adam Roben  <aroben@apple.com>
1925
1926         Strip off /results.html from results URLs before trying to load leaks files from them
1927
1928         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
1929         files, rather than pointing to the directory that contains them. This is more convenient for
1930         people browsing build.webkit.org, but confused Leaks Viewer.
1931
1932         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
1933         list don't work
1934
1935         Reviewed by Joseph Pecoraro.
1936
1937         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1938         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
1939
1940 2011-04-05  Carol Szabo  <carol@webkit.org>
1941
1942         Unreviewed.
1943
1944         Updated my info in committers.py
1945
1946         Scripts\webkitpy\common\config\committers.py 
1947
1948 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
1949
1950         Reviewed by Laszlo Gombos.
1951
1952         [Qt] Make WebKitLibraries optional for building QtWebKit
1953         https://bugs.webkit.org/show_bug.cgi?id=57542
1954
1955         * Scripts/build-webkit:
1956
1957 2011-04-05  Chang Shu  <cshu@webkit.org>
1958
1959         Reviewed by Laszlo Gombos.
1960
1961         [Qt] MiniBrowser defaultUrl does not work
1962         https://bugs.webkit.org/show_bug.cgi?id=57021
1963
1964         Match the behavior and coding of MiniBrowser to QtTestBrowser.
1965         * MiniBrowser/qt/main.cpp:
1966         (main):
1967
1968 2011-04-05  Jade Han  <jade.han@nokia.com>
1969
1970         Reviewed by Laszlo Gombos.
1971
1972         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
1973         https://bugs.webkit.org/show_bug.cgi?id=54977
1974
1975         This change is a preparation to enable building webkit2 for Symbian.
1976         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
1977
1978         * Tools.pro:
1979
1980 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1981
1982         Reviewed by Andreas Kling.
1983
1984         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
1985         https://bugs.webkit.org/show_bug.cgi?id=57832
1986
1987         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
1988
1989         * MiniBrowser/qt/UrlLoader.cpp:
1990         (UrlLoader::UrlLoader):
1991
1992 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1993
1994         [Qt] Linux Release minimal build fix after r82919.
1995
1996         * MiniBrowser/qt/BrowserWindow.cpp:
1997         (BrowserWindow::loadURLListFromFile):
1998         * QtTestBrowser/launcherwindow.cpp:
1999         (LauncherWindow::loadURLListFromFile):
2000
2001 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
2002
2003         Reviewed by Andreas Kling.
2004
2005         [Qt] Make URL loader accessible from testbrowser's menus
2006         https://bugs.webkit.org/show_bug.cgi?id=57823
2007
2008         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
2009
2010         * MiniBrowser/qt/BrowserWindow.cpp:
2011         (BrowserWindow::BrowserWindow):
2012         (BrowserWindow::loadURLListFromFile):
2013         (BrowserWindow::~BrowserWindow):
2014         * MiniBrowser/qt/BrowserWindow.h:
2015         * QtTestBrowser/launcherwindow.cpp:
2016         (LauncherWindow::LauncherWindow):
2017         (LauncherWindow::~LauncherWindow):
2018         (LauncherWindow::createChrome):
2019         (LauncherWindow::loadURLListFromFile):
2020         * QtTestBrowser/launcherwindow.h:
2021
2022 2011-04-04  Sam Weinig  <sam@webkit.org>
2023
2024         Reviewed by Brian Weinstein.
2025
2026         Remove duplicate API from WKContext
2027         <rdar://problem/8727879>
2028         https://bugs.webkit.org/show_bug.cgi?id=57815
2029
2030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2031         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
2032         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2033         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
2034
2035 2011-04-04  Tony Chang  <tony@chromium.org>
2036
2037         Reviewed by Ojan Vafai.
2038
2039         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
2040         https://bugs.webkit.org/show_bug.cgi?id=57783
2041
2042         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2043         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2044
2045 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
2046
2047         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
2048         from WebKitBuild.
2049
2050         * Scripts/webkitdirs.pm:
2051
2052 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
2053
2054         Reviewed by Gustavo Noronha Silva.
2055
2056         [GTK] WebGL support
2057         https://bugs.webkit.org/show_bug.cgi?id=31517
2058
2059         Add support to the DRT for turning on WebGL when a layout tests requests it.
2060
2061         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2062         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
2063
2064 2011-04-04  Chang Shu  <cshu@webkit.org>
2065
2066         Reviewed by Darin Adler.
2067
2068         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
2069         https://bugs.webkit.org/show_bug.cgi?id=57572
2070
2071         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2072         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2073         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
2074         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2075
2076 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
2077
2078         Reviewed by Csaba Osztrogonác.
2079
2080         [Qt] DumpRenderTree breaks compilation in some uClibc environments
2081         https://bugs.webkit.org/show_bug.cgi?id=57602
2082
2083         * DumpRenderTree/qt/main.cpp:
2084         (get_backtrace):
2085
2086 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
2087
2088         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
2089
2090         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2091         (LayoutTestController::shadowRoot):
2092
2093 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
2094
2095         Unreviewed, fix exception in rebaseline tool.
2096
2097         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2098
2099 2011-04-02  Beth Dakin  <bdakin@apple.com>
2100
2101         Rubber-stamped by Geoff Garen.
2102
2103         For Dan!
2104         * DumpRenderTree/mac/DumpRenderTree.mm:
2105         (resetWebViewToConsistentStateBeforeTesting):
2106
2107 2011-04-02  Beth Dakin  <bdakin@apple.com>
2108
2109         Rubber-stamped by Geoff Garen.
2110
2111         Need to reset the scale, much like zoom.
2112         * DumpRenderTree/mac/DumpRenderTree.mm:
2113         (resetWebViewToConsistentStateBeforeTesting):
2114
2115 2011-04-02  Sam Weinig  <sam@webkit.org>
2116
2117         Reviewed by Beth Dakin.
2118
2119         https://bugs.webkit.org/show_bug.cgi?id=57605
2120         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
2121         getClientRects()
2122         -and corresponding-
2123         <rdar://problem/9194541>
2124
2125         Add DRT support for the scaleWebView SPI.
2126         * DumpRenderTree/mac/EventSendingController.mm:
2127         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2128         (+[EventSendingController webScriptNameForSelector:]):
2129         (-[EventSendingController scalePageBy:atX:andY:]):
2130         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2131         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2132         (WTR::EventSendingController::scalePageBy):
2133         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2134         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2135         (WTR::InjectedBundlePage::reset):
2136
2137 2011-04-02  Dominic Cooney  <dominicc@google.com>
2138
2139         Reviewed by Martin Robinson.
2140
2141         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
2142         https://bugs.webkit.org/show_bug.cgi?id=57551
2143
2144         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2145         (LayoutTestController::shadowRoot):
2146
2147 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
2148
2149         Reviewed by Eric Seidel.
2150
2151         Remove AbstractStep._run_script and move script names to ports.py
2152         https://bugs.webkit.org/show_bug.cgi?id=57704
2153
2154         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
2155
2156         * Scripts/webkitpy/common/config/ports.py:
2157         * Scripts/webkitpy/tool/commands/download_unittest.py:
2158         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2159         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2160         * Scripts/webkitpy/tool/steps/abstractstep.py:
2161         * Scripts/webkitpy/tool/steps/checkstyle.py:
2162         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2163         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2164         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2165
2166 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
2167
2168         Reviewed by Eric Seidel.
2169
2170         Emulate shebang on Win32
2171         https://bugs.webkit.org/show_bug.cgi?id=55927
2172
2173         Scripts on Windows work only if they are called with the explicit interpreter.
2174         Read the first line of scripts to detect the correct executable.
2175
2176         * Scripts/webkitpy/common/config/ports.py:
2177         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
2178         * Scripts/webkitpy/common/system/executive_unittest.py:
2179
2180 2011-04-01  Adam Barth  <abarth@webkit.org>
2181
2182         Reviewed by Eric Seidel.
2183
2184         apos entities shouldn't show up in ChangeLogs when using webkit-patch
2185         https://bugs.webkit.org/show_bug.cgi?id=57692
2186
2187         Previously, we were using BeautifulSoup to process XML from
2188         bugs.webkit.org, but that's incorrect.  We should be using
2189         BeautifulStoneSoup to process the XML.  We were getting the &apos;
2190         entity wrong because &apos; is an XML entity but not an HTML entity.
2191
2192         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2193         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2194
2195 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2196
2197         Unreviewed, rolling out r82721.
2198         http://trac.webkit.org/changeset/82721
2199         https://bugs.webkit.org/show_bug.cgi?id=57687
2200
2201         This patch introduced assertion failures on the GTK+ bots.
2202         (Requested by mrobinson on #webkit).
2203
2204         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2205         (LayoutTestController::shadowRoot):
2206
2207 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
2208
2209         Unreviewed buildfix.
2210
2211         [Qt][WK2] Build Webkit2 using "-2" option on Qt
2212         https://bugs.webkit.org/show_bug.cgi?id=55074
2213
2214         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
2215         (The isWK2() function removes it from @ARGV, but not from @options.)
2216
2217 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
2218
2219         Reviewed by Csaba Osztrogonác.
2220
2221         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
2222         https://bugs.webkit.org/show_bug.cgi?id=57666
2223
2224         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
2225
2226 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2227
2228         Reviewed by Adam Barth.
2229
2230         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
2231
2232         We apparently never implemented the code to skip tests based on
2233         what was compiled into DRT. Also, change the logic used to skip
2234         platform directories to match what old-run-webkit-tests does: 
2235         skip every test not in a directory in the baseline search path.
2236
2237         https://bugs.webkit.org/show_bug.cgi?id=57662
2238
2239         * Scripts/webkitpy/layout_tests/port/mac.py:
2240         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2241         * Scripts/webkitpy/layout_tests/port/webkit.py:
2242
2243 2011-03-29  Mark Rowe  <mrowe@apple.com>
2244
2245         Reviewed by Jon Honeycutt.
2246
2247         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
2248
2249         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
2250
2251         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2252         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2253         * Scripts/webkitpy/layout_tests/port/mac.py:
2254         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2255
2256 2011-04-01  Chang Shu  <cshu@webkit.org>
2257
2258         Reviewed by Csaba Osztrogonác.
2259
2260         [Qt][WK2] Build Webkit2 using "-2" option on Qt
2261         https://bugs.webkit.org/show_bug.cgi?id=55074
2262
2263         * Scripts/build-webkit:
2264
2265 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2266
2267         Reviewed by Tony Chang.
2268
2269         new-run-webkit-tests: remove spurious port version override in webkit.py
2270         base.py provides a default implementation so this is just
2271         breaking things.
2272
2273         https://bugs.webkit.org/show_bug.cgi?id=57667
2274
2275         * Scripts/webkitpy/layout_tests/port/webkit.py:
2276         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2277
2278 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
2279
2280         Reviewed by Adam Roben.
2281
2282         Make view results on waterfall direct link to results.html
2283         https://bugs.webkit.org/show_bug.cgi?id=57671
2284
2285         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
2286         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
2287
2288 2011-04-01  Sam Weinig  <sam@webkit.org>
2289
2290         Fix windows build.
2291
2292         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2293         (TestWebKitAPI::TEST):
2294         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2295         (TestWebKitAPI::flushMessages):
2296
2297 2011-04-01  Sam Weinig  <sam@webkit.org>
2298
2299         Reviewed by Adam Roben.
2300
2301         Add adoptWK to WKRetainPtr.h
2302         https://bugs.webkit.org/show_bug.cgi?id=57670
2303
2304         * TestWebKitAPI/PlatformUtilities.h:
2305         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2306         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2307         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2308         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2309         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2310         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2311         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2312         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2313         (TestWebKitAPI::createSessionStateContainingFormData):
2314         * WebKitTestRunner/StringFunctions.h:
2315         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
2316
2317 2011-04-01  Sam Weinig  <sam@webkit.org>
2318
2319         Reviewed by Adam Roben.
2320
2321         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
2322
2323         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2324         (WTR::LayoutTestController::shadowRoot):
2325         Make judicious use of adoptWK().
2326
2327 2011-04-01  Sam Weinig  <sam@webkit.org>
2328
2329         Reviewed by Timothy Hatcher.
2330
2331         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
2332
2333         * Scripts/extract-localizable-strings:
2334
2335 2011-04-01  Anders Carlsson  <andersca@apple.com>
2336
2337         Reviewed by Sam Weinig.
2338
2339         Shockwave plug-in doesn't accept mouse events
2340         https://bugs.webkit.org/show_bug.cgi?id=57653
2341         <rdar://problem/8483273>
2342
2343         Add a plug-in test.
2344
2345         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2346         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2347         (PluginTest::indicateTestFailure):
2348         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
2349
2350         (PluginTest::NPN_ConvertPoint):
2351         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2352         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
2353         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2354         Call indicateTestFailure.
2355
2356         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
2357         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
2358         (ConvertPoint::ConvertPoint):
2359         (ConvertPoint::testConvert):
2360         (ConvertPoint::NPP_New):
2361
2362 2011-04-01  Dominic Cooney  <dominicc@google.com>
2363
2364         Reviewed by Martin Robinson.
2365
2366         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
2367         https://bugs.webkit.org/show_bug.cgi?id=57551
2368
2369         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2370         (LayoutTestController::shadowRoot):
2371
2372 2011-04-01  Sam Weinig  <sam@webkit.org>
2373
2374         Reviewed by Anders Carlsson.
2375
2376         WebKitTestRunner needs layoutTestController.shadowRoot
2377         https://bugs.webkit.org/show_bug.cgi?id=57661
2378
2379         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2380         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2381         (WTR::LayoutTestController::shadowRoot):
2382         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2383         Implement layoutTestController.shadowRoot for WebKit2.
2384
2385 2011-04-01  Chang Shu  <cshu@webkit.org>
2386
2387         Reviewed by Darin Adler.
2388
2389         WebKitTestRunner needs layoutTestController.setDatabaseQuota
2390         https://bugs.webkit.org/show_bug.cgi?id=57568
2391
2392         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2393         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2394         (WTR::LayoutTestController::setDatabaseQuota):
2395         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2396
2397 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2398
2399         Reviewed by Tony Chang.
2400
2401         This patch completes the cleanup of
2402         rebaseline-chromium-webkit-tests to work with all of the
2403         variants of a platform (we can now rebaseline gpu- and non-gpu
2404         files at the same time).
2405
2406         When the rebaselining is complete, any lines declared as
2407         REBASELINE in the expectations file that matches a test that was
2408         actually rebaselined will be deleted, even if only one of the
2409         variants was actually rebaselined. This may cause odd problems,
2410         but is better than where we're at today.
2411
2412         This change removes the -g flag and deprecates -w. The -g flag is gone
2413         because GPU baselines are handled just like any other variant.
2414         The -w flag is deprecated because this tool now only works
2415         against the canaries, since that's the only place we have a full
2416         set of bots. It will be trivial to change this to
2417         build.webkit.org if we decide that's where we want them to be.
2418
2419         Also, this patch deletes a lot of cruft that is no longer needed
2420         in the test_expectations code and the port-specific code.
2421
2422         https://bugs.webkit.org/show_bug.cgi?id=55191
2423
2424         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2425         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2426         * Scripts/webkitpy/layout_tests/port/base.py:
2427         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2428         * Scripts/webkitpy/layout_tests/port/chromium.py:
2429         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2430         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2431         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2432         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2433         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2434         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2435         * Scripts/webkitpy/layout_tests/port/mac.py:
2436         * Scripts/webkitpy/layout_tests/port/test.py:
2437         * Scripts/webkitpy/layout_tests/port/webkit.py:
2438         * Scripts/webkitpy/layout_tests/port/win.py:
2439         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2440         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2441
2442 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2443
2444         Reviewed by Adam Barth.
2445
2446         rebaseline-chromium-webkit-tests does not work correctly with
2447         version-specific baselines. This patch updates the tool to use
2448         all of the version-specific bots on the canaries, and will now
2449         attempt to rebaseline all of the versions by default, although
2450         it will not update both GPU and CPU versions.
2451         
2452         Also, it will no longer modify the test_expectations.txt file
2453         *at all*. You will have to manually delete the REBASELINE lines
2454         after running the tool and determining that it did what you
2455         wanted it to do. This should be fixed in a separate bug - see
2456         webkit bug #55191.
2457
2458         https://bugs.webkit.org/show_bug.cgi?id=55608
2459
2460         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2461         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2462         * Scripts/webkitpy/layout_tests/port/chromium.py:
2463         * Scripts/webkitpy/layout_tests/port/test.py:
2464         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2465         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2466
2467 2011-03-31  Tony Chang  <tony@chromium.org>
2468
2469         Reviewed by Ojan Vafai.
2470
2471         [chromium] update the rebaseline tool to know about pngs with checksums
2472         https://bugs.webkit.org/show_bug.cgi?id=57481
2473
2474         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
2475         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2476
2477 2011-04-01  Adam Roben  <aroben@apple.com>
2478
2479         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
2480
2481         Previously, we were getting the revision of the first revision that triggered a build.
2482         Choosing the last revision would have been more accurate. But got_revision is what is used
2483         everywhere else on build.webkit.org, and should work even when there were no changes that
2484         triggered a build (e.g., if someone clicked the Force Build button).
2485
2486         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
2487         recent builds list
2488
2489         Reviewed by Anders Carlsson.
2490
2491         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2492         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
2493         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
2494
2495         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2496         (Array.prototype.first): Added this helper function to return the first element in an array
2497         that matches the given predicate, or null if no such element exists.
2498
2499 2011-03-31  Adam Roben  <aroben@apple.com>
2500
2501         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
2502
2503         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
2504
2505         Reviewed by Darin Adler.
2506
2507         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2508         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
2509         URL on its own line.
2510
2511         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2512         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
2513         progression, and added a new test that uses a short bug URL while I was at it.
2514
2515 2011-04-01  Adam Roben  <aroben@apple.com>
2516
2517         Mark .vcproj/.vsprops/.sln files as being Windows-only
2518
2519         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
2520
2521         Reviewed by Anders Carlsson.
2522
2523         * Scripts/webkitpy/common/config/build.py:
2524         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
2525         directories as Windows-only.
2526
2527         * Scripts/webkitpy/common/config/build_unittest.py:
2528         (ShoulBuildTest): Added test cases for the above.
2529
2530 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
2531
2532         Reviewed by Laszlo Gombos.
2533
2534         [Qt] Build MiniBrowser for Symbian
2535         https://bugs.webkit.org/show_bug.cgi?id=56319
2536
2537         Have MiniBrowser reference it's own copy of useragentlist.txt instead
2538         of copying QtTestBrowser's.
2539         Remove Tools/MiniBrowser/DerivedSources.pro
2540         This reduces complexity in the Tools scripts due to Symbian limitations.
2541
2542         * DerivedSources.pro:
2543         * MiniBrowser/DerivedSources.pro: Removed.
2544         * MiniBrowser/MiniBrowser.qrc:
2545         * MiniBrowser/qt/MiniBrowser.pro:
2546         * Scripts/webkitdirs.pm:
2547
2548 2011-03-31  Chang Shu  <cshu@webkit.org>
2549
2550         Reviewed by Darin Adler.
2551
2552         WebKitTestRunner needs layoutTestController.clearAllDatabases
2553         https://bugs.webkit.org/show_bug.cgi?id=42540
2554
2555         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2556         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2557         (WTR::InjectedBundle::beginTesting):
2558         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2559         (WTR::LayoutTestController::clearAllDatabases):
2560         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2561
2562 2011-03-31  Chang Shu  <cshu@webkit.org>
2563
2564         Reviewed by Darin Adler.
2565
2566         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
2567         https://bugs.webkit.org/show_bug.cgi?id=42692
2568
2569         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2570
2571 2011-03-31  Darin Adler  <darin@apple.com>
2572
2573         Reviewed by Sam Weinig.
2574
2575         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
2576         https://bugs.webkit.org/show_bug.cgi?id=57573
2577
2578         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2579         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
2580         Removed fake definitions of keyDown and contextClick.
2581
2582         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2583         (WTR::operator==): Added. So we can compare two WKPoint structs.
2584         (WTR::parseModifier): Added.
2585         (WTR::parseModifierArray): Added.
2586         (WTR::EventSendingController::EventSendingController): Initialize the
2587         new data members.
2588         (WTR::EventSendingController::mouseDown): Added. Calls
2589         WKBundlePageSimulateMouseDown.
2590         (WTR::EventSendingController::mouseUp): Added. Calls
2591         WKBundlePageSimulateMouseUp.
2592         (WTR::EventSendingController::mouseMoveTo): Added. Calls
2593         WKBundlePageSimulateMouseMotion.
2594         (WTR::EventSendingController::leapForward): Added.
2595         (WTR::EventSendingController::updateClickCount): Added. Used by the
2596         mouseDown/Up functions to create a click count.
2597
2598         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
2599         for the changes above.
2600
2601 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
2602
2603         Reviewed by Martin Robinson.
2604
2605         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
2606         https://bugs.webkit.org/show_bug.cgi?id=57362
2607
2608         Do not generate DRT output if willSendRequestReturnsNull is set.
2609
2610         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2611         (willSendRequestCallback):
2612
2613 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
2614
2615         Reviewed by Martin Robinson.
2616
2617         Implement MiniBrowser for Gtk port.
2618         https://bugs.webkit.org/show_bug.cgi?id=48512
2619
2620         Initial implementation of the Gtk MiniBrowser.
2621
2622         * MiniBrowser/gtk/GNUmakefile.am: Added.
2623         * MiniBrowser/gtk/main.c: Added.
2624         (activateUriEntryCallback):
2625         (destroyCallback):
2626         (goBackCallback):
2627         (goForwardCallback):
2628         (createToolbar):
2629         (createWebView):
2630         (createWindow):
2631         (argumentToURL):
2632         (main):
2633
2634 2011-03-30  Dominic Cooney  <dominicc@google.com>
2635
2636         Reviewed by Dimitri Glazkov.
2637
2638         Adds layoutTestController.shadowRoot accessor to Mac DRT.
2639         https://bugs.webkit.org/show_bug.cgi?id=57415
2640
2641         * DumpRenderTree/LayoutTestController.cpp:
2642         (shadowRootCallback):
2643         (LayoutTestController::staticFunctions):
2644         * DumpRenderTree/LayoutTestController.h:
2645         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2646         (LayoutTestController::shadowRoot):
2647         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2648         (LayoutTestController::shadowRoot):
2649
2650 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
2651
2652         Reviewed by Chris Marrin.
2653
2654         Update fast/canvas tests to avoid dumping the render tree when possible
2655         https://bugs.webkit.org/show_bug.cgi?id=57493
2656
2657         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
2658           accelerated drawing and accelerated drawing for canvas
2659
2660 2011-03-30  Adam Roben  <aroben@apple.com>
2661
2662         Stop ignoring leaks in CGGradientCreateWithColorStops
2663
2664         Fixes <rdar://problem/7888547>.
2665
2666         Rubber-stamped by John Sullivan.
2667
2668         * Scripts/old-run-webkit-tests:
2669         (countAndPrintLeaks): Removed some code to ignore those leaks.
2670
2671 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
2672
2673         Reviewed by Alexey Proskuryakov.
2674
2675         Add some dynamic annotations to JavaScriptCore/wtf
2676         https://bugs.webkit.org/show_bug.cgi?id=53747
2677
2678         By using these annotations we can improve the precision of finding
2679         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
2680         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
2681
2682         These files don't add new functionality, so don't need extra tests.
2683
2684         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
2685
2686 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2687
2688         Reviewed by Adam Roben.
2689
2690         Share most vsprops between Release and Production builds in releaseproduction.vsprops
2691         https://bugs.webkit.org/show_bug.cgi?id=57508
2692
2693         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
2694         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
2695         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
2696         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
2697         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
2698         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
2699         * DumpRenderTree/win/ImageDiffProduction.vsprops:
2700         * DumpRenderTree/win/ImageDiffRelease.vsprops:
2701         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
2702         * FindSafari/FindSafariProduction.vsprops:
2703         * FindSafari/FindSafariRelease.vsprops:
2704         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
2705         * FindSafari/FindSafariReleasePGO.vsprops:
2706         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
2707         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
2708         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
2709         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
2710         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
2711         * WebKitAPITest/WebKitAPITestProduction.vsprops:
2712         * WebKitAPITest/WebKitAPITestRelease.vsprops:
2713         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
2714         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
2715         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
2716         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
2717         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
2718         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
2719         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
2720         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
2721         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
2722         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
2723         * WinLauncher/WinLauncherProduction.vsprops:
2724         * WinLauncher/WinLauncherRelease.vsprops:
2725         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
2726         * record-memory-win/record-memory-winProduction.vsprops:
2727         * record-memory-win/record-memory-winRelease.vsprops:
2728         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
2729
2730 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2731
2732         Reviewed by Adam Roben.
2733
2734         Update Windows production build logic for new production configurations
2735         https://bugs.webkit.org/show_bug.cgi?id=57494
2736
2737         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
2738         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
2739         * DumpRenderTree/win/ImageDiffProduction.vsprops:
2740         * FindSafari/FindSafariProduction.vsprops:
2741         * FindSafari/FindSafariReleasePGO.vsprops:
2742         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
2743         * WebKitAPITest/WebKitAPITestProduction.vsprops:
2744         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
2745         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
2746         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
2747         * WinLauncher/WinLauncherProduction.vsprops:
2748         * record-memory-win/record-memory-winProduction.vsprops:
2749
2750 2011-03-30  Robert Hogan  <robert@webkit.org>
2751
2752         Reviewed by Antonio Gomes.
2753
2754         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
2755         Unskip http/tests/navigation/go-back-to-error-page.html
2756
2757         Also add the location of DumpRenderTreeSupportQt.h
2758         to DRT's include paths.
2759
2760         https://bugs.webkit.org/show_bug.cgi?id=52614
2761
2762         * DumpRenderTree/qt/DumpRenderTree.pro:
2763         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2764         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2765         * DumpRenderTree/qt/GCControllerQt.cpp:
2766         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2767         (LayoutTestController::queueLoadHTMLString):
2768         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2769         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2770         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2771         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2772         (LoadAlternateHTMLStringItem::invoke):
2773         * DumpRenderTree/qt/WorkQueueItemQt.h:
2774         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2775         * QtTestBrowser/QtTestBrowser.pro:
2776         * QtTestBrowser/launcherwindow.h:
2777
2778 2011-03-30  Adam Barth  <abarth@webkit.org>
2779
2780         Reviewed by Adam Roben.
2781
2782         SheriffBot rollouts take too long
2783         https://bugs.webkit.org/show_bug.cgi?id=57498
2784
2785         We used to build before landing rollouts via the commit-queue to
2786         prevent further breakage, but now that our individual commit-queue
2787         machines are slower, building takes too long.  I can't remember the
2788         last time a rollout broke compile.  It seems like just landing the
2789         patch is the better trade-off.
2790
2791         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2792         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2793
2794 2011-03-30  Adam Barth  <abarth@webkit.org>
2795
2796         Remove platform/chromium-mac-snowleopard
2797         https://bugs.webkit.org/show_bug.cgi?id=57486
2798
2799         This directory no longer exists, so we can remove it from the fallback
2800         chain.
2801
2802         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2803
2804 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2805
2806         Reviewed by Adam Roben.
2807
2808         Rename Windows configuration Release_LTCG to Production for clarity
2809         https://bugs.webkit.org/show_bug.cgi?id=57465
2810
2811         * DumpRenderTree/DumpRenderTree.sln:
2812         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2813         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
2814         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
2815         * DumpRenderTree/win/DumpRenderTree.vcproj:
2816         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
2817         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
2818         * DumpRenderTree/win/ImageDiff.vcproj:
2819         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
2820         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
2821         * FindSafari/FindSafari.vcproj:
2822         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
2823         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
2824         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
2825         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
2826         * MiniBrowser/MiniBrowser.vcproj:
2827         * Scripts/webkitdirs.pm:
2828         * TestWebKitAPI/win/TestWebKitAPI.sln:
2829         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2830         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2831         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2832         * WebKitAPITest/WebKitAPITest.vcproj:
2833         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
2834         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
2835         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2836         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
2837         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
2838         * WebKitTestRunner/WebKitTestRunner.sln:
2839         * WebKitTestRunner/win/InjectedBundle.vcproj:
2840         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
2841         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
2842         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
2843         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2844         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
2845         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
2846         * WinLauncher/WinLauncher.vcproj:
2847         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
2848         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
2849         * record-memory-win/record-memory-win.vcproj:
2850         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
2851         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
2852
2853 2011-03-30  MORITA Hajime  <morrita@google.com>
2854
2855         Reviewed by Dimitri Glazkov.
2856
2857         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
2858         https://bugs.webkit.org/show_bug.cgi?id=56573
2859
2860         Added LayoutTestController.shadowRoot() to Chromium DRT.
2861
2862         * DumpRenderTree/chromium/LayoutTestController.cpp:
2863         (LayoutTestController::LayoutTestController):
2864         (LayoutTestController::shadowRoot):
2865         * DumpRenderTree/chromium/LayoutTestController.h:
2866
2867 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
2868
2869         Reviewed by Kent Tamura.
2870
2871         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
2872         https://bugs.webkit.org/show_bug.cgi?id=57430
2873
2874         * DumpRenderTree/chromium/LayoutTestController.cpp:
2875         (LayoutTestController::LayoutTestController):
2876         (LayoutTestController::setPluginsEnabled):
2877         * DumpRenderTree/chromium/LayoutTestController.h:
2878
2879 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2880
2881         Reviewed by Adam Barth.
2882
2883         make webkit-patch upload respect -d
2884         https://bugs.webkit.org/show_bug.cgi?id=57425
2885
2886         * Scripts/webkitpy/common/checkout/scm.py:
2887         * Scripts/webkitpy/tool/steps/commit.py:
2888
2889 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2890
2891         Reviewed by Adam Barth.
2892
2893         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
2894         https://bugs.webkit.org/show_bug.cgi?id=57429
2895
2896         * Scripts/webkitpy/common/checkout/scm.py:
2897
2898 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2899
2900         Unreviewed, rolling out r82383.
2901         http://trac.webkit.org/changeset/82383
2902         https://bugs.webkit.org/show_bug.cgi?id=57417
2903
2904         "nrwt isn't shutting down cleanly" (Requested by dpranke on
2905         #webkit).
2906
2907         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2908         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2909         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2910
2911 2011-03-29  Kent Tamura  <tkent@chromium.org>
2912
2913         Reviewed by Dimitri Glazkov.
2914
2915         Make validation message bubble testable
2916         https://bugs.webkit.org/show_bug.cgi?id=57290
2917
2918         * DumpRenderTree/mac/DumpRenderTree.mm:
2919         (createWebViewAndOffscreenWindow): Change a setting so that validation
2920           bubbles isn't hidden automatically.
2921
2922 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
2923
2924         Reviewed by Ojan Vafai.
2925
2926         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
2927
2928         It's a bit unclear whether multiple threads or multiple
2929         processes will be a better model on windows. This change will
2930         test threads for now while we're still working out the bugs in
2931         multiple-processes.
2932
2933         https://bugs.webkit.org/show_bug.cgi?id=57410
2934
2935         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2936         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2937         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2938
2939 2011-03-29  David Levin  <levin@chromium.org>
2940
2941         Reviewed by Shinichiro Hamaji.
2942
2943         check-webkit-style confused by two ChangeLog entries in a row from same user
2944         https://bugs.webkit.org/show_bug.cgi?id=57250
2945
2946         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
2947         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
2948         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
2949           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
2950           checking more than that would be very messey.
2951         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
2952         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
2953
2954 2011-03-29  Kent Tamura  <tkent@chromium.org>
2955
2956         Reviewed by Dimitri Glazkov.
2957
2958         [Mac] Enable interactive-validation tests on Mac DRT
2959         https://bugs.webkit.org/show_bug.cgi?id=57308
2960
2961         * DumpRenderTree/mac/DumpRenderTree.mm:
2962         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
2963
2964 2011-03-29  Chang Shu  <cshu@webkit.org>
2965
2966         Reviewed by Kenneth Rohde Christiansen.
2967
2968         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
2969         https://bugs.webkit.org/show_bug.cgi?id=42692
2970
2971         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2972         (WTR::InjectedBundle::beginTesting):
2973         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2974         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
2975         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2976
2977 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
2978
2979         Reviewed by Xan Lopez.
2980
2981         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
2982         https://bugs.webkit.org/show_bug.cgi?id=57067
2983
2984         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
2985         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
2986         update DRT and pixel results as hundreds of results will need to be updated.
2987
2988         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2989         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
2990         by overriding the theme RC/CSS files.
2991
2992 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
2993
2994         Reviewed by Adam Roben.
2995
2996         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
2997         https://bugs.webkit.org/show_bug.cgi?id=57394
2998
2999         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
3000         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
3001         the IDE. To avoid this, add a separate vsprops file for each project configuration that
3002         contains the required inherited property sheets.
3003
3004         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3005         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
3006         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
3007         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
3008         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
3009         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
3010         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
3011         * DumpRenderTree/win/DumpRenderTree.vcproj:
3012         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
3013         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
3014         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
3015         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
3016         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
3017         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
3018         * DumpRenderTree/win/ImageDiff.vcproj:
3019         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
3020         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
3021         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
3022         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
3023         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
3024         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
3025         * FindSafari/FindSafari.vcproj:
3026         * FindSafari/FindSafariDebug.vsprops: Added.
3027         * FindSafari/FindSafariDebugAll.vsprops: Added.
3028         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
3029         * FindSafari/FindSafariRelease.vsprops: Added.
3030         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
3031         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
3032         * FindSafari/FindSafariReleasePGO.vsprops: Added.
3033         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
3034         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
3035         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
3036         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
3037         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
3038         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
3039         * MiniBrowser/MiniBrowser.vcproj:
3040         * WebKitAPITest/WebKitAPITest.vcproj:
3041         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
3042         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
3043         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
3044         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
3045         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
3046         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
3047         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3048         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
3049         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
3050         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
3051         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
3052         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
3053         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
3054         * WebKitTestRunner/win/InjectedBundle.vcproj:
3055         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
3056         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
3057         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
3058         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
3059         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
3060         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
3061         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3062         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
3063         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
3064         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
3065         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
3066         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
3067         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
3068         * WinLauncher/WinLauncher.vcproj:
3069         * WinLauncher/WinLauncherDebug.vsprops: Added.
3070         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
3071         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
3072         * WinLauncher/WinLauncherRelease.vsprops: Added.
3073         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
3074         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
3075         * record-memory-win/record-memory-win.vcproj:
3076         * record-memory-win/record-memory-winDebug.vsprops: Added.
3077         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
3078         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
3079         * record-memory-win/record-memory-winRelease.vsprops: Added.
3080         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
3081         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
3082
3083 2011-03-29  Adam Barth  <abarth@webkit.org>
3084
3085         Reviewed by Darin Adler.
3086
3087         test_runner2.py can crash due to undefined variable
3088         https://bugs.webkit.org/show_bug.cgi?id=57356
3089
3090         Replace reference to undefined variable with a variable that's actually
3091         defined.  AFAICT, there's no way to test this code.
3092
3093         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3094
3095 2011-03-29  Tony Chang  <tony@chromium.org>
3096
3097         Reviewed by Eric Seidel.
3098
3099         cleanup rebaseline-chromium-webkit-tests
3100         https://bugs.webkit.org/show_bug.cgi?id=57375
3101
3102         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3103             - Split _extract_and_add_new_baselines into 3 functions
3104             - Reduce the amount of line wrapping (the file already has lines
3105               over 80 col, so may as well try to make the file consistent)
3106             - Remove unnecessary ()s
3107
3108 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
3109
3110         Reviewed by Adam Roben.
3111
3112         Make WinCairo a core builder.
3113         https://bugs.webkit.org/show_bug.cgi?id=57373
3114
3115         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
3116         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
3117
3118 2011-03-29  Timothy Hatcher  <timothy@apple.com>
3119
3120         Update update-webkit-localizable-strings to understand that WebKit and
3121         WebKit2 strings go in WebCore.
3122
3123         Also make extract-localizable-strings optionally use an exclude file. No individual
3124         warnings are produced about unlocalized strings when there is no exclude file. This
3125         is needed for WebCore, since there are too many bare strings.
3126
3127         https://webkit.org/b/57354
3128
3129         Reviewed by Sam Weinig.
3130
3131         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
3132         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
3133
3134 2011-03-29  Darin Adler  <darin@apple.com>
3135
3136         Reviewed by Adam Roben.
3137
3138         WebKit2 bundle page needs to offer generated file hooks
3139         https://bugs.webkit.org/show_bug.cgi?id=57279
3140
3141         (Land missing part of the original patch after r82289.)
3142
3143         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3144         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
3145
3146 2011-03-29  Tony Chang  <tony@chromium.org>
3147
3148         Reviewed by Ojan Vafai.
3149
3150         [chromium] NRWT should be able to read checksums from png comments
3151         https://bugs.webkit.org/show_bug.cgi?id=57280
3152
3153         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
3154             from a file.
3155         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
3156         * Scripts/webkitpy/common/system/filesystem_mock.py:
3157         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
3158             if the -checksum.txt file doesn't exist, try looking in the png.
3159         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3160         * Scripts/webkitpy/layout_tests/port/test.py:
3161         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
3162             2k for a png comment with the checksum
3163         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
3164
3165 2011-03-29  Philippe Normand  <pnormand@igalia.com>
3166
3167         Rubber-stamped by Gustavo Noronha Silva.
3168
3169         [GTK] http/tests/uri/username-with-no-hostname.html fails
3170         https://bugs.webkit.org/show_bug.cgi?id=57325
3171
3172         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3173         (willSendRequestCallback): URI host value check done case-insensitively.
3174
3175 2011-03-29  Philippe Normand  <pnormand@igalia.com>
3176
3177         Reviewed by Martin Robinson.
3178
3179         [GTK] http/tests/uri/username-with-no-hostname.html fails
3180         https://bugs.webkit.org/show_bug.cgi?id=57325
3181
3182         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3183         (willSendRequestCallback): Check URI before submitting the request
3184         to WebCore.
3185
3186 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
3187
3188         Reviewed by Ojan Vafai.
3189
3190         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
3191         https://bugs.webkit.org/show_bug.cgi?id=57303
3192
3193         * DumpRenderTree/chromium/EventSender.cpp:
3194         (EventSender::doDragDrop):
3195         (EventSender::beginDragWithFiles):
3196
3197 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
3198
3199         Reviewed by Andreas Kling.
3200
3201         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
3202         https://bugs.webkit.org/show_bug.cgi?id=57314
3203
3204         Provide possibility to print loaded urls to the standard output.
3205
3206         * MiniBrowser/qt/BrowserWindow.cpp:
3207         (BrowserWindow::BrowserWindow):
3208         (BrowserWindow::printURL):
3209         * MiniBrowser/qt/BrowserWindow.h:
3210         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3211         (MiniBrowserApplication::handleUserOptions):
3212         * MiniBrowser/qt/MiniBrowserApplication.h:
3213         (WindowOptions::WindowOptions):
3214         * QtTestBrowser/launcherwindow.cpp:
3215         (LauncherWindow::initializeView):
3216         (LauncherWindow::printURL):
3217         (LauncherWindow::cloneWindow):
3218         * QtTestBrowser/launcherwindow.h:
3219         (WindowOptions::WindowOptions):
3220         * QtTestBrowser/main.cpp:
3221         (LauncherApplication::handleUserOptions):
3222
3223 2011-03-29  Gabor Loki  <loki@webkit.org>
3224
3225         Rubber-stamped by Csaba Osztrogonác.
3226
3227         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
3228         https://bugs.webkit.org/show_bug.cgi?id=56918
3229
3230         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
3231
3232 2011-03-28  Gabor Loki  <loki@webkit.org>
3233
3234         Reviewed by Csaba Osztrogonác.
3235
3236         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
3237         https://bugs.webkit.org/show_bug.cgi?id=56918
3238
3239         * Scripts/build-jsc:
3240         * Scripts/webkitdirs.pm:
3241
3242 2011-03-28  Andrew Foster  <andrewf@chromium.org>
3243
3244         Reviewed by Ojan Vafai.
3245
3246         webkit-patch should be more intelligent about whether a bug applies to a patch
3247         Create a new function, parse_bug_id_from_changelog() which determines
3248         that a bug is related to a patch by parsing the output generated from
3249         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
3250         the description of a patch.
3251         https://bugs.webkit.org/show_bug.cgi?id=56989
3252
3253         * Scripts/webkitpy/common/checkout/api.py:
3254         * Scripts/webkitpy/common/checkout/changelog.py:
3255         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
3256         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3257         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3258         * Scripts/webkitpy/style/checkers/changelog.py:
3259         * Scripts/webkitpy/tool/commands/upload.py:
3260
3261 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
3262
3263         Revert accidentally commited change.
3264
3265         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3266         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3267
3268 2011-03-28  Tony Chang  <tony@chromium.org>
3269
3270         Reviewed by Adam Barth.
3271
3272         [chromium] have DRT write the png checksum into a png comment
3273         https://bugs.webkit.org/show_bug.cgi?id=57255
3274
3275         * DumpRenderTree/chromium/TestShell.cpp:
3276         (TestShell::dumpImage):
3277
3278 2011-03-28  Adele Peterson  <adele@apple.com>
3279
3280         Removing Qt stub, since it doesn't use the same header as the others.
3281
3282         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3283
3284 2011-03-28  Adele Peterson  <adele@apple.com>
3285
3286         Added a few more stubs.
3287
3288         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3289         (LayoutTestController::hasGrammarMarker):
3290         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3291         (LayoutTestController::hasGrammarMarker):
3292         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3293         (LayoutTestController::hasGrammarMarker):
3294
3295 2011-03-28  Adele Peterson  <adele@apple.com>
3296
3297         Build fix.
3298
3299         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3300         (LayoutTestController::hasGrammarMarker):
3301
3302 2011-03-28  Adele Peterson  <adele@apple.com>
3303
3304         Reviewed by Eric Seidel.
3305
3306         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
3307         https://bugs.webkit.org/show_bug.cgi?id=57173
3308
3309         * DumpRenderTree/LayoutTestController.cpp:
3310         (hasGrammarMarkerCallback): Added.
3311         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
3312         * DumpRenderTree/LayoutTestController.h:
3313         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
3314         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
3315
3316 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3317
3318         Reviewed by Benjamin Poulain.
3319
3320         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
3321         https://bugs.webkit.org/show_bug.cgi?id=57087
3322
3323         Trivial typo fix after r82082.
3324
3325         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3326         (WTR::activateFonts):
3327
3328 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
3329
3330         Reviewed by Andreas Kling.
3331
3332         Add myself to the committers list.
3333
3334         * Scripts/webkitpy/common/config/committers.py:
3335
3336 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
3337
3338         Reviewed by Sam Weinig.
3339
3340         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
3341         to link against WebKit.framework for now.
3342
3343         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3344
3345 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
3346
3347         Reviewed by Andreas Kling.
3348
3349         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
3350         https://bugs.webkit.org/show_bug.cgi?id=57087
3351
3352         Disable QT_ASCII_CAST_WARNINGS for applications.
3353
3354         * DumpRenderTree/qt/DumpRenderTree.pro:
3355         * DumpRenderTree/qt/ImageDiff.pro:
3356         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3357         * MiniBrowser/qt/MiniBrowser.pro:
3358         * QtTestBrowser/QtTestBrowser.pro:
3359         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3360
3361 2011-03-28  Andreas Kling  <kling@webkit.org>
3362
3363         Reviewed by Kenneth Rohde Christiansen.
3364
3365         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
3366         https://bugs.webkit.org/show_bug.cgi?id=57224
3367
3368         * QtTestBrowser/mainwindow.cpp:
3369         (MainWindow::buildUI):
3370         (MainWindow::onTitleChanged):
3371         * QtTestBrowser/mainwindow.h:
3372
3373 2011-03-27  Jer Noble  <jer.noble@apple.com>
3374
3375         Reviewed by Maciej Stachowiak.
3376
3377         Full Screen: disable keyboard access by default
3378         https://bugs.webkit.org/show_bug.cgi?id=56684
3379
3380         Accept the withKeyboard parameter to supportsFullScreenForElement.
3381
3382         * DumpRenderTree/mac/UIDelegate.mm:
3383         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
3384
3385 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
3386
3387         Reviewed by David Levin.
3388
3389         check-webkit-style should check ChangeLog for a valid bug number
3390         https://bugs.webkit.org/show_bug.cgi?id=57184
3391
3392         * Scripts/webkitpy/style/checker.py:
3393         * Scripts/webkitpy/style/checker_unittest.py:
3394         * Scripts/webkitpy/style/checkers/changelog.py: Added.
3395         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
3396
3397 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
3398
3399         Reviewed by Andreas Kling.
3400
3401         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
3402         https://bugs.webkit.org/show_bug.cgi?id=57087
3403
3404         Use explicit conversion for string to avoid depending on the default codec
3405         installed by the user code.
3406
3407         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3408         (WTR::activateFonts):
3409
3410 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
3411
3412         Revert inadvertantly committed changes.
3413
3414         * Scripts/old-run-webkit-tests:
3415         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3416
3417 2011-03-26  Andreas Kling  <kling@webkit.org>
3418
3419         Reviewed by Kenneth Rohde Christiansen.
3420
3421         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
3422         https://bugs.webkit.org/show_bug.cgi?id=57162
3423
3424         * QtTestBrowser/QtTestBrowser.qrc:
3425         * QtTestBrowser/favicon.png: Added.
3426         * QtTestBrowser/locationedit.cpp:
3427         (defaultPageIcon):
3428         (LocationEdit::LocationEdit):
3429         (LocationEdit::setPageIcon):
3430         (LocationEdit::resizeEvent):
3431         (LocationEdit::updateInternalGeometry):
3432         * QtTestBrowser/locationedit.h:
3433         * QtTestBrowser/mainwindow.cpp:
3434         (MainWindow::buildUI):
3435         (MainWindow::onIconChanged):
3436         (MainWindow::onLoadStarted):
3437         * QtTestBrowser/mainwindow.h:
3438
3439 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
3440
3441         Reviewed by Xan Lopez.
3442
3443         [GTK] Force DumpRenderTree to use 96 DPI
3444         https://bugs.webkit.org/show_bug.cgi?id=56866
3445
3446         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
3447         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
3448
3449         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3450         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
3451         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
3452         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
3453
3454 2011-03-25  Andy Estes  <aestes@apple.com>
3455
3456         Reviewed by Adele Peterson.
3457
3458         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
3459         https://bugs.webkit.org/show_bug.cgi?id=49016
3460
3461         TestNetscapePlugIn needs to register support for an image MIME type so
3462         we can test that the embed tag prefers plug-ins to render image MIME
3463         types.
3464
3465         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
3466         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3467         (NP_GetMIMEDescription): Ditto.
3468         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
3469
3470 2011-03-25  Jessie Berlin  <jberlin@apple.com>
3471
3472         Reviewed by Sam Weinig.
3473
3474         WebKit2: Need to be able to set and get the Cookie Storage Policy.
3475         https://bugs.webkit.org/show_bug.cgi?id=50780
3476
3477         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
3478
3479         The test is named "CookieManager" so that we can eventually exercise more of the
3480         CookieManager functionality in the test.
3481
3482         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
3483         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
3484         Assert that the policy returned is equal to the policy set in
3485         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
3486         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
3487         Set the policy to something different than the user's policy and get the policy again.
3488         (TestWebKitAPI::didFinishLoadForFrame):
3489         Get the user's policy so that it can be restored at the end of the test.
3490         (TestWebKitAPI::TEST):
3491         Load about:blank so that the Web Process gets instatiated (needed to get the
3492         CookieManager).
3493
3494         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3495         Add CookieManager.cpp.
3496
3497 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
3498
3499         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
3500
3501         * wx/build/settings.py:
3502
3503 2011-03-24  Ilya Sherman  <isherman@chromium.org>
3504
3505         Reviewed by Adam Roben.
3506
3507         Implement layoutTestController.setAutoFilled in DRT on Windows
3508         https://bugs.webkit.org/show_bug.cgi?id=56828
3509
3510         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3511         (LayoutTestController::setAutofilled): Implemented.
3512
3513 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
3514
3515         Unreviewed build correction.
3516
3517         Correct vsprops file for Debug variant of the CFLite build.
3518         Disable a CFNETWORK-specific test when building for CFLite.
3519
3520         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
3521         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3522
3523 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
3524
3525         Reviewed by Adam Barth.
3526
3527         fix regressions introduced in 81908 - there were a couple of
3528         code paths that only fired under python 2.5 that I missed.
3529
3530         Also change a couple of 'python' references to sys.executable
3531         in order to handle runing test-webkitpy with a binary other than
3532         something called 'python'.
3533
3534         https://bugs.webkit.org/show_bug.cgi?id=57063
3535
3536         * Scripts/webkitpy/layout_tests/port/mac.py:
3537         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3538         * Scripts/webkitpy/test/cat.py:
3539         * Scripts/webkitpy/test/echo.py:
3540
3541 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
3542
3543         Unreviewed build correction.
3544
3545         Add a stub implementation of the TestInvocation dumping logic.
3546         Update project files to reflect new file.
3547
3548         * WebKitTestRunner/cairo: Added.
3549         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
3550         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3551         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3552
3553 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
3554
3555         Reviewed by Tony Chang.
3556
3557         new-run-webkit-tests: clean up worker model defaults. This
3558         changes the default behavior to 'threads' instead of
3559         'old-threads', and clarifies that chromium-win-* and
3560         chromium-mac-leopard are exceptions.
3561
3562         https://bugs.webkit.org/show_bug.cgi?id=56971
3563
3564         * Scripts/webkitpy/layout_tests/port/base.py:
3565         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3566         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3567         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3568         * Scripts/webkitpy/layout_tests/port/test.py:
3569         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3570
3571 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
3572
3573         Reviewed by Darin Adler.
3574
3575         Media Stream API: fix the order of the options in build-webkit.
3576         https://bugs.webkit.org/show_bug.cgi?id=56949
3577
3578         Fix the order of the options in build-webkit.
3579
3580         * Scripts/build-webkit:
3581
3582 2011-03-23  Adam Klein  <adamk@chromium.org>
3583
3584         Reviewed by Mihai Parparita.
3585
3586         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
3587         https://bugs.webkit.org/show_bug.cgi?id=56884
3588
3589         This option will be utilized by Chromium's ui_tests to allow
3590         referencing js-test-resources from a layout test over HTTP.
3591
3592         * Scripts/new-run-webkit-httpd:
3593         Added --layout_tests_dir option.
3594         * Scripts/webkitpy/layout_tests/port/http_server.py:
3595         Plumbed through as layout_tests_dir param.
3596
3597 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
3598
3599         Reviewed by Mihai Parparita.
3600
3601         new-run-webkit-tests: run tests in ascending alphabetical order per
3602         dir. This is a second attempt at the fix; the first attempt, in 
3603         r81597, broke the behavior on the old-inline and old-threads
3604         worker models.
3605
3606         https://bugs.webkit.org/show_bug.cgi?id=56760
3607
3608         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3609         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3610         * Scripts/webkitpy/layout_tests/port/test.py:
3611         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3612
3613 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
3614
3615         Reviewed by Martin Robinson.
3616
3617         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
3618         https://bugs.webkit.org/show_bug.cgi?id=56953
3619
3620         Print the string for the detail of 'property-change' signal.
3621
3622         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
3623         (axObjectEventListener): Print the detail string.
3624
3625 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
3626
3627         Reviewed by Pavel Feldman.
3628
3629         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
3630         https://bugs.webkit.org/show_bug.cgi?id=56843
3631
3632         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3633         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3634
3635 2011-03-22  Eric Seidel  <eric@webkit.org>
3636
3637         Reviewed by Adam Barth.
3638
3639         Teach update-webkit about gyp
3640         https://bugs.webkit.org/show_bug.cgi?id=56881
3641
3642         This makes it possible for someone who builds from Xcode
3643         to just run update-webkit --gyp and have the project files
3644         generated after update automatically.
3645
3646         I also added a stand-alone "generate-project-files" script
3647         wrapping Source/gyp/configure.  This makes running gyp simpler
3648         since most people will not have gyp or Source/gyp in their path.
3649
3650         * Scripts/build-webkit:
3651         * Scripts/generate-project-files: Added.
3652         * Scripts/update-webkit:
3653
3654 2011-03-22  Anton D'Auria  <adauria@apple.com>
3655
3656         Reviewed by Alexey Proskuryakov.
3657
3658         Add +[WebApplicationCache getOriginsWithCache]
3659         https://bugs.webkit.org/show_bug.cgi?id=56722
3660
3661         * DumpRenderTree/LayoutTestController.cpp:
3662         (originsWithApplicationCacheCallback):
3663         (LayoutTestController::staticFunctions):
3664         * DumpRenderTree/LayoutTestController.h:
3665         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
3666         (LayoutTestController::originsWithApplicationCache):
3667         * DumpRenderTree/chromium/LayoutTestController.h:
3668         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
3669         (LayoutTestController::originsWithApplicationCache):
3670         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
3671         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
3672         (LayoutTestController::originsWithApplicationCache):
3673         (LayoutTestController::originsWithLocalStorage):
3674         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
3675         (LayoutTestController::originsWithApplicationCache):
3676         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3677         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
3678         (LayoutTestController::originsWithApplicationCache):
3679         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
3680         (LayoutTestController::originsWithApplicationCache):
3681
3682 2011-03-22  Eric Seidel  <eric@webkit.org>
3683
3684         Reviewed by Adam Barth.
3685
3686         Add support to build-webkit for building with gyp-generated project files
3687         https://bugs.webkit.org/show_bug.cgi?id=56877
3688
3689         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
3690         Eventually we'll want to support gyp-generated projects in a more general manner.
3691
3692         * Scripts/build-webkit:
3693
3694 2011-03-22  David Kilzer  <ddkilzer@apple.com>
3695
3696         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
3697
3698         Reviewed by Joseph Pecoraro.
3699
3700         * Scripts/build-webkit: Updated usage statement to include
3701         --dsym.
3702         * Scripts/webkitdirs.pm: Added $generateDsym variable.
3703         (generateDsym): Added. Call determineGenerateDsym() and
3704         return $generateDsym.
3705         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
3706         $generateDsym.
3707         (argumentsForXcode): Added.  Returns additional arguments for
3708         xcodebuild based on command-line switches.
3709         (XcodeOptions): Updated to include argumentsForXcode() in the
3710         array returned.
3711
3712 2011-03-22  Adam Roben  <aroben@apple.com>
3713
3714         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
3715
3716         These bots are consistently green again.
3717
3718         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
3719         core builders
3720
3721         Rubber-stamped by Antti Koivisto.
3722
3723         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3724         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
3725
3726         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3727         (BuildBotTest.test_builder_name_regexps): Updated expectations.
3728
3729 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
3730
3731         Unreviewed, rolling out r81597.
3732         http://trac.webkit.org/changeset/81597
3733         https://bugs.webkit.org/show_bug.cgi?id=56801
3734
3735         Change results in lots of unexpected flaky on the dashboard.
3736         (Requested by pfeldman on #webkit).
3737
3738         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3739         * Scripts/webkitpy/layout_tests/port/test.py:
3740         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3741
3742 2011-03-21  Sam Weinig  <sam@webkit.org>
3743
3744         Fix failing tests on the WebKit2 bots.
3745
3746         * WebKitTestRunner/TestController.cpp:
3747         (WTR::TestController::resetStateToConsistentValues):
3748
3749 2011-03-21  Daniel Sievers  <sievers@google.com>
3750
3751         Reviewed by Simon Fraser.
3752
3753         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
3754         https://bugs.webkit.org/show_bug.cgi?id=56139
3755
3756         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3757         (main):
3758         * DumpRenderTree/chromium/LayoutTestController.cpp:
3759         (LayoutTestController::LayoutTestController):
3760         (LayoutTestController::layerTreeAsText):
3761         * DumpRenderTree/chromium/LayoutTestController.h:
3762         (LayoutTestController::setShowDebugLayerTree):
3763         * DumpRenderTree/chromium/TestShell.cpp:
3764         (TestShell::runFileTest):
3765         (TestShell::dump):
3766         * DumpRenderTree/chromium/TestShell.h:
3767         (TestParams::TestParams):
3768
3769 2011-03-21  Adam Roben  <aroben@apple.com>
3770
3771         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
3772
3773         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
3774         output as plain text
3775
3776         Reviewed by David Kilzer.
3777
3778         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3779         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
3780         to the master.
3781         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
3782         since we're running on the build master, not the slave. Instead, turn the raw source of
3783         actual.html which the build slave uploaded into an HTML log.
3784
3785 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
3786
3787         Reviewed by Mihai Parparita.
3788
3789         new-run-webkit-tests: run tests in ascending alphabetical order per dir
3790         https://bugs.webkit.org/show_bug.cgi?id=56760
3791
3792         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3793         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3794         * Scripts/webkitpy/layout_tests/port/test.py:
3795
3796 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
3797
3798         Reviewed by Steve Block.
3799
3800         Media Stream API patch 0: adding compilation guards.
3801         https://bugs.webkit.org/show_bug.cgi?id=56458
3802
3803         Adding options to enable the media stream API feature in Chromium.
3804
3805         * Scripts/build-webkit:
3806
3807 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
3808
3809         Reviewed by Laszlo Gombos.
3810
3811         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
3812         https://bugs.webkit.org/show_bug.cgi?id=56323
3813
3814         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
3815         "--stdout" or "--stderr" option.
3816
3817         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3818         (WebCore::DumpRenderTree::~DumpRenderTree):
3819         (WebCore::DumpRenderTree::processArgsLine):
3820         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3821         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3822         (WebCore::DumpRenderTree::setRedirectOutputFileName):
3823         (WebCore::DumpRenderTree::setRedirectErrorFileName):
3824         * DumpRenderTree/qt/main.cpp:
3825         (isOption):
3826         (takeOptionValue):
3827         (printUsage):
3828         (main):
3829
3830 2011-03-21  Adam Roben  <aroben@apple.com>
3831
3832         Fix exceptions on the buildbot due to my last change
3833
3834         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3835         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
3836
3837 2011-03-21  Adam Roben  <aroben@apple.com>
3838
3839         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
3840
3841         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
3842         output as plain text
3843
3844         Reviewed by Darin Adler.
3845
3846         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3847         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
3848         logs.
3849         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
3850         the build master. This will correctly treat it as HTML.
3851
3852 2011-03-20  Bill Budge  <bbudge@chromium.org>
3853
3854         Reviewed by Adam Barth.
3855
3856         Rename ThreadSafeShared to ThreadSafeRefCounted
3857         https://bugs.webkit.org/show_bug.cgi?id=56714
3858
3859         No new tests. Exposes no new functionality.
3860
3861         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
3862         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
3863         * Scripts/do-webcore-rename:
3864
3865 2011-03-19  Anton D'Auria  <adauria@apple.com>
3866
3867         Reviewed by Dan Bernstein.
3868
3869         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
3870         https://bugs.webkit.org/show_bug.cgi?id=56719
3871
3872         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
3873         (LayoutTestController::clearApplicationCacheForOrigin):
3874
3875 2011-03-19  Anton D'Auria  <adauria@apple.com>
3876
3877         Reviewed by Alexey Proskuryakov.
3878
3879         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
3880         https://bugs.webkit.org/show_bug.cgi?id=56415
3881
3882         * DumpRenderTree/LayoutTestController.cpp:
3883         (clearApplicationCacheForOriginCallback):
3884         (LayoutTestController::staticFunctions):
3885         * DumpRenderTree/LayoutTestController.h:
3886         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
3887         (LayoutTestController::LayoutTestController):
3888         (LayoutTestController::clearAllApplicationCaches):
3889         (LayoutTestController::clearApplicationCacheForOrigin): 
3890         * DumpRenderTree/chromium/LayoutTestController.h:
3891         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
3892         (LayoutTestController::clearApplicationCacheForOrigin):
3893         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
3894         (LayoutTestController::clearApplicationCacheForOrigin):
3895         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3896         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
3897         (LayoutTestController::clearApplicationCacheForOrigin):
3898         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
3899         (LayoutTestController::clearApplicationCacheForOrigin):
3900
3901 2011-03-18  Dan Bernstein  <mitz@apple.com>
3902
3903         Revised build fix for r81135.
3904
3905         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3906         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3907
3908 2011-03-18  Adam Roben  <aroben@apple.com>
3909
3910         Windows build fix
3911
3912         * WebKitTestRunner/config.h: Add a missing #endif.
3913
3914 2011-03-18  Andreas Kling  <kling@webkit.org>
3915
3916         Unbreak Qt build after r81494.
3917
3918         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3919         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3920
3921 2011-03-18  Sam Weinig  <sam@webkit.org>
3922
3923         Fix windows build. This was really Adam Roben's fault. I swear!
3924
3925         * WebKitTestRunner/config.h:
3926
3927 2011-03-18  Sam Weinig  <sam@webkit.org>
3928
3929         Reviewed by Adam Roben.
3930
3931         Pixel tests don't work in WebKitTestRunner on Windows
3932         https://bugs.webkit.org/show_bug.cgi?id=56630
3933
3934         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
3935         built-in snapshotting instead of using the window server on the Mac.
3936
3937         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3938         (WTR::InjectedBundle::InjectedBundle):
3939         (WTR::InjectedBundle::didReceiveMessage):
3940         (WTR::InjectedBundle::beginTesting):
3941         (WTR::InjectedBundle::done):
3942         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3943         (WTR::InjectedBundle::setPixelResult):
3944         (WTR::InjectedBundle::shouldDumpPixels):
3945         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3946         (WTR::InjectedBundlePage::dump):
3947         Take the snapshot in the bundle and send it to the UIProcess for dumping.
3948
3949         * WebKitTestRunner/TestInvocation.cpp:
3950         (WTR::TestInvocation::invoke):
3951         (WTR::TestInvocation::dump):
3952         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3953         * WebKitTestRunner/TestInvocation.h:
3954         * WebKitTestRunner/cg: Added.
3955         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
3956         (WTR::createCGContextFromImage):
3957         (WTR::computeMD5HashStringForContext):
3958         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3959         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
3960         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
3961
3962         * WebKitTestRunner/win/TestInvocationWin.cpp:
3963         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3964         Keep stub for Cairo build.
3965
3966         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
3967         Add CG configuration.
3968
3969         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3970         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3971         Add new files.
3972
3973 2011-03-18  Adam Roben  <aroben@apple.com>
3974
3975         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
3976
3977         Rubber-stamped by Simon Fraser.
3978
3979         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3980         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
3981         overflow-y:overlay so that the scrollbar doesn't overlay the content.
3982
3983 2011-03-18  Adam Roben  <aroben@apple.com>
3984
3985         Don't ellipsize long or indented function names in Leaks Viewer
3986
3987         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
3988         scrollbar
3989
3990         Reviewed by Simon Fraser.
3991
3992         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3993         (.data-grid .data-container):
3994         (.data-grid td > div, .data-grid th > div):
3995         Allow the contents to extend to the right.
3996
3997 2011-03-18  Adam Roben  <aroben@apple.com>
3998
3999         Fix some leaks in DRT seen on the leaks bot
4000
4001         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
4002         setWillSendRequestClearHeaderCallback in DRT are leaky
4003
4004         Reviewed by Alexey Proskuryakov.
4005
4006         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
4007
4008         * DumpRenderTree/LayoutTestController.cpp:
4009         (addURLToRedirectCallback):
4010         (setWillSendRequestClearHeaderCallback):
4011         Use OwnArrayPtr to cause the strings to be deleted.
4012
4013 2011-03-18  Adam Roben  <aroben@apple.com>
4014
4015         Fix a NSURLCredential leak seen on the leaks bot
4016
4017         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
4018         connection:didReceiveAuthenticationChallenge:] is leaky
4019
4020         Reviewed by John Sullivan.
4021
4022         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4023         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
4024         cause the NSURLCredential to be released.
4025
4026 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
4027
4028         Unreviewed.
4029
4030         Remove unnecessary brackets around my email address.
4031
4032         * Scripts/webkitpy/common/config/committers.py:
4033
4034 2011-03-18  Adam Roben  <aroben@apple.com>
4035         
4036         Remove some files I accidentally added in r81454
4037
4038         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
4039         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
4040
4041 2011-03-18  Adam Roben  <aroben@apple.com>
4042
4043         Ignore an NSNumberFormatter leak on SnowLeopard
4044
4045         * Scripts/old-run-webkit-tests:
4046         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
4047         getObjectValue:forString:errorDescription:].
4048
4049 2011-03-18  Adam Roben  <aroben@apple.com>
4050
4051         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
4052
4053         Rubber-stamped by Mark Rowe.
4054
4055         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4056         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
4057         released.
4058
4059 2011-03-17  Adam Roben  <aroben@apple.com>
4060
4061         Address a review comment I missed in r81445
4062
4063         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
4064         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
4065         leaked bytes to speed up searching on long lines.
4066
4067 2011-03-17  Adam Roben  <aroben@apple.com>
4068
4069         Mark leaky builds orange, even if all regression tests passed
4070
4071         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
4072         build.webkit.org when all tests pass even though there are still leaks
4073
4074         Reviewed by Dan Bernstein.
4075
4076         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4077         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
4078         be marked orange if this build step generates warnings.
4079
4080 2011-03-17  Adam Roben  <aroben@apple.com>
4081
4082         Allow values in Leaks Viewer to be shown as percentages
4083
4084         Double-clicking on a column will toggle between showing percentages and showing real values.
4085
4086         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
4087         number of leaked bytes in Leaks Viewer
4088
4089         Reviewed by Joe Pecoraro.
4090
4091         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
4092         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
4093         node's totalTime, which is used in calculating percentages.
4094
4095         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
4096         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
4097         showing them as percentages.
4098
4099 2011-03-17  Adam Roben  <aroben@apple.com>
4100
4101         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
4102
4103         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
4104         the number of leaked allocations. And the new Average column shows the average number of
4105         leaked bytes per call.
4106
4107         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
4108         just how many allocations
4109
4110         Reviewed by Joe Pecoraro.
4111
4112         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
4113         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
4114         line and store it with the leak stack.
4115         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
4116         properties.
4117         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
4118         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
4119         .numberOfCalls now holds the number of leaked allocations.
4120
4121         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
4122         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
4123         appear.
4124         (monkeyPatchInspectorObjects): Format the values as bytes.
4125
4126 2011-03-17  Adam Roben  <aroben@apple.com>
4127
4128         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
4129
4130         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
4131         regression tests
4132
4133         Reviewed by James Robinson.
4134
4135         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
4136         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
4137         is always populated, even when all regression tests pass.
4138
4139 2011-03-10  Hayato Ito  <hayato@chromium.org>
4140
4141         Reviewed by Tony Chang.
4142
4143         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
4144
4145         https://bugs.webkit.org/show_bug.cgi?id=56076
4146
4147         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
4148
4149 2011-03-17  Adam Roben  <aroben@apple.com>
4150
4151         Skip a compositing-sensitive test when accelerated compositing is disabled
4152
4153         Reviewed by Sam Weinig.
4154
4155         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
4156         accelerated compositing is disabled.
4157
4158 2011-03-17  Adam Roben  <aroben@apple.com>
4159
4160         Start using PlatformSpecificScheduler for the Mac builders
4161
4162         The current set of file/directory patterns should work for Mac builders. We may discover
4163         that there are more files and directories we can exclude from the Mac builds, but they can
4164         be added later.
4165
4166         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
4167
4168         Reviewed by Mark Rowe.
4169
4170         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
4171         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
4172
4173         * Scripts/webkitpy/common/config/build.py:
4174         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
4175         cleaned up patterns a little bit.
4176
4177         * Scripts/webkitpy/common/config/build_unittest.py:
4178         (ShouldBuildTest): Fixed some expected results.
4179         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
4180         platforms.
4181
4182 2011-03-17  Jeff Miller  <jeffm@apple.com>
4183
4184         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
4185         
4186         *.mode*
4187         *.pbxuser
4188         *.perspective*
4189         project.xcworkspace
4190         xcuserdata
4191
4192         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
4193         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
4194         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
4195         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
4196         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
4197
4198 2011-03-17  Adam Roben  <aroben@apple.com>
4199
4200         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
4201
4202         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
4203         mac-wk2
4204
4205         Reviewed by Anders Carlsson.
4206
4207         * Scripts/old-run-webkit-tests:
4208         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
4209         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
4210         we're running in WebKit2 mode.
4211
4212 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
4213
4214         Reviewed by Yury Semikhatsky.
4215
4216         Web Inspector: Clean up Inspector strings.
4217         https://bugs.webkit.org/show_bug.cgi?id=56557
4218
4219         Modify the script to deal correctly with "\xNN" escapes, and to
4220         check strings in Chromium's DevTools.js.
4221
4222         * Scripts/check-inspector-strings:
4223
4224 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
4225
4226         Reviewed by Benjamin Poulain.
4227
4228         Update autoinstall to install mechanize 0.2.4
4229         https://bugs.webkit.org/show_bug.cgi?id=56499
4230
4231         Newer versions of mechanize support HTTPS proxies, which is necessary
4232         for people using webkit-patch behind firewalls.
4233
4234         * Scripts/webkitpy/common/system/autoinstall.py:
4235         * Scripts/webkitpy/thirdparty/__init__.py:
4236
4237 2011-03-16  Sam Weinig  <sam@webkit.org>
4238
4239         Reviewed by Adam Roben.
4240
4241         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
4242         https://bugs.webkit.org/show_bug.cgi?id=56541
4243
4244         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4245         (WTR::InjectedBundlePage::willSendRequestForFrame):
4246         Check for an empty host in addition to a null host.  This bug was introduced
4247         when porting off of the KURL code and onto the WKURLRef version.
4248
4249 2011-03-16  Sam Weinig  <sam@webkit.org>
4250
4251         Reviewed by Adam Roben.
4252
4253         Add Lucas Forschler to the list of WebKit committers.
4254
4255         * Scripts/webkitpy/common/config/committers.py:
4256
4257 2011-03-16  Sam Weinig  <sam@webkit.org>
4258
4259         Reviewed upon and dictated through Adam Roben.
4260
4261         Escape crashing function names in results.html. This fixes an issue
4262         when a crash involves a type with templates.
4263
4264         * Scripts/old-run-webkit-tests:
4265
4266 2011-03-16  Daniel Sievers  <sievers@google.com>
4267
4268         Reviewed by James Robinson.
4269
4270         Add setting to always force compositing mode
4271         https://bugs.webkit.org/show_bug.cgi?id=56156
4272
4273         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4274         (main):
4275         * DumpRenderTree/chromium/TestShell.cpp:
4276         (TestShell::TestShell):
4277         (TestShell::resetWebSettings):
4278         * DumpRenderTree/chromium/TestShell.h:
4279         (TestShell::setForceCompositingMode):
4280         * DumpRenderTree/chromium/WebPreferences.cpp:
4281         (WebPreferences::reset):
4282         (WebPreferences::applyTo):
4283         * DumpRenderTree/chromium/WebPreferences.h:
4284
4285 2011-03-15  Hayato Ito  <hayato@chromium.org>
4286
4287         Reviewed by Ojan Vafai.
4288
4289         Ignore files that will be used by reftests in old-run-webkit-tests.
4290
4291         https://bugs.webkit.org/show_bug.cgi?id=55936
4292
4293         * Scripts/old-run-webkit-tests:
4294
4295 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
4296
4297         Reviewed by Adam Roben.
4298
4299         Function relativeScriptsDir doesn't return the correct relative
4300         Scripts directory.
4301
4302         * Scripts/webkitdirs.pm:
4303         (relativeScriptsDir): Ensure we use the directory that contains
4304         webkitdirs.pm, not the one that contains the original script that
4305         was invoked.
4306
4307 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
4308
4309         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
4310         fix to link against the Security framework after recent WebKitSystemInterface changes.
4311
4312         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4313         (LayoutTestController::originsWithLocalStorage):
4314         * wx/build/settings.py:
4315         * wx/build/waf_extensions.py:
4316
4317 2011-03-15  Sam Weinig  <sam@webkit.org>
4318
4319         Reviewed by Darin Adler.
4320
4321         Add script to convert a patch to a prettypatch and show in the default browser
4322         https://bugs.webkit.org/show_bug.cgi?id=56416
4323
4324         This can be used either like
4325             $ svn-create-patch | show-pretty-diff
4326         or
4327             $ show-pretty-diff patch.diff
4328
4329         * Scripts/show-pretty-diff: Added.
4330
4331 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
4332
4333         Rubber-stamped by Adam Roben.
4334
4335         Adding myself as a reviewer.
4336
4337         * Scripts/webkitpy/common/config/committers.py:
4338
4339 2011-03-15  Anders Carlsson  <andersca@apple.com>
4340
4341         Try to fix the Windows build.
4342
4343         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
4344         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
4345
4346 2011-03-15  Anders Carlsson  <andersca@apple.com>
4347
4348         Reviewed by Sam Weinig.
4349
4350         Make sure that NP_Shutdown is always the last NPP function called
4351         https://bugs.webkit.org/show_bug.cgi?id=56391
4352
4353         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
4354
4355         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4356         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4357         (PluginTest::PluginTest):
4358         (PluginTest::NP_Shutdown):
4359         (Pl