EWSTools should be able to build a chromium-ews bot from scratch
[WebKit-https.git] / Tools / ChangeLog
1 2012-07-10  Adam Barth  <abarth@webkit.org>
2
3         EWSTools should be able to build a chromium-ews bot from scratch
4         https://bugs.webkit.org/show_bug.cgi?id=90912
5
6         Reviewed by Eric Seidel.
7
8         I've been using this script to kick off the build process for the
9         chromium-ews bots on Google Compute Engine.
10
11         * EWSTools/GoogleComputeEngine: Added.
12         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Added.
13
14 2012-07-10  Alec Flett  <alecflett@chromium.org>
15
16         Add alecflett to the list of committers
17         https://bugs.webkit.org/show_bug.cgi?id=90903
18
19         Reviewed by Ojan Vafai.
20
21         * Scripts/webkitpy/common/config/committers.py:
22
23 2012-07-10  Xianzhu Wang  <wangxianzhu@chromium.org>
24
25         Unreviewed fix of webkitpy unittest break about chromium_android.py
26         caused by r122251.
27
28         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
29         (ChromiumAndroidDriverTest.test_cmd_line):
30
31 2012-07-10  Ojan Vafai  <ojan@chromium.org>
32
33         webkit-patch rebaseline doesn't work for audio/pixel tests
34         https://bugs.webkit.org/show_bug.cgi?id=90905
35
36         Reviewed by Adam Barth.
37
38         We just need to pass the correct suffix list to rebaseline-test-internal
39         and optimize-baselines. By default, pass all suffixes.
40
41         * Scripts/webkitpy/tool/commands/rebaseline.py:
42         (Rebaseline):
43         (Rebaseline.__init__):
44         (Rebaseline._suffixes_to_update):
45         (Rebaseline.execute):
46         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
47         (test_rebaseline_multiple_builders_and_tests_command_line):
48
49 2012-07-10  Adam Barth  <abarth@webkit.org>
50
51         Remove LayoutTestController and WebKitTestRunner support for Hixie76 WebSockets
52         https://bugs.webkit.org/show_bug.cgi?id=90853
53
54         Reviewed by Eric Seidel.
55
56         WebKit no longer implements the Hixie76 version of the WebSocket
57         protocol. We don't need to support it in our test framework.
58
59         * DumpRenderTree/chromium/LayoutTestController.cpp:
60         (LayoutTestController::overridePreference):
61         * DumpRenderTree/chromium/WebPreferences.cpp:
62         (WebPreferences::reset):
63         (WebPreferences::applyTo):
64         * DumpRenderTree/chromium/WebPreferences.h:
65         (WebPreferences):
66         * DumpRenderTree/gtk/DumpRenderTree.cpp:
67         (resetDefaultsToConsistentValues):
68         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
69         (LayoutTestController::overridePreference):
70         * DumpRenderTree/mac/DumpRenderTree.mm:
71         (resetDefaultsToConsistentValues):
72         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
73         (WebCore::WebPage::resetSettings):
74         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
75         (LayoutTestController::overridePreference):
76         * DumpRenderTree/win/DumpRenderTree.cpp:
77         (resetDefaultsToConsistentValues):
78
79 2012-07-10  Xianzhu Wang  <wangxianzhu@chromium.org>
80
81         [Chromium-Android] Fix typos in chromium_android.py in r151492
82         https://bugs.webkit.org/show_bug.cgi?id=90904
83
84         Reviewed by Ojan Vafai.
85
86         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
87         (ChromiumAndroidPort.setup_test_run):
88
89 2012-07-10  Xianzhu Wang  <wangxianzhu@chromium.org>
90
91         [Chromium-Android] Use setup_test_runner() instead of start_helper() to setup test environment
92         https://bugs.webkit.org/show_bug.cgi?id=90894
93
94         Reviewed by Adam Barth.
95
96         start_helper() is actually start_pixel_test_helper() since r115601 (bug 81729).
97         Should use setup_test_runner() to setup test environment for chromium-android.
98
99         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
100         (ChromiumAndroidPort.setup_test_run): Renamed from start_helper(). Added cache cleanup code.
101         (ChromiumAndroidPort.clean_up_test_run): Renamed from stop_helper().
102         (ChromiumAndroidPort._path_to_helper): Returns None as we don't have a helper now.
103         (ChromiumAndroidPort):
104         (ChromiumAndroidPort._path_to_forwarder): Original _path_to_helper().
105         (ChromiumAndroidPort._push_executable):
106         (ChromiumAndroidDriver.__init__):
107         (ChromiumAndroidDriver.cmd_line):
108
109 2012-07-09  Ojan Vafai  <ojan@chromium.org>
110
111         Improve webkit-patch rebaseline to work for more cases
112         https://bugs.webkit.org/show_bug.cgi?id=90504
113
114         Reviewed by Adam Barth.
115
116         -Makes it work for the build.chromium.org bots.
117         -Lets you rebaseline all builders instead of just one.
118         -Lets you pass in the builders or tests to rebaseline.
119
120         * Scripts/webkitpy/common/host.py:
121         (Host.buildbot_for_builder_name):
122         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
123         (Builder.__init__):
124         (Builder.latest_layout_test_results):
125         Provide a way to get to the LayoutTestResults of the latest build.
126         Most of the time we only need to get the latest one and the Chromium bots
127         only expose the full_results.json file for the latest build.
128
129         (Builder):
130         (Builder._fetch_file_from_results):
131         (Builder.fetch_layout_test_results):
132         Move these functions into Builder so that Builder and Build can both
133         fetch layout test results.
134
135         (Build.results_zip_url):
136         (Build.layout_test_results):
137         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
138         (BuilderTest.test_latest_layout_test_results):
139         (BuildTest.test_layout_test_results):
140         * Scripts/webkitpy/common/system/user.py:
141         (User.prompt_with_multiple_lists):
142         Prompt with multiple sublists, but still have a global numbering.
143         This lets the build.chromium.org bots be clearly separated from the
144         build.webkit.org bots, which helps understand the builder names.
145
146         (User):
147         (User._wait_on_list_response):
148         (User.prompt_with_list):
149         * Scripts/webkitpy/common/system/user_unittest.py:
150         (UserTest.test_prompt_with_multiple_lists):
151         (UserTest.test_prompt_with_multiple_lists.run_prompt_test):
152         (UserTest.test_prompt_with_multiple_lists.run_prompt_test.mock_raw_input):
153         * Scripts/webkitpy/layout_tests/port/base.py:
154         (Port.is_chromium):
155         Provide a way to tell if a port is a Chromium port that doesn't involve string
156         manipulation on the port name or builder name.
157
158         * Scripts/webkitpy/layout_tests/port/builders.py:
159         (builder_path_from_name):
160         (all_builder_names):
161         Memoizing here is incorrect because the test override _exact_matches,
162         so these can return different values. In either case, I'm pretty sure these
163         are not remotely hot codepaths. I manually inspected all call sites and they're
164         all in high-level calls (e.g. execute calls for webkit-patch commands) and not
165         called in a loop.
166
167         * Scripts/webkitpy/layout_tests/port/chromium.py:
168         (ChromiumPort.is_chromium):
169         * Scripts/webkitpy/tool/commands/rebaseline.py:
170         (RebaselineTest._results_url):
171         (AbstractParallelRebaselineCommand.__init__):
172         (Rebaseline.__init__):
173         (Rebaseline):
174         (Rebaseline._builders_to_pull_from):
175         (Rebaseline._tests_to_update):
176         (Rebaseline.execute):
177         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
178         (test_rebaseline.mock_builders_to_pull_from):
179         (test_rebaseline):
180         (test_rebaseline_command_line_flags):
181         (test_rebaseline_multiple_builders):
182         (test_rebaseline_multiple_builders.mock_builders_to_pull_from):
183         (test_rebaseline_multiple_builders.mock_tests_to_update):
184         (test_rebaseline_multiple_builders_and_tests_command_line):
185         * Scripts/webkitpy/tool/mocktool.py:
186         (MockTool.irc):
187         (MockTool):
188         (MockTool.buildbot_for_builder_name):
189
190 2012-07-10  Alice Cheng  <alice_cheng@apple.com>
191
192         Editing: Reproducible crasher when pasting a 0x0 image into Mail
193         https://bugs.webkit.org/show_bug.cgi?id=90640
194         <rdar://problem/11141920>
195
196         Reviewed by Brady Eidson.
197
198         Test cases for the patch. 0x0 images don't get a resource representation in the WebArchive, so we need a null check.
199
200         * TestWebKitAPI/Tests/mac/0.png: Added.
201         * TestWebKitAPI/Tests/mac/WebViewCanPasteZeroPng.mm: Added.
202         (TestWebKitAPI):
203         (TestWebKitAPI::TEST):
204
205 2012-07-10  Leandro Gracia Gil  <leandrogracia@chromium.org>
206
207         WebSurroundingText layout tests should use the same code path as the rest of the feature.
208         https://bugs.webkit.org/show_bug.cgi?id=90807
209
210         Reviewed by Adam Barth.
211
212         Make the textSurroundingNode method take a pair of point coordinates
213         instead of a node offset.
214
215         * DumpRenderTree/chromium/LayoutTestController.cpp:
216         (LayoutTestController::textSurroundingNode):
217         * DumpRenderTree/chromium/LayoutTestController.h:
218         (LayoutTestController):
219
220 2012-07-10  Csaba Osztrogonác  <ossy@webkit.org>
221
222         [Qt] REGRESSION(r122175): It broke the Windows build
223         https://bugs.webkit.org/show_bug.cgi?id=90850
224
225         Reviewed by Noam Rosenthal.
226
227         * qmake/mkspecs/features/features.prf: Disable USE(3D_GRAPHICS) on Windows temporarily until proper fix.
228
229 2012-07-10  János Badics  <jbadics@inf.u-szeged.hu>
230
231         [Qt][NRWT] Enable cascaded TestExpectations
232         https://bugs.webkit.org/show_bug.cgi?id=89108
233
234         Reviewed by Dirk Pranke.
235
236         * Scripts/webkitpy/layout_tests/port/qt.py:
237         (QtPort.expectations_files):
238         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
239         (QtPortTest._assert_expectations_files):
240         (QtPortTest.test_expectations_files):
241
242 2012-07-10  Christophe Dumez  <christophe.dumez@intel.com>
243
244         [EFL] WebKit DRT and WTR fail to build due to undefined reference to WTF::MD5::*
245         https://bugs.webkit.org/show_bug.cgi?id=90868
246
247         Unreviewed EFL build fix.
248
249         Correct CMake configuration to have EFL's DRT and WebKitTestRunner link
250         WTF library. This is needed to resolve undefined reference to WTF::MD5::*.
251
252         * DumpRenderTree/efl/CMakeLists.txt:
253         * WebKitTestRunner/PlatformEfl.cmake:
254
255 2012-07-10  Adam Barth  <abarth@webkit.org>
256
257         LayoutTestController.dumpConfigurationForViewport should move to Internals
258         https://bugs.webkit.org/show_bug.cgi?id=45652
259
260         Reviewed by Eric Seidel.
261
262         Remove dumpConfigurationForViewport from LayoutTestController. This API
263         has been replaced by an API on Internals that does the same thing in a
264         port-agnostic way.
265
266         * DumpRenderTree/LayoutTestController.cpp:
267         (LayoutTestController::staticFunctions):
268         * DumpRenderTree/LayoutTestController.h:
269         (LayoutTestController):
270         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
271         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
272         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
273         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
274         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
275         * DumpRenderTree/qt/LayoutTestControllerQt.h:
276         (LayoutTestController):
277         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
278         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
279
280 2012-07-09  Matt Falkenhagen  <falken@chromium.org>
281
282         Add ENABLE_DIALOG_ELEMENT and skeleton files
283         https://bugs.webkit.org/show_bug.cgi?id=90521
284
285         Reviewed by Kent Tamura.
286
287         * Scripts/webkitperl/FeatureList.pm:
288
289 2012-07-09  Kent Tamura  <tkent@chromium.org>
290
291         Improve the boilerplate generated by prepare-ChangeLog
292         https://bugs.webkit.org/show_bug.cgi?id=89560
293
294         Reviewed by Ryosuke Niwa.
295
296         Produce the following boilerplate:
297
298         > 2012-06-20  Kent Tamura  <tkent@chromium.org>
299         >
300         >         Need a short description (Oops!).
301         >         Need the bug URL (Oops!).
302         >
303         >         Reviewed by NOBODY (Oops!).
304         >
305         >         Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).
306         >
307         >         No new tests (Oops!).
308
309         * Scripts/prepare-ChangeLog:
310         (generateNewChangeLogs): Generate the updated template.
311         * Scripts/webkitpy/common/checkout/changelog.py:
312         (ChangeLog.update_with_unreviewed_message):
313         Update the pattern for the beginning of the boilerplate.
314         (ChangeLog.set_short_description_and_bug_url):
315         - Use self._changelog_indent
316         - Update the pattern for the description line
317         - Skip the bug boilerplate.
318         We substitute the specified bug URL to the description boilerplate
319         because we need to add it even if the bug URL boilerplate is missing.
320         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Update the boilerplate data.
321         (test_set_short_description_and_bug_url):
322         - Update the description boilerplate.
323         - Add a test for a case with both of the description boilerplace and the
324           bug URL boilerplate.
325         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
326         (PrepareChangeLogTest.test_ensure_bug_url): Update the expected boilerplate.
327
328 2012-07-09  No'am Rosenthal  <noam.rosenthal@nokia.com>
329
330         Shared code that is guarded with ENABLE(WEBGL) should be guarded with USE()
331         https://bugs.webkit.org/show_bug.cgi?id=90506
332
333         Reviewed by Martin Robinson.
334
335         Always enable the WTF_USE_3D_GRAPHICS flag in features.prf if we're compiling with Qt5
336         or if the OpenGL module is enabled.
337
338         * qmake/mkspecs/features/features.prf:
339
340 2012-07-09  Yongjun Zhang  <yongjun_zhang@apple.com>
341
342         Consider closing unused localStorage database after a timeout.
343         https://bugs.webkit.org/show_bug.cgi?id=90713
344
345         For a localStorage, if there is no active document referencing to it for certain amount of time (300 seconds),
346         we can close the underlying sqlite database.
347
348         Reviewed by Brady Eidson.
349
350         * DumpRenderTree/LayoutTestController.cpp: add a JS method setStorageDatabaseIdleInterval to testRunner
351             to set a different timeout value for closing localStorage database.
352         (setStorageDatabaseIdleIntervalCallback):
353         (LayoutTestController::staticFunctions):
354         * DumpRenderTree/LayoutTestController.h:
355         (LayoutTestController):
356         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
357         (LayoutTestController::setStorageDatabaseIdleInterval): add empty method.
358         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
359         (LayoutTestController::setStorageDatabaseIdleInterval): ditto.
360         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
361         (LayoutTestController::setStorageDatabaseIdleInterval): ditto.
362         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
363         (LayoutTestController::setStorageDatabaseIdleInterval): ditto.
364
365 2012-07-09  Adam Klein  <adamk@chromium.org>
366
367         Rename WebCore::WebKitMutationObserver to WebCore::MutationObserver
368         https://bugs.webkit.org/show_bug.cgi?id=90810
369
370         Reviewed by Ojan Vafai.
371
372         * DumpRenderTree/gtk/EventSender.cpp:
373
374 2012-07-09  Mihai Parparita  <mihaip@chromium.org>
375
376         Handle missing results in TestResultsServer better
377         https://bugs.webkit.org/show_bug.cgi?id=90816
378
379         Reviewed by Ojan Vafai.
380
381         If we can't load the results JSON, don't try to wrap it with the JSONP
382         callback invocation.
383
384         * TestResultServer/handlers/testfilehandler.py:
385         (GetFile.get):
386
387 2012-07-09  Sheriff Bot  <webkit.review.bot@gmail.com>
388
389         Unreviewed, rolling out r122124.
390         http://trac.webkit.org/changeset/122124
391         https://bugs.webkit.org/show_bug.cgi?id=90815
392
393         It broke NRWT on Qt (Requested by Ossy_HOME on #webkit).
394
395         * Scripts/webkitpy/layout_tests/port/qt.py:
396         (QtPort._skipped_file_search_paths):
397         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
398         (QtPortTest._assert_skipped_path):
399         (QtPortTest.test_skipped_file_search_path):
400
401 2012-07-09  Zan Dobersek  <zandobersek@gmail.com>
402
403         [Gtk] Implement dumpFrameScrollPosition in DumpRenderTree
404         https://bugs.webkit.org/show_bug.cgi?id=89356
405
406         Reviewed by Martin Robinson.
407
408         Implement dumpFrameScrollPosition, acquiring the scroll position
409         through WebKitDOMDOMWindow of the WebKitDOMDocument loaded in the frame
410         whose scroll position is being dumped.
411
412         * DumpRenderTree/gtk/DumpRenderTree.cpp:
413         (dumpFrameScrollPosition):
414
415 2012-07-09  János Badics  <jbadics@inf.u-szeged.hu>
416
417         [Qt][NRWT] Enable cascaded TestExpectations
418         https://bugs.webkit.org/show_bug.cgi?id=89108
419
420         Reviewed by Dirk Pranke.
421
422         * Scripts/webkitpy/layout_tests/port/qt.py:
423         (QtPort.expectations_files):
424         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
425         (QtPortTest._assert_expectations_files):
426         (QtPortTest.test_expectations_files):
427
428 2012-07-09  Dan Bernstein  <mitz@apple.com>
429
430         Fixed clean builds of the All target in the DumpRenderTree project.
431
432         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode know that the
433         DumpRenderTree Perl Support target depends on the DumpRenderTree target.
434
435 2012-07-09  Zan Dobersek  <zandobersek@gmail.com>
436
437         [Gtk] Unskip the CSS Regions layout tests
438         https://bugs.webkit.org/show_bug.cgi?id=90771
439
440         Reviewed by Martin Robinson.
441
442         Use the DumpRenderTreeSupportGtk method for enabling the CSS Regions,
443         calling it when resetting the defaults in DumpRenderTree or when the
444         settings value is overriden through the testRunner.
445
446         * DumpRenderTree/gtk/DumpRenderTree.cpp:
447         (resetDefaultsToConsistentValues):
448         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
449         (LayoutTestController::overridePreference):
450
451 2012-07-09  Sheriff Bot  <webkit.review.bot@gmail.com>
452
453         Unreviewed, rolling out r122107.
454         http://trac.webkit.org/changeset/122107
455         https://bugs.webkit.org/show_bug.cgi?id=90794
456
457         Build failure on Mac debug bots (Requested by falken_ on
458         #webkit).
459
460         * Scripts/webkitperl/FeatureList.pm:
461
462 2012-07-09  Matt Falkenhagen  <falken@chromium.org>
463
464         Add ENABLE_DIALOG_ELEMENT and skeleton files
465         https://bugs.webkit.org/show_bug.cgi?id=90521
466
467         Reviewed by Kent Tamura.
468
469         * Scripts/webkitperl/FeatureList.pm:
470
471 2012-07-08  Kent Tamura  <tkent@chromium.org>
472
473         Unreviewed, rolling out r122076.
474         http://trac.webkit.org/changeset/122076
475         https://bugs.webkit.org/show_bug.cgi?id=89560
476
477         Broke sheriffbot rollout
478
479         * Scripts/prepare-ChangeLog:
480         (generateNewChangeLogs):
481
482 2012-07-08  Leandro Gracia Gil  <leandrogracia@chromium.org>
483
484         Update the description of LayoutTestController::textSurroundingElement
485         https://bugs.webkit.org/show_bug.cgi?id=90620
486
487         Reviewed by Adam Barth.
488
489         Rename and fix the description of the method as its behaviour changed
490         during the review of https://bugs.webkit.org/show_bug.cgi?id=82461
491
492         * DumpRenderTree/chromium/LayoutTestController.cpp:
493         (LayoutTestController::LayoutTestController):
494         (LayoutTestController::textSurroundingNode):
495         * DumpRenderTree/chromium/LayoutTestController.h:
496         (LayoutTestController):
497
498 2012-07-08  Kent Tamura  <tkent@chromium.org>
499
500         Improve the template generated by prepare-ChangeLog
501         https://bugs.webkit.org/show_bug.cgi?id=89560
502
503         Reviewed by Ryosuke Niwa.
504
505         Produce the following template:
506
507         > 2012-06-20  Kent Tamura  <tkent@chromium.org>
508         >
509         >         Need a short description (Oops!).
510         >         Need the bug URL (Oops!).
511         >
512         >         Reviewed by Ryosuke Niwa.
513         >
514         >         Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).
515         >
516         >         No new tests (Oops!).
517
518         * Scripts/prepare-ChangeLog:
519         (generateNewChangeLogs):
520
521 2012-07-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
522
523         [wx] Unreviewed. Fix notificaitons directory path after notifications move.
524
525         * waf/build/settings.py:
526
527 2012-07-07  Nuno Lopes  <nlopes@apple.com>
528
529         Fix build with recent clang.
530         https://bugs.webkit.org/show_bug.cgi?id=90712
531
532         Reviewed by Alexey Proskuryakov.
533
534         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
535         (DOMWindowExtensionBasic):
536         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
537         (DOMWindowExtensionNoCache):
538         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
539         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
540
541 2012-07-06  Zan Dobersek  <zandobersek@gmail.com>
542
543         [Gtk] Add a configuration option for disabling unstable features in releases
544         https://bugs.webkit.org/show_bug.cgi?id=87995
545
546         Reviewed by Martin Robinson.
547
548         Pass the --enable-unstable-features flag when building the Gtk port through build-webkit.
549
550         * Scripts/webkitdirs.pm:
551         (buildAutotoolsProject):
552
553 2012-07-06  Jessie Berlin  <jberlin@apple.com>
554
555         WKContext should ask for its initialization data when it needs it so the client doesn't have
556         to keep it up to date.
557         https://bugs.webkit.org/show_bug.cgi?id=90627
558
559         Reviewed by Anders Carlsson.
560
561         Add tests and update other WKContextInjectedBundleClients.
562
563         * MiniBrowser/mac/AppDelegate.m:
564         (-[BrowserAppDelegate init]):
565         Updated for the change to WKContextInjectedBundleClient.
566         * WebKitTestRunner/TestController.cpp:
567         (WTR::TestController::initialize):
568         Ditto.
569
570         * TestWebKitAPI/PlatformUtilities.cpp:
571         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
572         Moved the logic to create the initialization dictionary here ...
573         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
574         ... from here so that it can be used without automatically using
575         WKContextSetInitializationUserDataForInjectedBundle.
576         * TestWebKitAPI/PlatformUtilities.h:
577
578         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
579         Add the new test files.
580         * TestWebKitAPI/GNUmakefile.am:
581         Ditto.
582
583         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: Added.
584         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
585         Check that the message received from the injected bundle matches the user data it was
586         initialized with.
587         (TestWebKitAPI::getInjectedBundleInitializationUserData):
588         Return the user data that the injected bundle should be initialized with.
589         (TestWebKitAPI::TEST):
590         Set up WKContextInjectedBundleClient and load a page.
591         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: Added.
592         (TestWebKitAPI::GetInjectedBundleInitializationUserDataCallbackTest::initialize):
593         Send the initialization user data back up to the UI Process.
594
595         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: Added.
596         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
597         Check that the message received from the injected bundle matches the user data it was
598         initialized with in the callback.
599         (TestWebKitAPI::getInjectedBundleInitializationUserData):
600         Return the user data that the injected bundle should be initialized with.
601         (TestWebKitAPI::TEST):
602         Set up the context and use WKContextSetInitializationUserDataForInjectedBundle to set the
603         initialization user data (which should be overridden by the user data returned in
604         getInjectedBundleInitializationUserData).
605         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: Added.
606         (TestWebKitAPI::InjectedBundleInitializationUserDataCallbackWinsTest::initialize):
607         Send the initialization user data back up to the UI Process.
608
609 2012-07-06  Dongwoo Im  <dw.im@samsung.com>
610
611         [EFL][GTK] jhbuild : Disable pixman demos build depending on GTK+
612         https://bugs.webkit.org/show_bug.cgi?id=90593
613
614         Reviewed by Philippe Normand.
615
616         * efl/jhbuild.modules: Give '--enable-gtk=no' option to pixman.
617         * gtk/jhbuild.modules: Give '--enable-gtk=no' option to pixman.
618
619 2012-07-06  Luciano Wolf <luciano.wolf@openbossa.org>
620
621         [Qt] DumpRenderTree does not use 'monospace' font when directed
622         https://bugs.webkit.org/show_bug.cgi?id=85203
623
624         The test fonts used for Qt tests were moved to the Liberation font family.
625
626         Due to this change we are skipping tons of tests. They will be gradually
627         unskipped in batches, ASAP.
628
629         Also, the now unneeded special font configuration for Qt5 WK1 was removed.
630
631         Reviewed by Tor Arne Vestbø.
632
633         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
634         (WebKit::initializeTestFonts):
635
636 2012-07-06  Csaba Osztrogonác  <ossy@webkit.org>
637
638         [Qt] Buildfix for newer Qt5
639         https://bugs.webkit.org/show_bug.cgi?id=90519
640
641         Reviewed by Tor Arne Vestbø.
642
643         * MiniBrowser/qt/MiniBrowser.pro: We also need to depend on gui-private in the MiniBrowser to get access to these headers.
644         * MiniBrowser/qt/MiniBrowserApplication.h: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h
645         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h
646
647 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
648
649         [Qt] Make use of Qt5 qmake's changed makefile recursion behavior
650
651         When not using the -r option, qmake now interleaves qmake and make calls,
652         so we don't need custom logic for this. There's also an option to supress
653         the effect of the -r option, which we use to make WebKit.pro the only
654         project file parsed in a recursive qmake-run.
655
656         https://bugs.webkit.org/show_bug.cgi?id=90461
657
658         Reviewed by Tor Arne Vestbø.
659
660         * qmake/mkspecs/features/default_post.prf:
661         * qmake/mkspecs/features/functions.prf:
662
663 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
664
665         [Qt] Remove custom qmake logic for module creation
666
667         Qmake now has the necessary hooks to cleanly override the build locations.
668
669         https://bugs.webkit.org/show_bug.cgi?id=90461
670
671         Reviewed by Tor Arne Vestbø.
672
673         * qmake/mkspecs/features/default_pre.prf:
674
675 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
676
677         [Qt] Add top-level .qmake.conf
678
679         With Qt5, this makes setting $QMAKEPATH externally unnecessary.
680
681         The magic in the perl scripts to set QMAKEPATH is still there, as it doesn't
682         hurt, and is still required for Qt4.
683
684         https://bugs.webkit.org/show_bug.cgi?id=90461
685
686         Reviewed by Tor Arne Vestbø.
687
688         * qmake/mkspecs/features/default_pre.prf:
689
690 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
691
692         [Qt] Unify qtFeatureDefaults code paths
693
694         There's no reason to run qmake on features.prf directly anymore, as we
695         can selectivly run configure tests in the project file now.
696
697         https://bugs.webkit.org/show_bug.cgi?id=90461
698
699         Reviewed by Tor Arne Vestbø.
700
701         * Scripts/webkitdirs.pm:
702         (qtFeatureDefaults):
703         * qmake/configure.pri:
704         * qmake/mkspecs/features/features.prf:
705
706 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
707
708         [Qt] Don't let qt_webkit.pri proclaim its own location
709
710         This won't work any more with recent Qt5 versions, as the forwarding
711         pri is created by qt_module_config, which needs MODULE_PRI to be set
712         up already.
713
714         We also need to load build_config, not qt_module.
715
716         https://bugs.webkit.org/show_bug.cgi?id=90461
717
718         Reviewed by Tor Arne Vestbø.
719
720         * qmake/qt_webkit.pri:
721
722 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
723
724         [Qt] Remove redundant CONFIG+=module
725
726         qt_module_config takes care of that.
727
728         In api.pri we are actually testing the flag ourselves, so now we need to
729         test a related flag qt_module_config sets instead.
730
731         Reviewed by Tor Arne Vestbø.
732
733         * qmake/mkspecs/features/default_post.prf:
734
735 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
736
737         [Qt] Switch to new-style Qt 5 configure tests
738
739         Use explicit project file action instead of syncqt magic.
740
741         https://bugs.webkit.org/show_bug.cgi?id=90461
742
743         Reviewed by Tor Arne Vestbø.
744
745         * Scripts/webkitdirs.pm:
746         (buildQMakeProjects):
747         * qmake/configure.pri: Copied from Tools/qmake/configure.pro.
748         * qmake/configure.pro:
749         * qmake/mkspecs/features/default_pre.prf:
750         * qmake/mkspecs/features/features.prf:
751         * qmake/sync.profile: Removed.
752
753 2012-07-05  Jason Liu  <jason.liu@torchmobile.com.cn>
754
755         Add Jason Liu to committers.py.
756         https://bugs.webkit.org/show_bug.cgi?id=90654
757
758         Unreviewed.
759
760         * Scripts/webkitpy/common/config/committers.py:
761
762 2012-07-05  Benjamin Poulain  <bpoulain@apple.com>
763
764         Double release of resources if the load is canceled in a callback of ResourceLoader::didFinishLoading
765         https://bugs.webkit.org/show_bug.cgi?id=90431
766
767         Reviewed by Anders Carlsson.
768
769         Add a Mac API test.
770
771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
772         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.html: Added.
773         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm: Added.
774         (-[CancelLoadFromResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
775         (-[CancelLoadFromResourceLoadDelegateFrameLoadDelegate webView:didFinishLoadForFrame:]):
776         (TestWebKitAPI):
777         (TestWebKitAPI::TEST):
778
779 2012-07-05  Dave Tharp  <dtharp@codeaurora.org>
780
781         Adding myself as committer to committers.py
782
783         Unreviewed.
784
785         * Scripts/webkitpy/common/config/committers.py:
786
787 2012-07-05  Alexey Proskuryakov  <ap@apple.com>
788
789         [Mac][WK2] Enable HTTPS tests
790         https://bugs.webkit.org/show_bug.cgi?id=90600
791
792         Reviewed by Brady Eidson.
793
794         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed a misleading comment.
795         It explained why we were doing this here instead of a frame load delegate, but that's
796         just history, not an explanation of why we need this code.
797
798         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
799         Ignore certificate errors for localhost and 127.0.0.1. Since this is only needed
800         for tests, it seems appropriate to have platform specific solutions in every WTR,
801         and not add a WebKit2 API.
802
803 2012-07-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
804
805         [Qt] Remove rpath-hacks in qt_webkit.pri
806
807         Having it in qt_webkit.pri meant that all client apps would inherit the rpath,
808         even if they were not using QtWebKit.
809
810         This is a regression for people who build client apps against a non-installed
811         QtWebKit, as the client app will be missing a rpath to the standalone WebKit
812         build dir. This can be solved by LD_LIBRARY_PATH or custom QMAKE_RPATHDIR
813         logic, until the real issue is fixed in Qt.
814
815         Reviewed by Csaba Osztrogonác.
816
817         * qmake/mkspecs/features/rpath.prf:
818         * qmake/qt_webkit.pri:
819
820 2012-07-05  Dongwoo Im  <dw.im@samsung.com>
821
822         [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
823         https://bugs.webkit.org/show_bug.cgi?id=88608
824
825         Reviewed by Hajime Morita.
826
827         * Scripts/webkitperl/FeatureList.pm: Enable the CUSTOM_SCHEME_HANDLER feature as default.
828
829 2012-07-05  Ryuan Choi  <ryuan.choi@samsung.com>
830
831         [Wk2][EFL] EFL needs a WebKitTestRunner
832         https://bugs.webkit.org/show_bug.cgi?id=87659
833
834         Reviewed by Kenneth Rohde Christiansen.
835
836         Add an implementation of WebKitTestRunner for Efl port.
837
838         * CMakeLists.txt: Includes WebKitTestRunner build script.
839         * Scripts/build-webkittestrunner: Added knowledge of WebKitTestRunner/Efl.
840         * Scripts/webkitpy/layout_tests/port/efl.py: Ditto.
841         (EflPort.setup_environ_for_server):
842         * WebKitTestRunner/CMakeLists.txt: Added.
843         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
844         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Added.
845         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Added.
846         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Added.
847         * WebKitTestRunner/PlatformEfl.cmake: Added.
848         * WebKitTestRunner/PlatformWebView.h:
849         * WebKitTestRunner/TestController.cpp:
850         * WebKitTestRunner/config.h: Added knowledge of WebKitTestRunner/Efl.
851         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Added.
852         * WebKitTestRunner/efl/TestControllerEfl.cpp: Added.
853         * WebKitTestRunner/efl/main.cpp: Added.
854         (main):
855
856 2012-07-05  Christophe Dumez  <christophe.dumez@intel.com>
857
858         [WK2][EFL] Ewk_View needs API to load HTML data
859         https://bugs.webkit.org/show_bug.cgi?id=90540
860
861         Reviewed by Kenneth Rohde Christiansen.
862
863         Update EFL MiniBrowser to catch the "load,error" signal
864         on the view and display an error page.
865
866         * MiniBrowser/efl/main.c:
867         (on_error):
868         (browserCreate):
869
870 2012-07-05  Sergio Villar Senin  <svillar@igalia.com>
871
872         Hidden dirs are not copied when creating the built product archive
873         https://bugs.webkit.org/show_bug.cgi?id=90559
874
875         Reviewed by Carlos Garcia Campos.
876
877         Hidden dirs are not copied inside the built product archive
878         because the recursive copy command was ignoring them. We need those
879         hidden directories for the GTK WebKit2 testing bot to work fine.
880
881         * BuildSlaveSupport/built-product-archive:
882         (archiveBuiltProduct): replaced "*" by "." to include hidden
883         dirs/files.
884
885 2012-07-04  Yoshifumi Inoue  <yosin@chromium.org>
886
887         Unreviewed Chromium gardening, Disable always failed python tests on Windows.
888         https://bugs.webkit.org/show_bug.cgi?id=90587
889
890         PortTest.qt_linux and mac_lion are always failed on Chromium Windows at
891         creating child process.
892
893         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
894         (PortTest.disabled_test_qt_linux):
895         (PortTest.disabled_test_mac_lion):
896
897 2012-07-04  Yoshifumi Inoue  <yosin@chromium.org>
898
899         [Tools] webkit_unittest.py got assertion
900         https://bugs.webkit.org/show_bug.cgi?id=90579
901
902         Reviewed by Hajime Morita.
903
904         This patch updates expectation of assertion in test_skipped_directories_for_symbols().
905         r121874 added new (exclude) directory (inspector/styles/variables), however it didn't
906         update one of two assertions.
907
908         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
909
910 2012-07-04  Balazs Ankes  <bank@inf.u-szeged.hu>
911
912         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
913         https://bugs.webkit.org/show_bug.cgi?id=67935
914
915         Reviewed by Ryosuke Niwa.
916
917         * Scripts/webkitpy/common/checkout/changelog.py:
918         (ChangeLog.set_reviewer):
919         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
920         (test_set_reviewer):
921         (test_set_short_description_and_bug_url):
922
923 2012-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
924
925         Unreviewed, rolling out r121862.
926         http://trac.webkit.org/changeset/121862
927         https://bugs.webkit.org/show_bug.cgi?id=90569
928
929         It broke built-product-archive for GTK, Qt and EFL (Requested
930         by svillar on #webkit).
931
932         * BuildSlaveSupport/built-product-archive:
933         (archiveBuiltProduct):
934
935 2012-07-04  Sergio Villar Senin  <svillar@igalia.com>
936
937         Hidden dirs are not copied when creating the built product archive
938         https://bugs.webkit.org/show_bug.cgi?id=90559
939
940         Reviewed by Carlos Garcia Campos.
941
942         Hidden dirs are not copied inside the built product archive because
943         the recursive copy command was ignoring them. We need those hidden
944         directories for the GTK WebKit2 testing bot to work fine.
945
946         * BuildSlaveSupport/built-product-archive:
947         (archiveBuiltProduct): removed the trailing "*" from the copy
948         command.
949
950 2012-07-04  John Mellor  <johnme@chromium.org>
951
952         Text Autosizing: Add compile flag and runtime setting
953         https://bugs.webkit.org/show_bug.cgi?id=87394
954
955         This patch renames Font Boosting to Text Autosizing.
956
957         Reviewed by Adam Barth.
958
959         * Scripts/webkitperl/FeatureList.pm:
960         * qmake/mkspecs/features/features.pri:
961
962 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
963
964         [Qt] Replace deprecated IN_PWD with PWD
965
966         Reviewed by Csaba Osztrogonác.
967
968         * qmake/mkspecs/features/default_pre.prf:
969
970 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
971
972         [Qt] Don't try to build WTR twice
973
974         Reviewed by Csaba Osztrogonác.
975
976         * Tools.pro:
977
978 2012-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
979
980         Unreviewed, rolling out r121821.
981         http://trac.webkit.org/changeset/121821
982         https://bugs.webkit.org/show_bug.cgi?id=90551
983
984         This patch did not receive a high-quality review and has a
985         number of errors (Requested by abarth on #webkit).
986
987         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
988         (Build.results_url):
989         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
990         (ChromiumBuilder.accumulated_results_url):
991         * Scripts/webkitpy/layout_tests/port/builders.py:
992         * Scripts/webkitpy/tool/commands/rebaseline.py:
993         (AbstractParallelRebaselineCommand.__init__):
994         (Rebaseline):
995         (Rebaseline._builder_to_pull_from):
996         (Rebaseline._tests_to_update):
997         (Rebaseline.execute):
998         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
999         (test_rebaseline.mock_builder_to_pull_from):
1000         (test_rebaseline):
1001
1002 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1003
1004         [Qt] Get rid of un-needed QT += declarative for Qt 5
1005
1006         The declarative module has been renamed to quick1 in Qt 5, and the
1007         engine-only module for Qt 5 is named 'qml'. For many of the instances
1008         we could just remove 'declarative', since the project file was only
1009         used for Qt5/WebKit2 builds. In the other cases the module was wrapped
1010         in a haveQt(4) scope.
1011
1012         Reviewed by Csaba Osztrogonác.
1013
1014         * MiniBrowser/qt/MiniBrowser.pro:
1015         * WebKitTestRunner/InjectedBundle/Target.pri:
1016         * WebKitTestRunner/Target.pri:
1017
1018 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1019
1020         [Qt] Remove a few un-needed load(features) after r121777
1021
1022         The features are computed by configure.pro and cached in .qmake.cache.
1023
1024         Reviewed by Jocelyn Turcotte..
1025
1026         * MiniBrowser/qt/raw/Target.pri:
1027
1028 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1029
1030         [Qt] Use haveQtModule() in project files instead of manual checks
1031
1032         Reviewed by Jocelyn Turcotte.
1033
1034         * qmake/mkspecs/features/default_pre.prf:
1035         * qmake/mkspecs/features/features.prf:
1036
1037 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1038
1039         [Qt] Fix haveQtModule() check
1040
1041         Without {} brackets we were pulling out the value of the module.name variable.
1042
1043         Reviewed by Jocelyn Turcotte.
1044
1045         * qmake/mkspecs/features/functions.prf:
1046
1047 2012-07-04  Sergio Villar Senin  <svillar@igalia.com>
1048
1049         [WK2] [GTK] WK2 testing bot unable to find the InjectedBundle library
1050         https://bugs.webkit.org/show_bug.cgi?id=90541
1051
1052         Reviewed by Carlos Garcia Campos.
1053
1054         We must add the contents of WebKitBuild/*/Libraries/ directory to
1055         the file to be uploaded to b.w.o to successfully run WebKit2 tests
1056         in the WebKit2 testing bot.
1057
1058         * BuildSlaveSupport/built-product-archive:
1059         (archiveBuiltProduct): appended Libraries to the list of
1060         neededDirectories.
1061
1062 2012-07-04  Sergio Villar Senin  <svillar@igalia.com>
1063
1064         [GTK] WebKit2 testing bot unable to find the build directory
1065         https://bugs.webkit.org/show_bug.cgi?id=90523
1066
1067         Reviewed by Carlos Garcia Campos.
1068
1069         The presence of GNUmakefile was used to determine whether a given
1070         directory was a valid build directory or not. That's not correct for
1071         testing bots as we export only the minimum required stuff to run the
1072         tests.
1073
1074         * gtk/common.py:
1075         (get_build_path.is_valid_build_directory): added an extra check.:
1076
1077 2012-07-04  Joe Thomas  <joethomas@motorola.com>
1078
1079         Adding myself to committers list.
1080
1081         Unreviewed.
1082
1083         * Scripts/webkitpy/common/config/committers.py:
1084
1085 2012-07-03  Christophe Dumez  <christophe.dumez@intel.com>
1086
1087         [WK2][EFL] Ewk_View should report the load progress
1088         https://bugs.webkit.org/show_bug.cgi?id=90457
1089
1090         Reviewed by Kenneth Rohde Christiansen.
1091
1092         Update EFL MiniBrowser so that it listens for the
1093         "load,progress" on the Ewk_View and updates its
1094         window title accordingly.
1095
1096         * MiniBrowser/efl/main.c:
1097         (title_set):
1098         (on_title_changed):
1099         (on_progress):
1100         (browserCreate):
1101
1102 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
1103
1104         disable failing mock-chromium-mac python unit tests
1105
1106         Unreviewed, build fix.
1107
1108         Disable these tests until I can figure out why they're failing
1109         on the bots.
1110
1111         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1112         (PortTest.disabled_test_chromium_mac_lion):
1113         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
1114
1115 2012-07-03  Ian Vollick  <vollick@chromium.org>
1116
1117         Add vollick to the list of committers
1118         https://bugs.webkit.org/show_bug.cgi?id=90512
1119
1120         Reviewed by Adrienne Walker.
1121
1122         * Scripts/webkitpy/common/config/committers.py:
1123
1124 2012-07-03  Ojan Vafai  <ojan@chromium.org>
1125
1126         Improve webkit-patch rebaseline to work for more cases
1127         https://bugs.webkit.org/show_bug.cgi?id=90504
1128
1129         Reviewed by Dirk Pranke.
1130
1131         -Makes it work for the build.chromium.org bots.
1132         -Lets you rebaseline all builders instead of just one.
1133         -Lets you pass in the builder or test to rebaseline.
1134
1135         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1136         (Build.results_url):
1137         Make this work for build.chromium.org builders as well.
1138
1139         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
1140         (ChromiumBuilder):
1141         (ChromiumBuilder.latest_cached_build):
1142         ChromiumBuilder doesn't support large parts of the Builder interface.
1143         This provides the bare minimum for this patch to work. Eventually,
1144         we should create a single interface that can be supported for both
1145         sets of buildbots.
1146
1147         * Scripts/webkitpy/layout_tests/port/builders.py:
1148         (builder_path_from_name):
1149         (all_builder_names):
1150         memoizing here is incorrect because the test override _exact_matches,
1151         so these can return different values. In either case, I'm pretty sure these
1152         are not remotely hot codepaths.
1153
1154         * Scripts/webkitpy/tool/commands/rebaseline.py:
1155         (AbstractParallelRebaselineCommand.__init__):
1156         (Rebaseline):
1157         (Rebaseline.__init__):
1158         (Rebaseline._builders_to_pull_from):
1159         (Rebaseline._builder_with_name):
1160         (Rebaseline._tests_to_update):
1161         (Rebaseline.execute):
1162         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1163         (test_rebaseline.mock_builders_to_pull_from):
1164         (test_rebaseline):
1165         (test_rebaseline_command_line_flags):
1166         (test_rebaseline_multiple_builders):
1167         (test_rebaseline_multiple_builders.mock_builders_to_pull_from):
1168         (test_rebaseline_multiple_builders.mock_tests_to_update):
1169
1170 2012-07-03  Christophe Dumez  <christophe.dumez@intel.com>
1171
1172         [EFL] Enable CSS variables support at compile time
1173         https://bugs.webkit.org/show_bug.cgi?id=90448
1174
1175         Reviewed by Kenneth Rohde Christiansen.
1176
1177         Turn on CSS_VARIABLES flag by default on EFL port.
1178
1179         * Scripts/webkitperl/FeatureList.pm:
1180
1181 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
1182
1183         nrwt: clean up exception handling and make sure we log some more failures
1184         https://bugs.webkit.org/show_bug.cgi?id=90503
1185
1186         Reviewed by Ojan Vafai.
1187
1188         There were several places where exceptions weren't getting
1189         logged, most notably if you passed a bad value to --platform.
1190         This change tests that and cleans things up a bit; more cleanup
1191         will be possible when we rework the manager_worker_broker code.
1192
1193         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1194         (_BrokerConnection.raise_exception):
1195         (_InlineWorkerConnection.raise_exception):
1196         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1197         (Worker.run):
1198         (Worker.kill_driver):
1199         * Scripts/webkitpy/layout_tests/port/factory.py:
1200         (PortFactory.get):
1201         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1202         (run):
1203         (main):
1204         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1205         (MainTest.test_unsupported_platfrom):
1206
1207 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
1208
1209         nrwt: fix mock port
1210         https://bugs.webkit.org/show_bug.cgi?id=90500
1211
1212         Reviewed by Ojan Vafai.
1213
1214         The MockDRT code was never updated when we switched the chromium
1215         ports to using "drt mode" by default. This change updates that
1216         code, fixes a typo in the chromium port that went undetected
1217         (default_test_timeout_ms -> default_timeout_ms), and adds tests
1218         that actually exercise some of the mock ports. These tests are
1219         useful in that they will exercise the port-specific code in an
1220         end-to-end-manner, but they are a bit slow for some reason (>1s
1221         each) that I need to look into.
1222
1223         * Scripts/webkitpy/layout_tests/port/chromium.py:
1224         (ChromiumDriver.stop):
1225         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1226         (ChromiumAndroidPort.default_timeout_ms):
1227         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1228         (TestChromiumAndroidPort.test_default_timeout_ms):
1229         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1230         (main):
1231         (parse_options):
1232         (MockTestShell):
1233         (MockTestShell.output_for_test):
1234         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1235         (MockDRTTest.assertTest):
1236         (MockTestShellTest):
1237         (MockTestShellTest.make_drt):
1238         (MockTestShellTest.test_test_shell_parse_options):
1239         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1240         (PortTest):
1241         (PortTest.assert_mock_port_works):
1242         (PortTest.test_chromium_mac_lion):
1243         (PortTest.test_chromium_mac_lion_in_test_shell_mode):
1244         (PortTest.test_qt_linux):
1245         (PortTest.test_mac_lion):
1246
1247 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
1248
1249         nrwt: make the worker class stand alone with a cleaner interface
1250         https://bugs.webkit.org/show_bug.cgi?id=90409
1251
1252         Reviewed by Ojan Vafai.
1253
1254         Currently the Worker class derives from AbstractWorker, which is
1255         kind of crufty and awkward; it would be better if we did not
1256         rely on shared state.
1257
1258         This change changes that so that Worker derives from object, and
1259         exposes the following interface:
1260           __init__() - called in the manager process
1261           safe_init() - called in the worker process to initialize
1262             unpicklable state
1263           handle() - a single routine to handle all messages
1264           cleanup() - called so the worker can clean up
1265
1266         Also, all of the "administrative" messages that are handled by
1267         the worker (notification of start/stop/etc.) move into
1268         manager_worker_broker - this reduces worker.py to just handling
1269         the mechanics of actually running each test.
1270
1271         For the moment, we do this by creating Yet Another wrapper/proxy
1272         class in manager_worker_broker, but this will get simpler
1273         shortly when the rest of m_w_b is cleaned up.
1274
1275         With this change worker is now in its new form but there will be
1276         a follow-on change that cleans up some names and other minor
1277         things.
1278
1279         This change is again mostly just moving things around and should
1280         be covered by the (updated) existing tests.
1281
1282         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1283         (get):
1284         (AbstractWorker.__init__):
1285         (AbstractWorker.run):
1286         (AbstractWorker):
1287         (AbstractWorker.handle_stop):
1288         (AbstractWorker.handle_test_list):
1289         (AbstractWorker.yield_to_broker):
1290         (AbstractWorker.post_message):
1291         (_WorkerConnection.__init__):
1292         (_Process.run):
1293         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1294         (_TestWorker):
1295         (_TestWorker.__init__):
1296         (_TestWorker.name):
1297         (_TestWorker.cleanup):
1298         (_TestWorker.handle):
1299         (_TestWorker.safe_init):
1300         (_TestWorker.stop):
1301         (_TestsMixin.handle_finished_test):
1302         (_TestsMixin.setUp):
1303         (_TestsMixin.test_cancel):
1304         (_TestsMixin.test_done):
1305         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1306         (Worker):
1307         (Worker.__init__):
1308         (Worker.safe_init):
1309         (Worker.handle):
1310
1311 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
1312
1313         nrwt: moving child process logging code into manager_worker_broker
1314         https://bugs.webkit.org/show_bug.cgi?id=90408
1315
1316         Reviewed by Ojan Vafai.
1317
1318         Users of manager_worker_broker should not have to be aware of
1319         whether they're in the same process or different processes and
1320         configure logging themselves; mwb should hide this complexity.
1321         We can't quite do this completely/correctly yet, since the
1322         manager expects to get a list of messages to log, but this
1323         change fixes the worker side of it, at least.
1324
1325         This is just moving code around, there is no new functionality
1326         and this should be covered by existing tests.
1327
1328         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1329         (AbstractWorker.__init__):
1330         (_WorkerConnection.__init__):
1331         (_WorkerConnection.post_message):
1332         (_WorkerConnection):
1333         (_WorkerConnection.set_up_logging):
1334         (_WorkerConnection.clean_up_logging):
1335         (_InlineWorkerConnection.run):
1336         (_MultiProcessWorkerConnection.run):
1337         (_WorkerLogHandler):
1338         (_WorkerLogHandler.__init__):
1339         (_WorkerLogHandler.emit):
1340         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1341         (_TestWorker.run):
1342         (_TestsMixin.handle_done):
1343         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1344         (Worker.__init__):
1345         (Worker.run):
1346         (Worker._run_test):
1347         (Worker.cleanup):
1348         (Worker.run_single_test):
1349
1350 2012-07-03  Tony Chang  <tony@chromium.org>
1351
1352         [chromium] Don't archive build files generated by VS2010
1353         https://bugs.webkit.org/show_bug.cgi?id=90493
1354
1355         Reviewed by Ojan Vafai.
1356
1357         In particular, the pch (pre compiled header) files are gigantic, making
1358         release.zip almost a 1gb in size.
1359
1360         * BuildSlaveSupport/built-product-archive:
1361         (archiveBuiltProduct):
1362
1363 2012-07-03  Tony Chang  <tony@chromium.org>
1364
1365         [chromium] Unreviewed, update .gitignore to handle VS2010 files.
1366
1367         * .gitignore:
1368         * DumpRenderTree/DumpRenderTree.gyp/.gitignore:
1369         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore:
1370
1371 2012-07-03  Ojan Vafai  <ojan@chromium.org>
1372
1373         Have webkit-patch rebaseline use rebaseline-test-internal
1374         https://bugs.webkit.org/show_bug.cgi?id=90491
1375
1376         Reviewed by Dirk Pranke.
1377
1378         This lets it handle new files, reduces duplicate code and lays the
1379         groundwork for making rebaseline have a richer interface.
1380
1381         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1382         (MockBuild):
1383         (MockBuild.__init__):
1384         (MockBuilder.build):
1385         * Scripts/webkitpy/tool/commands/rebaseline.py:
1386         (AbstractParallelRebaselineCommand._files_to_add):
1387         (Rebaseline):
1388         (Rebaseline._builder_to_pull_from):
1389         (Rebaseline._tests_to_update):
1390         (Rebaseline.execute):
1391         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1392         (test_overrides_are_included_correctly):
1393         (test_rebaseline):
1394         (test_rebaseline.mock_builder_to_pull_from):
1395         (test_rebaseline.mock_tests_to_update):
1396
1397 2012-07-03  Ojan Vafai  <ojan@chromium.org>
1398
1399         Rename rebaseline-test to rebaseline-test-internal
1400         https://bugs.webkit.org/show_bug.cgi?id=90485
1401
1402         Reviewed by Adam Barth.
1403
1404         It's now only used by other rebaseline commands. It's still useful to leave it
1405         as it's own command to aid in debugging when something goes wrong. In a followup
1406         patch, I'll make webkit-patch rebaseline cover any use-cases that rebaseline-test
1407         might have covered.
1408
1409         We no longer need the --print-scm-changes option since the only caller always passes
1410         that option in.
1411
1412         Also, make all the arguments command-line flags instead. Simplifies the code
1413         a bit in my opinion.
1414
1415         * Scripts/webkitpy/tool/commands/rebaseline.py:
1416         (RebaselineTest):
1417         (RebaselineTest.__init__):
1418         (RebaselineTest.execute):
1419         (AbstractParallelRebaselineCommand._rebaseline_commands):
1420         (RebaselineExpectations.execute):
1421         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1422         (test_rebaseline_all):
1423
1424 2012-07-03  Balazs Kelemen  <kbalazs@webkit.org>
1425
1426         [Qt][WTR] Get rid of using DumpRenderTreeSupportQt
1427         https://bugs.webkit.org/show_bug.cgi?id=90262
1428
1429         Unreviewed build fix.
1430
1431         Reverting r121550 manually because it caused build
1432         break on ARM and Mac. It turned out that the Qt build
1433         system is too broken for this change now, first we have
1434         to address two issues:
1435             * symbol hiding was forbidden accidentally on x86 Linux
1436             * Qt lacks a separate library for test support
1437
1438         * Tools.pro:
1439         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1440         (WTR::InjectedBundlePage::resetAfterTest):
1441         (WTR::InjectedBundlePage::didClearWindowForFrame):
1442         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1443
1444 2012-07-03  Tony Chang  <tony@chromium.org>
1445
1446         [chromium] Handle trailing backslash on %VSINSTALLDIR%
1447         https://bugs.webkit.org/show_bug.cgi?id=90410
1448
1449         Reviewed by Ojan Vafai.
1450
1451         * Scripts/webkitdirs.pm:
1452         (buildChromiumVisualStudioProject): Handle VSINSTALLDIR ending in a backslash, the backslash escapes the closing double quote.
1453
1454 2012-07-02  Ojan Vafai  <ojan@chromium.org>
1455
1456         Make the skia_test_expectations.txt file optional.
1457         https://bugs.webkit.org/show_bug.cgi?id=90400
1458
1459         Reviewed by Dirk Pranke.
1460
1461         It used to be optional. This regressed at some point. It's important that it be
1462         optional so that webkit-patch commands work in a pure-webkit checkout for chromium bots.
1463         Specifically, this was breaking webkit-patch rebaseline-test when it would go to update
1464         TestExpectations.
1465
1466         * Scripts/webkitpy/layout_tests/port/chromium.py:
1467         (ChromiumPort.expectations_files):
1468         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1469         (ChromiumDriverTest.test_expectations_dict):
1470
1471 2012-07-03  Raphael Kubo da Costa  <rakuco@webkit.org>
1472
1473         [jhbuild][EFL] Bump libffi dependency.
1474         https://bugs.webkit.org/show_bug.cgi?id=85373
1475
1476         Reviewed by Gustavo Noronha Silva.
1477
1478         Update libffi to 3.0.11, which fixes the build on some platforms
1479         where 3.0.10 had problems.
1480
1481         * efl/jhbuild.modules:
1482
1483 2012-07-03  George Staikos  <staikos@webkit.org>
1484
1485         [BlackBerry] Enable microdata support for BlackBerry.
1486         https://bugs.webkit.org/show_bug.cgi?id=90429
1487
1488         Reviewed by Rob Buis.
1489
1490         * Scripts/webkitperl/FeatureList.pm:
1491
1492 2012-07-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1493
1494         [Qt] Make use of .qmake.cache for caching features
1495
1496         Instead of loading() features from the files that need them (and re-running
1497         a bunch of checks), we now run feature detection as part of configure.pro,
1498         and have build-webkit write the computed feature-defines and CONFIG to
1499         .qmake.cache, which is then loaded by qmake _before_ even defaults_pre
1500         when building WebKit.pro.
1501
1502         At some point we'll be able to selectivly prevent running of config tests
1503         in configure.pro, which means we don't need a separate code-path for
1504         the build-webkit --help case.
1505
1506         We should also move the code in build-webkit that now uses .webkit.config
1507         to detect clean builds, to use .qmake.cache, since we now store the same
1508         thing there.
1509
1510         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
1511
1512         Reviewed by Tor Arne Vestbø.
1513
1514         * DumpRenderTree/qt/DumpRenderTree.pro:
1515         * QtTestBrowser/QtTestBrowser.pro:
1516         * Scripts/webkitdirs.pm:
1517         (qtFeatureDefaults):
1518         (buildQMakeProjects):
1519         * Tools.pro:
1520         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1521         * WebKitTestRunner/InjectedBundle/Target.pri:
1522         * WebKitTestRunner/Target.pri:
1523         * qmake/.qmake.conf: Added.
1524         * qmake/configure.pro:
1525         * qmake/mkspecs/features/default_post.prf:
1526         * qmake/mkspecs/features/default_pre.prf:
1527         * qmake/mkspecs/features/features.prf:
1528
1529 2012-07-03  Nico Weber  <thakis@chromium.org>
1530
1531         -Wunused-private-field cleanup, linux edition
1532         https://bugs.webkit.org/show_bug.cgi?id=90463
1533
1534         Reviewed by Stephen White.
1535
1536         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1537         * DumpRenderTree/chromium/GamepadController.h:
1538         (GamepadController):
1539         * DumpRenderTree/chromium/NotificationPresenter.h:
1540         (NotificationPresenter::NotificationPresenter):
1541         (NotificationPresenter):
1542
1543 2012-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1544
1545         Unreviewed, rolling out r121766.
1546         http://trac.webkit.org/changeset/121766
1547         https://bugs.webkit.org/show_bug.cgi?id=90465
1548
1549         It caused flakey build errors on the bots (Requested by Ossy
1550         on #webkit).
1551
1552         * DumpRenderTree/qt/DumpRenderTree.pro:
1553         * QtTestBrowser/QtTestBrowser.pro:
1554         * Scripts/webkitdirs.pm:
1555         (qtFeatureDefaults):
1556         (buildQMakeProjects):
1557         * Tools.pro:
1558         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1559         * WebKitTestRunner/InjectedBundle/Target.pri:
1560         * WebKitTestRunner/Target.pri:
1561         * qmake/.qmake.conf: Removed.
1562         * qmake/configure.pro:
1563         * qmake/mkspecs/features/default_post.prf:
1564         * qmake/mkspecs/features/default_pre.prf:
1565         * qmake/mkspecs/features/features.prf:
1566
1567 2012-07-03  George Staikos  <staikos@webkit.org>
1568
1569         [BlackBerry] Enable Custom Scheme Handlers for BlackBerry.
1570         https://bugs.webkit.org/show_bug.cgi?id=90422
1571
1572         Reviewed by Rob Buis.
1573
1574         * Scripts/webkitperl/FeatureList.pm:
1575
1576 2012-07-03  George Staikos  <staikos@webkit.org>
1577
1578         [BlackBerry] Enable RegisterProtocolHandler for BlackBerry.
1579         https://bugs.webkit.org/show_bug.cgi?id=90422
1580
1581         Reviewed by Rob Buis.
1582
1583         * Scripts/webkitperl/FeatureList.pm:
1584
1585 2012-07-03  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1586
1587         [EFL] Add run API tests as a step on the build bots
1588         https://bugs.webkit.org/show_bug.cgi?id=87252
1589
1590         Reviewed by Daniel Bates.
1591
1592         Run EFL API test suite on the build bots.
1593
1594         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1595         (RunEflAPITests):
1596         (TestFactory.__init__):
1597         (BuildAndTestFactory.__init__):
1598         * Scripts/run-efl-tests: Added.
1599
1600 2012-07-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1601
1602         [Qt] Make use of .qmake.cache for caching features
1603
1604         Instead of loading() features from the files that need them (and re-running
1605         a bunch of checks), we now run feature detection as part of configure.pro,
1606         and have build-webkit write the computed feature-defines and CONFIG to
1607         .qmake.cache, which is then loaded by qmake _before_ even defaults_pre
1608         when building WebKit.pro.
1609
1610         At some point we'll be able to selectivly prevent running of config tests
1611         in configure.pro, which means we don't need a separate code-path for
1612         the build-webkit --help case.
1613
1614         We should also move the code in build-webkit that now uses .webkit.config
1615         to detect clean builds, to use .qmake.cache, since we now store the same
1616         thing there.
1617
1618         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
1619
1620         Reviewed by Tor Arne Vestbø.
1621
1622         * DumpRenderTree/qt/DumpRenderTree.pro:
1623         * QtTestBrowser/QtTestBrowser.pro:
1624         * Scripts/webkitdirs.pm:
1625         (qtFeatureDefaults):
1626         (buildQMakeProjects):
1627         * Tools.pro:
1628         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1629         * WebKitTestRunner/InjectedBundle/Target.pri:
1630         * WebKitTestRunner/Target.pri:
1631         * qmake/.qmake.conf: Added.
1632         * qmake/configure.pro:
1633         * qmake/mkspecs/features/default_post.prf:
1634         * qmake/mkspecs/features/default_pre.prf:
1635         * qmake/mkspecs/features/features.prf:
1636
1637 2012-07-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>  Joel Dillon <joel.dillon@codethink.co.uk>
1638
1639         [Qt][Win] Fix broken QtWebKit5.lib linking
1640         https://bugs.webkit.org/show_bug.cgi?id=88321
1641
1642         Reviewed by Kenneth Rohde Christiansen.
1643
1644         On windows the import/export definition is part of the symbol's signature.
1645         Define STATICALLY_LINKED_WITH_$$library for each dependend module
1646         that is being linked statically to make sure that they can be linked together
1647         later on.
1648
1649         Also do not compile Assertions.cpp in DumpRenderTree anymore since all the
1650         used symbols are exported and it would cause a duplicate symbols error.
1651
1652         * DumpRenderTree/qt/DumpRenderTree.pro:
1653         * qmake/mkspecs/features/default_post.prf:
1654
1655 2012-07-03  Szilard Ledan  <szledan@inf.u-szeged.hu>
1656
1657         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
1658         https://bugs.webkit.org/show_bug.cgi?id=89001
1659
1660         Reviewed by Csaba Osztrogonác.
1661
1662         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1663         (UploadBuiltProduct.__init__):
1664         (UploadTestResults.__init__):
1665         (ExtractTestResults.__init__):
1666         (Factory.__init__):
1667         (BuildFactory.__init__):
1668         (TestFactory.__init__):
1669         (BuildAndTestFactory.__init__):
1670         (BuildAndPerfTestFactory.__init__):
1671         (BuildAndPerfTestWebKit2Factory.__init__):
1672         (DownloadAndPerfTestFactory.__init__):
1673
1674 2012-07-03  Ádám Kallai  <kadam@inf.u-szeged.hu>
1675
1676         Update unit test after r121724.
1677         https://bugs.webkit.org/show_bug.cgi?id=90444
1678
1679         Reviewed by Csaba Osztrogonác.
1680
1681         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1682         (GardeningServerTest.test_rebaseline_new_port):
1683
1684 2012-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1685
1686         Unreviewed, rolling out r121749.
1687         http://trac.webkit.org/changeset/121749
1688         https://bugs.webkit.org/show_bug.cgi?id=90441
1689
1690         Tests crash on the paralel NRWT Qt bot (Requested by Ossy on
1691         #webkit).
1692
1693         * Scripts/webkitpy/layout_tests/port/qt.py:
1694         (QtPort._build_driver):
1695         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1696         (XvfbDriver._start):
1697         (XvfbDriver._start.x_filter):
1698         (XvfbDriver.stop):
1699
1700 2012-07-03  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1701
1702         [NRWT] XvfbDriver should choose the next free display
1703         https://bugs.webkit.org/show_bug.cgi?id=88414
1704
1705         Reviewed by Dirk Pranke.
1706
1707         * Scripts/webkitpy/layout_tests/port/qt.py:
1708         (QtPort._driver_class):
1709         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1710         (XvfbDriver.__init__):
1711         (XvfbDriver._start):
1712         (XvfbDriver._start.next_free_id):
1713         (XvfbDriver.stop):
1714
1715 2012-07-03  Christophe Dumez  <christophe.dumez@intel.com>
1716
1717         [EFL] Enable MICRODATA support
1718         https://bugs.webkit.org/show_bug.cgi?id=90377
1719
1720         Reviewed by Kenneth Rohde Christiansen.
1721
1722         Turn on MICRODATA flag for EFL port by default.
1723
1724         * Scripts/webkitperl/FeatureList.pm:
1725
1726 2012-07-02  George Staikos  <staikos@webkit.org>
1727
1728         [BlackBerry] Enable scoped style for BlackBerry.
1729         https://bugs.webkit.org/show_bug.cgi?id=90418
1730
1731         Reviewed by Rob Buis.
1732
1733         * Scripts/webkitperl/FeatureList.pm:
1734
1735 2012-07-02  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1736
1737         [BlackBerry] Use PUBLIC_BUILD to enable/disable DRT
1738         https://bugs.webkit.org/show_bug.cgi?id=90271
1739
1740         Reviewed by George Staikos.
1741
1742         RIM PR #154707
1743
1744         Currently DRT code will be compiled only if ENABLE_DRT is set, and it's not
1745         defined by default.
1746         We should enable DRT by default unless PUBLIC_BUILD is set. In this way we don't
1747         need to rebuild webkit before running DRT.
1748
1749         * Scripts/webkitdirs.pm:
1750         (blackberryCMakeArguments):
1751
1752 2012-07-02  Ojan Vafai  <ojan@chromium.org>
1753
1754         webkit-patch rebaseline-expectations should share code with rebaseline-all
1755         https://bugs.webkit.org/show_bug.cgi?id=90413
1756
1757         Reviewed by Dirk Pranke.
1758
1759         Make them share code. In addition to reducing code duplication this makes
1760         rebaseline-expectations considerably faster by rebaselining in parallel.
1761
1762         * Scripts/webkitpy/tool/commands/rebaseline.py:
1763         (AbstractParallelRebaselineCommand):
1764         (AbstractParallelRebaselineCommand._run_webkit_patch):
1765         (AbstractParallelRebaselineCommand._rebaseline):
1766         (RebaselineJson):
1767         (RebaselineJson.execute):
1768         (RebaselineExpectations):
1769         (RebaselineExpectations._update_expectations_file):
1770         (RebaselineExpectations._tests_to_rebaseline):
1771         (RebaselineExpectations._add_tests_to_rebaseline_for_port):
1772         (RebaselineExpectations.execute):
1773         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1774         (test_rebaseline_all):
1775         (test_rebaseline_expectations.run_in_parallel):
1776         (test_rebaseline_expectations):
1777
1778 2012-07-02  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1779
1780         [BlackBerry] Update DumpRenderTree to have it work interactively in parallel
1781         https://bugs.webkit.org/show_bug.cgi?id=88326
1782
1783         Reviewed by Rob Buis.
1784
1785         1. Test name is sent to torch-launcher via PPS message(from host machine).
1786            So we get test list by monitoring and receiving PPS message instead of
1787            reading file index.drt.
1788         2. Torch-launcher create a <test file>.done file when it finished a test.
1789         3. We don't need to search for Ref-tests in DumpRenderTree.cpp any more. NRWT
1790            will get them for us.
1791
1792         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1793         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
1794         (BlackBerry::WebKit::DumpRenderTree::doneDrt):
1795         (BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
1796         (BlackBerry::WebKit::DumpRenderTree::ensurePPS):
1797         (WebKit):
1798         (BlackBerry::WebKit::DumpRenderTree::handlePPSData):
1799         (BlackBerry::WebKit::DumpRenderTree::waitForTest):
1800         (BlackBerry::WebKit::DumpRenderTree::runTests):
1801         (BlackBerry::WebKit::DumpRenderTree::dump):
1802         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1803         (DumpRenderTree):
1804
1805 2012-07-02  Adam Barth  <abarth@webkit.org>
1806
1807         Remove flashplugin-installer from the EWS image because it causes some tests to crash
1808         https://bugs.webkit.org/show_bug.cgi?id=90403
1809
1810         Reviewed by Tony Chang.
1811
1812         * EWSTools/cold-boot.sh:
1813
1814 2012-07-02  Leandro Gracia Gil  <leandrogracia@chromium.org>
1815
1816         [Chromium] Implement a Layout Test for editing/SurroundingText
1817         https://bugs.webkit.org/show_bug.cgi?id=82461
1818
1819         Reviewed by Ryosuke Niwa.
1820
1821         Add a new method to the layout test controller in order to retrieve the
1822         text surrounding a provided element.
1823
1824         * DumpRenderTree/chromium/LayoutTestController.cpp:
1825         (LayoutTestController::LayoutTestController):
1826         (LayoutTestController::textSurroundingElement):
1827         * DumpRenderTree/chromium/LayoutTestController.h:
1828         (LayoutTestController):
1829
1830 2012-07-02  Ojan Vafai  <ojan@chromium.org>
1831
1832         Delete unused rebaseline method in gardeningserver.py
1833         https://bugs.webkit.org/show_bug.cgi?id=90396
1834
1835         Reviewed by Eric Seidel.
1836
1837         As best I can tell, the only usage was in this unittest.
1838
1839         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1840         (GardeningHTTPRequestHandler.updateexpectations):
1841         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1842         (GardeningServerTest.test_rebaseline_new_port):
1843
1844 2012-07-02  Csaba Osztrogonác  <ossy@webkit.org>
1845
1846         REGRESSION(r121497): It switched off and broke many unittests
1847         https://bugs.webkit.org/show_bug.cgi?id=90371
1848
1849         Reviewed by Adam Barth.
1850
1851         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1852         (ChromiumMacPortTest): Use snowleopard as os_version instead of leopard, because it isn't supported anymore.
1853         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1854         (ChromiumPortTestCase.test_all_test_configurations): Remove leopard testcases, because it isn't supported anymore.
1855         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1856         (PortTestCase): Inherit class PortTestCase from unittest.TestCase instead of object.
1857
1858 2012-07-02  Ojan Vafai  <ojan@chromium.org>
1859
1860         Move rebaseline-all command from the gardening-server down into webkit-patch
1861         https://bugs.webkit.org/show_bug.cgi?id=90395
1862
1863         Reviewed by Adam Barth.
1864
1865         This is just moving code. It it in preparation for making rebaseline-expectations
1866         use the same code in order to get the parallelism benefits and reduces the amount
1867         of code we have for doing rebaselines.
1868
1869         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1870         (CheckoutTest.test_apply_patch):
1871         Updated due to the change to executive_mock.
1872         * Scripts/webkitpy/common/system/executive_mock.py:
1873         (MockExecutive.run_command):
1874         Update to print out the input passed to stdin.
1875         * Scripts/webkitpy/tool/commands/download_unittest.py:
1876         Updated due to executive_mock change.
1877         * Scripts/webkitpy/tool/commands/rebaseline.py:
1878         (RebaselineAll):
1879         (RebaselineAll._run_webkit_patch):
1880         (RebaselineAll._builders_to_fetch_from):
1881         (RebaselineAll._rebaseline_commands):
1882         (RebaselineAll._files_to_add):
1883         (RebaselineAll._optimize_baselines):
1884         (RebaselineAll._rebaseline):
1885         (RebaselineAll.execute):
1886         All this code is just copy-pasted except for mechanical changes
1887         (e.g. self.server.tool --> self._tool) and the reading in of the 
1888         JSON from stdin instead of the post body.
1889         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1890         (test_rebaseline_all):
1891         Copied the test-case out of gardeningserver_unittest.py.
1892         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1893         (GardeningHTTPRequestHandler):
1894         (GardeningHTTPRequestHandler.rebaseline):
1895         (GardeningHTTPRequestHandler.rebaselineall):
1896         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1897         (GardeningServerTest.test_rebaselineall):
1898         (GardeningServerTest.test_rebaselineall.run_command):
1899
1900 2012-07-02  Ojan Vafai  <ojan@chromium.org>
1901
1902         Remove Leopard support from the flakiness dashboard
1903         https://bugs.webkit.org/show_bug.cgi?id=90390
1904
1905         Reviewed by Adam Barth.
1906
1907         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1908         (nonChromiumPlatform):
1909         (chromiumPlatform):
1910         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1911         (test):
1912         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1913         * TestResultServer/static-dashboards/run-unittests.html:
1914
1915 2012-07-02  Ojan Vafai  <ojan@chromium.org>
1916
1917         Fix posting from garden-o-matic. This broke in moving away from jquery's ajax method
1918         in http://trac.webkit.org/changeset/121617.
1919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1920
1921 2012-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1922
1923         [GTK] Read fonts path when running layout tests from alternative fonts dir when main dir doesn't exist
1924         https://bugs.webkit.org/show_bug.cgi?id=89437
1925
1926         Reviewed by Martin Robinson.
1927
1928         If main fonts directory doesn't exist, try with an alternative
1929         fonts directory at build directory.
1930
1931         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1932         (getOutputDir):
1933         (getFontsPath):
1934         (initializeFonts):
1935         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1936         (WTR::getOutputDir):
1937         (WTR):
1938         (WTR::getFontsPath):
1939         (WTR::inititializeFontConfigSetting):
1940
1941 2012-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1942
1943         [GTK] Don't run the tests with jhbuild wrapper if it's already running under jhbuild
1944         https://bugs.webkit.org/show_bug.cgi?id=89435
1945
1946         Reviewed by Martin Robinson.
1947
1948         * Scripts/new-run-webkit-tests: Don't run the tests with the
1949         jhbuild wrapper if there isn't a Dependencies directory inside the
1950         build directory.
1951
1952 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
1953
1954         [Qt] Simplify detection of non-installed module file
1955
1956         Has the additional advantage that we do not rely on additional information.
1957
1958         Reviewed by Tor Arne Vestbø.
1959
1960         * qmake/qt_webkit.pri:
1961
1962 2012-07-01  Christophe Dumez  <christophe.dumez@intel.com>
1963
1964         [EFL] Add Gamepad support
1965         https://bugs.webkit.org/show_bug.cgi?id=90170
1966
1967         Reviewed by Kenneth Rohde Christiansen.
1968
1969         * Scripts/webkitperl/FeatureList.pm: Turn on GAMEPAD flag
1970         by default for EFL port.
1971         * efl/jhbuild.modules: Bump dependency versions of EFL libs
1972         since the latest Eeze is required for gamepad support.
1973
1974 2012-07-01  Adam Barth  <abarth@webkit.org>
1975
1976         Unreviewed.
1977
1978         Using the default start cylinder for fdisk causes a warning about the
1979         partition not starting on physical sector boundary.  The Ubuntu forums
1980         recommend using a number that's divisible by 8, which is what we do in
1981         this patch.
1982
1983         * EWSTools/cold-boot.sh:
1984
1985 2012-07-01  Adam Barth  <abarth@webkit.org>
1986
1987         Unreviewed.
1988
1989         It turns out we need to use Ubuntu 10.04 to get the right image results
1990         for chromium-linux. This patch updates our scripts to be compatible
1991         with Ubuntu 10.04.
1992
1993         * EWSTools/cold-boot.sh:
1994             - fdisk doesn't have p and 1 as default commands in 10.04.
1995         * EWSTools/start-queue.sh:
1996             - git doesn't understanding the -B argument in 10.04. We've been
1997               using this change locally on the EC2 bots for a while.
1998
1999 2012-07-01  Adam Barth  <abarth@webkit.org>
2000
2001         Unreviewed.
2002
2003         * EWSTools/boot.sh:
2004             - We need to start the screen in detached mode so that we can run
2005               it remotely via ssh.
2006
2007 2012-07-01  Adam Barth  <abarth@webkit.org>
2008
2009         Unreviewed.
2010
2011         * EWSTools/cold-boot.sh:
2012             - Turns out we need to sudo this command in order for it to
2013               actually dimiss the EULA screen. :)
2014
2015 2012-06-29  Adam Barth  <abarth@webkit.org>
2016
2017         Turns out we need zip too.
2018
2019         * EWSTools/cold-boot.sh:
2020
2021 2012-06-29  Adam Barth  <abarth@webkit.org>
2022
2023         Add a cold-boot.sh script for the EWS
2024         https://bugs.webkit.org/show_bug.cgi?id=90330
2025
2026         Unreviewed.
2027
2028         * EWSTools/cold-boot.sh: Added.
2029             - This script can take us from a cold GCE instance to a running EWS
2030               bot in one fell swoop.
2031         * EWSTools/start-queue.sh:
2032             - The if-block at the top of this script was causing trouble. I
2033               removed it from the bots a while ago. Now that we're using SVN to
2034               cold-boot the EWS bots, we need to make this change in the repo.
2035
2036 2012-06-29  Luiz Agostini  <luiz.agostini@nokia.com>
2037
2038         [Qt][WK2] Private non-QtQuick API
2039         https://bugs.webkit.org/show_bug.cgi?id=84532
2040
2041         MiniBrowserRaw is an usage example for the QRawWebView API.
2042         It is only an example and is not fully implemented.
2043
2044         Reviewed by Noam Rosenthal.
2045
2046         * MiniBrowser/qt/raw/DerivedSources.pri: Added.
2047         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Added.
2048         * MiniBrowser/qt/raw/Target.pri: Added.
2049         * MiniBrowser/qt/raw/View.cpp: Added.
2050         * MiniBrowser/qt/raw/View.h: Added.
2051         * Scripts/webkitpy/style/checker.py:
2052         * Tools.pro:
2053
2054 2012-06-29  Ojan Vafai  <ojan@chromium.org>
2055
2056         Remove leopard bots from garden-o-matic
2057         https://bugs.webkit.org/show_bug.cgi?id=90328
2058
2059         Reviewed by Adam Barth.
2060
2061         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2062         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2063         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2064
2065 2012-06-29  Ojan Vafai  <ojan@chromium.org>
2066
2067         garden-o-matic broken: TypeError: 'undefined' is not an object (evaluating 'buildLocations[currentIndex].url')
2068         https://bugs.webkit.org/show_bug.cgi?id=90243
2069
2070         Reviewed by Dirk Pranke.
2071
2072         jQuery was trying to be too smart and parsing the jsonp as json because of it's content-type.
2073         Excise jQuery and just use XHR directly since it's easier to maintain something where we control it
2074         all.
2075
2076         Not really sure how to unittest this. I tested it all manually of course.
2077
2078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
2079         Made net.ajax a drop-in replacement for the features of $.ajax that we were using.
2080         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2081         Not related to this patch, but figured I'd update the failing test while I was at it.
2082
2083 2012-06-29  Yaron Friedman  <yfriedman@chromium.org>
2084
2085         Fix layout test runner for Android after https://bugs.webkit.org/show_bug.cgi?id=88134
2086         https://bugs.webkit.org/show_bug.cgi?id=90309
2087
2088         Reviewed by Adam Barth.
2089
2090         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2091         (ChromiumAndroidPort.start_http_server):
2092
2093 2012-06-29  James Weatherall  <wez@chromium.org>
2094
2095         NPObjectWrapper may not address all window script object lifetime issues
2096         https://bugs.webkit.org/show_bug.cgi?id=85679
2097
2098         TestNetscapePlugin now has a leak-window-scriptable-object test which takes a reference to the window script object, and a second reference to it via the "self" property, and does not release those references. This is used to simulate a leaky plugin in layout tests of the NPAPI scripting interface glue code.
2099
2100         Reviewed by Nate Chapin.
2101
2102         * DumpRenderTree/DumpRenderTree.gypi:
2103         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2104         (PluginTest::NPN_GetProperty):
2105         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2106         (PluginTest):
2107         * DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Added.
2108         (LeakWindowScriptableObject):
2109         (LeakWindowScriptableObject::LeakWindowScriptableObject):
2110         (LeakWindowScriptableObject::NPP_New):
2111
2112 2012-06-29  Dirk Pranke  <dpranke@chromium.org>
2113
2114         webkitpy: add comment about how determine_full_port_name() works for apple ports, fix -wk2 bug
2115         https://bugs.webkit.org/show_bug.cgi?id=90314
2116
2117         Reviewed by Ojan Vafai.
2118
2119         Add comments and fix a bug in how we would handle the mac-wk2
2120         and win-wk2 port names after confusion around in bug 90312 :).
2121
2122         * Scripts/webkitpy/layout_tests/port/apple.py:
2123         (ApplePort.determine_full_port_name):
2124
2125 2012-06-29  Dirk Pranke  <dpranke@chromium.org>
2126
2127         webkitpy: remove support for mac leopard from chromium configurations
2128         https://bugs.webkit.org/show_bug.cgi?id=90313
2129
2130         Reviewed by Tony Chang.
2131
2132         Google has shipped the last version of Chrome that will support
2133         Mac OS 10.5 (Leopard), and we no longer have bots that run this
2134         configuration, so we're removing support for it.
2135
2136         A subsequent change will remove the baselines in platform/chromium-mac-leopard.
2137
2138         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2139         (BaselineOptimizerTest.test_complex_shadowing):
2140         * Scripts/webkitpy/layout_tests/port/builders.py:
2141         * Scripts/webkitpy/layout_tests/port/chromium.py:
2142         (ChromiumPort):
2143         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2144         (ChromiumMacPort):
2145         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2146         (ChromiumMacPortTest.test_versions):
2147         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2148         (FactoryTest.test_mac):
2149         (FactoryTest.test_chromium_mac):
2150         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2151         (test_rebaseline_and_copy_test_with_lion_result):
2152
2153 2012-06-29  Ojan Vafai  <ojan@chromium.org>
2154
2155         Fix optimize-baselines to not move baselines from win to win-7sp0
2156         https://bugs.webkit.org/show_bug.cgi?id=90312
2157
2158         Reviewed by Dirk Pranke.
2159
2160         It used to consider win-7sp0 as the common directory for all the Apple
2161         windows ports and incorrectly move results out of win.
2162
2163         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2164         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2165         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
2166         (BaselineOptimizerTest.test_common_directory_includes_root):
2167
2168 2012-06-28  Ojan Vafai  <ojan@chromium.org>
2169
2170         Fix rebaselining for Qt and Apple ports
2171         https://bugs.webkit.org/show_bug.cgi?id=90204
2172
2173         Reviewed by Dirk Pranke.
2174
2175         -Apporpriately put wk2 results in the -wk2 directories.
2176         -Since Qt and Apple-Win don't have bots that correspond to the
2177         platform/qt and platform/win directories, we need to fudge it
2178         and always put the results in those directories for those ports.
2179
2180         * Scripts/webkitpy/layout_tests/port/builders.py:
2181         (rebaseline_override_dir):
2182         * Scripts/webkitpy/layout_tests/port/factory.py:
2183         (_builder_options):
2184         Identify webkit2 builders by the WK2 in the builder name.
2185         * Scripts/webkitpy/tool/commands/rebaseline.py:
2186         (RebaselineTest._baseline_directory):
2187         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2188         (TestRebaseline.test_baseline_directory):
2189
2190 2012-06-29  Zoltan Horvath  <zoltan@webkit.org>
2191
2192         Add support for --force parameter to run-performance-tests
2193         https://bugs.webkit.org/show_bug.cgi?id=90279
2194
2195         Reviewed by Dirk Pranke.
2196
2197         It's helpful to be able to run tests from the Skipped list of the performance tests.
2198
2199         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2200         (PerfTestsRunner._parse_args):
2201         (PerfTestsRunner._collect_tests):
2202         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Add test.
2203         (test_collect_tests_with_skipped_list):
2204
2205 2012-06-29  Tony Chang  <tony@chromium.org>
2206
2207         [GTK] Enable CSS grid layout LayoutTests on GTK+
2208         https://bugs.webkit.org/show_bug.cgi?id=90226
2209
2210         Reviewed by Martin Robinson.
2211
2212         This feature is disabled via Settings by default, but for testing,
2213         we enable it using layoutTestController.overridePreferences. Add the
2214         necessary plumbing for DRT.
2215
2216         WTR already works because support was added for Apple Mac earlier.
2217
2218         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2219         (resetDefaultsToConsistentValues): Feature is off by default.
2220         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2221         (LayoutTestController::overridePreference): Add handling of WebKitCSSGridLayoutEnabled.
2222
2223 2012-06-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
2224
2225         [Qt] Added Qt port for garden-o-matic.
2226         https://bugs.webkit.org/show_bug.cgi?id=82719
2227
2228         Reviewed by Adam Barth.
2229
2230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2231         (.):
2232
2233 2012-06-29  Balazs Kelemen  <kbalazs@webkit.org>
2234
2235         [Qt][WTR] Get rid of using DumpRenderTreeSupportQt
2236         https://bugs.webkit.org/show_bug.cgi?id=90262
2237
2238         Reviewed by Alexey Proskuryakov.
2239
2240         Now that we decided to not support v8 in WebKit2
2241         we can get rid of using DumpRenderTreeSupportQt
2242         in WebKitTestRunner.
2243
2244         * Tools.pro:
2245         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2246         (WTR::InjectedBundlePage::resetAfterTest):
2247         (WTR::InjectedBundlePage::didClearWindowForFrame):
2248         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2249
2250 2012-06-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2251
2252         Revert r121540, it broke most Qt builds
2253
2254         * qmake/mkspecs/features/default_post.prf:
2255         * qmake/mkspecs/features/functions.prf:
2256
2257 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2258
2259         [Qt] Make build-webkit reject uknown configurations, eg. --profile
2260
2261         The qmake-based buildsystem doesn't support it.
2262
2263         Reviewed by Tor Arne Vestbø.
2264
2265         * Scripts/webkitdirs.pm:
2266         (buildQMakeProjects):
2267
2268 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2269
2270         [Qt] Don't add Qt module dependencies in features.prf
2271
2272         The required dependencies are already added in WebCore.pri.
2273
2274         Reviewed by Tor Arne Vestbø.
2275
2276         * qmake/mkspecs/features/features.prf:
2277
2278 2012-06-27  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2279
2280         [Qt] Use LIBS_PRIVATE instead of putting dependencies into LIBS
2281
2282         Reviewed by Tor Arne Vestbø..
2283
2284         * qmake/mkspecs/features/default_post.prf:
2285         * qmake/mkspecs/features/functions.prf:
2286
2287 2012-06-28  Ryosuke Niwa  <rniwa@webkit.org>
2288
2289         DOMHTMLCollection::item may return a wrong element after namedItem is called
2290         https://bugs.webkit.org/show_bug.cgi?id=90240
2291
2292         Reviewed by Antti Koivisto.
2293
2294         Add a WebKit API test since namedItem is not used in the JS/V8 binding code.
2295
2296         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2297         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.html: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html.
2298         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm.
2299         (TestWebKitAPI::TEST):
2300
2301 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
2302
2303         nrwt: remove the 'google-chrome' port code
2304         https://bugs.webkit.org/show_bug.cgi?id=88824
2305
2306         Reviewed by Ojan Vafai.
2307
2308         NRWT now supports passing additional baseline directories
2309         and expectations files on the command line, so there's no need
2310         to support the concept of a 'google-chrome' port directly.
2311
2312         * Scripts/webkitpy/layout_tests/port/base.py:
2313         (Port.path_to_test_expectations_file):
2314         * Scripts/webkitpy/layout_tests/port/builders.py:
2315         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2316         (ChromiumMacPort.__init__):
2317         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2318         (ChromiumWinPort.__init__):
2319         * Scripts/webkitpy/layout_tests/port/factory.py:
2320         (PortFactory):
2321         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2322         (FactoryTest.test_win):
2323         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Removed.
2324         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: Removed.
2325
2326 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
2327
2328         nrwt: clean up how arguments are passed to workers
2329         https://bugs.webkit.org/show_bug.cgi?id=90126
2330
2331         Reviewed by Ojan Vafai.
2332
2333         The way arguments are passed to workers has been crufty. It
2334         turns out it can be a lot cleaner via two things:
2335         1) using a factory method instead of instantiating objects
2336         directly in manager_worker_broker removes the need for passing
2337         'worker arguments' to the broker.
2338         2) it turns out that since mock hosts and test ports are purely
2339         in-memory constructions, they can be pickled and passed to child
2340         workers, meaning that the worker no longer needs hacky code to
2341         pass the port in a special case or to guess what to do if we
2342         don't have a host - all of the test-specific logic can move to
2343         the test file, where we can stub out the mock host's
2344         port_factory to return the same already-created port when it
2345         needs to be shared.
2346
2347         This change also moves WorkerException to manager_worker_broker.py
2348         where it belongs, and removes several useless tests that were
2349         just a maintenance burden (and would've needed rewriting when we
2350         change the rest of the broker implementation).
2351
2352         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2353         (Manager._run_tests.worker_factory):
2354         (Manager._run_tests):
2355         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2356         (get):
2357         (WorkerException):
2358         (AbstractWorker.__init__):
2359         (_ManagerConnection.__init__):
2360         (_ManagerConnection.start_worker):
2361         (_InlineManager.__init__):
2362         (_InlineManager.start_worker):
2363         (_MultiProcessManager._can_pickle_host):
2364         (_MultiProcessManager):
2365         (_MultiProcessManager.start_worker):
2366         (_WorkerConnection.__init__):
2367         (_InlineWorkerConnection.__init__):
2368         (_InlineWorkerConnection.join):
2369         (_InlineWorkerConnection.run):
2370         (_Process.run):
2371         (_MultiProcessWorkerConnection.__init__):
2372         (_MultiProcessWorkerConnection.start):
2373         (_MultiProcessWorkerConnection):
2374         (_MultiProcessWorkerConnection.run):
2375         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2376         (_TestWorker.__init__):
2377         (_TestWorker.run):
2378         (_TestsMixin.test_name):
2379         (_TestsMixin.test_cancel):
2380         (_TestsMixin.test_done):
2381         (_TestsMixin.test_unknown_message):
2382         (InlineBrokerTests.setUp):
2383         (MultiProcessBrokerTests.setUp):
2384         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2385         (Worker.__init__):
2386         (Worker.run):
2387         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Removed.
2388         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2389         (passing_run):
2390         (logging_run):
2391         (run_and_capture):
2392         (MainTest.test_child_processes_2):
2393         (MainTest.test_child_processes_min):
2394         (MainTest.test_exception_raised):
2395         (MainTest.test_keyboard_interrupt):
2396         (MainTest.test_retrying_and_flaky_tests):
2397         (MainTest.test_run_order__inline):
2398
2399 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
2400
2401         nrwt: don't try to catch worker exceptions in run_webkit_tests.__main__
2402         https://bugs.webkit.org/show_bug.cgi?id=90125
2403
2404         Reviewed by Ojan Vafai.
2405
2406         It turns out run_webkit_tests.py wasn't really using
2407         WorkerException and the catch we had for it was pointless. I've
2408         removed the symbol import and moved it to the integration tests
2409         where it is needed. Eventually the definition of the exception
2410         moves to the broker module, and so minimizing the number of
2411         users of it is a good thing.
2412
2413         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2414         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2415         (MainTest.test_exception_raised):
2416
2417 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
2418
2419         nrwt: clean up passing of log messages between processes
2420         https://bugs.webkit.org/show_bug.cgi?id=90123
2421
2422         Reviewed by Ojan Vafai.
2423
2424         It turns out log messages are perfectly picklable by themselves
2425         and contain the process id of the process that generated the
2426         message, so if we just pass the record from the worker to the
2427         manager and call logger.handle() in the manager, everything just
2428         works :).
2429
2430         The change is covered by existing tests.
2431
2432         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2433         (Manager._log_messages):
2434         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2435         (_WorkerLogHandler.emit):
2436         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2437         (MeteredStream.__init__):
2438         (_LogHandler.emit):
2439
2440 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
2441
2442         add a pylint wrapper for linting python code
2443         https://bugs.webkit.org/show_bug.cgi?id=90232
2444
2445         Reviewed by Adam Barth.
2446
2447         Currently we use 'pep8' to check python code in
2448         check-webkit-style. pep8 is fast but simple; pylint is slower
2449         but has much more robust linting capabilities and will catch
2450         variable typos and all sorts of other things. Eventually we
2451         should switch check-webkit-style to use this, but our code is
2452         far from linting now so it needs to be cleaned up first.
2453
2454         This change adds the infrastructure and a wrapper so we can
2455         start doing that.
2456
2457         * Scripts/lint-webkitpy: Added.
2458         * Scripts/webkitpy/pylintrc: Added.
2459         * Scripts/webkitpy/thirdparty/__init__.py:
2460         (AutoinstallImportHook.find_module):
2461         (AutoinstallImportHook._install_pylint):
2462
2463 2012-06-28  Tony Chang  <tony@chromium.org>
2464
2465         [GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
2466         https://bugs.webkit.org/show_bug.cgi?id=90215
2467
2468         Reviewed by Martin Robinson.
2469
2470         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2471         (initializeFonts): Check for WEBKITOUTPUTDIR first.
2472         * Scripts/webkitpy/layout_tests/port/gtk.py:
2473         (GtkPort.setup_environ_for_server): Copy the environment variable to the child process.
2474         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2475         (WTR::inititializeFontConfigSetting): Check for WEBKITOUTPUTDIR first.
2476
2477 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
2478
2479         derive ChromiumPort from WebKitPort in NRWT in order to support skipping tests if symbols are missing
2480         https://bugs.webkit.org/show_bug.cgi?id=89706
2481
2482         Reviewed by Ojan Vafai.
2483
2484         Try again to land the change first landed in r121363. This patch
2485         adds a bunch more tests and reworks the handling of
2486         port-specific default values for --pixel-tests and --time-out-ms
2487         to be more consistent (adding a default_pixel_tests() method,
2488         pushing the webkit default_timeout_ms() value up into base.py,
2489         and overriding it properly in the chromium and apple mac ports.
2490
2491         Also change the logic in
2492         run_webkit_tests._setup_derived_options() to not second-guess
2493         what the port wants the timeout value to be for debug builds;
2494         computing this in two different places led to several bugs.
2495
2496         This change also changes the Chromium unittest ports to derive
2497         from ChromiumPortTestCase instead of PortTestCase, so that we
2498         ensure that we're running the same tests on all port variants
2499         more easily. There's more cleanup that can be done here, but
2500         this is good enough for now
2501
2502         * Scripts/webkitpy/layout_tests/port/base.py:
2503         (Port.default_pixel_tests):
2504         (Port):
2505         (Port.default_timeout_ms):
2506         * Scripts/webkitpy/layout_tests/port/chromium.py:
2507         (ChromiumPort):
2508         (ChromiumPort.__init__):
2509         (ChromiumPort.default_pixel_tests):
2510         (ChromiumPort.default_timeout_ms):
2511         (ChromiumPort.driver_name):
2512         (ChromiumPort._driver_class):
2513         (ChromiumPort._missing_symbol_to_skipped_tests):
2514         (ChromiumPort.skipped_layout_tests):
2515         (ChromiumPort.setup_test_run):
2516         (ChromiumPort._path_to_image_diff):
2517         (ChromiumPort._convert_path):
2518         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2519         (ChromiumAndroidPortTest):
2520         (ChromiumAndroidPortTest.test_expectations_files):
2521         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2522         (ChromiumLinuxPort._modules_to_search_for_symbols):
2523         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2524         (ChromiumLinuxPortTest):
2525         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2526         (ChromiumMacPort._modules_to_search_for_symbols):
2527         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2528         (ChromiumMacPortTest):
2529         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
2530         split off from chromium_unittest.
2531         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2532         (ChromiumWinPort._modules_to_search_for_symbols):
2533         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2534         (ChromiumWinTest):
2535         * Scripts/webkitpy/layout_tests/port/mac.py:
2536         (MacPort.default_timeout_ms):
2537         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2538         (MacTest.test_default_timeout_ms):
2539         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2540         (MockDRTPort.start_http_server):
2541         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2542         (PortTestCase.test_default_timeout_ms):
2543         (PortTestCase):
2544         (PortTestCase.test_default_pixel_tests):
2545         * Scripts/webkitpy/layout_tests/port/test.py:
2546         (TestPort.default_pixel_tests):
2547         * Scripts/webkitpy/layout_tests/port/webkit.py:
2548         (WebKitPort._modules_to_search_for_symbols):
2549         (WebKitPort):
2550         (WebKitPort._symbols_string):
2551         (WebKitPort._skipped_tests_for_unsupported_features):
2552         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2553         (TestWebKitPort._symbols_string):
2554         (TestWebKitPort._tests_for_disabled_features):
2555         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2556         (_set_up_derived_options):
2557
2558 2012-06-28  Joshua Bell  <jsbell@chromium.org>
2559
2560         run-bindings-tests should return non-zero exit code on test failure
2561         https://bugs.webkit.org/show_bug.cgi?id=90205
2562
2563         Reviewed by Adam Barth.
2564
2565         * Scripts/run-bindings-tests:
2566         (main):
2567
2568 2012-06-28  Terry Anderson  <tdanderson@chromium.org>
2569
2570         [chromium] Reset the device scale factor to 1 before each test is run
2571         https://bugs.webkit.org/show_bug.cgi?id=90212
2572
2573         Reviewed by Adam Barth.
2574
2575         Some tests change the device scale factor, so this needs to be reset to
2576         1.0 at the start of each test to avoid test flakiness.
2577
2578         * DumpRenderTree/chromium/LayoutTestController.cpp:
2579         (LayoutTestController::reset):
2580
2581 2012-06-28  Ryosuke Niwa  <rniwa@webkit.org>
2582
2583         Cleanup HTMLFormCollection
2584         https://bugs.webkit.org/show_bug.cgi?id=90111
2585
2586         Reviewed by Andreas Kling.
2587
2588         Add a WebKit API test using copy-paste design pattern per kling's request.
2589
2590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2591         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html: Added.
2592         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm: Added.
2593         (-[HTMLFormCollectionNamedItemTest webView:didFinishLoadForFrame:]):
2594         (TestWebKitAPI):
2595         (TestWebKitAPI::TEST):
2596
2597 2012-06-28  Tim Horton  <timothy_horton@apple.com>
2598
2599         [mac] WKTR windows still don't stay off screen sometimes
2600         https://bugs.webkit.org/show_bug.cgi?id=90214
2601         <rdar://problem/11760263>
2602
2603         Reviewed by Simon Fraser.
2604
2605         In some cases, the system itself will consult [WebKitTestRunnerWindow frame], so we should refrain from
2606         overriding it and instead provide a different method to use when we want the web-facing "fake" window origin
2607         (for PlatformWebView::windowFrame()).
2608
2609         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2610         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
2611         (WTR::PlatformWebView::windowFrame):
2612
2613 2012-06-28  Martin Robinson  <mrobinson@igalia.com>
2614
2615         [GTK] Add unit tests for GtkInputMethodFilter
2616         https://bugs.webkit.org/show_bug.cgi?id=88698
2617
2618         Reviewed by Carlos Garcia Campos.
2619
2620         Add unit tests for GtkInputMethodFilter in the WebCore platform layer.
2621         This change adds the TestGtk test suite which will be used for all non-API
2622         layer GTK unit tests.
2623
2624         * TestWebKitAPI/GNUmakefile.am: Update the build to include the new tests.
2625         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp: Added.
2626         (TestWebKitAPI::PlatformWebView::PlatformWebView): Remove the call to gtk_init here
2627         as it's now in main.cpp.
2628         * TestWebKitAPI/gtk/main.cpp: Change the g_type_init call to gtk_init, because now
2629         a majority of all unit tests depend on GTK+ being initialized.
2630
2631 2012-06-28  Christophe Dumez  <christophe.dumez@intel.com>
2632
2633         [EFL] Enable support for HTML5 datalist
2634         https://bugs.webkit.org/show_bug.cgi?id=90157
2635
2636         Reviewed by Martin Robinson.
2637
2638         Turn on DATALIST flag by default on EFL port to
2639         support HTML5 datalist tag.
2640
2641         * Scripts/webkitperl/FeatureList.pm:
2642
2643 2012-06-28  Tony Chang  <tony@chromium.org>
2644
2645         Enable CSS grid layout LayoutTests on platform Mac
2646         https://bugs.webkit.org/show_bug.cgi?id=90113
2647
2648         Reviewed by Ojan Vafai.
2649
2650         * DumpRenderTree/mac/DumpRenderTree.mm:
2651         (resetDefaultsToConsistentValues): Reset the value to NO between tests.
2652
2653 2012-06-28  Mike Fenton  <mifenton@rim.com>
2654
2655         [BlackBerry] Add watchlist options for Blackberry and editing.
2656         https://bugs.webkit.org/show_bug.cgi?id=90193
2657
2658         Unreviewed.
2659
2660         Add BlackBerry and Editing watchlist and monitor them.
2661
2662         * Scripts/webkitpy/common/config/watchlist:
2663
2664 2012-06-28  Tim Horton  <timothy_horton@apple.com>
2665
2666         Unreviewed, upgrade myself to a reviewer!
2667
2668         http://www.webkit.org/blog/2082/tim-horton-is-now-a-webkit-reviewer/
2669
2670         * Scripts/webkitpy/common/config/committers.py:
2671
2672 2012-06-28  Terry Anderson  <tdanderson@chromium.org>
2673
2674         [Chromium] Chromium's LayoutTestController is missing setBackingScaleFactor
2675         https://bugs.webkit.org/show_bug.cgi?id=83635
2676
2677         Reviewed by Adam Barth.
2678
2679         Added InvokeCallbackTask, a new derived class of MethodTask. When
2680         setBackingScaleFactor is called, a call to setDeviceScaleFactor in
2681         WebView is made and then postTask is used to invoke the callback
2682         function specified in testRunner.setBackingScaleFactor. 
2683
2684         * DumpRenderTree/chromium/LayoutTestController.cpp:
2685         (LayoutTestController::LayoutTestController):
2686         (InvokeCallbackTask):
2687         (InvokeCallbackTask::InvokeCallbackTask):
2688         (InvokeCallbackTask::runIfValid):
2689         (LayoutTestController::setBackingScaleFactor):
2690         * DumpRenderTree/chromium/LayoutTestController.h:
2691         (LayoutTestController):
2692
2693 2012-06-28  Ojan Vafai  <ojan@chromium.org>
2694
2695         Make rebaseline-test and rebaseline-expectations work for non-Chromium ports
2696         https://bugs.webkit.org/show_bug.cgi?id=90186
2697
2698         Reviewed by Adam Barth.
2699
2700         This makes rebaselining work for all ports that have a TestExpectations file
2701         in the tree. I didn't test other ports.
2702
2703         This doesn't address 100% of the problem. The rebaseline code puts the expectations
2704         in the most specific directory and relies on optimize-baselines to merge baselines
2705         appropriately. This only works if every platform directory has an equivalent bot
2706         that runs the tests, which is not true for most ports.
2707
2708         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2709         (Builder._revision_and_build_for_filename):
2710         Some bots have filenames that aren't revision/build number pairs
2711         e.g. they are random junk like aQhxvx. Handle this gracefully.
2712         (Builder._fetch_revision_to_build_map):
2713         (Builder._file_info_list_to_revision_to_build_list):
2714         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2715         (BuilderTest.test_build_and_revision_for_filename):
2716         (BuilderTest.test_file_info_list_to_revision_to_build_list):
2717         * Scripts/webkitpy/layout_tests/port/builders.py:
2718         Update the list of builders. This list needs to be kept up
2719         to date for the rebaseline tool to work.
2720         * Scripts/webkitpy/tool/commands/rebaseline.py:
2721         (RebaselineTest._results_url):
2722         (RebaselineExpectations._run_webkit_patch):
2723         (RebaselineExpectations._rebaseline_port):
2724         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2725         Qt port uses qmake to determine the right version. Systems without qmake correctly fallback
2726         to a specific version.
2727
2728 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
2729
2730         [Qt][NRWT] Fix baseline and skipped file search path.
2731         https://bugs.webkit.org/show_bug.cgi?id=89882
2732
2733         Unreviewed trivial typo fix after r121430.
2734
2735         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2736         (QtPortTest._assert_search_path):
2737         (QtPortTest._assert_skipped_path):
2738
2739 2012-06-28  János Badics  <jbadics@inf.u-szeged.hu>
2740
2741         [Qt][NRWT] Fix baseline and skipped file search path.
2742         https://bugs.webkit.org/show_bug.cgi?id=89882
2743
2744         Reviewed by Csaba Osztrogonác.
2745
2746         * Scripts/webkitpy/layout_tests/port/qt.py:
2747         (QtPort._search_paths):
2748         (QtPort):
2749         (QtPort.baseline_search_path):
2750         (QtPort._skipped_file_search_paths):
2751         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2752         (QtPortTest):
2753         (QtPortTest._assert_skipped_path):
2754         (QtPortTest.test_baseline_search_path):
2755         (QtPortTest.test_skipped_file_search_path):
2756
2757 2012-06-28  Alexander Pavlov  <apavlov@chromium.org>
2758
2759         [Qt] inspector/styles/inject-stylesheet.html makes 4 tests flakey (TEXT PASS)
2760         https://bugs.webkit.org/show_bug.cgi?id=90167
2761
2762         Reviewed by Csaba Osztrogonác.
2763
2764         DRT should remove user stylesheets from the page group when resetting before running another test.
2765
2766         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2767         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2768
2769 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
2770
2771         [Qt][DRT] Reset AcceleratedCompositingEnabled between tests
2772         https://bugs.webkit.org/show_bug.cgi?id=90164
2773
2774         Reviewed by Simon Hausmann.
2775
2776         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2777         (WebCore::WebPage::resetSettings):
2778
2779 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
2780
2781         [Qt] Restore original value of mock scrollbars between tests
2782         https://bugs.webkit.org/show_bug.cgi?id=90155
2783
2784         Reviewed by Simon Hausmann.
2785
2786         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2787         (WebCore::WebPage::resetSettings):
2788         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2789         (LayoutTestController::setMockScrollbarsEnabled):
2790         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2791         (LayoutTestController):
2792
2793 2012-06-27  Mark Rowe  <mrowe@apple.com>
2794
2795         <http://webkit.org/b/90096> Building within Xcode sometimes does a full rebuild after building via build-webkit
2796
2797         We need to ensure that build-webkit uses the same setting for SHARED_PRECOMPS_DIR
2798         as what Xcode itself will use when building, otherwise switching between the two
2799         can result in the precompiled headers being rebuilt and thus the entire world
2800         rebuilding.
2801
2802         Reviewed by Dan Bernstein.
2803
2804         * Scripts/webkitdirs.pm:
2805         (determineBaseProductDir):
2806
2807 2012-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2808
2809         Unreviewed, rolling out r121363, r121367, r121384, and
2810         r121390.
2811         http://trac.webkit.org/changeset/121363
2812         http://trac.webkit.org/changeset/121367
2813         http://trac.webkit.org/changeset/121384
2814         http://trac.webkit.org/changeset/121390
2815         https://bugs.webkit.org/show_bug.cgi?id=90134
2816
2817         It broke debug NRWT on GTK and on Qt (Requested by Ossy_NIGHT
2818         on #webkit).
2819
2820         * Scripts/webkitpy/layout_tests/port/chromium.py:
2821         (ChromiumPort):
2822         (ChromiumPort.__init__):
2823         (ChromiumPort._check_file_exists):
2824         (ChromiumPort.default_results_directory):
2825         (ChromiumPort._driver_class):
2826         (ChromiumPort._build_path):
2827         (ChromiumPort._path_to_image_diff):
2828         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2829         (ChromiumLinuxPort.baseline_search_path):
2830         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2831         (ChromiumMacPort.baseline_search_path):
2832         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2833         (ChromiumPortTest):
2834         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2835         (ChromiumWinPort.baseline_search_path):
2836         * Scripts/webkitpy/layout_tests/port/webkit.py:
2837         (WebKitPort.__init__):
2838         (WebKitPort._webcore_symbols_string):
2839         (WebKitPort._skipped_tests_for_unsupported_features):
2840         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2841         (TestWebKitPort._webcore_symbols_string):
2842         (WebKitPortUnitTests.test_default_options):
2843
2844 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
2845
2846         Fix typo in r121384 :(
2847
2848         Unreviewed, build fix.
2849
2850         * Scripts/webkitpy/layout_tests/port/webkit.py:
2851         (WebKitPort.default_test_timeout_ms):
2852
2853 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
2854
2855         nrwt: default timeout for debug bots broke in r121363
2856         https://bugs.webkit.org/show_bug.cgi?id=90112
2857
2858         Unreviewed, build fix.
2859
2860         I forgot to account for release and debug having different
2861         default values :(.
2862
2863         * Scripts/webkitpy/layout_tests/port/chromium.py:
2864         (ChromiumPort.default_test_timeout_ms):
2865         * Scripts/webkitpy/layout_tests/port/webkit.py:
2866         (WebKitPort):
2867         (WebKitPort.default_test_timeout_ms):
2868         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2869         (WebKitPortUnitTests.test_default_options):
2870
2871 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
2872
2873         webkitpy: fix a couple of issues running under cygwin
2874         https://bugs.webkit.org/show_bug.cgi?id=90035
2875
2876         Reviewed by Eric Seidel.
2877
2878         These were causing unit tests to fail on cygwin (apple win bot).
2879
2880         * Scripts/webkitpy/layout_tests/port/chromium.py:
2881         * Scripts/webkitpy/performance_tests/perftest.py:
2882
2883 2012-06-27  Adam Barth  <abarth@webkit.org>
2884
2885         [Chromium] DumpRenderTree on Android should call SkUseTestFontConfigFile once available
2886         https://bugs.webkit.org/show_bug.cgi?id=89801
2887
2888         Reviewed by Nate Chapin.
2889
2890         Let's call SkUseTestFontConfigFile now that it exists.
2891
2892         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2893         (platformInit):
2894
2895 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
2896
2897         Fix typo introduced in r121363.
2898
2899         Unreviewed, build fix.
2900
2901         * Scripts/webkitpy/layout_tests/port/webkit.py:
2902         (WebKitPort._symbols_string):
2903
2904 2012-06-27  Mark Hahnenberg  <mhahnenberg@apple.com>
2905
2906         Moving from committers to reviewers :-)
2907
2908         Rubber stamped by Filip Pizlo.
2909
2910         * Scripts/webkitpy/common/config/committers.py:
2911
2912 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
2913
2914         Derive ChromiumPort from WebKitPort to add support for missing symbols to skip tests
2915         https://bugs.webkit.org/show_bug.cgi?id=89706
2916
2917         Reviewed by Adam Barth.
2918
2919         Based on the original patch by Raymond Toy.
2920
2921         This patch changes ChromiumPort to derive from webkit.WebKitPort
2922         instead of base.Port. This is a long-awaited change and a
2923         precursor to merging base.Port and webkit.WebKitPort, but is
2924         driven by the desire to dynamically detect whether the MP3 and
2925         AAC codecs are compiled into DRT on Chromium, for which we
2926         wanted to re-use the existing logic in WebKit port for determine
2927         what to skip at compile time.
2928
2929         Most of the changes are shuffling things around so that we don't
2930         change any other logic and so we override the necessary methods
2931         in WebKitPort (and try to follow the same method definition
2932         order where possible).
2933
2934         Also, on the Chromium port the mp3 and aac codecs are actually
2935         defined in a separate library, so scanning webcore isn't
2936         sufficient. This patch generalizes the symbol lookup to handle
2937         multiple libraries, and uses different libraries as appropriate
2938         for Chromium.
2939
2940         The only functional/visible changes should be in the value
2941         returned for skipped_layout_tests().
2942
2943         * Scripts/webkitpy/layout_tests/port/chromium.py:
2944         (ChromiumPort):
2945         (ChromiumPort.__init__):
2946         (ChromiumPort.driver_name):
2947         (ChromiumPort._driver_class):
2948         (ChromiumPort._missing_symbol_to_skipped_tests):
2949         (ChromiumPort.skipped_layout_tests):
2950         (ChromiumPort.setup_test_run):
2951         (ChromiumPort._path_to_image_diff):
2952         (ChromiumPort._convert_path):
2953         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2954         (ChromiumPortTest.test_missing_symbol_to_skipped_tests):
2955         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2956         (ChromiumLinuxPort._modules_to_search_for_symbols):
2957         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2958         (ChromiumLinuxPort._modules_to_search_for_symbols):
2959         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2960         (ChromiumLinuxPort._modules_to_search_for_symbols):
2961         * Scripts/webkitpy/layout_tests/port/webkit.py:
2962         (WebKitPort):
2963         (WebKitPort.__init__):
2964         (WebKitPort._symbols_string):
2965         (WebKitPort._modules_to_search_for_symbols):
2966
2967 2012-06-27  Csaba Osztrogonác  <ossy@webkit.org>
2968
2969         [Qt] REGRESSION(r121339): It broke the build on the Qt Windows bots
2970         https://bugs.webkit.org/show_bug.cgi?id=90081
2971
2972         Buildfix for Qt 4.8 Windows. Use the former path for Qt 4.8, and the newer one for Qt 5.
2973
2974         Reviewed by Noam Rosenthal.
2975
2976         * qmake/mkspecs/features/features.prf:
2977
2978 2012-06-27  Sergio Villar Senin  <svillar@igalia.com>
2979
2980         [WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
2981         https://bugs.webkit.org/show_bug.cgi?id=90061
2982
2983         Reviewed by Gustavo Noronha Silva.
2984
2985         Add "-no-install -no-fast-install" to the LDFLAGS in bots. With
2986         this flag libtool tells the linker to set the rpath for the output
2987         file to the full path of the .libs directory, instead of using a
2988         wrapper script to set up the LD_LIBRARY_PATH. This will allow us
2989         to directly reuse builds in the pure testing bots.
2990
2991         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2992
2993 2012-06-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2994
2995         [Qt] No need to save and restore TEMPLATE in a function
2996
2997         This was a leftover from when the logic was not in its own function scope.
2998
2999         QMAKE_FRAMEWORK_BUNDLE_NAME on the other hand is exported in qtLibraryTarget, which
3000         will surprisingly affect the global scope as well, so we have to save and restore it.
3001
3002         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
3003
3004         Reviewed by Tor Arne Vestbø.
3005
3006         * qmake/mkspecs/features/functions.prf:
3007
3008 2012-06-27  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
3009
3010         [Qt] Fix lookup location for sqlite sources
3011
3012         Don't look in the install dir - we are unlikely to find anything there
3013         unless we are doing a developer build.
3014
3015         Reviewed by Tor Arne Vestbø.
3016
3017         * qmake/mkspecs/features/features.prf:
3018
3019 2012-06-27  Zan Dobersek  <zandobersek@gmail.com>
3020
3021         [Gtk] Add support for the Gamepad API
3022         https://bugs.webkit.org/show_bug.cgi?id=87503
3023
3024         Reviewed by Carlos Garcia Campos.
3025
3026         Enable the gamepad support for the GTK port.
3027
3028         * Scripts/webkitperl/FeatureList.pm:
3029
3030 2012-06-27  Ryosuke Niwa  <rniwa@webkit.org>
3031
3032         Fix gcc build after r121302
3033         https://bugs.webkit.org/show_bug.cgi?id=90055
3034
3035         Reviewed by Mark Rowe.
3036
3037         Assume RTTI is always disabled so that gtest builds on XCode 3.2.6.
3038
3039         It appears that gcc doesn't like window.get().* inside a template so replace that by [window.get() *] instead.
3040
3041         * TestWebKitAPI/Configurations/Base.xcconfig:
3042         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
3043         (TestWebKitAPI::AcceptsFirstMouse::runTest):
3044
3045 2012-06-27  Csaba Osztrogonác  <ossy@webkit.org>
3046
3047         Add master.cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses
3048         https://bugs.webkit.org/show_bug.cgi?id=89564
3049
3050         Reviewed by Tony Chang.
3051
3052         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3053         (BuildStepsConstructorTest):
3054         (BuildStepsConstructorTest.generateTests):
3055         (BuildStepsConstructorTest.createTest):
3056         (BuildStepsConstructorTest.createTest.doTest):
3057
3058 2012-06-26  Mark Hahnenberg  <mhahnenberg@apple.com>
3059
3060         Add support for preciseTime() to WebKitTestRunner
3061         https://bugs.webkit.org/show_bug.cgi?id=90027
3062
3063         Reviewed by Darin Adler.
3064
3065         It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
3066
3067         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3068         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 
3069         (WTR::LayoutTestController::preciseTime): 
3070         (WTR):
3071         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3072         (LayoutTestController):
3073
3074 2012-06-26  Lucas Forschler  <lforschler@apple.com>
3075
3076       Teach the Apple port how to build the test tools in build-webkit
3077       https://bugs.webkit.org/show_bug.cgi?id=89540
3078
3079       Reviewed by Jon Lee & Simon Fraser.
3080
3081       * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3082       (RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive
3083       (RunUnitTests.start): ditto
3084       * Scripts/build-webkit: add tools to the projects build list
3085
3086 2012-06-26  Ojan Vafai  <ojan@chromium.org>
3087
3088         Only show the platform-appropriate builders for non-layout test failures in garden-o-matic
3089         https://bugs.webkit.org/show_bug.cgi?id=90025
3090
3091         Reviewed by Simon Fraser.
3092
3093         Move the chromium-specific filtering code into config.js and replace it with a method on each platform
3094         config. Also, let the webkit test step name be webkit_tests (build.chromium.org) or layout-test (build.webkit.org).
3095
3096         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
3097         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3098         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3099
3100 2012-06-26  Ojan Vafai  <ojan@chromium.org>
3101
3102         Fix failing garden-o-matic unittests
3103         https://bugs.webkit.org/show_bug.cgi?id=90021
3104
3105         Reviewed by Adam Barth.
3106
3107         These had all just fallen out of date.
3108
3109         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3112
3113 2012-06-26  Ojan Vafai  <ojan@chromium.org>
3114
3115         Fix platform picker change handler in garden-o-matic
3116         https://bugs.webkit.org/show_bug.cgi?id=90010
3117
3118         Reviewed by Simon Fraser.
3119
3120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3121         The old code never worked. This is hard to test because change handlers require
3122         a user-initiated action and the code is changing the window's location, which would
3123         navigate the test page.
3124
3125         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
3126         Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
3127         due to the large margin-bottom.
3128
3129 2012-06-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3130
3131         webkitpy: Make webkit-patch patches-to-review useful
3132         https://bugs.webkit.org/show_bug.cgi?id=89470
3133
3134         Reviewed by Eric Seidel.
3135
3136         webkit-patch patches-to-review will now output the list of
3137         bugs with patches pending for review that has the user on CC,
3138         excluding patches with cq-, sorted by the age of the patch.
3139
3140         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3141         (BugzillaQueries.fetch_bugs_from_review_queue):
3142         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3143         (MockBugzillaQueries.fetch_bugs_from_review_queue):
3144         (MockBugzilla.__init__):
3145         (MockBugzilla.authenticate):
3146         * Scripts/webkitpy/tool/commands/queries.py:
3147         (PatchesToReview):
3148         (PatchesToReview.__init__):
3149         (PatchesToReview._print_report):
3150         (PatchesToReview._generate_report):
3151         (PatchesToReview.execute):
3152         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3153         (QueryCommandsTest.test_patches_to_review):
3154
3155 2012-06-26  Dirk Pranke  <dpranke@chromium.org>
3156
3157         nrwt: broken for chromium on vista
3158         https://bugs.webkit.org/show_bug.cgi?id=89988
3159
3160         Reviewed by Tony Chang.
3161
3162         r121194 removed support for 'chromium-win-vista' as a separate
3163         port, but this actually prevented the code from running on vista
3164         at all, which is unduly harsh and broke the websocket tests on
3165         the (non-webkit) chromium bots that are still running on vista.
3166
3167         It's probably good enough to pretend that vista is win7 instead;
3168         some layout tests will still fail but at least things'll run.
3169
3170         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3171         (ChromiumWinPort.determine_full_port_name):
3172         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3173         (ChromiumWinTest.test_versions):
3174
3175 2012-06-26  Csaba Osztrogonác  <ossy@webkit.org>
3176
3177         master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
3178         https://bugs.webkit.org/show_bug.cgi?id=89215
3179
3180         We need it because it is deprecated and will be dropped in buildbot 0.8.7
3181
3182         Reviewed by Tony Chang.
3183
3184         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3185         (CheckOutSource.__init__):
3186         (Factory.__init__):
3187
3188 2012-06-26  Simon Hausmann  <simon.hausmann@nokia.com>
3189
3190         [Qt][Win] Symbols are not exported in QtWebKit5.dll
3191         https://bugs.webkit.org/show_bug.cgi?id=88873
3192
3193         Reviewed by Tor Arne Vestbø.
3194
3195         When linking the target dll make sure to re-export the symbols from
3196         the static libraries marked as export, with the help of a little python
3197         script and a qmake extra compiler.
3198
3199         * Scripts/generate-win32-export-forwards: Added.
3200         * qmake/mkspecs/features/win32/default_post.prf:
3201
3202 2012-06-25  Jocelyn Turcotte  <turcotte.j@gmail.com>
3203
3204         Add a note about hostname completion not working well with --cc completion
3205
3206         Reviewed by Simon Hausmann.
3207
3208         Hostname completion tries to resolve anything after an @ sign which is present
3209         in the completed list of contributor emails to CC.
3210
3211         * Scripts/webkit-tools-completion.sh:
3212
3213 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3214
3215         Unreviewed, rolling out r121244.
3216         http://trac.webkit.org/changeset/121244
3217         https://bugs.webkit.org/show_bug.cgi?id=89966
3218
3219         skip list path is incorrect now. (Requested by Ossy on
3220         #webkit).
3221
3222         * Scripts/webkitpy/layout_tests/port/qt.py:
3223         (QtPort.baseline_search_path):
3224         (QtPort._skipped_file_search_paths):
3225         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3226         (QtPortTest.test_baseline_search_path):
3227
3228 2012-06-26  János Badics  <jbadics@inf.u-szeged.hu>
3229
3230         [Qt][NRWT] Fix baseline and skipped file search path.
3231         https://bugs.webkit.org/show_bug.cgi?id=89882
3232
3233         Reviewed by Csaba Osztrogonác.
3234
3235         * Scripts/webkitpy/layout_tests/port/qt.py:
3236         (QtPort.baseline_search_path):
3237         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3238         (QtPortTest.test_baseline_search_path):
3239
3240 2012-06-26  Tony Chang  <tony@chromium.org>
3241
3242         [Qt] Enable grid layout LayoutTests
3243         https://bugs.webkit.org/show_bug.cgi?id=89909
3244
3245         Reviewed by Csaba Osztrogonác.
3246
3247         These tests pass, we just need to hook up the overridePreference.
3248
3249         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3250         (WebCore::WebPage::resetSettings): Reset grid layout and regions between tests.
3251         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3252         (LayoutTestController::overridePreference): Add WebKitCSSGridLayoutEnabled.
3253
3254 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3255
3256         Unreviewed, rolling out r121236.
3257         http://trac.webkit.org/changeset/121236
3258         https://bugs.webkit.org/show_bug.cgi?id=89956
3259
3260         It's broke the nrwt on qt and gtk platform (Requested by
3261         kkristof on #webkit).
3262
3263         * Scripts/webkitpy/layout_tests/port/qt.py:
3264         (QtPort._build_driver):
3265         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3266         (XvfbDriver._start):
3267         (XvfbDriver._start.x_filter):
3268         (XvfbDriver.stop):
3269
3270 2012-06-26  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3271
3272         [NRWT] XvfbDriver should choose the next free display
3273         https://bugs.webkit.org/show_bug.cgi?id=88414
3274
3275         Reviewed by Dirk Pranke.
3276
3277         * Scripts/webkitpy/layout_tests/port/qt.py:
3278         (QtPort._driver_class):
3279         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3280         (XvfbDriver.__init__):
3281         (XvfbDriver._start):
3282         (XvfbDriver._start.next_free_id):
3283         (XvfbDriver.stop):
3284
3285 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
3286
3287         [Qt] Make it possible to build WebKit without QtWidgets
3288         https://bugs.webkit.org/show_bug.cgi?id=78109
3289
3290         Reviewed by Tor Arne Vestbø.
3291
3292         * Tools.pro: Disable various tools that depend on WK1.
3293         * qmake/mkspecs/features/default_post.prf: Add WK1 as supported static lib in WEBKIT
3294         * qmake/mkspecs/features/default_pre.prf: Disable WK1 if QtWidgets is not built.
3295         * qmake/mkspecs/modules/webkit1.prf: Added.
3296
3297 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
3298
3299         put vista back for chromium (non-webkit) bots ...
3300         https://bugs.webkit.org/show_bug.cgi?id=89929
3301
3302         Unreviewed, build fix.
3303
3304         Turns out we've only gotten rid of vista on the webkit tests so
3305         far. Put vista back for the other chromium bots ...
3306
3307         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3308         (chromiumPlatform):
3309         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3310         (test):
3311
3312 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
3313
3314         update flakiness dashboard after removing chromium-vista bots
3315         https://bugs.webkit.org/show_bug.cgi?id=89925
3316
3317         Unreviewed, build fix.
3318
3319         More changes missed in r121194 :(.
3320
3321         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3322         (chromiumPlatform):
3323         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3324         (test):
3325
3326 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
3327
3328         remove support for chromium vista from tools
3329         https://bugs.webkit.org/show_bug.cgi?id=89915
3330
3331         Reviewed by Tony Chang.
3332
3333         This change is all deleting code and updating tests to handle
3334         the configuration being gone. All tests now pass except for a
3335         few unittests for the flakiness dashboard which were failing
3336         before this patch.
3337
3338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3339         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3340         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3341         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3342         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3343         (BaselineOptimizerTest.test_complex_shadowing):
3344         * Scripts/webkitpy/layout_tests/port/builders.py:
3345         * Scripts/webkitpy/layout_tests/port/chromium.py:
3346         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3347         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3348         (ChromiumWinPort):
3349         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3350         (ChromiumWinTest.test_versions):
3351         (ChromiumWinTest.test_baseline_path):
3352         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3353         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3354         (BuildCoverageExtrapolatorTest.test_extrapolate):
3355
3356 2012-06-25  Scott Graham  <scottmg@chromium.org>
3357
3358         [Chromium] add empty impl of WebThemeEngine::getSize() for DRT
3359         https://bugs.webkit.org/show_bug.cgi?id=89907
3360
3361         Not reviewed. Fix build in Chromium.
3362
3363         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3364         (WebThemeEngineDRTWin::getSize):
3365         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
3366         (WebThemeEngineDRTWin):
3367
3368 2012-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3369
3370         [EFL] Implement Network Information API
3371         https://bugs.webkit.org/show_bug.cgi?id=87067
3372
3373         Reviewed by Kenneth Rohde Christiansen.
3374
3375         * efl/jhbuild.modules: Add eeze library dependency.
3376
3377 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
3378
3379         [Qt] Fix Win32 debug build
3380
3381         Reviewed by Tor Arne Vestbø.
3382
3383         Consolidate use_all_in_one_files into mac/unix/win32 default_pre.prf.
3384
3385         * qmake/mkspecs/features/unix/default_pre.prf:
3386         * qmake/mkspecs/features/win32/default_pre.prf: Added.
3387
3388 2012-06-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3389
3390         [Qt] Enable <input type="color"> support by default
3391         https://bugs.webkit.org/show_bug.cgi?id=89653
3392
3393         Reviewed by Kenneth Rohde Christiansen.
3394
3395         This feature is complete for Qt WebKit2. Enabling by default
3396         will help to mature the implementation.
3397
3398         * Scripts/webkitperl/FeatureList.pm:
3399         * qmake/mkspecs/features/features.pri:
3400
3401 2012-06-24  Dan Bernstein  <mitz@apple.com>
3402
3403         Made debug-{minibrowser,safari,test-runner} work with LLDB.
3404
3405         Reviewed by Sam Weinig.
3406
3407         * Scripts/debug-minibrowser: Pass INCLUDE_OPTIONS_FOR_DEBUGGING to
3408         printHelpAndExitForRunAndDebugWebKitAppIfNeeded().
3409         * Scripts/debug-safari: Ditto.
3410         * Scripts/debug-test-runner: Ditto.
3411         * Scripts/webkitdirs.pm:
3412         (debugger): Added. Calls determineDebugger() if needed and returns the chosen debugger.
3413         (determineDebugger): Added. Sets the debugger to "lldb" if the --use-lldb switch is present,
3414         and to "gdb" otherwise.
3415         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Changed to print help for the
3416         --target-web-process and --use-lldb switches if passed INCLUDE_OPTIONS_FOR_DEBUGGING.
3417         (execMacWebKitAppForDebugging): Changed to use the chosen debugger.
3418
3419 2012-06-24  Adam Barth  <abarth@webkit.org>
3420
3421         [Chromium] Release media resources after each LayoutTest on Android
3422         https://bugs.webkit.org/show_bug.cgi?id=89720
3423
3424         Reviewed by Eric Carlson.
3425
3426         The LayoutTests can hang when run on Android because we sometimes run
3427         out of media resources. This patch causes us to release our media
3428         resources after each test in order to avoid running out of this
3429         resource. In production, there are other mechanisms that manage this
3430         resource.
3431
3432         * DumpRenderTree/chromium/TestShell.cpp:
3433         (TestShell::resetTestController):
3434
3435 2012-06-23  Zan Dobersek  <zandobersek@gmail.com>
3436
3437         [Gtk] REGRESSION(r120918): Causes flaky DND tests
3438         https://bugs.webkit.org/show_bug.cgi?id=89770
3439
3440         Reviewed by Martin Robinson.
3441
3442         Connect to the run-file-chooser signal of the WebKitWebView and
3443         return TRUE so no file chooser dialog is run. This prevents certain
3444         test failures.
3445
3446         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3447         (webViewRunFileChooser):
3448         (createWebView):
3449
3450 2012-06-23  Dan Bernstein  <mitz@apple.com>
3451
3452         debug-{minibrowser,safari,test-runner} fail when gdb is not installed in /usr/bin.
3453
3454         Reviewed by Sam Weinig.
3455
3456         * Scripts/webkitdirs.pm:
3457         (execMacWebKitAppForDebugging): Use xcrun to locate gdb.
3458
3459 2012-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3460
3461         Unreviewed. Skip GTK+ unit test /webkit2/WebKitFindController/hide.
3462
3463         It fails always when running it in Xvfb.
3464
3465         * gtk/run-api-tests:
3466         (TestRunner):
3467
3468 2012-06-23  Wajahat Siddiqui  <mdwajahatali.siddiqui@motorola.com>
3469
3470         [GTK][WK2]Mis-spelt defaultWindowTitle
3471         https://bugs.webkit.org/show_bug.cgi?id=89808
3472
3473         Reviewed by Carlos Garcia Campos.
3474
3475         * MiniBrowser/gtk/BrowserWindow.c:
3476
3477 2012-06-23  Sergio Villar Senin  <svillar@igalia.com>
3478
3479         [GTK] Add a new webkit2 tests slave bot
3480         https://bugs.webkit.org/show_bug.cgi?id=89336
3481
3482         Reviewed by Csaba Osztrogonác.
3483
3484         Slave configuration for a new GTK 64 bit release bot that will run
3485         WebKit2 tests.
3486
3487         Also BuildAndTest now accepts the "triggers" parametter,
3488         this means that apart from building and testing it can trigger
3489         some other build/test sequences in other slaves.
3490
3491         * BuildSlaveSupport/build.webkit.org-config/config.json:
3492         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3493         (BuildAndTestFactory.__init__):
3494
3495 2012-06-23  Kwang Yul Seo  <skyul@company100.net>
3496
3497         Unreviewed. Update my email.
3498
3499         * Scripts/webkitpy/common/config/committers.py:
3500
3501 2012-06-22  Adam Barth  <abarth@webkit.org>
3502
3503         [Chromium] DumpRenderTree on Android needs to configure fonts for testing
3504         https://bugs.webkit.org/show_bug.cgi?id=89721
3505
3506         Reviewed by Nate Chapin.
3507
3508         This patch teaches DumpRenderTree to configure Skia to use the fallback
3509         fonts that the LayoutTests assume. This patch reduces the number result
3510         differences between chromium-android and chromium-linux.
3511
3512         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3513         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3514         (platformInit):
3515         * DumpRenderTree/chromium/android_fallback_fonts.xml: Added.
3516         * DumpRenderTree/chromium/android_main_fonts.xml: Added.
3517         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3518
3519 2012-06-22  Alexandru Chiculita  <achicu@adobe.com>
3520
3521         [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
3522         https://bugs.webkit.org/show_bug.cgi?id=89781
3523
3524         Reviewed by Dean Jackson.
3525
3526         Added CSS Shaders as enabled by default on Safari for Mac.
3527
3528         * Scripts/webkitperl/FeatureList.pm:
3529
3530 2012-06-22  Adam Barth  <abarth@webkit.org>
3531
3532         Add support for test_expectations_android.txt for overriding test expecations on the chromium-android branch
3533         https://bugs.webkit.org/show_bug.cgi?id=89791
3534
3535         Reviewed by Dirk Pranke.
3536
3537         Downstream, the chromium-android port maintains a test expectations
3538         file to keep track of which tests pass or fail. That causes them to
3539         keep a patch in chromium_android.py in their branch.
3540
3541         This patch teaches chromium_android.py to use test_expectations_android.txt.
3542         We don't intend to use this file upstream, but having this code patch
3543         upstream lets us unfork webkitpy.
3544
3545         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3546         (ChromiumAndroidPort.expectations_files):
3547
3548 2012-06-22  Dirk Pranke  <dpranke@chromium.org>
3549
3550         run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'')
3551         https://bugs.webkit.org/show_bug.cgi?id=89734
3552
3553         Reviewed by Ryosuke Niwa.
3554
3555         Fix a crash in ServerProcess if you called .pid() after it
3556         crashed during a write(). We had a test for this case but the
3557         test wasn't calling pid(), just has_crashed(). Fixed the problem
3558         and the test.
3559
3560         * Scripts/webkitpy/layout_tests/port/server_process.py:
3561         (ServerProcess.__init__):
3562         (ServerProcess.pid):
3563         (ServerProcess._start):
3564         (ServerProcess.stop):
3565         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3566         (FakeServerProcess._start):
3567         (TestServerProcess.test_broken_pipe):
3568
3569 2012-06-22  Peter Beverloo  <peter@chromium.org>
3570
3571         [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
3572         https://bugs.webkit.org/show_bug.cgi?id=88853
3573
3574         Reviewed by Steve Block.
3575
3576         The Android exclusions were necessary to fix a gyp generation error, as
3577         the gcc_version variable wasn't being defined for Android. Remove these
3578         exceptions when Chromium is able to define the gcc_version variable.
3579
3580         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3581
3582 2012-06-22  Mario Sanchez Prada  <msanchez@igalia.com>
3583
3584         Unreviewed gardening. Unskipping test passing after fixing bug 88419.
3585
3586         * gtk/run-api-tests:
3587         (TestRunner): Unskip WTF.HashMap.
3588
3589 2012-06-22  Zoltan Horvath  <zoltan@webkit.org>
3590
3591         [Qt] Allow DumpRenderTree to dump about:blank
3592         https://bugs.webkit.org/show_bug.cgi?id=89685
3593
3594         Reviewed by Ryosuke Niwa.
3595
3596         We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports,
3597         additionaly this behavior is required for running WTR performance tests.
3598
3599         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3600         (WebCore::DumpRenderTree::processLine):
3601
3602 2012-06-21  Adam Barth  <abarth@webkit.org>
3603
3604         [Chromium] Reset mediaPlaybackRequiresUserGesture WebSettings after each test
3605         https://bugs.webkit.org/show_bug.cgi?id=89718
3606
3607         Reviewed by Kent Tamura.
3608
3609         We should reset this WebSetting to its default value so that it behaves
3610         consistently across tests.
3611
3612         * DumpRenderTree/chromium/WebPreferences.cpp:
3613         (WebPreferences::reset):
3614         (WebPreferences::applyTo):
3615         * DumpRenderTree/chromium/WebPreferences.h:
3616         (WebPreferences):
3617
3618 2012-06-21  Zoltan Horvath  <zoltan@webkit.org>
3619
3620         DRT/WTR python interface handles about:blank incorrectly
3621         https://bugs.webkit.org/show_bug.cgi?id=89563
3622
3623         Reviewed by Dirk Pranke.
3624
3625         Currently DRT/WTR python interface's _command_from_driver_input function
3626         puts the test directory path before about:blank. Remove this incorrect behavior.
3627
3628         * Scripts/webkitpy/layout_tests/port/webkit.py:
3629         (WebKitDriver._command_from_driver_input):
3630
3631 2012-06-21  Dirk Pranke  <dpranke@chromium.org>
3632
3633         reenable perf tests on win
3634         https://bugs.webkit.org/show_bug.cgi?id=89690
3635
3636         Reviewed by Ryosuke Niwa.
3637
3638         Only the replay tests don't work, and those are disabled by
3639         default. This change also fixes the undefined _log reference
3640         that was causing a crash.
3641
3642         * Scripts/run-perf-tests:
3643
3644 2012-06-21  Sheriff Bot  <webkit.review.bot@gmail.com>
3645
3646         Unreviewed, rolling out r120937.
3647         http://trac.webkit.org/changeset/120937
3648         https://bugs.webkit.org/show_bug.cgi?id=89679
3649
3650         This patch brought buildbot master down (Requested by svillar
3651         on #webkit).
3652
3653         * BuildSlaveSupport/build.webkit.org-config/config.json:
3654
3655 2012-06-21  Martin Robinson  <mrobinson@igalia.com>
3656
3657         [GTK] Combine WebKit API tests into fewer binaries
3658         https://bugs.webkit.org/show_bug.cgi?id=88458
3659
3660         Reviewed by Carlos Garcia Campos.
3661
3662         Instead of creating one binary per-test file, create binaries for each
3663         category of tests. Right now this includes WTF and the WebKit2 C API,
3664         but later tests can be added for the GTK+ platform layer and the WebKit1
3665         and WebKit2 API layers.
3666
3667         * TestWebKitAPI/GNUmakefile.am: Compile only two test binaries, one for the WebKit2
3668           C API and one for WTF. Refresh the source list to ensure that new test are active.
3669         * gtk/run-api-tests: Change the way that tests are skipped by splitting out the
3670         concept of skipping a test and skipping a suite (program) of tests. Test cases are
3671         skipped because of legitimate failures, but entire programs are skipped because of
3672         problems in the harness. As of right now a test program is only skipped if the
3673         accessibility bus cannot be started.
3674         (SkippedTest.__init__): Make the test case a required argument and have one skipped