c700d0ff902e44c8c323577de616fa5745b018a0
[WebKit-https.git] / Tools / ChangeLog
1 2015-07-06  Benjamin Poulain  <benjamin@webkit.org>
2
3         [Content Extensions] Make the DFA transitions ranges instead of characters
4         https://bugs.webkit.org/show_bug.cgi?id=146575
5
6         Reviewed by Alex Christensen.
7
8         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
9         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
10         Since the minimizer is perfect, we get the minimal solution now,
11         which is really cool!
12
13 2015-07-06  Brady Eidson  <beidson@apple.com>
14
15         ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads.
16         <rdar://problem/21640050> and https://bugs.webkit.org/show_bug.cgi?id=146563
17
18         Reviewed by Geoff Garen.
19
20         * WebKitTestRunner/TestInvocation.cpp:
21         (WTR::TestInvocation::invoke): For testing purposes, all pages should start with the 
22           ShouldOpenExternalURLsPolicy set to "ShouldNotAllow"
23
24 2015-07-06  Daniel Bates  <dabates@apple.com>
25
26         Unreviewed, rolling out r170639.
27
28         Broke using webkit-patch apply-attachment to apply an
29         attachment from a security bug. The patch incorrectly assumed
30         that Bugzilla returns a non-HTTP 200 status code in its HTTP
31         response when authentication is required.
32
33         Reverted changeset:
34
35         "webkit-patch apply-from-bug / apply-attachment should not ask
36         for credentials if none are required"
37         https://bugs.webkit.org/show_bug.cgi?id=40095
38         http://trac.webkit.org/changeset/170639
39
40 2015-07-04  Chris Dumez  <cdumez@apple.com>
41
42         Drop RefPtr::clear() method
43         https://bugs.webkit.org/show_bug.cgi?id=146556
44
45         Reviewed by Brady Eidson.
46
47         Drop RefPtr::clear() method in favor of "= nullptr;" pattern.
48
49 2015-07-03  Dan Bernstein  <mitz@apple.com>
50
51         Fixed the iOS build.
52
53         * DumpRenderTree/mac/EventSendingController.mm:
54         (+[EventSendingController isSelectorExcludedFromWebScript:]):
55         (+[EventSendingController webScriptNameForSelector:]):
56
57 2015-07-03  Dan Bernstein  <mitz@apple.com>
58
59         [Xcode] Update some build settings as recommended by Xcode 7
60         https://bugs.webkit.org/show_bug.cgi?id=146597
61
62         Reviewed by Sam Weinig.
63
64         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
65
66         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
67         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
68         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
69         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
70         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
71
72         * DumpRenderTree/mac/EventSendingController.mm:
73         (+[EventSendingController webScriptNameForSelector:]): Removed check for setDragMode:,
74         which was removed in r19101.
75
76         * DumpRenderTree/mac/TextInputController.m:
77         (-[TextInputController interpretKeyEvents:withSender:]): Suppressed -Wundeclared-selector
78         around used of a selector not that is not declared anywhere.
79
80         * MiniBrowser/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS.
81
82         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
83
84         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
85         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
86         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
87         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
88         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
89
90         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
91
92 2015-07-02  Daniel Bates  <dabates@apple.com>
93
94         [iOS] Add WebKitSystemInterface for iOS 8.4
95         https://bugs.webkit.org/show_bug.cgi?id=146548
96
97         Rubber-stamped by Zalan Bujtas.
98
99         * Scripts/copy-webkitlibraries-to-product-directory:
100
101 2015-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
102
103         [GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18
104         https://bugs.webkit.org/show_bug.cgi?id=146234
105
106         Reviewed by Sergio Villar Senin.
107
108         Enable the WebSQL directory test that was disabled because of this bug.
109
110         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
111         (testWebContextConfiguration):
112
113 2015-07-01  Matthew Daiter  <mdaiter@apple.com>
114
115         Enabled MEDIA_STREAM flag
116         https://bugs.webkit.org/show_bug.cgi?id=145947
117         <rdar://problem/21365829>
118         
119         Reviewed by Eric Carlson.
120
121         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
122
123 2015-06-30  Martin Robinson  <mrobinson@igalia.com>
124
125         [GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936
126         https://bugs.webkit.org/show_bug.cgi?id=144828
127
128         Reviewed by Carlos Garcia Campos.
129
130         * WebKitTestRunner/gtk/main.cpp:
131         (main): Use the new WKTextChecker API to set the spell checking languages
132         when the process is starting up.
133
134 2015-06-30  Andy VanWagoner  <thetalecrafter@gmail.com>
135
136         Implement ECMAScript Internationalization API
137         https://bugs.webkit.org/show_bug.cgi?id=90906
138
139         Reviewed by Benjamin Poulain.
140
141         * Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag
142
143 2015-06-30  Jonathan Davis  <jond@apple.com>
144
145         Unreviewed. Added myself as a committer.
146
147         * Scripts/webkitpy/common/config/contributors.json:
148
149 2015-06-30  Brent Fulgham  <bfulgham@apple.com>
150
151         Unreviewed build fix.
152
153         * Scripts/update-webkit-dependency: Try to build even if we cannot connect
154         to developer.apple.com to get update libraries.
155
156 2015-06-29  Jake Nielsen  <jacob_nielsen@apple.com>
157
158         Add timeout in run-webkit-tests for launching the simulator
159         https://bugs.webkit.org/show_bug.cgi?id=146371
160
161         Reviewed by Darin Adler.
162
163         Adds a default 5-minute timeout using the timeout class in webkitpy.benchmark_runner.utils
164         for the otherwise infinitely patient wait_until_device_is_in_state method.
165
166         * Scripts/webkitpy/xcode/simulator.py:
167         (Simulator.DeviceState):
168         (Simulator):
169         (Simulator.wait_until_device_is_in_state):
170         (Simulator.device_state):
171
172 2015-06-29  Benjamin Poulain  <benjamin@webkit.org>
173
174         Make the NFA transitions range-based
175         https://bugs.webkit.org/show_bug.cgi?id=146338
176
177         Reviewed by Alex Christensen.
178
179         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
180         Test some new interesting cases.
181
182 2015-06-28  Dan Bernstein  <mitz@apple.com>
183
184         [Xcode] Use the same environment for command-line and IDE builds
185         https://bugs.webkit.org/show_bug.cgi?id=146401
186
187         Reviewed by Anders Carlsson.
188
189         * Scripts/webkitdirs.pm:
190         (XcodeOptions): Set the UseSanitizedBuildSystemEnvironment user default to YES, which makes
191         xcodebuild use the same environment Xcode uses.
192
193 2015-06-28  Dan Bernstein  <mitz@apple.com>
194
195         REGRESSION (r185915): Source-incompatible change in WKPageUIClient
196         https://bugs.webkit.org/show_bug.cgi?id=146396
197
198         Reviewed by Anders Carlsson.
199
200         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
201         (TestWebKitAPI::runJavaScriptAlert): Removed _deprecatedForUseWithV0 suffix from the name.
202         (TestWebKitAPI::TEST): Updated for renames.
203         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
204         (runJavaScriptAlert): Removed suffix.
205         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): Updated.
206         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
207         (runJavaScriptAlert): Removed suffix.
208         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): Updated.
209
210 2015-06-27  Carlos Garcia Campos  <cgarcia@igalia.com>
211
212         [GTK][SOUP] Implement WebCore::PublicSuffix for soup and enable PUBLIC_SUFFIX_LIST for GTK+
213         https://bugs.webkit.org/show_bug.cgi?id=146318
214
215         Reviewed by Sergio Villar Senin.
216
217         Copy mac PublicSuffix test to the common directory and add it to
218         the GTK+ build.
219
220         * TestWebKitAPI/PlatformGTK.cmake:
221         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: Added.
222         (TestWebKitAPI::TEST_F):
223
224 2015-06-26  Per Arne Vollan  <peavo@outlook.com>
225
226         WinLauncher fails to download files.
227         https://bugs.webkit.org/show_bug.cgi?id=146242
228
229         Reviewed by Alex Christensen.
230
231         Added WinLauncher download delegate.
232
233         * WinLauncher/Common.cpp:
234         * WinLauncher/WebDownloadDelegate.cpp: Added.
235         (WebDownloadDelegate::WebDownloadDelegate):
236         (WebDownloadDelegate::~WebDownloadDelegate):
237         (WebDownloadDelegate::QueryInterface):
238         (WebDownloadDelegate::AddRef):
239         (WebDownloadDelegate::Release):
240         (WebDownloadDelegate::decideDestinationWithSuggestedFilename):
241         (WebDownloadDelegate::didCancelAuthenticationChallenge):
242         (WebDownloadDelegate::didCreateDestination):
243         (WebDownloadDelegate::didFailWithError):
244         (WebDownloadDelegate::didReceiveAuthenticationChallenge):
245         (WebDownloadDelegate::didReceiveDataOfLength):
246         (WebDownloadDelegate::didReceiveResponse):
247         (WebDownloadDelegate::shouldDecodeSourceDataOfMIMEType):
248         (WebDownloadDelegate::willResumeWithResponse):
249         (WebDownloadDelegate::willSendRequest):
250         (WebDownloadDelegate::didBegin):
251         (WebDownloadDelegate::didFinish):
252         * WinLauncher/WebDownloadDelegate.h: Added.
253         * WinLauncher/WinLauncher.cpp:
254         (WinLauncher::setAccessibilityDelegate):
255         (WinLauncher::setResourceLoadDelegate):
256         (WinLauncher::setDownloadDelegate):
257         (WinLauncher::mainFrame):
258         * WinLauncher/WinLauncher.h:
259         (WinLauncher::standardPreferences):
260         (WinLauncher::privatePreferences):
261         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
262         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
263         * WinLauncher/WinMain.cpp:
264         (wWinMain):
265
266 2015-06-26  Csaba Osztrogonác  <ossy@webkit.org>
267
268         [EFL] Bump libseccomp version to 2.2.1
269         https://bugs.webkit.org/show_bug.cgi?id=146341
270
271         Reviewed by Gyuyoung Kim.
272
273         * efl/jhbuild.modules:
274         * efl/jhbuildrc: Enabled libseccomp build on AArch64.
275         * efl/patches/libseccomp-pick-up-CC.patch: Removed, we don't need it anymore.
276
277 2015-06-25  Alex Christensen  <achristensen@webkit.org>
278
279         [Content Extensions] Add a way to match a domain but not subdomains
280         https://bugs.webkit.org/show_bug.cgi?id=146241
281         rdar://problem/21557754
282
283         Reviewed by Darin Adler.
284
285         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
286         (TestWebKitAPI::TEST_F):
287         Update subdomain test because of changed behavior and add test for new '*' functionality.
288
289 2015-06-25  Jaehun Lim  <ljaehun.lim@samsung.com>
290
291         Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes.
292         https://bugs.webkit.org/show_bug.cgi?id=146308
293
294         Reviewed by Csaba Osztrogonác.
295
296         ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536.
297
298         * Scripts/webkitperl/FeatureList.pm:
299
300 2015-06-25  Carlos Garcia Campos  <cgarcia@igalia.com>
301
302         [GTK] Add initial WebKitWebsiteDataManager API for process configuration options
303         https://bugs.webkit.org/show_bug.cgi?id=146149
304
305         Reviewed by Sergio Villar Senin.
306
307         Update unit tests to use WebKitWebsiteDataManager.
308
309         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
310         (testWebContextConfiguration):
311         (serverCallback):
312         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
313         (Test::Test): Use WebKitWebsiteDataManager and set all possible
314         values to ensure unit tests don't write outside the temporary directory.
315         (Test::~Test): Explicitly reset the web context to ensure its
316         objects are released before the leaks check.
317         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
318         (WebViewTest::wait): Fix the GSource used, since we are receiving
319         a double in seconds, but using g_timeout_add_seconds() that
320         expects an unsigned in seconds. Use GMainLoopSource to correctly
321         handle the value and simplify the code.
322
323 2015-06-24  Jason Marcell  <jmarcell@apple.com>
324
325         Work towards: Add status of Safari projects on iOS Dashboard on build-safari
326         https://bugs.webkit.org/show_bug.cgi?id=146126
327         <rdar://problem/18226291>
328
329         Reviewed by Alexey Proskuryakov.
330
331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
332         (documentReady): Using combined queues to display iOS projects
333
334 2015-06-24  Doug Russell  <d_russell@apple.com>
335
336         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject 
337         when posting a selection notification when on the border between two accessibilityObjects
338         https://bugs.webkit.org/show_bug.cgi?id=146177
339
340         Reviewed by Darin Adler.
341
342         Add support for mapping WebCore Accessibility types into JSValueRef types
343         so they can be used in tests.
344
345         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
346         (webAccessibilityObjectWrapperClass):
347         (-[AccessibilityNotificationHandler startObserving]):
348         (makeValueRefForValue):
349         (makeArrayRefForArray):
350         (makeObjectRefForDictionary):
351         (-[AccessibilityNotificationHandler _notificationReceived:]):
352         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
353         (webAccessibilityObjectWrapperClass):
354         (-[AccessibilityNotificationHandler startObserving]):
355         (makeValueRefForValue):
356         (makeArrayRefForArray):
357         (makeObjectRefForDictionary):
358         (-[AccessibilityNotificationHandler _notificationReceived:]):
359
360 2015-06-24  Zalan Bujtas  <zalan@apple.com>
361
362         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
363         https://bugs.webkit.org/show_bug.cgi?id=146273
364         rdar://problem/18509840
365
366         Reviewed by Simon Fraser.
367
368         Due to the floating point approximate representation, we can't always produce
369         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
370         and by changing the rounding in roundToDevicePixel() from float to double.
371
372         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
373         (TestWebKitAPI::TEST):
374
375 2015-06-24  Brady Eidson  <beidson@apple.com>
376
377         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
378         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
379
380         Reviewed by Alex Christensen.
381
382         - Update WKTR to the new client structure.
383         - Update existing TestWebKitAPI tests to either use the new client structure or
384           assign the old function signature to the updated variable name.
385         - Include a new test.
386
387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
388
389         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
390         (TestWebKitAPI::runJavaScriptAlert):
391
392         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
393         (TestWebKitAPI::TEST):
394
395         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
396         (TestWebKitAPI::analyzeDialogArguments):
397         (TestWebKitAPI::runJavaScriptAlert):
398         (TestWebKitAPI::runJavaScriptConfirm):
399         (TestWebKitAPI::runJavaScriptPrompt):
400         (TestWebKitAPI::createNewPage):
401         (TestWebKitAPI::TEST):
402
403         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
404         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
405
406         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
407         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
408
409         * WebKitTestRunner/TestController.cpp:
410         (WTR::TestController::createOtherPage):
411         (WTR::TestController::createWebViewWithOptions):
412
413 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
414
415         Refactoring benchmark runner script to follow pep8 code style.
416         https://bugs.webkit.org/show_bug.cgi?id=146264
417
418         Reviewed by Ryosuke Niwa.
419
420         Refactor benchmark runner script to follow pep8 code style.
421
422         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
423         (GenericBenchmarkBuilder.prepare):
424         (GenericBenchmarkBuilder._run_create_script):
425         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
426         (GenericBenchmarkBuilder._fetch_remote_archive):
427         (GenericBenchmarkBuilder):
428         (GenericBenchmarkBuilder._checkout_with_subversion):
429         (GenericBenchmarkBuilder._apply_patch):
430         (GenericBenchmarkBuilder.clean):
431         (GenericBenchmarkBuilder._runCreateScript): Deleted.
432         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
433         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
434         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
435         (GenericBenchmarkBuilder._applyPatch): Deleted.
436         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
437         (BenchmarkRunner.__init__):
438         (BenchmarkRunner._find_plan_file):
439         (BenchmarkRunner.execute):
440         (BenchmarkRunner._cleanup):
441         (BenchmarkRunner._dump):
442         (BenchmarkRunner._wrap):
443         (BenchmarkRunner._merge):
444         (BenchmarkRunner._show_results):
445         (BenchmarkRunner._findPlanFile): Deleted.
446         (BenchmarkRunner.cleanup): Deleted.
447         (BenchmarkRunner.dump): Deleted.
448         (BenchmarkRunner.wrap): Deleted.
449         (BenchmarkRunner.merge): Deleted.
450         (BenchmarkRunner.show_results): Deleted.
451         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
452         (BrowserDriver.prepare_env):
453         (BrowserDriver.launch_url):
454         (BrowserDriver.close_browsers):
455         (BrowserDriver.prepareEnv): Deleted.
456         (BrowserDriver.launchUrl): Deleted.
457         (BrowserDriver.closeBrowser): Deleted.
458         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
459         (OSXBrowserDriver):
460         (OSXBrowserDriver.prepare_env):
461         (OSXBrowserDriver.close_browsers):
462         (OSXBrowserDriver._launch_process):
463         (OSXBrowserDriver._terminiate_processes):
464         (OSXBrowserDriver._launch_process_with_caffinate):
465         (OSXBrowserDriver._screen_size):
466         (OSXBrowserDriver.prepareEnv): Deleted.
467         (OSXBrowserDriver.closeBrowsers): Deleted.
468         (OSXBrowserDriver.launchProcess): Deleted.
469         (OSXBrowserDriver.terminateProcesses): Deleted.
470         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
471         (OSXBrowserDriver.screenSize): Deleted.
472         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
473         (OSXChromeDriver):
474         (OSXChromeDriver.launch_url):
475         (OSXChromeCanaryDriver):
476         (OSXChromeCanaryDriver.launch_url):
477         (OSXChromeDriver.launchUrl): Deleted.
478         (OSXChromeCanaryDriver.launchUrl): Deleted.
479         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
480         (OSXFirefoxDriver):
481         (OSXFirefoxDriver.launch_url):
482         (OSXFirefoxNightlyDriver):
483         (OSXFirefoxNightlyDriver.launch_url):
484         (OSXFirefoxDriver.launchUrl): Deleted.
485         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
486         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
487         (OSXSafariDriver):
488         (OSXSafariDriver.prepare_env):
489         (OSXSafariDriver.launch_url):
490         (OSXSafariDriver.close_browsers):
491         (OSXSafariDriver._maximize_window):
492         (OSXSafariDriver.prepareEnv): Deleted.
493         (OSXSafariDriver.launchUrl): Deleted.
494         (OSXSafariDriver.closeBrowsers): Deleted.
495         (OSXSafariDriver.maximizeWindow): Deleted.
496         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
497         (HTTPServerDriver.fetch_result):
498         (HTTPServerDriver.kill_server):
499         (HTTPServerDriver.get_return_code):
500         (HTTPServerDriver.set_device_id):
501         (HTTPServerDriver.fetchResult): Deleted.
502         (HTTPServerDriver.killServer): Deleted.
503         (HTTPServerDriver.getReturnCode): Deleted.
504         (HTTPServerDriver.setDeviceID): Deleted.
505         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
506         (SimpleHTTPServerDriver.serve):
507         (SimpleHTTPServerDriver.base_url):
508         (SimpleHTTPServerDriver.fetch_result):
509         (SimpleHTTPServerDriver.kill_server):
510         (SimpleHTTPServerDriver.get_return_code):
511         (SimpleHTTPServerDriver): Deleted.
512         (SimpleHTTPServerDriver.baseUrl): Deleted.
513         (SimpleHTTPServerDriver.fetchResult): Deleted.
514         (SimpleHTTPServerDriver.killServer): Deleted.
515         (SimpleHTTPServerDriver.getReturnCode): Deleted.
516         * Scripts/webkitpy/benchmark_runner/utils.py:
517         (get_path_from_project_root):
518         (force_remove):
519         (getPathFromProjectRoot): Deleted.
520         (forceRemove): Deleted.
521
522 2015-06-23  Anders Carlsson  <andersca@apple.com>
523
524         Add operator! and copy/move constructors to WeakObjCPtr
525         https://bugs.webkit.org/show_bug.cgi?id=146255
526
527         Reviewed by Andreas Kling.
528
529         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
530         (TEST):
531
532 2015-06-23  Simon Fraser  <simon.fraser@apple.com>
533
534         Expose some more rendering progress events, and have MiniBrowser log for each of them
535         https://bugs.webkit.org/show_bug.cgi?id=146227
536
537         Reviewed by Darin Adler.
538
539         Register for layout milestones/rendering progress events in the WK1 and WK2
540         browser window controllers, and, if logging is turned on, log when they are
541         reached.
542
543         * MiniBrowser/mac/WK1BrowserWindowController.m:
544         (-[WK1BrowserWindowController awakeFromNib]):
545         (-[WK1BrowserWindowController webView:didLayout:]):
546         * MiniBrowser/mac/WK2BrowserWindowController.m:
547         (-[WK2BrowserWindowController awakeFromNib]):
548         (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]):
549
550 2015-06-23  Brady Eidson  <beidson@apple.com>
551
552         WKFrameInfo should have an accessor for the Frame's current security origin.
553         https://bugs.webkit.org/show_bug.cgi?id=146162
554
555         Reviewed by Dan Bernstein.
556
557         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
558         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added.
559         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added.
560         (sawDialog):
561         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
562         (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
563         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
564         (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
565         (TEST):
566
567 2015-06-23  Tanay C  <tanay.c@samsung.com>
568
569         Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
570         https://bugs.webkit.org/show_bug.cgi?id=146007
571
572         Reviewed by Darin Adler.
573
574         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
575         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
576         (pluginLogWithWindowObject):
577         (pluginLogWithArguments):
578         (pluginLog):
579         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
580         (PluginTest::executeScript):
581         (PluginTest::log):
582
583 2015-06-23  Csaba Osztrogonác  <ossy@webkit.org>
584
585         [EFL] Add libhyphen-dev as dependency after r185862
586         https://bugs.webkit.org/show_bug.cgi?id=146230
587
588         Reviewed by Gyuyoung Kim.
589
590         * efl/install-dependencies:
591
592 2015-06-22  Ryuan Choi  <ryuan.choi@navercorp.com>
593
594         [EFL] Hyphenation is not supported
595         https://bugs.webkit.org/show_bug.cgi?id=89830
596
597         Reviewed by Gyuyoung Kim.
598
599         * efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test.
600
601 2015-06-22  Dewei Zhu  <dewei_zhu@apple.com>
602
603         Get rid of factory json files in benchmark_runner
604         https://bugs.webkit.org/show_bug.cgi?id=146175
605
606         Reviewed by Ryosuke Niwa.
607
608         Get rid of factory json files in benchmark_runner and refactoring the code.
609
610         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:
611         (benchmark_builder_loader):
612         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:
613         (BenchmarkBuilderFactory):
614         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed.
615         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
616         (GenericBenchmarkBuilder):
617         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
618         (BenchmarkRunner.__init__):
619         (BenchmarkRunner.execute):
620         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py:
621         (browser_driver_loader):
622         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
623         (BrowserDriver):
624         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
625         (BrowserDriverFactory):
626         (BrowserDriverFactory.available_platforms):
627         (BrowserDriverFactory.available_browsers):
628         (BrowserDriverFactory.add_browser_driver):
629         (BrowserDriverFactory.create):
630         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed.
631         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
632         (OSXBrowserDriver):
633         (OSXBrowserDriver.prepareEnv):
634         (OSXBrowserDriver.terminateProcesses):
635         (OSXBrowserDriver.screenSize):
636         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
637         (OSXChromeDriver):
638         (OSXChromeCanaryDriver):
639         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
640         (OSXFirefoxDriver):
641         (OSXFirefoxNightlyDriver):
642         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
643         (OSXSafariDriver):
644         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
645         (GenericFactory.create):
646         (GenericFactory.add):
647         (GenericFactory.iterateGetItem): Deleted.
648         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
649         (http_server_driver_loader):
650         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
651         (HTTPServerDriver):
652         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
653         (HTTPServerDriverFactory):
654         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed.
655         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
656         (SimpleHTTPServerDriver):
657         * Scripts/webkitpy/benchmark_runner/utils.py:
658         (is_subclass):
659         (load_subclasses):
660         (ModuleNotFoundError): Deleted.
661         (loadModule): Deleted.
662         (loadJSONFromFile): Deleted.
663
664 2015-06-22  Simon Fraser  <simon.fraser@apple.com>
665
666         Make it possible to enable incremental rendering suppression in MiniBrowser
667         https://bugs.webkit.org/show_bug.cgi?id=146223
668         
669         Reviewed by Tim Horton.
670
671         Add a menu item to enable incremental rendering suppression to MiniBrowser.
672         
673         For WK1, this just toggles a pref, and takes effect immediately.
674         
675         For WK2, this is a WKConfiguration property, so only affects new web views.
676         
677         Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused
678         logging on launch.
679
680         * MiniBrowser/mac/AppDelegate.m:
681         (defaultConfiguration):
682         * MiniBrowser/mac/BrowserWindow.xib:
683         * MiniBrowser/mac/SettingsController.h:
684         * MiniBrowser/mac/SettingsController.m:
685         (-[SettingsController _populateMenu]):
686         (-[SettingsController validateMenuItem:]):
687         (-[SettingsController toggleIncrementalRenderingSuppressed:]):
688         (-[SettingsController incrementalRenderingSuppressed]):
689         * MiniBrowser/mac/WK1BrowserWindowController.m:
690         (-[WK1BrowserWindowController didChangeSettings]):
691
692 2015-06-19  Filip Pizlo  <fpizlo@apple.com>
693
694         Run CDjs as part of JSC stress testing
695         https://bugs.webkit.org/show_bug.cgi?id=146174
696
697         Reviewed by Geoffrey Garen.
698
699         * Scripts/run-javascriptcore-tests:
700         (runJSCStressTests): Make this aware of the cdjs-tests.yaml.
701         * Scripts/run-jsc-stress-tests:
702         - Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed.
703         - Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests.
704         - Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory.
705
706 2015-06-21  Alexey Proskuryakov  <ap@apple.com>
707
708         REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
709         https://bugs.webkit.org/show_bug.cgi?id=146121
710         rdar://problem/21395180
711
712         Reviewed by Darin Adler.
713
714         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
715         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
716         (-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
717         (TestWebKitAPI::overrideAppleLanguages):
718         (TestWebKitAPI::languageForSystemLanguage):
719         (TestWebKitAPI::TEST):
720
721 2015-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
722
723         [CMake] Ignore warnings from system headers when compiling Tools
724         https://bugs.webkit.org/show_bug.cgi?id=146185
725
726         Reviewed by Martin Robinson.
727
728         Use the SYSTEM argument to the include_directories() command to silence compiler warnings
729         from system headers that we don't control.
730
731         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
732         * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
733         * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
734         * ImageDiff/PlatformGTK.cmake:
735         * MiniBrowser/efl/CMakeLists.txt:
736         * MiniBrowser/gtk/CMakeLists.txt:
737         * TestWebKitAPI/PlatformEfl.cmake:
738         * TestWebKitAPI/PlatformGTK.cmake:
739         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
740         * WebKitTestRunner/CMakeLists.txt:
741         * WebKitTestRunner/PlatformEfl.cmake:
742         * WebKitTestRunner/PlatformGTK.cmake:
743
744 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
745
746         [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
747         https://bugs.webkit.org/show_bug.cgi?id=146186
748
749         Reviewed by Martin Robinson.
750
751         Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
752         deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
753
754         * MiniBrowser/gtk/CMakeLists.txt:
755
756 2015-06-19  Ryosuke Niwa  <rniwa@webkit.org>
757
758         Build fix after r146125.
759
760         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
761         (OSXSafariDriver):
762         (OSXSafariDriver.prepareEnv):
763
764 2015-06-19  Brady Eidson  <beidson@apple.com>
765
766         Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.
767         https://bugs.webkit.org/show_bug.cgi?id=146152
768
769         Reviewed by Dan Bernstein.
770
771         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
772         * WebKitTestRunner/WebNotificationProvider.cpp:
773
774 2015-06-19  Mark Lam  <mark.lam@apple.com>
775
776         CheckedArithmetic's operator bool() and operator==() is broken.
777         https://bugs.webkit.org/show_bug.cgi?id=146129
778
779         Reviewed by Geoffrey Garen and Oliver Hunt.
780
781         Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal
782         and overflow scenarios in usage of the Checked arithmetic class.
783
784         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
785         (TestWebKitAPI::OverflowCrashLogger::overflowed):
786         (TestWebKitAPI::OverflowCrashLogger::clearOverflow):
787         (TestWebKitAPI::OverflowCrashLogger::crash):
788         (TestWebKitAPI::OverflowCrashLogger::reset):
789         (TestWebKitAPI::OverflowCrashLogger::hasOverflowed):
790         (TestWebKitAPI::OverflowCrashLogger::overflowCount):
791         (TestWebKitAPI::OverflowCrashLogger::didCrash):
792         - crash logger for verifying that a crash occurs when expected. 
793
794         (TestWebKitAPI::resetOverflow):
795         - convenience function for resetting a test value to an initial overflowed state
796           before a crash.  We will use this value in the overflow testing.
797
798         (TestWebKitAPI::CheckedArithmeticTester::run):
799         - Added new tests for all the comparison operators.
800
801 2015-06-19  Per Arne Vollan  <peavo@outlook.com>
802
803         Fix the Windows build after r185721
804         https://bugs.webkit.org/show_bug.cgi?id=146146
805
806         Reviewed by Csaba Osztrogonác.
807
808         Speculative buildfix.
809
810         * DumpRenderTree/win/UIDelegate.h:
811         (UIDelegate::unused4): Added.
812         (UIDelegate::webViewShouldInterruptJavaScript): Deleted.
813
814 2015-06-19  Diego Pino Garcia  <dpino@igalia.com>
815
816         Unreviewed. Add myself as a committer.
817
818         * Scripts/webkitpy/common/config/contributors.json:
819
820 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
821
822         Remove unnecessary svn:executable flags
823         https://bugs.webkit.org/show_bug.cgi?id=146107
824
825         Reviewed by Alexey Proskuryakov.
826
827         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable.
828         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable.
829         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable.
830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable.
831         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable.
832         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable.
833         * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable.
834         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable.
835         * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable.
836         * DumpRenderTree/win/TextInputController.h: Removed property svn:executable.
837         * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable.
838         * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable.
839         * Scripts/webkitpy/port/driver.py: Removed property svn:executable.
840         * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable.
841
842 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
843
844         Disable tests on the WinCairo buildbot
845         https://bugs.webkit.org/show_bug.cgi?id=146106
846
847         Reviewed by Alexey Proskuryakov.
848
849         * BuildSlaveSupport/build.webkit.org-config/config.json:
850         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
851
852 2015-06-19  Hunseop Jeong  <hs85.jeong@samsung.com>
853
854         [EFL] Fix the minibrowser after r185725
855         https://bugs.webkit.org/show_bug.cgi?id=146135
856
857         Reviewed by Gyuyoung Kim.
858
859         Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard
860         for the elm_config_accel_preference_set() to set the config of acceleration preference.
861
862         * MiniBrowser/efl/main.c:
863         (elm_main): Deleted the HAVE_ECORE_X guard.
864
865 2015-06-18  Dewei Zhu  <dewei_zhu@apple.com>
866
867         Extend capability of run-benchmark script to support mobile device
868         https://bugs.webkit.org/show_bug.cgi?id=146125
869
870         Reviewed by Ryosuke Niwa.
871
872         Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to
873         benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo.
874
875         * Scripts/run-benchmark:
876         (main): Deleted.
877         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
878         (BenchmarkRunner.__init__):
879         (BenchmarkRunner.execute):
880         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
881         (BrowserDriver.prepareEnv):
882         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
883         (OSXBrowserDriver.prepareEnv):
884         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
885         (OSXSafariDriver.prepareEnv):
886         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
887         (HTTPServerDriver.getReturnCode):
888         (HTTPServerDriver):
889         (HTTPServerDriver.setDeviceID):
890         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark.
891         (parse_args):
892         (start):
893         (main):
894         * Scripts/webkitpy/benchmark_runner/utils.py:
895         (getPathFromProjectRoot):
896
897 2015-06-18  Jon Lee  <jonlee@apple.com>
898
899         Unreviewed. Add Matt Daiter as a contributor.
900
901         * Scripts/webkitpy/common/config/contributors.json:
902
903 2015-06-18  Mark Lam  <mark.lam@apple.com>
904
905         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
906         https://bugs.webkit.org/show_bug.cgi?id=146103
907
908         Not reviewed.
909
910         Follow up to fix some typos not caught before original patch was landed.
911
912         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
913         (TestWebKitAPI::CheckedArithmeticTester::run):
914         (TestWebKitAPI::AllowMixedSignednessTest::run):
915         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
916
917 2015-06-18  Daniel Bates  <dabates@apple.com>
918
919         Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout
920         https://bugs.webkit.org/show_bug.cgi?id=146082
921
922         Reviewed by Darin Adler.
923
924         The function webkitdirs::runGitUpdate may not update the Git checkout in the current
925         working directory after being invoked in a different Git checkout. In particular,
926         calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside
927         a pure Git checkout g will fail to update g.
928
929         Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether
930         the current working directory is a Git SVN checkout. And isGitSVN() caches its result
931         to speed up subsequent queries. This prevents runGitUpdate() from being used to update
932         an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory
933         different than the current working directory). Instead runGitUpdate() should check
934         whether the current working directory is a Git SVN checkout on each invocation.
935
936         * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate().
937         (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git
938         SVN directory from isGitSVN().
939         (isGitSVN): Implemented in terms of isGitSVNDirectory().
940         * Scripts/webkitdirs.pm:
941         (runGitUpdate): Modified to use isGitSVNDirectory().
942
943 2015-06-18  Mark Lam  <mark.lam@apple.com>
944
945         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
946         https://bugs.webkit.org/show_bug.cgi?id=146103
947
948         Reviewed by Anders Carlsson.
949
950         Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as
951         part of a large macro.  This makes them harder to:
952
953         1. write: no editor help with indentations, have to add trailing '\'s,
954            inconvenient to add line breaks and comments.
955
956         2. read: no chroma coding / syntax highlighting.
957
958         3. debug: compile time errors are reported as being on the single line where
959            the macro is used.
960
961         Refactoring the tests to use C++ templates solves all these issues.
962
963         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
964         (TestWebKitAPI::CheckedArithmeticTester::run):
965         (TestWebKitAPI::AllowMixedSignednessTest::run):
966         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
967         (TestWebKitAPI::CoerceLiteralToUnsigned::coerce):
968         (TestWebKitAPI::CoerceLiteralNop::coerce):
969
970 2015-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
971
972         [EFL][WK2] Use Web Browser cache model in MiniBrowser
973         https://bugs.webkit.org/show_bug.cgi?id=112273
974
975         Reviewed by Laszlo Gombos.
976
977         Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser
978         instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER).
979         This way we have a decent cache capacity and the page cache actually works.
980
981         * MiniBrowser/efl/main.c:
982         (elm_main):
983
984 2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
985
986         Remove redundant Chromium bug keyword
987         https://bugs.webkit.org/show_bug.cgi?id=146097
988
989         Reviewed by Csaba Osztrogonác.
990
991         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
992         (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
993         (TestExpectationLine._format_line): Deleted.
994
995 2015-06-17  Daniel Bates  <dabates@apple.com>
996
997         Client may receive began editing callback for already focused text field
998         https://bugs.webkit.org/show_bug.cgi?id=146074
999         <rdar://problem/21293562>
1000
1001         Reviewed by Darin Adler.
1002
1003         Add a unit test to ensure that a client receives exactly one began editing
1004         callback when a text field is newly focused. In particular, dispatching
1005         a DOM focus event at an already focused text field does not dispatch a
1006         began editing callback to the client.
1007
1008         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
1009         (TestWebKitAPI::TEST_F):
1010
1011 2015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1012
1013         [Win]Implement layoutTestController.dispatchPendingLoadRequests. 
1014         https://bugs.webkit.org/show_bug.cgi?id=26481
1015
1016         Reviewed by Darin Adler.
1017
1018         Implement WebView::dispatchPendingLoadRequests() private API for test runner.
1019
1020         * DumpRenderTree/win/TestRunnerWin.cpp:
1021         (TestRunner::dispatchPendingLoadRequests):
1022         (TestRunner::overridePreference):
1023
1024 2015-06-17  Alex Christensen  <achristensen@webkit.org>
1025
1026         [Content Extensions] Fail to parse invalid arrays
1027         https://bugs.webkit.org/show_bug.cgi?id=146079
1028         rdar://problem/21422649
1029
1030         Reviewed by Benjamin Poulain.
1031
1032         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1033         (TestWebKitAPI::TEST_F):
1034         Correct and add parsing tests with invalid arrays.
1035
1036 2015-06-17  Matt Rajca  <mrajca@apple.com>
1037
1038         Unreviewed. Added myself as a committer.
1039
1040         * Scripts/webkitpy/common/config/contributors.json:
1041
1042 2015-06-17  Daniel Bates  <dabates@apple.com>
1043
1044         Export VCSUtils::gitTreeDirectory()
1045         <rdar://problem/21248901>
1046
1047         Rubber-stamped by Alexey Proskuryakov.
1048
1049         * Scripts/VCSUtils.pm:
1050
1051 2015-06-17  Tim Horton  <timothy_horton@apple.com>
1052
1053         Safari tabs still have shrunken content after coming out of fullscreen
1054         https://bugs.webkit.org/show_bug.cgi?id=146037
1055         <rdar://problem/21105960>
1056
1057         Reviewed by Simon Fraser and Darin Adler.
1058
1059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1060         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added.
1061         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]):
1062         (TEST):
1063         Add a test that ensures that disabling scale-to-fit mode correctly updates
1064         the page's layout.
1065
1066 2015-06-17  Dan Bernstein  <mitz@apple.com>
1067
1068         [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate
1069         https://bugs.webkit.org/show_bug.cgi?id=145957
1070
1071         Reviewed by Darin Adler.
1072
1073         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1074         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:.
1075
1076 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
1077
1078         AX:  iOS accessibility tests are not running because we need WKTR support
1079         https://bugs.webkit.org/show_bug.cgi?id=145991
1080
1081         Reviewed by Daniel Bates.
1082
1083         Add support for WKTR iOS accessibility.
1084         Utilize the notification handling mechanisms that Mac already uses.
1085         Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names.
1086
1087         * DumpRenderTree/AccessibilityUIElement.cpp:
1088         (stringForSelectionCallback):
1089         (getIdentifierCallback):
1090         (getTraitsCallback):
1091         (getElementTextPositionCallback):
1092         (getElementTextLengthCallback):
1093         (AccessibilityUIElement::getJSClass):
1094         (getIPhoneLabelCallback): Deleted.
1095         (getIPhoneHintCallback): Deleted.
1096         (getIPhoneValueCallback): Deleted.
1097         (getIPhoneIdentifierCallback): Deleted.
1098         (getIPhoneTraitsCallback): Deleted.
1099         (getIPhoneIsElementCallback): Deleted.
1100         (getIPhoneElementTextPositionCallback): Deleted.
1101         (getIPhoneElementTextLengthCallback): Deleted.
1102         * DumpRenderTree/AccessibilityUIElement.h:
1103         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1104         (AccessibilityUIElement::identifier):
1105         (AccessibilityUIElement::traits):
1106         (AccessibilityUIElement::elementTextPosition):
1107         (AccessibilityUIElement::elementTextLength):
1108         (AccessibilityUIElement::description):
1109         (AccessibilityUIElement::orientation):
1110         (AccessibilityUIElement::stringValue):
1111         (AccessibilityUIElement::language):
1112         (AccessibilityUIElement::helpText):
1113         (AccessibilityUIElement::intValue):
1114         (AccessibilityUIElement::isSelected):
1115         (AccessibilityUIElement::isExpanded):
1116         (AccessibilityUIElement::documentURI):
1117         (AccessibilityUIElement::addNotificationListener):
1118         (AccessibilityUIElement::removeNotificationListener):
1119         (AccessibilityUIElement::isFocusable):
1120         (AccessibilityUIElement::isIgnored):
1121         (AccessibilityUIElement::hasPopup):
1122         (AccessibilityUIElement::iphoneLabel): Deleted.
1123         (AccessibilityUIElement::iphoneHint): Deleted.
1124         (AccessibilityUIElement::iphoneValue): Deleted.
1125         (AccessibilityUIElement::iphoneIdentifier): Deleted.
1126         (AccessibilityUIElement::iphoneTraits): Deleted.
1127         (AccessibilityUIElement::iphoneIsElement): Deleted.
1128         (AccessibilityUIElement::iphoneElementTextPosition): Deleted.
1129         (AccessibilityUIElement::iphoneElementTextLength): Deleted.
1130         (_accessibilityNotificationCallback): Deleted.
1131         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1132         (WTR::AccessibilityUIElement::isValid):
1133         (WTR::AccessibilityUIElement::identifier):
1134         (WTR::AccessibilityUIElement::traits):
1135         (WTR::AccessibilityUIElement::elementTextPosition):
1136         (WTR::AccessibilityUIElement::elementTextLength):
1137         (WTR::AccessibilityUIElement::stringForSelection):
1138         (WTR::AccessibilityUIElement::elementsForRange):
1139         (WTR::AccessibilityUIElement::increaseTextSelection):
1140         (WTR::AccessibilityUIElement::decreaseTextSelection):
1141         (WTR::AccessibilityUIElement::linkedElement):
1142         (WTR::AccessibilityUIElement::headerElementAtIndex):
1143         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1144         (WTR::AccessibilityUIElement::characterAtOffset):
1145         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1146         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1147         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1148         (WTR::findAccessibleObjectById):
1149         (WTR::AccessibilityController::accessibleElementById):
1150         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1151         (+[NSString stringWithJSStringRef:]):
1152         (-[NSString createJSStringRef]):
1153         (WTR::convertNSArrayToVector):
1154         (WTR::concatenateAttributeAndValue):
1155         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1156         (WTR::AccessibilityUIElement::isEqual):
1157         (WTR::AccessibilityUIElement::headerElementAtIndex):
1158         (WTR::AccessibilityUIElement::linkedElement):
1159         (WTR::AccessibilityUIElement::getLinkedUIElements):
1160         (WTR::AccessibilityUIElement::elementAtPoint):
1161         (WTR::convertElementsToObjectArray):
1162         (WTR::AccessibilityUIElement::elementsForRange):
1163         (WTR::AccessibilityUIElement::indexOfChild):
1164         (WTR::AccessibilityUIElement::stringAttributeValue):
1165         (WTR::AccessibilityUIElement::description):
1166         (WTR::AccessibilityUIElement::orientation):
1167         (WTR::AccessibilityUIElement::stringValue):
1168         (WTR::AccessibilityUIElement::language):
1169         (WTR::AccessibilityUIElement::helpText):
1170         (WTR::AccessibilityUIElement::x):
1171         (WTR::AccessibilityUIElement::clickPointX):
1172         (WTR::AccessibilityUIElement::clickPointY):
1173         (WTR::AccessibilityUIElement::intValue):
1174         (WTR::AccessibilityUIElement::minValue):
1175         (WTR::AccessibilityUIElement::maxValue):
1176         (WTR::AccessibilityUIElement::valueDescription):
1177         (WTR::AccessibilityUIElement::isSelected):
1178         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1179         (WTR::AccessibilityUIElement::stringForRange):
1180         (WTR::AccessibilityUIElement::attributedStringForRange):
1181         (WTR::AccessibilityUIElement::attributesOfHeader):
1182         (WTR::AccessibilityUIElement::traits):
1183         (WTR::AccessibilityUIElement::identifier):
1184         (WTR::AccessibilityUIElement::rowCount):
1185         (WTR::AccessibilityUIElement::rowIndexRange):
1186         (WTR::AccessibilityUIElement::columnIndexRange):
1187         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1188         (WTR::AccessibilityUIElement::horizontalScrollbar):
1189         (WTR::AccessibilityUIElement::documentURI):
1190         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1191         (WTR::AccessibilityUIElement::increaseTextSelection):
1192         (WTR::AccessibilityUIElement::decreaseTextSelection):
1193         (WTR::AccessibilityUIElement::stringForSelection):
1194         (WTR::AccessibilityUIElement::elementTextPosition):
1195         (WTR::AccessibilityUIElement::elementTextLength):
1196         (WTR::AccessibilityUIElement::url):
1197         (WTR::AccessibilityUIElement::addNotificationListener):
1198         (WTR::AccessibilityUIElement::removeNotificationListener):
1199         (WTR::AccessibilityUIElement::isFocusable):
1200         (WTR::AccessibilityUIElement::isIgnored):
1201         (WTR::AccessibilityUIElement::hasPopup):
1202         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1203         (WTR::_CGPathEnumerationIteration):
1204         (WTR::AccessibilityUIElement::pathDescription):
1205         (WTR::AccessibilityUIElement::supportedActions):
1206
1207 2015-06-16  Mark Lam  <mark.lam@apple.com>
1208
1209         Use NakedPtr<Exception>& to return exception results.
1210         https://bugs.webkit.org/show_bug.cgi?id=145870
1211
1212         Reviewed by Anders Carlsson and Filip Pizlo.
1213
1214         * TestWebKitAPI/CMakeLists.txt:
1215         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1216         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1218         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added.
1219         (TestWebKitAPI::TEST):
1220         (TestWebKitAPI::nakedPtrFoo):
1221
1222 2015-06-16  Tobias Reiss  <tobi+webkit@basecode.de>
1223
1224         Unreviewed. Adding myself as a committer.
1225
1226         * Scripts/webkitpy/common/config/contributors.json:
1227
1228 2015-06-15  Alexey Proskuryakov  <ap@apple.com>
1229
1230         Add test expectations for El Capitan
1231         https://bugs.webkit.org/show_bug.cgi?id=146005
1232
1233         Rubber-stamped by Dan Bernstein.
1234
1235         Add appropriate tools code.
1236
1237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
1238         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
1239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1240         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1241         Added dashboard support.
1242
1243         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1244         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1245         Trigger the right build queues on check-in.
1246
1247         * Scripts/webkitpy/common/system/platforminfo.py:
1248         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1249         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1250         * Scripts/webkitpy/port/mac.py:
1251         * Scripts/webkitpy/port/mac_unittest.py:
1252         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1253         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1254         Added cases for El Capitan, and updated tests for new baseline search paths.
1255
1256 2015-06-15  Alex Christensen  <achristensen@webkit.org>
1257
1258         [Content Extensions] Make max NFA size and max rule count user defaults.
1259         https://bugs.webkit.org/show_bug.cgi?id=145663
1260
1261         Reviewed by Benjamin Poulain.
1262
1263         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1264         (TestWebKitAPI::TEST_F):
1265
1266 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
1267
1268         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
1269         https://bugs.webkit.org/show_bug.cgi?id=145900
1270
1271         Reviewed by Sam Weinig.
1272
1273         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
1274         (TEST): Added tests.
1275
1276 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1277
1278         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
1279         https://bugs.webkit.org/show_bug.cgi?id=145969
1280
1281         Reviewed by Sergio Villar Senin.
1282
1283         Add a test case to the custom URI schemes unit test.
1284
1285         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1286         (testWebContextURIScheme):
1287
1288 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1289
1290         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
1291         https://bugs.webkit.org/show_bug.cgi?id=145922
1292
1293         Reviewed by Carlos Garcia Campos.
1294
1295         * gtk/jhbuild.modules:
1296         * gtk/patches/glib-warning-fix.patch: Added.
1297
1298 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
1299
1300         Update springLoadingHighlight type
1301         https://bugs.webkit.org/show_bug.cgi?id=145939
1302         rdar://problem/20880213
1303
1304         Reviewed by Darin Adler.
1305
1306         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1307         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1308         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1309         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1310
1311 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
1312
1313         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
1314         https://bugs.webkit.org/show_bug.cgi?id=145945
1315
1316         Reviewed by Stephanie Lewis.
1317
1318         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1319         (OSXBrowserDriver.prepareEnv):
1320         (OSXBrowserDriver.moveCursor): Deleted.
1321         (OSXBrowserDriver): Deleted.
1322         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1323         (OSXSafariDriver.prepareEnv):
1324
1325 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
1326
1327         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
1328         https://bugs.webkit.org/show_bug.cgi?id=145938
1329
1330         Reviewed by Alexey Proskuryakov.
1331
1332         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
1333         LWP::UserAgent to get access to more robust HTTPS support.
1334
1335 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1336
1337         [GTK] Fix return type warning in WebViewTest.cpp
1338         https://bugs.webkit.org/show_bug.cgi?id=145914
1339
1340         Reviewed by Darin Adler.
1341
1342         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1343         (WebViewTest::isEditable):
1344
1345 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
1346
1347         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
1348         https://bugs.webkit.org/show_bug.cgi?id=145799
1349
1350         Reviewed by Carlos Garcia Campos.
1351
1352         Update header inclusions for headers that have been moved
1353         to Source/WTF/wtf/glib/.
1354
1355         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
1356         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
1357
1358         * TestWebKitAPI/PlatformGTK.cmake:
1359         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
1360         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1361         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1362         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1363         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1364         (TestWebKitAPI::GMainLoopSourceTest::finish):
1365         (TestWebKitAPI::GMainLoopSourceTest::source):
1366         (TestWebKitAPI::basicRescheduling):
1367         (TestWebKitAPI::TEST):
1368         (TestWebKitAPI::reentrantRescheduling):
1369         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
1370         (TestWebKitAPI::basicDestroyCallbacks):
1371         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
1372         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
1373         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
1374         (log):
1375         (takeLogStr):
1376         (TestWebKitAPI::TEST):
1377         (TestWebKitAPI::returnOutChar):
1378         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1379         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1380         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
1381         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
1382         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
1383         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
1384         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
1385         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
1386         (TestWebKitAPI::basicRescheduling): Deleted.
1387         (TestWebKitAPI::TEST): Deleted.
1388         (TestWebKitAPI::reentrantRescheduling): Deleted.
1389         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
1390         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
1391         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
1392         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
1393         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
1394         (log): Deleted.
1395         (takeLogStr): Deleted.
1396         (TestWebKitAPI::TEST): Deleted.
1397         (TestWebKitAPI::returnOutChar): Deleted.
1398         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
1399         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1400         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1401         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1402         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1403         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1404         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1405         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
1406         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1407         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1408         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1409         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1410         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1411         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1412         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1413         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
1414         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
1415         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1416         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1417         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1418         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1419         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1420         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1421         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1422         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1423         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1424         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1425         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1426         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1427         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
1428         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1429         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
1430         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1431         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1432         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1433         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1434         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
1435         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1436         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1437         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1438         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1439         * WebKitTestRunner/PlatformGTK.cmake:
1440         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1441         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1442
1443 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1444
1445         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
1446         https://bugs.webkit.org/show_bug.cgi?id=145913
1447
1448         Reviewed by Gyuyoung Kim.
1449
1450         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1451         (TestWebKitAPI::setupGeolocationProvider):
1452         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1453         (TestWebKitAPI::setPageLoaderClient):
1454         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1455         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1456         * WebKitTestRunner/GeolocationProviderMock.cpp:
1457         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1458         * WebKitTestRunner/WebNotificationProvider.cpp:
1459         (WTR::WebNotificationProvider::provider):
1460
1461 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1462
1463         Fix the libusrsctp build with clang
1464         https://bugs.webkit.org/show_bug.cgi?id=145128
1465
1466         Reviewed by Gyuyoung Kim.
1467
1468         * efl/jhbuild.modules:
1469         * gtk/jhbuild.modules:
1470
1471 2015-06-11  Mark Lam  <mark.lam@apple.com>
1472
1473         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
1474         https://bugs.webkit.org/show_bug.cgi?id=145872
1475
1476         Reviewed by Michael Saboff.
1477
1478         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1479         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
1480         - Exercises the JSC ObjC API to call a function which throws an exception.  That
1481           exception will be returned as a JSValue instead of an Exception object.  We
1482           will use this JSValue to test WebCore::reportException() to confirm that it is
1483           able to handle an exception value which is not an Exception object.
1484
1485 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
1486
1487         Move cursor to corner and fix safari window size before running benchmark
1488         https://bugs.webkit.org/show_bug.cgi?id=145858
1489
1490         Reviewed by Ryosuke Niwa
1491
1492         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1493         (OSXBrowserDriver.prepareEnv):
1494         (OSXBrowserDriver):
1495         (OSXBrowserDriver.moveCursor):
1496         (OSXBrowserDriver.getScreenSize):
1497         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1498         (OSXChromeDriver.launchUrl):
1499         (OSXChromeCanaryDriver.launchUrl):
1500         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1501         (OSXFirefoxDriver.launchUrl):
1502         (OSXFirefoxNightlyDriver.launchUrl):
1503         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1504         (OSXSafariDriver.prepareEnv):
1505         (OSXSafariDriver):
1506         (OSXSafariDriver.maximizeWindow):
1507
1508 2015-06-11  Daniel Bates  <dabates@apple.com>
1509
1510         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
1511         https://bugs.webkit.org/show_bug.cgi?id=145319
1512
1513         Reviewed by David Kilzer.
1514
1515         Add SPI wrapper header for CoreSimulator and update the source files to reference
1516         it instead of directly referencing the CoreSimulator header.
1517
1518         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
1519         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
1520         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1521         * LayoutTestRelay/LayoutTestRelay/main.m:
1522
1523 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
1524
1525         [EFL] dimmed area for popup does not cover the fullscreen mode.
1526         https://bugs.webkit.org/show_bug.cgi?id=145133
1527
1528         Reviewed by Gyuyoung Kim.
1529
1530         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
1531         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
1532
1533         * MiniBrowser/efl/main.c:
1534         (on_fullscreen_accept):
1535         (on_fullscreen_deny):
1536         (on_fullscreen_enter):
1537
1538 2015-06-10  Commit Queue  <commit-queue@webkit.org>
1539
1540         Unreviewed, rolling out r185442.
1541         https://bugs.webkit.org/show_bug.cgi?id=145871
1542
1543         seems to have broken WTF.StringOperators test (Requested by
1544         alexchristensen on #webkit).
1545
1546         Reverted changeset:
1547
1548         "[Content Extensions] Limit number of rules."
1549         https://bugs.webkit.org/show_bug.cgi?id=145663
1550         http://trac.webkit.org/changeset/185442
1551
1552 2015-06-10  Alex Christensen  <achristensen@webkit.org>
1553
1554         [Content Extensions] Make max NFA size and max rule count user defaults.
1555         https://bugs.webkit.org/show_bug.cgi?id=145663
1556         rdar://problem/21242407
1557
1558         Reviewed by Benjamin Poulain.
1559
1560         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1561         (TestWebKitAPI::TEST_F):
1562
1563 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1564
1565         [EFL] Execute Javascript method in mini browser address bar.
1566         https://bugs.webkit.org/show_bug.cgi?id=145725
1567
1568         Reviewed by Gyuyoung Kim.
1569
1570         Support 'javascript:' scheme in WebKit EFL Mini Browser.
1571
1572         * MiniBrowser/efl/main.c:
1573         (url_from_user_input):
1574         (url_load_from_user_input):
1575         (on_url_bar_activated):
1576         (elm_main):
1577
1578 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1579
1580         Implement dumpProgressFinishedCallback() for Win layoutTestController.
1581         https://bugs.webkit.org/show_bug.cgi?id=66773
1582
1583         Reviewed by Darin Adler.
1584
1585         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1586         * DumpRenderTree/win/FrameLoadDelegate.h:
1587
1588 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
1589
1590         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
1591         https://bugs.webkit.org/show_bug.cgi?id=145764
1592
1593         Reviewed by Darin Adler.
1594
1595         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
1596         JetStream and SunSpider.
1597
1598         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1599         (GenericBenchmarkBuilder):
1600         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
1601         the whole JSON as the input.
1602         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
1603         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
1604         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1605         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
1606         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
1607         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1608         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1609
1610 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1611
1612         Remove ewstool scripts used by chromium port
1613         https://bugs.webkit.org/show_bug.cgi?id=145789
1614
1615         Reviewed by Csaba Osztrogonác.
1616
1617         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
1618         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
1619         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
1620         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
1621         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
1622
1623 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1624
1625         Unreviewed, updated my list of email addresses.
1626
1627         * Scripts/webkitpy/common/config/contributors.json:
1628
1629 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
1630
1631         [cmake] Fix the style issues in cmake project files
1632         https://bugs.webkit.org/show_bug.cgi?id=145755
1633
1634         Reviewed by Darin Adler.
1635
1636         * TestWebKitAPI/CMakeLists.txt:
1637         * TestWebKitAPI/PlatformEfl.cmake:
1638
1639 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1640
1641         Fix a typo in r185345.
1642
1643         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1644         (OSXSafariDriver.closeBrowsers):
1645
1646 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1647
1648         Yet another unreviewed build fix :(
1649
1650         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1651         (OSXSafariDriver):
1652         (OSXSafariDriver.launchUrl):
1653         (OSXSafariDriver.closeBrowsers):
1654
1655 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1656
1657         Unreviewed build fix. Initialize result in the case things blow up below.
1658
1659         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1660         (BenchmarkRunner.execute):
1661
1662 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1663
1664         Partially revert and fix after r185243.
1665
1666         * Scripts/benchmark_runner/benchmark_runner.py:
1667         * Scripts/run-benchmark:
1668
1669 2015-06-08  Daniel Bates  <dabates@apple.com>
1670
1671         Many LayoutTests/http tests time out in DumpRenderTree
1672         https://bugs.webkit.org/show_bug.cgi?id=145770
1673         <rdar://problem/19593910>
1674
1675         Reviewed by Alexey Proskuryakov.
1676
1677         * DumpRenderTree/ios/Info.plist: Add ATS key.
1678         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1679         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
1680         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
1681         that make use of testRunner.pathToLocalResource().
1682
1683 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
1684
1685         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
1686         https://bugs.webkit.org/show_bug.cgi?id=145759
1687
1688         Reviewed by Carlos Garcia Campos.
1689
1690         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1691         (testWebViewSave):
1692
1693 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1694
1695         [GTK] Add editor mode to MiniBrowser
1696         https://bugs.webkit.org/show_bug.cgi?id=145595
1697
1698         Reviewed by Sergio Villar Senin.
1699
1700         It loads an empty editable web view with an edit toolbar. It makes
1701         easier to test the editor, editing commands and input methods.
1702
1703         * MiniBrowser/gtk/BrowserWindow.c:
1704         (editingCommandCallback):
1705         (browserWindowSetupEditorToolbar):
1706         (browserWindowConstructed):
1707         * MiniBrowser/gtk/main.c:
1708         (createBrowserWindow):
1709
1710 2015-06-05  Zalan Bujtas  <zalan@apple.com>
1711
1712         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
1713
1714         Reviewed by Dan Bernstein.
1715
1716         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1717         (TestWebKitAPI::TEST):
1718
1719 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1720
1721         [EFL] API test has been broken since r184357
1722         https://bugs.webkit.org/show_bug.cgi?id=145635
1723
1724         Reviewed by Darin Adler.
1725
1726         r184357 suppress cmake build warning using TARGET_FILE property. However
1727         many EFL API test cases have been broken after applying it.
1728
1729         * TestWebKitAPI/CMakeLists.txt:
1730
1731 2015-06-05  Anders Carlsson  <andersca@apple.com>
1732
1733         Make the network cache directory part of WKContextConfigurationRef
1734         https://bugs.webkit.org/show_bug.cgi?id=145711
1735
1736         Reviewed by Antti Koivisto.
1737
1738         * WebKitTestRunner/TestController.cpp:
1739         (WTR::TestController::initialize):
1740
1741 2015-06-05  Anders Carlsson  <andersca@apple.com>
1742
1743         Make the application cache directory part of WKContextConfigurationRef
1744         https://bugs.webkit.org/show_bug.cgi?id=145704
1745
1746         Reviewed by Geoffrey Garen.
1747
1748         * WebKitTestRunner/TestController.cpp:
1749         (WTR::TestController::initialize):
1750
1751 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1752
1753         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
1754         https://bugs.webkit.org/show_bug.cgi?id=145680
1755
1756         Reviewed by Brent Fulgham.
1757
1758         * Scripts/webkitpy/style/checkers/cpp.py:
1759         (check_for_null):
1760         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1761         (WebKitStyleTest.test_null_false_zero):
1762
1763 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1764
1765         Make the web server more robust to timing issues..
1766
1767         Reviewed by Ryosuke Niwa.
1768
1769         Cleaned up exception handling.
1770         Test server is actually serving pages before returning.
1771         Clean up some style issues.
1772
1773         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1774         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1775         (SimpleHTTPServerDriver.__init__):
1776         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
1777         (SimpleHTTPServerDriver.baseUrl): 
1778         (SimpleHTTPServerDriver.fetchResult):
1779         (SimpleHTTPServerDriver.killServer):
1780         (SimpleHTTPServerDriver.getReturnCode):
1781
1782 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1783
1784
1785         Add errors to run-benchmark exception handling.
1786
1787         Reviewed by Ryosuke Niwa.
1788
1789         * Scripts/run-benchmark:
1790         (main):
1791         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1792         (GenericBenchmarkBuilder.prepare):
1793         (GenericBenchmarkBuilder._runCreateScript):
1794         (GenericBenchmarkBuilder._applyPatch):
1795         (GenericBenchmarkBuilder.clean):
1796         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1797         (BenchmarkRunner.__init__):
1798         (BenchmarkRunner.execute):
1799         (BenchmarkRunner):
1800         (BenchmarkRunner.cleanup):
1801         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
1802         (GenericFactory.iterateGetItem):
1803         (GenericFactory.create):
1804         * Scripts/webkitpy/benchmark_runner/utils.py:
1805         (loadModule):
1806         (loadJSONFromFile):
1807         (forceRemove):
1808
1809 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1810
1811         Streamline run-benchmark browser
1812
1813         Reviewed by Ryosuke Niwa.
1814
1815         Add Caffeinate so computer won't sleep while running.
1816         Remove calls to collect output since we were just dumping to stdout anyway.
1817         Add xpc dyld_path.
1818         Default to system safari.
1819
1820         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1821         (OSXBrowserDriver.launchProcess):
1822         (OSXBrowserDriver.terminateProcesses):
1823         (OSXBrowserDriver):
1824         (OSXBrowserDriver.launchCaffeinateForProcess):
1825         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1826         (OSXSafariDriver.launchUrl):
1827         (OSXSafariDriver.closeBrowsers):
1828
1829 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
1830
1831         Combine tiny DFAs into slightly larger ones
1832         https://bugs.webkit.org/show_bug.cgi?id=145572
1833
1834         Reviewed by Alex Christensen.
1835
1836         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1837         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
1838         (TestWebKitAPI::DFACombinerTest::SetUp):
1839         (TestWebKitAPI::combine):
1840         (TestWebKitAPI::TEST_F):
1841         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
1842         (TestWebKitAPI::countLiveNodes):
1843         (TestWebKitAPI::createNFAs):
1844         (TestWebKitAPI::buildDFAFromPatterns):
1845         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1846         (TestWebKitAPI::countLiveNodes): Deleted.
1847         (TestWebKitAPI::createNFAs): Deleted.
1848         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
1849
1850 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
1851
1852         WebKitTestRunner leaks strings in generateWhitelist()
1853         https://bugs.webkit.org/show_bug.cgi?id=145665
1854
1855         Reviewed by Myles C. Maxfield.
1856
1857         * WebKitTestRunner/mac/TestControllerMac.mm:
1858         (WTR::generateWhitelist):
1859
1860 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
1861
1862         Fix options in build-jsc for CMake builds
1863         https://bugs.webkit.org/show_bug.cgi?id=145636
1864
1865         Reviewed by Gyuyoung Kim.
1866
1867         CMake only accepts -DXXX=YYY style options.
1868         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
1869
1870         * Scripts/build-jsc:
1871
1872 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
1873
1874         Added a patch so that the colors displayed on the page could be toggled
1875         in case people need accessibility colors displayed in their browser.
1876         https://bugs.webkit.org/show_bug.cgi?id=145570
1877         <rdar://problem/20994468>
1878
1879         Added in CSS colors and toggle buttons for checkmarks in the page, so that
1880         the page could be rendered in a specific way for accessibility needs if needed.
1881
1882         Reviewed by Alexey Proskuryakov.
1883
1884         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1885         (updateHiddenPlatforms):
1886         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
1887         (toggleAccessibilityColors): Toggle colors on and off
1888         (documentReady): Needed to make changes to the initialization
1889         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1890         (a:hover):
1891         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
1892         (div.cellButton.hide, div.accessibilityButton.hide):
1893         (div.cellButton.unhide, div.accessibilityButton.unhide):
1894         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
1895         (.popover-tracking:hover):
1896         (.accessibilityButton):
1897         (div.cellButton): Deleted.
1898         (div.cellButton.hide): Deleted.
1899         (div.cellButton.unhide): Deleted.
1900         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
1901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1902         (.status-line.neutral .bubble):
1903         (.status-line.unauthorized .bubble):
1904         (.status-line.danger .bubble.pictogram):
1905         (.status-line.bad .bubble.pictogram):
1906         (.status-line.no-bubble .message):
1907         (.status-line.bad .bubble):
1908         (.status-line.good .bubble):
1909         (.status-line.good .message):
1910         (.status-line.bad .message):
1911         (body.accessibility-colors .status-line.good .bubble):
1912         (body.accessibility-colors .status-line.bad .bubble):
1913         (body.accessibility-colors .status-line.good .message):
1914         (body.accessibility-colors .status-line.bad .message):
1915         (.status-line.danger .message):
1916         (.status-line.unauthorized .message):
1917
1918 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
1919
1920         Unreviewed build fix for Dromaeo.
1921
1922         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1923         (BenchmarkResults._aggregate_results_for_test):
1924
1925 2015-06-03  Anders Carlsson  <andersca@apple.com>
1926
1927         Fix build.
1928
1929         * DumpRenderTree/mac/TestRunnerMac.mm:
1930
1931 2015-06-03  Daniel Bates  <dabates@apple.com>
1932
1933         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
1934         https://bugs.webkit.org/show_bug.cgi?id=145616
1935
1936         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
1937         of the test. Further investigation is needed.
1938
1939         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
1940         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
1941
1942 2015-06-03  Brady Eidson  <beidson@apple.com>
1943
1944         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
1945         https://bugs.webkit.org/show_bug.cgi?id=145580
1946
1947         Reviewed by Mark Lam.
1948
1949         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1950         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
1951
1952 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
1953
1954         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
1955
1956         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
1957         (TestWebKitAPI::TEST): Update the syntax.
1958
1959 2015-06-02  Mark Lam  <mark.lam@apple.com>
1960
1961         build-jsc's --cloop option is broken.
1962         https://bugs.webkit.org/show_bug.cgi?id=145516
1963
1964         Reviewed by Darin Adler.
1965
1966         * Scripts/build-jsc:
1967         - Make sure to disable the JIT when --cloop is specified.
1968           Did analogous fix for --ftljit.
1969
1970 2015-06-02  Daniel Bates  <dabates@apple.com>
1971
1972         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
1973
1974         Rubber-stamped by Alexey Proskuryakov.
1975
1976         * MiniBrowser/mac/Info.plist:
1977         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1978
1979 2015-06-01  Commit Queue  <commit-queue@webkit.org>
1980
1981         Unreviewed, rolling out r185066.
1982         https://bugs.webkit.org/show_bug.cgi?id=145543
1983
1984         it breaks the FTL JIT builds with a local checkout of llvm
1985         (Requested by pizlo on #webkit).
1986
1987         Reverted changeset:
1988
1989         "build-jsc's --cloop option is broken."
1990         https://bugs.webkit.org/show_bug.cgi?id=145516
1991         http://trac.webkit.org/changeset/185066
1992
1993 2015-06-01  Daniel Bates  <dabates@apple.com>
1994
1995         Notify client that we began editing when text field is focused
1996         https://bugs.webkit.org/show_bug.cgi?id=145439
1997         <rdar://problem/21142108>
1998
1999         Reviewed by Anders Carlsson.
2000
2001         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
2002         a text field is focused and defocused.
2003
2004         * TestWebKitAPI/CMakeLists.txt:
2005         * TestWebKitAPI/PlatformEfl.cmake:
2006         * TestWebKitAPI/PlatformGTK.cmake:
2007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2008         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
2009         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
2010         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
2011         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
2012         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
2013         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
2014         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
2015         (TestWebKitAPI::TEST_F):
2016         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
2017         (TestWebKitAPI::textFieldDidBeginEditing):
2018         (TestWebKitAPI::textFieldDidEndEditing):
2019         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
2020         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
2021         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
2022
2023 2015-06-01  Alex Christensen  <achristensen@webkit.org>
2024
2025         [Content Extensions] resource-type and load-type should be independent.
2026         https://bugs.webkit.org/show_bug.cgi?id=145528
2027         rdar://problem/21190765
2028
2029         Reviewed by Benjamin Poulain.
2030
2031         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2032         (TestWebKitAPI::TEST_F):
2033
2034 2015-06-01  Daniel Bates  <dabates@apple.com>
2035
2036         Add ATS keys to WebKitTestRunnerApp
2037         https://bugs.webkit.org/show_bug.cgi?id=145519
2038
2039         Reviewed by Alexey Proskuryakov.
2040
2041         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
2042
2043         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2044
2045 2015-06-01  Brady Eidson  <beidson@apple.com>
2046
2047         Add WKTR support for "should open external URLs".
2048         https://bugs.webkit.org/show_bug.cgi?id=145505
2049
2050         Reviewed by Darin Adler.
2051
2052         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
2053           "should open external URLs" bit set.
2054         
2055         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
2056           the policy delegate, including whether or not the bit was set.
2057         
2058         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2059         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2060         (WTR::TestRunner::queueLoad):
2061         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2062         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
2063         (WTR::TestRunner::shouldDumpPolicyCallbacks):
2064         
2065         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2066         (WTR::InjectedBundle::queueLoad):
2067         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2068
2069         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2070         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2071
2072         * WebKitTestRunner/TestInvocation.cpp:
2073         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2074
2075         * WebKitTestRunner/WorkQueueManager.cpp:
2076         (WTR::WorkQueueManager::queueLoad):
2077         * WebKitTestRunner/WorkQueueManager.h:
2078
2079 2015-06-01  Mark Lam  <mark.lam@apple.com>
2080
2081         build-jsc's --cloop option is broken.
2082         https://bugs.webkit.org/show_bug.cgi?id=145516
2083
2084         Reviewed by Darin Adler.
2085
2086         * Scripts/build-jsc:
2087         - Make sure to disable the JIT when --cloop is specified.
2088           Did analogous fix for --ftljit.
2089
2090 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
2091
2092         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
2093         https://bugs.webkit.org/show_bug.cgi?id=144959
2094
2095         Reviewed by Darin Adler.
2096
2097         * Scripts/webkitpy/style/checkers/cmake.py:
2098         (CMakeChecker.check): Use enumerate instead of xrange.
2099         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
2100         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2101         (CMakeCheckerTest.test_check): Update the expected results.
2102
2103 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
2104
2105         Fix the webkitpy scm unittests after r174051
2106         https://bugs.webkit.org/show_bug.cgi?id=145511
2107
2108         Reviewed by Darin Adler.
2109
2110         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2111         (GitTestWithMock.make_scm):
2112
2113 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
2114
2115         EWS provides misleading information for not applyable patches
2116         https://bugs.webkit.org/show_bug.cgi?id=145307
2117
2118         Reviewed by Alexey Proskuryakov.
2119
2120         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
2121
2122 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
2123
2124         Further tweak results of WebKit1.StringTruncator after r184965.
2125
2126         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2127
2128 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
2129
2130         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
2131         https://bugs.webkit.org/show_bug.cgi?id=145264
2132
2133         Reviewed by Carlos Garcia Campos.
2134
2135         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
2136
2137 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
2138
2139         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
2140
2141         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2142         (BenchmarkResults._lint_subtest_results):
2143         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
2144         (test_aggregate_nested_results):
2145         (test_lint_results):
2146         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
2147
2148 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
2149
2150         run-benchmark should print out the results
2151         https://bugs.webkit.org/show_bug.cgi?id=145398
2152
2153         Reviewed by Antti Koivisto.
2154
2155         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
2156         of the output to catch early errors.
2157
2158         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
2159         (BenchmarkResults): Added.
2160         (BenchmarkResults.__init__): Added.
2161         (BenchmarkResults.format): Added.
2162         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
2163         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
2164         Uses the sample standard deviation to compute the significant figures for the value.
2165         (BenchmarkResults._unit_from_metric): Added.
2166         (BenchmarkResults._aggregate_results): Added.
2167         (BenchmarkResults._aggregate_results_for_test): Added.
2168         (BenchmarkResults._flatten_list): Added.
2169         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
2170         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
2171         (BenchmarkResults._aggregate_values): Added.
2172         (BenchmarkResults._lint_results): Added.
2173         (BenchmarkResults._lint_subtest_results): Added.
2174         (BenchmarkResults._lint_aggregator_list): Added.
2175         (BenchmarkResults._lint_configuration): Added.
2176         (BenchmarkResults._lint_values): Added.
2177         (BenchmarkResults._is_numeric): Added.
2178         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
2179         (BenchmarkResultsTest):
2180         (BenchmarkResultsTest.test_init):
2181         (BenchmarkResultsTest.test_format):
2182         (test_format_values_with_large_error):
2183         (test_format_values_with_small_error):
2184         (test_format_values_with_time):
2185         (test_format_values_with_no_error):
2186         (test_format_values_with_small_difference):
2187         (test_aggregate_results):
2188         (test_aggregate_results_with_gropus):
2189         (test_aggregate_nested_results):
2190         (test_lint_results):
2191         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2192         (BenchmarkRunner.execute): Added a call to show_results
2193         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
2194         (BenchmarkRunner.show_results): Added.
2195
2196 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2197
2198         run_benchmark should have an option to specify the number of runs
2199         https://bugs.webkit.org/show_bug.cgi?id=145091
2200
2201         Reviewed by Antti Koivisto.
2202
2203         Added --count option.
2204
2205         * Scripts/run-benchmark:
2206         (main):
2207         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2208         (BenchmarkRunner.__init__):
2209
2210 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
2211
2212         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
2213
2214         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
2215
2216 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
2217
2218         Update results of WebKit1.StringTruncator after r184965.
2219
2220         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
2221
2222 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2223
2224         Unreviewed, updated my list of email addresses.
2225
2226         * Scripts/webkitpy/common/config/contributors.json:
2227
2228 2015-05-27  Dean Jackson  <dino@apple.com>
2229
2230         img.currentSrc problem in strict mode with old picturefill
2231         https://bugs.webkit.org/show_bug.cgi?id=144095
2232         <rdar://problem/21087013>
2233
2234         Reviewed by Simon Fraser.
2235
2236         Add a PICTURE_SIZES flag.
2237
2238         * Scripts/webkitperl/FeatureList.pm:
2239
2240 2015-05-26  Dana Burkart  <dburkart@apple.com>
2241
2242         Fixes compatibility issues with recent dashboard cleanup.
2243         https://bugs.webkit.org/show_bug.cgi?id=144814
2244
2245         Reviewed by Alexey Proskuryakov.
2246
2247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2248         (BuildbotStaticAnalyzerQueueView):
2249         (BuildbotStaticAnalyzerQueueView.prototype.update):
2250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2251         (documentReady):
2252
2253 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
2254
2255         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
2256         https://bugs.webkit.org/show_bug.cgi?id=143091
2257         rdar://problem/19330328
2258
2259         Reviewed by Darin Adler and Timothy Hatcher.
2260
2261         We have many of these, which are hard to fit on the dashboard. Added a view that
2262         collapses to a single green bubble when everything is good, and expands when there
2263         are failures (or manually).
2264
2265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
2266
2267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2268         (Buildbot.prototype.set isAuthenticated):
2269         (Buildbot.prototype._normalizeQueueInfo):
2270         (Buildbot.prototype._normalizeQueuesInfo):
2271         (Buildbot.prototype.updateQueues):
2272         Moved queue info normalization here from BuildbitQueue. The latter is a model class
2273         that shouldn't have to know about presentation, and this lets us leep the knowledge
2274         about combined queues out if it. Later, we can refactor existing code, and move out
2275         all knowledge about headings and such.
2276
2277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2278         Added the new view. It's not quite universal, and doesn't have as helpful popovers
2279         as other views, but we can extend it when/if we use it for more than JSC.
2280
2281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2282         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
2283
2284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2285         (documentReady): Added support for combined queues. These are currently always ending up
2286         in Other column, but it's easy to customize in the future if we need to.
2287
2288         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2289         (WebKitBuildbot): Added JSC queus.
2290
2291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2292         (.combined-queue-popover):
2293         (.combined-queue-popover .revision):
2294         Added styles for the combined view.
2295
2296 2015-05-26  Dan Bernstein  <mitz@apple.com>
2297
2298         Changed a file to use Unix line endings.
2299
2300         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2301
2302 2015-05-26  Dan Bernstein  <mitz@apple.com>
2303
2304         <rdar://problem/21104551> Update build settings
2305
2306         Reviewed by Anders Carlsson.
2307
2308         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2309         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2310         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2311         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2312         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2313         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2314         * asan/asan.xcconfig:
2315
2316 2015-05-26  Anders Carlsson  <andersca@apple.com>
2317
2318         Fix build.
2319
2320         * WebKitTestRunner/mac/EventSenderProxy.mm:
2321         (WTR::EventSenderProxy::mouseForceDown):
2322         (WTR::EventSenderProxy::mouseForceUp):
2323         (WTR::EventSenderProxy::mouseForceChanged):
2324
2325 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
2326
2327         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
2328         https://bugs.webkit.org/show_bug.cgi?id=145342
2329
2330         Reviewed by Darin Adler.
2331
2332         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2333         (BuildbotIteration.prototype._parseData):
2334
2335 2015-05-26  Milan Crha  <mcrha@redhat.com>
2336
2337         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
2338         https://bugs.webkit.org/show_bug.cgi?id=138134
2339
2340         Reviewed by Žan Doberšek.
2341
2342         * gtk/generate-inspector-gresource-manifest.py:
2343         (get_filenames): Command line with expanded resources exceeds 32KB, which
2344         is a limit on Windows. It's better to expand wildcards inside the python script.
2345
2346 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2347
2348         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
2349         https://bugs.webkit.org/show_bug.cgi?id=140882
2350
2351         Reviewed by Gustavo Noronha Silva.
2352
2353         Make sure unit tests write IndexedDB databases to the temporary
2354         directory, and add a test case to check that the directory is
2355         correctly created at the expected path.
2356
2357         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2358         (testWebContextConfiguration):
2359         (serverCallback):
2360         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2361         (Test::Test):
2362
2363 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2364
2365         [GTK] Enable IndexedDB
2366         https://bugs.webkit.org/show_bug.cgi?id=98932
2367
2368         Reviewed by Žan Doberšek.
2369
2370         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
2371
2372 2015-05-24  Sam Weinig  <sam@webkit.org>
2373
2374         Crash when using a removed ScriptMessageHandler
2375         <rdar://problem/20888499>
2376         https://bugs.webkit.org/show_bug.cgi?id=145359
2377
2378         Reviewed by Dan Bernstein.
2379
2380         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2381         Add tests for removing script message handlers.
2382
2383 2015-05-23  Dan Bernstein  <mitz@apple.com>
2384
2385         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
2386         https://bugs.webkit.org/show_bug.cgi?id=145345
2387
2388         Reviewed by Sam Weinig.
2389
2390         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2391         * LayoutTestRelay/Configurations/Base.xcconfig:
2392         * TestWebKitAPI/Configurations/Base.xcconfig:
2393         * WebKitTestRunner/Configurations/Base.xcconfig:
2394
2395 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2396
2397         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
2398         https://bugs.webkit.org/show_bug.cgi?id=144848
2399
2400         Reviewed by Darin Adler.
2401
2402         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
2403
2404         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2405
2406 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2407
2408         Fix one more merge error in static analyzer support.
2409
2410         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2411         (BuildbotStaticAnalyzerQueueView):
2412
2413 2015-05-22  Dana Burkart  <dburkart@apple.com>
2414
2415         Fix internal dashboard breakage from recent commit.
2416         https://bugs.webkit.org/show_bug.cgi?id=144814
2417
2418         Unreviewed build fix.
2419
2420         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2421         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2422         (BuildbotStaticAnalyzerQueueView.prototype.update):
2423
2424 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2425
2426         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2427         https://bugs.webkit.org/show_bug.cgi?id=130463
2428         rdar://problem/20461342
2429
2430         Reviewed by Tim Horton.
2431
2432         This was more of a timing related flakiness than an actual OS version specific bug,
2433         we weren't getting window visibility notifications.
2434         
2435         I will look into adding this function call to DumpRenderTree separately, layout tests
2436         might actually rely on the broken behavior.
2437
2438         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2439         (TestWebKitAPI::TEST_F):
2440         * TestWebKitAPI/mac/mainMac.mm:
2441         (main):
2442
2443 2015-05-22  Dana Burkart  <dburkart@apple.com>
2444
2445         Add missing file from r184804 (mis-applied diff).
2446         https://bugs.webkit.org/show_bug.cgi?id=144814
2447
2448         Reviewed by Alexey Proskuryakov.
2449
2450         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
2451         (BuildbotStaticAnalyzerQueueView):
2452         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2453         (BuildbotStaticAnalyzerQueueView.prototype.update):
2454
2455 2015-05-22  Dana Burkart  <dburkart@apple.com>
2456
2457         Add support to the botwatchers dashboard for a static analyzer bot.
2458         https://bugs.webkit.org/show_bug.cgi?id=144814
2459
2460         Reviewed by Alexey Proskuryakov.
2461
2462         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2463         scan-build should be considered a productive step.
2464
2465         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2466         (BuildbotQueue):
2467         Adds support for the staticAnalyzer property
2468
2469         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2470         (BuildbotTestResults.prototype._parseResults):
2471         Get bug count from the scan-build step output
2472
2473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2474         (documentReady):
2475         Rename the performance column 'Other', and merge the current 'Other' column with it.
2476
2477         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2478         (WebKitBuildbot):
2479         Now that performance bots are part of the 'Other' column, give them better headings.
2480
2481 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2482
2483         Turn on autosaving of toolbar configuration in MiniBrowser
2484
2485         Rubber-stamped by Dan Bernstein.
2486
2487         * MiniBrowser/mac/BrowserWindow.xib:
2488
2489 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2490
2491         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
2492         https://bugs.webkit.org/show_bug.cgi?id=145297
2493
2494         Reviewed by Tim Horton.
2495
2496         This is a refactoring to simplify code, and to make it more logical.
2497
2498         It is up to the view to decide how to present the queues, and whether to split
2499         them into debug and release, or in some different way.
2500
2501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2502         (BuildbotBuilderQueueView.filterQueues):
2503         (BuildbotBuilderQueueView):
2504         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2505         (BuildbotLeaksQueueView):
2506         (BuildbotLeaksQueueView.prototype.update):
2507         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2508         (BuildbotPerformanceQueueView):
2509         (BuildbotPerformanceQueueView.prototype.update):
2510         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2511         (BuildbotQueueView):
2512         (BuildbotQueueView.prototype._updateQueues):
2513         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2514         (BuildbotTesterQueueView):
2515         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2516         (documentReady):
2517
2518 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2519
2520         Remove action menu support
2521         https://bugs.webkit.org/show_bug.cgi?id=145305
2522         <rdar://problem/21070771>
2523
2524         Reviewed by Anders Carlsson.
2525
2526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2527         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
2528         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
2529         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
2530         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
2531         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
2532         Remove the tests.
2533
2534 2015-05-22  Dan Bernstein  <mitz@apple.com>
2535
2536         Removed the Use Shrink To Fit button from the toolbar’s default set.
2537
2538         Rubber-stamped by Tim Horton.
2539
2540         * MiniBrowser/mac/BrowserWindow.xib:
2541
2542 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
2543
2544         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
2545         https://bugs.webkit.org/show_bug.cgi?id=128420
2546
2547         Reviewed by Chris Fleizach.
2548
2549         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2550         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
2551
2552 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
2553
2554         [EFL] Bump libsoup version to 2.50.0
2555         https://bugs.webkit.org/show_bug.cgi?id=145127
2556
2557         Reviewed by Gyuyoung Kim.
2558
2559         * efl/jhbuild.modules:
2560         * efl/patches/soup-clang-warning-fix1.patch: Removed.
2561         * efl/patches/soup-clang-warning-fix2.patch: Removed.
2562
2563 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
2564
2565         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
2566         https://bugs.webkit.org/show_bug.cgi?id=145117
2567
2568         Reviewed by Csaba Osztrogonác.
2569
2570         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
2571         Tools/TestWebKitAPI/Tests/WTF/glib/.
2572
2573         * TestWebKitAPI/PlatformGTK.cmake:
2574         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
2575         (TestWebKitAPI::TEST):
2576
2577 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
2578
2579         [EFL] fix efreet error
2580         https://bugs.webkit.org/show_bug.cgi?id=143670
2581
2582         Reviewed by Gyuyoung Kim.
2583
2584         Fix efreet error by using external variable efreet_cache_update.
2585         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
2586         efreet error for efreet_cache does not occur.
2587
2588         * MiniBrowser/efl/main.c:
2589         (elm_main):
2590
2591 2015-05-20  Michael Saboff  <msaboff@apple.com>
2592
2593         Add option to run_jsc_stress_tests to disable JIT testing
2594         https://bugs.webkit.org/show_bug.cgi?id=145233
2595
2596         Reviewed by Mark Lam.
2597
2598         Added --no-jit option.
2599
2600         * Scripts/run-jsc-stress-tests:
2601
2602 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2603
2604         Use correct String for StringView in WTF API tests
2605         https://bugs.webkit.org/show_bug.cgi?id=145226
2606         rdar://problem/20361786
2607
2608         Reviewed by Benjamin Poulain.
2609
2610         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2611         (TestWebKitAPI::TEST):
2612         Use patternHolder for pattern.
2613
2614 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2615
2616         [Content Extensions] Relax restrictions on triggers that match everything.
2617         https://bugs.webkit.org/show_bug.cgi?id=145069
2618
2619         Reviewed by Benjamin Poulain.
2620
2621         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2622         (TestWebKitAPI::TEST_F):
2623         Update and add tests for new possibilities with .*
2624
2625 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
2626
2627         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
2628         https://bugs.webkit.org/show_bug.cgi?id=144992
2629
2630         Reviewed by Gyuyoung Kim.
2631
2632         * MiniBrowser/efl/main.c:
2633         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
2634         (on_key_down):
2635         (on_fullscreen_enter):
2636         (on_fullscreen_exit):
2637         (window_create):
2638
2639 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2640
2641         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
2642         https://bugs.webkit.org/show_bug.cgi?id=145109
2643
2644         Reviewed by Darin Adler.
2645
2646         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2647         (TestWebKitAPI::TEST):
2648
2649 2015-05-19  Anders Carlsson  <andersca@apple.com>
2650
2651         Add alternate menu items for performing operations on the default data store
2652         https://bugs.webkit.org/show_bug.cgi?id=145184
2653
2654         Reviewed by Sam Weinig.
2655
2656         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
2657         associated with a data store.
2658
2659         * MiniBrowser/mac/AppDelegate.m:
2660         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
2661         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
2662         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
2663         * MiniBrowser/mac/MainMenu.xib:
2664
2665 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
2666
2667         Fix tautological-compare warning in AtomicString.cpp
2668         https://bugs.webkit.org/show_bug.cgi?id=145120
2669
2670         Reviewed by Alexey Proskuryakov.
2671
2672         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2673         (TestWebKitAPI::TEST): Removed always true assert.
2674
2675 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
2676
2677         [EFL] Fix unsequenced warning in MiniBrowser's main.c
2678         https://bugs.webkit.org/show_bug.cgi?id=145123
2679
2680         Reviewed by Gyuyoung Kim.
2681
2682         * MiniBrowser/efl/main.c:
2683         (on_key_down):
2684
2685 2015-05-18  Daniel Bates  <dabates@apple.com>
2686
2687         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
2688         when staged non-empty file for commit
2689         https://bugs.webkit.org/show_bug.cgi?id=145082
2690
2691         Reviewed by Darin Adler.
2692
2693         Fixes two issues when running prepare-ChangeLog:
2694             1. The function above a deleted function is reported as changed.
2695             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
2696             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
2697             included in this patch).
2698
2699         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
2700         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
2701         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
2702         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
2703         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
2704         VCSUtil::parseChunkRange() has existing test coverage.
2705
2706         * Scripts/prepare-ChangeLog:
2707         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
2708         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
2709         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
2710         examine files that only have deletions. Currently this works as a side effect of the behavior of
2711         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
2712         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
2713         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
2714         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
2715         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2716         We return (-1, -1) when the change represents a deletion.
2717         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
2718         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2719         We return (-1, -1) when the change represents an addition.
2720         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
2721         unit tests.
2722
2723 2015-05-18  Anders Carlsson  <andersca@apple.com>
2724
2725         Add ATS keys to MiniBrowser
2726         https://bugs.webkit.org/show_bug.cgi?id=145141
2727
2728         Reviewed by Sam Weinig.
2729
2730         * MiniBrowser/mac/Info.plist:
2731
2732 2015-05-17  David Kilzer  <ddkilzer@apple.com>
2733
2734         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
2735         <http://webkit.org/b/145100>
2736
2737         Reviewed by Darin Adler.
2738
2739         * Scripts/bisect-builds:
2740         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
2741         - Switch to using PROMPT_RESPONSE_* constants when testing the
2742           value of $didReproduceBug.
2743         - Add do { } while loops to implement 'retry' mode.
2744         (promptForTest):
2745         - Switch to returning PROMPT_RESPONSE_* constants.
2746         - Add support for 'retry' response.
2747
2748 2015-05-16  Tanay C  <tanay.c@samsung.com>
2749
2750         [EFL][WK2] Minibrowser : Add search icon to search bar
2751         https://bugs.webkit.org/show_bug.cgi?id=139773
2752
2753         Reviewed by Gyuyoung Kim.
2754
2755         * MiniBrowser/efl/main.c: 
2756         (search_icon_show): Added.
2757         (search_box_show): Modified.
2758
2759 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2760
2761         run_benchmark should have an option to specify the number of runs
2762         https://bugs.webkit.org/show_bug.cgi?id=145091
2763
2764         Reviewed by Stephanie Lewis.
2765
2766         Added --count option.
2767
2768         * Scripts/run-benchmark:
2769         (main):
2770         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2771         (BenchmarkRunner.__init__):
2772
2773 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
2774
2775         Temporarily disable failing API test.
2776
2777         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2778         (TestWebKitAPI::TEST):
2779
2780 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
2781
2782         User interruption while running of run-webkit-tests should also generate results.html
2783         https://bugs.webkit.org/show_bug.cgi?id=122154
2784
2785         Reviewed by Csaba Osztrogonác.
2786
2787         Generation of results.html on execution of run-webkit-tests happens only
2788         on completion of entire layout tests run. It should be created even when
2789         the execution has been interrupted - either by user (by pressing Ctrl+C)
2790         or because of other interruptions (like exit-after-n-failures option).
2791
2792         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2793         (LayoutTestRunner.run_tests):
2794         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2795         (Manager.run):
2796         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2797         (TestRunResults.__init__):
2798         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2799         (main):
2800         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2801         (RunTest.test_keyboard_interrupt):
2802         (MainTest.test_exception_handling):
2803
2804 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
2805
2806         [buildbot] Fix the URL of the performance bots
2807         https://bugs.webkit.org/show_bug.cgi?id=145043
2808
2809         Reviewed by Ryosuke Niwa.
2810
2811         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2812
2813 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
2814
2815         Add a layout mode that scales down the view to try to fit the document
2816         https://bugs.webkit.org/show_bug.cgi?id=145022
2817         <rdar://problem/19790341>
2818
2819         Reviewed by Dean Jackson.
2820
2821         * MiniBrowser/mac/BrowserWindow.xib:
2822         * MiniBrowser/mac/BrowserWindowController.h:
2823         * MiniBrowser/mac/WK2BrowserWindowController.m:
2824         (-[WK2BrowserWindowController toggleShrinkToFit:]):
2825         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
2826         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
2827
2828 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
2829
2830         [CMake] Don't read the LOCATION property of targets
2831         https://bugs.webkit.org/show_bug.cgi?id=145018
2832
2833         Reviewed by Martin Robinson.
2834
2835         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
2836         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
2837         be the same at configure-time as it is at generate-time.
2838
2839         * TestWebKitAPI/CMakeLists.txt:
2840
2841 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
2842
2843         Add String literal overloads to equalIgnoringASCIICase()
2844         https://bugs.webkit.org/show_bug.cgi?id=145008
2845
2846         Reviewed by Benjamin Poulain.
2847
2848         Test changes to WTF.
2849
2850         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2851         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
2852         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2853         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2854         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
2855         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2856
2857 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2858
2859         SharedBuffer::createWithContentsOfFile should use map file routines
2860         https://bugs.webkit.org/show_bug.cgi?id=144192
2861
2862         Reviewed by Darin Adler.
2863
2864         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
2865
2866         * TestWebKitAPI/PlatformGTK.cmake:
2867         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2868         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
2869         (TestWebKitAPI::FileSystemTest::tempFilePath):
2870         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
2871         (TestWebKitAPI::TEST_F):
2872         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
2873         (TestWebKitAPI::SharedBufferTest::tempFilePath):
2874         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
2875         (TestWebKitAPI::TEST_F):
2876
2877 2015-05-13  Alex Christensen  <achristensen@webkit.org>
2878
2879         [Content Extensions] Test interactions between multiple extensions and multiple domains.
2880         https://bugs.webkit.org/show_bug.cgi?id=144967
2881
2882         Reviewed by Benjamin Poulain.
2883
2884         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2885         Xcode wanted to fix an alphabetization issue.
2886         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2887         (TestWebKitAPI::TEST_F):
2888         Test interactions that worked but were not explicitly tested before.
2889
2890 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2891
2892         Unreviewed build fix.
2893
2894         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
2895
2896         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
2897
2898 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2899
2900         Fix the previous commit, which made both bubbles green.
2901
2902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2903         (.status-line.good .bubble):
2904         (.status-line.bad .bubble):
2905         (.status-line.good .message):
2906
2907 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2908
2909         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
2910         https://bugs.webkit.org/show_bug.cgi?id=144929
2911
2912         Reviewed by Eric Carlson.
2913
2914         Tweaked colors as I see fit.
2915
2916         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2917         (.status-line.good .bubble):
2918         (.status-line.bad .bubble):
2919
2920 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
2921
2922         [Mac] Share cookie storage between UI process and secondary processes
2923         https://bugs.webkit.org/show_bug.cgi?id=144820
2924         rdar://problem/20572830
2925
2926         Reviewed by Darin Adler.
2927
2928         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2929         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
2930         for testing.
2931
2932 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
2933
2934         Fix internal build configuration issues
2935         https://bugs.webkit.org/show_bug.cgi?id=144762
2936
2937         Reviewed by David Kilzer.
2938
2939         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
2940
2941         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2942         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2943         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2944         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2945         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
2946         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2947         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
2948         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2949
2950 2015-05-12  David Kilzer  <ddkilzer@apple.com>
2951
2952         Switch to launching iOS Simulator using bundle ID
2953         <rdar://problem/20916096>
2954
2955         This is required to fix the layout tests on internal bots.
2956
2957         * Scripts/webkitdirs.pm:
2958         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
2959         Simulator.  Add FIXME.
2960         (quitIOSSimulator): Add FIXME.
2961         * Scripts/webkitpy/port/ios.py:
2962         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
2963         launch iOS Simulator.  Add FIXME.
2964         (IOSSimulatorPort.check_sys_deps): Add FIXME.
2965
2966 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
2967
2968         Fix run-javascriptcore-tests step on the WinCairo bot
2969         https://bugs.webkit.org/show_bug.cgi?id=144866
2970
2971         Reviewed by Csaba Osztrogonác.
2972
2973         Catch exception when failing to create soft link, so we can fall back to copy.
2974
2975         * Scripts/run-jsc-stress-tests:
2976
2977 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
2978
2979         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
2980         https://bugs.webkit.org/show_bug.cgi?id=116971
2981
2982         Reviewed by Chris Fleizach.
2983
2984         Implement rowAtIndex for ATK.
2985
2986         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2987         (WTR::AccessibilityUIElement::rowAtIndex):
2988
2989 2015-05-11  Dan Bernstein  <mitz@apple.com>
2990
2991         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
2992
2993         Reviewed by Alexey Proskuryakov.
2994
2995         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2996         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
2997         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
2998         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
2999
3000 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
3001
3002         Fix internal build configuration issues
3003         https://bugs.webkit.org/show_bug.cgi?id=144762
3004
3005         Reviewed by Darin Adler.
3006
3007         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
3008
3009         * TestWebKitAPI/Configurations/Base.xcconfig:
3010         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3011         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3012         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3013         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3014         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3015         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3016
3017 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
3018
3019         [Win] Move Windows build target to Windows 7 (or newer)
3020         https://bugs.webkit.org/show_bug.cgi?id=144890
3021         <rdar://problem/20707307>
3022
3023         Reviewed by Anders Carlsson.
3024
3025         Update linked SDK and minimal Windows level to be compatible with
3026         Windows 7 or newer.
3027
3028         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3029         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3030         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3031         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3032         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3033         * DumpRenderTree/config.h:
3034         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3035         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3036         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3037         * WinLauncher/stdafx.h:
3038
3039 2015-05-11  Commit Queue  <commit-queue@webkit.org>
3040
3041         Unreviewed, rolling out r184119.
3042         https://bugs.webkit.org/show_bug.cgi?id=144888
3043
3044         broke JSC tests on Apple Windows bots (Requested by kling on
3045         #webkit).
3046
3047         Reverted changeset:
3048
3049         "Fix run-javascriptcore-tests step on the WinCairo bot"
3050         https://bugs.webkit.org/show_bug.cgi?id=144866
3051         http://trac.webkit.org/changeset/184119
3052
3053 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3054
3055         run-benchmark should support Dromaeo
3056         https://bugs.webkit.org/show_bug.cgi?id=144849
3057
3058         Reviewed by Chris Dumez.
3059
3060         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
3061         they can take as much as 15 minutes to run each.
3062
3063         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
3064         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
3065         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
3066         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
3067
3068 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3069
3070         Build fix. jetstream has a local copy, not remote archive.
3071
3072         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
3073
3074 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3075
3076         run-benchmark should support SunSpider, Kraken and Octane
3077         https://bugs.webkit.org/show_bug.cgi?id=144840
3078
3079         Reviewed by Darin Adler.
3080
3081         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
3082         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
3083         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
3084         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
3085
3086         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
3087         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
3088
3089         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
3090         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
3091
3092         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
3093         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
3094         now has the ability to run an arbitrary "create script".
3095
3096         * Scripts/run-benchmark:
3097         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
3098         This also overrides the remote archive URL specified in the plan.
3099
3100         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
3101
3102         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
3103         JetStreamBenchmarkBuilder.
3104
3105         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
3106         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
3107         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
3108         _runCreateScript and _applyPatch to clean after themselves.
3109         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
3110         JetStream, SunSpider, Kraken all use this feature.
3111         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
3112         the leaf directory name since the latter is not available when a remote ZIP file is used.
3113         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
3114         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
3115         the benchmark name in the patches.
3116
3117         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
3118
3119         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3120         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
3121         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
3122         the browser opens by planName as the plan file no longer contains that.
3123
3124         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
3125         the top directory of JetStream instead of its parent.
3126         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
3127         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
3128         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
3129         the top directory of JetStream instead of its parent.
3130         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
3131         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
3132         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
3133         done in JetStream.patch.
3134         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
3135         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
3136         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
3137         path from the top directory of JetStream as done in JetStream.patch.
3138         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
3139
3140 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
3141
3142         Fix run-javascriptcore-tests step on the WinCairo bot
3143         https://bugs.webkit.org/show_bug.cgi?id=144866
3144
3145         Reviewed by Darin Adler.
3146
3147         * Scripts/run-jsc-stress-tests:
3148
3149 2015-05-11  Alex Christensen  <achristensen@webkit.org>
3150
3151         [Content Extensions] Support domain-specific rules and exceptions.
3152         https://bugs.webkit.org/show_bug.cgi?id=144833
3153
3154         Reviewed by Darin Adler.
3155
3156         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3157         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3158         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
3159         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
3160         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
3161         (TestWebKitAPI::mainDocumentRequest):
3162         (TestWebKitAPI::subResourceRequest):
3163         (TestWebKitAPI::TEST_F):
3164         (TestWebKitAPI::checkCompilerError):
3165         Added tests for parsing and functionality of if-domain and unless-domain.
3166
3167 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3168
3169         run-benchmark should support Chrome Canary and Firefox Nightly
3170         https://bugs.webkit.org/show_bug.cgi?id=144850
3171
3172         Reviewed by Darin Adler.
3173
3174         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
3175
3176         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
3177
3178         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
3179         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
3180         (OSXBrowserDriver):
3181         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
3182         (OSXBrowserDriver.closeBrowsers): Ditto.
3183         (OSXBrowserDriver.launchProcess): Ditto.
3184         (OSXBrowserDriver.terminateProcesses): Ditto.
3185         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3186         (OSXChromeDriver): Removed the unused self.chromePreferences.
3187         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
3188         (OSXChromeDriver.closeBrowsers): Ditto.
3189         (OSXChromeDriver.launchUrl):
3190         (OSXChromeCanaryDriver): Added.
3191         (OSXChromeCanaryDriver.launchUrl):
3192         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
3193         (OSXFirefoxDriver): Added.
3194         (OSXFirefoxDriver.launchUrl):
3195         (OSXFirefoxNightlyDriver): Added.
3196         (OSXFirefoxNightlyDriver.launchUrl):
3197         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3198         (OSXSafariDriver):
3199         (OSXSafariDriver.closeBrowsers):
3200
3201 2015-05-11  Tim Horton  <timothy_horton@apple.com>
3202
3203         Page overlay action context override should indicate the source of the request
3204         https://bugs.webkit.org/show_bug.cgi?id=144832
3205         <rdar://problem/20562594>
3206
3207         Reviewed by Darin Adler.
3208
3209         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
3210         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
3211
3212 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
3213
3214         [GTK] fast/events/page-visibility-transition-test.html is timing out
3215         https://bugs.webkit.org/show_bug.cgi?id=114789
3216
3217         Reviewed by Darin Adler.
3218
3219         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3220         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
3221         requests visibility changes.
3222
3223 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
3224
3225         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
3226         https://bugs.webkit.org/show_bug.cgi?id=144798
3227
3228         Reviewed by Darin Adler.
3229
3230         * efl/install-dependencies:
3231
3232 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
3233
3234         Make arguments of run-benchmark more user friendly
3235         https://bugs.webkit.org/show_bug.cgi?id=144835
3236
3237         Reviewed by Darin Adler.
3238
3239         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
3240         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
3241         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
3242         default values from --platform and --browser as they are required arguments.
3243
3244         * Scripts/run-benchmark:
3245         (main): Made --build-directory optional, and removed default values from --platform and --browser.
3246         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
3247         are not dynamically obtained via BrowserDriverFactory.
3248         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3249         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
3250         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
3251         run any benchmark in that case.
3252         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
3253         the specified file isn't a valid relative or an absolute path.
3254         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3255         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
3256         and browsers.
3257         (BrowserDriverFactory.available_browsers): Ditto.
3258         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3259         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
3260         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
3261         browserBuildPath was None.
3262         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3263         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
3264         so that we can use locally built WebKit to launch Safari.
3265
3266 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
3267
3268         Remove the PICTURE_SIZES build flag
3269         https://bugs.webkit.org/show_bug.cgi?id=144679
3270
3271         Reviewed by Benjamin Poulain.
3272
3273         Removed the PICTURE_SIZES build time flag.
3274
3275         * Scripts/webkitperl/FeatureList.pm:
3276
3277 2015-05-09  David Kilzer  <ddkilzer@apple.com>
3278
3279         Layout tests broke due to unexpected simctl output
3280
3281         * Scripts/webkitpy/xcode/simulator.py:
3282         (Simulator._parse_devices): Handle new Device Pairs header.
3283         * Scripts/webkitpy/xcode/simulator_unittest.py:
3284         (test_device_pairs): Add unit test for Device Pairs header.
3285
3286 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3287
3288         Remove convenience constructors for TextRun
3289         https://bugs.webkit.org/show_bug.cgi?id=144752
3290
3291         Reviewed by Anders Carlsson.
3292
3293         Test the StringView which takes a StringImpl*.
3294
3295         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3296         (StringView8Bit): Testing is8Bit() on StringView
3297
3298 2015-05-07  Sam Weinig  <sam@webkit.org>
3299
3300         [Content Extensions] Add simple tester that takes an extension and compiles it
3301         https://bugs.webkit.org/show_bug.cgi?id=144781
3302
3303         Reviewed by Dan Bates.
3304
3305         * ContentExtensionTester: Added.
3306         * ContentExtensionTester/Configurations: Added.
3307         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
3308         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
3309         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
3310         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
3311         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
3312         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
3313         * ContentExtensionTester/main.m: Added.
3314         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
3315
3316 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
3317
3318         Build fix.
3319
3320         Reviewed by Dan Bernstein.
3321
3322         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3323         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3324         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
3325         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3326         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3327         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3328         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
3329         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3330
3331 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
3332
3333         [GTK] Some tests fail because they do not assume the popup menu captures click events
3334         https://bugs.webkit.org/show_bug.cgi?id=40601
3335
3336         Reviewed by Carlos Garcia Campos.
3337
3338         Popdown all attached menus when moving between tests and between each new
3339         event sent to the WebView. This prevents context and popup menus from eating
3340         events.
3341
3342         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
3343         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
3344         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3345         (WTR::dispatchEvent): Popdown all menus between dispatching events.
3346         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
3347         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
3348         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3349         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
3350         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3351         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
3352         longer in the platform-independent file.
3353         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
3354
3355 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
3356
3357         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3358         https://bugs.webkit.org/show_bug.cgi?id=144746
3359
3360         Reviewed by Carlos Garcia Campos.
3361
3362         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3363
3364         * MiniBrowser/gtk/main.c:
3365         (main):
3366
3367 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3368
3369         Unreviewed, rolling out r183996.
3370         https://bugs.webkit.org/show_bug.cgi?id=144806
3371
3372         ASan detected use-after free (Requested by ap on #webkit).
3373
3374         Reverted changeset:
3375
3376         "Remove convenience constructors for TextRun"
3377         https://bugs.webkit.org/show_bug.cgi?id=144752
3378         http://trac.webkit.org/changeset/183996
3379
3380 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3381
3382         Remove convenience constructors for TextRun
3383         https://bugs.webkit.org/show_bug.cgi?id=144752
3384
3385         Reviewed by Anders Carlsson.
3386
3387         Test the StringView which takes a StringImpl*.
3388
3389         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3390         (StringView8Bit): Testing is8Bit() on StringView
3391
3392 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3393
3394         [GTK] WTR doesn't correctly handle the Escape key
3395         https://bugs.webkit.org/show_bug.cgi?id=144788
3396
3397         Reviewed by Martin Robinson.
3398
3399         Correctly handle 0x001B character code in GTK+ event sender to be
3400         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
3401         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
3402         to dismiss popup menus.
3403
3404         Fixes editing/selection/5354455-1.html.
3405
3406         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3407         (WTR::getGDKKeySymForKeyRef):
3408
3409 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3410
3411         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
3412         https://bugs.webkit.org/show_bug.cgi?id=144748
3413
3414         Reviewed by Sergio Villar Senin.
3415
3416         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3417         (testWebKitSettings): Check the new setting is correctly
3418         initialized and updated.
3419         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3420         (testWebContextSecurityFileXHR): Check XHR to local files is
3421         allowed from file URLs after changing the setting.
3422         (beforeAll): Add new test.
3423
3424 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3425
3426         Unreviewed, rolling out r183945.
3427         https://bugs.webkit.org/show_bug.cgi?id=144789
3428
3429         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
3430
3431         Reverted changeset:
3432
3433         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
3434         https://bugs.webkit.org/show_bug.cgi?id=144746
3435         http://trac.webkit.org/changeset/183945
3436
3437 2015-05-07  Anders Carlsson  <andersca@apple.com>
3438
3439         Build fixes.
3440
3441         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
3442         (TestWebKitAPI::TEST):
3443         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
3444         (TestWebKitAPI::TEST):
3445         Add casts.
3446
3447 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
3448
3449         GC has trouble with pathologically large array allocations
3450         https://bugs.webkit.org/show_bug.cgi?id=144609
3451
3452         Reviewed by Geoffrey Garen.
3453         
3454         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
3455         and it's a frequently requested feature.
3456         
3457         Also add the ability to run a test pretending that your system has a particular RAM size.
3458         This is useful for GC tests, and the new GC test that I added uses this.
3459
3460         * Scripts/run-javascriptcore-tests:
3461         (runJSCStressTests):
3462         * Scripts/run-jsc-stress-tests:
3463
3464 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
3465
3466         [EFL] Bump EFL version to 1.14.0
3467         https://bugs.webkit.org/show_bug.cgi?id=144743
3468
3469         Reviewed by Darin Adler.
3470
3471         Bump EFL and elementary version to 1.14.0 and removed
3472         md5sum, because it isn't used at all if hash is present.
3473
3474         * efl/jhbuild.modules:
3475
3476 2015-05-07  Saam Barati  <saambarati1@gmail.com>
3477
3478         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
3479         https://bugs.webkit.org/show_bug.cgi?id=144753
3480
3481         Reviewed by Mark Lam.
3482
3483         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3484
3485 2015-05-07  Beth Dakin  <bdakin@apple.com>
3486
3487         New force-related DOM events should fire in WK1 views
3488         https://bugs.webkit.org/show_bug.cgi?id=144663
3489         -and corresponding-
3490         rdar://problem/20281886
3491
3492         Reviewed by Sam Weinig.
3493
3494         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
3495         now. Just send nil. 
3496         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3497         (TestWebKitAPI::buildAndPerformTest):
3498
3499 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3500
3501         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3502         https://bugs.webkit.org/show_bug.cgi?id=144746
3503
3504         Reviewed by Martin Robinson.
3505
3506         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3507
3508         * MiniBrowser/gtk/main.c:
3509         (main):
3510
3511 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3512
3513         Revert "Introducing the Platform Abstraction Layer (PAL)"
3514         https://bugs.webkit.org/show_bug.cgi?id=144751
3515
3516         Unreviewed.
3517
3518         PAL should be a new target inside WebCore, rather than a top-level folder.
3519
3520         * Scripts/build-webkit: Add it to build-webkit.
3521
3522 2015-05-07  Ada Chan  <adachan@apple.com>
3523
3524         Add a test for WKPageCopySessionState() with filtering.
3525         https://bugs.webkit.org/show_bug.cgi?id=144666
3526
3527         Reviewed by Darin Adler.
3528
3529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3530         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
3531         (TestWebKitAPI::didFinishLoadForFrame):
3532         (TestWebKitAPI::setPageLoaderClient):
3533         (TestWebKitAPI::filterFirstItemCallback):
3534         (TestWebKitAPI::filterAllItemsCallback):
3535         (TestWebKitAPI::createSessionStates):
3536         (TestWebKitAPI::TEST):
3537
3538 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3539
3540         iOS build fix attempt
3541
3542         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
3543
3544         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3545
3546 2015-05-06  Matt Baker  <mattbaker@apple.com>
3547
3548         Unreviewed, updated my list of email addresses.
3549
3550         * Scripts/webkitpy/common/config/contributors.json:
3551
3552 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3553
3554         Do not link tools to WebKit2.framework
3555         https://bugs.webkit.org/show_bug.cgi?id=144699
3556
3557         Unreviewed build fix.
3558
3559         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3560         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3561         These linked to WebKit2 in two ways, eliminating the other one.
3562
3563 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3564
3565         Introducing the Platform Abstraction Layer (PAL)
3566         https://bugs.webkit.org/show_bug.cgi?id=143358
3567
3568         Reviewed by Simon Fraser.
3569
3570         * Scripts/build-webkit: Add it to build-webkit.
3571
3572 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3573
3574         Fix api tests after r183877.
3575
3576         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3577         (TestWebKitAPI::TEST_F):
3578         Generate all DFAs before compiling them.
3579
3580 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3581
3582         Do not link tools to WebKit2.framework
3583         https://bugs.webkit.org/show_bug.cgi?id=144699
3584
3585         Reviewed by Tim Horton.
3586
3587         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3589         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3590
3591 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3592
3593         [Content Extensions] Test splitting NFAs by max NFA size.
3594         https://bugs.webkit.org/show_bug.cgi?id=144659
3595
3596         Reviewed by Darin Adler.
3597
3598         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3599         (TestWebKitAPI::createNFAs):
3600         (TestWebKitAPI::TEST_F):
3601         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3602         (TestWebKitAPI::createNFAs):
3603
3604 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
3605
3606         Remove the remaining vestiges of SVG feature define
3607         https://bugs.webkit.org/show_bug.cgi?id=144655
3608
3609         Reviewed by Alexey Proskuryakov.
3610
3611         * Scripts/webkitperl/FeatureList.pm:
3612
3613 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
3614
3615         Add a layout mode for computing fixed layout size from a minimum size
3616         https://bugs.webkit.org/show_bug.cgi?id=144610
3617         <rdar://problem/19790341>
3618
3619         Reviewed by Simon Fraser.
3620
3621         * MiniBrowser/mac/BrowserWindow.xib:
3622         * MiniBrowser/mac/BrowserWindowController.h:
3623         * MiniBrowser/mac/WK1BrowserWindowController.m:
3624         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
3625         * MiniBrowser/mac/WK2BrowserWindowController.m:
3626         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
3627         Add a optional toolbar item to toggle a minimum view size of 1024x0.
3628
3629 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3630
3631         [Content Extensions] Release input NSString when finished copying it.
3632         https://bugs.webkit.org/show_bug.cgi?id=144642
3633
3634         Reviewed by Brian Weinstein.
3635
3636         * WebKitTestRunner/mac/TestControllerMac.mm:
3637         (WTR::TestController::platformConfigureViewForTest):
3638         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
3639
3640 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
3641
3642         Unreviewed test fix after r183798.
3643
3644         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3645         (convertToDRTLabel): Mimic behavior of Mac accessibility output
3646         so we can share results.
3647
3648 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3649
3650         [Content Extensions] Use less memory to store the json input.
3651         https://bugs.webkit.org/show_bug.cgi?id=144604
3652
3653         Reviewed by Benjamin Poulain.
3654
3655         * MiniBrowser/mac/ExtensionManagerWindowController.m:
3656         (-[ExtensionManagerWindowController add:]):
3657         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3658         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3659         * WebKitTestRunner/mac/TestControllerMac.mm:
3660         (WTR::TestController::platformConfigureViewForTest):
3661
3662 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3663
3664         Unreviewed. Make myself a WebKit reviewer.
3665
3666         * Scripts/webkitpy/common/config/contributors.json:
3667
3668 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
3669
3670         [GTK] r183783 breaks build
3671         https://bugs.webkit.org/show_bug.cgi?id=144632
3672
3673         Reviewed by Martin Robinson.
3674
3675         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
3676
3677         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3678         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3679
3680 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3681
3682         [Content Extensions] Combine NFAs properly and free memory as we compile.
3683         https://bugs.webkit.org/show_bug.cgi?id=144485
3684
3685         Reviewed by Benjamin Poulain.
3686
3687         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3688         (TestWebKitAPI::TEST_F):
3689         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
3690         Added tests for deep NFAs.
3691
3692 2015-05-04  Alex Christensen  <achristensen@webkit.org>
3693
3694         [Content Extensions] Use less memory when writing byte code to file
3695         https://bugs.webkit.org/show_bug.cgi?id=144602
3696
3697         Reviewed by Darin Adler.
3698
3699         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3700
3701 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3702
3703         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
3704         https://bugs.webkit.org/show_bug.cgi?id=144541
3705
3706         Reviewed by Žan Doberšek.
3707
3708         Add a test case to WorkQueue unit test, to check that sources of
3709         asynchronous IO operations running in the WorkQueue thread are
3710         dispatched by the WorkQueue main loop.
3711
3712         * TestWebKitAPI/PlatformGTK.cmake:
3713         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
3714         (TestWebKitAPI::TEST):
3715
3716 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
3717
3718         Correct '--show-webview' option for Tiled Drawing tests
3719         https://bugs.webkit.org/show_bug.cgi?id=144621
3720
3721         Reviewed by Simon Fraser.
3722
3723         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
3724         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
3725
3726         * WebKitTestRunner/mac/TestControllerMac.mm:
3727         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
3728         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
3729
3730 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
3731
3732         Large array shouldn't be slow
3733         https://bugs.webkit.org/show_bug.cgi?id=144617
3734
3735         Reviewed by Geoffrey Garen.
3736         
3737         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
3738         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
3739         long-running. So, hash-map sort of belongs here.
3740
3741         * Scripts/run-jsc-benchmarks:
3742
3743 2015-05-04  Doug Russell  <d_russell@apple.com>
3744
3745         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
3746         https://bugs.webkit.org/show_bug.cgi?id=144489
3747
3748         Reviewed by Chris Fleizach.
3749
3750         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
3751         on the returned control.
3752         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
3753         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
3754         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
3755         Add support for setSelectedVisibleTextRange() in accessibility tests.
3756
3757         * DumpRenderTree/AccessibilityUIElement.cpp:
3758         (setSelectedVisibleTextRangeCallback):
3759         (AccessibilityUIElement::setSelectedVisibleTextRange):
3760         (AccessibilityUIElement::getJSClass):
3761         (AccessibilityUIElement::textMarkerForIndex): Deleted.
3762         * DumpRenderTree/AccessibilityUIElement.h:
3763         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3764         (AccessibilityUIElement::setSelectedVisibleTextRange):
3765         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3766         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3767         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
3768         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3769         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3770         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3771         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3772         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3773         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3774         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3775         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3776
3777 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
3778
3779         [Win] Implement the "--show-webview" option for Windows
3780         https://bugs.webkit.org/show_bug.cgi?id=144589
3781
3782         Reviewed by Alex Christensen.
3783
3784         Add another runtime flag (--show-webview) that causes DumpRenderTree
3785         to draw its view on-screen, rather than the standard offscreen mode.
3786
3787         * DumpRenderTree/win/DumpRenderTree.cpp:
3788         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
3789         (initializeGlobalsFromCommandLineOptions): Recognize the new
3790         command-line argument, and set the global 'showWebView' state if
3791         appropriate.
3792
3793 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
3794
3795         Remove dead code from TestInvocationCairo.cpp
3796         https://bugs.webkit.org/show_bug.cgi?id=144564
3797
3798         Reviewed by Gyuyoung Kim.
3799
3800         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
3801
3802         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3803         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3804
3805 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
3806
3807         [GTK] Add libnotify in gtk install-dependencies
3808         https://bugs.webkit.org/show_bug.cgi?id=144379
3809
3810         Reviewed by Csaba Osztrogonác.
3811
3812         * gtk/install-dependencies:
3813
3814 2015-05-01  Dan Bernstein  <mitz@apple.com>
3815
3816         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
3817         https://bugs.webkit.org/show_bug.cgi?id=144501
3818
3819         Reviewed by Darin Adler.
3820
3821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3822         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
3823         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
3824         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
3825
3826 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3827
3828         check-webkit-style fails due to system pylint
3829         https://bugs.webkit.org/show_bug.cgi?id=144360
3830
3831         Reviewed by Darin Adler.
3832
3833         Make sure that the directory containing third party autoinstalled modules
3834         is at the beginning of the search path, to avoid conflicts with other
3835         versions of the same modules installed in the system (e.g. pylint).
3836
3837         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
3838         modules directory to sys.path, instead of appending it.
3839
3840 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3841
3842         Unreviewed, updated my list of email addresses.
3843
3844         * Scripts/webkitpy/common/config/contributors.json: Updated.
3845
3846 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
3847
3848         USE(...) macro should expect unprefixed variables
3849         https://bugs.webkit.org/show_bug.cgi?id=144454
3850
3851         Reviewed by Daniel Bates.
3852
3853         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
3854         * DumpRenderTree/config.h: Ditto.
3855         * TestWebKitAPI/config.h: Ditto.
3856
3857 2015-05-01  Basile Clement  <basile_clement@apple.com>
3858
3859         Unreviewed. Add myself as a commiter in contributors.json.
3860
3861         * Scripts/webkitpy/common/config/contributors.json:
3862
3863 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
3864
3865         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
3866         https://bugs.webkit.org/show_bug.cgi?id=144487
3867
3868         Reviewed by Ryosuke Niwa.
3869
3870         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3871         (BenchmarkRunner.merge): Fix bug.
3872         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
3873
3874 2015-05-01  Brady Eidson  <beidson@apple.com>
3875
3876         Add API to disable meta refreshes.
3877         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
3878
3879         Reviewed by Alexey Proskuryakov.
3880
3881         * DumpRenderTree/mac/DumpRenderTree.mm:
3882         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
3883
3884 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
3885
3886         Provide a runtime flag to run-webkit-tests that shows the test view
3887         https://bugs.webkit.org/show_bug.cgi?id=144079.
3888
3889         Unreviewed correction to r183651.
3890
3891         * WebKitTestRunner/TestController.cpp:
3892         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
3893         flag is included in the options dictionary passed to the PlatformWebView.
3894
3895 2015-05-01  Antti Koivisto  <antti@apple.com>
3896
3897         Remove network process load serialization code
3898         https://bugs.webkit.org/show_bug.cgi?id=144448
3899
3900         Reviewed by Alexey Proskuryakov.
3901
3902         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3903         (WTR::InjectedBundle::beginTesting):
3904         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3905         (WTR::TestRunner::setSerializeHTTPLoads):
3906         (WTR::TestRunner::dispatchPendingLoadRequests):
3907
3908 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3909
3910         [GTK] Add libhyphen-dev to the build dependencies
3911         https://bugs.webkit.org/show_bug.cgi?id=144452
3912
3913         Reviewed by Martin Robinson.
3914
3915         * gtk/install-dependencies: Added hyphen as Fedora and Arch
3916         dependencies.
3917
3918 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
3919
3920         Provide a runtime flag to run-webkit-tests that shows the test view
3921         https://bugs.webkit.org/show_bug.cgi?id=144079.
3922
3923         Reviewed by Dean Jackson.
3924
3925         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
3926         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
3927         option:
3928         
3929         --additional-drt-flag="--show-webview"
3930
3931         * DumpRenderTree/mac/DumpRenderTree.mm:
3932         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
3933         '--show-webview' flag.
3934         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
3935         * WebKitTestRunner/Options.cpp:
3936         (WTR::Options::Options):
3937         (WTR::handleOptionShowWebView):
3938         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
3939         * WebKitTestRunner/Options.h:
3940         * WebKitTestRunner/TestController.cpp:
3941         (WTR::TestController::TestController):
3942         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
3943         * WebKitTestRunner/TestController.h:
3944         (WTR::TestController::shouldShowWebView):
3945         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3946         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
3947         options dictionary. If it is true, display the web view while running the test.
3948
3949 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
3950
3951         r183355 didn't trigger Mac tests
3952         https://bugs.webkit.org/show_bug.cgi?id=144464
3953
3954         Reviewed by Simon Fraser.
3955
3956         Update badly neglected filters and unit tests.
3957
3958         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3959         (_should_file_trigger_build):
3960         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3961         (ShouldBuildTest):
3962         (ShouldBuildTest.test_should_build):
3963
3964 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3965
3966         [GTK] Add libhyphen-dev to the build dependencies
3967         https://bugs.webkit.org/show_bug.cgi?id=144452
3968
3969         Reviewed by Martin Robinson.
3970
3971         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
3972         build dependencies.
3973
3974 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
3975
3976         [GTK] Testing dictionaries are not installed automatically
3977         https://bugs.webkit.org/show_bug.cgi?id=144460
3978
3979         Reviewed by Carlos Garcia Campos.
3980
3981         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
3982
3983 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
3984
3985         Fix return code issue, check return code of safari process and dump results to log
3986         https://bugs.webkit.org/show_bug.cgi?id=144436
3987
3988         Reviewed by Ryosuke Niwa.
3989
3990         * Scripts/run-benchmark:
3991         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3992         (BenchmarkRunner.dump): Correct typo.
3993         (BenchmarkRunner.wrap): Add results to console.
3994         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
3995         (OSXSafariDriver.prepareEnv):
3996         (OSXSafariDriver.launchUrl):
3997         (OSXSafariDriver.closeBrowsers):
3998
3999 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
4000
4001         Should no longer need to worry about very old versions of Xcode
4002         https://bugs.webkit.org/show_bug.cgi?id=144437
4003
4004         Reviewed by Dan Bernstein.
4005
4006         * Scripts/check-for-exit-time-destructors:
4007         * Scripts/check-for-global-initializers:
4008         * Scripts/check-for-weak-vtables-and-externals:
4009
4010 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
4011
4012         REGRESSION(183583): [Mac] make without SDKROOT has issues
4013         https://bugs.webkit.org/show_bug.cgi?id=144431
4014
4015         Reviewed by Dan Bernstein.
4016
4017         * Makefile:
4018         * WebKitTestRunner/Makefile:
4019         Assume an empty SDKROOT means an macosx variant, so only
4020         enable settings if the SDKROOT is not empty and does not
4021         contain "macosx".
4022
4023 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
4024
4025         Expand test infrastructure to support scrolling tests
4026         https://bugs.webkit.org/show_bug.cgi?id=143684
4027         <rdar://problem/20375516>
4028
4029         Reviewed by Simon Fraser.
4030
4031         * DumpRenderTree/mac/DumpRenderTree.mm:
4032         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
4033         reset before the next test run.
4034         * WebKitTestRunner/TestController.cpp:
4035         (WTR::TestController::resetStateToConsistentValues): Ditto."
4036
4037 2015-04-29  Alex Christensen  <achristensen@webkit.org>
4038
4039         Run javascriptcore tests on Windows without cygwin
4040         https://bugs.webkit.org/show_bug.cgi?id=144419
4041
4042         Reviewed by Brent Fulgham.
4043
4044         * Scripts/run-javascriptcore-tests:
4045         (runJSCStressTests):
4046         Just call ruby, not /usr/bin/env ruby.
4047
4048 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
4049
4050         [GTK] Add --enable-shared option to LLVM to build mesa
4051         https://bugs.webkit.org/show_bug.cgi?id=144393
4052
4053         Reviewed by Martin Robinson.
4054
4055         The updated mesa requires the shared LLVM libraries.
4056         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
4057         to LLVM configure script. It will provide shared libraries in addition to static libraries.
4058
4059         * gtk/jhbuild-optional.modules:
4060
4061 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
4062
4063         [GTK] Add support for automatic hyphenation
4064         https://bugs.webkit.org/show_bug.cgi?id=44478
4065
4066         Reviewed by Carlos Garcia Campos.
4067
4068         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
4069         all systems will use the same dictionaries for testing purposes.
4070
4071 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
4072
4073         Failure when building WebKit for appletvsimulator.
4074         https://bugs.webkit.org/show_bug.cgi?id=144356
4075
4076         Reviewed by Alexey Proskuryakov.
4077
4078         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
4079         make TVOS and WatchOS behave correctly.
4080
4081         * Makefile:
4082         * WebKitTestRunner/Makefile:
4083
4084 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
4085
4086         Use-after-free when invalidating WKPageForceRepaint callback
4087         https://bugs.webkit.org/show_bug.cgi?id=144401
4088         rdar://problem/20741111
4089
4090         Reviewed by Tim Horton.
4091
4092         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
4093
4094         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
4095         Don't do anything on error, because the context may be a stale pointer now.
4096
4097 2015-04-29  David Kilzer  <ddkilzer@apple.com>
4098
4099         check-webkit-style: Don't complain about returning value from Objective-C method call in header
4100         <http://webkit.org/b/144395>
4101
4102         Reviewed by Andy Estes.
4103
4104         * Scripts/webkitpy/style/checkers/cpp.py:
4105         (check_spacing): Update regex so 'return' is ignored if it
4106         precedes the whitespace and bracket.  Change category name to
4107         'whitespace/brackets'.  Add period to error message.
4108         (CppChecker): Add 'whitespace/brackets' as a category.
4109         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4110         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
4111         'CppChecker.categories' since that's where the list lives now.
4112         (CppStyleTest.test_spacing_before_brackets): Add tests for
4113         'whitespace/brackets' issues and non-issues.
4114
4115 2015-04-29  Alex Christensen  <achristensen@webkit.org>
4116
4117         Fix WinCairo bot.
4118
4119         * Scripts/webkitdirs.pm:
4120         (determinePassedConfiguration):
4121         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
4122
4123 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
4124
4125         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
4126         https://bugs.webkit.org/show_bug.cgi?id=132159
4127
4128         Reviewed by Darin Adler.
4129
4130         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
4131         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
4132
4133         * DumpRenderTree/mac/DumpRenderTree.mm:
4134         (fontWhitelist):
4135         (adjustFonts):
4136         (createWebViewAndOffscreenWindow):
4137         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4138         (WTR::activateFonts):
4139         * WebKitTestRunner/mac/TestControllerMac.mm:
4140         (WTR::allowedFontFamilySet):
4141         (WTR::systemHiddenFontFamilySet):
4142         (WTR::generateWhitelist):
4143         (WTR::TestController::platformInitializeContext):
4144
4145 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
4146
4147         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
4148         https://bugs.webkit.org/show_bug.cgi?id=144155
4149
4150         Reviewed by Andreas Kling.
4151
4152         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
4153         Make sure that test window is "visible" before each test. While there is no concrete
4154         evidence that this is the problem indeed, the behavior is consistent with what would
4155         happen for an invisible window. Also, WKTR obviously needs to do this to protect
4156         against potential buggy tests that hide the window and don't show it.
4157
4158 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
4159
4160         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
4161
4162         Latest changes in the inspector UI made this test fail. We were
4163         relying that the sidebar was always visible and the first 'li'
4164         element of the inspector was the one containing the title. This is
4165         no longer true, so better use document title that is not likely
4166         to change.
4167
4168         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
4169         (openRemoteDebuggingSession):
4170
4171 2015-04-29  Andres Gomez  <agomez@igalia.com>
4172
4173         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
4174
4175         * Scripts/webkitpy/common/config/contributors.json:
4176
4177 2015-04-29  Andres Gomez  <agomez@igalia.com>
4178
4179         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
4180
4181         * Scripts/webkitpy/common/config/watchlist:
4182
4183 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
4184
4185         [EFL] Allow to run the tests on the native X display
4186         https://bugs.webkit.org/show_bug.cgi?id=144247
4187
4188         Reviewed by Gyuyoung Kim.
4189
4190         Added the USE_NATIVE_XDISPLAY option for the WTR.
4191         We can select the Xorg driver if environment variable is set up before running the tests.
4192
4193         * Scripts/webkitpy/port/efl.py:
4194         (EflPort._driver_class):
4195
4196 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
4197
4198         [GTK] Add libnotify-dev in gtk install-dependencies
4199         https://bugs.webkit.org/show_bug.cgi?id=144379
4200
4201         Reviewed by Žan Doberšek.
4202
4203         * gtk/install-dependencies:
4204
4205 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
4206
4207         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
4208         https://bugs.webkit.org/show_bug.cgi?id=143001
4209
4210         Reviewed by Gyuyoung Kim.
4211
4212         * WebKitTestRunner/TestController.cpp:
4213         (WTR::shouldUseFixedLayout):
4214
4215 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
4216
4217         Increase stablility of run-benchmark script
4218         https://bugs.webkit.org/show_bug.cgi?id=144361
4219
4220         Reviewed by Ryosuke Niwa.
4221
4222         * Scripts/run-benchmark:
4223         (main):
4224         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
4225         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
4226         (GenericBenchmarkBuilder.clean):
4227         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
4228         (BenchmarkRunner.__init__):
4229         (BenchmarkRunner.execute):
4230         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
4231         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
4232         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
4233         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
4234         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
4235         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
4236         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
4237         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
4238         (HTTPServerDriver.fetchResult):
4239         (HTTPServerDriver):
4240         (HTTPServerDriver.killServer): Add kill server interface.
4241         (HTTPServerDriver.getReturnCode): Add get return code interface.
4242         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
4243         (SimpleHTTPServerDriver.serve):
4244         (SimpleHTTPServerDriver.fetchResult):
4245         (SimpleHTTPServerDriver):
4246         (SimpleHTTPServerDriver.killServer):
4247         (SimpleHTTPServerDriver.getReturnCode):
4248         * Scripts/webkitpy/benchmark_runner/utils.py:
4249         (forceRemove): Provide python version of 'rm -rf'.
4250
4251 2015-04-28  Sam Weinig  <sam@webkit.org>
4252
4253         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
4254         https://bugs.webkit.org/show_bug.cgi?id=144363
4255
4256         Reviewed by Alex Christensen.
4257
4258         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4259         (TestWebKitAPI::createNFAs):
4260         (TestWebKitAPI::TEST_F):
4261         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
4262         (TestWebKitAPI::countLiveNodes):
4263         (TestWebKitAPI::createNFAs):
4264         (TestWebKitAPI::buildDFAFromPatterns):
4265         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
4266
4267 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
4268
4269         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
4270         https://bugs.webkit.org/show_bug.cgi?id=144304
4271
4272         Reviewed by Geoffrey Garen.
4273
4274         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
4275         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
4276         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
4277
4278 2015-04-28  Commit Queue  <commit-queue@webkit.org>
4279
4280         Unreviewed, rolling out r183514.
4281         https://bugs.webkit.org/show_bug.cgi?id=144359
4282
4283         It broke cloop test bots (Requested by mcatanzaro on #webkit).
4284
4285         Reverted changeset:
4286
4287         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
4288         https://bugs.webkit.org/show_bug.cgi?id=144304
4289         http://trac.webkit.org/changeset/183514
4290
4291 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
4292
4293         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
4294         https://bugs.webkit.org/show_bug.cgi?id=144304
4295
4296         Reviewed by Geoffrey Garen.
4297
4298         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
4299         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
4300         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
4301         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
4302
4303 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4304
4305         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
4306         https://bugs.webkit.org/show_bug.cgi?id=144319
4307
4308         Reviewed by Csaba Osztrogonác.
4309
4310         * TestWebKitAPI/CMakeLists.txt:
4311         * TestWebKitAPI/PlatformEfl.cmake:
4312
4313 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
4314
4315         Fix common typo "targetting" => "targeting"
4316         https://bugs.webkit.org/show_bug.cgi?id=144349
4317
4318         Reviewed by Daniel Bates.
4319
4320         * Scripts/webkitdirs.pm:
4321         (execMacWebKitAppForDebugging):
4322
4323 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
4324
4325         [GTK][jhbuild] Mesa build failure with llvm 3.6
4326         https://bugs.webkit.org/show_bug.cgi?id=144250
4327
4328         Reviewed by Žan Doberšek.