c6744bfaf4604c0c19e71dec1d44c331c9cc5481
[WebKit-https.git] / Tools / ChangeLog
1 2017-06-28  Keith Miller  <keith_miller@apple.com>
2
3         VMTraps has some races
4         https://bugs.webkit.org/show_bug.cgi?id=173941
5
6         Reviewed by Michael Saboff.
7
8         Add new testing mode for testing the Watchdog with our stress
9         tests.
10
11         * Scripts/run-jsc-stress-tests:
12
13 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
14
15         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
16         https://bugs.webkit.org/show_bug.cgi?id=173877
17
18         Reviewed by Brady Eidson.
19
20         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
21         the next tests.
22
23         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
24         (testGetFavicon):
25
26 2017-06-28  Tim Horton  <timothy_horton@apple.com>
27
28         MobileSafari was constantly using 10-15% CPU viewing a PDF
29         https://bugs.webkit.org/show_bug.cgi?id=173944
30         <rdar://problem/33039910>
31
32         Reviewed by Simon Fraser.
33
34         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
35         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
36         Add a test that we ever call the stable presentation update callback
37         when we have a WKPDFView up, instead of infinitely looping.
38
39 2017-06-28  Alex Christensen  <achristensen@webkit.org>
40
41         Prevent displaying URLs with small capital letters
42         https://bugs.webkit.org/show_bug.cgi?id=173949
43         <rdar://problem/32952058>
44
45         Reviewed by Brent Fulgham.
46
47         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
48         (TestWebKitAPI::TEST):
49
50 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
51
52         Unreviewed test fix.
53
54         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
55
56         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
57
58 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
59
60         Teach ResourceLoadStatistics to recognize changes in the file system
61         https://bugs.webkit.org/show_bug.cgi?id=173800
62         <rdar://problem/32937842>
63
64         Reviewed by Chris Dumez.
65
66         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
67         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
68         (TestWebKitAPI::FileMonitorTest::tempFilePath):
69         (TestWebKitAPI::handleFileModification):
70         (TestWebKitAPI::handleFileDeletion):
71         (TestWebKitAPI::resetTestState):
72         (TestWebKitAPI::TEST_F):
73
74 2017-06-28  Brady Eidson  <beidson@apple.com>
75
76         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
77         https://bugs.webkit.org/show_bug.cgi?id=173874
78
79         Reviewed by Alex Christensen.
80
81         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
82
83 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
84
85         Unreviewed, adding Don Olmstead to contributors.json
86
87         * Scripts/webkitpy/common/config/contributors.json:
88
89 2017-06-28  Alex Christensen  <achristensen@webkit.org>
90
91         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
92         https://bugs.webkit.org/show_bug.cgi?id=173886
93         <rdar://problem/32543191>
94
95         Reviewed by Andy Estes.
96
97         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
98         (ParsedRange::ParsedRange):
99         (-[TestSchemeHandler initWithVideoData:]):
100         (-[TestSchemeHandler webView:startURLSchemeTask:]):
101         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
102         (TEST):
103
104 2017-06-27  JF Bastien  <jfbastien@apple.com>
105
106         WebAssembly: running out of executable memory should throw OoM
107         https://bugs.webkit.org/show_bug.cgi?id=171537
108         <rdar://problem/32963338>
109
110         Reviewed by Saam Barati.
111
112         * Scripts/run-jsc-stress-tests: add a configuration which runs the
113         tests under limited executable memory and avoids non-WebAssembly
114         code generation so that we more reliably run out of executable
115         memory in WebAssembly.
116
117 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
118
119         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
120         https://bugs.webkit.org/show_bug.cgi?id=173854
121         <rdar://problem/32236827>
122
123         Reviewed by Ryosuke Niwa and Tim Horton.
124
125         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
126
127         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
128         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
129         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
130         (TestWebKitAPI::TEST):
131
132 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
133
134         [PAL] Add symbol export macros for PAL
135         https://bugs.webkit.org/show_bug.cgi?id=171519
136
137         Reviewed by Konstantin Tokarev.
138
139         * DumpRenderTree/config.h:
140         * TestWebKitAPI/CMakeLists.txt:
141         * TestWebKitAPI/config.h:
142         * WebKitTestRunner/config.h:
143
144 2017-06-27  John Wilander  <wilander@apple.com>
145
146         Resource Load Statistics: Add telemetry
147         https://bugs.webkit.org/show_bug.cgi?id=173499
148         <rdar://problem/32826094>
149
150         Reviewed by Brent Fulgham.
151
152         Adds three new testRunner functions:
153         - installStatisticsDidRunTelemetryCallback()
154         - statisticsFireTelemetryHandler()
155         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
156
157         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
158         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
159         (WTR::InjectedBundle::didReceiveMessageToPage):
160         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
161         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
162         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
163         (WTR::TestRunner::statisticsFireTelemetryHandler):
164         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
165         * WebKitTestRunner/InjectedBundle/TestRunner.h:
166         * WebKitTestRunner/TestController.cpp:
167         (WTR::TestController::resetStateToConsistentValues):
168         (WTR::TestController::statisticsFireTelemetryHandler):
169         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
170         * WebKitTestRunner/TestController.h:
171         * WebKitTestRunner/TestInvocation.cpp:
172         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
173
174 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
175
176         Add missing includes to fix compilation error on FreeBSD
177         https://bugs.webkit.org/show_bug.cgi?id=172919
178
179         Reviewed by Mark Lam.
180
181         * ImageDiff/cairo/PlatformImageCairo.cpp:
182
183 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
184
185         Unreviewed, rolling out r218783.
186
187         Causing accessibility/mac/setting-attributes-is-
188         asynchronous.html to crash consistently on mac-wk2 Debug
189
190         Reverted changeset:
191
192         "AX: Cannot call setValue() on contenteditable or ARIA text
193         controls"
194         https://bugs.webkit.org/show_bug.cgi?id=173520
195         http://trac.webkit.org/changeset/218783
196
197 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
198
199         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
200         https://bugs.webkit.org/show_bug.cgi?id=173825
201
202         Reviewed by Saam Barati.
203
204         * DumpRenderTree/JavaScriptThreading.cpp:
205         (runJavaScriptThread):
206         (startJavaScriptThreads):
207         * DumpRenderTree/mac/DumpRenderTree.mm:
208         (runThread):
209         (runPthread):
210         (testThreadIdentifierMap):
211
212 2017-06-26  David Kilzer  <ddkilzer@apple.com>
213
214         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
215         <https://webkit.org/b/173837>
216
217         Reviewed by Geoffrey Garen.
218
219         The clang static analyzer can't reason about objects that are
220         assigned to a delegate as +1 retained, and then released
221         later in a different method when the delegate is cleared.
222
223         Instead, use a common idiom where the object setting the
224         delegate retains it as an instance variable on initialization.
225         Then the same object clears the delegate and releases its
226         instance variable during teardown.
227
228         Also add EXPECT_TRUE() tests to make sure the delegate objects
229         match before teardown.
230
231         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
232         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
233         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
234         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
235         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
236         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
237
238 2017-06-26  David Kilzer  <ddkilzer@apple.com>
239
240         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
241         <https://webkit.org/b/173836>
242
243         Reviewed by Brady Eidson.
244
245         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
246         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
247         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
248         objects in this test.
249
250 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
251
252         [ATK] Add support for aria-details and aria-errormessage
253         https://bugs.webkit.org/show_bug.cgi?id=172588
254
255         Reviewed by Chris Fleizach.
256
257         Add additional methods to test ARIA properties which are exposed via
258         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
259         to versions which support the details and error-message relation types.
260
261         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
262         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
263         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
264         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
265         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
266         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
267         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
268         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
269         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
270         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
271         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
272         * gtk/jhbuild.modules:
273
274 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
275
276         Unreviewed. Add libfii to GTK+ install dependencies script.
277
278         * gtk/install-dependencies:
279
280 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
281
282         Unreviewed, rolling out r215190.
283
284         Broke product select element on GNOME Bugzilla
285
286         Reverted changeset:
287
288         "[GTK] Misplaced right click menu on web page due to
289         deprecated gtk_menu_popup()"
290         https://bugs.webkit.org/show_bug.cgi?id=170553
291         http://trac.webkit.org/changeset/215190
292
293 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
294
295         Remove Reflect.enumerate
296         https://bugs.webkit.org/show_bug.cgi?id=173806
297
298         Reviewed by Yusuke Suzuki.
299
300         * Scripts/run-jsc-stress-tests:
301
302 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
303
304         AX: Cannot call setValue() on contenteditable or ARIA text controls
305         https://bugs.webkit.org/show_bug.cgi?id=173520
306
307         Reviewed by Ryosuke Niwa.
308
309         Add setValue() method to WKTR (already existed in DRT).
310
311         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
312         (WTR::AccessibilityUIElement::setValue):
313         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
314         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
315         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
316         (WTR::AccessibilityUIElement::setValue):
317
318 2017-06-23  Keith Miller  <keith_miller@apple.com>
319
320         Switch VMTraps to use halt instructions rather than breakpoint instructions
321         https://bugs.webkit.org/show_bug.cgi?id=173677
322
323         Reviewed by JF Bastien.
324
325         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
326         (TEST):
327
328 2017-06-23  Youenn Fablet  <youenn@apple.com>
329
330         Set getUserMedia permission to true by default on WTR
331         https://bugs.webkit.org/show_bug.cgi?id=173610
332
333         Reviewed by Alex Christensen.
334
335         Adding a way to reset the getUserMedia permission to pending.
336
337         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
338         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
339         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
340         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
341         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
342         (WTR::TestRunner::setUserMediaPermissionAsUnset):
343         * WebKitTestRunner/InjectedBundle/TestRunner.h:
344         * WebKitTestRunner/TestController.cpp:
345         (WTR::TestController::resetStateToConsistentValues):
346         (WTR::TestController::setUserMediaPermissionAsUnset):
347         * WebKitTestRunner/TestController.h:
348         * WebKitTestRunner/TestInvocation.cpp:
349         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
350
351 2017-06-23  Alex Christensen  <achristensen@webkit.org>
352
353         Add SPI to WKURLSchemeTask for redirection
354         https://bugs.webkit.org/show_bug.cgi?id=173730
355
356         Reviewed by Brady Eidson.
357
358         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
359         (-[SchemeHandler webView:startURLSchemeTask:]):
360         (-[SchemeHandler webView:stopURLSchemeTask:]):
361         (TEST):
362         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
363         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
364         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
365         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
366         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
367
368 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
369
370         [WPE] Use JSC API to send script messages from web extension in tests
371         https://bugs.webkit.org/show_bug.cgi?id=173757
372
373         Reviewed by Žan Doberšek.
374
375         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
376         to run postMessage().
377
378         Fixes: /wpe/WebKitSecurityManager/file-xhr
379                /wpe/WebKitConsoleMessage/console-api
380                /wpe/WebKitConsoleMessage/js-exception
381                /wpe/WebKitConsoleMessage/network-error
382                /wpe/WebKitConsoleMessage/security-error
383
384         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
385         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
386         (beforeAll): Ditto.
387         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
388         (testWebContextSecurityFileXHR): Ditto.
389         (beforeAll): Ditto.
390         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
391         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
392         (pageCreatedCallback): Remove ifdefs.
393
394 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
395
396         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
397
398         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
399         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
400         doesn't exist yet in WPE.
401
402         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
403         (testWebViewJavaScriptDialogs):
404         (testWebViewWindowProperties):
405
406 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
407
408         [GTK] Upgrade pixman and cairo in jhbuild
409         https://bugs.webkit.org/show_bug.cgi?id=173710
410
411         Reviewed by Carlos Alberto Lopez Perez.
412
413         * gtk/jhbuild.modules:
414
415 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
416
417         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
418         https://bugs.webkit.org/show_bug.cgi?id=173711
419
420         Reviewed by Carlos Alberto Lopez Perez.
421
422         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
423         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
424
425         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
426         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
427
428 2017-06-22  David Kilzer  <ddkilzer@apple.com>
429
430         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
431         <https://webkit.org/b/173721>
432
433         Reviewed by Joseph Pecoraro.
434
435         Use RetainPtr<> to create NSMutableDictionary and NSNumber
436         objects to fix leaks and to avoid the autoreleasepool.
437
438         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
439         (TEST):
440
441 2017-06-22  Matt Lewis  <jlewis3@apple.com>
442
443         Unreviewed, rolling out r218633.
444
445         The test is failing frequently on Sierra Debug and Windows
446
447         Reverted changeset:
448
449         "AX: Cannot call setValue() on contenteditable or ARIA text
450         controls"
451         https://bugs.webkit.org/show_bug.cgi?id=173520
452         http://trac.webkit.org/changeset/218633
453
454 2017-06-22  David Kilzer  <ddkilzer@apple.com>
455
456         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
457         <https://webkit.org/b/173690>
458
459         Reviewed by Chris Dumez.
460
461         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
462         ownership of malloc()-ed memory, then frees it when it's
463         released.  These tests were passing global variables into the
464         method, which is not malloc()-ed memory, which violates the API
465         contract.
466
467         The fix is to switch to use
468         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
469         NO for the last argument.
470
471         Caught by the clang static analyzer.
472
473         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
474         (TEST):
475         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
476         (TEST):
477
478 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
479
480         [GTK] Upgrade Harfbuzz to version 1.4.2
481         https://bugs.webkit.org/show_bug.cgi?id=173592
482
483         Reviewed by Carlos Alberto Lopez Perez.
484
485         * gtk/jhbuild.modules:
486
487 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
488
489         [WPE] Update WPEBackend-mesa
490         https://bugs.webkit.org/show_bug.cgi?id=173705
491
492         Reviewed by Carlos Alberto Lopez Perez.
493
494         A crash has been fixed, needed for unit tests to work.
495
496         * wpe/jhbuild.modules:
497
498 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
499
500         Remove unused coordinated graphics C API
501         https://bugs.webkit.org/show_bug.cgi?id=173706
502
503         Reviewed by Žan Doberšek.
504
505         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
506         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
507         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
508         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
509         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
510         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
511
512 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
513
514         [WPE] Build glib API tests
515         https://bugs.webkit.org/show_bug.cgi?id=173702
516
517         Reviewed by Žan Doberšek.
518
519         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
520         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
521         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
522         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
523         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
524         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
525         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
526         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
527         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
528         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
529         and implement the missing features.
530
531         * CMakeLists.txt:
532         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
533         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
534         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
535         (testAutomationSessionRequestSession):
536         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
537         (testWebKitWebViewSessionState):
538         (testWebKitWebViewSessionStateWithFormData):
539         (testWebKitWebViewNavigationAfterSessionRestore):
540         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
541         (beforeAll):
542         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
543         (testCookieManagerEphemeral):
544         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
545         (testBlobDownload):
546         (beforeAll):
547         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
548         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
549         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
550         (testProcessPerWebView):
551         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
552         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
553         (testWebViewCreateNavigationData):
554         (testWebViewJavaScriptDialogs):
555         (testWebViewWindowProperties):
556         (testWebViewMouseTarget):
557         (testWebViewGeolocationPermissionRequests):
558         (testWebViewUserMediaPermissionRequests):
559         (testWebViewAudioOnlyUserMediaPermissionRequests):
560         (testWebViewFileChooserRequest):
561         (beforeAll):
562         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
563         (beforeAll):
564         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
565         (testPrivateBrowsing):
566         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
567         (testFindControllerHide):
568         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
569         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
570         (testWebKitSettings):
571         (beforeAll):
572         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
573         (testWebViewNewWithUserContentManager):
574         (beforeAll):
575         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
576         (testWebContextEphemeral):
577         (testWebContextProxySettings):
578         (beforeAll):
579         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
580         (testWebViewWebContext):
581         (testWebViewWebContextLifetime):
582         (testWebViewEphemeral):
583         (testWebViewSettings):
584         (testWebViewCanShowMIMEType):
585         (testWebViewPageVisibility):
586         (testWebViewIsPlayingAudio):
587         (beforeAll):
588         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
589         (testWebsiteDataEphemeral):
590         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
591         (documentLoadedCallback):
592         (pageCreatedCallback):
593         (methodCallCallback):
594         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
595         * TestWebKitAPI/glib/CMakeLists.txt:
596         * TestWebKitAPI/glib/PlatformGTK.cmake:
597         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
598         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
599         (main):
600         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
601         (Test::adoptView):
602         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
603         (WebKitTestBus::run):
604         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
605         (WebViewTest::~WebViewTest):
606         (WebViewTest::initializeWebView):
607         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
608         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
609         (WebViewTest::platformDestroy):
610         (WebViewTest::platformInitializeWebView):
611         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
612         (WebViewTest::resizeView):
613         (WebViewTest::hideView):
614         (parentWindowMapped):
615         (WebViewTest::showInWindow):
616         (WebViewTest::showInWindowAndWaitUntilMapped):
617         (WebViewTest::mouseMoveTo):
618         (WebViewTest::clickMouseButton):
619         (WebViewTest::emitPopupMenuSignal):
620         (WebViewTest::keyStroke):
621         (WebViewTest::doMouseButtonEvent):
622         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
623         (WebViewTest::platformDestroy):
624         (WebViewTest::platformInitializeWebView):
625         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
626         (WebViewTest::resizeView):
627         (WebViewTest::hideView):
628         (WebViewTest::mouseMoveTo):
629         (WebViewTest::clickMouseButton):
630         (WebViewTest::keyStroke):
631
632 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
633
634         [GTK] Move WebKit2 GLib API tests to glib directories
635         https://bugs.webkit.org/show_bug.cgi?id=173642
636
637         Reviewed by Žan Doberšek.
638
639         * CMakeLists.txt:
640         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
641         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
642         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
643         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
644         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
645         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
646         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
647         (testWebKitConsoleMessageNetworkError):
648         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
649         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
650         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
651         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
652         (testLoadFromGResource):
653         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
654         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
655         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
656         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
657         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
658         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
659         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
660         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
661         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
662         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
663         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
664         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
665         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
666         (testWebViewRunJavaScript):
667         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
668         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
669         (registerGResource):
670         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
671         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
672         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
673         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
674         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
675         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
676         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
677         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
678         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
679         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
680         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
681         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
682         * TestWebKitAPI/glib/CMakeLists.txt: Added.
683         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
684         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
685         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
686         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
687         (registerGResource):
688         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
689         (Test::getResourcesDir):
690         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
691         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
692         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
693         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
694         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
695         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
696
697 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
698
699         [WPE] Add initial web extensions API
700         https://bugs.webkit.org/show_bug.cgi?id=173640
701
702         Reviewed by Žan Doberšek.
703
704         Add style checker exceptions for WPE web extensions API files.
705
706         * Scripts/webkitpy/style/checker.py:
707
708 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
709
710         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
711         https://bugs.webkit.org/show_bug.cgi?id=173659
712         <rdar://problem/32879788>
713
714         Reviewed by Tim Horton.
715
716         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
717
718         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
719
720         Augment this test page to log dragend and dragstart events on the drag source as well.
721
722         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
723         (checkStringArraysAreEqual):
724         (TestWebKitAPI::TEST):
725
726 2017-06-21  Antoine Quint  <graouts@apple.com>
727
728         Ensure DRT always logs rAF suspension debugging code
729         https://bugs.webkit.org/show_bug.cgi?id=173681
730
731         Reviewed by Tim "Mr. T" Horton.
732
733         * DumpRenderTree/mac/DumpRenderTree.mm:
734         (resetWebPreferencesToConsistentValues):
735
736 2017-06-21  Chris Dumez  <cdumez@apple.com>
737
738         Allow constructing a WTF:Function from a function pointer
739         https://bugs.webkit.org/show_bug.cgi?id=173660
740
741         Reviewed by Alex Christensen.
742
743         Add API test coverage.
744
745         * TestWebKitAPI/Tests/WTF/Function.cpp:
746         (TestWebKitAPI::returnThree):
747         (TestWebKitAPI::returnFour):
748         (TestWebKitAPI::returnPassedValue):
749         (TestWebKitAPI::TEST):
750
751 2017-06-21  Antoine Quint  <graouts@apple.com>
752
753         Add logging to identify when the Page suspends scripted animations
754         https://bugs.webkit.org/show_bug.cgi?id=173626
755
756         Reviewed by Tim Horton.
757
758         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
759
760         * DumpRenderTree/mac/DumpRenderTree.mm:
761         (resetWebPreferencesToConsistentValues):
762
763 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
764
765         AX: Cannot call setValue() on contenteditable or ARIA text controls
766         https://bugs.webkit.org/show_bug.cgi?id=173520
767
768         Reviewed by Ryosuke Niwa.
769
770         Add setValue() method to WKTR (already existed in DRT).
771
772         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
773         (WTR::AccessibilityUIElement::setValue):
774         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
775         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
776         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
777         (WTR::AccessibilityUIElement::setValue):
778
779 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
780
781         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
782         as one of the dependencies required to build the product.
783
784         Rubber-stamped by Carlos Garcia Campos.
785
786         * gtk/install-dependencies:
787         * wpe/install-dependencies:
788
789 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
790
791         Disable font variations on macOS Sierra and iOS 10
792         https://bugs.webkit.org/show_bug.cgi?id=173618
793         <rdar://problem/32879164>
794
795         Reviewed by Jon Lee.
796
797         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
798
799 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
800
801         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
802         https://bugs.webkit.org/show_bug.cgi?id=173578
803         <rdar://problem/32825028>
804
805         Reviewed by Tim Horton.
806
807         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
808         a custom popover does not cause dragging to fail when the popover is presented.
809
810         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
811         (-[DataInteractionSimulator _advanceProgress]):
812
813 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
814
815         [WPE] Add initial implementation of glib API
816         https://bugs.webkit.org/show_bug.cgi?id=173546
817
818         Reviewed by Žan Doberšek.
819
820         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
821         include WPE glib API files.
822
823         * Scripts/webkitperl/FeatureList.pm:
824         * Scripts/webkitpy/style/checker.py:
825         * Scripts/webkitpy/style/checkers/cpp.py:
826         (check_identifier_name_in_declaration):
827
828 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
829
830         [GTK] Upgrade to ICU to version 57.1
831         https://bugs.webkit.org/show_bug.cgi?id=173538
832
833         Reviewed by Žan Doberšek.
834
835         * gtk/jhbuild.modules:
836
837 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
838
839         [GTK] Remove unneeded modules from the jhbuild
840         https://bugs.webkit.org/show_bug.cgi?id=170540
841
842         Reviewed by Michael Catanzaro.
843
844         We are building libxslt and libffi that we don't really need to build from sources.
845
846         * gtk/jhbuild.modules:
847
848 2017-06-19  Frederic Wang  <fwang@igalia.com>
849
850         [Mac] Add an experimental feature setting for async frame scrolling
851         https://bugs.webkit.org/show_bug.cgi?id=173359
852
853         Reviewed by Simon Fraser.
854
855         * DumpRenderTree/mac/DumpRenderTree.mm:
856         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
857         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
858         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
859         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
860
861 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
862
863         Unreviewed, adding myself to contributors.json
864
865         * Scripts/webkitpy/common/config/contributors.json:
866
867 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
868
869         test262: Completion values for control flow do not match the spec
870         https://bugs.webkit.org/show_bug.cgi?id=171265
871
872         Reviewed by Saam Barati.
873
874         * Scripts/run-jsc-stress-tests:
875         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
876
877 2017-06-19  Zalan Bujtas  <zalan@apple.com>
878
879         Opening certain mails brings up a mail that grows indefinitely.
880         https://bugs.webkit.org/show_bug.cgi?id=173562
881         <rdar://problem/32766579>
882
883         Reviewed by Tim Horton.
884
885         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
886         (TEST):
887
888 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
889
890         [iOS DnD] Support .zip archives for file uploads via drag and drop
891         https://bugs.webkit.org/show_bug.cgi?id=173511
892         <rdar://problem/32521025>
893
894         Reviewed by Tim Horton.
895
896         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
897         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
898
899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
900         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
901         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
902         (testZIPArchive):
903         (TestWebKitAPI::TEST):
904
905 2017-06-18  Darin Adler  <darin@apple.com>
906
907         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
908         https://bugs.webkit.org/show_bug.cgi?id=173526
909
910         Reviewed by Sam Weinig.
911
912         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
913         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
914
915         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
916         tests for assignment before destruction ones.
917
918         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
919         as a function, so it can be used in WTF::Function tests.
920
921         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
922         Added tests for swap and for assignment before deref.
923
924         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
925         to inline everything. Also removed the unnecessary clearing of the log every time
926         the DerivedRefLogger constructor is called.
927         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
928
929         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
930         Added tests for assignment before deref and similar for releaseNonNull.
931
932 2017-06-19  Sam Weinig  <sam@webkit.org>
933
934         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
935         https://bugs.webkit.org/show_bug.cgi?id=173513
936
937         Reviewed by Alex Christensen.
938
939         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
940         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
941         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
942
943 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
944
945         [Win] fast/dom/assign-to-window-status.html is flaky.
946         https://bugs.webkit.org/show_bug.cgi?id=173512
947
948         Reviewed by Alex Christensen.
949
950         We should not dump status callbacks when test is done.
951
952         * DumpRenderTree/win/UIDelegate.cpp:
953         (UIDelegate::setStatusText):
954
955 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
956
957         [WPE][JHBuild] Update WPEBackend-mesa
958         https://bugs.webkit.org/show_bug.cgi?id=173433
959
960         Unreviewed.
961
962         Update WPEBackend-mesa back (like it was done originally in r218344)
963         after fixing the issue with the DISPLAY environment variables that
964         caused the crashes.
965
966         * wpe/jhbuild.modules:
967
968 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
969
970         Rename unit test file after r218482
971         https://bugs.webkit.org/show_bug.cgi?id=173483
972
973         Unreviewed.
974
975         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
976
977 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
978
979         Unreviewed. Fix wrong style checker condition added in r218487.
980
981         * Scripts/webkitpy/style/checkers/cpp.py:
982         (check_identifier_name_in_declaration):
983
984 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
985
986         Missing <functional> includes make builds fail with GCC 7.x
987         https://bugs.webkit.org/show_bug.cgi?id=173544
988
989         Unreviewed gardening.
990
991         Fix compilation with GCC 7.
992
993         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
994         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
995
996 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
997
998         [GTK] Move GTK+ API files that could be shared to glib dirs
999         https://bugs.webkit.org/show_bug.cgi?id=173545
1000
1001         Reviewed by Žan Doberšek.
1002
1003         Update paths of GTK+ API in watchlist and style checker.
1004
1005         * Scripts/webkitpy/common/config/watchlist:
1006         * Scripts/webkitpy/style/checker.py:
1007         * Scripts/webkitpy/style/checkers/cpp.py:
1008         (check_identifier_name_in_declaration):
1009
1010 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1011
1012         Port setup_environ_for_server should not set environment variables related with the driver.
1013         https://bugs.webkit.org/show_bug.cgi?id=173483
1014
1015         Reviewed by Carlos Garcia Campos.
1016
1017         The port setup_environ_for_server() should not set environment variables
1018         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
1019         This varibles should be only set on the driver setup_environ_for_test().
1020
1021         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
1022         into the test environment even when running the tests with a driver
1023         that is not the Xorg or Xvfb one.
1024
1025         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
1026         (Port.to.setup_environ_for_server):
1027         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
1028         (Driver._setup_environ_for_driver):
1029         * Scripts/webkitpy/port/driver_unittest.py:
1030         (DriverTest.test_setup_environ_for_test):
1031         (DriverTest):
1032         (DriverTest.test_setup_environ_base_vars):
1033         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
1034         (GtkPort.setup_environ_for_server):
1035         * Scripts/webkitpy/port/wayland_unittest.py: Added.
1036         (WaylandDriverTest):
1037         (WaylandDriverTest.make_driver):
1038         (WaylandDriverTest.make_environment):
1039         (WaylandDriverTest.test_checkdriver):
1040         (WaylandDriverTest.test_environment_needed_variables):
1041         (WaylandDriverTest.test_environment_forbidden_variables):
1042         (WaylandDriverTest.test_environment_optional_variables):
1043         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
1044         (WaylandDriver.check_driver):
1045         (WaylandDriver._setup_environ_for_test):
1046         * Scripts/webkitpy/port/xorgdriver.py:
1047         (XorgDriver.check_driver):
1048         (XorgDriver._setup_environ_for_test):
1049         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
1050         (XorgDriverTest):
1051         (XorgDriverTest.make_driver):
1052         (XorgDriverTest.make_environment):
1053         (XorgDriverTest.test_checkdriver):
1054         (XorgDriverTest.test_environment_needed_variables):
1055         (XorgDriverTest.test_environment_forbidden_variables):
1056         (XorgDriverTest.test_environment_optional_variables):
1057         * Scripts/webkitpy/port/xvfbdriver.py:
1058         (XvfbDriver._setup_environ_for_test):
1059         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1060         (XvfbDriverTest.assertDriverStartSuccessful):
1061
1062
1063 2017-05-14 Frederic Wang  <fwang@igalia.com>
1064
1065         Add heuristic to avoid flattening "fullscreen" iframes
1066         https://bugs.webkit.org/show_bug.cgi?id=171914
1067
1068         Reviewed by Simon Fraser.
1069
1070         * DumpRenderTree/mac/DumpRenderTree.mm:
1071         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
1072
1073 2017-06-18  Chris Dumez  <cdumez@apple.com>
1074
1075         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
1076         https://bugs.webkit.org/show_bug.cgi?id=173522
1077         <rdar://problem/31185739>
1078
1079         Reviewed by Darin Adler.
1080
1081         Add API test for re-entering Function's assignment operators.
1082
1083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1084         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
1085         (TestWebKitAPI::TestObject::TestObject):
1086         (TestWebKitAPI::TestObject::~TestObject):
1087         (TestWebKitAPI::TestObject::operator()):
1088         (TestWebKitAPI::TEST):
1089
1090 2017-06-16  Dan Bernstein  <mitz@apple.com>
1091
1092         [Cocoa] Some declarations have missing or incorrect availability attributes
1093         https://bugs.webkit.org/show_bug.cgi?id=173508
1094
1095         Reviewed by Tim Horton.
1096
1097         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
1098         (TestWebKitAPI::TEST): Updated for renames.
1099
1100 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1101
1102         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
1103         https://bugs.webkit.org/show_bug.cgi?id=173366
1104         <rdar://problem/32767014>
1105
1106         Reviewed by Tim Horton.
1107
1108         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
1109         change in behavior.
1110
1111         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1113         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
1114         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
1115         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
1116         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
1117         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
1118         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
1119         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
1120         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
1121         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
1122         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
1123         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
1124         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
1125         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1126         (-[MockDragDropSession initWithItems:location:window:]):
1127         (-[MockDragDropSession allowsMoveOperation]):
1128         (-[MockDragDropSession isRestrictedToDraggingApplication]):
1129         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
1130         (-[MockDragDropSession canLoadObjectsOfClass:]):
1131         (-[MockDragDropSession canLoadObjectsOfClasses:]):
1132         (-[MockDragDropSession items]):
1133         (-[MockDragDropSession setItems:]):
1134         (-[MockDragDropSession locationInView:]):
1135         (-[MockDataOperationSession initWithProviders:location:window:]):
1136         (-[MockDataOperationSession session]):
1137         (-[MockDataOperationSession isLocal]):
1138         (-[MockDataOperationSession progress]):
1139         (-[MockDataOperationSession setProgressIndicatorStyle:]):
1140         (-[MockDataOperationSession progressIndicatorStyle]):
1141         (-[MockDataOperationSession operationMask]):
1142         (-[MockDataOperationSession localDragSession]):
1143         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
1144         (-[MockDataOperationSession canCreateItemsOfClass:]):
1145         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
1146         (-[MockDataInteractionSession initWithWindow:]):
1147         (-[MockDataInteractionSession localOperationMask]):
1148         (-[MockDataInteractionSession externalOperationMask]):
1149         (-[MockDataInteractionSession session]):
1150         (-[DataInteractionSimulator _advanceProgress]):
1151
1152 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1153
1154         Show punycode to user if a URL has dotless i or j followed by diacritic dot
1155         https://bugs.webkit.org/show_bug.cgi?id=173431
1156
1157         Reviewed by Darin Adler.
1158
1159         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1160         (TestWebKitAPI::TEST):
1161
1162 2017-06-16  Chris Dumez  <cdumez@apple.com>
1163
1164         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
1165         https://bugs.webkit.org/show_bug.cgi?id=173472
1166         <rdar://problem/28858817>
1167
1168         Reviewed by Brady Eidson.
1169
1170         Add API test coverage.
1171
1172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1173         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
1174         (TEST):
1175
1176 2017-06-16  Brady Eidson  <beidson@apple.com>
1177
1178         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
1179         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
1180
1181         Reviewed by Daniel Bates.
1182
1183         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1184
1185 2017-06-16  Chris Dumez  <cdumez@apple.com>
1186
1187         DRT fails to reset page visibility between tests
1188         https://bugs.webkit.org/show_bug.cgi?id=173485
1189
1190         Reviewed by Alexey Proskuryakov.
1191
1192         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
1193         Fix this to address flakiness.
1194
1195         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
1196         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
1197         The test became flaky without the DRT change and was no longer flaky with the DRT
1198         change.
1199
1200         WebKitTestRunner already does this.
1201
1202         * DumpRenderTree/mac/DumpRenderTree.mm:
1203         (resetWebViewToConsistentStateBeforeTesting):
1204
1205 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1206
1207         Implement basic authentication in MiniBrowser
1208         https://bugs.webkit.org/show_bug.cgi?id=173443
1209
1210         Reviewed by Tim Horton.
1211
1212         * MiniBrowser/mac/WK2BrowserWindowController.m:
1213         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
1214
1215 2017-06-16  Jer Noble  <jer.noble@apple.com>
1216
1217         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1218         https://bugs.webkit.org/show_bug.cgi?id=173398
1219         <rdar://problem/32592961>
1220
1221         Reviewed by Eric Carlson.
1222
1223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1224         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1225         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1226         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1227         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1228         (TestWebKitAPI::TEST):
1229         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1230
1231 2017-06-16  Matt Lewis  <jlewis3@apple.com>
1232
1233         Unreviewed, rolling out r218375.
1234
1235         The API test MediaStreamTrackDetached is still timing out
1236         after the patch
1237
1238         Reverted changeset:
1239
1240         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1241         reports no recording to WebKit clients"
1242         https://bugs.webkit.org/show_bug.cgi?id=173398
1243         http://trac.webkit.org/changeset/218375
1244
1245 2017-06-15  Jer Noble  <jer.noble@apple.com>
1246
1247         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1248         https://bugs.webkit.org/show_bug.cgi?id=173398
1249         <rdar://problem/32592961>
1250
1251         Reviewed by Eric Carlson.
1252
1253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1254         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1255         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1256         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1257         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1258         (TestWebKitAPI::TEST):
1259         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1260
1261 2017-06-15  Matt Lewis  <jlewis3@apple.com>
1262
1263         Unreviewed, rolling out r218365.
1264
1265         The revision caused API timeouts on all builds.
1266
1267         Reverted changeset:
1268
1269         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1270         reports no recording to WebKit clients"
1271         https://bugs.webkit.org/show_bug.cgi?id=173398
1272         http://trac.webkit.org/changeset/218365
1273
1274 2017-06-15  Jer Noble  <jer.noble@apple.com>
1275
1276         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1277         https://bugs.webkit.org/show_bug.cgi?id=173398
1278         <rdar://problem/32592961>
1279
1280         Reviewed by Eric Carlson.
1281
1282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1283         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1284         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1285         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1286         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1287         (TestWebKitAPI::TEST):
1288         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1289
1290 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1291
1292         REGRESSION(r218344): [WPE] Thousands of layout test crashes
1293         https://bugs.webkit.org/show_bug.cgi?id=173433
1294
1295         Unreviewed.
1296
1297         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
1298
1299 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1300
1301         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
1302         https://bugs.webkit.org/show_bug.cgi?id=173061
1303
1304         Reviewed by Žan Doberšek.
1305
1306         Launch dyz <https://github.com/Igalia/dyz> with the script
1307         run-minibrowser for the wpe port. It is now built as part of the
1308         WPE dependencies with JHBuild.
1309
1310         * Scripts/run-minibrowser:
1311         * Scripts/webkitdirs.pm:
1312         (launcherPath):
1313         (launcherName):
1314         * wpe/install-dependencies: Luajit is needed for building dyz.
1315         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
1316
1317 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1318
1319         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
1320         https://bugs.webkit.org/show_bug.cgi?id=173338
1321         <rdar://problem/32777720>
1322
1323         Reviewed by Tim Horton.
1324
1325         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
1326         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
1327         these remaining items on drop.
1328
1329         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1330         (TestWebKitAPI::TEST):
1331         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1332         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1333
1334         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
1335
1336         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
1337
1338 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
1339
1340         [Win] Crash in accessibility layout test.
1341         https://bugs.webkit.org/show_bug.cgi?id=173401
1342
1343         Reviewed by Brent Fulgham.
1344
1345         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
1346         member will be automatically released when the _variant_t object goes out of scope if the vt member
1347         does not equal VT_UNKNOWN | VT_BYREF.
1348         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
1349
1350         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1351         (AccessibilityUIElement::titleUIElement):
1352
1353 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1354
1355         [GTK] Add API to allow overriding popup menus
1356         https://bugs.webkit.org/show_bug.cgi?id=172905
1357
1358         Reviewed by Michael Catanzaro.
1359
1360         Add a unit test to check the new API.
1361
1362         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1363         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
1364         (OptionMenuTest::OptionMenuTest):
1365         (OptionMenuTest::~OptionMenuTest):
1366         (OptionMenuTest::destroyMenu):
1367         (OptionMenuTest::showOptionMenuCallback):
1368         (OptionMenuTest::menuCloseCallback):
1369         (OptionMenuTest::showOptionMenu):
1370         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
1371         (OptionMenuTest::close):
1372         (OptionMenuTest::activateItem):
1373         (OptionMenuTest::selectItem):
1374         (testOptionMenuSimple):
1375         (testOptionMenuGroups):
1376         (testOptionMenuActivate):
1377         (testOptionMenuSelect):
1378         (beforeAll):
1379         (afterAll):
1380
1381 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1382
1383         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
1384         https://bugs.webkit.org/show_bug.cgi?id=173399
1385
1386         Reviewed by Per Arne Vollan.
1387
1388         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
1389         Curl port needs to do nothing because libcurl doesn't have disk cache.
1390
1391         * DumpRenderTree/win/DumpRenderTree.cpp:
1392         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
1393         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
1394
1395 2017-06-14  Tomas Popela  <tpopela@redhat.com>
1396
1397         [GTK] integer expression expected if running Tools/gtk/install-dependencies
1398         https://bugs.webkit.org/show_bug.cgi?id=173356
1399
1400         Reviewed by Michael Catanzaro.
1401
1402         Use the correct operator to compare the strings.
1403
1404         * gtk/install-dependencies:
1405
1406 2017-06-14  Commit Queue  <commit-queue@webkit.org>
1407
1408         Unreviewed, rolling out r218285.
1409         https://bugs.webkit.org/show_bug.cgi?id=173391
1410
1411         API test fails on iOS (Requested by alexchristensen on
1412         #webkit).
1413
1414         Reverted changeset:
1415
1416         "Add SPI for immediate injection of user scripts"
1417         https://bugs.webkit.org/show_bug.cgi?id=173342
1418         http://trac.webkit.org/changeset/218285
1419
1420 2017-06-14  Chris Dumez  <cdumez@apple.com>
1421
1422         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
1423         https://bugs.webkit.org/show_bug.cgi?id=173384
1424         <rdar://problem/32723779>
1425
1426         Reviewed by Dan Bernstein.
1427
1428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1429         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
1430         Add API test coverage.
1431
1432         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1433         (TestWebKitAPI::Util::sleep):
1434         Update implementation of Util::sleep() so that we actually run the run loop.
1435         Otherwise, we don't process events while sleeping.
1436
1437 2017-06-14  Alex Christensen  <achristensen@webkit.org>
1438
1439         Add SPI for immediate injection of user scripts
1440         https://bugs.webkit.org/show_bug.cgi?id=173342
1441         <rdar://problem/29202285>
1442
1443         Reviewed by Brady Eidson.
1444
1445         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1446         (waitForMessage):
1447         (TEST):
1448
1449 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
1450
1451         Add WPE to the flakiness dashboard
1452         https://bugs.webkit.org/show_bug.cgi?id=173365
1453
1454         Reviewed by Carlos Alberto Lopez Perez.
1455
1456         * TestResultServer/static-dashboards/builders.jsonp:
1457         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1458         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1459         (resetGlobals):
1460         * TestResultServer/static-dashboards/loader_unittests.js:
1461
1462 2017-06-14  Brady Eidson  <beidson@apple.com>
1463
1464         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
1465         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
1466
1467         Reviewed by Alex Christensen.
1468
1469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1470         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
1471         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
1472         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
1473         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
1474         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
1475         (TEST):
1476
1477 2017-06-14  Tim Horton  <timothy_horton@apple.com>
1478
1479         WKContentViewEditingActions API test always fails
1480         https://bugs.webkit.org/show_bug.cgi?id=173374
1481
1482         Reviewed by Wenson Hsieh.
1483
1484         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
1485         (TEST):
1486         selectAll isn't working, because canPerformAction for selectAll returns NO
1487         if selectionIsNone (which is true in the non-contenteditable case).
1488         Instead, make use of r218180's test page, which knows how to select itself.
1489         Also, reset the pasteboard at the beginning of the test to reduce confusion
1490         (I landed the test broken because my simulator had the correct text
1491         stuck in its pasteboard).
1492
1493 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
1494
1495         Configure screen scale for running layout tests on plus devices
1496         https://bugs.webkit.org/show_bug.cgi?id=173319
1497
1498         Reviewed by Tim Horton.
1499
1500         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1501         * DumpRenderTree/mac/DumpRenderTree.mm:
1502         (dumpRenderTree): Set screen scale to 2.0.
1503         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
1504         add _setScale for UIScreen.
1505         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1506         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1507         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
1508         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
1509         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
1510         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
1511         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
1512         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
1513         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1514         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
1515
1516 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
1517
1518         Add iOS 11 support to the bot watcher's dashboard
1519         https://bugs.webkit.org/show_bug.cgi?id=173369
1520
1521         Reviewed by Lucas Forschler.
1522
1523         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
1524         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
1525         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
1526         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
1527         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1528         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1529
1530 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1531
1532         [GTK][WPE] Raise the timeout values for layout tests
1533         https://bugs.webkit.org/show_bug.cgi?id=173368
1534
1535         Reviewed by Carlos Garcia Campos.
1536
1537         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
1538         When running under valgrind a 10x multiplier is applied.
1539
1540         * Scripts/webkitpy/port/gtk.py:
1541         (GtkPort.default_timeout_ms):
1542         * Scripts/webkitpy/port/gtk_unittest.py:
1543         (GtkPortTest.test_default_timeout_ms):
1544         * Scripts/webkitpy/port/wpe.py:
1545         (WPEPort.default_timeout_ms):
1546         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
1547         (WPEPortTest):
1548         (WPEPortTest.make_port):
1549         (WPEPortTest.test_default_timeout_ms):
1550         (WPEPortTest.test_get_crash_log):
1551
1552 2017-06-14  Alex Christensen  <achristensen@webkit.org>
1553
1554         Test persistent WKHTTPCookieStorages on iOS.
1555         https://bugs.webkit.org/show_bug.cgi?id=173284
1556
1557         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1558         (TEST):
1559         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
1560
1561 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
1562
1563         [Win] DRT should not use disk cache.
1564         https://bugs.webkit.org/show_bug.cgi?id=173361
1565
1566         Reviewed by Darin Adler.
1567
1568         Like on macOS/iOS, DRT on Windows should only use memory cache.
1569
1570         * DumpRenderTree/win/DumpRenderTree.cpp:
1571         (setDefaultsToConsistentValuesForTesting):
1572         (prepareConsistentTestingEnvironment):
1573
1574 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
1575
1576         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
1577         https://bugs.webkit.org/show_bug.cgi?id=171668
1578
1579         Reviewed by Jer Noble.
1580
1581         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
1582         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
1583         Infinity when the double value passed as argument is greater than 2^64.
1584
1585         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
1586         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
1587         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
1588         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
1589         method. No behavior change for rational MediaTime.
1590
1591         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
1592         (TestWebKitAPI::TEST):
1593
1594 2017-06-13  Alex Christensen  <achristensen@webkit.org>
1595
1596         Test persistent WKHTTPCookieStorages on iOS
1597         https://bugs.webkit.org/show_bug.cgi?id=173284
1598         <rdar://problem/32260156>
1599
1600         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1601         (TEST):
1602
1603 2017-06-13  Matt Rajca  <mrajca@apple.com>
1604
1605         WebsitePolicies: let clients select specific autoplay quirks
1606         https://bugs.webkit.org/show_bug.cgi?id=173343
1607
1608         Reviewed by Alex Christensen.
1609
1610         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1611         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1612         (TEST): Updated tests.
1613
1614 2017-06-13  Daniel Bates  <dabates@apple.com>
1615
1616         Implement W3C Secure Contexts Draft Specification
1617         https://bugs.webkit.org/show_bug.cgi?id=158121
1618         <rdar://problem/26012994>
1619
1620         Reviewed by Brent Fulgham.
1621
1622         Part 4
1623
1624         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
1625         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
1626         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
1627
1628         * DumpRenderTree/TestOptions.h:
1629         * DumpRenderTree/TestOptions.mm:
1630         (TestOptions::TestOptions):
1631         * DumpRenderTree/mac/DumpRenderTree.mm:
1632         (setWebPreferencesForTestOptions):
1633         * DumpRenderTree/win/DumpRenderTree.cpp:
1634         (enableExperimentalFeatures):
1635         * WebKitTestRunner/TestController.cpp:
1636         (WTR::TestController::resetPreferencesToConsistentValues):
1637         (WTR::updateTestOptionsFromTestHeader):
1638         * WebKitTestRunner/TestOptions.h:
1639         (WTR::TestOptions::hasSameInitializationOptions):
1640
1641 2017-06-13  Alex Christensen  <achristensen@webkit.org>
1642
1643         Test persistent WKHTTPCookieStorages on iOS
1644         https://bugs.webkit.org/show_bug.cgi?id=173284
1645         <rdar://problem/32260156>
1646
1647         Reviewed by Alexey Proskuryakov.
1648
1649         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1650         (TEST):
1651
1652 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1653
1654         [GTK] Blob download doesn't work
1655         https://bugs.webkit.org/show_bug.cgi?id=172442
1656
1657         Reviewed by Carlos Alberto Lopez Perez.
1658
1659         Add a unit test to check blob downloads.
1660
1661         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1662         (testBlobDownload):
1663         (beforeAll):
1664
1665 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1666
1667         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
1668         https://bugs.webkit.org/show_bug.cgi?id=173316
1669
1670         Reviewed by Alex Christensen.
1671
1672         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
1673
1674         * gtk/manifest.txt.in:
1675
1676 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1677
1678         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
1679         https://bugs.webkit.org/show_bug.cgi?id=173315
1680
1681         Reviewed by Darin Adler.
1682
1683         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
1684         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
1685         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
1686         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
1687         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
1688         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
1689         WKGeolocationManagerRef is not destroyed.
1690
1691         * WebKitTestRunner/GeolocationProviderMock.cpp:
1692         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1693         * WebKitTestRunner/GeolocationProviderMock.h:
1694
1695 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1696
1697         Unable to paste text that was copied from a page into the universal search field
1698         https://bugs.webkit.org/show_bug.cgi?id=173293
1699         <rdar://problem/32440918>
1700
1701         Reviewed by Ryosuke Niwa.
1702
1703         Adds 2 new unit tests for copying plain and rich selected web content.
1704         See WebCore and WebKit ChangeLogs for more detail.
1705
1706         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1707         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
1708         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
1709         (TestWebKitAPI::dataForPasteboardType):
1710         (TestWebKitAPI::setUpWebViewForPasteboardTests):
1711         (TestWebKitAPI::TEST):
1712
1713 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
1714
1715         AX: [ATK] Implement missing AtkRelation types
1716         https://bugs.webkit.org/show_bug.cgi?id=155494
1717
1718         Reviewed by Darin Adler.
1719
1720         Add additional methods to test ARIA properties which are exposed via
1721         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
1722
1723         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1724         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
1725         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
1726         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
1727         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
1728         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
1729         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
1730         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
1731         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1732         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1733         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1734         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
1735         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
1736         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
1737         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
1738         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
1739         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
1740         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
1741
1742 2017-06-12  Daniel Bates  <dabates@apple.com>
1743
1744         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
1745         https://bugs.webkit.org/show_bug.cgi?id=173286
1746         <rdar://problem/32726102>
1747
1748         Reviewed by Brent Fulgham.
1749
1750         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1751         (TestWebKitAPI::TEST_F):
1752
1753 2017-06-12  Lucas Forschler  <lforschler@apple.com>
1754
1755         <rdar://problem/32683422>
1756         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
1757
1758         Reviewed by Conrad Schultz.
1759
1760         * Scripts/copy-webkitlibraries-to-product-directory:
1761
1762 2017-06-12  Tim Horton  <timothy_horton@apple.com>
1763
1764         [iOS] Cmd-C doesn't copy text from WKWebView
1765         https://bugs.webkit.org/show_bug.cgi?id=173277
1766         <rdar://problem/32396742>
1767
1768         Reviewed by Dan Bernstein.
1769
1770         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1771         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
1772         Add a test ensuring that -copy on WKContentView will cause text to be copied.
1773
1774 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
1775
1776         [WebCrypto] Remove experimental feature flag of SubtleCrypto
1777         https://bugs.webkit.org/show_bug.cgi?id=173197
1778         <rdar://problem/32688148>
1779
1780         Reviewed by Brent Fulgham.
1781
1782         * DumpRenderTree/mac/DumpRenderTree.mm:
1783         (enableExperimentalFeatures):
1784         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1785         (WTR::InjectedBundle::beginTesting):
1786         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1787         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
1788         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1789
1790 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1791
1792         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
1793         https://bugs.webkit.org/show_bug.cgi?id=173238
1794         <rdar://problem/31943370>
1795
1796         Reviewed by Ryosuke Niwa and Tim Horton.
1797
1798         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
1799         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
1800         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
1801
1802         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1803         (TestWebKitAPI::TEST):
1804         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1805         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1806         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
1807         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
1808
1809 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1810
1811         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
1812         https://bugs.webkit.org/show_bug.cgi?id=173225
1813         <rdar://problem/32713144>
1814
1815         Reviewed by Tim Horton.
1816
1817         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
1818         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
1819
1820         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1821         (TestWebKitAPI::TEST):
1822
1823 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
1824
1825         Return correct process names for iOS on-device testing
1826         https://bugs.webkit.org/show_bug.cgi?id=173263
1827
1828         Reviewed by Alex Christensen.
1829
1830         When running tests on iOS devices, process names do not end with '.Development'
1831         as they do on Mac and iOS simulator.
1832
1833         * WebKitTestRunner/TestController.cpp:
1834         (WTR::TestController::webProcessName): Return correct process name without '.Development'
1835         for iOS on-device testing.
1836         (WTR::TestController::networkProcessName): Ditto.
1837         (WTR::TestController::databaseProcessName): Ditto.
1838
1839 2017-06-12  Chris Dumez  <cdumez@apple.com>
1840
1841         Regression(r217867): Legacy SessionHistoryEntryData format should not change
1842         https://bugs.webkit.org/show_bug.cgi?id=173267
1843         <rdar://problem/32701257>
1844
1845         Reviewed by Simon Fraser.
1846
1847         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
1848         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
1849         though as this covers the crash that r217867 was fixing.
1850
1851         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
1852         (TestWebKitAPI::createSessionStateData):
1853         (TestWebKitAPI::TEST):
1854         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
1855
1856 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1857
1858         [GTK] Stop dismissing menus attached to the web view for every injected event
1859         https://bugs.webkit.org/show_bug.cgi?id=172708
1860
1861         Reviewed by Alex Christensen.
1862
1863         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
1864         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
1865         events while the menu is open.
1866
1867         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1868         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
1869         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1870         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
1871
1872 2017-06-12  Miguel Gomez  <magomez@igalia.com>
1873
1874         [GTK][WPE] Enable GStreamer GL on development builds
1875         https://bugs.webkit.org/show_bug.cgi?id=173248
1876
1877         Enable GStreamer GL for GTK and WPE.
1878
1879         Reviewed by Carlos Garcia Campos.
1880
1881         * Scripts/webkitperl/FeatureList.pm:
1882
1883 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1884
1885         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
1886
1887         Notifications are no longer cleared on page navigation.
1888
1889         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1890         (testWebViewNotification):
1891
1892 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1893
1894         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
1895
1896         DBus interface and object path names were updated in r217831.
1897
1898         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
1899
1900 2017-06-10  Dan Bernstein  <mitz@apple.com>
1901
1902         Reverted r218056 because it made the IDE reindex constantly.
1903
1904         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1905         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1906         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1907         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1908         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
1909         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1910         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1911         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1912
1913 2017-06-10  Dan Bernstein  <mitz@apple.com>
1914
1915         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
1916         https://bugs.webkit.org/show_bug.cgi?id=173223
1917
1918         Reviewed by Sam Weinig.
1919
1920         The rebuilds were happening due to a difference in the compiler options that the IDE and
1921         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
1922         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
1923         specify an appropriate path in CLANG_INDEX_STORE_PATH.
1924
1925         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1926         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1927         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1928         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1929         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
1930         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1931         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1932         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1933
1934 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
1935
1936         webkitpy: Reduce polling in ServerProcess
1937         https://bugs.webkit.org/show_bug.cgi?id=173116
1938
1939         Reviewed by Ryosuke Niwa.
1940
1941         We should be smarter about polling. We do not need to poll every time a line is read from
1942         stdout and stderr since lines are usually read from cached data. We should only poll
1943         when extracting that cached data from stdout and stderr.
1944
1945         * Scripts/webkitpy/port/driver.py:
1946         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
1947         and on ServerProcess to poll the process if not data is available in stdout and stderr.
1948         * Scripts/webkitpy/port/driver_unittest.py:
1949         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
1950         ServerProcess.
1951         * Scripts/webkitpy/port/server_process.py:
1952         (ServerProcess._read): Allow for data to be read from _output even if the process has
1953         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
1954         * Scripts/webkitpy/port/server_process_mock.py:
1955         (MockServerProcess): Add number_of_times_polled.
1956         (MockServerProcess.poll): Increment number_of_times_polled.
1957         (MockServerProcess.has_crashed): Poll before returning crash state.
1958         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
1959         just like a ServerProcess would.
1960         (MockServerProcess.read_stdout): Ditto.
1961         * Scripts/webkitpy/port/server_process_unittest.py:
1962         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
1963         process from ending before stdout and stderr are read. This is the reason this test was flakey.
1964         (TestServerProcess):
1965         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
1966         the processes is polled.
1967         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
1968         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
1969
1970 2017-06-10  Andy Estes  <aestes@apple.com>
1971
1972         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
1973         https://bugs.webkit.org/show_bug.cgi?id=173190
1974         <rdar://problem/31360659>
1975
1976         Reviewed by Brady Eidson.
1977         
1978         Added a release assert that tries to create a proper test failure if the web process crashes.
1979
1980         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1981         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
1982
1983 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1984
1985         [iOS DnD] Add a hook to perform two-step drops in editable content
1986         https://bugs.webkit.org/show_bug.cgi?id=172992
1987         <rdar://problem/32590174>
1988
1989         Reviewed by Tim Horton.
1990
1991         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
1992         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
1993                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
1994
1995         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
1996         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1997         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
1998
1999         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
2000         be overridden. Currently, this is overridden to just return true.
2001
2002         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2003         (TestWebKitAPI::TEST):
2004         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2005         (WTR::InjectedBundlePage::InjectedBundlePage):
2006
2007 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2008
2009         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
2010         https://bugs.webkit.org/show_bug.cgi?id=173103
2011
2012         Reviewed by Xabier Rodriguez-Calvar.
2013
2014         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
2015         when building the WPE port through build-webkit.
2016
2017 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2018
2019         [WPE] Enable MEDIA_SOURCE for build-webkit builds
2020         https://bugs.webkit.org/show_bug.cgi?id=173136
2021
2022         Reviewed by Xabier Rodriguez-Calvar.
2023
2024         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
2025
2026 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2027
2028         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
2029         https://bugs.webkit.org/show_bug.cgi?id=173098
2030
2031         Reviewed by Žan Doberšek.
2032
2033         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
2034         assuming that all tests containing forms define ids for the form elements like
2035         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
2036
2037         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2038         (formControlsAssociatedCallback):
2039
2040 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
2041
2042         webkitpy: Run sample/spindump on iOS devices
2043         https://bugs.webkit.org/show_bug.cgi?id=171881
2044         <rdar://problem/32084602>
2045
2046         Reviewed by Daniel Bates.
2047
2048         * Scripts/webkitpy/port/darwin.py:
2049         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
2050         requires sudo to run spindump.
2051         * Scripts/webkitpy/port/ios_device.py:
2052         (IOSDevicePort.look_for_new_samples): Deleted.
2053         (IOSDevicePort.sample_process): Deleted.
2054         * Scripts/webkitpy/port/ios_device_unittest.py:
2055         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
2056         (IOSDeviceTest.test_spindump):
2057         (IOSDeviceTest.test_sample_process):
2058         (IOSDeviceTest.test_sample_process_exception):
2059         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2060         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
2061
2062 2017-06-08  Keith Miller  <keith_miller@apple.com>
2063
2064         WebAssembly: We should only create wrappers for functions that can be exported
2065         https://bugs.webkit.org/show_bug.cgi?id=173088
2066
2067         Reviewed by Saam Barati.
2068
2069         Add quick mode for wasm tests.
2070
2071         * Scripts/run-jsc-stress-tests:
2072
2073 2017-06-08  Darin Adler  <darin@apple.com>
2074
2075         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
2076         https://bugs.webkit.org/show_bug.cgi?id=173106
2077
2078         Reviewed by Sam Weinig.
2079
2080         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
2081         destroyed last.
2082         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
2083         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
2084
2085 2017-06-07  Dan Bernstein  <mitz@apple.com>
2086
2087         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
2088         https://bugs.webkit.org/show_bug.cgi?id=173086
2089
2090         Reviewed by Andy Estes.
2091
2092         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2093         (TEST):
2094
2095 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
2096
2097         Add High Sierra support to WebKit tools
2098         https://bugs.webkit.org/show_bug.cgi?id=173080
2099
2100         Rubber-stamped by Daniel Bates.
2101
2102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
2103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
2104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2105         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2106         Added dashboard support.
2107
2108         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2109         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2110         Trigger the right build queues on check-in.
2111
2112         * Scripts/webkitpy/common/system/platforminfo.py:
2113         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2114         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2115         * Scripts/webkitpy/port/mac.py:
2116         * Scripts/webkitpy/port/mac_unittest.py:
2117         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2118         Added cases for Sierra, and updated tests for new baseline search paths.
2119
2120 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
2121
2122         Unreviewed, rolling out r217902.
2123
2124         This change appears to have caused imported/w3c/web-platform-
2125         tests/fetch/api/cors tests to fail on El Capitan.
2126
2127         Reverted changeset:
2128
2129         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
2130         https://bugs.webkit.org/show_bug.cgi?id=172930
2131         http://trac.webkit.org/changeset/217902
2132
2133 2017-06-07  Daniel Bates  <dabates@apple.com>
2134
2135         Teach run-webkit-tests how to run HTTPS Web Platform Tests
2136         https://bugs.webkit.org/show_bug.cgi?id=172930
2137         <rdar://problem/32570201>
2138
2139         Reviewed by Youenn Fablet.
2140
2141         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
2142         that is conditioned on the page being delivered over a secure protocol. One example of such
2143         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
2144
2145         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
2146         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
2147         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
2148
2149         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2150         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
2151         to the Web Platform Tests HTTPS server.
2152         * Scripts/webkitpy/port/base.py:
2153         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
2154         * Scripts/webkitpy/port/driver.py:
2155         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
2156         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
2157         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
2158         indicate that they should be considered private instance variables.
2159         (Driver.is_web_platform_test): Update code for renamed instance variables.
2160         (Driver):
2161         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
2162         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
2163         determine the base URL to use to access the test.
2164         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
2165         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
2166
2167 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
2168
2169         Support removal of authentication data through the Website data store API.
2170         https://bugs.webkit.org/show_bug.cgi?id=171217
2171
2172         Reviewed by Brady Eidson.
2173
2174         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2175         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2176         (WTR::InjectedBundle::didReceiveMessageToPage):
2177         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2178         (WTR::TestRunner::removeAllSessionCredentials):
2179         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
2180         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2181         * WebKitTestRunner/TestController.h:
2182         * WebKitTestRunner/TestInvocation.cpp:
2183         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2184         (WTR::TestInvocation::didRemoveAllSessionCredentials):
2185         * WebKitTestRunner/TestInvocation.h:
2186         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2187         (WTR::TestController::removeAllSessionCredentials):
2188
2189 2017-06-07  Charlie Turner  <cturner@igalia.com>
2190
2191         Add Charlie Turner as contributor
2192         https://bugs.webkit.org/show_bug.cgi?id=173055
2193
2194         Reviewed by Carlos Alberto Lopez Perez.
2195
2196         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
2197         of webkit-patch upload, which reordered some fields and removed a newline.
2198
2199         * Scripts/webkitpy/common/config/contributors.json:
2200
2201 2017-06-06  Chris Dumez  <cdumez@apple.com>
2202
2203         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
2204         https://bugs.webkit.org/show_bug.cgi?id=173033
2205         <rdar://problem/32591099>
2206
2207         Reviewed by Simon Fraser.
2208
2209         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
2210         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
2211
2212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2213         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
2214         (TestWebKitAPI::didFinishLoadForFrame):
2215         (TestWebKitAPI::setPageLoaderClient):
2216         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
2217         (TestWebKitAPI::TEST):
2218
2219 2017-06-06  Andy Estes  <aestes@apple.com>
2220
2221         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
2222         https://bugs.webkit.org/show_bug.cgi?id=172849
2223         <rdar://problem/32567454>
2224
2225         Reviewed by Darin Adler.
2226
2227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2228         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
2229         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2230         (TestWebKitAPI::TEST):
2231
2232 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
2233
2234         [preload] Conditional support for media preloading and align media `as` values.
2235         https://bugs.webkit.org/show_bug.cgi?id=172501
2236
2237         Reviewed by Dean Jackson.
2238
2239         Turn on media preloading preference for tests.
2240
2241         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
2242         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
2243         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
2244
2245 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2246
2247         webkitpy: Return correct process names from SimulatorProcess
2248         https://bugs.webkit.org/show_bug.cgi?id=172940
2249
2250         Reviewed by Aakash Jain.
2251
2252         * Scripts/webkitpy/port/darwin.py:
2253         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
2254         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
2255         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
2256         * Scripts/webkitpy/port/driver.py:
2257         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
2258         _server_process.name() will not return the correct process name for iOS.
2259         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
2260         (Driver._read_block): Ditto.
2261         * Scripts/webkitpy/port/driver_unittest.py:
2262         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
2263         process_name() instead of name().
2264         * Scripts/webkitpy/port/server_process.py:
2265         (ServerProcess._start): Use process_name() instead of name().
2266         (ServerProcess.stop): Ditto.
2267         (ServerProcess.name): Deleted.
2268         * Scripts/webkitpy/port/simulator_process.py:
2269         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2270
2271 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
2272
2273         test-webkitpy: stop forking unsafely from within a spawned process
2274         https://bugs.webkit.org/show_bug.cgi?id=172774
2275
2276         Reviewed by Darin Adler.
2277
2278         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2279         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
2280         it's going to be used.
2281         (Builder.force_build):
2282
2283 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2284
2285         webkitpy: Process crash-logs for iOS devices
2286         https://bugs.webkit.org/show_bug.cgi?id=171976
2287         <rdar://problem/32134551>
2288
2289         Reviewed by David Kilzer.
2290
2291         When running layout tests on an iOS device, crash logs should be processed.
2292         Implement crash log searching and parsing for iOS devices.
2293
2294         * Scripts/webkitpy/common/system/crashlogs.py:
2295         (CrashLogs): Moved process regular expression for Darwin to class variable.
2296         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
2297         (CrashLogs.find_newest_log): Add iOS as a potential platform.
2298         (CrashLogs.find_all_logs): Ditto.
2299         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
2300         Do not assume that a Darwin crash log starts with the process.
2301         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
2302         shared code for parsing Darwin crash logs.
2303         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
2304         object so that crash logs already on the system before testing are not parsed.
2305         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
2306         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
2307         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
2308         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2309         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
2310         * Scripts/webkitpy/common/system/systemhost.py:
2311         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2312         systems is just the crashlog, use this behavior by default.
2313         * Scripts/webkitpy/common/system/systemhost_mock.py:
2314         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2315         systems is just the crashlog, use this behavior by default.
2316         * Scripts/webkitpy/port/apple.py:
2317         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
2318         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
2319         the system before testing begins
2320         * Scripts/webkitpy/port/base.py:
2321         (Port._get_crash_log): Pass optional target host when getting crash logs.
2322         * Scripts/webkitpy/port/darwin.py:
2323         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
2324         CrashLogs object.
2325         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2326         logs to be skipped to CrashLogs object.
2327         * Scripts/webkitpy/port/darwin_testcase.py:
2328         (DarwinTest.test_get_crash_log): Removed unused local function.
2329         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
2330         * Scripts/webkitpy/port/device.py:
2331         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
2332         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
2333         * Scripts/webkitpy/port/driver.py:
2334         (Driver._get_crash_log): Pass optional target host when getting crash logs.
2335         * Scripts/webkitpy/port/gtk.py:
2336         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
2337         * Scripts/webkitpy/port/ios.py: Ditto.
2338         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
2339         to be skipped for each host.
2340         * Scripts/webkitpy/port/ios_device.py:
2341         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
2342         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
2343         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
2344         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
2345         host is specified. Else, search all connected devices for the specified crash-log.
2346         (IOSDevicePort.look_for_new_crash_logs): Deleted.
2347         * Scripts/webkitpy/port/ios_device_unittest.py:
2348         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
2349         (IOSDeviceTest.test_get_crash_log): Ditto.
2350         * Scripts/webkitpy/port/simulator_process.py:
2351         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2352         * Scripts/webkitpy/port/win.py:
2353         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2354         logs to be skipped to CrashLogs object.
2355         * Scripts/webkitpy/port/wpe.py:
2356         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
2357
2358 2017-06-06  David Kilzer  <ddkilzer@apple.com>
2359
2360         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
2361         <https://webkit.org/b/172804>
2362
2363         Reviewed by Darin Adler.
2364
2365         WTF_ATTRIBUTE_PRINTF() only works outside the current
2366         compilation unit if it's on the declaration, not the
2367         implementation, of a function or class method.
2368
2369         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2370         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2371         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2372         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2373         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
2374         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2375         - Remove redundant CRASH() macro definition.  Use the one from
2376           <wtf/Assertions.h> instead.
2377
2378 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
2379
2380         Move Resource Timing / User Timing from experimental features into main preferences
2381         https://bugs.webkit.org/show_bug.cgi?id=172950
2382
2383         Reviewed by Darin Adler.
2384
2385         * DumpRenderTree/mac/DumpRenderTree.mm:
2386         (enableExperimentalFeatures):
2387         (resetWebPreferencesToConsistentValues):
2388         * DumpRenderTree/win/DumpRenderTree.cpp:
2389         (enableExperimentalFeatures):
2390         (resetWebPreferencesToConsistentValues):
2391         * WebKitTestRunner/TestController.cpp:
2392         (WTR::TestController::resetPreferencesToConsistentValues):
2393         Move out no longer experimental features to the main list.
2394
2395 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2396
2397         [WPE] Add an install-dependencies script
2398         https://bugs.webkit.org/show_bug.cgi?id=172948
2399
2400         Reviewed by Žan Doberšek.
2401
2402         It is based on the gtk/install-dependencies script.
2403         Includes support for Debian based distrubutions, Fedora and Arch.
2404         It has been tested on a minimal Debian 9 chroot.
2405
2406         * wpe/install-dependencies: Added.
2407
2408 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2409
2410         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
2411         https://bugs.webkit.org/show_bug.cgi?id=172891
2412         <rdar://problem/32204540>
2413
2414         Reviewed by Darin Adler.
2415
2416         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
2417         contenteditable. See WebCore ChangeLog for more details.
2418
2419         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2420         (TestWebKitAPI::TEST):
2421
2422 2017-06-05  Daniel Bates  <dabates@apple.com>
2423
2424         webkitpy: Abstract Executive class
2425         https://bugs.webkit.org/show_bug.cgi?id=172928
2426         <rdar://problem/32569531>
2427
2428         Reviewed by Ryosuke Niwa.
2429
2430         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
2431         This will make it straightforward to create additional derived classes that
2432         adhere to the same interface, say for iOS on-device testing.
2433
2434         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
2435         (AbstractExecutive):
2436         (AbstractExecutive.run_and_throw_if_fail):
2437         (AbstractExecutive.cpu_count):
2438         (AbstractExecutive.interpreter_for_script):
2439         (AbstractExecutive.shell_command_for_script):
2440         (AbstractExecutive.kill_process):
2441         (AbstractExecutive.check_running_pid):
2442         (AbstractExecutive.running_pids):
2443         (AbstractExecutive.wait_newest):
2444         (AbstractExecutive.wait_limited):
2445         (AbstractExecutive.interrupt):
2446         (AbstractExecutive.default_error_handler):
2447         (AbstractExecutive.ignore_error):
2448         (AbstractExecutive._stringify_args):
2449         (AbstractExecutive.command_for_printing):
2450         (AbstractExecutive.run_command):
2451         (AbstractExecutive.popen):
2452         (AbstractExecutive.run_in_parallel):
2453         * Scripts/webkitpy/common/system/executive.py:
2454         (Executive):
2455         (Executive.cpu_count):
2456         (Executive.running_pids):
2457         (Executive.kill_all):
2458         (Executive._compute_stdin):
2459         (Executive.interpreter_for_script): Deleted.
2460         (Executive.shell_command_for_script): Deleted.
2461         (Executive.wait_newest): Deleted.
2462         (Executive.wait_limited): Deleted.
2463         (Executive.default_error_handler): Deleted.
2464         (Executive.ignore_error): Deleted.
2465         (Executive.command_for_printing): Deleted.
2466
2467 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
2468
2469         webkitpy: Add iOS to platform
2470         https://bugs.webkit.org/show_bug.cgi?id=172931
2471
2472         Reviewed by Daniel Bates.
2473
2474         * Scripts/webkitpy/common/system/platforminfo.py:
2475         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
2476         (PlatformInfo.is_ios): Added.
2477         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
2478         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2479         (MockPlatformInfo.is_ios): Added.
2480
2481 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2482
2483         [WPE][JHBuild] Switch github repository from git:// to https://
2484         https://bugs.webkit.org/show_bug.cgi?id=172921
2485
2486         Reviewed by Alex Christensen.
2487
2488         * wpe/jhbuild.modules:
2489
2490 2017-06-05  Tim Horton  <timothy_horton@apple.com>
2491
2492         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
2493         https://bugs.webkit.org/show_bug.cgi?id=172887
2494         <rdar://problem/32546061>
2495
2496         Reviewed by Sam Weinig.
2497
2498         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2499         (WTR::UIScriptController::applyAutocorrection):
2500         applyAutocorrection can call its completion handler synchronously,
2501         which makes UIScriptController unhappy (see bug 172884).
2502
2503 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
2504
2505         webkitpy: Add contextmanager to disable logging for a block
2506         https://bugs.webkit.org/show_bug.cgi?id=172876
2507
2508         Reviewed by Daniel Bates.
2509
2510         Add a context manager which will use an OutputCapture object to capture logging
2511         in a block and hold it in a variable.
2512
2513         * Scripts/webkitpy/common/system/outputcapture.py:
2514         (OutputCaptureScope):
2515         (OutputCaptureScope.__init__): Construct with OutputCapture object.
2516         (OutputCaptureScope.__enter__): Begin capturing output. 
2517         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
2518         output and retain the resulting log.
2519         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2520         (OutputCaptureTest.test_output_capture_scope): Added.
2521
2522 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2523
2524         Cleanup FrameView::autoSizeIfEnabled.
2525         https://bugs.webkit.org/show_bug.cgi?id=172889
2526         <rdar://problem/32550783>
2527
2528         Reviewed by Tim Horton.
2529
2530         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2531         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
2532         (TEST):
2533
2534 2017-06-02  Chris Dumez  <cdumez@apple.com>
2535
2536         ResourceLoadStatistics are not using unique paths during test runs
2537         https://bugs.webkit.org/show_bug.cgi?id=172861
2538         <rdar://problem/32442251>
2539
2540         Reviewed by Darin Adler.
2541
2542         Make sure WebKitTestRunner sets a temporary path for saving resource
2543         load statistics.
2544
2545         * WebKitTestRunner/TestController.cpp:
2546         (WTR::TestController::generateContextConfiguration):
2547
2548 2017-06-02  Brady Eidson  <beidson@apple.com>
2549
2550         Prevent scheme handlers from handling all built-in URL schemes.
2551         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
2552
2553         Reviewed by Andy Estes.
2554
2555         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2556
2557 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
2558
2559         [JSCOnly] Build static jsc.exe on Windows
2560         https://bugs.webkit.org/show_bug.cgi?id=172833
2561
2562         Reviewed by Konstantin Tokarev.
2563
2564         * CMakeLists.txt:
2565         * Scripts/build-jsc:
2566
2567 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2568
2569         Disable ViewportSizeForViewportUnits tests on iOS.
2570         https://bugs.webkit.org/show_bug.cgi?id=172872
2571
2572         Reviewed by Tim Horton.
2573
2574         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
2575
2576 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2577
2578         Allow clients to override viewport size for CSS viewport units.
2579         https://bugs.webkit.org/show_bug.cgi?id=172838
2580         <rdar://problem/32523441>
2581
2582         Reviewed by Tim Horton.
2583
2584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2585         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
2586         (TEST):
2587
2588 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
2589
2590         Get <chrono> out of StdLibExtras.h
2591         https://bugs.webkit.org/show_bug.cgi?id=172744
2592
2593         Reviewed by Zalan Bujtas.
2594
2595         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2596
2597 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
2598
2599         [WPE] Enable SUBTLE_CRYPTO
2600         https://bugs.webkit.org/show_bug.cgi?id=172756
2601
2602         Reviewed by Michael Catanzaro.
2603
2604         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
2605         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
2606         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
2607         exhausting entropy when running the crypto layout tests.
2608
2609 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2610
2611         [GTK] Bump GTK+ and its dependencies in jhbuild
2612         https://bugs.webkit.org/show_bug.cgi?id=171918
2613
2614         Reviewed by Carlos Alberto Lopez Perez.
2615
2616         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2617         (WTR::initializeGtkSettings):
2618         * gtk/jhbuild.modules:
2619         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
2620         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
2621
2622 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2623
2624         [GTK] Bump wayland and weston in jhbuild
2625         https://bugs.webkit.org/show_bug.cgi?id=171921
2626
2627         Reviewed by Carlos Alberto Lopez Perez.
2628
2629         * gtk/jhbuild.modules:
2630         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
2631
2632 2017-06-01  Andy Estes  <aestes@apple.com>
2633
2634         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
2635         https://bugs.webkit.org/show_bug.cgi?id=172828
2636
2637         Reviewed by Beth Dakin.
2638
2639         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2640
2641 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
2642
2643         webkitpy: Remove unneeded simulator teardown
2644         https://bugs.webkit.org/show_bug.cgi?id=171891
2645
2646         Reviewed by Aakash Jain.
2647
2648         * Scripts/webkitpy/port/ios_simulator.py:
2649         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
2650         for communication between Python and WebKitTestRunner/DumpRenderTree.
2651
2652 2017-06-01  Keith Miller  <keith_miller@apple.com>
2653
2654         Undo rollout in r217638 with bug fix
2655         https://bugs.webkit.org/show_bug.cgi?id=172824
2656
2657         Unreviewed, reland patch with unused set_state code removed.
2658
2659         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2660         (runThreadMessageTest):
2661         (TEST):
2662
2663 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
2664
2665         webkitpy: Do not send 0 or -1 as a pid to kill_process
2666         https://bugs.webkit.org/show_bug.cgi?id=172818
2667
2668         Reviewed by Darin Adler.
2669
2670         Sending a signal to process 0 will result in all processes in the group receiving 
2671         the signal. Sending a signal to process -1 will result in all non-system processes
2672         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
2673         should consider these cases
2674
2675         * Scripts/webkitpy/common/system/executive.py:
2676         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
2677         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
2678         never be running, although os.kill may succeed.
2679         * Scripts/webkitpy/port/simulator_process.py:
2680         (SimulatorProcess.stop): Do not kill process if it is undefined.
2681
2682 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
2683
2684         JSC EWS bot does not run on WTF only patches
2685         https://bugs.webkit.org/show_bug.cgi?id=172777
2686         rdar://problem/32495975
2687
2688         Reviewed by Aakash Jain.
2689
2690         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
2691         (CheckPatchRelevance): Add a missing comma.
2692
2693 2017-05-31  Commit Queue  <commit-queue@webkit.org>
2694
2695         Unreviewed, rolling out r217611 and r217631.
2696         https://bugs.webkit.org/show_bug.cgi?id=172785
2697
2698         "caused wasm-hashset-many.html to become flaky." (Requested by
2699         keith_miller on #webkit).
2700
2701         Reverted changesets:
2702
2703         "Reland r216808, underlying lldb bug has been fixed."
2704         https://bugs.webkit.org/show_bug.cgi?id=172759
2705         http://trac.webkit.org/changeset/217611
2706
2707         "Use dispatch queues for mach exceptions"
2708         https://bugs.webkit.org/show_bug.cgi?id=172775
2709         http://trac.webkit.org/changeset/217631
2710
2711 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
2712
2713         EWS bots should reboot themselves more frequently
2714         https://bugs.webkit.org/show_bug.cgi?id=172402
2715
2716         Reviewed by Alexey Proskuryakov.
2717
2718         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
2719
2720         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
2721
2722 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
2723
2724         Reallocate hardware for iOS bots.
2725         https://bugs.webkit.org/show_bug.cgi?id=172657
2726
2727         Reviewed by Alexey Proskuryakov.
2728
2729         * BuildSlaveSupport/build.webkit.org-config/config.json:
2730
2731 2017-05-31  Andy Estes  <aestes@apple.com>
2732
2733         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
2734         https://bugs.webkit.org/show_bug.cgi?id=172366
2735
2736         Reviewed by Daniel Bates.
2737
2738         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2739
2740 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
2741
2742         Unreviewed, add Jiewen Tan as a reviewer
2743
2744         * Scripts/webkitpy/common/config/contributors.json:
2745
2746 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
2747
2748         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
2749         https://bugs.webkit.org/show_bug.cgi?id=172770
2750
2751         Reviewed by Michael Catanzaro.
2752
2753         * MiniBrowser/gtk/BrowserWindow.c:
2754         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
2755         which caused the body of the if-clause to be accidentally empty.
2756
2757 2017-05-31  Keith Miller  <keith_miller@apple.com>
2758
2759         Reland r216808, underlying lldb bug has been fixed.
2760         https://bugs.webkit.org/show_bug.cgi?id=172759
2761
2762         Unreviewed, relanding old patch. See: rdar://problem/31183352
2763
2764         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2765         (runThreadMessageTest):
2766         (TEST):
2767
2768 2017-05-31  Matt Lewis  <jlewis3@apple.com>
2769
2770         Unreviewed, rolling out r217603.
2771
2772         This patch broke the internal builds.
2773
2774         Reverted changeset:
2775
2776         "Get <chrono> out of StdLibExtras.h"
2777         https://bugs.webkit.org/show_bug.cgi?id=172744
2778         http://trac.webkit.org/changeset/217603
2779
2780 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
2781
2782         Make ResourceLoadStatistics testing more reliable
2783         https://bugs.webkit.org/show_bug.cgi?id=172730
2784         <rdar://problem/32028373>
2785
2786         Reviewed by Andy Estes.
2787
2788         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
2789         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
2790
2791         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2792         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2793
2794 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2795
2796         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
2797         https://bugs.webkit.org/show_bug.cgi?id=172757
2798
2799         Reviewed by Xabier Rodriguez-Calvar.
2800
2801         When needed, add the jhbuild wrapper at the beginning of the array
2802         that will be invoked to execute the run-jsc-stress-test or testapi
2803         commands.
2804
2805         * Scripts/run-javascriptcore-tests:
2806         (runJSCStressTests):
2807         * Scripts/webkitdirs.pm:
2808         (shouldUseJhbuild):
2809
2810 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
2811
2812         Get <chrono> out of StdLibExtras.h
2813         https://bugs.webkit.org/show_bug.cgi?id=172744
2814
2815         Reviewed by Saam Barati.
2816
2817         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2818
2819 2017-05-30  Tim Horton  <timothy_horton@apple.com>
2820
2821         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
2822         https://bugs.webkit.org/show_bug.cgi?id=172735
2823         <rdar://problem/32015977>
2824
2825         Reviewed by Enrica Casucci.
2826
2827         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2828         (WTR::UIScriptController::applyAutocorrection):
2829         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2830         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2831         (WTR::UIScriptController::applyAutocorrection):
2832         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2833         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2834         (WTR::UIScriptController::applyAutocorrection):
2835         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
2836         because I don't know how to tap the button in the autocorrection bar from a test.
2837
2838 2017-05-30  Daniel Bates  <dabates@apple.com>
2839
2840         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
2841         https://bugs.webkit.org/show_bug.cgi?id=172671
2842
2843         Reviewed by Alex Christensen.
2844
2845         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
2846         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
2847
2848         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
2849         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
2850         to trigger a navigation to test it.
2851         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
2852         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
2853
2854 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
2855
2856         webkitpy: Start servers before setting-up for testing
2857         https://bugs.webkit.org/show_bug.cgi?id=172176
2858         <rdar://problem/32225538>
2859
2860         Reviewed by Alexey Proskuryakov.
2861
2862         On-device testing requires that servers are started before ports set-up their
2863         test environments.
2864
2865         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2866         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
2867         Servers are unconditionally stopped on exit.
2868         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
2869         Manager now stops servers.
2870         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
2871         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
2872         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2873         (Manager.__init__): Delay construction of the test runner until we can determine
2874         if servers need to be started.
2875         (Manager.run): Determine if servers need to be started and construct the test runner.
2876         Shut servers down when the test run is finished.
2877         (Manager._run_tests): Move the determination of servers to run into Manager.run.
2878         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2879         (is_wpt_server_running): Server is not running if no config is found.
2880         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2881         (PyWebSocket.is_running): Check if this WebSocket server is running.
2882         * Scripts/webkitpy/port/base.py:
2883         (Port.__init__): Define secure WebSocket server.
2884         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
2885
2886 2017-05-30  Daniel Bates  <dabates@apple.com>
2887
2888         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
2889         https://bugs.webkit.org/show_bug.cgi?id=172603
2890         <rdar://problem/32471306>
2891
2892         Reviewed by Brady Eidson.
2893
2894         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
2895         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
2896         unloading is initiated for a page that registered a onbeforeunload handler.
2897
2898         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
2899         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
2900         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
2901
2902         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
2903         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
2904         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
2905         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
2906
2907         * MiniBrowser/mac/WK2BrowserWindowController.m:
2908         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2909         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
2910         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
2911         (sawDialog):
2912         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2913         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2914         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2915
2916 2017-05-30  Alex Christensen  <achristensen@webkit.org>
2917
2918         Update libwebrtc configuration
2919         https://bugs.webkit.org/show_bug.cgi?id=172727
2920
2921         Reviewed by Geoffrey Garen.
2922
2923         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2924
2925 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2926
2927         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
2928         https://bugs.webkit.org/show_bug.cgi?id=172702
2929
2930         Reviewed by Alex Christensen.
2931
2932         EGL PlatformDisplay needs to be shut down before existing a
2933         program on Windows.
2934
2935         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
2936         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
2937         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2938         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
2939
2940 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
2941
2942         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
2943         https://bugs.webkit.org/show_bug.cgi?id=172709
2944
2945         Reviewed by Brent Fulgham.
2946
2947         Exit fullscreen mode after a fullscreen test.
2948
2949         * DumpRenderTree/win/DumpRenderTree.cpp:
2950         (resetWebViewToConsistentStateBeforeTesting):
2951
2952 2017-05-30  Antti Koivisto  <antti@apple.com>
2953
2954         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
2955         https://bugs.webkit.org/show_bug.cgi?id=172713
2956
2957         Reviewed by Zalan Bujtas.
2958
2959         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2960         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
2961
2962             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
2963             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
2964             because on Mac WK1 it may get invoked from middle of a layout.
2965
2966             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
2967
2968 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2969
2970         Add a WPE EWS queue
2971         https://bugs.webkit.org/show_bug.cgi?id=172693
2972
2973         Reviewed by Carlos Garcia Campos.
2974
2975         * QueueStatusServer/config/queues.py:
2976         * QueueStatusServer/model/queues.py: Capitalize the name of the
2977         port on the tooltip of the bubbles. Do the same for the GTK port.
2978         (Queue.display_name):
2979         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
2980         for the GTK+ EWS also. Set for both ports as watcher the alias
2981         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
2982         * Scripts/webkitpy/common/config/ports.py:
2983         (DeprecatedPort.port):
2984         (WpePort):
2985         (WpePort.build_webkit_command):
2986         (WpePort.run_webkit_tests_command):
2987         * Scripts/webkitpy/common/config/ports_unittest.py:
2988         (DeprecatedPortTest):
2989         (DeprecatedPortTest.test_wpe_port):
2990         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2991         (test_ews_name):
2992
2993 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
2994
2995         Unreviewed. Bumping the WPEBackend-mesa dependency version.
2996
2997         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
2998         priorities for IPC communication.
2999
3000 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
3001
3002         [JSC] Map and Set constructors should have fast path for cloning
3003         https://bugs.webkit.org/show_bug.cgi?id=172413
3004
3005         Reviewed by Saam Barati.
3006
3007         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3008         (TestWebKitAPI::TEST):
3009
3010 2017-05-27  Zalan Bujtas  <zalan@apple.com>
3011
3012         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
3013         https://bugs.webkit.org/show_bug.cgi?id=172676
3014
3015         Reviewed by Simon Fraser.
3016
3017         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
3018         (TestWebKitAPI::TEST):
3019
3020 2017-05-26  Zalan Bujtas  <zalan@apple.com>
3021
3022         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
3023         https://bugs.webkit.org/show_bug.cgi?id=172674
3024
3025         Reviewed by Simon Fraser.
3026
3027         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
3028         (TestWebKitAPI::TEST):
3029
3030 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3031
3032         Add test resources back into TestWebKitAPI Copy Resources phase
3033
3034         Rubber-stamped by Beth Dakin.
3035
3036         Add two files back into the Copy Resources phase after they were unintentionally
3037         removed in r217447 and r217496.
3038
3039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3040
3041 2017-05-26  Beth Dakin  <bdakin@apple.com>
3042
3043         Media documents inside iframes should not get controls in the TouchBar unless the 
3044         video is playing
3045         https://bugs.webkit.org/show_bug.cgi?id=172620
3046         -and corresponding-
3047         rdar://problem/32165477
3048
3049         Reviewed by Jon Lee.
3050
3051         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3052         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3053         (TestWebKitAPI::TEST):
3054         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
3055
3056 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
3057
3058         _WKUserStyleSheet and WKUserScript leak string data
3059         https://bugs.webkit.org/show_bug.cgi?id=172583
3060         <rdar://problem/32395209>
3061
3062         Reviewed by Sam Weinig.
3063
3064         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3065         We should not have been adopting an autoreleased object.
3066
3067 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
3068
3069         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
3070         https://bugs.webkit.org/show_bug.cgi?id=172554
3071         <rdar://problem/31247133>
3072
3073         Reviewed by Simon Fraser.
3074
3075         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
3076         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
3077         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
3078         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
3079         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
3080         codepath.
3081
3082         * DumpRenderTree/TestOptions.h:
3083         * DumpRenderTree/TestOptions.mm:
3084         (TestOptions::TestOptions):
3085         (TestOptions::webViewIsCompatibleWithOptions):
3086         * DumpRenderTree/mac/DumpRenderTree.mm:
3087         (shouldIgnoreWebCoreNodeLeaks):
3088         (allowedFontFamilySet):
3089         (-[DRTMockScroller rectForPart:]):
3090         (-[DRTMockScroller drawKnob]):
3091         (-[DRTMockScroller drawRect:]):
3092         (createWebViewAndOffscreenWindow):
3093         (initializeGlobalsFromCommandLineOptions):
3094         (prepareConsistentTestingEnvironment):
3095         (dumpRenderTree):
3096         (dumpAudio):
3097         (dumpHistoryItem):
3098         (dumpBackForwardListForWebView):
3099         (resetWebViewToConsistentStateBeforeTesting):
3100         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
3101         (runTest):
3102
3103 2017-05-25  Sam Weinig  <sam@webkit.org>
3104
3105         [WebIDL] Use the term 'operation' more consistently
3106         https://bugs.webkit.org/show_bug.cgi?id=172601
3107
3108         Reviewed by Chris Dumez.
3109
3110         We were using the term 'operation', a WebIDL term for function-like
3111         constructs, inconsistently in the code generator. Now, when we use
3112         'operation' when referring to the IDL concept (usually the object the
3113         parser produces) and 'function' when referring to code being generated.
3114
3115         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3116         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3117
3118 2017-05-25  Jer Noble  <jer.noble@apple.com>
3119
3120         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
3121
3122         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
3123
3124 2017-05-25  Jer Noble  <jer.noble@apple.com>
3125
3126         System sleeps while playing to wireless target, ending stream.
3127         https://bugs.webkit.org/show_bug.cgi?id=172541
3128
3129         Reviewed by Eric Carlson.
3130
3131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3132         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
3133         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
3134         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
3135         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3136         (TestWebKitAPI::simulateKeyDown):
3137         (TestWebKitAPI::hasAssertionType):
3138         (TestWebKitAPI::TEST):
3139
3140 2017-05-25  Commit Queue  <commit-queue@webkit.org>
3141
3142         Unreviewed, rolling out r217423 and r217424.
3143         https://bugs.webkit.org/show_bug.cgi?id=172607
3144
3145         These caused an api failure on all testers. (Requested by
3146         mlewis13 on #webkit).
3147
3148         Reverted changesets:
3149
3150         "REGRESSION (r216977): 4 leaks introduced in new
3151         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
3152         https://bugs.webkit.org/show_bug.cgi?id=172558
3153         http://trac.webkit.org/changeset/217423
3154
3155         "REGRESSION (r217423): Fix last-second typo in 'auto'"
3156         http://trac.webkit.org/changeset/217424
3157
3158 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
3159
3160         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
3161         https://bugs.webkit.org/show_bug.cgi?id=172355
3162
3163         Reviewed by Chris Fleizach.
3164
3165         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
3166         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
3167         releases which support the new platform footnote accessibility role.
3168
3169         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3170         * gtk/jhbuild.modules:
3171
3172 2017-05-25  David Kilzer  <ddkilzer@apple.com>
3173
3174         REGRESSION (r217423): Fix last-second typo in 'auto'
3175
3176         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3177         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
3178
3179 2017-05-24  David Kilzer  <ddkilzer@apple.com>
3180
3181         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
3182         <https://webkit.org/b/172558>
3183
3184         Reviewed by Sam Weinig.
3185
3186         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3187         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
3188
3189 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
3190
3191         [CMake] Consolidate CMake code related to Cairo
3192         https://bugs.webkit.org/show_bug.cgi?id=172568
3193
3194         Reviewed by Alex Christensen.
3195
3196         * DumpRenderTree/config.h:
3197         * TestWebKitAPI/config.h:
3198
3199 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3200
3201         Plumb additional image metadata to item providers when beginning data interaction on an image
3202         https://bugs.webkit.org/show_bug.cgi?id=172536
3203         <rdar://problem/32371300>
3204
3205         Reviewed by Beth Dakin.
3206
3207         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
3208         source item providers.
3209
3210         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3211         (checkSuggestedNameAndEstimatedSize):
3212         (TestWebKitAPI::TEST):
3213
3214 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
3215
3216         [Win] Create unique network storage session for each DRT.
3217         https://bugs.webkit.org/show_bug.cgi?id=172540
3218
3219         Reviewed by Brent Fulgham.
3220
3221         During layout testing, each DRT instance should have its own network storage session.
3222
3223         * DumpRenderTree/win/DumpRenderTree.cpp:
3224         (prepareConsistentTestingEnvironment):
3225
3226 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3227
3228         Respect image UTIs when writing to item providers when beginning data interaction on an image
3229         https://bugs.webkit.org/show_bug.cgi?id=172436
3230         <rdar://problem/31786569>
3231
3232         Reviewed by Beth Dakin.
3233
3234         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
3235         details.
3236
3237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3238         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
3239         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
3240
3241         Create a new test page containing a GIF and a file input.
3242
3243         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3244         (checkTypeIdentifierIsRegisteredAtIndex):
3245         (TestWebKitAPI::TEST):
3246
3247 2017-05-23  Per Arne Vollan  <pvollan@apple.com>
3248
3249         [Win] Increase test timeout for slow tests.
3250         https://bugs.webkit.org/show_bug.cgi?id=172449
3251
3252         Reviewed by Alexey Proskuryakov.
3253
3254         Instead of using a fixed timeout of 30 seconds for all tests, we should use the
3255         timeout member in the TestRunner class.
3256
3257         * DumpRenderTree/win/TestRunnerWin.cpp:
3258         (TestRunner::setWaitToDump):
3259
3260 2017-05-15  Matt Rajca  <mrajca@apple.com>
3261
3262         Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
3263         https://bugs.webkit.org/show_bug.cgi?id=172138
3264
3265         Reviewed by Alex Christensen.
3266
3267         Added API tests.
3268
3269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3270         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
3271         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3272         (TEST):
3273         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
3274
3275 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
3276
3277         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
3278         https://bugs.webkit.org/show_bug.cgi?id=172522
3279         rdar://problem/31071812
3280
3281         Reviewed by Sam Weinig.
3282
3283         Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
3284         We set this in the .xib file now.
3285
3286         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3287
3288 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
3289
3290         Snapshotting via -renderInContext: should do synchronous image decodes
3291         https://bugs.webkit.org/show_bug.cgi?id=172485
3292         rdar://problem/32276146
3293
3294         Reviewed by Tim Horton.
3295
3296         New API test.
3297
3298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3299         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
3300         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
3301         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
3302         (TestWebKitAPI::getPixelIndex):
3303         (TestWebKitAPI::TEST):
3304
3305 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
3306
3307         Remove dead ENABLE(FONT_LOAD_EVENTS) code
3308         https://bugs.webkit.org/show_bug.cgi?id=172517
3309
3310         Rubber-stamped by Simon Fraser.
3311
3312         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3313
3314 2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3315
3316         Multiple links should be inserted separately when performing data interaction
3317         https://bugs.webkit.org/show_bug.cgi?id=172489
3318         <rdar://problem/31510832>
3319
3320         Reviewed by Dan Bernstein.
3321
3322         Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.
3323
3324         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3325         (TestWebKitAPI::TEST):
3326
3327 2017-05-23  Tim Horton  <timothy_horton@apple.com>
3328
3329         REGRESSION: API test WebKit2.WKObject is failing
3330         https://bugs.webkit.org/show_bug.cgi?id=172497
3331         <rdar://problem/31694641>
3332
3333         Reviewed by Geoff Garen.
3334
3335         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
3336         (TestWebKitAPI::TEST):
3337         Add a test that ensures that we pretend to at least be *some* kind of
3338         NSString, which my first fix would not have passed.
3339
3340 2017-05-23  youenn fablet  <youenn@apple.com>
3341
3342         There should be an easy way to run HTTP/WPT served tests on a browser
3343         https://bugs.webkit.org/show_bug.cgi?id=172068
3344
3345         Reviewed by Sam Weinig.
3346
3347         Adding a new script open-layout-test to open a layout-test in a
3348         browser and making sure it is served as done through run-webkit-tests.
3349         In case tests should be run using a server, detecting whether the
3350         server are running. If not, calling run-webkit-httpd to run the
3351         servers and open the URL in a browser.
3352         Otherwise, open directly the URL.
3353
3354         Adding an option in run-webkit-httpd to open an URL after having
3355         started the servers.
3356
3357         Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
3358         This allows running run-webkit-httpd once and not having to restart
3359         servers everytime a test should be served.
3360
3361         Moving most of run-webkit-httpd logic in its own python file to reuse
3362         it in open-layout-test script.
3363
3364         Adding routines to check whether HTTP and WPT servers are running.
3365
3366         * Scripts/open-layout-test: Added.
3367         (parse_args):
3368         (main):
3369         * Scripts/run-webkit-httpd:
3370         (main):
3371         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3372         (LayoutTestFinder.find_tests):
3373         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3374         (LayoutTestRunner.run_tests):
3375         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3376         (parse_args):
3377         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3378         (HttpServerBase._is_server_running_on_all_ports):
3379         (HttpServerBase):
3380         (HttpServerBase._is_running_on_port):
3381         (HttpServerBase._check_that_all_ports_are_available):
3382         (is_http_server_running):
3383         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
3384         (parse_args):
3385         (main):
3386         (run_server):
3387         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3388         (is_wpt_server_running):
3389         * Scripts/webkitpy/port/base.py:
3390         (Port.to.is_http_server_running):
3391         (Port.to):
3392         (Port.to.is_wpt_server_running):
3393         (Port.to.start_web_platform_test_server):
3394         * Scripts/webkitpy/port/driver.py:
3395         (DriverProxy.is_web_platform_test):
3396         (DriverProxy):
3397         (DriverProxy.is_webkit_specific_web_platform_test):
3398
3399 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
3400
3401         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3402         https://bugs.webkit.org/show_bug.cgi?id=171984
3403
3404         Reviewed by Antti Koivisto.
3405
3406         * DumpRenderTree/mac/DumpRenderTree.mm:
3407         (enableExperimentalFeatures):
3408         * WebKitTestRunner/TestController.cpp:
3409         (WTR::TestController::resetPreferencesToConsistentValues):
3410
3411 2017-05-20  Alex Christensen  <achristensen@webkit.org>
3412
3413         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
3414         https://bugs.webkit.org/show_bug.cgi?id=172406
3415         <rdar://32109532>
3416
3417         Reviewed by Brady Eidson.
3418
3419         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3420         (TestWebKitAPI::checkBuffer):
3421         (TestWebKitAPI::TEST_F):
3422
3423 2017-05-22  Jason Marcell  <jmarcell@apple.com>
3424
3425         Do not enter Subversion-specific logic when parsing Git-based Trac data.
3426         https://bugs.webkit.org/show_bug.cgi?id=172433
3427         <rdar://problem/32234188>
3428
3429         Reviewed by Alexey Proskuryakov.
3430
3431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3432         (Trac.prototype._convertCommitInfoElementToObject):
3433
3434 2017-05-22  Tim Horton  <timothy_horton@apple.com>
3435
3436         ExplicitSnapshotsChangeUponNavigation API test often fails
3437         https://bugs.webkit.org/show_bug.cgi?id=172475
3438         <rdar://problem/31688322>
3439
3440         Reviewed by Simon Fraser.
3441
3442         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3443         (-[TestWKWebView _setUpTestWindow:]):
3444         Make TestWKWebView's window layer-backed. This is now the default,
3445         and it's also easy to accidentally write a test that depends on it
3446         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
3447         which becomes layer backed, just like the WKWebView, but with no
3448         common layer-backed ancestor).
3449
3450 2017-05-22  youenn fablet  <youenn@apple.com>
3451
3452         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
3453         https://bugs.webkit.org/show_bug.cgi?id=172426
3454
3455         Reviewed by Chris Dumez.
3456
3457         * Scripts/webkitpy/w3c/test_importer.py:
3458         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
3459
3460 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
3461
3462         Unreviewed, change my status to reviewer and fill "expertise" field
3463
3464         * Scripts/webkitpy/common/config/contributors.json:
3465
3466 2017-05-22  Tomas Popela  <tpopela@redhat.com>
3467
3468         Remove some of the EFL port leftovers
3469         https://bugs.webkit.org/show_bug.cgi?id=172440
3470
3471         Reviewed by Carlos Garcia Campos.
3472
3473         * BuildSlaveSupport/built-product-archive:
3474         (archiveBuiltProduct):
3475         (extractBuiltProduct):
3476         * BuildSlaveSupport/test-result-archive:
3477         (archiveTestResults):
3478         * ImageDiff/PlatformEfl.cmake: Removed.
3479         * Scripts/run-efl-tests: Removed.
3480         * Scripts/webkit-build-directory:
3481         * Scripts/webkitpy/common/config/contributionareas.py:
3482         * Scripts/webkitpy/common/config/watchlist:
3483         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3484         (parse_args):
3485         (_set_up_derived_options):
3486         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3487         (PerfTestsRunner.__init__):
3488         * Scripts/webkitpy/style/checker.py:
3489         * Scripts/webkitpy/style/checker_unittest.py:
3490         (GlobalVariablesTest.test_path_rules_specifier):
3491         * gtk/manifest.txt.in:
3492         * jhbuild/jhbuild-wrapper:
3493
3494 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3495
3496         Unreviewed. Do not include WPE files in GTK+ tarballs.
3497
3498         * gtk/manifest.txt.in:
3499
3500 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3501
3502         [GTK] Add webkit_context_menu_item_new_from_gaction
3503         https://bugs.webkit.org/show_bug.cgi?id=159631
3504
3505         Reviewed by Michael Catanzaro.
3506
3507         Update context menu tests to check the new GAction API.
3508
3509         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3510         (testContextMenuPopulateMenu):
3511
3512 2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3513
3514         [GTK] Remove Firefox user agent quirk for Google domains
3515         https://bugs.webkit.org/show_bug.cgi?id=171941
3516
3517         Reviewed by Carlos Garcia Campos.
3518
3519         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3520         (TestWebKitAPI::TEST):
3521         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.
3522
3523 2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>
3524
3525         [GTK] gtkdoc-fixxref needs --module argument to work
3526         https://bugs.webkit.org/show_bug.cgi?id=172415
3527
3528         Reviewed by Michael Catanzaro.
3529
3530         * gtk/gtkdoc.py:
3531         (GTKDoc._run_gtkdoc_fixxref):
3532
3533 2017-05-20  Alexey Proskuryakov  <ap@apple.com>
3534
3535         make-new-script-test should create tests that use js-test.js, not js-test-pre.js
3536         https://bugs.webkit.org/show_bug.cgi?id=172416
3537
3538         Reviewed by Daniel Bates.
3539
3540         * Scripts/make-new-script-test:
3541
3542 2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>
3543
3544         [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
3545         https://bugs.webkit.org/show_bug.cgi?id=172267
3546
3547         Reviewed by Per Arne Vollan.
3548
3549         TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
3550         TestWebCoreLib should link only with WebCore. And, TestWebKitLib
3551         should link only with WebKit.
3552
3553         Unfortunately, there is a layer violation at the moment.
3554         WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
3555         in WebKit. This change contains a stub of loadResourceIntoBuffer
3556         in TestWebCoreLib for the workaround.
3557
3558         * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
3559         TestWebCoreLib. Do not link WebCore to TestWebKitLib.
3560         * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
3561         (loadResourceIntoBuffer): Added a stub.
3562
3563 2017-05-19  Simon Fraser  <simon.fraser@apple.com>
3564
3565         Fix dump-class-layout to handle different file architectures
3566         https://bugs.webkit.org/show_bug.cgi?id=172392
3567
3568         Reviewed by Zalan Bujtas.
3569
3570         Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
3571         and use the first architecture reported. Also add a "--architecture" argument
3572         to allow the user to specify an architecture.
3573
3574         * Scripts/dump-class-layout:
3575         (import_lldb):
3576         (verify_type_recursive):
3577         (get_first_file_architecture):
3578         (dump_class):
3579         (main):
3580         (find_build_directory): Deleted.
3581
3582 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3583
3584         Unreviewed infrastructure fix.
3585
3586         * Scripts/webkitpy/port/ios_simulator.py:
3587         (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
3588
3589 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3590
3591         webkitpy: Use simctl boot to run multiple simulators at once
3592         https://bugs.webkit.org/show_bug.cgi?id=172374
3593
3594         Reviewed by Alexey Proskuryakov.
3595
3596         * Scripts/webkitpy/common/system/platforminfo.py:
3597         (PlatformInfo.xcode_version): Return the current version of Xcode.
3598         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3599         (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
3600         * Scripts/webkitpy/port/ios_simulator.py:
3601         (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
3602         run multiple Simulator.app instances.
3603         (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
3604         versions of Xcode.
3605         (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
3606         an older version of Xcode.
3607
3608 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3609
3610         Unreviewed, fix the build on the latest internal SDK.
3611
3612         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3613         (TestWebKitAPI::TEST):
3614
3615 2017-05-19  Filip Pizlo  <fpizlo@apple.com>
3616
3617         arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
3618         https://bugs.webkit.org/show_bug.cgi?id=172369
3619
3620         Reviewed by Mark Lam.
3621         
3622         Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
3623         would be a good idea to write this down.
3624
3625         * Scripts/run-jsc-stress-tests:
3626
3627 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3628
3629         webkitpy: Layout tests which have no output will succeed
3630         https://bugs.webkit.org/show_bug.cgi?id=172322
3631         <rdar://problem/32258350>
3632
3633         Reviewed by David Kilzer.
3634
3635         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3636         (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
3637         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3638         (determine_result_type): FailureNotTested means that the test could not be loaded. This
3639         is classified as a MISSING failure.
3640         (FailureNotTested): Added.
3641         (FailureNotTested.message):
3642
3643 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3644
3645         Add SixSpeed benchmark to PerformanceTests
3646         https://bugs.webkit.org/show_bug.cgi?id=172326
3647
3648         Reviewed by Sam Weinig.
3649
3650         * Scripts/run-jsc-benchmarks:
3651
3652 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3653
3654         [WK1] MiniBrowser should navigate when handling a dropped URL
3655         https://bugs.webkit.org/show_bug.cgi?id=172350
3656
3657         Reviewed by Tim Horton.
3658
3659         Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
3660
3661         * MiniBrowser/mac/WK1BrowserWindowController.m:
3662         (-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
3663
3664 2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>
3665
3666         REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
3667         https://bugs.webkit.org/show_bug.cgi?id=172077
3668
3669         Reviewed by Chris Dumez.
3670
3671         Fixed perftest.py by updating the lines to ignore in Speedometer.
3672
3673         Also start report the results as "Speedometer" instead of "DoYouEvenBench/Full.html" to perf.webkit.org.
3674
3675         * Scripts/webkitpy/performance_tests/perftest.py:
3676         (PerfTest._lines_to_ignore_in_parser_result): Updated for Speedometer 2.0.
3677         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3678         (PerfTestsRunner._collect_tests): Use "Speedometer" instead of "Speedometer/index.html" as the test name.
3679         (_generate_results_dict): Removed the workaround to keep reporting Speedometer as DoYouEvenBench.
3680         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3681         (MainTest.test_collect_tests_with_index_html_and_resources): Added.
3682
3683 2017-05-18  Andy Estes  <aestes@apple.com>
3684
3685         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
3686         https://bugs.webkit.org/show_bug.cgi?id=172305
3687
3688         Reviewed by Anders Carlsson.
3689
3690         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3691
3692 2017-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3693
3694         Selection around attachment elements should not persist when beginning a drag
3695         https://bugs.webkit.org/show_bug.cgi?id=172319
3696         <rdar://problem/32283008>
3697
3698         Reviewed by Tim Horton.
3699
3700         Tests that temporary selection around an attachment does not persist longer than it needs to.
3701
3702         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3703         (TestWebKitAPI::TEST):
3704
3705 2017-05-18  John Wilander  <wilander@apple.com>
3706
3707         Resource Load Statistics: Grandfather domains for existing data records
3708         https://bugs.webkit.org/show_bug.cgi?id=172155
3709         <rdar://problem/24913532>
3710
3711         Reviewed by Alex Christensen.
3712
3713         Adds test infrastructure needed for the added functionality.
3714
3715         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3716         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3717         (WTR::InjectedBundle::didReceiveMessageToPage):
3718         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3719         (WTR::TestRunner::setStatisticsGrandfathered):
3720         (WTR::TestRunner::isStatisticsGrandfathered):
3721         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
3722         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
3723         (WTR::TestRunner::setStatisticsGrandfatheringTime):
3724         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3725         * WebKitTestRunner/TestController.cpp:
3726         (WTR::TestController::setStatisticsGrandfathered):
3727         (WTR::TestController::isStatisticsGrandfathered):
3728         (WTR::TestController::setStatisticsGrandfatheringTime):
3729         * WebKitTestRunner/TestController.h:
3730         * WebKitTestRunner/TestInvocation.cpp:
3731         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3732
3733 2017-05-18  Saam Barati  <sbarati@apple.com>
3734
3735         WebAssembly: perform stack checks
3736         https://bugs.webkit.org/show_bug.cgi?id=165546
3737         <rdar://problem/29760307>
3738
3739         Reviewed by Filip Pizlo.
3740
3741         Add some new testing modes for using and not using fast TLS wasm contexts.
3742
3743         * Scripts/run-jsc-stress-tests:
3744
3745 2017-05-18  Daniel Bates  <dabates@apple.com>
3746
3747         REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
3748         window CSP when object-src 'none' is set
3749         https://bugs.webkit.org/show_bug.cgi?id=172038
3750         <rdar://problem/32258262>
3751
3752         Reviewed by Andy Estes.
3753
3754         Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
3755         When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().
3756
3757         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3758         (NPP_New):
3759
3760 2017-05-18  Per Arne Vollan  <pvollan@apple.com>
3761
3762         [Win] Many layout tests are failing.
3763         https://bugs.webkit.org/show_bug.cgi?id=172286
3764
3765         Reviewed by Brent Fulgham.
3766
3767         Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
3768  
3769         * DumpRenderTree/win/TestRunnerWin.cpp:
3770         (TestRunner::grantWebNotificationPermission):
3771         (TestRunner::denyWebNotificationPermission):
3772         (TestRunner::removeAllWebNotificationPermissions):
3773         (TestRunner::simulateWebNotificationClick):
3774
3775 2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>
3776
3777         [Win] Remove usage of _snprintf
3778         https://bugs.webkit.org/show_bug.cgi?id=172251
3779
3780         Reviewed by Per Arne Vollan.
3781
3782         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3783         * MiniBrowser/win/PageLoadTestClient.cpp:
3784         (PageLoadTestClient::dumpRunStatistics):
3785
3786 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
3787
3788         Unreviewed, rolling out r217014.
3789
3790         This change caused mac-wk2 LayoutTests to exit early due to
3791         crashes.
3792
3793         Reverted changeset:
3794
3795         "Resource Load Statistics: Grandfather domains for existing
3796         data records"
3797         https://bugs.webkit.org/show_bug.cgi?id=172155
3798         http://trac.webkit.org/changeset/217014
3799
3800 2017-05-17  John Wilander  <wilander@apple.com>
3801
3802         Resource Load Statistics: Grandfather domains for existing data records
3803         https://bugs.webkit.org/show_bug.cgi?id=172155
3804         <rdar://problem/24913532>
3805
3806         Reviewed by Alex Christensen.
3807
3808         Adds test infrastructure needed for the added functionality.
3809
3810         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3811         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3812         (WTR::InjectedBundle::didReceiveMessageToPage):
3813         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3814         (WTR::TestRunner::setStatisticsGrandfathered):
3815         (WTR::TestRunner::isStatisticsGrandfathered):
3816         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
3817         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
3818         (WTR::TestRunner::setStatisticsGrandfatheringTime):
3819         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3820         * WebKitTestRunner/TestController.cpp:
3821         (WTR::TestController::setStatisticsGrandfathered):
3822         (WTR::TestController::isStatisticsGrandfathered):
3823         (WTR::TestController::setStatisticsGrandfatheringTime):
3824         * WebKitTestRunner/TestController.h:
3825         * WebKitTestRunner/TestInvocation.cpp:
3826         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3827
3828 2017-05-17  Alex Christensen  <achristensen@webkit.org>
3829
3830         Fix ios-simulator API test after r216977
3831         https://bugs.webkit.org/show_bug.cgi?id=171987
3832
3833         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3834         (TEST):
3835         <rdar://problem/32260156> covers the investigation of this, but fixing it is 
3836         not as urgent as having the rest of this working. Notably the ephemeral part of the
3837         test works, so something is just wrong with the persistent part.
3838
3839 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
3840
3841         Unreviewed, rolling out r216955.
3842
3843         This change caused strange behavior with web-platform-tests
3844         locally and on EWS.
3845
3846         Reverted changeset:
3847
3848         "webkitpy: Start servers before setting-up for testing"
3849         https://bugs.webkit.org/show_bug.cgi?id=172176
3850         http://trac.webkit.org/changeset/216955
3851
3852 2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3853
3854         A URL type is vended for a non-URL plain text string when starting data interaction
3855         https://bugs.webkit.org/show_bug.cgi?id=172228
3856         <rdar://problem/32166729>
3857
3858         Reviewed by Andy Estes.
3859
3860         Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
3861         to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
3862         still vended when beginning data interaction on something that resembles a link.
3863
3864         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3865
3866 2017-05-17  David Kilzer  <ddkilzer@apple.com>
3867
3868         BlobDataFileReference::generateReplacementFile() should use mkstemp()
3869         <https://webkit.org/b/172192>
3870
3871         Reviewed by Brent Fulgham.
3872
3873         * Scripts/webkitpy/style/checkers/cpp.py:
3874         (check_language): Add check for mktemp.
3875         (CppChecker): Add 'security/temp_file' category.
3876         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3877         (CppStyleTest.test_insecure_temp_file): Add test.
3878
3879 2017-05-17  Devin Rousso  <drousso@apple.com>
3880
3881         Unreviewed, change my email.
3882
3883         * Scripts/webkitpy/common/config/contributors.json:
3884
3885 2017-05-17  Matt Lewis  <jlewis3@apple.com>
3886
3887         Unreviewed, rolling out r216974.
3888
3889         Revision caused consistent timeouts on all platforms.
3890
3891         Reverted changeset:
3892
3893         "Add a RuntimeEnabledFeature for display: contents, defaulted
3894         to false."
3895         https://bugs.webkit.org/show_bug.cgi?id=171984
3896         http://trac.webkit.org/changeset/216974
3897
3898 2017-05-17  Alex Christensen  <achristensen@webkit.org>
3899
3900         Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
3901         https://bugs.webkit.org/show_bug.cgi?id=171987
3902
3903         Reviewed by Brady Eidson.
3904
3905         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3906         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3907         (TEST):
3908
3909 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
3910
3911         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3912         https://bugs.webkit.org/show_bug.cgi?id=171984
3913
3914         Reviewed by Antti Koivisto.
3915
3916         * DumpRenderTree/mac/DumpRenderTree.mm:
3917         (enableExperimentalFeatures):
3918         * WebKitTestRunner/TestController.cpp:
3919         (WTR::TestController::resetPreferencesToConsistentValues):
3920
3921 2017-05-16  Timothy Horton  <timothy_horton@apple.com>
3922
3923         Fix the build
3924
3925         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3926         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3927
3928 2017-05-16  Tim Horton  <timothy_horton@apple.com>
3929
3930         PageVisibilityStateWithWindowChanges tests sometimes time out
3931         https://bugs.webkit.org/show_bug.cgi?id=172202
3932         <rdar://problem/29653266>
3933
3934         Reviewed by Dean Jackson.
3935
3936         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3937         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3938         Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.
3939
3940 2017-05-16  Jonathan Bedard  <jbedard@apple.com>
3941
3942         webkitpy: Start servers before setting-up for testing
3943         https://bugs.webkit.org/show_bug.cgi?id=172176
3944         <rdar://problem/32225538>
3945
3946         Reviewed by Alexey Proskuryakov.
3947
3948         On-device testing requires that servers are started before ports set-up their
3949         test environments.
3950
3951         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3952         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
3953         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer.
3954         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3955         (Manager.__init__): Delay construction of the test runner until we can determine
3956         if servers need to be started.
3957         (Manager.run): Determine if servers need to be started and construct the test runner.
3958         (Manager._run_tests): Move the determination of servers to run into Manager.run.
3959
3960 2017-05-16  Adrian Perez de Castro  <aperez@igalia.com>
3961
3962         Unreviewed, adding myself to contributors.json
3963
3964         * Scripts/webkitpy/common/config/contributors.json:
3965
3966 2017-05-16  Claudio Saavedra  <csaavedra@igalia.com>
3967
3968         [GTK] Tests that always pass when run alone, but fail in the bots
3969         https://bugs.webkit.org/show_bug.cgi?id=168572
3970
3971         Reviewed by Michael Catanzaro.
3972
3973         PlatformWebView::viewSupportsOptions() is basically a comparison
3974         that checks that the passed options are the ones supported by the
3975         web view. There is no reason for them to be implemented for each
3976         platform differently. In fact doing so causes issues each time a
3977         new option is added, if the corresponding platform implementation
3978         is not updated accordingly.
3979
3980         A consequence of not updating the viewSupportOptions()
3981         implementations when new options are added is that tests that need
3982         these options might fail if they are executed after a test that
3983         didn't need the option, as the webview will be reused even if the
3984         option is not supported. This cannot be spotted when running the
3985         tests individually. See bug #165133 for other example of the same
3986         problem.
3987
3988         Remove the platform implementations and make the comparison a
3989         method of the TestOptions structure, so that the check is in one
3990         place. For the time being, only include in the comparison the
3991         options that were checked in the mac platform, which seem to be
3992         the only ones relevant this far (unless newer ones have also been
3993         forgotten).
3994
3995         * WebKitTestRunner/PlatformWebView.h:
3996         (WTR::PlatformWebView::viewSupportsOptions): Use the method
3997         defined below.
3998         * WebKitTestRunner/TestOptions.h:
3999         (WTR::TestOptions::hasSameInitializationOptions): Added.
4000         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4001         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
4002         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4003         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
4004         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4005         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
4006         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
4007         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
4008
4009 2017-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>
4010
4011         [JSC] Build testapi in non Apple ports
4012         https://bugs.webkit.org/show_bug.cgi?id=172103
4013
4014         Reviewed by Filip Pizlo.
4015
4016         Now testapi is drived in JSCOnly, GTK and WPE ports too.
4017
4018         * Scripts/build-jsc:
4019         * Scripts/run-javascriptcore-tests:
4020
4021 2017-05-15  Youenn Fablet  <youenn@apple.com>
4022
4023         WPT test importer should not account for slow manual tests
4024         https://bugs.webkit.org/show_bug.cgi?id=172127
4025
4026         Reviewed by Ryosuke Niwa.
4027
4028         Making sure manual tests are not triggering updating tests-options.json file.
4029
4030         * Scripts/webkitpy/w3c/test_importer.py:
4031         (TestImporter.find_importable_tests):
4032         (TestImporter._already_identified_as_resource_file):
4033         (TestImporter.update_tests_options):
4034         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4035         (test_manual_slow_test):
4036
4037 2017-05-15  Jonathan Bedard  <jbedard@apple.com>
4038
4039         webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
4040         https://bugs.webkit.org/show_bug.cgi?id=172142
4041
4042         Reviewed by Tim Horton.
4043
4044         * Scripts/webkitpy/xcode/simulator.py:
4045         (Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
4046         around runtime identifiers.
4047         * Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.
4048
4049 2017-05-15  Ryosuke Niwa  <rniwa@webkit.org>
4050
4051         Update ARES-6 plan file to use the latest version
4052         https://bugs.webkit.org/show_bug.cgi?id=172139
4053
4054         Reviewed by Keith Miller.
4055
4056         Include r216538.
4057
4058         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
4059
4060 2017-05-15  Jeremy Jones  <jeremyj@apple.com>
4061
4062         Disable Picture In Picture API tests on unsupported platforms.
4063         https://bugs.webkit.org/show_bug.cgi?id=172125
4064         rdar://problem/32199477
4065
4066         Reviewed by Simon Fraser.
4067
4068         The callbacks and allowing picture-in-picture require new SPI.
4069
4070         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
4071
4072 2017-05-15  Brady Eidson  <beidson@apple.com>
4073
4074         [ios-simulator] API test WKWebView.ClearAppCache is failing.
4075         https://bugs.webkit.org/show_bug.cgi?id=172120
4076
4077         Unreviewed test gardening.
4078
4079         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
4080         (TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.
4081           Restoring that code fixes this.
4082
4083 2017-05-15  Timothy Horton  <timothy_horton@apple.com>
4084
4085         Null deref under WebContentReader::readURL when interacting with a file URL
4086         https://bugs.webkit.org/show_bug.cgi?id=172045
4087         <rdar://problem/25880647>
4088
4089         Reviewed by Wenson Hsieh.
4090
4091         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4092         (TestWebKitAPI::TEST):
4093         The text of the file URL is pasted because a textual version of it gets
4094         onto the pasteboard. However, this test would have crashed before. Also
4095         tests that we don't make an <a>.
4096
4097 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
4098
4099         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
4100         https://bugs.webkit.org/show_bug.cgi?id=172071
4101
4102         Reviewed by Alexey Proskuryakov.
4103
4104         * DumpRenderTree/win/DumpRenderTree.cpp:
4105         (resetWebPreferencesToConsistentValues):
4106
4107 2017-05-14  Chris Dumez  <cdumez@apple.com>
4108
4109         Drop PassRefPtr class from WTF
4110         https://bugs.webkit.org/show_bug.cgi?id=172091
4111
4112         Reviewed by Alex Christensen.
4113
4114         Drop API test coverage.
4115
4116         * TestWebKitAPI/Tests/WTF/Ref.cpp:
4117         (TestWebKitAPI::TEST):
4118         (TestWebKitAPI::passWithPassRefPtr): Deleted.
4119
4120 2017-05-13  Eric Carlson  <eric.carlson@apple.com>
4121
4122         [MediaStream] deviceId constraint doesn't work with getUserMedia
4123         https://bugs.webkit.org/show_bug.cgi?id=171877
4124         <rdar://problem/31899730>
4125
4126         Reviewed by Jer Noble.
4127
4128         The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
4129         implement the "checkUserMediaPermission" callback.
4130         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
4131         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
4132         (TestWebKitAPI::checkUserMediaPermissionCallback):
4133         (TestWebKitAPI::TEST):
4134
4135         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:
4136         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4137
4138 2017-05-13  Chris Dumez  <cdumez@apple.com>
4139
4140         Stop using RefPtr::release()
4141         https://bugs.webkit.org/show_bug.cgi?id=172074
4142
4143         Reviewed by Geoffrey Garen.
4144
4145         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
4146         (TestWebKitAPI::TEST):
4147
4148 2017-05-13  Commit Queue  <commit-queue@webkit.org>
4149
4150         Unreviewed, rolling out r216808.
4151         https://bugs.webkit.org/show_bug.cgi?id=172075
4152
4153         caused lldb to hang when debugging (Requested by smfr on
4154         #webkit).
4155
4156         Reverted changeset:
4157
4158         "Use Mach exceptions instead of signals where possible"
4159         https://bugs.webkit.org/show_bug.cgi?id=171865
4160         http://trac.webkit.org/changeset/216808
4161
4162 2017-05-12  Alex Christensen  <achristensen@webkit.org>
4163
4164         Rename WKContentExtension to WKContentRuleList
4165         https://bugs.webkit.org/show_bug.cgi?id=172053
4166         <rdar://problem/32141005>
4167
4168         Reviewed by Geoffrey Garen.
4169
4170         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:
4171         (WKContentRuleListStoreTest::SetUp):
4172         (TEST_F):
4173         (-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4174         (WKContentExtensionStoreTest::SetUp): Deleted.
4175         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
4176
4177 2017-05-12  Keith Miller  <keith_miller@apple.com>
4178
4179         Use Mach exceptions instead of signals where possible
4180         https://bugs.webkit.org/show_bug.cgi?id=171865
4181
4182         Reviewed by Mark Lam.
4183
4184         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
4185         (runThreadMessageTest):
4186         (TEST):
4187
4188 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
4189
4190         Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
4191         https://bugs.webkit.org/show_bug.cgi?id=172048
4192         rdar://problem/32163054
4193
4194         Reviewed by Simon Fraser.
4195
4196         Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.
4197
4198         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
4199         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
4200         (hasVideoInPictureInPictureDidChange):
4201         (-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
4202         (-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
4203         (TestWebKitAPI::TEST):
4204
4205 2017-05-12  Brady Eidson  <beidson@apple.com>
4206
4207         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
4208         https://bugs.webkit.org/show_bug.cgi?id=172030
4209
4210         Unreviewed - Test gardening
4211
4212         Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
4213         before the test starts.
4214
4215         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
4216         (defaultWebsiteCacheDirectory):
4217         (defaultApplicationCacheDirectory):
4218         (TEST):
4219         (defaultWebsiteDataDirectory): Deleted.
4220
4221 2017-05-12  David Quesada  <david_quesada@apple.com>
4222
4223         Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
4224         https://bugs.webkit.org/show_bug.cgi?id=172000
4225         rdar://problem/32144756
4226
4227         Reviewed by Simon Fraser.
4228
4229         Added API tests to verify that WKWebView provides the expected value for
4230         _visibleContentRect in various configurations. (i.e. not inside a scrollview,
4231         inside a scrollview but not clipped, clipped by an ancestor scrollview,
4232         clipped by the webview's _enclosingViewForExposedRectComputation)
4233
4234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4235         * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
4236         (-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
4237         (TestWebKitAPI::TEST):
4238
4239 2017-05-12  Brady Eidson  <beidson@apple.com>
4240
4241         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
4242         https://bugs.webkit.org/show_bug.cgi?id=172030
4243
4244         Unreviewed - Test gardening, in effect...
4245
4246         More exploration as to why this continues to fail on the bots.
4247         
4248         This change should give us a smoking gun.
4249         
4250         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
4251         (TEST):
4252
4253 2017-05-12  Hyungwook Lee  <hyungwook.lee@navercorp.com>
4254
4255         [GTK] Fix compile warnings in PlatformImageCairo.cpp
4256         https://bugs.webkit.org/show_bug.cgi?id=171850
4257
4258         Reviewed by Michael Catanzaro.
4259
4260         * ImageDiff/cairo/PlatformImageCairo.cpp:
4261         (ImageDiff::PlatformImage::createFromStdin):
4262         (ImageDiff::PlatformImage::writeAsPNGToStdout):
4263
4264 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
4265
4266         Add UIClient callback for when picture-in-picture is activated.
4267         https://bugs.webkit.org/show_bug.cgi?id=172023
4268
4269         Reviewed by Simon Fraser.
4270
4271         Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.
4272
4273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4274         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
4275         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
4276         (onLoadedCompletedCallback):
4277         (waitUntilOnLoadIsCompleted):
4278         (didFinishLoadForFrame):
4279         (setHasVideoInPictureInPicture):
4280         (TestWebKitAPI::TEST):
4281
4282 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
4283
4284         Unreviewed follow-up to r216776.
4285
4286         * Scripts/webkitpy/port/base.py:
4287         (Port.path_to_crash_logs): Raise not implemented.
4288         * Scripts/webkitpy/port/test.py:
4289         (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
4290         * Scripts/webkitpy/port/win.py:
4291         (WinPort.path_to_crash_logs): Ditto.
4292
4293 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
4294
4295         Bot watcher's dashboard shows results links twice sometimes
4296         https://bugs.webkit.org/show_bug.cgi?id=172043
4297
4298         Reviewed by Tim Horton.
4299
4300         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4301         (BuildbotTesterQueueView.prototype._pr