c5f7178dd757802d7089fcefff4605a2633f4193
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
2
3         Reviewed by Adam Barth.
4
5         Move main CMakeLists.txt into Source directory
6         https://bugs.webkit.org/show_bug.cgi?id=52888
7
8         * Scripts/webkitdirs.pm:
9
10 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
11
12         Reviewed by Eric Seidel.
13
14         Improve label text in submit-to-ews
15         https://bugs.webkit.org/show_bug.cgi?id=53130
16
17         * QueueStatusServer/templates/submittoews.html:
18
19 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
20
21         Reviewed by Antonio Gomes.
22
23         QtTestBrowser should have a UI Settings to prevent loading images
24         https://bugs.webkit.org/show_bug.cgi?id=52409
25         
26         Added a new action item named "DisableAutoLoadImages"
27         under the "Settings" menu 
28
29         * QtTestBrowser/launcherwindow.cpp:
30         (LauncherWindow::createChrome):
31         (LauncherWindow::toggleAutoLoadImages):
32         * QtTestBrowser/launcherwindow.h:
33
34 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
35
36         Reviewed by Tony Chang.
37
38         Minor bug fixes and cleanup for filesystem wrappers, port/* test
39         classes, test_expectations.py. This change adds "test-win" and
40         "test-mac" variants to the test port so that we can better test
41         rebaselining, and adds a MockUser() object for reuse in testing.
42
43         https://bugs.webkit.org/show_bug.cgi?id=53036
44
45         * Scripts/webkitpy/common/system/filesystem.py:
46         * Scripts/webkitpy/common/system/filesystem_mock.py:
47         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
48         * Scripts/webkitpy/layout_tests/port/factory.py:
49         * Scripts/webkitpy/layout_tests/port/base.py:
50         * Scripts/webkitpy/layout_tests/port/test.py:
51         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
52         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
53         * Scripts/webkitpy/tool/mocktool.py:
54
55 2011-01-25  Tony Chang  <tony@chromium.org>
56
57         Reviewed by Dimitri Glazkov.
58
59         [chromium] remove unused layoutTestController callback
60         https://bugs.webkit.org/show_bug.cgi?id=53103
61
62         This method is used by a test_shell_test, but not needed by DRT.
63
64         * DumpRenderTree/chromium/LayoutTestController.cpp:
65         (LayoutTestController::LayoutTestController):
66         * DumpRenderTree/chromium/LayoutTestController.h:
67
68 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
69
70         Reviewed by Andreas Kling.
71
72         [GTK] Remove 64 bits release bot from the buildbot master
73         https://bugs.webkit.org/show_bug.cgi?id=52899
74
75         Removes the 64 bits release slave from the buildbot configuration,
76         so that we can use it as an EWS.
77
78         * BuildSlaveSupport/build.webkit.org-config/config.json:
79
80 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
81
82         Reviewed by Dan Bernstein.
83
84         Implement database quota callback to fix storage tests on WebKit2 bot
85         https://bugs.webkit.org/show_bug.cgi?id=53064
86
87         * WebKitTestRunner/TestController.cpp:
88         (WTR::exceededDatabaseQuota):
89         (WTR::TestController::createOtherPage):
90         (WTR::TestController::initialize):
91
92 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
93
94         Reviewed by Anders Carlsson.
95
96         Use designated temp directory for the database for WebKit2
97         https://bugs.webkit.org/show_bug.cgi?id=53052
98         
99         Adopt the new WK2 API for this.
100
101         * WebKitTestRunner/TestController.cpp:
102         (WTR::TestController::libraryPathForTesting):
103         (WTR::TestController::initialize):
104         * WebKitTestRunner/TestController.h:
105         * WebKitTestRunner/mac/TestControllerMac.mm:
106         (WTR::TestController::platformLibraryPathForTesting):
107         * WebKitTestRunner/qt/TestControllerQt.cpp:
108         (WTR::TestController::platformLibraryPathForTesting):
109         * WebKitTestRunner/win/TestControllerWin.cpp:
110         (WTR::TestController::platformLibraryPathForTesting):
111
112 2011-01-24  Lucas Forschler  <lforschler@apple.com>
113
114         Reviewed by Stephanie Lewis.
115
116         Add a new Leopard test bot.
117
118         * BuildSlaveSupport/build.webkit.org-config/config.json:
119
120 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
121
122         Reviewed by Adam Barth.
123
124         Add EFL Builder to core waterfall
125         https://bugs.webkit.org/show_bug.cgi?id=52704
126
127         Add EFL Builder to the core waterfall again.
128
129         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
130         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
131
132 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
133
134         Reviewed by Tony Chang.
135
136         new-run-webkit-tests fails to start HTTP server if there are proxy settings
137         https://bugs.webkit.org/show_bug.cgi?id=52872
138
139         Force disabling proxy to resolve the problem.
140
141         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
142         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
143
144 2011-01-24  Andreas Kling  <kling@webkit.org>
145
146         Reviewed by Darin Adler.
147
148         check-webkit-style: Update exemptions following Source/ move.
149         https://bugs.webkit.org/show_bug.cgi?id=53017
150
151         * Scripts/webkitpy/style/checker.py:
152         * Scripts/webkitpy/style/checker_unittest.py:
153
154 2011-01-24  Andras Becsi  <abecsi@webkit.org>
155
156         Rubber-stamped by Csaba Osztrogonác.
157
158         [Qt] Move project files into Source
159         https://bugs.webkit.org/show_bug.cgi?id=52891
160
161         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
162
163 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
164
165         Reviewed by Yury Semikhatsky.
166
167         Web Inspector: Find duplicate strings in localizedStrings.js
168
169         https://bugs.webkit.org/show_bug.cgi?id=53005
170
171         * Scripts/check-inspector-strings:
172
173 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
174
175         Reviewed by Andreas Kling.
176
177         [Qt] Regroup MiniBrowser's menubar and add open file action
178         https://bugs.webkit.org/show_bug.cgi?id=53000
179
180         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
181
182         * MiniBrowser/qt/BrowserWindow.cpp:
183         (BrowserWindow::BrowserWindow):
184         (BrowserWindow::openFile):
185         (BrowserWindow::~BrowserWindow):
186         * MiniBrowser/qt/BrowserWindow.h:
187
188 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
189
190         Unreviewed fix after r76496
191
192         [Qt] Move project files into Source
193         https://bugs.webkit.org/show_bug.cgi?id=52891
194
195         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
196         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
197         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
198
199 2011-01-24  Andras Becsi  <abecsi@webkit.org>
200
201         Reviewed by Csaba Osztrogonác.
202
203         [Qt] Move project files into Source
204         https://bugs.webkit.org/show_bug.cgi?id=52891
205
206         * DerivedSources.pro: Renamed from DerivedSources.pro.
207         * DumpRenderTree/qt/DumpRenderTree.pro:
208         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
209         * MiniBrowser/DerivedSources.pro:
210         * MiniBrowser/qt/MiniBrowser.pro:
211         * QtTestBrowser/QtTestBrowser.pro:
212         * Scripts/webkitdirs.pm:
213         * Tools.pro: Added.
214         * WebKitTestRunner/DerivedSources.pro:
215         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
216         * WebKitTestRunner/qt/WebKitTestRunner.pro:
217
218 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
219
220         Reviewed by Dan Bernstein.
221
222         Beefed up --threaded mode to catch even more kinds of errors.
223         https://bugs.webkit.org/show_bug.cgi?id=52971
224
225         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
226         context group to force JSC to mark multiple threads. (This used to be
227         the default, but it changed in SnowLeopard.)
228         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
229         to give threading mistakes more chances to show themselves.
230         (startJavaScriptThreads):
231         (stopJavaScriptThreads):
232
233 2011-01-22  Robert Hogan  <robert@webkit.org>
234
235         Reviewed by Andreas Kling.
236
237         [Qt] Support layoutTestController.addURLToRedirect()
238         https://bugs.webkit.org/show_bug.cgi?id=52956
239
240         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
241         (LayoutTestController::addURLToRedirect):
242         * DumpRenderTree/qt/LayoutTestControllerQt.h:
243
244 2011-01-22  Robert Hogan  <robert@webkit.org>
245
246         Reviewed by Kenneth Rohde Christiansen.
247
248         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
249         https://bugs.webkit.org/show_bug.cgi?id=49802
250
251         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
252         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
253         (WebCore::DumpRenderTree::open):
254
255 2011-01-21  Adam Barth  <abarth@webkit.org>
256
257         Reviewed by Maciej Stachowiak.
258
259         Disable mac_unittest.py that fails on some of the Mac bots
260         https://bugs.webkit.org/show_bug.cgi?id=52947
261
262         As noted in the comment, this test does not appear to be correct
263         because the function this test is testing returns different results
264         depending on which flavor of Mac the test is run on.  This patch
265         disable the test.  Hopefully we can re-enable the test once we've
266         probably insulated the test from its environment.
267
268         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
269
270 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
271
272         Reviewed by Mihai Parparita.
273
274         Fix bug introduced in r76322 that caused NRWT to not actually
275         read the Skipped files properly.
276
277         https://bugs.webkit.org/show_bug.cgi?id=52771
278
279         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
280         * Scripts/webkitpy/layout_tests/port/webkit.py:
281         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
282
283 2011-01-21  Sam Weinig  <sam@webkit.org>
284
285         Reviewed by Geoffrey Sean Garen and Mark Rowe.
286
287         WebKitTestRunner needs the HOME environment variable to be set.
288         <rdar://problem/8896573>
289
290         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
291         it exists.
292
293 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
294
295         Reviewed by Eric Seidel.
296
297         Suppress a few remaining integration tests so that none of the
298         layout_test unit tests ever read from the filesystem or launch
299         subprocesses that aren't part of the unit tests.
300
301         Also fix a minor bug in the printing unit tests that was
302         incorrectly relying on sys.argv.
303
304         https://bugs.webkit.org/show_bug.cgi?id=52863
305
306         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
307         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
308         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
309
310 2011-01-21  Darin Adler  <darin@apple.com>
311
312        Fix Mac build.
313
314         * MiniBrowser/mac/BrowserWindowController.m:
315         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
316
317 2011-01-20  Darin Adler  <darin@apple.com>
318
319         Reviewed by Dan Bernstein.
320
321         WebKit2: Implement showModalDialog
322         https://bugs.webkit.org/show_bug.cgi?id=52855
323
324         This fixes WebKitTestRunner to compile, but more work is probably
325         needed to get it to pass the tests.
326
327         * WebKitTestRunner/TestController.cpp:
328         (WTR::TestController::runModal): Added. Calls through to the
329         platform-specific version of runModal.
330         (WTR::TestController::createOtherPage): Changed to be a private
331         static member function so it can refer to runModal, which is
332         a private static member function.
333         (WTR::TestController::initialize): Pass 0 for the runModal
334         function since we don't need to run the main window modal.
335         I suspect this is wrong and will need to change.
336         * WebKitTestRunner/TestController.h: Added declarations for
337         the functions added above.
338         * WebKitTestRunner/mac/TestControllerMac.mm:
339         (WTR::TestController::runModal): Added. Untested implementation.
340         * WebKitTestRunner/qt/TestControllerQt.cpp:
341         (WTR::TestController::runModal): Added.
342         * WebKitTestRunner/win/TestControllerWin.cpp:
343         (WTR::TestController::runModal): Added.
344
345 2011-01-21  Eric Seidel  <eric@webkit.org>
346
347         Reviewed by Adam Barth.
348
349         Split Host object off from WebKitPatch for easier re-use
350         https://bugs.webkit.org/show_bug.cgi?id=52284
351
352         new-run-webkit-tests and other tools are eventually going to want one of these.
353         Basically you need to inherit from this class if you want to pretend to be a
354         self.tool object for Steps/Commands.
355
356         * Scripts/webkitpy/common/host.py: Added.
357         * Scripts/webkitpy/tool/main.py:
358
359 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
360
361         Reviewed by Adam Barth.
362
363         Disable the tests that start and stop the http server and web
364         server, so that we don't have to worry about port collisions on
365         the bots.
366
367         https://bugs.webkit.org/show_bug.cgi?id=52861
368
369         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
370
371 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
372
373         Reviewed by Eric Seidel.
374
375         nrwt: rewrite google_chrome_unittest to use mock filesystem.
376         
377         https://bugs.webkit.org/show_bug.cgi?id=52772
378         
379         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
380
381 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
382
383         Reviewed by Eric Siedel.
384
385         nrwt: clean up almost all remaining port references, remove
386         unnecessary import clauses. The only remaining references are
387         in places where a mock filesystem makes no sense or can't be
388         used, and in one routine in port/google_chrome_unittest that
389         I'll rewrite in a separate patch.
390
391         https://bugs.webkit.org/show_bug.cgi?id=52771
392
393         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
394         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
395         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
396         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
397         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
398         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
399         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
400         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
401         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
402         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
403         * Scripts/webkitpy/layout_tests/port/gtk.py:
404         * Scripts/webkitpy/layout_tests/port/mac.py:
405         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
406         * Scripts/webkitpy/layout_tests/port/qt.py:
407         * Scripts/webkitpy/layout_tests/port/webkit.py:
408         * Scripts/webkitpy/layout_tests/port/win.py:
409         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
410
411 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
412
413         Reviewed by Mihai Parparita.
414
415         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
416
417         https://bugs.webkit.org/show_bug.cgi?id=52762
418
419         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
420         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
421
422 2011-01-20  Tony Chang  <tony@chromium.org>
423
424         Reviewed by Ojan Vafai.
425
426         [chromium] fix the paths used for the rebaseline tool
427         https://bugs.webkit.org/show_bug.cgi?id=52857
428
429         Some of the bots were renamed so the path to grab the results zip
430         file has changed.
431
432         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
433
434 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
435
436         Reviewed by Tony Chang.
437
438         Fix bug introduced in r72688 / bug 52768 that broke the
439         generation of the output filename links in the results.html
440         output. Apparently none of the unit tests actually checked to
441         make sure the generated links were correct :(
442
443         https://bugs.webkit.org/show_bug.cgi?id=52854
444
445         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
446         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
447
448 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
449
450         Reviewed by Darin Adler.
451
452         https://bugs.webkit.org/show_bug.cgi?id=52849
453         Make window.print work with WebKit2
454
455         * MiniBrowser/mac/BrowserWindowController.m:
456         (-[BrowserWindowController awakeFromNib]):
457         * WebKitTestRunner/TestController.cpp:
458         (WTR::createOtherPage):
459         (WTR::TestController::initialize):
460         Added zeroes to WKPageUIClient structures to avoid build failures.
461
462 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
463
464         Reviewed by Eric Seidel.
465
466         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
467
468         https://bugs.webkit.org/show_bug.cgi?id=52756
469
470         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
471         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
472         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
473         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
474         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
475         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
476
477 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
478
479         Reviewed by Antonio Gomes.
480
481         QtTestBrowser should have a seperate menu for Settings
482         https://bugs.webkit.org/show_bug.cgi?id=52817
483         
484         Added a new menu item named "Settings"
485         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
486
487         * QtTestBrowser/launcherwindow.cpp:
488         (LauncherWindow::createChrome):
489
490 2011-01-20  Sam Weinig  <sam@webkit.org>
491
492         Reviewed by John Sullivan.
493
494         Update update-webkit-localizable-strings with new path to WebKit.
495
496         * Scripts/update-webkit-localizable-strings:
497
498 2011-01-20  James Robinson  <jamesr@chromium.org>
499
500         Reviewed by Darin Fisher.
501
502         Implement mozilla's requestAnimationFrame API
503         https://bugs.webkit.org/show_bug.cgi?id=51218
504
505         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
506
507         * DumpRenderTree/chromium/WebViewHost.cpp:
508         (invokeScheduleComposite):
509         (WebViewHost::scheduleAnimation):
510         (WebViewHost::paintInvalidatedRegion):
511         * DumpRenderTree/chromium/WebViewHost.h:
512
513 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
514
515         Reviewed by Adam Roben.
516
517         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
518         https://bugs.webkit.org/show_bug.cgi?id=42327
519
520         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
521         for methods that take their normal arguments but also a JSContextRef.
522         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
523         for evaluateScriptInIsolatedWorld.
524         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
525         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
526         this call is for an isolated world.
527         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
528         (WTR::worldMap): Helper to create a world map.
529         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
530         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
531         added LayoutTestController API.
532         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
533
534 2011-01-19  Adam Roben  <aroben@apple.com>
535
536         Convert paths in environment variables back to msys-style inside commit-log-editor
537
538         When this script gets run from inside git commit, msys-style paths in the environment will
539         have been turned into Windows-style paths with forward slashes. This screws up functions
540         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
541         the paths back to msys-style before doing anything else.
542
543         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
544         using msysgit's Perl and multiple ChangeLogs have been edited
545
546         Reviewed by David Kilzer.
547
548         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
549         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
550         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
551
552 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
553
554         [Win] Unreviewed build fix after r76248.
555
556         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
557
558 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
559
560         Reviewed by Csaba Osztrogonác.
561
562         Refactoring of the custom allocation framework
563         https://bugs.webkit.org/show_bug.cgi?id=49897
564
565         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
566         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
567         equivalent macro implementation at the necessary places.
568 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
569
570         Unreviewed. 
571
572         Adding myself to committers.py.
573
574         * Scripts/webkitpy/common/config/committers.py:
575
576 2011-01-20  Adam Barth  <abarth@webkit.org>
577
578         Reviewed by Tony Chang.
579
580         Chromium builders don't delete unversioned directories when DEPS change
581         https://bugs.webkit.org/show_bug.cgi?id=52745
582
583         If we pass this option to gclient sync, gclient will delete directories
584         that are no longer part of DEPS instead of leaving them around to
585         confuse us later.  Apparently, the downstream buildbots use this option
586         already.
587
588         * Scripts/update-webkit-chromium:
589
590 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
591
592         Unreviewed, build fix - I pulled this patch in to fix an issue
593         revealed by r76195 running on some new bots). Also fix a couple
594         of other issues revealed in testing.
595
596         nrwt: remove fs refs from layout_package/json*
597
598         https://bugs.webkit.org/show_bug.cgi?id=52754
599
600         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
601         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
602         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
603         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
604         * Scripts/webkitpy/layout_tests/port/base.py:
605
606 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
607
608         Unreviewed, build fix.
609
610         Fix a couple of minor bugs discovered while bringing up new bots
611         for testing.
612
613         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
614         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
615
616 2011-01-19  James Robinson  <jamesr@chromium.org>
617
618         Unreviewed, rolling out r76194.
619         http://trac.webkit.org/changeset/76194
620         https://bugs.webkit.org/show_bug.cgi?id=51218
621
622         Caused mysterious compile failure on the chromium win
623         build.webkit.org bots
624
625         * DumpRenderTree/chromium/WebViewHost.cpp:
626         (WebViewHost::paintInvalidatedRegion):
627         * DumpRenderTree/chromium/WebViewHost.h:
628
629 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
630
631         Reviewed by Mihai Parparita.
632
633         remove fs refs from test_runner, dump_render_tree_thread
634
635         https://bugs.webkit.org/show_bug.cgi?id=52753
636
637         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
638         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
639         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
640         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
641
642 2011-01-19  James Robinson  <jamesr@chromium.org>
643
644         Reviewed by Darin Fisher.
645
646         Implement mozilla's requestAnimationFrame API
647         https://bugs.webkit.org/show_bug.cgi?id=51218
648
649         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
650
651         * DumpRenderTree/chromium/WebViewHost.cpp:
652         (invokeScheduleComposite):
653         (WebViewHost::scheduleAnimation):
654         (WebViewHost::paintInvalidatedRegion):
655         * DumpRenderTree/chromium/WebViewHost.h:
656
657 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
658
659         Unreviewed, build fix.
660
661         Fix a few incorrect "self._filesystem" references introduced in
662         r76184.
663
664         * Scripts/webkitpy/layout_tests/port/chromium.py:
665         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
666
667 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
668
669         Reviewed by Mihai Parparita.
670
671         add a .sep property, abspath(), isabs(), mtime(), and
672         open_text_file_for_writing() to filesystem modules. Some of
673         these properties are not needed in this patch but will be needed
674         in subsequent patches (I'm doing this to avoid having to track
675         multiple versions of a single file).
676
677         Also, change most of the port/* modules to use the filesystem
678         objects instead of referencing the filesystem directly.
679
680         https://bugs.webkit.org/show_bug.cgi?id=52748
681
682         * Scripts/webkitpy/common/system/filesystem.py:
683         * Scripts/webkitpy/common/system/filesystem_mock.py:
684         * Scripts/webkitpy/layout_tests/port/__init__.py:
685         * Scripts/webkitpy/layout_tests/port/base.py:
686         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
687         * Scripts/webkitpy/layout_tests/port/chromium.py:
688         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
689         * Scripts/webkitpy/layout_tests/port/config.py:
690         * Scripts/webkitpy/layout_tests/port/test.py:
691         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
692
693 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
694
695         Reviewed by Anders Carlsson.
696
697         If resetting between tests times out, treat it as a WebProcess crash
698         https://bugs.webkit.org/show_bug.cgi?id=52757
699
700         * WebKitTestRunner/TestController.cpp:
701         (WTR::TestController::runTest):
702
703 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
704
705         Reviewed by Darin Adler.
706
707         https://bugs.webkit.org/show_bug.cgi?id=52739
708         Make it possible for a WebKit2 client to print headers and footers
709
710         Added dummy implementations for new printing UIClient calls.
711
712         * MiniBrowser/mac/BrowserWindowController.m:
713         (-[BrowserWindowController awakeFromNib]):
714         * WebKitTestRunner/TestController.cpp:
715         (WTR::createOtherPage):
716         (WTR::TestController::initialize):
717
718 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
719
720         Reviewed by Ojan Vafai.
721
722         Change webkitpy/layout_tests/port/test.py to use the
723         in-memory filesystem for cleaner unit testing. This
724         change allows us to kill a lot of code that was
725         specific to the test port, at the cost of being a
726         little less clear about how things would work if
727         you didn't have a filesystem.
728
729         https://bugs.webkit.org/show_bug.cgi?id=52605
730
731         * Scripts/webkitpy/layout_tests/port/test.py:
732
733 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
734
735         Unreviewed, build fix.
736
737         Fix test failure caused by committing attachment 79368 instead
738         of attachment 79461 on bug 52604.
739
740         * Scripts/webkitpy/common/system/filesystem_mock.py:
741
742 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
743
744         Reviewed by Mihai Parparita.
745
746         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
747         unit testing. os.walk() is too much of a hassle to implement on
748         top of the in-memory mock filesystem and adding the necessary
749         interface to files_under() gives clients a cleaner API anyway
750         (for this particular usage model).
751
752         https://bugs.webkit.org/show_bug.cgi?id=52691
753
754         * Scripts/webkitpy/common/system/filesystem.py:
755         * Scripts/webkitpy/common/system/filesystem_mock.py:
756         * Scripts/webkitpy/layout_tests/port/test_files.py:
757         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
758
759 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
760
761         Reviewed by Tony Chang.
762
763         Change more modules in the layout-tests code to use the
764         filesystem wrapper for cleaner unit testing.
765
766         This patch also adds the glob() wrapper to the filesystem
767         abstraction.
768         
769         https://bugs.webkit.org/show_bug.cgi?id=52604
770
771         * Scripts/webkitpy/layout_tests/port/test_files.py:
772         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
773         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
774         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
775         * Scripts/webkitpy/common/system/filesystem.py:
776         * Scripts/webkitpy/common/system/filesystem_mock.py:
777
778 2011-01-19  Levi Weintraub  <leviw@chromium.org>
779
780         Unreviewed.
781
782         Updating my email addresses and irc nick.
783
784         * Scripts/webkitpy/common/config/committers.py:
785
786 2011-01-19  Tony Chang  <tony@chromium.org>
787
788         Reviewed by Mihai Parparita.
789
790         [chromium] [linux] if check-sys-deps fails, output the failure reason
791         https://bugs.webkit.org/show_bug.cgi?id=52671
792
793         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
794             error handler functions.
795         * Scripts/webkitpy/layout_tests/port/chromium.py:
796             output the error text from --check-sys-deps
797         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
798
799 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
800
801         Reviewed by Andreas Kling.
802
803         [Qt] QtTestBrowser crashes when closing if Facebook is opened
804         https://bugs.webkit.org/show_bug.cgi?id=52554
805         
806         QtNetworkAccessManager is created in a thread and set as
807         member variable in QWebPage. When the thread is destroyed
808         the object is still used. So fix will set the object to
809         NULL once the thread is destroyed.
810
811         * QtTestBrowser/launcherwindow.cpp:
812         (LauncherWindow::~LauncherWindow):
813
814 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
815
816         Rubber stamped by Csaba Osztrogonac
817
818         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
819
820 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
821
822         Reviewed by Tony Chang.
823
824         new-run-webkit-tests: add a --build-directory command line argument
825
826         Official Google Chrome builds use a non-standard build directory
827         location. This patch adds a --build-directory argument that
828         allows that location to be specified on the command line. Only
829         Chromium-based builds will use this flag for now, but anyone can
830         in the future.
831
832         There are no unit tests for this since it's difficult to test
833         until mock filesystems are fully supported in the code. This was
834         tested by hand for now.
835
836         https://bugs.webkit.org/show_bug.cgi?id=52694
837
838         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
839         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
840         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
841         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
842
843 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
844
845         Not reviewed. Bot fix.
846
847         Remove an inadvertently committed debugging print.
848
849         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
850         (LayoutTestController::notifyDone):
851
852 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
853
854         Reviewed by Sam Weinig.
855
856         WebKitTestRunner should track loading more like DumpRenderTree
857         https://bugs.webkit.org/show_bug.cgi?id=52692
858
859         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
860         This makes some tests that call notifyDone multiple times pass.
861         
862         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
863         (WTR::InjectedBundle::InjectedBundle):
864         (WTR::InjectedBundle::done):
865         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
866         (WTR::InjectedBundle::topLoadingFrame):
867         (WTR::InjectedBundle::setTopLoadingFrame):
868         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
869         (WTR::InjectedBundlePage::InjectedBundlePage):
870         (WTR::InjectedBundlePage::stopLoading):
871         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
872         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
873         (WTR::InjectedBundlePage::didFinishLoadForFrame):
874         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
875         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
876         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
877         (WTR::LayoutTestController::notifyDone):
878         * WebKitTestRunner/TestController.cpp:
879         (WTR::TestController::didReceiveMessageFromInjectedBundle):
880
881 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
882
883         Reviewed by Kent Tamura.
884
885         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
886         https://bugs.webkit.org/show_bug.cgi?id=52678
887         
888         Update path now that WebKit is inside Source.
889
890         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
891
892 2011-01-18  Robert Hogan  <robert@webkit.org>
893
894         Reviewed by Simon Hausmann.
895
896         [Qt] http/tests/incremental/slow-utf8-text.pl fails
897         https://bugs.webkit.org/show_bug.cgi?id=44282
898
899         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
900         (WebCore::DumpRenderTree::dump):
901
902 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
903
904         Reviewed by Mihai Parparita.
905
906         Fix a small race condition that could cause the unit tests for
907         new-run-webkit-tests to fail in a multithreaded environment.
908         There was a small window in the code where one thread would
909         check to see if a thread had raised an exception, do something,
910         and then check to see if the thread was alive. If the other
911         thread raised an exception and exited in between these two
912         steps, the exception would be lost. Flipping the order of the
913         two checks fixes the race, since we will now always check for an
914         exception on the thread before exiting.
915
916         https://bugs.webkit.org/show_bug.cgi?id=51579
917
918         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
919
920 2011-01-18  Eric Seidel  <eric@webkit.org>
921
922         Reviewed by Adam Barth.
923
924         commit-queue dies when test archiving fails
925         https://bugs.webkit.org/show_bug.cgi?id=52617
926
927         I looked at the machine and it had 10 archives already
928         thus find_unused_name was returning None.  I've upped
929         the limit to 100 (per bug) and tested the case where
930         find_unused_name returns None (making archive return None).
931
932         * Scripts/webkitpy/common/system/workspace.py:
933         * Scripts/webkitpy/common/system/workspace_unittest.py:
934         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
935         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
936         * Scripts/webkitpy/tool/commands/queues.py:
937
938 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
939
940         Reviewed by Ojan Vafai.
941
942         Update rebaseline-chromium-webkit-tests unit tests to use a mock
943         filesystem. Also fix a couple of "with" statements missed by
944         r76050.
945
946         https://bugs.webkit.org/show_bug.cgi?id=52487
947
948         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
949
950 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
951
952         Reviewed by Martin Robinson.
953
954         [Gtk] Build fixes for gtk3 build
955         https://bugs.webkit.org/show_bug.cgi?id=52648
956
957         * DumpRenderTree/gtk/EventSender.cpp:
958         (beginDragWithFilesCallback):
959
960 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
961
962         Reviewed by Mihai Parparita.
963
964         Update rebaseline-chromium-webkit-tests to use filesystem objects
965         instead of direct references to os.path, shutil, tempfile, etc.
966
967         This patch doesn't change anything, but will allow subsequent
968         patches to change the unit tests to no longer use the real
969         filesystem.
970
971         This patch adds a bunch more methods to the filesystem object as
972         well.
973
974         https://bugs.webkit.org/show_bug.cgi?id=52482
975
976         * Scripts/webkitpy/common/system/filesystem.py:
977         * Scripts/webkitpy/common/system/filesystem_mock.py:
978         * Scripts/webkitpy/tool/commands/queues.py:
979         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
980         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
981
982 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
983
984         Reviewed by Mihai Parparita.
985
986         new-run-webkit-tests shouldn't crash when you try to run a
987         directory containing only skipped files.
988
989         https://bugs.webkit.org/show_bug.cgi?id=52478
990         
991         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
992         * Scripts/webkitpy/layout_tests/port/test.py:
993         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
994
995 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
996
997         Reviewed by Gustavo Noronha Silva.
998
999         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1000         https://bugs.webkit.org/show_bug.cgi?id=40833
1001
1002         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1003         GTK+ event sender.
1004         (dragWithFilesDragDataGetCallback): Added.
1005         (dragWithFilesDragEndCallback): Added.
1006         (beginDragWithFilesCallback): Added.
1007
1008 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1009
1010         Reviewed by Adam Barth.
1011
1012         ews: Add additional watcher to efl ews
1013         https://bugs.webkit.org/show_bug.cgi?id=52613
1014
1015         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1016
1017         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1018
1019 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1020
1021         Reviewed by Alexey Proskuryakov.
1022
1023         Fix some headers with missing or misspelled #ifndef guards
1024         https://bugs.webkit.org/show_bug.cgi?id=52545
1025
1026         * DumpRenderTree/chromium/TestEventPrinter.h:
1027         * DumpRenderTree/chromium/WebPreferences.h:
1028
1029 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1030
1031         Reviewed by Anders Carlsson.
1032
1033         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1034         navigating back to an unreachable URL
1035         https://bugs.webkit.org/show_bug.cgi?id=52388
1036
1037         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1038
1039         * DumpRenderTree/LayoutTestController.cpp:
1040         (queueLoadHTMLStringCallback):
1041         (LayoutTestController::queueLoadHTMLString):
1042         (LayoutTestController::queueLoadAlternateHTMLString):
1043         * DumpRenderTree/LayoutTestController.h:
1044
1045         * DumpRenderTree/WorkQueueItem.h:
1046         (LoadHTMLStringItem::LoadHTMLStringItem):
1047
1048         * DumpRenderTree/chromium/LayoutTestController.cpp:
1049         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1050         (WorkItemLoadHTMLString::run):
1051         (LayoutTestController::queueLoadHTMLString):
1052
1053         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1054         (LoadHTMLStringItem::invoke):
1055         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1056         (LoadHTMLStringItem::invoke):
1057         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1058         (LoadHTMLStringItem::invoke):
1059
1060 2011-01-17  Dan Bernstein  <mitz@apple.com>
1061
1062         Rubber-stamped by Mark Rowe.
1063
1064         Update xcodeproj svn:ignore to include xcuserdata.
1065
1066         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1067         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1068         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1069         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1070         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1071
1072 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1073
1074         Unreviewed fix after r75908.
1075
1076         Move WebKit into Source
1077         https://bugs.webkit.org/show_bug.cgi?id=52530
1078
1079         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1080
1081 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1082
1083         Unreviewed.
1084
1085         Remove accidentally committed debug printing after r75908.
1086
1087         * Scripts/webkitdirs.pm:
1088
1089 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1090
1091         Unreviewed.
1092
1093         Add myself to committers list
1094         https://bugs.webkit.org/show_bug.cgi?id=52566
1095
1096         * Scripts/webkitpy/common/config/committers.py:
1097
1098 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1099
1100         Reviewed by Jeremy Orlow.
1101
1102         GeolocationController should call stopUpdating on destruction
1103         https://bugs.webkit.org/show_bug.cgi?id=52216
1104
1105         fast/dom/Geolocation/window-close-crash.html requires that a
1106         Geolocation watch be started in a secondary window. Consequently,
1107         we need to allow geolocation permission and provide a mock
1108         geolocation position for the secondary window's
1109         GeolocationClientMock.
1110
1111         * DumpRenderTree/chromium/LayoutTestController.cpp:
1112         (LayoutTestController::setGeolocationPermission):
1113         (LayoutTestController::setMockGeolocationPosition):
1114         (LayoutTestController::setMockGeolocationError):
1115         * DumpRenderTree/chromium/TestShell.h:
1116         (TestShell::windowList):
1117
1118 2011-01-16  Adam Barth  <abarth@webkit.org>
1119
1120         Update more include paths to reflect WebKit move.
1121
1122         * DumpRenderTree/chromium/EventSender.cpp:
1123         (EventSender::keyDown):
1124         (EventSender::needsShiftModifier):
1125         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1126         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1127
1128 2011-01-16  Kent Tamura  <tkent@chromium.org>
1129
1130         Unreviewed, Chromium build fix.
1131
1132         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1133
1134 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1135
1136         Build fix for GTK+ after source directory movement.
1137
1138         * GNUmakefile.am: Correct include paths.
1139
1140 2011-01-16  Adam Barth  <abarth@webkit.org>
1141
1142         Teach svn-apply about WebKit move.
1143
1144         * Scripts/VCSUtils.pm:
1145
1146 2011-01-16  Adam Barth  <abarth@webkit.org>
1147
1148         Rubber-stamped by Eric Seidel.
1149
1150         Move WebKit into Source
1151         https://bugs.webkit.org/show_bug.cgi?id=52530
1152
1153         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1154         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1155         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1156         * DumpRenderTree/qt/GCControllerQt.cpp:
1157         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1158         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1159         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1160         * DumpRenderTree/wscript:
1161         * QtTestBrowser/launcherwindow.h:
1162         * Scripts/build-webkit:
1163         * Scripts/webkitdirs.pm:
1164
1165 2011-01-15  Adam Barth  <abarth@webkit.org>
1166
1167         Teach svn-apply about WebKit2 move.
1168
1169         * Scripts/VCSUtils.pm:
1170
1171 2011-01-15  Adam Barth  <abarth@webkit.org>
1172
1173         Rubber-stamped by Eric Seidel.
1174
1175         Move WebKit2 into Source
1176         https://bugs.webkit.org/show_bug.cgi?id=52438
1177
1178         * MiniBrowser/qt/MiniBrowser.pro:
1179         * Scripts/build-webkit:
1180         * Scripts/do-file-rename:
1181         * Scripts/do-webcore-rename:
1182         * Scripts/test-webkitpy:
1183         * Scripts/webkitdirs.pm:
1184         * Scripts/webkitpy/style/checker.py:
1185         * WebKitTestRunner/DerivedSources.pro:
1186         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1187         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1188
1189 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1190
1191         Reviewed by David Levin.
1192
1193         [chromium] remove obsolete createView method
1194         https://bugs.webkit.org/show_bug.cgi?id=52437
1195
1196         * DumpRenderTree/chromium/WebViewHost.cpp:
1197         (WebViewHost::createView):
1198         * DumpRenderTree/chromium/WebViewHost.h:
1199
1200 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1201
1202         Reviewed by Geoff Garen.
1203
1204         ShouldLoadResourceForFrame should use strings, not URLs.
1205         https://bugs.webkit.org/show_bug.cgi?id=52476
1206
1207         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1208         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1209         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1210
1211 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1212
1213         Reviewed by David Levin.
1214
1215         Add Tony Gentilcore as a reviewer
1216         https://bugs.webkit.org/show_bug.cgi?id=52480
1217
1218         * Scripts/webkitpy/common/config/committers.py:
1219
1220 2011-01-14  David Levin  <levin@chromium.org>
1221
1222         Reviewed by Eric Seidel.
1223
1224         check-webkit-style: _FunctionState should keep track of where the function name starts.
1225         https://bugs.webkit.org/show_bug.cgi?id=52454
1226
1227         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1228         _FunctionState and logic for setting it correctly.
1229         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1230
1231 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1232
1233         Reviewed by David Levin.
1234
1235         Add support to DumpRenderTree to use the GPU rather than software renderer
1236         https://bugs.webkit.org/show_bug.cgi?id=52333
1237
1238         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1239         (main):
1240         * Scripts/webkitpy/layout_tests/port/chromium.py:
1241         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1242
1243 2011-01-14  Tony Chang  <tony@chromium.org>
1244
1245         Reviewed by Kent Tamura.
1246
1247         [chromium] update fonts.conf to fix 6 linux tests in drt
1248         https://bugs.webkit.org/show_bug.cgi?id=52411
1249
1250         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1251             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1252
1253 2011-01-14  Eric Seidel  <eric@webkit.org>
1254
1255         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1256
1257         Reviewed by Adam Barth.
1258
1259         Fix when running Tools/Scripts/check-webkit-style without arguments.
1260         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1261
1262         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1263         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1264
1265 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1266
1267         Reviewed by David Levin.
1268
1269         Store the tempdir object in a variable so it doesn't get deleted too early.
1270         https://bugs.webkit.org/show_bug.cgi?id=51875
1271
1272         * Scripts/update-webkit-auxiliary-libs:
1273         * Scripts/update-webkit-support-libs:
1274
1275 2011-01-14  Eric Seidel  <eric@webkit.org>
1276
1277         Unreviewed.  Make it work in python 2.5.
1278
1279         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1280         https://bugs.webkit.org/show_bug.cgi?id=49158
1281
1282         * Scripts/webkitpy/common/checkout/api_unittest.py:
1283
1284 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1285
1286         Unreviewed, rolling out r75774.
1287         http://trac.webkit.org/changeset/75774
1288         https://bugs.webkit.org/show_bug.cgi?id=52431
1289
1290         gtk builds were broken (Requested by loislo2 on #webkit).
1291
1292         * Scripts/webkitpy/common/checkout/scm.py:
1293
1294 2011-01-14  David Levin  <levin@chromium.org>
1295
1296         Reviewed by Shinichiro Hamaji.
1297
1298         check-webkit-style: _FunctionState should detect pure functions.
1299         https://bugs.webkit.org/show_bug.cgi?id=52428
1300
1301         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1302         is a pure virtual function.
1303         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1304         virtual functions are correctly detected.
1305
1306 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1307
1308         Reviewed by Yury Semikhatsky.
1309
1310         Just small fix for problem with check-webkit-style.
1311         It just didn't work for this patch.
1312         Old code can't concatenate a list of strings with None.
1313
1314         * Scripts/webkitpy/common/checkout/scm.py:
1315
1316 2011-01-13  David Levin  <levin@chromium.org>
1317
1318         Reviewed by Shinichiro Hamaji.
1319
1320         check-webkit-style: _FunctionState should use Position to know where items are.
1321         https://bugs.webkit.org/show_bug.cgi?id=52424
1322
1323         * Scripts/webkitpy/style/checkers/cpp.py:
1324         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1325         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1326         did some minor clean-up.
1327         (*): Other changes are simply about converting to use the Position's in_FunctionState
1328         instead of line numbers.
1329         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1330         to verify the positions stored in _FunctionState.
1331
1332 2011-01-13  Eric Seidel  <eric@webkit.org>
1333
1334         Reviewed by David Levin.
1335
1336         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1337         https://bugs.webkit.org/show_bug.cgi?id=49158
1338
1339         This is not the most elegant, but it is a very safe fix to this bug.
1340         One advantage of catching ScriptError like this instead of adding a
1341         new added_or_modified_files or fixing all changed_files callers
1342         to use a more specific change_files variant, is that we catch
1343         all kinds of ScriptErrors which might cause our (non-essential)
1344         suggest-reviewers code to fail out.  This should make passing
1345         --suggest-reviewers to webkit-patch upload much more robust
1346         and may even make it possible for us to make it default.
1347
1348         The root of the problem here is that SCM.changed_files includes
1349         deleted ChangeLog paths (from moves, etc) which then when we ask
1350         SVN/Git for the contents of the file at that revision, the command
1351         errors out and Executive.run_command raises a ScriptError.
1352
1353         In the future we might fix this differently by making all current
1354         callers of chagned_files use a more specific method for requesting
1355         what types of changes they're interested in (adds, modifies, deletes, etc.)
1356
1357         * Scripts/webkitpy/common/checkout/api.py:
1358         * Scripts/webkitpy/common/checkout/api_unittest.py:
1359
1360 2011-01-13  Dan Bernstein  <mitz@apple.com>
1361
1362         Reviewed by Alexey Proskuryakov.
1363
1364         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1365         https://bugs.webkit.org/show_bug.cgi?id=52419
1366
1367         Allow to further control the behavior of the willSendRequest delegate callback by making it
1368         set a different URL in the new request.
1369
1370         * DumpRenderTree/LayoutTestController.cpp:
1371         (addURLToRedirectCallback): Added.
1372         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1373         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1374         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1375         * DumpRenderTree/LayoutTestController.h:
1376         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1377         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1378         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1379         change the URL in the new request to the redirect destination.
1380
1381 2011-01-13  Eric Seidel  <eric@webkit.org>
1382
1383         Reviewed by Mihai Parparita.
1384
1385         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1386         https://bugs.webkit.org/show_bug.cgi?id=52416
1387
1388         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1389         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1390
1391         I also added FIXMEs about the changed_files returning deleted files problem
1392         which is causing the other most common exception for suggest-reviewers
1393         (and is probably breaking sheriff-bots blame detection).
1394
1395         * Scripts/webkitpy/common/checkout/api.py:
1396         * Scripts/webkitpy/common/checkout/api_unittest.py:
1397         * Scripts/webkitpy/common/checkout/scm.py:
1398
1399 2011-01-13  Eric Seidel  <eric@webkit.org>
1400
1401         Reviewed by Adam Barth.
1402
1403         results archives from commit-queue are too large to upload
1404         https://bugs.webkit.org/show_bug.cgi?id=52405
1405
1406         * Scripts/webkitpy/common/system/filesystem.py:
1407         * Scripts/webkitpy/common/system/filesystem_mock.py:
1408         * Scripts/webkitpy/tool/commands/queues.py:
1409
1410 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1411
1412         Reviewed by Martin Robinson.
1413
1414         [gtk] Zero-sized font does not yet work
1415         https://bugs.webkit.org/show_bug.cgi?id=49793
1416
1417         Set minimum-font-size to 0 for the DRT.
1418
1419         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1420         (resetDefaultsToConsistentValues):
1421
1422 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1423
1424         Reviewed by Darin Adler.
1425
1426         Make old-run-webkit-tests more robust on buildbots
1427         https://bugs.webkit.org/show_bug.cgi?id=52364
1428
1429         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1430
1431 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1432
1433         Reviewed by Darin Adler.
1434
1435         Make old-run-webkit-tests more robust on buildbots
1436         https://bugs.webkit.org/show_bug.cgi?id=52364
1437
1438         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1439
1440 2011-01-13  Tony Chang  <tony@chromium.org>
1441
1442         Reviewed by Kent Tamura.
1443
1444         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1445         https://bugs.webkit.org/show_bug.cgi?id=52332
1446
1447         Forked Info.plist is not longer needed.
1448
1449         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1450
1451 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1452
1453         Reviewed by Timothy Hatcher.
1454
1455         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1456         to be passed directly to WebInspector.UIString
1457
1458         https://bugs.webkit.org/show_bug.cgi?id=52365
1459
1460         * Scripts/check-inspector-strings:
1461
1462 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1463
1464         Unreviewed, rolling out r74881.
1465         http://trac.webkit.org/changeset/74881
1466         https://bugs.webkit.org/show_bug.cgi?id=52357
1467
1468         The EFL builder has been red for days (Requested by abarth on
1469         #webkit).
1470
1471         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1472         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1473
1474 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1475
1476         Reviewed by David Levin.
1477
1478         Add beforeunload support to WebKitTestRunner
1479         https://bugs.webkit.org/show_bug.cgi?id=52353
1480         
1481         This makes a number of currently failing tests pass.
1482
1483         * WebKitTestRunner/TestController.cpp:
1484         (WTR::runBeforeUnloadConfirmPanel):
1485         (WTR::createOtherPage):
1486         (WTR::TestController::initialize):
1487
1488 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1489
1490         Reviewed by Sam Weinig.
1491
1492         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1493         https://bugs.webkit.org/show_bug.cgi?id=52330
1494
1495         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1496         a web process crash.
1497         * WebKitTestRunner/TestController.cpp:
1498         (WTR::TestController::initialize): Set up a processDidCrash
1499         callback.
1500         (WTR::TestController::processDidCrash): Report that the Web process
1501         crashed.
1502         * WebKitTestRunner/TestController.h:
1503
1504 2011-01-12  David Levin  <levin@chromium.org>
1505
1506         Reviewed by Shinichiro Hamaji.
1507
1508         check-webkit-style -- close_expression function doesn't work correctly.
1509         https://bugs.webkit.org/show_bug.cgi?id=52272
1510
1511         * Scripts/webkitpy/style/checkers/cpp.py:
1512         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1513         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1514         generally useful (for upcoming code changes).
1515         (close_expression): Changed to use Position for input and output.
1516         Also, fixed many bugs such as only working correctly for parenthesis,
1517         not working correctly if given an offset in a line and not finding
1518         the real closing element if there were multiple closing elements in
1519         the same line.
1520         (detect_functions): Adjusted due to the change in arguments for
1521         close_expression.
1522         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1523         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1524         two positions are the same.
1525         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1526         (CppStyleTest.test_close_expression): Added tests to catch the issues
1527         that were fixed.
1528
1529 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1530
1531         Unreviewed, rolling out r75576.
1532         http://trac.webkit.org/changeset/75576
1533         https://bugs.webkit.org/show_bug.cgi?id=52304
1534
1535         broke rebaseline-chromium-webkit-test (Requested by thakis on
1536         #webkit).
1537
1538         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1539         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1540         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1541         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1542         * Scripts/webkitpy/layout_tests/port/base.py:
1543         * Scripts/webkitpy/layout_tests/port/chromium.py:
1544         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1545         * Scripts/webkitpy/layout_tests/port/test.py:
1546         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1547         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1548         * Scripts/webkitpy/style/checkers/test_expectations.py:
1549         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1550
1551 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1552
1553         Reviewed by Darin Adler.
1554
1555         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1556         https://bugs.webkit.org/show_bug.cgi?id=52307
1557
1558         * Scripts/old-run-webkit-tests:
1559
1560 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1561
1562         Reviewed by Martin Robinson.
1563
1564         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1565         https://bugs.webkit.org/show_bug.cgi?id=50867
1566
1567         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1568         TestNetscapePlugin.cpp 
1569
1570         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1571         * Scripts/webkitdirs.pm:
1572
1573 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1574
1575         Reviewed by Pavel Feldman.
1576
1577         Add check-inspector-strings script.
1578
1579         https://bugs.webkit.org/show_bug.cgi?id=52295
1580
1581         * Scripts/check-inspector-strings: Added.
1582
1583 2011-01-12  Adam Roben  <aroben@apple.com>
1584
1585         Advertise the .testnetscape file extension on Windows
1586
1587         Fixes <http://webkit.org/b/52298>
1588         plugins/no-mime-with-valid-extension.html fails on Windows
1589
1590         Reviewed by Dan Bernstein.
1591
1592         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1593         FileExtents field to map the .testnetscape file extension to the
1594         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1595
1596 2011-01-12  Adam Barth  <abarth@webkit.org>
1597
1598         Reviewed by Eric Seidel.
1599
1600         Make webkit-patch support subdirectories for SVN checkouts
1601         https://bugs.webkit.org/show_bug.cgi?id=52261
1602
1603         os.relpath does not exist on Python 2.5, so we need to call our version
1604         of the API.
1605
1606         * Scripts/webkitpy/common/checkout/scm.py:
1607
1608 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1609
1610         Reviewed by Eric Seidel.
1611
1612         Close additional pages opened during a test once the test completes.
1613         https://bugs.webkit.org/show_bug.cgi?id=52276
1614
1615         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1616         (WTR::InjectedBundle::done):
1617
1618 2011-01-11  David Levin  <levin@chromium.org>
1619
1620         Reviewed by Eric Seidel.
1621
1622         Errors should be separated from the command line in bot messages.
1623         https://bugs.webkit.org/show_bug.cgi?id=52275
1624
1625         * Scripts/webkitpy/common/system/executive.py:
1626         (ScriptError.message_with_output): Added a newline to separate the command
1627         line from the errors.
1628         * Scripts/webkitpy/common/system/executive_unittest.py:
1629         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1630         paths in message_with_output.
1631
1632 2011-01-11  Eric Seidel  <eric@webkit.org>
1633
1634         Unreviewed.
1635
1636         commit-queue should know how to upload archived results (for test flakes or general failures)
1637         https://bugs.webkit.org/show_bug.cgi?id=52048
1638
1639         The zips are mostly empty due to forgetting -r.
1640         Expected diffs were not being pulled from the archive due
1641         to the archive having longer paths than I realized.
1642
1643         * Scripts/webkitpy/common/system/workspace.py:
1644         * Scripts/webkitpy/common/system/workspace_unittest.py:
1645         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1646         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1647
1648 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1649
1650         Reviewed by Ojan Vafai.
1651
1652         The current modifier parsing code in test_expectations is
1653         fragile and hard-coded, so it's not easy to understand the logic
1654         or easily add new types of modifiers (like GPU vs. CPU testing
1655         for graphics tests, or 32-bit vs. 64-bit differences).
1656
1657         This is the first of two patches that will add in more generic
1658         support and then eliminate the GPU-specific test expectations
1659         files for Chromium.
1660
1661         This patch adds two standalone objects for handling modifiers. The
1662         rules for interpreting modifiers, precedence, and conflicts are
1663         given in the docstring to the ModifierMatcher class, which
1664         returns ModifierMatchResult objects.
1665         
1666         This patch also adds routines to the Port interface and a
1667         default set of values in the base object, in order to obtain the
1668         values needed on a given test run. These values are then passed
1669         to the expectation parser. This also allows us to clean up the
1670         logic used to lint all of the different configurations in a
1671         single test_expectations.txt file.
1672
1673         The next patch will merge in the separate GPU expectations file.
1674
1675         https://bugs.webkit.org/show_bug.cgi?id=51222
1676
1677         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1678         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1679         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1680         * Scripts/webkitpy/layout_tests/port/base.py:
1681         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1682         * Scripts/webkitpy/layout_tests/port/chromium.py:
1683         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1684         * Scripts/webkitpy/layout_tests/port/test.py:
1685         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1686         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1687
1688 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1689
1690         Reviewed by Adam Barth.
1691
1692         Make webkit-patch support subdirectories for SVN checkouts
1693         https://bugs.webkit.org/show_bug.cgi?id=52261
1694
1695         * Scripts/webkitpy/common/checkout/scm.py:
1696         * Scripts/webkitpy/style_references.py:
1697         * Scripts/webkitpy/tool/main.py:
1698         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1699
1700 2011-01-11  Eric Seidel  <eric@webkit.org>
1701
1702         Unreviewed.
1703
1704         commit-queue should know how to upload archived results (for test flakes or general failures)
1705         https://bugs.webkit.org/show_bug.cgi?id=52048
1706
1707         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1708         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1709
1710         * Scripts/webkitpy/common/system/workspace.py:
1711         * Scripts/webkitpy/common/system/workspace_unittest.py:
1712         * Scripts/webkitpy/tool/commands/queues.py:
1713
1714 2011-01-11  Sam Weinig  <sam@webkit.org>
1715
1716         Roll r75474 back in.
1717
1718 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1719
1720         Reviewed by Kenneth Rohde Christiansen.
1721
1722         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1723         https://bugs.webkit.org/show_bug.cgi?id=51204
1724
1725         * QtTestBrowser/webpage.h:
1726         (QtNAMThread::QtNAMThread):
1727         (QtNAMThread::networkAccessManager):
1728         (QtNAMThread::run):
1729
1730 2011-01-11  Peter Varga  <pvarga@webkit.org>
1731
1732         Unreviewed.
1733
1734         Add myself to committers' list.
1735
1736         * Scripts/webkitpy/common/config/committers.py:
1737
1738 2011-01-11  Eric Seidel  <eric@webkit.org>
1739
1740         Reviewed by Adam Barth.
1741
1742         commit-queue should know how to upload archived results (for test flakes or general failures)
1743         https://bugs.webkit.org/show_bug.cgi?id=52048
1744
1745         Now the queue will always upload results.  Either the entire zip, or just
1746         the diffs.txt in the case of text failures.
1747
1748         This should make understanding flakes much easier, and paves the way
1749         for having the EWS run layout tests (and upload failures).
1750
1751         In order to upload .zip files I had to teach bugzilla.py to autodetect
1752         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1753         for .patch files, I have it add one before calling guess_type.
1754
1755         We may find that always uploading the whole zip instead of just the -diffs.txt
1756         file is preferable, but for now I'm keeping the old behavior because it makes
1757         quickly understanding text failures easy.
1758
1759         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1760         * Scripts/webkitpy/common/system/workspace.py: Added.
1761         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1762         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1763         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1764         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1765         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1766         * Scripts/webkitpy/tool/commands/queues.py:
1767         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1768
1769 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1770
1771         Unreviewed, rolling out r75464.
1772         http://trac.webkit.org/changeset/75464
1773         https://bugs.webkit.org/show_bug.cgi?id=52193
1774
1775         Followup rollout for 75474 (Requested by Ossy on #webkit).
1776
1777         * MiniBrowser/mac/BrowserWindowController.m:
1778         (-[BrowserWindowController awakeFromNib]):
1779         * MiniBrowser/win/BrowserView.cpp:
1780         (BrowserView::create):
1781         * WebKitTestRunner/TestController.cpp:
1782         (WTR::createOtherPage):
1783         (WTR::TestController::initialize):
1784
1785 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1786
1787         Reviewed by Csaba Osztrogonác.
1788
1789         [Qt] Baseline qt_minimal configuration
1790         https://bugs.webkit.org/show_bug.cgi?id=51313
1791
1792         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1793         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1794         QT_NO_UNDOSTACK guard.
1795
1796         * QtTestBrowser/launcherwindow.cpp:
1797         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1798         guards.
1799         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1800         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1801         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1802         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1803
1804         * QtTestBrowser/launcherwindow.h:
1805         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1806         * QtTestBrowser/locationedit.h: Ditto.
1807
1808         * QtTestBrowser/mainwindow.cpp:
1809         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1810         QT_NO_UNDOSTACK guards.
1811         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1812         (MainWindow::changeLocation): Ditto.
1813         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1814         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1815
1816         * QtTestBrowser/webpage.cpp:
1817         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1818         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1819
1820         * QtTestBrowser/webview.cpp:
1821         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1822         (WebViewGraphicsBased::animatedYFlip): Ditto.
1823
1824 2011-01-10  Sam Weinig  <sam@webkit.org>
1825
1826         Fix build.
1827
1828         * MiniBrowser/mac/BrowserWindowController.m:
1829         (-[BrowserWindowController awakeFromNib]):
1830         * MiniBrowser/win/BrowserView.cpp:
1831         (BrowserView::create):
1832         * WebKitTestRunner/TestController.cpp:
1833         (WTR::createOtherPage):
1834         (WTR::TestController::initialize):
1835
1836 2011-01-10  Eric Seidel  <eric@webkit.org>
1837
1838         Reviewed by Ojan Vafai.
1839
1840         style-queue messages are way too long for big patches
1841         https://bugs.webkit.org/show_bug.cgi?id=52161
1842
1843         We definitely could build much fancier list-to-string-with-limit functions
1844         but this should be sufficient for our needs at the moment.
1845
1846         * Scripts/webkitpy/common/system/executive.py:
1847         * Scripts/webkitpy/common/system/executive_unittest.py:
1848
1849 2011-01-10  Tony Chang  <tony@chromium.org>
1850
1851         Unreviewed, rolling out r75398.
1852         http://trac.webkit.org/changeset/75398
1853         https://bugs.webkit.org/show_bug.cgi?id=52008
1854
1855         Some layout tests are crashing on Chromium Win.
1856
1857         * DumpRenderTree/chromium/WebViewHost.cpp:
1858         (WebViewHost::updatePaintRect):
1859         * DumpRenderTree/chromium/WebViewHost.h:
1860
1861 2011-01-10  Adam Roben  <aroben@apple.com>
1862
1863         Roll out r75392
1864
1865         It isn't needed now that r75289 has been rolled out.
1866
1867         * Scripts/run-javascriptcore-tests:
1868
1869 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1870
1871         Reviewed by Anders Carlsson.
1872
1873         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1874         https://bugs.webkit.org/show_bug.cgi?id=52160
1875
1876         * WebKitTestRunner/mac/TestControllerMac.mm:
1877         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1878         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1879         anyway.
1880
1881 2011-01-10  Tony Chang  <tony@chromium.org>
1882
1883         Reviewed by Mihai Parparita.
1884
1885         [chromium] fix for animated gif layout tests
1886         https://bugs.webkit.org/show_bug.cgi?id=52008
1887
1888         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1889             to trigger gif animations.
1890         (WebViewHostPaintTask::WebViewHostPaintTask):
1891         (WebViewHostPaintTask::runIfValid):
1892         (WebViewHost::updatePaintRect):
1893         * DumpRenderTree/chromium/WebViewHost.h:
1894         (WebViewHost::taskList):
1895
1896 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1897
1898         Reviewed by Xan Lopez.
1899
1900         [GTK] Fix gtk2 compilation for master
1901         https://bugs.webkit.org/show_bug.cgi?id=51885
1902
1903         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1904         (createBitmapContextFromWebView): Replaced the old
1905         gdk_drawable_get_size with gdk_pixmap_get_size.
1906
1907 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1908
1909         Reviewed by Laszlo Gombos.
1910
1911         [WINCE] Reenable NPAPI after r75203
1912         https://bugs.webkit.org/show_bug.cgi?id=52109
1913
1914         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1915         it with !isEfl(), because EFL port does not support NPAPI (yet).
1916
1917         * Scripts/build-webkit:
1918
1919 2011-01-10  Adam Roben  <aroben@apple.com>
1920
1921         Skip some asserting JS tests
1922
1923         See <http://webkit.org/b/52156>.
1924
1925         * Scripts/run-javascriptcore-tests:
1926
1927 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1928
1929         Reviewed by Xan Lopez.
1930
1931         [GTK] build-webkit disable Blob support via arguments passed to automake
1932         https://bugs.webkit.org/show_bug.cgi?id=52097
1933
1934         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1935         build-webkit.
1936
1937 2011-01-10  Adam Roben  <aroben@apple.com>
1938
1939         Use the same name and description for TestNetscapePlugin on Windows and
1940         Mac
1941
1942         Fixes <http://webkit.org/b/52151>
1943         fast/frames/iframe-reparenting-plugins.html fails on Windows
1944
1945         Reviewed by Steve Falkenburg.
1946
1947         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1948         the name and description from Mac's Info.plist.
1949
1950 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1951
1952         Reviewed by Laszlo Gombos.
1953
1954         [Qt][WK2] Guard gcc-specific syntax
1955
1956         Non-gcc based compliers choke on the "-include"
1957         syntax for preinclude, place guard around it.
1958
1959         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1960         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1961
1962 2011-01-10  Andreas Kling  <kling@webkit.org>
1963
1964         Reviewed by Simon Hausmann.
1965
1966         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1967         https://bugs.webkit.org/show_bug.cgi?id=52111
1968
1969         When getting a createNewPage() callback from QWKPage, create the
1970         new page with the same QWKContext as the page that is passed to
1971         the callback.
1972
1973         * MiniBrowser/qt/BrowserView.h:
1974         * MiniBrowser/qt/BrowserWindow.cpp:
1975         (newPageFunction):
1976         (BrowserWindow::BrowserWindow):
1977         * MiniBrowser/qt/BrowserWindow.h:
1978
1979 2011-01-10  Andreas Kling  <kling@webkit.org>
1980
1981         Reviewed by Kenneth Rohde Christiansen.
1982
1983         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1984
1985         BrowserView set its own useless createNewPage() callback on QWKPage.
1986         This was immediately overridden by BrowserWindow anyway, so remove
1987         the BrowserView one.
1988
1989         * MiniBrowser/qt/BrowserView.cpp:
1990         (BrowserView::BrowserView):
1991
1992 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1993
1994         Reviewed by Jeremy Orlow.
1995
1996         [Chromium] Remove non-client-based Geolocation code
1997         https://bugs.webkit.org/show_bug.cgi?id=50921
1998
1999         * DumpRenderTree/chromium/LayoutTestController.cpp:
2000         (LayoutTestController::setGeolocationPermission):
2001         (LayoutTestController::setMockGeolocationPosition):
2002         (LayoutTestController::setMockGeolocationError):
2003         * DumpRenderTree/chromium/WebViewHost.cpp:
2004         (WebViewHost::geolocationClientMock):
2005         (WebViewHost::reset):
2006         * DumpRenderTree/chromium/WebViewHost.h:
2007
2008 2011-01-10  Eric Seidel  <eric@webkit.org>
2009
2010         Reviewed by Adam Barth.
2011
2012         Commit bot tried to land r? cq+ patch
2013         https://bugs.webkit.org/show_bug.cgi?id=36638
2014
2015         It should now be possible to post a patch with r? and cq+ and the
2016         commit-queue will correctly wait for the r+ before attempting to land the patch.
2017         (This was a feature requested by several users.)
2018
2019         One caveat: We don't actually reject r-, cq+ patches from the queue
2020         (we just ignore them), but I think that's OK for now.
2021
2022         I also noticed that setting r- once a commit-queue node had grabbed
2023         a patch would not properly cancel the landing.  That's fixed and
2024         tested in this patch.
2025
2026         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2027         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2028         * Scripts/webkitpy/tool/bot/feeders.py:
2029         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2030
2031 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2032
2033         Reviewed by Kenneth Rohde Christiansen.
2034
2035         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2036         https://bugs.webkit.org/show_bug.cgi?id=51934
2037
2038         When accessing the network from the destructor of QWebPage, the network access manager
2039         was already deleted because the object WebPage was already destructed.
2040
2041         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2042         The object is now destructed in the destructor of QObject.
2043
2044         * QtTestBrowser/webpage.cpp:
2045         (WebPage::WebPage):
2046         (WebPage::setQnamThreaded):
2047         * QtTestBrowser/webpage.h:
2048         (QtNAMThread::QtNAMThread):
2049
2050 2011-01-08  Eric Seidel  <eric@webkit.org>
2051
2052         Reviewed by Ojan Vafai.
2053
2054         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2055         https://bugs.webkit.org/show_bug.cgi?id=52067
2056
2057         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2058         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2059
2060         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2061
2062 2011-01-08  Eric Seidel  <eric@webkit.org>
2063
2064         Reviewed by Mihai Parparita.
2065
2066         commit-queue hangs when the ChangeLog diff is bad
2067         https://bugs.webkit.org/show_bug.cgi?id=52072
2068
2069         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2070         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2071
2072 2011-01-08  Adam Barth  <abarth@webkit.org>
2073
2074         Teach svn-apply how to re-write WebCore to Source/WebCore.
2075
2076         * Scripts/VCSUtils.pm:
2077
2078 2011-01-07  Adam Barth  <abarth@webkit.org>
2079
2080         Rubber-stamped by Eric Seidel.
2081
2082         Move WebCore to Source
2083         https://bugs.webkit.org/show_bug.cgi?id=52050
2084
2085         Update the tools to understand WebCore's new location.
2086
2087         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2088         * DumpRenderTree/wscript:
2089         * GNUmakefile.am:
2090         * Scripts/build-webkit:
2091         * Scripts/do-file-rename:
2092         * Scripts/do-webcore-rename:
2093         * Scripts/generate-qt-inspector-resource:
2094         * Scripts/prepare-ChangeLog:
2095         * Scripts/run-bindings-tests:
2096         * Scripts/update-iexploder-cssproperties:
2097         * Scripts/update-sources-list.py:
2098         * Scripts/update-webkit-localizable-strings:
2099         * Scripts/webkitdirs.pm:
2100         * Scripts/webkitpy/common/config/build.py:
2101         * Scripts/webkitpy/common/config/build_unittest.py:
2102         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2103         * Scripts/webkitpy/style/checker.py:
2104         * Scripts/webkitpy/style/checker_unittest.py:
2105         * WebKitTestRunner/DerivedSources.pro:
2106         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2107         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2108         * wx/browser/wscript:
2109         * wx/build/settings.py:
2110
2111 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2112
2113         Reviewed by Sam Weinig.
2114
2115         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2116         https://bugs.webkit.org/show_bug.cgi?id=52086
2117
2118         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2119         (WTR::InjectedBundle::didReceiveMessage):
2120         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2121         (WTR::LayoutTestController::notifyDone):
2122         * WebKitTestRunner/TestController.cpp:
2123         (WTR::TestController::resetStateToConsistentValues):
2124         (WTR::TestController::run):
2125
2126 2011-01-07  James Robinson  <jamesr@chromium.org>
2127
2128         Revert "Implement mozilla's animationTime property"
2129         https://bugs.webkit.org/show_bug.cgi?id=51952
2130
2131         This approach isn't quite right.
2132
2133         * DumpRenderTree/chromium/WebViewHost.cpp:
2134         (WebViewHost::paintInvalidatedRegion):
2135
2136 2011-01-07  Adam Roben  <aroben@apple.com>
2137
2138         Build master fix
2139
2140         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2141         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2142
2143 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2144
2145         Reviewed by Csaba Osztrogonác.
2146
2147         run-qtwebkit-tests should be able to kill a testsuite.
2148
2149         Add new option in the script that can setup a timeout for a test.
2150         If the test execution takes more then specified time then the test
2151         would be terminated.
2152
2153         [Qt] run-qtwebkit-tests needs timeout
2154         https://bugs.webkit.org/show_bug.cgi?id=51894
2155
2156         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2157         * Scripts/run-qtwebkit-tests:
2158
2159 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2160
2161         Unreviewed fix after r75233.
2162
2163         Based on idea from Eric Seidel.
2164
2165         Add remote zip file handling to webkitpy.
2166         https://bugs.webkit.org/show_bug.cgi?id=50901
2167
2168         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2169
2170 2011-01-07  Shane Stephens  <shanestephens@google.com>
2171
2172         Reviewed by Eric Seidel.
2173
2174         svn-apply: should support git binary delta diffs
2175         https://bugs.webkit.org/show_bug.cgi?id=38864
2176
2177         * Scripts/VCSUtils.pm:
2178         * Scripts/svn-apply:
2179
2180 2011-01-06  Julie Parent  <jparent@chromium.org>
2181
2182         Reviewed by Eric Seidel.
2183
2184         Test Result Server not removing old results.
2185         https://bugs.webkit.org/show_bug.cgi?id=52012
2186
2187         * TestResultServer/model/jsonresults.py:
2188         Fix off-by-one: Truncate if >= num_runs, not just >.
2189         * TestResultServer/model/jsonresults_unittest.py:
2190         Add unit test to test that merging in a new result with the same value
2191         as the last result causes previous result to fall off.
2192
2193 2011-01-06  James Kozianski  <koz@chromium.org>
2194
2195         Reviewed by Mihai Parparita.
2196
2197         Add classes to provide a consistent interface to a set of files.
2198         https://bugs.webkit.org/show_bug.cgi?id=50901
2199
2200         These classes allow us to write code that is agnostic to whether a
2201         particular set of files resides in a local directory or in a zip file
2202         on a remote machine.
2203
2204         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2205         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2206         * Scripts/webkitpy/common/system/fileset.py: Added.
2207         * Scripts/webkitpy/common/system/filesystem.py:
2208         * Scripts/webkitpy/common/system/filesystem_mock.py:
2209         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2210         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2211
2212 2011-01-06  Eric Seidel  <eric@webkit.org>
2213
2214         Reviewed by Adam Barth.
2215
2216         NetworkTransaction should log the url it is retrying
2217         https://bugs.webkit.org/show_bug.cgi?id=52043
2218
2219         * Scripts/webkitpy/common/net/networktransaction.py:
2220         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2221
2222 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2223
2224         Windows build fix.
2225         Import os before using it.
2226
2227         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2228
2229 2011-01-06  Eric Seidel  <eric@webkit.org>
2230
2231         Reviewed by Adam Barth.
2232
2233         StyleQueue fails to report errors when patches have many files
2234         https://bugs.webkit.org/show_bug.cgi?id=52042
2235
2236         This is one of at least two errors preventing style error reporting at the moment.
2237         When we moved to passing the list of files to check explicitly,
2238         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2239         We could change the type of the QueueStatus.message type, or we could
2240         just teach statusserver.py how to clamp values (and warn when it does).
2241         I chose the latter path.
2242
2243         * Scripts/webkitpy/common/net/statusserver.py:
2244
2245 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2246
2247         Reviewed by Stephanie Lewis.
2248         
2249         Fix syntax error in script.
2250
2251         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2252         https://bugs.webkit.org/show_bug.cgi?id=51996
2253
2254         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2255
2256 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2257
2258         Unreviewed, fixing WinCE build after r75196.
2259
2260         WinCE port does not (yet) support NPAPI.
2261
2262         * Scripts/build-webkit:
2263
2264 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2265
2266         Reviewed by Darin Adler.
2267
2268         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2269         https://bugs.webkit.org/show_bug.cgi?id=52015
2270
2271         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2272         after the platform has been detected, otherwise the script will
2273         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2274         detection.
2275
2276 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2277
2278         Reviewed by Eric Seidel.
2279
2280         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2281         https://bugs.webkit.org/show_bug.cgi?id=51346
2282
2283         * Scripts/build-webkit:
2284
2285 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2286
2287         Reviewed by Adam Roben.
2288
2289         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2290         https://bugs.webkit.org/show_bug.cgi?id=51996
2291         
2292         After the configuration directory change, we were archiving the incorrect directory for
2293         build product, so we were running tests on the wrong binaries.
2294         
2295         This change archives the correct directory, and also unarchives it into a configuration-
2296         specific directory.
2297
2298         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2299         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2300
2301 2011-01-06  Eric Seidel  <eric@webkit.org>
2302
2303         Reviewed by Mihai Parparita.
2304
2305         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2306         https://bugs.webkit.org/show_bug.cgi?id=52002
2307
2308         See an example of this here:
2309         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2310
2311         It's due to the fact that we pass around TestFailure() instance
2312         objects and yet expect them to all compare to be the same.
2313
2314         This is bad.  We should either have shared instances of these values
2315         or we should just pass around the class names.  There are already hacks
2316         in place to make TestFailure objects pass equality tests, I just added
2317         a __hash__ implementation so they can be used in sets as expected.
2318
2319         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2320         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2321
2322 2011-01-06  Evan Martin  <evan@chromium.org>
2323
2324         Reviewed by Tony Chang.
2325
2326         [gdb] handle inaccessible memory and UChar*
2327         https://bugs.webkit.org/show_bug.cgi?id=52003
2328
2329         To pretty-print a UChar*, we just grope around in the memory
2330         looking for a terminating NUL.  We need to handle the exception
2331         that can occur when we poke into an invalid location.
2332
2333         Additionally, the logic for choosing which pretty-printer would
2334         early return before hitting the point where we'd use the UChar*
2335         printer.  (Did this ever work?  How did it regress?)
2336
2337         * gdb/webkit.py:
2338
2339 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2340
2341         Reviewed by Ada Chan.
2342
2343         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2344         https://bugs.webkit.org/show_bug.cgi?id=51969
2345         
2346         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2347
2348         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2349         (WTR::InjectedBundlePage::InjectedBundlePage):
2350         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2351         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2352
2353 2011-01-06  James Robinson  <jamesr@chromium.org>
2354
2355         Reviewed by Simon Fraser.
2356
2357         Implement mozilla's animationTime property
2358         https://bugs.webkit.org/show_bug.cgi?id=51952
2359
2360         Chromium DRT support for webkitAnimationTime.
2361
2362         * DumpRenderTree/chromium/WebViewHost.cpp:
2363         (WebViewHost::paintInvalidatedRegion):
2364
2365 2011-01-06  Julie Parent  <jparent@chromium.org>
2366
2367         Reviewed by Tony Chang.
2368
2369         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2370         https://bugs.webkit.org/show_bug.cgi?id=51217
2371
2372         * TestResultServer/model/jsonresults.py:
2373         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2374         Adds missing documentation.
2375         * TestResultServer/model/jsonresults_unittest.py:
2376         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2377         Update test_merge to take a number of builds to truncate at.
2378
2379 2011-01-06  Adam Barth  <abarth@webkit.org>
2380
2381         Reviewed by Eric Seidel.
2382
2383         The EWS should log outside of the working directory
2384         https://bugs.webkit.org/show_bug.cgi?id=51986
2385
2386         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2387         script, which will actually clean the working copy back to a pristine
2388         state instead of leaving untracked directories and ignored files.
2389
2390         * Scripts/webkitpy/tool/commands/queues.py:
2391         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2392
2393 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2394
2395         Windows build fix.
2396         Back out attempted change to built-product-archive.
2397
2398         * BuildSlaveSupport/built-product-archive:
2399
2400 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2401
2402         Windows build fix.
2403         Include configuration name when unpacking a build archive.
2404
2405         Needed, since we split Windows build results into configuration-specific directories
2406         under WebKitOutputDir.
2407
2408         * BuildSlaveSupport/built-product-archive:
2409
2410 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2411
2412         Reviewed by Darin Adler.
2413
2414         Debug and Release builds on Windows clobber each other
2415         https://bugs.webkit.org/show_bug.cgi?id=49185
2416
2417         Changes the structure of WebKitBuild build products directory so we
2418         completely separate each build configuration into independent directories.
2419         
2420         Although we previously had per-configuration directories for obj, this change adds
2421         per-configuration directories for bin, lib, obj, and include. Each configuration's
2422         build products are stored within a directory inside of WebKitBuild.
2423         
2424         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2425         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2426
2427         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2428         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2429         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2430         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2431         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2432         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2433         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2434         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2435         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2436         * FindSafari/FindSafari.vcproj:
2437         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2438         * MiniBrowser/MiniBrowserPostBuild.cmd:
2439         * MiniBrowser/MiniBrowserPreBuild.cmd:
2440         * Scripts/webkitdirs.pm:
2441         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2442         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2443         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2444         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2445         * TestWebKitAPI/win/copy-resources.cmd:
2446         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2447         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2448         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2449         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2450         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2451         * WebKitTestRunner/win/InjectedBundle.vcproj:
2452         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2453         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2454         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2455         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2456         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2457         * WinLauncher/WinLauncherCommon.vsprops:
2458         * WinLauncher/WinLauncherPostBuild.cmd:
2459         * WinLauncher/WinLauncherPreBuild.cmd:
2460
2461 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2462
2463         Reviewed by Ariya Hidayat.
2464
2465         [Qt] TestNetscapePlugin doesn't link on OS X
2466         https://bugs.webkit.org/show_bug.cgi?id=51948
2467
2468         Only add a dependency on libX11 on X11 systems
2469
2470         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2471
2472 2011-01-05  Jeff Miller  <jeffm@apple.com>
2473
2474         Reviewed by Adam Roben.
2475
2476         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2477         https://bugs.webkit.org/show_bug.cgi?id=51970
2478
2479         * Scripts/webkitpy/style/checker.py:
2480         Add -readability/naming for WebKit2 C API directories.
2481
2482 2011-01-05  Eric Seidel  <eric@webkit.org>
2483
2484         Unreviewed, just fixing one more log error from my previous python patch.
2485
2486         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2487         https://bugs.webkit.org/show_bug.cgi?id=51802
2488
2489         webkit-patch failure-reason was logging about parsing errors
2490         due to my misunderstanding of how BeautifulSoup.findAll worked.
2491
2492         Fixed, and added a unit test.
2493
2494         * Scripts/webkitpy/common/net/layouttestresults.py:
2495         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2496
2497 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2498
2499         Reviewed by Kenneth Rohde Christiansen.
2500
2501         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2502         https://bugs.webkit.org/show_bug.cgi?id=51951
2503
2504         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2505         to create new window from WebKit.
2506
2507         * MiniBrowser/qt/BrowserWindow.cpp:
2508         (newPageFunction):
2509         (BrowserWindow::BrowserWindow):
2510         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2511         (BrowserWindow::newWindow):
2512         (BrowserWindow::updateUserAgentList):
2513         (BrowserWindow::showUserAgentDialog):
2514         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2515         define the type of the backing store used for new windows.
2516         * MiniBrowser/qt/main.cpp:
2517         (main):
2518
2519 2011-01-05  Eric Seidel  <eric@webkit.org>
2520
2521         Reviewed by Ojan Vafai.
2522
2523         commit-queue should report failure type when reporting flaky tests
2524         https://bugs.webkit.org/show_bug.cgi?id=51900
2525
2526         This patch was a ridiculous amount of plumbing.  In the end I like
2527         the NRWT-style TestResult class even less.  But now we're passing
2528         a list of TestResult objects from the queue to the FlakyTestReporter.
2529         Thus the FlakyTestReporter can more easily report what type of failure
2530         occurred.
2531
2532         In the process, I found that I was not alone in finding TestResult
2533         cumbersome to use.  A bunch of code was trying to create a TestResult
2534         object with default values.  However since the constructor didn't make
2535         this easy, some places were getting it wrong (including the TestResult unit test)!
2536         I've fixed the TestResult constructor to have default values for non-essential
2537         arguments.
2538
2539         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2540         * Scripts/webkitpy/common/net/layouttestresults.py:
2541         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2542         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2543         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2544         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2545         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2546         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2547         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2548         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2549         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2550         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2551         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2552         * Scripts/webkitpy/tool/commands/queues.py:
2553         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2554
2555 2011-01-05  Eric Seidel  <eric@webkit.org>
2556
2557         Unreviewed.
2558
2559         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2560         https://bugs.webkit.org/show_bug.cgi?id=51802
2561
2562         Add another unit test to cover a previously missing import.
2563
2564         * Scripts/webkitpy/common/net/layouttestresults.py:
2565         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2566
2567 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2568
2569         Reviewed by David Levin.
2570
2571         Add mihaip@chromium.org as a reviewer
2572         https://bugs.webkit.org/show_bug.cgi?id=51966
2573         
2574         Add myself as a reviewer.
2575
2576         * Scripts/webkitpy/common/config/committers.py:
2577
2578 2011-01-05  James Simonsen  <simonjam@chromium.org>
2579
2580         Unreviewed. Adding myself to the list of committers.
2581
2582         * Scripts/webkitpy/common/config/committers.py:
2583
2584 2011-01-05  Eric Seidel  <eric@webkit.org>
2585
2586         Unreviewed.
2587
2588         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2589         https://bugs.webkit.org/show_bug.cgi?id=51802
2590
2591         Fix two exceptions seen on the bots after my original commit.
2592
2593         * Scripts/webkitpy/common/net/layouttestresults.py:
2594         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2595
2596 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2597
2598         Reviewed by Andreas Kling.
2599
2600         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2601         https://bugs.webkit.org/show_bug.cgi?id=51750
2602
2603         * QtTestBrowser/main.cpp:
2604         (LauncherApplication::handleUserOptions):
2605          Local storage settings can be enable form command line arguments for
2606          QtTestBrowser.
2607
2608 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2609
2610         Reviewed by Martin Robinson.
2611
2612         GTK: AX: DRT needs to use correct root object method.
2613         https://bugs.webkit.org/show_bug.cgi?id=51911
2614
2615         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2616         (AccessibilityController::rootElement):
2617
2618 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2619
2620         Rubber-stamped by Csaba Osztrogonác.
2621
2622         Based on idea from Péter Gál.
2623
2624         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2625
2626 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2627
2628         Reviewed by Adam Barth.
2629
2630         sheriff-bot should be able to do multi-revision rollouts
2631         https://bugs.webkit.org/show_bug.cgi?id=51176
2632
2633         * Scripts/webkitpy/tool/bot/irc_command.py:
2634         * Scripts/webkitpy/tool/bot/sheriff.py:
2635         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2636
2637 2011-01-05  Eric Seidel  <eric@webkit.org>
2638
2639         Reviewed by Adam Barth.
2640
2641         queues.webkit.org should have per-bot status pages
2642         https://bugs.webkit.org/show_bug.cgi?id=51906
2643
2644         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2645         statuses from a single queue.  Now that we have many bots servicing
2646         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2647         you care about scroll off the end of the 15-message limit on the main page.
2648
2649         Eventually we should probably rename /queue-status to /queue or /queues,
2650         but that's fodder for another patch.
2651
2652         * QueueStatusServer/handlers/queuestatus.py:
2653         * QueueStatusServer/index.yaml:
2654         * QueueStatusServer/main.py:
2655         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2656          - This probably should use a custom filter instead of hard-coding
2657            the URL scheme here, but I couldn't figure out how to easily
2658            create such a filter.  Most filters work with "strings" so we can't
2659            pass the status object.  We could add a method to the status
2660            object and call that, but that seemed a bit strange too.
2661         * QueueStatusServer/templates/queuestatus.html:
2662
2663 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2664
2665         Unreviewed. Adding myself to the list of committers.
2666
2667         * Scripts/webkitpy/common/config/committers.py:
2668
2669 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2670
2671         Reviewed by David Levin.
2672
2673         check-webkit-style treated some macros with parentheses after #elif as function calls
2674         https://bugs.webkit.org/show_bug.cgi?id=51695
2675
2676         Ingore function call space checking in any preprocessor directives
2677         (things starting with #). Change search() to match() because 
2678         preprocessor directives are supposed to be in the beginning of lines.
2679
2680         * Scripts/webkitpy/style/checkers/cpp.py:
2681         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2682
2683 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2684
2685         Reviewed by Tony Chang.
2686
2687         Change the --multi-load test option to --stress-opt
2688         https://bugs.webkit.org/show_bug.cgi?id=50751
2689
2690         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2691         (runTest):
2692         (main):
2693         * DumpRenderTree/chromium/TestShell.cpp:
2694         (TestShell::TestShell):
2695         * DumpRenderTree/chromium/TestShell.h:
2696         (TestShell::stressOpt):
2697         (TestShell::setStressOpt):
2698         (TestShell::stressDeopt):
2699         (TestShell::setStressDeopt):
2700         (TestShell::javaScriptFlags):
2701         (TestShell::setJavaScriptFlags):
2702         * Scripts/webkitpy/layout_tests/port/chromium.py:
2703         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2704
2705 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2706
2707         Reviewed by Sam Weinig.
2708
2709         WK2: Support Accessibility
2710         https://bugs.webkit.org/show_bug.cgi?id=51859
2711
2712         Use rootObject() method to get top of accessibility tree.
2713
2714         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2715         (AccessibilityController::focusedElement):
2716         (AccessibilityController::rootElement):
2717
2718 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2719
2720         Reviewed by Darin Adler.
2721
2722         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2723         https://bugs.webkit.org/show_bug.cgi?id=51846
2724
2725         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2726         back to GRefPtr.
2727
2728 2011-01-04  Zhe Su  <suzhe@chromium.org>
2729
2730         Reviewed by Kenneth Russell.
2731
2732         Fix insertText, setMarkedText and unmarkText methods of
2733         TextInputController to call corresponding methods of WebKit::WebView
2734         rather than WebKit::WebFrame. This change matches the behavior of
2735         chromium browser.
2736         insertText corresponds to WebView::confirmComposition(text)
2737         setMarkedText corresponds to WebView::setComposition(...)
2738         unmarkText corresponds to WebView::confirmComposition()
2739         https://bugs.webkit.org/show_bug.cgi?id=51693
2740
2741         * DumpRenderTree/chromium/TextInputController.cpp:
2742         (TextInputController::insertText):
2743         (TextInputController::setMarkedText):
2744         (TextInputController::unmarkText):
2745
2746 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2747
2748         Reviewed by Laszlo Gombos.
2749
2750         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2751
2752         On Symbian productDir points to the source directory. Removing all the
2753         empty files from the productDir directory corrupts the svn repository.
2754
2755         * Scripts/build-webkit:
2756
2757 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2758
2759         Reviewed by Adam Barth.
2760
2761         [Qt] Add SelectAll option to the context menu for the editor
2762         https://bugs.webkit.org/show_bug.cgi?id=50049
2763
2764         Set shortcut for the SelectAll action.
2765
2766         * QtTestBrowser/mainwindow.cpp:
2767         (MainWindow::buildUI):
2768
2769 2011-01-03  David Levin  <levin@chromium.org>
2770
2771         Reviewed by Eric Seidel.
2772
2773         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2774         https://bugs.webkit.org/show_bug.cgi?id=51842
2775
2776         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2777         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2778
2779 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2780
2781         Reviewed by David Kilzer.
2782
2783         [WINCE] Adds a build slave.
2784         https://bugs.webkit.org/show_bug.cgi?id=50523
2785
2786         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2787         entry for a release build of the WinCE port.
2788         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2789         flag to build the WinCE port.
2790
2791 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2792
2793         Reviewed by David Kilzer.
2794
2795         Add WinCE support to build-webkit
2796         https://bugs.webkit.org/show_bug.cgi?id=51642
2797
2798         * Scripts/build-webkit:
2799         * Scripts/webkitdirs.pm:
2800
2801 2011-01-03  Eric Seidel  <eric@webkit.org>
2802
2803         Reviewed by Adam Barth.
2804
2805         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2806         https://bugs.webkit.org/show_bug.cgi?id=51802
2807
2808         I'm not the biggest fan of the test_failures or test_results classes,
2809         but it's better to have one shared set of classes, than separate ones
2810         for new vs. old run-webkit-test result handling.
2811
2812         This moves the ORWT results class "LayoutTestResults" over to using
2813         TestResult and TestFailure classes, making it easy for us to
2814         make all our sheriff-bot and other webkitpy code NRWT ready.
2815
2816         This also makes it a trivial patch to generate results.json information
2817         from ORWT results.html files (for flaky test analysis, etc.) as well
2818         as making it a one-liner to report test failure types when the
2819         commit-queue sees flaky tests.
2820
2821         This patch tried not to add new functionality, but only to replace
2822         the guts of LayoutTestResults, while adding unit tests and hoping
2823         not to break anything.
2824
2825         I also moved callers which assumed User.prompt* were static/class methods
2826         to using them as instance methods (since we'll eventually want to make them such).
2827
2828         In the process of re-writing things, I broke the rebaseline command, so I wrote
2829         a unit test to catch my breakage were I do do so again in the future.
2830
2831         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2832         * Scripts/webkitpy/common/net/layouttestresults.py:
2833         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2834         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2835         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2836         * Scripts/webkitpy/tool/commands/queries.py:
2837         * Scripts/webkitpy/tool/commands/rebaseline.py:
2838         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2839         * Scripts/webkitpy/tool/mocktool.py:
2840
2841 2011-01-03  Adam Barth  <abarth@webkit.org>
2842
2843         Reviewed by Simon Fraser.
2844
2845         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2846         https://bugs.webkit.org/show_bug.cgi?id=51840
2847
2848         * Scripts/webkitpy/common/checkout/scm.py:
2849
2850 2011-01-03  Adam Barth  <abarth@webkit.org>
2851
2852         Reviewed by Simon Fraser.
2853
2854         webkit-patch should only hide update output if --quiet
2855         https://bugs.webkit.org/show_bug.cgi?id=51838
2856
2857         As requested by smfr.
2858
2859         * Scripts/webkitpy/tool/steps/update.py:
2860
2861 2011-01-03  Adam Barth  <abarth@webkit.org>
2862
2863         Reviewed by David Levin.
2864
2865         commit-queue shouldn't reject patches twice if two bots process the same patch
2866         https://bugs.webkit.org/show_bug.cgi?id=51805
2867
2868         Before raising an error, we first check whether the patch is still in
2869         the commit-queue.  This check is still racy, of course, but the time
2870         window is much smaller.
2871
2872         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2873
2874 2011-01-03  Sam Weinig  <sam@webkit.org>
2875
2876         Reviewed by Anders Carlsson.
2877
2878         Make run-api-tests less chatty.
2879         https://bugs.webkit.org/show_bug.cgi?id=51831
2880
2881         - Make script quiet by default and add --verbose option (replacing --quiet).
2882         - When not verbose, pipe stdout and stderr to devnull.
2883
2884         * Scripts/run-api-tests:
2885
2886 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2887
2888         Unreviewed. Adding myself to committers.py.
2889
2890         * Scripts/webkitpy/common/config/committers.py:
2891
2892 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2893
2894         Reviewed by Xan Lopez.
2895
2896         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2897         https://bugs.webkit.org/show_bug.cgi?id=51806
2898
2899         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2900         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2901         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2902         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2903         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2904         so make it 'WebKitBuild/Release/.libs'
2905
2906         * Scripts/webkitdirs.pm: 
2907
2908 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2909
2910         Reviewed by Adam Barth.
2911
2912         Make EFL a core builder
2913         https://bugs.webkit.org/show_bug.cgi?id=51804
2914
2915         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2916         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2917
2918 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2919
2920         [Qt] Unreviewed fix after r74855 and r74875.
2921
2922         * BuildSlaveSupport/built-product-archive:
2923          - Create directories explicitly.
2924          - Pass shell=True to subprocess.call().
2925
2926 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2927
2928         [Qt] Unreviewed fix after r74855.
2929
2930         Move JavaScriptCore to Source
2931         https://bugs.webkit.org/show_bug.cgi?id=51604
2932
2933         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2934
2935 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2936
2937         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2938
2939         Move JavaScriptCore to Source
2940         https://bugs.webkit.org/show_bug.cgi?id=51604
2941
2942         * Scripts/webkitdirs.pm:
2943
2944 2011-01-02  Robert Hogan  <robert@webkit.org>
2945
2946         Unreviewed, build fix.
2947
2948         [Qt] Fix DRT build after 74855
2949
2950         * DumpRenderTree/qt/DumpRenderTree.pro:
2951
2952 2011-01-01  Adam Barth  <abarth@webkit.org>
2953
2954         Remove the assumption from the Qt and Gtk builds that every project is
2955         in the root directory.
2956
2957         * Scripts/build-webkit:
2958
2959 2011-01-01  Adam Barth  <abarth@webkit.org>
2960
2961         Reviewed by Eric Seidel.
2962
2963         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2964         https://bugs.webkit.org/show_bug.cgi?id=51796
2965
2966         After this change, svn-apply will magically apply patches to
2967         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2968
2969         * Scripts/VCSUtils.pm:
2970
2971 2011-01-01  Adam Barth  <abarth@webkit.org>
2972
2973         Reviewed by Eric Seidel.
2974
2975         Move JavaScriptCore to Source
2976         https://bugs.webkit.org/show_bug.cgi?id=51604
2977
2978         Update references to JavaScriptCore to point to the new location.
2979
2980         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2981         * DumpRenderTree/qt/DumpRenderTree.pro:
2982         * DumpRenderTree/qt/ImageDiff.pro:
2983         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2984         * DumpRenderTree/wscript:
2985         * Scripts/build-jsc:
2986         * Scripts/build-webkit:
2987         * Scripts/do-file-rename:
2988         * Scripts/do-webcore-rename:
2989         * Scripts/run-javascriptcore-tests:
2990         * Scripts/update-javascriptcore-test-results:
2991         * Scripts/webkitdirs.pm:
2992         * Scripts/webkitpy/common/config/build_unittest.py:
2993         * Scripts/webkitpy/style/checker.py:
2994         * Scripts/webkitpy/style/checker_unittest.py:
2995         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2996         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2997         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2998         * wx/build/settings.py:
2999
3000 2011-01-01  Adam Barth  <abarth@webkit.org>
3001
3002         Reviewed by Eric Seidel.
3003
3004         Move Sources to Source
3005         https://bugs.webkit.org/show_bug.cgi?id=51794
3006
3007         Update scripts to point to the new location.
3008
3009         * Scripts/build-webkit:
3010         * Scripts/do-file-rename:
3011         * Scripts/do-webcore-rename:
3012         * Scripts/webkitpy/common/config/build.py:
3013         * Scripts/webkitpy/common/config/build_unittest.py:
3014
3015 2010-12-31  Kent Tamura  <tkent@chromium.org>
3016
3017         Reviewed by Eric Seidel.
3018
3019         [DRT/Chromium] Enable mock spell checker on non-OSX
3020         https://bugs.webkit.org/show_bug.cgi?id=51401
3021
3022         * DumpRenderTree/chromium/WebViewHost.cpp:
3023         (WebViewHost::spellCheck):
3024
3025 2010-12-31  Adam Barth  <abarth@webkit.org>
3026
3027         Reviewed by Ariya Hidayat.
3028
3029         Remove Tools/Scripts/wkstyle
3030         https://bugs.webkit.org/show_bug.cgi?id=51774
3031
3032         This script appears to not have been touched in a while and seems to
3033         have been replaced by check-webkit-style.
3034
3035         * Scripts/wkstyle: Removed.
3036
3037 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3038
3039         Unreviewed. Coding style fix.
3040
3041         * DumpRenderTree/chromium/TestShell.h:
3042
3043 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3044
3045         Reviewed by Pavel Feldman.
3046
3047         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3048
3049         It was a problem with Chromium DRT. DevToolsAgent object instance was
3050         attached not only to the inspected page but to the DevTools window too.
3051         As result all the inspector files were interpreted as a content of inspected page
3052         and were transfered to the DevTools scripts panel for debugging etc.
3053
3054         https://bugs.webkit.org/show_bug.cgi?id=51735
3055
3056         * DumpRenderTree/chromium/TestShell.cpp:
3057         (TestShell::TestShell):
3058         (TestShell::bindJSObjectsToWindow):
3059         (TestShell::createNewWindow):
3060         * DumpRenderTree/chromium/TestShell.h:
3061
3062 2010-12-31  Adam Barth  <abarth@webkit.org>
3063
3064         Rubber-stamped by Eric Seidel.
3065
3066         Move PageLoadTests to PerformanceTests/PageLoad
3067         https://bugs.webkit.org/show_bug.cgi?id=51771
3068
3069         Update references to PageLoadTests to point to the new location.
3070
3071         * Scripts/run-pageloadtest:
3072         * Scripts/webkitpy/common/config/build.py:
3073
3074 2010-12-31  Adam Barth  <abarth@webkit.org>
3075
3076         Rubber-stamped by Eric Seidel.
3077
3078         Move SunSpider into PerformanceTests
3079         https://bugs.webkit.org/show_bug.cgi?id=51769
3080
3081         Update these scripts to point to the new location.
3082
3083         * Scripts/run-sunspider:
3084         * Scripts/sunspider-compare-results:
3085
3086 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3087
3088         Reviewed by Kent Tamura.
3089
3090         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3091         https://bugs.webkit.org/show_bug.cgi?id=51728
3092         
3093         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3094         to render top-level scrollbars. This makes them match the Mac port's
3095         use of an NSScrollView, which means that we'll be able to share more
3096         pixel baselines.
3097         
3098         The new rendering code will not be activated until the 
3099         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3100         ScrollbarThemeChromiumMac.
3101
3102         * DumpRenderTree/DumpRenderTree.gypi:
3103         * DumpRenderTree/chromium/TestShellMac.mm:
3104         (platformInit):
3105         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3106         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3107         (+[FakeActiveWindow alwaysActiveWindow]):
3108         (+[FakeActiveWindow alwaysInactiveWindow]):
3109         (-[FakeActiveWindow initWithActiveControls:]):
3110         (-[FakeActiveWindow _hasActiveControls]):
3111         (WebThemeEngineDRTMac::paintScrollbarThumb):
3112         (stateToHIEnableState):
3113         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3114         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3115
3116 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3117
3118         Reviewed by David Kilzer.
3119
3120         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3121         used
3122         https://bugs.webkit.org/show_bug.cgi?id=51672
3123
3124         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3125         with USE_SYSTEM_MALLOC=1
3126         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3127         with USE_SYSTEM_MALLOC=1
3128
3129 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3130
3131         Reviewed by David Kilzer.
3132
3133         [Qt] [Symbian] Fix build-webkit script for Symbian
3134         https://bugs.webkit.org/show_bug.cgi?id=51509
3135
3136         Set the OUTPUT_DIR for Symbian to be the same as the source
3137         directory.
3138
3139         * Scripts/webkitdirs.pm:
3140
3141 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3142
3143         Reviewed by Darin Adler.
3144
3145         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3146         https://bugs.webkit.org/show_bug.cgi?id=51758
3147
3148         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3149
3150         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3151         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3152
3153 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3154
3155         Unreviewed WinCE buildfix.
3156
3157         * WinCELauncher/main.cpp: Add missing include.
3158
3159 2010-12-29  Daniel Bates  <dbates@rim.com>
3160
3161         Reviewed by Darin Adler.
3162
3163         svn-apply updates date of wrong change log entry for a change log diff that
3164         contains two consecutive entries with the same author and date
3165         https://bugs.webkit.org/show_bug.cgi?id=46061
3166
3167         Fixes an issue where the date of the wrong change log entry may be modified.
3168         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3169         in a ChangeLog file to the top of the file.
3170
3171         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3172         diff when it detects that the diff inserts a change log entry earlier in a
3173         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3174         change. With the advent of the commit-queue this functionality of bailing out
3175         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3176         Instead, we should always move the change log entry to the top of the ChangeLog file.
3177
3178         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3179         the date line of the correct change log entry in a ChangeLog diff.
3180
3181         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3182
3183         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3184           Updated the following unit tests now that we move entries inserted earlier to the top:
3185           - "fixChangeLogPatch: New entry inserted in middle."
3186             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3187
3188           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3189             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3190
3191         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3192
3193 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3194
3195         Reviewed by Eric Seidel.
3196
3197         [Qt] Fixed compatibility with gold linker on X11 platforms
3198         https://bugs.webkit.org/show_bug.cgi?id=51700
3199
3200         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3201         Linked TestNetscapePlugin with libX11 on Unix platforms
3202
3203 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3204
3205         Reviewed by Darin Adler.
3206
3207         Circular dependency in webkitpy.common.checkout.changelog module
3208         https://bugs.webkit.org/show_bug.cgi?id=50475
3209
3210         Remove automatic import of api.Checkout module when any checkout/
3211         submodule is imported (e.g.: when checkout.scm.Git is imported).
3212
3213         * Scripts/webkitpy/common/checkout/__init__.py:
3214
3215 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3216
3217         Reviewed by Ojan Vafai.
3218
3219         prepare-ChangeLog should support the -g option for specifying the git-commit
3220         https://bugs.webkit.org/show_bug.cgi?id=51708
3221
3222         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3223         webkit-patch, though the exact meaning of the two options remain different.
3224
3225         * Scripts/prepare-ChangeLog: Add -g.
3226
3227 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3228
3229         Reviewed by Simon Hausmann.
3230
3231         [Qt] Fix compilation with Qt in namespace
3232         https://bugs.webkit.org/show_bug.cgi?id=51701
3233
3234         * QtTestBrowser/webview.h:
3235
3236 2010-12-28  Daniel Bates  <dbates@rim.com>
3237
3238         Reviewed by Sam Weinig.
3239
3240         Substitute // MARK: for compiler-specific #pragma mark
3241         https://bugs.webkit.org/show_bug.cgi?id=51657
3242
3243         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3244         substituting  "// MARK:" for "#pragma mark", which provides
3245         analogous code-bookmarking functionality under Xcode.
3246
3247         Also, for consistency, we should substitute "// MARK:" for compiler-
3248         specific "#pragma mark" in the source files for the Mac port.
3249
3250         * DumpRenderTree/AccessibilityTextMarker.cpp:
3251         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3252         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3253         * DumpRenderTree/mac/ObjCController.m:
3254         * MiniBrowser/mac/AppDelegate.m:
3255         * MiniBrowser/mac/BrowserWindowController.m:
3256
3257 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3258
3259         Reviewed by Eric Seidel.
3260
3261         Add --no-build option to run-sunspider
3262         https://bugs.webkit.org/show_bug.cgi?id=51658
3263
3264         * Scripts/run-sunspider: add --no-build flag to skip building
3265         phase.
3266
3267 2010-12-27  Daniel Bates  <dbates@rim.com>
3268
3269         Rubber-stamped by Martin Robinson.
3270
3271         Append the directory Tools/DumpRenderTree to the list of directories that
3272         do-webcore-rename should search so that it can rename DRT files and
3273         source code.
3274
3275         * Scripts/do-webcore-rename:
3276
3277 2010-12-27  Eric Seidel  <eric@webkit.org>
3278
3279         Reviewed by Adam Barth.
3280
3281         build-webkit should detect missing Java SDK and explain how to install it
3282         https://bugs.webkit.org/show_bug.cgi?id=51651
3283
3284         * Scripts/build-webkit:
3285
3286 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3287
3288         Reviewed by Daniel Bates.
3289
3290         [GTK] Add support for build-jsc
3291         https://bugs.webkit.org/show_bug.cgi?id=51625
3292
3293         Add GTK+ support to build-jsc now that building the jsc executable as
3294         a standalone target is easy.
3295
3296         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3297         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3298         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3299         and pass it along to buildAutotoolsProject.
3300
3301 2010-12-27  David Levin  <levin@chromium.org>
3302
3303         Reviewed by Eric Seidel.
3304
3305         check-webkit-style check for meaningless variable names in function declarations.
3306         https://bugs.webkit.org/show_bug.cgi?id=51523
3307
3308         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3309         from the new check and whitespace/parens because the syntax is unusual and
3310         produced a fair number of positives for these checks.
3311         * Scripts/webkitpy/style/checkers/cpp.py:
3312         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3313         and parameter names when determining if the parameter name is useless.
3314         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3315         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3316         format.
3317         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3318         text or an acronym of it.
3319         (check_function_definition): Checks function definitions for meaningless variable names.
3320         (process_line): Added call to check_function_definition.
3321         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3322         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3323         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3324         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3325         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3326         because when only checking a snippet, there are a lot of bogus functions.
3327         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3328         that I put there previously and just noticed.
3329         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3330         check_function_definition and process_line.
3331
3332 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3333
3334         Reviewed by Martin Robinson.
3335
3336         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3337         https://bugs.webkit.org/show_bug.cgi?id=51591
3338
3339         Flash plugin uses gtk2 that is incompatible with gtk3 making
3340         webkit crash when it's built with gtk3.
3341
3342         * GtkLauncher/main.c:
3343         (main):
3344
3345 2010-12-25  Adam Barth  <abarth@webkit.org>
3346
3347         Reviewed by Eric Seidel.
3348
3349         Move ANGLE to Sources/ThirdParty
3350         https://bugs.webkit.org/show_bug.cgi?id=51605
3351
3352         * Scripts/build-webkit:
3353           - Point to the new ANGLE location.
3354
3355 2010-12-26  David Levin  <levin@chromium.org>
3356
3357         Reviewed by Eric Seidel.
3358
3359         check-webkit-style should be able to parse function declaration parameters.
3360         https://bugs.webkit.org/show_bug.cgi?id=51451
3361
3362         * Scripts/webkitpy/style/checkers/cpp.py:
3363         (Position.__init__): Holds simple position information (row, column).
3364         (Parameter.__init__): Holds information about a parameter.
3365         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3366         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3367         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3368         (find_parameter_name_index): Finds where the parameter name is.
3369         (parameter_list): Generates the list of parameters for a function.
3370         (_FunctionState.begin): Added information to allow determining the parameters
3371         on demand.
3372         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3373         (detect_functions): Improve function detection for operator functions and
3374         determine where the parameters end and pass that to _FunctionState.begin.
3375         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3376         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3377         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3378         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3379         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3380         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3381         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3382         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3383         the parameters found.
3384         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3385         detection test to verify that we catch the operator functions.
3386         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3387         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3388         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3389         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3390         test_function_length_check_definition_severity1_for_test.
3391
3392 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3393
3394         Unreviewed WinCE buildfix after r74334.
3395
3396         * CMakeListsWinCE.txt:
3397
3398 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3399
3400         Unreviewed, rolling out r74632.
3401         http://trac.webkit.org/changeset/74632
3402         https://bugs.webkit.org/show_bug.cgi?id=51600
3403
3404         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3405         on #webkit).
3406
3407         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3408         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3409
3410 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3411
3412         Reviewed by Kenneth Rohde Christiansen.
3413
3414         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3415         https://bugs.webkit.org/show_bug.cgi?id=43528
3416
3417         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3418         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3419         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3420         called.
3421
3422         * EWebLauncher/main.c:
3423         (browserCreate):
3424
3425 2010-12-24  Eric Seidel  <eric@webkit.org>
3426
3427         Reviewed by Adam Barth.
3428
3429         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3430         https://bugs.webkit.org/show_bug.cgi?id=28291
3431
3432         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3433         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3434         to strings with find in the diff.
3435         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3436
3437         * Scripts/webkitpy/common/checkout/api.py:
3438         * Scripts/webkitpy/common/checkout/diff_parser.py:
3439         * Scripts/webkitpy/tool/steps/abstractstep.py:
3440         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3441         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3442         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3443         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3444
3445 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3446
3447         Reviewed by Kenneth Russell.
3448
3449         Modify new-run-webkit-tests to shut up and exit when all the threads
3450         are wedged so that test runs complete faster and we don't end up
3451         w/ enormous log files.
3452
3453         https://bugs.webkit.org/show_bug.cgi?id=51572
3454
3455         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3456         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3457
3458 2010-12-24  Eric Seidel  <eric@webkit.org>
3459
3460         Reviewed by David Levin.
3461
3462         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3463         https://bugs.webkit.org/show_bug.cgi?id=51549
3464
3465         I've had multiple people ask me about the commit-queue's behavior
3466         regarding reporting flaky tests.  I figured it would be best to just
3467         have the queue explain itself in the bugs it files.
3468
3469         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3470         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3471
3472 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3473
3474         Reviewed by Eric Seidel.
3475
3476         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3477         https://bugs.webkit.org/show_bug.cgi?id=51467
3478
3479         * Scripts/webkitpy/style/checker.py:
3480         * Scripts/webkitpy/style/checker_unittest.py:
3481
3482 2010-12-23  Adam Barth  <abarth@webkit.org>
3483
3484         Rubber-stamped by Eric Seidel.
3485
3486         Move JavaScriptGlue into Sources
3487         https://bugs.webkit.org/show_bug.cgi?id=51583
3488
3489         These tools refer to JavaScriptGlue and need to be updated to its new
3490         location.
3491
3492         * Scripts/build-webkit:
3493         * Scripts/do-file-rename:
3494         * Scripts/do-webcore-rename:
3495         * Scripts/webkitpy/common/config/build.py:
3496         * Scripts/webkitpy/common/config/build_unittest.py:
3497
3498 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3499
3500         Reviewed by Eric Seidel.
3501
3502         Bug 51539 - update iexploder scripts to point to new location
3503
3504         * Scripts/run-iexploder-tests:
3505         * Scripts/update-iexploder-cssproperties:
3506
3507 2010-12-23  Evan Martin  <evan@chromium.org>
3508
3509         Reviewed by Ryosuke Niwa.
3510
3511         [chromium] LayoutTestController warning in float->int conversion
3512         https://bugs.webkit.org/show_bug.cgi?id=51553
3513
3514         Rather than reading an int, converting to a float, then getting a compiler
3515         warning on passing the float to something that expects an int, instead
3516         just pass around ints.
3517
3518         No tests, fixes a compiler warning.
3519
3520         * DumpRenderTree/chromium/LayoutTestController.cpp:
3521         (parsePageSizeParameters):
3522         (LayoutTestController::pageNumberForElementById):
3523         (LayoutTestController::numberOfPages):
3524
3525 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3526
3527         Reviewed by Darin Adler.
3528
3529         Bug 51537 - iexploder needs cleanup
3530         
3531         * iExploder/htdocs: Removed.
3532         * iExploder/htdocs/config.rb: Removed.
3533         * iExploder/htdocs/cssproperties.in: Removed.
3534         * iExploder/htdocs/cssvalues.in: Removed.
3535         * iExploder/htdocs/htmlattrs.in: Removed.
3536         * iExploder/htdocs/htmltags.in: Removed.
3537         * iExploder/htdocs/htmlvalues.in: Removed.
3538         * iExploder/htdocs/iexploder.cgi: Removed.
3539         * iExploder/htdocs/iexploder.rb: Removed.
3540         * iExploder/htdocs/index.html: Removed.
3541         * iExploder/htdocs/webserver.rb: Removed.
3542         * iExploder/iexploder-1.7.2/output: Removed.
3543         * iExploder/tools: Removed.
3544         * iExploder/tools/lasthit.rb: Removed.
3545         * iExploder/tools/osx_last_crash.rb: Removed.
3546         * iExploder/tools/showtest.rb: Removed.
3547
3548 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3549
3550         Reviewed by Kenneth Rohde Christiansen.
3551
3552         [EFL] Make 'single' the default backing store in EWebLauncher
3553         https://bugs.webkit.org/show_bug.cgi?id=51534
3554
3555         'single' is the simplest backing store and the one intended to be the
3556         default in the test browser. By mistake the tiled backing store was
3557         left as default in r72617.
3558
3559         * EWebLauncher/main.c:
3560         (browserCreate): ditto.
3561
3562 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3563
3564         Reviewed by Kenneth Rohde Christiansen.
3565
3566         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3567         https://bugs.webkit.org/show_bug.cgi?id=51533
3568
3569         There's no point in concatenating env("HOME") with "blah", so remove
3570         option from EWebLauncher.
3571
3572         * EWebLauncher/main.c:
3573         (main): ditto.
3574
3575 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3576
3577         Reviewed by Eric Seidel.
3578
3579         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3580
3581         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3582         I just discovered that we have two additional GC runs per each WebViewHost.
3583         Test_shell had no such calls.
3584         These gc runs eat 15% of cpu time.
3585
3586         https://bugs.webkit.org/show_bug.cgi?id=51479
3587
3588         * DumpRenderTree/chromium/WebViewHost.cpp:
3589         (WebViewHost::~WebViewHost):
3590
3591 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3592
3593         Reviewed by Ojan Vafai.
3594
3595         This change splits out the TestRunner class into its own file.
3596         When we fork the code for message passing, we will create a new
3597         TestRunner, and this change will allow that to be more modular.
3598
3599         While we're at it, split out TestInput and ResultSummary into
3600         their own files, to reduce the size of run_webkit_tests to
3601         something more managable.
3602
3603         https://bugs.webkit.org/show_bug.cgi?id=51092
3604
3605         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3606         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3607         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3608         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3609         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3610         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3611         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3612
3613  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3614
3615         Reviewed by Ojan Vafai.
3616
3617         nrwt multiprocessing - start over, prepare to fork the code
3618  
3619         This code cleans up the signatures and implementation of the
3620         TestRunner class so we can easily fork it to run either the
3621         stable implementation or the new, unstable message-passing
3622         implementation. The two variants will have different
3623         implementations of the run_tests() method. We will switch
3624         between the two based on the setting for the '--worker-model'
3625         switch. We rename the two currently valid values to 'old-inline'
3626         and 'old-threads'.
3627
3628         https://bugs.webkit.org/show_bug.cgi?id=51081
3629
3630         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3631         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3632
3633 2010-12-22  Victor Wang  <victorw@chromium.org>
3634
3635         Reviewed by Darin Fisher.
3636
3637         [Chromium] Update chromium archive test result url in rebaseline script.
3638
3639         https://bugs.webkit.org/show_bug.cgi?id=51503
3640
3641         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3642
3643 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3644
3645         Reviewed by Alice Liu.
3646
3647         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3648         Verified on Chrome, Safari, and IE.
3649         With this change, we will record memory from a parent browser window and all child processes.
3650
3651         * record-memory-win/main.cpp:
3652         (ProcessArgs):
3653         (PrintUsage):
3654         (getMemoryInfo):
3655         (printProcessInfo):
3656         (evalProcesses):
3657         (UseImage):
3658         (QueryContinuously):
3659         (ElapsedTime):
3660
3661 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3662
3663         Unreviewed rollout r74489, because it was missing changelog.
3664
3665         * record-memory-win/main.cpp:
3666         
3667 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3668
3669         Adding myself as a reviewer.
3670
3671         * Scripts/webkitpy/common/config/committers.py:
3672
3673 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3674
3675         Unreviewed.  Adding myself to committers.py.
3676
3677         * Scripts/webkitpy/common/config/committers.py:
3678
3679 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3680
3681         Reviewed by Kenneth Rohde Christiansen.
3682
3683         TestNetscapePlugIn should use #if defined
3684         https://bugs.webkit.org/show_bug.cgi?id=51471
3685
3686         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3687         (NP_Initialize):
3688         (NPP_New):
3689
3690 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3691
3692         Reviewed by Yury Semikhatsky.
3693
3694         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3695
3696         DevTools window should be closed explicitly because it has custom deinitialization code.
3697
3698         https://bugs.webkit.org/show_bug.cgi?id=50722
3699
3700         * DumpRenderTree/chromium/TestShell.cpp:
3701         (TestShell::closeRemainingWindows):
3702
3703 2010-12-22  David Levin  <levin@chromium.org>
3704
3705         Reviewed by Shinichiro Hamaji.
3706
3707         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3708         https://bugs.webkit.org/show_bug.cgi?id=51452