c5d42c1a563af35662c54088e2a2d801692ebeaf
[WebKit-https.git] / Tools / ChangeLog
1 2012-04-10  Brady Eidson  <beidson@apple.com>
2
3         <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600
4         Need WebKit2 API to notify whether history loads are in the page cache
5
6         Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
7         callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
8
9         Reviewed by Darin Adler.
10
11         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
12         (TestWebKitAPI::didFinishLoadForFrame):
13         (TestWebKitAPI::willGoToBackForwardListItem):
14         (TestWebKitAPI::setPageLoaderClient):
15         (TestWebKitAPI::TEST):
16         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
17         (ShouldGoToBackForwardListItemTest):
18         (TestWebKitAPI::shouldGoToBackForwardListItemCallback):
19         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
20         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
21         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22
23         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
24         (WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
25
26 2012-04-13  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
27
28         Group EFL bots into a category on the buildbot master
29         https://bugs.webkit.org/show_bug.cgi?id=82712
30
31         Reviewed by Adam Roben.
32
33         Creating a new category definition on the buildbot frontend.
34
35         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
36         (loadBuilderConfig): Determine category for EFL bots
37         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
38
39 2012-04-13  Sheriff Bot  <webkit.review.bot@gmail.com>
40
41         Unreviewed, rolling out r113714.
42         http://trac.webkit.org/changeset/113714
43         https://bugs.webkit.org/show_bug.cgi?id=83887
44
45         It is behaving strange on the bots and needs more
46         investigation. (Requested by jeez_ on #webkit).
47
48         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
49         (WTR::PlatformWebView::PlatformWebView):
50
51 2012-04-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
52
53         webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
54         https://bugs.webkit.org/show_bug.cgi?id=83690
55
56         Reviewed by Tor Arne Vestbø.
57
58         Typing part of an email and pressing <TAB> will bash-complete it using the list in
59         Tools/Scripts/webkitpy/common/config/committers.py
60
61         * Scripts/webkit-tools-completion.sh:
62
63 2012-04-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
64
65         [EFL] Add API for color chooser
66         https://bugs.webkit.org/show_bug.cgi?id=83692
67
68         Enables INPUT_TYPE_COLOR by default on the EFL port.
69
70         Reviewed by Kenneth Rohde Christiansen.
71
72         * Scripts/build-webkit:
73
74 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
75
76         Extract PerfTest class from PerfTestRunner
77         https://bugs.webkit.org/show_bug.cgi?id=83847
78
79         Reviewed by Hajime Morita.
80
81         Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
82         that was previously represented by a tuple.
83
84         Also moved the logic to determine whether a given test is chromium style or not from run() to
85         _collect_tests(). And moved the output parsing algorithms for parser style and chromium style
86         tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
87         add new types of tests more easily.
88
89         * Scripts/webkitpy/performance_tests/perftest.py: Added.
90         (PerfTest):
91         (PerfTest.__init__):
92         (PerfTest.test_name):
93         (PerfTest.dirname):
94         (PerfTest.path_or_url):
95         (PerfTest._should_ignore_line_in_parser_test_result):
96         (PerfTest.parse_output):
97         (ChromiumStylePerfTest):
98         (ChromiumStylePerfTest.__init__):
99         (ChromiumStylePerfTest.parse_output):
100         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
101         (PerfTestsRunner._collect_tests):
102         (PerfTestsRunner.run):
103         (PerfTestsRunner._run_tests_set):
104         (PerfTestsRunner._run_single_test):
105         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
106         (run_test):
107         (_tests_for_runner):
108         (test_run_test_set_with_json_output):
109         (test_run_test_set_with_json_source):
110         (test_run_test_set_with_multiple_repositories):
111         (_collect_tests_and_sort_test_name):
112         (test_collect_tests):
113         (test_collect_tests_with_skipped_list):
114
115 2012-04-12  Balazs Kelemen  <kbalazs@webkit.org>
116
117         [Qt] Fix WebKit1 build with V8
118         https://bugs.webkit.org/show_bug.cgi?id=83322
119
120         Reviewed by Adam Barth.
121
122         * DumpRenderTree/qt/DumpRenderTree.pro:
123         * qmake/mkspecs/features/default_post.prf:
124         * qmake/mkspecs/features/default_pre.prf:
125         * qmake/mkspecs/features/features.prf:
126
127 2012-04-12  Dirk Pranke  <dpranke@chromium.org>
128
129         test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
130         https://bugs.webkit.org/show_bug.cgi?id=83583
131
132         Reviewed by Philippe Normand
133
134         Updated the unit test to ignore the hours and minutes of the
135         localtime for time(0), since we can't easily guarantee which
136         timezone we're in or what timezone rules were in effect on
137         1/1/1970; this should be mostly fine since we can trust that
138         time.localtime() will work, although there is the possibility
139         that we'll screw up the time formatting of which field is the
140         hours and which is the minutes.
141
142         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
143         (VerboseTest):
144         (VerboseTest.test_basic):
145         (VerboseTest.test_log_after_update):
146
147 2012-04-12  Dominik Rottsches  <dominik.rottsches@linux.intel.com>
148
149         Add an EFL Debug Buildbot to the master configuration
150         https://bugs.webkit.org/show_bug.cgi?id=82711
151
152         Forgot to add EFL Linux Debug to scheduler.
153
154         Reviewed by Philippe Normand.
155
156         * BuildSlaveSupport/build.webkit.org-config/config.json:
157
158 2012-04-12  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
159
160         Add an EFL Debug Buildbot to the master configuration
161         https://bugs.webkit.org/show_bug.cgi?id=82711
162
163         Reviewed by Philippe Normand.
164
165         Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.
166
167         * BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
168
169 2012-04-12  George Staikos  <staikos@webkit.org>
170
171         Enable the fullscreen API for BlackBerry.
172         https://bugs.webkit.org/show_bug.cgi?id=83757
173
174         Reviewed by Antonio Gomes.
175
176         * Scripts/build-webkit:
177
178 2012-04-12  Simon Pena  <spena@igalia.com>
179
180         [GTK] Test runner crashes without recent versions of pulseaudio-utils
181         https://bugs.webkit.org/show_bug.cgi?id=83774
182
183         Reviewed by Philippe Normand.
184
185         Besides checking that pactl is available, check also that its output
186         is the expected one, and handle gracefully when it isn't, when
187         trying to unload pulseaudio modules.
188
189         * Scripts/webkitpy/layout_tests/port/gtk.py:
190         (GtkPort._unload_pulseaudio_module):
191         (GtkPort._restore_pulseaudio_module):
192
193 2012-03-05  Pierre Rossi  <pierre.rossi@gmail.com>
194
195         [Qt] Use QRawFont when building with Qt 5
196         https://bugs.webkit.org/show_bug.cgi?id=78001
197
198         Flip the QRawFont switch for Qt 5.
199
200         Reviewed by Simon Hausmann.
201
202         * qmake/mkspecs/features/features.prf:
203
204 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
205
206         Web Inspector: Disabling Inspector causes build failure on Windows
207         https://bugs.webkit.org/show_bug.cgi?id=83557
208
209         Reviewed by Pavel Feldman.
210
211         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
212         This change brings all such API calls under the guard.
213
214         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
215         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
216         (WTR):
217         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
218         (LayoutTestController):
219         * WebKitTestRunner/TestInvocation.cpp:
220         (WTR::TestInvocation::invoke):
221
222 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
223
224         Fix regression introduced in r113927.
225
226         Unreviewed, build fix.
227
228         I failed to rename skipped_tests() to skipped_layout_tests()
229         everywhere it needed to be renamed. The unit tests didn't catch
230         this because the TestPort was one of the places that didn't get
231         renamed :(.
232
233         * Scripts/webkitpy/layout_tests/controllers/manager.py:
234         (Manager.parse_expectations):
235         * Scripts/webkitpy/layout_tests/port/test.py:
236         (TestPort.skipped_layout_tests):
237         * Scripts/webkitpy/tool/commands/queries.py:
238         (PrintExpectations._model):
239
240 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
241
242         new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
243         https://bugs.webkit.org/show_bug.cgi?id=47528
244
245         Reviewed by Adam Barth.
246
247         The skipped-ports command has been replaced by 'webkit-patch
248         print-expectations', which offers the equivalent functionality
249         via 'webkit-patch print-expectations --platform \* -t skip'
250         (and other features, of course).
251         
252         This also allows me to fix a nasty layering violation where the
253         chromium port had to know about the TestExpectations objects in
254         order to implement the command properly.
255
256         Lastly, this allows me to rename skipped_tests() to
257         skipped_layout_tests() to more consistent with
258         skipped_perf_tests().
259         
260         This patch removes skips_layout_test() from the Port interface,
261         because that can't be implemented without the port knowing about
262         Expectations objects (and skipped-ports was the only thing using it).
263
264         * Scripts/webkitpy/layout_tests/port/base.py:
265         (Port.skipped_layout_tests):
266         (Port.skipped_perf_tests):
267         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
268         (PortTest.test_default_configuration_notfound):
269         * Scripts/webkitpy/layout_tests/port/chromium.py:
270         (ChromiumPort.test_expectations_overrides):
271         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
272         (ChromiumPortTest.test_path_to_image_diff):
273         * Scripts/webkitpy/layout_tests/port/webkit.py:
274         (WebKitPort.skipped_layout_tests):
275         * Scripts/webkitpy/tool/commands/queries.py:
276         (execute):
277         * Scripts/webkitpy/tool/commands/queries_unittest.py:
278         (QueryCommandsTest.test_tree_status):
279
280 2012-04-11  Mark Rowe  <mrowe@apple.com>
281
282         Remove a fprintf from LayoutTestController.
283
284         This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
285         It was added for no apparent reason by Ryosuke in r113651.
286
287         * DumpRenderTree/LayoutTestController.cpp:
288         (LayoutTestController::redirectionDestinationForURL):
289
290 2012-04-11  Nico Weber  <thakis@chromium.org>
291
292         [mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
293         https://bugs.webkit.org/show_bug.cgi?id=83709
294
295         Reviewed by Anders Carlsson.
296
297         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
298         (handleEventCarbon):
299
300 2012-04-11  Rafael Brandao  <rafael.lobo@openbossa.org>
301
302         Adding myself to committers.py
303         https://bugs.webkit.org/show_bug.cgi?id=83711
304
305         Unreviewed update to committers.py.
306
307         * Scripts/webkitpy/common/config/committers.py:
308
309 2012-04-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
310
311         [EFL] LayoutTestController needs implementation of pageProperty
312         https://bugs.webkit.org/show_bug.cgi?id=82449
313
314         Add missing implementation pageProperty to EFL's LayoutTestController
315         in order to unskip printing/page-rule-selection.html
316
317         Reviewed by Antonio Gomes.
318
319         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
320         (LayoutTestController::pageProperty):
321
322 2012-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
323
324         Unreviewed, rolling out r113836.
325         http://trac.webkit.org/changeset/113836
326         https://bugs.webkit.org/show_bug.cgi?id=83705
327
328         Broke all the WebKit2 inspector tests (Requested by andersca
329         on #webkit).
330
331         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
332         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
333         (WTR::LayoutTestController::showWebInspector):
334         (WTR::LayoutTestController::closeWebInspector):
335         (WTR::LayoutTestController::evaluateInWebInspector):
336         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
337         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
338         (LayoutTestController):
339         * WebKitTestRunner/TestInvocation.cpp:
340         (WTR::TestInvocation::invoke):
341
342 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
343
344         Web Inspector: Disabling Inspector causes build failure on Windows
345         https://bugs.webkit.org/show_bug.cgi?id=83557
346
347         Reviewed by Pavel Feldman.
348
349         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
350         This change brings all such API calls under the guard.
351
352         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
353         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
354         (WTR):
355         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
356         (LayoutTestController):
357         * WebKitTestRunner/TestInvocation.cpp:
358         (WTR::TestInvocation::invoke):
359
360 2012-04-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
361
362         [Qt][WK2] Manage graphics buffers in the web process
363         https://bugs.webkit.org/show_bug.cgi?id=78675
364  
365         Make graphics surface available only for Qt 5, attempting to fix
366         the Qt-mac build.
367
368         Unreviewed build fix.
369
370         * qmake/mkspecs/features/features.prf:
371
372 2012-04-11  Philippe Normand  <pnormand@igalia.com>
373
374         Unreviewed, GTK NRWT follow-up fix after r113849.
375
376         * Scripts/webkitpy/layout_tests/port/gtk.py:
377         (GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.
378
379 2012-04-11  Simon Pena  <spena@igalia.com>
380
381         [GTK] media/event-attributes.html fails
382         https://bugs.webkit.org/show_bug.cgi?id=71662
383
384         Reviewed by Philippe Normand.
385
386         PulseAudio's module "module-stream-restore" allows saving the volume
387         of a stream, restoring it the next time it runs.
388         This affects the tests, since DumpRenderTree's volume settings are
389         saved between test runs, and tests relying on specific volume values
390         would miss some volumeChange events (or get additional ones).
391
392         This patch hooks on the existing GtkPort setup_test_run method and
393         creates a new clean_up_test_run method, so PulseAudio's module is
394         unloaded (if found) before running the tests, and restored (if it
395         was there previously) after they finished, ensuring the tests run in
396         the right environment.
397
398         * Scripts/webkitpy/layout_tests/controllers/manager.py:
399         (Manager._clean_up_run): Invoke the port implementation of
400         clean_up_test_run.
401         * Scripts/webkitpy/layout_tests/port/base.py:
402         (Port.clean_up_test_run): Add an empty implementation of
403         clean_up_test_run.
404         * Scripts/webkitpy/layout_tests/port/gtk.py:
405         (GtkPort._unload_pulseaudio_module): Unloads the offending
406         pulseaudio module, if found.
407         (GtkPort):
408         (GtkPort._restore_pulseaudio_module): Restores the offending
409         pulseaudio module, if it was there previously.
410         (GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
411         (GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.
412
413 2012-04-11  Andras Becsi  <andras.becsi@nokia.com>
414
415         Fix the build with gcc 4.7.0
416         https://bugs.webkit.org/show_bug.cgi?id=83584
417
418         Reviewed by Alexey Proskuryakov.
419
420         * qmake/mkspecs/features/unix/default_post.prf:
421         The -fuse-ld=gold option is not supported with upstream gcc.
422
423 2012-04-11  Ryosuke Niwa  <rniwa@webkit.org>
424
425         Refactor PerfTestRunner to include file extensions in test names
426         https://bugs.webkit.org/show_bug.cgi?id=83677
427
428         Reviewed by Hajime Morita.
429
430         Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.
431
432         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
433         (PerfTestsRunner._collect_tests):
434         (PerfTestsRunner._run_tests_set):
435         (PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
436         We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', '', test_name)" here.
437         (PerfTestsRunner._run_single_test):
438         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
439         (run_test):
440         (_tests_for_runner):
441         (test_run_test_set):
442         (test_run_test_set_kills_drt_per_run):
443         (test_run_test_pause_before_testing):
444         (test_run_test_set_for_parser_tests):
445         (test_collect_tests):
446         (test_collect_tests_with_skipped_list):
447
448 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
449
450         Web Inspector: Disabling Inspector causes build failure on Windows
451         https://bugs.webkit.org/show_bug.cgi?id=83557
452
453         Reviewed by Pavel Feldman.
454
455         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
456         This change brings all such API calls under the guard.
457
458         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
459         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
460         (WTR):
461         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
462         (LayoutTestController):
463         * WebKitTestRunner/TestInvocation.cpp:
464         (WTR::TestInvocation::invoke):
465
466 2012-04-10  Kent Tamura  <tkent@chromium.org>
467
468         Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.
469
470         * Scripts/webkitpy/common/config/watchlist:
471         * Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
472
473 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
474
475         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
476         https://bugs.webkit.org/show_bug.cgi?id=82799
477
478         Reviewed by Ojan Vafai.
479
480         The tests we were skipping in _mark_interrupted_tests_as_skipped
481         had incorrectly-constructed TestResults, and so they were not
482         being treated as failures. The JSON generator doesn't record
483         tests that are passed or skiped in incremental_results, so you
484         couldn't tell these tests were being skipped at all.
485
486         This change changes _mark_interrupted_tests_as_skipped() to
487         treat the skipped tests as failures; this is arguably still
488         incorrect but is minimally invasive for now. We probably need to
489         revisit how we are uploading information about tests that are
490         skipped and passed altogether in a separate change.
491
492         This change also cleans up a couple of other nits that were
493         unnecessary or broken in this same code path.
494
495         * Scripts/webkitpy/layout_tests/controllers/manager.py:
496         (Manager._mark_interrupted_tests_as_skipped):
497         (Manager._upload_json_files): Deletes the check for
498         chromium-mac-leopard (as it is no longer necessary).
499         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
500         (JSONLayoutResultsGenerator.__init__): Here we were
501         recalculating the failure type unnecessarily.
502         * Scripts/webkitpy/layout_tests/models/test_failures.py:
503         (determine_result_type):
504         (FailureEarlyExit): Adds a new failure type so we can tell what
505         happened.
506         (FailureEarlyExit.message):
507         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
508         (MainTest.test_exit_after_n_failures_upload): Add more checks to
509         ensure that we are recording the SKIP correctly; this is less
510         than ideal, because we can't actually test the contents of
511         incremental_results.json. We should fix that at some point.
512
513 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
514
515         make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
516         https://bugs.webkit.org/show_bug.cgi?id=83401
517
518         Reviewed by Adam Barth.
519
520         Last patch in the series - no longer look in mac-leopard,
521         mac-snowleopard, or mac-lion.
522
523         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
524         (ChromiumMacPort):
525         * TestResultServer/static-dashboards/flakiness_dashboard.html:
526
527 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
528
529         webkit-patch: add a print-expectations command
530         https://bugs.webkit.org/show_bug.cgi?id=83347
531
532         Reviewed by Adam Barth.
533
534         This command will print the expected results for a given set of
535         tests on a given set of ports matching a given set of keywords.
536
537         Example output (printing all the tests not expected to pass, and their
538         expected results, on a Mac):
539
540         $ webkit-patch print-expectations -x pass fast/html
541         // For mac-snowleopard
542         fast/html/details-open4.html = TEXT
543         fast/html/details-open2.html = TEXT
544         fast/html/details-no-summary4.html = TEXT
545         fast/html/details-open-javascript.html = TEXT
546         $
547
548         You can also print full test-expectatons.txt lines using --full and a
549         CSV-style report (which can be useful for post-processing) using --csv.
550
551         It will replace the 'skipped-files' command (which will be
552         removed in a subsequent patch) and is a more general (and
553         cleaner and properly layered) solution.
554
555         Also add an update() command to MockOptions() to make overriding keywords easier.
556
557         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
558         (TestExpectationSerializer.to_string):
559         (TestExpectationSerializer):
560         (TestExpectationSerializer.to_csv):
561         (TestExpectationSerializer._format_result):
562         (TestExpectationLine.create_passing_expectation):
563         (TestExpectationsModel.get_test_set_for_keyword):
564         (TestExpectationsModel.has_keyword):
565         (TestExpectations.model):
566         * Scripts/webkitpy/tool/commands/queries.py:
567         (execute):
568         (PrintExpectations):
569         (PrintExpectations.__init__):
570         (PrintExpectations.execute):
571         (PrintExpectations._filter_tests):
572         (PrintExpectations._format_lines):
573         (PrintExpectations._model):
574         * Scripts/webkitpy/tool/commands/queries_unittest.py:
575         (TestPrintExpectations): Added.
576         * Scripts/webkitpy/tool/mocktool.py:
577         (MockOptions):
578         (MockOptions.__init__):
579         (MockOptions.update): Added.
580
581 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
582
583         webkitpy: refactor handling of --platform and related options
584         https://bugs.webkit.org/show_bug.cgi?id=83525
585
586         Reviewed by Adam Barth.
587
588         This change moves to centralize handling of --platform, --debug,
589         --gtk, and other similar flags into a central place next to the
590         code that actually uses those flags in PortFactory to get the
591         right Port object.
592
593         * Scripts/webkitpy/layout_tests/port/__init__.py:
594         * Scripts/webkitpy/layout_tests/port/factory.py:
595         (port_options):
596         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
597         (parse_args):
598         * Scripts/webkitpy/tool/commands/queries.py:
599         (PrintBaselines.__init__):
600
601 2012-04-10  Ojan Vafai  <ojan@chromium.org>
602
603         Add a chromeless view to the individual tests view
604         https://bugs.webkit.org/show_bug.cgi?id=83541
605
606         Reviewed by Daniel Bates.
607
608         This is the view suitable to inlining in other contexts (e.g. garden-o-matic).
609
610         * TestResultServer/static-dashboards/flakiness_dashboard.html:
611         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
612         (testHtmlForIndividualTestOnAllBuilders):
613         (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
614         (testHtmlForIndividualTestOnAllBuildersWithChrome):
615         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
616         (testHtmlForIndividualTests):
617         (htmlEscape):
618         (runTests):
619
620 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
621
622         remove 'win' from chromium-win, chromium-linux fallback paths
623         https://bugs.webkit.org/show_bug.cgi?id=83613
624
625         Reviewed by Ojan Vafai.
626
627         The chromium ports no longer need to look at the apple 'win'
628         directory for baseline results.
629
630         Also remove the old '-gpu-' entries from the flakiness dashboard
631         map since I'm touching lines nearby.
632
633         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
634         (ChromiumLinuxPort):
635         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
636         (ChromiumWinPort):
637         * TestResultServer/static-dashboards/flakiness_dashboard.html:
638
639 2012-04-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
640
641         [Qt][WK2] Manage graphics buffers in the web process
642         https://bugs.webkit.org/show_bug.cgi?id=78675
643
644         Enable graphics surfaces on Mac for Qt.
645
646         Reviewed by Kenneth Rohde Christiansen.
647
648         * qmake/mkspecs/features/features.prf:
649
650 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
651
652         [CMake] Enable USE_FOLDERS property
653         https://bugs.webkit.org/show_bug.cgi?id=83571
654
655         Reviewed by Daniel Bates.
656
657         Setting the FOLDER property on targets gives more structure
658         to the generated Visual Studio solutions.
659         This does not affect other CMake generators.
660
661         * DumpRenderTree/efl/CMakeLists.txt:
662         * EWebLauncher/CMakeLists.txt:
663         * WinCELauncher/CMakeLists.txt:
664
665 2012-04-10  David Dorwin  <ddorwin@chromium.org>
666
667         Add Encrypted Media Extensions methods to HTMLMediaElement
668         https://bugs.webkit.org/show_bug.cgi?id=82971
669
670         Reviewed by Adam Barth.
671
672         The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
673         Implementation is based on v0.1 of the draft proposal at
674         http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.
675
676         * DumpRenderTree/chromium/TestShell.cpp:
677         (TestShell::TestShell):
678
679 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
680
681         [EFL][DRT] Catch the "title,changed" signal
682         https://bugs.webkit.org/show_bug.cgi?id=82174
683
684         Reviewed by Gustavo Noronha Silva.
685
686         EFL's DumpRenderTree now catches the "title,changed" signal, and
687         prints out the needed information.
688
689         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
690         (DumpRenderTreeChrome::onTitleChanged):
691
692 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
693
694         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
695         https://bugs.webkit.org/show_bug.cgi?id=82443
696
697         Reviewed by Philippe Normand.
698
699         EFL's DRT needs to support LayoutTestController's
700         willSendRequestReturnsNull() and return NULL when expected. This
701         allows for several tests to be removed from the skip list.
702
703         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
704         (DumpRenderTreeChrome::onWillSendRequest):
705
706 2012-04-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
707
708         [EFL] LayoutTestController needs implementation of addUserStyleSheet
709         https://bugs.webkit.org/show_bug.cgi?id=82446
710
711         Adding missing implementation addUserStyleSheet to EFL's LayoutTestController 
712         so that we can unskip related tests from the skip list. 
713
714         Reviewed by Antonio Gomes.
715
716         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
717         (LayoutTestController::addUserStyleSheet): Implemented.
718
719 2012-04-10  Philip Rogers  <pdr@google.com>
720
721         Adding myself to committers.py!
722
723         Unreviewed update to committers.py.
724
725         * Scripts/webkitpy/common/config/committers.py:
726
727 2012-04-10  Dinu Jacob  <dinu.jacob@nokia.com>
728
729         [Qt][WK2] Title in MiniBrowser is not updated for a page with no title
730         https://bugs.webkit.org/show_bug.cgi?id=82483
731
732         Reviewed by Kenneth Rohde Christiansen.
733
734         Set window title to default if there is no page title.
735
736         * MiniBrowser/qt/BrowserWindow.cpp:
737         (BrowserWindow::BrowserWindow):
738         (BrowserWindow::onTitleChanged):
739         * MiniBrowser/qt/BrowserWindow.h:
740         (BrowserWindow):
741
742 2012-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
743
744         [Qt][WK2] Implement PageClient::isViewWindowActive()
745         https://bugs.webkit.org/show_bug.cgi?id=81143
746
747         Reviewed by Kenneth Rohde Christiansen.
748
749         Fix the WrapperWindow from our PlatformWebView
750         so it correctly creates the platform related
751         stuff for QWindow, which is not created unless
752         QWindow::setVisible() or QWindow::show() are called.
753
754         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
755         (WTR::PlatformWebView::PlatformWebView):
756
757 2012-04-10  Balazs Kelemen  <kbalazs@webkit.org>
758
759         [Qt][WK2] TestNetscapePlugin is broken
760         https://bugs.webkit.org/show_bug.cgi?id=83024
761
762         Reviewed by Csaba Osztrogonác.
763
764         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
765         Fix X11 availability check. embedded is always true with QPA.
766         * Tools.pro:
767         Build the test plugin if plugins are enabled for WebKit2.
768         * qmake/mkspecs/features/features.prf:
769         * qmake/mkspecs/features/functions.prf:
770         Added a convenience function to determine availability
771         of X11 libraries.
772
773 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
774
775         [WIN] Fix build without precompiled header.
776
777         * DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
778
779 2012-04-10  Arko Saha  <arko@motorola.com>
780
781         Unreviewed: adding myself to committers.py.
782
783         * Scripts/webkitpy/common/config/committers.py:
784
785 2012-04-09  Kaustubh Atrawalkar  <kaustubh@motorola.com>
786
787         Unreviewed: adding myself to committers.py.
788
789         * Scripts/webkitpy/common/config/committers.py:
790
791 2012-04-09  Sheriff Bot  <webkit.review.bot@gmail.com>
792
793         Unreviewed, rolling out r113656.
794         http://trac.webkit.org/changeset/113656
795         https://bugs.webkit.org/show_bug.cgi?id=83542
796
797         test is broken on chromium-win (Requested by simonjam on
798         #webkit).
799
800         * DumpRenderTree/chromium/WebViewHost.cpp:
801         (WebViewHost::dispatchIntent):
802
803 2012-04-09  Takashi Toyoshima  <toyoshim@chromium.org>
804
805         Update pywebsocket to 0.7.4.
806         https://bugs.webkit.org/show_bug.cgi?id=83461
807
808         Reviewed by Kent Tamura.
809
810         This version supports TLS by using ssl in addition to pyOpenSSL.
811         Other functional difrerences from 0.7.2 are:
812          - strict Sec-WebSocket-Key validation conforming RFC 4648
813          - compression ratio logging in debug
814
815         * Scripts/webkitpy/thirdparty/__init__.py:
816         (AutoinstallImportHook._install_pywebsocket):
817
818 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
819
820         add a webkit-patch print-baselines command
821         https://bugs.webkit.org/show_bug.cgi?id=83348
822
823         Reviewed by Adam Barth.
824
825         This adds a simple 'print-baselines' command to webkit-patch
826         that can be used in one of two forms: to print where the
827         baselines for a given test (or set of tests) on a single port
828         will be found, or to generate a report for multiple ports.
829
830         Example of the former:
831
832         $ webkit-patch print-baselines fast/html/keygen.html
833         // For mac-snowleopard
834         platform/mac/fast/html/keygen-expected.txt
835         platform/mac/fast/html/keygen-expected.png
836         $
837
838         The latter is most useful for finding out which fallback dirs are
839         used by which ports for which tests, for example,
840         'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
841         No example output is given because the reports are pretty wordy :).
842
843         * Scripts/webkitpy/layout_tests/port/base.py:
844         (Port.baseline_extensions): Added.
845         (Port.expected_baseline_dict): Added.
846         * Scripts/webkitpy/tool/commands/queries.py:
847         (PrintBaselines):
848         (PrintBaselines.__init__):
849         (PrintBaselines.execute):
850         (PrintBaselines._print_baselines):
851         (PrintBaselines._platform_for_path):
852
853 2012-04-09  Florin Malita  <fmalita@chromium.org>
854
855         Unreviewed: adding myself to committers.py.
856
857         * Scripts/webkitpy/common/config/committers.py:
858
859 2012-04-09  Ming Xie  <mxie@rim.com>
860
861         [BlackBerry] Allow simulator to use GLES2 acceleration
862         https://bugs.webkit.org/show_bug.cgi?id=81672
863
864         Reviewed by Rob Buis.
865
866         * Scripts/webkitdirs.pm:
867         (blackberryCMakeArguments):
868
869 2012-04-09  Dana Jansens  <danakj@chromium.org>
870
871         Mark myself as a committer
872         https://bugs.webkit.org/show_bug.cgi?id=83510
873
874         Reviewed by Adrienne Walker.
875
876         * Scripts/webkitpy/common/config/committers.py:
877
878 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
879
880         nrwt is failing to upload test results on the chromium-mac-leopard bots
881         https://bugs.webkit.org/show_bug.cgi?id=83230
882
883         Unreviewed, build fix.
884
885         It looks like the change in r113399 to use the per-request
886         timeout variable didn't actually work, so I am removing the
887         timeout code altogether and counting on the idea that upload
888         just isn't likely to take that long and the timeouts and
889         retransmits are largely unused and largely unnecessary. We'll
890         see if this breaks anywhere else.
891
892         * Scripts/webkitpy/common/net/file_uploader.py:
893         (FileUploader.__init__):
894         (FileUploader._upload_data.callback):
895         (FileUploader):
896
897 2012-04-09  Rob Buis  <rbuis@rim.com>
898
899         [BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
900         https://bugs.webkit.org/show_bug.cgi?id=83469
901
902         Reviewed by Dirk Schulze.
903
904         Remove WTF:: prefixes and fix a warning with the length variable.
905
906         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
907         (jsStringRefToWebCoreString):
908         (LayoutTestController::execCommand):
909         (LayoutTestController::isCommandEnabled):
910         (LayoutTestController::setUserStyleSheetLocation):
911         (LayoutTestController::counterValueForElementById):
912         (LayoutTestController::overridePreference):
913         (LayoutTestController::setMockGeolocationError):
914         (LayoutTestController::findString):
915
916 2012-04-09  Patrick Gansterer  <paroga@webkit.org>
917
918         Build fix for WinCE after r113570.
919
920         * Scripts/build-webkit: Do not use FastMalloc for WinCE.
921
922 2012-04-09  Eric Carlson  <eric.carlson@apple.com>
923
924         Subscribe eric.carlson@apple.com to Media-related changes
925         https://bugs.webkit.org/show_bug.cgi?id=83421
926
927         Reviewed by Dan Bernstein.
928
929         * Scripts/webkitpy/common/config/watchlist:
930
931 2012-04-09  Martin Robinson  <mrobinson@igalia.com>
932
933         check-webkit-style should ignore NULL usage in gtk_style_context_get_style
934         https://bugs.webkit.org/show_bug.cgi?id=83412
935
936         Reviewed by David Levin.
937
938         Accept NULL as an argument for gtk_style_context_get_style, because it's
939         used as a sentinel in a variable argument list. 
940
941         * Scripts/webkitpy/style/checkers/cpp.py:
942         (check_for_null): Add an exception.
943         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
944         (WebKitStyleTest.test_null_false_zero): Add a test for the exception.
945
946 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
947
948         webkitpy: use the filesystem object properly in fileuploader
949         https://bugs.webkit.org/show_bug.cgi?id=83326
950
951         Reviewed by Adam Barth.
952
953         We should be using the filesystem object rather than the codecs
954         object.
955
956         * Scripts/webkitpy/common/net/file_uploader.py:
957         (FileUploader.upload_as_multipart_form_data):
958
959 2012-04-09  Eric Seidel  <eric@webkit.org>
960
961         Enable webkit_unit_tests for commit queue and EWS while tracking failures
962         https://bugs.webkit.org/show_bug.cgi?id=83329
963
964         Unreviewed.  Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
965
966         line 62, in _create_unit_test_results
967          return UnitTestResults.results_from_string(results_xml)
968          NameError: global name 'UnitTestResults' is not defined
969
970         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
971         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
972         (LayoutTestResultsReaderTest.test_create_unit_test_results):
973
974 2012-04-08  Adam Barth  <abarth@webkit.org>
975
976         The port object is missing unit_tests_results_path
977         https://bugs.webkit.org/show_bug.cgi?id=83448
978
979         Unreviewed.
980
981         This is causing the cr-linux-ews to throw an exception.
982
983         * Scripts/webkitpy/common/config/ports.py:
984         (DeprecatedPort.unit_tests_results_path):
985
986 2012-04-07  Patrick Gansterer  <paroga@webkit.org>
987
988         [CMake] Cleanup WTF include directories
989         https://bugs.webkit.org/show_bug.cgi?id=82716
990
991         Reviewed by Eric Seidel.
992
993         * DumpRenderTree/efl/CMakeLists.txt:
994         * WinCELauncher/CMakeLists.txt:
995
996 2012-04-07  Rob Buis  <rbuis@rim.com>
997
998         [BlackBerry] Add Battery Status API support
999         https://bugs.webkit.org/show_bug.cgi?id=82615
1000
1001         Reviewed by George Staikos.
1002
1003         Enable BATTERY_STATUS.
1004
1005         * Scripts/build-webkit:
1006
1007 2012-04-06  Ami Fischman  <fischman@chromium.org>
1008
1009         Subscribe feature-media-reviews@c.o to Media-related changes.
1010         https://bugs.webkit.org/show_bug.cgi?id=83397
1011
1012         Reviewed by David Levin.
1013
1014         * Scripts/webkitpy/common/config/committers.py:
1015         * Scripts/webkitpy/common/config/watchlist:
1016
1017 2012-04-06  Adrienne Walker  <enne@google.com>
1018
1019         [chromium] Add virtual test suite for threaded compositing
1020         https://bugs.webkit.org/show_bug.cgi?id=82263
1021
1022         Reviewed by James Robinson.
1023
1024         Add compositing/visibility as a virtual test suites to test threaded
1025         compositing with. This is a reasonable smoke test of 9 tests, none of
1026         which have any expectations in the non-threaded case.
1027
1028         To fix many of the remaining tests in this virtual test suite, there
1029         will need to be some serious refactoring to merge the conflict between
1030         the way CCScheduler wants to draw frames and the way DRT also wants to
1031         control things. So, in the short term, enable a few simple tests that
1032         are known to be passing.
1033
1034         * Scripts/webkitpy/layout_tests/port/chromium.py:
1035         (ChromiumPort.virtual_test_suites):
1036
1037 2012-04-06  Enrica Casucci  <enrica@apple.com>
1038
1039         Provide Obj-C private API to simplify markup.
1040         https://bugs.webkit.org/show_bug.cgi?id=83334
1041         <rdar://problem/11033861>
1042
1043         Reviewed by Sam Weinig.
1044
1045         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1046         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.
1047         (-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):
1048         * TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.
1049
1050 2012-04-06  Dirk Pranke  <dpranke@chromium.org>
1051
1052         new-run-webkit-tests: fix bugs in 'mock' drt implementation
1053         https://bugs.webkit.org/show_bug.cgi?id=83341
1054
1055         Reviewed by Eric Seidel.
1056
1057         The current implementation crashed in some circumstances for
1058         reference tests and files that were missing expected results.
1059         This patch fixes those cases and adds more unit tests; it is a
1060         precursor to adding unit tests each port that actually uses this
1061         code, in order to get better coverage of the port/*
1062         implementations.
1063
1064         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1065         (parse_options):
1066         (MockDRT.input_from_line):
1067         (MockDRT.output_for_test):
1068         (MockDRT.run_one_test):
1069         (MockChromiumDRT.input_from_line):
1070         (MockChromiumDRT.output_for_test):
1071         (MockChromiumDRT.run_one_test):
1072         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1073         (MockDRTTest.make_input_output):
1074         (MockDRTTest.expected_output):
1075         (MockDRTTest):
1076         (MockDRTTest.assertTest):
1077         (MockDRTTest.test_missing_image):
1078         (MockDRTTest.test_missing_text):
1079         (MockDRTTest.test_reftest_match):
1080         (MockDRTTest.test_reftest_mismatch):
1081         (MockChromiumDRTTest.expected_output):
1082
1083 2012-04-06  James Robinson  <jamesr@chromium.org>
1084
1085         Enable webkit_unit_tests for commit queue and EWS while tracking failures
1086         https://bugs.webkit.org/show_bug.cgi?id=83329
1087
1088         Reviewed by Adam Barth.
1089
1090         This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
1091         the commit queue and EWS can reject patches that cause regressions.
1092
1093         * Scripts/webkitpy/common/config/ports.py:
1094         (ChromiumPort.run_webkit_unit_tests_command):
1095         * Scripts/webkitpy/common/config/ports_mock.py:
1096         (MockPort.unit_tests_results_path):
1097         * Scripts/webkitpy/common/net/layouttestresults.py:
1098         (LayoutTestResults.__init__):
1099         (LayoutTestResults.failing_tests):
1100         (LayoutTestResults):
1101         (LayoutTestResults.add_unit_test_failures):
1102         * Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.
1103         (UnitTestResults):
1104         (UnitTestResults.results_from_string):
1105         * Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.
1106         (UnitTestResultsTest):
1107         (UnitTestResultsTest.test_nostring):
1108         (UnitTestResultsTest.test_emptystring):
1109         (UnitTestResultsTest.test_nofailures):
1110         (test_onefailure):
1111         (test_multiple_failures_per_test):
1112         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1113         (MockCommitQueue.test_results):
1114         (MockCommitQueue.archive_last_test_results):
1115         (FailingTestCommitQueue.test_results):
1116         (test_flaky_test_failure):
1117         (test_failed_archive):
1118         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1119         (LayoutTestResultsReader._create_unit_test_results):
1120         (LayoutTestResultsReader.results):
1121         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1122         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1123         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1124         (PatchAnalysisTaskDelegate.test_results):
1125         (PatchAnalysisTaskDelegate.archive_last_test_results):
1126         (PatchAnalysisTask._test):
1127         (PatchAnalysisTask._build_and_test_without_patch):
1128         (PatchAnalysisTask._test_patch):
1129         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1130         (AbstractEarlyWarningSystem.test_results):
1131         (AbstractEarlyWarningSystem.archive_last_test_results):
1132         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1133         (EarlyWarningSytemTest._test_testing_ews):
1134         * Scripts/webkitpy/tool/commands/queues.py:
1135         (CommitQueue.test_results):
1136         (CommitQueue.archive_last_test_results):
1137         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1138         (CommitQueueTest.test_commit_queue):
1139         (test_rollout):
1140         (test_manual_reject_during_processing):
1141         * Scripts/webkitpy/tool/steps/runtests.py:
1142         (RunTests.run):
1143         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1144         (RunTestsTest.test_webkit_run_unit_tests):
1145
1146 2012-04-06  Aaron Colwell  <acolwell@chromium.org>
1147
1148         Enable MediaSource feature for DumpRenderTree so
1149         MediaSource LayoutTests will pass for Chromium.
1150         https://bugs.webkit.org/show_bug.cgi?id=83053
1151
1152         Reviewed by Dimitri Glazkov.
1153
1154         * DumpRenderTree/chromium/TestShell.cpp:
1155         (TestShell::TestShell):
1156
1157 2012-04-06  George Staikos  <staikos@webkit.org>
1158
1159         Turn on vibration support for BlackBerry.
1160
1161         Reviewed by Rob Buis.
1162
1163         * Scripts/build-webkit:
1164
1165 2012-04-06  Dan Bernstein  <mitz@apple.com>
1166
1167         <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access
1168
1169         Reviewed by Sam Weinig.
1170
1171         * Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.
1172
1173 2012-04-05  Dirk Pranke  <dpranke@chromium.org>
1174
1175         nrwt is failing to upload test results on the chromium-mac-leopard bots
1176         https://bugs.webkit.org/show_bug.cgi?id=83230
1177
1178         Reviewed by Ojan Vafai.
1179
1180         This should fix things properly; FileUploader() was setting the
1181         socket default timeout value, and apparently that doesn't work
1182         properly with urllib. Also, the class had a bad try/finally
1183         block that was causing the exceptions to be swallowed :(.
1184
1185         * Scripts/webkitpy/common/net/file_uploader.py:
1186         (FileUploader.__init__):
1187         (FileUploader._upload_data.callback):
1188         (FileUploader):
1189         (FileUploader._upload_data):
1190         * Scripts/webkitpy/common/net/networktransaction.py:
1191         (NetworkTimeout.__str__):
1192         (NetworkTransaction.run):
1193         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1194         (JSONResultsGeneratorBase.upload_json_files):
1195
1196 2012-04-05  Patrick Gansterer  <paroga@webkit.org>
1197
1198         [Qt] Correct <wtf/*.h> include paths.
1199         https://bugs.webkit.org/show_bug.cgi?id=83270
1200
1201         Reviewed by Eric Seidel.
1202
1203         Modify the #include declerations so that the
1204         wtf types are included using the full path.
1205
1206         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1207
1208 2012-04-05  Philippe Normand  <pnormand@igalia.com>
1209
1210         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
1211         https://bugs.webkit.org/show_bug.cgi?id=83176
1212
1213         Reviewed by Tony Chang.
1214
1215         Refactored the test to use os.path.join() to specify the
1216         core_pattern value of the empty crash log mock.
1217
1218         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1219         (GtkPortTest):
1220         (GtkPortTest.assertLinesEqual):
1221         (GtkPortTest.test_get_crash_log):
1222         (_mock_gdb_output):
1223
1224 2012-04-05  Csaba Osztrogonác  <ossy@webkit.org>
1225
1226         [Qt] Fix includes after QtDeclarative -> QtQML renaming
1227         https://bugs.webkit.org/show_bug.cgi?id=82195
1228
1229         Relanding r112651, because Qt5 is updated everywhere.
1230
1231         * MiniBrowser/qt/BrowserWindow.cpp:
1232         (BrowserWindow::updateVisualMockTouchPoints):
1233         * MiniBrowser/qt/main.cpp:
1234         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1235         (WTR::WrapperWindow::handleStatusChanged):
1236         * qmake/mkspecs/features/unix/default_post.prf:
1237
1238 2012-04-05  Pierre Rossi  <pierre.rossi@gmail.com>
1239
1240         [Qt] WK1/WK2 layout test results are diverging
1241         https://bugs.webkit.org/show_bug.cgi?id=82720
1242
1243         The resolving of default font families was altered in Qt5.
1244         This directly affects the font picked by DRT for layout
1245         tests. Since we want to keep the Qt4 and Qt5 results in line,
1246         we can trick DRT in picking the same font as before for now.
1247
1248         Reviewed by Csaba Osztrogonác.
1249
1250         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1251         (WebKit::initializeTestFonts):
1252
1253 2012-04-05  Kinuko Yasuda  <kinuko@chromium.org>
1254
1255         Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
1256         https://bugs.webkit.org/show_bug.cgi?id=82592
1257
1258         Reviewed by David Levin.
1259
1260         Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.
1261
1262         * DumpRenderTree/chromium/EventSender.cpp:
1263         (EventSender::beginDragWithFiles):
1264
1265 2012-04-04  Tim Horton  <timothy_horton@apple.com>
1266
1267         [mac] WKTR should always keep its windows offscreen
1268         https://bugs.webkit.org/show_bug.cgi?id=83244
1269         <rdar://problem/11188764>
1270
1271         Reviewed by Simon Fraser.
1272
1273         We don't want to allow windows onto the main display; intercept attempts to
1274         change WebKitTestRunnerWindow's frame origin and prevent it from happening.
1275
1276         Also keep around and respond with a new "fake" origin, in case someone is
1277         expecting it to change (I couldn't find any tests that expected this, however).
1278
1279         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1280         (-[WebKitTestRunnerWindow setFrameOrigin:]):
1281         (-[WebKitTestRunnerWindow setFrame:display:animate:]):
1282         (-[WebKitTestRunnerWindow setFrame:display:]):
1283         (-[WebKitTestRunnerWindow frame]):
1284
1285 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1286
1287         Fix typo introduced in r113271.
1288
1289         Unreviewed, build fix.
1290
1291         * Scripts/webkitpy/common/net/file_uploader.py:
1292         (FileUploader._upload_data.callback):
1293         (FileUploader):
1294
1295 2012-04-04  Scott Graham  <scottmg@google.com>
1296
1297         [Chromium, DRT] Bounds check indices on gamepadController
1298         https://bugs.webkit.org/show_bug.cgi?id=83192
1299
1300         Invalid test data would cause bad array accesses. Add simple checks to
1301         ignore such invalid data.
1302
1303         Reviewed by Kent Tamura.
1304
1305         * DumpRenderTree/chromium/GamepadController.cpp:
1306         (GamepadController::connect):
1307         (GamepadController::disconnect):
1308         (GamepadController::setId):
1309         (GamepadController::setButtonCount):
1310         (GamepadController::setButtonData):
1311         (GamepadController::setAxisCount):
1312         (GamepadController::setAxisData):
1313
1314 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1315
1316         nrwt is failing to upload test results on the chromium-mac-leopard bots
1317         https://bugs.webkit.org/show_bug.cgi?id=83230
1318
1319         Reviewed by Ojan Vafai.
1320
1321         More debugging info and a possible fix - stop messing with the
1322         default network timeout, and don't swallow URLErrors.
1323
1324         * Scripts/webkitpy/common/net/file_uploader.py:
1325         (FileUploader._upload_data):
1326         * Scripts/webkitpy/common/net/networktransaction.py:
1327         (NetworkTransaction.run):
1328         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1329         (JSONResultsGeneratorBase.upload_json_files):
1330
1331 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1332
1333         nrwt is failing to upload test results on the chromium-mac-leopard bots
1334         https://bugs.webkit.org/show_bug.cgi?id=83230
1335
1336         Reviewed by Ojan Vafai.
1337
1338         * Scripts/webkitpy/common/net/file_uploader.py:
1339         (FileUploader.__init__):
1340         (FileUploader._upload_data.callback):
1341         (FileUploader):
1342         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1343         (Manager._upload_json_files):
1344         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1345         (JSONResultsGeneratorBase.upload_json_files):
1346
1347 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1348
1349         WKTR needs to implement layoutTestController.setPageVisibility()
1350         https://bugs.webkit.org/show_bug.cgi?id=69554
1351
1352         Reviewed by Simon Fraser.
1353
1354         This patch implements the layoutTestController.setPageVisibility
1355         so WKTR supports the Page Visibility API implementation by using InjectedBundle
1356         to set the visibility state directly to Page.
1357
1358         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1359         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1360         (WTR::LayoutTestController::setPageVisibility):
1361         (WTR):
1362         (WTR::LayoutTestController::resetPageVisibility):
1363         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1364         (LayoutTestController):
1365
1366 2012-04-04  Adam Barth  <abarth@webkit.org>
1367
1368         [Chromium] TestWebKitAPI links in WebCore twice
1369         https://bugs.webkit.org/show_bug.cgi?id=83177
1370
1371         Reviewed by Dimitri Glazkov.
1372
1373         This is causing link errors in the Windows component build. This patch
1374         moves the dependencies a bit lower down in the dependency diagram in
1375         the hopes of removing the duplicate symbols.
1376
1377         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1378
1379 2012-04-04  Christophe Dumez  <christophe.dumez@intel.com>
1380
1381         [EFL][DRT] Catch the "resource,request,willsend" signal
1382         https://bugs.webkit.org/show_bug.cgi?id=82192
1383
1384         Reviewed by Gustavo Noronha Silva.
1385
1386         EFL's DumpRenderTree now catches the "resource,request,willsend"
1387         signal in order to implement the "Blocked access to external URL"
1388         behavior and avoid potential network-related timeouts in the tests.
1389
1390         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1391         (DumpRenderTreeChrome::createView):
1392         (DumpRenderTreeChrome::onWillSendRequest):
1393         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1394         (DumpRenderTreeChrome):
1395
1396 2012-04-04  Patrick Gansterer  <paroga@webkit.org>
1397
1398         [EFL][DRT] Correct <wtf/*.h> include paths.
1399         https://bugs.webkit.org/show_bug.cgi?id=83168
1400
1401         Reviewed by Eric Seidel.
1402
1403         Modify the #include declarations so that the 
1404         wtf types are included using the full path.
1405
1406         * DumpRenderTree/efl/DumpRenderTree.cpp:
1407
1408 2012-04-04  Philippe Normand  <pnormand@igalia.com>
1409
1410         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
1411         https://bugs.webkit.org/show_bug.cgi?id=83176
1412
1413         Reviewed by Tony Chang.
1414
1415         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1416         (test_get_crash_log): Skip the test on non-linux platforms.
1417
1418 2012-04-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1419
1420         [EFL] DRT support for computedStyleIncludingVisitedInfo
1421         https://bugs.webkit.org/show_bug.cgi?id=82190
1422
1423         Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
1424         LayoutTestController so that we can unskip related tests from the skip list.
1425
1426         Reviewed by Antonio Gomes.
1427
1428         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1429         (LayoutTestController::computedStyleIncludingVisitedInfo):
1430
1431 2012-04-04  Raphael Kubo da Costa  <rakuco@webkit.org>
1432
1433         Unreviewed; update my email address once again in the committers
1434         and watch list.
1435
1436         * Scripts/webkitpy/common/config/committers.py: Prefer my
1437         webkit.org email over my FreeBSD.org one.
1438         * Scripts/webkitpy/common/config/watchlist: Ditto.
1439
1440 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1441
1442         [Qt][WK2] QtWebKit2 should support Page Visibility API
1443         https://bugs.webkit.org/show_bug.cgi?id=81164
1444
1445         Reviewed by Kenneth Rohde Christiansen.
1446
1447         Enabling Page Visiblity API for Qt WebKit2.
1448
1449         * qmake/mkspecs/features/features.prf:
1450
1451 2012-04-04  Andras Becsi  <andras.becsi@nokia.com>
1452
1453         [Qt][WK2] Make the WebView a subclass of Flickable
1454         https://bugs.webkit.org/show_bug.cgi?id=83033
1455
1456         Reviewed by Kenneth Rohde Christiansen.
1457
1458         Remove workaround in MiniBrowser and the ScrollIndicator
1459         now that the WebView is a Flickable.
1460
1461         * MiniBrowser/qt/MiniBrowser.pro:
1462         * MiniBrowser/qt/qml/BrowserWindow.qml:
1463         * MiniBrowser/qt/qml/ScrollIndicator.qml:
1464         * WebKitTestRunner/Target.pri:
1465
1466 2012-04-04  Csaba Osztrogonác  <ossy@webkit.org>
1467
1468         REGRESSION(r113144): It made run-webkit-tests always fail
1469         https://bugs.webkit.org/show_bug.cgi?id=83142
1470
1471         Unreviewed trivial fix after r113144.
1472
1473         * Scripts/run-webkit-tests:
1474
1475 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1476
1477         I really hope this is the last build fix. Apparently exec doesn't quite arguments with
1478         double quotations on Windows. Use system instead.
1479
1480         Hopefully, this won't break anything.
1481
1482         * Scripts/run-webkit-tests:
1483
1484 2012-04-03  Keishi Hattori  <keishi@webkit.org>
1485
1486         Disable ENABLE_DATALIST for now
1487         https://bugs.webkit.org/show_bug.cgi?id=82871
1488
1489         Reviewed by Kent Tamura.
1490
1491         * Scripts/build-webkit: Disabled ENABLE_DATALIST.
1492
1493 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1494
1495         Sigh... this isn't going well. I can't even reproduce this issue locally.
1496         Another speculative fix.
1497
1498         * Scripts/run-webkit-tests:
1499
1500 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1501
1502         I don't know why I'm so sloppy today. Another build fix.
1503
1504         * Scripts/run-webkit-tests:
1505
1506 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1507
1508         Hopefully the last build fix for Chromium Windows.
1509
1510         Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.
1511
1512         * Scripts/run-webkit-tests:
1513
1514 2012-04-03  Dirk Pranke  <dpranke@chromium.org>
1515
1516         [Chromium] Lots of timeouts causing Mac10.6 to exit early.
1517         https://bugs.webkit.org/show_bug.cgi?id=83076
1518
1519         Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).
1520
1521         Add logic to the apple mac and chromium mac code to not use
1522         too many workers; it looks like the xserves (and possibly mac
1523         pros) count hyperthreaded cores when they really shouldn't and
1524         we end up using too many workers at a time; this leads to tests
1525         thrashing and timing out.
1526
1527         This change is a temporary fix to make the bots happy while I
1528         look into more profiling and other fixes.
1529
1530         * Scripts/webkitpy/layout_tests/port/mac.py:
1531         (ChromiumMacPort.default_child_processes):
1532
1533         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1534         (ChromiumMacPort.default_child_processes):
1535
1536 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
1537
1538         WebKitTestRunner's EventSender is leaky
1539         https://bugs.webkit.org/show_bug.cgi?id=83099
1540
1541         Reviewed by Beth Dakin.
1542         
1543         Fix leaks of WKNumbers by using the adoptWK idiom, and make
1544         all the code consistent.
1545
1546         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1547         (WTR::EventSendingController::mouseDown):
1548         (WTR::EventSendingController::mouseUp):
1549         (WTR::EventSendingController::mouseMoveTo):
1550         (WTR::EventSendingController::leapForward):
1551         (WTR::EventSendingController::keyDown):
1552         (WTR::EventSendingController::mouseScrollBy):
1553         (WTR::EventSendingController::addTouchPoint):
1554         (WTR::EventSendingController::updateTouchPoint):
1555         (WTR::EventSendingController::setTouchModifier):
1556         (WTR::EventSendingController::releaseTouchPoint):
1557         (WTR::EventSendingController::cancelTouchPoint):
1558
1559 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1560
1561         Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.
1562
1563         * Scripts/run-webkit-tests:
1564         (useNewRunWebKitTests):
1565
1566 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1567
1568         kill-old-processes should kill apache2 and httpd
1569         https://bugs.webkit.org/show_bug.cgi?id=83065
1570
1571         Reviewed by Tony Chang.
1572
1573         Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.
1574
1575         * BuildSlaveSupport/kill-old-processes:
1576
1577 2012-04-03  Tony Chang  <tony@chromium.org>
1578
1579         run the same test steps on test only bots as on build-and-test bots
1580         https://bugs.webkit.org/show_bug.cgi?id=83090
1581
1582         Reviewed by Ryosuke Niwa.
1583
1584         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1585         (TestFactory.__init__):
1586
1587 2012-04-03  Ami Fischman  <fischman@chromium.org>
1588
1589         Add a Media watchlist.
1590         https://bugs.webkit.org/show_bug.cgi?id=83071
1591
1592         Reviewed by David Levin.
1593
1594         * Scripts/webkitpy/common/config/watchlist:
1595
1596 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
1597
1598         Fix large leak in WebKitTestRunner
1599         https://bugs.webkit.org/show_bug.cgi?id=83084
1600
1601         Reviewed by Beth Dakin.
1602         
1603         Fix a leak of the bimap backing store created when doing pixel and
1604         ref tests. This leak was causing serious thrash on the test bots.
1605         
1606         We don't need to allocate memory for CGBitmapContextCreate(); if we
1607         pass NULL, it will allocate and manage its own backing store.
1608
1609         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1610         (WTR::createCGContextFromImage):
1611
1612 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1613
1614         Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.
1615
1616         * BuildSlaveSupport/built-product-archive:
1617         (unzipArchive):
1618
1619 2012-04-03  Ojan Vafai  <ojan@chromium.org>
1620
1621         Give more human friendly error message when builders fail to load or have stale data.
1622         https://bugs.webkit.org/show_bug.cgi?id=83058
1623
1624         Reviewed by Eric Seidel.
1625
1626         * TestResultServer/static-dashboards/dashboard_base.js:
1627         (addError):
1628         (addBuilderLoadErrors):
1629         (handleLocationChange):
1630         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1631
1632 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1633
1634         Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.
1635
1636         * BuildSlaveSupport/built-product-archive:
1637         (extractBuiltProduct):
1638
1639 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1640
1641         Yet another build fix after r113067. Don't trigger Chromium testers right away
1642         since they're now triggered by builders.
1643
1644         * BuildSlaveSupport/build.webkit.org-config/config.json:
1645
1646 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1647
1648         Another build fix after r113067 for Mac port.
1649         It turned out that archiving the entire build directory doesn't work.
1650
1651         * BuildSlaveSupport/built-product-archive:
1652         (createZipManually):
1653         (createZip):
1654         (archiveBuiltProduct):
1655
1656 2012-04-03  Mike Lattanzio  <mlattanzio@rim.com>
1657
1658         [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
1659         https://bugs.webkit.org/show_bug.cgi?id=82643
1660
1661         Update LayoutTestController to accomodate the new find API.
1662         It now provides caseSensitive functionality to DRT.
1663
1664         Internal Review by Andy Chen.
1665
1666         Reviewed by Rob Buis.
1667
1668         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1669         (LayoutTestController::findString):
1670
1671 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1672
1673         Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
1674         because download-built-product creates the build directory as needed.
1675
1676         This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.
1677
1678         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1679         (TestFactory.__init__):
1680
1681 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1682
1683         Build fix after r113067. Don't delete the build directory.
1684
1685         * BuildSlaveSupport/built-product-archive:
1686         (extractBuiltProduct):
1687
1688 2012-04-02  Ojan Vafai  <ojan@chromium.org>
1689
1690         Load all builder lists from the buildbot json
1691         https://bugs.webkit.org/show_bug.cgi?id=82998
1692
1693         Reviewed by Adam Barth.
1694
1695         Also, remove an unnecessary list of test types. Now we don't hard-code
1696         builder names anywhere and we only have a single hard-coded list of
1697         test types.
1698
1699         * TestResultServer/static-dashboards/builders.js:
1700         (BuilderMaster.prototype.logPath):
1701         (BuilderMaster.prototype.builderJsonPath):
1702         (requestBuilderList.xhr.onload):
1703         (requestBuilderList.xhr.onerror):
1704         (isChromiumDepsFyiGpuTestRunner):
1705         (isChromiumTipOfTreeGpuTestRunner):
1706         (isChromiumDepsGTestRunner):
1707         (isChromiumDepsCrosGTestRunner):
1708         (isChromiumTipOfTreeGTestRunner):
1709         (onBuilderListLoad):
1710         (loadBuildersList):
1711         * TestResultServer/static-dashboards/dashboard_base.js:
1712         (parseCrossDashboardParameters):
1713         (currentBuilderGroupCategory):
1714         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1715         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1716         (testHtmlForTestsWithExpectationsButNoFailures):
1717         (testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
1718         (testGenerateChromiumDepsGTestBuildersFromBuilderList):
1719         (testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
1720         (testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):
1721         * TestResultServer/static-dashboards/timeline_explorer.html:
1722
1723 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
1724
1725         Chromium testers should extract builds instead of building on their own
1726         https://bugs.webkit.org/show_bug.cgi?id=82996
1727
1728         Reviewed by Tony Chang.
1729
1730         Make Chromium builders triggger Chromium testers and make testers download and extract builds
1731         from the buildbot master instead of building binaries on their own.
1732
1733         Add download-built-product to wrap curl used in the download-built-product step since Windows
1734         does not provide "curl" natively.
1735
1736         * BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make
1737         Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.
1738         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1739         (DownloadBuiltProduct): Call download-built-product instead of curl.
1740         * BuildSlaveSupport/built-product-archive:
1741         (createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
1742         needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
1743         (archiveBuiltProduct): Zip the configuration build directory on Mac port.
1744         (unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
1745         (extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.
1746         * BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.
1747
1748 2012-04-03  Martin Robinson  <mrobinson@igalia.com>
1749
1750         [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
1751         https://bugs.webkit.org/show_bug.cgi?id=82473
1752
1753         Reviewed by Philippe Normand.
1754
1755         Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
1756         was ever run.
1757
1758         * gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
1759         check if the user has ever run update-gtk-libs and, if so, then use jhbuild.
1760
1761 2012-04-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1762
1763         [EFL] DRT support for setInteractiveFormValidationEnabled
1764         https://bugs.webkit.org/show_bug.cgi?id=82050
1765
1766         Enable interactive form validation and unskip tests from the
1767         skip list.
1768
1769         Reviewed by Antonio Gomes.
1770
1771         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1772         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1773
1774 2012-04-03  Philippe Normand  <pnormand@igalia.com>
1775
1776         Unreviewed, another test-webkitpy fix-up after r113037.
1777
1778         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock
1779         crash dump depending on current environment.
1780
1781 2012-04-03  Philippe Normand  <pnormand@igalia.com>
1782
1783         Unreviewed, test-webkitpy build fix after r113037.
1784
1785         * Scripts/webkitpy/layout_tests/port/gtk.py:
1786         (GtkPort._get_crash_log):
1787
1788 2012-04-03  Philippe Normand  <pnormand@igalia.com>
1789
1790         [GTK] crash log reports support
1791         https://bugs.webkit.org/show_bug.cgi?id=81659
1792
1793         Reviewed by Martin Robinson.
1794
1795         Removed the daemontools crashmon/xvfb scripts and implemented the crash
1796         log reporting in the NRWT Gtk port. To get proper crash logs one
1797         needs to set the core pattern like this:
1798         echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
1799         Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
1800         environment variable.
1801
1802         * BuildSlaveSupport/gtk/README:
1803         * BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
1804         * BuildSlaveSupport/gtk/crashmon/log/run: Removed.
1805         * BuildSlaveSupport/gtk/crashmon/run: Removed.
1806         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1807         * BuildSlaveSupport/gtk/xvfb/log/run: Removed.
1808         * BuildSlaveSupport/gtk/xvfb/run: Removed.
1809         * Scripts/new-run-webkit-tests:
1810         * Scripts/webkitpy/layout_tests/port/gtk.py:
1811         (GtkDriver.stop):
1812         (GtkPort.show_results_html_file):
1813         (GtkPort):
1814         (GtkPort._get_gdb_output):
1815         (GtkPort._get_crash_log):
1816         (GtkPort._get_crash_log.match_filename):
1817         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1818         (GtkPortTest):
1819         (test_show_results_html_file):
1820         (assertLinesEqual):
1821         (_mock_gdb_output):
1822         (test_get_crash_log):
1823
1824 2012-04-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1825
1826         Enable and connect the WebInspectorServer with WebKit2 pages.
1827         https://bugs.webkit.org/show_bug.cgi?id=73094
1828
1829         Reviewed by Simon Hausmann.
1830
1831         Enable developer extras on pages in MiniBrowser for Qt.
1832
1833         * MiniBrowser/qt/qml/BrowserWindow.qml:
1834
1835 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
1836
1837         [EFL] LayoutTestController needs implementation of setDefersLoading
1838         https://bugs.webkit.org/show_bug.cgi?id=82890
1839
1840         Reviewed by Philippe Normand.
1841
1842         Implement setDefersLoading() in EFL's LayoutTestController so that the
1843         corresponding test case can be removed from the skip list.
1844
1845         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1846         (LayoutTestController::setDefersLoading):
1847
1848 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
1849
1850         [EFL] LayoutTestController needs implementation of goBack
1851         https://bugs.webkit.org/show_bug.cgi?id=81914
1852
1853         Reviewed by Philippe Normand.
1854
1855         Implement goBack() in EFL's LayoutTestController by calling
1856         ewk_frame_back().
1857
1858         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1859         (LayoutTestController::goBack):
1860
1861 2012-04-03  Alexander Shalamov  <alexander.shalamov@intel.com>
1862
1863         [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
1864         https://bugs.webkit.org/show_bug.cgi?id=82589
1865
1866         Add missing implementation for pageSizeAndMarginsInPixels to EFL's LayoutTestController
1867         in order to unskip printing/page-format-data.html
1868
1869         Reviewed by Philippe Normand.
1870
1871         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1872         (LayoutTestController::pageSizeAndMarginsInPixels):
1873
1874 2012-04-03  Simon Pena  <spena@igalia.com>
1875
1876         [GTK] DRT missing didRunInsecureContent notification
1877         https://bugs.webkit.org/show_bug.cgi?id=59367
1878
1879         Reviewed by Philippe Normand.
1880
1881         Connect DumpRenderTree to WebFrame's "insecure-content-run", in both
1882         the main WebFrame or any other WebFrame created later. Added
1883         "didRunInsecureContent" notification in the callback in order to
1884         get the LayoutTests passing.
1885
1886         * DumpRenderTree/gtk/DumpRenderTree.cpp: Connect
1887         to WebFrame's "insecure-content-run" signal and add
1888         didRunInsecureContent notification in the callback to get the
1889         LayoutTests passing.
1890         (didRunInsecureContent):
1891         (createWebView):
1892
1893 2012-04-03  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1894
1895         rebaseline-server: Make it possible to not launch a browser with the server.
1896         https://bugs.webkit.org/show_bug.cgi?id=82999
1897
1898         Reviewed by Adam Barth.
1899
1900         Add the `--no-show-results' option, which lets one decide not to
1901         launch a web browser when running the rebaseline server.  This is
1902         especially useful if the default browser is not the wanted one, or
1903         if the rebaseline server page is already open.
1904
1905         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
1906         (AbstractLocalServerCommand.__init__):
1907         (AbstractLocalServerCommand.execute):
1908
1909 2012-04-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1910
1911         EFL's LayoutTestController disableImageLoading implementation.
1912         https://bugs.webkit.org/show_bug.cgi?id=82848
1913
1914         Reviewed by Hajime Morita.
1915
1916         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1917         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1918         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1919         (LayoutTestController::disableImageLoading):
1920
1921 2012-04-02  Alexander Shalamov  <alexander.shalamov@intel.com>
1922
1923         [EFL] LayoutTestController needs implementation of isPageBoxVisible
1924         https://bugs.webkit.org/show_bug.cgi?id=82591
1925
1926         Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
1927         in order to unskip printing/page-format-data.html
1928
1929         Reviewed by Hajime Morita.
1930
1931         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1932         (LayoutTestController::isPageBoxVisible):
1933
1934 2012-04-02  Simon Fraser  <simon.fraser@apple.com>
1935
1936         run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
1937         https://bugs.webkit.org/show_bug.cgi?id=82962
1938
1939         Reviewed by Dirk Pranke.
1940
1941         Ensure that _build_path() returns an absolute path.
1942
1943         Eric Seidel also had to deploy MockConfig in a bunch of places
1944         in order to correct previous testing errors where we were
1945         pretending that "Mock Output from child process" (returned by MockExecutive.run_command)
1946         was a real path.  The real Config object calls run_command("webkit-build-directory")
1947         to read the WebKit build directory from the webkitdirs.pm perl code.
1948         MockConfig abstracts this away and always returns "/mock-build" during
1949         testing.  This change is much larger than one would think necessary
1950         because of needing to deploy this MockConfig class.
1951
1952         * Scripts/webkitpy/layout_tests/port/webkit.py:
1953         (WebKitPort._build_path):
1954
1955 2012-04-02  Ojan Vafai  <ojan@chromium.org>
1956
1957         Fix snafu in r112971. We were never calling parseParameter for builder.
1958
1959         * TestResultServer/static-dashboards/dashboard_base.js:
1960
1961 2012-04-02  Ojan Vafai  <ojan@chromium.org>
1962
1963         Generate the lists of all layout test builders from the buildbot json
1964         https://bugs.webkit.org/show_bug.cgi?id=82924
1965
1966         Reviewed by Mihai Parparita.
1967
1968         In order to make this work, cleaned up a lot of existing technical debt.
1969         -Got rid of expectations builder. This concept is outdated and just dead code.
1970         -Split hash parameter parsing into two functions. One for dashboard_base
1971         (crossDashboardParameters) and one for the specific dashboard html file
1972         (dashboardSpecificParameters). In the old world, parseParameters needed to
1973         be called twice and depended on it's own output the first time through.
1974         Now we only need to parse crossDashboardParameters first and crossDashboardParameters
1975         doesn't depend on the output of crossDashboardParameters.
1976         -Lots of variable/method renames due to the above.
1977         -g_defaultDashboardSpecificStateValues now has to list all possible hash parameters
1978         for that dashboard.
1979
1980         * TestResultServer/static-dashboards/aggregate_results.html:
1981         * TestResultServer/static-dashboards/builders.js:
1982         (BuilderGroup):
1983         (BuilderGroup.prototype.setup):
1984         (jsonRequest.xhr.onload):
1985         (jsonRequest.xhr.onerror):
1986         (isWebkitTestRunner):
1987         (isChromiumWebkitTipOfTreeTestRunner):
1988         (isChromiumWebkitDepsTestRunner):
1989         (generateBuildersFromBuilderList):
1990         (onLayoutTestBuilderListLoad):
1991         (onErrorLoadingBuilderList):
1992         (loadBuildersList):
1993         * TestResultServer/static-dashboards/dashboard_base.js:
1994         (handleValidHashParameterWrapper):
1995         (queryHashAsMap):
1996         (parseParameter):
1997         (parseCrossDashboardParameters):
1998         (parseDashboardSpecificParameters):
1999         (parseParameters):
2000         (diffStates):
2001         (defaultValue):
2002         (isLayoutTestResults):
2003         (isGPUTestResults):
2004         (currentBuilderGroupCategory):
2005         (currentBuilderGroup):
2006         (initBuilders):
2007         Now that we've split parameter parseing, these methods no longer need
2008         to take an optional state. They can always just use the global cross-dashboard state.
2009
2010         (pathToBuilderResultsFile):
2011         (appendJSONScriptElementFor):
2012         (appendJSONScriptElements):
2013         (handleResourceLoadError):
2014         (haveJsonFilesLoaded):
2015         (combinedDashboardState):
2016         (setQueryParameter):
2017         (permaLinkURLHash):
2018         (toggleQueryParameter):
2019         (queryParameterValue):
2020         (selectHTML):
2021         (htmlForTestTypeSwitcher):
2022         (g_handleBuildersListLoaded):
2023         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2024         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2025         (testPlatformAndBuildType):
2026         (testSubstringList):
2027         (testHtmlForTestTypeSwitcherGroup):
2028         (testLookupVirtualTestSuite):
2029         (testBaseTest):
2030         (generateBuildersFromBuilderListHelper):
2031         (testGenerateChromiumWebkitTipOfTreeBuildersFromBuilderList):
2032         (testGenerateChromiumWebkitDepsBuildersFromBuilderList):
2033         (assertObjectsDeepEqual):
2034         (testQueryHashAsMap):
2035         (testDiffStates):
2036         * TestResultServer/static-dashboards/timeline_explorer.html:
2037         * TestResultServer/static-dashboards/treemap.html:
2038
2039 2012-04-02  Tony Chang  <tony@chromium.org>
2040
2041         check-webkit-style errors when removing .png files
2042         https://bugs.webkit.org/show_bug.cgi?id=82933
2043
2044         Reviewed by David Levin.
2045
2046         * Scripts/webkitpy/style/patchreader.py:
2047         (PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).
2048         * Scripts/webkitpy/style/patchreader_unittest.py:
2049         (test_check_patch_with_png_deletion):
2050
2051 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2052
2053         Unreviewed, rolling out r112948.
2054         http://trac.webkit.org/changeset/112948
2055         https://bugs.webkit.org/show_bug.cgi?id=82961
2056
2057         Someone else already checked in a similar change (Requested by
2058         sundiamonde on #webkit).
2059
2060         * Scripts/webkitpy/layout_tests/port/webkit.py:
2061         (WebKitDriver._start):
2062
2063 2012-04-02  Adam Barth  <abarth@webkit.org>
2064
2065         garden-o-matic isn't able to rebaseline audio failures
2066         https://bugs.webkit.org/show_bug.cgi?id=82957
2067
2068         Reviewed by Chris Rogers.
2069
2070         This patch just adds "wav" to the list of test suffixes and updates the
2071         unit tests to show that we're rebaselining audio tests results now too.
2072
2073         * Scripts/webkitpy/tool/commands/rebaseline.py:
2074         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2075         (test_rebaseline_updates_expectations_file):
2076
2077 2012-04-02  Adam Barth  <abarth@webkit.org>
2078
2079         garden-o-matic should let you listen to audio failures
2080         https://bugs.webkit.org/show_bug.cgi?id=82953
2081
2082         Reviewed by Chris Rogers.
2083
2084         Now that we've actually got an audio failure on the bots, we can clean
2085         up the last stray bugs.  This patch doesn't have any tests because I'm
2086         lame.
2087
2088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2091         (.):
2092
2093 2012-04-02  Stephanie Lewis  <slewis@apple.com>
2094
2095         run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
2096         https://bugs.webkit.org/show_bug.cgi?id=82552
2097
2098         Reviewed by Dirk Pranke.
2099
2100         Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.
2101
2102         * Scripts/webkitpy/layout_tests/port/webkit.py:
2103         (WebKitDriver._start):
2104
2105 2012-04-02  Dirk Pranke  <dpranke@chromium.org>
2106
2107         NRWT is not printing out the builder it's uploading JSON files for
2108         https://bugs.webkit.org/show_bug.cgi?id=82834
2109
2110         Reviewed by Ojan Vafai.
2111
2112         Handle log messages of the form log.info("%s", arg) properly ...
2113         I didn't even know you could do that :).
2114
2115         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2116         (_LogHandler.emit):
2117         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2118         (RegularTest.test_log_args):
2119         (VerboseTest.test_log_args):
2120
2121 2012-04-02  Tim Horton  <timothy_horton@apple.com>
2122
2123         [mac] LayoutTestHelper crashes if there is no main display
2124         https://bugs.webkit.org/show_bug.cgi?id=82944
2125         <rdar://problem/11162954>
2126
2127         Reviewed by Simon Fraser.
2128
2129         If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
2130         a null dictionary, so we shouldn't go ahead and try to read from it.
2131
2132         * DumpRenderTree/mac/LayoutTestHelper.m:
2133         (installLayoutTestColorProfile):
2134
2135 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
2136
2137         [Qt][WK2] Set up plugin process on Unix
2138         https://bugs.webkit.org/show_bug.cgi?id=72121
2139
2140         Reviewed by Simon Hausmann.
2141
2142         * qmake/mkspecs/features/features.prf: Reenable plugins
2143         and turn on plugin process.
2144
2145 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2146
2147         Unreviewed, rolling out r112868, r112879, and r112881.
2148         http://trac.webkit.org/changeset/112868
2149         http://trac.webkit.org/changeset/112879
2150         http://trac.webkit.org/changeset/112881
2151         https://bugs.webkit.org/show_bug.cgi?id=82901
2152
2153         "Build fail on bots." (Requested by kbalazs on #webkit).
2154
2155         * MiniBrowser/gtk/GNUmakefile.am:
2156         * qmake/mkspecs/features/features.prf:
2157
2158 2012-04-02  Philippe Normand  <pnormand@igalia.com>
2159
2160         [GTK] Enable shadow-dom in build-webkit.
2161
2162         Rubber-stamped by Gustavo Noronha Silva.
2163
2164         * Scripts/build-webkit: Enable shadow-dom build, this is need to
2165         have a working build currently.
2166
2167 2012-04-02  Andreas Kling  <kling@webkit.org>
2168
2169         Adding Zalan Bujtas to committers list.
2170
2171         * Scripts/webkitpy/common/config/committers.py:
2172
2173 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
2174
2175         [Qt][WK2] Set up plugin process on Unix
2176         https://bugs.webkit.org/show_bug.cgi?id=72121
2177
2178         Reviewed by Simon Hausmann.
2179
2180         * qmake/mkspecs/features/features.prf: Reenable plugins
2181         and turn on plugin process.
2182
2183 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2184
2185         Unreviewed, rolling out r112651.
2186         http://trac.webkit.org/changeset/112651
2187         https://bugs.webkit.org/show_bug.cgi?id=82887
2188
2189         It doesn't work with older Qt5 (Requested by Ossy on #webkit).
2190
2191         * MiniBrowser/qt/BrowserWindow.cpp:
2192         (BrowserWindow::updateVisualMockTouchPoints):
2193         * MiniBrowser/qt/main.cpp:
2194         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2195         (WTR::WrapperWindow::handleStatusChanged):
2196         * qmake/mkspecs/features/unix/default_post.prf:
2197
2198 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2199
2200         [GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
2201         https://bugs.webkit.org/show_bug.cgi?id=82877
2202
2203         Reviewed by Philippe Normand.
2204
2205         * Scripts/run-gtk-tests:
2206         (TestRunner.run_tests): Use replace instead of lstrip to remove
2207         the programs_path from the full path of unit tests.
2208
2209 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2210
2211         Unreviewed. Skip flaky unit tests.
2212
2213         * Scripts/run-gtk-tests:
2214         (TestRunner):
2215
2216 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
2217
2218         webkitpy rebaseline.
2219
2220         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2221         (test_run_test_set_with_json_output):
2222         (test_run_test_set_with_json_source):
2223
2224 2012-04-01  Ryosuke Niwa  <rniwa@webkit.org>
2225
2226         perf-o-matic should store test results' units
2227         https://bugs.webkit.org/show_bug.cgi?id=82852
2228
2229         Reviewed by Kentaro Hara.
2230
2231         Include units in the results JSON.
2232
2233         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2234         (PerfTestsRunner._process_chromium_style_test_result):
2235         (PerfTestsRunner._process_parser_test_result):
2236
2237 2012-04-01  Tony Tseung  <tseung@apple.com>
2238
2239         Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
2240         composite fonts from existing physical fonts.
2241         <rdar://problem/10717370>
2242         https://bugs.webkit.org/show_bug.cgi?id=82810
2243             
2244         A new test font of this kind as been added to the test tools for running the webkit-tests
2245
2246         Reviewed by Dan Bernstein.
2247
2248         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2249         Added new dependency SampleFont.sfont
2250         
2251         * DumpRenderTree/fonts/SampleFont.sfont: Added.
2252         
2253         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2254         * DumpRenderTree/mac/DumpRenderTree.mm:
2255         (allowedFontFamilySet):
2256         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
2257         
2258         (activateTestingFonts):
2259         Added the registration of the Composite Font Referene sample font
2260         
2261         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2262         (WTR::allowedFontFamilySet):
2263         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
2264
2265         (WTR::activateFonts):
2266         Added the registration of the Composite Font Referene sample font
2267
2268         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2269         Added new dependency SampleFont.sfont
2270
2271         * WebKitTestRunner/fonts/SampleFont.sfont: Added.
2272
2273 2012-04-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2274
2275         Support the Network Information API
2276         https://bugs.webkit.org/show_bug.cgi?id=73528
2277
2278         Reviewed by Adam Barth.
2279
2280         Add network information API feature to build script.
2281
2282         * Scripts/build-webkit:
2283
2284 2012-03-31  Ojan Vafai  <ojan@chromium.org>
2285
2286         Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
2287         https://bugs.webkit.org/show_bug.cgi?id=82839
2288
2289         Reviewed by Adam Barth.
2290
2291         Also, update various hard-coded lists for WIN7 and Lion ports.
2292         This is necessary since the new list of builders grabbed off the
2293         buildbot includes Lion.
2294
2295         * TestResultServer/static-dashboards/builders.js:
2296         (generateWebkitBuildersFromBuilderList):
2297         (xhr.onreadystatechange):
2298         Don't use dashboard_base's request method to avoid layering violation.
2299
2300         * TestResultServer/static-dashboards/dashboard_base.js:
2301         (parseParameters):
2302         (initBuilders):
2303         (haveJsonFilesLoaded):
2304         (g_handleBuildersListLoaded):
2305         Block loading the JSON files for each builder until we actually have a list of builders.
2306
2307         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2308         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2309         (testPlatformAndBuildType):
2310         (testGenerateWebkitBuildersFromBuilderList):
2311         * TestResultServer/static-dashboards/timeline_explorer.html:
2312         * TestResultServer/static-dashboards/treemap.html:
2313         Delay generating the page until the builder list has loaded.
2314
2315 2012-03-31  Ojan Vafai  <ojan@chromium.org>
2316
2317         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
2318         https://bugs.webkit.org/show_bug.cgi?id=82799
2319
2320         Reviewed by Eric Seidel.
2321
2322         If we don't run a test, mark it as skipped.
2323
2324         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2325         (Manager._mark_interrupted_tests_as_skipped):
2326         (Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
2327         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2328         (ManagerTest.test_interrupt_if_at_failure_limits):
2329
2330 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2331
2332         One more build fix after r112781 for Chromium Windows.
2333         Don't copy zip .idb files.
2334
2335         * BuildSlaveSupport/built-product-archive:
2336         (copyBuildFiles):
2337
2338 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2339
2340         Yet another build fix after r112781 for Chromium Windows.
2341         Run webkit-build-directory by perl explicitly.
2342
2343         * BuildSlaveSupport/built-product-archive:
2344         (determineWebKitBuildDirectory):
2345
2346 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2347
2348         Fix the syntax error in master.cfg after r112734.
2349
2350         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2351         (unitTestsSupported):
2352
2353 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2354
2355         Another build fix after r112781.
2356
2357         * BuildSlaveSupport/built-product-archive:
2358         (createZip):
2359
2360 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2361
2362         Build fix after r112781.
2363
2364         * BuildSlaveSupport/built-product-archive:
2365         (createZipManually):
2366         (createZip):
2367
2368 2012-03-30  Ryosuke Niwa  <rniwa@webkit.org>
2369
2370         Chromium bots should upload archived built files
2371         https://bugs.webkit.org/show_bug.cgi?id=82666
2372
2373         Reviewed by Tony Chang.
2374
2375         * BuildSlaveSupport/build.webkit.org-config/config.json:
2376         * BuildSlaveSupport/built-product-archive:
2377         (main):
2378         (determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
2379         call out to webkit-build-directory.
2380         (removeDirectoryIfExists): Extracted.
2381         (copyBuildFiles): Added to avoid archiving useless intermedinate files.
2382         (createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
2383         (createZipManually.addToArchive):
2384         (createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
2385         (archiveBuiltProduct): Add support for Chromium port.
2386         * Scripts/webkit-build-directory: Add support for --platform options.
2387
2388 2012-03-30  Dan Bernstein  <mitz@apple.com>
2389
2390         Reverted r112767, because it caused many vertical text tests to fail.
2391
2392         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2393         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
2394         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2395         * DumpRenderTree/mac/DumpRenderTree.mm:
2396         (allowedFontFamilySet):
2397         (activateTestingFonts):
2398         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2399         (WTR::allowedFontFamilySet):
2400         (WTR::activateFonts):
2401         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2402         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
2403
2404 2012-03-30  Malcolm MacLeod  <malcolm.macleod@tshwanedje.com>
2405
2406         [wx] Move wxWebKit API into WebKit namespace.
2407         https://bugs.webkit.org/show_bug.cgi?id=82740
2408
2409         Reviewed by Kevin Ollivier.
2410
2411         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2412         (LayoutWebViewEventHandler::LayoutWebViewEventHandler):
2413         (LayoutWebViewEventHandler::bindEvents):
2414         (LayoutWebViewEventHandler::OnLoadEvent):
2415         (LayoutWebViewEventHandler::OnAlertEvent):
2416         (LayoutWebViewEventHandler::OnConfirmEvent):
2417         (LayoutWebViewEventHandler::OnPromptEvent):
2418         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
2419         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
2420         (LayoutWebViewEventHandler::OnWindowObjectClearedEvent):
2421         (LayoutWebViewEventHandler):
2422         (dumpFramesAsText):
2423         (dump):
2424         (MyApp::OnInit):
2425         * wx/browser/browser.cpp:
2426         (MyApp::OnInit):
2427
2428 2012-03-30  Eli Fidler  <efidler@rim.com>
2429
2430         Enable OpenType Sanitizer for BlackBerry port.
2431         https://bugs.webkit.org/show_bug.cgi?id=82782
2432
2433         Reviewed by Eric Seidel.
2434
2435         * Scripts/webkitdirs.pm:
2436         (blackberryCMakeArguments): add OTS to include path
2437
2438 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
2439
2440         run-webkit-tests needs to set DYLD_LIBRARY_PATH as well
2441         as DYLD_FRAMEWORK_PATH, so that libWebCoreTestSupport.dylib
2442         is found.
2443
2444         <rdar://problem/11158581>
2445         
2446         Reviewed by Mark Rowe.
2447
2448         * Scripts/webkitpy/layout_tests/port/webkit.py:
2449         (WebKitDriver._start):
2450
2451 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
2452
2453         Disable run-api-tests on release mac builds
2454         https://bugs.webkit.org/show_bug.cgi?id=82788
2455
2456         Reviewed by Ryosuke Niwa.
2457         
2458         TestWebKitAPI crashes every time in release builds currently
2459         (https://bugs.webkit.org/show_bug.cgi?id=82652) so disable
2460         run-api-tests on mac release builders.
2461
2462         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2463         (unitTestsSupported):
2464
2465 2012-03-30  Chang Shu  <cshu@webkit.org>
2466
2467         Unreviewed. Update my email.
2468
2469         * Scripts/webkitpy/common/config/committers.py:
2470
2471 2012-03-30  Chris Fleizach  <cfleizach@apple.com>
2472
2473         AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&)
2474         https://bugs.webkit.org/show_bug.cgi?id=82745
2475
2476         Reviewed by Simon Fraser.
2477
2478         * DumpRenderTree/AccessibilityUIElement.cpp:
2479         (rangeForPositionCallback):
2480         (AccessibilityUIElement::rangeForPosition):
2481         (AccessibilityUIElement::getJSClass):
2482         * DumpRenderTree/AccessibilityUIElement.h:
2483         (AccessibilityUIElement):
2484         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2485         (AccessibilityUIElement::rangeForPosition):
2486         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2487         (WTR::AccessibilityUIElement::rangeForPosition):
2488         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2489         (AccessibilityUIElement):
2490         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2491         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2492         (WTR::AccessibilityUIElement::rangeForPosition):
2493         (WTR):
2494
2495 2012-03-30  David Barr  <davidbarr@chromium.org>
2496
2497         Split up top-level .gitignore and .gitattributes
2498         https://bugs.webkit.org/show_bug.cgi?id=82687
2499
2500         Reviewed by Tor Arne Vestbø.
2501
2502         * .gitattributes: Added.
2503         * .gitignore: Added.
2504         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Added.
2505         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Added.
2506
2507 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
2508
2509         Actually remove the ChromiumOS GTK builder, like r112673 said it would.
2510
2511         * TestResultServer/static-dashboards/builders.js:
2512
2513 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
2514
2515         Update ChromiumOS bot names in builders.js to reflect changes made by
2516         http://crrev.com/129835
2517         
2518         Also removes the ChromiumOS GTK builder, which was removed by
2519         http://crrev.com/129835
2520
2521         * TestResultServer/static-dashboards/builders.js:
2522
2523 2012-03-30  Vineet Chaudhary  <rgf748@motorola.com>
2524
2525         [GTK] Disable introspection build in the at-spi2-core module.
2526         https://bugs.webkit.org/show_bug.cgi?id=82729
2527
2528         Reviewed by Philippe Normand.
2529
2530         This change is a follow-up of bug 82395 which initially disabled for other modules of the set.
2531
2532         * gtk/jhbuild.modules: Disable introspection.
2533
2534 2012-03-30  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2535
2536         Add a "preview" state to Page Visibility API implementation
2537         https://bugs.webkit.org/show_bug.cgi?id=81355
2538
2539         Reviewed by Adam Barth.
2540
2541         Updating the Page Visibility API implementation to the current spec version.
2542
2543         * DumpRenderTree/chromium/LayoutTestController.cpp:
2544         (LayoutTestController::setPageVisibility):
2545
2546 2012-03-30  Keishi Hattori  <keishi@webkit.org>
2547
2548         Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
2549         https://bugs.webkit.org/show_bug.cgi?id=80972
2550
2551         Reviewed by Kent Tamura.
2552
2553         * Scripts/build-webkit:
2554         * qmake/mkspecs/features/features.prf:
2555
2556 2012-03-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
2557
2558         [Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
2559         https://bugs.webkit.org/show_bug.cgi?id=82195
2560
2561         Reviewed by Simon Hausmann.
2562
2563         * MiniBrowser/qt/BrowserWindow.cpp:
2564         (BrowserWindow::updateVisualMockTouchPoints):
2565         * MiniBrowser/qt/main.cpp:
2566         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2567         (WTR::WrapperWindow::handleStatusChanged):
2568         * qmake/mkspecs/features/unix/default_post.prf:
2569
2570 2012-03-30  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2571
2572         [EFL] Implement LayoutTestController::setMinimumTimerInterval
2573         https://bugs.webkit.org/show_bug.cgi?id=81220
2574
2575         Add missing implementation setMinimumTimerInterval to EFL's
2576         LayoutTestController so that we can unskip related tests from the skip list.
2577
2578         Reviewed by Philippe Normand.
2579
2580         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2581         (LayoutTestController::setMinimumTimerInterval):
2582
2583 2012-03-29  Dan Bernstein  <mitz@apple.com>
2584
2585         Removed “Intel” from the Lion builders’ names.
2586
2587         Rubber-stamped by Mark Rowe.
2588
2589         * BuildSlaveSupport/build.webkit.org-config/config.json:
2590         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2591         (LeaksViewer._displayURLPrompt):
2592
2593 2012-03-29  Mihai Parparita  <mihaip@chromium.org>
2594
2595         [Chromium] Add sharded ChromiumOS debug bots to builders.js
2596         https://bugs.webkit.org/show_bug.cgi?id=82639
2597
2598         Reviewed by Eric Seidel.
2599
2600         The bots were sharded by http://crrev.com/129613, update builders.js
2601         to reflect this.
2602
2603         * TestResultServer/static-dashboards/builders.js:
2604
2605 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
2606
2607         remove support for junit-style xml output from test-webkitpy
2608         https://bugs.webkit.org/show_bug.cgi?id=82279
2609
2610         Reviewed by Eric Seidel.
2611
2612         This was added when we were looking into integrating w/ Jenkins
2613         rather than buildbot, but I believe that project got shelved, so
2614         this is unused. We can always add it back in later as necessary.
2615
2616         * Scripts/webkitpy/test/main.py:
2617         (Tester._parse_args):
2618         (Tester._run_tests):
2619         * Scritps/webkitpy/thirdparty/__init__.py:
2620
2621 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
2622
2623         new-run-webkit-tests: crashes when it fails to decode a stack trace
2624         https://bugs.webkit.org/show_bug.cgi?id=82673
2625
2626         Unreviewed, build fix.
2627
2628         We are assuming the stdout/stderr output from the driver is utf-8
2629         encoded when we get stack traces; this may not be a valid
2630         assumption generally, but if we do get strings that aren't valid
2631         utf-8, we would crash. Now we will ignore any decoding errors.
2632
2633         * Scripts/webkitpy/layout_tests/port/base.py:
2634         (Port._get_crash_log):
2635         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2636         (PortTestCase.test_get_crash_log):
2637
2638 2012-03-29  Simon Fraser  <simon.fraser@apple.com>
2639
2640         Scripts fail to detect when a tool crashes
2641         https://bugs.webkit.org/show_bug.cgi?id=82659
2642
2643         Reviewed by Mark Rowe.
2644         
2645         Have exitStatus() detect when the process fail to exit cleanly
2646         (possibly because of a crash), and return a non-zero exit code
2647         in that case.
2648
2649         * Scripts/VCSUtils.pm:
2650         (exitStatus):
2651
2652 2012-03-29  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2653
2654         [GTK][EFL] run-javascriptcore-tests should be run through jhbuild
2655         https://bugs.webkit.org/show_bug.cgi?id=82581
2656
2657         Reviewed by Martin Robinson.
2658
2659         Running Javascriptcore tests through jhbuild
2660         for consistency with run-webkit-tests and in order to
2661         avoid confusing libraries when facing regressions.
2662
2663         * Scripts/run-javascriptcore-tests:
2664
2665 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
2666
2667         test-webkitpy: add --timing
2668         https://bugs.webkit.org/show_bug.cgi?id=82550
2669
2670         Reviewed by Eric Seidel.
2671
2672         This patch adds a --timing option that will display the time
2673         each test takes. It also removes the --silent option, since
2674         probably no one ever used it, and cleans up the logging
2675         option parsing code to be easier to follow.
2676
2677         * Scripts/webkitpy/test/main.py:
2678         (Tester._parse_args):
2679         (Tester._configure):
2680         * Scripts/webkitpy/test/runner.py:
2681         (TestRunner.write_result):
2682         * Scripts/webkitpy/test/runner_unittest.py:
2683         (RunnerTest.test_regular):
2684         (RunnerTest.test_verbose):
2685         (RunnerTest):
2686         (RunnerTest.test_timing):
2687
2688 2012-03-29  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2689
2690         HashMap<>::add should return a more descriptive object
2691         https://bugs.webkit.org/show_bug.cgi?id=71063
2692
2693         Reviewed by Ryosuke Niwa.
2694
2695         Update code to use AddResult instead of a pair.
2696
2697         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2698         (LayoutTestController::evaluateScriptInIsolatedWorld):
2699         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2700         (LayoutTestController::evaluateScriptInIsolatedWorld):
2701         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2702         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld):
2703
2704 2012-03-29  Ilya Tikhonovsky  <loislo@chromium.org>
2705
2706         Web Inspector: chromium: DRT --no-timeout option doesn't work.
2707         https://bugs.webkit.org/show_bug.cgi?id=82608
2708
2709         Initial value for m_timeout was initialized in constructor and was overwritten in DRT::main.
2710         This was broken by r112354 and the sequence became opposite.
2711
2712         Reviewed by Yury Semikhatsky.
2713
2714         * DumpRenderTree/chromium/TestShell.cpp:
2715         (TestShell::TestShell):
2716         (TestShell::initialize):
2717
2718 2012-03-29  Vineet Chaudhary  <rgf748@motorola.com>
2719
2720         Remove custom bindings form Internals.idl of attribute type Array.
2721         https://bugs.webkit.org/show_bug.cgi?id=82319
2722
2723         Reviewed by Kentaro Hara.
2724
2725         Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp as no longer required.
2726
2727         * GNUmakefile.am:
2728
2729 2012-03-28  Mark Rowe  <mrowe@apple.com>
2730
2731         Fix --no-saved-state.
2732
2733         Ignore the flag before Lion, rather than making it specific to Lion.
2734
2735         Rubber-stamped by Dan Bernstein.
2736
2737         * Scripts/webkitdirs.pm:
2738         (argumentsForRunAndDebugMacWebKitApp):
2739
2740 2012-03-28  Dave Tharp  <dtharp@codeaurora.org>
2741
2742         Add dtharp to contributors list
2743         https://bugs.webkit.org/show_bug.cgi?id=82545
2744
2745         Reviewed by Adam Barth.
2746
2747         Adding dtharp as Contributor.
2748
2749         * Scripts/webkitpy/common/config/committers.py:
2750
2751 2012-03-28  Stuart Eichert  <stuart.eichert@palm.com>
2752
2753         build-webkit : the word "pass" is spelled incorrectly as "passs"
2754         https://bugs.webkit.org/show_bug.cgi?id=82532
2755
2756         Reviewed by Julien Chaffraix.
2757
2758         Corrected spelling of the word "pass" in build-webkit.
2759
2760         * Scripts/build-webkit:
2761
2762 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
2763
2764         new-run-webkit-tests doesn't log correctly after retrying failures
2765         https://bugs.webkit.org/show_bug.cgi?id=82541
2766
2767         Unreviewed, build fix.
2768
2769         r112189 introduced a regression where we would accidentally
2770         delete the log handler after we retried any failing tests - that
2771         meant that any log messages around uploading the results got
2772         dropped.
2773
2774         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2775         (Manager._run_tests):
2776
2777 2012-03-28  Kevin Ollivier  <kevino@theolliviers.com>
2778
2779         [wx] Unreviewed. Build fix, move WTF back into JSCore target
2780         until issues with JSCore not linking in all WTF symbols are resolved.
2781
2782         * waf/build/settings.py:
2783
2784 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
2785
2786         download-built-product build step should detect 404 errors
2787         https://bugs.webkit.org/show_bug.cgi?id=82491
2788
2789         Reviewed by Ryosuke Niwa.
2790         
2791         Pass --fail to curl so that it reports 404 errors.
2792
2793         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2794         (DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
2795         * BuildSlaveSupport/built-product-archive:
2796         (extractBuiltProduct): Remove trailing whitespace.
2797
2798 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
2799
2800         flakiness dashboard should only keep the last 500 runs
2801         https://bugs.webkit.org/show_bug.cgi?id=82530
2802
2803         Reviewed by Ojan Vafai.
2804
2805         If a bot has an overly large amount of failing tests, then
2806         storing 750 runs' worth takes a lot of memory and CPU time to
2807         process and we end up getting killed by AppEngine; this cases
2808         data corruption and confusion down the road when we have to
2809         retry the upload of the data and the tests show up as multiple
2810         runs.
2811
2812         * TestResultServer/model/jsonresults.py:
2813         (JsonResults.update_file):
2814
2815 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
2816
2817         extract-built-product build step should fail if unzipping fails
2818         https://bugs.webkit.org/show_bug.cgi?id=82493
2819
2820         Reviewed by Simon Fraser.
2821
2822         Forward non-zero exit code from subprocesses so that the master can detect any failures
2823         and bail out early.
2824
2825         * BuildSlaveSupport/built-product-archive:
2826         (main):
2827
2828 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
2829
2830         test-webkitpy should support files, directories, and packages as command line args
2831         https://bugs.webkit.org/show_bug.cgi?id=76765
2832
2833         Reviewed by Adam Barth.
2834
2835         This patch adds support for specifying files, directories, and
2836         packages to test-webkitpy along with the already existing
2837         support for modules, test classes, and individual test names.
2838
2839         Also, fix a bug in filesystem_mock where we wouldn't normalize a
2840         path containing a reference to the current directory properly,
2841         for example, '/foo/./bar.py'.
2842
2843         * Scripts/webkitpy/common/system/filesystem_mock.py:
2844         (MockFileSystem.normpath):
2845         * Scripts/webkitpy/test/main.py:
2846         (Tester._configure_logging):
2847         (Tester._run_tests):
2848         * Scripts/webkitpy/test/test_finder.py:
2849         (TestDirectoryTree.find_modules):
2850         (TestDirectoryTree.subpath):
2851         (TestFinder.is_dotted_name):
2852         (TestFinder.find_names):
2853         (TestFinder):
2854         (TestFinder._find_names_for_arg):
2855         (TestFinder._find_in_trees):
2856         (TestFinder._default_names):
2857         * Scripts/webkitpy/test/test_finder_unittest.py:
2858         (TestFinderTest.setUp):
2859         (TestFinderTest.tearDown):
2860         (TestFinderTest.check_names):
2861         (TestFinderTest.test_default_names):
2862         (TestFinderTest):
2863         (TestFinderTest.test_paths):
2864
2865 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
2866
2867         Fix inspector tests when running in internal builds.
2868
2869         <rdar://problem/11050694>
2870
2871         Reviewed by Tim Hatcher.
2872
2873         * DumpRenderTree/mac/DumpRenderTree.mm:
2874         (resetDefaultsToConsistentValues):
2875         * WebKitTestRunner/TestController.cpp:
2876         (WTR::TestController::resetStateToConsistentValues):
2877
2878 2012-03-28  David Kilzer  <ddkilzer@apple.com>
2879
2880         Use xcrun to find nm and ranlib on OS X builds
2881         <http://webkit.org/b/82466>
2882
2883         Reviewed by Dan Bernstein.
2884
2885         * Scripts/build-webkit: Use xcrun to find ranlib.
2886         * Scripts/webkitdirs.pm:
2887         (determineNmPath): Added.  Use xcrun to find nm on OS X.
2888         (nmPath): Added.
2889         * Scripts/webkitperl/features.pm:
2890         (libraryContainsSymbol): Use nmPath().
2891
2892 2012-03-28  Ojan Vafai  <ojan@chromium.org>
2893
2894         Add history navigation to garden-o-matic
2895         https://bugs.webkit.org/show_bug.cgi?id=82495
2896
2897         Reviewed by Dimitri Glazkov.
2898
2899         Also, maintain scroll offsets when returning to a tab. This makes addressing
2900         expected failures considerably easier when dealing with below-the-fold tests.
2901
2902         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2903         -Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
2904         switching.
2905         -Modify window.location with the tabName in the hash. Can't use pushState because this is served
2906         from a file URL and Chrome puts each different file URL in it's own origin.
2907
2908         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2909         Remove the href so that clicking on the accordion item does not modify window.location.hash.
2910
2911         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2912         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2913
2914 2012-03-28  Philippe Normand  <pnormand@igalia.com>
2915
2916         [GTK] generate-gtk-doc doesn't cope with custom build directory
2917         https://bugs.webkit.org/show_bug.cgi?id=82448
2918
2919         Reviewed by Martin Robinson.
2920
2921         Pass the product directory in generate-gtkdoc arguments from
2922         build-webkit.
2923
2924         * Scripts/webkitdirs.pm:
2925         (buildAutotoolsProject):
2926         * gtk/common.py:
2927         (get_build_path):
2928
2929 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2930
2931         [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
2932         https://bugs.webkit.org/show_bug.cgi?id=82341
2933
2934         Reviewed by Martin Robinson.
2935
2936         Add --skipped=skip|ignore|only command line option.
2937
2938         * Scripts/run-gtk-tests:
2939         (TestRunner._test_cases_to_skip): Return the list of test cases
2940         to skip for the given test depending on the skipped action.
2941         (TestRunner._should_run_test): Decide whether to run the test or
2942         not depending on the skipped action.
2943         (TestRunner.run_tests): Only show the list of skipped tests when
2944         skipped action is 'skip'.
2945
2946 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2947
2948         [GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
2949         https://bugs.webkit.org/show_bug.cgi?id=82333
2950
2951         Reviewed by Martin Robinson.
2952
2953         * Scripts/run-gtk-tests:
2954         (TestRunner.SkippedTest): Add SkippedTest class to store more
2955         information about skipped tests.
2956         (TestRunner._setup_testing_environment): Use SkippedTest to add
2957         TestWebKitAccessibility to the skipped list.
2958         (TestRunner._find_skipped_test): Return the SkippedTest object for
2959         a given test path.
2960         (TestRunner._test_cases_to_skip): Returns the list of test cases
2961         that should be skipped for a given test path.
2962         (TestRunner._should_run_test): Helper funtion to decide whether
2963         the given test path should be run or not. Tests in the skipped
2964         list that don't have a list of failing test cases are not run at
2965         all. Tests in the skipped list that contain a list of test cases
2966         are run with gtester -s to skip the individual test cases.
2967         (TestRunner._run_test): Helper funtion to run a given test.
2968         (TestRunner.run_tests): Build the list of tests to run based on
2969         _should_run_test() and use helper function _run_test() to run
2970         every test.
2971
2972 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
2973
2974         [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
2975         https://bugs.webkit.org/show_bug.cgi?id=52810
2976
2977         Reviewed by Simon Hausmann.
2978
2979         Use SSE2 floating point math on 32 bit instead of the default
2980         387 to make layout test result same on 32 and on 64 bit builds.
2981
2982         * qmake/mkspecs/features/unix/default_post.prf:
2983
2984 2012-03-28  Sergio Villar Senin  <svillar@igalia.com>
2985
2986         [Soup] DNS prefetching spams resolver, shoots self in the foot
2987         https://bugs.webkit.org/show_bug.cgi?id=41630
2988
2989         Reviewed by Martin Robinson.
2990
2991         Bump libsoup and glib dependencies.
2992
2993         * efl/jhbuild.modules:
2994         * gtk/jhbuild.modules:
2995
2996 2012-03-28  Gustavo Noronha Silva  <gns@gnome.org>
2997
2998         [GTK] Disable introspection for jhbuild modules
2999         https://bugs.webkit.org/show_bug.cgi?id=82395
3000
3001         Reviewed by Philippe Normand.
3002
3003         * efl/jhbuild.modules: add --disable-introspection to all modules
3004         that support it
3005         * gtk/jhbuild.modules: ditto.
3006
3007 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3008
3009         [Qt] Unreviewed, fix API tests after adding full platforms. (r111658)
3010
3011         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3012         (BuildAndTestFactory.__init__):
3013
3014 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3015
3016         [Qt] Unreviewed typo fix after r112383.
3017
3018         * Scripts/run-qtwebkit-tests:
3019         (Main.check_crash_occurences):
3020
3021 2012-03-28  Ádám Kallai  <kadam@inf.u-szeged.hu>
3022
3023         [Qt] run-qtwebkit-tests should report crashes
3024         https://bugs.webkit.org/show_bug.cgi?id=76905
3025
3026         Added checking of crashing tests. Now final summary includes the total number of crashing tests too.
3027         Made unit test for this modification by János Badics <jbadics@inf.u-szeged.hu>.
3028
3029         Reviewed by Csaba Osztrogonác.
3030
3031         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3032         (RunQtAPITests.commandComplete):
3033         (RunQtAPITests.evaluateCommand):
3034         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3035         (RunQtAPITestsTest):
3036         (test_failure):
3037         (test_crash):
3038         * Scripts/run-qtwebkit-tests:
3039         (Main.announce_results_html):
3040         (Main):
3041         (Main.check_crash_occurences):
3042         (Main.convert_to_stdout):
3043         (Main.convert_to_html):
3044
3045 2012-03-28  Kwonjin Jeong  <gram@company100.net>
3046
3047         Add support for Intel compiler on Linux QT port.
3048         https://bugs.webkit.org/show_bug.cgi?id=81077
3049
3050         Reviewed by Tor Arne Vestbø.
3051
3052         * qmake/mkspecs/features/default_post.prf:
3053         Don't hide symbols when building with Intel compiler.
3054         The symbols are needed when building QtWebKit tests.
3055
3056         * qmake/mkspecs/features/unix/icc.prf:
3057         Added to ignore icc-specific warnings.
3058         This feature is used with command-line arguments for build-webkit script.
3059
3060 2012-03-28  Philippe Normand  <pnormand@igalia.com>
3061
3062         Unreviewed, trivial update-webkit-libs-jhbuild system call fix.
3063
3064         * Scripts/update-webkitgtk-libs: This script is written in
3065         Perl. Not Python. So use perl vocabulary to refer to command line arguments.
3066
3067 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
3068
3069         kill-old-processes doesn't do anything on linux
3070         https://bugs.webkit.org/show_bug.cgi?id=82388
3071
3072         Reviewed by Tony Chang.
3073
3074         Kill cc1plus, ld, etc... on linux. Also ps aux + grep to kill old run-webkit-tests processes.
3075         This should help stabilizing Chromium linux bots.
3076
3077         * BuildSlaveSupport/kill-old-processes:
3078
3079 2012-03-28  Philippe Normand  <pnormand@igalia.com>
3080
3081         [GTK] jhbuild wrongly tricked into clean-up
3082         https://bugs.webkit.org/show_bug.cgi?id=82216
3083
3084         Reviewed by Gustavo Noronha Silva.
3085
3086         Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
3087         build tree. Also when checking if the jhbuild configuration
3088         changed use absolute md5sum paths.
3089
3090         * Scripts/webkitdirs.pm:
3091         (runAutogenForAutotoolsProjectIfNecessary):
3092         (jhbuildConfigurationChanged):
3093         (buildAutotoolsProject):
3094
3095 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3096
3097         kill-old-processes doesn't do anything on linux
3098         https://bugs.webkit.org/show_bug.cgi?id=82388
3099
3100         One more attempt to disable kill-old-processes on the Qt bots not to kill each others.
3101
3102         The platform in Factory comes from config.json, accordingly platform is fullplatform,
3103         for example: qt-4.8, qt-5.0-wk2. We have to check only the prefix of platform.
3104
3105         Reviewed by Ryosuke Niwa.
3106
3107         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3108         (Factory.__init__):
3109
3110 2012-03-28  Hao Zheng  <zhenghao@chromium.org>
3111
3112         Make Chromium port for Android use hardware gpu path default.
3113         https://bugs.webkit.org/show_bug.cgi?id=82033
3114
3115         Reviewed by Dirk Pranke.
3116
3117         Skip canvas tests, which are run in virtual gpu test suites.
3118
3119         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3120         (ChromiumAndroidPort.__init__):
3121         (ChromiumAndroidPort.skipped_tests):
3122
3123 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3124
3125         kill-old-processes doesn't do anything on linux
3126         https://bugs.webkit.org/show_bug.cgi?id=82388
3127
3128         Disable kill-old-processes on the Qt bots not to kill each others.
3129
3130         Reviewed by Ryosuke Niwa.
3131
3132         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3133         (Factory.__init__):
3134
3135 2012-03-27  Hao Zheng  <zhenghao@chromium.org>
3136
3137         Handle DRT crash caused by Android OOM.
3138         https://bugs.webkit.org/show_bug.cgi?id=82310
3139
3140         Reviewed by Tony Chang.
3141
3142         When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
3143         is stopped silently and regarded as crashed. Re-run the test for
3144         such crash.
3145
3146         Add some debug log to NRWT.
3147
3148         * Scripts/webkitpy/layout_tests/port/chromium.py:
3149         (ChromiumDriver.run_test):
3150         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3151         (ChromiumAndroidPort.__init__):
3152         (ChromiumAndroidPort.get_last_stacktrace):
3153         (ChromiumAndroidDriver.__init__):
3154         (ChromiumAndroidDriver._start):
3155         (ChromiumAndroidDriver.run_test):
3156         (ChromiumAndroidDriver._get_drt_return_value):
3157
3158 2012-03-27  Ojan Vafai  <ojan@chromium.org>
3159
3160         Fix expected results for some unittest failures.
3161
3162         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3163
3164 2012-03-27  Adrienne Walker  <enne@google.com>
3165
3166         [chromium] Fix --enabled-threaded-compositing flag in DRT
3167         https://bugs.webkit.org/show_bug.cgi?id=82405
3168
3169         Reviewed by James Robinson.
3170
3171         --enable-threaded-compositing wasn't working because there was no way
3172         to set the value before it was used in the TestShell constructor.
3173
3174         To avoid adding yet another boolean parameter to TestShell's
3175         constructor, add an explicit initialize function that can operate on
3176         any boolean settings that are set post-constructor.
3177
3178         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3179         (main):
3180         * DumpRenderTree/chromium/TestShell.cpp:
3181         (TestShell::TestShell):
3182         (TestShell::initialize):
3183         * DumpRenderTree/chromium/TestShell.h:
3184         (TestShell):
3185         (TestShell::setTestShellMode):
3186
3187 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
3188
3189         new-run-webkit-tests: suppress debug output from run-safari on results file
3190         https://bugs.webkit.org/show_bug.cgi?id=82400
3191
3192         Reviewed by Ryosuke Niwa.
3193
3194         Send the run-safari output to /dev/null rather than the console.
3195
3196         * Scripts/webkitpy/layout_tests/port/mac.py:
3197         (MacPort.show_results_html_file):
3198
3199 2012-03-27  Simon Fraser  <simon.fraser@apple.com>
3200
3201         Improve error reporting in run-javascriptcore-tests
3202         https://bugs.webkit.org/show_bug.cgi?id=82379
3203
3204         Reviewed by Jessie Berlin.
3205         
3206         When the script dies, have it print out the reason for dying.
3207
3208         * Scripts/run-javascriptcore-tests:
3209
3210 2012-03-27  Eric Seidel  <eric@webkit.org>
3211
3212         Add Dave Barton to the Contributors list so I can more easily CC him on bugs
3213         https://bugs.webkit.org/show_bug.cgi?id=82373
3214
3215         Reviewed by Ryosuke Niwa.
3216
3217         Dave's committer-status in in-progress, so until then
3218         list him as a Contributor so at least I can more easily CC him on bugs.
3219
3220         * Scripts/webkitpy/common/config/committers.py:
3221
3222 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3223
3224         [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
3225         https://bugs.webkit.org/show_bug.cgi?id=82252
3226
3227         Reviewed by Gustavo Noronha Silva.
3228
3229         Appending the directory containing common.py may be problematic if
3230         another path in sys.path also contains either a common.py or a
3231         common/ module, so prepend to select our version instead. This is
3232         the case with fail2ban, which has a common/ directory which may
3233         end up being in Python's default path.
3234
3235         * efl/jhbuildrc:
3236         * gtk/jhbuildrc:
3237
3238 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
3239
3240         test-webkitpy: prepare for better test run output
3241         https://bugs.webkit.org/show_bug.cgi?id=82290
3242
3243         Reviewed by Adam Barth.
3244
3245         This code basically re-implements the output of the TextTestRunner default
3246         runner code from unittest, although the implementation is quite
3247         different, in preparation for changing the test output to be
3248         metered and possibly running in parallel.
3249
3250         The output is almost identical to before, except that instead of
3251         logging "test_regular (webkitpy.main.RunnerTest) passed" we log
3252         "webkitpy.main.RunnerTest.test_regular passed". It has always
3253         annoyed me that they invert the names to be harder to read and
3254         so that you can't copy & paste back to the input for
3255         test-webkitpy.
3256
3257         This patch is provided to add a skeleton for unit tests and for
3258         comparison to an upcoming patch that will actually add new
3259         functionality.
3260
3261         * Scripts/webkitpy/test/main.py:
3262         (Tester.__init__):
3263         (Tester._configure_logging):
3264         (Tester._run_tests):
3265         * Scripts/webkitpy/test/runner.py: Added.
3266         (TestRunner):
3267         (TestRunner.__init__):
3268         (TestRunner.test_name):
3269         (TestRunner.all_test_names):
3270         (TestRunner.run):
3271         (TestRunner.write_result):
3272         (TestRunner.write_summary):
3273         * Scripts/webkitpy/test/runner_unittest.py: Added.
3274         (FakeModuleSuite):
3275         (FakeModuleSuite.__init__):
3276         (FakeModuleSuite.__str__):
3277         (FakeModuleSuite.run):
3278         (FakeTopSuite):
3279         (FakeTopSuite.__init__):
3280         (FakeLoader):
3281         (FakeLoader.__init__):
3282         (FakeLoader.top_suite):
3283         (FakeLoader.loadTestsFromName):
3284         (RunnerTest):
3285         (RunnerTest.test_regular):
3286         (RunnerTest.test_verbose):
3287
3288 2012-03-27  Gustavo Noronha Silva  <gns@gnome.org>
3289
3290         [GTK] Build gnutls without p11-kit support
3291         https://bugs.webkit.org/show_bug.cgi?id=82212
3292
3293         Reviewed by Martin Robinson.
3294
3295         * gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
3296         configure, to avoid requiring that dependency, which is not used
3297         by libsoup and WebKit anyway
3298
3299 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3300
3301         [Qt] Make debug build work on 32 bit
3302         https://bugs.webkit.org/show_bug.cgi?id=82331
3303
3304         Use --no-keep-memory option of ld not to cache the symbol tables of input files in
3305         memory to avoid memory exhaustion during the linking phase for x86-debug builds.
3306
3307         Reviewed by Tor Arne Vestbø.
3308
3309         * qmake/mkspecs/features/unix/default_post.prf:
3310         * qmake/mkspecs/features/unix/default_pre.prf:
3311
3312 2012-03-23  Balazs Ankes  <bank@inf.u-szeged.hu>
3313
3314         Add png checking to check-webkit-style
3315         https://bugs.webkit.org/show_bug.cgi?id=75824
3316
3317         Reviewed by NOBODY Tony Chang.
3318
3319         * Scripts/webkitpy/style/checker.py:
3320         (_all_categories):
3321         (FileType):
3322         (CheckerDispatcher._should_skip_file_path):
3323         (CheckerDispatcher._file_type):
3324         (CheckerDispatcher._create_checker):
3325         * Scripts/webkitpy/style/checker_unittest.py:
3326         (CheckerDispatcherDispatchTest.test_none_paths):
3327         * Scripts/webkitpy/style/checkers/png.py: Added.
3328         (PNGChecker):
3329         (PNGChecker.__init__):
3330         (PNGChecker.check):
3331         (PNGChecker._config_file_path):
3332         * Scripts/webkitpy/style/checkers/png_unittest.py: Added.
3333         (MockSCMDetector):
3334         (MockSCMDetector.__init__):
3335         (MockSCMDetector.display_name):
3336         (MockSCMDetector.propget):
3337         (PNGCheckerTest):
3338         (PNGCheckerTest.test_init):
3339         (PNGCheckerTest.test_init.mock_handle_style_error):
3340         (PNGCheckerTest.test_check):
3341         (PNGCheckerTest.test_check.mock_handle_style_error):
3342         * Scripts/webkitpy/style/patchreader.py:
3343         (PatchReader.check):
3344
3345 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3346
3347         Unreviewed. Skip GTK+ unit tests that fail in the bots
3348
3349         * Scripts/run-gtk-tests:
3350         (TestRunner): Add failing tests to the skipped list.
3351
3352 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3353
3354         Unreviewed. Unskip all GTK+ unit test.
3355
3356         Currently, skipped tests contains the list of unit tests that have
3357         failed in one or more bots. In this moment it's not possible to
3358         skip just the test cases that fail, so the complete unit test is
3359         skipped when a single test case fails. For that reason, we don't
3360         know which test cases are actually failing for every skipped
3361         test. We are planning to land a patch to allow skipping individual
3362         test cases, but first we need to know which test cases are
3363         currently failing in the bots to skip them. So, this patch simply
3364         unskips all unit tests in order to watch the bots and get the list
3365         of test cases failing. Failing tests will be skipped again as soon
3366         as we have the new list of failing test cases.
3367
3368         * Scripts/run-gtk-tests:
3369         (TestRunner): Reset the list of skipped tests.
3370
3371 2012-03-26  Scott Byer  <scottbyer@chromium.org>
3372
3373         Enable layout testing of the scroll animator.
3374         https://bugs.webkit.org/show_bug.cgi?id=81858
3375         Add a call to the InternalSettings that layout tests can use to
3376         turn on scroll animation. Enable animation updates for the
3377         Chromium platform DRT when scroll animation has been turned on in
3378         a test. This should be a no-op for all current layout tests.
3379
3380         Reviewed by James Robinson.
3381
3382         * DumpRenderTree/chromium/WebViewHost.cpp:
3383         (WebViewHost::serviceAnimation):
3384         (WebViewHost::scheduleAnimation):
3385         * DumpRenderTree/chromium/WebViewHost.h:
3386         (WebViewHost):
3387
3388 2012-03-26  Dinu Jacob  <dinu.jacob@nokia.com>
3389
3390         [Qt][WK2] Support multi-file upload
3391         https://bugs.webkit.org/show_bug.cgi?id=81589
3392
3393         Reviewed by Simon Hausmann.
3394
3395         Modified filePicker to support multi-file upload.
3396
3397         * MiniBrowser/qt/MiniBrowser.qrc:
3398         * MiniBrowser/qt/icons/checkbox_checked.png: Added.
3399         * MiniBrowser/qt/icons/checkbox_unchecked.png: Added.
3400         * MiniBrowser/qt/js/MultiSelect.js: Added.
3401         (values):
3402         (isSelected):
3403         (removeValue):
3404         * MiniBrowser/qt/qml/CheckBox.qml: Added.
3405         * MiniBrowser/qt/qml/FilePicker.qml:
3406
3407 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
3408
3409         Retry crashing tests serially at the end of NRWT on Apple Mac
3410         https://bugs.webkit.org/show_bug.cgi?id=82233
3411
3412         Reviewed by Dirk Pranke.
3413
3414         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3415         (Manager.run):
3416         * Scripts/webkitpy/layout_tests/port/base.py:
3417         (Port.should_retry_crashes):
3418         * Scripts/webkitpy/layout_tests/port/mac.py:
3419         (MacPort.should_retry_crashes):
3420
3421 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
3422
3423         NRWT should retry failures serially
3424         https://bugs.webkit.org/show_bug.cgi?id=82241
3425
3426         Reviewed by Dirk Pranke.
3427
3428         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3429         (Manager._run_tests): Add another parameter to specify the number of workers to use.
3430         (Manager.run): Run the failures serially.
3431
3432 2012-03-26  Adrienne Walker  <enne@google.com>
3433
3434         Allow expectations on directories in virtual test suites
3435         https://bugs.webkit.org/show_bug.cgi?id=82250
3436
3437         Reviewed by Dirk Pranke.
3438
3439         lookup_virtual_test_base was only returning valid results for files
3440         and not directories. Fix by falling back to the virtual test suite
3441         mapping if possible.
3442
3443         * Scripts/webkitpy/layout_tests/port/base.py:
3444         (Port.lookup_virtual_test_base):
3445         * Scripts/webkitpy/layout_tests/port/test.py:
3446         (TestPort.skipped_tests):
3447         (TestPort.virtual_test_suites):
3448
3449 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
3450
3451         Fix duplicated ChangeLog entry from r112171.
3452
3453         Unreviewed, build fix.
3454
3455 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
3456
3457         nrwt: remove --worker-model flag
3458         https://bugs.webkit.org/show_bug.cgi?id=82112
3459
3460         Reviewed by Adam Barth.
3461
3462         The --worker-model=inline flag is basically redundant with the
3463         --child-processes=1 flag (technically, you could one run child
3464         process, but this is only useful for testing); this patch
3465         removes this flag, which simplifies things and enables more
3466         cleanup down the road.
3467
3468         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3469         (Manager._run_tests):
3470         (Manager.print_config):
3471         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3472         (get):
3473         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3474         (make_broker):
3475         (FunctionTests.test_get__inline):
3476         (FunctionTests.test_get__processes):
3477         (_TestsMixin.setUp):
3478         (_TestsMixin.make_broker):
3479         (InlineBrokerTests.setUp):
3480         (MultiProcessBrokerTests.setUp):
3481         * Scripts/webkitpy/layout_tests/port/base.py:
3482         (Port.default_child_processes):
3483         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3484         (ChromiumAndroidPort.check_sys_deps):
3485         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3486         (ChromiumAndroidPortTest):
3487         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3488         (MockDRTPortTest.make_port):
3489         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3490         (PortTestCase):
3491         (PortTestCase.make_port):
3492         * Scripts/webkitpy/layout_tests/port/test.py:
3493         (TestPort.default_child_processes):
3494         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3495         (_set_up_derived_options):
3496         (parse_args):
3497         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3498         (parse_args):
3499         (MainTest.test_batch_size):
3500         (MainTest.test_child_processes_2):
3501         (MainTest.test_child_processes_min):
3502         (MainTest.test_exception_raised):
3503         (MainTest.test_keyboard_interrupt):
3504         (MainTest.test_exit_after_n_crashes):
3505         (MainTest.assert_run_order):
3506         (MainTest.test_run_order__inline):
3507         (MainTest.test_virtual):
3508
3509 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
3510
3511         test-webkitpy: split test-finding code into a different module
3512         https://bugs.webkit.org/show_bug.cgi?id=82253
3513
3514         Reviewed by Adam Barth.
3515
3516         Per suggestion from abarth, this change splits all the
3517         filesystem-crawling, test-finding code in test-webkitpy out into
3518         a separate module and switches to using a FileSystem object.
3519         This makes things much more testable, so we also add tests :).
3520
3521         We also add a realpath() method to the Filesystem object, since
3522         test-webkitpy needs that in order to be able to resolve symlinks
3523         properly to determine whether a file is under a particular tree
3524         or not.
3525
3526         * Scripts/webkitpy/common/system/filesystem.py:
3527         (FileSystem.realpath):
3528         * Scripts/webkitpy/common/system/filesystem_mock.py:
3529         (MockFileSystem.realpath):
3530         * Scripts/webkitpy/test/main.py:
3531         (Tester.__init__):
3532         (Tester.add_tree):
3533         (Tester.run):
3534         (Tester._run_tests):
3535         (Tester._log_exception):
3536         * Scripts/webkitpy/test/test_finder.py: Added.
3537         (TestDirectoryTree):
3538         (TestDirectoryTree.__init__):
3539         (TestDirectoryTree.find_modules):
3540         (TestDirectoryTree.find_modules.file_filter):
3541         (TestDirectoryTree.to_module):
3542         (TestDirectoryTree.clean):
3543         (TestFinder):
3544         (TestFinder.__init__):
3545         (TestFinder.add_tree):
3546         (TestFinder.additional_paths):
3547         (TestFinder.clean_trees):
3548         (TestFinder.is_module):
3549         (TestFinder.to_module):
3550         (TestFinder.find_names):
3551         (TestFinder._exclude):
3552         * Scripts/webkitpy/test/test_finder_unittest.py: Added.
3553         (TestFinderTest):
3554         (TestFinderTest.setUp):
3555         (TestFinderTest.tearDown):
3556         (TestFinderTest.test_additional_system_paths):
3557         (TestFinderTest.test_is_module):
3558         (TestFinderTest.test_to_module):
3559         (TestFinderTest.test_clean):
3560         (TestFinderTest.test_find_names):
3561
3562 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3563
3564         [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
3565         https://bugs.webkit.org/show_bug.cgi?id=82209
3566
3567         Reviewed by Martin Robinson.
3568
3569         Respecting the $MAKE environment variable when it is defined makes
3570         building jhbuild more portable, as some platforms may have GNU
3571         make as gmake, for example.
3572
3573         * jhbuild/jhbuild-wrapper:
3574         (install_jhbuild):
3575
3576 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
3577
3578         add a Tree abstraction to test-webkitpy to better encapsulate things
3579         https://bugs.webkit.org/show_bug.cgi?id=82158
3580
3581         Reviewed by Adam Barth.
3582
3583         There are no functional changes in this patch, but adding a
3584         basic abstraction for the trees we are looking in for python
3585         tests will allow me to add some features later on more easily
3586         (like ignoring certain directories like webkitpy/thirdparty),
3587         and it makes things slightly less hard-coded.
3588
3589         * Scripts/test-webkitpy:
3590         * Scripts/webkitpy/test/main.py:
3591         (Tester.__init__):
3592         (Tester):
3593         (Tester.add_tree):
3594         (Tester._parse_args):
3595         (Tester._configure):
3596         (Tester.run):
3597         (Tester._find_modules):
3598         (Tester._run_tests):
3599         (Tester._is_module):
3600         (Tester._log_exception):
3601         (TestDirectoryTree):
3602         (TestDirectoryTree.__init__):
3603         (TestDirectoryTree.find_modules):
3604         (TestDirectoryTree.clean):
3605
3606 2012-03-26  Ojan Vafai  <ojan@chromium.org>
3607
3608         garden-o-matic should special case reftests
3609         https://bugs.webkit.org/show_bug.cgi?id=81812
3610
3611         Reviewed by Adam Barth.
3612
3613         On the examine page, don't show a rebaseline button for reftests.
3614         We still show it on the failure summary page because tests are grouped
3615         together. Long-term, we should make sure webkit-patch rebaseline-test
3616         never tries to rebaseline reftests.
3617
3618         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3621
3622 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
3623
3624         clean up NRWT logging/metering, be less verbose
3625         https://bugs.webkit.org/show_bug.cgi?id=73846
3626
3627         Reviewed by Ojan Vafai.
3628
3629         Re-land r112014 with a build fix for Python 2.6 compatibility.
3630
3631         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3632         (ManagerTest.test_http_locking):
3633         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3634         (AbstractWorker.run):
3635         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3636         (Worker.__init__):
3637         (Worker._set_up_logging):
3638         (Worker):
3639         (Worker._set_up_host_and_port):
3640         (Worker.run):
3641         (Worker.cleanup):
3642         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
3643         (WorkerTest.test_default_platform_in_worker):
3644         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3645         (run):
3646         (main):
3647         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3648         (MeteredStream):
3649         (MeteredStream.implements):
3650         (MeteredStream._erasure):
3651         (MeteredStream._ensure_newline):
3652         (MeteredStream.__init__):
3653         (MeteredStream.__del__):
3654         (MeteredStream.cleanup):
3655         (MeteredStream.write_throttled_update):
3656         (MeteredStream.write_update):
3657         (MeteredStream.write):
3658         (MeteredStream.writeln):
3659         (MeteredStream._erase_last_partial_line):
3660         (_LogHandler):
3661         (_LogHandler.__init__):
3662         (_LogHandler.emit):
3663         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3664         (RegularTest):
3665         (RegularTest.setUp):
3666         (RegularTest.tearDown):
3667         (RegularTest.time_fn):
3668         (RegularTest.test_logging_not_included):
3669         (RegularTest._basic):
3670         (RegularTest.test_basic):
3671         (RegularTest._log_after_update):
3672         (RegularTest.test_log_after_update):
3673         (TtyTest):
3674         (TtyTest.test_basic):
3675         (TtyTest.test_log_after_update):
3676         (VerboseTest):
3677         (VerboseTest.test_basic):
3678         (VerboseTest.test_log_after_update):
3679         * Scripts/webkitpy/layout_tests/views/printing.py:
3680         (parse_print_options):
3681         (Printer.__init__):
3682         (Printer.cleanup):
3683         (Printer.print_progress):
3684         (Printer.print_update):
3685         (Printer._write):
3686         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3687         (Testprinter.get_printer):
3688         (Testprinter.test_print_progress):
3689         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3690         (PerfTestsRunner.__init__):
3691         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3692         (test_run_test_pause_before_testing):
3693
3694 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3695
3696         [jhbuild] Revert $MAKE environment hack introduced in r101929.
3697         https://bugs.webkit.org/show_bug.cgi?id=82234
3698
3699         Reviewed by Martin Robinson.
3700
3701         The problem it was supposedly fixing was fixed in jhbuild itself
3702         in git revision da8944d8ca987ca48c91b350257a530050406092, so we
3703         can remove the workaround added to the script.
3704
3705         * jhbuild/jhbuild-wrapper:
3706         (install_jhbuild):
3707
3708 2012-03-26  Leo Yang  <leo.yang@torchmobile.com.cn>
3709
3710         [BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
3711         https://bugs.webkit.org/show_bug.cgi?id=82157
3712
3713         Reviewed by Rob Buis.
3714
3715         * Scripts/build-webkit:
3716         Make ENABLE_FILE_SYSTEM default on for blackberry.
3717
3718 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3719
3720         [jhbuild] Explicitly disable DTrace when building glib.
3721         https://bugs.webkit.org/show_bug.cgi?id=82145
3722
3723         Reviewed by Gustavo Noronha Silva.
3724
3725         DTrace support is not really needed by WebKit, so disabling it
3726         helps avoid some build errors on more exotic platforms (such as
3727         FreeBSD).
3728
3729         * efl/jhbuild.modules:
3730         * gtk/jhbuild.modules:
3731
3732 2012-03-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3733
3734         Unreviewed, rolling out r111993.
3735         http://trac.webkit.org/changeset/111993
3736         https://bugs.webkit.org/show_bug.cgi?id=82184
3737
3738         It broke layout and API tests and made WTR crash (Requested by
3739         Ossy on #webkit).
3740
3741         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3742         (WTR::PlatformWebView::PlatformWebView):
3743
3744 2012-03-25  Kevin Ollivier  <kevino@theolliviers.com>
3745
3746         [wx] Unreviewed build fix. Move WTF to its own static lib build.
3747
3748         * waf/build/settings.py:
3749         (common_configure):
3750
3751 2012-03-24  Chris Fleizach  <cfleizach@apple.com>
3752
3753         AX: Support solution to handle invalid ax text marker
3754         https://bugs.webkit.org/show_bug.cgi?id=82023
3755
3756         Reviewed by Oliver Hunt.
3757
3758         * DumpRenderTree/AccessibilityUIElement.cpp:
3759         (indexForTextMarkerCallback):
3760         (isTextMarkerValidCallback):
3761         (textMarkerForIndexCallback):
3762         (AccessibilityUIElement::indexForTextMarker):
3763         (AccessibilityUIElement::isTextMarkerValid):
3764         (AccessibilityUIElement::textMarkerForIndex):
3765         (AccessibilityUIElement::getJSClass):
3766         * DumpRenderTree/AccessibilityUIElement.h:
3767         (AccessibilityUIElement):
3768         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3769         (AccessibilityUIElement::indexForTextMarker):
3770         (AccessibilityUIElement::textMarkerForIndex):
3771         (AccessibilityUIElement::isTextMarkerValid):
3772         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3773         (WTR::AccessibilityUIElement::indexForTextMarker):
3774         (WTR::AccessibilityUIElement::isTextMarkerValid):
3775         (WTR::AccessibilityUIElement::textMarkerForIndex):
3776         (WTR):
3777         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3778         (AccessibilityUIElement):
3779         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3780         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3781         (WTR):
3782         (WTR::AccessibilityUIElement::indexForTextMarker):
3783         (WTR::AccessibilityUIElement::isTextMarkerValid):
3784         (WTR::AccessibilityUIElement::textMarkerForIndex):
3785
3786 2012-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3787
3788         Unreviewed, rolling out r112014.
3789         http://trac.webkit.org/changeset/112014
3790         https://bugs.webkit.org/show_bug.cgi?id=82138
3791
3792         Broke SnowLeopard, Chromium and GTK+ bots (Requested by kov on
3793         #webkit).
3794
3795         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3796         (ManagerTest.test_http_locking):
3797         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3798         (AbstractWorker.run):
3799         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3800         (Worker.__init__):
3801         (Worker.safe_init):
3802         (Worker.run):
3803         (Worker.cleanup):
3804         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
3805         (WorkerTest.test_default_platform_in_worker):
3806         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3807         (run):
3808         (main):
3809         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3810         (MeteredStream):
3811         (MeteredStream.is):
3812         (MeteredStream.__init__):
3813         (MeteredStream.write):
3814         (MeteredStream.update):
3815         (MeteredStream._overwrite):
3816         (MeteredStream._reset):
3817         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3818         (TestMeteredStream):
3819         (TestMeteredStream.test_regular):
3820         * Scripts/webkitpy/layout_tests/views/printing.py:
3821         (_configure_logging):
3822         (_restore_logging):
3823         (Printer.__init__):
3824         (Printer.cleanup):
3825         (Printer.print_progress):
3826         (Printer.print_update):
3827         (Printer._write):
3828         (Printer):
3829         (Printer._update):
3830         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3831         (TestUtilityFunctions.assertEmpty):
3832         (TestUtilityFunctions):
3833         (TestUtilityFunctions.assertNotEmpty):
3834         (TestUtilityFunctions.assertWritten):
3835         (TestUtilityFunctions.test_configure_logging):
3836         (Testprinter.get_printer):
3837         (Testprinter.test_print_progress):
3838         (Testprinter.test_print_progress.mock_time):
3839         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3840         (PerfTestsRunner.__init__):
3841         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3842         (test_run_test_pause_before_testing):
3843
3844 2012-03-24  Kevin Ollivier  <kevino@theolliviers.com>
3845
3846         [wx] Unreviewed. Fix the build after WTF move.
3847
3848         * waf/build/build_utils.py:
3849         (get_excludes):
3850         (get_excludes_in_dirs):
3851         * waf/build/settings.py:
3852         (get_port_excludes):
3853         (common_configure):
3854
3855 2012-03-24  Dirk Pranke  <dpranke@chromium.org>
3856
3857         clean up NRWT logging/metering, be less verbose
3858         https://bugs.webkit.org/show_bug.cgi?id=73846
3859
3860         Reviewed by Ojan Vafai.
3861
3862         This patch totally rewrites the metered_stream module and
3863         changes the way it and the printing module now interact with the
3864         logging subsystem.
3865
3866         The printing module becomes a dumb layout_tests-specific wrapper around
3867         the metered stream. All of the intelligence of how and when to
3868         actually write (or erase) lines and how things interact with
3869         logging moves into the metered stream.
3870
3871         As of now, anything written to the metered stream *bypasses the
3872         logging system*. If a logger is passed to the meter constructor,
3873         the metered stream will also attach a log handler so that all
3874         messages fed to the logger will also be written to the metered
3875         stream. This detangles the logic that used to exist where
3876         sometimes the meter would write to the logger and sometimes the
3877         logger would write to the meter.
3878
3879         All of this makes the logic generic and reusable for
3880         test-webkitpy (coming in another patch). It also helps clarify
3881         what the mysterious "configure_logging" parameter to the printer
3882         constructor used to do (that parameter itself is gone now, and
3883         by default the printer and metered_stream will not ever touch
3884         the logging system; this makes a bunch of tests less fragile).
3885
3886         All of the above should produce no user-visible changes.
3887
3888         However, to also fix the bug in question, we change the message
3889         format in --verbose mode to %H:%M:%S.%frac %pid %message,
3890         eliminating the date, file:lineno, and level parameters. I am
3891         making this change at the same time because it would be
3892         difficult to write things consistently between the logs and the
3893         metered stream if we were still logging the file:lineno.
3894
3895         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3896           Remove the configure_logging parameter
3897         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3898           Use metered stream to configure the logging (we don't need a printer)
3899           and be careful about when and how we manipulate the log level
3900           and handlers on the root logger.
3901         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3902           Pass in the root logger so that log messages are formatted
3903           properly, and set the log level outside of any routines called
3904           by unit tests so as to not interfere.
3905         * Scripts/webkitpy/layout_tests/views/manager_worker_broker.py:
3906           remove a duplicate log message.
3907         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3908           complete rewrite :).
3909         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3910           complete rewrite :).
3911         * Scripts/webkitpy/layout_tests/views/printing.py:
3912           move the logging configuration into metered_stream, and also
3913           move the "when should I log progress messages" into metered stream.
3914         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3915           remove tests that are no longer necessary.
3916         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3917           remove the configure_logging parameter.
3918         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3919           update the test; since the printer no longer writes to the log,
3920           we need to check what is written to the regular_output instead.
3921           (test_run_test_pause_before_testing):
3922
3923 2012-03-24  Gustavo Noronha Silva  <gns@gnome.org>
3924
3925         Add myself and Martin Robinson to:
3926           * GStreamerGraphics
3927           * GtkWebKit2PublicAPI
3928           * SoupNetwork
3929         and to the newly created WebKitGTKTranslations.
3930
3931         Rubber-stamped by Martin Robinson.
3932
3933         * Scripts/webkitpy/common/config/watchlist:
3934
3935 2012-03-24  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3936
3937         [Qt][WK2] Implement PageClient::isViewWindowActive()
3938         https://bugs.webkit.org/show_bug.cgi?id=81143
3939
3940         Reviewed by Kenneth Rohde Christiansen.
3941
3942         Fix the WrapperWindow from our PlatformWebView
3943         so it correctly creates the platform related
3944         stuff for QWindow, which is not created unless
3945         QWindow::setVisible() or QWindow::show() are called.
3946
3947         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3948         (WTR::PlatformWebView::PlatformWebView):
3949
3950 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
3951
3952         nrwt: don't wait for safari to exit before exiting after showing the results file
3953         https://bugs.webkit.org/show_bug.cgi?id=81845
3954
3955         Reviewed by Ryosuke Niwa.
3956
3957         Prior to this change, if you ran new-run-webkit-tests and
3958         displayed the HTML results file at the end, we would block
3959         waiting for the user to quit the browser. There doesn't seem to
3960         be a need for that, and the Chromium ports don't do this.
3961
3962         Also, update the mac tests to capture the output and be quiet :).
3963
3964         * Scripts/webkitpy/common/system/executive_mock.py:
3965           Make popen() testable, implement should_log for it.
3966         * Scripts/webkitpy/layout_tests/port/mac.py:
3967         (MacPort.show_results_html_file):
3968         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3969           Silence some of the tests via outputcapture.
3970
3971 2012-03-23  Gustavo Noronha Silva  <gns@gnome.org>
3972
3973         [GTK] libgcrypt and p11-kit should not be in jhbuild modules
3974         https://bugs.webkit.org/show_bug.cgi?id=82073
3975
3976         Reviewed by Martin Robinson.
3977
3978         * Scripts/webkitdirs.pm:
3979         (jhbuildConfigurationChanged): new function that isolates the
3980         jhbuild configuration change checking from the autogen logic.
3981         (mustReRunAutogen): code for the new function lived here.
3982         (buildAutotoolsProject): now calls jhbuildConfigurationChanged
3983         itself, and cleans up the jhbuild root if configuration has
3984         changed; it also forces autogen to be run in that case, to
3985         make sure the new libraries are used.
3986         * gtk/jhbuild.modules: removed libgcrypt and p11-kit.
3987         * jhbuild/jhbuild-wrapper:
3988         (ensure_jhbuild): this might be run inside a jhbuild environment,
3989         in which case aclocal fails when trying to use the now deleted
3990         aclocal directory in the jhbuild prefix, so work around that.
3991
3992 2012-03-23  Ojan Vafai  <ojan@chromium.org>
3993
3994         garden-o-matic scrolls to the top of the page when you click an accordion item
3995         https://bugs.webkit.org/show_bug.cgi?id=82088
3996
3997         Reviewed by Adam Barth.
3998
3999         Check the scroll position and make sure that the clicked accordion item is visible.
4000
4001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
4002
4003 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
4004
4005         LayoutTestHelper could get torn down earlier (mostly to reset color profile)
4006         https://bugs.webkit.org/show_bug.cgi?id=80567
4007
4008         Reviewed by Ryosuke Niwa.
4009
4010         Move clean_up_run to occur right after we finish testing and
4011         before we start processing the results. Also makes set_up_run()
4012         and clean_up_run() private since there's no real need for
4013         callers to be aware of them.
4014
4015         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4016         (Manager._set_up_run):
4017         (Manager.run):
4018         (Manager._clean_up_run):
4019         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4020         (ManagerTest.test_http_locking):
4021         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4022         (run):
4023
4024 2012-03-23  Dean Jackson  <dino@apple.com>
4025
4026         Disable CSS_SHADERS in Apple builds
4027         https://bugs.webkit.org/show_bug.cgi?id=81996
4028
4029         Reviewed by Simon Fraser.
4030
4031         Default enableCSSShaders to be 0 on all builds that use
4032         this script. Use the flag to turn it back on.
4033
4034         * Scripts/build-webkit:
4035
4036 2012-03-23  Tony Chang  <tony@chromium.org>
4037
4038         [chromium] rename newwtf target back to wtf
4039         https://bugs.webkit.org/show_bug.cgi?id=82064
4040
4041         Reviewed by Adam Barth.
4042
4043         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4044
4045 2012-03-23  Jessie Berlin  <jberlin@apple.com>
4046
4047         Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on
4048         the Lion Intel WebKit2 Debug bots.
4049         https://bugs.webkit.org/show_bug.cgi?id=81012.
4050
4051         Rubber-stamped by Dan Bernstein.
4052
4053         Add a step to kill the pasteboard server while we investigate what is causing these
4054         assertion failures (to get the bots green).
4055
4056         * BuildSlaveSupport/kill-old-processes:
4057
4058 2012-03-22  Martin Robinson  <mrobinson@igalia.com>
4059
4060         [check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
4061         https://bugs.webkit.org/show_bug.cgi?id=81986
4062
4063         Reviewed by David Levin.
4064
4065         Track whether or not errors are filtered in error handlers. If an
4066         alphabetical sorting error is reported for a header and filtered, try
4067         reporting it for the other potential source of the error. This ensures
4068         that the style bot can still find new sorting errors in both potential
4069         situations:
4070
4071             #include <foo.h> <-- 1. edited line
4072             #include <baz.h> <-- 2. edited line
4073
4074         * Scripts/webkitpy/style/checkers/cpp.py:
4075         (check_include_line): Potentially report the error for both lines,
4076         if the first error is filtered.
4077         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of
4078         test that allows only reporting errors for certain lines. This verifies that
4079         when one line of an ordering error is filtered, the error is reported on the
4080         other line.
4081         (ErrorCollector.__init__):
4082         (ErrorCollector.__call__):
4083         (CppStyleTestBase.perform_lint):
4084         (CppStyleTestBase.perform_language_rules_check):
4085         (CppStyleTestBase.assert_language_rules_check):
4086         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
4087         Added a new test that verifies that when one line of the two lines of an ordering
4088         error occur, the error is reported on the other line.
4089         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
4090         (MockErrorHandler.__call__): Report True because the error is handled.
4091         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4092         (ErrorCollector.__call__): Ditto.
4093         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
4094         (MockErrorHandler.__call__): Ditto.
4095         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
4096         (TestErrorHandler.__call__): Ditto.
4097         * Scripts/webkitpy/style/checkers/xml_unittest.py:
4098         (MockErrorHandler.__call__): Ditto.
4099         * Scripts/webkitpy/style/error_handlers.py:
4100         (DefaultStyleErrorHandler.__call__): Report True if the error is handled
4101         and False if it is filtered.
4102
4103 2012-03-23  Patrick Gansterer  <paroga@webkit.org>
4104
4105         Build fix for WinCE after r111778.
4106
4107         * WinCELauncher/CMakeLists.txt:
4108
4109 2012-03-23  Peter Beverloo  <peter@chromium.org>
4110
4111         Unreviewed buildfix for the Chromium Android builder.
4112
4113         Disable the ImageDiff target for now. Android needs to build this for
4114         host rather than for target (as other configurations do), but since the
4115         WTF move the dependency chain got significantly more complicated.
4116
4117         I'll work out a proper fix in the following bug, but since several
4118         things are broken due to this, this buildfix should be landed first.
4119         https://bugs.webkit.org/show_bug.cgi?id=82039
4120
4121         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4122
4123 2012-03-23  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
4124
4125         [EFL][DRT] Implement LayoutTestController's methods related with editing.
4126         https://bugs.webkit.org/show_bug.cgi?id=80136
4127
4128         Reviewed by Ryosuke Niwa.
4129
4130         Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
4131         setSelectTrailingWhitespaceEnabled.
4132
4133         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4134         (LayoutTestController::setSmartInsertDeleteEnabled):
4135         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
4136
4137 2012-03-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4138
4139         Convert hasGrammarMarker to use Internals interface
4140         https://bugs.webkit.org/show_bug.cgi?id=82004
4141
4142         Reviewed by Ryosuke Niwa.
4143
4144         Remove hasGrammarMarker functions, because it is able to work in the
4145         cross-port way through the Internals interface.
4146
4147         * DumpRenderTree/LayoutTestController.cpp:
4148         (LayoutTestController::staticFunctions):
4149         * DumpRenderTree/LayoutTestController.h:
4150         (LayoutTestController):
4151         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
4152         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4153         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4154         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4155         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4156         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4157
4158 2012-03-22  Adam Barth  <abarth@webkit.org>
4159
4160         sync-master-with-upstream creates non-linear git history
4161         https://bugs.webkit.org/show_bug.cgi?id=82006
4162
4163         Reviewed by Julien Chaffraix.
4164
4165         Previously this script would create a merge commit at the HEAD of
4166         origin/master, causing your fork of WebKit to diverge from upstream.
4167         The new version of this script pushes directly from upstream to origin
4168         (without round-tripping through any local branches), avoiding this
4169         problem.
4170
4171         * Scripts/sync-master-with-upstream:
4172
4173 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
4174
4175         Unreviewed build fix. Add knowledge of the WTF project to
4176         the autotools build system scripts so that build-jsc works
4177         correctly for GTK+.
4178
4179         * Scripts/webkitdirs.pm:
4180         (buildAutotoolsProject): handle the WTF project, build the
4181         libWTF.la target.
4182         (buildGtkProject): add WTF to the list of supported projects.
4183
4184 2012-03-22  Eric Seidel  <eric@webkit.org>
4185
4186         Make svn-apply re-write JavaScriptCore/wtf to WTF/wtf
4187         https://bugs.webkit.org/show_bug.cgi?id=81984
4188
4189         Reviewed by Adam Barth.
4190
4191         * Scripts/VCSUtils.pm:
4192         (adjustPathForRecentRenamings):
4193
4194 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
4195
4196         [CMake] Fix build-jsc after r111778 and r111797.
4197         https://bugs.webkit.org/show_bug.cgi?id=82001
4198
4199         Reviewed by Filip Pizlo.
4200
4201         Contrary to the comment in build-jsc, buildCMakeProjectOrExit()
4202         does return if no error occurred, and build-jsc failed with
4203         "building not defined for this platform".
4204
4205         * Scripts/build-jsc: Always exit after caling
4206         buildCMakeProjectOrExit().
4207         * Scripts/webkitdirs.pm:
4208         (buildCMakeProjectOrExit): Return 0 if no error occurred.
4209
4210 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
4211
4212         [CMake] Unreviewed build fix after r111778.
4213
4214         * DumpRenderTree/efl/CMakeLists.txt: Replace
4215         ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include
4216         paths.
4217         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Use the right
4218         wtf include.
4219         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Ditto.
4220         * WinCELauncher/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf
4221         with ${WTF_DIR}/wtf in the include paths.
4222
4223 2012-03-22  Filip Pizlo  <fpizlo@apple.com>
4224
4225         Tools/Scripts/build-jsc doesn't work after WTF move
4226         https://bugs.webkit.org/show_bug.cgi?id=81999
4227
4228         Reviewed by Eric Seidel.
4229         
4230         For ports that require WTF and JSC to be built as two projects and where
4231         the machinery to build both does not already exist, teach the tool to do
4232         so for us.
4233
4234         * Scripts/build-jsc:
4235         (buildMyProject):
4236
4237 2012-03-22  Ojan Vafai  <ojan@chromium.org>
4238
4239         Fix accidental missing line in r111793.
4240
4241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
4242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
4243         Remove base.values. It was unused and duplicates the builtin Object.values.
4244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
4245         Accidentally deleted this line before committing r111793.
4246
4247 2012-03-22  Ojan Vafai  <ojan@chromium.org>
4248
4249         Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page
4250         https://bugs.webkit.org/show_bug.cgi?id=81983
4251
4252         Reviewed by Adam Barth.
4253
4254         The dialogs get in the way if you are doing multiple rebaselines. Also,
4255         a number of people didn't realize that you could do multiple rebaselines
4256         in parallel. A non-modal dialog is just confusing.
4257
4258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
4259         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
4260         If we're only rebaselining 1 test, show the test name in the initial message. Otherwise,
4261         show the number of tests being rebaselined.
4262
4263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
4264         Turn MessageBox into StatusArea. StatusArea is a singleton and messages in the StatusArea are grouped
4265         by ID. That way, the results of each UI action (e.g. clicking rebaseline) are grouped together
4266         into a single area.
4267
4268         Once addFinalMessage has been called for all IDs, we show the close button. Clicking close
4269         also serves to clear all teh content in the StatusArea. 
4270
4271         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
4272         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
4273
4274 2012-03-22  Tony Chang  <tony@chromium.org>
4275
4276         Unreviewed, fix chromium build after wtf move.
4277
4278         Only use newwtf, remove references to wtf.
4279
4280         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4281
4282 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
4283
4284         Actually move WTF files to their new home
4285         https://bugs.webkit.org/show_bug.cgi?id=81844
4286
4287         [Qt] Unreviewed buildfix after r111778.
4288
4289         * DumpRenderTree/qt/DumpRenderTree.pro:
4290
4291 2012-03-22  Dan Bernstein  <mitz@apple.com>
4292
4293         Font fallback in WebKitTestRunner depends on user settings
4294         https://bugs.webkit.org/show_bug.cgi?id=81978
4295
4296         Reviewed by Jessie Berlin.
4297
4298         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4299         (WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
4300         with a value consisting of the array ("en") to the override defaults
4301         dictionary. This is the same value used in DumpRenderTree, and it
4302         ensures that font fallback follows a consistent path that is not
4303         affected by the language preferences of the user running the test.
4304
4305 2012-03-22  Andy Estes  <aestes@apple.com>
4306
4307         check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
4308         https://bugs.webkit.org/show_bug.cgi?id=81971
4309
4310         Reviewed by Dan Bernstein.
4311
4312         Xcode will automatically link ObjC binaries against libarclite in some
4313         cases, which defines a class called __ARCLite__.
4314         check-for-inappropriate-objc-class-names shouldn't complain about this
4315         class name.
4316
4317         * Scripts/check-for-inappropriate-objc-class-names:
4318
4319 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
4320
4321         new-run-webkit-tests blames the wrong test for crashing
4322         https://bugs.webkit.org/show_bug.cgi?id=81951
4323
4324         Reviewed by Adam Barth.
4325
4326         NRWT wasn't extracting the WebProcess pid correct; should've
4327         used re.search instead of re.match :(. Add more tests!
4328
4329         * Scripts/webkitpy/layout_tests/port/mac.py:
4330         (MacPort._get_crash_log):
4331         * Scripts/webkitpy/layout_tests/port/webkit.py:
4332         (WebKitDriver.has_crashed):
4333         (WebKitDriver._check_for_driver_crash):
4334         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4335         (WebKitDriverTest.test_no_timeout):
4336         (WebKitDriverTest):
4337         (WebKitDriverTest.test_check_for_driver_crash):
4338         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
4339         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
4340         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
4341         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
4342         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
4343         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
4344
4345 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
4346
4347         [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
4348         https://bugs.webkit.org/show_bug.cgi?id=81512
4349
4350         Adding missing implementation markerTextForListItem to EFL's
4351         LayoutTestController so that we can unskip related tests from
4352         the skip list.
4353
4354         Reviewed by Antonio Gomes.
4355
4356         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4357         (LayoutTestController::markerTextForListItem): Implemented.
4358
4359 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
4360
4361         [EFL] Enable view mode media feature layout tests
4362         https://bugs.webkit.org/show_bug.cgi?id=81205
4363
4364         Adding missing implementation setViewModeMediaFeature to EFL's 
4365         LayoutTestController so that we can unskip view mode 
4366         media feature layout tests.
4367
4368         Reviewed by Antonio Gomes.
4369
4370         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4371         (LayoutTestController::setViewModeMediaFeature): Implemented.
4372
4373 2012-03-22  Dirk Pranke  <dpranke@chromium.org>