c4b853a6fcee4f05295a072ac60f44124293a54e
[WebKit-https.git] / Tools / ChangeLog
1 2015-11-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2
3         [ES6] Support Generator Syntax
4         https://bugs.webkit.org/show_bug.cgi?id=150769
5
6         Reviewed by Geoffrey Garen.
7
8         Added ENABLE_ES6_GENERATORS flag.
9
10         * Scripts/webkitperl/FeatureList.pm:
11
12 2015-11-01  Alexey Proskuryakov  <ap@apple.com>
13
14         Sort EWS bots in popovers
15         https://bugs.webkit.org/show_bug.cgi?id=150782
16
17         Reviewed by Darin Adler.
18
19         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
20         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
21
22 2015-10-31  Filip Pizlo  <fpizlo@apple.com>
23
24         B3::reduceStrength's DCE should be more agro and less wrong
25         https://bugs.webkit.org/show_bug.cgi?id=150748
26
27         Reviewed by Geoffrey Garen.
28
29         Add an LLVM version of testb3's "testComplex".
30
31         * ReducedFTL/ComplexTest.cpp: Added.
32
33 2015-11-01  Commit Queue  <commit-queue@webkit.org>
34
35         Unreviewed, rolling out r191831.
36         https://bugs.webkit.org/show_bug.cgi?id=150774
37
38         The new test fails (Requested by ap on #webkit).
39
40         Reverted changeset:
41
42         "Begin work on supporting reply blocks in
43         _WKRemoteObjectRegistry"
44         https://bugs.webkit.org/show_bug.cgi?id=150739
45         http://trac.webkit.org/changeset/191831
46
47 2015-10-31  Andreas Kling  <akling@apple.com>
48
49         Add a debug overlay with information about web process resource usage.
50         <https://webkit.org/b/150599>
51
52         Reviewed by Darin Adler.
53
54         Add a menu item to the MiniBrowser so we can toggle the resource usage overlay on/off.
55
56         * MiniBrowser/mac/SettingsController.h:
57         * MiniBrowser/mac/SettingsController.m:
58         (-[SettingsController _populateMenu]):
59         (-[SettingsController validateMenuItem:]):
60         (-[SettingsController toggleShowResourceUsageOverlay:]):
61         (-[SettingsController resourceUsageOverlayVisible]):
62         * MiniBrowser/mac/WK2BrowserWindowController.m:
63         (-[WK2BrowserWindowController didChangeSettings]):
64
65 2015-10-31  Lucas Forschler  <lforschler@apple.com>
66
67         Teach the CompileWebKit step to look for additional arguments.
68         
69         Unreviewed config change.
70
71         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
72         (CompileWebKit.start):
73
74 2015-10-30  Anders Carlsson  <andersca@apple.com>
75
76         Begin work on supporting reply blocks in _WKRemoteObjectRegistry
77         https://bugs.webkit.org/show_bug.cgi?id=150739
78
79         Reviewed by Tim Horton.
80
81         Add a test. We only test the encoding right now.
82
83         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
84         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
85         (TEST):
86         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
87         (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
88
89 2015-10-30  Lucas Forschler  <lforschler@apple.com>
90
91         Add CMAke builder to build.webkit.org
92         https://bugs.webkit.org/show_bug.cgi?id=150738
93         
94         Reviewed by Alex Christensen.
95
96         * BuildSlaveSupport/build.webkit.org-config/config.json:
97
98 2015-10-30  Brent Fulgham  <bfulgham@apple.com>
99
100         [Win] build-jsc and run-javascriptcore-tests do not work
101         https://bugs.webkit.org/show_bug.cgi?id=150700
102
103         Reviewed by Mark Lam.
104         
105         Correct our build system so that it expects Windows to be using CMake,
106         and to build the correct sub-projects for our JSC helper scripts.
107
108         * Scripts/build-jsc: Make sure to build the testapi harness when
109           building for Windows.
110         * Scripts/build-webkit:
111           (1) Use the existing 'cmakeBasedPortName()'
112           (2) Use File::Spec rather than hard-coding path delimeters.
113           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
114         method rather than hard-coding the name based on conditional.
115         * Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
116           LLVM libraries on Apple Windows build.
117         * Scripts/run-javascriptcore-tests:
118         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
119         * Scripts/run-jsc: Ditto.
120         * Scripts/webkitdirs.pm:
121         (cmakeBasedPortName): Update to return the right value for the Apple
122         Windows port and the WinCairo port.
123         (isCMakeBuild): Expect CMake build for all Windows ports.
124
125 2015-10-30  Carlos Garcia Campos  <cgarcia@igalia.com>
126
127         [JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
128         https://bugs.webkit.org/show_bug.cgi?id=150665
129
130         Reviewed by Csaba Osztrogonác.
131
132         We check it only to wipe the directory or not, but we are still
133         tryihng to update every module even when the configuration hasn't
134         changed. This is problematic because it makes the whole build fail
135         when any repository fails to checkout an already checked out
136         revision, because the server is down for example. This is even
137         more problematic for the bots that skip perfectly valid revisions.
138         It's still possible to force an update passing --force command
139         line argument.
140
141         * Scripts/update-webkit-libs-jhbuild:
142         (deleteJhbuildMd5): Delete the md5sum files if exist.
143         (runJhbuild): Return early if the md5sum files haven't
144         changed. Only write them after a successful build and delete them
145         if the build fails to ensure we don't skip next run.
146
147 2015-10-30  Philippe Normand  <pnormand@igalia.com>
148
149         [GTK] Fix MacCLang build errors in Tools
150         https://bugs.webkit.org/show_bug.cgi?id=150031
151
152         Reviewed by Carlos Garcia Campos.
153
154         * TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
155         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
156         * WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
157         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
158
159 2015-10-29  Hunseop Jeong  <hs85.jeong@samsung.com>
160
161         [EFL] MiniBrowser didn't work after r191749.
162         https://bugs.webkit.org/show_bug.cgi?id=150706
163
164         Reviewed by Alex Christensen.
165
166         Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.
167
168         * Scripts/run-minibrowser:
169
170 2015-10-29  Commit Queue  <commit-queue@webkit.org>
171
172         Unreviewed, rolling out r191766.
173         https://bugs.webkit.org/show_bug.cgi?id=150707
174
175         Problem with Cygwin build (Requested by bfulgham_ on #webkit).
176
177         Reverted changeset:
178
179         "[Win] build-jsc and run-javascriptcore-tests do not work"
180         https://bugs.webkit.org/show_bug.cgi?id=150700
181         http://trac.webkit.org/changeset/191766
182
183 2015-10-29  Brent Fulgham  <bfulgham@apple.com>
184
185         [Win] build-jsc and run-javascriptcore-tests do not work
186         https://bugs.webkit.org/show_bug.cgi?id=150700
187
188         Reviewed by Mark Lam.
189         
190         Correct our build system so that it expects Windows to be using CMake,
191         and to build the correct sub-projects for our JSC helper scripts.
192
193         * Scripts/build-jsc: Make sure to build the testapi harness when
194           building for Windows.
195         * Scripts/build-webkit:
196           (1) Use the existing 'cmakeBasedPortName()'
197           (2) Use File::Spec rather than hard-coding path delimeters.
198           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
199         method rather than hard-coding the name based on conditional.
200         * Scripts/run-javascriptcore-tests:
201         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
202         * Scripts/run-jsc: Ditto.
203         * Scripts/webkitdirs.pm:
204         (cmakeBasedPortName): Update to return the right value for the Apple
205         Windows port and the WinCairo port.
206         (isCMakeBuild): Expect CMake build for all Windows ports.
207
208 2015-10-29  Alex Christensen  <achristensen@webkit.org>
209
210         Fix build-jsc on Mac after r191749.
211
212         * Scripts/build-jsc:
213         Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.
214
215 2015-10-29  Alex Christensen  <achristensen@webkit.org>
216
217         Fix Mac CMake build
218         https://bugs.webkit.org/show_bug.cgi?id=150686
219
220         Reviewed by Filip Pizlo.
221
222         * Scripts/build-webkit:
223         * Scripts/webkitdirs.pm:
224         (isCachedArgumentfileOutOfDate):
225         (wrapperPrefixIfNeeded):
226         (generateBuildSystemFromCMakeProject):
227         (buildCMakeGeneratedProject):
228         (cmakeBasedPortName):
229         (determineIsCMakeBuild):
230         (isCMakeBuild):
231         (promptUser):
232         (jhbuildWrapperPrefixIfNeeded): Deleted.
233
234 2015-10-29  Lucas Forschler  <lforschler@apple.com>
235
236         Teach JSC bots to build 32bit instead of x86_64
237         
238         Reviewed by Mark Lam.
239
240         * BuildSlaveSupport/build.webkit.org-config/config.json:
241
242 2015-10-29  Per Arne Vollan  <peavo@outlook.com>
243
244         [WinCairo] Fall back to AppleWin results in layout tests.
245         https://bugs.webkit.org/show_bug.cgi?id=150672
246
247         Reviewed by Alex Christensen.
248
249         * Scripts/webkitpy/port/win.py:
250         (WinCairoPort):
251         (WinCairoPort.default_baseline_search_path):
252
253 2015-10-28  Keith Rollin  <krollin@apple.com>
254
255         Do not sanitize user input for input[type=url]
256         https://bugs.webkit.org/show_bug.cgi?id=150346
257         <rdar://problem/23243240>
258
259         Reviewed by Brent Fulgham.
260
261         The Windows version of DumpRenderTree's eventSender.keyDown handler
262         simulates user-entry by decomposing the given character into a virtual
263         key code and a set of modifier keys. The code that determines if the
264         shift key should be simulated only worked if the character was an
265         upper case character. Extend this support to also include symbols that
266         (on the U.S. keyboard) require holding down the shift key.
267
268         This change allows fast/forms/input-user-input-sanitization.html
269         to succeed, which requires us to simulate the entering of '@' and ':'.
270
271         * DumpRenderTree/win/EventSender.cpp:
272         (keyDownCallback):
273
274 2015-10-28  Alex Christensen  <achristensen@webkit.org>
275
276         Compile and link with CMake on Mac
277         https://bugs.webkit.org/show_bug.cgi?id=150632
278
279         Reviewed by Tim Horton.
280
281         * TestWebKitAPI/PlatformMac.cmake:
282
283 2015-10-28  Xabier Rodriguez Calvar  <calvaris@igalia.com>
284
285         Unreviewed.
286
287         * Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
288
289 2015-10-28  Per Arne Vollan  <peavo@outlook.com>
290
291         Add WinCairo to list of ports in run-webkit-tests.
292         https://bugs.webkit.org/show_bug.cgi?id=150625
293
294         Reviewed by Brent Fulgham.
295
296         * Scripts/webkitpy/common/config/ports.py:
297         (DeprecatedPort.port):
298         (WinPort.run_webkit_tests_command):
299         (WinCairoPort):
300         (GtkWK2Port):
301         * Scripts/webkitpy/port/factory.py:
302         (PortFactory):
303         * Scripts/webkitpy/port/win.py:
304         (WinPort.find_system_pid):
305         (WinCairoPort):
306
307 2015-10-27  Alexey Proskuryakov  <ap@apple.com>
308
309         WebKitTestRunner leaks in generateWhitelist()
310         https://bugs.webkit.org/show_bug.cgi?id=150563
311
312         Reviewed by Andreas Kling.
313
314         * WebKitTestRunner/mac/TestControllerMac.mm:
315         (WTR::generateWhitelist):
316
317 2015-10-27  Anders Carlsson  <andersca@apple.com>
318
319         Add an API test for _WKRemoteObjectRegistry
320         https://bugs.webkit.org/show_bug.cgi?id=150597
321
322         Reviewed by Andreas Kling.
323
324         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
325         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
326         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
327         (TEST):
328         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
329         (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
330         (-[RemoteObjectRegistryPlugIn sayHello:]):
331
332 2015-10-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
333
334         Add myself to the reviewers list
335         https://bugs.webkit.org/show_bug.cgi?id=150581
336
337         Unreviewed.
338
339         * Scripts/webkitpy/common/config/contributors.json:
340
341 2015-10-26  Ryan Haddad  <ryanhaddad@apple.com>
342
343         Adding myself to contributors.json
344
345         * Scripts/webkitpy/common/config/contributors.json:
346
347 2015-10-26  Tim Horton  <timothy_horton@apple.com>
348
349         Don't expose the whitelist/blacklist in _WKUserStyleSheet
350         https://bugs.webkit.org/show_bug.cgi?id=150566
351
352         Reviewed by Anders Carlsson.
353
354         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
355         (TEST):
356
357 2015-10-26  Philippe Normand  <pnormand@igalia.com>
358
359         Unreviewed, rolling out r191576.
360
361         broke
362
363         Reverted changeset:
364
365         "[GStreamer] Bump internal jhbuild versions to 1.6.0"
366         https://bugs.webkit.org/show_bug.cgi?id=149594
367         http://trac.webkit.org/changeset/191576
368
369 2015-10-26  ChangSeok Oh  <changseok.oh@collabora.com>
370
371         [GStreamer] Bump internal jhbuild versions to 1.6.0
372         https://bugs.webkit.org/show_bug.cgi?id=149594
373
374         Reviewed by Philippe Normand.
375
376         Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
377         useful so they are removed accordingly.
378
379         * gtk/jhbuild.modules:
380         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
381         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
382         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
383
384 2015-10-25  Alexey Proskuryakov  <ap@apple.com>
385
386         API tests fail on El Capitan after r191543
387         https://bugs.webkit.org/show_bug.cgi?id=150547
388
389         Reviewed by Dan Bernstein.
390
391         * Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
392
393 2015-10-24  Tim Horton  <timothy_horton@apple.com>
394
395         Add a way to add user style sheets to WKUserContentController
396         https://bugs.webkit.org/show_bug.cgi?id=150531
397         <rdar://problem/23191691>
398
399         Reviewed by Darin Adler.
400
401         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
402         (TEST):
403
404 2015-10-24  Tim Horton  <timothy_horton@apple.com>
405
406         Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
407         https://bugs.webkit.org/show_bug.cgi?id=150525
408
409         Reviewed by Darin Adler.
410
411         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
412         (TEST):
413         Test the various new keys.
414
415 2015-10-24  Frederic Wang  <fred.wang@free.fr>
416
417         check-webkit-style complains about missing operator whitespace inside character literal
418         https://bugs.webkit.org/show_bug.cgi?id=150396
419
420         Reviewed by Darin Adler.
421
422         * Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
423         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
424         (WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
425
426 2015-10-23  Michael Saboff  <msaboff@apple.com>
427
428         REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
429         https://bugs.webkit.org/show_bug.cgi?id=150513
430
431         Reviewed by Saam Barati.
432
433         Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
434
435         * DumpRenderTree/TestRunner.cpp:
436         (simulateWebNotificationClickCallback):
437         (failNextCodeBlock):
438         (numberOfDFGCompiles):
439         (TestRunner::staticFunctions):
440         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
441         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
442         (WTR::TestRunner::setBlockAllPlugins):
443         (WTR::TestRunner::failNextCodeBlock):
444         (WTR::TestRunner::numberOfDFGCompiles):
445         * WebKitTestRunner/InjectedBundle/TestRunner.h:
446
447 2015-10-23  Anders Carlsson  <andersca@apple.com>
448
449         Simplify the WebKitLegacy menu conversion code
450         https://bugs.webkit.org/show_bug.cgi?id=150509
451
452         Reviewed by Andreas Kling.
453
454         Implement the context menu delegate method so we'll test that code path.
455
456         * MiniBrowser/mac/WK1BrowserWindowController.m:
457         (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
458
459 2015-10-23  Per Arne Vollan  <peavo@outlook.com>
460
461         [WinCairo] Improve test results for fast layouttests.
462         https://bugs.webkit.org/show_bug.cgi?id=150464
463
464         Reviewed by Alex Christensen.
465
466         Set custom device scale factor to 1.0.
467
468         * DumpRenderTree/win/DumpRenderTree.cpp:
469         (createWebViewAndOffscreenWindow):
470
471 2015-10-23  Mark Salisbury  <mark.salisbury@hp.com>
472
473         [GTK] update-webkitgtk-libs should use mesa tarball
474
475         https://bugs.webkit.org/show_bug.cgi?id=150470
476
477         update-webkitgtk-libs downloads all build dependencies; in fixing
478         bug 148941 mesa was switched from ftp to git access.  Now an http
479         tarball is available, which is preferred over accessing via git.
480
481         Reviewed by Philippe Normand
482
483         * gtk/jhbuild.modules:
484         Mesa access changed to http tarball.
485
486 2015-10-22  Sam Weinig  <sam@webkit.org>
487
488         Navigations on the same host (but with different schemes and ports) should not trigger universal links
489         <rdar://problem/22811325>
490         https://bugs.webkit.org/show_bug.cgi?id=150481
491
492         Reviewed by Dan Bernstein.
493
494         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
495         Update test to test that navigations on the same host but with different schemes does not
496         trigger universal links, but that changes in the host do.
497
498 2015-10-22  Ryosuke Niwa  <rniwa@webkit.org>
499
500         REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
501         https://bugs.webkit.org/show_bug.cgi?id=150428
502
503         Reviewed by Antti Koivisto.
504
505         Added a regression test using WebKit API test.
506
507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
508         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
509         (TestWebKitAPI::didFinishLoadForFrame):
510         (TestWebKitAPI::TEST):
511
512 2015-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
513
514         Unreviewed. Fix GTK+ build after r191423.
515
516         Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
517
518         * gtk/webkitdom.py:
519         (WebKitDOMDocGenerator):
520
521 2015-10-22  Aakash Jain  <aakash_jain@apple.com>
522
523         [Win][EFL][GTK] webkitpy test failed after r191374.
524         https://bugs.webkit.org/show_bug.cgi?id=150433
525
526         Reviewed by Alexey Proskuryakov.
527
528         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
529         (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
530         (CrashLogsTest.test_find_log_darwin): Same.
531
532 2015-10-21  Brian Burg  <bburg@apple.com>
533
534         Unreviewed, update watchlist for JS builtins.
535
536         Add a category for JS builtins code generator, similar to other generators.
537
538         Add a nag message to rebaseline builtins generator tests when touching
539         code generator files in Source/JavaScriptCore/Scripts/builtins/.
540
541         * Scripts/webkitpy/common/config/watchlist:
542
543 2015-10-21  Brian Burg  <bburg@apple.com>
544
545         Restructure generate-js-bindings script to be modular and testable
546         https://bugs.webkit.org/show_bug.cgi?id=149929
547
548         Reviewed by Alex Christensen.
549
550         Add a stub shell script and basic webkitpy support for running builtins
551         generator tests.
552
553         * Scripts/run-builtins-generator-tests: Added.
554         (main):
555         * Scripts/webkitpy/codegen/__init__.py: Added.
556         * Scripts/webkitpy/codegen/main.py: Added.
557
558             The only interesting difference here from the inspector protocol
559             generator equivalent is that this implementation decodes the target
560             framework and output mode (combined or separate) from the test's file name.
561
562         (BuiltinsGeneratorTests):
563         (BuiltinsGeneratorTests.__init__):
564         (BuiltinsGeneratorTests.generate_from_js_builtins):
565         (BuiltinsGeneratorTests.write_error_file):
566         (BuiltinsGeneratorTests.detect_changes):
567         (BuiltinsGeneratorTests.run_tests):
568         (BuiltinsGeneratorTests.main):
569
570 2015-10-21  Aakash Jain  <aakash_jain@apple.com>
571
572         run-webkit-tests does not copy all crash logs for layout test failures on Mac
573         https://bugs.webkit.org/show_bug.cgi?id=150407
574         <rdar://problem/22239750>
575
576         Reviewed by Alexey Proskuryakov.
577
578         * Scripts/webkitpy/port/mac.py:
579         (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
580         (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
581         the log directory.
582         (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
583         from log directory and merge them with the list of already crashed tests.
584
585 2015-10-21  Filip Pizlo  <fpizlo@apple.com>
586
587         Failures in PutStackSinkingPhase should be less severe
588         https://bugs.webkit.org/show_bug.cgi?id=150400
589
590         Reviewed by Geoffrey Garen.
591
592         Add a test mode for no PutStackSinkingPhase.
593
594         * Scripts/run-jsc-stress-tests:
595
596 2015-10-21  Nan Wang  <n_wang@apple.com>
597
598         AX: Expose table size and cell indexes on iOS
599         https://bugs.webkit.org/show_bug.cgi?id=150366
600
601         Reviewed by Chris Fleizach.
602
603         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
604         (AccessibilityUIElement::rowCount):
605         (AccessibilityUIElement::columnCount):
606         (AccessibilityUIElement::indexInTable):
607         (AccessibilityUIElement::numberAttributeValue):
608         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
609         (WTR::AccessibilityUIElement::numberAttributeValue):
610         (WTR::AccessibilityUIElement::rowCount):
611         (WTR::AccessibilityUIElement::columnCount):
612         (WTR::AccessibilityUIElement::indexInTable):
613
614 2015-10-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
615
616         W3C test importer should not import reference files as regular tests
617         https://bugs.webkit.org/show_bug.cgi?id=150331
618
619         Reviewed by Darin Adler.
620
621         Updated test_parser to return information that a file can be a referencefile or a manual test.
622         Updated test importer to skip those files.
623         Updated/Added test parser unit tests accordingly.
624
625         Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
626         Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
627         to mark these files as Skip, since they are not direct tests. 
628
629         * Scripts/webkitpy/w3c/test_importer.py:
630         (TestImporter.__init__):
631         (TestImporter.find_importable_tests):
632         (TestImporter.import_tests):
633         * Scripts/webkitpy/w3c/test_parser.py:
634         (TestParser.analyze_test):
635         * Scripts/webkitpy/w3c/test_parser_unittest.py:
636         (test_analyze_non_html_file):
637         (test_reference_test):
638
639 2015-10-20  Aakash Jain  <aakash_jain@apple.com>
640
641         run-webkit-tests does not copy all crash logs for layout test failures on iOS
642         https://bugs.webkit.org/show_bug.cgi?id=150056
643         <rdar://problem/9280656>
644
645         Reviewed by Alexey Proskuryakov.
646
647         * Scripts/webkitpy/common/system/crashlogs.py:
648         (CrashLogs.find_all_logs): Generic method to find all crash logs.
649         (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
650         It iterates through log directory and returns all the logs based on timestamp.
651         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
652         (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
653         (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
654         (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
655         * Scripts/webkitpy/layout_tests/controllers/manager.py:
656         (Manager.run): Modified start_time to start counting before simulator launch
657         so that we can capture crashes during simualator launch.
658         (Manager._look_for_new_crash_logs): Browse through list of crashes and append
659         any test which is not already marked as CRASH to the run_results.
660         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
661         (TestExpectationsModel.get_expectations_string): return PASS in case there
662         are no expectations defined for this test.
663         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
664         (summarize_results): Add other_crashes in a separte category in full_results.json.
665         * Scripts/webkitpy/port/ios.py:
666         (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
667         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
668         from the log directory.
669         (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
670         logs from log directory and merge them with the list of already crashed tests.
671
672 2015-10-20  Dana Burkart  <dburkart@apple.com>
673
674         Fix the build
675
676         Unreviewed.
677
678         My previous patch was missing a necessary space character.
679
680         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
681
682 2015-10-20  Dana Burkart  <dburkart@apple.com>
683
684         svn-apply fails to apply binary diffs in some cases
685         https://bugs.webkit.org/show_bug.cgi?id=64647
686
687         Reviewed by Daniel Bates.
688
689         * Scripts/VCSUtils.pm:
690         (decodeGitBinaryPatchDeltaSize): Modified.
691         We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
692         * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
693
694 2015-10-20  Alexey Proskuryakov  <ap@apple.com>
695
696         Mac Debug EWS never finishes when there are failures
697         https://bugs.webkit.org/show_bug.cgi?id=150334
698
699         Reviewed by Daniel Bates.
700
701         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
702         * Scripts/webkitpy/tool/commands/queues.py:
703
704 2015-10-20  Philippe Normand  <pnormand@igalia.com>
705
706         [GTK] Enable OpenWebRTC test video/audio sources in tests
707
708         This is needed because we can't expect the buildbots to have
709         webcam/mic devices plugged in.
710
711         Rubber-stamped by Carlos Garcia Campos.
712
713         * Scripts/run-gtk-tests:
714         (TestRunner._setup_testing_environment):
715         * Scripts/webkitpy/port/gtk.py:
716         (GtkPort.setup_environ_for_server):
717
718 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
719
720         Rename the PICTURE_SIZES flag to CURRENTSRC
721         https://bugs.webkit.org/show_bug.cgi?id=150275
722
723         Reviewed by Dean Jackson.
724
725         * Scripts/webkitperl/FeatureList.pm:
726
727 2015-10-19  Hunseop Jeong  <hs85.jeong@samsung.com>
728
729         Unreviewed, add myself to the committers list.
730
731         * Scripts/webkitpy/common/config/contributors.json:
732
733 2015-10-19  Alexey Proskuryakov  <ap@apple.com>
734
735         Add new EWS queues to bot watcher's dashboard
736         https://bugs.webkit.org/show_bug.cgi?id=150297
737
738         Reviewed by Darin Adler.
739
740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
741         (BubbleQueueServer):
742
743 2015-10-19  ChangSeok Oh  <changseok.oh@collabora.com>
744
745         REGRESSION(r190262): User media unit test failures after r190262
746         https://bugs.webkit.org/show_bug.cgi?id=149580
747
748         Reviewed by Carlos Garcia Campos.
749
750         The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
751         So we do not need to skip them anymore.
752
753         * Scripts/run-gtk-tests:
754         (TestRunner): Deleted.
755
756 2015-10-19  Csaba Osztrogonác  <ossy@webkit.org>
757
758         Add historical addresses to contributors.json
759         https://bugs.webkit.org/show_bug.cgi?id=150227
760
761         Reviewed by Darin Adler.
762
763         * Scripts/webkitpy/common/config/contributors.json:
764
765 2015-10-18  Sungmann Cho  <sungmann.cho@navercorp.com>
766
767         [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
768         https://bugs.webkit.org/show_bug.cgi?id=150307
769
770         Reviewed by Brent Fulgham.
771
772         The DLL build rules have been changed to generate "{Name}Lib.DLL",
773         but these changes have not yet been applied to the Visual Studio builds.
774
775         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
776
777 2015-10-16  Andreas Kling  <akling@apple.com>
778
779         [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
780         <https://webkit.org/b/150153>
781
782         Unreviewed.
783
784         Just use simple arrays of LChar and UChar for this test instead of creating String
785         objects and then getting the characters8()/characters16() from them, since that
786         doesn't guarantee null-termination (the bug.)
787
788         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
789         (TestWebKitAPI::TEST):
790         (TestWebKitAPI::build): Deleted.
791
792 2015-10-16  Tim Horton  <timothy_horton@apple.com>
793
794         WebKit2.AutoLayoutIntegration API test is failing on some of the bots
795         https://bugs.webkit.org/show_bug.cgi?id=150255
796
797         Reviewed by Simon Fraser.
798
799         * Scripts/run-api-tests:
800         (runTest):
801         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
802         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
803         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
804         (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
805         (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
806         Don't set the layout size until after the load finishes and we're waiting
807         for the reply, so that there is no race between the new size coming in
808         and us waiting for it.
809
810 2015-10-16  Anders Carlsson  <andersca@apple.com>
811
812         WebEditingDelegate should be a formal protocol
813         https://bugs.webkit.org/show_bug.cgi?id=150254
814         <rdar://problem/23149847>
815
816         Reviewed by Dan Bernstein.
817
818         * DumpRenderTree/mac/EditingDelegate.h:
819         Conform to the WebEditingDelegate protocol.
820
821 2015-10-16  Tim Horton  <timothy_horton@apple.com>
822
823         Hook up autolayout intrinsic sizing for WKWebView
824         https://bugs.webkit.org/show_bug.cgi?id=150219
825         <rdar://problem/20016905>
826
827         Reviewed by Simon Fraser.
828
829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
830         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
831         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
832         (-[AutoLayoutWKWebView load:expectingContentSize:]):
833         (-[AutoLayoutWKWebView expectContentSizeChange:]):
834         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
835         (TEST):
836         Add a variety of tests, including one which catches the bug that
837         the WebCore part of this patch fixes.
838
839 2015-10-15  Csaba Osztrogonác  <ossy@webkit.org>
840
841         Update the help message of --system-malloc
842         https://bugs.webkit.org/show_bug.cgi?id=150169
843
844         Reviewed by Geoffrey Garen.
845
846         * Scripts/webkitperl/FeatureList.pm:
847
848 2015-10-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
849
850         Update ImportExpectations according currently imported wpt tests
851         https://bugs.webkit.org/show_bug.cgi?id=150158
852
853         Reviewed by Chris Dumez.
854
855         * Scripts/webkitpy/w3c/test_downloader.py:
856         (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
857
858 2015-10-15  Eunmi Lee  <eunmi15.lee@samsung.com>
859
860         Unreviewed, Update my email address.
861
862         * Scripts/webkitpy/common/config/contributors.json:
863
864 2015-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
865
866         [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
867         https://bugs.webkit.org/show_bug.cgi?id=84960
868
869         Reviewed by Žan Doberšek.
870
871         * Scripts/run-gtk-tests:
872         (TestRunner): Unskip tests using SessionState.
873         * TestWebKitAPI/PlatformGTK.cmake: Add
874         WKPageCopySessionStateWithFiltering test.
875
876 2015-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
877
878         [GTK] Missing return value on TestWebExtensions.cpp:193
879         https://bugs.webkit.org/show_bug.cgi?id=149755
880
881         Unreviewed. Add missing return value.
882
883         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
884         (permissionRequestCallback):
885
886 2015-10-14  Andy Estes  <aestes@apple.com>
887
888         [iOS] build-dumprendertree does not build ImageDiff
889         https://bugs.webkit.org/show_bug.cgi?id=150152
890
891         Reviewed by Tim Horton.
892
893         run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
894         On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
895         as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
896         WebKit.xcworkspace), tests that rely on image diffing won't work properly.
897
898         There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
899         fine on that platform, and results in ImageDiff being built.
900
901         * Scripts/build-dumprendertree:
902
903 2015-10-14  Brent Fulgham  <bfulgham@apple.com>
904
905         [Win] Enforce launcher/library naming scheme
906         https://bugs.webkit.org/show_bug.cgi?id=150124
907
908         Reviewed by Alex Christensen.
909
910         * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
911         * MiniBrowser/win/CMakeLists.txt: Ditto.
912         * TestWebKitAPI/PlatformWin.cmake: Ditto.
913         * win/DLLLauncher/DLLLauncherMain.cpp:
914         (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
915         original {name}.dll.
916
917 2015-10-14  Andreas Kling  <akling@apple.com>
918
919         REGRESSION(r190882): Concatenating a character array and an empty string is broken.
920         <https://webkit.org/b/150135>
921
922         Reviewed by Geoffrey Garen.
923
924         Add a new WTF API test that covers this issue.
925
926         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
927         (TestWebKitAPI::build):
928         (TestWebKitAPI::TEST):
929
930 2015-10-14  Alex Christensen  <achristensen@webkit.org>
931
932         Add SPI for reloading without content blockers
933         https://bugs.webkit.org/show_bug.cgi?id=150058
934         rdar://problem/22742222
935
936         Reviewed by Sam Weinig.
937
938         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
939         (WTR::TestController::cocoaResetStateToConsistentValues):
940         * WebKitTestRunner/mac/TestControllerMac.mm:
941         (WTR::TestController::platformConfigureViewForTest):
942
943 2015-10-14  Mark Lam  <mark.lam@apple.com>
944
945         Rename some JSC option names to be more uniform.
946         https://bugs.webkit.org/show_bug.cgi?id=150127
947
948         Reviewed by Geoffrey Garen.
949
950         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
951         * Scripts/run-jsc-stress-tests:
952
953 2015-10-14  Anders Carlsson  <andersca@apple.com>
954
955         Change the bundle app cache APIs to take a page
956         https://bugs.webkit.org/show_bug.cgi?id=150123
957
958         Reviewed by Sam Weinig.
959
960         Update APIs.
961
962         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
963         (WTR::InjectedBundle::beginTesting):
964         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
965         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
966         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
967         (WTR::TestRunner::clearAllApplicationCaches):
968         (WTR::TestRunner::clearApplicationCacheForOrigin):
969         (WTR::TestRunner::setAppCacheMaximumSize):
970         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
971         (WTR::TestRunner::originsWithApplicationCache):
972
973 2015-10-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
974
975         Update web-platform-tests tools to the latest revision
976         https://bugs.webkit.org/show_bug.cgi?id=149645
977
978         Reviewed by Darin Adler.
979
980         Disabling git submodules information conversion to json install file for web-platform-tests.
981         Disabling related python unit tests.
982         The tools submodules contain submodules and the conversion tool does not support that yet.
983
984         Updating wpt launcher script to aling it with web-platform-test main script.
985
986         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
987         (main):
988         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
989         (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
990         * Scripts/webkitpy/w3c/test_importer_unittest.py:
991         (TestImporterTest.test_submodules_generation):
992
993 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
994
995         More debug queue build fixing.
996
997         Preserve the build style in one more place. Changed mock build_style from "both"
998         to "release", as we don't support testing both debug and release.
999
1000         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1001         (MockCommitQueue.archive_last_test_results):
1002         (MockCommitQueue):
1003         (MockCommitQueue.build_style):
1004         (MockCommitQueue.did_pass_testing_ews):
1005         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1006         (PatchAnalysisTask._test):
1007         (PatchAnalysisTask._build_and_test_without_patch):
1008         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1009         (EarlyWarningSystemTest._default_expected_logs):
1010         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1011
1012 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1013
1014         More debug queue build fixing.
1015
1016         Add build_style argument to derived classes as well.
1017
1018         * Scripts/webkitpy/common/config/ports.py:
1019         (MacPort):
1020         (MacPort.run_webkit_tests_command):
1021         (WinPort.run_bindings_tests_command):
1022         (WinPort):
1023         (WinPort.run_webkit_tests_command):
1024         (GtkWK2Port.build_webkit_command):
1025         (GtkWK2Port):
1026         (GtkWK2Port.run_webkit_tests_command):
1027
1028 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
1029
1030         [iOS] Build fix
1031
1032         Unreviewed.
1033
1034         Mach-O section names are limited to 16 characters.
1035
1036         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1037         * DumpRenderTree/mac/DumpRenderTree.mm:
1038         (activateFontsIOS):
1039
1040 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1041
1042         Build fix for mac-debug EWS queue.
1043
1044         Unreviewed.
1045
1046         Pass --debug to run-webkit-tests.
1047
1048         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
1049         will need to be substantially modified to work in EWS, so the dummy implementation
1050         was not helpful.
1051
1052         * Scripts/webkitpy/common/config/ports.py:
1053         (DeprecatedPort.run_javascriptcore_tests_command):
1054         (DeprecatedPort):
1055         (DeprecatedPort.run_webkit_tests_command):
1056         (DeprecatedPort.run_python_unittests_command):
1057         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
1058         * Scripts/webkitpy/common/config/ports_mock.py:
1059         (MockPort.run_javascriptcore_tests_command):
1060         (MockPort):
1061         (MockPort.run_webkit_tests_command):
1062         (MockPort.run_bindings_tests_command):
1063         (MockPort.run_webkit_unit_tests_command): Deleted.
1064         * Scripts/webkitpy/tool/commands/download_unittest.py:
1065         * Scripts/webkitpy/tool/steps/runtests.py:
1066         (RunTests.run):
1067         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1068         (RunTestsTest.test_webkit_run_unit_tests):
1069         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1070         (StepsTest.test_runtests_args):
1071
1072 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
1073
1074         [Win] Generate Crash Traces
1075         https://bugs.webkit.org/show_bug.cgi?id=150103
1076
1077         Reviewed by Daniel Bates.
1078
1079         We were using an exception filter to try to emit "#CRASHED" to stderr
1080         when a test program crashed. However, the modern Python implementation
1081         seems capable of recognizing crashes on its own. Furthermore, registering
1082         the exception handler was preventing the JIT debugger (NTSD) from
1083         automatically attaching to the crashing program, so we were not getting
1084         crash traces.
1085         
1086         * DumpRenderTree/win/DumpRenderTree.cpp:
1087         (main): Don't register an exception filter.
1088         (exceptionFilter): Deleted.
1089         * Scripts/webkitpy/common/system/crashlogs.py:
1090         (CrashLogs): Add another regular expression to handle a second crash trace
1091         syntax I encountered during testing.
1092         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
1093         try the new one. The PID found by the new expression is in hexadecimal, so
1094         convert it to an integer before returning it.
1095         * Scripts/webkitpy/port/driver.py:
1096         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
1097         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
1098         check for "#CRASHED" after stripping off the EOL characters.
1099         * Scripts/webkitpy/port/win.py:
1100         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
1101         invocation. This is apparently used to signal an event when the debugger is finished.
1102
1103 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1104
1105         Mac Debug and 32-bit queues should be separate
1106         https://bugs.webkit.org/show_bug.cgi?id=150092
1107
1108         Reviewed by Lucas Forschler.
1109
1110         * QueueStatusServer/config/queues.py:
1111         * QueueStatusServer/model/queues.py:
1112         (Queue._capitalize_after_dash):
1113         (Queue._caplitalize_after_dash): Deleted.
1114         * Scripts/webkitpy/common/config/ews.json:
1115
1116 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
1117
1118         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
1119         https://bugs.webkit.org/show_bug.cgi?id=150085
1120
1121         Reviewed by Carlos Garcia Campos.
1122
1123         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1124
1125 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
1126
1127         Unreviewed, add myself to the committers list.
1128
1129         * Scripts/webkitpy/common/config/contributors.json:
1130
1131 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1132
1133         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
1134         https://bugs.webkit.org/show_bug.cgi?id=149983
1135
1136         Reviewed by Dan Bates.
1137
1138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1139         (BubbleQueueServer):
1140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1141
1142 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1143
1144         Fix webkitpy tests after r190922.
1145
1146         * Scripts/webkitpy/common/config/ews.json:
1147         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1148         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1149
1150 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1151
1152         Add a Mac debug EWS queue
1153         https://bugs.webkit.org/show_bug.cgi?id=150069
1154
1155         Reviewed by Geoffrey Garen.
1156
1157         * QueueStatusServer/config/queues.py:
1158         * Scripts/webkitpy/common/config/ews.json:
1159         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1160         (AbstractEarlyWarningSystem):
1161         (AbstractEarlyWarningSystem.archive_last_test_results):
1162         (AbstractEarlyWarningSystem.build_style):
1163         (AbstractEarlyWarningSystem.refetch_patch):
1164         (AbstractEarlyWarningSystem.load_ews_classes):
1165
1166 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1167
1168         [GTK] Update jhbuild's version of harfbuzz
1169         https://bugs.webkit.org/show_bug.cgi?id=149749
1170
1171         Reviewed by Martin Robinson.
1172
1173         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
1174
1175         * gtk/jhbuild.modules: Updated details for harfbuzz.
1176
1177 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1178
1179         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
1180         https://bugs.webkit.org/show_bug.cgi?id=150026
1181
1182         Reviewed by Philippe Normand.
1183
1184         Backport upstream patch from gst-plugins-bad so that the right version
1185         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
1186         gets compiled properly, avoiding crashes on runtime while running tests.
1187
1188         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
1189         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
1190
1191 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
1192
1193         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
1194         https://bugs.webkit.org/show_bug.cgi?id=149777
1195
1196         Reviewed by Simon Fraser.
1197
1198         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
1199         to the list of tests to preinstall at startup time.
1200
1201         Also, update the generation of the 'name' table in the FontWithFeatures font.
1202
1203         * DumpRenderTree/mac/DumpRenderTree.mm:
1204         (allowedFontFamilySet):
1205         (activateTestingFonts):
1206         (activateFontsIOS):
1207         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1208         (Generator::generate):
1209         (Generator::appendCFFTable):
1210         (Generator::appendNameSubtable):
1211         (Generator::appendNAMETable):
1212         * FontWithFeatures/FontWithFeatures/main.cpp:
1213         (main):
1214         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1215         (WTR::allowedFontFamilySet):
1216         (WTR::activateFonts):
1217         * WebKitTestRunner/mac/TestControllerMac.mm:
1218         (WTR::allowedFontFamilySet):
1219
1220 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
1221
1222         Unreviewed. Add Jinyoung Hur as a committer. 
1223
1224         * Scripts/webkitpy/common/config/contributors.json:
1225
1226 2015-10-10  Dan Bernstein  <mitz@apple.com>
1227
1228         [iOS] Remove unnecessary iOS version checks
1229         https://bugs.webkit.org/show_bug.cgi?id=150002
1230
1231         Reviewed by Alexey Proskuryakov.
1232
1233         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1234         (-[HIDEventGenerator _createIOHIDEventType:]):
1235         (-[HIDEventGenerator _sendHIDEvent:]):
1236         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1237         * WebKitTestRunner/ios/UIKitSPI.h:
1238
1239 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
1240
1241         Unreviewed, rolling out r190689
1242         https://bugs.webkit.org/show_bug.cgi?id=149992
1243
1244         Fixed in other repository.
1245
1246         Reverted changesets:
1247
1248         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
1249         https://bugs.webkit.org/show_bug.cgi?id=149897
1250
1251 2015-10-09  Brian Burg  <bburg@apple.com>
1252
1253         Teach webkitperl how to figure out IOS versions from the SDK
1254         https://bugs.webkit.org/show_bug.cgi?id=149963
1255
1256         Reviewed by Daniel Bates.
1257
1258         It should be easier to check the major and minor version of IOS SDKs.
1259
1260         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
1261         * Scripts/webkitdirs.pm:
1262         (splitVersionString): Added.
1263         (determineOSXVersion): Use splitVersionString.
1264         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
1265         (iosVersion): Added.
1266
1267 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
1268
1269         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
1270         https://bugs.webkit.org/show_bug.cgi?id=149960
1271
1272         Reviewed by Tim Horton.
1273         
1274         Use adoptWK(), and null out some members (file is not using ARC).
1275
1276         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1277         (UIScriptContext::uiScriptComplete):
1278         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1279         (-[TestRunnerWKWebView dealloc]):
1280
1281 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1282
1283         Remove ENABLE_SUID_SANDBOX_LINUX cruft
1284         https://bugs.webkit.org/show_bug.cgi?id=149954
1285
1286         Reviewed by Darin Adler.
1287
1288         * Scripts/webkitperl/FeatureList.pm:
1289
1290 2015-10-09  Daniel Bates  <dabates@apple.com>
1291
1292         Make iOS builders generate debug information in a separate dSYM file
1293         https://bugs.webkit.org/show_bug.cgi?id=149696
1294
1295         Reviewed by Darin Adler.
1296
1297         Similar to the Mac builders, the iOS builders should write debug information
1298         into a separate dSYM file instead of including such information in the binary
1299         itself (default Xcode behavior)
1300
1301         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1302         (CompileWebKit.start):
1303
1304 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1305
1306         Fix webkitpy tests after r190779
1307         https://bugs.webkit.org/show_bug.cgi?id=149949
1308
1309         Reviewed by Ryosuke Niwa.
1310
1311         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1312         (BenchmarkResults.format):
1313         (BenchmarkResults._format_values):
1314
1315 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
1316
1317         Extend run-benchmark script to support human-readable results conversion.
1318         https://bugs.webkit.org/show_bug.cgi?id=149944
1319
1320         Reviewed by Ryosuke Niwa.
1321
1322         Add '--read-results-json' and '--no-adjust-unit' options.
1323         '--read-results-json' option converts result file to human readable format.
1324         '--no-adjust-unit' option skips scientific notation convertion.
1325         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
1326
1327         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1328         (BenchmarkResults.format):
1329         (BenchmarkResults._format_tests):
1330         (BenchmarkResults._format_values):
1331         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1332         (BenchmarkRunner.__init__):
1333         (BenchmarkRunner._run_benchmark):
1334         (BenchmarkRunner._dump):
1335         (BenchmarkRunner.show_results):
1336         (BenchmarkRunner._show_results): Deleted.
1337         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1338         (parse_args):
1339         (start):
1340
1341 2015-10-08  Daniel Bates  <dabates@apple.com>
1342
1343         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
1344         https://bugs.webkit.org/show_bug.cgi?id=149945
1345
1346         Reviewed by Dan Bernstein.
1347
1348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
1349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
1350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1351         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1352         (WebKitBuildbot):
1353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1354         (table.queue-grid tr.platform.ios-9 img.logo):
1355
1356 2015-10-08  Daniel Bates  <dabates@apple.com>
1357
1358         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
1359         https://bugs.webkit.org/show_bug.cgi?id=149943
1360
1361         Reviewed by Dan Bernstein.
1362
1363         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
1364         teach build-webkit to install them when building for iOS device using the public iOS SDK. 
1365
1366         * Scripts/build-webkit:
1367
1368 2015-10-08  Daniel Bates  <dabates@apple.com>
1369
1370         Add LLVM binaries for iOS 9 device
1371         https://bugs.webkit.org/show_bug.cgi?id=149913
1372
1373         Reviewed by Filip Pizlo.
1374
1375         Implement support for building LLVM for ARM64-based iOS devices.
1376
1377         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
1378         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
1379         an existing build earlier in the file such that remove previously built
1380         libraries before building/copying new ones (if applicable).
1381         (fileContains): Moved function outside of if-block.
1382         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
1383         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
1384         added logic to build LLVM for ARM64-based iOS devices.
1385         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
1386         LLVM into the WebKitBuild directory.
1387
1388 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
1389
1390         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
1391         https://bugs.webkit.org/show_bug.cgi?id=149848
1392
1393         Reviewed by Darin Adler.
1394
1395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1396
1397 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
1398
1399         [Win] Support 64-bit Build and Testing
1400         https://bugs.webkit.org/show_bug.cgi?id=149904
1401
1402         Reviewed by Daniel Bates.
1403
1404         Extend our existing scripts to support 64-bit build and test operations on
1405         Windows.
1406
1407         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
1408         Windows always builds the whole stack.
1409         * Scripts/webkit-build-directory: Add an option to return the location of
1410         the executable files produced by a specific configuration. This change is
1411         actually useful for Gtk and EFL, too.
1412         * Scripts/webkitdirs.pm:
1413         (executableProductDir): Added. This function appends the proper binary
1414         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
1415         (jscProductDir): Use the new 'executableProductDir' method.
1416         (setPathForRunningWebKitApp): Ditto.
1417         (runSafari): Ditto.
1418         (runMiniBrowser): Ditto.
1419         * Scripts/webkitpy/port/factory.py:
1420         (configuration_options): Add a 64-bit option, used on Windows to specify
1421         which binary target should be used for testing.
1422         * Scripts/webkitpy/port/win.py:
1423         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
1424         processes when needed.
1425         (WinPort._build_path): Add the correct binary target path to _build_path.
1426         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
1427         64-bit paths for 64-bit tests.
1428         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
1429         NTSD debugger does not understand this argument.
1430
1431 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
1432
1433         Test font-variant-* and font-feature-settings with TrueType fonts
1434         https://bugs.webkit.org/show_bug.cgi?id=149776
1435
1436         Reviewed by Simon Fraser.
1437
1438         This test extends our existing FontWithFeatures project to be able to generate a
1439         TrueType font. This font is conceptually similar as the existing OpenType font,
1440         except the feature -> character mapping is different.
1441
1442         The font itself only supports the following characters:
1443         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1444         However, the shape of these letters are either an X or a check mark.
1445         The letter "A" always is a check mark.
1446         The letter "B" always is an X.
1447         Each font feature has an letter associated with it. When the font feature is enabled,
1448         that letter is shown as a check mark. For example, when
1449         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
1450         mark.
1451
1452         Here are the mappings of font features to letters:
1453         kLigaturesType / kCommonLigaturesOnSelector: C
1454         kLigaturesType / kContextualLigaturesOnSelector: D
1455         kLigaturesType / kRareLigaturesOnSelector: G
1456         kLigaturesType / kHistoricalLigaturesOnSelector: I
1457         kContextualAlternatesType / kContextualAlternatesOnSelector: L
1458         kVerticalPositionType / kInferiorsSelector: O
1459         kVerticalPositionType / kSuperiorsSelector: P
1460         kLowerCaseType / kLowerCaseSmallCapsSelector: S
1461         kUpperCaseType / kUpperCaseSmallCapsSelector: V
1462         kLowerCaseType / kLowerCasePetiteCapsSelector: T
1463         kUpperCaseType / kUpperCasePetiteCapsSelector: W
1464         kLetterCaseType / 14: Y
1465         kStyleOptionsType / kTitlingCapsSelector: a
1466         kNumberCaseType / kUpperCaseNumbersSelector: c
1467         kNumberCaseType / kLowerCaseNumbersSelector: d
1468         kNumberSpacingType / kProportionalNumbersSelector: f
1469         kNumberSpacingType / kMonospacedNumbersSelector: g
1470         kFractionsType / kDiagonalFractionsSelector: i
1471         kFractionsType / kVerticalFractionsSelector: j
1472         kVerticalPositionType / kOrdinalsSelector: Q
1473         kTypographicExtrasType / kSlashedZeroOnSelector: k
1474         kLigaturesType / kHistoricalLigaturesOnSelector: K
1475         kCharacterShapeType / kJIS1978CharactersSelector: m
1476         kCharacterShapeType / kJIS1983CharactersSelector: n
1477         kCharacterShapeType / kJIS1990CharactersSelector: o
1478         kCharacterShapeType / kJIS2004CharactersSelector: p
1479         kCharacterShapeType / kSimplifiedCharactersSelector: q
1480         kCharacterShapeType / kTraditionalCharactersSelector: r
1481         kTextSpacingType / kMonospacedTextSelector: t
1482         kTextSpacingType / kProportionalTextSelector: u
1483         kRubyKanaType / kRubyKanaOnSelector: v
1484
1485         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1486         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1487         (CFFBuilder::moveTo):
1488         (CFFBuilder::lineTo):
1489         (GLYFBuilder::GLYFBuilder):
1490         (GLYFBuilder::takeResult):
1491         (GLYFBuilder::moveTo):
1492         (GLYFBuilder::lineTo):
1493         (GLYFBuilder::closePath):
1494         (GLYFBuilder::writePoint):
1495         (GLYFBuilder::append16):
1496         (generateBoxCharString):
1497         (generateCheckCharString):
1498         (generateXCharString):
1499         (itemForGlyph):
1500         (Generator::generate):
1501         (Generator::insertSelector):
1502         (Generator::insertFeature):
1503         (Generator::generateFeatureDescription):
1504         (Generator::appendCFFTable):
1505         (Generator::appendGLYFTable):
1506         (Generator::appendLOCATable):
1507         (Generator::appendFEATTable):
1508         (Generator::appendMetamorphosisChain):
1509         (Generator::appendMORXTable):
1510         (Generator::appendHEADTable):
1511         (Generator::appendHMTXTable):
1512         (Generator::appendNameSubtable):
1513         (Generator::append2ByteASCIIString):
1514         (Generator::appendNAMETable):
1515         (generateFont):
1516         (CFFBuilder::curveToCubic): Deleted.
1517         (charStringForGlyph): Deleted.
1518         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1519         * FontWithFeatures/FontWithFeatures/main.cpp:
1520         (constructFontWithTrueTypeFeature):
1521         (constructFontWithOpenTypeFeature):
1522         (drawText):
1523         (main):
1524         (drawTextWithFeature): Deleted.
1525
1526 2015-10-07  Commit Queue  <commit-queue@webkit.org>
1527
1528         Unreviewed, rolling out r190572, r190593, r190594, and
1529         r190639.
1530         https://bugs.webkit.org/show_bug.cgi?id=149897
1531
1532         Breaks Mavericks build (Requested by litherum on #webkit).
1533
1534         Reverted changesets:
1535
1536         "Allow WKRetainPtrs to be used as keys in hashing data
1537         structures"
1538         https://bugs.webkit.org/show_bug.cgi?id=149762
1539         http://trac.webkit.org/changeset/190572
1540
1541         "REGRESSION(189668?): http/tests/notifications/events.html
1542         flakily asserts or times out"
1543         https://bugs.webkit.org/show_bug.cgi?id=149218
1544         http://trac.webkit.org/changeset/190593
1545
1546         "Prospective Mavericks build fix."
1547         http://trac.webkit.org/changeset/190594
1548
1549         "Post-review cleanup after r190572."
1550         http://trac.webkit.org/changeset/190639
1551
1552 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1553
1554         [GTK] Add autocleanups
1555         https://bugs.webkit.org/show_bug.cgi?id=149588
1556
1557         Reviewed by Darin Adler.
1558
1559         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
1560         (AutocleanupsTest::create):
1561         (AutocleanupsTest::testWebProcessAutocleanups):
1562         (registerTests):
1563         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1564         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
1565         (testUIProcessAutocleanups):
1566         (testWebProcessAutocleanups):
1567         (beforeAll):
1568         (afterAll):
1569
1570 2015-10-06  Brian Burg  <bburg@apple.com>
1571
1572         Unreviewed, try to fix the iOS 8 build after r190368.
1573
1574         On older versions, IOHIDEventCreateForceEvent is not available.
1575
1576         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1577         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
1578
1579 2015-10-06  Keith Miller  <keith_miller@apple.com>
1580
1581         Add gmalloc option to run-javascriptcore-tests.
1582         https://bugs.webkit.org/show_bug.cgi?id=149858
1583
1584         Reviewed by Geoffrey Garen.
1585
1586         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
1587         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
1588
1589         * Scripts/run-javascriptcore-tests:
1590
1591 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
1592
1593         Post-review cleanup after r190572.
1594
1595         Unreviewed.
1596
1597         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
1598
1599 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
1600
1601         [Win] Unreviewed build correction.
1602
1603         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
1604         are soft-linked at runtime.
1605
1606 2015-10-06  Keith Miller  <keith_miller@apple.com>
1607
1608         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
1609         https://bugs.webkit.org/show_bug.cgi?id=149815
1610
1611         Reviewed by Filip Pizlo.
1612
1613         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
1614         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
1615         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
1616         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
1617         so should just use one test runner.
1618
1619         * Scripts/run-javascriptcore-tests:
1620         (runJSCStressTests):
1621         (runMozillaTests): Deleted.
1622         (defaultJsDriverArgsForMozillaTests): Deleted.
1623         * Scripts/run-jsc-stress-tests:
1624
1625 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
1626
1627         [GTK] Make update-webkitgtk-libs work behind firewall
1628
1629         update-webkitgtk-libs can work behind a firewall with changes to
1630         a few packages.  Where outbound git and active FTP connections
1631         fail, using http protocol succeeds.  Most packages are
1632         already accessed using http.
1633
1634         https://bugs.webkit.org/show_bug.cgi?id=148941
1635
1636         Reviewed by Martin Robinson.
1637
1638         Tools
1639         * gtk/jhbuild.modules:
1640             Replace git URLs with http.  Remove no longer used ftp repositories.
1641             Update argument for libxml2's autogen.sh script (--without-python
1642             is ignored; --with-python=no is correct).
1643         * jhbuild/jhbuild-wrapper:
1644             Instead of connecting to git://git.gnome.org/jhbuild, connect to
1645             http://git.gnome.org/browse/jhbuild.
1646
1647 2015-10-06  Daniel Bates  <dbates@webkit.org>
1648
1649         Enable XSLT when building WebKit for iOS using the public iOS SDK
1650         https://bugs.webkit.org/show_bug.cgi?id=149827
1651
1652         Reviewed by Alexey Proskuryakov.
1653
1654         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1655         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1656         run this script before building WebKit for iOS or the build will fail because one or more XSLT
1657         headers cannot be found.
1658
1659         * Scripts/configure-xcode-for-ios-development:
1660         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1661
1662 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1663
1664         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1665         https://bugs.webkit.org/show_bug.cgi?id=149218
1666
1667         Reviewed by Alexey Proskuryakov.
1668
1669         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1670         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1671         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1672         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1673         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1674         WebNotificationProvider must be updated to appropriately handle multiple
1675         WKNotificationManagerRefs in flight at the same time.
1676
1677         * WebKitTestRunner/WebNotificationProvider.cpp:
1678         (WTR::WebNotificationProvider::~WebNotificationProvider):
1679         (WTR::WebNotificationProvider::showWebNotification):
1680         (WTR::WebNotificationProvider::closeWebNotification):
1681         (WTR::WebNotificationProvider::addNotificationManager):
1682         (WTR::WebNotificationProvider::removeNotificationManager):
1683         (WTR::WebNotificationProvider::simulateWebNotificationClick):
1684         (WTR::WebNotificationProvider::reset):
1685         * WebKitTestRunner/WebNotificationProvider.h:
1686
1687 2015-10-05  Daniel Bates  <dabates@apple.com>
1688
1689         Disable Bitcode when building for iOS device
1690         https://bugs.webkit.org/show_bug.cgi?id=149818
1691
1692         Reviewed by Alexey Proskuryakov.
1693
1694         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1695         when building for iOS device.
1696
1697         * Scripts/webkitdirs.pm:
1698         (XcodeOptions):
1699
1700 2015-10-05  Daniel Bates  <dabates@apple.com>
1701
1702         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1703         https://bugs.webkit.org/show_bug.cgi?id=140828
1704         <rdar://problem/19520599>
1705
1706         Reviewed by Alexey Proskuryakov.
1707
1708         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1709         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1710         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1711         to build-webkit.
1712
1713         * Scripts/webkitdirs.pm:
1714         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1715         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1716         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1717         (hasIOSDevelopmentCertificate): Added.
1718
1719 2015-10-05  Daniel Bates  <dabates@apple.com>
1720
1721         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1722         https://bugs.webkit.org/show_bug.cgi?id=149766
1723
1724         Reviewed by Alexey Proskuryakov.
1725
1726         Create network storage testing session on iOS.
1727
1728         Currently we do not create a network storage testing session on iOS. A network storage testing session always
1729         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1730         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1731         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1732         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1733         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1734         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1735         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1736         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1737
1738         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1739         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1740         returns a non-null pointer to a cookie store.
1741
1742         * DumpRenderTree/mac/DumpRenderTree.mm:
1743         (prepareConsistentTestingEnvironment):
1744
1745 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1746
1747         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1748         available.
1749
1750         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1751         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1752
1753 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1754
1755         Allow WKRetainPtrs to be used as keys in hashing data structures
1756         https://bugs.webkit.org/show_bug.cgi?id=149762
1757
1758         Reviewed by Anders Carlsson.
1759
1760         * TestWebKitAPI/PlatformGTK.cmake:
1761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1762         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1763         (TestWebKitAPI::TEST):
1764
1765 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1766
1767         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1768         available, and tidy up the #ifdefs in the UIKitSPI header.
1769
1770         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1771         (-[HIDEventGenerator _sendHIDEvent:]):
1772         * WebKitTestRunner/ios/UIKitSPI.h:
1773
1774 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
1775
1776         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1777         https://bugs.webkit.org/show_bug.cgi?id=149792
1778
1779         Reviewed by Martin Robinson.
1780
1781         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1782         for WebKitTestRunner multiple times.
1783
1784 2015-10-04  Daniel Bates  <dabates@apple.com>
1785
1786         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1787         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1788
1789         For now, support calling build-layouttestrelay without --ios-simulator so long
1790         as we are building on a Mac.
1791
1792         * Scripts/build-layouttestrelay:
1793
1794 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1795
1796         Support Trac 1.0.x XML timeline link format
1797         https://bugs.webkit.org/show_bug.cgi?id=149786
1798
1799         Reviewed by Lucas Forschler.
1800
1801         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1802         (Trac.prototype._convertCommitInfoElementToObject):
1803
1804 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1805
1806         Fix some errors on bot watcher's dashboard
1807         https://bugs.webkit.org/show_bug.cgi?id=149789
1808
1809         Reviewed by Lucas Forschler.
1810
1811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1812         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
1813         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
1814
1815 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1816
1817         Bot watcher's dashboard builders should turn yellow when svn fails
1818         https://bugs.webkit.org/show_bug.cgi?id=149791
1819
1820         Reviewed by Lucas Forschler.
1821
1822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1823         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
1824         (BuildbotBuilderQueueView.prototype.update):
1825
1826 2015-10-02  Daniel Bates  <dabates@apple.com>
1827
1828         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
1829         https://bugs.webkit.org/show_bug.cgi?id=149769
1830
1831         Reviewed by Alexey Proskuryakov.
1832
1833         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
1834         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
1835         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1836         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1837         (WebKitBuildbot):
1838         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1839         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
1840
1841 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1842
1843         REGRESSION(r190370): Speedometer spits out an extra console message
1844         https://bugs.webkit.org/show_bug.cgi?id=149720
1845
1846         Unreviewed. Temporarily ignore the console error message.
1847
1848         * Scripts/webkitpy/performance_tests/perftest.py:
1849         (PerfTest._filter_output):
1850
1851 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1852
1853         Provide "--no-ninja" option to avoid using Ninja
1854         https://bugs.webkit.org/show_bug.cgi?id=149757
1855
1856         Reviewed by Alex Christensen.
1857
1858         Add a new command line argument understood by webkitdirs.pm so
1859         that we can conditionally avoid using Ninja. This is an
1860         'opt-out' argument, so no existing Ninja users should be affected.
1861         
1862         * Scripts/webkitdirs.pm:
1863         (canUseNinja): Check for option and block ninja if present.
1864
1865 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
1866
1867         Flakiness dashboard should support OS X El Capitan
1868         https://bugs.webkit.org/show_bug.cgi?id=149648
1869
1870         Reviewed by Alexey Proskuryakov.
1871
1872         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
1873
1874 2015-10-02  Daniel Bates  <dabates@apple.com>
1875
1876         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
1877         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1878
1879         For now, pass --ios-simulator.
1880
1881         * Scripts/webkitpy/port/ios.py:
1882         (IOSSimulatorPort._build_relay):
1883
1884 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
1885
1886         Remove a "nullable" that breaks the iOS 8 build.
1887
1888         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1889         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
1890
1891 2015-10-02  Daniel Bates  <dabates@apple.com>
1892
1893         LayoutTestRelay is not built and archived when building for iOS Simulator
1894         https://bugs.webkit.org/show_bug.cgi?id=149753
1895
1896         Reviewed by Alexey Proskuryakov and Andy Estes.
1897
1898         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
1899         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
1900         product archive when building for iOS Simulator, respectively.
1901
1902         * BuildSlaveSupport/built-product-archive:
1903         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
1904         differentiate between iOS device and iOS Simulator platforms.
1905         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
1906         from determineWebKitBuildDirectories() into this function so that it can be used by both
1907         determineWebKitBuildDirectories() and archiveBuiltProduct().
1908         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
1909         webkitBuildDirectoryForConfigurationAndPlatform().
1910         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
1911         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
1912         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
1913         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
1914         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
1915         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
1916         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
1917         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
1918         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
1919         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
1920         * Scripts/build-layouttestrelay:
1921             - Remove unnecessary include of Perl module POSIX.
1922             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
1923         * Scripts/build-webkit:
1924             - Invoke script build-layouttestrelay when building for iOS Simulator.
1925
1926 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1927
1928         [Win] Unreviewed test fix.
1929
1930         You cannot run 'run-webkit-tests' from the command line because it does not know
1931         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
1932         because they explicitly set use the 'root' argument to provide the full path to
1933         the test binaries.
1934
1935         * Scripts/webkitpy/port/win.py:
1936         (WinPort._build_path): Added.
1937
1938 2015-10-02  Alex Christensen  <achristensen@webkit.org>
1939
1940         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
1941         https://bugs.webkit.org/show_bug.cgi?id=149430
1942         rdar://problem/22742222
1943
1944         Reviewed by Geoffrey Garen.
1945
1946         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1947         (WTR::TestController::cocoaResetStateToConsistentValues):
1948         * WebKitTestRunner/mac/TestControllerMac.mm:
1949         (WTR::TestController::platformConfigureViewForTest):
1950         Test what happens when you disable content blockers from the SPI.
1951
1952 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1953
1954         [Win] Unreviewed build fix for run-api-tests
1955
1956         * Scripts/run-api-tests:
1957         (testToolPaths): Windows run needs to specify the binary path.
1958
1959 2015-10-01  Daniel Bates  <dabates@apple.com>
1960
1961         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
1962         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1963
1964         Following r190424 we can now rely on webkit-build-directory to return the path to
1965         the correct configuration-specific build directory on Windows.
1966
1967         * BuildSlaveSupport/built-product-archive:
1968         (archiveBuiltProduct):
1969
1970 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1971
1972         [Win] Unreviewed build fix.
1973
1974         * Scripts/webkitdirs.pm:
1975         (setupAppleWinEnv): Use 64-bit build tools if available
1976
1977 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1978
1979         [Win] Fix TestWebKitAPI build under CMake.
1980
1981         Reviewed by Alex Christensen.
1982
1983         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
1984         for Psapi.lib.
1985
1986 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1987
1988         [Win] Fix behavior of webkit-build-directory script
1989         https://bugs.webkit.org/show_bug.cgi?id=149718
1990
1991         Reviewed by Alex Christensen.
1992
1993         * Scripts/webkitdirs.pm:
1994         (determineConfigurationProductDir): Do not include the binary
1995         sub-directory in the configuration product directory output.
1996         (jscProductDir): Append correct binary path for Windows build.
1997         (setPathForRunningWebKitApp): Include properly binary subdirectories.
1998         (runSafari): Update for revised productDir behavior.
1999         (runMiniBrowser): Ditto.
2000
2001 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
2002
2003         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
2004         use iOS SDK, like with all the others.
2005
2006         * Scripts/build-webkit:
2007
2008 2015-10-01  Daniel Bates  <dabates@apple.com>
2009
2010         Attempt to fix the iOS 9 Simulator testers
2011
2012         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
2013         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
2014         LayoutTestRelay when building for iOS Simulator.
2015
2016         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2017         * Scripts/build-webkit:
2018
2019 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2020
2021         [GTK] Websites with invalid auth header keep loading forever
2022         https://bugs.webkit.org/show_bug.cgi?id=149710
2023
2024         Reviewed by Martin Robinson.
2025
2026         Add test case to check that we can authenticate sites with an
2027         empty realm.
2028
2029         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2030         (testWebViewAuthenticationEmptyRealm):
2031         (serverCallback):
2032         (beforeAll):
2033
2034 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
2035
2036         [Mac] Make run-api-tests work with System Integrity Protection
2037         https://bugs.webkit.org/show_bug.cgi?id=149711
2038         rdar://problem/22928202
2039
2040         Reviewed by Dan Bernstein.
2041
2042         * Scripts/run-api-tests:
2043         (runTest):
2044         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
2045
2046 2015-10-01  Daniel Bates  <dabates@apple.com>
2047
2048         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
2049         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2050
2051         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
2052         For now, use the path to the top-level WebKit build directory instead of using the configuration-
2053         specific build directory.
2054
2055         * BuildSlaveSupport/built-product-archive:
2056         (archiveBuiltProduct):
2057
2058 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2059
2060         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
2061         https://bugs.webkit.org/show_bug.cgi?id=145837
2062
2063         Reviewed by Philippe Normand.
2064
2065         * efl/jhbuild.modules:
2066         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
2067         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
2068
2069 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2070
2071         Unreviewed. Fix the iOS build after r190407.
2072
2073         * WebKitTestRunner/ios/IOKitSPI.h:
2074
2075 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2076
2077         Implement keyboard event sending for iOS in WebKitTestRunner
2078         https://bugs.webkit.org/show_bug.cgi?id=149676
2079
2080         Reviewed by Simon Fraser.
2081
2082         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
2083         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
2084         allows us to run code when the keyboard is shown or hidden.
2085
2086         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
2087         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2088         (WTR::UIScriptController::setDidShowKeyboardCallback):
2089         (WTR::UIScriptController::didShowKeyboardCallback):
2090         (WTR::UIScriptController::setDidHideKeyboardCallback):
2091         (WTR::UIScriptController::didHideKeyboardCallback):
2092         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
2093         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
2094         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
2095         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2096         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2097         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2098         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
2099                 the notifications that the keyboard has been raised or lowered.
2100         (-[TestRunnerWKWebView _keyboardDidShow:]):
2101         (-[TestRunnerWKWebView _keyboardDidHide:]):
2102         * WebKitTestRunner/ios/HIDEventGenerator.h:
2103         * WebKitTestRunner/ios/HIDEventGenerator.m:
2104         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
2105         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
2106         (hidUsageCodeForCharacter): Ditto.
2107         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
2108                 a keyDown event in WebKit.
2109         * WebKitTestRunner/ios/IOKitSPI.h:
2110         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2111
2112 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2113
2114         Unreviewed, rolling out r190399.
2115
2116         Tests are still failing even after r190362
2117
2118         Reverted changeset:
2119
2120         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
2121         http://trac.webkit.org/changeset/190399
2122
2123 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2124
2125         [jhbuild] switch to new upstream usrsctp library
2126         https://bugs.webkit.org/show_bug.cgi?id=149494
2127
2128         Reviewed by Philippe Normand.
2129
2130         * efl/jhbuild.modules:
2131         * gtk/jhbuild.modules:
2132
2133 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2134
2135         Unreviewed. Unskip GTK+ user media unit tests after r190362.
2136
2137         They should pass now.
2138
2139         * Scripts/run-gtk-tests:
2140         (TestRunner):
2141
2142 2015-09-30  Daniel Bates  <dabates@apple.com>
2143
2144         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2145         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2146
2147         * BuildSlaveSupport/built-product-archive:
2148         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
2149         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
2150
2151 2015-09-30  Daniel Bates  <dabates@apple.com>
2152
2153         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2154         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2155
2156         Actually, we need to pass --configuration to script webkit-build-directory to have
2157         it return the path to the configuration-specific build directory.
2158
2159         * BuildSlaveSupport/built-product-archive:
2160         (determineWebKitBuildDirectories):
2161
2162 2015-09-30  Daniel Bates  <dabates@apple.com>
2163
2164         built-product-archive archives incorrect build directory for iOS port
2165         https://bugs.webkit.org/show_bug.cgi?id=149695
2166
2167         Reviewed by Darin Adler.
2168
2169         Fixes an issue where the script built-product-archive archives a non-existent
2170         build directory for the iOS port. Without loss of generality, the script assumes
2171         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
2172         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
2173
2174         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
2175         to determine the top-level build directory and computes the configuration-specific
2176         build directory to be the concatenation of the the top-level build directory and
2177         the configuration (e.g. Release). This is incorrect. Instead we should call
2178         webkit-build-directory omitting the flag --top-level to compute the path to the
2179         configuration-specific build directory.
2180
2181         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
2182         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
2183         its purpose and added global variable _configurationBuildDirectory to store the path
2184         to the configuration-specific build directory. Ensure that we have a non-empty string
2185         for both the top-level and configuration-specific build directories.
2186         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
2187         Compute the configuration-specific build directory and store it in the global variable
2188         _configurationBuildDirectory.
2189         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
2190         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
2191         as needed.
2192         (determineWebKitBuildDirectory): Deleted.
2193
2194 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
2195
2196         [EFL] css3/device-adapt/* tests failed after r190335.
2197         https://bugs.webkit.org/show_bug.cgi?id=149655
2198
2199         Reviewed by Simon Fraser.
2200
2201         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2202         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
2203
2204         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2205         (WTR::shouldUseFixedLayout):
2206
2207 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
2208
2209         Extend JetStream timeout for slow devices.
2210
2211         Reviewed by Chris Dumez.
2212
2213         Extend JetStream timeout to 20 minutes.
2214
2215         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2216
2217 2015-09-30  Daniel Bates  <dabates@apple.com>
2218
2219         Rename iOS builders/testers to include version
2220         https://bugs.webkit.org/show_bug.cgi?id=149685
2221
2222         Reviewed by Simon Fraser.
2223
2224         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
2225         make it clear to a reader the version of iOS these builders/testers are using.
2226
2227         * BuildSlaveSupport/build.webkit.org-config/config.json:
2228         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2229
2230 2015-09-30  Daniel Bates  <dabates@apple.com>
2231
2232         Add iOS criterion for triggering a build
2233         https://bugs.webkit.org/show_bug.cgi?id=149679
2234
2235         Rubber-stamped by Alexey Proskuryakov.
2236
2237         First pass at defining criterion for triggering an iOS build.
2238
2239         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2240         (_should_file_trigger_build):
2241         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2242         (ShouldBuildTest):
2243         (ShouldBuildTest.test_should_build):
2244
2245 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2246
2247         [iOS] Allow tests to generate user gestures for UI testing
2248         https://bugs.webkit.org/show_bug.cgi?id=149653
2249
2250         Reviewed by Tim Horton.
2251
2252         Expose functionality in UIScriptController to allow for testing single- and double-tap,
2253         and to listen for completion of scrolling and zooming in the WKWebView.
2254         
2255         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
2256         which hides the complexity of creating these events. Event dispatch is asynchronous.
2257         We detect when the last event has been handled by dispatching a vendor-specific event,
2258         which is detected via -_handleHIDEvent: in our UIApplication subclass.
2259         
2260         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
2261         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
2262         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
2263         single and double taps.
2264         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2265         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
2266         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
2267         (UIScriptContext::unregisterCallback):
2268         (UIScriptContext::callbackWithID):
2269         (UIScriptContext::fireCallback):
2270         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
2271         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2272         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
2273         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
2274         (WTR::UIScriptController::setDidEndZoomingCallback):
2275         (WTR::UIScriptController::didEndZoomingCallback):
2276         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
2277         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
2278         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2279         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2280         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2281         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2282         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
2283         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2284         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
2285         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
2286         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
2287         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
2288         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2289         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
2290         (simpleDragCurve):
2291         (calculateNextLocation):
2292         (delayBetweenMove):
2293         (+[HIDEventGenerator sharedHIDEventGenerator]):
2294         (+[HIDEventGenerator nextEventCallbackID]):
2295         (-[HIDEventGenerator init]):
2296         (-[HIDEventGenerator _createIOHIDEventType:]):
2297         (-[HIDEventGenerator _sendHIDEvent:]):
2298         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2299         (-[HIDEventGenerator _updateTouchPoints:count:]):
2300         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
2301         (-[HIDEventGenerator touchDown:touchCount:]):
2302         (-[HIDEventGenerator touchDown:]):
2303         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
2304         (-[HIDEventGenerator liftUp:touchCount:]):
2305         (-[HIDEventGenerator liftUp:]):
2306         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
2307         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2308         (-[HIDEventGenerator tap:completionBlock:]):
2309         (-[HIDEventGenerator doubleTap:completionBlock:]):
2310         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
2311         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2312         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
2313         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
2314         (-[HIDEventGenerator markerEventReceived:]):
2315         * WebKitTestRunner/ios/IOKitSPI.h: Added.
2316         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2317         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2318         (WTR::globalToContentCoordinates):
2319         (WTR::UIScriptController::singleTapAtPoint):
2320         (WTR::UIScriptController::doubleTapAtPoint):
2321         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2322         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2323         * WebKitTestRunner/ios/mainIOS.mm:
2324         (-[WebKitTestRunnerApp _handleHIDEvent:]):
2325
2326 2015-09-30  Dana Burkart  <dburkart@apple.com>
2327
2328         git-add-reviewer should trim trailing spaces/newlines
2329         https://bugs.webkit.org/show_bug.cgi?id=149513
2330
2331         Reviewed by Darin Adler.
2332
2333         * Scripts/git-add-reviewer:
2334         (nonInteractive):
2335
2336 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
2337
2338         REGRESSION(r190262): User media unit test failures after r190262
2339         https://bugs.webkit.org/show_bug.cgi?id=149580
2340
2341         Reviewed by Darin Adler.
2342
2343         * WebKitTestRunner/TestController.cpp:
2344         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
2345           order to WKUserMediaPermissionRequestAllow.
2346
2347 2015-09-30  Daniel Bates  <dabates@apple.com>
2348
2349         Add iOS builders and testers
2350         https://bugs.webkit.org/show_bug.cgi?id=149549
2351
2352         Reviewed by Alexey Proskuryakov.
2353
2354         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
2355         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
2356
2357         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
2358         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
2359
2360 2015-09-30  Timothy Hatcher  <timothy@apple.com>
2361
2362         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
2363         https://bugs.webkit.org/show_bug.cgi?id=149674
2364
2365         Reviewed by Lucas Forschler.
2366
2367         * WebKitLauncher/WebKitLauncher.entitlements: Added.
2368         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2369
2370 2015-09-30  Jason Marcell  <jmarcell@apple.com>
2371
2372         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
2373         have an associated trac instance.
2374         https://bugs.webkit.org/show_bug.cgi?id=149673
2375
2376         Reviewed by Alexey Proskuryakov.
2377
2378         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2379         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
2380         have an associated trac instance.
2381
2382 2015-09-30  Daniel Bates  <dabates@apple.com>
2383
2384         Prioritize testing latest build request on iOS test bots
2385         https://bugs.webkit.org/show_bug.cgi?id=149669
2386
2387         Reviewed by Darin Adler.
2388
2389         We should prioritize testing of the latest build request on the iOS test bots
2390         as we do for Mac and Windows test bots.
2391
2392         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2393         (loadBuilderConfig):
2394
2395 2015-09-30  Daniel Bates  <dabates@apple.com>
2396
2397         Add buildbot category for iOS builders and testers
2398         https://bugs.webkit.org/show_bug.cgi?id=149667
2399
2400         Reviewed by Darin Adler.
2401
2402         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
2403         for iOS to the build.webkit.org home page.
2404
2405         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2406         (loadBuilderConfig):
2407         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2408
2409 2015-09-30  Daniel Bates  <dabates@apple.com>
2410
2411         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2412         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2413
2414         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
2415         in <http://trac.webkit.org/changeset/190351>.
2416
2417         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2418         (CompileWebKit.start):
2419
2420 2015-09-30  Daniel Bates  <dabates@apple.com>
2421
2422         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2423         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2424
2425         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
2426         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
2427
2428         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2429         (CompileWebKit.start):
2430
2431 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2432
2433         bot210 was configured for a queue instead of bot126.
2434         
2435         Unreviewed config.json fix.
2436         
2437         * BuildSlaveSupport/build.webkit.org-config/config.json:
2438
2439 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2440
2441         Bring El Capitan buildbot infrastructure online.
2442         https://bugs.webkit.org/show_bug.cgi?id=149605
2443         
2444         Reviewed by Darin Adler.
2445
2446         * BuildSlaveSupport/build.webkit.org-config/config.json:
2447
2448 2015-09-30  Tomas Popela  <tpopela@redhat.com>
2449
2450         [GTK] Deprecation warnings in DOMNodeTest
2451         https://bugs.webkit.org/show_bug.cgi?id=149663
2452
2453         After the webkit_dom_document_get_elements_by_tag_name deprecation we
2454         need to update the tests to use webkit_dom_document_query_selector_all
2455         to avoid compilation warnings.
2456
2457         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
2458         (the suggested replacement for the deprecated function).
2459
2460         Reviewed by Carlos Garcia Campos.
2461
2462         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2463         (WebKitDOMNodeTest::testTagNamesNodeList):
2464         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2465         (registerTests):
2466         (WebKitDOMNodeTest::testTagNames): Deleted.
2467         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2468         (prepareDOMForTagNamesTests):
2469         (testWebKitDOMNodeTagNamesNodeList):
2470         (testWebKitDOMNodeTagNamesHTMLCollection):
2471         (beforeAll):
2472         (testWebKitDOMNodeTagNames): Deleted.
2473
2474 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2475
2476         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
2477         https://bugs.webkit.org/show_bug.cgi?id=149650
2478
2479         Reviewed by Tim Horton.
2480         
2481         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
2482         looks at the file path, and not the custom options that come from file comments.
2483         
2484         Fix by computing TestOptions before making the TestInvocation, and setting them
2485         as const TestInvocation data. This meant changing various call sites to take
2486         the std::string pathOrURL, rather than the TestInvocation itself.
2487         
2488         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
2489
2490         * WebKitTestRunner/CMakeLists.txt:
2491         * WebKitTestRunner/TestController.cpp:
2492         (WTR::TestController::ensureViewSupportsOptionsForTest):
2493         (WTR::testPath):
2494         (WTR::createTestURL):
2495         (WTR::updateTestOptionsFromTestHeader):
2496         (WTR::TestController::testOptionsForTest):
2497         (WTR::TestController::updateWebViewSizeForTest):
2498         (WTR::TestController::updateWindowScaleForTest):
2499         (WTR::TestController::runTest):
2500         * WebKitTestRunner/TestController.h:
2501         * WebKitTestRunner/TestInvocation.cpp:
2502         (WTR::TestInvocation::TestInvocation):
2503         (WTR::TestInvocation::invoke):
2504         (WTR::createWKURL): Deleted.
2505         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
2506         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
2507         * WebKitTestRunner/TestInvocation.h:
2508         (WTR::TestInvocation::options):
2509         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2510         (WTR::pathContains):
2511         (WTR::shouldMakeViewportFlexible):
2512         (WTR::shouldUseFixedLayout):
2513         (WTR::isSVGTestPath):
2514         (WTR::isHiDPITestPath):
2515         (WTR::TestOptions::TestOptions):
2516         * WebKitTestRunner/TestOptions.h:
2517         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2518         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2519         (WTR::pathContains):
2520         (WTR::shouldUseFixedLayout):
2521         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2522         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2523         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2524         * WebKitTestRunner/ios/TestControllerIOS.mm:
2525         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2526         * WebKitTestRunner/mac/TestControllerMac.mm:
2527         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2528
2529 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
2530
2531         Flakiness dashboard should support OS X El Capitan
2532         https://bugs.webkit.org/show_bug.cgi?id=149648
2533
2534         Reviewed by Alexey Proskuryakov.
2535
2536         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
2537         difference between new appscale and old Google App Engine implementation.
2538         * TestResultServer/app.yaml: Same.
2539         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
2540
2541 2015-09-29  Daniel Bates  <dabates@apple.com>
2542
2543         configure-xcode-for-ios-development does not work with Xcode 7
2544         https://bugs.webkit.org/show_bug.cgi?id=149640
2545
2546         Reviewed by Alexey Proskuryakov.
2547
2548         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
2549         because it cannot find the Xcode specification files for iOS simulator and device. These
2550         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
2551         relevant definitions to the Xcode 7 specification files directly as opposed to creating
2552         new specification files with the added definitions (as we did in older versions of Xcode)
2553         in order for Xcode 7 to honor these definitions.
2554
2555         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
2556         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
2557         (updateXcode7SpecificationFile): Added.
2558         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
2559         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
2560         appropriate success message.
2561         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
2562         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
2563         (createXcodeSpecificationFromSpecificationAndId): Deleted.
2564
2565 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2566
2567         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
2568         https://bugs.webkit.org/show_bug.cgi?id=149639
2569
2570         Reviewed by Alex Christensen.
2571
2572         * Scripts/VCSUtils.pm:
2573         (exitStatus): Use 'isWindows()' method.
2574         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
2575         an error. This method could probably just go away.
2576         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
2577         always changing to Unix style. 
2578         (unixPath): Added. Needed so Windows can always show a Unix path in the
2579         ChangeLog file.
2580         (changeLogName): Work around the fact that 'getpwuid' is not available on
2581         a pure Windows build of Perl.
2582         * Scripts/prepare-ChangeLog:
2583         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
2584         path on Windows.
2585         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
2586         support using arrays for 'open' arguments.
2587         (resolveChangeLogsPath): Ditto.
2588         (resolveConflictedChangeLogs): Use new helper functions.
2589         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
2590         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
2591         quotes. Unix systems are happy either way.
2592         (statusCommand): Ditto.
2593         * Scripts/webkitdirs.pm:
2594         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
2595
2596 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2597
2598         [Win] Unreviewed 64-bit build fix after switch to CMake.
2599
2600         * Scripts/webkitdirs.pm:
2601         (determineIsWin64FromArchitecture): Added.
2602
2603 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2604
2605         printing does not use minimum page zoom factor
2606         https://bugs.webkit.org/show_bug.cgi?id=108507
2607
2608         Reviewed by Darin Adler.
2609
2610         WebKitTestRunner always takes the snapshots from the UI process
2611         (expect for IOS), so in the case of printing, the layout in the
2612         web view is not the expected one. When printing, we need to take
2613         the snapshot in the web process and ensure it's rendered with a
2614         PrintContext.
2615
2616         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2617         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2618         kWKSnapshotOptionsPrinting option to
2619         WKBundlePageCreateSnapshotWithOptions() when printing.
2620
2621 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2622
2623         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
2624         https://bugs.webkit.org/show_bug.cgi?id=149595
2625
2626         Reviewed by Tim Horton.
2627
2628         All ports except IOS implement
2629         PlatformWebView::windowSnapshotImage() to generate the snapshot
2630         for the pixel tests in the UI process. But we are still generating
2631         a snapshot for pixel tests in the Web process too, that is passed
2632         to the UI process but ignored.
2633         Whether a pixel result is needed or not, is only known by the web
2634         process depending on whether the test called dumpAsText with
2635         dumpPixels == true or not. Since the pixels are now dump in the UI
2636         process, we need to pass that information to the UI process when
2637         the test is done. For that we set a PixelResultIsPending bool
2638         parameter to the Done message, and we only add the PixelResult
2639         when UI process doesn't need to generate the pixels dump.
2640
2641         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2642         (WTR::InjectedBundle::didReceiveMessageToPage): Set
2643         m_pixelResultIsPending to false on reset.
2644         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2645         Done message, and set the PixelResult if m_pixelResultIsPending is false.
2646         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2647         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2648         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2649         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2650         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2651         port.
2652         * WebKitTestRunner/TestInvocation.cpp:
2653         (WTR::TestInvocation::dumpResults): Use either the pixel result
2654         from the web process or generate a pixel result from the web view
2655         if need it.
2656         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2657         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2658         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2659         is created by the caller now, but the CG implementation needs to
2660         know if it's a Web or UI process snapshot.
2661         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2662         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2663         cairo surface for the given image.
2664         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2665         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2666         CGContext for the given image.
2667
2668 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
2669
2670         Fix JS errors on dashboard metrics page
2671         https://bugs.webkit.org/show_bug.cgi?id=149608
2672
2673         Reviewed by Alexey Proskuryakov.
2674
2675         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2676         (initPlatformsByFamily): 
2677         (updateHiddenPlatforms):
2678         (parsePlatformFamily): Deleted.
2679         (updateToggleButtons): Deleted.
2680         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2681         (updateHiddenPlatforms): Added to remove errors.
2682         (initPlatformsByFamily): Added to remove errors.
2683         (unhiddenQueues): Updated to use Settings.
2684         (documentReady): Added logic to add toggle buttons to the settings menu.
2685         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2686         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2687         MetricsMain.js to Settings.
2688         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2689         MetricsMain.js to Settings.
2690         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2691         (QueueView.prototype._updateHiddenState): Updated to use Settings.
2692
2693 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
2694
2695         Appscale query fails because of missing index
2696         https://bugs.webkit.org/show_bug.cgi?id=149609
2697
2698         Reviewed by Darin Adler.
2699
2700         * QueueStatusServer/index.yaml: Added the required index.
2701
2702 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2703
2704         [Win] Fix the 64-bit build after switch to cmake.
2705
2706         Reviewed by Alex Christensen.
2707
2708         * Scripts/webkitdirs.pm:
2709         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2710         run a 64-bit build.
2711
2712 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2713
2714         [Win] Allow Windows to run test-webkitpy without Cygwin
2715         https://bugs.webkit.org/show_bug.cgi?id=149602
2716
2717         Reviewed by Alex Christensen.
2718
2719         These changes mostly shift from hard-coded paths using UNIX-style
2720         separators to Python's "os.path.join" syntax that uses the correct
2721         path separator for each platform.
2722         
2723         * Scripts/webkitpy/common/system/path.py:
2724         (cygpath): Don't pass paths through Cygpath on native Windows.
2725         * Scripts/webkitpy/port/win.py:
2726         (WinPort._path_to_apache): Use os.path.join.
2727         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2728         in 64-bit environments).
2729         * Scripts/webkitpy/style/checker.py: Use os.path.join.
2730         * Scripts/webkitpy/style/checker_unittest.py:
2731         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2732         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2733         (GlobalVariablesTest): Ditto.
2734         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2735         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2736         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2737         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2738         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2739         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2740         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2741         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2742         (StyleProcessor_CodeCoverageTest): Ditto.
2743         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2744         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2745         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2746         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2747         manual string concatenation of paths.
2748
2749 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2750
2751         Add bugzilla addresses of committers to contributors.json
2752         https://bugs.webkit.org/show_bug.cgi?id=149520
2753
2754         Reviewed by Darin Adler.
2755
2756         * Scripts/webkitpy/common/config/contributors.json:
2757
2758 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2759
2760         validate-committer-lists -b shouldn't need edituser privileges
2761         https://bugs.webkit.org/show_bug.cgi?id=149519
2762
2763         Reviewed by Darin Adler.
2764
2765         * Scripts/validate-committer-lists:
2766         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2767         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2768         (BugzillaQueries.is_invalid_bugzilla_email):
2769         (BugzillaQueries): Deleted.
2770         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2771
2772 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2773
2774         Unreviewed. Gardening: skip media stream tests failing after r190262.
2775
2776         * Scripts/run-gtk-tests:
2777         (TestRunner):
2778
2779 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2780
2781         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2782         https://bugs.webkit.org/show_bug.cgi?id=149571
2783
2784         Reviewed by Dan Bernstein.
2785
2786         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
2787
2788         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2789         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2790         * LayoutTestRelay/Configurations/Base.xcconfig:
2791         * MiniBrowser/Configurations/Base.xcconfig:
2792         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2793         * TestWebKitAPI/Configurations/Base.xcconfig:
2794         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2795         * WebEditingTester/Configurations/Base.xcconfig:
2796         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2797         * WebKitTestRunner/Configurations/Base.xcconfig:
2798         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2799         * WebKitTestRunner/iOS.xcconfig: Removed.
2800
2801 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
2802
2803         Clean up user media request internal API
2804         https://bugs.webkit.org/show_bug.cgi?id=149527
2805
2806         Reviewed by Tim Horton.
2807
2808         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2809         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
2810
2811         * WebKitTestRunner/TestController.cpp:
2812         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2813
2814 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
2815
2816         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
2817         https://bugs.webkit.org/show_bug.cgi?id=149577
2818
2819         Reviewed by Tim Horton.
2820         
2821         When calling testRunner.runUIScript() from a page load event, the script could run
2822         in the UI process before the current remote layer tree transaction had been handled
2823         there. This meant that runUIScript() could query state which was about to change.
2824         
2825         Fix by delaying the execution of the UI script until a layer tree transaction has
2826         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
2827
2828         * WebKitTestRunner/TestInvocation.cpp:
2829         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2830         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2831         * WebKitTestRunner/TestInvocation.h:
2832
2833 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2834
2835         [Mac] Media tests start to time out after a few days of bot uptime
2836         https://bugs.webkit.org/show_bug.cgi?id=149468
2837
2838         Reviewed by Darin Adler.
2839
2840         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
2841         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
2842         all temporary and cache files go to a custom location.
2843
2844         * Scripts/webkitpy/port/base.py:
2845         * Scripts/webkitpy/port/driver.py:
2846         * Scripts/webkitpy/port/mac.py:
2847         * Scripts/webkitpy/port/win.py:
2848         (WinPort._driver_tempdir_for_environment): Deleted unused function.
2849
2850 2015-09-25  Dan Bernstein  <mitz@apple.com>
2851
2852         Removed MiniBrowser.entitlements.
2853
2854         Rubber-stamped by Anders Carlsson.
2855
2856         The entitlements weren’t used anyway.
2857
2858         * MiniBrowser/MiniBrowser.entitlements: Removed.
2859         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2860
2861 2015-09-24  Daniel Bates  <dabates@apple.com>
2862
2863         Add WebKitSystemInterface for iOS 9.0
2864         https://bugs.webkit.org/show_bug.cgi?id=149550
2865
2866         Rubber-stamped by Alexey Proskuryakov.
2867
2868         * Scripts/copy-webkitlibraries-to-product-directory:
2869
2870 2015-09-24  Daniel Bates  <dabates@apple.com>
2871
2872         Support building for arbitrary architectures
2873         https://bugs.webkit.org/show_bug.cgi?id=149539
2874
2875         Reviewed by Alexey Proskuryakov.
2876
2877         Teach buildbot to pass the architectures associated with the builder to build-webkit
2878         when building on OS X and iOS. As a side effect of this change we now support building
2879         universal binaries when multiples architectures are specified.
2880
2881         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2882         (CompileWebKit.start):
2883
2884 2015-09-24  Daniel Bates  <dabates@apple.com>
2885
2886         Fix the build after <http://trac.webkit.org/changeset/190212>
2887         (http://trac.webkit.org/changeset/190212)
2888
2889         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
2890
2891         * BuildSlaveSupport/built-product-archive:
2892         (main):
2893
2894 2015-09-24  Daniel Bates  <dabates@apple.com>
2895
2896         Support running unit tests on iOS Simulator test bot
2897         https://bugs.webkit.org/show_bug.cgi?id=149536
2898
2899         Reviewed by Alexey Proskuryakov.
2900
2901         Implements support for running unit tests on a iOS test bot. At the time of writing,
2902         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
2903
2904         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2905         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
2906         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
2907
2908 2015-09-24  Daniel Bates  <dabates@apple.com>
2909
2910         Add support infrastructure for OpenSource iOS builders and testers
2911         https://bugs.webkit.org/show_bug.cgi?id=149534
2912
2913         Reviewed by Darin Adler.
2914
2915         Towards setting up OpenSource iOS build bots, teach buildbot and its support
2916         scripts about iOS.
2917
2918         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2919         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
2920         --ios-simulator or --device for a builder/tester whose full platform name begins with
2921         "ios-simulator" or "ios", respectively.
2922         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
2923         * BuildSlaveSupport/built-product-archive:
2924         (main): Pass the full platform name to determineWebKitBuildDirectory().
2925         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
2926         command line flag when building for iOS.
2927         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
2928         parameter fullPlatform. This parameter was originally added in r125066 to support the
2929         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
2930         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
2931         * BuildSlaveSupport/clean-build:
2932         (main): Call script webkit-build-directory with the appropriate command line flag when
2933         building for iOS.
2934         * BuildSlaveSupport/delete-stale-build-files:
2935         (main): Use the same logic for iOS as we do for Mac.
2936         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
2937         flag when building for iOS.
2938         * BuildSlaveSupport/test-result-archive:
2939         (archiveTestResults): Use the same logic for iOS as we do for Mac.
2940
2941 2015-09-24  Daniel Bates  <dabates@apple.com>
2942
2943         Remove Chromium-specific changes to script built-product-archive
2944         https://bugs.webkit.org/show_bug.cgi?id=149530
2945
2946         Rubber-stamped by Csaba Osztrogonác.
2947
2948         Reverts changes made in r113074 and r113067 to support Chromium testers. The
2949         Chromium code has long since been removed from the OpenSource WebKit Project.
2950
2951         * BuildSlaveSupport/built-product-archive:
2952         (createZipManually):
2953         (createZip):
2954         (archiveBuiltProduct):
2955
2956 2015-09-24  Dan Bernstein  <mitz@apple.com>
2957
2958         Build fix.
2959
2960         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2961
2962 2015-09-24  Mark Lam  <mark.lam@apple.com>
2963
2964         Unreviewed. Make Lucas Forschler a WebKit reviewer.
2965
2966         * Scripts/webkitpy/common/config/contributors.json:
2967
2968 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2969
2970         Unreviewed. Fix GObject DOM API breaks after r190120.
2971
2972         Bring back code removed in r169931 to handle documentation of
2973         deleted classes.
2974
2975         * gtk/webkitdom.py:
2976         (WebKitDOMDocGenerator):
2977         (WebKitDOMDocGenerator.write_deleted_classes):
2978         (WebKitDOMDocGenerator.generate):
2979         (write_deleted_classes):
2980         (WebKitDOMDocGeneratorSections._deleted_class):
2981         (WebKitDOMDocGeneratorSections._deleted_class.in):
2982         (WebKitDOMDocGeneratorSections.write_deleted_classes):
2983         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
2984
2985 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
2986
2987         [Cocoa] [Font Features] Implement font-variant-*
2988         https://bugs.webkit.org/show_bug.cgi?id=148413
2989
2990         Reviewed by Darin Adler.
2991
2992         Update test font to use "lnum" feature.
2993
2994         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2995         (Generator::appendGSUBTable):
2996
2997 2015-09-22  Andy Estes  <aestes@apple.com>
2998
2999         ContentFiltering.AllowDownloadAfterAddData is very flaky
3000         https://bugs.webkit.org/show_bug.cgi?id=148885
3001         <rdar://problem/22729563>
3002
3003         Reviewed by Alexey Proskuryakov.
3004
3005         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
3006         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
3007         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
3008
3009         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3010         (downloadTest):
3011
3012 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
3013
3014         Mavericks: Media tests start to time out after a few days of bot uptime
3015         https://bugs.webkit.org/show_bug.cgi?id=149468
3016
3017         Reviewed by Chris Dumez.
3018
3019         * Scripts/webkitpy/port/base.py:
3020         * Scripts/webkitpy/port/driver.py:
3021         * Scripts/webkitpy/port/mac.py:
3022
3023 2015-09-22  Nan Wang  <n_wang@apple.com>
3024
3025         Unreviewed, add myself to the committers list.
3026
3027         * Scripts/webkitpy/common/config/contributors.json:
3028
3029 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
3030
3031         Remove 'nullable' to fix older iOS builds.
3032
3033         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3034         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3035
3036 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
3037
3038         [Win] Show tiled drawing debug overlay on Windows
3039         https://bugs.webkit.org/show_bug.cgi?id=149426
3040
3041         Reviewed by Dean Jackson.
3042
3043         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
3044         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
3045         * MiniBrowser/win/Common.cpp:
3046         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
3047         flag if needed.
3048         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
3049
3050 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
3051
3052         [Win] Use command-line argument to launch in regular or High DPI mode.
3053         https://bugs.webkit.org/show_bug.cgi?id=149417
3054
3055         Reviewed by Dean Jackson.
3056
3057         * MiniBrowser/win/Common.cpp:
3058         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
3059         very start of execution, before the MiniBrowser.dll is loaded.
3060         * win/DLLLauncher/DLLLauncherMain.cpp:
3061         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
3062         present. On WinCairo, always use High DPI.
3063
3064 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3065
3066         32-bit Mac build fix attempt after r190065.
3067
3068         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3069
3070 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
3071
3072         [OS X] Update for Xcode 7.0 on Yosemite
3073         https://bugs.webkit.org/show_bug.cgi?id=149389
3074
3075         Reviewed by Dan Bernstein.
3076
3077         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3078         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3079         Removed unneeded declarations - conforming to a protocol is sufficient.
3080
3081         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3082         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3083         Changed the definitions to be compiled whenever the SDK requires it (so we will have
3084         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
3085
3086 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
3087
3088         Add the ability for tests to run script in the UI process in WebKitTestRunner
3089         https://bugs.webkit.org/show_bug.cgi?id=149356
3090
3091         Reviewed by Tim Horton.
3092
3093         This change adds testRunner.runUIScript(script, callback), which allows a test
3094         to execute script in a JSContext which runs in the UI process. That context
3095         has bindings exposed through the UIScriptController interface; currently one test
3096         function, and some iOS-specific functions are included. UIScriptController can be
3097         async with a callback, and runUIScript() itself is asynchronous. When the UI 
3098         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
3099         is a string passed back to the web process, and given to the runUIScript()
3100         callback function.
3101         
3102         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
3103
3104         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
3105         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
3106         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3107         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
3108         complete, call back into TestRunner.
3109         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3110         (WTR::nextUIScriptCallbackID):
3111         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
3112         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
3113         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3114         * WebKitTestRunner/PlatformWebView.h:
3115         * WebKitTestRunner/TestController.cpp:
3116         (WTR::updateTestOptionsFromTestHeader):
3117         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
3118         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
3119         * WebKitTestRunner/TestInvocation.cpp:
3120         (WTR::TestInvocation::shouldUseFixedLayout):
3121         (WTR::TestInvocation::shouldUseThreadedScrolling):
3122         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3123         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3124         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
3125         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
3126         * WebKitTestRunner/TestInvocation.h:
3127         * WebKitTestRunner/TestOptions.h:
3128         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3129         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3130         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3131         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
3132         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3133         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
3134         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3135         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
3136         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3137         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
3138         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
3139         (WTR::UIScriptController::doAsyncTask):
3140         (WTR::UIScriptController::zoomToScale):
3141         (WTR::UIScriptController::zoomScale):
3142         (WTR::UIScriptController::minimumZoomScale):
3143         (WTR::UIScriptController::maximumZoomScale):
3144         (WTR::UIScriptController::contentVisibleRect):
3145         * WebKitTestRunner/mac/EventSenderProxy.mm:
3146         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3147         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
3148         * WebKitTestRunner/mac/TestControllerMac.mm:
3149         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3150         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
3151         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3152         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
3153         (UIScriptContext::UIScriptContext):
3154         (UIScriptContext::~UIScriptContext):
3155         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
3156         asynchronous, call the callback.
3157         (UIScriptContext::nextTaskCallbackID):
3158         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
3159         that has a callback). Has to store the callbackID of the script, so code called from the completion
3160         callback knows which UI script invoked it.
3161         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
3162         (UIScriptContext::uiScriptComplete):
3163         (UIScriptContext::objectFromRect): Make a JS object from a rect.
3164         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3165         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
3166         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
3167         (WTR::UIScriptController::UIScriptController):
3168         (WTR::UIScriptController::makeWindowObject):
3169         (WTR::UIScriptController::wrapperClass):
3170         (WTR::UIScriptController::doAsyncTask):
3171         (WTR::UIScriptController::zoomToScale):
3172         (WTR::UIScriptController::zoomScale):
3173         (WTR::UIScriptController::minimumZoomScale):
3174         (WTR::UIScriptController::maximumZoomScale):
3175         (WTR::UIScriptController::contentVisibleRect):
3176         (WTR::UIScriptController::uiScriptComplete):
3177         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3178         (WTR::UIScriptController::create):
3179         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
3180
3181 2015-09-21  Tim Horton  <timothy_horton@apple.com>
3182
3183         Turn on threaded scrolling by default in the tests
3184         https://bugs.webkit.org/show_bug.cgi?id=149377
3185
3186         Reviewed by Simon Fraser.
3187
3188         * WebKitTestRunner/mac/TestControllerMac.mm:
3189         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3190         (WTR::shouldUseThreadedScrolling): Deleted.
3191         Turn on threaded scrolling by default.
3192
3193 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3194
3195         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
3196         https://bugs.webkit.org/show_bug.cgi?id=149252
3197
3198         Reviewed by Darin Adler.
3199
3200         In case of glib tests the test runner notifies about tests
3201         crashing, but for google tests we don't get any feedback, which
3202         means that in case of a test crashing we get a list of **PASS**
3203         messages and at the summary we are notified that the test suite
3204         has failed, but it's impossible to know which test cases have failed.
3205
3206         * Scripts/run-gtk-tests:
3207         (TestRunner._run_google_test): Add a **CRASH** message if test
3208         case crashed.
3209
3210 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3211
3212         WebKitTestRunner can leak user content script results between tests
3213         https://bugs.webkit.org/show_bug.cgi?id=149391
3214
3215         Reviewed by Sam Weinig.
3216
3217         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
3218         about:blank, and thus about:blank doesn't have unintended side effects.
3219
3220         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3221         (WTR::InjectedBundle::beginTesting):
3222         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3223         (WTR::InjectedBundlePage::resetAfterTest):
3224
3225 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3226
3227         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
3228         https://bugs.webkit.org/show_bug.cgi?id=149384
3229
3230         Reviewed by Chris Fleizach.
3231
3232         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3233         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
3234         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
3235         regardless of whether someone else holds a reference (we also call -stopListening in
3236         -dealloc).
3237
3238         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3239         (AccessibilityController::platformResetToConsistentState):
3240         (AccessibilityController::addNotificationListener):
3241         Ditto.
3242
3243 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3244
3245         Remove XHR_TIMEOUT compilation guard
3246         https://bugs.webkit.org/show_bug.cgi?id=149260
3247
3248         Reviewed by Benjamin Poulain.
3249
3250         * Scripts/webkitperl/FeatureList.pm:
3251
3252 2015-09-19  Dan Bernstein  <mitz@apple.com>
3253
3254         Attempted build fix.
3255
3256         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3257
3258 2015-09-18  Commit Queue  <commit-queue@webkit.org>
3259
3260         Unreviewed, rolling out r189908.
3261         https://bugs.webkit.org/show_bug.cgi?id=149368
3262
3263         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
3264
3265         Reverted changeset:
3266
3267         "printing does not use minimum page zoom factor"
3268         https://bugs.webkit.org/show_bug.cgi?id=108507
3269         http://trac.webkit.org/changeset/189908
3270
3271 2015-09-18  Andy Estes  <aestes@apple.com>
3272
3273         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
3274         https://bugs.webkit.org/show_bug.cgi?id=149360
3275
3276         Reviewed by Tim Horton.
3277
3278         Added an API test.
3279
3280         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3281         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
3282         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3283         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3284         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
3285         (TEST):
3286         * TestWebKitAPI/ios/pages.pages: Added.
3287
3288 2015-09-18  Nan Wang  <n_wang@apple.com>
3289
3290         AX: Implement ARIA 1.1 @aria-current on iOS
3291         https://bugs.webkit.org/show_bug.cgi?id=149297
3292
3293         Reviewed by Chris Fleizach.
3294
3295         Added support to test aria-current on iOS.
3296
3297         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3298         (AccessibilityUIElement::stringAttributeValue):
3299         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3300         (WTR::AccessibilityUIElement::stringAttributeValue):
3301
3302 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
3303
3304         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
3305         https://bugs.webkit.org/show_bug.cgi?id=149352
3306
3307         Reviewed by Simon Fraser.
3308
3309         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
3310         m_context can be null. This may indicate a bug in webkitpy too, but
3311         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
3312         wrong with opening and immediately closing it.
3313
3314 2015-09-18  Daniel Bates  <dabates@apple.com>
3315
3316         isGitSVNDirectory() returns true when Git is not installed
3317         https://bugs.webkit.org/show_bug.cgi?id=149351
3318
3319         Reviewed by Alexey Proskuryakov.
3320
3321         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
3322         Git is not installed on the machine.
3323
3324         * Scripts/VCSUtils.pm:
3325         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
3326         status code 0 (success).
3327
3328 2015-09-18  Alex Christensen  <achristensen@webkit.org>
3329
3330         Prevent build-webkit from building four times on Windows 
3331         https://bugs.webkit.org/show_bug.cgi?id=149336
3332
3333         Reviewed by Brent Fulgham.
3334
3335         * Scripts/build-webkit:
3336         Move the Windows code out of the for loop iterating over each subdirectory to be build.
3337         They're built all at once.
3338         * Scripts/webkitdirs.pm:
3339         (buildVisualStudioProject):
3340         (cmakeGeneratedBuildfile):
3341         Don't generate the Visual Studio solution if it already exists.
3342         It will run CMake again if necessary.
3343
3344 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3345
3346         [iOS WK2] WTR fails to set the key window in the UIKit sense
3347         https://bugs.webkit.org/show_bug.cgi?id=149325
3348
3349         Reviewed by Tim Horton.
3350
3351         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
3352         This causes UIKit to bypass code that actually sets the key window, resulting in
3353         [UIAppliation sharedApplication].keyWindow always being nil.
3354
3355         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
3356         -[WebKitTestRunnerWindow isKeyWindow] call super.
3357
3358         * WebKitTestRunner/PlatformWebView.h:
3359         (WTR::PlatformWebView::setWindowIsKey): Deleted.
3360         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3361         (WTR::PlatformWebView::setWindowIsKey):
3362         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3363         (WTR::PlatformWebView::setWindowIsKey):
3364         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3365         (-[WebKitTestRunnerWindow isKeyWindow]):
3366         (WTR::PlatformWebView::PlatformWebView):
3367         (WTR::PlatformWebView::~PlatformWebView):
3368         (WTR::PlatformWebView::setWindowIsKey):
3369         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3370         (WTR::PlatformWebView::setWindowIsKey):
3371
3372 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3373
3374         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
3375         https://bugs.webkit.org/show_bug.cgi?id=149321
3376
3377         Reviewed by Tim Horton.
3378         
3379         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
3380         enabled the "testing" viewport configuration, which disables page scaling.
3381         
3382         If we're running viewport tests, we want the normal web page configuration.
3383         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
3384         based on whether the test is in a "viewport" directory.
3385
3386         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3387         (WTR::InjectedBundle::beginTesting):
3388         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3389         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
3390         * WebKitTestRunner/TestInvocation.cpp:
3391         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3392         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3393         (WTR::TestInvocation::shouldMakeViewportFlexible):
3394         (WTR::TestInvocation::invoke):
3395         * WebKitTestRunner/TestInvocation.h:
3396         * WebKitTestRunner/ios/TestControllerIOS.mm:
3397         (WTR::TestController::platformConfigureViewForTest):
3398         (WTR::shouldMakeViewportFlexible): Deleted.
3399
3400 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3401
3402         Give iOS WebKitTestRunner a launch storyboard
3403         https://bugs.webkit.org/show_bug.cgi?id=149314
3404
3405         Reviewed by Dan Bates.
3406         
3407         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
3408         that it's been built for specific device configurations, and puts the window
3409         at the top of the screen. This simplifies coordinate conversions in a future patch.
3410
3411         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3412         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
3413         * WebKitTestRunner/ios/Launch.storyboard: Added.
3414
3415 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
3416
3417         Update licence in r189890
3418         https://bugs.webkit.org/show_bug.cgi?id=149306
3419
3420         Reviewed by Dean Jackson.
3421
3422         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3423         * FontWithFeatures/FontWithFeatures/FontCreator.h:
3424         * FontWithFeatures/FontWithFeatures/main.cpp:
3425
3426 2015-09-17  Mark Lam  <mark.lam@apple.com>
3427
3428         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
3429         https://bugs.webkit.org/show_bug.cgi?id=149285
3430
3431         Reviewed by Saam Barati.
3432
3433         Just need to add an option to pass --no-jit to run-jsc-stress-test.
3434
3435         * Scripts/run-javascriptcore-tests:
3436         (runJSCStressTests):
3437
3438 2015-09-17  Alex Christensen  <achristensen@webkit.org>
3439
3440         Switch AppleWin build to use CMake
3441         https://bugs.webkit.org/show_bug.cgi?id=149163
3442
3443         Reviewed by Brent Fulgham.
3444
3445         * Scripts/build-webkit:
3446         * Scripts/run-api-tests:
3447         (runTest):
3448         (listAllTests):
3449         (prepareEnvironmentForRunningTestTool):
3450         (testToolPaths):
3451         (testToolPath): Deleted.
3452         Run the API tests as separate executables on Windows.
3453         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3454         * Scripts/webkitdirs.pm:
3455         (checkRequiredSystemConfig):
3456         (jhbuildWrapperPrefixIfNeeded):
3457         (generateBuildSystemFromCMakeProject):
3458         Fix configuration quirks.
3459
3460 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
3461
3462         Added toggle options for hiding and showing certain platform families on the dashboard.
3463         https://bugs.webkit.org/show_bug.cgi?id=148403
3464
3465         Reviewed by David Kilzer.
3466
3467         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
3468         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
3469         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
3470         in lieu of an "all" button in the toggle menu.
3471
3472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3473         (parsePlatformFamily): Helper function to parse out a platform family.
3474         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
3475         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
3476         (updateToggleButtons): Updates the status of the toggle buttons.
3477         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
3478         (documentReady): Added creation of toggle buttons.
3479         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3480         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
3481         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
3482         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
3483         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
3484         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3485         (QueueView): Updated to use hiddenPlatformFamilies.
3486         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
3487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3488         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
3489         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
3490         (Settings.prototype.toggleHiddenPlatform): Deleted.
3491         (Settings.prototype.clearHiddenPlatforms): Deleted.
3492         (Settings.prototype.toggleShowPlatformFamily): Deleted.
3493         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3494         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
3495         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
3496         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
3497         (table.queue-grid tr.headers th):
3498         (div.settingsWrapper.hide):
3499         (div.settingsWrapper):
3500         (div.familyToggleWrapper):
3501         (div.platformFamilyToggleButton):
3502         (div.platformFamilyShowToggleButton:not(:last-child)):
3503         (div.familyShown):
3504         (div.accessibilityButton):
3505         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
3506         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
3507         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
3508         platformFamilyToggleButton and settingsWrapper class.
3509         (.accessibilityButton): Deleted.
3510
3511 2015-09-17  Tim Horton  <timothy_horton@apple.com>
3512
3513         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
3514         https://bugs.webkit.org/show_bug.cgi?id=148904
3515
3516         Reviewed by Myles Maxfield.
3517
3518         * WebKitTestRunner/TestController.cpp:
3519         (WTR::parseBooleanTestHeaderValue):
3520         (WTR::updateViewOptionsFromTestHeader):
3521         Check for the key "useThreadedScrolling".
3522         Add some code to check for "true" and "false" for boolean options.
3523
3524         (WTR::TestController::viewOptionsForTest):
3525         Apply the test's overrides last, even after the platform's.
3526
3527 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3528
3529         printing does not use minimum page zoom factor
3530         https://bugs.webkit.org/show_bug.cgi?id=108507
3531
3532         Reviewed by Darin Adler.
3533
3534         WebKitTestRunner always takes the snapshots from the UI process
3535         (expect for IOS), so in the case of printing, the layout in the
3536         web view is not the expected one. When printing, we need to take
3537         the snapshot in the web process and ensure it's rendered with a
3538         PrintContext.
3539
3540         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3541         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
3542         kWKSnapshotOptionsPrinting option to
3543         WKBundlePageCreateSnapshotWithOptions() when printing. When not
3544         printing, don't even create the snapshot, since it will be ignored
3545         by the UI process that always creates its own from the WebView (expect for IOS platform)
3546         * WebKitTestRunner/TestInvocation.cpp:
3547         (WTR::TestInvocation::dumpResults): Use always the snapshot image
3548         received from the web process if any when comparing pixel
3549         results. Now we only receive a snapshot from the web process in
3550         case of printing, or when platform is IOS. Otherwhise, generate
3551         the snapshot from the WebView as usual.
3552         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
3553         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
3554         is created by the caller now, but the CG implementation needs to
3555         know if it's a Web or UI process snapshot.
3556         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3557         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3558         cairo surface for the given image.
3559         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3560         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3561         CGContext for the given image.
3562
3563 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
3564
3565         Create a font which can be used for testing font features
3566         https://bugs.webkit.org/show_bug.cgi?id=149237
3567
3568         Reviewed by Simon Fraser.
3569
3570         This patch adds a new project in the Tools/ directory which generates a font which can
3571         be used for testing font features. This is a standalone project consisting of two files:
3572         1. A file which actually generates the byte vector representing the font. This file has
3573         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
3574         specific, and only relies on the C++ STL.
3575         2. A file with a main() which calls generateFont() and writes out the font, as well as
3576         uses the font to render some demonstration text into a .png file. This file is platform
3577         specific.
3578
3579         The font itself only supports the following characters:
3580         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
3581         However, the shape of these letters are either an X or a check mark.
3582
3583         The letter "A" always is a check mark.
3584         The letter "B" always is an X.
3585         Without any font features turned on, the rest of the letters are shown as X.
3586
3587         Each font feature has an letter associated with it. When the font feature is enabled,
3588         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
3589         as a check mark.
3590
3591         Here are the mappings of font features to letters:
3592         liga: C
3593         clig: D
3594         dlig: E
3595         hlig: F
3596         calt: G
3597         subs: H
3598         sups: I
3599         smcp: J
3600         c2sc: K
3601         pcap: L
3602         c2pc: M
3603         unic: N
3604         titl: O
3605         onum: P
3606         pnum: Q
3607         tnum: R
3608         frac: S