[GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
[WebKit-https.git] / Tools / ChangeLog
1 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
4         https://bugs.webkit.org/show_bug.cgi?id=115904
5
6         Reviewed by Martin Robinson.
7
8         * ImageDiff/gtk/ImageDiff.cpp:
9         (main):
10
11 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
12
13         Add my new address to contributors.json. (Unreviewed)
14
15         * Scripts/webkitpy/common/config/contributors.json:
16
17 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
18
19         Unreviewed. Move myself to the reviewers list.
20
21         * Scripts/webkitpy/common/config/contributors.json:
22
23 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
24
25         Unreviewed. Add my email to a few watchlists.
26
27         * Scripts/webkitpy/common/config/watchlist:
28
29 2013-05-10  Simon Pena  <simon.pena@samsung.com>
30
31         Unicode support missing from string representation of Contributors in committers.py
32         https://bugs.webkit.org/show_bug.cgi?id=115859
33
34         Reviewed by Darin Adler.
35
36         Contributors, in committers.py, provided a string representation in __str__ which
37         didn't support unicode characters, so printing a contributor would fail in that case.
38         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
39         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
40
41         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
42         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
43         representation.
44         (Contributor.__str__):
45         (Contributor):
46         (Contributor.__unicode__):
47         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
48         a contributor with unicode characters can be represented as a string.
49         (CommittersTest):
50         (CommittersTest.test_contributor_encoding):
51
52 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
53
54         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
55         https://bugs.webkit.org/show_bug.cgi?id=92371
56
57         Reviewed by Brent Fulgham.
58
59         Use JavaScriptThreading.cpp where the same functionality is
60         implemented too. This reduces the dependency on the pthread
61         library. Also replace assert() with WebKit ASSERT().
62
63         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
64         * DumpRenderTree/win/DumpRenderTree.cpp:
65         (dumpHistoryItem):
66         (dumpBackForwardList):
67         * DumpRenderTree/win/DumpRenderTree.vcproj:
68
69 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
70
71         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
72         https://bugs.webkit.org/show_bug.cgi?id=92505
73
74         Reviewed by Brent Fulgham.
75
76         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
77         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
78         (javaScriptThreadsMutex):
79         (javaScriptThreads):
80         (runJavaScriptThread):
81         (startJavaScriptThreads):
82         (stopJavaScriptThreads):
83         * DumpRenderTree/pthreads: Removed.
84         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
85
86 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
87
88         Unreviewed. Update Simon Pena email on his behalf.
89
90         * Scripts/webkitpy/common/config/contributors.json:
91
92 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
93
94         Add support for [NoInterfaceObject] Web IDL extended attribute
95         https://bugs.webkit.org/show_bug.cgi?id=115714
96
97         Reviewed by Kentaro Hara.
98
99         Update BindingsTests.generate_supplemental_dependency() to pass an
100         additional windowConstructorsFile argument to preprocess-idls.pl.
101
102         * Scripts/webkitpy/bindings/main.py:
103         (BindingsTests.generate_supplemental_dependency):
104         (BindingsTests.main):
105
106 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
107
108         [GTK][AC] Buildfix after r149694
109         https://bugs.webkit.org/show_bug.cgi?id=115797
110
111         Reviewed by Gustavo Noronha Silva.
112
113         Add CLUTTER_LIBS for linking TestWebCore.
114
115         * TestWebKitAPI/GNUmakefile.am:
116
117 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
118
119         [EFL] Remove unnecessary pkgs in EFL jhbuild
120         https://bugs.webkit.org/show_bug.cgi?id=114908
121
122         Reviewed by Laszlo Gombos.
123
124         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
125         handle them using jhbuild. We can reduce build time when using --update-efl.
126
127         * efl/jhbuild.modules:
128
129 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
130
131         [EFL] Disable SHADOW DOM feature in FeatureList.pm
132         https://bugs.webkit.org/show_bug.cgi?id=115834
133
134         Reviewed by Gyuyoung Kim.
135
136         * Scripts/webkitperl/FeatureList.pm:
137
138 2013-05-08  Lucas Forschler  <lforschler@apple.com>
139
140         Add Scheduler for Mac MtnLion 32bit Release builder.
141         
142         Unreviewed.
143         
144         * BuildSlaveSupport/build.webkit.org-config/config.json:
145
146 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
147
148         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
149         https://bugs.webkit.org/show_bug.cgi?id=115808
150
151         Reviewed by Darin Adler.
152
153         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
154         was left outdated after r127191, when the m_string member was changed
155         from UString to String. This patch calls the right pretty printer for it.
156
157         * gdb/webkit.py:
158         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
159         WTFImplPrettyPrinter.
160
161 2013-05-08  Andy Estes  <aestes@apple.com>
162
163         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
164         https://bugs.webkit.org/show_bug.cgi?id=115790
165
166         Reviewed by Alexey Proskuryakov.
167
168         Added two API tests:
169
170         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
171         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
172
173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
174         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
175         (TestWebKitAPI):
176         (TestWebKitAPI::TEST):
177         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
178         (TestWebKitAPI):
179         (TestWebKitAPI::decidePolicyForNavigationAction):
180         (CustomProtocolInvalidSchemeTest):
181         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
182
183 2013-05-08  Lucas Forschler  <lforschler@apple.com>
184
185         Teach buildbot how to compile 32-bit on Mac.
186
187         Reviewed by Ryosuke Niwa.
188
189         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
190         (CompileWebKit.start):
191         (ExtractTestResultsAndLeaks):
192
193 2013-05-08  Eli Fidler  <efidler@blackberry.com>
194
195         [BlackBerry] Fix usage of BlackBerry::Platform::String
196         https://bugs.webkit.org/show_bug.cgi?id=115781
197
198         Reviewed by Rob Buis.
199
200         BlackBerry PRs 304193 and 327181
201         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
202
203         We currently have a problem where we're passing UTF-8 encoded data into
204         the char* constructors of BlackBerry::Platform::String. This means the string
205         thinks its data is not UTF-8.
206
207         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
208         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
209         (BlackBerry::WebKit::dumpHistoryItem):
210         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
211         (TestRunner::setUserStyleSheetLocation):
212         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
213         (LoadHTMLStringItem::invoke):
214
215 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
216
217         Tools: add new BlackBerry include dirs.
218         https://bugs.webkit.org/show_bug.cgi?id=115514
219
220         Reviewed by Rob Buis.
221
222         iType include dirs are missing, and HarfBuzz needs to be fixed.
223
224         * Scripts/webkitdirs.pm:
225         (blackberryCMakeArguments):
226
227 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
228
229         [GTK] Plumb the Automake build system for the Battery Status API feature
230         https://bugs.webkit.org/show_bug.cgi?id=115718
231
232         Reviewed by Martin Robinson.
233
234         * Scripts/webkitdirs.pm:
235         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
236         through the --(enable|disable)-battery-status flag passed to configure.
237
238 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
239
240         new-run-webkit-websocketserver doesn't work after Chromium removal
241         https://bugs.webkit.org/show_bug.cgi?id=115816
242
243         Reviewed by Joseph Pecoraro.
244
245         Fix the bug by instantiating the correct port object.
246
247         * Scripts/new-run-webkit-websocketserver:
248         (main):
249
250 2013-05-07  Lucas Forschler  <lforschler@apple.com>
251
252         Configure buildbot for 32bit builder.
253         https://bugs.webkit.org/show_bug.cgi?id=115769
254         
255         Reviewed by Ryosuke Niwa.
256
257         * BuildSlaveSupport/build.webkit.org-config/config.json:
258
259 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
260
261         Unreviewed. Update to show my apple.com address.
262
263         * Scripts/webkitpy/common/config/contributors.json: Added
264         my apple.com e-mail address.
265
266 2013-05-08  David Kilzer  <ddkilzer@apple.com>
267
268         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
269
270         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
271         (concatenateAttributeAndValue): Switch to appendVector().
272
273 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
274
275         [Qt][WTR] Fix the build on Mac after r149692
276
277         Unreviewed build fix.
278
279         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
280         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
281
282 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
283
284         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
285         to the watchlist for Accessibility.
286
287         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
288         * Scripts/webkitpy/common/config/watchlist: Added myself.
289
290 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
291
292         [Qt] Build fails with clang
293         https://bugs.webkit.org/show_bug.cgi?id=115741
294
295         Reviewed by Benjamin Poulain.
296
297         Since r149112 std::move is used in AtomicString for compilers that
298         support rvalue references and this requires a standard library
299         implementing c++11 move semantics.
300         We only explicitely require c++11 for WebKit2, but since clang supports
301         rvalue references the build of subtargets using AtomicString fails because
302         of missing std::move.
303         It is safe to add CONFIG += c++11 for the whole project when using clang
304         since we explicitely disable c++11 for ANGLE that had probems with libc++.
305
306         * qmake/mkspecs/features/unix/default_pre.prf:
307
308 2013-05-08  Darin Adler  <darin@apple.com>
309
310         Fix one more place that needed to use adoptCF/NS
311         https://bugs.webkit.org/show_bug.cgi?id=115778
312
313         Reviewed by Benjamin Poulain.
314
315         Not sure why I missed this code last time, but found a bit more code that needs
316         to switch to the newer style adoptCF/NS.
317
318         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
319         (convertWebResourceDataToString): Use adoptCF.
320         (convertWebResourceResponseToDictionary): Ditto.
321         (createXMLStringFromWebArchiveData): Ditto.
322         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
323         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
324
325 2013-05-08  Commit Queue  <commit-queue@webkit.org>
326
327         Unreviewed, rolling out r149271.
328         http://trac.webkit.org/changeset/149271
329         https://bugs.webkit.org/show_bug.cgi?id=115780
330
331         The mangled symbols are now enforced through LDFLAGS
332         (Requested by zdobersek on #webkit).
333
334         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
335
336 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
337
338         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
339         https://bugs.webkit.org/show_bug.cgi?id=115636
340
341         Reviewed by Ryosuke Niwa.
342
343         * TestResultServer/static-dashboards/flakiness_dashboard.js:
344         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
345         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
346         while Chromium-specific, can't be removed just yet as there's more code that uses it.
347
348 2013-05-06  Darin Adler  <darin@apple.com>
349
350         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
351         https://bugs.webkit.org/show_bug.cgi?id=115657
352
353         Reviewed by Sam Weinig.
354
355         This is similar to my last set of changes, but covers code that I missed with
356         global replace using the Safari Xcode workspace.
357
358         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
359         (convertWebResourceDataToString):
360         (convertWebResourceResponseToDictionary):
361         (createXMLStringFromWebArchiveData):
362         * DumpRenderTree/cg/ImageDiffCG.cpp:
363         (createImageFromStdin):
364         (createDifferenceImage):
365         (main):
366         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
367         (printPNG):
368         (dumpBitmap):
369         * DumpRenderTree/cg/PixelDumpSupportCG.h:
370         (BitmapContext::BitmapContext):
371         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
372         (-[MockWebNotificationProvider init]):
373         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
374         (createBitmapContext):
375         * DumpRenderTree/mac/TestRunnerMac.mm:
376         (TestRunner::addDisallowedURL):
377         (TestRunner::applicationCacheDiskUsageForOrigin):
378         (TestRunner::localStorageDiskUsageForOrigin):
379         (TestRunner::clearApplicationCacheForOrigin):
380         (TestRunner::deleteLocalStorageForOrigin):
381         (TestRunner::copyDecodedHostName):
382         (TestRunner::copyEncodedHostName):
383         (TestRunner::queueLoad):
384         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
385         (TestRunner::setMockGeolocationPositionUnavailableError):
386         (TestRunner::setUserStyleSheetLocation):
387         (TestRunner::setValueForUser):
388         (TestRunner::overridePreference):
389         (TestRunner::setPersistentUserStyleSheetLocation):
390         (TestRunner::execCommand):
391         (TestRunner::findString):
392         (TestRunner::isCommandEnabled):
393         (TestRunner::addOriginAccessWhitelistEntry):
394         (TestRunner::removeOriginAccessWhitelistEntry):
395         (TestRunner::addUserScript):
396         (TestRunner::addUserStyleSheet):
397         (TestRunner::evaluateInWebInspector):
398         (TestRunner::evaluateScriptInIsolatedWorld):
399         (TestRunner::apiTestNewWindowDataLoadBaseURL):
400         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
401         (TestRunner::authenticateSession):
402         (TestRunner::grantWebNotificationPermission):
403         (TestRunner::denyWebNotificationPermission):
404         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
405         (createCFURLResponseFromResponseData):
406         * DumpRenderTree/mac/WorkQueueItemMac.mm:
407         (LoadItem::invoke):
408         (LoadHTMLStringItem::invoke):
409         (ScriptItem::invoke):
410         * DumpRenderTree/win/DumpRenderTree.cpp:
411         (substringFromIndex):
412         (urlSuitableForTestResult):
413         (lastPathComponent):
414         (sharedCFURLCache):
415         * DumpRenderTree/win/ImageDiffCairo.cpp:
416         (createImageFromStdin):
417         (main):
418         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
419         (createBitmapContextFromWebView):
420         * DumpRenderTree/win/TestRunnerWin.cpp:
421         (TestRunner::setUserStyleSheetLocation):
422         (TestRunner::setPersistentUserStyleSheetLocation):
423         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
424         (TestWebKitAPI::TEST):
425         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
426         (TestWebKitAPI::TEST):
427         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
428         (TestWebKitAPI::TEST):
429         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
430         (TestWebKitAPI::TEST):
431         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
432         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
433         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
434         (TestWebKitAPI::createWindow):
435         (TestWebKitAPI::TEST):
436         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
437         (TestWebKitAPI::TEST):
438         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
439         (TestWebKitAPI::AcceptsFirstMouse::runTest):
440         * TestWebKitAPI/Tests/mac/AttributedString.mm:
441         (TestWebKitAPI::TEST):
442         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
443         (TestWebKitAPI::TEST):
444         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
445         (TestWebKitAPI::TEST):
446         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
447         (TestWebKitAPI::TEST):
448         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
449         (TestWebKitAPI::TEST):
450         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
451         (TestWebKitAPI::TEST):
452         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
453         (TestWebKitAPI::TEST):
454         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
455         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
456         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
457         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
458         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
459         (TestWebKitAPI::TEST):
460         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
461         (TestWebKitAPI::TEST):
462         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
463         (TestWebKitAPI::TEST):
464         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
465         (TestWebKitAPI::TEST):
466         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
467         (TestWebKitAPI::TEST):
468         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
469         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
470         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
471         (TestWebKitAPI::TEST):
472         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
473         (TestWebKitAPI::TEST):
474         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
475         (TestWebKitAPI::TEST):
476         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
477         (TestWebKitAPI::TEST):
478         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
479         (TestWebKitAPI::TEST):
480         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
481         (TestWebKitAPI::TEST):
482         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
483         (TestWebKitAPI::TEST):
484         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
485         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
486         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
487         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
488         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
489         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
490         (WTR::testPathFromURL):
491         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
492         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
493         * WebKitTestRunner/cg/TestInvocationCG.cpp:
494         (WTR::createCGContextFromImage):
495         (WTR::dumpBitmap):
496         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
497         * WebKitTestRunner/mac/EventSenderProxy.mm:
498         (WTR::EventSenderProxy::mouseScrollBy):
499         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
500         (WTR::PlatformWebView::windowSnapshotImage):
501         * WebKitTestRunner/win/TestControllerWin.cpp:
502         (WTR::TestController::initializeTestPluginDirectory):
503         Use adoptCF and adoptNS.
504
505 2013-05-07  Alex Christensen  <achristensen@apple.com>
506
507         Fix a memory leak introduced in r149692
508         https://bugs.webkit.org/show_bug.cgi?id=115766
509
510         Reviewed by Mark Rowe.
511
512         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
513         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
514
515         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
516         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
517         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
518
519 2013-05-07  Darin Adler  <darin@apple.com>
520
521         [Win] Fix storage leak in Windows DumpRenderTree
522         https://bugs.webkit.org/show_bug.cgi?id=115651
523
524         Reviewed by Sam Weinig.
525
526         * DumpRenderTree/win/DumpRenderTree.cpp:
527         (lastPathComponent): Added a missing call to adoptCF.
528
529 2013-05-07  Alex Christensen  <achristensen@apple.com>
530
531         fixed a memory leak introduced by bug 42324 by using a RetainPtr
532         https://bugs.webkit.org/show_bug.cgi?id=115760
533
534         Reviewed by Tim Horton.
535
536         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
537         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
538         fixed memory leak, added UNUSED_PARAM macros
539
540 2013-05-07  Alex Christensen  <achristensen@apple.com>
541
542         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
543         https://bugs.webkit.org/show_bug.cgi?id=42324
544         <rdar://problem/8193633>
545
546         Reviewed by Tim Horton.
547
548         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
549         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
550         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
551         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
552         Added dumpDOMAsWebArchive code that is called when dumping.        
553         (WTR::InjectedBundlePage::dump):
554         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
555         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
556         (InjectedBundlePage):
557         Added dumpDOMAsWebArchive declaration.
558         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
559         (WTR::TestRunner::dumpDOMAsWebArchive):
560         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
561         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
562         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
563         * Tools/WebKitTestRunner/cf: Added.
564         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
565         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
566         (convertMIMEType):
567         (convertWebResourceDataToString):
568         (normalizeHTTPResponseHeaderFields):
569         (normalizeWebResourceURL):
570         (convertWebResourceResponseToDictionary):
571         (compareResourceURLs):
572         (createXMLStringFromWebArchiveData):
573         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
574         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
575         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
576         Copied from Tools/DumpRenderTree/mac for used functions.
577         (createCFURLResponseFromResponseData):
578         (supportedNonImageMIMETypes):
579
580 2013-05-07  Alex Christensen  <achristensen@apple.com>
581
582         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
583         https://bugs.webkit.org/show_bug.cgi?id=115745
584
585         Reviewed by Tim Horton.
586
587         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
588         (compareResourceURLs):
589         Updated style.
590
591 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
592
593         Add an 'isReadOnly' member to IDL parse tree structure
594         https://bugs.webkit.org/show_bug.cgi?id=115704
595
596         Reviewed by Kentaro Hara.
597
598         Use newly added isReadOnly attribute.
599
600         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
601         (_generateHeaderFile):
602         (_generateImplementationFile):
603         (_staticValuesGetterImplementation):
604
605 2013-05-07  Anders Carlsson  <andersca@apple.com>
606
607         Remove AlwaysInline.h from WTF
608         https://bugs.webkit.org/show_bug.cgi?id=115727
609
610         Reviewed by Brent Fulgham.
611
612         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
613         to keep AlwaysInline.h around anymore.
614
615         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
616         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
617
618 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
619
620         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
621         https://bugs.webkit.org/show_bug.cgi?id=114808
622
623         Reviewed by Jocelyn Turcotte.
624
625         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
626         (https://codereview.qt-project.org/#change,54234)
627
628         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
629         (WTR::WrapperWindow::handleStatusChanged):
630
631 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
632
633         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
634
635         * Scripts/webkitpy/common/config/watchlist:
636
637 2013-05-06  Kangil Han  <kangil.han@samsung.com>
638
639         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
640         https://bugs.webkit.org/show_bug.cgi?id=115645
641
642         Reviewed by Gyuyoung Kim.
643
644         To run performance tests in wk1, we need --no-timeout option implementation.
645         So adopt it from gtk+ port.
646
647         * DumpRenderTree/efl/DumpRenderTree.cpp:
648         (shouldSetWaitToDumpWatchdog):
649         (parseCommandLineOptions):
650         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
651         * DumpRenderTree/efl/TestRunnerEfl.cpp:
652         (TestRunner::setWaitToDump):
653
654 2013-05-06  Commit Queue  <commit-queue@webkit.org>
655
656         Unreviewed, rolling out r149547.
657         http://trac.webkit.org/changeset/149547
658         https://bugs.webkit.org/show_bug.cgi?id=115682
659
660         Added unittests that fail on bots and spits out text into
661         stdout (Requested by rniwa on #webkit).
662
663         * Scripts/import-w3c-tests: Removed.
664         * Scripts/webkitpy/w3c/__init__.py: Removed.
665         * Scripts/webkitpy/w3c/test_converter.py: Removed.
666         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
667         * Scripts/webkitpy/w3c/test_importer.py: Removed.
668         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
669         * Scripts/webkitpy/w3c/test_parser.py: Removed.
670         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
671
672 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
673
674         [jhbuild] bump jhbuild version to take advantage of new improvements
675         https://bugs.webkit.org/show_bug.cgi?id=115558
676
677         Reviewed by Martin Robinson.
678
679         One of the important improvements is jhbuild no longer fetches git
680         repositories if they are already at the expected revision, which should
681         make the EWS bots more robust to git servers unavailability.
682
683         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
684
685 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
686
687         [GTK] Add webkit_uri_scheme_request_finish_error
688         https://bugs.webkit.org/show_bug.cgi?id=94316
689
690         Reviewed by Anders Carlsson.
691
692         * MiniBrowser/gtk/main.c:
693         (miniBrowserErrorQuark): Add function to create a global quark for
694         MiniBrowser.
695         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
696         function webkit_uri_scheme_request_finish_error().
697
698 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
699
700         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
701         https://bugs.webkit.org/show_bug.cgi?id=113808
702
703         Reviewed by Rob Buis.
704
705         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
706         to true for BlackBerry.
707
708         * Scripts/webkitperl/FeatureList.pm:
709
710 2013-05-06  Jessie Berlin  <jberlin@apple.com>
711
712         check-webkit-style should complain about a layering violation if platform-specific guards are
713         used in WebCore outside of the platform directory
714         https://bugs.webkit.org/show_bug.cgi?id=115567
715
716         Reviewed by Benjamin Poulain.
717
718         * Scripts/webkitpy/style/checkers/cpp.py:
719         (check_for_webcore_platform_layering_violation):
720         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
721         (process_line):
722         Add the check_for_webcore_platform_layering_violation.
723         (CppChecker):
724         List the new check.
725
726         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
727         (CppStyleTest.test_webcore_platform_layering_violation):
728         Add tests.
729
730 2013-05-06  David Kilzer  <ddkilzer@apple.com>
731
732         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
733         <http://webkit.org/b/115667>
734
735         Reviewed by Dirk Pranke.
736
737         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
738         (Bugzilla._check_create_bug_response): Update regex to work with
739         Bugzilla 3.2.3 and 4.2.5.
740         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
741         (test__check_create_bug_response): Add new test that covers both
742         old and new <title> variations.
743
744 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
745
746         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
747         https://bugs.webkit.org/show_bug.cgi?id=115661
748
749         Reviewed by Ryosuke Niwa.
750
751         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
752         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
753         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
754
755         * TestResultServer/static-dashboards/flakiness_dashboard.js:
756         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
757
758 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
759
760         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
761         https://bugs.webkit.org/show_bug.cgi?id=114603
762
763         Reviewed by Ryosuke Niwa.
764
765         * TestResultServer/generate_builders_json.py:
766         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
767         to represent these to be 'layout-test', for backwards compatibility.
768         (main): Remove all the build.chromium.org masters.
769         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
770         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
771         (GenerateBuildersJsonTest):
772         (GenerateBuildersJsonTest.test_generate_json_data):
773         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
774         test-running builders from the webkit.org master.
775
776 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
777
778         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
779         https://bugs.webkit.org/show_bug.cgi?id=114988
780
781         Reviewed by Ryosuke Niwa.
782
783         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
784         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
785         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
786         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
787         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
788
789 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
790
791         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
792         https://bugs.webkit.org/show_bug.cgi?id=114954
793
794         Reviewed by Ryosuke Niwa.
795
796         * TestResultServer/static-dashboards/flakiness_dashboard.js:
797         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
798         modifier unions in the list of modifiers.
799         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
800         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
801
802 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
803
804         [Flakiness Dashboard] Simplify builder-name-based platform recognition
805         https://bugs.webkit.org/show_bug.cgi?id=114957
806
807         Reviewed by Ryosuke Niwa.
808
809         * TestResultServer/static-dashboards/flakiness_dashboard.js:
810         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
811         (chromiumPlatform): Removed, unnecessary.
812         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
813         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
814         the builder operates with debug builds, no webkit.org builders are named this way.
815         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
816         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
817
818 2013-05-06  Andy Estes  <aestes@apple.com>
819
820         Added two files I neglected to commit in r149589.
821
822         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
823         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
824
825 2013-05-04  Andy Estes  <aestes@apple.com>
826
827         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
828         https://bugs.webkit.org/show_bug.cgi?id=115609
829
830         Reviewed by Oliver Hunt.
831
832         Added an API test.
833
834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
835         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
836         (+[TestDelegate shared]):
837         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
838         (-[TestDelegate webView:createWebViewWithRequest:]):
839         (TestWebKitAPI):
840         (TestWebKitAPI::TEST):
841         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
842
843 2013-05-06  Antoine Quint  <graouts@apple.com>
844
845         Manage the presentation of the snapshotted plug-in using JavaScript
846         https://bugs.webkit.org/show_bug.cgi?id=115548
847
848         Reviewed by Dean Jackson.
849
850         Take into account the new plugInExtraScript method added to support
851         the injection of a JS file from the chrome client to customize the
852         rendering of a snapshotted plug-in's shadow tree.
853
854         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
855         (WTR::InjectedBundlePage::InjectedBundlePage):
856
857 2013-05-05  Anders Carlsson  <andersca@apple.com>
858
859         Remove the Vector::append overload that takes a Vector
860         https://bugs.webkit.org/show_bug.cgi?id=115535
861
862         Reviewed by Andreas Kling.
863
864         Use Vector::appendVector instead.
865
866         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
867         (concatenateAttributeAndValue):
868         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
869         (WTR::concatenateAttributeAndValue):
870
871 2013-05-04  Sam Weinig  <sam@webkit.org>
872
873         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
874         <rdar://problem/13702008>
875         https://bugs.webkit.org/show_bug.cgi?id=115607
876
877         Reviewed by Benjamin Poulain.
878
879         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
880         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
881         (TestWebKitAPI::didFinishLoadForFrame):
882         (TestWebKitAPI::TEST):
883         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
884
885 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
886
887         Unreviewed.
888
889         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
890
891 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
892
893         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
894
895         * Scripts/webkitpy/common/config/contributors.json:
896
897 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
898
899         [GTK] Catch select.error exceptions in parse_output_lines
900         https://bugs.webkit.org/show_bug.cgi?id=115253
901
902         Reviewed by Gustavo Noronha Silva.
903
904         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
905         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
906         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
907         error code and the error message) and the loop is re-entered.
908
909         * gtk/common.py:
910         (parse_output_lines):
911
912 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
913
914         [GTK] Set up the TestWebCore in TestWebKitAPI
915         https://bugs.webkit.org/show_bug.cgi?id=115237
916
917         Reviewed by Gustavo Noronha Silva.
918
919         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
920         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
921         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
922         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
923         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
924
925         * TestWebKitAPI/GNUmakefile.am:
926
927 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
928
929         Create a script to import W3C tests
930         https://bugs.webkit.org/show_bug.cgi?id=111513
931
932         Reviewed by Dirk Pranke.
933
934         Script to automate the import of W3C tests into WebKit. 
935         For the full description of how it works, see the comments
936         at the top of test_importer.py.
937
938         * Scripts/import-w3c-tests: Added.
939         * Scripts/webkitpy/w3c/__init__.py: Added.
940         * Scripts/webkitpy/w3c/test_converter.py: Added.
941         (TestConverter):
942         (TestConverter.__init__):
943         (TestConverter.load_prefixed_prop_list):
944         (TestConverter.load_file):
945         (TestConverter.convert_for_webkit):
946         (TestConverter.convert_testharness_paths):
947         (TestConverter.convert_prefixed_properties):
948         (TestConverter.scrub_unprefixed_props):
949         (TestConverter.replace_tag):
950         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
951         (TestConverterTest):
952         (TestConverterTest.testLoadPrefixedPropList):
953         (TestConverterTest.test_convertForWebkitNothingToConvert):
954         (test_convertForWebkitHarnessOnly):
955         (test_convertForWebkitPropsOnly):
956         (test_convertForWebkitHarnessAndProps):
957         (test_convertTestHarnessPaths):
958         (test_convertPrefixedProperties):
959         (verifyTestHarnessPaths):
960         (verifyPrefixedProperties):
961         (generateTestContent):
962         * Scripts/webkitpy/w3c/test_importer.py: Added.
963         (main):
964         (parse_args):
965         (validate_import_directory):
966         (TestImporter):
967         (TestImporter.__init__):
968         (TestImporter.do_import):
969         (TestImporter.get_changeset):
970         (TestImporter.scan_source_directory):
971         (TestImporter.import_tests):
972         (TestImporter.setup_destination_directory):
973         (TestImporter.get_test_status):
974         (TestImporter.remove_deleted_files):
975         (TestImporter.write_import_log):
976         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
977         (TestImporterTest):
978         (TestImporterTest.test_ImportDirWithNoTests):
979         * Scripts/webkitpy/w3c/test_parser.py: Added.
980         (TestParser):
981         (TestParser.__init__):
982         (TestParser.load_file):
983         (TestParser.analyze_test):
984         (TestParser.get_reftests):
985         (TestParser.is_jstest):
986         (TestParser.get_support_files):
987         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
988         (TestParserTest):
989         (TestParserTest.test_analyzeTestReftestOneMatch):
990         (test_analyzeTestReftestMultipleMatches):
991         (test_analyzeTestReftestMatchAndMismatch):
992         (test_analyzeTestReftestWithRefSupportFiles):
993         (test_analyzeJSTest):
994         (test_analyzePixelTestAllTrue):
995         (test_analyzePixelTestAllFalse):
996         (test_analyzeNonHTMLFile):
997
998 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
999
1000         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
1001
1002         * Scripts/webkitpy/common/config/contributors.json:
1003
1004 2013-05-02  Nico Weber  <thakis@chromium.org>
1005
1006         Remove a stale script file.
1007         https://bugs.webkit.org/show_bug.cgi?id=115521
1008
1009         Reviewed by Anders Carlsson.
1010
1011         This script was added in
1012         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
1013         Bakefile system that was removed in
1014         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
1015         script just asserts when it's run and is useless.
1016
1017         * Scripts/update-sources-list.py: Removed.
1018
1019 2013-05-01  Glenn Adams  <glenn@skynav.com>
1020
1021         [webkitpy] Need abstract base class for commands that analyze commit logs
1022         https://bugs.webkit.org/show_bug.cgi?id=115391
1023
1024         Reviewed by Benjamin Poulain.
1025
1026         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
1027         in preparation for adding two new commands that will reuse this functionality along with
1028         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
1029         https://bugs.webkit.org/show_bug.cgi?id=115388.
1030
1031         No new tests as this patch does not change existing functionality or behavior.
1032
1033         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1034         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
1035         (AbstractCommitLogCommand.__init__):
1036         (AbstractCommitLogCommand._init_options):
1037         (AbstractCommitLogCommand._parse_commit_message):
1038         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
1039         (SuggestNominations.__init__): 
1040         (SuggestNominations._init_options):
1041
1042 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
1043
1044         Web Inspector: Fix check-inspector-strings script and fix localized strings
1045         https://bugs.webkit.org/show_bug.cgi?id=115495
1046
1047         Reviewed by Joseph Pecoraro.
1048
1049         * Scripts/check-inspector-strings:
1050
1051 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
1052
1053         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
1054         https://bugs.webkit.org/show_bug.cgi?id=115470
1055
1056         Reviewed by Martin Robinson.
1057
1058         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
1059         not building either of the IOS, Windows or GTK-WK1 platforms.
1060
1061         Up until now the header was included for everything but the IOS and Windows platforms due to
1062         an incorrectly stated condition regarding the GTK platform.
1063
1064         * TestWebKitAPI/config.h:
1065
1066 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
1067
1068         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
1069         https://bugs.webkit.org/show_bug.cgi?id=115469
1070
1071         Reviewed by Martin Robinson.
1072
1073         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
1074         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
1075         for the WebKit2 tests and the injected bundle required by them.
1076
1077         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
1078         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
1079         under the WebKit2 code).
1080
1081         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
1082         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
1083         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
1084
1085         * TestWebKitAPI/GNUmakefile.am:
1086
1087 2013-04-30  Glenn Adams  <glenn@skynav.com>
1088
1089         Unreviewed. Add myself to watchlist entries.
1090
1091         * Scripts/webkitpy/common/config/watchlist:
1092
1093 2013-04-30  Glenn Adams  <glenn@skynav.com>
1094
1095         [webkitpy] suggest-nominations doesn't count all qualified patches
1096         https://bugs.webkit.org/show_bug.cgi?id=115285
1097
1098         Reviewed by Benjamin Poulain.
1099
1100         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
1101         nomination. Improve commit log parsing.
1102
1103         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1104         (CommitLogError):
1105         (CommitLogError.__init__):
1106         (CommitLogMissingReviewer):
1107         (CommitLogMissingReviewer.__init__):
1108         (SuggestNominations):
1109         (SuggestNominations.__init__):
1110         (SuggestNominations._recent_commit_messages):
1111         (SuggestNominations._author_name_from_email):
1112         (SuggestNominations._contributor_from_email):
1113         (SuggestNominations._parse_commit_message):
1114         (SuggestNominations._count_commit):
1115         (SuggestNominations._count_recent_patches):
1116         (SuggestNominations._collect_nominations):
1117         (SuggestNominations._print_nominations):
1118         (SuggestNominations.execute):
1119         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1120         (_make_options):
1121         (test_recent_commit_messages):
1122         (test_basic):
1123
1124 2013-04-30  Commit Queue  <rniwa@webkit.org>
1125
1126         Unreviewed, rolling out r149309.
1127         http://trac.webkit.org/changeset/149309
1128         https://bugs.webkit.org/show_bug.cgi?id=115430
1129
1130         The patch does not build on WK1-only builds of the GTK port
1131         (Requested by zdobersek on #webkit).
1132
1133         * TestWebKitAPI/GNUmakefile.am:
1134
1135 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1136
1137         Stop using "in" keyword in IDL files
1138         https://bugs.webkit.org/show_bug.cgi?id=115418
1139
1140         Reviewed by Kentaro Hara.
1141
1142         Remove "in" keyword from IDL files as this is no longer part of the Web
1143         IDL specification.
1144
1145         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1146         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
1147         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
1148         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1149         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1150         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
1151         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1152         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
1153
1154 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1155
1156         [EFL] Enable scaled cursors
1157         https://bugs.webkit.org/show_bug.cgi?id=106242
1158
1159         Reviewed by Gyuyoung Kim.
1160
1161         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
1162
1163         * Scripts/webkitperl/FeatureList.pm:
1164
1165 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1166
1167         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
1168         https://bugs.webkit.org/show_bug.cgi?id=115380
1169
1170         Reviewed by Kentaro Hara.
1171
1172         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
1173         keyword.
1174
1175         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1176         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1177
1178 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1179
1180         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
1181         https://bugs.webkit.org/show_bug.cgi?id=114684
1182
1183         Reviewed by Simon Hausmann.
1184
1185         Remove the ANGLE requirement for USE(3D_GRAPHICS).
1186         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
1187
1188         * qmake/mkspecs/features/features.prf:
1189
1190 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1191
1192         [GTK] Disable Shadow DOM feature
1193         https://bugs.webkit.org/show_bug.cgi?id=115374
1194
1195         Reviewed by Martin Robinson.
1196
1197         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
1198
1199         * Scripts/webkitperl/FeatureList.pm:
1200
1201 2013-04-29  Glenn Adams  <glenn@skynav.com>
1202
1203         [webkitpy] Add missing contributor email addresses
1204         https://bugs.webkit.org/show_bug.cgi?id=115394
1205
1206         Reviewed by Ryosuke Niwa.
1207
1208         * Scripts/webkitpy/common/config/contributors.json:
1209
1210 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
1211
1212         Remove all remaining Skia code
1213         https://bugs.webkit.org/show_bug.cgi?id=115263
1214
1215         Reviewed by Benjamin Poulain.
1216
1217         Remove all remaining references to Skia.
1218
1219         * Scripts/webkitdirs.pm:
1220         (blackberryCMakeArguments):
1221         * Scripts/webkitpy/common/config/contributionareas.py:
1222         * Scripts/webkitpy/common/config/watchlist:
1223
1224 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
1225
1226         Get rid of unused options in Tools/Scripts/webkit-build-directory
1227         https://bugs.webkit.org/show_bug.cgi?id=115383
1228
1229         Reviewed by Darin Adler.
1230
1231         * Scripts/webkit-build-directory:
1232
1233 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
1234
1235         [WK2][Mac] Test with NetworkProcess enabled.
1236
1237         Fix the build for non-Mac.
1238
1239         * WebKitTestRunner/TestController.cpp:
1240         (WTR::TestController::initialize):
1241
1242 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
1243
1244         [WK2][Mac] Test with NetworkProcess enabled.
1245
1246         Reviewed by Sam Weinig.
1247
1248         * WebKitTestRunner/TestController.cpp:
1249         (WTR::TestController::initialize):
1250
1251 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1252
1253         [GTK] Set up the TestWebCore in TestWebKitAPI
1254         https://bugs.webkit.org/show_bug.cgi?id=115237
1255
1256         Reviewed by Gustavo Noronha Silva.
1257
1258         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
1259         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
1260         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
1261         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
1262         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
1263
1264         * TestWebKitAPI/GNUmakefile.am:
1265
1266 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1267
1268         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
1269         https://bugs.webkit.org/show_bug.cgi?id=115236
1270
1271         Reviewed by Gustavo Noronha Silva.
1272
1273         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
1274         under the TestWebKitAPI/Tests/JavaScriptCore directory.
1275
1276         * TestWebKitAPI/GNUmakefile.am:
1277
1278 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1279
1280         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
1281         https://bugs.webkit.org/show_bug.cgi?id=115323
1282
1283         Reviewed by Philippe Normand.
1284
1285         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
1286         Its presence enforces linkers to output mangled symbols when reporting linking failures
1287         due to unresolved references. People trying to fix the build can then simply copy
1288         the printed mangled symbol into the symbols.filter file instead of doing a manual build
1289         or connecting to the builders to discover the mangled version of the missing symbol.
1290
1291         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1292
1293 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
1294
1295         Remove Chromium code from Tools/BuildSlaveSupport
1296         https://bugs.webkit.org/show_bug.cgi?id=115325
1297
1298         Reviewed by Benjamin Poulain.
1299
1300         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
1301         covering archiving test results and built products.
1302
1303         * BuildSlaveSupport/built-product-archive:
1304         (archiveBuiltProduct):
1305         (extractBuiltProduct):
1306         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
1307         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
1308         * BuildSlaveSupport/test-result-archive:
1309         (archiveTestResults):
1310
1311 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
1312
1313         Remove support for Chromium from webkitdirs.pm
1314         https://bugs.webkit.org/show_bug.cgi?id=115338
1315
1316         Reviewed by Darin Adler.
1317
1318         * Scripts/webkitdirs.pm:
1319         (determineBaseProductDir):
1320         (argumentsForConfiguration):
1321         (builtDylibPathForName):
1322         (determineIsQt):
1323         (isAppleWebKit):
1324
1325 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
1326
1327         Rename TestRunner's setAudioData to setAudioResult
1328         https://bugs.webkit.org/show_bug.cgi?id=115326
1329
1330         Reviewed by Darin Adler.
1331
1332         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
1333         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
1334         affected tests are adjusted accordingly.
1335
1336         * DumpRenderTree/qt/TestRunnerQt.cpp:
1337         (TestRunnerQt::setAudioResult):
1338         * DumpRenderTree/qt/TestRunnerQt.h:
1339         (TestRunnerQt):
1340         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1341         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1342         (WTR::TestRunner::setAudioResult):
1343         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1344         (TestRunner):
1345
1346 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
1347
1348         [WKTR] Tests dumping audio data shouldn't dump pixels
1349         https://bugs.webkit.org/show_bug.cgi?id=115270
1350
1351         Reviewed by Benjamin Poulain.
1352
1353         Prevent dumping the pixel output when Web Audio tests are dumping output data
1354         as the testing output. Pixel output in these tests has no real meaning and is
1355         as such unnecessary.
1356
1357         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1358         (WTR::TestRunner::setAudioData):
1359
1360 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1361
1362         [EFL] Unreviewed Intel bots fix after r149231.
1363
1364         * efl/jhbuild.modules: Disable the libxml Python bindings since the
1365         bots don't have Python's development files installed. libxml should
1366         detect this kind of thing better.
1367
1368 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
1369
1370         [EFL] Build break using jhbuild on ubuntu 13.04
1371         https://bugs.webkit.org/show_bug.cgi?id=115225
1372
1373         Reviewed by Gyuyoung Kim.
1374
1375         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
1376         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
1377         So this patch bumped libxml version to 2.9.1.
1378
1379         * efl/jhbuild.modules:
1380
1381 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
1382
1383         delete-stale-build-files does not clear .d files
1384         http://bugs.webkit.org/show_bug.cgi?id=115293
1385
1386         Reviewed by Ryosuke Niwa.
1387
1388         * BuildSlaveSupport/delete-stale-build-files:
1389         (main): Add .d to the file type list
1390
1391 2013-04-26  Roger Fong  <roger_fong@apple.com>
1392
1393         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
1394         Make the DebugSuffix configuration use _debug dependencies.
1395
1396         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1397         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
1398         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1399         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
1400         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1401         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1402         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
1403         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
1404         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
1405         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
1406         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
1407         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
1408         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
1409         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1410         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1411         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
1412         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
1413         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
1414         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1415         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
1416         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
1417         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
1418         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
1419         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
1420         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
1421         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
1422         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
1423         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1424         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
1425         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
1426         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
1427         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
1428         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
1429         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
1430         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1431         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1432         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1433         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
1434         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1435         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
1436         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
1437         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1438         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1439         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
1440         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
1441         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1442         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1443         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
1444         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
1445         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
1446         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
1447         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
1448         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1449         * win/AssembleBuildLogs/AssembleLogs.cmd:
1450         * win/record-memory/record-memory.vcxproj:
1451         * win/record-memory/record-memoryDebug.props:
1452         * win/record-memory/record-memoryDebugWinCairo.props:
1453         * win/record-memory/record-memoryProduction.props:
1454         * win/record-memory/record-memoryRelease.props:
1455         * win/record-memory/record-memoryReleaseWinCairo.props:
1456
1457 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
1458
1459         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
1460         https://bugs.webkit.org/show_bug.cgi?id=115233
1461
1462         Reviewed by Martin Robinson.
1463
1464         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
1465         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
1466         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
1467         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
1468         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
1469
1470         * TestWebKitAPI/GNUmakefile.am:
1471
1472 2013-04-25  Andy Estes  <aestes@apple.com>
1473
1474         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
1475         https://bugs.webkit.org/show_bug.cgi?id=115223
1476
1477         Reviewed by Darin Adler.
1478
1479         Added an API test.
1480
1481         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1482         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
1483         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
1484         when it loads a request with a custom protocol.
1485         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
1486         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
1487         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
1488         miscellaneous cleanup.
1489         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
1490         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
1491         (+[TestProtocol canInitWithRequest:]):
1492         (+[TestProtocol canonicalRequestForRequest:]):
1493         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
1494         (+[TestProtocol scheme]):
1495         (-[TestProtocol startLoading]):
1496         (-[TestProtocol stopLoading]):
1497
1498 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
1499
1500         Remove the remaining Skia #ifdefs
1501         https://bugs.webkit.org/show_bug.cgi?id=114886
1502
1503         Reviewed by Benjamin Poulain.
1504
1505         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1506         (createBitmapContextFromWebView): Remove Skia #ifdef references.
1507
1508 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
1509
1510         [BlackBerry] Clean up load interface in WebPage
1511         https://bugs.webkit.org/show_bug.cgi?id=113267
1512
1513         Reviewed by Rob Buis.
1514
1515         Update DumpRenderTree with change of load() interface in WebPage.
1516         RIM Bug# 315535, internally reviewed by Joe Mason.
1517
1518         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1519         (BlackBerry::WebKit::DumpRenderTree::runTest):
1520
1521 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
1522
1523         Remove the HeapGraphSerializer unit test
1524         https://bugs.webkit.org/show_bug.cgi?id=115231
1525
1526         Reviewed by Andreas Kling.
1527
1528         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
1529         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
1530
1531         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
1532
1533 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1534
1535         Remove support for Chromium from build/update scripts
1536         https://bugs.webkit.org/show_bug.cgi?id=115218
1537
1538         Reviewed by Darin Adler.
1539
1540         * Scripts/build-webkit:
1541         (writeCongrats):
1542         * Scripts/update-webkit:
1543
1544 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1545
1546         Remove support for Chromium from api-test
1547         https://bugs.webkit.org/show_bug.cgi?id=115211
1548
1549         Reviewed by Dirk Pranke.
1550
1551         * Scripts/build-api-tests:
1552         * Scripts/run-api-tests:
1553         (isSupportedPlatform):
1554
1555 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1556
1557         Get rid of Chromium in build-dumprendertree
1558         https://bugs.webkit.org/show_bug.cgi?id=115212
1559
1560         Reviewed by Dirk Pranke.
1561
1562         * Scripts/build-dumprendertree:
1563
1564 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
1565
1566         Pass relatedPage when creating a page in WebKitTestRunner
1567         https://bugs.webkit.org/show_bug.cgi?id=115206
1568
1569         Reviewed by Geoffrey Garen.
1570
1571         To make sure that window.open() opens in the same process even when using multiple processes.
1572
1573         * WebKitTestRunner/PlatformWebView.h:
1574         * WebKitTestRunner/TestController.cpp:
1575         (WTR::TestController::createOtherPage):
1576         (WTR::TestController::createWebViewWithOptions):
1577         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1578         (WTR::PlatformWebView::PlatformWebView):
1579         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1580         (WTR::PlatformWebView::PlatformWebView):
1581         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1582         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
1583         (WTR::PlatformWebView::PlatformWebView):
1584         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1585         (WTR::PlatformWebView::PlatformWebView):
1586         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1587         (WTR::PlatformWebView::PlatformWebView):
1588
1589 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1590
1591         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
1592
1593         * Scripts/webkitpy/common/config/contributors.json:
1594
1595 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1596
1597         Build fix. Forgot to merge args.
1598
1599         * Scripts/webkitpy/tool/bot/irc_command.py:
1600         (Hi.execute):
1601
1602 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1603
1604         webkitbot should recognize its own nickname in greetings.
1605         https://bugs.webkit.org/show_bug.cgi?id=115196
1606
1607         Reviewed by Andreas Kling.
1608
1609         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
1610
1611         * Scripts/webkitpy/tool/bot/irc_command.py:
1612         (Hi.execute):
1613
1614 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
1615
1616         [GTK] Tools/gtk/install-dependencies added ragel dependency
1617         https://bugs.webkit.org/show_bug.cgi?id=115163
1618
1619         Reviewed by Xan Lopez.
1620
1621         The install-dependencies script was missing a dependency on ragel
1622         which is expected when building HarfBuzz.
1623
1624         * gtk/install-dependencies: Added a dependency on ragel for both
1625         apt and yum.
1626
1627 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
1628
1629         [GTK] Remove pango from optional jhbuild dependencies
1630         https://bugs.webkit.org/show_bug.cgi?id=115162
1631
1632         Reviewed by Martin Robinson.
1633
1634         Pango is not needed since revision r148293 that lowers the pango
1635         dependency to 1.30, which is available in most distributions.
1636
1637         * gtk/jhbuild-optional.modules: Removes description of pango module.
1638
1639 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1640
1641         Remove Chromium-specific cases from FeatureList.pm
1642         https://bugs.webkit.org/show_bug.cgi?id=115169
1643
1644         Reviewed by Andreas Kling.
1645
1646         * Scripts/webkitperl/FeatureList.pm:
1647
1648 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
1649
1650         Remove checking chromium from run-webkit-tests
1651         https://bugs.webkit.org/show_bug.cgi?id=115139
1652
1653         Reviewed by Benjamin Poulain.
1654
1655         * Scripts/run-webkit-tests:
1656         (useNewRunWebKitTests):
1657
1658 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
1659
1660         Pixel tests in SVG are all broken in WK2
1661         https://bugs.webkit.org/show_bug.cgi?id=114218
1662
1663         Reviewed by Darin Adler.
1664         
1665         Window snapshots in WebKitTestRunner on Mac are window-sized
1666         (800x600), which is wrong for the W3C SVG tests that require a
1667         480x360 snapshot.
1668         
1669         Fix by resizing the window, as well as the web view in
1670         PlatformWebView::resizeTo() so that window snapshots are correctly
1671         sized.
1672         
1673         Also do some drive-by cleanup of the window size constants in both
1674         DRT and WTR to remove magic numbers, and make the code more similar.
1675         
1676         * DumpRenderTree/TestRunner.cpp:
1677         (TestRunner::setShouldPaintBrokenImage):
1678         * DumpRenderTree/TestRunner.h:
1679         * DumpRenderTree/efl/DumpRenderTree.cpp:
1680         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1681         (webInspectorShowWindow):
1682         * DumpRenderTree/mac/DumpRenderTree.mm:
1683         (createWebViewAndOffscreenWindow):
1684         (sizeWebViewForCurrentTest):
1685         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1686         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1687         (createPagedBitmapContext):
1688         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1689         (DumpRenderTree::DumpRenderTree):
1690         (DumpRenderTree::open):
1691         * DumpRenderTree/qt/TestRunnerQt.cpp:
1692         * DumpRenderTree/qt/TestRunnerQt.h:
1693         * DumpRenderTree/win/DumpRenderTree.cpp:
1694         (sizeWebViewForCurrentTest):
1695         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1696         * WebKitTestRunner/TestController.cpp:
1697         (WTR::TestController::resetStateToConsistentValues):
1698         * WebKitTestRunner/TestController.h:
1699         * WebKitTestRunner/TestInvocation.cpp:
1700         (WTR::sizeWebViewForCurrentTest):
1701         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1702         (WTR::PlatformWebView::PlatformWebView):
1703         (WTR::PlatformWebView::resizeTo):
1704
1705 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
1706
1707         [EFL] Fix build error after r148963.
1708         https://bugs.webkit.org/show_bug.cgi?id=115126
1709
1710         Reviewed by Laszlo Gombos.
1711
1712         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
1713
1714         * TestWebKitAPI/PlatformEfl.cmake:
1715
1716 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1717
1718         [GTK] Use stamp files for generate-forwarding-headers makefile rules
1719         https://bugs.webkit.org/show_bug.cgi?id=115118
1720
1721         Reviewed by Martin Robinson.
1722
1723         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
1724         forwarding generator rules and don't call it for soup since there
1725         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
1726
1727         * TestWebKitAPI/GNUmakefile.am:
1728         * WebKitTestRunner/GNUmakefile.am:
1729
1730 2013-04-24  Simon Pena  <simon.pena@samsung.com>
1731
1732         [GTK] Update build dependencies
1733         https://bugs.webkit.org/show_bug.cgi?id=115111
1734
1735         Reviewed by Martin Robinson.
1736
1737         The install-dependencies script was missing a dependency on EGL,
1738         which is expected when building Cairo.
1739
1740         * gtk/install-dependencies: Added a dependency on libegl1-mesa
1741         for both apt and yum.
1742
1743 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
1744
1745         Remove the Chromium-specific helper from run_webkit_tests.py
1746         https://bugs.webkit.org/show_bug.cgi?id=114996
1747
1748         Reviewed by Dirk Pranke.
1749
1750         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1751         (parse_args):
1752
1753 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
1754
1755         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
1756         https://bugs.webkit.org/show_bug.cgi?id=114850
1757
1758         Reviewed by Andreas Kling.
1759
1760         Revision r148312 fixed WebPageProxy cleanup and also changed the process
1761         termination semantics when requested by the user so that a client is not
1762         notified of a crash anymore, since there was no crash anyway.
1763
1764         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
1765         relied on being notified of a crash after calling WKPageTerminate(). As
1766         a result of not being notified of such non-existent crash, the test would
1767         timeout right after making the terminate call.
1768
1769         This patch adds an InjectedBundle to be used for simulating a crash, by
1770         calling abort() upon receiving a "Crash" message, and thus we are able to
1771         keep testing the crash callback.
1772
1773         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
1774         had been disabled in revisions r148858 and r148855, since it was failing.
1775
1776         * TestWebKitAPI/PlatformEfl.cmake:
1777         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1778         (TestWebKitAPI::TEST):
1779         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
1780         (TestWebKitAPI):
1781         (WKViewClientWebProcessCallbacksTest):
1782         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
1783         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
1784
1785 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1786
1787         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
1788         https://bugs.webkit.org/show_bug.cgi?id=115095
1789
1790         Reviewed by Antonio Gomes.
1791
1792         Use different subfolders under DumpRenderTree Temp folder for every
1793         functionality (icon database, cache, localstorage, ...). This makes
1794         sure there is no conflict between the functionalities.
1795
1796         In EFL's case, libsoup cache was causing problems for the icon
1797         database if sharing the same folder.
1798
1799         * WebKitTestRunner/TestController.cpp:
1800         (WTR::TestController::initialize):
1801
1802 == Rolled over to ChangeLog-2013-04-24 ==