[Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
4         https://bugs.webkit.org/show_bug.cgi?id=174793
5
6         Reviewed by Tim Horton.
7
8         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
9         down. Without r219765, this test will dereference null and crash.
10
11         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
13         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
14         (TEST):
15
16 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
17
18         [Win] Implement Authentication dialog in MiniBrowser
19         https://bugs.webkit.org/show_bug.cgi?id=174662
20
21         Reviewed by Alex Christensen.
22
23         * MiniBrowser/win/Common.cpp:
24         (CustomUserAgent):
25         (DisplayAuthDialog):
26         (AuthDialogProc):
27         * MiniBrowser/win/MiniBrowserLib.rc:
28         * MiniBrowser/win/MiniBrowserLibResource.h:
29         * MiniBrowser/win/ResourceLoadDelegate.cpp:
30         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
31
32 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
33
34         Handle case where line_numbers is None instead of an array of line numbers
35         https://bugs.webkit.org/show_bug.cgi?id=174775
36
37         Reviewed by Aakash Jain.
38
39         Added files set line_numbers to None in process_file.
40
41         * Scripts/webkitpy/style/filereader.py:
42         (TextFileReader.process_file): Handle case where line_number is set to None.
43         * Scripts/webkitpy/style/main_unittest.py:
44         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
45
46 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
47
48         [WPE] Add libepoxy to the Jhbuild moduleset
49         https://bugs.webkit.org/show_bug.cgi?id=174711
50
51         Reviewed by Carlos Alberto Lopez Perez.
52
53         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
54
55 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
56
57         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
58         https://bugs.webkit.org/show_bug.cgi?id=174780
59
60         Reviewed by Carlos Garcia Campos.
61
62         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
63         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
64         in case the eglplatform.h header doesn't provide that macro. This replicates
65         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
66
67 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
68
69         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
70         https://bugs.webkit.org/show_bug.cgi?id=174758
71
72         Reviewed by Dan Bernstein.
73
74         Migrate position-information-related unit tests from the PositionInformationTests suite to
75         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
76
77         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
78         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
79         (TestWebKitAPI::checkElementTypeAndBoundingRect):
80         (TestWebKitAPI::TEST):
81         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
82         * TestWebKitAPI/cocoa/TestWKWebView.h:
83         * TestWebKitAPI/cocoa/TestWKWebView.mm:
84         (-[TestWKWebView activatedElementAtPosition:]):
85
86 2017-07-22  Chris Dumez  <cdumez@apple.com>
87
88         REGRESSION(r204565): WKObject is broken
89         https://bugs.webkit.org/show_bug.cgi?id=174736
90         <rdar://problem/33246169>
91
92         Reviewed by Dan Bernstein.
93
94         Add API test that used to crash.
95
96         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
97         (TestWebKitAPI::TEST):
98
99 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
100
101         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
102         https://bugs.webkit.org/show_bug.cgi?id=174705
103
104         Reviewed by Mark Lam.
105
106         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
107         (TestWebKitAPI::testThreadGroup):
108         (TestWebKitAPI::TEST):
109
110 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
111
112         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
113         https://bugs.webkit.org/show_bug.cgi?id=174724
114
115         Reviewed by Aakash Jain.
116
117         * Scripts/webkitpy/port/ios_simulator.py:
118         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
119         simulator. Errors here should be treated the same as no simulators found.
120
121 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
122
123         [CMake] Add an option to stop build after generating project files
124         https://bugs.webkit.org/show_bug.cgi?id=174664
125
126         Reviewed by Konstantin Tokarev.
127
128         Add "--generate-project-only" to stop build after generating project files.
129
130         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
131         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
132         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
133         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
134         (isGenerateProjectOnly): ditto
135
136 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
137
138         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
139         https://bugs.webkit.org/show_bug.cgi?id=174501
140
141         Reviewed by Darin Adler.
142
143         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
144         (TestWebKitAPI::TEST):
145
146 2017-07-20  David Quesada  <david_quesada@apple.com>
147
148         Add SPI to notify WKNavigationDelegate about client redirects
149         https://bugs.webkit.org/show_bug.cgi?id=174680
150         rdar://problem/33184886
151
152         Reviewed by Brady Eidson.
153
154         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
155         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
156         (TEST):
157         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
158
159 2017-07-20  Brady Eidson  <beidson@apple.com>
160
161         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
162         https://bugs.webkit.org/show_bug.cgi?id=174685
163
164         Reviewed by Andy Estes.
165
166         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
167         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
168
169 2017-07-20  Brady Eidson  <beidson@apple.com>
170
171         Deprecate WebIconDatabase in WebKitLegacy/mac.
172         https://bugs.webkit.org/show_bug.cgi?id=174607
173
174         Reviewed by Alex Christensen.
175
176         * DumpRenderTree/mac/TestRunnerMac.mm:
177
178 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
179
180         lint-test-expectations should be run during style checking
181         https://bugs.webkit.org/show_bug.cgi?id=173559
182         <rdar://problem/32854941>
183
184         Reviewed by Aakash Jain.
185
186         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
187         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
188         prevents identifying errors on specific lines in a file.
189         * Scripts/webkitpy/style/main_unittest.py:
190         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
191         case where a linter error is in the file modified, but the line modified is not related to
192         the linter error.
193
194 2017-07-20  Brady Eidson  <beidson@apple.com>
195
196         Remove WebIconDatabase from WebKitLegacy/win.
197         https://bugs.webkit.org/show_bug.cgi?id=174608
198
199         Reviewed by Alex Christensen.
200
201         * DumpRenderTree/win/DumpRenderTree.cpp:
202         (main):
203         * DumpRenderTree/win/TestRunnerWin.cpp:
204         (TestRunner::setIconDatabaseEnabled):
205
206 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
207
208         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
209         https://bugs.webkit.org/show_bug.cgi?id=174671
210
211         Reviewed by Carlos Garcia Campos.
212
213         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
214         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
215         priority for this source in order to have it dispatched on the same
216         priority as the other WebKit-controlled GSource objects.
217
218 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
219
220         lint-test-expectations should be run during style checking
221         https://bugs.webkit.org/show_bug.cgi?id=173559
222         <rdar://problem/32854941>
223
224         Reviewed by Daniel Bates.
225
226         Follow up fix addressing style and a few minor bugs.
227
228         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
229         (TestExpectationParser.__init__): Use lambda x: x instead of str
230         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
231         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
232         reduce the calls of _shorten_filename, fix minor bug in appending the current
233         expectation's line number instead of the previous ones, clarify treatment of None
234         in file-to-line-number mapping.
235         (TestExpectations._report_warnings): Collapse call.
236         * Scripts/webkitpy/style/checkers/test_expectations.py:
237         (TestExpectationsChecker.lint_test_expectations):
238         * Scripts/webkitpy/style/filereader.py: Re-write comment.
239         (TextFileReader.process_file): Add comment explaining treatment of None in
240         file-to-line-number mapping.
241         (TextFileReader.delete_file): Collapse call.
242
243 2017-07-19  Chris Dumez  <cdumez@apple.com>
244
245         Unreviewed attempt to fix API test failure after r219663.
246
247         The test was hard-coding an exception string and the string has changed slightly
248         in r219663.
249
250         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
251         (TEST):
252
253 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
254
255         Don't write file URLs to iOS Pasteboard
256         https://bugs.webkit.org/show_bug.cgi?id=174647
257         <rdar://problem/33199730>
258
259         Reviewed by Wenson Hsieh.
260
261         Updating tests to reflect the lack of file URLs for images.
262
263         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
264         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
265         (checkEstimatedSize):
266         (TestWebKitAPI::TEST):
267
268 2017-07-19  Brady Eidson  <beidson@apple.com>
269
270         iBooks sometimes crashes when closing a book.
271         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
272
273         Reviewed by Oliver Hunt.
274
275         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
276         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
277         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
278         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
279         (TestWebKitAPI::TEST):
280
281         Add a "spin the runloop X number of times" utility:
282         * TestWebKitAPI/Utilities.h:
283         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
284         (TestWebKitAPI::Util::spinRunLoop):
285
286 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
287
288         lint-test-expectations should be run during style checking
289         https://bugs.webkit.org/show_bug.cgi?id=173559
290         <rdar://problem/32854941>
291
292         Reviewed by David Kilzer.
293
294         Running the test expectation linter requires reading both files and lines not in the
295         patch because, for example, deletion of a test can cause a lint failure even though
296         no test expectations where modified. This means that the linter will occasionally warn
297         about lines which were not changed in a given patch but whose error is related to a
298         change made in that patch.
299
300         * Scripts/webkitpy/common/system/filesystem_mock.py:
301         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
302         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
303         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
304         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
305         content, description of the error and the name of the associated test.
306         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
307         (TestExpectationParser.__init__): Pass shorten_filename function to
308         TestExpectationsParser to add a deleted file to the related_files dictionary.
309         (TestExpectationParser._check_test_exists): If the test does not exist, add the
310         missing path to the related_files dictionary.
311         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
312         files and line numbers related to this test expectation line. This will allow
313         tracking linter errors in the style checker occurring across multiple files.
314         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
315         lines to related_files dictionary.
316         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
317         (TestExpectations._report_warnings): Construct warning object instead of string
318         when adding to warnings list.
319         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
320         clean-up log.
321         * Scripts/webkitpy/style/checker.py:
322         (ProcessorBase.do_association_check): Add required function for processor classes.
323         (StyleProcessor):
324         (StyleProcessor.do_association_check): Run the TestExpectations linter when
325         checking for errors between associated files.
326         * Scripts/webkitpy/style/checkers/test_expectations.py:
327         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
328         (TestExpectationsChecker):
329         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
330         of modified files, the current working directory and the host, determine if the linter
331         warning is associated with the changes.
332         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
333         style checker.
334         * Scripts/webkitpy/style/filereader.py:
335         (TextFileReader):
336         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
337         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
338         (TextFileReader.process_file): Track both the number of files changed and which lines
339         in those files were changed.
340         (TextFileReader.do_association_check): Run the processor's association check on all
341         modified or deleted files processed by TextFileReader.
342         (TextFileReader.delete_file): Track deleted files in _files dictionary.
343         (TextFileReader.count_delete_only_file): Deleted.
344         * Scripts/webkitpy/style/filereader_unittest.py:
345         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
346         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
347         * Scripts/webkitpy/style/main.py:
348         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
349         explicitly run the association check on the file reader.
350         * Scripts/webkitpy/style/main_unittest.py:
351         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
352         embedded in the style checker.
353         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
354         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
355         construct the TextFileReader object with a StyleProcessor used to run style checks on
356         specific files.
357         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
358         testing the test expectation linter inside the style checker. This host must contain a
359         mock file system with the basic structure of test expectations.
360         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
361         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
362         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
363         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
364         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
365         * Scripts/webkitpy/style/patchreader.py:
366         (PatchReader.check): Specify which file was deleted, run the association check.
367         * Scripts/webkitpy/style/patchreader_unittest.py:
368         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
369         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
370         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
371
372 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
373
374         [WTF] Implement WTF::ThreadGroup
375         https://bugs.webkit.org/show_bug.cgi?id=174081
376
377         Reviewed by Mark Lam.
378
379         Add WTF::ThreadGroup tests.
380
381         * TestWebKitAPI/CMakeLists.txt:
382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
383         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
384         (TestWebKitAPI::testThreadGroup):
385         (TestWebKitAPI::TEST):
386
387 2017-07-18  Andy Estes  <aestes@apple.com>
388
389         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
390         https://bugs.webkit.org/show_bug.cgi?id=174631
391
392         Reviewed by Tim Horton.
393
394         * DumpRenderTree/mac/Configurations/Base.xcconfig:
395         * MiniBrowser/Configurations/Base.xcconfig:
396         * MobileMiniBrowser/Configurations/Base.xcconfig:
397         * TestWebKitAPI/Configurations/Base.xcconfig:
398         * WebKitTestRunner/Configurations/Base.xcconfig:
399
400 2017-07-18  Andy Estes  <aestes@apple.com>
401
402         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
403         https://bugs.webkit.org/show_bug.cgi?id=174631
404
405         Reviewed by Sam Weinig.
406
407         * DumpRenderTree/mac/Configurations/Base.xcconfig:
408         * MiniBrowser/Configurations/Base.xcconfig:
409         * MobileMiniBrowser/Configurations/Base.xcconfig:
410         * TestWebKitAPI/Configurations/Base.xcconfig:
411         * WebKitTestRunner/Configurations/Base.xcconfig:
412
413 2017-07-18  Daniel Bates  <dabates@apple.com>
414
415         lldb: Add type summary for StringView
416         https://bugs.webkit.org/show_bug.cgi?id=174637
417
418         Reviewed by Sam Weinig.
419
420         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
421         StringView object will print output that has the form:
422
423             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
424               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
425               m_length = 2
426               m_is8Bit = true
427               m_underlyingString = 0x0000614000000a90
428             }
429
430         * lldb/lldb_webkit.py:
431         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
432         (WTFStringView_SummaryProvider):
433         (WTFStringViewProvider):
434         (WTFStringViewProvider.__init__):
435         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
436         (WTFStringViewProvider.get_length): Access field StringView.m_length.
437         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
438         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
439
440 2017-07-18  Andy Estes  <aestes@apple.com>
441
442         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
443         https://bugs.webkit.org/show_bug.cgi?id=174631
444
445         Reviewed by Dan Bernstein.
446
447         * DumpRenderTree/mac/Configurations/Base.xcconfig:
448         * MiniBrowser/Configurations/Base.xcconfig:
449         * MobileMiniBrowser/Configurations/Base.xcconfig:
450         * TestWebKitAPI/Configurations/Base.xcconfig:
451         * WebKitTestRunner/Configurations/Base.xcconfig:
452
453 2017-07-18  Devin Rousso  <drousso@apple.com>
454
455         Web Inspector: Add memoryCost to Inspector Protocol objects
456         https://bugs.webkit.org/show_bug.cgi?id=174478
457
458         Reviewed by Joseph Pecoraro.
459
460         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
461         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
462         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
463         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
464         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
465         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
466         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
467         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
468         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
469         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
470         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
471         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
472         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
473         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
474         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
475         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
476         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
477
478 2017-07-18  Andy Estes  <aestes@apple.com>
479
480         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
481         https://bugs.webkit.org/show_bug.cgi?id=174631
482
483         Reviewed by Darin Adler.
484
485         * DumpRenderTree/mac/Configurations/Base.xcconfig:
486         * MiniBrowser/Configurations/Base.xcconfig:
487         * MobileMiniBrowser/Configurations/Base.xcconfig:
488         * TestWebKitAPI/Configurations/Base.xcconfig:
489         * WebKitTestRunner/Configurations/Base.xcconfig:
490
491 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
492
493         Unreviewed, fix the iOS build.
494
495         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
496
497         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
498         (TestWebKitAPI::TEST):
499
500 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
501
502         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
503         https://bugs.webkit.org/show_bug.cgi?id=174585
504         <rdar://problem/33302541>
505
506         Reviewed by Tim Horton.
507
508         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
509         being dragged when initiating a drag.
510
511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
512         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
513         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
514         (TestWebKitAPI::TEST):
515         * TestWebKitAPI/cocoa/TestWKWebView.h:
516
517         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
518
519         * TestWebKitAPI/cocoa/TestWKWebView.mm:
520         (-[TestWKWebView synchronouslyLoadHTMLString:]):
521
522 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
523
524         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
525         https://bugs.webkit.org/show_bug.cgi?id=174547
526
527         Reviewed by Alex Christensen.
528
529         * DumpRenderTree/PlatformWin.cmake:
530         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
531
532 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
533
534         Update style checker to deal with "final"
535         https://bugs.webkit.org/show_bug.cgi?id=174528
536
537         Reviewed by Alex Christensen.
538         
539         check-webkit-style shouldn't complain about an open brace to start a
540         line after a function definition with "final" or "const final".
541
542         * Scripts/webkitpy/style/checkers/cpp.py:
543         (check_braces):
544         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
545         (CppStyleTest.test_brace_at_begin_of_line):
546
547 2017-07-17  Alex Christensen  <achristensen@webkit.org>
548
549         Modernize content extension code
550         https://bugs.webkit.org/show_bug.cgi?id=174588
551
552         Reviewed by Sam Weinig.
553
554         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
555         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
556         (TestWebKitAPI::testRequest):
557         (TestWebKitAPI::makeBackend):
558         (TestWebKitAPI::TEST_F):
559
560 2017-07-17  Brady Eidson  <beidson@apple.com>
561
562         WKHTTPCookieStore observing only works on the default cookie store.
563         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
564
565         Reviewed by Sam Weinig.
566
567         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
568         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
569           called for the default store, a non-persistent store, and a custom store.
570         (TEST):
571
572 2017-07-16  Sam Weinig  <sam@webkit.org>
573
574         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
575         https://bugs.webkit.org/show_bug.cgi?id=174575
576
577         Reviewed by Brady Eidson.
578
579         * Scripts/svn-create-patch:
580         (findModificationType):
581         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
582         default value of "unknown".
583
584         (generateFileList):
585         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
586         for untracked, which matches our old behavior.
587
588 2017-07-17  Charlie Turner  <cturner@igalia.com>
589
590         Add some missing build dependencies on Fedora
591         https://bugs.webkit.org/show_bug.cgi?id=174578
592
593         Unreviewed dependency update.
594
595         * gtk/install-dependencies:
596
597 2017-07-16  Brady Eidson  <beidson@apple.com>
598
599         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
600         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
601
602         Reviewed by Tim Horton.
603
604         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
605         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
606         (TEST):
607
608 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
609
610         [GTK] Sort inspector GResource manifest to ensure reproducible builds
611         https://bugs.webkit.org/show_bug.cgi?id=174540
612
613         Reviewed by Michael Catanzaro.
614
615         * gtk/generate-inspector-gresource-manifest.py:
616         (get_filenames): sort list of input files
617
618 2017-07-15  Brady Eidson  <beidson@apple.com>
619
620         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
621         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
622
623         Reviewed by Tim Horton.
624
625         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
626         (TEST): Make this test more reliable by clearing everything beforehand.
627
628 2017-07-15  David Kilzer  <ddkilzer@apple.com>
629
630         Make it possible to extend check-webkit-style with Apple-internal checkers
631         <https://webkit.org/b/174464>
632         <rdar://problem/25564402>
633
634         Reviewed by Darin Adler.
635
636         * Scripts/webkitpy/style/checker.py: Import apple_additions.
637         (_all_categories): Add categories from apple_additions() if it
638         exists.
639         (CheckerDispatcher._create_checker): Create python checker
640         from apple_additions() if it exists.
641
642 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
643
644         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
645         https://bugs.webkit.org/show_bug.cgi?id=174539
646         <rdar://problem/33307395>
647
648         Reviewed by Darin Adler.
649
650         Adds a new unit test suite to cover action sheet popover presentation.
651
652         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
653         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
654         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
655         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
656
657         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
658
659         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
660         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
661
662         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
663
664         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
665         (TestWebKitAPI::TEST):
666
667 2017-07-15  Sam Weinig  <sam@webkit.org>
668
669         [Scripts] Make svn-create-patch work better when called in sub directories
670         https://bugs.webkit.org/show_bug.cgi?id=174551
671
672         Reviewed by Darin Adler.
673
674         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
675           by ensuring that the prefix is applied as is done in generateDiff.
676         - Silence output of explanatory lines from svn stat (" > move to ...")
677           that show up in STDERR when running svn-create-patch.
678         - Add verbose logging that I found useful while debugging this issue.
679
680         * Scripts/svn-create-patch:
681         (findBaseUrl):
682         (findMimeType):
683         (findSourceFileAndRevision):
684         (generateDiff):
685         (generateFileList):
686         (manufacturePatchForAdditionWithHistory):
687
688 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
689
690         Unreviewed build fix after r219537.
691
692         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
693
694 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
695
696         Add iOS 11 SPI
697         https://bugs.webkit.org/show_bug.cgi?id=174430
698         <rdar://problem/33269288>
699
700         Reviewed by Tim Horton.
701
702         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
703         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
704         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
705
706 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
707
708         Failing to install on iPad simulators
709         https://bugs.webkit.org/show_bug.cgi?id=174532
710         <rdar://problem/33328347>
711
712         Reviewed by Stephanie Lewis.
713
714         * Scripts/webkitpy/xcode/simulated_device.py:
715         (SimulatedDevice.install_app): Place install command in retry try-except block.
716
717 2017-07-14  Jeff Miller  <jeffm@apple.com>
718
719         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
720         https://bugs.webkit.org/show_bug.cgi?id=174524
721
722         Reviewed by Sam Weinig.
723
724         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
725         (TEST):
726         Renamed TestParameter to TestParameter1.
727         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
728
729         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
730         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
731         Observe changes for two bundle parameters.
732
733         (-[BundleParametersPlugIn dealloc]):
734         Remove observers for two bundle parameters.
735
736 2017-07-14  Commit Queue  <commit-queue@webkit.org>
737
738         Unreviewed, rolling out r219510.
739         https://bugs.webkit.org/show_bug.cgi?id=174525
740
741         Need to revert length() == 0 check for null string (Requested
742         by yusukesuzuki on #webkit).
743
744         Reverted changeset:
745
746         "[WTF] Newly added AtomicStringImpl should use BufferInternal
747         static string if StringImpl is static"
748         https://bugs.webkit.org/show_bug.cgi?id=174501
749         http://trac.webkit.org/changeset/219510
750
751 2017-07-14  Jer Noble  <jer.noble@apple.com>
752
753         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
754         https://bugs.webkit.org/show_bug.cgi?id=174514
755
756         Reviewed by Sam Weinig.
757
758         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
759         (TestWebKitAPI::TEST_F):
760
761 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
762
763         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
764         https://bugs.webkit.org/show_bug.cgi?id=174501
765
766         Reviewed by Darin Adler.
767
768         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
769         (TestWebKitAPI::TEST):
770
771 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
772
773         Bring mac expectations in-line with other platforms
774         https://bugs.webkit.org/show_bug.cgi?id=174472
775         <rdar://problem/33297388>
776
777         Reviewed by David Kilzer.
778
779         The override order for Mac test expectations does not conform to the pattern used by iOS,
780         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
781
782             platform/mac-wk2
783             platform/wk2
784             platform/mac-elcapitan
785             platform/mac-sierra
786             generic
787
788         After this change, El Capitan's baseline search path looks like this:
789
790             platform/mac-sierra-wk2
791             platform/mac-sierra
792             platform/mac-wk2
793             platform/wk2
794             generic
795
796         * Scripts/webkitpy/port/mac.py:
797         (MacPort.__init__): If a specific version is specified in the port name, use that
798         as the os version.
799         (MacPort.default_baseline_search_path): Expectation search paths should work the
800         same way they do on other ports. Port + version overrides port, port overrides generic
801         and wk1/wk2 should override expectations for the two combined.
802         * Scripts/webkitpy/port/mac_unittest.py:
803         (MacTest.test_tests_for_other_platforms): Deleted.
804         (MacTest._assert_search_path): Deleted.
805         (MacTest.test_baseline_search_path): Deleted.
806         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
807         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
808         (test_rebaseline_test_and_print_scm_changes): Ditto.
809         (test_rebaseline_and_copy_test): Ditto.
810         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
811         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
812         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
813
814 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
815
816         Fix style checker unit test
817
818         Unreviewed WebKit2 => WebKit fixup.
819
820         * Scripts/webkitpy/style/checker_unittest.py:
821         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
822
823 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
824
825         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
826
827         Unreviewed build fix.
828
829         r219492 missed one hunk from its partial revert of r219489.
830         This patch reverts that hunk.
831
832         * TestWebKitAPI/CMakeLists.txt:
833
834 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
835
836         Use the old WebKit/WebKit2 targets for CMake builds.
837
838         Unreviewed build fix.
839
840         We can update the target names to match the Framework names in a future patch.
841         This is a partial revert of r219489.
842
843         * TestWebKitAPI/CMakeLists.txt:
844         WebKitLegacy => WebKit
845         WebKit => WebKit2
846
847 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
848
849         Fix TestWebKit API.
850         https://bugs.webkit.org/show_bug.cgi?id=174164
851         rdar://problem/33137595
852
853         Reviewed by Dan Bernstein.
854
855         * TestWebKitAPI/CMakeLists.txt:
856         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
857         * TestWebKitAPI/PlatformGTK.cmake:
858
859 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
860
861         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
862         https://bugs.webkit.org/show_bug.cgi?id=174164
863         rdar://problem/33137595
864
865         Reviewed by Dan Bernstein.
866
867         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
868         (ShouldBuildTest):
869         * DumpRenderTree/mac/Configurations/Base.xcconfig:
870         * Scripts/build-webkit:
871         * Scripts/do-file-rename:
872         * Scripts/do-webcore-rename:
873         * Scripts/update-webkit-localizable-strings:
874         * Scripts/webkitpy/common/config/watchlist:
875         * Scripts/webkitpy/style/checker.py:
876         * Scripts/webkitpy/style/checkers/featuredefines.py:
877         * gtk/make-dist.py:
878         (ensure_version_if_possible):
879         * gtk/manifest.txt.in:
880
881 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
882
883         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
884         https://bugs.webkit.org/show_bug.cgi?id=174162
885         rdar://problem/33137594
886
887         Reviewed by Dan Bernstein.
888
889         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
890
891         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
892         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
893         * EWSTools/configure-clang-linux.sh:
894         * Scripts/build-webkit:
895         * Scripts/do-file-rename:
896         * Scripts/do-webcore-rename:
897         * Scripts/update-webkit-localizable-strings:
898         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
899         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
900         * Scripts/webkitpy/style/checkers/featuredefines.py:
901         * gtk/manifest.txt.in:
902
903 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
904
905         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
906         https://bugs.webkit.org/show_bug.cgi?id=174438
907         <rdar://problem/33277112>
908
909         Reviewed by Aakash Jain.
910
911         Given a patch, this will convert the changes from the path to the new directory structure.
912
913         * Scripts/rebase-patch-after-webkit-move: Added.
914         (append_source): Append 'Source' to the provided path.
915         (is_editable_line): Return true if a line the script expects to modify.
916         (needs_rebase): Return if a line needs to be rebased based on it's content.
917         (rebase_line): Rebase the provided line.
918         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
919         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
920         were provided.
921
922 2017-07-12  Nan Wang  <n_wang@apple.com>
923
924         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
925         https://bugs.webkit.org/show_bug.cgi?id=174393
926         <rdar://problem/33248006>
927
928         Reviewed by Chris Fleizach.
929
930         * DumpRenderTree/AccessibilityUIElement.cpp:
931         (textMarkerRangeMatchesTextNearMarkersCallback):
932         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
933         (AccessibilityUIElement::getJSClass):
934         * DumpRenderTree/AccessibilityUIElement.h:
935         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
936         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
937         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
938         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
939         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
940         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
941         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
942         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
943
944 2017-07-12  Matt Lewis  <jlewis3@apple.com>
945
946         Unreviewed, rolling out r219409.
947
948         The revision caused the Windows builds to fail.
949
950         Reverted changeset:
951
952         "AX: [iOS] Implement a way to retrieve a text marker range
953         with desired text that is closest to a position"
954         https://bugs.webkit.org/show_bug.cgi?id=174393
955         http://trac.webkit.org/changeset/219409
956
957 2017-07-12  Nan Wang  <n_wang@apple.com>
958
959         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
960         https://bugs.webkit.org/show_bug.cgi?id=174393
961         <rdar://problem/33248006>
962
963         Reviewed by Chris Fleizach.
964
965         * DumpRenderTree/AccessibilityUIElement.cpp:
966         (textMarkerRangeMatchesTextNearMarkersCallback):
967         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
968         (AccessibilityUIElement::getJSClass):
969         * DumpRenderTree/AccessibilityUIElement.h:
970         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
971         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
972         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
973         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
974         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
975         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
976         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
977         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
978
979 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
980
981         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
982         https://bugs.webkit.org/show_bug.cgi?id=174197
983
984         Reviewed by Darin Adler.
985
986         This bit me the first time I tried to submit a patch to WebKit, and still I have
987         to manually edit the ChangeLog every time I use the script.
988
989         This generates a more convenient and standard ChangeLog entry.
990
991         * Scripts/prepare-ChangeLog:
992         (generateNewChangeLogs):
993
994 2017-07-12  Matt Lewis  <jlewis3@apple.com>
995
996         Unreviewed, rolling out r219401.
997
998         This revision rolled out the previous patch, but after talking
999         with reviewer, a rebaseline is what was needed.Rolling back in
1000         before rebaseline.
1001
1002         Reverted changeset:
1003
1004         "Unreviewed, rolling out r219379."
1005         https://bugs.webkit.org/show_bug.cgi?id=174400
1006         http://trac.webkit.org/changeset/219401
1007
1008 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1009
1010         Unreviewed, rolling out r219379.
1011
1012         This revision caused a consistent failure in the test
1013         fast/dom/Window/property-access-on-cached-window-after-frame-
1014         removed.html.
1015
1016         Reverted changeset:
1017
1018         "Remove NAVIGATOR_HWCONCURRENCY"
1019         https://bugs.webkit.org/show_bug.cgi?id=174400
1020         http://trac.webkit.org/changeset/219379
1021
1022 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1023
1024         [WPE] Use libepoxy
1025         https://bugs.webkit.org/show_bug.cgi?id=172104
1026
1027         Reviewed by Michael Catanzaro.
1028
1029         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
1030         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
1031
1032 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1033
1034         [GTK][WPE] Align Jhbuild patches for GStreamer packages
1035         https://bugs.webkit.org/show_bug.cgi?id=174363
1036
1037         Reviewed by Michael Catanzaro.
1038
1039         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
1040         between the GTK+ and WPE port. There's no reason for the two ports to apply
1041         different patches over same versions of GStreamer releases.
1042
1043         This aligns the two ports on this specific issue. Next we'll look into
1044         creating a single GStreamer-specific Jhbuild moduleset that will allow us
1045         to keep these patches in a single place, avoiding duplicate files.
1046
1047         * gtk/jhbuild.modules:
1048         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1049         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
1050         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1051         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
1052
1053 2017-07-11  Dean Jackson  <dino@apple.com>
1054
1055         Remove NAVIGATOR_HWCONCURRENCY
1056         https://bugs.webkit.org/show_bug.cgi?id=174400
1057
1058         Reviewed by Sam Weinig.
1059
1060         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1061
1062 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
1063
1064         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
1065         https://bugs.webkit.org/show_bug.cgi?id=174239
1066
1067         Reviewed by Brady Eidson.
1068
1069         Create windows with specific features set and make sure those are properly reflected in the
1070         WKWindowFeatures object.
1071
1072         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1073         (resetToConsistentState):
1074         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1075         (TEST):
1076
1077 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
1078
1079         Do not duplicate files when deleting directories with svn 1.9
1080         https://bugs.webkit.org/show_bug.cgi?id=174339
1081         <rdar://problem/33226781>
1082
1083         Reviewed by David Kilzer.
1084
1085         * Scripts/svn-create-patch:
1086         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
1087         (generateFileList): Determine which files are deleted because they are part of a
1088         directory being deleted.
1089
1090 2017-07-11  Dean Jackson  <dino@apple.com>
1091
1092         Rolling out r219372.
1093
1094         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1095
1096 2017-07-11  Dean Jackson  <dino@apple.com>
1097
1098         Remove NAVIGATOR_HWCONCURRENCY
1099         https://bugs.webkit.org/show_bug.cgi?id=174400
1100
1101         Reviewed by Sam Weinig.
1102
1103         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1104
1105 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1106
1107         Teach build workers to fetch archives from S3.
1108         https://bugs.webkit.org/show_bug.cgi?id=174384
1109
1110         Reviewed by Aakash Jain.
1111
1112         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1113         (DownloadBuiltProduct):
1114
1115 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1116
1117         Configure buildbot to transfer all archives to S3.
1118         Previously this was Mac only, but it's time to expand!
1119         https://bugs.webkit.org/show_bug.cgi?id=174378
1120         
1121         Reviewed by Aakash Jain.
1122
1123         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1124         (BuildFactory.__init__):
1125
1126 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
1127
1128         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
1129         https://bugs.webkit.org/show_bug.cgi?id=174350
1130
1131         Reviewed by Xabier Rodriguez-Calvar.
1132
1133         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
1134         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
1135         patches are removed. The patches for gst-plugins-good are updated, removing
1136         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
1137         rtpbin elements that will help with the EMEv3 development.
1138
1139         * wpe/jhbuild.modules:
1140         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1141         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1142         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
1143         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1144         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1145         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1146         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1147         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1148         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1149
1150 2017-07-10  John Wilander  <wilander@apple.com>
1151
1152         Resource Load Statistics: Prune statistics in orders of importance
1153         https://bugs.webkit.org/show_bug.cgi?id=174215
1154         <rdar://problem/33164403>
1155
1156         Reviewed by Chris Dumez.
1157
1158         Nest infrastructure. Adds these functions:
1159         1. testRunner.setStatisticsLastSeen()
1160         2. setStatisticsMaxStatisticsEntries()
1161         3. setStatisticsPruneEntriesDownTo()
1162
1163         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1164         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1165         (WTR::TestRunner::setStatisticsLastSeen):
1166         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1167         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1168         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1169         * WebKitTestRunner/TestController.cpp:
1170         (WTR::TestController::setStatisticsLastSeen):
1171         (WTR::TestController::setMaxStatisticsEntries):
1172         (WTR::TestController::setPruneEntriesDownTo):
1173         * WebKitTestRunner/TestController.h:
1174         * WebKitTestRunner/TestInvocation.cpp:
1175         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1176         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1177         (WTR::TestController::setStatisticsLastSeen):
1178         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1179         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1180
1181 2017-07-03  Brian Burg  <bburg@apple.com>
1182
1183         Web Replay: remove some unused code
1184         https://bugs.webkit.org/show_bug.cgi?id=173903
1185
1186         Rubber-stamped by Joseph Pecoraro.
1187
1188         * Scripts/run-input-generator-tests: Removed.
1189         * Scripts/webkitpy/replay/__init__.py: Removed.
1190         * Scripts/webkitpy/replay/main.py: Removed.
1191
1192 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
1193
1194         [WPE] Fix layout test baseline and TestExpectations hierarchy
1195         https://bugs.webkit.org/show_bug.cgi?id=174092
1196
1197         Reviewed by Michael Catanzaro.
1198
1199         Like for the GTK+ port, override the default_baseline_search_path() and
1200         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
1201         Both methods operate on a short list of search paths that defaults to 'wpe' and
1202         'wk2', along with any other user-specified platform directory.
1203
1204         The test_expectations_file_position() method is overridden for testing purposes,
1205         and relevant unit tests are added.
1206
1207         * Scripts/webkitpy/port/wpe.py:
1208         (WPEPort._search_paths):
1209         (WPEPort):
1210         (WPEPort.default_baseline_search_path):
1211         (WPEPort._port_specific_expectations_files):
1212         (WPEPort.test_expectations_file_position):
1213         * Scripts/webkitpy/port/wpe_unittest.py:
1214         (WPEPortTest.test_default_baseline_search_path):
1215         (WPEPortTest):
1216         (WPEPortTest.test_port_specific_expectations_files):
1217
1218 2017-07-10  Chris Dumez  <cdumez@apple.com>
1219
1220         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
1221         https://bugs.webkit.org/show_bug.cgi?id=174301
1222
1223         Reviewed by Brent Fulgham.
1224
1225         Rename some of the testRunner API for clarity and to better match what it calls
1226         internally.
1227
1228         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1229         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1230         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1231         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1232         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1233         * WebKitTestRunner/TestController.cpp:
1234         (WTR::TestController::statisticsUpdateCookiePartitioning):
1235         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1236         * WebKitTestRunner/TestController.h:
1237         * WebKitTestRunner/TestInvocation.cpp:
1238         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1239         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1240         (WTR::TestController::statisticsUpdateCookiePartitioning):
1241         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1242
1243 2017-07-10  Charlie Turner  <cturner@igalia.com>
1244
1245         [GStreamer] Live twitch.tv videos do not play
1246         https://bugs.webkit.org/show_bug.cgi?id=174222
1247
1248         Reviewed by Michael Catanzaro.
1249
1250         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
1251         fixes videos not playing on twitch.tv.
1252
1253         * gtk/jhbuild.modules:
1254
1255 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
1256
1257         Add WebGL2 configuration option to build-webkit
1258         https://bugs.webkit.org/show_bug.cgi?id=174251
1259
1260         Reviewed by Michael Catanzaro.
1261
1262         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
1263         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
1264         is marked as enabled for the Apple Cocoa ports.
1265
1266 2017-07-08  Chris Dumez  <cdumez@apple.com>
1267
1268         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
1269         https://bugs.webkit.org/show_bug.cgi?id=174290
1270
1271         Reviewed by Brent Fulgham.
1272
1273         Rename testRunner API to match the new internal API names.
1274
1275         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1276         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1277         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1278         (WTR::TestRunner::statisticsSubmitTelemetry):
1279         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1280         * WebKitTestRunner/TestController.cpp:
1281         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1282         (WTR::TestController::statisticsSubmitTelemetry):
1283         * WebKitTestRunner/TestController.h:
1284         * WebKitTestRunner/TestInvocation.cpp:
1285         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1286         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1287         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1288         (WTR::TestController::statisticsSubmitTelemetry):
1289
1290 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1291
1292         Drop NOSNIFF compile flag
1293         https://bugs.webkit.org/show_bug.cgi?id=174289
1294
1295         Reviewed by Michael Catanzaro.
1296
1297         * Scripts/webkitperl/FeatureList.pm:
1298         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1299
1300 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1301
1302         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
1303         https://bugs.webkit.org/show_bug.cgi?id=174219
1304         <rdar://problem/32083177>
1305
1306         Reviewed by Ryosuke Niwa.
1307
1308         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
1309         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
1310         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
1311         place.
1312
1313         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
1314         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
1315         no action is taken when dropping.
1316
1317         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
1318         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1319         (TestWebKitAPI::TEST):
1320         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1321         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1322         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1323         (-[MockDragDropSession allowsMoveOperation]):
1324         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
1325         (-[MockDataInteractionSession initWithWindow:allowMove:]):
1326         (-[DataInteractionSimulator initWithWebView:]):
1327         (-[DataInteractionSimulator runFrom:to:]):
1328         (-[DataInteractionSimulator _advanceProgress]):
1329         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
1330         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
1331         (-[MockDataInteractionSession initWithWindow:]): Deleted.
1332
1333 2017-07-07  Commit Queue  <commit-queue@webkit.org>
1334
1335         Unreviewed, rolling out r219238, r219239, and r219241.
1336         https://bugs.webkit.org/show_bug.cgi?id=174265
1337
1338         "fast/workers/dedicated-worker-lifecycle.html is flaky"
1339         (Requested by yusukesuzuki on #webkit).
1340
1341         Reverted changesets:
1342
1343         "[WTF] Implement WTF::ThreadGroup"
1344         https://bugs.webkit.org/show_bug.cgi?id=174081
1345         http://trac.webkit.org/changeset/219238
1346
1347         "Unreviewed, build fix after r219238"
1348         https://bugs.webkit.org/show_bug.cgi?id=174081
1349         http://trac.webkit.org/changeset/219239
1350
1351         "Unreviewed, CLoop build fix after r219238"
1352         https://bugs.webkit.org/show_bug.cgi?id=174081
1353         http://trac.webkit.org/changeset/219241
1354
1355 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1356
1357         [GTK][WPE] Enable X-Content-Type-Options: nosniff
1358         https://bugs.webkit.org/show_bug.cgi?id=174250
1359
1360         Reviewed by Carlos Alberto Lopez Perez.
1361
1362         * Scripts/webkitperl/FeatureList.pm:
1363
1364 2017-07-07  Charlie Turner  <cturner@igalia.com>
1365         [GStreamer] vid.me videos do not play
1366         https://bugs.webkit.org/show_bug.cgi?id=172240
1367
1368         Reviewed by Xabier Rodriguez-Calvar.
1369
1370         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1371         have the existing libsoup build against GNOME to avoid header drift
1372         against GStreamer's linked Soup library.
1373
1374         * gtk/jhbuild.modules:
1375
1376 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1377
1378         Write a support script to enable buildbot to upload to S3
1379         https://bugs.webkit.org/show_bug.cgi?id=174196
1380         
1381         Reviewed by Stephanie Lewis.
1382
1383         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
1384         (uploadToS3):
1385         (archiveExists):
1386
1387 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1388
1389         Enabling uploading archives to S3.
1390         https://bugs.webkit.org/show_bug.cgi?id=174198
1391         
1392         Reviewed by Stephanie Lewis.
1393
1394         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1395         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1396         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1397         (TransferToS3): Transfer full and minified archives to S3
1398
1399 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1400
1401         [WTF] Implement WTF::ThreadGroup
1402         https://bugs.webkit.org/show_bug.cgi?id=174081
1403
1404         Reviewed by Mark Lam.
1405
1406         Add WTF::ThreadGroup tests.
1407
1408         * TestWebKitAPI/CMakeLists.txt:
1409         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1410         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1411         (TestWebKitAPI::TEST):
1412
1413 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1414
1415         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1416         https://bugs.webkit.org/show_bug.cgi?id=174150
1417
1418         Reviewed by Mark Lam.
1419
1420         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1421         (TestWebKitAPI::TEST):
1422         * TestWebKitAPI/TestsController.cpp:
1423         (TestWebKitAPI::TestsController::TestsController):
1424
1425 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1426
1427         Enabling uploading archives to S3.
1428         https://bugs.webkit.org/show_bug.cgi?id=174198
1429         
1430         Reviewed by Lucas Forschler.
1431
1432         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1433         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1434         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1435         (TransferToS3): Transfer full and minified archives to S3
1436
1437 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1438
1439         [GTK][WPE] kill-old-process should kill more webkit related process
1440         https://bugs.webkit.org/show_bug.cgi?id=174220
1441
1442         Reviewed by Michael Catanzaro.
1443
1444         Generate list of possible webkit-related process names and add
1445         them to the list of process to kill.
1446         Also update the possible system related process for GTK+/WPE.
1447
1448         * BuildSlaveSupport/kill-old-processes:
1449         (listAllWebKitPrograms):
1450         (main):
1451
1452 2017-07-06  Chris Dumez  <cdumez@apple.com>
1453
1454         FileMonitor should not be ref counted
1455         https://bugs.webkit.org/show_bug.cgi?id=174166
1456
1457         Reviewed by Brent Fulgham.
1458
1459         Update the API tests to reflect the API change.
1460
1461         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1462         (TestWebKitAPI::TEST_F):
1463
1464 2017-07-06  Commit Queue  <commit-queue@webkit.org>
1465
1466         Unreviewed, rolling out r219194.
1467         https://bugs.webkit.org/show_bug.cgi?id=174207
1468
1469         it broke some layout tests (Requested by clopez on #webkit).
1470
1471         Reverted changeset:
1472
1473         "[GStreamer] vid.me videos do not play"
1474         https://bugs.webkit.org/show_bug.cgi?id=172240
1475         http://trac.webkit.org/changeset/219194
1476
1477 2017-07-06  Matt Lewis  <jlewis3@apple.com>
1478
1479         Unreviewed, rolling out r219178.
1480
1481         This caused a consistent failure with the API test
1482         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
1483
1484         Reverted changeset:
1485
1486         "[WTF] Clean up StringStatics.cpp by using
1487         LazyNeverDestroyed<> for Atoms"
1488         https://bugs.webkit.org/show_bug.cgi?id=174150
1489         http://trac.webkit.org/changeset/219178
1490
1491 2017-07-06  Alicia Boya García  <aboya@igalia.com>
1492
1493         Add CWD to Perl library path (no longer the default since 5.26.0)
1494         https://bugs.webkit.org/show_bug.cgi?id=174200
1495
1496         Reviewed by Michael Catanzaro.
1497
1498         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1499         (SetupGitClone._get_username_and_email):
1500
1501 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1502
1503         Unreviewed, update my email address.
1504
1505         * Scripts/webkitpy/common/config/contributors.json:
1506
1507 2017-07-06  Charlie Turner  <cturner@igalia.com>
1508         [GStreamer] vid.me videos do not play
1509         https://bugs.webkit.org/show_bug.cgi?id=172240
1510
1511         Reviewed by Xabier Rodriguez-Calvar.
1512
1513         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1514         have the existing libsoup build against GNOME to avoid header drift
1515         against GStreamer's linked Soup library.
1516
1517         * gtk/jhbuild.modules:
1518
1519 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1520
1521         [WTF] Move SoftLinking.h into WTF
1522         https://bugs.webkit.org/show_bug.cgi?id=174000
1523
1524         Reviewed by Alex Christensen.
1525
1526         * DumpRenderTree/mac/TestRunnerMac.mm:
1527         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1528         (test_primary_header):
1529         (ErrorCollector.__init__): Deleted.
1530         (ErrorCollector.__call__): Deleted.
1531         (ErrorCollector.results): Deleted.
1532         (ErrorCollector.result_list): Deleted.
1533         (ErrorCollector.verify_all_categories_are_seen): Deleted.
1534         (MockIo.open): Deleted.
1535         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
1536         (CppFunctionsTest.test_create_acronym): Deleted.
1537         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
1538         (CppFunctionsTest.test_parameter): Deleted.
1539         (CppFunctionsTest.test_single_line_view): Deleted.
1540         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
1541         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
1542         (CppFunctionsTest.test_parameter_list): Deleted.
1543         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
1544         (CppStyleTestBase.process_file_data): Deleted.
1545         (CppStyleTestBase.perform_lint): Deleted.
1546         (CppStyleTestBase.perform_single_line_lint): Deleted.
1547         (CppStyleTestBase.perform_multi_line_lint): Deleted.
1548         (CppStyleTestBase.perform_language_rules_check): Deleted.
1549         (CppStyleTestBase.perform_function_lengths_check): Deleted.
1550         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
1551         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
1552         (CppStyleTestBase.perform_include_what_you_use): Deleted.
1553         (CppStyleTestBase.perform_header_guard_check): Deleted.
1554         (CppStyleTestBase.assert_lint): Deleted.
1555         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
1556         (CppStyleTestBase.assert_multi_line_lint): Deleted.
1557         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
1558         (CppStyleTestBase.assert_language_rules_check): Deleted.
1559         (CppStyleTestBase.assert_include_what_you_use): Deleted.
1560         (CppStyleTestBase.assert_header_guard): Deleted.
1561         (CppStyleTestBase.assert_blank_lines_check): Deleted.
1562         (CppStyleTestBase.assert_positions_equal): Deleted.
1563         (FunctionDetectionTest.test_basic_function_detection): Deleted.
1564         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
1565         (FunctionDetectionTest.test_pure_function_detection): Deleted.
1566         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
1567         (FunctionDetectionTest.test_ignore_macros): Deleted.
1568         (FunctionDetectionTest.test_non_functions): Deleted.
1569         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
1570         (FunctionDetectionTest.test_parameter_list): Deleted.
1571         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
1572         (CppStyleTest.test_asm_lines_ignored): Deleted.
1573         (CppStyleTest.test_get_line_width): Deleted.
1574         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
1575         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
1576         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
1577         (CppStyleTest.test_position): Deleted.
1578         (CppStyleTest.test_rfind_in_lines): Deleted.
1579         (CppStyleTest.test_close_expression): Deleted.
1580         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
1581         (CppStyleTest.test_cstyle_cast): Deleted.
1582         (CppStyleTest.test_runtime_casting): Deleted.
1583         (CppStyleTest.test_runtime_selfinit): Deleted.
1584         (CppStyleTest.test_runtime_rtti): Deleted.
1585         (CppStyleTest.test_static_cast_readability): Deleted.
1586         (CppStyleTest.test_check_for_unnamed_params): Deleted.
1587         (CppStyleTest.void): Deleted.
1588         (CppStyleTest.test_deprecated_cast): Deleted.
1589         (CppStyleTest.test_mock_method): Deleted.
1590         (CppStyleTest.test_sizeof_type): Deleted.
1591         (CppStyleTest.cases): Deleted.
1592         (CppStyleTest.for): Deleted.
1593         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
1594         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
1595         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
1596         (CppStyleTest.test_include_what_you_use): Deleted.
1597         (CppStyleTest.test_files_belong_to_same_module): Deleted.
1598         (CppStyleTest.test_cleanse_line): Deleted.
1599         (CppStyleTest.test_multi_line_comments): Deleted.
1600         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
1601         (CppStyleTest.test_multiline_strings): Deleted.
1602         (CppStyleTest.test_platformh_comments): Deleted.
1603         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
1604         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
1605         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
1606         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
1607         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
1608         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
1609         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
1610         (CppStyleTest.test_check_posix_threading): Deleted.
1611         (CppStyleTest.test_insecure_string_operations): Deleted.
1612         (CppStyleTest.test_format_strings): Deleted.
1613         (CppStyleTest.test_insecure_temp_file): Deleted.
1614         (CppStyleTest.test_variable_length_array_detection): Deleted.
1615         (CppStyleTest.test_braces): Deleted.
1616         (CppStyleTest.test_check_check): Deleted.
1617         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
1618         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
1619         (CppStyleTest.test_spacing_for_fncall): Deleted.
1620         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
1621         (CppStyleTest.test_spacing_before_braces): Deleted.
1622         (CppStyleTest.test_spacing_between_braces): Deleted.
1623         (CppStyleTest.test_spacing_before_brackets): Deleted.
1624         (CppStyleTest.test_cpp_lambda_functions): Deleted.
1625         (CppStyleTest.test_objective_c_block): Deleted.
1626         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
1627         (CppStyleTest.test_spacing_around_else): Deleted.
1628         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
1629         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
1630         (CppStyleTest.test_operator_methods): Deleted.
1631         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
1632         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
1633         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
1634         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
1635         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
1636         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
1637         (CppStyleTest.test_space_after_comment_marker): Deleted.
1638         (CppStyleTest.test_newline_at_eof): Deleted.
1639         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
1640         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
1641         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
1642         (CppStyleTest.test_invalid_utf8): Deleted.
1643         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
1644         (CppStyleTest.test_is_blank_line): Deleted.
1645         (CppStyleTest.test_blank_lines_check): Deleted.
1646         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
1647         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
1648         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
1649         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
1650         (CppStyleTest.test_comma): Deleted.
1651         (CppStyleTest.test_declaration): Deleted.
1652         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
1653         (CppStyleTest.test_indent): Deleted.
1654         (CppStyleTest.test_indent.Foo): Deleted.
1655         (CppStyleTest.test_not_alabel): Deleted.
1656         (CppStyleTest.test_tab): Deleted.
1657         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
1658         (CppStyleTest.test_build_class): Deleted.
1659         (CppStyleTest.test_build_class.definitions): Deleted.
1660         (CppStyleTest.test_build_class.Foo): Deleted.
1661         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
1662         (CppStyleTest.test_build_end_comment): Deleted.
1663         (CppStyleTest.test_build_forward_decl): Deleted.
1664         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
1665         (CppStyleTest.test_build_header_guard): Deleted.
1666         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
1667         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
1668         (CppStyleTest.test_build_printf_format): Deleted.
1669         (CppStyleTest.test_runtime_printf_format): Deleted.
1670         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
1671         (CppStyleTest.test_build_storage_class): Deleted.
1672         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
1673         (CppStyleTest.test_build_storage_class.declaration): Deleted.
1674         (CppStyleTest.test_build_storage_class.after): Deleted.
1675         (CppStyleTest.test_build_storage_class.is): Deleted.
1676         (CppStyleTest.test_legal_copyright): Deleted.
1677         (CppStyleTest.test_invalid_increment): Deleted.
1678         (CppStyleTest.test_enum_bitfields): Deleted.
1679         (CppStyleTest.test_plain_integral_bitfields): Deleted.
1680         (CleansedLinesTest.test_init_empty): Deleted.
1681         (CleansedLinesTest.test_collapse_strings): Deleted.
1682         (OrderOfIncludesTest.tearDown): Deleted.
1683         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
1684         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
1685         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
1686         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
1687         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
1688         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
1689         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
1690         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
1691         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
1692         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
1693         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
1694         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
1695         (OrderOfIncludesTest.test_primary_header): Deleted.
1696         (OrderOfIncludesTest.test_public_primary_header): Deleted.
1697         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
1698         (OrderOfIncludesTest.test_classify_include): Deleted.
1699         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
1700         (CheckForFunctionLengthsTest.tearDown): Deleted.
1701         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
1702         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
1703         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
1704         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
1705         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
1706         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
1707         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
1708         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
1709         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
1710         (CheckForFunctionLengthsTest.function_body): Deleted.
1711         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
1712         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
1713         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
1714         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
1715         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
1716         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
1717         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
1718         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
1719         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
1720         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
1721         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
1722         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
1723         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
1724         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
1725         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
1726         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
1727         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
1728         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
1729         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
1730         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
1731         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
1732         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
1733         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
1734         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
1735         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
1736         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
1737         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
1738         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
1739         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
1740         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
1741         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
1742         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
1743         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
1744         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
1745         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
1746         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
1747         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
1748         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
1749         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
1750         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
1751         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
1752         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
1753         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
1754         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
1755         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
1756         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
1757         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
1758         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
1759         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
1760         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
1761         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
1762         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
1763         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
1764         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
1765         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
1766         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
1767         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
1768         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
1769         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
1770         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
1771         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
1772         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
1773         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
1774         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
1775         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
1776         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
1777         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
1778         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
1779         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
1780         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
1781         (LeakyPatternTest.test_get_dc): Deleted.
1782         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
1783         (LeakyPatternTest.test_own_get_dc): Deleted.
1784         (LeakyPatternTest.test_create_dc): Deleted.
1785         (LeakyPatternTest.test_create_compatible_dc): Deleted.
1786         (WebKitStyleTest.test_indentation): Deleted.
1787         (WebKitStyleTest.test_indentation.Foo): Deleted.
1788         (WebKitStyleTest.test_indentation.Document): Deleted.
1789         (WebKitStyleTest.test_spacing): Deleted.
1790         (WebKitStyleTest.test_line_breaking): Deleted.
1791         (WebKitStyleTest.test_braces): Deleted.
1792         (WebKitStyleTest.test_braces.MyClass): Deleted.
1793         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
1794         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
1795         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
1796         (WebKitStyleTest.test_null_false_zero): Deleted.
1797         (WebKitStyleTest.test_directive_indentation): Deleted.
1798         (WebKitStyleTest.test_using_std): Deleted.
1799         (WebKitStyleTest.test_using_namespace): Deleted.
1800         (WebKitStyleTest.test_max_macro): Deleted.
1801         (WebKitStyleTest.test_min_macro): Deleted.
1802         (WebKitStyleTest.test_wtf_move): Deleted.
1803         (WebKitStyleTest.test_ctype_fucntion): Deleted.
1804         (WebKitStyleTest.test_names): Deleted.
1805         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
1806         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
1807         (WebKitStyleTest.test_names.declarations): Deleted.
1808         (WebKitStyleTest.test_names.struct): Deleted.
1809         (WebKitStyleTest.test_names.VectorType): Deleted.
1810         (WebKitStyleTest.test_parameter_names): Deleted.
1811         (WebKitStyleTest.test_comments): Deleted.
1812         (WebKitStyleTest.test_webkit_export_check): Deleted.
1813         (WebKitStyleTest.test_member_initialization_list): Deleted.
1814         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
1815         (WebKitStyleTest.test_other): Deleted.
1816         (CppCheckerTest.mock_handle_style_error): Deleted.
1817         (CppCheckerTest._checker): Deleted.
1818         (CppCheckerTest.test_init): Deleted.
1819         (CppCheckerTest.test_eq): Deleted.
1820         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
1821         (CppCheckerTest.test_ne): Deleted.
1822         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1823         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1824         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1825         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1826         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1827         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1828
1829 2017-07-05  Saam Barati  <sbarati@apple.com>
1830
1831         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
1832         https://bugs.webkit.org/show_bug.cgi?id=174188
1833         <rdar://problem/30581423>
1834
1835         Reviewed by Mark Lam.
1836
1837         * Scripts/run-jsc-stress-tests:
1838
1839 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1840
1841         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1842         https://bugs.webkit.org/show_bug.cgi?id=174150
1843
1844         Reviewed by Mark Lam.
1845
1846         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1847         (TestWebKitAPI::TEST):
1848
1849 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1850
1851         Remove copy of ICU headers from WebKit
1852         https://bugs.webkit.org/show_bug.cgi?id=116407
1853
1854         Reviewed by Alex Christensen.
1855
1856         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1857         * TestWebKitAPI/Configurations/Base.xcconfig:
1858         * WebKitTestRunner/Configurations/Base.xcconfig:
1859
1860 2017-07-05  Chris Dumez  <cdumez@apple.com>
1861
1862         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
1863         https://bugs.webkit.org/show_bug.cgi?id=174163
1864         <rdar://problem/33067518>
1865
1866         Reviewed by Alex Christensen.
1867
1868         Add API test coverage.
1869
1870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1871         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
1872         (TEST):
1873
1874 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1875
1876         When dragging a selection, clearing the selection in dragstart should not crash the web process
1877         https://bugs.webkit.org/show_bug.cgi?id=174142
1878         <rdar://problem/33067501>
1879
1880         Reviewed by Tim Horton.
1881
1882         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
1883         drag is starting up.
1884
1885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1886         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
1887         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1888         (TestWebKitAPI::TEST):
1889
1890 2017-07-05  Daniel Bates  <dabates@apple.com>
1891
1892         Do not pass API::FrameInfo for source frame or clear out page of target frame on
1893         API navigation
1894         https://bugs.webkit.org/show_bug.cgi?id=174170
1895         <rdar://problem/33140328>
1896
1897         Reviewed by Brady Eidson.
1898
1899         Update tests as needed for the behavior change.
1900
1901         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1902         (TEST):
1903
1904 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
1905
1906         Add WebKitPrivateFrameworkStubs for iOS 11
1907         https://bugs.webkit.org/show_bug.cgi?id=173988
1908
1909         Reviewed by David Kilzer.
1910
1911         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
1912         should use the same directory for private framework stubs.
1913         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1914
1915 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
1916
1917         [MediaStream] Protect request and web view during gUM client callback
1918         https://bugs.webkit.org/show_bug.cgi?id=174096
1919         <rdar://problem/32833102>
1920
1921         Reviewed by Youenn Fablet.
1922
1923         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1924         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
1925
1926 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1927
1928         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
1929
1930         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1931
1932 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1933
1934         Unreviewed, rolling out r219128.
1935
1936         Spoke with engineer who originally submitted, Patch for APi
1937         test to follow.
1938
1939         Reverted changeset:
1940
1941         "Unreviewed, rolling out r219070."
1942         https://bugs.webkit.org/show_bug.cgi?id=174082
1943         http://trac.webkit.org/changeset/219128
1944
1945 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1946
1947         Unreviewed, rolling out r219070.
1948
1949         This revision caused consistent failures of the API test
1950         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
1951
1952         Reverted changeset:
1953
1954         "Pasting single words copied to UIPasteboard inserts URLs in
1955         editable areas"
1956         https://bugs.webkit.org/show_bug.cgi?id=174082
1957         http://trac.webkit.org/changeset/219070
1958
1959 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1960
1961         Remove unused EFL logo from bot watcher dashboard
1962         https://bugs.webkit.org/show_bug.cgi?id=174136
1963
1964         Reviewed by Alexey Proskuryakov.
1965
1966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
1967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
1968
1969 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1970
1971         [GTK] Add more GTK bots to dashboard
1972         https://bugs.webkit.org/show_bug.cgi?id=174129
1973
1974         Reviewed by Carlos Alberto Lopez Perez.
1975
1976         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
1977         them.
1978
1979         This also changes the sort order to put WPE above GTK so that it's not buried under all the
1980         less-essential GTK bots.
1981
1982         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1984         (WebKitBuildbot):
1985
1986 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1987
1988         [WPE] Add WPE to bot watcher dashboard
1989         https://bugs.webkit.org/show_bug.cgi?id=174119
1990
1991         Reviewed by Alexey Proskuryakov.
1992
1993         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
1994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
1995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
1996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1997         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1998         (WebKitBuildbot):
1999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2000         (table.queue-grid tr.platform.linux-wpe img.logo):
2001
2002 2017-07-03  Lucas Forschler  <lforschler@apple.com>
2003
2004         https://bugs.webkit.org/show_bug.cgi?id=174105
2005         
2006         Reviewed by Stephanie Lewis.
2007
2008         * BuildSlaveSupport/built-product-archive:
2009         (main): Add a -minify parser option
2010         (createZip): Pass along the optional Minify argument if requested
2011         (minifySource): This will trim down archives, logic limited to Mac platform.
2012
2013 2017-07-03  Matt Rajca  <mrajca@apple.com>
2014
2015         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
2016         https://bugs.webkit.org/show_bug.cgi?id=174103
2017
2018         Reviewed by Alex Christensen.
2019
2020         Added an API test.
2021
2022         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
2023         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2024         (TEST): Added test.
2025         * TestWebKitAPI/cocoa/TestWKWebView.h:
2026         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2027         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
2028
2029 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2030
2031         Unreviewed, rolling out r219103.
2032
2033         Caused multiple build failures.
2034
2035         Reverted changeset:
2036
2037         "Remove copy of ICU headers from WebKit"
2038         https://bugs.webkit.org/show_bug.cgi?id=116407
2039         http://trac.webkit.org/changeset/219103
2040
2041 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2042
2043         Remove copy of ICU headers from WebKit
2044         https://bugs.webkit.org/show_bug.cgi?id=116407
2045
2046         Reviewed by Alex Christensen.
2047
2048         Use WTF's copy of ICU headers.
2049
2050         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2051         * TestWebKitAPI/Configurations/Base.xcconfig:
2052         * WebKitTestRunner/Configurations/Base.xcconfig:
2053
2054 2017-07-03  Brady Eidson  <beidson@apple.com>
2055
2056         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2057         https://bugs.webkit.org/show_bug.cgi?id=174073
2058
2059         Reviewed by Andy Estes.
2060
2061         * DumpRenderTree/mac/TestRunnerMac.mm:
2062         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
2063
2064         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
2065         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2066
2067 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2068
2069         Unreviewed, rolling out r219083.
2070
2071         The revision caused an API failure on all testing platforms.
2072
2073         Reverted changeset:
2074
2075         "[MediaStream] Protect request and web view during gUM client
2076         callback"
2077         https://bugs.webkit.org/show_bug.cgi?id=174096
2078         http://trac.webkit.org/changeset/219083
2079
2080 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
2081
2082         webkitpy: Properly number duplicated crashlogs
2083         https://bugs.webkit.org/show_bug.cgi?id=172002
2084
2085         Reviewed by Aakash Jain.
2086
2087         * Scripts/webkitpy/common/system/crashlogs.py:
2088         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
2089         an increasing integer.
2090         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2091         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
2092         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
2093         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
2094
2095 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
2096
2097         WebContent processes crash when the network process crashes with pending connection requests
2098         https://bugs.webkit.org/show_bug.cgi?id=174065
2099         <rdar://problem/30359835>
2100
2101         Reviewed by Tim Horton.
2102
2103         Add a API to ensure UI process tries to relaunch a new network process when the network process
2104         crashes with pending network connection requests.
2105
2106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2107         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
2108         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2109         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2110         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
2111
2112 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
2113
2114         [MediaStream] Protect request and web view during gUM client callback
2115         https://bugs.webkit.org/show_bug.cgi?id=174096
2116         <rdar://problem/32833102>
2117
2118         Reviewed by Youenn Fablet.
2119
2120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2121         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2122
2123 2017-07-03  Andy Estes  <aestes@apple.com>
2124
2125         [Xcode] Add an experimental setting to build with ccache
2126         https://bugs.webkit.org/show_bug.cgi?id=173875
2127
2128         Reviewed by Tim Horton.
2129
2130         On systems that already have ccache(1) installed, this patch adds experimental support for
2131         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
2132
2133         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
2134         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
2135         find the toolchain from which to run clang, and then invokes ccache with the required
2136         arguments.
2137
2138         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
2139         precompiled headers to work properly [1].
2140
2141         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
2142         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
2143         during linking.
2144         
2145         [1] https://ccache.samba.org/manual.html#_precompiled_headers
2146
2147         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2148         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2149         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2150         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2151         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
2152         * ccache/README.md: Added.
2153         * ccache/ccache-clang: Added.
2154         * ccache/ccache-clang++: Added.
2155         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
2156
2157 2017-07-03  Alex Christensen  <achristensen@webkit.org>
2158
2159         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2160         https://bugs.webkit.org/show_bug.cgi?id=174051
2161
2162         Reviewed by Tim Horton.
2163
2164         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2165         (TestWebKitAPI::TEST_F):
2166
2167 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2168
2169         Unreviewed, rolling out r219024.
2170
2171         This patch cause 3 didferent test to fail.
2172
2173         Reverted changeset:
2174
2175         "REGRESSION(r215096) Queries of URLs with non-special schemes
2176         should not percent-encode single quotes"
2177         https://bugs.webkit.org/show_bug.cgi?id=174051
2178         http://trac.webkit.org/changeset/219024
2179
2180 2017-07-03  Chris Dumez  <cdumez@apple.com>
2181
2182         Drop ResourceLoadStatisticsStore's statisticsLock
2183         https://bugs.webkit.org/show_bug.cgi?id=174080
2184
2185         Reviewed by Brent Fulgham.
2186
2187         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
2188
2189         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2190         (WTR::TestController::isStatisticsPrevalentResource):
2191         (WTR::TestController::isStatisticsHasHadUserInteraction):
2192         (WTR::TestController::isStatisticsGrandfathered):
2193
2194 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2195
2196         Pasting single words copied to UIPasteboard inserts URLs in editable areas
2197         https://bugs.webkit.org/show_bug.cgi?id=174082
2198         <rdar://problem/33046992>
2199
2200         Reviewed by Tim Horton.
2201
2202         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
2203
2204         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2205         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2206         (TestWebKitAPI::TEST):
2207
2208 2017-07-02  Brady Eidson  <beidson@apple.com>
2209
2210         Add API test for all parts of WebKit1 API related to favicons.
2211         https://bugs.webkit.org/show_bug.cgi?id=174069
2212
2213         Reviewed by Andy Estes.
2214
2215         These two API tests cover all WebKit1 API related to icons.
2216         
2217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2218         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
2219         (mainResourceData):
2220         (defaultFaviconData):
2221         (customFaviconData):
2222         (imageFromData):
2223         (+[IconLoadingProtocol canInitWithRequest:]):
2224         (+[IconLoadingProtocol canonicalRequestForRequest:]):
2225         (-[IconLoadingProtocol startLoading]):
2226         (-[IconLoadingProtocol stopLoading]):
2227         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2228         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2229         (TestWebKitAPI::TEST):
2230
2231 2017-07-01  Dan Bernstein  <mitz@apple.com>
2232
2233         [iOS] Remove code only needed when building for iOS 9.x
2234         https://bugs.webkit.org/show_bug.cgi?id=174068
2235
2236         Reviewed by Tim Horton.
2237
2238         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2239         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2240         (WTR::initializeWebViewConfiguration):
2241         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2242         (-[HIDEventGenerator _createIOHIDEventType:]):
2243
2244 2017-07-01  Brady Eidson  <beidson@apple.com>
2245
2246         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
2247         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
2248
2249         Reviewed by Alex Christensen.
2250
2251         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2252
2253 2017-07-01  Dan Bernstein  <mitz@apple.com>
2254
2255         [macOS] Remove code only needed when building for OS X Yosemite
2256         https://bugs.webkit.org/show_bug.cgi?id=174067
2257
2258         Reviewed by Tim Horton.
2259
2260         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2261         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2262         * DumpRenderTree/mac/DumpRenderTree.mm:
2263         (setDefaultsToConsistentValuesForTesting):
2264         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2265         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2266         * MiniBrowser/Configurations/Base.xcconfig:
2267         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2268         * TestWebKitAPI/Configurations/Base.xcconfig:
2269         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2270         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2271         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2272         (TestWebKitAPI::TEST_F):
2273         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2274         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2275         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2276         (TestWebKitAPI::TEST_F):
2277         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2278         (TestWebKitAPI::TEST):
2279         * WebKitTestRunner/Configurations/Base.xcconfig:
2280         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2281         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2282         (WTR::InjectedBundle::platformInitialize):
2283         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2284         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2285
2286 2017-07-01  Chris Dumez  <cdumez@apple.com>
2287
2288         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
2289         https://bugs.webkit.org/show_bug.cgi?id=174060
2290
2291         Reviewed by Brent Fulgham.
2292
2293         Port WebKitTestRunner over to the new Cocoa SPI.
2294
2295         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2296         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2297         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2298         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
2299         no-ops since this code runs in the WebContent process, not the
2300         UIProcess.
2301
2302         * WebKitTestRunner/TestController.cpp:
2303         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2304
2305 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2306
2307         Unreviewed mac build fix.
2308
2309         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2310         (TestWebKitAPI::TEST):
2311
2312 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2313
2314         Add API to get WKActivatedElementInfo
2315         https://bugs.webkit.org/show_bug.cgi?id=174001
2316         <rdar://problem/29165518>
2317         
2318         Tests for now SPI to get activatedElementInfo.
2319
2320         Reviewed by Tim Horton.
2321
2322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2323         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
2324         (TestWebKitAPI::TEST):
2325
2326 2017-06-30  Chris Dumez  <cdumez@apple.com>
2327
2328         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
2329         https://bugs.webkit.org/show_bug.cgi?id=174038
2330
2331         Reviewed by Brent Fulgham.
2332
2333         Fix typo in API name.
2334
2335         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2336         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2337         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2338         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2339         * WebKitTestRunner/TestController.cpp:
2340         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2341         * WebKitTestRunner/TestController.h:
2342         * WebKitTestRunner/TestInvocation.cpp:
2343         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2344
2345 2017-06-30  Alex Christensen  <achristensen@webkit.org>
2346
2347         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2348         https://bugs.webkit.org/show_bug.cgi?id=174051
2349         <rdar://problem/33002846>
2350
2351         Reviewed by Tim Horton.
2352
2353         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2354         (TestWebKitAPI::TEST_F):
2355
2356 2017-06-30  Daniel Bates  <dabates@apple.com>
2357
2358         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2359         https://bugs.webkit.org/show_bug.cgi?id=165160
2360         <rdar://problem/29451999>
2361
2362         Reviewed by Brady Eidson.
2363
2364         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
2365         for navigations and window creation.
2366
2367         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2368         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
2369         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2370         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
2371         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2372         (TEST):
2373
2374 2017-06-29  Jer Noble  <jer.noble@apple.com>
2375
2376         Make Legacy EME API controlled by RuntimeEnabled setting.
2377         https://bugs.webkit.org/show_bug.cgi?id=173994
2378
2379         Reviewed by Sam Weinig.
2380
2381         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2382
2383 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2384
2385         Follow-up fix for r218996
2386
2387         Unreviewed infrastructure fix.
2388
2389         Repeated calls to 'ios_version' make the log noisy, memoize the function.
2390
2391         * Scripts/webkitpy/port/ios_simulator.py:
2392         (IOSSimulatorPort): Memoize ios_version().
2393
2394 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2395
2396         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2397         https://bugs.webkit.org/show_bug.cgi?id=174017
2398         <rdar://problem/32959782>
2399
2400         Reviewed by Simon Fraser.
2401
2402         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
2403         changes, the caret would appear outside of the iframe.
2404
2405         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2406         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
2407         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2408         (checkDragCaretRectIsContainedInRect):
2409         (TestWebKitAPI::TEST):
2410         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2411         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2412         (-[DataInteractionSimulator _resetSimulatedState]):
2413         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2414         (-[DataInteractionSimulator _advanceProgress]):
2415         (-[DataInteractionSimulator lastKnownDragCaretRect]):
2416
2417 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2418
2419         Add support for different versions of iOS when loading test expectations
2420         https://bugs.webkit.org/show_bug.cgi?id=173774
2421         <rdar://problem/32951132>
2422
2423         Rubber-stamped by Aakash Jain.
2424
2425         When running layout tests, we should support multiple version of iOS the same way we do Mac.
2426
2427         * Scripts/webkitpy/port/ios.py:
2428         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
2429         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
2430         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
2431         * Scripts/webkitpy/port/ios_device.py:
2432         (IOSDevicePort.ios_version): Ask connected devices for implementation.
2433         * Scripts/webkitpy/port/ios_device_unittest.py:
2434         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
2435         (IOSDeviceTest.test_baseline_searchpath): Ditto.
2436         (IOSDeviceTest.test_expectations_ordering): Ditto.
2437         * Scripts/webkitpy/port/ios_simulator.py:
2438         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
2439         ask the platform.
2440
2441 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
2442
2443         Fontconfig build breaks with glibc 2.15+
2444         https://bugs.webkit.org/show_bug.cgi?id=174019
2445
2446         Reviewed by Carlos Alberto Lopez Perez.
2447
2448         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
2449
2450         * wpe/jhbuild.modules:
2451         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
2452
2453 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2454
2455         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
2456         https://bugs.webkit.org/show_bug.cgi?id=174010
2457         <rdar://problem/32597802>
2458
2459         Reviewed by Tim Horton.
2460
2461         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
2462         snapshot fails for any reason.
2463
2464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2465         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
2466         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2467         (TestWebKitAPI::TEST):
2468
2469 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
2470
2471         AX: Cannot call setValue() on contenteditable or ARIA text controls
2472         https://bugs.webkit.org/show_bug.cgi?id=173520
2473
2474         Reviewed by Ryosuke Niwa.
2475
2476         Add setValue() method to WKTR (already existed in DRT).
2477
2478         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2479         (WTR::AccessibilityUIElement::setValue):
2480         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2481         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2482         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2483         (WTR::AccessibilityUIElement::setValue):
2484
2485 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2486
2487         getBoundingClientRect returns wrong value for combination of page zoom and scroll
2488         https://bugs.webkit.org/show_bug.cgi?id=173841
2489         rdar://problem/32983841
2490
2491         Reviewed by Dean Jackson.
2492
2493         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
2494         always did text zooming.
2495
2496         * MiniBrowser/mac/WK1BrowserWindowController.m:
2497         (-[WK1BrowserWindowController zoomIn:]):
2498         (-[WK1BrowserWindowController zoomOut:]):
2499         (-[WK1BrowserWindowController canResetZoom]):
2500         (-[WK1BrowserWindowController resetZoom:]):
2501
2502 2017-06-29  John Wilander  <wilander@apple.com>
2503
2504         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
2505         https://bugs.webkit.org/show_bug.cgi?id=173940
2506         <rdar://problem/33018125>
2507
2508         Reviewed by Brent Fulgham.
2509
2510         This change allows the TestController to turn off
2511         regular resource load statistics telemetry submission
2512         and to manually control when telemetry is calculated
2513         and submitted.
2514
2515         * WebKitTestRunner/TestController.cpp:
2516         (WTR::TestController::initialize):
2517             Turns off automatic resource load statistics telemetry submission.
2518
2519 2017-06-29  Commit Queue  <commit-queue@webkit.org>
2520
2521         Unreviewed, rolling out r218512.
2522         https://bugs.webkit.org/show_bug.cgi?id=173981
2523
2524         "It changes the behavior of the JS API's JSEvaluateScript
2525         which breaks TurboTax" (Requested by saamyjoon on #webkit).
2526
2527         Reverted changeset:
2528
2529         "test262: Completion values for control flow do not match the
2530         spec"
2531         https://bugs.webkit.org/show_bug.cgi?id=171265
2532         http://trac.webkit.org/changeset/218512
2533
2534 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
2535
2536         Add WebKitSystemInterface for iOS 11
2537         https://bugs.webkit.org/show_bug.cgi?id=173936
2538
2539         Reviewed by Lucas Forschler.
2540
2541         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
2542
2543 2017-06-28  Keith Miller  <keith_miller@apple.com>
2544
2545         VMTraps has some races
2546         https://bugs.webkit.org/show_bug.cgi?id=173941
2547
2548         Reviewed by Michael Saboff.
2549
2550         Add new testing mode for testing the Watchdog with our stress
2551         tests.
2552
2553         * Scripts/run-jsc-stress-tests:
2554
2555 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2556
2557         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
2558         https://bugs.webkit.org/show_bug.cgi?id=173877
2559
2560         Reviewed by Brady Eidson.
2561
2562         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
2563         the next tests.
2564
2565         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2566         (testGetFavicon):
2567
2568 2017-06-28  Tim Horton  <timothy_horton@apple.com>
2569
2570         MobileSafari was constantly using 10-15% CPU viewing a PDF
2571         https://bugs.webkit.org/show_bug.cgi?id=173944
2572         <rdar://problem/33039910>
2573
2574         Reviewed by Simon Fraser.
2575
2576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2577         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2578         Add a test that we ever call the stable presentation update callback
2579         when we have a WKPDFView up, instead of infinitely looping.
2580
2581 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2582
2583         Prevent displaying URLs with small capital letters
2584         https://bugs.webkit.org/show_bug.cgi?id=173949
2585         <rdar://problem/32952058>
2586
2587         Reviewed by Brent Fulgham.
2588
2589         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2590         (TestWebKitAPI::TEST):
2591
2592 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2593
2594         Unreviewed test fix.
2595
2596         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
2597
2598         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
2599
2600 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2601
2602         Teach ResourceLoadStatistics to recognize changes in the file system
2603         https://bugs.webkit.org/show_bug.cgi?id=173800
2604         <rdar://problem/32937842>
2605
2606         Reviewed by Chris Dumez.
2607
2608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2609         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
2610         (TestWebKitAPI::FileMonitorTest::tempFilePath):
2611         (TestWebKitAPI::handleFileModification):
2612         (TestWebKitAPI::handleFileDeletion):
2613         (TestWebKitAPI::resetTestState):
2614         (TestWebKitAPI::TEST_F):
2615
2616 2017-06-28  Brady Eidson  <beidson@apple.com>
2617
2618         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
2619         https://bugs.webkit.org/show_bug.cgi?id=173874
2620
2621         Reviewed by Alex Christensen.
2622
2623         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2624
2625 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
2626
2627         Unreviewed, adding Don Olmstead to contributors.json
2628
2629         * Scripts/webkitpy/common/config/contributors.json:
2630
2631 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2632
2633         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
2634         https://bugs.webkit.org/show_bug.cgi?id=173886
2635         <rdar://problem/32543191>
2636
2637         Reviewed by Andy Estes.
2638
2639         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2640         (ParsedRange::ParsedRange):
2641         (-[TestSchemeHandler initWithVideoData:]):
2642         (-[TestSchemeHandler webView:startURLSchemeTask:]):
2643         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
2644         (TEST):
2645
2646 2017-06-27  JF Bastien  <jfbastien@apple.com>
2647
2648         WebAssembly: running out of executable memory should throw OoM
2649         https://bugs.webkit.org/show_bug.cgi?id=171537
2650         <rdar://problem/32963338>
2651
2652         Reviewed by Saam Barati.
2653
2654         * Scripts/run-jsc-stress-tests: add a configuration which runs the
2655         tests under limited executable memory and avoids non-WebAssembly
2656         code generation so that we more reliably run out of executable
2657         memory in WebAssembly.
2658
2659 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2660
2661         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2662         https://bugs.webkit.org/show_bug.cgi?id=173854
2663         <rdar://problem/32236827>
2664
2665         Reviewed by Ryosuke Niwa and Tim Horton.
2666
2667         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
2668
2669         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2670         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
2671         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2672         (TestWebKitAPI::TEST):
2673
2674 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
2675
2676         [PAL] Add symbol export macros for PAL
2677         https://bugs.webkit.org/show_bug.cgi?id=171519
2678
2679         Reviewed by Konstantin Tokarev.
2680
2681         * DumpRenderTree/config.h:
2682         * TestWebKitAPI/CMakeLists.txt:
2683         * TestWebKitAPI/config.h:
2684         * WebKitTestRunner/config.h:
2685
2686 2017-06-27  John Wilander  <wilander@apple.com>
2687
2688         Resource Load Statistics: Add telemetry
2689         https://bugs.webkit.org/show_bug.cgi?id=173499
2690         <rdar://problem/32826094>
2691
2692         Reviewed by Brent Fulgham.
2693
2694         Adds three new testRunner functions:
2695         - installStatisticsDidRunTelemetryCallback()
2696         - statisticsFireTelemetryHandler()
2697         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
2698
2699         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2700         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2701         (WTR::InjectedBundle::didReceiveMessageToPage):
2702         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2703         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
2704         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
2705         (WTR::TestRunner::statisticsFireTelemetryHandler):
2706         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2707         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2708         * WebKitTestRunner/TestController.cpp:
2709         (WTR::TestController::resetStateToConsistentValues):
2710         (WTR::TestController::statisticsFireTelemetryHandler):
2711         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2712         * WebKitTestRunner/TestController.h:
2713         * WebKitTestRunner/TestInvocation.cpp:
2714         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2715
2716 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
2717
2718         Add missing includes to fix compilation error on FreeBSD
2719         https://bugs.webkit.org/show_bug.cgi?id=172919
2720
2721         Reviewed by Mark Lam.
2722
2723         * ImageDiff/cairo/PlatformImageCairo.cpp:
2724
2725 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
2726
2727         Unreviewed, rolling out r218783.
2728
2729         Causing accessibility/mac/setting-attributes-is-
2730         asynchronous.html to crash consistently on mac-wk2 Debug
2731
2732         Reverted changeset:
2733
2734         "AX: Cannot call setValue() on contenteditable or ARIA text
2735         controls"
2736         https://bugs.webkit.org/show_bug.cgi?id=173520
2737         http://trac.webkit.org/changeset/218783
2738
2739 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2740
2741         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
2742         https://bugs.webkit.org/show_bug.cgi?id=173825
2743
2744         Reviewed by Saam Barati.
2745
2746         * DumpRenderTree/JavaScriptThreading.cpp:
2747         (runJavaScriptThread):
2748         (startJavaScriptThreads):
2749         * DumpRenderTree/mac/DumpRenderTree.mm:
2750         (runThread):
2751         (runPthread):
2752         (testThreadIdentifierMap):
2753
2754 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2755
2756         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
2757         <https://webkit.org/b/173837>
2758
2759         Reviewed by Geoffrey Garen.
2760
2761         The clang static analyzer can't reason about objects that are
2762         assigned to a delegate as +1 retained, and then released
2763         later in a different method when the delegate is cleared.
2764
2765         Instead, use a common idiom where the object setting the
2766         delegate retains it as an instance variable on initialization.
2767         Then the same object clears the delegate and releases its
2768         instance variable during teardown.
2769
2770         Also add EXPECT_TRUE() tests to make sure the delegate objects
2771         match before teardown.
2772
2773         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2774         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2775         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2776         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2777         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2778         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
2779
2780 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2781
2782         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
2783         <https://webkit.org/b/173836>
2784
2785         Reviewed by Brady Eidson.
2786
2787         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2788         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
2789         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
2790         objects in this test.
2791
2792 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
2793
2794         [ATK] Add support for aria-details and aria-errormessage
2795         https://bugs.webkit.org/show_bug.cgi?id=172588
2796
2797         Reviewed by Chris Fleizach.
2798
2799         Add additional methods to test ARIA properties which are exposed via
2800         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
2801         to versions which support the details and error-message relation types.
2802
2803         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2804         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2805         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2806         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2807         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2808         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2809         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2810         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2811         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2812         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2813         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2814         * gtk/jhbuild.modules:
2815
2816 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2817
2818         Unreviewed. Add libfii to GTK+ install dependencies script.
2819
2820         * gtk/install-dependencies:
2821
2822 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2823
2824         Unreviewed, rolling out r215190.
2825
2826         Broke product select element on GNOME Bugzilla
2827
2828         Reverted changeset:
2829
2830         "[GTK] Misplaced right click menu on web page due to
2831         deprecated gtk_menu_popup()"
2832         https://bugs.webkit.org/show_bug.cgi?id=170553
2833         http://trac.webkit.org/changeset/215190
2834
2835 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
2836
2837         Remove Reflect.enumerate
2838         https://bugs.webkit.org/show_bug.cgi?id=173806
2839
2840         Reviewed by Yusuke Suzuki.
2841
2842         * Scripts/run-jsc-stress-tests:
2843
2844 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
2845
2846         AX: Cannot call setValue() on contenteditable or ARIA text controls
2847         https://bugs.webkit.org/show_bug.cgi?id=173520
2848
2849         Reviewed by Ryosuke Niwa.
2850
2851         Add setValue() method to WKTR (already existed in DRT).
2852
2853         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2854         (WTR::AccessibilityUIElement::setValue):
2855         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2856         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2857         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2858         (WTR::AccessibilityUIElement::setValue):
2859
2860 2017-06-23  Keith Miller  <keith_miller@apple.com>
2861
2862         Switch VMTraps to use halt instructions rather than breakpoint instructions
2863         https://bugs.webkit.org/show_bug.cgi?id=173677
2864
2865         Reviewed by JF Bastien.
2866
2867         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2868         (TEST):
2869
2870 2017-06-23  Youenn Fablet  <youenn@apple.com>
2871
2872         Set getUserMedia permission to true by default on WTR
2873         https://bugs.webkit.org/show_bug.cgi?id=173610
2874
2875         Reviewed by Alex Christensen.
2876
2877         Adding a way to reset the getUserMedia permission to pending.
2878
2879         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2880         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2881         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
2882         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2883         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2884         (WTR::TestRunner::setUserMediaPermissionAsUnset):
2885         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2886         * WebKitTestRunner/TestController.cpp:
2887         (WTR::TestController::resetStateToConsistentValues):
2888         (WTR::TestController::setUserMediaPermissionAsUnset):
2889         * WebKitTestRunner/TestController.h:
2890         * WebKitTestRunner/TestInvocation.cpp:
2891         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2892
2893 2017-06-23  Alex Christensen  <achristensen@webkit.org>
2894
2895         Add SPI to WKURLSchemeTask for redirection
2896         https://bugs.webkit.org/show_bug.cgi?id=173730
2897
2898         Reviewed by Brady Eidson.
2899
2900         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2901         (-[SchemeHandler webView:startURLSchemeTask:]):
2902         (-[SchemeHandler webView:stopURLSchemeTask:]):
2903         (TEST):
2904         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
2905         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
2906         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
2907         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
2908         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
2909
2910 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2911
2912         [WPE] Use JSC API to send script messages from web extension in tests
2913         https://bugs.webkit.org/show_bug.cgi?id=173757
2914
2915         Reviewed by Žan Doberšek.
2916
2917         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
2918         to run postMessage().
2919
2920         Fixes: /wpe/WebKitSecurityManager/file-xhr
2921                /wpe/WebKitConsoleMessage/console-api
2922                /wpe/WebKitConsoleMessage/js-exception
2923                /wpe/WebKitConsoleMessage/network-error
2924                /wpe/WebKitConsoleMessage/security-error
2925
2926         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2927         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
2928         (beforeAll): Ditto.
2929         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2930         (testWebContextSecurityFileXHR): Ditto.
2931         (beforeAll): Ditto.
2932         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2933         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
2934         (pageCreatedCallback): Remove ifdefs.
2935
2936 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2937
2938         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
2939
2940         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
2941         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
2942         doesn't exist yet in WPE.
2943
2944         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2945         (testWebViewJavaScriptDialogs):
2946         (testWebViewWindowProperties):
2947
2948 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2949
2950         [GTK] Upgrade pixman and cairo in jhbuild
2951         https://bugs.webkit.org/show_bug.cgi?id=173710
2952
2953         Reviewed by Carlos Alberto Lopez Perez.
2954
2955         * gtk/jhbuild.modules:
2956
2957 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2958
2959         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
2960         https://bugs.webkit.org/show_bug.cgi?id=173711
2961
2962         Reviewed by Carlos Alberto Lopez Perez.
2963
2964         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
2965         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
2966
2967         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2968         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
2969
2970 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2971
2972         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
2973         <https://webkit.org/b/173721>
2974
2975         Reviewed by Joseph Pecoraro.
2976
2977         Use RetainPtr<> to create NSMutableDictionary and NSNumber
2978         objects to fix leaks and to avoid the autoreleasepool.
2979
2980         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
2981         (TEST):
2982
2983 2017-06-22  Matt Lewis  <jlewis3@apple.com>
2984
2985         Unreviewed, rolling out r218633.
2986
2987         The test is failing frequently on Sierra Debug and Windows
2988
2989         Reverted changeset:
2990
2991         "AX: Cannot call setValue() on contenteditable or ARIA text
2992         controls"
2993         https://bugs.webkit.org/show_bug.cgi?id=173520
2994         http://trac.webkit.org/changeset/218633
2995
2996 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2997
2998         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
2999         <https://webkit.org/b/173690>
3000
3001         Reviewed by Chris Dumez.
3002
3003         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
3004         ownership of malloc()-ed memory, then frees it when it's
3005         released.  These tests were passing global variables into the
3006         method, which is not malloc()-ed memory, which violates the API
3007         contract.
3008
3009         The fix is to switch to use
3010         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
3011         NO for the last argument.
3012
3013         Caught by the clang static analyzer.
3014
3015         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3016         (TEST):
3017         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3018         (TEST):
3019
3020 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3021
3022         [GTK] Upgrade Harfbuzz to version 1.4.2
3023         https://bugs.webkit.org/show_bug.cgi?id=173592
3024
3025         Reviewed by Carlos Alberto Lopez Perez.
3026
3027         * gtk/jhbuild.modules:
3028
3029 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3030
3031         [WPE] Update WPEBackend-mesa
3032         https://bugs.webkit.org/show_bug.cgi?id=173705
3033
3034         Reviewed by Carlos Alberto Lopez Perez.
3035
3036         A crash has been fixed, needed for unit tests to work.
3037
3038         * wpe/jhbuild.modules:
3039
3040 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3041
3042         Remove unused coordinated graphics C API
3043         https://bugs.webkit.org/show_bug.cgi?id=173706
3044
3045         Reviewed by Žan Doberšek.
3046
3047         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
3048         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
3049         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
3050         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
3051         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
3052         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
3053
3054 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3055
3056         [WPE] Build glib API tests
3057         https://bugs.webkit.org/show_bug.cgi?id=173702
3058
3059         Reviewed by Žan Doberšek.
3060
3061         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
3062         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
3063         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
3064         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
3065         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
3066         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
3067         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
3068         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
3069         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
3070         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
3071         and implement the missing features.
3072
3073         * CMakeLists.txt:
3074         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
3075         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3076         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3077         (testAutomationSessionRequestSession):
3078         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3079         (testWebKitWebViewSessionState):
3080         (testWebKitWebViewSessionStateWithFormData):
3081         (testWebKitWebViewNavigationAfterSessionRestore):
3082         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3083         (beforeAll):
3084         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3085         (testCookieManagerEphemeral):
3086         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3087         (testBlobDownload):
3088         (beforeAll):
3089         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3090         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3091         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3092         (testProcessPerWebView):
3093         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3094         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3095         (testWebViewCreateNavigationData):
3096         (testWebViewJavaScriptDialogs):
3097         (testWebViewWindowProperties):
3098         (testWebViewMouseTarget):
3099         (testWebViewGeolocationPermissionRequests):
3100         (testWebViewUserMediaPermissionRequests):
3101         (testWebViewAudioOnlyUserMediaPermissionRequests):
3102         (testWebViewFileChooserRequest):
3103         (beforeAll):
3104         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3105         (beforeAll):
3106         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3107         (testPrivateBrowsing):
3108         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3109         (testFindControllerHide):
3110         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3111         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3112         (testWebKitSettings):
3113         (beforeAll):
3114         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3115         (testWebViewNewWithUserContentManager):
3116         (beforeAll):
3117         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3118         (testWebContextEphemeral):
3119         (testWebContextProxySettings):
3120         (beforeAll):
3121         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3122         (testWebViewWebContext):
3123         (testWebViewWebContextLifetime):
3124         (testWebViewEphemeral):
3125         (testWebViewSettings):
3126         (testWebViewCanShowMIMEType):
3127         (testWebViewPageVisibility):
3128         (testWebViewIsPlayingAudio):
3129         (beforeAll):
3130         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3131         (testWebsiteDataEphemeral):
3132         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3133         (documentLoadedCallback):
3134         (pageCreatedCallback):
3135         (methodCallCallback):
3136         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
3137         * TestWebKitAPI/glib/CMakeLists.txt:
3138         * TestWebKitAPI/glib/PlatformGTK.cmake:
3139         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3140         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3141         (main):
3142         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3143         (Test::adoptView):
3144         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3145         (WebKitTestBus::run):
3146         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3147         (WebViewTest::~WebViewTest):
3148         (WebViewTest::initializeWebView):
3149         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3150         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
3151         (WebViewTest::platformDestroy):
3152         (WebViewTest::platformInitializeWebView):
3153         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3154         (WebViewTest::resizeView):
3155         (WebViewTest::hideView):
3156         (parentWindowMapped):
3157         (WebViewTest::showInWindow):
3158         (WebViewTest::showInWindowAndWaitUntilMapped):
3159         (WebViewTest::mouseMoveTo):
3160         (WebViewTest::clickMouseButton):
3161         (WebViewTest::emitPopupMenuSignal):
3162         (WebViewTest::keyStroke):
3163         (WebViewTest::doMouseButtonEvent):
3164         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
3165         (WebViewTest::platformDestroy):
3166         (WebViewTest::platformInitializeWebView):
3167         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3168         (WebViewTest::resizeView):
3169         (WebViewTest::hideView):
3170         (WebViewTest::mouseMoveTo):
3171         (WebViewTest::clickMouseButton):
3172         (WebViewTest::keyStroke):
3173
3174 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3175
3176         [GTK] Move WebKit2 GLib API tests to glib directories
3177         https://bugs.webkit.org/show_bug.cgi?id=173642
3178
3179         Reviewed by Žan Doberšek.
3180
3181         * CMakeLists.txt:
3182         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
3183         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
3184         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
3185         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
3186         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
3187         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
3188         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
3189         (testWebKitConsoleMessageNetworkError):
3190         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
3191         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
3192         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
3193         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
3194         (testLoadFromGResource):
3195         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
3196         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
3197         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
3198         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
3199         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
3200         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
3201         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
3202         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
3203         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
3204         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
3205         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
3206         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
3207         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
3208         (testWebViewRunJavaScript):
3209         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
3210         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
3211         (registerGResource):
3212         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
3213         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
3214         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
3215         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
3216         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
3217         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
3218         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
3219         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
3220         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
3221         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
3222         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
3223         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
3224         * TestWebKitAPI/glib/CMakeLists.txt: Added.
3225         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
3226         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
3227         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
3228         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
3229         (registerGResource):
3230         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
3231         (Test::getResourcesDir):
3232         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
3233         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
3234         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
3235         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
3236         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
3237         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
3238
3239 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3240
3241         [WPE] Add initial web extensions API
3242         https://bugs.webkit.org/show_bug.cgi?id=173640
3243
3244         Reviewed by Žan Doberšek.
3245
3246         Add style checker exceptions for WPE web extensions API files.
3247
3248         * Scripts/webkitpy/style/checker.py:
3249
3250 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3251
3252         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
3253         https://bugs.webkit.org/show_bug.cgi?id=173659
3254         <rdar://problem/32879788>
3255
3256         Reviewed by Tim Horton.
3257
3258         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
3259
3260         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
3261
3262         Augment this test page to log dragend and dragstart events on the drag source as well.
3263
3264         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3265         (checkStringArraysAreEqual):
3266         (TestWebKitAPI::TEST):
3267
3268 2017-06-21  Antoine Quint  <graouts@apple.com>
3269
3270         Ensure DRT always logs rAF suspension debugging code
3271         https://bugs.webkit.org/show_bug.cgi?id=173681
3272
3273         Reviewed by Tim "Mr. T" Horton.
3274
3275         * DumpRenderTree/mac/DumpRenderTree.mm:
3276         (resetWebPreferencesToConsistentValues):
3277
3278 2017-06-21  Chris Dumez  <cdumez@apple.com>
3279
3280         Allow constructing a WTF:Function from a function pointer
3281         https://bugs.webkit.org/show_bug.cgi?id=173660
3282
3283         Reviewed by Alex Christensen.
3284
3285         Add API test coverage.
3286
3287         * TestWebKitAPI/Tests/WTF/Function.cpp:
3288         (TestWebKitAPI::returnThree):
3289         (TestWebKitAPI::returnFour):
3290         (TestWebKitAPI::returnPassedValue):
3291         (TestWebKitAPI::TEST):
3292
3293 2017-06-21  Antoine Quint  <graouts@apple.com>
3294
3295         Add logging to identify when the Page suspends scripted animations
3296         https://bugs.webkit.org/show_bug.cgi?id=173626
3297
3298         Reviewed by Tim Horton.
3299
3300         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
3301
3302         * DumpRenderTree/mac/DumpRenderTree.mm:
3303         (resetWebPreferencesToConsistentValues):
3304
3305 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
3306
3307         AX: Cannot call setValue() on contenteditable or ARIA text controls
3308         https://bugs.webkit.org/show_bug.cgi?id=173520
3309
3310         Reviewed by Ryosuke Niwa.
3311
3312         Add setValue() method to WKTR (already existed in DRT).
3313
3314         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3315         (WTR::AccessibilityUIElement::setValue):
3316         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3317         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3318         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3319         (WTR::AccessibilityUIElement::setValue):
3320
3321 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
3322
3323         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
3324         as one of the dependencies required to build the product.
3325
3326         Rubber-stamped by Carlos Garcia Campos.
3327
3328         * gtk/install-dependencies:
3329         * wpe/install-dependencies:
3330
3331 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3332
3333         Disable font variations on macOS Sierra and iOS 10
3334         https://bugs.webkit.org/show_bug.cgi?id=173618
3335         <rdar://problem/32879164>
3336
3337         Reviewed by Jon Lee.
3338
3339         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3340
3341 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3342
3343         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
3344         https://bugs.webkit.org/show_bug.cgi?id=173578
3345         <rdar://problem/32825028>
3346
3347         Reviewed by Tim Horton.
3348
3349         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
3350         a custom popover does not cause dragging to fail when the popover is presented.
3351
3352         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3353         (-[DataInteractionSimulator _advanceProgress]):
3354
3355 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3356
3357         [WPE] Add initial implementation of glib API
3358         https://bugs.webkit.org/show_bug.cgi?id=173546
3359
3360         Reviewed by Žan Doberšek.
3361
3362         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
3363         include WPE glib API files.
3364
3365         * Scripts/webkitperl/FeatureList.pm:
3366         * Scripts/webkitpy/style/checker.py:
3367         * Scripts/webkitpy/style/checkers/cpp.py:
3368         (check_identifier_name_in_declaration):
3369
3370 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3371
3372         [GTK] Upgrade to ICU to version 57.1
3373         https://bugs.webkit.org/show_bug.cgi?id=173538
3374
3375         Reviewed by Žan Doberšek.
3376
3377         * gtk/jhbuild.modules:
3378
3379 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3380
3381         [GTK] Remove unneeded modules from the jhbuild
3382         https://bugs.webkit.org/show_bug.cgi?id=170540
3383
3384         Reviewed by Michael Catanzaro.
3385
3386         We are building libxslt and libffi that we don't really need to build from sources.
3387
3388         * gtk/jhbuild.modules:
3389
3390 2017-06-19  Frederic Wang  <fwang@igalia.com>
3391
3392         [Mac] Add an experimental feature setting for async frame scrolling
3393         https://bugs.webkit.org/show_bug.cgi?id=173359
3394
3395         Reviewed by Simon Fraser.
3396
3397         * DumpRenderTree/mac/DumpRenderTree.mm:
3398         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
3399         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
3400         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3401         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
3402
3403 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
3404
3405         Unreviewed, adding myself to contributors.json
3406
3407         * Scripts/webkitpy/common/config/contributors.json:
3408
3409 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
3410
3411         test262: Completion values for control flow do not match the spec
3412         https://bugs.webkit.org/show_bug.cgi?id=171265
3413
3414         Reviewed by Saam Barati.
3415
3416         * Scripts/run-jsc-stress-tests:
3417         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
3418
3419 2017-06-19  Zalan Bujtas  <zalan@apple.com>
3420
3421         Opening certain mails brings up a mail that grows indefinitely.
3422         https://bugs.webkit.org/show_bug.cgi?id=173562
3423         <rdar://problem/32766579>
3424
3425         Reviewed by Tim Horton.
3426
3427         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3428         (TEST):
3429
3430 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3431
3432         [iOS DnD] Support .zip archives for file uploads via drag and drop
3433         https://bugs.webkit.org/show_bug.cgi?id=173511
3434         <rdar://problem/32521025>
3435
3436         Reviewed by Tim Horton.
3437
3438         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
3439         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
3440
3441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3442         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
3443         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3444         (testZIPArchive):
3445         (TestWebKitAPI::TEST):
3446
3447 2017-06-18  Darin Adler  <darin@apple.com>
3448
3449         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
3450         https://bugs.webkit.org/show_bug.cgi?id=173526
3451
3452         Reviewed by Sam Weinig.
3453
3454         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
3455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3456
3457         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
3458         tests for assignment before destruction ones.
3459
3460         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
3461         as a function, so it can be used in WTF::Function tests.
3462
3463         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
3464         Added tests for swap and for assignment before deref.
3465
3466         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
3467         to inline everything. Also removed the unnecessary clearing of the log every time
3468         the DerivedRefLogger constructor is called.
3469         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
3470
3471         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
3472         Added tests for assignment before deref and similar for releaseNonNull.
3473
3474 2017-06-19  Sam Weinig  <sam@webkit.org>
3475
3476         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
3477         https://bugs.webkit.org/show_bug.cgi?id=173513
3478
3479         Reviewed by Alex Christensen.
3480
3481         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3482         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3483         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
3484
3485 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
3486
3487         [Win] fast/dom/assign-to-window-status.html is flaky.
3488         https://bugs.webkit.org/show_bug.cgi?id=173512
3489
3490         Reviewed by Alex Christensen.
3491
3492         We should not dump status callbacks when test is done.
3493
3494         * DumpRenderTree/win/UIDelegate.cpp:
3495         (UIDelegate::setStatusText):
3496
3497 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3498
3499         [WPE][JHBuild] Update WPEBackend-mesa
3500         https://bugs.webkit.org/show_bug.cgi?id=173433
3501
3502         Unreviewed.
3503
3504         Update WPEBackend-mesa back (like it was done originally in r218344)
3505         after fixing the issue with the DISPLAY environment variables that
3506         caused the crashes.
3507
3508         * wpe/jhbuild.modules:
3509
3510 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3511
3512         Rename unit test file after r218482
3513         https://bugs.webkit.org/show_bug.cgi?id=173483
3514
3515         Unreviewed.
3516
3517         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
3518
3519 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3520
3521         Unreviewed. Fix wrong style checker condition added in r218487.
3522
3523         * Scripts/webkitpy/style/checkers/cpp.py:
3524         (check_identifier_name_in_declaration):
3525
3526 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
3527
3528         Missing <functional> includes make builds fail with GCC 7.x
3529         https://bugs.webkit.org/show_bug.cgi?id=173544
3530
3531         Unreviewed gardening.
3532
3533         Fix compilation with GCC 7.
3534
3535         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3536         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3537
3538 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3539
3540         [GTK] Move GTK+ API files that could be shared to glib dirs
3541         https://bugs.webkit.org/show_bug.cgi?id=173545
3542
3543         Reviewed by Žan Doberšek.
3544
3545         Update paths of GTK+ API in watchlist and style checker.
3546
3547         * Scripts/webkitpy/common/config/watchlist:
3548         * Scripts/webkitpy/style/checker.py:
3549         * Scripts/webkitpy/style/checkers/cpp.py:
3550         (check_identifier_name_in_declaration):
3551
3552 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3553
3554         Port setup_environ_for_server should not set environment variables related with the driver.
3555         https://bugs.webkit.org/show_bug.cgi?id=173483
3556
3557         Reviewed by Carlos Garcia Campos.
3558
3559         The port setup_environ_for_server() should not set environment variables
3560         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
3561         This varibles should be only set on the driver setup_environ_for_test().
3562
3563         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
3564         into the test environment even when running the tests with a driver
3565         that is not the Xorg or Xvfb one.
3566
3567         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
3568         (Port.to.setup_environ_for_server):
3569         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
3570         (Driver._setup_environ_for_driver):
3571         * Scripts/webkitpy/port/driver_unittest.py:
3572         (DriverTest.test_setup_environ_for_test):
3573         (DriverTest):
3574         (DriverTest.test_setup_environ_base_vars):
3575         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
3576         (GtkPort.setup_environ_for_server):
3577         * Scripts/webkitpy/port/wayland_unittest.py: Added.
3578         (WaylandDriverTest):
3579         (WaylandDriverTest.make_driver):
3580         (WaylandDriverTest.make_environment):
3581         (WaylandDriverTest.test_checkdriver):
3582         (WaylandDriverTest.test_environment_needed_variables):
3583         (WaylandDriverTest.test_environment_forbidden_variables):
3584         (WaylandDriverTest.test_environment_optional_variables):
3585         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
3586         (WaylandDriver.check_driver):
3587         (WaylandDriver._setup_environ_for_test):
3588         * Scripts/webkitpy/port/xorgdriver.py:
3589         (XorgDriver.check_driver):
3590         (XorgDriver._setup_environ_for_test):
3591         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
3592         (XorgDriverTest):
3593         (XorgDriverTest.make_driver):
3594         (XorgDriverTest.make_environment):
3595         (XorgDriverTest.test_checkdriver):
3596         (XorgDriverTest.test_environment_needed_variables):
3597         (XorgDriverTest.test_environment_forbidden_variables):
3598         (XorgDriverTest.test_environment_optional_variables):
3599         * Scripts/webkitpy/port/xvfbdriver.py:
3600         (XvfbDriver._setup_environ_for_test):
3601         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3602         (XvfbDriverTest.assertDriverStartSuccessful):
3603
3604
3605 2017-05-14 Frederic Wang  <fwang@igalia.com>
3606
3607         Add heuristic to avoid flattening "fullscreen" iframes
3608         https://bugs.webkit.org/show_bug.cgi?id=171914
3609
3610         Reviewed by Simon Fraser.
3611
3612         * DumpRenderTree/mac/DumpRenderTree.mm:
3613         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
3614
3615 2017-06-18  Chris Dumez  <cdumez@apple.com>
3616