Fix build when the script is called from Xcode.
[WebKit-https.git] / Tools / ChangeLog
1 2014-02-04  Filip Pizlo  <fpizlo@apple.com>
2
3         Fix build when the script is called from Xcode.
4
5         * Scripts/copy-webkitlibraries-to-product-directory:
6
7 2014-02-04  Filip Pizlo  <fpizlo@apple.com>
8
9         DFG PutByVal on typed arrays should detect OutOfBounds sooner
10         https://bugs.webkit.org/show_bug.cgi?id=128162
11
12         Reviewed by Mark Hahnenberg.
13         
14         Add a defautNoEagerRun, which is intended to be used for convergence tests.
15
16         * Scripts/run-jsc-stress-tests:
17
18 2014-02-04  Filip Pizlo  <fpizlo@apple.com>
19
20         export-llvm-build should work with git checkouts
21         https://bugs.webkit.org/show_bug.cgi?id=128217
22
23         Reviewed by Mark Hahnenberg.
24         
25         If svn export fails, just do ditto.
26
27         * Scripts/export-llvm-build:
28
29 2014-02-04  Carlos Garnacho  <carlosg@gnome.org>
30
31         [Automake] Add missing $(feature_defines) when generating InjectedBundle bindings
32         https://bugs.webkit.org/show_bug.cgi?id=128170
33
34         Reviewed by Carlos Garcia Campos.
35
36         * WebKitTestRunner/GNUmakefile.am: Add missing $(feature_defines) when
37         generating the InjectedBundle bindings. So the various ENABLE_* defines
38         are available there.
39
40 2014-02-04  Carlos Garnacho  <carlosg@gnome.org>
41
42         [GTK] Ensure generated events have given modifiers GDK understands
43         https://bugs.webkit.org/show_bug.cgi?id=128171
44
45         Reviewed by Carlos Garcia Campos.
46
47         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
48         (WTR::webkitModifiersToGDKModifiers): Move around
49         (WTR::EventSenderProxy::createMouseButtonEvent):
50         (WTR::EventSenderProxy::keyDown): Use webkitModifiersToGDKModifiers to
51         translate WKEventModifiers.
52
53 2014-02-04  Gabor Rapcsanyi  <rgabor@webkit.org>
54
55         Fine tuning the ARM EFL bots
56         https://bugs.webkit.org/show_bug.cgi?id=128168
57
58         Reviewed by Csaba Osztrogonác.
59
60         * BuildSlaveSupport/build.webkit.org-config/config.json: Add custom SVN mirror.
61         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
62         (WaitForSVNServer): Make it not to halt before the first repository checkout.
63         (WaitForSVNServer.evaluateCommand):
64         (Factory.__init__): Disable kill-old-processes step on EFL ARM bots, because these
65         bots run on the same machine and they kill the processes of each other.
66
67 2014-02-03  Ryosuke Niwa  <rniwa@webkit.org>
68
69         kill-old-processes doesn't kill plugin processes
70         https://bugs.webkit.org/show_bug.cgi?id=128138
71
72         Reviewed by Andreas Kling.
73
74         Add plugin process names to the list of processes to kill.
75
76         * BuildSlaveSupport/kill-old-processes:
77         (main):
78
79 2014-02-03  Dean Jackson  <dino@apple.com>
80
81         Feature flag for shape-inside
82         https://bugs.webkit.org/show_bug.cgi?id=128001
83
84         Reviewed by Simon Fraser.
85
86         Add CSS_SHAPE_INSIDE flag, and -css-shape-inside build
87         flag.
88
89         * Scripts/webkitperl/FeatureList.pm:
90
91 2014-02-03  Zoltan Horvath  <zoltan@webkit.org>
92
93         Unreviewed. Reorder my e-mail addresses in contributors.json,
94         so bugzilla will auto complete my actual bugzilla username.
95
96         * Scripts/webkitpy/common/config/contributors.json:
97
98 2014-02-03  Daniel Bates  <dabates@apple.com>
99
100         WebKit Bot Watcher's Dashboard: Defer subsequent resource loads from access-restricted build bot when
101         iteration fails to load with HTTP 401 status code
102         https://bugs.webkit.org/show_bug.cgi?id=128077
103
104         Reviewed by Alexey Proskuryakov.
105
106         Similar to the fix for <https://bugs.webkit.org/show_bug.cgi?id=127849>, we should only prompt for
107         the HTTP credentials of a build bot so long as an earlier authentication request wasn't cancelled
108         (i.e. failed with an HTTP 401 Unauthorized status code). Currently an authentication dialog will be
109         presented for an iteration each time the update queue timer fires until a person successfully
110         authenticates. Instead we should update the authentication status of the build bot on receiving an
111         HTTP 401 response code such that we defer subsequent requests to load any resource from the access-
112         restricted build bot when the queue update timer fires.
113
114         A person must explicitly click the "unauthorized" status line shown for the queue associated with the
115         iteration in the dashboard and authenticate successfully for the iteration to be loaded once an
116         authentication request for an iteration is cancelled.
117
118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
119         (BuildbotIteration.prototype.update): Early return if the associated Buildbot was given invalid credentials.
120         Also notify the associated Buildbot and update the queue view when a load failed with an HTTP 401 status code.
121         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
123         (BuildbotQueueView): Modified to call BuildbotQueueView.prototype._unauthorizedAccess instead of
124         QueueView.prototype._updateSoon when event BuildbotQueue.Event.UnauthorizedAccess is received.
125         (BuildbotQueueView.prototype._unauthorizedAccess): Added.
126
127 2014-02-03  Daniel Bates  <dabates@apple.com>
128
129         WebKit Bot Watcher's Dashboard: Teach JSON.load() to interpret third argument as either an
130         option dictionary or a failure callback
131         https://bugs.webkit.org/show_bug.cgi?id=128080
132
133         Reviewed by Alexey Proskuryakov.
134
135         Currently JSON.load() takes a failure callback function as its third argument and
136         an option dictionary as its fourth argument. So, a caller that wants to ignore errors
137         and pass an option dictionary must pass null or a reference to an empty function for
138         the value of third argument. Instead, we should make the third argument polymorphic for
139         convenience. Then a caller can either pass a failure callback function or an option dictionary.
140
141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
142
143 2014-02-03  Krzysztof Czech  <k.czech@samsung.com>
144
145         [ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR
146         https://bugs.webkit.org/show_bug.cgi?id=127908
147
148         Reviewed by Chris Fleizach.
149
150         Updated AccessibilityUIElement both in WKTR and DRT so that aria-controls support could be tested properly.
151         Added empty stubs to not break mac builds.
152
153         * DumpRenderTree/AccessibilityUIElement.cpp:
154         (ariaControlsElementAtIndexCallback):
155         (AccessibilityUIElement::getJSClass):
156         * DumpRenderTree/AccessibilityUIElement.h:
157         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
158         (accessibilityElementAtIndex):
159         (AccessibilityUIElement::disclosedRowAtIndex):
160         (AccessibilityUIElement::ariaOwnsElementAtIndex):
161         (AccessibilityUIElement::ariaFlowToElementAtIndex):
162         (AccessibilityUIElement::ariaControlsElementAtIndex):
163         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
164         (AccessibilityUIElement::ariaControlsElementAtIndex):
165         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
166         (AccessibilityUIElement::ariaControlsElementAtIndex):
167         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
168         (AccessibilityUIElement::ariaControlsElementAtIndex):
169         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
170         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
171         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
172         (WTR::accessibilityElementAtIndex):
173         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
174         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
175         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
176         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
177         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
178         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
179         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
180         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
181
182 2014-02-02  Daniel Bates  <dabates@apple.com>
183
184         WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
185         https://bugs.webkit.org/show_bug.cgi?id=127849
186
187         I inadvertently used the equality operator instead of the identity operator when comparing the
188         value of the error HTTP status code with the numeric literal 401.
189
190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
191         (BuildbotQueue.prototype.update):
192
193 2014-02-02  Daniel Bates  <dabates@apple.com>
194
195         Attempt to fix production dashboard after <http://trac.webkit.org/changeset/163222>
196
197         Actually pass option dictionary to JSON.load(); JSON.load() takes four arguments with the
198         last-most argument being the option dictionary.
199
200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
201         (BuildbotIteration.prototype.update):
202
203 2014-02-01  Filip Pizlo  <fpizlo@apple.com>
204
205         JSC profiler's stub info profiling support should work again
206         https://bugs.webkit.org/show_bug.cgi?id=128057
207
208         Reviewed by Mark Lam.
209
210         * Scripts/display-profiler-output: Just make sure that there's always a space between the origin stack dump and the top bytecode index.
211
212 2014-02-01  Filip Pizlo  <fpizlo@apple.com>
213
214         JSC profiler should show reasons for jettison
215         https://bugs.webkit.org/show_bug.cgi?id=128047
216
217         Reviewed by Geoffrey Garen.
218         
219         Gave the tool a "log" command, that tells you all of the interesting things
220         that happened to a piece of bytecode, from the standpoint of optimization.
221         It's a great summary view for seeing how our tier-up machinery works.
222         
223         This uses a lot of information that was already available, plus the newly
224         added jettisonReason field.
225
226         * Scripts/display-profiler-output:
227
228 2014-01-31  Ryosuke Niwa  <rniwa@webkit.org>
229
230         Remove inline member functions of FrameSelection that access m_selection
231         https://bugs.webkit.org/show_bug.cgi?id=127986
232
233         Reviewed by Enrica Casucci.
234
235         * TestWebKitAPI/Configurations/Base.xcconfig:
236
237 2014-01-31  Anders Carlsson  <andersca@apple.com>
238
239         Another attempt at fixing the build.
240
241         * TestWebKitAPI/Configurations/Base.xcconfig:
242
243 2014-01-31  Oliver Hunt  <oliver@apple.com>
244
245         Rollout r163195 and related patches
246
247         * DumpRenderTree/CMakeLists.txt:
248         * WebKitTestRunner/CMakeLists.txt:
249         * WinCELauncher/CMakeLists.txt:
250
251 2014-01-31  Daniel Bates  <dabates@apple.com>
252
253         Attempt to fix Production Dashboard after <http://trac.webkit.org/changeset/163213>
254         (https://bugs.webkit.org/show_bug.cgi?id=127849)
255
256         Reviewed by David Farler.
257
258         Pass credentials when querying build bot iteration. 
259
260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
261         (BuildbotIteration.prototype.update):
262         (BuildbotIteration.prototype.loadLayoutTestResults):
263
264 2014-01-31  Anders Carlsson  <andersca@apple.com>
265
266         Fix iOS build.
267
268         * TestWebKitAPI/Configurations/Base.xcconfig:
269
270 2014-01-31  Simon Fraser  <simon.fraser@apple.com>
271
272         WebKitTestRunner project doesn't show Mac as a valid destination architecture.
273         
274         Make sure that SUPPORTED_PLATFORMS is defined in Base.xcconfig.
275         
276         Also add BaseTarget.xcconfig to the project.
277
278         * WebKitTestRunner/Configurations/Base.xcconfig:
279         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
280
281 2014-01-31  Daniel Bates  <dabates@apple.com>
282
283         WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
284         https://bugs.webkit.org/show_bug.cgi?id=127849
285
286         Reviewed by Alexey Proskuryakov.
287
288         Currently whenever the dashboard updates the status of a queue whose Buildbot requires authentication
289         it will cause a browser to prompt for credentials once per update until valid credentials are provided.
290         Instead we should keep track of Buildbots that respond with an HTTP 401 Unauthorized status code to avoid
291         subsequently querying them and hence cause a browser to prompt for credentials. Together with an optional
292         hint provided when instantiating a Buildbot object as to whether it requires authentication, we can make
293         the dashboard prompt for HTTP credentials exactly once per page load for each queue whose associated
294         Buildbot requires authentication.
295
296         Queues whose Buildbot wasn't authenticated will show in the dashboard as "unauthorized". Clicking on
297         this status message will cause the browser to prompt for credentials.
298
299         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
300         (Buildbot): Initialize instance variable authenticationStatus to Buildbot.AuthenticationStatus.Unauthenticated.
301         (Buildbot.prototype.get needsAuthentication): Added.
302         (Buildbot.prototype.get authenticationStatus): Added.
303         (Buildbot.prototype.get isAuthenticated): Added.
304         (Buildbot.prototype.set isAuthenticated): Added.
305         (Buildbot.prototype.updateQueues): Added.
306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
307         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Modified to call
308         BuildbotQueueView.prototype._appendUnauthorizedLineView() to update the view and show status of the queue as
309         "unauthorized" if the Buildbot associated with the queue is either unauthenticated or was given invalid credentials.
310         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
311         (BuildbotQueue.prototype.update): Return immediately if the associated Buildbot requires authentication.
312         Additionally, if the JSON load fails with an HTTP 401 Unauthorized access error (say, credentials were
313         invalidated) then update the authentication status of the Buildbot to avoid subsequently prompting a
314         person for credentials the next time the queue update timer fires.
315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
316         (BuildbotQueueView): Register as a listener for event BuildbotQueue.Event.UnauthorizedAccess on each queue
317         so that the view can be updated to show status "unauthorized".
318         (BuildbotQueueView.prototype._appendUnauthorizedLineView): Added.
319         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
320         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
321         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added new status, StatusLineView.Status.Unauthorized.
322         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
323         (.status-line.unauthorized .bubble): Added.
324         (.status-line.unauthorized .bubble.pictogram): Added.
325         (.status-line.unauthorized .message): Added.
326
327 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
328
329         Unreviewed, really make --copy-libraries a no-able option.
330         
331         * Scripts/build-jsc:
332
333 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
334
335         Unreviewed, really add the --copy-libraries option.
336
337         * Scripts/build-jsc:
338
339 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
340
341         Unreviewed, fix the script for older Rubies.
342
343         * Scripts/export-llvm-build:
344
345 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
346
347         Having a custom LLVM checkout should always override all other ways of getting LLVM
348         https://bugs.webkit.org/show_bug.cgi?id=128015
349
350         Reviewed by Oliver Hunt.
351
352         * Scripts/copy-webkitlibraries-to-product-directory:
353
354 2014-01-31  Daniel Bates  <dabates@apple.com>
355
356         WebKit Bot Watcher's Dashboard: Teach JSON.load() to take optional failure callback function
357         https://bugs.webkit.org/show_bug.cgi?id=127924
358
359         Reviewed by Alexey Proskuryakov.
360
361         Towards providing better error handling when a JSON load fails with a non-200 HTTP status
362         code, we should teach JSON.load() to take an optional failure callback function and invoke
363         it when either a load error or a JSON parsing error occurs.
364
365         As a side benefit of having a failure callback function a caller can separate the error handling
366         logic for a JSON load or parse error from the logic of handling a successful parsing of JSON content.
367
368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
369         (BuildbotIteration.prototype.loadLayoutTestResults): Move JSON parser error logic into failure
370         callback function.
371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
372         (JSON.load): Modified to take optional failure callback function called failureCallback.
373
374 2014-01-29  Oliver Hunt  <oliver@apple.com>
375
376         Make it possible to implement JS builtins in JS
377         https://bugs.webkit.org/show_bug.cgi?id=127887
378
379         Reviewed by Michael Saboff.
380
381         CMake updates
382
383         * DumpRenderTree/CMakeLists.txt:
384         * WebKitTestRunner/CMakeLists.txt:
385         * WinCELauncher/CMakeLists.txt:
386
387 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
388
389         Allow more flexibility for copy-webkitlibraries-to-product-directory
390         https://bugs.webkit.org/show_bug.cgi?id=128010
391
392         Reviewed by Oliver Hunt.
393         
394         It's now the case that copy-webkitlibraries-to-product-directory does nothing by
395         default, but you can tell it to either copy WebKitSystemInterface (--wksi) or LLVM
396         (--llvm). You can also tell it where to get LLVM from.
397
398         * Scripts/build-jsc:
399         * Scripts/build-webkit:
400         * Scripts/copy-webkitlibraries-to-product-directory:
401
402 2014-01-31  David Farler  <dfarler@apple.com>
403
404         DumpRenderTree iOS fails to link: missing rowHeaders and columnHeaders in AccessibilityUIElement
405         https://bugs.webkit.org/show_bug.cgi?id=128004
406
407         Reviewed by Chris Fleizach.
408
409         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
410         (AccessibilityUIElement::columnHeaders): Stub added.
411         (AccessibilityUIElement::rowHeaders): Stub added.
412
413 2014-01-31  Zoltan Horvath  <zoltan@webkit.org>
414
415         Unreviewed. Update my contributors.json entry.
416
417         * Scripts/webkitpy/common/config/contributors.json:
418
419 2014-01-31  Anders Carlsson  <andersca@apple.com>
420
421         REGRESSION: WebKit2.PageLoadBasic API test is failing
422         https://bugs.webkit.org/show_bug.cgi?id=127892
423
424         Reviewed by Dan Bernstein.
425
426         Re-enable test.
427
428         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
429
430 2014-01-31  Csaba Osztrogonác  <ossy@webkit.org>
431
432         [jhbuild] Disable escape sequences in EWS output
433         https://bugs.webkit.org/show_bug.cgi?id=127922
434
435         Reviewed by Alexey Proskuryakov.
436
437         * Scripts/webkitpy/common/system/environment.py:
438         (Environment.disable_gcc_smartquotes):
439         (Environment):
440         (Environment.disable_jhbuild_VT100_output):
441         * Scripts/webkitpy/tool/commands/download_unittest.py:
442         * Scripts/webkitpy/tool/steps/build.py:
443         (Build.build):
444
445 2014-01-30  Martin Robinson  <mrobinson@igalia.com>
446
447         [GTK] [CMake] Add support for building against GTK+ 2
448         https://bugs.webkit.org/show_bug.cgi?id=127959
449
450         Reviewed by Anders Carlsson.
451
452         * DumpRenderTree/PlatformGTK.cmake: Use the new API version variable and don't use GTK3 directly.
453         * GtkLauncher/CMakeLists.txt: Ditto.
454         * ImageDiff/PlatformGTK.cmake: Ditto.
455         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Ditto.
456
457 2014-01-30  Anders Carlsson  <andersca@apple.com>
458
459         Add webView:didFinishLoadingNavigation: delegate method
460         https://bugs.webkit.org/show_bug.cgi?id=127976
461
462         Reviewed by Dan Bernstein.
463
464         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
465         (-[NavigationDelegate webView:didCommitNavigation:]):
466         (-[NavigationDelegate webView:didFinishLoadingNavigation:]):
467
468 2014-01-30  Anders Carlsson  <andersca@apple.com>
469
470         Add a webView:didCommitNavigation: delegate method
471         https://bugs.webkit.org/show_bug.cgi?id=127972
472
473         Reviewed by Dan Bernstein.
474
475         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
476         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
477         (-[NavigationDelegate webView:didCommitNavigation:]):
478
479 2014-01-30  Anders Carlsson  <andersca@apple.com>
480
481         Add a webView:didFailProvisionalNavigation:withError: delegate method
482         https://bugs.webkit.org/show_bug.cgi?id=127968
483
484         Reviewed by Dan Bernstein.
485
486         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
487         (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
488         (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
489         (TEST):
490
491 2014-01-30  Ryosuke Niwa  <rniwa@webkit.org>
492
493         The test server build fixes.
494
495         * TestResultServer/model/jsonresults.py:
496         (JsonResults.merge):
497         * TestResultServer/static-dashboards/flakiness_dashboard.js:
498
499 2014-01-30  Ryosuke Niwa  <rniwa@webkit.org>
500
501         NRWT shouldn't say "Finished writing JSON files" if it failed to to so
502         https://bugs.webkit.org/show_bug.cgi?id=127966
503
504         Reviewed by Alexey Proskuryakov.
505
506         Don't say "Finished writing JSON files" if we had failed to generate the JSON file.
507         Also explicitly say this is for test results server as we're generating two JSON files.
508
509         * Scripts/webkitpy/layout_tests/controllers/manager.py:
510         (Manager._upload_json_files):
511         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
512         (JSONLayoutResultsGenerator.__init__): Don't generate JSON file implicitly inside the constructor.
513         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
514         (JSONResultsGenerator.generate_json_output): Return a boolean indicating whether the generation
515         had succeeded or not.
516
517 2014-01-30  Filip Pizlo  <fpizlo@apple.com>
518
519         copy-webkitlibraries-to-product-directory should accept command-line arguments for extra work required for optional features rather than relying on environment variables
520         https://bugs.webkit.org/show_bug.cgi?id=120221
521
522         Reviewed by Mark Hahnenberg.
523
524         * Scripts/build-jsc:
525         * Scripts/build-webkit:
526         * Scripts/copy-webkitlibraries-to-product-directory:
527
528 2014-01-30  Anders Carlsson  <andersca@apple.com>
529
530         Add a webView:didStartProvisionalNavigation: delegate method
531         https://bugs.webkit.org/show_bug.cgi?id=127965
532
533         Reviewed by Dan Bernstein.
534
535         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
536         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
537         (TEST):
538
539 2014-01-30  Chris Fleizach  <cfleizach@apple.com>
540
541         WebKitTestRunner fails to link - missing rowHeaders and columnHeaders
542         https://bugs.webkit.org/show_bug.cgi?id=127917
543
544         Reviewed by Andy Estes.
545
546         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
547         (WTR::AccessibilityUIElement::rowHeaders):
548         (WTR::AccessibilityUIElement::columnHeaders):
549
550 2014-01-30  Martin Robinson  <mrobinson@igalia.com>
551
552         [GTK] [CMake] Add a "make dist" target
553         https://bugs.webkit.org/show_bug.cgi?id=116378
554
555         Reviewed by Gustavo Noronha Silva.
556
557         Added a script that reads a manifest file an produces a tarball. Also add
558         the manifest.
559
560         * gtk/make-dist.py: Added.
561         * gtk/manifest.txt: Added.
562
563 2014-01-30  David Farler  <dfarler@apple.com>
564
565         Move OTHER_LDFLAGS erasure to DumpRenderTreeLibrary.xcconfig.
566         https://bugs.webkit.org/show_bug.cgi?id=127935
567
568         Reviewed by Andy Estes.
569
570         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
571         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
572         Move OTHER_LDFLAGS erasure to the static library's xcconfig.
573
574 2014-01-30  David Farler  <dfarler@apple.com>
575
576         DumpRenderTree fails to build with ASAN: -fsanitize=address passed to static DRT target
577         https://bugs.webkit.org/show_bug.cgi?id=127935
578
579         Reviewed by Andy Estes.
580
581         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
582         Clear OTHER_LDFLAGS at the project level for the static library target.
583         No other linker flags were inherited from DebugRelease.
584
585 2014-01-30  David Farler  <dfarler@apple.com>
586
587         package-root shouldn't prefix simulator roots with the SDK path
588         http://bugs.webkit.org/show_bug.cgi?id=127923
589
590         Reviewed by Dan Bernstein.
591
592         * Scripts/package-root: Don't add an install path prefix.
593
594 2014-01-30  Gabor Rapcsanyi  <rgabor@webkit.org>
595
596         Add ARM EFL Linux builder bots to Apple buildmaster
597         https://bugs.webkit.org/show_bug.cgi?id=127472
598
599         Reviewed by Csaba Osztrogonác.
600
601         There is no ARM buildslaves after removing the Qt builders.
602
603         * BuildSlaveSupport/build.webkit.org-config/config.json:
604
605 2014-01-30  Andy Estes  <aestes@apple.com>
606
607         REGRESSION (r163037): WebKit2.PageLoadBasic API test failing on Mountain Lion
608         https://bugs.webkit.org/show_bug.cgi?id=127934
609
610         Disable the failing test on Mountain Lion.
611
612         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
613         (TestWebKitAPI::TEST):
614
615 2014-01-30  Anders Carlsson  <andersca@apple.com>
616
617         Add WKNavigationDelegate class
618         https://bugs.webkit.org/show_bug.cgi?id=127927
619
620         Reviewed by Dan Bernstein.
621
622         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
623         (TEST):
624
625 2014-01-30  David Farler  <dfarler@apple.com>
626
627         Enable iOS Tools builds by default
628         https://bugs.webkit.org/show_bug.cgi?id=127919
629
630         Reviewed by Andy Estes.
631
632         * Makefile:
633         Build all the tools except MiniBrowser on iOS
634         * Scripts/build-webkit:
635         Ditto.
636         Build WebKitTestRunnerApp target on iOS.
637
638 2014-01-30  David Farler  <dfarler@apple.com>
639
640         Make TestWebKitAPI build and run for iOS
641         https://bugs.webkit.org/show_bug.cgi?id=127925
642
643         Reviewed by Andy Estes.
644
645         * TestWebKitAPI/Configurations/Base.xcconfig:
646         - Don't warn on 64-32 bit conversion on x86_64 and arm64
647         - Don't build mac/*
648         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
649         - Link WebKit2 on all platforms
650
651 2014-01-30  David Farler  <dfarler@apple.com>
652
653         package-root should copy ./usr from the build products directory
654         https://bugs.webkit.org/show_bug.cgi?id=127878
655
656         Reviewed by Daniel Bates.
657
658         * Scripts/package-root:
659         Copy ./usr in addition to the frameworks.
660
661 2014-01-30  Andrei Bucur  <abucur@adobe.com>
662
663         Remove the ACCELERATED_COMPOSITING flag
664         https://bugs.webkit.org/show_bug.cgi?id=127833
665
666         Reviewed by Antti Koivisto.
667
668         Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
669         mandatory.
670
671         * DumpRenderTree/efl/DumpRenderTree.cpp:
672         (initEcoreEvas):
673         * EWebLauncher/main.c:
674         (windowCreate):
675         * MiniBrowser/efl/main.c:
676         (elm_main):
677         * TestWebKitAPI/efl/PlatformWebView.cpp:
678         (TestWebKitAPI::initEcoreEvas):
679         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
680         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
681         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
682         (WTR::initEcoreEvas):
683
684 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
685
686         Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
687         https://bugs.webkit.org/show_bug.cgi?id=127845
688
689         Reviewed by Joseph Pecoraro.
690
691         * Scripts/webkitperl/FeatureList.pm:
692
693 2014-01-29  Anders Carlsson  <andersca@apple.com>
694
695         -[WKWebView loadRequest:] should return a WKNavigation
696         https://bugs.webkit.org/show_bug.cgi?id=127873
697
698         Reviewed by Dan Bernstein.
699
700         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
701         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: Added.
702         (TEST):
703
704 2014-01-29  Tim Horton  <timothy_horton@apple.com>
705
706         WebKit2 View Gestures (Swipe): Update rubberBandsAt{Left,Right} when WebKit swipe is enabled
707         https://bugs.webkit.org/show_bug.cgi?id=127855
708         <rdar://problem/15933878>
709
710         Reviewed by Anders Carlsson.
711
712         * MiniBrowser/mac/WK2BrowserWindowController.m:
713         (-[WK2BrowserWindowController awakeFromNib]):
714         Enable swipe in MiniBrowser for testing purposes.
715
716 2014-01-29  Daniel Bates  <dabates@apple.com>
717
718         Fix JSONP requests made by the WebKit Bot Watcher's Dashboard following <http://trac.webkit.org/changeset/163034>
719         (https://bugs.webkit.org/show_bug.cgi?id=127784)
720
721         Use dot-notation instead of array index notation to access the dictionary value for key jsonpCallbackName
722         in the specified options dictionary.
723
724         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
725         (JSON.load):
726
727 2014-01-29  Daniel Bates  <dabates@apple.com>
728
729         WebKit Bot Watcher's Dashboard: Add support for using HTTP authentication with Buildbot
730         https://bugs.webkit.org/show_bug.cgi?id=127784
731
732         Reviewed by Alexey Proskuryakov.
733
734         Implement support for querying a Buildbot that requires HTTP authentication to access it.
735
736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
737         (Buildbot): Add optional argument, options, to pass a dictionary of Buildbot options.
738         For now, we only support a single option, needsAuthentication, to indicate whether the
739         Buildbots requires HTTP authentication (defaults to false - HTTP authentication is
740         not required).
741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
742         (BuildbotIteration.prototype.loadLayoutTestResults): Modified to pass JSONP callback name
743         to JSON.load() using the option dictionary.
744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
745         (BuildbotQueue.prototype.update): Modified to pass withCredentials to JSON.load().
746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
747         (JSON.load): Removed optional argument jsonpCallbackName and added optional argument options,
748         which is a dictionary. The argument jsonpCallbackName is now specified as an entry in the
749         options dictionary. Added boolean options withCredentials to toggle querying with HTTP
750         authentication credentials.
751
752 2014-01-29  Alexey Proskuryakov  <ap@apple.com>
753
754         build.webkit.org/dashboard links to an old failing build rather than the most recent
755         https://bugs.webkit.org/show_bug.cgi?id=127765
756         <rdar://problem/15795228>
757
758         Reviewed by Timothy Hatcher.
759
760         This patch changes builder view to not show how many failures there were in a row,
761         because it is not very relevant, and complicates the UI. Instead, we just show the
762         latest failing build and the latest successful one.
763
764         The patch also removes commit history popovers from revisions that can not be correlated
765         with any change. These popovers are only helpful in the first line, when there is
766         another line for comparison below. In this case, it's useful to see what changed
767         between the revisions, but even then, only if it was an actual failure, not a buildbot
768         exception.
769
770         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
771         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
772         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
773         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
774         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
775         (BuildbotQueueView.prototype._revisionPopoverContentForIteration):
776         (BuildbotQueueView.prototype.revisionContentForIteration):
777         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
778         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
779
780 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
781
782         Remove ENABLE(JAVASCRIPT_DEBUGGER) guards
783         https://bugs.webkit.org/show_bug.cgi?id=127840
784
785         Reviewed by Mark Lam.
786
787         * Scripts/webkitperl/FeatureList.pm:
788
789 2014-01-29  Krzysztof Czech  <k.czech@samsung.com>
790
791         [ATK] Expose aria-describedby with ATK_RELATION_DESCRIBED_BY
792         https://bugs.webkit.org/show_bug.cgi?id=121684
793
794         Reviewed by Mario Sanchez Prada.
795
796         Implementing helpText by using relation ATK_RELATION_DESCRIBED_BY.
797
798         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
799         (AccessibilityUIElement::helpText):
800         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
801         (WTR::AccessibilityUIElement::helpText):
802
803 2014-01-27  Chris Fleizach  <cfleizach@apple.com>
804
805         AX: Support @scope in HTML tables
806         https://bugs.webkit.org/show_bug.cgi?id=127688
807
808         Reviewed by Mario Sanchez Prada.
809
810         Add support for rowHeaders and columnHeaders.
811
812         * DumpRenderTree/AccessibilityUIElement.cpp:
813         (convertElementsToObjectArray):
814         (columnHeadersCallback):
815         (rowHeadersCallback):
816         (uiElementArrayAttributeValueCallback):
817         (AccessibilityUIElement::columnHeaders):
818         (AccessibilityUIElement::rowHeaders):
819         (AccessibilityUIElement::getJSClass):
820         * DumpRenderTree/AccessibilityUIElement.h:
821         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
822         (AccessibilityUIElement::rowHeaders):
823         (AccessibilityUIElement::columnHeaders):
824         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
825         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
826         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
827         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
828         (WTR::AccessibilityUIElement::rowHeaders):
829         (WTR::AccessibilityUIElement::columnHeaders):
830         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
831         (WTR::convertElementsToObjectArray):
832         (WTR::AccessibilityUIElement::rowHeaders):
833         (WTR::AccessibilityUIElement::columnHeaders):
834         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
835
836 2014-01-28  Daniel Bates  <dabates@apple.com>
837
838         Teach Buildbot dashboard to parse alternative revision format
839         https://bugs.webkit.org/show_bug.cgi?id=127561
840
841         Reviewed by Alexey Proskuryakov.
842
843         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
844         returns a dictionary for the value of property got_revision.
845
846         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
847         (isMultiCodebaseGotRevisionProperty): Added.
848         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
849         string or a dictionary.
850         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
851         the OpenSource and Internal revision numbers.
852
853 2014-01-28  Adrian Perez de Castro  <aperez@igalia.com>
854
855         [GTK] Add API to allow setting the process model in WebKitWebContext
856         https://bugs.webkit.org/show_bug.cgi?id=125463
857
858         Reviewed by Carlos Garcia Campos.
859
860         Implements accessors in WebKitWebContext for the process model.
861         The default behavior is unchanged, and a single web process is
862         used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
863         as the process model will make use one web process for each
864         WebKitWebView. This also enables the network process. Setting
865         the process model must be done as early as possible, before the
866         very first web process is spawned.
867
868         * MiniBrowser/gtk/main.c:
869         (main):
870         Enable multiple process mode if the MINIBROWSER_MULTIPROCESS
871         environment variable is defined and not empty.
872         * TestWebKitAPI/GNUmakefile.am:
873         Add new TestMultiprocess test case.
874         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
875         Add new TestMultiprocess test case.
876         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: Added.
877         (loadChanged):
878         (testMultipleSecondaryProcesses):
879         (initializeWebExtensions):
880         (beforeAll):
881         (afterAll):
882         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
883         (methodCallCallback):
884         Implement the GetProcessIdentifier D-Bus method.
885         (makeBusName):
886         Choose a different bus name when the web extension is used
887         from TestMultiprocess.
888         (webkit_web_extension_initialize_with_user_data):
889         Use makeBusName() to choose the bus name.
890
891 2014-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
892
893         [SOUP] Remove soupURIToKURL
894         https://bugs.webkit.org/show_bug.cgi?id=127104
895
896         Reviewed by Martin Robinson.
897
898         * TestWebKitAPI/GNUmakefile.am: Add soup cppflags to WebCore unit
899         tests, because URL.h now includes GUniquePtrSoup.h.
900         * TestWebKitAPI/CMakeLists.txt: Ditto.
901         * WebKitTestRunner/PlatformEfl.cmake: Add soup cppflags to WTR,
902         because URL.h now includes GUniquePtrSoup.h.
903
904 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
905
906         [GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
907         https://bugs.webkit.org/show_bug.cgi?id=127614
908
909         Reviewed by Gustavo Noronha Silva.
910
911         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring
912         back the custom URI scheme WebView check.
913
914 2014-01-27  Tim Horton  <timothy_horton@apple.com>
915
916         Revert yet one more tiny part of r162629 that didn't get reverted in r162883
917
918         * WebKitTestRunner/TestController.cpp:
919         (WTR::TestController::pluginLoadPolicy):
920         * WebKitTestRunner/TestController.h:
921
922 2014-01-27  Tim Horton  <timothy_horton@apple.com>
923
924         Revert one more tiny part of r162629 that didn't get reverted in r162883.
925
926         ... which was also causing test failures!
927
928         * WebKitTestRunner/TestController.cpp:
929         (WTR::TestController::createWebViewWithOptions):
930
931 2014-01-27  David Farler  <dfarler@apple.com>
932
933         iOS DumpRenderTree.app dies loading fonts
934         https://bugs.webkit.org/show_bug.cgi?id=127730
935
936         Reviewed by Daniel Bates.
937
938         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
939         - Add Ahem to the __DATA section
940         * DumpRenderTree/mac/DumpRenderTree.mm:
941         (activateFontsIOS):
942         - Load "WeightWatcher100" instead.
943
944 2014-01-27  Alexey Proskuryakov  <ap@apple.com>
945
946         [Mac] Extra logging output from run-safari --no-saved-state
947         https://bugs.webkit.org/show_bug.cgi?id=127732
948
949         Reviewed by Daniel Bates.
950
951         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that
952         disables saved state without logging.
953
954 2014-01-27  Tim Horton  <timothy_horton@apple.com>
955
956         Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.
957
958         We're leaving the parts that make us use PDFPlugin instead of showing the blocked
959         plugin indicator intact, though.
960
961         * WebKitTestRunner/TestController.cpp:
962         (WTR::TestController::createWebViewWithOptions):
963
964 2014-01-27  Andy Estes  <aestes@apple.com>
965
966         Scrub WebKit API headers of WTF macros
967         https://bugs.webkit.org/show_bug.cgi?id=127706
968
969         Reviewed by David Kilzer.
970
971         * Scripts/check-for-inappropriate-macros-in-external-headers: Modified
972         the regex to require a '(' after the macro name in order to be
973         considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
974         from being flagged as an ENABLE() macro.
975
976 2014-01-27  Commit Queue  <commit-queue@webkit.org>
977
978         Unreviewed, rolling out r162846.
979         http://trac.webkit.org/changeset/162846
980         https://bugs.webkit.org/show_bug.cgi?id=127695
981
982         "Broke the WebKit Bot Watcher's Dashboard; will fix offline"
983         (Requested by dydz on #webkit).
984
985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
986         (BuildbotIteration.prototype.update.):
987
988 2014-01-27  Daniel Bates  <dabates@apple.com>
989
990         Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
991         https://bugs.webkit.org/show_bug.cgi?id=127564
992
993         Reviewed by Alexey Proskuryakov.
994
995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
997
998 2014-01-27  Daniel Bates  <dabates@apple.com>
999
1000         Teach Buildbot dashboard to parse alternative revision format
1001         https://bugs.webkit.org/show_bug.cgi?id=127561
1002
1003         Reviewed by Alexey Proskuryakov.
1004
1005         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
1006         returns a dictionary for the value of property got_revision.
1007
1008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1009         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
1010         string or a dictionary.
1011         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
1012         the OpenSource and Internal revision numbers.
1013
1014 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1015
1016         [GTK] Implement custom URI schemes with CustomProtocols
1017         https://bugs.webkit.org/show_bug.cgi?id=127091
1018
1019         Reviewed by Gustavo Noronha Silva.
1020
1021         Temporarily disable the WebKitWebView check until we figure out
1022         how to implement it with CustomProtocols.
1023
1024         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1025
1026 2014-01-26  Alexey Proskuryakov  <ap@apple.com>
1027
1028         REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
1029
1030         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
1031         Fixed an incorrect ifdef.
1032
1033 2014-01-26  Brendan Long  <b.long@cablelabs.com>
1034
1035         [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
1036         https://bugs.webkit.org/show_bug.cgi?id=110602
1037
1038         Reviewed by Philippe Normand.
1039
1040         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1041         (getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
1042         (initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
1043
1044 2014-01-24  Andy Estes  <aestes@apple.com>
1045
1046         [iOS] Upstream changes in Tools/DumpRenderTree
1047         https://bugs.webkit.org/show_bug.cgi?id=127412
1048
1049         Reviewed by Simon Fraser.
1050
1051         Upstream all iOS changes. Added a new target called DumpRenderTree.app,
1052         which builds the DumpRenderTree static library into an app bundle as
1053         expected by the iOS Simulator.
1054
1055         * DumpRenderTree/AccessibilityTextMarker.h:
1056         * DumpRenderTree/AccessibilityUIElement.h:
1057         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1058         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
1059         * DumpRenderTree/DumpRenderTreePrefix.h:
1060         * DumpRenderTree/PixelDumpSupport.cpp:
1061         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1062         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1063         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
1064         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1065         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1066         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1067         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1068         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
1069         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
1070         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
1071         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
1072         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
1073         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
1074         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1075         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
1076         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1077         * DumpRenderTree/TestRunner.cpp:
1078         * DumpRenderTree/TestRunner.h:
1079         * DumpRenderTree/cg/ImageDiffCG.cpp:
1080         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1081         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1082         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1083         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
1084         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
1085         * DumpRenderTree/ios/Info.plist: Added.
1086         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
1087         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
1088         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
1089         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
1090         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
1091         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
1092         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
1093         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
1094         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
1095         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
1096         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
1097         * DumpRenderTree/ios/PerlSupport/Makefile: Added.
1098         * DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
1099         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1100         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1101         * DumpRenderTree/mac/AppleScriptController.m:
1102         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1103         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1104         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1105         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
1106         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
1107         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
1108         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
1109         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1110         * DumpRenderTree/mac/DumpRenderTree.mm:
1111         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1112         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1113         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1114         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1115         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1116         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1117         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1118         * DumpRenderTree/mac/EditingDelegate.h:
1119         * DumpRenderTree/mac/EventSendingController.h:
1120         * DumpRenderTree/mac/EventSendingController.mm:
1121         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1122         * DumpRenderTree/mac/HistoryDelegate.h:
1123         * DumpRenderTree/mac/LayoutTestHelper.m:
1124         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1125         * DumpRenderTree/mac/NavigationController.h:
1126         * DumpRenderTree/mac/ObjCPlugin.h:
1127         * DumpRenderTree/mac/ObjCPlugin.m:
1128         * DumpRenderTree/mac/ObjCPluginFunction.h:
1129         * DumpRenderTree/mac/PolicyDelegate.h:
1130         * DumpRenderTree/mac/ResourceLoadDelegate.h:
1131         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1132         * DumpRenderTree/mac/TestRunnerMac.mm:
1133         * DumpRenderTree/mac/TextInputController.h:
1134         * DumpRenderTree/mac/TextInputController.m:
1135         * DumpRenderTree/mac/UIDelegate.h:
1136         * DumpRenderTree/mac/UIDelegate.mm:
1137
1138 2014-01-25  Darin Adler  <darin@apple.com>
1139
1140         Call deprecatedCharacters instead of characters at more call sites
1141         https://bugs.webkit.org/show_bug.cgi?id=127631
1142
1143         Reviewed by Sam Weinig.
1144
1145         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1146         (TestWebKitAPI::expectBuilderContent):
1147         (TestWebKitAPI::expectEmpty):
1148         (TestWebKitAPI::TEST):
1149         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1150         (TestWebKitAPI::TEST):
1151         Use the new name.
1152
1153 2014-01-25  Anders Carlsson  <andersca@apple.com>
1154
1155         Modernize HashTable threading code
1156         https://bugs.webkit.org/show_bug.cgi?id=127621
1157
1158         Reviewed by Darin Adler.
1159
1160         Explicitly include headers that used to be brought in by HashTable.h
1161
1162         * DumpRenderTree/JavaScriptThreading.cpp:
1163
1164 2014-01-24  Eric Carlson  <eric.carlson@apple.com>
1165
1166         Unreviewed. Add Philip Jägenstedt to watch and contributor lists.
1167
1168         * Scripts/webkitpy/common/config/contributors.json:
1169         * Scripts/webkitpy/common/config/watchlist:
1170
1171 2014-01-23  David Farler  <dfarler@apple.com>
1172
1173         Make WebKitTestRunner work with iOS
1174         https://bugs.webkit.org/show_bug.cgi?id=127448
1175
1176         Reviewed by Simon Fraser.
1177
1178         Combined patch from Simon below with some additional xcconfig cleanups,
1179         rebasing and stubbing out a couple of new functions that popped up
1180         since then.
1181
1182         2013-12-03  Simon Fraser  <simon.fraser@apple.com>
1183
1184                 <rdar://problem/15515469> Get WebKitTestRunner working on iOS
1185
1186                 Get WebKitTestRunner limping on iOS. Main parts:
1187                 - Stub out lots of accessibility-related functions.
1188                 - Stub out EventSender
1189                 - Create target to make a bundled app that runs in the simulator,
1190                   and copy the injected bundle library into it.
1191                 - Make a UIWindow and WKView to load tests in
1192
1193                 It runs, load tests, and dumps results to output. More work will be
1194                 required once we can execute it via the webkitpy scripts.
1195
1196         * WebKitTestRunner/Configurations/Base.xcconfig:
1197         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1198         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1199         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1200         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.
1201         (WTR::AccessibilityController::addNotificationListener):
1202         (WTR::AccessibilityController::removeNotificationListener):
1203         (WTR::AccessibilityController::platformName):
1204         (WTR::AccessibilityController::logAccessibilityEvents):
1205         (WTR::AccessibilityController::resetToConsistentState):
1206         (WTR::findAccessibleObjectById):
1207         (WTR::AccessibilityController::accessibleElementById):
1208         * WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
1209         * WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1210         (WTR::AccessibilityTextMarker::isEqual):
1211         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.
1212         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1213         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1214         (WTR::AccessibilityUIElement::isEqual):
1215         (WTR::AccessibilityUIElement::getLinkedUIElements):
1216         (WTR::AccessibilityUIElement::getDocumentLinks):
1217         (WTR::AccessibilityUIElement::getChildren):
1218         (WTR::AccessibilityUIElement::getChildrenWithRange):
1219         (WTR::AccessibilityUIElement::childrenCount):
1220         (WTR::AccessibilityUIElement::elementAtPoint):
1221         (WTR::AccessibilityUIElement::indexOfChild):
1222         (WTR::AccessibilityUIElement::childAtIndex):
1223         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1224         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1225         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1226         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1227         (WTR::AccessibilityUIElement::rowAtIndex):
1228         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1229         (WTR::AccessibilityUIElement::selectedChildrenCount):
1230         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1231         (WTR::AccessibilityUIElement::titleUIElement):
1232         (WTR::AccessibilityUIElement::parentElement):
1233         (WTR::AccessibilityUIElement::disclosedByRow):
1234         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1235         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1236         (WTR::AccessibilityUIElement::attributesOfChildren):
1237         (WTR::AccessibilityUIElement::allAttributes):
1238         (WTR::AccessibilityUIElement::stringAttributeValue):
1239         (WTR::AccessibilityUIElement::numberAttributeValue):
1240         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
1241         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1242         (WTR::AccessibilityUIElement::boolAttributeValue):
1243         (WTR::AccessibilityUIElement::isAttributeSettable):
1244         (WTR::AccessibilityUIElement::isAttributeSupported):
1245         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1246         (WTR::AccessibilityUIElement::role):
1247         (WTR::AccessibilityUIElement::subrole):
1248         (WTR::AccessibilityUIElement::roleDescription):
1249         (WTR::AccessibilityUIElement::title):
1250         (WTR::AccessibilityUIElement::description):
1251         (WTR::AccessibilityUIElement::orientation):
1252         (WTR::AccessibilityUIElement::stringValue):
1253         (WTR::AccessibilityUIElement::language):
1254         (WTR::AccessibilityUIElement::helpText):
1255         (WTR::AccessibilityUIElement::x):
1256         (WTR::AccessibilityUIElement::y):
1257         (WTR::AccessibilityUIElement::width):
1258         (WTR::AccessibilityUIElement::height):
1259         (WTR::AccessibilityUIElement::clickPointX):
1260         (WTR::AccessibilityUIElement::clickPointY):
1261         (WTR::AccessibilityUIElement::intValue):
1262         (WTR::AccessibilityUIElement::minValue):
1263         (WTR::AccessibilityUIElement::maxValue):
1264         (WTR::AccessibilityUIElement::valueDescription):
1265         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1266         (WTR::AccessibilityUIElement::isPressActionSupported):
1267         (WTR::AccessibilityUIElement::isIncrementActionSupported):
1268         (WTR::AccessibilityUIElement::isDecrementActionSupported):
1269         (WTR::AccessibilityUIElement::isEnabled):
1270         (WTR::AccessibilityUIElement::isRequired):
1271         (WTR::AccessibilityUIElement::isFocused):
1272         (WTR::AccessibilityUIElement::isSelected):
1273         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1274         (WTR::AccessibilityUIElement::isIndeterminate):
1275         (WTR::AccessibilityUIElement::isExpanded):
1276         (WTR::AccessibilityUIElement::isChecked):
1277         (WTR::AccessibilityUIElement::hierarchicalLevel):
1278         (WTR::AccessibilityUIElement::classList):
1279         (WTR::AccessibilityUIElement::speak):
1280         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1281         (WTR::AccessibilityUIElement::ariaDropEffects):
1282         (WTR::AccessibilityUIElement::lineForIndex):
1283         (WTR::AccessibilityUIElement::rangeForLine):
1284         (WTR::AccessibilityUIElement::rangeForPosition):
1285         (WTR::AccessibilityUIElement::boundsForRange):
1286         (WTR::AccessibilityUIElement::stringForRange):
1287         (WTR::AccessibilityUIElement::attributedStringForRange):
1288         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1289         (WTR::uiElementCountForSearchPredicate):
1290         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1291         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1292         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1293         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1294         (WTR::AccessibilityUIElement::attributesOfColumns):
1295         (WTR::AccessibilityUIElement::attributesOfRows):
1296         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1297         (WTR::AccessibilityUIElement::attributesOfHeader):
1298         (WTR::AccessibilityUIElement::rowCount):
1299         (WTR::AccessibilityUIElement::columnCount):
1300         (WTR::AccessibilityUIElement::indexInTable):
1301         (WTR::AccessibilityUIElement::rowIndexRange):
1302         (WTR::AccessibilityUIElement::columnIndexRange):
1303         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1304         (WTR::AccessibilityUIElement::horizontalScrollbar):
1305         (WTR::AccessibilityUIElement::verticalScrollbar):
1306         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1307         (WTR::AccessibilityUIElement::selectedTextRange):
1308         (WTR::AccessibilityUIElement::setSelectedTextRange):
1309         (WTR::AccessibilityUIElement::increment):
1310         (WTR::AccessibilityUIElement::decrement):
1311         (WTR::AccessibilityUIElement::showMenu):
1312         (WTR::AccessibilityUIElement::press):
1313         (WTR::AccessibilityUIElement::setSelectedChild):
1314         (WTR::AccessibilityUIElement::accessibilityValue):
1315         (WTR::AccessibilityUIElement::documentEncoding):
1316         (WTR::AccessibilityUIElement::documentURI):
1317         (WTR::AccessibilityUIElement::url):
1318         (WTR::AccessibilityUIElement::addNotificationListener):
1319         (WTR::AccessibilityUIElement::removeNotificationListener):
1320         (WTR::AccessibilityUIElement::isFocusable):
1321         (WTR::AccessibilityUIElement::isSelectable):
1322         (WTR::AccessibilityUIElement::isMultiSelectable):
1323         (WTR::AccessibilityUIElement::isVisible):
1324         (WTR::AccessibilityUIElement::isOffScreen):
1325         (WTR::AccessibilityUIElement::isCollapsed):
1326         (WTR::AccessibilityUIElement::isIgnored):
1327         (WTR::AccessibilityUIElement::hasPopup):
1328         (WTR::AccessibilityUIElement::takeFocus):
1329         (WTR::AccessibilityUIElement::takeSelection):
1330         (WTR::AccessibilityUIElement::addSelection):
1331         (WTR::AccessibilityUIElement::removeSelection):
1332         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1333         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1334         (WTR::AccessibilityUIElement::previousTextMarker):
1335         (WTR::AccessibilityUIElement::nextTextMarker):
1336         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1337         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1338         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1339         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1340         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1341         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1342         (WTR::AccessibilityUIElement::textMarkerForPoint):
1343         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1344         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1345         (WTR::AccessibilityUIElement::indexForTextMarker):
1346         (WTR::AccessibilityUIElement::isTextMarkerValid):
1347         (WTR::AccessibilityUIElement::textMarkerForIndex):
1348         (WTR::AccessibilityUIElement::startTextMarker):
1349         (WTR::AccessibilityUIElement::endTextMarker):
1350         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1351         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1352         (WTR::AccessibilityUIElement::pathDescription):
1353         (WTR::AccessibilityUIElement::supportedActions):
1354         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1355         (WTR::activateFonts):
1356         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.
1357         (WTR::EventSenderProxy::EventSenderProxy):
1358         (WTR::EventSenderProxy::~EventSenderProxy):
1359         (WTR::EventSenderProxy::updateClickCountForButton):
1360         (WTR::EventSenderProxy::mouseDown):
1361         (WTR::EventSenderProxy::mouseUp):
1362         (WTR::EventSenderProxy::mouseMoveTo):
1363         (WTR::EventSenderProxy::leapForward):
1364         (WTR::EventSenderProxy::keyDown):
1365         (WTR::EventSenderProxy::mouseScrollBy):
1366         (WTR::EventSenderProxy::continuousMouseScrollBy):
1367         (WTR::EventSenderProxy::addTouchPoint):
1368         (WTR::EventSenderProxy::updateTouchPoint):
1369         (WTR::EventSenderProxy::setTouchModifier):
1370         (WTR::EventSenderProxy::setTouchPointRadius):
1371         (WTR::EventSenderProxy::touchStart):
1372         (WTR::EventSenderProxy::touchMove):
1373         (WTR::EventSenderProxy::touchEnd):
1374         (WTR::EventSenderProxy::touchCancel):
1375         (WTR::EventSenderProxy::clearTouchPoints):
1376         (WTR::EventSenderProxy::releaseTouchPoint):
1377         (WTR::EventSenderProxy::cancelTouchPoint):
1378         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1379         (WTR::InjectedBundle::platformInitialize):
1380         * WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1381         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1382         * WebKitTestRunner/Makefile:
1383         * WebKitTestRunner/TestController.cpp:
1384         (WTR::TestController::initialize):
1385         * WebKitTestRunner/TestController.h:
1386         * WebKitTestRunner/TestInvocation.cpp:
1387         (WTR::TestInvocation::invoke):
1388         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1389         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1390         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
1391         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.
1392         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
1393         (-[AppDelegate applicationWillResignActive:]):
1394         (-[AppDelegate applicationDidEnterBackground:]):
1395         (-[AppDelegate applicationWillEnterForeground:]):
1396         (-[AppDelegate applicationDidBecomeActive:]):
1397         (-[AppDelegate applicationWillTerminate:]):
1398         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
1399         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
1400         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
1401         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
1402         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
1403         * WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.
1404         (main):
1405         * WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
1406         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
1407         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.
1408         (-[WebKitTestRunnerAppTests setUp]):
1409         (-[WebKitTestRunnerAppTests tearDown]):
1410         (-[WebKitTestRunnerAppTests testExample]):
1411         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
1412         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1413         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1414         * WebKitTestRunner/iOS.xcconfig: Added.
1415         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.
1416         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
1417         (-[TestRunnerWKView _shouldUseTiledDrawingArea]):
1418         (-[WebKitTestRunnerWindow isKeyWindow]):
1419         (-[WebKitTestRunnerWindow setFrameOrigin:]):
1420         (-[WebKitTestRunnerWindow setFrame:]):
1421         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1422         (-[WebKitTestRunnerWindow backingScaleFactor]):
1423         (WTR::PlatformWebView::PlatformWebView):
1424         (WTR::PlatformWebView::resizeTo):
1425         (WTR::PlatformWebView::~PlatformWebView):
1426         (WTR::PlatformWebView::page):
1427         (WTR::PlatformWebView::focus):
1428         (WTR::PlatformWebView::windowFrame):
1429         (WTR::PlatformWebView::setWindowFrame):
1430         (WTR::PlatformWebView::didInitializeClients):
1431         (WTR::PlatformWebView::addChromeInputField):
1432         (WTR::PlatformWebView::removeChromeInputField):
1433         (WTR::PlatformWebView::makeWebViewFirstResponder):
1434         (WTR::PlatformWebView::windowSnapshotImage):
1435         (WTR::PlatformWebView::viewSupportsOptions):
1436         * WebKitTestRunner/ios/TestControllerIOS.mm: Added.
1437         (WTR::TestController::notifyDone):
1438         (WTR::TestController::platformInitialize):
1439         (WTR::TestController::platformDestroy):
1440         (WTR::TestController::initializeInjectedBundlePath):
1441         (WTR::TestController::initializeTestPluginDirectory):
1442         (WTR::TestController::platformRunUntil):
1443         (WTR::TestController::platformInitializeContext):
1444         (WTR::TestController::runModal):
1445         (WTR::TestController::platformLibraryPathForTesting):
1446         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1447         (createCFURLResponseFromResponseData):
1448         (supportedNonImageMIMETypes):
1449         * WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1450         (-[WebKitTestRunnerApp _runTestController]):
1451         (-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
1452         (main):
1453
1454 2014-01-24  Enrique Ocaña González  <eocanha@igalia.com>
1455
1456         [GTK] Put cache files in XDG_CACHE_HOME
1457         https://bugs.webkit.org/show_bug.cgi?id=123458
1458
1459         Reviewed by Martin Robinson.
1460
1461         * GtkLauncher/main.c:
1462         (createBrowser):
1463
1464 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
1465
1466         Remove CSS Custom Filters code and tests
1467         https://bugs.webkit.org/show_bug.cgi?id=127382
1468
1469         Reviewed by Simon Fraser.
1470
1471         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1472         (resetDefaultsToConsistentValues):
1473         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1474         (TestRunner::overridePreference):
1475
1476 2014-01-23  Tim Horton  <timothy_horton@apple.com>
1477
1478         PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
1479         https://bugs.webkit.org/show_bug.cgi?id=127415
1480         <rdar://problem/12482452>
1481
1482         Reviewed by Sam Weinig.
1483
1484         Adopt the new page loader client plugin load callback.
1485
1486         * WebKitTestRunner/TestController.cpp:
1487         (WTR::TestController::createWebViewWithOptions):
1488         (WTR::TestController::pluginLoadPolicy):
1489         * WebKitTestRunner/TestController.h:
1490
1491 2014-01-23  peavo@outlook.com  <peavo@outlook.com>
1492
1493         [Curl] There is no way to specify cache folder.
1494         https://bugs.webkit.org/show_bug.cgi?id=125028
1495
1496         Reviewed by Brent Fulgham.
1497
1498         Enable disc cache in WinLauncher by setting cache folder location.
1499
1500         * WinLauncher/WinLauncher.cpp:
1501         (getAppDataFolder): Added function to get app data folder.
1502         (setCacheFolder): Added function to set cache folder.
1503         (createCrashReport): Use new getAppDataFolder function.
1504         (wWinMain): Use function setCacheFolder to set cache folder location.
1505
1506 2014-01-23  Daniel Bates  <dabates@apple.com>
1507
1508         build-webkit --sdk=iphonesimulator doesn't think it's building iOS
1509         https://bugs.webkit.org/show_bug.cgi?id=127379
1510
1511         Reviewed by Simon Fraser.
1512
1513         Teach build-webkit to recognize --sdk=X.
1514
1515         Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
1516         considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
1517         help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
1518         of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).
1519
1520         * Scripts/webkitdirs.pm:
1521         (checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
1522         (checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().
1523         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
1524
1525 2014-01-23  Commit Queue  <commit-queue@webkit.org>
1526
1527         Unreviewed, rolling out r162612.
1528         http://trac.webkit.org/changeset/162612
1529         https://bugs.webkit.org/show_bug.cgi?id=127488
1530
1531         broke the build (Requested by mhahnenberg on #webkit).
1532
1533         * Scripts/build-jsc:
1534         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
1535         * jsc-cli/jsc-cli/CLIInstance.h: Removed.
1536         * jsc-cli/jsc-cli/CLIInstance.m: Removed.
1537         * jsc-cli/jsc-cli/JSModule.h: Removed.
1538         * jsc-cli/jsc-cli/JSModule.m: Removed.
1539         * jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
1540         * jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
1541         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
1542         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
1543         * jsc-cli/jsc-cli/RunLoopThread.h: Removed.
1544         * jsc-cli/jsc-cli/RunLoopThread.m: Removed.
1545         * jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
1546         * jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
1547         * jsc-cli/jsc-cli/main.m: Removed.
1548
1549 2014-01-23  Mark Hahnenberg  <mhahnenberg@apple.com>
1550
1551         Basic framework for a modern jsc CLI
1552         https://bugs.webkit.org/show_bug.cgi?id=127435
1553
1554         Reviewed by Geoffrey Garen.
1555
1556         The most basic components of a modern jsc command line interface consist of the following:
1557
1558         - A simple REPL to enter commands and receive results
1559         - The ability to define a module (which consists of various internal methods as well as a 
1560           set of externally visible methods)
1561         - The ability to load other modules at runtime
1562         - The ability to interact with the underlying platform to perform various "privileged" 
1563           functions (e.g. opening files, printing to the stdout, etc.)
1564         
1565         The basic architecture will look something like the following:
1566         - If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL 
1567           on the main thread and start a secondary thread with a run loop to handle various inputs 
1568           from the REPL thread.
1569         - If the tool is given a script to run, it will evaluate that script (and any scripts that 
1570           it might transitively load) within the run loop on the secondary thread while the main 
1571           thread blocks until it has completed.
1572
1573         * Scripts/build-jsc:
1574         * jsc-cli: Added.
1575         * jsc-cli/jsc-cli: Added.
1576         * jsc-cli/jsc-cli.xcodeproj: Added.
1577         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
1578         * jsc-cli/jsc-cli/CLIInstance.h: Added.
1579         * jsc-cli/jsc-cli/CLIInstance.m: Added.
1580         (-[CLIInstance init]):
1581         (-[CLIInstance loadFile:]):
1582         (-[CLIInstance run]):
1583         * jsc-cli/jsc-cli/JSModule.h: Added.
1584         * jsc-cli/jsc-cli/JSModule.m: Added.
1585         (coreModules):
1586         (isCoreModule):
1587         (classForModule):
1588         (coreModuleFullPath):
1589         (resolveModuleAsFile):
1590         (resolveModuleAsDirectory):
1591         (nodeModulePaths):
1592         (resolveAsNodeModule):
1593         (+[JSModule resolve:atPath:]):
1594         (globalModuleCache):
1595         (isCached):
1596         (cachedModule):
1597         (cacheModule):
1598         (+[JSModule require:atPath:]):
1599         (+[JSModule require:atPath:inContext:]):
1600         (-[JSModule platformObjectInContext:]):
1601         (-[JSModule initWithId:filename:context:]):
1602         (-[JSModule dealloc]):
1603         (-[JSModule didStartLoading]):
1604         (-[JSModule didFinishLoading]):
1605         (-[JSModule require:]):
1606         (-[JSModule exports]):
1607         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
1608         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
1609         (jsThreadMain):
1610         (+[JSRunLoopThread threadMain]):
1611         (-[JSRunLoopThread initWithFiles:andContext:]):
1612         (-[JSRunLoopThread startRunLoop]):
1613         (-[JSRunLoopThread start]):
1614         (-[JSRunLoopThread join]):
1615         (-[JSRunLoopThread didReceiveInput:]):
1616         (-[JSRunLoopThread performCallback:withError:]):
1617         (-[JSRunLoopThread performCallback:withArguments:]):
1618         (-[JSRunLoopThread didFinishRunLoopInitialization]):
1619         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
1620         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
1621         (-[ReadEvalPrintLoop initWithJSThread:]):
1622         (prompt):
1623         (escapeStringForOutput):
1624         (-[ReadEvalPrintLoop processNextInput]):
1625         (-[ReadEvalPrintLoop run]):
1626         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
1627         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
1628         (+[RunLoopThread threadMain]):
1629         (-[RunLoopThread init]):
1630         (-[RunLoopThread dealloc]):
1631         (-[RunLoopThread didFinishRunLoopInitialization]):
1632         (-[RunLoopThread start]):
1633         (-[RunLoopThread join]):
1634         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
1635         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
1636         (scriptInputSourceScheduleRoutine):
1637         (scriptInputSourcePerformRoutine):
1638         (scriptInputSourceCancelRoutine):
1639         (-[ScriptInputSource initWithContext:]):
1640         (-[ScriptInputSource dealloc]):
1641         (-[ScriptInputSource addToCurrentRunLoop]):
1642         (-[ScriptInputSource removeFromRemoteRunLoop]):
1643         (-[ScriptInputSource didReceiveScript:]):
1644         (-[ScriptInputSource didReceiveSignal]):
1645         (-[ScriptInputSource runScriptRemotely:]):
1646         (-[ScriptInputSource finishAsyncCallback:withResult:]):
1647         * jsc-cli/jsc-cli/main.m: Added.
1648         (main):
1649
1650 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
1651
1652         Remove a FIXME comment that is already fixed.
1653         https://bugs.webkit.org/show_bug.cgi?id=127468
1654
1655         Reviewed by Csaba Osztrogonác.
1656
1657         * Scripts/webkitpy/style/filereader.py:
1658         (TextFileReader.__init__):
1659
1660 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1661
1662         [GLIB] Use GUniquePtr instead of GOwnPtr
1663         https://bugs.webkit.org/show_bug.cgi?id=127431
1664
1665         Reviewed by Martin Robinson.
1666
1667         GUniquePtr is a template alias of std::unique_ptr with a custom
1668         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
1669         where the output pointer is needed, but it will also be replaced soon.
1670
1671         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1672         (printAccessibilityEvent):
1673         (axObjectEventListener):
1674         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1675         (indexRangeInTable):
1676         (AccessibilityUIElement::role):
1677         (AccessibilityUIElement::title):
1678         (AccessibilityUIElement::description):
1679         (AccessibilityUIElement::stringValue):
1680         (AccessibilityUIElement::language):
1681         (AccessibilityUIElement::lineForIndex):
1682         (AccessibilityUIElement::selectedTextRange):
1683         (AccessibilityUIElement::url):
1684         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
1685         (AccessibilityController::accessibleElementById):
1686         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1687         (AccessibilityController::accessibleElementById):
1688         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1689         (getOutputDir):
1690         (getFontsPath):
1691         (initializeFonts):
1692         (dumpFramesAsText):
1693         (compareHistoryItems):
1694         (dumpHistoryItem):
1695         (soupURIToStringPreservingPassword):
1696         (resetDefaultsToConsistentValues):
1697         (temporaryDatabaseDirectory):
1698         (webViewTitleChanged):
1699         (webFrameLoadStatusNotified):
1700         (pathFromSoupURI):
1701         (convertWebResourceToURLPath):
1702         (urlSuitableForTestResult):
1703         (descriptionSuitableForTestResult):
1704         (willSendRequestCallback):
1705         (frameLoadEventCallback):
1706         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1707         (dumpNodePath):
1708         (dumpRange):
1709         (shouldApplyStyle):
1710         * DumpRenderTree/gtk/EventSender.cpp:
1711         (contextClickCallback):
1712         (beginDragWithFilesCallback):
1713         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1714         (TestRunner::pathToLocalResource):
1715         (TestRunner::queueLoad):
1716         (TestRunner::removeOriginAccessWhitelistEntry):
1717         (TestRunner::setMockGeolocationPositionUnavailableError):
1718         (TestRunner::setIconDatabaseEnabled):
1719         (TestRunner::findString):
1720         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1721         (TestRunner::overridePreference):
1722         (TestRunner::addUserScript):
1723         (TestRunner::addUserStyleSheet):
1724         (TestRunner::setTextDirection):
1725         * DumpRenderTree/gtk/TextInputController.cpp:
1726         (setMarkedTextCallback):
1727         (insertTextCallback):
1728         (doCommandCallback):
1729         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1730         (LoadHTMLStringItem::invoke):
1731         * TestWebKitAPI/PlatformGTK.cmake:
1732         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1733         (WebKitDOMNodeTest::testTagNames):
1734         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1735         (testBackForwardListLimitAndCache):
1736         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1737         (testContextMenuSmartSeparators):
1738         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1739         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1740         (testDownloadLocalFile):
1741         (testDownloadLocalFileError):
1742         (addContentDispositionHTTPHeaderToResponse):
1743         (serverCallback):
1744         (testDownloadRemoteFileError):
1745         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1746         (startTestServer):
1747         (testInspectorServerPageList):
1748         (openRemoteDebuggingSession):
1749         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1750         (testPrintOperationPrint):
1751         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1752         (addCacheHTTPHeadersToResponse):
1753         (serverCallback):
1754         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1755         (httpsServerCallback):
1756         (httpServerCallback):
1757         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1758         (testWebViewJavaScriptDialogs):
1759         (testWebViewWindowProperties):
1760         (testWebViewFileChooserRequest):
1761         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1762         (testWebExtensionWindowObjectCleared):
1763         (testWebExtensionIsolatedWorld):
1764         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1765         (startTestServer):
1766         (checkAtspiAccessible):
1767         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1768         (serverCallback):
1769         (testClearDatabase):
1770         (testGetFaviconURI):
1771         (webkitFaviconDatabaseFinalizedCallback):
1772         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1773         (testWebContextGetPlugins):
1774         (testWebContextURIScheme):
1775         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1776         (testWebViewRunJavaScript):
1777         (testWebViewMode):
1778         (testWebViewPageVisibility):
1779         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
1780         (isStyleSheetInjectedForURLAtPath):
1781         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1782         (testWebViewEditorCutCopyPasteNonEditable):
1783         (testWebViewEditorCutCopyPasteEditable):
1784         (testWebViewEditorSelectAllNonEditable):
1785         (testWebViewEditorSelectAllEditable):
1786         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1787         (sendRequestCallback):
1788         (methodCallCallback):
1789         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1790         (TestWebKitAPI::Util::createInjectedBundlePath):
1791         (TestWebKitAPI::Util::createURLForResource):
1792         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1793         (TestWebKitAPI::doKeyStroke):
1794         (TestWebKitAPI::doMouseButtonEvent):
1795         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1796         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1797         (loadFailedCallback):
1798         (LoadTrackingTest::loadURI):
1799         (LoadTrackingTest::loadHtml):
1800         (LoadTrackingTest::loadPlainText):
1801         (LoadTrackingTest::loadRequest):
1802         (LoadTrackingTest::reload):
1803         (LoadTrackingTest::goBack):
1804         (LoadTrackingTest::goForward):
1805         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1806         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1807         (registerGResource):
1808         (removeNonEmptyDirectory):
1809         (main):
1810         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1811         (Test::getWebKit1TestResoucesDir):
1812         (Test::getResourcesDir):
1813         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1814         (WebKitTestBus::run):
1815         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1816         (WebKitTestServer::WebKitTestServer):
1817         (WebKitTestServer::getURIForPath):
1818         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
1819         (WebProcessTestRunner::runTest):
1820         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1821         (resourceGetDataCallback):
1822         (WebViewTest::mainResourceData):
1823         (WebViewTest::mouseMoveTo):
1824         (WebViewTest::keyStroke):
1825         (WebViewTest::doMouseButtonEvent):
1826         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1827         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1828         (WTR::AccessibilityController::accessibleElementById):
1829         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1830         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1831         (WTR::AccessibilityUIElement::role):
1832         (WTR::AccessibilityUIElement::title):
1833         (WTR::AccessibilityUIElement::description):
1834         (WTR::AccessibilityUIElement::stringValue):
1835         (WTR::AccessibilityUIElement::language):
1836         (WTR::AccessibilityUIElement::lineForIndex):
1837         (WTR::AccessibilityUIElement::selectedTextRange):
1838         (WTR::AccessibilityUIElement::url):
1839         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1840         (WTR::getOutputDir):
1841         (WTR::getFontsPath):
1842         (WTR::initializeFontConfigSetting):
1843         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1844         (WTR::topLevelPath):
1845         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1846         (WTR::TestRunner::pathToLocalResource):
1847         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1848         (WTR::TestController::initializeInjectedBundlePath):
1849         (WTR::TestController::initializeTestPluginDirectory):
1850
1851 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
1852
1853         [GTK] [CMake] run-webkit-tests should support the CMake build
1854         https://bugs.webkit.org/show_bug.cgi?id=126503
1855
1856         Reviewed by Daniel Bates.
1857
1858         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
1859         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
1860
1861         * Scripts/run-launcher: Work properly with the gtkcmake flag.
1862         * Scripts/webkitpy/port/gtk.py:
1863         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
1864         file to detect a CMake build.
1865         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
1866         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
1867         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
1868         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
1869         (GtkPort._path_to_driver): Use the new helper.
1870         (GtkPort._path_to_image_diff): Use the new helper.
1871         (GtkPort._path_to_webcore_library): Use the new helper.
1872         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
1873
1874 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
1875
1876         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
1877         https://bugs.webkit.org/show_bug.cgi?id=127417
1878
1879         Reviewed by Gyuyoung Kim.
1880
1881         * EWebLauncher/main.c:
1882         (on_key_down): Removed shortcut to test pre render.
1883
1884 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
1885
1886         Remove CSS3_TEXT_DECORATION define
1887         https://bugs.webkit.org/show_bug.cgi?id=127333
1888
1889         This is required for unprefixing the text-decoration-* CSS properties.
1890
1891         Reviewed by Simon Fraser.
1892
1893         * Configurations/FeatureDefines.xcconfig:
1894
1895 2014-01-22  Andy Estes  <aestes@apple.com>
1896
1897         [iOS] Prepare for upstreaming DumpRenderTree changes
1898         https://bugs.webkit.org/show_bug.cgi?id=127412
1899
1900         Reviewed by Simon Fraser.
1901
1902         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
1903         an application bundle. Instead of upstreaming a separate target for the
1904         app that duplicates the 'Compile Sources' phase of the tool, separate
1905         out the compilation into a static library target that both the
1906         command-line tool and the app can link against. Also, perform some
1907         unrelated cleanup.
1908
1909         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
1910         project file format from 2.4- to 3.2-compatible. Removed the
1911         'Copy Headers' build phase and removed all files from the
1912         'Compile Sources' build phase of DumpRenderTree. Added some files that
1913         were missing from the project. Created a 'DumpRenderTree (Library)'
1914         target for building the static library and made the 'DumpRenderTree'
1915         target depend on it. Added a 'Compile Sources' build phase to this
1916         target that builds the same files the DumpRenderTree target used to.
1917         Created DumpRenderTreeMain.mm as the only source file of the
1918         DumpRenderTree target, since targets won't link a binary without at
1919         least one source file. Made DumpRenderTree (Library) use
1920         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
1921         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
1922         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
1923         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
1924         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
1925         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
1926         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
1927         This is needed to correctly link a static library containing an Objective-C
1928         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
1929         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
1930         * DumpRenderTree/mac/DumpRenderTree.mm:
1931         (DumpRenderTreeMain): Renamed from main.
1932         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
1933         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
1934         (main): Called DumpRenderTreeMain from main.
1935
1936 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
1937
1938         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
1939         https://bugs.webkit.org/show_bug.cgi?id=127073
1940
1941         Reviewed by Daniel Bates.
1942
1943         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
1944         the new isCMakeBuild conditional. This allows us to share more code between ports.
1945         Pass the build arguments to the removeCMakeCache function.
1946         * Scripts/webkitdirs.pm:
1947         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
1948         because it's now shared with the CMake build.
1949         (cachedArgumentFileOutOfDate): Renamed.
1950         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
1951         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
1952         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
1953         as well as checking if build-webkit has been run with different arguments.
1954         (removeCMakeCache): Call shouldRemoveCMakeCache now.
1955         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
1956         (isCMakeBuild): Added.
1957
1958 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
1959
1960         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
1961         https://bugs.webkit.org/show_bug.cgi?id=127119
1962
1963         Reviewed by Mario Sanchez Prada.
1964
1965         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
1966
1967         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1968         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1969         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1970         (resetDefaultsToConsistentValues):
1971         (webViewWindowObjectCleared):
1972         (main):
1973         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1974         (WTR::AccessibilityController::platformName):
1975         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1976         (WTR::AccessibilityUIElement::isIndeterminate):
1977
1978 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1979
1980
1981         [GTK] Add GUniquePtr
1982         https://bugs.webkit.org/show_bug.cgi?id=127170
1983
1984         Reviewed by Gustavo Noronha Silva.
1985
1986         Add unit tests for GUniquePtr.
1987
1988         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
1989         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
1990         (log):
1991         (takeLogStr):
1992         (TestWebKitAPI::TEST):
1993
1994 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
1995
1996         Remove Nix files from Tools
1997         https://bugs.webkit.org/show_bug.cgi?id=127418
1998
1999         Reviewed by Csaba Osztrogonác.
2000
2001         * Scripts/build-webkit:
2002         * Scripts/update-webkit-libs-jhbuild:
2003         * Scripts/webkitdirs.pm:
2004         (determineArchitecture):
2005         (argumentsForConfiguration):
2006         (jscProductDir):
2007         (builtDylibPathForName):
2008         (isAppleWebKit):
2009         (launcherPath):
2010         (launcherName):
2011         (checkRequiredSystemConfig):
2012         (copyInspectorFrontendFiles):
2013         (jhbuildWrapperPrefixIfNeeded):
2014         (buildCMakeProjectOrExit):
2015         (cmakeBasedPortName):
2016         * Scripts/webkitpy/common/config/ports.py:
2017         (DeprecatedPort.port):
2018         (EflWK2Port.build_webkit_command):
2019         * Scripts/webkitpy/port/factory.py:
2020         (platform_options):
2021         (PortFactory):
2022         * Scripts/webkitpy/port/nix.py: Removed.
2023         * Scripts/webkitpy/port/nix_unittest.py: Removed.
2024
2025 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
2026
2027         Add Ian and Ricky to the contributor list
2028
2029         * Scripts/webkitpy/common/config/contributors.json:
2030         I am too old to remember all those email addresses :)
2031
2032 2014-01-21  David Farler  <dfarler@apple.com>
2033
2034         Upstream package-root for iOS
2035
2036         Reviewed by Daniel bates.
2037
2038         * Scripts/package-root: Added.
2039         (usage):
2040         * Scripts/webkitdirs.pm:
2041         (XcodeSDKPath): Added function.
2042
2043 2014-01-21  Daniel Bates  <dabates@apple.com>
2044
2045         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
2046         https://bugs.webkit.org/show_bug.cgi?id=127368
2047
2048         Reviewed by Tim Horton.
2049
2050         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
2051         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
2052         Tools.
2053
2054         * Makefile:
2055
2056 2014-01-21  Daniel Bates  <dabates@apple.com>
2057
2058         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
2059         https://bugs.webkit.org/show_bug.cgi?id=127364
2060
2061         Reviewed by Simon Fraser.
2062
2063         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
2064         projects fail to build because we need to upstream the relevant iOS changes.
2065         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
2066         aren't building TestWebKitAPI.
2067
2068         * Scripts/build-webkit:
2069
2070 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2071
2072         Unreviewed, remove myself from some watchlist entries.
2073
2074         * Scripts/webkitpy/common/config/watchlist:
2075
2076 2014-01-21  Zalan Bujtas  <zalan@apple.com>
2077
2078         Use 64 as the default value for the subpixel denominator.
2079
2080         Reviewed by Simon Fraser.
2081
2082         * lldb/lldb_webkit.py:
2083         (WebCoreLayoutUnitProvider.to_string):
2084
2085 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
2086
2087         [GTK] Fix a c++11 compliance issue for fontconfig
2088         https://bugs.webkit.org/show_bug.cgi?id=127283
2089
2090         Reviewed by Martin Robinson.
2091
2092         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
2093         hotfix until bumping fontconfig up.
2094
2095         * gtk/jhbuild.modules:
2096         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2097
2098 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2099
2100         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
2101         like run_webkit_test does
2102         https://bugs.webkit.org/show_bug.cgi?id=127349
2103
2104         Reviewed by Csaba Osztrogonác.
2105
2106         * Scripts/run-jsc-stress-tests:
2107
2108 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
2109
2110         [GTK] Allow passing extra data to web extensions
2111         https://bugs.webkit.org/show_bug.cgi?id=125990
2112
2113         Reviewed by Carlos Garcia Campos.
2114
2115         Allow passing additional information to the injected bundle. On top
2116         of the string containing the path to the web extensions directory,
2117         a GVariant can be set with additional data using
2118         webkit_web_context_set_web_extensions_initialization_user_data().
2119         Also, a new initialize-web-extensions signal is emitted before
2120         launching a new WebProcess to allow setting different user data
2121         for each process. The GVariant is serialized as a string, passed
2122         to the injected bundle, and the injected bundle deserializes back
2123         the data, which is passed to web extensions which define the
2124         webkit_web_extension_initialize_with_user_data() function (for
2125         backwards compatibility, webkit_web_extension_initialize() is
2126         used as a fallback.)
2127
2128         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2129         (initializeWebExtensions): Handles the initialize-web-extensions
2130         signal, and sets the web extensions directory and the initialization
2131         user data.
2132         (testWebExtensionInitializationUserData): New test case for checking
2133         the user data passed on initialization to web extensions.
2134         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2135         (methodCallCallback): Added implementation for the
2136         GetInitializationUserData D-Bus method, used by
2137         testWebExtensionInitializationUserData().
2138         (webkit_web_extension_initialize_with_user_data): Define the
2139         initialization function with the additional user data parameter.
2140
2141 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
2142
2143         Change my email address in contributors.json.
2144
2145         Unreviewed.
2146
2147         * Scripts/webkitpy/common/config/contributors.json:
2148
2149 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
2150
2151         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
2152         https://bugs.webkit.org/show_bug.cgi?id=127291
2153
2154         Reviewed by Mario Sanchez Prada.
2155
2156         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
2157
2158         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2159         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2160         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2161         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2162
2163 2014-01-20  Zalan Bujtas  <zalan@apple.com>
2164
2165         Force float division when calculating CSS px value.
2166
2167         Reviewed by Simon Fraser.
2168
2169         Note that in Python 3, this is the default behavior.
2170
2171         * lldb/lldb_webkit.py:
2172         (WebCoreLayoutUnitProvider.to_string):
2173
2174 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2175
2176         build.webkit.org/dashboard should display information about patches in EWS
2177         https://bugs.webkit.org/show_bug.cgi?id=127006
2178
2179         Reviewed by Ryosuke Niwa.
2180
2181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2182         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
2183         (Bugzilla.prototype.detailsURLForAttachment):
2184         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
2185         which is needed when one wants to do something with a patch EWS is stuck on.
2186
2187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2188         Create a Bugzilla instance.
2189
2190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2191         (EWS.prototype.jsonQueueLengthURL):
2192         (EWS.prototype.jsonQueueStatusURL):
2193         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
2194
2195         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2196         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
2197         of second guessing.
2198         (EWSQueue.prototype.get chartsPageURL): Added.
2199         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
2200         additional data already loaded (it's reset with every update).
2201         (EWSQueue.prototype.get patches): Get patch queue.
2202         (EWSQueue.prototype.get bots): Get bots.
2203         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
2204         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
2205
2206         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2207         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
2208         in the queue.
2209         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
2210         (EWSQueueView.prototype.addTextToRow): Ditto.
2211         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
2212         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
2213         (EWSQueueView.prototype._addDividerToPopover): Ditto.
2214         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
2215         relative string.
2216         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
2217         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
2218         it when done.
2219
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2221         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
2222         Changed a few difficult to read padding styles to padding-left.
2223
2224 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2225
2226         Fix webkitpy tests.
2227
2228         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
2229         Added a mock implementation, as we now call this function.
2230
2231 2014-01-20  Darin Adler  <darin@apple.com>
2232
2233         Update style checker and tests to deal with override instead of OVERRIDE
2234         https://bugs.webkit.org/show_bug.cgi?id=127175
2235
2236         Reviewed by Anders Carlsson.
2237
2238         * Scripts/webkitpy/style/checkers/cpp.py:
2239         (check_braces): Use override instead of OVERRIDE.
2240         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2241         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
2242
2243 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2244
2245         EWS should provide better information to Dashboard via JSON
2246         https://bugs.webkit.org/show_bug.cgi?id=127265
2247
2248         Reviewed by Ryosuke Niwa.
2249
2250         * QueueStatusServer/app.yaml: Updated version.
2251
2252         * QueueStatusServer/main.py:
2253         * QueueStatusServer/handlers/queuelengthjson.py:
2254         Added a way to cheaply get only the queue length, which is all the dashboard
2255         needs unless a popover is opened.
2256
2257         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
2258         that we will need. Changed some field names to be more meaningful. Fixed bot listing
2259         to understand that a bot can be reprurposed and used in a different queue.
2260
2261 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2262
2263         Make uploading results to EWS work despite robots.txt
2264         https://bugs.webkit.org/show_bug.cgi?id=127296
2265
2266         Reviewed by Ryosuke Niwa.
2267
2268         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
2269         checking robots.txt.
2270
2271         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
2272         Removed a comment saying that we would want to stop doing this. Not checking
2273         robots.txt is more efficient than checking it.
2274
2275 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
2276
2277         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
2278         https://bugs.webkit.org/show_bug.cgi?id=127214
2279
2280         Reviewed by Gyuyoung Kim.
2281
2282         Followed the changes of API.
2283
2284         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2285         (drtViewAdd):
2286         * EWebLauncher/main.c:
2287         (windowCreate):
2288
2289 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
2290
2291         [EFL][WK2] Add touch events option to MiniBrowser.
2292         https://bugs.webkit.org/show_bug.cgi?id=127262
2293
2294         Reviewed by Gyuyoung Kim.
2295
2296         As a default, touch events are disabled and mouse events are enabled.
2297         If touch events option sets to true, touch events are enabled and mouse
2298         events are disabled.
2299
2300         * MiniBrowser/efl/main.c:
2301         (window_create):
2302         (elm_main):
2303
2304 2014-01-19  Zalan Bujtas  <zalan@apple.com>
2305
2306         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
2307         https://bugs.webkit.org/show_bug.cgi?id=126080
2308
2309         Reviewed by Sam Weinig.
2310
2311         This changes the output of printing LayoutUnits to be in px but it also
2312         preserves the original LayoutUnit value.
2313
2314         This will lead to lldb output like: (and it works even when subpixel is disabled)
2315
2316         (const WebCore::LayoutRect) $0 = {
2317             m_location = { x = 2.25px (144), y = 1px (64)}
2318             m_size = { width = 13.75px (880), height = 20px (1280) }
2319
2320
2321         And gdb output like:
2322
2323         m_frameRect = {
2324             m_location = LayoutPoint(0px (0), 0px(0)),
2325             m_size = LayoutSize(8px (512), 5px (320))
2326         }
2327
2328         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
2329
2330         * gdb/webkit.py:
2331         (WebCoreLayoutUnitPrinter):
2332         (WebCoreLayoutUnitPrinter.__init__):
2333         (WebCoreLayoutUnitPrinter.to_string):
2334         (WebCoreLayoutSizePrinter):
2335         (WebCoreLayoutSizePrinter.__init__):
2336         (WebCoreLayoutSizePrinter.to_string):
2337         (WebCoreLayoutPointPrinter):
2338         (WebCoreLayoutPointPrinter.__init__):
2339         (WebCoreLayoutPointPrinter.to_string):
2340         (add_pretty_printers):
2341         * lldb/lldb_webkit.py:
2342         (__lldb_init_module):
2343         (WebCoreLayoutUnit_SummaryProvider):
2344         (WebCoreLayoutSize_SummaryProvider):
2345         (WebCoreLayoutPoint_SummaryProvider):
2346         (WebCoreLayoutUnitProvider):
2347         (WebCoreLayoutUnitProvider.__init__):
2348         (WebCoreLayoutUnitProvider.to_string):
2349         (WebCoreLayoutSizeProvider):
2350         (WebCoreLayoutSizeProvider.__init__):
2351         (WebCoreLayoutSizeProvider.get_width):
2352         (WebCoreLayoutSizeProvider.get_height):
2353         (WebCoreLayoutPointProvider):
2354         (WebCoreLayoutPointProvider.__init__):
2355         (WebCoreLayoutPointProvider.get_x):
2356         (WebCoreLayoutPointProvider.get_y):
2357
2358 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2359
2360         Add robots.txt to http://webkit-queues.appspot.com
2361         https://bugs.webkit.org/show_bug.cgi?id=127240
2362
2363         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
2364
2365 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2366
2367         Add robots.txt to http://webkit-queues.appspot.com
2368         https://bugs.webkit.org/show_bug.cgi?id=127240
2369
2370         Reviewed by Ryosuke Niwa.
2371
2372         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
2373
2374         * QueueStatusServer/robots.txt: Added.
2375
2376 2014-01-18  Alberto Garcia  <berto@igalia.com>
2377
2378         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
2379         https://bugs.webkit.org/show_bug.cgi?id=127217
2380
2381         Reviewed by Daniel Bates.
2382
2383         The syntax File::Temp->tempdir() was explicitly made invalid
2384         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
2385         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
2386
2387         Use File::Temp::tempdir() instead.
2388
2389         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2390
2391 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2392
2393         build.webkit.org/dashboard should have image diff links in test results popovers
2394         https://bugs.webkit.org/show_bug.cgi?id=127188
2395
2396         Reviewed by Timothy Hatcher.
2397
2398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2399         (Buildbot.prototype.layoutTestImagesURLForIteration):
2400         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
2401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2402         (BuildbotIteration.prototype.loadLayoutTestResults):
2403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2404         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
2405         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
2406         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
2407
2408 2014-01-18  Anders Carlsson  <andersca@apple.com>
2409
2410         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
2411         https://bugs.webkit.org/show_bug.cgi?id=127225
2412
2413         Reviewed by Andreas Kling.
2414
2415         This concludes the removal of over 8.8 million lines of threaded parser code.
2416
2417         * Scripts/webkitperl/FeatureList.pm:
2418
2419 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
2420
2421         build.webkit.org/dashboard should have diff links in test results popovers
2422         https://bugs.webkit.org/show_bug.cgi?id=126986
2423
2424         Reviewed by Tim Horton.
2425
2426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2427         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
2428         (Buildbot.prototype.layoutTestStderrURLForIteration):
2429         (Buildbot.prototype.layoutTestDiffURLForIteration):
2430         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2432         (BuildbotIteration.prototype.loadLayoutTestResults):
2433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2434         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
2435
2436 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
2437
2438         Add the bare minimum support for branches to the bot-watchers dashboard
2439         https://bugs.webkit.org/show_bug.cgi?id=127124
2440
2441         This patch simply introduces the notion of branches into the bot-watchers dashboard.
2442         Subsequent patches will build functionality on top of this simple bit of infrastructure.
2443
2444         Reviewed by Timothy Hatcher.
2445
2446         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2447         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
2448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2449         Initialize the Dashboard.Branch object
2450
2451 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
2452
2453         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
2454         https://bugs.webkit.org/show_bug.cgi?id=127141
2455
2456         Reviewed by Alexey Proskuryakov.
2457
2458         Make sure to reset the notification handler each time.
2459
2460         * DumpRenderTree/AccessibilityController.cpp:
2461         (AccessibilityController::resetToConsistentState):
2462         * DumpRenderTree/AccessibilityController.h:
2463         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2464         (AccessibilityController::platformResetToConsistentState):
2465         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2466         (AccessibilityController::platformResetToConsistentState):
2467         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2468         (AccessibilityController::~AccessibilityController):
2469         (AccessibilityController::platformResetToConsistentState):
2470         (AccessibilityController::removeNotificationListener):
2471         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2472         (AccessibilityController::platformResetToConsistentState):
2473
2474 2014-01-17  Alberto Garcia  <berto@igalia.com>
2475
2476         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
2477         https://bugs.webkit.org/show_bug.cgi?id=82329
2478
2479         Reviewed by Carlos Garcia Campos.
2480
2481         Unskip, this is working fine now.
2482
2483         * Scripts/run-gtk-tests:
2484         (TestRunner):
2485
2486 2014-01-17  Alberto Garcia  <berto@igalia.com>
2487
2488         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
2489         https://bugs.webkit.org/show_bug.cgi?id=82328
2490
2491         Reviewed by Carlos Garcia Campos.
2492
2493         This was caused by the icon database being corrupted in the
2494         Release bot. After removing it the test works fine so it can be
2495         run again.
2496
2497         * Scripts/run-gtk-tests:
2498         (TestRunner):
2499
2500 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
2501
2502         Test results popovers at http://build.webkit.org/dashboard should link to stderr
2503         https://bugs.webkit.org/show_bug.cgi?id=126929
2504
2505         Reviewed by Timothy Hatcher.
2506
2507         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2508         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
2509         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
2510
2511         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2512         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
2513
2514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2515         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
2516         Add a link to stderr output if present.
2517
2518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2519         (.test-results-popover .additional-link): Style with light grey (will use the same style
2520         for diff links).
2521
2522 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
2523
2524         Automate DoYouEvenBench
2525         https://bugs.webkit.org/show_bug.cgi?id=124497
2526
2527         Reviewed by Geoffrey Garen.
2528
2529         * Scripts/webkitpy/performance_tests/perftest.py:
2530         (PerfTestMetric.__init__): Added the aggregator name as an argument.
2531         (PerfTestMetric.aggregator): Added.
2532         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
2533         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
2534         should be parsed as the metric and the aggregator respectively.
2535         (PerfTest._run_with_driver): Pass in the aggregator name.
2536         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
2537         which generates subtests of subtests within a single test file.
2538
2539         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2540         (test_parse_output_with_subtests_and_total): Added.
2541
2542         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2543         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
2544
2545         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2546         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
2547
2548 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
2549
2550         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
2551         https://bugs.webkit.org/show_bug.cgi?id=127141
2552
2553         Reviewed by Alexey Proskuryakov.
2554
2555         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
2556
2557         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2558         (AccessibilityController::~AccessibilityController):
2559
2560 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
2561
2562         EWS shouldn't comment on Bugzilla for failing builds or style errors
2563         https://bugs.webkit.org/show_bug.cgi?id=127079
2564
2565         Reviewed by Anders Carlsson.
2566
2567         Since patch authors and reviewers could retrieve this information from bubbles,
2568         we shouldn't spam the Bugzilla with useless comments.
2569
2570         We still post style errors but not python paths we used since it's a pure noise.
2571
2572         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2573         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
2574         * Scripts/webkitpy/tool/commands/queues.py:
2575         (StyleQueue.review_patch):
2576
2577 2014-01-15  Roger Fong  <roger_fong@apple.com>
2578
2579         Add support for handling WebGL load policies.
2580         https://bugs.webkit.org/show_bug.cgi?id=126935
2581         <rdar://problem/15790448>.
2582
2583         Reviewed by Timothy Horton.
2584
2585         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
2586         (WTR::TestController::createWebViewWithOptions):
2587
2588 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2589
2590         Remove workaround for compilers not supporting explicit override control
2591         https://bugs.webkit.org/show_bug.cgi?id=127111
2592
2593         Reviewed by Anders Carlsson.
2594
2595         Now all compilers support explicit override control, this workaround can be removed.
2596
2597         * DumpRenderTree/gtk/fonts/fonts.conf:
2598         * Scripts/do-webcore-rename:
2599         Removed this rename operation from the list of contemplated future renames.
2600         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2601         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2602         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2603         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2604         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2605
2606 2014-01-16  Oliver Hunt  <oliver@apple.com>
2607
2608         Stop run-jsc from consuming stderr output
2609         https://bugs.webkit.org/show_bug.cgi?id=127115
2610
2611         Reviewed by Mark Lam.
2612
2613         Simple patch to make run-jsc easier to deal with
2614
2615         * Scripts/run-jsc:
2616
2617 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
2618
2619         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
2620         https://bugs.webkit.org/show_bug.cgi?id=126323
2621
2622         Reviewed by Csaba Osztrogonác.
2623
2624         * gtk/generate-feature-defines-files:
2625
2626 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2627
2628         [EFL][WK2] Implement TestController::setHidden
2629         https://bugs.webkit.org/show_bug.cgi?id=127036
2630
2631         Reviewed by Gyuyoung Kim.
2632
2633         WebKitTestRunner needs TestController::setHidden implementation to
2634         properly handle page visibility API layout tests after r161105.
2635
2636         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2637         (WTR::TestController::setHidden):
2638
2639 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
2640
2641         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
2642         https://bugs.webkit.org/show_bug.cgi?id=127083
2643
2644         Reviewed by Carlos Garcia Campos.
2645
2646         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
2647         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
2648
2649         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
2650         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
2651         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
2652         BrowserWindow object is being finalized, preventing the callback from firing.
2653
2654         * MiniBrowser/gtk/BrowserWindow.c:
2655         (resetEntryProgress):
2656         (webViewLoadProgressChanged):
2657         (browserWindowFinalize):
2658
2659 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
2660
2661         DumpRenderTree doesn't disable web preferences autosave
2662         https://bugs.webkit.org/show_bug.cgi?id=127062
2663
2664         Reviewed by Dan Bernstein.
2665
2666         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
2667         Do it.
2668
2669 2014-01-15  Dean Jackson  <dino@apple.com>
2670
2671         Improve filter-build-webkit, especially for iOS builds
2672         https://bugs.webkit.org/show_bug.cgi?id=81046
2673
2674         Reviewed by Joseph Pecoraro.
2675
2676         Lots of updates to the filtering rules, mostly from the
2677         iOS build output. Other highlights include:
2678         - ignoring escape sequences for color ouput
2679         - detecting escaped spaces in file name regexps
2680
2681         * Scripts/filter-build-webkit:
2682         (shouldIgnoreLine):
2683
2684 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2685
2686         [GTK] Web process sometimes crashes when printing in synchronous mode
2687         https://bugs.webkit.org/show_bug.cgi?id=126979
2688
2689         Reviewed by Gustavo Noronha Silva.
2690
2691         * Scripts/run-gtk-tests:
2692         (TestRunner): Unskip
2693         /webkit2/WebKitPrintOperation/close-after-print.
2694
2695 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
2696
2697         [EFL] Change test font installed path to webkitgtk-font-tests
2698         https://bugs.webkit.org/show_bug.cgi?id=126723
2699
2700         Reviewed by Gyuyoung Kim.
2701
2702         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
2703         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
2704         hard-coded in FontManagement.cpp#105
2705
2706         * DumpRenderTree/PlatformEfl.cmake:
2707         * WebKitTestRunner/PlatformEfl.cmake:
2708         * efl/jhbuild.modules:
2709
2710 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
2711
2712         Make DoYouEvenBench runnable by run-perf-tests
2713         https://bugs.webkit.org/show_bug.cgi?id=127030
2714
2715         Reviewed by Andreas Kling.
2716
2717         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
2718         ":Total" to appear at the end of a test name. We don't do anything with it for now.
2719
2720         * Scripts/webkitpy/performance_tests/perftest.py:
2721         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
2722         to the JSON in a follow up patch for the perf dashboard.
2723         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
2724
2725 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2726
2727         [GTK] UI process crashes when the web process crashes while printing
2728         https://bugs.webkit.org/show_bug.cgi?id=126977
2729
2730         Reviewed by Gustavo Noronha Silva.
2731
2732         Add new test case to check that closing the window right after
2733         printing works. It's skipped for now, because this patch only
2734         fixes the UI process crash, but not the web process one.
2735
2736         * Scripts/run-gtk-tests:
2737         (TestRunner): Skip
2738         /webkit2/WebKitPrintOperation/close-after-print.
2739         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2740         (testPrintOperationPrintPrinter):
2741         (findPrintToFilePrinter):
2742         (testPrintOperationPrint):
2743         (testPrintOperationErrors):
2744         (testPrintOperationCloseAfterPrint):
2745         (beforeAll):
2746
2747 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
2748
2749         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
2750         https://bugs.webkit.org/show_bug.cgi?id=127002
2751
2752         Reviewed by David Kilzer.
2753
2754         * Scripts/webkitdirs.pm:
2755         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
2756
2757 2014-01-14  Commit Queue  <commit-queue@webkit.org>
2758
2759         Unreviewed, rolling out r162000.
2760         http://trac.webkit.org/changeset/162000
2761         https://bugs.webkit.org/show_bug.cgi?id=127009
2762
2763         API versioning is wrong (Requested by rfong on #webkit).
2764
2765         * MiniBrowser/mac/WK2BrowserWindowController.m:
2766         (-[WK2BrowserWindowController awakeFromNib]):
2767         * WebKitTestRunner/TestController.cpp:
2768         (WTR::TestController::createOtherPage):
2769         (WTR::TestController::createWebViewWithOptions):
2770
2771 2014-01-13  Roger Fong  <roger_fong@apple.com>
2772
2773         Add support for handling WebGL load policies.
2774         https://bugs.webkit.org/show_bug.cgi?id=126935
2775         <rdar://problem/15790448>.
2776
2777         Reviewed by Brent Fulgham.
2778
2779         * MiniBrowser/mac/WK2BrowserWindowController.m:
2780         (-[WK2BrowserWindowController awakeFromNib]):
2781         * WebKitTestRunner/TestController.cpp:
2782         (WTR::TestController::createWebViewWithOptions):
2783
2784 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
2785
2786         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
2787         https://bugs.webkit.org/show_bug.cgi?id=120110
2788
2789         Reviewed by Martin Robinson.
2790
2791         Skip the FontConfig settings initialization in WebKitTestRunner if the
2792         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
2793         This is useful when profiling the WebKitTestRunner execution, where at the startup
2794         this step takes considerable amount of time and disturbs the profiling output.
2795
2796         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2797         (WTR::initializeFontConfigSetting):
2798
2799 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
2800
2801         Add ENABLE(WEB_REPLAY) feature flag to the build system
2802         https://bugs.webkit.org/show_bug.cgi?id=126949
2803
2804         Reviewed by Joseph Pecoraro.
2805
2806         * Scripts/webkitperl/FeatureList.pm:
2807
2808 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
2809
2810         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
2811         https://bugs.webkit.org/show_bug.cgi?id=126702
2812
2813         Reviewed by Alexey Proskuryakov.
2814
2815         Resolve regression and remove a FIXME comment that is already fixed.
2816
2817         * Scripts/webkitpy/common/system/filesystem.py:
2818         (FileSystem.open_text_file_for_reading):
2819         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2820         (RealFileSystemTest.test_read_and_write_file):
2821         * Scripts/webkitpy/style/filereader.py:
2822         (TextFileReader._read_lines):
2823         * Scripts/webkitpy/style/filereader_unittest.py:
2824         (TextFileReaderTest.test_count_delete_only_file):
2825         (TextFileReaderTest):
2826         (TextFileReaderTest.test_process_malformed_file):
2827
2828 2014-01-02  Brian Holt  <brian.holt@samsung.com>
2829
2830         [GTK] Parse Valgrind xml leak files
2831         https://bugs.webkit.org/show_bug.cgi?id=119446
2832
2833         Reviewed by Alejandro G. Castro.
2834
2835         Parse the xml files generated by Valgrind to yield useful
2836         information about the memory leaks.
2837
2838         * Scripts/webkitpy/port/gtk.py:
2839         (GtkPort.__init__):
2840         (GtkPort.setup_test_run): Clear the previous output files before new
2841         run.
2842         (GtkPort.print_leaks_summary):
2843
2844         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2845         Parse the xml files generated by Valgrind and summarise leaks
2846         into an easily understandable list.
2847         (get_text_of):
2848         (get_CDATA_of):
2849         (gather_frames):
2850         (ValgrindError):
2851         (ValgrindError.__init__):
2852         (ValgrindError.__str__):
2853         (ValgrindError.unique_string):
2854         (ValgrindError.error_hash):
2855         (ValgrindError.__hash__):
2856         (ValgrindError.__eq__):
2857         (LeakDetectorValgrind):
2858         (LeakDetectorValgrind.__init__):
2859         (LeakDetectorValgrind._parse_leaks_output):
2860         (LeakDetectorValgrind.leaks_files_in_results_directory):
2861         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2862         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2863
2864         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2865         (make_mock_valgrind_output):
2866         (make_mock_incomplete_valgrind_output):
2867         (make_mock_valgrind_results):
2868         (make_mock_valgrind_results_incomplete):
2869         (make_mock_valgrind_results_empty):
2870         (make_mock_valgrind_results_misformatted):
2871         (mock_run_cppfilt_command):
2872         (LeakDetectorValgrindTest):
2873         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2874         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2875         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2876         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2877         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2878         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2879         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2880         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2881
2882 2014-01-13  Lucas Forschler  <lforschler@apple.com>
2883
2884         Update the LLINT CLoop Bot build infrastructure
2885         https://bugs.webkit.org/show_bug.cgi?id=126604
2886         
2887         Unreviewed.
2888         
2889         * BuildSlaveSupport/build.webkit.org-config/config.json:
2890         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2891         (CompileLLINTCLoop):
2892         (RunLLINTCLoopTests):
2893         (BuildAndTestLLINTCLoopFactory):
2894         (BuildAndTestLLINTCLoopFactory.__init__):
2895
2896 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
2897
2898         [EFL][WK2] Disable failing API tests
2899         https://bugs.webkit.org/show_bug.cgi?id=126960
2900
2901         Reviewed by Gyuyoung Kim.
2902
2903         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
2904
2905         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2906         (TestWebKitAPI::TEST):
2907
2908 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
2909
2910         Remove wdiff
2911         https://bugs.webkit.org/show_bug.cgi?id=124766
2912
2913         Reviewed by Ryosuke Niwa.
2914
2915         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2916         (ResultsJSONParserTest):
2917         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2918         (TestResultWriter):
2919         (TestResultWriter.create_text_diff_and_write_result):
2920         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2921         (summarize_results):
2922         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2923         (RunTest.test_output_diffs):
2924         * Scripts/webkitpy/port/base.py:
2925         (Port.__init__):
2926         (Port.driver_stop_timeout):
2927         (Port.check_image_diff):
2928         (Port.repository_paths):
2929         (Port._path_to_lighttpd_php):
2930         * Scripts/webkitpy/port/base_unittest.py:
2931         (PortTest.test_default_child_processes):
2932         (PortTest.test_pretty_patch_script_error):
2933         * Scripts/webkitpy/port/port_testcase.py:
2934         (PortTestCase.test_diff_image_crashed):
2935         * Scripts/webkitpy/port/test.py:
2936         (TestPort.operating_system):
2937
2938 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
2939
2940         Build fix for the GTK+ CMake port
2941
2942         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
2943
2944 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2945
2946         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
2947         https://bugs.webkit.org/show_bug.cgi?id=126881
2948
2949         Reviewed by Carlos Garcia Campos.
2950
2951         * MiniBrowser/gtk/BrowserWindow.c:
2952         (browser_window_new):
2953         Explicitly cast GtkWindow** to gpointer* in call to
2954         g_object_add_weak_pointer to avoid compiler warnings.
2955
2956 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2957
2958         Remove parsing of old-run-webkit-tests output from master.cfg
2959         https://bugs.webkit.org/show_bug.cgi?id=126690
2960
2961         Reviewed by Csaba Osztrogonác.
2962
2963         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2964         Removed parsing of ORWT output, as it is not used anymore.
2965         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2966         Updated unit tests accordingly.
2967
2968 2014-01-13  Commit Queue  <commit-queue@webkit.org>
2969
2970         Unreviewed, rolling out r161808.
2971         http://trac.webkit.org/changeset/161808
2972         https://bugs.webkit.org/show_bug.cgi?id=126874
2973
2974         This patch make several files to be always regenerated on
2975         every make (Requested by KaL on #webkit).
2976
2977         * WebKitTestRunner/GNUmakefile.am:
2978
2979 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2980
2981         [GTK] Make MiniBrowser windows non-transient by default
2982         https://bugs.webkit.org/show_bug.cgi?id=126840
2983
2984         Reviewed by Carlos Garcia Campos.
2985
2986         Instead of making new browser windows transient as soon as they are
2987         created, save the pointer to the parent window and set the transient
2988         state later on when handling the "run-as-modal" signal. This makes
2989         it easier to use the MiniBrowser to do tests involving multiple
2990         windows, and will be useful as well when multi-web-process mode is
2991         enabled for the GTK port.
2992
2993         * MiniBrowser/gtk/BrowserWindow.c:
2994         (webViewRunAsModal): Set the parent window using
2995         gtk_window_set_transient_for() using the saved parent
2996         window.
2997         (browser_window_new): Save the parent window using
2998         g_object_set_data() instead of making the new window
2999         transient immediately.
3000
3001 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
3002
3003         [EFL][WK2] Make API tests work again
3004         https://bugs.webkit.org/show_bug.cgi?id=126769
3005
3006         Reviewed by Gyuyoung Kim.
3007
3008         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
3009         [E]WebKit2, respectively, and this causes problems because the logic to find
3010         where WebProcess is to look in the same directory of the running process and
3011         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
3012
3013         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
3014         Gtk port, which allows us to look for WebProcess initially in this directory,
3015         if it's defined.
3016
3017         * TestWebKitAPI/efl/main.cpp:
3018         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
3019
3020 2014-01-12  Daniel Bates  <dabates@apple.com>
3021
3022         [iOS] Fix the build
3023
3024         For now, ensure we build WebKit System Interface before we build WebKit.
3025         We'll remove this constraint and the constraint to build WebKit Additions
3026         in a subsequent commit.
3027
3028         * Scripts/build-webkit:
3029
3030 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3031
3032         Unreviewed. Fix make distcheck.
3033
3034         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
3035         to EXTRA_DIST.
3036
3037 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
3038
3039         --disable-dependency-tracking causes build failure due to missing directories
3040         https://bugs.webkit.org/show_bug.cgi?id=94488
3041
3042         Reviewed by Gustavo Noronha Silva.
3043
3044         Autotools build fix: Ensure output directory existing
3045         before generating DerivedSources. This allows for
3046         --disable-dependency-tracking to be run.
3047
3048
3049         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
3050
3051 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3052
3053         [GTK] Fix return value of WebKitDownload::created-destination
3054         https://bugs.webkit.org/show_bug.cgi?id=126741
3055
3056         Reviewed by Martin Robinson.
3057
3058         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
3059         value of several callbacks.
3060
3061 2014-01-11  Sam Weinig  <sam@webkit.org>
3062
3063         Add support for null StringViews
3064         https://bugs.webkit.org/show_bug.cgi?id=126827
3065
3066         Reviewed by Anders Carlsson.
3067
3068         Add new test for StringView.
3069
3070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3071         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
3072         (TestWebKitAPI::TEST):
3073
3074 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
3075
3076         Remove the BlackBerry port from trunk
3077         https://bugs.webkit.org/show_bug.cgi?id=126715
3078
3079         Reviewed by Anders Carlsson.
3080
3081         * DumpRenderTree/DumpRenderTree.h:
3082         * DumpRenderTree/PixelDumpSupport.cpp:
3083
3084 2014-01-10  Daniel Bates  <dabates@apple.com>
3085
3086         [iOS] Fix project build order
3087
3088         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
3089         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
3090         time of writing.
3091
3092         * Scripts/build-webkit:
3093
3094 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
3095
3096         Move platformName property from testRunner to accessibilityController
3097         https://bugs.webkit.org/show_bug.cgi?id=126689
3098
3099         Reviewed by Chris Fleizach.
3100
3101         Move the platformName property from the testRunner into
3102         accessibilityController, since this is a concept that has only be
3103         used by accessibility tests since it got added, and also because
3104         the real intention was not to distinguish among "ports" (mac, win,
3105         gtk, efl) but between platforms (atk, mac, win).
3106
3107         This change will be very useful to merge GTK's roles-exposed.html
3108         and Mac's role-subrole-roledescription.html into one single test,
3109         since we will be specifying in the test itself which elements are
3110         supported in which accessibility "platform". In this context,
3111         being able to check accessibilityController.platformName directly
3112         against a list of supported accessibility platforms (e.g. "atk,mac")
3113         will certainly maintain the code cleaner and simpler.
3114
3115         * DumpRenderTree/TestRunner.h:
3116         (TestRunner::platformName): Removed.
3117         * DumpRenderTree/TestRunner.cpp:
3118         (getPlatformNameCallback): Removed.
3119         (TestRunner::staticValues): Removed platformName
3120         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3121         (TestRunner::platformName): Removed.
3122         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3123         (TestRunner::platformName): Removed.
3124         * DumpRenderTree/mac/TestRunnerMac.mm:
3125         (TestRunner::platformName): Removed.
3126         * DumpRenderTree/win/TestRunnerWin.cpp:
3127         (TestRunner::platformName): Removed.
3128
3129         * DumpRenderTree/AccessibilityController.h:
3130         (AccessibilityController::platformName): Added.
3131         * DumpRenderTree/AccessibilityController.cpp:
3132         (getPlatformNameCallback): Added.
3133         (AccessibilityController::getJSClass): Added platformName.
3134         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3135         (AccessibilityController::platformName): Added, returning "atk".
3136         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3137         (AccessibilityController::platformName): Ditto, returning "mac".
3138         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3139         (AccessibilityController::platformName): Ditto, returning "ios".
3140         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3141         (AccessibilityController::platformName): Ditto, returning "win".
3142
3143         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3144         (platformName): Removed.
3145         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3146         (TestRunner::platformName): Removed.
3147         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3148         (TestRunner::platformName): Removed.
3149         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3150         (TestRunner::platformName): Removed.
3151         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3152         (TestRunner::platformName): Removed.
3153         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
3154         (TestRunner::platformName): Removed.
3155
3156         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3157         (WTR:AccessibilityController::platformName): Added.
3158         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3159         (platformName): Added.
3160         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3161         (WTR::AccessibilityController::platformName): Added, returning "atk".
3162         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3163         (WTR::AccessibilityController::platformName): Added, returning "mac".
3164
3165 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
3166
3167         Remove the BlackBerry port from trunk
3168         https://bugs.webkit.org/show_bug.cgi?id=126715
3169
3170         Reviewed by Anders Carlsson.
3171
3172         * Scripts/webkitpy/common/config/watchlist:
3173
3174 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
3175
3176         Remove the BlackBerry files outside WebCore
3177         https://bugs.webkit.org/show_bug.cgi?id=126715
3178
3179         Reviewed by Anders Carlsson.
3180
3181         * DumpRenderTree/blackberry: Removed.
3182
3183 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
3184
3185         Remove knowledge of Blackberry from build scripts
3186         https://bugs.webkit.org/show_bug.cgi?id=126766
3187
3188         Reviewed by Anders Carlsson.
3189         
3190         Remove isBlackBerry() and references to it, and rmeove
3191         blackberry-related stuff from the watchlist.
3192
3193         * Scripts/build-webkit:
3194         * Scripts/webkit-build-directory:
3195         * Scripts/webkitdirs.pm:
3196         (determineBaseProductDir):
3197         (argumentsForConfiguration):
3198         (builtDylibPathForName):
3199         (isAppleWebKit):
3200         (buildCMakeProjectOrExit):
3201         (cmakeBasedPortArguments):
3202         (cmakeBasedPortName):
3203         * Scripts/webkitperl/FeatureList.pm:
3204         * Scripts/webkitpy/common/config/watchlist:
3205
3206 2014-01-10  Daniel Bates  <dabates@apple.com>
3207
3208         [iOS] Fix up simulator build and enable default features
3209
3210         Rubber-stamped by Joseph Pecoraro.
3211
3212         * Scripts/webkitdirs.pm:
3213         (determineArchitecture):
3214         (determinePassedArchitecture):
3215         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
3216         by default only in iOS).
3217
3218 2014-01-10  Daniel Bates  <dabates@apple.com>
3219
3220         [iOS] Upstream WebCore and Tools miscellaneous changes
3221         https://bugs.webkit.org/show_bug.cgi?id=126698
3222
3223         Reviewed by David Kilzer.
3224
3225         * Scripts/check-for-inappropriate-objc-class-names:
3226         * Scripts/check-for-webkit-framework-include-consistency:
3227
3228 2014-01-09  Dan Bernstein  <mitz@apple.com>
3229
3230         [Cocoa] Promote WKBackForwardList{,Item}.h to public
3231         https://bugs.webkit.org/show_bug.cgi?id=126707
3232
3233         Reviewed by Sam Weinig.
3234
3235         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
3236         left behind in the build products directory after a private header is made public.
3237
3238 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3239
3240         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
3241         https://bugs.webkit.org/show_bug.cgi?id=126686
3242
3243         Reviewed by Martin Robinson.
3244
3245         Test that partial files are not left on disk after a download has
3246         been cancelled after the destination has been decided. To make
3247         sure the download is cancelled after the destination has been
3248         decided and before the operation finishes, we cancel the download
3249         in the destination decided callback, and we use an infinite
3250         resource that writes chunks to the response body and never
3251         completes the body.
3252
3253         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3254         (addContentDispositionHTTPHeaderToResponse): Helper function to
3255         add the Content-Disposition to the response headers.
3256         (writeNextChunkIdle): Write next chunk to response body.
3257         (writeNextChunk): Write next chunk in an idle to avoid flooding
3258         the network with the inifnite resource.
3259         (serverCallback): Add an inifinite resource.
3260         (testDownloadRemoteFileError): Check that partial file is not
3261         present after the download has been cancelled.
3262
3263 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
3264
3265         Move myself to the committers list.
3266
3267         Unreviewed.
3268
3269         * Scripts/webkitpy/common/config/contributors.json:
3270
3271 2014-01-08  Seokju Kwon  <seokju@webkit.org>
3272
3273         [GTK] Unreviewed build fix after r161522.
3274
3275         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
3276
3277 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3278
3279         Missleading style error when mixing system and non-system header include lines.
3280         https://bugs.webkit.org/show_bug.cgi?id=126564
3281
3282         Reviewed by Ryosuke Niwa.
3283
3284         * Scripts/webkitpy/style/checkers/cpp.py:
3285         (check_include_line):
3286         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3287         (OrderOfIncludesTest.test_check_alphabetical_include_order):
3288         (OrderOfIncludesTest.test_public_primary_header):
3289
3290 2014-01-08  Seokju Kwon  <seokju@webkit.org>
3291
3292         [EFL] Unreviewed build fix after r161522.
3293
3294         * TestWebKitAPI/CMakeLists.txt:
3295         * TestWebKitAPI/PlatformEfl.cmake:
3296
3297 2014-01-08  Anders Carlsson  <andersca@apple.com>
3298
3299         Remove WKConnectionRef tests
3300         https://bugs.webkit.org/show_bug.cgi?id=126666
3301
3302         Reviewed by Dan Bernstein.
3303
3304         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
3305         Remove the API tests as a first step towards killing the entire thing.
3306
3307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3308         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
3309         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
3310
3311 2014-01-08  Commit Queue  <commit-queue@webkit.org>
3312
3313         Unreviewed, rolling out r161512.
3314         http://trac.webkit.org/changeset/161512
3315         https://bugs.webkit.org/show_bug.cgi?id=126655
3316
3317         Broke webkitpy tests (Requested by ap on #webkit).
3318
3319         * Scripts/webkitpy/port/gtk.py:
3320         (GtkPort.__init__):
3321         (GtkPort.setup_test_run):
3322         (GtkPort._port_specific_expectations_files):
3323         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
3324         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
3325
3326 2014-01-08  Commit Queue  <commit-queue@webkit.org>
3327
3328         Unreviewed, rolling out r161517.
3329         http://trac.webkit.org/changeset/161517
3330         https://bugs.webkit.org/show_bug.cgi?id=126659
3331
3332         The fix didn't completely remove the problem and is now
3333         standing in the way of the rollout of the offending patch
3334         (Requested by zdobersek on #webkit).
3335
3336         * Scripts/webkitpy/port/gtk.py:
3337         (GtkPort.__init__):
3338
3339 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
3340
3341         Unreviewed. Attempting to fix webkitpy tests after r161512.
3342
3343         * Scripts/webkitpy/port/gtk.py:
3344         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
3345
3346 2014-01-08  Brian Holt  <brian.holt@samsung.com>
3347
3348         [GTK] Parse Valgrind xml leak files
3349         https://bugs.webkit.org/show_bug.cgi?id=119446
3350
3351         Reviewed by Alejandro G. Castro.
3352
3353         Parse the xml files generated by Valgrind to yield useful
3354         information about the memory leaks.
3355
3356         * Scripts/webkitpy/port/gtk.py:
3357         (GtkPort.__init__):
3358         (GtkPort.setup_test_run): Clear the previous output files before new
3359         run.
3360         (GtkPort.print_leaks_summary):
3361
3362         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
3363         Parse the xml files generated by Valgrind and summarise leaks
3364         into an easily understandable list.
3365         (get_text_of):
3366         (get_CDATA_of):
3367         (gather_frames):
3368         (ValgrindError):
3369         (ValgrindError.__init__):
3370         (ValgrindError.__str__):
3371         (ValgrindError.unique_string):
3372         (ValgrindError.error_hash):
3373         (ValgrindError.__hash__):
3374         (ValgrindError.__eq__):
3375         (LeakDetectorValgrind):
3376         (LeakDetectorValgrind.__init__):
3377         (LeakDetectorValgrind._parse_leaks_output):
3378         (LeakDetectorValgrind.leaks_files_in_results_directory):
3379         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
3380         (LeakDetectorValgrind.parse_and_print_leaks_detail):
3381
3382         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
3383         (make_mock_valgrind_output):
3384         (make_mock_incomplete_valgrind_output):
3385         (make_mock_valgrind_results):
3386         (make_mock_valgrind_results_incomplete):
3387         (make_mock_valgrind_results_empty):
3388         (make_mock_valgrind_results_misformatted):
3389         (LeakDetectorValgrindTest):
3390         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
3391         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
3392         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
3393         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
3394         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
3395         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
3396         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
3397         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
3398
3399 2014-01-08  Commit Queue  <commit-queue@webkit.org>
3400
3401         Unreviewed, rolling out r161427.
3402         http://trac.webkit.org/changeset/161427
3403         https://bugs.webkit.org/show_bug.cgi?id=126645
3404
3405         Emits a stye error on any newly added files (Requested by ap
3406         on #webkit).
3407
3408         * Scripts/webkitpy/style/checkers/cpp.py:
3409         (check_style):
3410         (CppChecker):
3411         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3412         (WebKitStyleTest.test_other):
3413
3414 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3415
3416         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
3417         https://bugs.webkit.org/show_bug.cgi?id=126580
3418
3419         Reviewed by Csaba Osztrogonác.
3420
3421         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3422         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
3423         run-webkit-tests script.
3424         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
3425         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
3426
3427 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3428
3429         Update the list of non-committer u-szeged contributors
3430         https://bugs.webkit.org/show_bug.cgi?id=126640
3431
3432         Reviewed by Csaba Osztrogonác.
3433
3434         * Scripts/webkitpy/common/config/contributors.json:
3435
3436 2014-01-08  Alberto Garcia  <berto@igalia.com>
3437
3438         Fix some compilation warnings
3439         https://bugs.webkit.org/show_bug.cgi?id=126635
3440
3441         Reviewed by Csaba Osztrogonác.
3442
3443         * GtkLauncher/main.c:
3444         (createWindow): This function is not supposed to receive any
3445         parameter, yet we are passing one.
3446
3447 2014-01-08  Brian Holt  <brian.holt@samsung.com>
3448
3449         [GTK][WK2] unskip passing unit tests
3450         https://bugs.webkit.org/show_bug.cgi?id=126637
3451
3452         Reviewed by Carlos Garcia Campos.
3453
3454         Unskip TestResources and TestAuthentication unit tests since they
3455         are passing both under Xvfb and X.
3456
3457         * Scripts/run-gtk-tests:
3458         (TestRunner):
3459
3460 2014-01-08  Alberto Garcia  <berto@igalia.com>
3461
3462         REGRESSION(r160304): [GTK] Disable libtool fast install
3463         https://bugs.webkit.org/show_bug.cgi?id=126381
3464
3465         Reviewed by Gustavo Noronha Silva.
3466
3467         Disable the libtool fast-install mode in developer/test builds.
3468
3469         In this mode binaries are generated ready to be used directly from
3470         the build tree. Otherwise they would need to be relinked when they
3471         are executed, which can take a lot of resources, particularly in
3472         debug builds.
3473
3474         * Scripts/webkitdirs.pm:
3475         (runAutogenForAutotoolsProjectIfNecessary):
3476
3477 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
3478
3479         Unreviewed GTK gardening.
3480
3481         * Scripts/run-gtk-tests:
3482         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
3483         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
3484
3485 2014-01-07  Lucas Forschler  <lforschler@apple.com>
3486
3487         Add buildbot infrasctructure for building and testing JSC cloop
3488         https://bugs.webkit.org/show_bug.cgi?id=126604
3489
3490         Reviewed by Geoffrey Garen.
3491
3492         * BuildSlaveSupport/build.webkit.org-config/config.json:
3493         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3494         (CompileCLOOP):
3495         (RunCLOOPTests):
3496         (RunCLOOPTests.countFailures):
3497         (BuildAndTestCLOOP):
3498
3499 2014-01-07  Brian Burg  <bburg@apple.com>
3500
3501         Unreviewed. Add myself as a committer.
3502
3503         * Scripts/webkitpy/common/config/contributors.json:
3504
3505 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3506
3507         Popovers at build.webkit.org/dashboard could have titles
3508         https://bugs.webkit.org/show_bug.cgi?id=126495
3509
3510         Reviewed by Timothy Hatcher.
3511
3512         Added titles to all popovers except for pending revisions one, which I would like
3513         to improve more (probably add an ETA).
3514
3515         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3516         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
3517         adding a title to base class.
3518
3519         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3520         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
3521         a divider to a separate function.
3522         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
3523         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
3524         title from above function.
3525         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
3526         variable to "content" to match all other code.
3527         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
3528         (BuildbotQueueView.prototype._addDividerToPopover): Added.
3529
3530         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3531         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
3532         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
3533         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
3534
3535         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3536
3537 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3538
3539         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
3540         https://bugs.webkit.org/show_bug.cgi?id=126472
3541
3542         Reviewed by Timothy Hatcher.
3543
3544         Added a delay when quickly switching to a different popover, making it easier to
3545         move mouse pointer from active element to its popover without accidentally opening
3546         a different popover.
3547
3548         Used this code to add a delay before creating a popover. This doesn't change UI
3549         behavior, as there was alerady a delay before it became visible, but it avoids
3550         flooding buildbot server with http requests when quickly moving the mouse over
3551         dashboard page.
3552
3553         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
3554         Fixed a case where popover could get stuck. If content was updated while fade-out
3555         transition was already in place, the transition was removed for no good reason.
3556
3557         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3558         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
3559
3560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
3561         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
3562         popover delay from 1s to 800ms.
3563
3564 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3565
3566         Improve display of failed builds at build.webkit.org/dashboard
3567         https://bugs.webkit.org/show_bug.cgi?id=126542
3568         <rdar://problem/15753550>
3569
3570         Reviewed by Timothy Hatcher.
3571
3572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3573         Instead of hardcoding step name, look for the first step that failed.
3574         While at it, added a popover with more links. There are multiple, and it's good
3575         to have a choice of which one to look at in each situation.
3576
3577         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3578         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
3579         of having failed. Many iterations are interrupted for whatever reason internal to
3580         Buildbot, and these are suppoed to be orange, not red.
3581         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
3582         not only WillRetry ones.
3583         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
3584         actually failed, more likely indicating a problem with code base.
3585         (BuildbotIteration.prototype.get firstFailedStepName):
3586         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
3587         (BuildbotIteration.prototype.get failureLogs): Ditto.
3588         (BuildbotIteration.prototype.update): Store complete results for the failed step.
3589         Not every failure stops the iteration, so we could have multiple failed steps,
3590         but let's see if seeing just the first one will be enough.
3591
3592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3593         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
3594         terms of successful iterations.
3595         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
3596
3597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3598         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
3599         terms of successful iterations.
3600
3601         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3602         Removed code to create a path to build output, we now take it from results JSON.
3603
3604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3605         Added styles for the new popover.
3606
3607 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>