c3f700f1fb736b566a00ee2b686b9da2b58073b7
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-19  Ojan Vafai  <ojan@chromium.org>
2
3         We should only add a live event listener once, not once per TestSelector.
4         Adding one per TestSelector would cause accordion('option', 'active') to
5         incorrectly be "false" if you examine multiple sets of tests.
6
7         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
8
9 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
10
11         Fix typo introduced in r111293.
12
13         Unreviewed, build fix.
14
15         * Scripts/webkitpy/layout_tests/port/webkit.py:
16         (WebKitDriver._check_for_driver_crash):
17
18 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
19
20         webkitpy: get ServerProcess out of the reportcrash business
21         https://bugs.webkit.org/show_bug.cgi?id=81600
22
23         Reviewed by Adam Barth.
24
25         ServerProcess was half-aware that ReportCrash might run
26         sometimes, and that the process ServerProcess was talking to
27         might have its own crashing subprocesses; neither of these
28         things really worked right and it made the logic convoluted, so
29         this change makes handling crashes completely separate from the
30         server_process code, so that it can focus on just I/O to the
31         subprocess.
32
33         There should be no functional changes resulting from this patch.
34
35         * Scripts/webkitpy/layout_tests/port/server_process.py:
36         (ServerProcess._reset):
37         (ServerProcess._handle_possible_interrupt):
38         (ServerProcess.write):
39         (ServerProcess.read_stdout):
40         (ServerProcess.has_crashed):
41         (ServerProcess._read):
42         (ServerProcess.stop):
43         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
44         (TrivialMockPort.check_for_leaks):
45         (TestServerProcess.test_broken_pipe):
46         * Scripts/webkitpy/layout_tests/port/webkit.py:
47         (WebKitPort._read_image_diff):
48         (WebKitDriver.has_crashed):
49         (WebKitDriver._check_for_driver_crash):
50         (WebKitDriver.run_test):
51         (WebKitDriver._read_block):
52         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
53         (MockServerProcess.__init__):
54         (MockServerProcess):
55         (MockServerProcess.has_crashed):
56
57 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
58
59         webkitpy: crashlog parsing is broken
60         https://bugs.webkit.org/show_bug.cgi?id=81586
61
62         Reviewed by Adam Barth.
63
64         Seeking on a file opened through codecs() appears to not work
65         correctly (at least on SL).
66         
67         The code was more complicated than it needed to be, so I have
68         revamped it to just read a full crashlog at once and then look
69         for matches. 
70         
71         I have also added the ability to optionally propagate
72         errors back (which can be helpful to debug races when ReportCrash is
73         still running and you need to see that you couldn't open some
74         files, rather than just ignoring them).
75
76         * Scripts/webkitpy/common/system/crashlogs.py:
77         (CrashLogs.find_newest_log):
78         (CrashLogs._find_newest_log_darwin):
79         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
80         (CrashLogsTest.test_find_log_darwin):
81
82 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
83
84         webkitpy: clean up some port._filesystem references to not reference private members
85         https://bugs.webkit.org/show_bug.cgi?id=81595
86
87         Reviewed by Eric Seidel.
88
89         There should be no functional changes in this patch, just some
90         refactoring. Also, fixes a minor nit in write_image_diff_files(()
91
92         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
93         (SingleTestRunner.__init__):
94         (SingleTestRunner._run_compare_test):
95         (SingleTestRunner._run_rebaseline):
96         (SingleTestRunner._save_baseline_data):
97         (SingleTestRunner._handle_error):
98         (SingleTestRunner._run_reftest):
99         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
100         (write_test_result):
101         (TestResultWriter.__init__):
102         (TestResultWriter._make_output_directory):
103         (TestResultWriter.output_filename):
104         (TestResultWriter._output_testname):
105         (TestResultWriter.write_output_files):
106         (TestResultWriter.write_stderr):
107         (TestResultWriter.write_crash_report):
108         (TestResultWriter.create_text_diff_and_write_result):
109         (TestResultWriter.write_image_diff_files):
110         (copy_file):
111         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
112         (TestResultWriterTest.test_reftest_diff_image):
113
114 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
115
116         webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
117         https://bugs.webkit.org/show_bug.cgi?id=81598
118
119         Reviewed by Eric Seidel.
120
121         "DumpRenderTree" shouldn't be hard-coded here, since some other
122         process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
123         
124         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
125         (TestExpectations):
126
127 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
128
129         webkitpy: allow instance data in TestFailure objects
130         https://bugs.webkit.org/show_bug.cgi?id=81580
131
132         Reviewed by Tony Chang.
133
134         Current TestFailures are basically enums, but it would be nice,
135         especially for crashes, if they contained the name and pid of
136         the process that crashed.
137
138         * Scripts/webkitpy/layout_tests/models/test_failures.py:
139         (TestFailure.message):
140         (FailureTimeout.message):
141         (FailureCrash):
142         (FailureCrash.__init__):
143         (FailureCrash.message):
144         (FailureMissingResult.message):
145         (FailureTextMismatch.message):
146         (FailureMissingImageHash.message):
147         (FailureMissingImage.message):
148         (FailureImageHashMismatch.message):
149         (FailureImageHashIncorrect.message):
150         (FailureReftestMismatch.message):
151         (FailureReftestMismatchDidNotOccur.message):
152         (FailureReftestNoImagesGenerated.message):
153         (FailureMissingAudio.message):
154         (FailureAudioMismatch.message):
155         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
156         (TestFailuresTest.test_equals):
157         (TestFailuresTest):
158         (TestFailuresTest.test_crashes):
159
160 2012-03-19  Brady Eidson  <beidson@apple.com>
161
162         <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
163         Crash in 3rd party WebKit apps under XHR/Cache code
164
165         Reviewed by Antti Koivisto.
166
167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
168         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
169         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
170         (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
171         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
172         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
173         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
174         (TestWebKitAPI):
175         (TestWebKitAPI::TEST):
176
177 2012-03-19  Brady Eidson  <beidson@apple.com>
178
179         <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
180         REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
181
182         Reviewed by Enrica Casucci.
183
184         Bring up a context menu on a link, copy the link, then verify the pasteboard contents
185         are in the correct format.
186
187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
188         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
189         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
190         (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
191         (TestWebKitAPI::contextMenuCopyLink):
192         (TestWebKitAPI::TEST):
193
194 2012-03-19  Ojan Vafai  <ojan@chromium.org>
195
196         Make the selected item in the accordion a link to the flakiness dashboard
197         https://bugs.webkit.org/show_bug.cgi?id=81571
198
199         Reviewed by Dimitri Glazkov.
200
201         Also, make it so that you can select the text of the link, instead of the current behavior
202         of acting as if you had clicked on the accordion header.
203
204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
205         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
206
207 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
208
209         NRWT runs some tests that are skipped with -i command line option
210         https://bugs.webkit.org/show_bug.cgi?id=81535
211
212         Reviewed by Ojan Vafai.
213
214         This change modifies the interaction of Skipped files and
215         test_expectations files so that entries in Skipped files (and
216         the -i command line) override *everything* in the expectations
217         file.
218
219         Specifically, a directory in a Skipped file will cause all of
220         the tests in the dir to be skipped even if individual tests in
221         the dir are listed in the test_expectations.txt.
222
223         Skipped files also override anything in an overrides files.
224
225         This seems to make more intuitive sense, since if you list
226         something in the Skips file (and even more specify it on the
227         command line) you probably want it to be universally applied.
228
229         Theoretically we could add more precedence levels and have full
230         paths in an expectations file override dirs in a Skipped file
231         (but not the command line), but I don't know yet that that level
232         of complexity is justified.
233         
234         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
235         (TestExpectations.__init__):
236         (TestExpectations._add_skipped_tests):
237         (TestExpectations._add_test):
238         (TestExpectations._add_expectations):
239         (TestExpectations._add_expectation_line):
240         (TestExpectations._already_seen_better_match):
241         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
242         (test_more_specific_override_resets_skip):
243         (SkippedTests):
244         (SkippedTests.get_exp):
245         (SkippedTests.assert_exp):
246         (SkippedTests.test_skipped_tests_work):
247         (SkippedTests.test_duplicate_skipped_test_fails_lint):
248         (SkippedTests.test_skipped_file_overrides_expectations):
249         (SkippedTests.test_skipped_dir_overrides_expectations):
250         (SkippedTests.test_skipped_file_overrides_overrides):
251         (SkippedTests.test_skipped_dir_overrides_overrides):
252
253 2012-03-19  Eric Seidel  <eric@webkit.org>
254
255         Fix WTF header include discipline in Chromium WebKit
256         https://bugs.webkit.org/show_bug.cgi?id=81281
257
258         Reviewed by James Robinson.
259
260         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
261         * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
262
263 2012-03-19  Andy Chen  <andchen@rim.com>
264
265         [BlackBerry] Add new layout test for text match marker
266         https://bugs.webkit.org/show_bug.cgi?id=81531
267
268         Make the LayoutTestControllerBlackBerry::findString to test the
269         BlackBerry port implementation.
270
271         Reviewed by Rob Buis.
272
273         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
274         (LayoutTestController::findString):
275
276 2012-03-19  Ojan Vafai  <ojan@chromium.org>
277
278         Don't show WONTFIX tests in garden-o-matic
279         https://bugs.webkit.org/show_bug.cgi?id=81554
280
281         Reviewed by Dimitri Glazkov.
282
283         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
284         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
285
286 2012-03-19  Chris Fleizach  <cfleizach@apple.com>
287
288         platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
289         https://bugs.webkit.org/show_bug.cgi?id=81530
290
291         Reviewed by Jessie Berlin.
292
293         Add rowAtIndex to WebKitTestRunner.
294
295         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
296         (WTR::AccessibilityUIElement::rowAtIndex):
297         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
298         (AccessibilityUIElement):
299         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
300         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
301         (WTR):
302         (WTR::AccessibilityUIElement::rowAtIndex):
303
304 2012-03-19  Ojan Vafai  <ojan@chromium.org>
305
306         Change garden-o-matic All Failures tab to Expected Failures
307         https://bugs.webkit.org/show_bug.cgi?id=81540
308
309         Reviewed by Dimitri Glazkov.
310
311         Also, fix some broken unittests that had just gotten stale.
312
313         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
314         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
315         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
316         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
317         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
318         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
319         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
320         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
321         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
323
324 2012-03-19  Hao Zheng  <zhenghao@chromium.org>
325
326         [chromium] DRT crashes at shutdown.
327         https://bugs.webkit.org/show_bug.cgi?id=81504
328
329         Reviewed by James Robinson.
330
331         WebCompositor must be destroyed after WebView is properly destroyed,
332         or some compositor objects like CCLayerTreeHost may not be destroyed.
333         However, it is really hard to make the destruction order correct
334         explicitly in ~TestShell. So move it out to DumpRenderTree.
335
336         * DumpRenderTree/chromium/DumpRenderTree.cpp:
337         (main):
338         * DumpRenderTree/chromium/TestShell.cpp:
339         (TestShell::~TestShell):
340
341 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
342
343         add dpranke to webkitpy watchlist
344         https://bugs.webkit.org/show_bug.cgi?id=81433
345
346         Reviewed by Benjamin Poulain.
347
348         * Scripts/webkitpy/common/config/watchlist:
349
350 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
351
352         test-webkitpy is failing on SL/Python 2.6.1
353         https://bugs.webkit.org/show_bug.cgi?id=81533
354
355         Reviewed by Ojan Vafai.
356
357         It appears that itertools.combinations() is buggy in 2.6.1; this
358         backports the implementation from 2.7.
359
360         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
361         (TestConfigurationConverter.collapse_macros):
362         (TestConfigurationConverter):
363         (TestConfigurationConverter.combinations):
364
365 2012-03-19  David Michael Barr  <davidbarr@google.com>
366
367         Optimize the cleanup sequence in the start-queue.sh script
368         https://github.com/abarth/webkit/pull/1
369
370         Reviewed by Adam Barth.
371
372         Updating the working copy is an expensive operation
373         for a repository the size of WebKit.
374         Attempt to reset only to the target revision.
375
376         * EWSTools/start-queue.sh:
377
378 2012-03-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
379
380         Adjust architecture type of the EFL build bot.
381         https://bugs.webkit.org/show_bug.cgi?id=81452
382
383         Reviewed by Tony Chang.
384
385         * BuildSlaveSupport/build.webkit.org-config/config.json: The
386         buildslave is a 64-bit machine, therefore describe it as being
387         x86_64, not i386.
388
389 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
390
391         [Qt] printLoadedUrls prints "Object" instead of the actual URL.
392         https://bugs.webkit.org/show_bug.cgi?id=81514
393
394         Reviewed by Simon Hausmann.
395
396         * MiniBrowser/qt/qml/BrowserWindow.qml:
397
398 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
399
400         [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
401         https://bugs.webkit.org/show_bug.cgi?id=81491
402
403         Reviewed by Philippe Normand.
404
405         For the find_path(), find_library() etc CMake calls to find the
406         dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
407         set, otherwise CMake cannot know the dependencies exist and will only
408         look in the standard directories.
409
410         * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
411         the jhbuild Root directory.
412
413 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
414
415         [EFL] Add XDG env vars to jhbuildrc
416         https://bugs.webkit.org/show_bug.cgi?id=81510
417
418         Needed to ensure correct glib behaviour in jhbuild environment.
419
420         Reviewed by Philippe Normand.
421
422         * efl/jhbuildrc:
423
424 2012-03-19  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
425
426         Select best target for tap gesture.
427         https://bugs.webkit.org/show_bug.cgi?id=78801
428
429         Reviewed by Kenneth Rohde Christiansen.
430
431         Add TOUCH_ADJUSTMENT to enabled features.
432
433         * qmake/mkspecs/features/features.prf:
434
435 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
436
437         [chromium] synthesize wheel events for fling on main thread
438         https://bugs.webkit.org/show_bug.cgi?id=81458
439
440         Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
441
442         Reviewed by James Robinson.
443
444         * DumpRenderTree/chromium/EventSender.cpp:
445         (EventSender::EventSender):
446         (EventSender::gestureFlingCancel):
447         (EventSender::gestureFlingStart):
448         * DumpRenderTree/chromium/EventSender.h:
449         (EventSender):
450
451 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
452
453         [Qt] Add command line option to set the user agent in the MiniBrowser
454         https://bugs.webkit.org/show_bug.cgi?id=81508
455
456         Reviewed by Simon Hausmann.
457
458         * MiniBrowser/qt/BrowserWindow.cpp:
459         (BrowserWindow::BrowserWindow):
460         (BrowserWindow::webViewExperimental):
461         * MiniBrowser/qt/BrowserWindow.h:
462         (BrowserWindow):
463         * MiniBrowser/qt/MiniBrowserApplication.cpp:
464         (printHelp):
465         (MiniBrowserApplication::handleUserOptions):
466         * MiniBrowser/qt/MiniBrowserApplication.h:
467         (WindowOptions::WindowOptions):
468         (WindowOptions::setUserAgent):
469         (WindowOptions::userAgent):
470         (WindowOptions):
471
472 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
473
474         [Qt] Remove dead user agent code from the MiniBrowser.
475
476         Reviewed by Simon Hausmann.
477
478         * MiniBrowser/qt/BrowserWindow.cpp:
479         * MiniBrowser/qt/BrowserWindow.h:
480         (BrowserWindow):
481         * MiniBrowser/qt/MiniBrowser.qrc:
482         * MiniBrowser/qt/useragentlist.txt: Removed.
483
484 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
485
486         jhbuild: Call jhbuild's autogen.sh via bash.
487         https://bugs.webkit.org/show_bug.cgi?id=81485
488
489         Reviewed by Philippe Normand.
490
491         jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
492         this is usually true only on Linux systems, and even then bash for
493         some reason might not be available in that location. It is safer to
494         call bash directly and pass autogen.sh to it instead.
495
496         * jhbuild/jhbuild-wrapper:
497         (install_jhbuild):
498
499 2012-03-19  Philippe Normand  <pnormand@igalia.com>
500
501         [GTK] Prefix run-launcher with run-with-jhbuild
502         https://bugs.webkit.org/show_bug.cgi?id=81503
503
504         Reviewed by Hajime Morita.
505
506         * Scripts/run-launcher:
507
508 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
509
510         [EFL] Prefix run-launcher with run-with-jhbuild
511         https://bugs.webkit.org/show_bug.cgi?id=80026
512
513         Reviewed by Hajime Morita.
514
515         * Scripts/run-launcher:
516
517 2012-03-18  Csaba Osztrogonác  <ossy@webkit.org>
518
519         [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
520         https://bugs.webkit.org/show_bug.cgi?id=81498
521
522         * qmake/mkspecs/features/unix/default_post.prf:
523
524 2012-03-17  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
525
526         Unreviewed; switch to using my FreeBSD.org email address, the
527         other one is going to disappear soon.
528
529         * Scripts/webkitpy/common/config/committers.py:
530         * Scripts/webkitpy/common/config/watchlist:
531
532 2012-03-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
533
534         Unreviewed; fix webkitpy unit test failures after r111116.
535
536         It turns out that cmd_line in the patch in bug 80025 had the right
537         signature when it was submitted, but r109242 added a few more
538         required parameters, and since the method (and EflDriver) did not
539         exist at the time we ended up committing a broken method.
540
541         * Scripts/webkitpy/layout_tests/port/efl.py:
542         (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
543         arguments.
544
545 2012-03-17  Charles Wei  <charles.wei@torchmobile.com.cn>
546
547         [BlackBerry] Enable Web Timing for performance profiling and improvement.
548         https://bugs.webkit.org/show_bug.cgi?id=81085
549
550         Reviewed by Rob Buis.
551
552         * Scripts/build-webkit:
553
554 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
555
556         Add a dependencies installation step for EFL to buildbot master.cfg
557         https://bugs.webkit.org/show_bug.cgi?id=81337
558
559         Reviewed by Gustavo Noronha Silva.
560
561         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
562         (InstallEflDependencies):
563         (Factory.__init__):
564
565 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
566
567         [EFL] Prefixing run-webkit-tests with run-with-jhbuild
568         https://bugs.webkit.org/show_bug.cgi?id=80025
569
570         Reviewed by Gustavo Noronha Silva.
571
572         * Scripts/webkitpy/layout_tests/port/efl.py:
573         (EflDriver):
574         (EflDriver.cmd_line):
575         (EflPort._driver_class):
576
577 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
578
579         [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
580         https://bugs.webkit.org/show_bug.cgi?id=79904
581
582         build-webkit --efl will use jhbuild for fetching and building dependencies.
583
584         Reviewed by Gustavo Noronha Silva.
585
586         * Scripts/update-webkitefl-libs: Added.
587         * Scripts/webkitdirs.pm:
588         (jhbuildWrapperPrefixIfNeeded):
589         (generateBuildSystemFromCMakeProject):
590         (buildCMakeGeneratedProject):
591         * efl/common.py: Added.
592         (script_path):
593         (top_level_path):
594         (number_of_cpus):
595         * efl/jhbuild.modules: Added.
596         * efl/jhbuildrc: Added.
597         * efl/run-with-jhbuild: Added.
598
599 2012-03-16  Stephanie Lewis  <slewis@apple.com>
600
601         https://bugs.webkit.org/show_bug.cgi?id=81065
602         <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
603         Fix crash preventing WebKitTestRunner from working in Release.  
604         WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
605         FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
606         the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.
607
608         I removed ostringstream in favor of StringBuilder.  
609
610         Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
611
612         Reviewed by Geoff Garen.
613
614         Add DEBUG_DEFINES to set NDEBUG on release builds.
615         * WebKitTestRunner/Configurations/Base.xcconfig:
616         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
617
618         Remove ostringstream member in favor of StringBuilder.
619         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
620         (WTR::InjectedBundle::initialize):
621         (WTR::InjectedBundle::beginTesting):
622         (WTR::InjectedBundle::done):
623         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
624         (WTF):
625         (WTR::InjectedBundle::stringBuilder):
626         (InjectedBundle):
627
628         Append output to StringBuilder.
629         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
630         (WTR::hasPrefix):
631         (WTR::dumpPath):
632         (WTR::rangeToStr):
633         (WTR::styleDecToStr):
634         (WTR::frameToStr):
635         (WTR::dumpFrameScrollPosition):
636         (WTR::dumpFrameText):
637         (WTR::dumpDescendantFramesText):
638         (WTR::InjectedBundlePage::dump):
639         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
640         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
641         (WTR::InjectedBundlePage::willSendRequestForFrame):
642         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
643         (WTR::lastFileURLPathComponent):
644         (WTR::InjectedBundlePage::willAddMessageToConsole):
645         (WTR::InjectedBundlePage::willSetStatusbarText):
646         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
647         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
648         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
649         (WTR::InjectedBundlePage::shouldBeginEditing):
650         (WTR::InjectedBundlePage::shouldEndEditing):
651         (WTR::InjectedBundlePage::shouldInsertNode):
652         (WTR::InjectedBundlePage::shouldInsertText):
653         (WTR::InjectedBundlePage::shouldDeleteRange):
654         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
655         (WTR::InjectedBundlePage::shouldApplyStyle):
656         (WTR::InjectedBundlePage::didBeginEditing):
657         (WTR::InjectedBundlePage::didEndEditing):
658         (WTR::InjectedBundlePage::didChange):
659         (WTR::InjectedBundlePage::didChangeSelection):
660         (WTR::InjectedBundlePage::supportsFullScreen):
661         (WTR::InjectedBundlePage::enterFullScreenForElement):
662         (WTR::InjectedBundlePage::exitFullScreenForElement):
663         (WTR::InjectedBundlePage::beganEnterFullScreen):
664         (WTR::InjectedBundlePage::beganExitFullScreen):
665         (WTR::dumpBackForwardListItem):
666         (WTR::InjectedBundlePage::dumpBackForwardList):
667         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
668         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
669         (WTR::LayoutTestController::dumpConfigurationForViewport):
670         
671         Convert between WTF::String and WKStringRef.
672         * WebKitTestRunner/StringFunctions.h:
673         (WTR::toWTFString):
674         (WTR):
675         * WebKitTestRunner/TestInvocation.cpp:
676         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
677
678 2012-03-16  Eric Seidel  <eric@webkit.org>
679
680         Add a land-from-url command
681         https://bugs.webkit.org/show_bug.cgi?id=81411
682
683         Reviewed by Adam Barth.
684
685         Very basic so far.  The goal is to make it landing smarter
686         so that users don't have to bother to parse out the ids out of the urls.
687
688         * Scripts/webkitpy/common/config/urls.py:
689         (parse_bug_id):
690         (parse_attachment_id):
691         * Scripts/webkitpy/common/config/urls_unittest.py:
692         (URLsTest.test_parse_bug_id):
693         (URLsTest):
694         (URLsTest.test_parse_attachment_id):
695         * Scripts/webkitpy/tool/commands/download.py:
696         (ProcessURLsMixin):
697         (ProcessURLsMixin._fetch_list_of_patches_to_process):
698         (LandFromURL):
699         * Scripts/webkitpy/tool/commands/download_unittest.py:
700         (test_land_from_bug):
701         (test_land_from_url):
702
703 2012-03-16  Dave Tharp  <dtharp@codeaurora.org>
704
705         build-webkit launcher instructions use wrong relative path for Qt
706         https://bugs.webkit.org/show_bug.cgi?id=81357
707
708         Reviewed by Eric Seidel.
709
710         Ensure we are at the proper directory before generating run-launcher
711         instructions.
712
713         * Scripts/build-webkit:
714
715 2012-03-16  Brady Eidson  <beidson@apple.com>
716
717         <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
718         REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
719
720         Reviewed by Geoff Garen.
721
722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
723         * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
724
725 2012-03-16  Ojan Vafai  <ojan@chromium.org>
726
727         Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
728         https://bugs.webkit.org/show_bug.cgi?id=81407
729
730         Reviewed by Adam Barth.
731
732         * Scripts/webkitpy/layout_tests/controllers/manager.py:
733         (summarize_results):
734         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
735         (ResultSummaryTest.summarized_results):
736         (ResultSummaryTest.test_no_svn_revision):
737         (ResultSummaryTest.test_svn_revision):
738         (ResultSummaryTest):
739         (ResultSummaryTest.test_summarized_results_wontfix):
740
741 2012-03-16  Ojan Vafai  <ojan@chromium.org>
742
743         Have webkit-patch rebaseline-test update test_expectations.txt
744         https://bugs.webkit.org/show_bug.cgi?id=81054
745
746         Recommit http://trac.webkit.org/changeset/110783 now that
747         http://trac.webkit.org/changeset/111034 has landed.
748
749         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
750         (TestExpectations.remove_configuration_from_test):
751         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
752         (RemoveConfigurationsTest):
753         (RemoveConfigurationsTest.test_remove):
754         (test_remove_line):
755         * Scripts/webkitpy/tool/commands/rebaseline.py:
756         (RebaselineTest._update_expectations_file):
757         (RebaselineTest._rebaseline_test_and_update_expectations):
758         (RebaselineTest):
759         (RebaselineTest.execute):
760         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
761         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
762         (test_rebaseline_updates_expectations_file):
763
764 2012-03-15  Ojan Vafai  <ojan@chromium.org>
765
766         Specifier collapsing when writing test expectations lines gets a number of cases wrong
767         https://bugs.webkit.org/show_bug.cgi?id=81309
768
769         Reviewed by Dimitri Glazkov.
770
771         I've run this over all the lines in the current Chromium test_expectations.txt file,
772         so I'm relatively confident we now cover all the cases.
773
774         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
775         (TestConfigurationConverter.__init__):
776         (TestConfigurationConverter.collapse_macros):
777         (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
778         (TestConfigurationConverter):
779         (TestConfigurationConverter.intersect_combination):
780         (TestConfigurationConverter.symmetric_difference):
781         (TestConfigurationConverter.to_specifiers_list):
782         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
783         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
784         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
785         (make_mock_all_test_configurations_set):
786         (TestConfigurationConverterTest.test_symmetric_difference):
787         (TestConfigurationConverterTest.test_to_config_set):
788         (TestConfigurationConverterTest.test_macro_expansion):
789         (TestConfigurationConverterTest.test_to_specifier_lists):
790         (TestConfigurationConverterTest.test_converter_macro_collapsing):
791         * Scripts/webkitpy/layout_tests/port/chromium.py:
792         (ChromiumPort):
793         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
794         (ChromiumAndroidPort.__init__):
795         The android port uses "arm" as it's architecture, which is technically correct,
796         but considerably complicates making collapsing work. We probably should kill
797         the concept of architecture entirely. The benefits are not worth the code
798         complexity.
799
800         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
801         (ChromiumPortTest.test_all_test_configurations):
802         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
803         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
804         (test_rebaseline_updates_expectations_file):
805
806 2012-03-16  Dinu Jacob  <dinu.jacob@nokia.com>
807
808         [Qt][Wk2] Assertion Failure and crash on file upload
809         https://bugs.webkit.org/show_bug.cgi?id=80854
810
811         Reviewed by Simon Hausmann.
812
813         Added filePicker to WebView using experimental API.
814
815         * MiniBrowser/qt/MiniBrowser.qrc:
816         * MiniBrowser/qt/icons/folder.png: Added.
817         * MiniBrowser/qt/icons/titlebar.png: Added.
818         * MiniBrowser/qt/icons/up.png: Added.
819         * MiniBrowser/qt/qml/BrowserWindow.qml:
820         * MiniBrowser/qt/qml/FilePicker.qml: Added.
821
822 2012-03-16  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
823
824         Updating email for committer.py script.
825
826         * Scripts/webkitpy/common/config/committers.py:
827
828 2012-03-16  Robert Kroeger  <rjkroege@chromium.org>
829
830         [chromium] DRT: Add support for sending gesture scrolls without a begin
831         https://bugs.webkit.org/show_bug.cgi?id=81292
832
833         Reviewed by Kent Tamura.
834
835         * DumpRenderTree/chromium/EventSender.cpp:
836         (EventSender::EventSender):
837         (EventSender::gestureScrollFirstPoint):
838         * DumpRenderTree/chromium/EventSender.h:
839         (EventSender):
840
841 2012-03-02  Carlos Garcia Campos  <cgarcia@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
842
843         [GTK] WebKitIconDatabase doesn't keep icons cached
844         https://bugs.webkit.org/show_bug.cgi?id=56200
845
846         Reviewed by Martin Robinson.
847
848         Add support for favicons in GtkLauncher.
849
850         * GtkLauncher/main.c:
851         (activateUriEntryCb):
852         (iconLoadedCb):
853         (createBrowser):
854
855 2012-03-16  Adam Barth  <abarth@webkit.org>
856
857         Remove sheriff-bot's last-green-revision command
858         https://bugs.webkit.org/show_bug.cgi?id=81314
859
860         Reviewed by Eric Seidel.
861
862         This command is a cruel joke.  WebKit doesn't really ever have a
863         last-green-revision.
864
865         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
866         (BuildBot._find_green_revision):
867         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
868         (MockBuildBot.builder_statuses):
869         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
870         (test_find_green_revision):
871         * Scripts/webkitpy/tool/bot/irc_command.py:
872         (IRCCommand.execute):
873         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
874         (SheriffIRCBotTest.test_help):
875         * Scripts/webkitpy/tool/commands/queries.py:
876         (PatchesToReview.execute):
877
878 2012-03-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
879
880         [Qt] Make gccdepends test aware of broken icecream deps generation
881
882         Icecream seems to build the files without passing -o to gcc with
883         the original destination path, which means the target name in the
884         dependency file is wrong.
885
886         Also, echo something to the final file instead of just touching it,
887         so it's not deleted on every build.
888
889         Reviewed by Simon Hausmann.
890
891         * qmake/config.tests/gccdepends/gccdepends.pro:
892
893 2012-03-16  Kihong Kwon  <kihong.kwon@samsung.com>
894
895         Support for Battery Status API
896         https://bugs.webkit.org/show_bug.cgi?id=62698
897
898         Add include directory and file.
899         http://www.w3.org/TR/battery-status/
900
901         Reviewed by Adam Barth.
902
903         * Scripts/build-webkit:
904
905 2012-03-16  Kishore Bolisetty  <kbolisetty@innominds.com>
906
907         check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
908         https://bugs.webkit.org/show_bug.cgi?id=81007
909
910         Reviewed by Adam Barth.
911
912         A dedidcated build slave is available for efl on build.webkit.org. 
913         This change add's an entry for the elf port in list of available port builders.
914         This is required because test_expectations.py when triggered, looks for a valid port object for the specified port. 
915
916         * Scripts/webkitpy/layout_tests/port/builders.py:
917
918 2012-03-16  Adam Barth  <abarth@webkit.org>
919
920         [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
921         https://bugs.webkit.org/show_bug.cgi?id=81302
922
923         Reviewed by Eric Seidel.
924
925         This is a trivial patch, but the variable name turned up in a grep of
926         webkitpy and looks like copy pasta.
927
928         * Scripts/webkitpy/common/net/statusserver.py:
929         (StatusServer.next_work_item):
930
931 2012-03-16  Andrew Lo  <anlo@rim.com>
932
933         [BlackBerry] Enable PAGE_VISIBILITY_API
934         https://bugs.webkit.org/show_bug.cgi?id=81257
935
936         Enable Page Visibility API for BlackBerry.
937
938         Reviewed by Rob Buis.
939
940         * Scripts/build-webkit:
941
942 2012-03-16  Zan Dobersek  <zandobersek@gmail.com>
943
944         [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
945         https://bugs.webkit.org/show_bug.cgi?id=81232
946
947         Reviewed by Philippe Normand.
948
949         Use the newly-added helper method in DumpRenderTreeSupportGtk.
950
951         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
952         (LayoutTestController::computedStyleIncludingVisitedInfo):
953
954 2012-03-15  Eric Seidel  <eric@webkit.org>
955
956         Move parse_bug_id into config/urls in preparation for re-use elsewhere.
957         https://bugs.webkit.org/show_bug.cgi?id=81313
958
959         Reviewed by Adam Barth.
960
961         * Scripts/webkitpy/common/checkout/changelog.py:
962         (parse_bug_id_from_changelog):
963         * Scripts/webkitpy/common/config/urls.py:
964         (parse_bug_id):
965         * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
966         (URLsTest):
967         (URLsTest.test_parse_bug_id):
968         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
969         (test_parse_bug_id):
970         * Scripts/webkitpy/tool/bot/irc_command.py:
971         (_post_error_and_check_for_bug_url):
972         * Scripts/webkitpy/tool/bot/sheriff.py:
973         (Sheriff.post_rollout_patch):
974         (Sheriff.post_chromium_deps_roll):
975
976 2012-03-15  Adam Barth  <abarth@webkit.org>
977
978         The commit-queue should fast-track patches that have already passed the testing EWS bots
979         https://bugs.webkit.org/show_bug.cgi?id=81305
980
981         Reviewed by Eric Seidel.
982
983         If a patch has already passed the testing EWS bots (currently only the
984         chromium-ews bot), we should be able to land the patch without running
985         the tests again.  This patch is somewhat risky in that the tests might
986         have been broken between when the EWS bots ran and when the
987         commit-queue is processing the patch.  If that turns out to be a
988         problem in practice, we'll tighten up this fast-track in some way,
989         likely by making sure that the pass status is recent.
990
991         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
992         (CommitQueueTaskDelegate.did_pass_testing_ews):
993         (CommitQueueTask._did_pass_tests_recently):
994         (CommitQueueTask.run):
995         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
996         (MockCommitQueue.did_pass_testing_ews):
997         (test_fast_success_case):
998         * Scripts/webkitpy/tool/commands/queues.py:
999         (CommitQueue.did_pass_testing_ews):
1000         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1001         (test_did_pass_testing_ews):
1002
1003 2012-03-15  Kentaro Hara  <haraken@chromium.org>
1004
1005         [PerformanceTests] run-perf-tests should output correct units
1006         https://bugs.webkit.org/show_bug.cgi?id=78303
1007
1008         Reviewed by Ryosuke Niwa.
1009
1010         Previously run-perf-tests just supported "ms" for units.
1011         Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
1012         This patch fixes run-perf-tests so that they can support custom units.
1013         The default unit is "ms".
1014
1015         The test result looks like this:
1016
1017         $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
1018         RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
1019         median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
1020
1021         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1022         (PerfTestsRunner._process_parser_test_result):
1023
1024 2012-03-15  Brent Fulgham  <bfulgham@webkit.org>
1025
1026         [WinCairo] Unreviewed build change after wtf path changes.
1027
1028         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
1029         directories to look at the private header directory to find 'wtf'.
1030
1031 2012-03-15  Kent Tamura  <tkent@chromium.org>
1032
1033         REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
1034         https://bugs.webkit.org/show_bug.cgi?id=81293
1035
1036         Reviewed by Adam Barth.
1037
1038         r110595 introduced new format of the author field of ChangeLog entry:
1039         "Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>"
1040         Updte chanelog.py to support it.
1041
1042         * Scripts/webkitpy/common/checkout/changelog.py:
1043         (ChangeLogEntry._split_contributor_names):
1044         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1045         (test_parse_authors):
1046
1047 2012-03-15  Lynn Neir  <lynn.neir@skype.net>
1048
1049         Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
1050
1051         Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
1052
1053         Reviewed by Jessie Berlin.
1054
1055         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1056         (LayoutTestController::setValueForUser):
1057         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1058         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1059         (WTR::LayoutTestController::setValueForUser):
1060         (WTR):
1061         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1062         (LayoutTestController):
1063
1064 2012-03-15  Adam Barth  <abarth@webkit.org>
1065
1066         Update the start-queue.sh script to match what we're using on the bots
1067         https://bugs.webkit.org/show_bug.cgi?id=81277
1068
1069         Reviewed by Eric Seidel.
1070
1071         Over time we've added more magic git commands to clean up the local repo after
1072         it has been borked in various ways. The idea behind this sequence is to clear
1073         out any changes in the working copy and then to rebuild the master branch from
1074         origin/master.
1075
1076         This patch also removes the watchdog timer that we've stopped using on the
1077         bots.
1078
1079         This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
1080         Note: Eric and I are experimenting with GitHub to see if it might be
1081         useful for WebKit.  If you have thoughts on this topic, please feel
1082         free to grab Eric or me on #webkit to chat.  I assume that he and I are
1083         the only ones who care about this file so using this alternative
1084         process for this patch shouldn't cause any trouble.
1085
1086         * EWSTools/start-queue.sh:
1087
1088 2012-03-15  Adam Barth  <abarth@webkit.org>
1089
1090         The commit-queue can hang when the test_expectations.txt style check fails during commit
1091         https://bugs.webkit.org/show_bug.cgi?id=81251
1092
1093         Reviewed by Eric Seidel.
1094
1095         We forgot to check the --non-interactive flag, so we end up prompting
1096         the "user" who doesn't exist on the bot.  We might consider teaching
1097         the User class about non-interactive if we have this sort of bug again.
1098
1099         * Scripts/webkitpy/tool/steps/commit.py:
1100         (Commit.options):
1101         (Commit._check_test_expectations):
1102         (Commit.run):
1103         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1104         (CommitTest.test_check_test_expectations):
1105
1106 2012-03-15  Jessie Berlin  <jberlin@apple.com>
1107
1108         fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
1109         Mac WK2 because WebAudio is not enabled
1110         https://bugs.webkit.org/show_bug.cgi?id=81259
1111
1112         Reviewed by Dan Bernstein.
1113
1114         Enable WebAudio so that it appears in the window object in the tests.
1115         The webaudio tests are all still skipped in the Mac Skipped list.
1116
1117         * WebKitTestRunner/TestController.cpp:
1118         (WTR::TestController::resetStateToConsistentValues):
1119
1120 2012-03-15  David Levin  <levin@chromium.org>
1121
1122         Various autoresize fixes.
1123         https://bugs.webkit.org/show_bug.cgi?id=81199
1124
1125         Reviewed by Darin Fisher.
1126
1127         * DumpRenderTree/chromium/LayoutTestController.cpp:
1128         (LayoutTestController::reset): Stop using the deprecated api that was removed.
1129
1130 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1131
1132         [GTK] Actually use --release and --debug command line options in run-gtk-test
1133         https://bugs.webkit.org/show_bug.cgi?id=81234
1134
1135         Reviewed by Philippe Normand.
1136
1137         Actually handle --release and --debug command line options to
1138         create the build directory, falling back to current hack to detect
1139         whether it's a Release or Debug build when both options are missed.
1140
1141         * Scripts/run-gtk-tests:
1142         (TestRunner.__init__): Receive options too.
1143         (TestRunner._get_top_level_directory): Helper function to get the
1144         top level directory.
1145         (TestRunner._get_build_directory): Helper function to get the
1146         build directory depending on --release/--debug command line
1147         options or gessing it if both options are missing.
1148         (TestRunner._ensure_accessibility_daemon_is_running): Use
1149         self-options now.
1150         (TestRunner.run): Ditto.
1151         (TestRunner.run.run_tests): Pass options to the constructor
1152         instead of run().
1153
1154 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1155
1156         [GTK] Run unit tests with --verbose in the bots
1157         https://bugs.webkit.org/show_bug.cgi?id=81230
1158
1159         Reviewed by Martin Robinson.
1160
1161         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1162         (RunGtkAPITests): Add --verbose to run-gtk-test command.
1163
1164 2012-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1165
1166         Move wx port to using export macros
1167         https://bugs.webkit.org/show_bug.cgi?id=77279
1168
1169         Reviewed by Hajime Morita.
1170
1171         * waf/build/settings.py:
1172         (common_configure):
1173
1174 2012-03-15  Philippe Normand  <pnormand@igalia.com>
1175
1176         Unreviewed, GTK build fix attempt after r110845.
1177
1178         * Scripts/run-gtk-tests: Added --release and --debug options.
1179
1180 2012-03-15  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1181
1182         Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
1183         https://bugs.webkit.org/show_bug.cgi?id=79673
1184
1185         Preparatory work for bringing jhbuild enabled build to EFL port.
1186
1187         Reviewed by Philippe Normand.
1188
1189         * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
1190         * Scripts/update-webkitgtk-libs:
1191         * gtk/run-with-jhbuild:
1192         * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
1193         (top_level_path):
1194         (jhbuild_installed):
1195         (jhbuild_cloned):
1196         (jhbuild_at_expected_revision):
1197         (update_jhbuild):
1198         (clone_jhbuild):
1199         (install_jhbuild):
1200         (update_webkit_libs_jhbuild):
1201         (determine_platform):
1202         (ensure_jhbuild):
1203
1204 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1205
1206         [GTK] Add command line options to run-gtk-tests script
1207         https://bugs.webkit.org/show_bug.cgi?id=81218
1208
1209         Reviewed by Philippe Normand.
1210
1211         Following command line options have been added:
1212
1213         -v, --verbose: to run gtester with --verbose. That would be used
1214         by the bots to make it easier to know which test case it failing.
1215
1216         --display: to use a different display for Xvfb
1217
1218         It's also possible to pass one or more tests as arguments.
1219
1220         * Scripts/run-gtk-tests:
1221         (TestRunner.__init__): Receive command line arguments.
1222         (TestRunner._get_tests): Get all the tests or the ones passed by
1223         command line arguments.
1224         (TestRunner._ensure_accessibility_daemon_is_running): Use display
1225         command line argument.
1226         (TestRunner.run): Pas command line options.
1227         (TestRunner.run.run_tests): Pass command line arguments.
1228
1229 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1230
1231         [GTK] WebKit2APITests/TestPrinting timeout in the bots
1232         https://bugs.webkit.org/show_bug.cgi?id=81211
1233
1234         Reviewed by Philippe Normand.
1235
1236         Add gtk+ patch to fix timeout in the bots. A similar patch has
1237         already landed in updatream gtk+, see
1238         http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
1239
1240         * gtk/jhbuild.modules:
1241         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
1242
1243 2012-03-14  Gustavo Noronha Silva  <gns@gnome.org>
1244
1245         sheriffbot should also be addressable with a comma in addition to colon
1246         https://bugs.webkit.org/show_bug.cgi?id=81101
1247
1248         Reviewed by Adam Barth.
1249
1250         * Scripts/webkitpy/common/net/irc/ircbot.py:
1251         (IRCBot.on_pubmsg):
1252
1253 2012-03-15  Alexander Færøy  <alexander.faeroy@nokia.com>
1254
1255         [Qt] MiniBrowser scroll indicators should not scroll out of view
1256         https://bugs.webkit.org/show_bug.cgi?id=81131
1257
1258         Reviewed by Kenneth Rohde Christiansen.
1259
1260         * MiniBrowser/qt/qml/ScrollIndicator.qml:
1261
1262 2012-03-14  Chris Fleizach  <cfleizach@apple.com>
1263
1264         AX: ARIA tables need to support selected rows attribute/select rows changed notification
1265         https://bugs.webkit.org/show_bug.cgi?id=79821
1266
1267         Reviewed by Beth Dakin.
1268
1269         * DumpRenderTree/AccessibilityUIElement.cpp:
1270         (rowAtIndexCallback):
1271         (AccessibilityUIElement::getJSClass):
1272         * DumpRenderTree/AccessibilityUIElement.h:
1273         (AccessibilityUIElement):
1274         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1275         (AccessibilityUIElement::rowAtIndex):
1276         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1277         (AccessibilityUIElement::rowAtIndex):
1278         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1279         (AccessibilityUIElement::rowAtIndex):
1280         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1281         (AccessibilityUIElement::rowAtIndex):
1282
1283 2012-03-14  Tim Horton  <timothy_horton@apple.com>
1284
1285         NRWT should respect --additional-platform-directory's Skipped list
1286         https://bugs.webkit.org/show_bug.cgi?id=81172
1287
1288         Reviewed by Timothy Hatcher.
1289
1290         Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
1291         from said path are already used, but the Skipped file is ignored.
1292
1293         * Scripts/webkitpy/layout_tests/port/webkit.py:
1294         (WebKitPort._skipped_file_search_paths):
1295         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1296         (test_skipped_file_search_paths):
1297
1298 2012-03-14  Ojan Vafai  <ojan@chromium.org>
1299
1300         Unreviewed, rolling out r110783.
1301         http://trac.webkit.org/changeset/110783
1302         https://bugs.webkit.org/show_bug.cgi?id=81054
1303
1304         Caused existing test expectation lines to expand to one for
1305         each test configuration.
1306
1307         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1308         (TestExpectations.has_warnings):
1309         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1310         (test_macro_overrides):
1311         * Scripts/webkitpy/tool/commands/rebaseline.py:
1312         (RebaselineTest._save_baseline):
1313         (RebaselineTest._rebaseline_test):
1314         (RebaselineTest.execute):
1315         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1316         (TestRebaseline.test_tests_to_update):
1317
1318 2012-03-13  Jon Lee  <jonlee@apple.com>
1319
1320         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
1321         https://bugs.webkit.org/show_bug.cgi?id=80922
1322         <rdar://problem/11035082>
1323
1324         Reviewed by Jian Li.
1325
1326         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
1327         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
1328         new API. Therefore, APIs that are common between the two will have:
1329         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
1330
1331         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
1332         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
1333
1334         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
1335         * DumpRenderTree/chromium/LayoutTestController.cpp:
1336         (LayoutTestController::grantDesktopNotificationPermission):
1337         (LayoutTestController::simulateDesktopNotificationClick):
1338         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1339         * DumpRenderTree/chromium/TestShell.cpp:
1340         (TestShell::TestShell):
1341         (TestShell::resetTestController):
1342         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1343         (DRTDesktopNotificationPresenter::checkNotificationPermission):
1344
1345 2012-03-13  Ojan Vafai  <ojan@chromium.org>
1346
1347         Have webkit-patch rebaseline-test update test_expectations.txt
1348         https://bugs.webkit.org/show_bug.cgi?id=81054
1349
1350         Reviewed by Dirk Pranke.
1351
1352         This will allow us to use the All Failures tab in garden-o-matic
1353         to rebaseline tests without making test_expectations.txt stale.
1354
1355         It's conservative and only removes lines if the test is
1356         not flaky and fails in a way the rebaseline would fix (e.g.
1357         CRASH/TIMEOUT will not be touched).
1358
1359         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1360         (TestExpectations.remove_configuration_from_test):
1361         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1362         (RemoveConfigurationsTest):
1363         (RemoveConfigurationsTest.test_remove):
1364         (test_remove_line):
1365         * Scripts/webkitpy/tool/commands/rebaseline.py:
1366         (RebaselineTest._is_supported_port):
1367         (RebaselineTest):
1368         (RebaselineTest._update_expectations_file):
1369         (RebaselineTest._rebaseline_test_and_update_expectations):
1370         (RebaselineTest.execute):
1371         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1372         (TestRebaseline.test_rebaseline_updates_expectations_file):
1373
1374 2012-03-14  Jessie Berlin  <jberlin@apple.com>
1375
1376         Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
1377         https://bugs.webkit.org/show_bug.cgi?id=81167
1378
1379         Reviewed by Sam Weinig.
1380
1381         Do not use 0 as a key in a HashMap.
1382
1383         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1384         cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
1385
1386 2012-03-14  Ojan Vafai  <ojan@chromium.org>
1387
1388         Add the chromium lion bot to garden-o-matic and remove
1389         the platform_move_to in builders.py since the Chromium Lion
1390         port is now a normal port.
1391
1392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1393         * Scripts/webkitpy/layout_tests/port/builders.py:
1394
1395 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
1396
1397         Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
1398
1399         Unreviewed, build fix.
1400
1401         * Scripts/webkitpy/layout_tests/port/base.py:
1402         (Port.skipped_tests):
1403
1404 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
1405
1406         Please add a way to manually skip some tests in NRWT
1407         https://bugs.webkit.org/show_bug.cgi?id=81019
1408
1409         Reviewed by Ojan Vafai.
1410
1411         This patch implements the -i / --ignore-tests flag from ORWT
1412         and refactors the test_expectations.py code slightly to handle
1413         it.
1414
1415         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1416         (Manager.parse_expectations):
1417         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1418         (TestExpectations.__init__):
1419         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1420         (test_add_skipped_tests):
1421         (test_add_skipped_tests_duplicate):
1422         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1423         (parse_args):
1424         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1425         (MainTest.test_ignore_tests):
1426         (MainTest.test_ignore_tests.assert_ignored):
1427
1428 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
1429
1430         nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
1431         https://bugs.webkit.org/show_bug.cgi?id=81028
1432
1433         Reviewed by Ojan Vafai.
1434
1435         The mac port had incorrect lookups for 'mac-lion' and
1436         'mac-future' in some places. This patch fixes that and adds a
1437         bunch of tests.
1438
1439         * Scripts/webkitpy/layout_tests/port/mac.py:
1440         (MacPort.baseline_path):
1441         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1442         (MacTest.assert_skipped_file_search_paths):
1443         (MacTest.test_skipped_file_search_paths):
1444         (_assert_search_path):
1445         (test_baseline_search_path):
1446         * Scripts/webkitpy/layout_tests/port/webkit.py:
1447         (WebKitPort._skipped_file_search_paths):
1448
1449 2012-03-13  Jer Noble  <jer.noble@apple.com>
1450
1451         Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
1452         https://bugs.webkit.org/show_bug.cgi?id=81056
1453
1454         Reviewed by Jessie Berlin.
1455
1456         Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
1457
1458         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1459         (WTR::InjectedBundlePage::InjectedBundlePage):
1460         (WTR::InjectedBundlePage::beganEnterFullScreen):
1461         (WTR::InjectedBundlePage::beganExitFullScreen):
1462
1463 2012-03-14  Alexander Færøy  <alexander.faeroy@nokia.com>
1464
1465         The width and height of the scroll indicators in the MiniBrowser does
1466         not consider the offset margins.
1467         https://bugs.webkit.org/show_bug.cgi?id=81112
1468
1469         Reviewed by Kenneth Rohde Christiansen.
1470
1471         This patch fixes the issue by withdrawing two times the anchor
1472         margins.
1473
1474         * MiniBrowser/qt/qml/ScrollIndicator.qml:
1475
1476 2012-03-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1477
1478         [EFL] Implement LayoutTestController::clearBackForwardList
1479         https://bugs.webkit.org/show_bug.cgi?id=80142
1480
1481         Adding missing implementation clearBackForwardList to EFL's
1482         LayoutTestController. This implementation allows us to unskip 
1483         tests connected with history.
1484
1485         Reviewed by Antonio Gomes.
1486
1487         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1488         (LayoutTestController::clearBackForwardList): Implemented.
1489
1490 2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1491
1492         [EFL][DRT] Expose window.internals object
1493         https://bugs.webkit.org/show_bug.cgi?id=79900
1494
1495         Exposes window.internals for EFL's DRT. Makes possible to
1496         remove some tests from the skip list.
1497
1498         Reviewed by Antonio Gomes.
1499
1500         * DumpRenderTree/efl/CMakeLists.txt:
1501         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1502         (DumpRenderTreeChrome::onWindowObjectCleared):
1503
1504 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
1505
1506         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
1507         https://bugs.webkit.org/show_bug.cgi?id=78853
1508
1509         Reviewed by Adam Barth.
1510
1511         * Scripts/build-webkit:
1512         * qmake/mkspecs/features/features.prf:
1513
1514 2012-03-12  Antonio Gomes  <agomes@rim.com>
1515
1516         Convert nodesFromRect tests to use Internals interface
1517         https://bugs.webkit.org/show_bug.cgi?id=80886
1518
1519         Reviewed by Ryosuke Niwa.
1520
1521         This clean up allows to remove port specific bits of each
1522         DRT implementation that supports testing Document::nodesFromRect,
1523         in favor of making use of the 'Internals' interface to test it.
1524
1525         This makes its code conveniently more expansible and cleaner.
1526
1527         Also removed stubs from Win and EFL DRTs.
1528
1529         * DumpRenderTree/LayoutTestController.cpp:
1530         (LayoutTestController::staticFunctions):
1531         * DumpRenderTree/LayoutTestController.h:
1532         (LayoutTestController):
1533         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1534         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1535         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1536         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1537         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1538         (LayoutTestController):
1539         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1540
1541 2012-03-13  Ojan Vafai  <ojan@chromium.org>
1542
1543         Rebaselining for a new port doesn't work right with multiple fallback ports
1544         https://bugs.webkit.org/show_bug.cgi?id=80932
1545
1546         Reviewed by Adam Barth.
1547
1548         Since chromium-leopard also falls back to mac-leopard, we need to
1549         copy the existing result for both chromium-leopard and chromium-snowleopard
1550         before doing lion rebaselines.
1551
1552         * Scripts/webkitpy/layout_tests/port/builders.py:
1553         (fallback_port_names_for_new_port):
1554         * Scripts/webkitpy/tool/commands/rebaseline.py:
1555         (RebaselineTest):
1556         (RebaselineTest._copy_existing_baseline):
1557         (RebaselineTest._rebaseline_test):
1558         (RebaselineTest.execute):
1559         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1560         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1561         (GardeningHTTPRequestHandler.rebaseline):
1562         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1563         (GardeningServerTest.test_rebaseline_new_port):
1564
1565 2012-03-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1566
1567         [Qt] Tweak minibrowser UI
1568
1569         Add some margins to the scroll indicators, and set a dark background
1570         color so you see the page dimensions.
1571
1572         Reviewed by Antonio Gomes.
1573
1574         * MiniBrowser/qt/qml/BrowserWindow.qml:
1575         * MiniBrowser/qt/qml/ScrollIndicator.qml:
1576
1577 2012-03-13  ChangSeok Oh  <shivamidow@gmail.com>
1578
1579         [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
1580         https://bugs.webkit.org/show_bug.cgi?id=79601
1581
1582         Reviewed by Gustavo Noronha Silva.
1583
1584         Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
1585         createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
1586         and is taken over to sendKeyDown.
1587         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
1588         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
1589
1590         * DumpRenderTree/efl/EventSender.cpp:
1591         (KeyEventInfo::KeyEventInfo):
1592         (KeyEventInfo):
1593         (createKeyEventInfo):
1594         (sendKeyDown):
1595         (keyDownCallback):
1596         (sendAsynchronousKeyDown):
1597         (scheduleAsynchronousKeyDownCallback):
1598
1599 2012-03-12  Ojan Vafai  <ojan@chromium.org>
1600
1601         webkit-patch optimize-baselines sometimes creates a mac-future result
1602         https://bugs.webkit.org/show_bug.cgi?id=80717
1603
1604         Reviewed by Adam Barth.
1605
1606         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1607         (_baseline_search_hypergraph):
1608         (BaselineOptimizer._find_optimal_result_placement):
1609         (BaselineOptimizer._filter_virtual_ports):
1610         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1611         (BaselineOptimizerTest.test_no_add_mac_future):
1612
1613 2012-03-12  Jessie Berlin  <jberlin@apple.com>
1614
1615         More Windows build fixing.
1616
1617         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1618
1619 2012-03-12  Jessie Berlin  <jberlin@apple.com>
1620
1621         More Windows build fixing.
1622
1623         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1624         * DumpRenderTree/win/EditingDelegate.cpp:
1625         * DumpRenderTree/win/EventSender.cpp:
1626         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1627         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1628         * DumpRenderTree/win/UIDelegate.cpp:
1629
1630 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
1631
1632         remove the 'gpu' group from the flakiness dashboard
1633         https://bugs.webkit.org/show_bug.cgi?id=80353
1634
1635         Reviewed by Adam Barth.
1636
1637         Since those bots are obsolete, we don't need this any more.
1638
1639         * TestResultServer/static-dashboards/builders.js:
1640         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1641         (testPlatformAndBuildType):
1642         (testHtmlForTestTypeSwitcherGroup):
1643
1644 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
1645
1646         remove graphics_type from webkitpy.layout_tests.models.test_configuration
1647         https://bugs.webkit.org/show_bug.cgi?id=80643
1648
1649         Reviewed by Ojan Vafai.
1650
1651         Now that the chromium-gpu ports are gone, there's no need for
1652         the graphics_type CPU/GPU distinction. Most of this change is
1653         just updating tests accordingly.
1654
1655         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
1656         (TestExpectationEditorTests):
1657         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1658         (TestConfiguration.__init__):
1659         (TestConfiguration.category_order):
1660         (TestConfiguration.__str__):
1661         (TestConfiguration.__repr__):
1662         (TestConfiguration.__hash__):
1663         (TestConfigurationConverter.to_specifiers_list):
1664         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1665         (make_mock_all_test_configurations_set):
1666         (TestConfigurationTest.test_items):
1667         (TestConfigurationTest.test_keys):
1668         (TestConfigurationTest.test_str):
1669         (TestConfigurationTest.test_repr):
1670         (TestConfigurationTest.test_hash):
1671         (TestConfigurationTest.test_hash.query_unknown_key):
1672         (TestConfigurationTest.test_eq):
1673         (TestConfigurationTest.test_values):
1674         (SpecifierSorterTest.test_specifier_priority):
1675         (SpecifierSorterTest.test_sort_specifiers):
1676         (TestConfigurationConverterTest.test_to_config_set):
1677         (TestConfigurationConverterTest.test_macro_expansion):
1678         (TestConfigurationConverterTest.test_to_specifier_lists):
1679         (TestConfigurationConverterTest.test_converter_macro_collapsing):
1680         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1681         (test_error_on_different_build_type):
1682         (TestExpectationSerializerTests.test_parsed_to_string):
1683         (TestExpectationSerializerTests.test_reconstitute_only_these):
1684         * Scripts/webkitpy/layout_tests/port/apple.py:
1685         (ApplePort._generate_all_test_configurations):
1686         * Scripts/webkitpy/layout_tests/port/base.py:
1687         (Port.__init__):
1688         (Port.name):
1689         (Port.version):
1690         (Port.test_configuration):
1691         * Scripts/webkitpy/layout_tests/port/builders.py:
1692         * Scripts/webkitpy/layout_tests/port/chromium.py:
1693         (ChromiumPort):
1694         (ChromiumPort._generate_all_test_configurations):
1695         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1696         (ChromiumLinuxPort.__init__):
1697         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1698         (ChromiumLinuxPortTest.test_check_illegal_port_names):
1699         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1700         (ChromiumMacPortTest.test_baseline_path):
1701         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1702         (ChromiumPortTest.test_all_test_configurations):
1703         * Scripts/webkitpy/layout_tests/port/efl.py:
1704         (EflPort._generate_all_test_configurations):
1705         * Scripts/webkitpy/layout_tests/port/gtk.py:
1706         (GtkPort._generate_all_test_configurations):
1707         * Scripts/webkitpy/layout_tests/port/qt.py:
1708         (QtPort._generate_all_test_configurations):
1709         * Scripts/webkitpy/layout_tests/port/test.py:
1710         (TestPort.all_test_configurations):
1711         (TestPort._all_build_types):
1712         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1713         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1714         (BuildCoverageExtrapolatorTest.test_extrapolate):
1715         (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
1716         (GardeningExpectationsUpdaterTest.test_add_new_expectation):
1717         (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
1718         (GardeningExpectationsUpdaterTest.test_pass_expectation):
1719         (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
1720         (GardeningExpectationsUpdaterTest.test_spurious_updates):
1721
1722 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
1723
1724         _runtime_feature_list isn't supported on Apple Mac DRT
1725         https://bugs.webkit.org/show_bug.cgi?id=80906
1726
1727         Reviewed by Eric Seidel.
1728
1729         It looks like this feature is actually only supported on the Win
1730         DRT port, so this patch reworks the code to make that clearer
1731         and reduce unnecessary overrides.
1732
1733         * Scripts/webkitpy/layout_tests/port/efl.py:
1734         (EflPort._path_to_webcore_library):
1735         * Scripts/webkitpy/layout_tests/port/gtk.py:
1736         (GtkPort._path_to_webcore_library):
1737         * Scripts/webkitpy/layout_tests/port/qt.py:
1738         (QtPort._skipped_file_search_paths):
1739         * Scripts/webkitpy/layout_tests/port/webkit.py:
1740         (WebKitPort._runtime_feature_list):
1741         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1742         (TestWebKitPort.__init__):
1743         (TestWebKitPort.all_test_configurations):
1744         (test_skipped_directories_for_features):
1745         * Scripts/webkitpy/layout_tests/port/win.py:
1746         (WinPort):
1747         (WinPort._runtime_feature_list):
1748         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1749         (WinPortTest.test_operating_system):
1750         (WinPortTest):
1751         (WinPortTest.test_runtime_feature_list):
1752
1753 2012-03-12  Peter Beverloo  <peter@chromium.org>
1754
1755         [Chromium] Temporary build-fix for the Android bot
1756         https://bugs.webkit.org/show_bug.cgi?id=80862
1757
1758         Reviewed by Adam Barth.
1759
1760         Manually set the environmental variables required to compile source
1761         files through the Android NDK instead of relying on the envsetup.sh
1762         script. A proper fix will be landed to Chromium ASAP, and following
1763         a Chromium roll into WebKit this code will be removed.
1764
1765         * Scripts/webkitdirs.pm:
1766         (buildChromiumMakefile):
1767
1768 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1769
1770         [Qt] Use right construct to detect config_test_gccdepends
1771
1772         Reviewed by Andreas Kling.
1773
1774         * qmake/mkspecs/features/default_pre.prf:
1775
1776 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1777
1778         [Qt] Expose location of WebKit's bin and imports dir through module file
1779
1780         Reviewed by Andreas Kling.
1781
1782         * qmake/qt_webkit.pri:
1783
1784 2012-03-12  Andras Becsi  <andras.becsi@nokia.com>
1785
1786         [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
1787         https://bugs.webkit.org/show_bug.cgi?id=80832
1788
1789         Reviewed by Tor Arne Vestbø.
1790
1791         Add a basic scroll indicator component to MiniBrowser so that it
1792         behaves similar to the ScrollDecorator QML component.
1793
1794         * MiniBrowser/qt/MiniBrowser.qrc:
1795         * MiniBrowser/qt/qml/BrowserWindow.qml:
1796         * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
1797
1798 2012-03-12  C Anthony Risinger  <anthony@xtfx.me>
1799
1800         [GTK] r110296 included an extra $ in @$(AM_V_GEN)
1801         https://bugs.webkit.org/show_bug.cgi?id=80809
1802
1803         Reviewed by Philippe Normand.
1804
1805         * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
1806
1807 2012-03-12  Ming Xie  <mxie@rim.com>
1808
1809         [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
1810         https://bugs.webkit.org/show_bug.cgi?id=80812
1811
1812         Reviewed by Rob Buis.
1813
1814         * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
1815         * Scripts/webkitdirs.pm:
1816         (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
1817
1818
1819 2012-03-12  Simon Hausmann  <simon.hausmann@nokia.com>
1820
1821         [Qt] Fix build with newer Qt 5.
1822
1823         Reviewed by Tor Arne Vestbø.
1824
1825         Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
1826         renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
1827         we should disable -Werror.
1828
1829         Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
1830         implicit load was removed recently.
1831
1832         * qmake/mkspecs/features/default_pre.prf:
1833         * qmake/mkspecs/features/unix/default_post.prf:
1834
1835 2012-03-11  Maciej Stachowiak  <mjs@apple.com>
1836
1837         Add --instruments option to sunspider to profile with Instruments
1838         https://bugs.webkit.org/show_bug.cgi?id=80783
1839
1840         Reviewed by Filip Pizlo.
1841
1842         * Scripts/run-sunspider:
1843
1844 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1845
1846         [Qt] [WK2] Support threaded renderer in WK2
1847         https://bugs.webkit.org/show_bug.cgi?id=76661
1848
1849         Remove disabling of threaded rendering.
1850
1851         Reviewed by Noam Rosenthal.
1852
1853         * MiniBrowser/qt/main.cpp:
1854         (main):
1855
1856 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
1857
1858         [WK2] run-perf-tests should be able to run with WTR
1859         https://bugs.webkit.org/show_bug.cgi?id=80042
1860
1861         Reviewed by Martin Robinson.
1862
1863         Add an option to PerfTestRunner to use WebKitTestRunner instead of
1864         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
1865         to avoid timing out when running performance tests.
1866
1867         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1868         (PerfTestsRunner._parse_args):
1869         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1870         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
1871         to true.
1872         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
1873         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
1874         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1875         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
1876         publicly accessible.
1877         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1878         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
1879         is required.
1880         * WebKitTestRunner/TestController.cpp:
1881         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
1882         to true.
1883         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
1884         if '--no-timeout' option is present.
1885         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
1886         value, or -1.0 if timeout should not occur.
1887         * WebKitTestRunner/TestController.h:
1888         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
1889         publicly accessible.
1890         * WebKitTestRunner/TestInvocation.cpp:
1891         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
1892         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
1893         Waiting for final message should not time out if not necessary.
1894         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1895         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
1896         * WebKitTestRunner/qt/TestControllerQt.cpp:
1897         (WTR::TestController::platformRunUntil): Ditto.
1898         * WebKitTestRunner/mac/TestControllerMac.mm:
1899         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
1900         is missing.
1901         * WebKitTestRunner/win/TestControllerWin.cpp:
1902         (WTR::TestController::platformRunUntil): Ditto.
1903
1904 2012-03-09  Jon Lee  <jonlee@apple.com>
1905
1906         Rename NotificationPresenter to NotificationClient
1907         https://bugs.webkit.org/show_bug.cgi?id=80488
1908         <rdar://problem/10965558>
1909
1910         Reviewed by Kentaro Hara.
1911
1912         Refactor to use renamed WebCore::NotificationClient.
1913         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1914         (DRTDesktopNotificationPresenter::checkNotificationPermission):
1915
1916 2012-03-07  James Robinson  <jamesr@chromium.org>
1917
1918         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
1919         https://bugs.webkit.org/show_bug.cgi?id=80523
1920
1921         Reviewed by Darin Fisher.
1922
1923         * DumpRenderTree/chromium/WebViewHost.cpp:
1924         (WebViewHost::createGraphicsContext3D):
1925         * DumpRenderTree/chromium/WebViewHost.h:
1926         (WebViewHost):
1927
1928 2012-03-09  Eric Seidel  <eric@webkit.org>
1929
1930         build-webkit should build Source/WTF on Mac
1931         https://bugs.webkit.org/show_bug.cgi?id=80728
1932
1933         Reviewed by Adam Barth.
1934
1935         We'll add other ports to this list in future commits.
1936
1937         * Scripts/build-webkit:
1938
1939 2012-03-09  Jon Lee  <jonlee@apple.com>
1940
1941         Add support for ENABLE(LEGACY_NOTIFICATIONS)
1942         https://bugs.webkit.org/show_bug.cgi?id=80497
1943
1944         Reviewed by Adam Barth.
1945
1946         Prep for b80472: Update API for Web Notifications
1947         * Scripts/build-webkit:
1948         * qmake/mkspecs/features/features.prf:
1949
1950 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
1951
1952         Bash scripts should support LF endings only
1953         https://bugs.webkit.org/show_bug.cgi?id=79509
1954
1955         Reviewed by David Kilzer.
1956
1957         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
1958         * EWSTools/start-queue.sh: Added property svn:eol-style.
1959         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
1960         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
1961         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
1962         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
1963
1964 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
1965
1966         [BUILD] use detected python to run generate-gtkdoc
1967         https://bugs.webkit.org/show_bug.cgi?id=80695
1968
1969         Reviewed by Gustavo Noronha Silva.
1970
1971         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
1972
1973 2012-03-09  Nat Duca  <nduca@chromium.org>
1974
1975         Make check-webkit-style complain about "no new tests" lines in changelogs
1976         https://bugs.webkit.org/show_bug.cgi?id=80582
1977
1978         Reviewed by David Levin.
1979
1980         * Scripts/webkitpy/style/checkers/changelog.py:
1981         (ChangeLogChecker.check_entry):
1982         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1983         (ChangeLogCheckerTest.test_no_new_tests):
1984
1985 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1986
1987         Unreviewed, rolling out r110250.
1988         http://trac.webkit.org/changeset/110250
1989         https://bugs.webkit.org/show_bug.cgi?id=80682
1990
1991         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
1992         qt-linux at all. (Requested by Ossy on #webkit).
1993
1994         * Scripts/old-run-webkit-tests:
1995         * Scripts/webkitpy/layout_tests/port/qt.py:
1996         (QtPort):
1997         (QtPort.determine_full_port_name):
1998         (QtPort.baseline_search_path):
1999         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2000         (QtPortTest):
2001         (QtPortTest._assert_search_path):
2002         (QtPortTest.test_baseline_search_path):
2003
2004 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2005
2006         [Qt] Use Qt's module system for install rules and depending on QtWebKit
2007
2008         Instead of rolling our own install rules we now use the same approach as
2009         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
2010
2011         This ensures that we follow the same semantics as the rest of Qt on
2012         what sort of config options are enabled by default (create_cmake eg.).
2013         It also allows us to use QT += webkit instead of the workaround we had
2014         with CONFIG += qtwebkit.
2015
2016         We do however force Qt to always treat our build as a non-developer build,
2017         so the libraries will end up in the WebKit lib directory instead of the
2018         qtbase directory (as with a normal developer-build). This allows us to
2019         keep the webkit-build self-contained. If Qt is a developer build we still
2020         copy the module file manually to Qt, so that you don't have to install
2021         WebKit to make it available.
2022
2023         For non-developer builds of Qt, it is still possible to use the built
2024         WebKit libraries without having to install them, by having the variable
2025         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
2026         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
2027
2028         https://bugs.webkit.org/show_bug.cgi?id=80590
2029
2030         Reviewed by Simon Hausmann.
2031
2032         * DumpRenderTree/qt/DumpRenderTree.pro:
2033         * MiniBrowser/qt/BrowserWindow.cpp:
2034         * MiniBrowser/qt/MiniBrowser.pro:
2035         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2036         * MiniBrowser/qt/UrlLoader.cpp:
2037         * QtTestBrowser/QtTestBrowser.pro:
2038         * Tools.pro:
2039         * WebKitTestRunner/InjectedBundle/Target.pri:
2040         * WebKitTestRunner/Target.pri:
2041         * qmake/mkspecs/features/default_post.prf:
2042         * qmake/mkspecs/features/default_pre.prf:
2043         * qmake/mkspecs/features/functions.prf:
2044         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
2045         * qmake/mkspecs/features/qtwebkit.prf:
2046         * qmake/mkspecs/features/rpath.prf:
2047         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
2048         * qmake/qt_webkit.pri: Added.
2049
2050 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
2051
2052         Unreviewed. Update my email.
2053
2054         * Scripts/webkitpy/common/config/committers.py:
2055
2056 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2057
2058         Recent changes to chromium.py etc. broke chromium_android.py
2059         https://bugs.webkit.org/show_bug.cgi?id=80623
2060
2061         Reviewed by Dirk Pranke.
2062
2063         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2064         (ChromiumAndroidDriver.__init__):
2065         (ChromiumAndroidDriver._start):
2066
2067 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2068
2069         [Chromium] Exception running reftest with --no-pixel-tests
2070         https://bugs.webkit.org/show_bug.cgi?id=80642
2071
2072         Reviewed by Dirk Pranke.
2073
2074         * Scripts/webkitpy/layout_tests/port/chromium.py:
2075         (ChromiumDriver.__init__):
2076         (ChromiumDriver._wrapper_options):
2077
2078 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
2079
2080         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
2081         https://bugs.webkit.org/show_bug.cgi?id=72489
2082
2083         Reviewed by Dirk Pranke.
2084
2085         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
2086         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
2087         --platform will override the platform name and then we'll use it.
2088
2089         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
2090         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
2091         override it in the end.
2092
2093         * Scripts/old-run-webkit-tests:
2094         * Scripts/webkitpy/layout_tests/port/qt.py:
2095         (QtPort):
2096         (QtPort.determine_full_port_name):
2097         (QtPort.baseline_search_path):
2098         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2099         (QtPortTest):
2100         (QtPortTest._assert_search_path):
2101         (QtPortTest.test_baseline_search_path):
2102
2103 2012-03-08  Beth Dakin  <bdakin@apple.com>
2104
2105         https://bugs.webkit.org/show_bug.cgi?id=80463
2106         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
2107         -and corresponding-
2108         <rdar://problem/10970221>
2109
2110         Reviewed by Dan Bernstein.
2111
2112         New test!
2113         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2114         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
2115         (TestWebKitAPI):
2116         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2117         (TestWebKitAPI::setPageLoaderClient):
2118         (TestWebKitAPI::TEST):
2119         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
2120         (TestWebKitAPI):
2121         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
2122         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
2123         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
2124         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
2125
2126 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2127
2128         [Qt] Prospective Windows build fix
2129
2130         Don't assume that windows-builds will always run inside a cmd.exe shell.
2131
2132         * qmake/mkspecs/features/default_pre.prf:
2133
2134 2012-03-08  Dan Bernstein  <mitz@apple.com>
2135
2136         <rdar://problem/10981173> Dashboard regions should not be in device space
2137
2138         Reviewed by John Sullivan.
2139
2140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2141         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
2142         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
2143         (TestWebKitAPI):
2144         (TestWebKitAPI::TEST):
2145
2146 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
2147
2148         webkit-patch works oddly on local Git branches
2149         https://bugs.webkit.org/show_bug.cgi?id=76958
2150
2151         Reviewed by Ojan Vafai.
2152
2153         This change makes the '-g' flag to webkit-patch behave a
2154         little more consistently with git. The 'HEAD..' syntax
2155         is changed to 'HEAD....' (four dots), so as to not
2156         collide with the underlying git syntax. We also generalize
2157         the syntax to support any refname, so 'foo....' means
2158         diff against foo and include working copy changes.
2159
2160         This change also adds the 'UPSTREAM' shortcut to identify
2161         whatever the current upstream/tracking branch is; this is
2162         useful if you have multiple local branches stacked up.
2163
2164         * Scripts/webkitpy/common/checkout/scm/git.py:
2165         (Git._branch_from_ref):
2166         (Git):
2167         (Git._current_branch):
2168         (Git._upstream_branch):
2169         (Git.merge_base):
2170         (Git._commit_on_branch):
2171         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2172         (GitSVNTest._second_local_commit):
2173         (GitSVNTest._two_local_commits):
2174         (GitSVNTest.test_commit_with_message_git_commit_range):
2175         (GitSVNTest.test_upstream_branch):
2176         (GitSVNTest.test_create_patch_working_copy_only):
2177         (GitSVNTest.test_changed_files_local_plus_working_copy):
2178         (GitSVNTest.test_changed_files_working_copy_only):
2179         (GitSVNTest.test_changed_files_upstream):
2180         * Scripts/webkitpy/tool/steps/options.py:
2181         (Options):
2182
2183 2012-03-08  John Sullivan  <sullivan@apple.com>
2184
2185         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
2186
2187         Reviewed by Eric Carlson.
2188
2189         * Scripts/extract-localizable-strings:
2190         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
2191         with NSLocalized. Also improved an error message to include the troublesome token.
2192
2193 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2194
2195         Unreviewed, rolling out r110115.
2196         http://trac.webkit.org/changeset/110115
2197         https://bugs.webkit.org/show_bug.cgi?id=80581
2198
2199         broke test-webkitpy (Requested by philn-tp on #webkit).
2200
2201         * Scripts/old-run-webkit-tests:
2202         * Scripts/webkitpy/layout_tests/port/qt.py:
2203         (QtPort):
2204         (QtPort.determine_full_port_name):
2205         (QtPort.baseline_search_path):
2206
2207 2012-03-08  Kentaro Hara  <haraken@chromium.org>
2208
2209         Unreviewed. Added myself to watchlist.
2210
2211         * Scripts/webkitpy/common/config/watchlist:
2212
2213 2012-03-07  Jessie Berlin  <jberlin@apple.com>
2214
2215         Clean Windows build fails after r110033
2216         https://bugs.webkit.org/show_bug.cgi?id=80553
2217
2218         Rubber-stamped by Jon Honeycutt and Eric Seidel.
2219
2220         Add the new JavaScriptCore include directory to some more vsprops files.
2221
2222         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2223         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2224         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2225
2226 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
2227
2228         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
2229         https://bugs.webkit.org/show_bug.cgi?id=72489
2230
2231         Reviewed by Dirk Pranke.
2232
2233         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
2234         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
2235         --platform will override the platform name and then we'll use it.
2236
2237         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
2238         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
2239         override it in the end.
2240
2241         * Scripts/old-run-webkit-tests:
2242         * Scripts/webkitpy/layout_tests/port/qt.py:
2243         (QtPort):
2244         (QtPort.determine_full_port_name):
2245         (QtPort.baseline_search_path):
2246
2247 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
2248
2249         [Qt][WK2] MiniBrowser on desktop does not react to click events
2250         https://bugs.webkit.org/show_bug.cgi?id=80314
2251
2252         Reviewed by Kenneth Rohde Christiansen.
2253
2254         Do not enable touch mocking on desktop mode.
2255
2256         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2257         (MiniBrowserApplication::handleUserOptions):
2258
2259 2012-03-07  Ojan Vafai  <ojan@chromium.org>
2260
2261         Automatically move to the next test after rebaseline in the results view
2262         https://bugs.webkit.org/show_bug.cgi?id=80527
2263
2264         Reviewed by Dimitri Glazkov.
2265
2266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2268
2269 2012-03-07  Ojan Vafai  <ojan@chromium.org>
2270
2271         garden-o-matic rebaseline is broken for ports that don't have a fallback port
2272         https://bugs.webkit.org/show_bug.cgi?id=80526
2273
2274         Reviewed by Adam Barth.
2275
2276         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
2277         since there is no "None" port.
2278
2279         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2280         (GardeningHTTPRequestHandler.rebaseline):
2281         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2282         (GardeningServerTest.test_rebaseline):
2283
2284 2012-03-07  James Robinson  <jamesr@chromium.org>
2285
2286         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
2287         https://bugs.webkit.org/show_bug.cgi?id=80521
2288
2289         Reviewed by Kenneth Russell.
2290
2291         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
2292         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
2293         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
2294
2295         Covered by platform/chromium/compositing/plugins/*
2296
2297         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2298         (TestWebPlugin::TestWebPlugin):
2299         (TestWebPlugin::initialize):
2300         (TestWebPlugin::updateGeometry):
2301         (TestWebPlugin::initScene):
2302         (TestWebPlugin::destroyScene):
2303         * DumpRenderTree/chromium/TestWebPlugin.h:
2304         (TestWebPlugin):
2305         * DumpRenderTree/chromium/WebViewHost.cpp:
2306         (WebViewHost::createPlugin):
2307
2308 2012-03-07  Philippe Normand  <pnormand@igalia.com>
2309
2310         [GTK] remove webkitpy dependency in run-gtk-tests
2311         https://bugs.webkit.org/show_bug.cgi?id=80500
2312
2313         Reviewed by Martin Robinson.
2314
2315         Replace Executive calls with bare subprocess calls.
2316
2317         * Scripts/run-gtk-tests:
2318         (TestRunner):
2319         (TestRunner._lookup_atspi2_binary):
2320         (TestRunner.run):
2321         (TestRunner.run.run_for_real):
2322
2323 2012-03-07  Philippe Normand  <pnormand@igalia.com>
2324
2325         Unreviewed, GTK build fix after r110059.
2326
2327         * Scripts/run-gtk-tests:
2328         (TestRunner._check_if_tests_have_timed_out):
2329         (TestRunner.run.run_tests):
2330         (TestRunner):
2331
2332 2012-03-07  Philippe Normand  <pnormand@igalia.com>
2333
2334         [GTK] race condition in run-gtk-tests
2335         https://bugs.webkit.org/show_bug.cgi?id=80495
2336
2337         Reviewed by Martin Robinson.
2338
2339         Refactored the script to wait the a11y dbus service becomes
2340         available before starting the tests.
2341
2342         * Scripts/run-gtk-tests:
2343         (TestRunner._lookup_atspi2_binary):
2344         (TestRunner):
2345         (TestRunner._wait_dbus_service_and_run):
2346         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
2347         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
2348         (TestRunner.run):
2349         (TestRunner.run.bailout):
2350         (TestRunner.run.run_for_real):
2351
2352 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
2353
2354         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
2355         https://bugs.webkit.org/show_bug.cgi?id=80425
2356
2357         Reviewed by Simon Hausmann.
2358
2359         Set startScreenPos in mock touch point
2360
2361         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2362         (MiniBrowserApplication::notify):
2363         * MiniBrowser/qt/MiniBrowserApplication.h:
2364         (MiniBrowserApplication):
2365
2366 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
2367
2368         [Qt] Windows build fix.
2369
2370         Reviewed by Tor Arne Vestbø.
2371
2372         Pass the -j parameter only to "make", not "nmake".
2373
2374         * Scripts/webkitdirs.pm:
2375         (buildQMakeProjects):
2376
2377 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
2378
2379         [Qt] Fix compilation without QtQuick1
2380         https://bugs.webkit.org/show_bug.cgi?id=80503
2381
2382         Reviewed by Tor Arne Vestbø.
2383
2384         Introduce HAVE_QQUICK1 as feature and added haveQtModule
2385         as convenience function.
2386
2387         * qmake/mkspecs/features/features.prf:
2388         * qmake/mkspecs/features/functions.prf:
2389
2390 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
2391
2392         [Qt] Add qmake config tests for JPEG and PNG library
2393         https://bugs.webkit.org/show_bug.cgi?id=80398
2394
2395         Add JPEG and PNG library tests to config.tests and
2396         add error() abort to WebCore.pri if tests don't work.
2397
2398         Reviewed by Tor Arne Vestbø.
2399
2400         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
2401         (main):
2402         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
2403         * qmake/config.tests/libpng/libpng.cpp: Added.
2404         (main):
2405         * qmake/config.tests/libpng/libpng.pro: Added.
2406         * qmake/sync.profile:
2407
2408 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
2409
2410         [EFL] Build warning: Fix warn_unused_result warnings.
2411         https://bugs.webkit.org/show_bug.cgi?id=79194
2412
2413         Reviewed by Filip Pizlo.
2414
2415         Fixed build warning which is getting generated when not using return
2416         value of a fuction, especially declared with warn_unused_result
2417         attribute.
2418
2419         * DumpRenderTree/efl/ImageDiff.cpp:
2420         (printImage):
2421
2422 2012-03-07  Kangil Han  <kangil.han@samsung.com>
2423
2424         [DRT] Remove PlainTextController implementations.
2425         https://bugs.webkit.org/show_bug.cgi?id=79959
2426
2427         Reviewed by Hajime Morita.
2428
2429         PlainTextController usages in existing tests have been
2430         replaced by internals API by bug 78570.
2431         So this patch will remove PlainTextController implementations
2432         to avoid further usage in new tests.
2433
2434         * DumpRenderTree/DumpRenderTree.gypi:
2435         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2436         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
2437         * DumpRenderTree/chromium/PlainTextController.h: Removed.
2438         * DumpRenderTree/chromium/TestShell.cpp:
2439         (TestShell::TestShell):
2440         (TestShell::bindJSObjectsToWindow):
2441         * DumpRenderTree/chromium/TestShell.h:
2442         (TestShell):
2443         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2444         (webViewWindowObjectCleared):
2445         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
2446         * DumpRenderTree/gtk/PlainTextController.h: Removed.
2447         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2448         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2449         * DumpRenderTree/mac/PlainTextController.h: Removed.
2450         * DumpRenderTree/mac/PlainTextController.mm: Removed.
2451         * DumpRenderTree/qt/DumpRenderTree.pro:
2452         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2453         (WebCore::DumpRenderTree::DumpRenderTree):
2454         (WebCore::DumpRenderTree::initJSObjects):
2455         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2456         (DumpRenderTree):
2457         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
2458         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
2459         * GNUmakefile.am:
2460
2461 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2462
2463         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
2464         https://bugs.webkit.org/show_bug.cgi?id=80137
2465
2466         Reviewed by Eric Seidel.
2467
2468         Adds implementation LayoutTestController's setPopupBlockingEnabled.
2469         To pass popup-blocking-click-in-iframe.html EventSender should not
2470         repeat click events in idler's function. EventSender allows to
2471         asynchronously send click event through ecore_idler_add.
2472         This event will be called repeatedly as long as it return true.
2473         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
2474
2475         * DumpRenderTree/efl/EventSender.cpp:
2476         (sendMouseEvent): Changed return value from bool to void because it always returns true.
2477         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
2478         (mouseDownCallback): Remove unnecessary checking of return value.
2479         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2480         (LayoutTestController::setPopupBlockingEnabled):
2481
2482 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
2483
2484         rebaseline_chromium_webkit_tests is obsolete and should be removed
2485         https://bugs.webkit.org/show_bug.cgi?id=80347
2486
2487         Reviewed by Tony Chang.
2488
2489         * Scripts/rebaseline-chromium-webkit-tests: Removed.
2490         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
2491         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
2492
2493 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
2494
2495         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
2496         https://bugs.webkit.org/show_bug.cgi?id=80468
2497
2498         Unreviewed, build fix.
2499
2500         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
2501
2502         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2503         (Lighttpd._prepare_config):
2504
2505 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
2506
2507         remove chromium_gpu ports
2508         https://bugs.webkit.org/show_bug.cgi?id=80345
2509
2510         Reviewed by Ojan Vafai.
2511
2512         This change leaves in the 'graphics_type' distinction in the
2513         test_expectations; removing that will require more updates and a
2514         pass over test_expectations.txt, so I'm separating that out.
2515
2516         * Scripts/webkitpy/layout_tests/port/builders.py:
2517         * Scripts/webkitpy/layout_tests/port/chromium.py:
2518         (ChromiumPort):
2519         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
2520         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
2521         * Scripts/webkitpy/layout_tests/port/factory.py:
2522         (PortFactory):
2523         (PortFactory.get):
2524         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2525         (FactoryTest.test_qt):
2526         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2527         (TestRebaseline.test_rebaseline_expectations):
2528
2529 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
2530
2531         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
2532         https://bugs.webkit.org/show_bug.cgi?id=80282
2533
2534         Reviewed by Antonio Gomes.
2535
2536         Remove transitive library dependencies; they are especially
2537         dangerous when one ends up linking against WTF, JSC and then WTF
2538         again, since some symbols will not be defined.
2539
2540         Passing --no-copy-dt-needed-entries and --as-needed to the linker
2541         (which some recent Linux distros do by default) makes the issue
2542         even more evident.
2543
2544         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
2545         as the other libraries have the needed symbols. Explicitly link
2546         against fontconfig.
2547
2548 2012-03-06  Dean Jackson  <dino@apple.com>
2549
2550         filter-build-webkit needs more filters
2551         https://bugs.webkit.org/show_bug.cgi?id=80440
2552
2553         Reviewed by Joseph Pecoraro.
2554
2555         Added as many missing filters as I could find for Apple
2556         builds. Plus a few minor style updates.
2557
2558         * Scripts/filter-build-webkit:
2559         (printLine):
2560
2561 2012-03-06  Ojan Vafai  <ojan@chromium.org>
2562
2563         Copying old baselines throws an error if the new directory doesn't exist
2564         https://bugs.webkit.org/show_bug.cgi?id=80443
2565
2566         Reviewed by Adam Barth.
2567
2568         Existing tests cover the new code with the fix to filesystem_mock.
2569
2570         * Scripts/webkitpy/common/system/filesystem_mock.py:
2571         (MockFileSystem.copyfile):
2572         Fix the mock to better match python's copyfile semantics.
2573
2574         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2575         (Rebaseliner._create_html_baseline_files):
2576         * Scripts/webkitpy/tool/commands/rebaseline.py:
2577         (RebaselineTest._copy_existing_baseline):
2578
2579 2012-03-05  Ojan Vafai  <ojan@chromium.org>
2580
2581         Add a mechanism to rebaseline new ports
2582         https://bugs.webkit.org/show_bug.cgi?id=80355
2583
2584         Reviewed by Adam Barth.
2585
2586         For a test that's only failing on a new port, we want
2587         to first copy the existing result into the location for the
2588         port it's replacing in order to not break that port.
2589
2590         For example, bringing up the chromium-lion port, if we just
2591         stick the results in the chromium-mac directory, the snow leopard
2592         will start failing. Instead, we first copy the existing result
2593         to the chromium-mac-snowleopard directory.
2594
2595         * Scripts/webkitpy/layout_tests/port/builders.py:
2596         (builder_path_for_port_name):
2597         (fallback_port_name_for_new_port):
2598         * Scripts/webkitpy/tool/commands/rebaseline.py:
2599         (RebaselineTest):
2600         (RebaselineTest._copy_existing_baseline):
2601         (RebaselineTest._rebaseline_test):
2602         (RebaselineTest.execute):
2603         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2604         (TestRebaseline.test_rebaseline_test):
2605         (TestRebaseline):
2606         (TestRebaseline.test_rebaseline_and_copy_test):
2607         (test_rebaseline_and_copy_test_no_existing_result):
2608         (test_rebaseline_and_copy_test_with_lion_result):
2609         (test_rebaseline_and_copy_no_overwrite_test):
2610         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2611         (GardeningHTTPRequestHandler.rebaseline):
2612         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2613         (GardeningServerTest.test_rebaseline):
2614         (GardeningServerTest):
2615         (GardeningServerTest.test_rebaseline_new_port):
2616
2617 2012-03-06  Beth Dakin  <bdakin@apple.com>
2618
2619         https://bugs.webkit.org/show_bug.cgi?id=80351
2620         InlineTextBox is using the wrong origin when calling 
2621         addRelevantRepaintedObject
2622         -and corresponding-
2623         <rdar://problem/10970221>
2624
2625         Reviewed by Sam Weinig.
2626
2627         This test has actually been broken since revision 109273. This change makes 
2628         the test pass again, and it makes it specifically exercise the fix for this 
2629         bug.
2630         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2631         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2632         (TestWebKitAPI::TEST):
2633
2634         Adjust comments in the other tests to reflect the API changes from 109273.
2635         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2636         (TestWebKitAPI::TEST):
2637         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
2638         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
2639         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
2640         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
2641         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
2642         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
2643         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
2644
2645 2012-03-06  Hans Wennborg  <hans@chromium.org>
2646
2647         Speech JavaScript API: add SpeechRecognitionError
2648         https://bugs.webkit.org/show_bug.cgi?id=80410
2649
2650         Chromium: enable the runtime flag for scripted speech so we can run
2651         the layout tests for it.
2652
2653         Reviewed by Adam Barth.
2654
2655         * DumpRenderTree/chromium/TestShell.cpp:
2656         (TestShell::TestShell):
2657
2658 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
2659
2660         Enable universal newlines in chromium android layout test runner
2661         https://bugs.webkit.org/show_bug.cgi?id=80418
2662
2663         Reviewed by Adam Barth.
2664
2665         The Chromium Android layout test runner uses the 'adb' program to
2666         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
2667         output lines from the test runner, while the test expectation files are
2668         written with LF ('\n') delimiters. This causes the results to have
2669         spurious whitespace differences, making them more difficult to
2670         interpret.
2671
2672         The fix is to enable universal newlines for the DumpRenderTree pipe,
2673         causing the output to only contain LF newlines like on other platforms.
2674
2675         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2676         (ChromiumAndroidDriver._start):
2677
2678 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2679
2680         [Qt] Revert r109900, it was completly busted
2681
2682         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
2683
2684         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
2685         of manual define checks.
2686
2687         Reviewed by Ossy.
2688
2689         * DumpRenderTree/qt/DumpRenderTree.pro:
2690         * QtTestBrowser/QtTestBrowser.pro:
2691         * WebKitTestRunner/InjectedBundle/Target.pri:
2692         * qmake/mkspecs/features/features.prf:
2693
2694 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2695
2696         [Qt] Use config test to determine if the compiler supports -MD
2697
2698         We used to assume that unix systems building against Qt5 would have
2699         a compiler that supported -MD. Although this was usually the case,
2700         we failed to take into account broken tools for distributed builds
2701         (e.g. teambuilder or icecream) which would end up producing .d files
2702         in the root of the build dir instead of along-side the object file.
2703
2704         Now that we use a config-test to determine the support, we'll capture
2705         those cases, unless distributed builds are enabled after the initial
2706         build-webkit run.
2707
2708         Reviewed by Csaba Osztrogonác.
2709
2710         * Tools.pro:
2711         * qmake/config.tests/gccdepends/empty.cpp: Added.
2712         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
2713         * qmake/mkspecs/features/default_pre.prf:
2714         * qmake/mkspecs/features/features.prf:
2715         * qmake/mkspecs/features/unix/default_pre.prf:
2716         * qmake/sync.profile:
2717
2718 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2719
2720         REGRESSION(r109294): It broke the unittest of master.cfg
2721         https://bugs.webkit.org/show_bug.cgi?id=80253
2722
2723         Reviewed by Tor Arne Vestbø.
2724
2725         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
2726         (BuildBotConfigLoader._create_mock_passwords_dict):
2727         (BuildBotConfigLoader._mock_open):
2728         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
2729         (BuildBotConfigLoader.load_config):
2730
2731 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2732
2733         Qt API test buildstep throws exception after buildmaster update
2734         https://bugs.webkit.org/show_bug.cgi?id=80249
2735
2736         This patch based on Peter Gal's work.
2737
2738         Reviewed by Csaba Osztrogonác.
2739
2740         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2741         (RunQtAPITests):
2742         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
2743
2744 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2745
2746         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
2747
2748         Reviewed by Simon Hausmann.
2749         Reviewed by Ossy.
2750
2751         * DumpRenderTree/qt/DumpRenderTree.pro:
2752         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
2753         (WebKit::initializeTestFonts):
2754         * QtTestBrowser/QtTestBrowser.pro:
2755         * WebKitTestRunner/InjectedBundle/Target.pri:
2756         * qmake/mkspecs/features/features.prf:
2757
2758 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2759
2760         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
2761
2762         Reviewed by Ossy.
2763
2764         * qmake/mkspecs/features/default_post.prf:
2765
2766 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2767
2768         [Qt] Make sure clean builds are followed by make qmake && make if needed
2769
2770         On non-GNUmake systems we have to run make qmake so that the generated
2771         sources are generated before we run qmake on the target pro files. This
2772         is achieved by using the 'incremental' target.
2773
2774         Reviewed by Ossy.
2775
2776         * Scripts/webkitdirs.pm:
2777         (buildQMakeProjects):
2778
2779 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
2780
2781         DumpRenderTree should support preciseTime()
2782         https://bugs.webkit.org/show_bug.cgi?id=80397
2783
2784         Reviewed by Gavin Barraclough.
2785
2786         * DumpRenderTree/LayoutTestController.cpp:
2787         (preciseTimeCallback):
2788         (LayoutTestController::staticFunctions):
2789
2790 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
2791
2792         Unreviewed, rolling out r109887.
2793         http://trac.webkit.org/changeset/109887
2794         https://bugs.webkit.org/show_bug.cgi?id=80402
2795
2796         It broke the build (Requested by Ossy on #webkit).
2797
2798         * DumpRenderTree/qt/DumpRenderTree.pro:
2799         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
2800         (WebKit::initializeTestFonts):
2801         * QtTestBrowser/QtTestBrowser.pro:
2802         * WebKitTestRunner/InjectedBundle/Target.pri:
2803         * qmake/mkspecs/features/features.prf:
2804
2805 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
2806
2807         Unreviewed, rolling out r109837.
2808         http://trac.webkit.org/changeset/109837
2809         https://bugs.webkit.org/show_bug.cgi?id=80399
2810
2811         breaks Mac Productions builds, too late to try and fix it
2812         tonight (Requested by eseidel on #webkit).
2813
2814         * Scripts/build-webkit:
2815
2816 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2817
2818         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
2819
2820         Reviewed by Simon Hausmann.
2821
2822         * DumpRenderTree/qt/DumpRenderTree.pro:
2823         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
2824         (WebKit::initializeTestFonts):
2825         * QtTestBrowser/QtTestBrowser.pro:
2826         * WebKitTestRunner/InjectedBundle/Target.pri:
2827         * qmake/mkspecs/features/features.prf:
2828
2829 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2830
2831         [Qt] Create EWS to build WebKit2
2832         https://bugs.webkit.org/show_bug.cgi?id=80277
2833
2834         Reviewed by Csaba Osztrogonác.
2835
2836         * QueueStatusServer/model/queues.py:
2837         (Queue):
2838         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2839         (QtWK2EWS):
2840         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2841         (EarlyWarningSytemTest.test_builder_ewses):
2842
2843 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2844
2845         Unreviewed, rolling out r109733.
2846         http://trac.webkit.org/changeset/109733
2847         https://bugs.webkit.org/show_bug.cgi?id=80378
2848
2849         It broke Qt5 build system (Requested by Ossy on #webkit).
2850
2851         * Tools.pro:
2852         * qmake/config.tests/gccdepends/empty.cpp: Removed.
2853         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
2854         * qmake/mkspecs/features/default_pre.prf:
2855         * qmake/mkspecs/features/features.prf:
2856         * qmake/mkspecs/features/unix/default_pre.prf:
2857         * qmake/sync.profile:
2858
2859 2012-03-05  Eric Seidel  <eric@webkit.org>
2860
2861         Update JavaScriptCore files to use fully-qualified WTF include path
2862         https://bugs.webkit.org/show_bug.cgi?id=79960
2863
2864         Reviewed by Adam Barth.
2865
2866         Build WTF/WTF.xcodeproj by default on Mac.
2867
2868         * Scripts/build-webkit:
2869
2870 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
2871
2872         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
2873         https://bugs.webkit.org/show_bug.cgi?id=69590
2874
2875         Reviewed by Ryosuke Niwa.
2876
2877         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
2878         to skip the 'optimize-expectations' step.
2879
2880         * Scripts/webkitpy/tool/commands/rebaseline.py:
2881         (RebaselineExpectations.__init__):
2882         (RebaselineExpectations.execute):
2883         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2884
2885 2012-03-05  Kent Tamura  <tkent@chromium.org>
2886
2887         [Chromium] Add new popup type: PagePopup
2888         https://bugs.webkit.org/show_bug.cgi?id=80106
2889
2890         Reviewed by Darin Fisher.
2891
2892         * DumpRenderTree/chromium/WebViewHost.cpp:
2893         (WebViewHost::createPopupMenu):
2894
2895 2012-03-05  Jessie Berlin  <jberlin@apple.com>
2896
2897         Add myself as a reviewer.
2898
2899         * Scripts/webkitpy/common/config/committers.py:
2900         Also, add my IRC nick so it is easier to find and yell at me.
2901
2902 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
2903
2904         Correctly compute the positions of GestureScroll* events on
2905         Chromium.
2906         https://bugs.webkit.org/show_bug.cgi?id=80075
2907
2908         Reviewed by Adam Barth.
2909
2910         * DumpRenderTree/chromium/EventSender.cpp:
2911         (EventSender::reset):
2912         (EventSender::gestureEvent):
2913         * DumpRenderTree/chromium/EventSender.h:
2914         (EventSender):
2915
2916 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
2917
2918         flakiness dashboard doesn't display baselines for virtual tests correctly
2919         https://bugs.webkit.org/show_bug.cgi?id=80341
2920
2921         Reviewed by Ojan Vafai.
2922
2923         If the test is part of a virtual test suite, we need to look for
2924         baselines in the underlying fallback path for the actual test
2925         being run, as well as baselines for the virtual version.
2926
2927         This patch adds code to handle both branches and also pulls the
2928         mapping of the test suites up into a constant.
2929
2930         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2931         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2932         (testLookupVirtualTestSuite):
2933         (testBaseTest):
2934
2935 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2936
2937         Unreviewed, rolling out r109760.
2938         http://trac.webkit.org/changeset/109760
2939         https://bugs.webkit.org/show_bug.cgi?id=80320
2940
2941         Caused many GTK+ tests to crash (Requested by mrobinson on
2942         #webkit).
2943
2944         * gtk/jhbuild.modules:
2945
2946 2012-03-05  Charlie Reis  <creis@chromium.org>
2947
2948         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
2949         https://bugs.webkit.org/show_bug.cgi?id=80057
2950
2951         Reviewed by Darin Fisher.
2952
2953         * DumpRenderTree/chromium/WebViewHost.cpp:
2954         (WebViewHost::createView):
2955         * DumpRenderTree/chromium/WebViewHost.h:
2956         (WebViewHost):
2957
2958 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
2959
2960         [soup] Crash while loading http://www.jusco.cn
2961         https://bugs.webkit.org/show_bug.cgi?id=68238
2962
2963         Reviewed by Philippe Normand.
2964
2965         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
2966         in the jhbuild file.
2967
2968 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2969
2970         Unreviewed, rolling out r109748.
2971         http://trac.webkit.org/changeset/109748
2972         https://bugs.webkit.org/show_bug.cgi?id=80296
2973
2974         Made some tests crash, will fix and recommit (Requested by
2975         noamr on #webkit).
2976
2977         * MiniBrowser/qt/main.cpp:
2978         (main):
2979
2980 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
2981
2982         [GTK] plugins/netscape-plugin-page-cache-works.html fails
2983         https://bugs.webkit.org/show_bug.cgi?id=74409
2984
2985         Reviewed by Martin Robinson.
2986
2987         Add support for overriding the page-cache-for-plugins preference
2988         through DumpRenderTreeSupport.
2989
2990         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2991         (booleanFromValue): A helper function to convert a string to boolean.
2992         (LayoutTestController::overridePreference):
2993
2994 2012-03-05  Rob Buis  <rbuis@rim.com>
2995
2996         [BlackBerry] Update Tools/DumpRenderTree
2997         https://bugs.webkit.org/show_bug.cgi?id=80287
2998
2999         Reviewed by Antonio Gomes.
3000
3001         Update so we are sure we can build our implementation of DRT.
3002
3003         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
3004         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
3005         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
3006         (AccessibilityController::addNotificationListener): add missing hook.
3007         (AccessibilityController::removeNotificationListener): add missing hook.
3008         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3009         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
3010         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3011         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
3012         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
3013
3014 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
3015
3016         [Qt] [WK2] Support threaded renderer in WK2
3017         https://bugs.webkit.org/show_bug.cgi?id=76661
3018
3019         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
3020
3021         Reviewed by Kenneth Rohde Christiansen.
3022
3023         * MiniBrowser/qt/main.cpp:
3024         (main):
3025
3026 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
3027
3028         Unreviewed. Add myself to committer list.
3029
3030         * Scripts/webkitpy/common/config/committers.py:
3031
3032 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3033
3034         [Qt] Use config test to determine if the compiler supports -MD
3035
3036         We used to assume that unix systems building against Qt5 would have
3037         a compiler that supported -MD. Although this was usually the case,
3038         we failed to take into account broken tools for distributed builds
3039         (e.g. teambuilder or icecream) which would end up producing .d files
3040         in the root of the build dir instead of along-side the object file.
3041
3042         Now that we use a config-test to determine the support, we'll capture
3043         those cases, unless distributed builds are enabled after the initial
3044         build-webkit run.
3045
3046         Reviewed by Csaba Osztrogonác.
3047
3048         * Tools.pro:
3049         * qmake/config.tests/gccdepends/empty.cpp: Added.
3050         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
3051         * qmake/mkspecs/features/default_pre.prf:
3052         * qmake/mkspecs/features/features.prf:
3053         * qmake/mkspecs/features/unix/default_pre.prf:
3054         * qmake/sync.profile:
3055
3056 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
3057
3058         Qt API test buildstep throws exception after buildmaster update
3059         https://bugs.webkit.org/show_bug.cgi?id=80249
3060
3061         Reviewed by Zoltan Herczeg.
3062
3063         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
3064         (BuildAndTestFactory.__init__):
3065
3066 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
3067
3068         [GTK] Unit tests are noisy when run under jhbuild
3069         https://bugs.webkit.org/show_bug.cgi?id=80241
3070
3071         Reviewed by Philippe Normand.
3072
3073         Force the 'memory' backend in GSettings so that each unit
3074         test doesn't produce a warning when it's forced to fall back
3075         to the 'memory' backend.
3076
3077         * Scripts/run-gtk-tests:
3078         (TestRunner.run): Force the 'memory' backend.
3079
3080 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
3081
3082         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
3083         https://bugs.webkit.org/show_bug.cgi?id=80235
3084
3085         Reviewed by Philippe Normand.
3086
3087         * Scripts/run-gtk-tests:
3088         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
3089         inspector resources path determination is shared by all tests.
3090
3091 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
3092
3093         [GTK] REGRESSION: r108278 broke some tests that expect focus
3094         https://bugs.webkit.org/show_bug.cgi?id=79084
3095
3096         Reviewed by Philippe Normand.
3097
3098         Grab focus when dumping test results and also when sending
3099         events. During the course of testing, the WebView may lose
3100         focus and this seems to snap it back when tests demand it.
3101
3102         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3103         (dump): Grab focus.
3104         * DumpRenderTree/gtk/EventSender.cpp:
3105         (dispatchEvent): Ditto.
3106
3107 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
3108
3109         Unreviewed, Add myself to committer list.
3110         https://bugs.webkit.org/show_bug.cgi?id=80232
3111
3112         * Scripts/webkitpy/common/config/committers.py:
3113
3114 2012-03-04  Anders Carlsson  <andersca@apple.com>
3115
3116         Newer versions of clang fail to compile WebKit.
3117
3118         Fix build.
3119
3120         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3121         (descriptionOfValue):
3122         (AccessibilityUIElement::rowIndexRange):
3123         (AccessibilityUIElement::columnIndexRange):
3124         (AccessibilityUIElement::selectedTextRange):
3125         * DumpRenderTree/mac/EditingDelegate.mm:
3126         (-[DOMRange dump]):
3127         * DumpRenderTree/mac/PolicyDelegate.mm:
3128         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
3129         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3130         (-[NSError _drt_descriptionSuitableForTestResult]):
3131         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3132         (WTR::descriptionOfValue):
3133         (WTR::AccessibilityUIElement::rowIndexRange):
3134         (WTR::AccessibilityUIElement::columnIndexRange):
3135         (WTR::AccessibilityUIElement::selectedTextRange):
3136
3137 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
3138
3139         [Qt] Fix static_libs_as_shared build
3140         https://bugs.webkit.org/show_bug.cgi?id=80214
3141
3142         Reviewed by Tor Arne Vestbø.
3143
3144         * WebKitTestRunner/qt/main.cpp:
3145         (main): Set the correct environment variable for choosing the theme in the
3146         web process.
3147
3148 2012-03-03  Hans Wennborg  <hans@chromium.org>
3149
3150         Implement Speech JavaScript API
3151         https://bugs.webkit.org/show_bug.cgi?id=80019
3152
3153         Reviewed by Adam Barth.
3154
3155         Add ENABLE_SCRIPTED_SPEECH.
3156
3157         * Scripts/build-webkit:
3158         * qmake/mkspecs/features/features.prf:
3159
3160 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
3161
3162         Fix commit queue, remove duplicate entry.
3163
3164         * Scripts/webkitpy/common/config/committers.py:
3165
3166 2012-03-02  Stephen Chenney  <schenney@chromium.org>
3167
3168         Unreviewed, add myself as a committer
3169
3170         * Scripts/webkitpy/common/config/committers.py:
3171
3172 2012-03-02  Ojan Vafai  <ojan@chromium.org>
3173
3174         Add the Chromium Lion canary bot to the flakiness dashboard.
3175         * TestResultServer/static-dashboards/builders.js:
3176
3177 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
3178
3179         links for virtual tests are broken in the flakiness dashboard
3180         https://bugs.webkit.org/show_bug.cgi?id=80180
3181
3182         Reviewed by Ojan Vafai.
3183
3184         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3185         (linkHTMLToOpenWindow):
3186         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3187         (testLinkHTMLToOpenWindow): added.
3188
3189 2012-03-02  Philippe Normand  <pnormand@igalia.com>
3190
3191         [GTK] security/block-test.html baselines differ from mac
3192         https://bugs.webkit.org/show_bug.cgi?id=78343
3193
3194         Reviewed by Martin Robinson.
3195
3196         Improved the FrameLoader error heuristics to match mac behavior a
3197         bit more.
3198
3199         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3200         (pathFromSoupURI): Handle ftp urls the same as http urls.
3201         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
3202
3203 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
3204
3205         [Qt][WK2] Fix typo in patch committed in r109575
3206
3207         Unreviewed typo fix.
3208
3209         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3210         (MiniBrowserApplication::notify): Cache the position
3211         in floating point coordinates.
3212
3213 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
3214
3215         [Qt][WK2] Infinite loop on history navigation, when panning
3216         https://bugs.webkit.org/show_bug.cgi?id=79119
3217
3218         Reviewed by Simon Hausmann.
3219
3220         Make the touch mocking more robust by creating touch events
3221         directly and sending them synchronously to the browser window.
3222         If the sent touch event was not accepted we propagate the
3223         original mouse event to its target.
3224         This way we make sure we only send either a touch or a mouse
3225         event and do not end up in an infinite loop between our mocking
3226         code and the Qt5 automatic mouse event synthesizing.
3227
3228         * MiniBrowser/qt/BrowserWindow.cpp:
3229         (BrowserWindow::updateVisualMockTouchPoints):
3230         * MiniBrowser/qt/BrowserWindow.h:
3231         (BrowserWindow):
3232         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3233         (touchRectForPosition):
3234         (MiniBrowserApplication::notify):
3235         (MiniBrowserApplication::sendTouchEvent):
3236         * MiniBrowser/qt/MiniBrowserApplication.h:
3237         (MiniBrowserApplication):
3238
3239 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3240
3241         [Qt] Use 'all' as default target when debug_and_release is in effect
3242
3243         When debug_and_release is enabled, in combination with build_all,
3244         qmake will generate an aggregate makefile that calls make on both
3245         the debug and the release makefiles, but with the 'all' target.
3246
3247         In this case we can't use 'first' as the default target, as the
3248         extra targets would then not be run, so we append extra targets
3249         to 'all' instead.
3250
3251         Reviewed by Simon Hausmann.
3252
3253         * qmake/mkspecs/features/default_post.prf:
3254
3255 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3256
3257         [Qt] Make sure activeBuildConfig() returns the right config
3258
3259         Using isActiveConfig fails, as that only checks if the given
3260         argument is in CONFIG, not the order.
3261
3262         Reviewed by Simon Hausmann.
3263
3264         * qmake/mkspecs/features/functions.prf:
3265
3266 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
3267
3268         [Qt] Fix tests run with WTR not using QStyle theme
3269         https://bugs.webkit.org/show_bug.cgi?id=80147
3270
3271         Reviewed by Csaba Osztrogonác.
3272
3273         * WebKitTestRunner/qt/main.cpp:
3274         (main): Set environment variable for web process to use QStyle theme.
3275
3276 2012-03-02  Philippe Normand  <pnormand@igalia.com>
3277
3278         Unreviewed, remove debug print call.
3279
3280         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3281         (descriptionSuitableForTestResult):
3282
3283 2012-03-02  Robert Kroeger  <rjkroege@chromium.org>
3284
3285         Updated EventSender to send complete gesture events.
3286         https://bugs.webkit.org/show_bug.cgi?id=80075
3287
3288         Reviewed by Adam Barth.
3289
3290         * DumpRenderTree/chromium/EventSender.cpp:
3291         (EventSender::gestureEvent): set additional parameters in sent events.
3292
3293 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
3294
3295         WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
3296         https://bugs.webkit.org/show_bug.cgi?id=80033
3297
3298         Reviewed by Gustavo Noronha Silva.
3299
3300         GCC 4.7 no longer includes unistd.h from most of the standard C++
3301         header files, so we need to explicitly include it for getcwd().
3302
3303         * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
3304         not only on Mac, but on all Unix platforms.
3305
3306 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
3307
3308         Actually look at the args in driver_input :(.
3309
3310         Unreviewed, build fix.
3311
3312         * Scripts/webkitpy/layout_tests/port/chromium.py:
3313         (ChromiumDriver.run_test):
3314
3315 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
3316
3317         Fix typo in flag used to run gpu virtual suites.
3318
3319         Unreviewed, build fix.
3320
3321         * Scripts/webkitpy/layout_tests/port/chromium.py:
3322         (ChromiumPort.virtual_test_suites):
3323
3324 2012-03-01  Adam Barth  <abarth@webkit.org>
3325
3326         Unreviewed, rolling out r109317.
3327         http://trac.webkit.org/changeset/109317
3328
3329         Let's try watchlists again now that we're using a pure git
3330         working copy
3331
3332         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3333         (StyleQueueTask.run):
3334         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3335
3336 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
3337
3338         webkitpy: test_run_test_pause_before_testing is failing after r109482
3339         https://bugs.webkit.org/show_bug.cgi?id=80084
3340
3341         Unreviewed, build fix.
3342
3343         Fixes the test string compare to ignore the time spent running
3344         the tests.
3345
3346         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3347         (test_run_test_pause_before_testing):
3348
3349 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
3350
3351         nrwt: virtual tests aren't being run
3352         https://bugs.webkit.org/show_bug.cgi?id=80083
3353
3354         Reviewed by Eric Seidel.
3355
3356         If we tried to run all of the tests by default (and
3357         didn't specify any paths), the virtual tests weren't
3358         picked up.
3359
3360         * Scripts/webkitpy/layout_tests/port/base.py:
3361         (Port._virtual_tests):
3362         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3363         (PortTest.test_tests):
3364         * Scripts/webkitpy/layout_tests/port/test.py:
3365         (TestPort.virtual_test_suites):
3366
3367 2012-03-01  Ryosuke Niwa  <rniwa@webkit.org>
3368
3369         run-perf-tests should report the test runtime
3370         https://bugs.webkit.org/show_bug.cgi?id=80078
3371
3372         Reviewed by Hajime Morita.
3373
3374         Record and output the aggreated test run time.
3375
3376         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3377         (PerfTestsRunner._run_single_test):
3378
3379 2012-03-01  Michael Nordman  <michaeln@google.com>
3380
3381         [chromium] Use webkit_support to create session storage namespaces in DRT.
3382         https://bugs.webkit.org/show_bug.cgi?id=79933
3383
3384         Reviewed by Tony Chang.
3385
3386         * DumpRenderTree/chromium/WebViewHost.cpp:
3387         (WebViewHost::createSessionStorageNamespace):
3388
3389 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
3390
3391         nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
3392         https://bugs.webkit.org/show_bug.cgi?id=80048
3393
3394         Reviewed by Adam Barth.
3395
3396         * Scripts/webkitpy/layout_tests/port/base.py:
3397         (Port.test_isfile):
3398         (Port.test_isdir):
3399         (Port):
3400         (Port.test_exists):
3401         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3402         (PortTest.test_test_exists):
3403         (PortTest):
3404         (PortTest.test_test_isfile):
3405         (PortTest.test_test_isdir):
3406         * Scripts/webkitpy/layout_tests/port/test.py:
3407         (TestPort.virtual_test_suites):
3408         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3409         (MainTest.test_virtual):
3410
3411 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
3412
3413         [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
3414         https://bugs.webkit.org/show_bug.cgi?id=80031
3415
3416         Reviewed by Gustavo Noronha Silva.
3417
3418         Only build the libTestRunnerInjectedBundle.la convenience library when
3419         ENABLE_WEBKIT2 is defined.
3420
3421         * WebKitTestRunner/GNUmakefile.am:
3422
3423 2012-03-01  Philippe Normand  <pnormand@igalia.com>
3424
3425         Unreviewed, second attempt to fix GTK NRWT after r109242.
3426
3427         * Scripts/webkitpy/layout_tests/port/gtk.py:
3428         (GtkDriver._start):
3429
3430 2012-03-01  Philippe Normand  <pnormand@igalia.com>
3431
3432         Unreviewed, GTK NRWT build fix attempt after r109242.
3433
3434         * Scripts/webkitpy/layout_tests/port/gtk.py:
3435         (GtkDriver._start):
3436
3437 2012-03-01  Kentaro Hara  <haraken@chromium.org>
3438
3439         REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
3440         https://bugs.webkit.org/show_bug.cgi?id=80008
3441
3442         Reviewed by Adam Barth.
3443
3444         In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
3445         to "preprocess-idls.pl". This patch renames it.
3446
3447         Test: Confirm that run-bindings-tests runs.
3448
3449         * Scripts/webkitpy/bindings/main.py:
3450         (BindingsTests.generate_supplemental_dependency):
3451
3452 2012-02-29  Simon Hausmann  <simon.hausmann@nokia.com>
3453
3454         [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
3455         https://bugs.webkit.org/show_bug.cgi?id=78047
3456
3457         Reviewed by Kenneth Rohde Christiansen.
3458
3459         Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
3460         sending to the item requires the QObject::event re-implementation to dispatch to the correct
3461         event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
3462         the event handlers directly, and with the removal of our own dispatching we need to go through
3463         that code path.
3464
3465         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3466         (WTR::PlatformWebView::sendEvent):
3467         (WTR::PlatformWebView::postEvent):
3468
3469 2012-02-29  Adam Barth  <abarth@webkit.org>
3470
3471         Disable watchlist.  It's been spamming CCs.
3472
3473         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3474         (StyleQueueTask.run):
3475         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3476
3477 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
3478
3479         need to clone the gpu baselines and expectations into the new "virtual" dir
3480         https://bugs.webkit.org/show_bug.cgi?id=79956
3481
3482         Reviewed by Adam Barth.
3483
3484         * Scripts/webkitpy/layout_tests/port/chromium.py:
3485         (ChromiumPort.virtual_test_suites):
3486
3487 2012-02-29  Mark Rowe  <mrowe@apple.com>
3488
3489         Switch to using json rather than simplejson now that the master is using Python 2.7.
3490
3491         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3492         (loadBuilderConfig):
3493
3494 2012-02-29  David Levin  <levin@chromium.org>
3495
3496         [chromium] Add the ability to turn off autoresize.
3497         https://bugs.webkit.org/show_bug.cgi?id=77452
3498
3499         Reviewed by Darin Fisher.
3500
3501         * DumpRenderTree/chromium/LayoutTestController.cpp:
3502         (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
3503         (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
3504         (LayoutTestController::disableAutoResizeMode):  Ditto.
3505         * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
3506
3507 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
3508
3509         nrwt: make --print trace work with virtual tests
3510         https://bugs.webkit.org/show_bug.cgi?id=79952
3511
3512         Reviewed by Adam Barth.
3513
3514         * Scripts/webkitpy/layout_tests/views/printing.py:
3515         (Printer._print_test_trace):
3516         (Printer._print_baseline):
3517
3518 2012-02-28  Brian Weinstein  <bweinstein@apple.com>
3519
3520         WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
3521         https://bugs.webkit.org/show_bug.cgi?id=79849
3522
3523         Reviewed by Beth Dakin.
3524
3525         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3526         (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
3527
3528 2012-02-29  Lucas Forschler  <lforschler@apple.com>
3529
3530         Removed unused Apple buildslaves from the master configuration
3531         https://bugs.webkit.org/show_bug.cgi?id=79925
3532
3533         Reviewed by Stephanie Lewis.
3534
3535         * BuildSlaveSupport/build.webkit.org-config/config.json:
3536
3537 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
3538
3539         nrwt: implement simple 'virtual test suite' support
3540         https://bugs.webkit.org/show_bug.cgi?id=79737
3541
3542         Reviewed by Adam Barth.
3543
3544         Add very basic support for 'virtual test suites' to NRWT:
3545         a virtual suite is a directory that may contain new baselines,
3546         contains a pointer to a "base" directory of tests, and an
3547         optional list of command line arguments to pass to DRT;
3548         it gives us a way to run all of the tests in a given directory
3549         multiple times with multiple (potentially differing) sets of
3550         results and baselines.
3551
3552         This patch implements the support needed for this feature, and
3553         some basic tests, but no actual port will use the feature yet.
3554
3555         This is probably the simplest implementation possible - the
3556         list of virtual suites will be hard-coded into the port's
3557         implementation. One can imagine a more data-driven approach
3558         where the suite instructions are stored in a manifest file
3559         either in LayoutTests (all suites in one file), or per-port,
3560         or per-directory. If this feature ends up being useful we
3561         should probably add something like that so people don't have
3562         to hunt around in the code to add suites.
3563
3564         * Scripts/webkitpy/layout_tests/port/base.py:
3565         (Port.__init__):
3566         (Port.expected_filename):
3567         (Port.tests):
3568         (Port):
3569         (Port._real_tests):
3570         (Port._driver_class):
3571         (Port.virtual_test_suites):
3572         (Port.virtual_suite):
3573         (Port.virtual_suite.VirtualTestSuite):
3574         (Port.virtual_suite.VirtualTestSuite.__init__):
3575         (Port.virtual_suite.VirtualTestSuite.__repr__):
3576         (Port.populated_virtual_test_suites):
3577         (Port._virtual_tests):
3578         (Port.lookup_virtual_test_base):
3579         (Port.lookup_virtual_test_args):
3580         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3581         (PortTest.test_find_with_skipped_directories):
3582         * Scripts/webkitpy/layout_tests/port/driver.py:
3583         (DriverInput.__init__):
3584         (DriverProxy.run_test):
3585         * Scripts/webkitpy/layout_tests/port/test.py:
3586         (TestPort.virtual_test_suites):
3587         (TestDriver.run_test):
3588         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3589         (MainTest.test_all):
3590         (MainTest.test_virtual):
3591
3592 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
3593
3594         nrwt: support more than two drivers in DriverProxy
3595         https://bugs.webkit.org/show_bug.cgi?id=79736
3596
3597         Reviewed by Adam Barth.
3598
3599         Now that we can support per-test command lines for
3600         Drivers, modify DriverProxy to keep a map of running
3601         drivers for each needed command-line; this will allow
3602         us to transparently maintain a pool of appropriately
3603         configured DRTs without having to constantly start and stop
3604         them.
3605
3606         Note that this potentially raises a garbage collection
3607         problem - the number of running DRTs will grow with the
3608         number of different sets of command line args. For now
3609         this is no worse than the current code - if you're running
3610         with pixel tests, you will only need one DRT per worker,
3611         and if you aren't, you'll need two (one for text-only tests,
3612         and one for reftests).
3613
3614         An alternative would be to only ever have one running driver,
3615         and restart the driver as the command line changes, but this
3616         might (?) slow down execution in the text-only case - we
3617         should benchmark this because it would be simpler and possibly
3618         allow us to eliminate DriverProxy altogether.
3619
3620         * Scripts/webkitpy/layout_tests/port/driver.py:
3621         (DriverProxy.__init__):
3622         (DriverProxy):
3623         (DriverProxy._make_driver):
3624         (DriverProxy.run_test):
3625         (DriverProxy.has_crashed):
3626         (DriverProxy.stop):
3627         (DriverProxy.cmd_line):
3628         (DriverProxy._cmd_line_as_key):
3629
3630 2012-02-29  Adrienne Walker  <enne@google.com>
3631
3632         Unreviewed, add myself as a reviewer
3633
3634         * Scripts/webkitpy/common/config/committers.py:
3635
3636 2012-02-29  Greg Billock  <gbillock@google.com>
3637
3638         Add more tests for web intents
3639         https://bugs.webkit.org/show_bug.cgi?id=79527
3640
3641         Reviewed by Adam Barth.
3642
3643         * DumpRenderTree/chromium/LayoutTestController.cpp:
3644         (LayoutTestController::LayoutTestController):
3645         (LayoutTestController::sendWebIntentResponse):
3646         * DumpRenderTree/chromium/LayoutTestController.h:
3647         (LayoutTestController):
3648         * DumpRenderTree/chromium/WebViewHost.h:
3649         (WebViewHost):
3650         (WebViewHost::currentIntentRequest):
3651
3652 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
3653
3654         nrwt: port/Driver needs to support per-test command line args
3655         https://bugs.webkit.org/show_bug.cgi?id=79733
3656
3657         Reviewed by Adam Barth.
3658
3659         As part of removing the 'gpu' configurations and adding support
3660         for 'virtual test suites', the Driver classes need to support
3661         per-test command lines (since different tests will need to be
3662         run with different command line options).
3663
3664         The per-test args are not yet used, so this change should have
3665         no visible effects and need no additional testing.
3666
3667         * Scripts/webkitpy/layout_tests/port/base.py:
3668         (Port.driver_cmd_line):
3669         * Scripts/webkitpy/layout_tests/port/chromium.py:
3670         (ChromiumDriver.cmd_line):
3671         (ChromiumDriver._start):
3672         (ChromiumDriver.start):
3673         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3674         (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
3675         (ChromiumDriverTest):
3676         (ChromiumDriverTest.test_two_drivers):
3677         * Scripts/webkitpy/layout_tests/port/driver.py:
3678         (Driver.cmd_line):
3679         (DriverProxy.__init__):
3680         (DriverProxy.start):
3681         (DriverProxy.cmd_line):
3682         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3683         (DriverTest.test_virtual_driver_methods):
3684         * Scripts/webkitpy/layout_tests/port/gtk.py:
3685         (GtkDriver.cmd_line):
3686         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3687         * Scripts/webkitpy/layout_tests/port/test.py:
3688         (TestPort._path_to_driver):
3689         (TestDriver.cmd_line):
3690         (TestDriver.start):
3691         * Scripts/webkitpy/layout_tests/port/webkit.py:
3692         (WebKitDriver.cmd_line):
3693         (WebKitDriver._start):
3694         (WebKitDriver.run_test):
3695         (WebKitDriver.start):
3696         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3697         (WebKitDriverTest.test_no_timeout):
3698         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3699         (PerfTestsRunner._run_tests_set):
3700         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3701         (test_run_test_pause_before_testing):
3702
3703 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
3704
3705         perftestsrunner can call printer.write() after printer.cleanup()
3706         https://bugs.webkit.org/show_bug.cgi?id=79872
3707
3708         Reviewed by Ryosuke Niwa.
3709
3710         This patch fixes a unittest that was incorrectly calling
3711         PerfTestsRunner.run() twice (which led to a weird state in the
3712         printer object).
3713
3714         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3715         (MainTest.test_run_with_upload_json):
3716
3717 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
3718
3719         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
3720         https://bugs.webkit.org/show_bug.cgi?id=76546
3721
3722         Reviewed by Simon Hausmann.
3723
3724         Revert the workaround introduced in r107868 and reintroduce
3725         the qml binding so we can test the code path that we are more
3726         interested in. The reason that it did not work before is that
3727         we don't have an active platform window which we now workaround
3728         by propagating the resize through QWindowSystemInterface.
3729
3730         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3731         (WTR::WrapperWindow::handleStatusChanged):
3732         (WTR::PlatformWebView::resizeTo):
3733
3734 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
3735
3736         [GTK] Small fix for cross compilation to not generate gtkdoc.
3737
3738         Rubber-stamped by Csaba Osztrogonác.
3739
3740         * Scripts/webkitdirs.pm:
3741         (isCrossCompilation):
3742
3743 2012-02-28  Lucas Forschler  <lforschler@apple.com>
3744
3745         Fix a typo in config.json
3746         linx -> linux
3747         
3748         * BuildSlaveSupport/build.webkit.org-config/config.json:
3749
3750 2012-02-28  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3751
3752         [Qt] Allow read/write to the WebView.url property
3753         https://bugs.webkit.org/show_bug.cgi?id=77554
3754
3755         Reviewed by Tor Arne Vestbø.
3756
3757         Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
3758
3759         * MiniBrowser/qt/qml/BrowserWindow.qml:
3760
3761 2012-02-28  Dan Winship  <danw@gnome.org>
3762
3763         [GTK] make tests explicitly request GSettingsBackendMemory
3764         https://bugs.webkit.org/show_bug.cgi?id=79788
3765
3766         Reviewed by Martin Robinson.
3767
3768         Explicitly request the fallback memory-based GSettings backend; if
3769         other backends are available then we don't want to use them,
3770         because they would make tests depend on the user's preferences.
3771         And if other backends aren't available, we don't need glib to
3772         print a warning about that fact.
3773
3774         * Scripts/webkitpy/layout_tests/port/gtk.py:
3775         (GtkPort.setup_environ_for_server):
3776
3777 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
3778
3779         Unreviewed, rolling out r109110.
3780         http://trac.webkit.org/changeset/109110
3781         https://bugs.webkit.org/show_bug.cgi?id=79806
3782
3783         webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
3784         (Requested by aroben on #webkit).
3785
3786         * Scripts/webkitpy/common/checkout/changelog.py:
3787         (parse_bug_id):
3788         (parse_bug_id_from_changelog):
3789         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3790         * Scripts/webkitpy/common/config/urls.py:
3791
3792 2012-02-28  Adam Roben  <aroben@webkit.org>
3793
3794         Add my new email address
3795
3796         Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
3797
3798         Reviewed by Anders Carlsson.
3799
3800         * Scripts/webkitpy/common/config/committers.py:
3801
3802 2012-02-28  Adam Roben  <aroben@apple.com>
3803
3804         Teach webkitpy about wkb.ug URLs
3805
3806         Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
3807         use wkb.ug URLs
3808
3809         Reviewed by Anders Carlsson.
3810
3811         * Scripts/webkitpy/common/checkout/changelog.py:
3812         (parse_bug_id):
3813         (parse_bug_id_from_changelog):
3814         Fall back to the tiny URL format if neither the short nor long URL formats work.
3815
3816         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3817         (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
3818
3819         * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
3820         wkb.ug URLs.
3821
3822 2012-02-28  János Badics  <dicska@gmail.com>
3823
3824         [Qt] build-webkit does not detect the number of CPUs
3825         https://bugs.webkit.org/show_bug.cgi?id=76445
3826
3827         Based on Seo Sanghyeon's work (modification:
3828         Automatically determine the number of CPUs for make
3829         only if -j make argument haven't already been specified.)
3830
3831         Reviewed by Csaba Osztrogonác.
3832
3833         * Scripts/webkitdirs.pm:
3834         (buildQMakeProjects):
3835
3836 2012-02-28  Kent Tamura  <tkent@chromium.org>
3837
3838         Update a pattern for forms files of watchlist
3839         https://bugs.webkit.org/show_bug.cgi?id=79767
3840
3841         Reviewed by Kentaro Hara.
3842
3843         * Scripts/webkitpy/common/config/watchlist:
3844         Catches the following files with the "Forms" pattern.
3845         - HTMLDatListElement.*
3846         - HTMLKeygenElement.*
3847         - HTMLLegendElement.*
3848         - HTMLOutputElement.*
3849         - FormAssociatedElement.*
3850         - SliderThumbElement.*
3851         - TextControlInnerElements.*
3852         - RenderFileUploadControl.*
3853
3854 2012-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3855
3856         Unreviewed, rolling out r109041.
3857         http://trac.webkit.org/changeset/109041
3858         https://bugs.webkit.org/show_bug.cgi?id=79741
3859
3860         Broke Chromium Win build (Requested by bashi on #webkit).
3861
3862         * DumpRenderTree/chromium/LayoutTestController.cpp:
3863         (LayoutTestController::LayoutTestController):
3864         * DumpRenderTree/chromium/LayoutTestController.h:
3865         (LayoutTestController):
3866         * DumpRenderTree/chromium/WebViewHost.h:
3867
3868 2012-02-27  James Robinson  <jamesr@chromium.org>
3869
3870         [chromium] Remove media tests from ChromiumGpu configurations
3871         https://bugs.webkit.org/show_bug.cgi?id=79720
3872
3873         Reviewed by Adam Barth.
3874
3875         We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
3876         composited playback path via tests in the compositing/ directory.
3877
3878         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3879         (_default_tests_paths):
3880         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3881         (ChromiumGpuTest.test_default_tests_paths):
3882         (ChromiumGpuTest.test_test_files):
3883
3884 2012-02-27  Dirk Pranke  <dpranke@chromium.org>
3885
3886         nrwt: log multiline stderr/crash output properly
3887         https://bugs.webkit.org/show_bug.cgi?id=79722
3888
3889         Reviewed by Adam Barth.
3890
3891         This cleans up some nits in the log output to make things
3892         slightly easier to read (every line gets timestamped, etc.).
3893
3894         Also tweaks the log message for pixel hash mismatches.
3895
3896         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3897         (SingleTestRunner._handle_error):
3898         (SingleTestRunner._compare_image):
3899
3900 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
3901
3902         Touch the master.cfg to force a reconfig.
3903
3904         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3905         (BuildAndTestLeaksFactory):
3906         (NewBuildAndTestFactory):
3907
3908 2012-02-27  Jacky Jiang  <zhajiang@rim.com>
3909
3910         [BlackBerry] Upstream BlackBerry API web page related files
3911         https://bugs.webkit.org/show_bug.cgi?id=74380
3912
3913         Reviewed by Antonio Gomes.
3914
3915         Adapt to the removing of WebPage::mainFrame(), use
3916         DumpRenderTreeSupport::corePage() and its mainFrame() instead.
3917
3918         No new tests as this patch doesn't change behavior.
3919
3920         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3921         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3922         (BlackBerry::WebKit::DumpRenderTree::runTests):
3923
3924 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
3925
3926         Add Windows and Linux Chromium perf bots
3927         https://bugs.webkit.org/show_bug.cgi?id=79418
3928
3929         Reviewed by Tony Chang.
3930
3931         Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
3932         the dedicated perf bot slave (uses the same hardware).
3933
3934         * BuildSlaveSupport/build.webkit.org-config/config.json:
3935
3936 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
3937
3938         Undefined variable 'current' when running chromium_android.py
3939         https://bugs.webkit.org/show_bug.cgi?id=79696
3940
3941         Reviewed by Adam Barth.
3942
3943         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3944         (ChromiumAndroidDriver._read_prompt):
3945
3946 2012-02-27  Greg Billock  <gbillock@google.com>
3947
3948         Add more tests for web intents
3949         https://bugs.webkit.org/show_bug.cgi?id=79527
3950
3951         Reviewed by Adam Barth.
3952
3953         * DumpRenderTree/chromium/LayoutTestController.cpp:
3954         (LayoutTestController::LayoutTestController):
3955         (LayoutTestController::sendWebIntentResponse):
3956         * DumpRenderTree/chromium/LayoutTestController.h:
3957         (LayoutTestController):
3958         * DumpRenderTree/chromium/WebViewHost.h:
3959         (WebViewHost):
3960         (WebViewHost::currentIntentRequest):
3961
3962 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
3963
3964         Chromium-Android layout test script: the adb shell prompt is not always '# '
3965         https://bugs.webkit.org/show_bug.cgi?id=79506
3966
3967         Reviewed by Adam Barth.
3968
3969         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3970         (ChromiumAndroidDriver._start):
3971         (ChromiumAndroidDriver._read_prompt):
3972
3973 2012-02-27  Dan Bernstein  <mitz@apple.com>
3974
3975         Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
3976         https://bugs.webkit.org/show_bug.cgi?id=79607
3977
3978         Reviewed by Adele Peterson.
3979
3980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3981         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
3982         (TestWebKitAPI::AcceptsFirstMouse::url):
3983         (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
3984         (TestWebKitAPI::AcceptsFirstMouse::runTest):
3985         (TestWebKitAPI::TEST_F):
3986         * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
3987
3988 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3989
3990         Unreviewed. Fix make distcheck.
3991
3992         * GNUmakefile.am: Fix typo.
3993
3994 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3995
3996         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
3997
3998         Reviewed by Kenneth Rohde Christiansen..
3999
4000         * qmake/mkspecs/features/features.prf:
4001
4002 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
4003
4004         Add a ChromiumGpuAndroid port.
4005         https://bugs.webkit.org/show_bug.cgi?id=79628
4006
4007         Reviewed by Adam Barth.
4008
4009         Android does have a gpu port, so revert r107697.
4010
4011         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4012         (ChromiumAndroidPort.__init__):
4013         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4014         (ChromiumGpuAndroidPort):
4015         (ChromiumGpuAndroidPort.__init__):
4016         (ChromiumGpuAndroidPort.baseline_search_path):
4017         (ChromiumGpuAndroidPort.default_child_processes):
4018         (ChromiumGpuAndroidPort.tests):
4019         * Scripts/webkitpy/layout_tests/port/factory.py:
4020         (PortFactory):
4021
4022 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4023
4024         Change Build bot with BuildAndTest bot for EFL port.
4025         https://bugs.webkit.org/show_bug.cgi?id=77518
4026
4027         Reviewed by Ryosuke Niwa.
4028
4029         EFL build bot starts to support layout test.
4030
4031         * BuildSlaveSupport/build.webkit.org-config/config.json:
4032         * BuildSlaveSupport/built-product-archive:
4033         (archiveBuiltProduct):
4034         (extractBuiltProduct):
4035         * BuildSlaveSupport/test-result-archive:
4036         (archiveTestResults):
4037         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
4038         (generateBuildSystemFromCMakeProject):
4039
4040 2012-02-24  Darin Fisher  <darin@chromium.org>
4041
4042         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
4043
4044         Reviewed by James Robinson.
4045
4046         * Scripts/webkitpy/common/config/watchlist:
4047
4048 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
4049
4050         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
4051         https://bugs.webkit.org/show_bug.cgi?id=79258
4052
4053         Reviewed by Ryosuke Niwa.
4054
4055         Split the fuzzy matching into separate functions so that they
4056         can be sharded and run in parallel.
4057
4058         Also, fix a bug in the svn_blame_regexp that was causing us
4059         to require ChangeLog lines to have at least one space after the
4060         author, making the code require trailing whitespace in the
4061         changelog in some places (this was making my life harder because
4062         I have my text editor set to strip trailing whitespace in python
4063         files, and that was causing test_parse_log_entries_from_changelog() to fail
4064         when the whitespace on line 275 was removed).
4065
4066         * Scripts/webkitpy/common/checkout/changelog.py:
4067         (ChangeLog):
4068         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4069         (test_fuzzy_reviewer_match__none):
4070         (test_fuzzy_reviewer_match_adam_barth):
4071         (test_fuzzy_reviewer_match_darin_adler_et_al):
4072         (test_fuzzy_reviewer_match_dimitri_glazkov):
4073         (test_fuzzy_reviewer_match_george_staikos):
4074         (test_fuzzy_reviewer_match_mark_rowe):
4075
4076 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
4077
4078         webkitpy: committers_unittest fuzzy matching is really slow
4079         https://bugs.webkit.org/show_bug.cgi?id=79179
4080
4081         Reviewed by Ryosuke Niwa.
4082
4083         Break the fuzzy matching tests into individual routines for
4084         each contributor so that the intent is a little clearer, so
4085         that it's easier to test individual names (and identify
4086         duplicate tests), and so that we can eventually run
4087         them in parallel.
4088
4089         Also, mark most of them as 'integration' tests so that they
4090         can be skipped if we want to go fast (we leave a few as
4091         regular tests for functional coverage).
4092
4093         * Scripts/webkitpy/common/config/committers_unittest.py:
4094         (CommittersTest):
4095         (CommittersTest.test_contributors_by_fuzzy_match):
4096         (CommittersTest.integration_test_contributors__none):
4097         (CommittersTest.integration_test_contributors__none_2):
4098         (CommittersTest.integration_test_contributors__none_3):
4099         (CommittersTest.integration_test_contributors_ada_chan):
4100         (CommittersTest.integration_test_contributors_adele_peterson):
4101         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
4102         (CommittersTest.integration_test_contributors_alice_liu):
4103         (CommittersTest.integration_test_contributors_alp_toker):
4104         (CommittersTest.integration_test_contributors_anders_carlsson):
4105         (CommittersTest.integration_test_contributors_antti_koivisto):
4106         (CommittersTest.integration_test_contributors_beth_dakin):
4107         (CommittersTest.integration_test_contributors_brady_eidson):
4108         (CommittersTest.integration_test_contributors_cameron_zwarich):
4109         (CommittersTest.integration_test_contributors_chris_blumenberg):
4110         (CommittersTest.integration_test_contributors_dan_bernstein):
4111         (CommittersTest.integration_test_contributors_dan_bernstein_2):
4112         (CommittersTest.integration_test_contributors_darin_adler):
4113         (CommittersTest.integration_test_contributors_david_harrison):
4114         (CommittersTest.integration_test_contributors_david_harrison_2):
4115         (CommittersTest.integration_test_contributors_david_hyatt):
4116         (CommittersTest.integration_test_contributors_david_kilzer):
4117         (CommittersTest.integration_test_contributors_don_melton):
4118         (CommittersTest.integration_test_contributors_eric_seidel):
4119         (CommittersTest.integration_test_contributors_geoffrey_garen):
4120         (CommittersTest.integration_test_contributors_greg_bolsinga):
4121         (CommittersTest.integration_test_contributors_holger_freyther):
4122         (CommittersTest.integration_test_contributors_jon_sullivan):
4123         (CommittersTest.integration_test_contributors_jon_honeycutt):
4124         (CommittersTest.integration_test_contributors_joseph_pecoraro):
4125         (CommittersTest.integration_test_contributors_ken_kocienda):
4126         (CommittersTest.integration_test_contributors_kenneth_russell):
4127         (CommittersTest.integration_test_contributors_kevin_decker):
4128         (CommittersTest.integration_test_contributors_kevin_mccullough):
4129         (CommittersTest.integration_test_contributors_lars_knoll):
4130         (CommittersTest.integration_test_contributors_lars_weintraub):
4131         (CommittersTest.integration_test_contributors_maciej_stachowiak):
4132         (CommittersTest.integration_test_contributors_mark_rowe):
4133         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
4134         (CommittersTest.integration_test_contributors_oliver_hunt):
4135         (CommittersTest.integration_test_contributors_rniwa):
4136         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
4137         (CommittersTest.integration_test_contributors_steve_falkenburg):
4138         (CommittersTest.integration_test_contributors_sam_weinig):
4139         (CommittersTest.integration_test_contributors_tim_omernick):
4140         (CommittersTest.integration_test_contributors_timothy_hatcher):
4141         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
4142         (CommittersTest.integration_test_contributors_vicki_murley):
4143         (CommittersTest.integration_test_contributors_zack_rusin):
4144
4145 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
4146
4147         webkitpy: should autoinstall coverage
4148         https://bugs.webkit.org/show_bug.cgi?id=79535
4149
4150         Reviewed by Eric Seidel.
4151
4152         We should automatically print the coverage report after the run, too.
4153
4154         * Scripts/webkitpy/test/main.py:
4155         (Tester._run_tests):
4156         * Scripts/webkitpy/thirdparty/__init__.py:
4157         (AutoinstallImportHook.find_module):
4158         (AutoinstallImportHook._install_coverage):
4159
4160 2012-02-24  Pablo Flouret  <pablof@motorola.com>
4161
4162         Fix copypasta in build-webkit's --vibration option description
4163         https://bugs.webkit.org/show_bug.cgi?id=79528
4164
4165         Reviewed by Andreas Kling.
4166
4167         * Scripts/build-webkit:
4168
4169 2012-02-24  Antonio Gomes  <agomes@rim.com>
4170
4171         Adding myself to ScrollingCoordinator watchlist
4172         https://bugs.webkit.org/show_bug.cgi?id=79525
4173
4174         Reviewed by Rob Buis.
4175
4176         * Scripts/webkitpy/common/config/watchlist:
4177
4178 2012-02-24  Darin Fisher  <darin@chromium.org>
4179
4180         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
4181
4182         Reviewed by Adam Barth.
4183
4184         * Scripts/webkitpy/common/config/watchlist:
4185
4186 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
4187
4188         webkitpy: config_unittest is sensitive to other tests that might've already run
4189         https://bugs.webkit.org/show_bug.cgi?id=79382
4190
4191         Reviewed by Adam Barth.
4192
4193         If another test runs prior to config_unittest and pokes the
4194         cached configuration, the first test in config_unittest might
4195         fail; the tearDown() will then allow subsequent tests to pass.
4196         Clearing the configuration prior to each test makes things
4197         slightly slower but safer.
4198
4199         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
4200         (ConfigTest.setUp):
4201
4202 2012-02-24  David Kilzer  <ddkilzer@apple.com>
4203
4204         Use xcrun to find compiler paths for Generate Derived Sources build phase script
4205         <http://webkit.org/b/79512>
4206
4207         Reviewed by Dan Bernstein.
4208
4209         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4210         (Generate Derived Sources): Use xcrun to find the path to the
4211         compiler since that works on both iOS and OS X.
4212
4213 2012-02-24  James Robinson  <jamesr@chromium.org>
4214
4215         Create a watchlist for ScrollingCoordinator changes
4216         https://bugs.webkit.org/show_bug.cgi?id=79511
4217
4218         Reviewed by Anders Carlsson.
4219
4220         * Scripts/webkitpy/common/config/watchlist:
4221
4222 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
4223
4224         [EFL][DRT] Implement setValueForUser and setAutofilled.
4225         https://bugs.webkit.org/show_bug.cgi?id=79237
4226
4227         Reviewed by Andreas Kling.
4228
4229         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
4230         Those implementations are related with input fields and allow to pass following tests:
4231         fast/forms/onchange-setvalueforuser.html
4232         fast/forms/input-autofilled.html
4233         fast/forms/reset-autofilled.html
4234
4235         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4236         (LayoutTestController::setValueForUser):
4237         (LayoutTestController::setAutofilled):
4238
4239 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
4240
4241         [Qt] Allow to use WebCore imagedecoders
4242         https://bugs.webkit.org/show_bug.cgi?id=32410
4243
4244         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
4245
4246         Reviewed by Simon Hausmann.
4247
4248         * qmake/mkspecs/features/features.prf:
4249
4250 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
4251
4252         [Qt] Add Qt5 way to force 96 DPI for tests
4253         https://bugs.webkit.org/show_bug.cgi?id=79364
4254
4255         Reviewed by Simon Hausmann.
4256
4257         * DumpRenderTree/qt/main.cpp:
4258         (main):
4259         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4260         (WTR::activateFonts):
4261
4262 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4263
4264         [GTK] MiniBrowser should reload the view then the reload button is clicked
4265         https://bugs.webkit.org/show_bug.cgi?id=79472
4266
4267         Reviewed by Philippe Normand.
4268
4269         * MiniBrowser/gtk/BrowserWindow.c:
4270         (reloadCallback): Call webkit_web_view_reload().
4271         (browser_window_init): Connect reload item clicked even to
4272         reloadCallback instead of activateUriEntryCallback.
4273
4274 2012-02-24  Kentaro Hara  <haraken@chromium.org>
4275
4276         Add performance tests for DOM attribute getters and setters
4277         https://bugs.webkit.org/show_bug.cgi?id=79208
4278
4279         Reviewed by Ryosuke Niwa.
4280
4281         We want to allow perf tests to output info messages
4282         that do not affect the test results. To accomplish this,
4283         this patch modifies perftestsrunner.py so that it ignores
4284         a line that starts from "Info:".
4285
4286         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4287         (PerfTestsRunner):
4288
4289 2012-02-24  Andrew Lo  <anlo@rim.com>
4290
4291         [BlackBerry] Enable requestAnimationFrame
4292         https://bugs.webkit.org/show_bug.cgi?id=79408
4293
4294         Enable requestAnimationFrame for BlackBerry.
4295
4296         Reviewed by Rob Buis.
4297
4298         * Scripts/build-webkit:
4299
4300 2012-02-24  Adam Barth  <abarth@webkit.org>
4301
4302         style-queue tries to apply the patch twice
4303         https://bugs.webkit.org/show_bug.cgi?id=79459
4304
4305         Reviewed by Eric Seidel.
4306
4307         Previously, we applied the patch using both apply-patch and
4308         check-style.  This patch introduces a check-style-local to mirror the
4309         apply-watchlist-local, which operates on the current working diff.
4310
4311         This patch also cleans up some other bugs I found by running the queue
4312         locally for a while.  The queue still prints out a slightly
4313         less-than-ideal message on the bugs when it find an error, but it's ok
4314         for now.  We'll need to iterate a bit.
4315
4316         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
4317         (StyleQueueTask.validate):
4318         (StyleQueueTask._check_style):
4319         * Scripts/webkitpy/tool/commands/download.py:
4320         (CheckStyleLocal):
4321         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4322         (EarlyWarningSytemTest._default_expected_stderr):
4323         (EarlyWarningSytemTest._test_testing_ews):
4324         * Scripts/webkitpy/tool/commands/queues.py:
4325         (AbstractReviewQueue.handle_script_error):
4326         (StyleQueue.review_patch):
4327         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4328         * Scripts/webkitpy/tool/commands/queuestest.py:
4329         (QueuesTest.assert_queue_outputs):
4330
4331 2012-02-23  Adam Barth  <abarth@webkit.org>
4332
4333         should_proceed_with_work_item is unused and can be removed
4334         https://bugs.webkit.org/show_bug.cgi?id=79416
4335
4336         Reviewed by Eric Seidel.
4337
4338         We used to use this function to check whether the tree is red.  Now, we
4339         don't use external measures of whether to proceed with work items.
4340         Instead, we analyze them with the idea in mind that the tree might be
4341         red.
4342
4343         * Scripts/webkitpy/tool/bot/queueengine.py:
4344         (QueueEngineDelegate.next_work_item):
4345         (QueueEngine.run):
4346         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
4347         (LoggingDelegate):
4348         (LoggingDelegate.next_work_item):
4349         (RaisingDelegate.process_work_item):
4350         (QueueEngineTest.test_terminating_error):
4351         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4352         (AbstractEarlyWarningSystem.__init__):
4353         * Scripts/webkitpy/tool/commands/queues.py:
4354         (AbstractQueue.next_work_item):
4355         (FeederQueue.next_work_item):
4356         (CommitQueue.next_work_item):
4357         (AbstractReviewQueue.next_work_item):
4358         (StyleQueue.__init__):
4359         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4360         (FeederQueueTest.test_feeder_queue):
4361         (CommitQueueTest.test_commit_queue):
4362         (test_commit_queue_failure):
4363         (test_commit_queue_failure_with_failing_tests):
4364         (test_rollout):
4365         (test_rollout_lands):
4366         (StyleQueueTest.test_style_queue_with_style_exception):
4367         (test_style_queue_with_watch_list_exception):
4368         * Scripts/webkitpy/tool/commands/queuestest.py:
4369         (QueuesTest.assert_queue_outputs):
4370         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4371         (SheriffBot.next_work_item):
4372
4373 2012-02-23  Adrienne Walker  <enne@google.com>
4374
4375         Unreviewed, add Stephen Chenney to committers.py as a contributor.
4376
4377         * Scripts/webkitpy/common/config/committers.py:
4378
4379 2012-02-23  Adam Barth  <abarth@webkit.org>
4380
4381         style-queue logs bogus messages to the QueueStatusServer
4382         https://bugs.webkit.org/show_bug.cgi?id=79424