c3685f77b8fa085ec4a06dfa121b9893e65dc5a9
[WebKit-https.git] / Tools / ChangeLog
1 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2
3         [EFL] Bump glib version from 2.36 to 2.38 
4         https://bugs.webkit.org/show_bug.cgi?id=130886
5
6         Reviewed by Csaba Osztrogonác.
7
8         There is a build break on EFL port when using glib 2.36 ver. To fix it,
9         we need to bump glib version up to 2.38 as gtk port.
10
11         * efl/jhbuild.modules:
12
13 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
14
15         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
16
17         Provide an implementation of WKContextHistoryClient that logs when called for tests in
18         the globalhistory directory.
19
20         Reviewed by Sam Weinig.
21
22         * WebKitTestRunner/TestController.cpp:
23         (WTR::TestController::TestController):
24         (WTR::TestController::initialize): Set the history client.
25         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
26         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
27         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
28         and we don't yet have API to access the data in question.
29         (WTR::TestController::didPerformClientRedirect):
30         (WTR::TestController::didPerformServerRedirect):
31         (WTR::TestController::didUpdateHistoryTitle):
32         * WebKitTestRunner/TestController.h:
33         (WTR::TestController::setShouldLogHistoryClientCallbacks):
34         * WebKitTestRunner/TestInvocation.cpp:
35         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
36         (WTR::TestInvocation::invoke):
37
38 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
39
40         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
41
42         * Scripts/build-webkit:
43         * Scripts/copy-webkitlibraries-to-product-directory:
44
45 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
46
47         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
48         https://bugs.webkit.org/show_bug.cgi?id=130867
49         <rdar://problem/16432456> 
50
51         Reviewed by Mark Hahnenberg.
52
53         * Scripts/build-webkit:
54         * Scripts/copy-webkitlibraries-to-product-directory:
55
56 2014-03-26  Andy Estes  <aestes@apple.com>
57
58         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
59         https://bugs.webkit.org/show_bug.cgi?id=130805
60
61         Reviewed by Dan Bernstein.
62
63         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
64         (-[DownloadDelegate _download:didReceiveResponse:]):
65         (-[DownloadDelegate _downloadDidFinish:]):
66         (runTest):
67         (TEST):
68         (-[FailingDownloadDelegate _downloadDidFinish:]):
69         (-[FailingDownloadDelegate _download:didFailWithError:]):
70         (-[FailingDownloadDelegate _downloadDidCancel:]):
71         (-[CancelledDownloadDelegate _downloadDidStart:]):
72         (-[CancelledDownloadDelegate _downloadDidFinish:]):
73         (-[CancelledDownloadDelegate _download:didFailWithError:]):
74         (-[CancelledDownloadDelegate _downloadDidCancel:]):
75         (-[DownloadDelegate initWithSourceURL:]): Deleted.
76         (-[DownloadDelegate sourceURL]): Deleted.
77         (runTestWithNavigationDelegate): Deleted.
78
79 2014-03-26  Anders Carlsson  <andersca@apple.com>
80
81         Change MiniBrowser to hold on to window controllers instead of windows
82         https://bugs.webkit.org/show_bug.cgi?id=130797
83
84         Reviewed by Oliver Hunt.
85
86         * MiniBrowser/mac/AppDelegate.h:
87         * MiniBrowser/mac/AppDelegate.m:
88         (-[BrowserAppDelegate init]):
89         (-[BrowserAppDelegate newWindow:]):
90         (-[BrowserAppDelegate browserWindowWillClose:]):
91         (-[BrowserAppDelegate applicationWillTerminate:]):
92         (-[BrowserAppDelegate frontmostBrowserWindowController]):
93
94 2014-03-26  Commit Queue  <commit-queue@webkit.org>
95
96         Unreviewed, rolling out r166264.
97         https://bugs.webkit.org/show_bug.cgi?id=130785
98
99         Broke some window.opener tests for WK2 Mavericks (Requested by
100         brrian__ on #webkit).
101
102         Reverted changeset:
103
104         "Web Replay: resource unique identifiers should be unique-per-
105         frame, not globally"
106         https://bugs.webkit.org/show_bug.cgi?id=130632
107         http://trac.webkit.org/changeset/166264
108
109 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
110
111         [CSS Shapes] Remove shape-inside support
112         https://bugs.webkit.org/show_bug.cgi?id=130698
113
114         Reviewed by David Hyatt.
115
116         * Scripts/webkitperl/FeatureList.pm:
117
118 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
119
120         Unreviewed. Add myself as a committer.
121
122         * Scripts/webkitpy/common/config/contributors.json:
123
124 2014-03-26  Tomas Popela  <tpopela@redhat.com>
125
126         run-launcher is Perl script so use elsif and not elif
127         https://bugs.webkit.org/show_bug.cgi?id=130771
128
129         Reviewed by Carlos Garcia Campos.
130
131         * Scripts/run-launcher:
132
133 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
134
135         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
136         https://bugs.webkit.org/show_bug.cgi?id=130575
137
138         Reviewed by Mario Sanchez Prada.
139
140         Change ATK version to 2.11.92. Adjust current implementation.
141
142         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
143         (AccessibilityUIElement::intValue):
144         (AccessibilityUIElement::minValue):
145         (AccessibilityUIElement::maxValue):
146         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
147         (WTR::AccessibilityUIElement::intValue):
148         (WTR::AccessibilityUIElement::minValue):
149         (WTR::AccessibilityUIElement::maxValue):
150         * efl/jhbuild.modules:
151         * gtk/jhbuild.modules:
152
153 2014-03-12  Philippe Normand  <pnormand@igalia.com>
154
155         [GTK] The gnumake package is no longer needed in jhbuild
156         https://bugs.webkit.org/show_bug.cgi?id=130121
157
158         Reviewed by Martin Robinson.
159
160         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
161         for a debug build cmake/system-gnumake worked just fine for me.
162
163         * gtk/jhbuild.modules: Removed gnumake.
164         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
165         * gtk/patches/make-3.82-parallel-build.patch: Removed.
166
167 2014-03-25  Andy Estes  <aestes@apple.com>
168
169         Fix a failing API test on Mountain Lion and remove temporary debug logging.
170
171         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
172         (-[DownloadDelegate _download:didReceiveData:]):
173         (-[DownloadDelegate _downloadDidFinish:]):
174
175 2014-03-25  Brian Burg  <bburg@apple.com>
176
177         Web Replay: resource unique identifiers should be unique-per-frame, not globally
178         https://bugs.webkit.org/show_bug.cgi?id=130623
179
180         Reviewed by Timothy Hatcher.
181
182         The resource loader callback dumping routines assumed that resource identifiers
183         were globally unique. Its map of resource identifiers to URLs must also track the
184         frame associated with the resource.
185
186         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
187         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
188         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
189         stable as long as the frame is valid.
190         (WTR::InjectedBundlePage::didInitiateLoadForResource):
191         (WTR::InjectedBundlePage::willSendRequestForFrame):
192         (WTR::InjectedBundlePage::didReceiveResponseForResource):
193         (WTR::InjectedBundlePage::didFinishLoadForResource):
194         (WTR::InjectedBundlePage::didFailLoadForResource):
195
196 2014-03-25  Andy Estes  <aestes@apple.com>
197
198         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
199
200         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
201         (-[DownloadDelegate _download:didReceiveResponse:]):
202         (-[DownloadDelegate _download:didReceiveData:]):
203
204 2014-03-25  Andy Estes  <aestes@apple.com>
205
206         Add some debug logging to an API test that's failing on Mountain Lion.
207
208         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
209         (-[DownloadDelegate _download:didReceiveResponse:]):
210         (-[DownloadDelegate _downloadDidFinish:]):
211
212 2014-03-25  Anders Carlsson  <andersca@apple.com>
213
214         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
215         https://bugs.webkit.org/show_bug.cgi?id=130732
216
217         Reviewed by Tim Horton.
218
219         * MiniBrowser/mac/WK2BrowserWindowController.m:
220         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
221
222 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
223
224         [GTK] Remove the autotools build
225         https://bugs.webkit.org/show_bug.cgi?id=130717
226
227         Reviewed by Anders Carlsson.
228
229         * DumpRenderTree/config.h: Remove references to the autotools configure file.
230         * GNUmakefile.am: Removed.
231         * GtkLauncher/GNUmakefile.am: Removed.
232         * GtkLauncher/main.c: Remove references to the autotools configure file.
233         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
234         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
235         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
236         * MiniBrowser/gtk/GNUmakefile.am: Removed.
237         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
238         * Scripts/build-webkit: No longer handle autotools.
239         * Scripts/run-gtk-tests: Ditto.
240         (TestRunner._setup_testing_environment):
241         * Scripts/run-launcher: Ditto.
242         * Scripts/webkitdirs.pm: Ditto.
243         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
244         * Scripts/webkitpy/common/config/contributors.json: Ditto.
245         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
246         * Scripts/webkitpy/style/checker.py:
247         * TestWebKitAPI/GNUmakefile.am: Removed.
248         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
249         * WebKitTestRunner/GNUmakefile.am: Removed.
250         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
251         * gtk/GNUmakefile.am: Removed.
252         * gtk/common.py: Remove checks for the autotools build.
253         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
254
255 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
256
257         prepare-ChangeLog throws false positive warnings for modified files.
258         https://bugs.webkit.org/show_bug.cgi?id=130687
259
260         Reviewed by Darin Adler.
261
262         * Scripts/prepare-ChangeLog:
263         (originalFile): Ignore git commit paremeter.
264         We don't need this to get the unmodified file.
265         (extractLineRangeBeforeChange):
266         Simplify the if statement. Follow-up after r166189.
267
268 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
269
270         [EFL] Add ARM64 build support
271         https://bugs.webkit.org/show_bug.cgi?id=130506
272
273         Rubber stamped by Gyuyoung Kim.
274
275         * Scripts/webkitdirs.pm:
276         (isARM): Detect aarch64 as ARM.
277
278 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
279
280         [webkitpy] Improve _parse_bug_description to recognize more descriptions
281         https://bugs.webkit.org/show_bug.cgi?id=130137
282
283         Reviewed by Csaba Osztrogonác.
284
285         * Scripts/webkitpy/common/checkout/changelog.py:
286         (ChangeLogEntry._parse_bug_description):
287         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
288         (test_parse_log_entries_from_changelog):
289         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
290         (CheckoutTest.test_commit_info_for_revision):
291
292 2014-03-24  Andy Estes  <aestes@apple.com>
293
294         Fix the iOS build of TestWebKitAPI.
295
296         * TestWebKitAPI/Configurations/Base.xcconfig:
297         * TestWebKitAPI/PlatformUtilities.h:
298
299 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
300
301         Fix prepare-ChangeLog after r166156.
302         https://bugs.webkit.org/show_bug.cgi?id=130674
303
304         Reviewed by Darin Adler.
305
306         * Scripts/prepare-ChangeLog:
307         (generateFunctionLists):
308         (extractLineRangeBeforeChange):
309
310 2014-03-24  Andy Estes  <aestes@apple.com>
311
312         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
313         https://bugs.webkit.org/show_bug.cgi?id=129322
314
315         Reviewed by Anders Carlsson.
316
317         Add an API test suite for _WKDownload.
318
319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
320         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
321         (-[DownloadDelegate initWithSourceURL:]):
322         (-[DownloadDelegate sourceURL]):
323         (-[DownloadDelegate _downloadDidStart:]):
324         (-[DownloadDelegate _download:didReceiveResponse:]):
325         (-[DownloadDelegate _download:didReceiveData:]):
326         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
327         (-[DownloadDelegate _downloadDidFinish:]):
328         (TEST):
329         (runTestWithNavigationDelegate):
330         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
331         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
332
333 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
334
335         filter-build-webkit: reduce unfiltered output
336         https://bugs.webkit.org/show_bug.cgi?id=130485
337
338         Reviewed by Brent Fulgham.
339
340         * Scripts/filter-build-webkit:
341         (shouldIgnoreLine):
342
343 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
344
345         prepare-ChangeLog should list functions that have been removed too.
346         https://bugs.webkit.org/show_bug.cgi?id=130508
347
348         Reviewed by Darin Adler.
349
350         The prepare-ChangeLog does not list the deleted functions in the Changelog.
351         We have to read the functions and the line ranges of them from the source
352         before the change, then search for overlaps between them and the changed
353         line ranges from diff.
354
355         * Scripts/prepare-ChangeLog:
356         (originalFile): Get original source command.
357         (generateFunctionLists): Collect deleted functions too.
358         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
359         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
360         deleted functions ranges too.
361         (extractLineRange): Renamed to extractLineRangeAfterChange.
362
363 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
364
365         Move all EFL typedefs into EflTypedefs.h.
366         https://bugs.webkit.org/show_bug.cgi?id=130511
367
368         Reviewed by Gyuyoung Kim.
369
370         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
371         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
372         * WebKitTestRunner/PlatformWebView.h: Ditto.
373
374 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
375
376         Don't flush compositing layers within FrameView::willPaintContents()
377         https://bugs.webkit.org/show_bug.cgi?id=130627
378         <rdar://problem/16368869>
379
380         Reviewed by Sam Weinig.
381         
382         Fix DRT to correctly render tests with layers now that FrameView::paintContents
383         does not flush.
384         
385         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
386         into an explicit function called before dumping. 
387         
388         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
389         are flushed to CA. They will be pushed to the window by snapshotting.
390
391         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
392         Fix weird path to IOKit.framework.
393         * DumpRenderTree/mac/DumpRenderTree.mm:
394         (updateDisplay):
395         (dump):
396         * DumpRenderTree/mac/FrameLoadDelegate.mm:
397         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
398         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
399
400 2014-03-21  David Kilzer  <ddkilzer@apple.com>
401
402         fix-blink-patch: tool to fix up renamed directory paths in Blink
403         <http://webkit.org/b/130609>
404
405         Reviewed by Ryosuke Niwa.
406
407         Usage: cat blink.patch | fix-blink-patch | svn-apply
408
409         * Scripts/fix-blink-patch: Added.
410
411 2014-03-21  Darin Adler  <darin@apple.com>
412
413         Remove use of deprecatedCharacters in WebKit API tests
414         https://bugs.webkit.org/show_bug.cgi?id=130602
415
416         Reviewed by Antti Koivisto.
417
418         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
419         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
420         (TestWebKitAPI::expectEmpty): Use characters8.
421         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
422
423         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
424         Removed the test that is entirely about 16-bit conversion since that's basically a test of
425         the deprecatedCharacters function itself, which we are about to delete.
426
427 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
428
429         [webkitpy] Fix has_valid_reviewer()
430         https://bugs.webkit.org/show_bug.cgi?id=130589
431
432         Reviewed by Csaba Osztrogonác.
433
434         * Scripts/webkitpy/common/checkout/changelog.py:
435         (ChangeLogEntry.has_valid_reviewer):
436         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
437         (test_has_valid_reviewer):
438         * Scripts/webkitpy/common/config/committers.py:
439         (CommitterList._reviewer_only):
440         (CommitterList.committer_by_name):
441         (CommitterList.reviewer_by_email):
442         (CommitterList):
443         (CommitterList.reviewer_by_name):
444
445 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
446
447         Add cache support for jhbuild
448         https://bugs.webkit.org/show_bug.cgi?id=130588
449
450         Reviewed by Csaba Osztrogonác.
451
452         * jhbuild/jhbuildrc_common.py:
453         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
454
455 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
456
457         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
458         https://bugs.webkit.org/show_bug.cgi?id=130504
459
460         Reviewed by Martin Robinson.
461
462         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
463         CMake if not specified.
464         * Scripts/webkitdirs.pm:
465         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
466         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
467
468 2014-03-21  Andreas Kling  <akling@apple.com>
469
470         RetainPtr API test should use CFArray instead of CFString for testing.
471         <rdar://problem/16384899>
472
473         Unreviewed bot fix.
474
475         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
476         (TestWebKitAPI::TEST):
477         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
478         (TestWebKitAPI::TEST):
479
480 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
481
482         Move to using std::unique_ptr for EFL objects.
483         https://bugs.webkit.org/show_bug.cgi?id=129853
484
485         Reviewed by Gyuyoung Kim.
486
487         EflUniquePtr is a template alias of std::unique_ptr
488         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
489         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
490
491         * DumpRenderTree/efl/DumpRenderTree.cpp:
492         (main):
493         * ImageDiff/efl/ImageDiff.cpp:
494         (initEfl):
495         (main):
496
497 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
498
499         Unreviewed buildfix after r165983 for non Cocoa platforms
500
501         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
502
503         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
504         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
505         * WebKitTestRunner/TestController.cpp:
506
507 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
508
509         [GTK][CMake] Add support for building with Clang
510         https://bugs.webkit.org/show_bug.cgi?id=130260
511
512         Reviewed by Martin Robinson.
513
514         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
515         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
516         included GTest framework headers.
517         * gtk/generate-gtkdoc:
518         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
519         in case of using Clang since that is now set by the CMake rule.
520
521 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
522
523         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
524         https://bugs.webkit.org/show_bug.cgi?id=130476
525
526         Reviewed by Anders Carlsson.
527         
528         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
529
530         * MiniBrowser/mac/WK1BrowserWindowController.m:
531         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
532         Remove log.
533         * MiniBrowser/mac/WK2BrowserWindowController.m:
534         (-[WK2BrowserWindowController awakeFromNib]):
535         (-[WK2BrowserWindowController validateMenuItem:]):
536         (-[WK2BrowserWindowController reload:]):
537         Hook up reload.
538         (-[WK2BrowserWindowController toggleZoomMode:]):
539         (-[WK2BrowserWindowController resetZoom:]):
540         (-[WK2BrowserWindowController canResetZoom]):
541         (-[WK2BrowserWindowController currentZoomFactor]):
542         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
543         (-[WK2BrowserWindowController canZoomIn]):
544         (-[WK2BrowserWindowController canZoomOut]):
545
546 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
547
548         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
549         https://bugs.webkit.org/show_bug.cgi?id=130463
550
551         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
552
553 2014-03-18  Samuel White  <samuel_white@apple.com>
554
555         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
556         https://bugs.webkit.org/show_bug.cgi?id=130250
557
558         Reviewed by Chris Fleizach.
559
560         Added ability to toggle enhanced accessibility on and off to support tests that require it.
561
562         * DumpRenderTree/AccessibilityController.cpp:
563         (enableEnhancedAccessibilityCallback):
564         (getEnhancedAccessibilityEnabledCallback):
565         (AccessibilityController::getJSClass):
566         * DumpRenderTree/AccessibilityController.h:
567         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
568         (AccessibilityController::enableEnhancedAccessibility):
569         (AccessibilityController::enhancedAccessibilityEnabled):
570         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
571         (AccessibilityController::enableEnhancedAccessibility):
572         (AccessibilityController::enhancedAccessibilityEnabled):
573         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
574         (AccessibilityController::enableEnhancedAccessibility):
575         (AccessibilityController::enhancedAccessibilityEnabled):
576         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
577         (AccessibilityController::enableEnhancedAccessibility):
578         (AccessibilityController::enhancedAccessibilityEnabled):
579         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
580         (WTR::AccessibilityController::enableEnhancedAccessibility):
581         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
582         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
583         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
584
585 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
586
587         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
588         yet).
589
590         * Scripts/webkitpy/common/config/contributors.json:
591
592 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
593
594         Web Inspector: Remove stale ReportMemoryUsagePlugin
595         https://bugs.webkit.org/show_bug.cgi?id=130405
596
597         Reviewed by Andreas Kling.
598
599         This clang plugin looks like it was used for the old Inspector memory
600         instrumentation that was removed. So the tool can be removed.
601
602         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
603         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
604         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
605         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
606
607 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
608
609         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
610         https://bugs.webkit.org/show_bug.cgi?id=130220
611
612         Reviewed by Csaba Osztrogonác.
613
614         * Scripts/webkitpy/common/checkout/changelog.py:
615         (ChangeLog.set_reviewer):
616         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
617         (test_set_reviewer):
618
619 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
620
621         More FTL enabling.
622
623         Rubber stamped by Dan Bernstein.
624
625         * Tools/Scripts/build-webkit:
626
627 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
628
629         Renable pagination mode in WK2 MiniBrowser
630         https://bugs.webkit.org/show_bug.cgi?id=130374
631
632         Reviewed by Anders Carlsson.
633         
634         Put the implementation of togglePaginationMode: back, and correctly
635         enable the menu item.
636
637         * MiniBrowser/mac/WK2BrowserWindowController.m:
638         (-[WK2BrowserWindowController validateMenuItem:]):
639         (-[WK2BrowserWindowController isPaginated]):
640         (-[WK2BrowserWindowController togglePaginationMode:]):
641
642 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
643
644         Add --reset option to Tools/Scripts/set-webkit-configuration script
645         https://bugs.webkit.org/show_bug.cgi?id=130401
646
647         Reviewed by Csaba Osztrogonác.
648
649         * Scripts/set-webkit-configuration:
650
651 2014-03-18  Alberto Garcia  <berto@igalia.com>
652
653         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
654         https://bugs.webkit.org/show_bug.cgi?id=130388
655
656         Reviewed by Sergio Villar Senin.
657
658         * Scripts/webkitdirs.pm:
659         (shouldRemoveCMakeCache): make sure that the build directory
660         exists before attempting to create a file in it.
661
662 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
663
664         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
665         https://bugs.webkit.org/show_bug.cgi?id=130336
666
667         Reviewed by Gyuyoung Kim.
668
669         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
670         requires a space between literal and string macro [-Wliteral-suffix]'
671         warning treated as error.
672
673         This patch applies a solution from r162448 to the EFL port.
674
675         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
676         * efl/jhbuild.modules: Added appropriate patch section.
677
678 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
679
680         webkitpy test rebaseline.
681
682         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
683         (MainTest.test_default_args):
684
685 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
686
687         --profile should imply --test-runner-count=1 in run-perf-tests
688         https://bugs.webkit.org/show_bug.cgi?id=130375
689
690         Reviewed by Benjamin Poulain.
691
692         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
693
694         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
695         (PerfTestsRunner._parse_args): Use -1 as the default value.
696         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
697         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
698         should be 1.
699
700 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
701
702         Address some style nits.
703
704         * MiniBrowser/mac/WK2BrowserWindowController.m:
705
706 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
707
708         Add transparent window support back into MiniBrowser
709         https://bugs.webkit.org/show_bug.cgi?id=130363
710
711         Reviewed by Anders Carlsson.
712         
713         Re-enable transparent window support for WK2.
714
715         * MiniBrowser/mac/WK2BrowserWindowController.m:
716         (-[WK2BrowserWindowController validateMenuItem:]):
717         (-[WK2BrowserWindowController toggleTransparentWindow:]):
718
719 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
720
721         Fix the 32-bit build; make the open panel make a WK1 window.
722
723         * MiniBrowser/mac/AppDelegate.m:
724         (-[BrowserAppDelegate openDocument:]):
725
726 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
727
728         Convert MiniBrowser to use WKWebView API
729         https://bugs.webkit.org/show_bug.cgi?id=130061
730
731         Reviewed by Anders Carlsson.
732         
733         Convert the MiniBrowser WK2 window to use WebKit2 API as much
734         as possible.
735         
736         Some functionality was removed temporarily:
737             - text zoom, page zoom
738             - reload
739             - pagination mode
740             - transparent window
741             - dumping source
742             - window.open support
743             - beforeUnload panel
744             - find in page
745
746         * MiniBrowser/mac/AppDelegate.h:
747         * MiniBrowser/mac/AppDelegate.m:
748         (-[BrowserAppDelegate init]):
749         (-[BrowserAppDelegate newWindow:]):
750         (-[BrowserAppDelegate applicationWillTerminate:]):
751         (-[BrowserAppDelegate openDocument:]):
752         * MiniBrowser/mac/WK2BrowserWindowController.h:
753         * MiniBrowser/mac/WK2BrowserWindowController.m:
754         (-[WK2BrowserWindowController awakeFromNib]):
755         (-[WK2BrowserWindowController dealloc]):
756         (-[WK2BrowserWindowController fetch:]):
757         (-[WK2BrowserWindowController validateMenuItem:]):
758         (-[WK2BrowserWindowController reload:]):
759         (-[WK2BrowserWindowController goBack:]):
760         (-[WK2BrowserWindowController goForward:]):
761         (-[WK2BrowserWindowController toggleZoomMode:]):
762         (-[WK2BrowserWindowController resetZoom:]):
763         (-[WK2BrowserWindowController canResetZoom]):
764         (-[WK2BrowserWindowController dumpSourceToConsole:]):
765         (-[WK2BrowserWindowController togglePaginationMode:]):
766         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
767         (-[WK2BrowserWindowController windowShouldClose:]):
768         (-[WK2BrowserWindowController applicationTerminating]):
769         (-[WK2BrowserWindowController currentZoomFactor]):
770         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
771         (-[WK2BrowserWindowController toggleTransparentWindow:]):
772         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
773         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
774         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
775         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
776         (-[WK2BrowserWindowController find:]):
777         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
778         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
779         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
780         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
781         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
782         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
783         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
784         * WebKitTestRunner/PlatformWebView.h:
785         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
786         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
787
788 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
789
790         Use RunLoop objects through references instead of pointers
791         https://bugs.webkit.org/show_bug.cgi?id=130313
792
793         Reviewed by Andreas Kling.
794
795         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
796         return RunLoop reference instead of a pointer.
797
798         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
799         (loadedCallback):
800         (clickedCallback):
801
802 2014-03-17  Tim Horton  <timothy_horton@apple.com>
803
804         sort-export-file --help doesn't work (missing 'use')
805         https://bugs.webkit.org/show_bug.cgi?id=130338
806
807         Reviewed by Anders Carlsson.
808
809         * Scripts/sort-export-file:
810         Add a missing 'use', and fix a typo in an error message.
811
812 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
813
814         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
815         https://bugs.webkit.org/show_bug.cgi?id=130155
816
817         Reviewed by Philippe Normand.
818
819         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
820
821 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
822
823         [GTK] MiniBrowser fails to load injected bundle lib
824         https://bugs.webkit.org/show_bug.cgi?id=130332
825
826         Reviewed by Anders Carlsson.
827
828         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
829
830         * MiniBrowser/gtk/main.c:
831         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
832         process is spawn.
833
834 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
835
836         [EFL] Enable TOUCH_SLIDER macro
837         https://bugs.webkit.org/show_bug.cgi?id=130185
838
839         Reviewed by Gyuyoung Kim.
840
841         * Scripts/webkitperl/FeatureList.pm:
842
843 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
844
845         [GTK][CMake] Build with -fno-rtti
846         https://bugs.webkit.org/show_bug.cgi?id=130261
847
848         Reviewed by Martin Robinson.
849
850         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
851         defined to 0 to prevent typeid use in included GTest headers.
852
853 2014-03-16  Brian Burg  <bburg@apple.com>
854
855         Web Inspector: vended backend commands file should be generated as part of the build
856         https://bugs.webkit.org/show_bug.cgi?id=130110
857
858         Reviewed by Timothy Hatcher.
859
860         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
861
862 2014-03-16  Diego Pino García  <dpino@igalia.com>
863
864         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
865         https://bugs.webkit.org/show_bug.cgi?id=128999
866
867         Reviewed by Philippe Normand.
868
869         * MiniBrowser/gtk/BrowserWindow.c:
870         (reloadPage):
871         (reloadPageIgnoringCache):
872         (browser_window_init):
873
874 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
875
876         [GTK] Improve ninja detection in webkitdirs.pm
877         https://bugs.webkit.org/show_bug.cgi?id=129902
878
879         Reviewed by Daniel Bates.
880
881         * Scripts/webkitdirs.pm:
882         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
883         us to look for ninja-build as well.
884
885 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
886
887         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
888         https://bugs.webkit.org/show_bug.cgi?id=130276
889         <rdar://problem/16266927>
890         
891         Reviewed by Simon Fraser.
892
893         * BuildSlaveSupport/build-launcher-app:
894         * BuildSlaveSupport/build-launcher-dmg:
895         * DumpRenderTree/DumpRenderTree.h:
896         * DumpRenderTree/DumpRenderTreePrefix.h:
897         * DumpRenderTree/GCController.cpp:
898         * DumpRenderTree/GCController.h:
899         * DumpRenderTree/JavaScriptThreading.cpp:
900         * DumpRenderTree/JavaScriptThreading.h:
901         * DumpRenderTree/PixelDumpSupport.cpp:
902         * DumpRenderTree/PixelDumpSupport.h:
903         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
904         * DumpRenderTree/TestRunner.cpp:
905         * DumpRenderTree/TestRunner.h:
906         * DumpRenderTree/WorkQueue.cpp:
907         * DumpRenderTree/WorkQueue.h:
908         * DumpRenderTree/WorkQueueItem.h:
909         * DumpRenderTree/atk/AccessibilityCallbacks.h:
910         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
911         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
912         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
913         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
914         * DumpRenderTree/cg/PixelDumpSupportCG.h:
915         * DumpRenderTree/efl/EditingCallbacks.cpp:
916         * DumpRenderTree/efl/EditingCallbacks.h:
917         * DumpRenderTree/efl/EventSender.cpp:
918         * DumpRenderTree/efl/EventSender.h:
919         * DumpRenderTree/efl/GCControllerEfl.cpp:
920         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
921         * DumpRenderTree/efl/TestRunnerEfl.cpp:
922         * DumpRenderTree/gtk/DumpRenderTree.cpp:
923         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
924         * DumpRenderTree/gtk/EditingCallbacks.cpp:
925         * DumpRenderTree/gtk/EditingCallbacks.h:
926         * DumpRenderTree/gtk/EventSender.cpp:
927         * DumpRenderTree/gtk/EventSender.h:
928         * DumpRenderTree/gtk/GCControllerGtk.cpp:
929         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
930         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
931         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
932         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
933         * DumpRenderTree/gtk/TextInputController.cpp:
934         * DumpRenderTree/gtk/TextInputController.h:
935         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
936         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
937         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
938         * DumpRenderTree/mac/AppleScriptController.h:
939         * DumpRenderTree/mac/AppleScriptController.m:
940         * DumpRenderTree/mac/CheckedMalloc.cpp:
941         * DumpRenderTree/mac/CheckedMalloc.h:
942         * DumpRenderTree/mac/DumpRenderTree.mm:
943         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
944         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
945         * DumpRenderTree/mac/DumpRenderTreeMac.h:
946         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
947         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
948         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
949         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
950         * DumpRenderTree/mac/EditingDelegate.h:
951         * DumpRenderTree/mac/EditingDelegate.mm:
952         * DumpRenderTree/mac/EventSendingController.h:
953         * DumpRenderTree/mac/EventSendingController.mm:
954         * DumpRenderTree/mac/FrameLoadDelegate.h:
955         * DumpRenderTree/mac/FrameLoadDelegate.mm:
956         * DumpRenderTree/mac/GCControllerMac.mm:
957         * DumpRenderTree/mac/MockWebNotificationProvider.h:
958         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
959         * DumpRenderTree/mac/NavigationController.h:
960         * DumpRenderTree/mac/NavigationController.m:
961         * DumpRenderTree/mac/ObjCController.h:
962         * DumpRenderTree/mac/ObjCController.m:
963         * DumpRenderTree/mac/ObjCPlugin.h:
964         * DumpRenderTree/mac/ObjCPlugin.m:
965         * DumpRenderTree/mac/ObjCPluginFunction.h:
966         * DumpRenderTree/mac/ObjCPluginFunction.m:
967         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
968         * DumpRenderTree/mac/PolicyDelegate.h:
969         * DumpRenderTree/mac/PolicyDelegate.mm:
970         * DumpRenderTree/mac/ResourceLoadDelegate.h:
971         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
972         * DumpRenderTree/mac/TestRunnerMac.mm:
973         * DumpRenderTree/mac/TextInputController.h:
974         * DumpRenderTree/mac/TextInputController.m:
975         * DumpRenderTree/mac/UIDelegate.h:
976         * DumpRenderTree/mac/UIDelegate.mm:
977         * DumpRenderTree/mac/WorkQueueItemMac.mm:
978         * DumpRenderTree/win/DRTDataObject.cpp:
979         * DumpRenderTree/win/DRTDataObject.h:
980         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
981         * DumpRenderTree/win/DRTDropSource.cpp:
982         * DumpRenderTree/win/DRTDropSource.h:
983         * DumpRenderTree/win/DraggingInfo.h:
984         * DumpRenderTree/win/DumpRenderTree.cpp:
985         * DumpRenderTree/win/DumpRenderTreeWin.h:
986         * DumpRenderTree/win/EditingDelegate.cpp:
987         * DumpRenderTree/win/EditingDelegate.h:
988         * DumpRenderTree/win/EventSender.cpp:
989         * DumpRenderTree/win/EventSender.h:
990         * DumpRenderTree/win/FrameLoadDelegate.cpp:
991         * DumpRenderTree/win/FrameLoadDelegate.h:
992         * DumpRenderTree/win/GCControllerWin.cpp:
993         * DumpRenderTree/win/HistoryDelegate.cpp:
994         * DumpRenderTree/win/HistoryDelegate.h:
995         * DumpRenderTree/win/MD5.cpp:
996         * DumpRenderTree/win/MD5.h:
997         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
998         * DumpRenderTree/win/PolicyDelegate.cpp:
999         * DumpRenderTree/win/PolicyDelegate.h:
1000         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1001         * DumpRenderTree/win/ResourceLoadDelegate.h:
1002         * DumpRenderTree/win/TestRunnerWin.cpp:
1003         * DumpRenderTree/win/TextInputController.cpp:
1004         * DumpRenderTree/win/TextInputController.h:
1005         * DumpRenderTree/win/TextInputControllerWin.cpp:
1006         * DumpRenderTree/win/UIDelegate.cpp:
1007         * DumpRenderTree/win/UIDelegate.h:
1008         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1009         * EWebLauncher/main.c:
1010         * GtkLauncher/main.c:
1011         * ImageDiff/efl/ImageDiff.cpp:
1012         * ImageDiff/gtk/ImageDiff.cpp:
1013         * MiniBrowser/gtk/main.c:
1014         * Scripts/SpacingHeuristics.pm:
1015         * Scripts/VCSUtils.pm:
1016         * Scripts/bisect-builds:
1017         * Scripts/build-dumprendertree:
1018         * Scripts/build-jsc:
1019         * Scripts/build-webkit:
1020         * Scripts/check-dom-results:
1021         * Scripts/check-for-exit-time-destructors:
1022         * Scripts/check-for-global-initializers:
1023         * Scripts/commit-log-editor:
1024         * Scripts/compare-timing-files:
1025         * Scripts/debug-minibrowser:
1026         * Scripts/debug-safari:
1027         * Scripts/do-file-rename:
1028         * Scripts/find-extra-includes:
1029         * Scripts/generate-coverage-data:
1030         * Scripts/make-script-test-wrappers:
1031         * Scripts/malloc-tree:
1032         * Scripts/old-run-webkit-tests:
1033         * Scripts/parse-malloc-history:
1034         * Scripts/report-include-statistics:
1035         * Scripts/resolve-ChangeLogs:
1036         * Scripts/run-bindings-tests:
1037         * Scripts/run-iexploder-tests:
1038         * Scripts/run-javascriptcore-tests:
1039         * Scripts/run-jsc:
1040         * Scripts/run-launcher:
1041         * Scripts/run-leaks:
1042         * Scripts/run-mangleme-tests:
1043         * Scripts/run-minibrowser:
1044         * Scripts/run-pageloadtest:
1045         * Scripts/run-regexp-tests:
1046         * Scripts/run-safari:
1047         * Scripts/run-sunspider:
1048         * Scripts/run-webkit-app:
1049         * Scripts/sampstat:
1050         * Scripts/set-webkit-configuration:
1051         * Scripts/sort-Xcode-project-file:
1052         * Scripts/sort-export-file:
1053         * Scripts/split-file-by-class:
1054         * Scripts/sunspider-compare-results:
1055         * Scripts/svn-apply:
1056         * Scripts/svn-create-patch:
1057         * Scripts/svn-unapply:
1058         * Scripts/test-webkit-scripts:
1059         * Scripts/update-javascriptcore-test-results:
1060         * Scripts/update-webkit:
1061         * Scripts/update-webkit-auxiliary-libs:
1062         * Scripts/update-webkit-dependency:
1063         * Scripts/update-webkit-localizable-strings:
1064         * Scripts/update-webkit-support-libs:
1065         * Scripts/update-webkit-wincairo-libs:
1066         * Scripts/webkit-build-directory:
1067         * Scripts/webkitdirs.pm:
1068         (installedSafariPath):
1069         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1070         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1071         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1072         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1073         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1074         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1075         * Scripts/webkitperl/features.pm:
1076         * Scripts/webkitperl/httpd.pm:
1077         * Scripts/webkitpy/bindings/main.py:
1078         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1079         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1080         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1081         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1082         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1083         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1084         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1085         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1086         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1087         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
1088         * WebKitTestRunner/PixelDumpSupport.cpp:
1089         * WebKitTestRunner/PixelDumpSupport.h:
1090         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1091         * WinLauncher/WinLauncher.cpp:
1092         * WinLauncher/WinLauncher.h:
1093         * WinLauncher/stdafx.cpp:
1094         * WinLauncher/stdafx.h:
1095
1096 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
1097
1098         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
1099         https://bugs.webkit.org/show_bug.cgi?id=130265
1100
1101         Reviewed by Michael Saboff.
1102
1103         * Scripts/build-webkit:
1104         * Scripts/copy-webkitlibraries-to-product-directory:
1105
1106 2014-03-14  Landry Breuil  <landry@openbsd.org>
1107
1108         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
1109         Also allow to set MAKE in the environment.
1110         https://bugs.webkit.org/show_bug.cgi?id=129991
1111
1112         Reviewed by Andreas Kling.
1113
1114         * Scripts/webkitdirs.pm:
1115         (determineArchitecture):
1116         (determineNumberOfCPUs):
1117         (isBSD):
1118         (buildAutotoolsProject):
1119         * Scripts/webkitpy/common/system/platforminfo.py:
1120         (PlatformInfo.__init__):
1121         (PlatformInfo.is_openbsd):
1122         (PlatformInfo):
1123         (PlatformInfo.is_netbsd):
1124         (PlatformInfo._determine_os_name):
1125
1126 2014-03-14  Dean Jackson  <dino@apple.com>
1127
1128         Remove libWebKitSystemInterfaceLion.a
1129         https://bugs.webkit.org/show_bug.cgi?id=130254
1130
1131         Reviewed by Geoffrey Garen and Andreas Kling.
1132
1133         No need to copy the Lion libraries into the build.
1134
1135         * Scripts/copy-webkitlibraries-to-product-directory:
1136
1137 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
1138
1139         [EFL][MiniBrowser] Revise help messages of command line parameters
1140         https://bugs.webkit.org/show_bug.cgi?id=130222
1141
1142         Reviewed by Csaba Osztrogonác.
1143
1144         Correct the default value description and make help messages to be consistent.
1145
1146         * MiniBrowser/efl/main.c:
1147
1148 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
1149
1150         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
1151         https://bugs.webkit.org/show_bug.cgi?id=129612
1152
1153         Reviewed by Darin Adler.
1154
1155         For new code use static NeverDestroyed<T> instead.
1156
1157         * DumpRenderTree/JavaScriptThreading.cpp:
1158         (javaScriptThreadsMutex):
1159         (javaScriptThreads):
1160         * DumpRenderTree/efl/EventSender.cpp:
1161         (touchPointList):
1162         (delayedEventQueue):
1163         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1164         (delegatesWithDelayedWork):
1165         * Scripts/check-for-exit-time-destructors:
1166         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1167         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1168         (testsMap):
1169
1170 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
1171
1172         [EFL][WK2] Fix compilation warning in Minibrowser
1173         https://bugs.webkit.org/show_bug.cgi?id=130132
1174
1175         Reviewed by Csaba Osztrogonác.
1176
1177         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
1178
1179         * MiniBrowser/efl/main.c:
1180         (on_download_request):
1181
1182 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
1183
1184         FTL should support IsBlah
1185         https://bugs.webkit.org/show_bug.cgi?id=130202
1186
1187         Reviewed by Geoffrey Garen.
1188         
1189         Running existing JSRegress tests with noInline gives us coverage for these
1190         changes. Chances are, this will also give coverage for other interesting things
1191         as well.
1192
1193         * Scripts/run-jsc-stress-tests:
1194
1195 2014-03-12  Brian Burg  <bburg@apple.com>
1196
1197         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
1198         https://bugs.webkit.org/show_bug.cgi?id=129744
1199
1200         Reviewed by Timothy Hatcher.
1201
1202         * DumpRenderTree/TestRunner.cpp:
1203         (evaluateInWebInspectorCallback):
1204         * DumpRenderTree/TestRunner.h:
1205         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1206         (TestRunner::evaluateInWebInspector):
1207         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1208         (TestRunner::evaluateInWebInspector):
1209         * DumpRenderTree/mac/TestRunnerMac.mm:
1210         (TestRunner::evaluateInWebInspector):
1211         * DumpRenderTree/win/TestRunnerWin.cpp:
1212         (TestRunner::evaluateInWebInspector):
1213         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1214         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1215         (WTR::TestRunner::evaluateInWebInspector):
1216         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1217
1218 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1219
1220         [GTK] build-webkit shouldn't show error message when ninja isn't installed
1221         https://bugs.webkit.org/show_bug.cgi?id=130129
1222
1223         Reviewed by Csaba Osztrogonác.
1224
1225         * Scripts/webkitdirs.pm:
1226         (canUseNinja): Redirecting stderr to /dev/null
1227
1228 2014-03-13  Andres Gomez  <agomez@igalia.com>
1229
1230         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
1231         https://bugs.webkit.org/show_bug.cgi?id=130092
1232
1233         Reviewed by Csaba Osztrogonác.
1234
1235         Added "python-dev" as dependency for deb based distros. It is
1236         already present for rpm based distros. This dependency will allow
1237         libxml2 to generate its python bindings, needed by gtk-doc.
1238
1239         * gtk/install-dependencies:
1240
1241 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1242
1243         Unreviewed. Fix GTK+ cmake build after r165488.
1244
1245         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
1246
1247 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1248
1249         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
1250         https://bugs.webkit.org/show_bug.cgi?id=130014
1251
1252         Reviewed by Martin Robinson.
1253
1254         Include cmake or autotools config header.
1255
1256         * MiniBrowser/gtk/BrowserDownloadsBar.c:
1257         * MiniBrowser/gtk/BrowserSearchBar.c:
1258         * MiniBrowser/gtk/BrowserWindow.c:
1259         * MiniBrowser/gtk/main.c:
1260
1261 2014-03-12  Commit Queue  <commit-queue@webkit.org>
1262
1263         Unreviewed, rolling out r165471.
1264         https://bugs.webkit.org/show_bug.cgi?id=130139
1265
1266         Didn't really fix the issue and broke another bot (Requested
1267         by mrobinson on #webkit).
1268
1269         Reverted changeset:
1270
1271         "[CMake] Newer versions of CMake cannot find older versions of
1272         Freetype"
1273         https://bugs.webkit.org/show_bug.cgi?id=130107
1274         http://trac.webkit.org/changeset/165471
1275
1276 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
1277
1278         It should be possible to build WebKit with FTL on iOS
1279         https://bugs.webkit.org/show_bug.cgi?id=130116
1280
1281         Reviewed by Dan Bernstein.
1282
1283         * Scripts/build-webkit:
1284         * Scripts/copy-webkitlibraries-to-product-directory:
1285
1286 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
1287
1288         [Win] Remove use of QTSDK
1289         https://bugs.webkit.org/show_bug.cgi?id=130049
1290
1291         Reviewed by Darin Adler.
1292
1293         * DumpRenderTree/win/DumpRenderTree.cpp:
1294         (initialize): Remove QuickTime code.
1295         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
1296         building QTMovieWin.
1297
1298 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
1299
1300         [GTK][CMAKE] Too verbose build output
1301         https://bugs.webkit.org/show_bug.cgi?id=130076
1302
1303         Reviewed by Carlos Garcia Campos.
1304
1305         Instead of building with cmake --build which isn't smart about pretty printing and
1306         colors, we build with a script which calls the proper build command.
1307
1308         * Scripts/webkitdirs.pm:
1309         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
1310         the CMake configuration pass.
1311
1312 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1313
1314         [CMake] Newer versions of CMake cannot find older versions of Freetype
1315         https://bugs.webkit.org/show_bug.cgi?id=130107
1316
1317         Reviewed by Gustavo Noronha Silva.
1318
1319         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
1320         to CMake during jhbuild initialization.
1321
1322 2014-03-12  Zalan Bujtas  <zalan@apple.com>
1323
1324         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
1325         https://bugs.webkit.org/show_bug.cgi?id=129961
1326
1327         Reviewed by Simon Fraser.
1328
1329         Now scaled content can go through the window capturing mechanism too for compositing content.
1330         AppleMagnifiedMode is redundant.
1331
1332         * DumpRenderTree/mac/DumpRenderTree.mm:
1333         (setDefaultsToConsistentValuesForTesting):
1334         (runTest):
1335         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1336         (createBitmapContextFromWebView):
1337         * WebKitTestRunner/PlatformWebView.h:
1338         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1339         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1340         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1341         (WTR::PlatformWebView::didInitializeClients):
1342         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1343         (WTR::PlatformWebView::forceWindowFramesChanged):
1344         * WebKitTestRunner/mac/main.mm:
1345         (setDefaultsToConsistentValuesForTesting):
1346
1347 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
1348
1349         Unreviewed. Add myself as a committer.
1350
1351         * Scripts/webkitpy/common/config/contributors.json:
1352
1353 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
1354
1355         Unreviewed build fix on the EFL port when used lower version of ATK
1356
1357         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1358         (WTR::AccessibilityUIElement::y): Fixed typo.
1359
1360 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1361
1362         Some images are blank in the rebaseline server UI
1363         https://bugs.webkit.org/show_bug.cgi?id=130104
1364
1365         Reviewed by Tim Horton.
1366
1367         Let the server check for images in the 'retries' directory
1368         if it can't find an image otherwise.
1369
1370         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1371         (RebaselineHTTPRequestHandler.test_result):
1372
1373 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1374
1375         [GTK][CMake] --update-gtk has no effect
1376         https://bugs.webkit.org/show_bug.cgi?id=130088
1377
1378         Reviewed by Philippe Normand.
1379
1380         * Scripts/webkitdirs.pm:
1381         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
1382         as an argument.
1383
1384 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1385
1386         Add "System Font" to the list of whitelisted DRT fonts
1387         https://bugs.webkit.org/show_bug.cgi?id=130046
1388
1389         Reviewed by Darin Adler.
1390
1391         * DumpRenderTree/mac/DumpRenderTree.mm:
1392         (allowedFontFamilySet):
1393         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1394
1395 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1396
1397         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
1398         https://bugs.webkit.org/show_bug.cgi?id=130064
1399
1400         Reviewed by Philippe Normand.
1401
1402         * efl/jhbuildrc: Remove duplicated code.
1403         * gtk/jhbuildrc: Remove duplicated code.
1404         * jhbuild/jhbuildrc_common.py:
1405         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
1406         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
1407         and is apparently necessary for GTK+.
1408
1409 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1410
1411         check-webkit-style failed to complain about missing braces
1412         https://bugs.webkit.org/show_bug.cgi?id=34189
1413
1414         Reviewed by Ryosuke Niwa.
1415
1416         * Scripts/webkitpy/style/checkers/cpp.py:
1417         (check_braces):
1418         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1419         (WebKitStyleTest.test_braces):
1420
1421 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1422
1423         Remove Qt cruft from style checker.
1424         https://bugs.webkit.org/show_bug.cgi?id=130085
1425
1426         Reviewed by Csaba Osztrogonác.
1427
1428         There is no 'foreach' keyword in c++. That was a Qt feature
1429         added in: http://trac.webkit.org/changeset/46113
1430         Qt was removed from WebKit, so we should remove the checks
1431         of this keyword from check-webkit-style scripts.
1432
1433         * Scripts/webkitpy/style/checkers/cpp.py:
1434         (check_spacing_for_function_call):
1435         (check_spacing):
1436         (check_braces):
1437         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1438         (CppStyleTest.test_mismatching_spaces_in_parens):
1439         (CppStyleTest.test_spacing_for_fncall):
1440         (WebKitStyleTest.test_braces):
1441
1442 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
1443
1444         [GTK] update-webkitgtk-libs needs itstool
1445         https://bugs.webkit.org/show_bug.cgi?id=130082
1446
1447         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
1448         itstool is a dependency of building gtk-doc from version 1.19, so it should
1449         be added to Tools/gtk/install-dependencies script, too.
1450
1451         Reviewed by Philippe Normand.
1452
1453         * gtk/install-dependencies:
1454
1455 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1456
1457         webkitbot rollout ChangeLogs should be nicer
1458         https://bugs.webkit.org/show_bug.cgi?id=122654
1459
1460         Reviewed by Csaba Osztrogonác.
1461
1462         Added bug urls and descriptions of rolled out patches to the rollout changelog
1463         if they are present in the original changelog. Additionally removed the list of
1464         changed files and functions.
1465
1466         * Scripts/webkitpy/common/checkout/changelog.py:
1467         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
1468         * Scripts/webkitpy/common/checkout/checkout.py:
1469         (Checkout._changelog_data_for_revision): Store bug description.
1470         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1471         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1472         (CheckoutTest.test_commit_info_for_revision):
1473         * Scripts/webkitpy/common/checkout/commitinfo.py:
1474         (CommitInfo.bug_description): Added.
1475         (CommitInfo.to_json):
1476         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1477         (CommitInfoTest.test_commit_info_creation):
1478         * Scripts/webkitpy/tool/commands/download.py:
1479         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
1480         out patches for creating rollout changelog.
1481         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
1482         caused the regression is stored in state["bug_blocked"] now.
1483         * Scripts/webkitpy/tool/commands/download_unittest.py:
1484         (test_prepare_rollout):
1485         (test_create_rollout_multiple_revision):
1486         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1487         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
1488         rolled out patches to the changelog.
1489         (PrepareChangeLogForRevert.run):
1490         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1491         (UpdateChangeLogsForRevertTest):
1492         (test_message_for_revert):
1493         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1494         (ReopenBugAfterRollout.run):
1495
1496 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1497
1498         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
1499         https://bugs.webkit.org/show_bug.cgi?id=130021
1500
1501         Reviewed by Mario Sanchez Prada.
1502
1503         Replace deprecated functions to use new API from ATK 2.11.90.
1504
1505         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1506         (AccessibilityUIElement::x):
1507         (AccessibilityUIElement::y):
1508         (AccessibilityUIElement::width):
1509         (AccessibilityUIElement::height):
1510         (AccessibilityUIElement::clickPointX):
1511         (AccessibilityUIElement::clickPointY):
1512         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1513         (WTR::AccessibilityUIElement::x):
1514         (WTR::AccessibilityUIElement::y):
1515         (WTR::AccessibilityUIElement::width):
1516         (WTR::AccessibilityUIElement::height):
1517         (WTR::AccessibilityUIElement::clickPointX):
1518         (WTR::AccessibilityUIElement::clickPointY):
1519
1520 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1521
1522         [ATK] Expose aria-posinset and aria-setsize through object attributes
1523         https://bugs.webkit.org/show_bug.cgi?id=130011
1524
1525         Reviewed by Chris Fleizach.
1526
1527         Added missing implementation of numberAttributeValue both to WKTR and DRT.
1528
1529         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1530         (AccessibilityUIElement::numberAttributeValue):
1531         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1532         (WTR::AccessibilityUIElement::numberAttributeValue):
1533
1534 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1535
1536         [Win] Unreviewed build fix.
1537
1538         Some bad Windows code was committed at some point that prevents the Apple Windows port
1539         from finding its runtime dependencies reliably.
1540
1541         * win/DLLLauncher/DLLLauncherMain.cpp:
1542         (appleApplicationSupportDirectory): Restored this function.
1543         (modifyPath): Update to use appleApplicationSupportDirectory function.
1544
1545 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
1546
1547         Let the user define the full address of the performance-site-server for uploading results
1548         https://bugs.webkit.org/show_bug.cgi?id=129819
1549
1550         Reviewed by Ryosuke Niwa.
1551
1552         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
1553         can be confusing. It's more straightforward, if you need to define explicitly the server's full
1554         address along with the protocol, when you're using this parameter. I added HTTPS as the default
1555         protocol for now, in order to avoid breaking the perf bots.
1556
1557         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1558         (_upload_json):
1559         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1560         (MainTest.test_upload_json):
1561
1562 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1563
1564         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
1565         https://bugs.webkit.org/show_bug.cgi?id=130023
1566
1567         Reviewed by Dean Jackson.
1568
1569         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
1570         /SAFESEH flag to DLL launcher process.
1571
1572 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1573
1574         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
1575         https://bugs.webkit.org/show_bug.cgi?id=129980
1576
1577         Reviewed by Carlos Garcia Campos.
1578
1579         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
1580
1581 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1582
1583         [GTK] Remove the WebView source-mode WebKit1 test
1584         https://bugs.webkit.org/show_bug.cgi?id=129976
1585
1586         Reviewed by Carlos Garcia Campos.
1587
1588         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
1589
1590 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
1591
1592         Unreviewed build fix for GTKbuild after the switch to CMake
1593
1594         * gtk/common.py:
1595         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
1596         test-only bot doesn't have any build files.
1597
1598 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1599
1600         [GTK] built-product-archive does not handle GTK+ CMake build
1601         https://bugs.webkit.org/show_bug.cgi?id=129941
1602
1603         * BuildSlaveSupport/built-product-archive:
1604         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
1605         the CMake build.
1606
1607 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
1608
1609         [GTK] Include CMake into install-dependencies script
1610         https://bugs.webkit.org/show_bug.cgi?id=129909
1611
1612         Reviewed by Martin Robinson.
1613
1614         As since r165267 buid-webkit uses CMake by default, the dependency
1615         with 'cmake' package should be introduced.
1616
1617         * gtk/install-dependencies: Ditto.
1618
1619 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1620
1621         REGRESSION(165267): Broke a webkitpy unit tests
1622         https://bugs.webkit.org/show_bug.cgi?id=129904
1623
1624         Reviewed by Jon Honeycutt.
1625
1626         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
1627         (GtkPort._is_cmake_build):
1628
1629 2014-03-07  Andres Gomez  <agomez@igalia.com>
1630
1631         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
1632         https://bugs.webkit.org/show_bug.cgi?id=129893
1633
1634         Reviewed by Martin Robinson.
1635
1636         Added "git-svn" as dependency for deb based distros and,
1637         additionally, "subversion" for rpm based distros.
1638
1639         * gtk/install-dependencies:
1640
1641 2014-03-07  Roger Fong  <roger_fong@apple.com>
1642
1643         Remove dummy setSystemWebGLLoadPolicy client method.
1644         https://bugs.webkit.org/show_bug.cgi?id=129873.
1645
1646         Reviewed by Dean Jackson.
1647
1648         * WebKitTestRunner/TestController.cpp:
1649         (WTR::TestController::createWebViewWithOptions):
1650
1651 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1652
1653         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
1654         https://bugs.webkit.org/show_bug.cgi?id=129886
1655
1656         Reviewed by Mark Lam.
1657
1658         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
1659         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
1660         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
1661         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
1662         make it through when in non-verbose mode.
1663
1664 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1665
1666         [GTK] buid-webkit should use CMake by default
1667         https://bugs.webkit.org/show_bug.cgi?id=129855
1668
1669         Reviewed by Carlos Garcia Campos.
1670
1671         Make the CMake build the default GTK+ build when using build-webkit. This will
1672         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
1673         so that we have --gtk and --gtkautotools.
1674
1675         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
1676         * Scripts/webkitpy/port/gtk.py: Ditto.
1677
1678 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
1679
1680         [CMake] [GTK] Build with ninja when it is available
1681         https://bugs.webkit.org/show_bug.cgi?id=129805
1682
1683         Reviewed by Philippe Normand.
1684
1685         * Scripts/webkitdirs.pm:
1686         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
1687         if it's available on the system.
1688         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
1689         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
1690
1691 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
1692
1693         If the FTL is build-time enabled then it should be run-time enabled.
1694
1695         Rubber stamped by Geoffrey Garen.
1696
1697         * Scripts/run-jsc-stress-tests:
1698
1699 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
1700
1701         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
1702         https://bugs.webkit.org/show_bug.cgi?id=129837
1703
1704         Reviewed by Michael Saboff.
1705
1706         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
1707         The fix is to use find instead of ls like we do in shell-runner.sh.
1708
1709         * Scripts/run-jsc-stress-tests:
1710
1711 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1712
1713         filter-build-webkit should not strip .o
1714         https://bugs.webkit.org/show_bug.cgi?id=129614
1715
1716         Reviewed by Dean Jackson.
1717
1718         This makes it much easier to jump from the failing output at
1719         the end back up to the compile errors earlier in the output.
1720
1721         * Scripts/filter-build-webkit:
1722
1723 2014-03-06  Anders Carlsson  <andersca@apple.com>
1724
1725         Build WebKit2 before building WebKit
1726         https://bugs.webkit.org/show_bug.cgi?id=129831
1727         <rdar://problem/15920020>
1728
1729         Reviewed by Dan Bernstein.
1730
1731         * Scripts/build-webkit:
1732         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
1733
1734 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
1735
1736         make-3.82 fails to build on ARM/Linux
1737         https://bugs.webkit.org/show_bug.cgi?id=107926
1738
1739         Reviewed by Martin Robinson.
1740
1741         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
1742         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
1743         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
1744         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
1745
1746         * gtk/patches/make-3.82-arg-list-length.patch:
1747
1748 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1749
1750         [GTK] Close the page when the view is disposed instead of when finalized
1751         https://bugs.webkit.org/show_bug.cgi?id=129783
1752
1753         Reviewed by Sergio Villar Senin.
1754
1755         Add test case but disabled for now because it's affetected by bug #129684.
1756
1757         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1758         (testProcessPerWebView):
1759
1760 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1761
1762         [GTK] MiniBrowser crashes when opening several urls passed as command line options
1763         https://bugs.webkit.org/show_bug.cgi?id=129738
1764
1765         Reviewed by Sergio Villar Senin.
1766
1767         The problem is that we are calling g_object_unref() for the
1768         WebKitWebSettings everytime we set it to a WebKitWebView, but the
1769         view only increases the reference counter when the settings is not
1770         the same it currently has. We should release our reference once.
1771
1772         * MiniBrowser/gtk/main.c:
1773         (createBrowserWindow):
1774         (main):
1775
1776 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1777
1778         [GTK][CMake] Tarball is created with wrong tarball paths
1779         https://bugs.webkit.org/show_bug.cgi?id=129496
1780
1781         Reviewed by Daniel Bates.
1782
1783         * gtk/make-dist.py:
1784         (Manifest.__init__): I inadvertently inverted the logic of these checks when
1785         landing the original patch with some suggestions from the reviewer. With the
1786         checks corrected, the tarball path is constructed properly.
1787
1788 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
1789
1790         Unreviewed. Update my email in contributors.json
1791
1792         * Scripts/webkitpy/common/config/contributors.json:
1793
1794 2014-03-05  Dean Jackson  <dino@apple.com>
1795
1796         [WebGL] Use WKSI to see what the system policy for WebGL is
1797         https://bugs.webkit.org/show_bug.cgi?id=129722
1798         <rdar://problem/15790542>
1799
1800         Reviewed by Tim Horton.
1801
1802         Dummy entry for setSystemWebGLLoadPolicy.
1803
1804         * WebKitTestRunner/TestController.cpp:
1805         (WTR::TestController::createWebViewWithOptions):
1806
1807 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
1808
1809         [GTK][CMake] Generate documentation for the DOM bindings
1810         https://bugs.webkit.org/show_bug.cgi?id=126211
1811
1812         Reviewed by Carlos Garcia Campos.
1813
1814         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
1815         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
1816         * gtk/generate-webkitdom-doc-files: Removed.
1817         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
1818         that it can be called by generate-gtkdoc.
1819
1820 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1821
1822         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
1823         https://bugs.webkit.org/show_bug.cgi?id=129380
1824
1825         Reviewed by Philippe Normand.
1826
1827         * Scripts/webkitdirs.pm:
1828         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
1829         skipping CMake execution.
1830
1831 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1832
1833         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
1834         https://bugs.webkit.org/show_bug.cgi?id=129651
1835
1836         Reviewed by Philippe Normand.
1837
1838         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
1839
1840 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1841
1842         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
1843         https://bugs.webkit.org/show_bug.cgi?id=129637
1844
1845         Reviewed by Carlos Garcia Campos.
1846
1847         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1848         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
1849         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
1850         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
1851         New API typically just requires a rebaseline and isn't necessarily a faiulre.
1852         (TestFactory.__init__): Add the test for GTK+.
1853         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
1854
1855 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
1856
1857         [ATK] Expose missing functionalities of AtkTableCell to AT
1858         https://bugs.webkit.org/show_bug.cgi?id=129492
1859
1860         Reviewed by Mario Sanchez Prada.
1861
1862         Reducing some code by using new API of AtkTableCell.
1863
1864         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1865         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1866
1867 2014-03-04  Alex Christensen  <achristensen@webkit.org>
1868
1869         Preparing to run layout tests on Wincairo.
1870         https://bugs.webkit.org/show_bug.cgi?id=129709
1871
1872         Reviewed by Brent Fulgham.
1873
1874         * Scripts/webkitdirs.pm:
1875         (setPathForRunningWebKitApp):
1876         Add GStreamer directory for WinCairo running layout tests.
1877         * win/DLLLauncher/DLLLauncherMain.cpp:
1878         (modifyPath):
1879         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
1880
1881 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
1882
1883         [GTK] Simplify the GObject DOM bindings API break check into one step
1884         https://bugs.webkit.org/show_bug.cgi?id=129571
1885
1886         Reviewed by Carlos Garcia Campos.
1887
1888         * GNUmakefile.am: Add the API break check to 'make check.'
1889         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
1890         * gtk/check-gdom-symbols: Removed.
1891         * gtk/webkitdom.py: Added.
1892         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
1893         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
1894
1895 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
1896
1897         Add Jeremy Jones to the contributors list as a contributor.
1898
1899         * Scripts/webkitpy/common/config/contributors.json:
1900
1901 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1902
1903         Unreviewed. Update contact email.
1904         https://bugs.webkit.org/show_bug.cgi?id=129610
1905
1906         * Scripts/webkitpy/common/config/contributors.json:
1907
1908 2014-03-02  Brian Burg  <bburg@apple.com>
1909
1910         Web Inspector model tests load wrong inspector page under WebKitTestRunner
1911         https://bugs.webkit.org/show_bug.cgi?id=129460
1912
1913         Reviewed by Dan Bernstein.
1914
1915         Don't unconditionally open the inspector before running an inspector test.
1916         Instead, the test should request that the inspector open when it's ready.
1917
1918         This change was lost during a rebase, but is the same change made to
1919         DumpRenderTree.
1920
1921         * WebKitTestRunner/TestInvocation.cpp:
1922         (WTR::TestInvocation::invoke): 
1923
1924 2014-03-02  Darin Adler  <darin@apple.com>
1925
1926         Split TextIteratorBehavior into a separate header
1927         https://bugs.webkit.org/show_bug.cgi?id=129578
1928
1929         Reviewed by Sam Weinig.
1930
1931         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
1932         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
1933         task easy, but the remove is still a bit of a pain.
1934
1935 2014-03-02  Darin Adler  <darin@apple.com>
1936
1937         Sort Mac platform export files so they merge better
1938         https://bugs.webkit.org/show_bug.cgi?id=129581
1939
1940         Reviewed by Sam Weinig.
1941
1942         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
1943         Mac export files in a "canonical" order for this project.
1944
1945 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1946
1947         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1948         https://bugs.webkit.org/show_bug.cgi?id=129438
1949
1950         Reviewed by Simon Fraser.
1951
1952         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1953         offscreen window. It makes testing subpixel rendering and positioning possible.
1954
1955         Both the offscreen window's and WebKit's scaling are set accordingly.
1956
1957         * DumpRenderTree/mac/DumpRenderTree.mm:
1958         (createWebViewAndOffscreenWindow): cleanup
1959         (destroyWebViewAndOffscreenWindow): cleanup
1960         (dumpRenderTree):
1961         (changeWindowScaleIfNeeded):
1962         (runTest):
1963         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1964         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1965         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
1966         * WebKitTestRunner/PlatformWebView.h:
1967         * WebKitTestRunner/TestInvocation.cpp:
1968         (WTR::changeWindowScaleIfNeeded):
1969         (WTR::TestInvocation::invoke):
1970         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1971         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1972         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1973         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1974         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1975         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1976         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1977         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1978
1979 2014-02-28  Anders Carlsson  <andersca@apple.com>
1980
1981         Remove logging.
1982
1983         Reviewed by Dan Bernstein.
1984
1985         * MiniBrowser/mac/WK2BrowserWindowController.m:
1986         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1987
1988 2014-02-28  Daniel Bates  <dabates@apple.com>
1989
1990         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
1991         https://bugs.webkit.org/show_bug.cgi?id=129163
1992
1993         Reviewed by David Kilzer.
1994
1995         Fixes an issue where DumpRenderTree Perl Support may build with the specified
1996         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
1997         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
1998         bundle.
1999
2000         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
2001         which is specified either explicitly when building with MAKE(1) or implicitly by
2002         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
2003         the OS X SDK and toolchain since the built products are only applicable to OS X.
2004
2005         * DumpRenderTree/ios/PerlSupport/Makefile:
2006
2007 2014-02-28  Commit Queue  <commit-queue@webkit.org>
2008
2009         Unreviewed, rolling out r164859.
2010         http://trac.webkit.org/changeset/164859
2011         https://bugs.webkit.org/show_bug.cgi?id=129483
2012
2013         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
2014         #webkit).
2015
2016         * DumpRenderTree/mac/DumpRenderTree.mm:
2017         (createWebViewAndOffscreenWindow):
2018         (dumpRenderTree):
2019         (runTest):
2020         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2021         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2022         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2023         * WebKitTestRunner/PlatformWebView.h:
2024         * WebKitTestRunner/TestInvocation.cpp:
2025         (WTR::TestInvocation::invoke):
2026         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2027         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2028         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2029         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2030         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
2031
2032 2014-02-28  Zalan Bujtas  <zalan@apple.com>
2033
2034         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
2035         https://bugs.webkit.org/show_bug.cgi?id=129438
2036
2037         Reviewed by Simon Fraser.
2038
2039         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
2040         offscreen window. It makes testing subpixel rendering and positioning possible.
2041
2042         Both the offscreen window's and WebKit's scaling are set accordingly.
2043
2044         * DumpRenderTree/mac/DumpRenderTree.mm:
2045         (createWebViewAndOffscreenWindow): unrelated cleanup.
2046         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
2047         (dumpRenderTree):
2048         (changeOffscreenWindowScaleIfNeeded):
2049         (runTest):
2050         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2051         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2052         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
2053         * WebKitTestRunner/PlatformWebView.h:
2054         * WebKitTestRunner/TestInvocation.cpp:
2055         (WTR::changeOffscreenWindowScaleIfNeeded):
2056         (WTR::TestInvocation::invoke):
2057         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2058         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
2059
2060 2014-02-27  Brian Burg  <bburg@apple.com>
2061
2062         Web Inspector: model tests should use a special Test.html inspector page
2063         https://bugs.webkit.org/show_bug.cgi?id=129190
2064
2065         Reviewed by Timothy Hatcher.
2066
2067         Remove code that immediately opens the Web Inspector based on the file path of the test.
2068         Instead, the test page should request that the inspector open inside its `test()` method.
2069
2070         This change is necessary because otherwise, the inspector would be opened too early for
2071         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
2072         will get loaded instead of the minimal test page.
2073
2074         * DumpRenderTree/efl/DumpRenderTree.cpp:
2075         (createTestRunner):
2076         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2077         (runTest):
2078         * DumpRenderTree/mac/DumpRenderTree.mm:
2079         (runTest):
2080         * DumpRenderTree/win/DumpRenderTree.cpp:
2081         (runTest):
2082
2083 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2084
2085         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
2086         https://bugs.webkit.org/show_bug.cgi?id=127076
2087
2088         Reviewed by Anders Carlsson.
2089
2090         Avoid match for :: as start of a member initialization list. Modify expression to match
2091         after a colon either non-colon character or end of line.
2092
2093         * Scripts/webkitpy/style/checkers/cpp.py:
2094         (check_member_initialization_list):
2095         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2096         (WebKitStyleTest.test_member_initialization_list):
2097
2098 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
2099
2100         Unreviewed. Update my email addresses in contributors.json.
2101
2102         * Scripts/webkitpy/common/config/contributors.json:
2103
2104 2014-02-27  Alberto Garcia  <berto@igalia.com>
2105
2106         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
2107         https://bugs.webkit.org/show_bug.cgi?id=128927
2108
2109         Reviewed by Philippe Normand.
2110
2111         Encode manually the data for sys.{stdout,stderr}.write.
2112
2113         * gtk/gtkdoc.py:
2114         (GTKDoc._run_command):
2115
2116 2014-02-27  Andres Gomez  <agomez@igalia.com>
2117
2118         Unreviewed. Add myself to watchlists
2119
2120         * Scripts/webkitpy/common/config/watchlist: Add myself to
2121         watchlists.
2122
2123 2014-02-27  Andres Gomez  <agomez@igalia.com>
2124
2125         Unreviewed, rolling out r164790.
2126         http://trac.webkit.org/changeset/164790
2127
2128         Revert r164790 because of erroneous commit log
2129
2130         * Scripts/webkitpy/common/config/watchlist:
2131
2132 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
2133
2134         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
2135         https://bugs.webkit.org/show_bug.cgi?id=129250
2136
2137         Reviewed by Mario Sanchez Prada.
2138
2139         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
2140         Implementing methods so that we could test column/row headers represented as an array of cells.
2141
2142         * DumpRenderTree/AccessibilityUIElement.cpp:
2143         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2144         (AccessibilityUIElement::columnHeaders):
2145         (AccessibilityUIElement::rowHeaders):
2146         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
2147         (AccessibilityUIElement::columnHeaders):
2148         (AccessibilityUIElement::rowHeaders):
2149         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2150         (WTR::AccessibilityUIElement::rowHeaders):
2151         (WTR::AccessibilityUIElement::columnHeaders):
2152         * efl/jhbuild.modules:
2153         * gtk/jhbuild.modules:
2154
2155 2014-02-27  Andres Gomez  <agomez@igalia.com>
2156
2157         Unreviewed. Add myself to watchlists
2158
2159         * Scripts/webkitpy/common/config/watchlist: Add myself to
2160         watchlists.
2161
2162 2014-02-27  Andres Gomez  <agomez@igalia.com>
2163
2164         Unreviewed. Add myself as a committer.
2165
2166         * Scripts/webkitpy/common/config/contributors.json:
2167
2168 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2169
2170         Unreviewed. Add Víctor Jáquez and myself to watchlists
2171
2172         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
2173         myself to watchlists.
2174
2175 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
2176
2177         Unreviewed. Add myself as a committer.
2178
2179         * Scripts/webkitpy/common/config/contributors.json:
2180
2181 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2182
2183         Unreviewed. Moved myself to the list of committers.
2184
2185         * Scripts/webkitpy/common/config/contributors.json:
2186
2187 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2188
2189         [GTK] Reduplicate common.top_level_path in scripts
2190         https://bugs.webkit.org/show_bug.cgi?id=129291
2191
2192         Reviewed by Philippe Normand.
2193
2194         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
2195         path manipulation and weird dependencies on the jhbuild infrastructure.
2196
2197         * Scripts/run-gtk-tests: Use common again.
2198         (TestRunner._setup_testing_environment): Ditto.
2199         * gtk/check-gdom-symbols: Ditto.
2200         * gtk/common.py:
2201         (top_level_path): Re-add top_level_path..
2202         (get_build_path): Use the builtin top_level_path again.
2203         * gtk/find-make-dist-errors: Use common again.
2204         (get_missing_headers): Ditto.
2205         * gtk/generate-inspector-gresource-manifest.py: Ditto.
2206
2207 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
2208
2209         runscript: line 42: /bin/ls: Argument list too long
2210         https://bugs.webkit.org/show_bug.cgi?id=129376
2211
2212         Reviewed by Michael Saboff.
2213
2214         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
2215         We should use find instead, which generates the list of files rather than expanding them all on 
2216         the command line and spitting them back out.
2217
2218         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
2219
2220 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2221
2222         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
2223         https://bugs.webkit.org/show_bug.cgi?id=129377
2224
2225         Reviewed by Csaba Osztrogonác.
2226
2227         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
2228
2229 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
2230
2231         [GTK] Re-enable gtk-doc in EWS
2232         https://bugs.webkit.org/show_bug.cgi?id=128369
2233
2234         Reviewed by Carlos Garcia Campos.
2235
2236         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2237
2238         * Scripts/webkitpy/common/config/ports.py:
2239         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2240         (GtkWK2Port.build_webkit_command): Ditto.
2241         * Scripts/webkitpy/common/config/ports_unittest.py:
2242         (DeprecatedPortTest.test_gtk_port): Ditto.
2243         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2244
2245 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2246
2247         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
2248         https://bugs.webkit.org/show_bug.cgi?id=129319
2249
2250         Reviewed by Carlos Garcia Campos.
2251
2252         * gtk/generate-gtkdoc:
2253         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
2254
2255 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
2256
2257         Unreviewed. Add myself as a committer.
2258
2259         * Scripts/webkitpy/common/config/contributors.json:
2260
2261 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
2262
2263         [CSS Grid Layout] Add ENABLE flag
2264         https://bugs.webkit.org/show_bug.cgi?id=129153
2265
2266         Reviewed by Simon Fraser.
2267
2268         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
2269         all ports for developer builds.
2270
2271         * Scripts/webkitperl/FeatureList.pm:
2272
2273 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2274
2275         Added myself as a committer.
2276
2277         Unreviewed.
2278
2279         * Scripts/webkitpy/common/config/contributors.json:
2280
2281 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2282
2283         Unreviewed. Moved myself to the list of committers.
2284
2285         * Scripts/webkitpy/common/config/contributors.json:
2286
2287 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2288
2289         Move myself to the committers list.
2290
2291         Unreviewed.
2292
2293         * Scripts/webkitpy/common/config/contributors.json:
2294
2295 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
2296
2297         Unreviewed. Add myself as a committer.
2298
2299         * Scripts/webkitpy/common/config/contributors.json:
2300
2301 2014-02-25  Commit Queue  <commit-queue@webkit.org>
2302
2303         Unreviewed, rolling out r164639.
2304         http://trac.webkit.org/changeset/164639
2305         https://bugs.webkit.org/show_bug.cgi?id=129302
2306
2307         gtk-doc still have problems in EWS (Requested by rego on
2308         #webkit).
2309
2310         * Scripts/webkitpy/common/config/ports.py:
2311         (GtkPort.build_webkit_command):
2312         (GtkWK2Port.build_webkit_command):
2313         * Scripts/webkitpy/common/config/ports_unittest.py:
2314         (DeprecatedPortTest.test_gtk_port):
2315         (DeprecatedPortTest.test_gtk_wk2_port):
2316
2317 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
2318
2319         [GTK] Re-enable gtk-doc in EWS
2320         https://bugs.webkit.org/show_bug.cgi?id=128369
2321
2322         Reviewed by Carlos Garcia Campos.
2323
2324         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2325
2326         * Scripts/webkitpy/common/config/ports.py:
2327         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2328         (GtkWK2Port.build_webkit_command): Ditto.
2329         * Scripts/webkitpy/common/config/ports_unittest.py:
2330         (DeprecatedPortTest.test_gtk_port): Ditto.
2331         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2332
2333 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2334
2335         [GTK] Mark view source mode methods as deprecated
2336         https://bugs.webkit.org/show_bug.cgi?id=128920
2337
2338         Reviewed by Martin Robinson.
2339
2340         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2341         (beforeAll): Remove view mode test.
2342
2343 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2344
2345         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
2346         https://bugs.webkit.org/show_bug.cgi?id=128417
2347
2348         Reviewed by Carlos Garcia Campos.
2349
2350         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
2351         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
2352         a makefile. This allows accepting a header list from the build system, which can be used
2353         to dynamically build a list of ignored files. We can ignore any source file that doesn't
2354         have a corresponding header file on the header list. 
2355         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
2356         source directories to gtkdoc-scan.
2357
2358 2014-02-24  Anders Carlsson  <andersca@apple.com>
2359
2360         Add a DefaultVisitedLinkProvider and route visited link actions through it
2361         https://bugs.webkit.org/show_bug.cgi?id=129285
2362
2363         Reviewed by Dan Bernstein.
2364
2365         * MiniBrowser/mac/AppDelegate.m:
2366         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2367         Set a shared history so we'll get visited link tracking.
2368
2369         * MiniBrowser/mac/WK1BrowserWindowController.m:
2370         (-[WK1BrowserWindowController awakeFromNib]):
2371         Set a group name.
2372
2373 2014-02-24  Dan Bernstein  <mitz@apple.com>
2374
2375         iOS build fix after r164577.
2376
2377         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2378         (AccessibilityUIElement::selectedChildrenCount):
2379         (AccessibilityUIElement::selectedChildAtIndex):
2380
2381 2014-02-24  David Kilzer  <ddkilzer@apple.com>
2382
2383         [ASan] Remove methods from ignore list that no longer cause crashes
2384         <http://webkit.org/b/129257>
2385
2386         Reviewed by Anders Carlsson.
2387
2388         * asan/webkit-asan-ignore.txt: Remove old methods.
2389
2390 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2391
2392         Extract common parts from jhbuildrc files.
2393         https://bugs.webkit.org/show_bug.cgi?id=125986
2394
2395         Reviewed by Csaba Osztrogonác.
2396
2397         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
2398
2399         * Scripts/run-gtk-tests:
2400         (TestRunner._setup_testing_environment):
2401         * efl/common.py: Removed.
2402         * efl/jhbuildrc:
2403         * gtk/check-gdom-symbols:
2404         * gtk/common.py:
2405         (binary_build_path):
2406         (get_build_path):
2407         * gtk/find-make-dist-errors:
2408         (get_missing_headers):
2409         * gtk/generate-gtkdoc:
2410         (get_webkit2_options):
2411         (get_webkit1_options.src_path):
2412         (get_webkit1_options):
2413         (get_webkitdom_options.src_path):
2414         (get_webkitdom_options):
2415         * gtk/generate-inspector-gresource-manifest.py:
2416         * gtk/jhbuildrc:
2417         * jhbuild/jhbuildrc_common.py: Added.
2418         (script_path):
2419         (top_level_path):
2420         (init):
2421
2422 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
2423
2424         Unreviewed. Fix code indentation and spacing.
2425
2426         * Scripts/webkitpy/style/checkers/js.py:
2427         (SingleQuoteChecker.check):
2428
2429 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
2430
2431         [ATK] Wrong selected element at a given index in a list box.
2432         https://bugs.webkit.org/show_bug.cgi?id=129039
2433
2434         Reviewed by Chris Fleizach.
2435
2436         Added missing implementation and proposed some new function for testing selection
2437         in a list boxes.
2438
2439         * DumpRenderTree/AccessibilityUIElement.cpp:
2440         (setSelectedChildAtIndexCallback):
2441         (removeSelectionAtIndexCallback):
2442         (AccessibilityUIElement::getJSClass):
2443         * DumpRenderTree/AccessibilityUIElement.h:
2444         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2445         (AccessibilityUIElement::selectedChildrenCount):
2446         (AccessibilityUIElement::selectedChildAtIndex):
2447         (AccessibilityUIElement::setSelectedChildAtIndex):
2448         (AccessibilityUIElement::removeSelectionAtIndex):
2449         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2450         (AccessibilityUIElement::selectedChildrenCount):
2451         (AccessibilityUIElement::selectedChildAtIndex):
2452         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2453         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2454         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2455         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2456         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2457         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2458         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2459         (WTR::AccessibilityUIElement::selectedChildrenCount):
2460         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2461         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2462
2463 2014-02-23  Diego Pino García  <dpino@igalia.com>
2464
2465         [GTK] Fix build after Web Inspector code reorganization (r164543)
2466         https://bugs.webkit.org/show_bug.cgi?id=129231
2467
2468         Reviewed by Dean Jackson.
2469
2470         * gtk/generate-inspector-gresource-manifest.py:
2471         Modify paths to Web Inspector code.
2472
2473 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2474
2475         [GTK] generate-gtkdoc should use argparse
2476         https://bugs.webkit.org/show_bug.cgi?id=128418
2477
2478         Reviewed by Carlos Garcia Campos.
2479
2480         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
2481         to all functions, and guard the main routine with a __name__ == __main__ check.
2482
2483 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2484
2485         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
2486         https://bugs.webkit.org/show_bug.cgi?id=129191
2487
2488         Reviewed by Anders Carlsson.
2489
2490         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
2491         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
2492         name of the directory is "lib" and not "libs". Instead we should use the CMake
2493         variable specifically assigned to this task.
2494
2495 2014-02-23  David Kilzer  <ddkilzer@apple.com>
2496
2497         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
2498         <http://webkit.org/b/129209>
2499
2500         Reviewed by Geoffrey Garen.
2501
2502         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
2503         ignore list to make ASan builds usable again.  Follow-up
2504         investigation is tracked by <rdar://problem/16055903>.
2505
2506 2014-02-20  David Farler  <dfarler@apple.com>
2507
2508         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
2509         https://bugs.webkit.org/show_bug.cgi?id=128622
2510
2511         Reviewed by Simon Fraser.
2512
2513         With this change, we now have layout tests running in both DumpRenderTree
2514         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
2515         simulator.
2516
2517         * Scripts/old-run-webkit-tests:
2518         In general, make any specific reference to DumpRenderTree
2519         able to refer to WebKitTestRunner wherever possible:
2520         - Rename functions to remove DRT-specific naming.
2521         - Name FIFOs after the tool that is being used.
2522         -- Clean up FIFO creation code
2523         Other necessary changes:
2524         - Allow use of an ios-sim-wk2 platform.
2525         - Clean up platform hierarchy creation where the simulator platform behavior differed.
2526         * WebKitTestRunner/TestController.cpp:
2527         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
2528         (WTR::TestController::TestController):
2529         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2530         Copy the injected bundle into the app bundle.
2531
2532 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
2533
2534         run-webkit-httpd fails to find httpd configuation file.
2535
2536         Reviewed by Ryosuke Niwa.
2537
2538         * Scripts/webkitperl/httpd.pm:
2539         (getHTTPDConfigPathForTestDirectory):
2540
2541 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
2542
2543         Fix TimeRanges layering violations
2544         https://bugs.webkit.org/show_bug.cgi?id=128717
2545
2546         Reviewed by Jer Noble.
2547
2548         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
2549         (TestWebKitAPI::TEST):
2550
2551 2014-02-21  Diego Pino García  <dpino@igalia.com>
2552
2553         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
2554         https://bugs.webkit.org/show_bug.cgi?id=128422
2555
2556         Reviewed by Joseph Pecoraro.
2557
2558         * Scripts/webkitpy/style/checkers/js.py:
2559         (JSChecker.__init__):
2560         (JSChecker.check):
2561         (SingleQuoteChecker):
2562         (SingleQuoteChecker.__init__):
2563         (SingleQuoteChecker.check):
2564         * Scripts/webkitpy/style/checkers/js_unittest.py:
2565         (JSTestCase.assertError.error_for_test):
2566         (JSTestCase.assertError):
2567         (JSTestCase.test_no_error):
2568         (JSTestCase.test_error):
2569
2570 == Rolled over to ChangeLog-2014-02-20 ==